on develop help sign in
Ensure addSelectedAttr is used only for option elements.
commit4bf4ee83cb92d7ee6beaa888ef1b6fcfea45c3d4 authorLuigy Leon <luigy@outlook.com> dateTue 17 Jan 2017, 23:38 (10 years ago) parentd85b300
1 file changed+3−3
src/Reflex/Dom/Builder/Static.hs+3−3
src/Reflex/Dom/Builder/Static.hs+3−3
@@ -191,9 +191,9 @@ instance SupportsStaticDomBuilder t m => DomBuilder t (StaticDomBuilderT t m) wh
191191 let addSelectedAttr attrs sel = case Map.lookup "value" attrs of
192192 Just v | v == sel -> attrs <> Map.singleton "selected" ""
193193 _ -> Map.delete "selected" attrs
194− let attrs1 = case selectValue of
195− Nothing -> current attrs0
196− Just sv -> pull $ addSelectedAttr <$> sample (current attrs0) <*> sample sv
194+ let attrs1 = case (elementTag, selectValue) of
195+ ("option", Just sv) -> pull $ addSelectedAttr <$> sample (current attrs0) <*> sample sv
196+ _ -> current attrs0
197197 let attrs2 = ffor attrs1 $ mconcat . fmap (\(k, v) -> " " <> toAttr k v) . Map.toList
198198 let tagBS = encodeUtf8 elementTag
199199 if Set.member elementTag voidElements