on develop help sign in
A bit more linting
80904baRyan Trinkle
src/Reflex/Dom/Builder/Static.hs+1−1
@@ -124,7 +124,7 @@ instance SupportsStaticDomBuilder t m => DomBuilder t (StaticDomBuilderT t m) wh
124 let tagBS = encodeUtf8 elementTag
124 let tagBS = encodeUtf8 elementTag
125 let open = mconcat [constant ("<" <> tagBS <> " "), attrs1, constant ">"]
125 let open = mconcat [constant ("<" <> tagBS <> " "), attrs1, constant ">"]
126 let close = constant $ "</" <> tagBS <> ">" -- TODO handle elements without closing tags
126 let close = constant $ "</" <> tagBS <> ">" -- TODO handle elements without closing tags
127− modify $ (:) $ mconcat $ [open, innerHtml, close]
127+ modify $ (:) $ mconcat [open, innerHtml, close]
128 return (Element es (error "Static.element RawElement was used"), result)
128 return (Element es (error "Static.element RawElement was used"), result)
129
129
130 {-# INLINABLE placeholder #-}
130 {-# INLINABLE placeholder #-}
src/Reflex/Dom/Time.hs+1−1
@@ -158,7 +158,7 @@ inhomogeneousPoissonFrom rnd rate maxRate t0 e = do
158 tTarget = addUTCTime dt tTargetLast
158 tTarget = addUTCTime dt tTargetLast
159 thisDelay = realToFrac $ diffUTCTime tTarget t :: Double
159 thisDelay = realToFrac $ diffUTCTime tTarget t :: Double
160 threadDelay $ ceiling $ thisDelay * 1000000
160 threadDelay $ ceiling $ thisDelay * 1000000
161− void $ cb $ (TickInfo t nEvents alreadyElapsed, p)
161+ _ <- cb (TickInfo t nEvents alreadyElapsed, p)
162 go tTarget nextGen' cb nEvents
162 go tTarget nextGen' cb nEvents
163
163
164-- | Send events with inhomogeneous Poisson timing with the given basis
164-- | Send events with inhomogeneous Poisson timing with the given basis
src/Reflex/Dom/Widget/Basic.hs+1−1
@@ -354,7 +354,7 @@ divClass = elClass "div"
354dtdd :: forall t m a. DomBuilder t m => Text -> m a -> m a
354dtdd :: forall t m a. DomBuilder t m => Text -> m a -> m a
355dtdd h w = do
355dtdd h w = do
356 el "dt" $ text h
356 el "dt" $ text h
357− el "dd" $ w
357+ el "dd" w
358
358
359blank :: forall m. Monad m => m ()
359blank :: forall m. Monad m => m ()
360blank = return ()
360blank = return ()
src/Reflex/Dom/Widget/Input.hs+1−1
@@ -293,7 +293,7 @@ fileInput config = do
293 eChange <- wrapDomEvent e (`on` Element.change) $ do
293 eChange <- wrapDomEvent e (`on` Element.change) $ do
294 Just files <- Input.getFiles e
294 Just files <- Input.getFiles e
295 len <- FileList.getLength files
295 len <- FileList.getLength files
296− mapM (fmap (fromMaybe (error "fileInput: fileList.item returned null")) . FileList.item files) $ [0 .. len-1]
296+ mapM (fmap (fromMaybe (error "fileInput: fileList.item returned null")) . FileList.item files) [0 .. len-1]
297 dValue <- holdDyn [] eChange
297 dValue <- holdDyn [] eChange
298 return $ FileInput
298 return $ FileInput
299 { _fileInput_value = dValue
299 { _fileInput_value = dValue
test/BrokenHaltSpec.hs+3−4
@@ -34,7 +34,6 @@ getFirstEventAndHalt action = do
34 return ()
34 return ()
35
35
36haltGui :: WebView -> IO ()
36haltGui :: WebView -> IO ()
37−haltGui wv = do
38− Gtk.postGUIAsync $ do
37+haltGui wv = Gtk.postGUIAsync $ do
39− w <- Gtk.widgetGetToplevel wv
38+ w <- Gtk.widgetGetToplevel wv
40− Gtk.widgetDestroy w
39+ Gtk.widgetDestroy w
test/HaltSpec.hs+8−10
@@ -7,23 +7,21 @@ import qualified Graphics.UI.Gtk as Gtk
7import Reflex.Dom
7import Reflex.Dom
8import Reflex.Spider.Internal (SpiderHostFrame)
8import Reflex.Spider.Internal (SpiderHostFrame)
9
9
10+main :: IO ()
10main = do
11main = do
11 getFirstEventAndHalt return
12 getFirstEventAndHalt return
12 putStrLn "stopped once"
13 putStrLn "stopped once"
13
14
14− forM_ [1 .. 1000] $ \ i -> do
15− getFirstEventAndHalt return
15+ forM_ [1 .. 1000] $ \i -> getFirstEventAndHalt return
16 putStrLn "stopped many times"
16 putStrLn "stopped many times"
17
17
18type SpiderM = Widget Spider (Gui Spider (WithWebView SpiderHost) SpiderHostFrame)
18type SpiderM = Widget Spider (Gui Spider (WithWebView SpiderHost) SpiderHostFrame)
19
19
20getFirstEventAndHalt :: (Event Spider () -> SpiderM (Event Spider ())) -> IO ()
20getFirstEventAndHalt :: (Event Spider () -> SpiderM (Event Spider ())) -> IO ()
21−getFirstEventAndHalt action = do
21+getFirstEventAndHalt action = mainWidget $ do
22− _ <- mainWidget $ do
23− tick <- getPostBuild
22+ tick <- getPostBuild
24− event <- action tick
23+ event <- action tick
25− webView <- askWebView
24+ webView <- askWebView
26− quit <- getQuitWidget
25+ quit <- getQuitWidget
27− performEvent_ (quit <$ event)
26+ performEvent_ (quit <$ event)
28− return ()
29 return ()
27 return ()