on develop help sign in
Merge pull request #323 from reflex-frp/cg-fix-requestert-prerender

Fix prerender for RequesterT so that it doesn't accidentally discard …

commitc89302c26aac5cacb8db8a00bb47ec4434779a26 authorAli Abrar <aliabrar@gmail.com> dateThu 14 Nov 2019, 15:14 (7 years ago) parent8b0dfd5ed2b2e9
2 files changed+3−2
reflex-dom-core/ChangeLog.md+1 reflex-dom-core/src/Reflex/Dom/Prerender.hs+2−2
reflex-dom-core/ChangeLog.md+1
@@ -11,6 +11,7 @@
1111 hydration.
1212* Fix an issue in the hydration tests that prevented the test from finding the chromium executable
1313* Relax constraints on `dyn` and `widgetHold` to match the ones in `networkView` and `networkHold` respectively
14+* Fix prerender for RequesterT so that it doesn't accidentally discard a request that is made at the same moment as getPostBuild's Event fires
1415
1516## 0.5.1
1617
reflex-dom-core/src/Reflex/Dom/Prerender.hs+2−2
@@ -271,8 +271,8 @@ instance (Prerender js t m, MonadFix m, Reflex t) => Prerender js t (RequesterT
271271 (x, e) <- runRequesterT w (selectInt fannedResponses selector)
272272 pure (x, fmapCheap (IntMap.singleton selector) e)
273273 (result, requestsDyn) <- fmap splitDynPure $ lift $ prerender (withFannedResponses server 0) (withFannedResponses client 1)
274− responses <- fmap (fmapCheap unMultiEntry) $ requesting' $ fmapCheap multiEntry $ switch $ current requestsDyn
275− pure result
274+ responses <- fmap (fmapCheap unMultiEntry) $ requesting' $ fmapCheap multiEntry $ switchPromptlyDyn requestsDyn
275+ return result
276276
277277instance (Prerender js t m, Monad m, Reflex t, MonadFix m, Group q, Additive q, Query q, Eq q) => Prerender js t (QueryT t q m) where
278278 type Client (QueryT t q m) = QueryT t q (Client m)