on develop help sign in
Remove unused Placeholder code
commitd18565b524a23a76a81bffc3006a89f07f7feff8 authorDaniel Haraj <dan@obsidian.systems> dateSat 28 Jan 2017, 20:14 (10 years ago) parent7ca4e27
2 files changed+1−59
src/Reflex/Dom/Builder/Class.hs+1−48 src/Reflex/Dom/Builder/Immediate.hs−11
src/Reflex/Dom/Builder/Class.hs+1−48
@@ -84,11 +84,6 @@ class (Monad m, Reflex t, DomSpace (DomBuilderSpace m), MonadAdjust t m) => DomB
8484 => Text -> ElementConfig er t m -> m a -> m (Element er (DomBuilderSpace m) t, a)
8585 element t cfg child = liftWith $ \run -> element t (liftElementConfig cfg) $ run child
8686 {-# INLINABLE element #-}
87− {-
88− -- | Create a placeholder in the DOM, with the ability to insert new DOM before it
89− -- The provided DOM will be executed after the current frame, so it will not be affected by any occurrences that are concurrent with the occurrence that created it
90− placeholder :: PlaceholderConfig above t m -> m (Placeholder above t)
91−-}
9287 inputElement :: InputElementConfig er t m -> m (InputElement er (DomBuilderSpace m) t)
9388 default inputElement :: ( MonadTransControl f
9489 , m ~ f m'
@@ -222,23 +217,6 @@ data Element er d t
222217 , _element_raw :: RawElement d
223218 }
224219
225−data PlaceholderConfig above t m
226− = PlaceholderConfig { _placeholderConfig_insertAbove :: Event t (m above)
227− , _placeholderConfig_deleteSelf :: Event t ()
228− }
229−
230−instance Reflex t => Default (PlaceholderConfig above t m) where
231− {-# INLINABLE def #-}
232− def = PlaceholderConfig
233− { _placeholderConfig_insertAbove = never
234− , _placeholderConfig_deleteSelf = never
235− }
236−
237−data Placeholder above t
238− = Placeholder { _placeholder_insertedAbove :: Event t above
239− , _placeholder_deletedSelf :: Event t ()
240− }
241−
242220data InputElementConfig er t m
243221 = InputElementConfig { _inputElementConfig_initialValue :: Text
244222 , _inputElementConfig_setValue :: Maybe (Event t Text)
@@ -372,24 +350,10 @@ elementConfig_modifyAttributes =
372350 in lens getter setter
373351
374352concat <$> mapM makeLenses
375− [ ''PlaceholderConfig
376− , ''TextAreaElementConfig
353+ [ ''TextAreaElementConfig
377354 , ''SelectElementConfig
378355 ]
379356
380−class CanDeleteSelf t a | a -> t where
381− deleteSelf :: Lens' a (Event t ())
382−
383−instance CanDeleteSelf t (PlaceholderConfig above t m) where
384− {-# INLINABLE deleteSelf #-}
385− deleteSelf = placeholderConfig_deleteSelf
386−
387−class InsertAbove t m above above' a a' | a -> t m above, a' -> t m above', a above' -> a', a' above -> a where
388− insertAbove :: Lens a a' (Event t (m above)) (Event t (m above'))
389−
390−instance InsertAbove t m above above' (PlaceholderConfig above t m) (PlaceholderConfig above' t m) where
391− insertAbove = placeholderConfig_insertAbove
392−
393357class InitialAttributes a where
394358 initialAttributes :: Lens' a (Map AttributeName Text)
395359
@@ -531,12 +495,6 @@ instance Functor1 (ElementConfig er t) where
531495 { _elementConfig_eventSpec = _elementConfig_eventSpec cfg
532496 }
533497
534−instance Reflex t => Functor1 (PlaceholderConfig above t) where
535− {-# INLINABLE fmap1 #-}
536− fmap1 f cfg = cfg
537− { _placeholderConfig_insertAbove = f <$> _placeholderConfig_insertAbove cfg
538− }
539−
540498instance Functor1 (InputElementConfig er t) where
541499 type Functor1Constraint (InputElementConfig er t) a b = Functor1Constraint (ElementConfig er t) a b
542500 fmap1 f cfg = cfg & inputElementConfig_elementConfig %~ fmap1 f
@@ -610,11 +568,6 @@ liftTextNode = lift . textNode
610568liftElement :: LiftDomBuilder t f m => Text -> ElementConfig er t (f m) -> f m a -> f m (Element er (DomBuilderSpace m) t, a)
611569liftElement elementTag cfg child = liftWithStateless $ \run -> element elementTag (fmap1 run cfg) $ run child
612570
613−{-
614−liftPlaceholder :: LiftDomBuilder t f m => PlaceholderConfig above t (f m) -> f m (Placeholder above t)
615−liftPlaceholder cfg = liftWithStateless $ \run -> placeholder $ fmap1 run cfg
616−-}
617−
618571liftInputElement :: LiftDomBuilder t f m => InputElementConfig er t (f m) -> f m (InputElement er (DomBuilderSpace m) t)
619572liftInputElement cfg = liftWithStateless $ \run -> inputElement $ fmap1 run cfg
620573
src/Reflex/Dom/Builder/Immediate.hs−11
@@ -292,17 +292,6 @@ instance SupportsImmediateDomBuilder t m => DomBuilder t (ImmediateDomBuilderT t
292292 return $ TextNode n
293293 {-# INLINABLE element #-}
294294 element elementTag cfg child = fst <$> makeElement elementTag cfg child
295− {-
296− {-# INLINABLE placeholder #-}
297− placeholder (PlaceholderConfig toInsertAbove delete) = liftThrough (deletable delete) $ do
298− n <- textNodeInternal ("" :: Text)
299− insertedAbove <- insertImmediateAbove n toInsertAbove
300− --Note: "deleteSelf" must come after "insertAbove", because we need to be able to insert above in the same frame that we delete
301− deleted <- lift $ performEvent $ ffor delete $ \_ -> do
302− mp <- getParentNode n
303− forM_ mp $ \p -> removeChild p $ Just n
304− return $ Placeholder insertedAbove deleted
305−-}
306295 {-# INLINABLE inputElement #-}
307296 inputElement cfg = do
308297 ((e, _), domElement) <- makeElement "input" (cfg ^. inputElementConfig_elementConfig) $ return ()