@@ -20,14 +20,6 @@
2020
2121{-# OPTIONS_GHC -fno-warn-orphans #-}
2222
23−-- Notice to those working on this test suite:
24−-- It doesn't appear to be possible to use --match to run a particular test, in
25−-- this situation the test may hang before reaching our code. This seems to
26−-- happen when the test is not the first test in the block. As a workaround, you
27−-- can just comment out the other tests. Also, using `xit` will cause the same
28−-- issue. `xit` tests must be the last tests in the session, or the session will
29−-- hang in the following test.
30−
3123import Prelude hiding (fail)
3224import Control.Concurrent
3325import qualified Control.Concurrent.Async as Async
@@ -47,7 +39,6 @@ import Data.Functor.Misc
4739import Data.GADT.Compare.TH
4840import Data.GADT.Show.TH
4941import Data.IORef (IORef)
50−import Data.List (sort)
5142import Data.Maybe
5243import Data.Proxy
5344import Data.Text (Text)
@@ -58,7 +49,6 @@ import Network.Socket
5849import Network.Wai
5950import Network.WebSockets
6051import Reflex.Dom.Core
61−import Reflex.Dom.Widget.Input (dropdown)
6252import Reflex.Patch.DMapWithMove
6353import System.Directory
6454import System.Environment
@@ -67,7 +57,7 @@ import System.IO.Silently
6757import System.IO.Temp
6858import System.Process
6959import System.Which (staticWhich)
70−import qualified Test.HUnit as HUnit
60+import qualified Test.HUnit as HUnit (assertEqual, assertFailure)
7161import qualified Test.Hspec as H
7262import qualified Test.Hspec.Core.Spec as H
7363import Test.Hspec (xit)
@@ -107,14 +97,11 @@ instance MonadRef WD where
10797 writeRef r = WD . writeRef r
10898
10999assertEqual :: (MonadIO m, Eq a, Show a) => String -> a -> a -> m ()
110−assertEqual msg a b = liftIO $ HUnit.assertEqual msg a b
100+assertEqual a b = liftIO . HUnit.assertEqual a b
111101
112102assertFailure :: MonadIO m => String -> m ()
113103assertFailure = liftIO . HUnit.assertFailure
114104
115−assertBool :: (MonadIO m) => String -> Bool -> m ()
116−assertBool msg bool = liftIO $ HUnit.assertBool msg bool
117−
118105chromeConfig :: Text -> [Text] -> WD.WDConfig
119106chromeConfig fp flags = WD.useBrowser (WD.chrome { WD.chromeBinary = Just $ T.unpack fp, WD.chromeOptions = T.unpack <$> flags }) WD.defaultConfig
120107
@@ -145,7 +132,7 @@ deriving instance MonadFail WD
145132
146133main :: IO ()
147134main = do
148− unshareNetwork
135+ unshareNetork
149136 isHeadless <- (== Nothing) <$> lookupEnv "NO_HEADLESS"
150137 withSandboxedChromeFlags isHeadless $ \chromeFlags -> do
151138 withSeleniumServer $ \selenium -> do
@@ -154,13 +141,13 @@ main = do
154141 withDebugging <- isNothing <$> lookupEnv "NO_DEBUG"
155142 let wdConfig = WD.defaultConfig { WD.wdPort = fromIntegral $ _selenium_portNumber selenium }
156143 chromeCaps' = WD.getCaps $ chromeConfig browserPath chromeFlags
157− hspec (tests withDebugging wdConfig [(chromeCaps', "chrome")] selenium) `finally` _selenium_stopServer selenium
144+ hspec (tests withDebugging wdConfig [chromeCaps'] selenium) `finally` _selenium_stopServer selenium
158145
159−tests :: Bool -> WD.WDConfig -> [(Capabilities, String)] -> Selenium -> Spec
146+tests :: Bool -> WD.WDConfig -> [Capabilities] -> Selenium -> Spec
160147tests withDebugging wdConfig caps _selenium = do
161148 let putStrLnDebug :: MonadIO m => Text -> m ()
162149 putStrLnDebug m = when withDebugging $ liftIO $ putStrLn $ T.unpack m
163− session' t = sessionWith wdConfig t . using caps
150+ session' = sessionWith wdConfig "" . using (map (,"") caps)
164151 runWD m = runWDOptions (WdOptions False) $ do
165152 putStrLnDebug "before"
166153 r <- m
@@ -169,10 +156,10 @@ tests withDebugging wdConfig caps _selenium = do
169156 testWidgetStatic :: WD b -> (forall m js. TestWidget js (SpiderTimeline Global) m => m ()) -> WD b
170157 testWidgetStatic = testWidgetStaticDebug withDebugging
171158 testWidget :: WD () -> WD b -> (forall m js. TestWidget js (SpiderTimeline Global) m => m ()) -> WD b
172− testWidget = testWidgetDebug True withDebugging
159+ testWidget = testWidgetDebug withDebugging
173160 testWidget' :: WD a -> (a -> WD b) -> (forall m js. TestWidget js (SpiderTimeline Global) m => m ()) -> WD b
174− testWidget' = testWidgetDebug' True withDebugging
175− session' "text" $ do
161+ testWidget' = testWidgetDebug' withDebugging
162+ describe "text" $ session' $ do
176163 it "works" $ runWD $ do
177164 testWidgetStatic (checkBodyText "hello world") $ do
178165 text "hello world"
@@ -233,7 +220,7 @@ tests withDebugging wdConfig caps _selenium = do
233220 click <- button ""
234221 void $ textNode $ TextNodeConfig "initial" $ Just $ "after" <$ click
235222
236− session' "element" $ do
223+ describe "element" $ session' $ do
237224 it "works with domEvent Click" $ runWD $ do
238225 clickedRef <- liftIO $ newRef False
239226 testWidget' (findElemWithRetry $ WD.ByTag "div") WD.click $ do
@@ -297,78 +284,21 @@ tests withDebugging wdConfig caps _selenium = do
297284 let click = domEvent Click e
298285 return ()
299286
300− session' "inputElement" $ do
301− describe "static renderer" $ do
302− it "sets value attribute" $ runWD $ do
303− let checkStatic = do
304− e <- findElemWithRetry $ WD.ByTag "input"
305− WD.attr e "value" `shouldBeWithRetryM` Just "test"
306− pure e
307− checkHydrated e = do
308− WD.attr e "value" `shouldBeWithRetryM` Just "test"
309− testWidget' checkStatic checkHydrated $ void $ inputElement $ def
310− & inputElementConfig_initialValue .~ "test"
311− it "updates value attribute at postBuild" $ runWD $ do
312− let checkStatic = do
313− e <- findElemWithRetry $ WD.ByTag "input"
314− WD.attr e "value" `shouldBeWithRetryM` Just "test-updated"
315− pure e
316− checkHydrated e = do
317− WD.attr e "value" `shouldBeWithRetryM` Just "test-updated"
318− testWidget' checkStatic checkHydrated $ do
319− pb <- getPostBuild
320− _ <- inputElement $ def
321− & inputElementConfig_initialValue .~ "test"
322− & inputElementConfig_setValue .~ ("test-updated" <$ pb)
323− pure ()
324− it "sets checked attr appropriately" $ runWD $ do
325− setCheckedChan <- liftIO newChan
326− let checkStatic = do
327− e <- findElemWithRetry $ WD.ByTag "input"
328− WD.attr e "checked" `shouldBeWithRetryM` Just "true"
329− pure e
330− checkValue e = do
331− WD.attr e "checked" `shouldBeWithRetryM` Just "true"
332− WD.moveToCenter e
333− WD.click e -- Click to uncheck
334− WD.attr e "checked" `shouldBeWithRetryM` Nothing
335− liftIO $ writeChan setCheckedChan True -- Programatically check the checkbox
336− WD.attr e "checked" `shouldBeWithRetryM` Just "true"
337− testWidget' checkStatic checkValue $ do
338− setChecked <- triggerEventWithChan setCheckedChan
339− _ <- inputElement $ def
340− & initialAttributes .~ "type" =: "checkbox"
341− & inputElementConfig_initialChecked .~ True
342− & inputElementConfig_setChecked .~ setChecked
343− pure ()
344− it "sets checked attr appropriately at postbuild" $ runWD $ do
345− let checkStatic = do
346− e <- findElemWithRetry $ WD.ByTag "input"
347− WD.attr e "checked" `shouldBeWithRetryM` Just "true"
348− pure e
349− checkValue e = do
350− WD.attr e "checked" `shouldBeWithRetryM` Just "true"
351− testWidget' checkStatic checkValue $ do
352− pb <- getPostBuild
353− _ <- inputElement $ def
354− & initialAttributes .~ "type" =: "checkbox"
355− & inputElementConfig_initialChecked .~ False
356− & inputElementConfig_setChecked .~ (True <$ pb)
357− pure ()
358− describe "hydration" $ do
287+ describe "inputElement" $ do
288+ describe "hydration" $ session' $ do
359289 it "doesn't wipe user input when switching over" $ runWD $ do
360− inputRef <- newRef ("hello " :: Text)
290+ inputRef <- newRef ("" :: Text)
361291 testWidget'
362292 (do
363293 e <- findElemWithRetry $ WD.ByTag "input"
364− WD.sendKeys "world" e
294+ WD.sendKeys "hello world" e
365295 pure e)
366296 (\e -> do
367297 WD.attr e "value" `shouldBeWithRetryM` Just "hello world"
368298 WD.click =<< findElemWithRetry (WD.ByTag "button")
369299 readRef inputRef `shouldBeWithRetryM` "hello world"
370300 ) $ do
371− e <- inputElement $ def & inputElementConfig_initialValue .~ "hello "
301+ e <- inputElement def
372302 click <- button "save"
373303 performEvent_ $ liftIO . writeRef inputRef <$> tag (current (value e)) click
374304 it "captures user input after switchover" $ runWD $ do
@@ -425,49 +355,24 @@ tests withDebugging wdConfig caps _selenium = do
425355 checkedByUIRef <- newRef False
426356 checkedRef <- newRef False
427357 setCheckedChan <- liftIO newChan
428− let checkStatic = do
429− e <- findElemWithRetry $ WD.ByTag "input"
430− WD.attr e "checked" `shouldBeWithRetryM` Nothing
431− pure e
432− checkValue e = do
358+ let checkValue = do
433359 readRef checkedByUIRef `shouldBeWithRetryM` False
434360 readRef checkedRef `shouldBeWithRetryM` False
435− WD.attr e "checked" `shouldBeWithRetryM` Nothing
361+ e <- findElemWithRetry $ WD.ByTag "input"
436362 WD.moveToCenter e
437363 WD.click e
438364 readRef checkedByUIRef `shouldBeWithRetryM` True
439365 readRef checkedRef `shouldBeWithRetryM` True
440− WD.attr e "checked" `shouldBeWithRetryM` Just "true"
441366 liftIO $ writeChan setCheckedChan False
442367 readRef checkedByUIRef `shouldBeWithRetryM` True
443368 readRef checkedRef `shouldBeWithRetryM` False
444− WD.attr e "checked" `shouldBeWithRetryM` Nothing
445− testWidget' checkStatic checkValue $ do
369+ testWidget (pure ()) checkValue $ do
446370 setChecked <- triggerEventWithChan setCheckedChan
447371 e <- inputElement $ def
448372 & initialAttributes .~ "type" =: "checkbox"
449373 & inputElementConfig_setChecked .~ setChecked
450374 performEvent_ $ liftIO . writeRef checkedByUIRef <$> _inputElement_checkedChange e
451375 performEvent_ $ liftIO . writeRef checkedRef <$> updated (_inputElement_checked e)
452− it "respects user updates to checked which happen before hydration" $ runWD $ do
453− checkedByUIRef <- newRef False
454− checkedRef <- newRef False
455− let checkStatic = do
456− e <- findElemWithRetry $ WD.ByTag "input"
457− WD.attr e "checked" `shouldBeWithRetryM` Nothing
458− WD.moveToCenter e
459− WD.click e
460− WD.attr e "checked" `shouldBeWithRetryM` Just "true"
461− pure e
462− checkValue e = do
463− WD.attr e "checked" `shouldBeWithRetryM` Just "true"
464− readRef checkedByUIRef `shouldBeWithRetryM` True
465− readRef checkedRef `shouldBeWithRetryM` True
466− testWidget' checkStatic checkValue $ do
467− e <- inputElement $ def
468− & initialAttributes .~ "type" =: "checkbox"
469− performEvent_ $ liftIO . writeRef checkedByUIRef <$> _inputElement_checkedChange e
470− performEvent_ $ liftIO . writeRef checkedRef <$> updated (_inputElement_checked e)
471376 it "captures file uploads" $ runWD $ do
472377 filesRef :: IORef [Text] <- newRef []
473378 let uploadFile = do
@@ -483,117 +388,8 @@ tests withDebugging wdConfig caps _selenium = do
483388 prerender_ (pure ()) $ performEvent_ $ ffor (tag (current (_inputElement_files e)) click) $ \fs -> do
484389 names <- liftJSM $ traverse File.getName fs
485390 liftIO $ writeRef filesRef names
486− it "fires _input event if the user altered the value before hydration" $ runWD $ do
487− input <- newRef ("" :: Text)
488− update <- newRef ("" :: Text)
489− let checkStatic = do
490− e <- findElemWithRetry $ WD.ByTag "input"
491− WD.attr e "value" `shouldBeWithRetryM` Just ""
492− WD.sendKeys "test" e
493− WD.attr e "value" `shouldBeWithRetryM` Just "test"
494− pure e
495− checkHydrated e = do
496− WD.attr e "value" `shouldBeWithRetryM` Just "test"
497− readRef input `shouldBeWithRetryM` "test"
498− readRef update `shouldBeWithRetryM` "test"
499− testWidget' checkStatic checkHydrated $ do
500− e <- inputElement def
501− performEvent_ $ liftIO . writeRef input <$> _inputElement_input e
502− performEvent_ $ liftIO . writeRef update <$> updated (_inputElement_value e)
503− it "does not fire _input event when the value is updated at postBuild" $ runWD $ do
504− input <- newRef (Nothing :: Maybe Text)
505− let checkStatic = do
506− e <- findElemWithRetry $ WD.ByTag "input"
507− WD.attr e "value" `shouldBeWithRetryM` Just "pb"
508− pure e
509− checkHydrated e = do
510− WD.attr e "value" `shouldBeWithRetryM` Just "pb"
511− readRef input `shouldBeWithRetryM` Nothing
512− testWidget' checkStatic checkHydrated $ do
513− pb <- getPostBuild
514− e <- inputElement $ def & inputElementConfig_setValue .~ ("pb" <$ pb)
515− performEvent_ $ liftIO . writeRef input . Just <$> _inputElement_input e
516− it "SSR produces correct DOM based on inputElement values when setValue happens at postBuild" $ runWD $ do
517− let checkBoth = do
518− input <- findElemWithRetry $ WD.ByTag "input"
519− WD.attr input "value" `shouldBeWithRetryM` Just "pb"
520− p <- findElemWithRetry (WD.ByTag "p")
521− shouldContainText "pb" p
522− testWidget checkBoth checkBoth $ do
523− pb <- getPostBuild
524− e <- inputElement $ def & inputElementConfig_setValue .~ ("pb" <$ pb)
525− el "p" $ dynText $ _inputElement_value e
526− it "does not fail when both setValue AND user updated value happen before switchover" $ runWD $ do
527− let checkStatic = do
528− input <- findElemWithRetry $ WD.ByTag "input"
529− h2_value <- findElemWithRetry (WD.ByTag "h2")
530− h3_input <- findElemWithRetry (WD.ByTag "h3")
531− WD.attr input "value" `shouldBeWithRetryM` Just "pb"
532− shouldContainText "pb" h2_value
533− shouldContainText "" h3_input
534− WD.sendKeys "abc" input
535− WD.attr input "value" `shouldBeWithRetryM` Just "pbabc"
536− shouldContainText "pb" h2_value
537− shouldContainText "" h3_input
538− pure (input, h2_value, h3_input)
539− checkHydrated (input, h2_value, h3_input) = do
540− WD.attr input "value" `shouldBeWithRetryM` Just "pbabc"
541− shouldContainText "pbabc" h3_input
542− shouldContainText "pbabc pb" h2_value
543− pure ()
544− testWidget' checkStatic checkHydrated $ do
545− pb <- getPostBuild
546− e <- inputElement $ def & inputElementConfig_setValue .~ ("pb" <$ pb)
547− el "h1" $ dynText $ _inputElement_value e
548− el "h2" $ dynText . fmap T.unwords <=< foldDyn (:) [] $ updated $ _inputElement_value e
549− el "h3" $ dynText . fmap T.unwords <=< foldDyn (:) [] $ _inputElement_input e
550− it "value is correct when both setValue AND user updated value happen before switchover" $ runWD $ do
551− let checkStatic = do
552− input <- findElemWithRetry $ WD.ByTag "input"
553− p <- findElemWithRetry (WD.ByTag "p")
554− WD.attr input "value" `shouldBeWithRetryM` Just "pb"
555− shouldContainText "pb" p
556− WD.sendKeys "abc" input
557− WD.attr input "value" `shouldBeWithRetryM` Just "pbabc"
558− shouldContainText "pb" p -- It won't be updated yet
559− pure (input, p)
560− checkHydrated (input, p) = do
561− WD.attr input "value" `shouldBeWithRetryM` Just "pbabc"
562− shouldContainText "pbabc" p
563− pure ()
564− testWidget' checkStatic checkHydrated $ do
565− pb <- getPostBuild
566− e <- inputElement $ def & inputElementConfig_setValue .~ ("pb" <$ pb)
567− el "p" $ dynText $ _inputElement_value e
568− it "input event and (updated value) fire correctly when both setValue AND user updated value happen before switchover" $ runWD $ do
569− valRef <- newRef ([] :: [Text])
570− inputRef <- newRef ([] :: [Text])
571− let consRef ref a = liftIO $ atomicModifyRef ref $ \as -> (a:as, ())
572− checkStatic = do
573− input <- findElemWithRetry $ WD.ByTag "input"
574− p <- findElemWithRetry (WD.ByTag "p")
575− WD.attr input "value" `shouldBeWithRetryM` Just "pb"
576− shouldContainText "pb" p
577− WD.sendKeys "abc" input
578− WD.attr input "value" `shouldBeWithRetryM` Just "pbabc"
579− shouldContainText "pb" p -- It won't be updated yet
580− readRef inputRef `shouldBeWithRetryM` [] -- Should never fire input ref during SSR
581− readRef valRef `shouldBeWithRetryM` ["pb"]
582− pure (input, p)
583− checkHydrated (input, p) = do
584− readRef inputRef `shouldBeWithRetryM` ["pbabc"]
585− readRef valRef `shouldBeWithRetryM` ["pbabc", "pb"]
586− WD.attr input "value" `shouldBeWithRetryM` Just "pbabc"
587− shouldContainText "pbabc" p
588− pure ()
589− testWidget' checkStatic checkHydrated $ do
590− liftIO $ writeRef valRef []
591− pb <- getPostBuild
592− e <- inputElement $ def & inputElementConfig_setValue .~ ("pb" <$ pb)
593− el "p" $ dynText $ _inputElement_value e
594− performEvent_ $ consRef valRef <$> updated (_inputElement_value e)
595− performEvent_ $ consRef inputRef <$> _inputElement_input e
596− describe "hydration/immediate" $ do
391+
392+ describe "hydration/immediate" $ session' $ do
597393 it "captures user input after switchover" $ runWD $ do
598394 inputRef :: IORef Text <- newRef ""
599395 let checkValue = do
@@ -673,31 +469,8 @@ tests withDebugging wdConfig caps _selenium = do
673469 names <- liftJSM $ traverse File.getName fs
674470 liftIO $ writeRef filesRef names
675471
676− session' "textAreaElement" $ do
677− describe "static renderer" $ do
678− it "sets value attribute" $ runWD $ do
679− let checkStatic = do
680− e <- findElemWithRetry $ WD.ByTag "textarea"
681− WD.attr e "value" `shouldBeWithRetryM` Just "test"
682− pure e
683− checkHydrated e = do
684− WD.attr e "value" `shouldBeWithRetryM` Just "test"
685− testWidget' checkStatic checkHydrated $ void $ textAreaElement $ def
686− & textAreaElementConfig_initialValue .~ "test"
687− it "updates value attribute at postBuild" $ runWD $ do
688− let checkStatic = do
689− e <- findElemWithRetry $ WD.ByTag "textarea"
690− WD.attr e "value" `shouldBeWithRetryM` Just "test-updated"
691− pure e
692− checkHydrated e = do
693− WD.attr e "value" `shouldBeWithRetryM` Just "test-updated"
694− testWidget' checkStatic checkHydrated $ do
695− pb <- getPostBuild
696− _ <- textAreaElement $ def
697− & textAreaElementConfig_initialValue .~ "test"
698− & textAreaElementConfig_setValue .~ ("test-updated" <$ pb)
699− pure ()
700− describe "hydration" $ do
472+ describe "textAreaElement" $ do
473+ describe "hydration" $ session' $ do
701474 it "doesn't wipe user input when switching over" $ runWD $ do
702475 inputRef <- newRef ("" :: Text)
703476 testWidget'
@@ -763,90 +536,8 @@ tests withDebugging wdConfig caps _selenium = do
763536 e <- textAreaElement $ def { _textAreaElementConfig_setValue = Just setValue' }
764537 performEvent_ $ liftIO . writeRef valueByUIRef <$> _textAreaElement_input e
765538 performEvent_ $ liftIO . writeRef valueRef <$> updated (value e)
766− it "fires _input event if the user altered the value before hydration" $ runWD $ do
767− textarea <- newRef ("" :: Text)
768− update <- newRef ("" :: Text)
769− let checkStatic = do
770− e <- findElemWithRetry $ WD.ByTag "textarea"
771− WD.attr e "value" `shouldBeWithRetryM` Just ""
772− WD.sendKeys "test" e
773− WD.attr e "value" `shouldBeWithRetryM` Just "test"
774− pure e
775− checkHydrated e = do
776− WD.attr e "value" `shouldBeWithRetryM` Just "test"
777− readRef textarea `shouldBeWithRetryM` "test"
778− readRef update `shouldBeWithRetryM` "test"
779− testWidget' checkStatic checkHydrated $ do
780− e <- textAreaElement def
781− performEvent_ $ liftIO . writeRef textarea <$> _textAreaElement_input e
782− performEvent_ $ liftIO . writeRef update <$> updated (_textAreaElement_value e)
783− it "does not fire _input event when the value is updated at postBuild" $ runWD $ do
784− textarea <- newRef (Nothing :: Maybe Text)
785− let checkStatic = do
786− e <- findElemWithRetry $ WD.ByTag "textarea"
787− WD.attr e "value" `shouldBeWithRetryM` Just "pb"
788− pure e
789− checkHydrated e = do
790− WD.attr e "value" `shouldBeWithRetryM` Just "pb"
791− readRef textarea `shouldBeWithRetryM` Nothing
792− testWidget' checkStatic checkHydrated $ do
793− pb <- getPostBuild
794− e <- textAreaElement $ def & textAreaElementConfig_setValue .~ ("pb" <$ pb)
795− performEvent_ $ liftIO . writeRef textarea . Just <$> _textAreaElement_input e
796− it "SSR produces correct DOM based on textAreaElement values when setValue happens at postBuild" $ runWD $ do
797− let checkBoth = do
798− textarea <- findElemWithRetry $ WD.ByTag "textarea"
799− WD.attr textarea "value" `shouldBeWithRetryM` Just "pb"
800− p <- findElemWithRetry (WD.ByTag "p")
801− shouldContainText "pb" p
802− testWidget checkBoth checkBoth $ do
803− pb <- getPostBuild
804− e <- textAreaElement $ def & textAreaElementConfig_setValue .~ ("pb" <$ pb)
805− el "p" $ dynText $ _textAreaElement_value e
806− it "does not fail when both setValue AND user updated value happen before switchover" $ runWD $ do
807− let checkStatic = do
808− textarea <- findElemWithRetry $ WD.ByTag "textarea"
809− h2_value <- findElemWithRetry (WD.ByTag "h2")
810− h3_input <- findElemWithRetry (WD.ByTag "h3")
811− WD.attr textarea "value" `shouldBeWithRetryM` Just "pb"
812− shouldContainText "pb" h2_value
813− shouldContainText "" h3_input
814− WD.sendKeys "abc" textarea
815− WD.attr textarea "value" `shouldBeWithRetryM` Just "pbabc"
816− shouldContainText "pb" h2_value
817− shouldContainText "" h3_input
818− pure (textarea, h2_value, h3_input)
819− checkHydrated (textarea, h2_value, h3_input) = do
820− WD.attr textarea "value" `shouldBeWithRetryM` Just "pbabc"
821− shouldContainText "pbabc" h3_input
822− shouldContainText "pbabc pb" h2_value
823− pure ()
824− testWidget' checkStatic checkHydrated $ do
825− pb <- getPostBuild
826− e <- textAreaElement $ def & textAreaElementConfig_setValue .~ ("pb" <$ pb)
827− el "h1" $ dynText $ _textAreaElement_value e
828− el "h2" $ dynText . fmap T.unwords <=< foldDyn (:) [] $ updated $ _textAreaElement_value e
829− el "h3" $ dynText . fmap T.unwords <=< foldDyn (:) [] $ _textAreaElement_input e
830− it "value is correct when both setValue AND user updated value happen before switchover" $ runWD $ do
831− let checkStatic = do
832− textarea <- findElemWithRetry $ WD.ByTag "textarea"
833− p <- findElemWithRetry (WD.ByTag "p")
834− WD.attr textarea "value" `shouldBeWithRetryM` Just "pb"
835− shouldContainText "pb" p
836− WD.sendKeys "abc" textarea
837− WD.attr textarea "value" `shouldBeWithRetryM` Just "pbabc"
838− shouldContainText "pb" p -- It won't be updated yet
839− pure (textarea, p)
840− checkHydrated (textarea, p) = do
841− WD.attr textarea "value" `shouldBeWithRetryM` Just "pbabc"
842− shouldContainText "pbabc" p
843− pure ()
844− testWidget' checkStatic checkHydrated $ do
845− pb <- getPostBuild
846− e <- textAreaElement $ def & textAreaElementConfig_setValue .~ ("pb" <$ pb)
847− el "p" $ dynText $ _textAreaElement_value e
848539
849− describe "hydration/immediate" $ do
540+ describe "hydration/immediate" $ session' $ do
850541 it "captures user input after switchover" $ runWD $ do
851542 inputRef :: IORef Text <- newRef ""
852543 let checkValue = do
@@ -888,13 +579,13 @@ tests withDebugging wdConfig caps _selenium = do
888579 performEvent_ $ liftIO . writeRef valueByUIRef <$> _textAreaElement_input e
889580 performEvent_ $ liftIO . writeRef valueRef <$> updated (value e)
890581
891− session' "selectElement" $ do
582+ describe "selectElement" $ do
892583 let options :: DomBuilder t m => m ()
893584 options = do
894585 elAttr "option" ("value" =: "one" <> "id" =: "one") $ text "one"
895586 elAttr "option" ("value" =: "two" <> "id" =: "two") $ text "two"
896587 elAttr "option" ("value" =: "three" <> "id" =: "three") $ text "three"
897− describe "hydration" $ do
588+ describe "hydration" $ session' $ do
898589 it "sets initial value correctly" $ runWD $ do
899590 inputRef <- newRef ("" :: Text)
900591 let setup = do
@@ -968,7 +659,7 @@ tests withDebugging wdConfig caps _selenium = do
968659 performEvent_ $ liftIO . writeRef valueByUIRef <$> _selectElement_change e
969660 performEvent_ $ liftIO . writeRef valueRef <$> updated (_selectElement_value e)
970661
971− describe "hydration/immediate" $ do
662+ describe "hydration/immediate" $ session' $ do
972663 it "captures user input after switchover" $ runWD $ do
973664 inputRef :: IORef Text <- newRef ""
974665 let checkValue = do
@@ -1014,7 +705,7 @@ tests withDebugging wdConfig caps _selenium = do
1014705 performEvent_ $ liftIO . writeRef valueByUIRef <$> _selectElement_change e
1015706 performEvent_ $ liftIO . writeRef valueRef <$> updated (_selectElement_value e)
1016707
1017− session' "prerender" $ do
708+ describe "prerender" $ session' $ do
1018709 it "works in simple case" $ runWD $ do
1019710 testWidget (checkBodyText "One") (checkBodyText "Two") $ do
1020711 prerender_ (text "One") (text "Two")
@@ -1083,7 +774,7 @@ tests withDebugging wdConfig caps _selenium = do
1083774 prerender_ (pure ()) (liftIO $ trigger "Client")
1084775 textNode $ TextNodeConfig "Initial" $ Just e
1085776
1086− session' "namespaces" $ do
777+ describe "namespaces" $ session' $ do
1087778 it "dyn can be nested in namespaced widget" $ runWD $ do
1088779 testWidget (pure ()) (checkTextInTag "svg" "one") $ do
1089780 let svgRootCfg = def
@@ -1092,7 +783,7 @@ tests withDebugging wdConfig caps _selenium = do
1092783 void $ element "svg" svgRootCfg $ do
1093784 dyn_ $ text "one" <$ pure ()
1094785
1095− session' "runWithReplace" $ do
786+ describe "runWithReplace" $ session' $ do
1096787 it "works" $ runWD $ do
1097788 replaceChan :: Chan Text <- liftIO newChan
1098789 let setup = findElemWithRetry $ WD.ByTag "div"
@@ -1266,9 +957,7 @@ tests withDebugging wdConfig caps _selenium = do
1266957 _ <- runWithReplace (text "inner1" *> comment "replace-end-0") $ text "inner2" <$ replace
1267958 text "|after"
1268959 void $ runWithReplace blank $ el "p" blank <$ replace -- Signal tag for end of test
1269− -- TODO This test actually causes a hydration failure, but it wasn't
1270− -- previously detected, so I've marked it pending
1271− xit "ignores missing ending bracketing comments" $ runWD $ do
960+ it "ignores missing ending bracketing comments" $ runWD $ do
1272961 replaceChan :: Chan () <- liftIO newChan
1273962 let
1274963 preSwitchover = do
@@ -1290,7 +979,7 @@ tests withDebugging wdConfig caps _selenium = do
1290979 _ <- runWithReplace (text "inner1") $ el "p" (text "inner2") <$ replace
1291980 text "|after"
1292981
1293− session' "traverseDMapWithKeyWithAdjust" $ do
982+ describe "traverseDMapWithKeyWithAdjust" $ session' $ do
1294983 let widget :: DomBuilder t m => DKey a -> Identity a -> m (Identity a)
1295984 widget k (Identity v) = elAttr "li" ("id" =: textKey k) $ do
1296985 elClass "span" "key" $ text $ textKey k
@@ -1393,7 +1082,7 @@ tests withDebugging wdConfig caps _selenium = do
13931082 (dmap, _evt) <- traverseDMapWithKeyWithAdjust widget keyMap $ leftmost [postBuildPatch <$ pb, replace]
13941083 liftIO $ dmap `H.shouldBe` keyMap
13951084
1396− session' "traverseIntMapWithKeyWithAdjust" $ do
1085+ describe "traverseIntMapWithKeyWithAdjust" $ session' $ do
13971086 let textKeyInt k = "key" <> T.pack (show k)
13981087 intMap = IntMap.fromList
13991088 [ (1, "one")
@@ -1500,7 +1189,7 @@ tests withDebugging wdConfig caps _selenium = do
15001189 (dmap, _evt) <- traverseIntMapWithKeyWithAdjust widget intMap $ leftmost [postBuildPatch <$ pb, replace]
15011190 liftIO $ dmap `H.shouldBe` intMap
15021191
1503− session' "traverseDMapWithKeyWithAdjustWithMove" $ do
1192+ describe "traverseDMapWithKeyWithAdjustWithMove" $ session' $ do
15041193 let widget :: DomBuilder t m => Key2 a -> Identity a -> m (Identity a)
15051194 widget k (Identity v) = elAttr "li" ("id" =: textKey2 k) $ do
15061195 elClass "span" "key" $ text $ textKey2 k
@@ -1580,8 +1269,8 @@ tests withDebugging wdConfig caps _selenium = do
15801269 (dmap, _evt) <- traverseDMapWithKeyWithAdjustWithMove widget initMap =<< triggerEventWithChan chan
15811270 liftIO $ assertEqual "DMap" initMap dmap
15821271
1583− session' "hydrating invalid HTML" $ do
1584− xit "can hydrate list in paragraph" $ runWD $ do
1272+ describe "hydrating invalid HTML" $ session' $ do
1273+ it "can hydrate list in paragraph" $ runWD $ do
15851274 let preSwitchover = do
15861275 checkBodyText "before\ninner\nafter"
15871276 -- Two <p> tags should be present
@@ -1598,8 +1287,7 @@ tests withDebugging wdConfig caps _selenium = do
15981287 shouldContainText "before\ninner\nafter" p1
15991288 elementShouldBeRemoved ol
16001289 elementShouldBeRemoved p2
1601− -- Don't fail fatally when hydration encounters the invalid DOM
1602− testWidgetDebug' False withDebugging preSwitchover check $ do
1290+ testWidget' preSwitchover check $ do
16031291 -- This is deliberately invalid HTML, the browser will interpret it as
16041292 -- <p>before</p><ol>inner</ol>after<p></p>
16051293 el "p" $ do
@@ -1607,29 +1295,6 @@ tests withDebugging wdConfig caps _selenium = do
16071295 el "ol" $ text "inner"
16081296 text "after"
16091297
1610− -- TODO: This test presupposes the exact set of labels that "dropdown" places in the "value" fields to distinguish options.
1611− -- This dependence on internal implementation details is undesirable in a test case, but seems fairly tricky to avoid.
1612− -- It seems expedient for the time being to expect this test case to be updated, should those implementation details ever change.
1613− session' "dropdown" $ do
1614− let doTest expectedOpts (initialValue :: Text) = do
1615− let doCheck = do
1616− es <- findElemsWithRetry $ WD.ByTag "option"
1617− opts <- mapM fetchElement es
1618− assertEqual "missing/extra/incorrect option element(s)" expectedOpts (sort opts)
1619− testWidget doCheck doCheck $ do
1620− void $ dropdown initialValue (constDyn (("aa" :: Text) =: "aaa" <> "bb" =: "bbb")) def
1621− fetchElement e = do
1622− val <- WD.attr e "value"
1623− sel <- WD.attr e "selected"
1624− return (fromMaybe "" val, isJust sel)
1625− -- The "aa" test case is important, but a good test implementation probably needs to avoid selenium, because HTML parsers will insert a "selected" attribute on the first "option" tag if no selected attributes are present; thus as written, this erroneously succeeds on the old implementation (but properly implemented, should fail)
1626− -- Thus, it would appear that we do actually need a HTML5 or maybe XML parser for this test suite.
1627− xit "statically renders initial values (on aa)" $ runWD $ do
1628− doTest [("0",True),("1",False)] "aa"
1629− -- These tests are currently marked "pending" (by using "xit" instead of "it") because this test has a high chance of non-deterministically failing, which is a problem elsewhere in this test suite as well
1630− xit "statically renders initial values (on bb)" $ runWD $ do
1631− doTest [("0",False),("1",True)] "bb"
1632−
16331298data Selenium = Selenium
16341299 { _selenium_portNumber :: PortNumber
16351300 , _selenium_stopServer :: IO ()
@@ -1697,9 +1362,6 @@ checkTextInId i expected = do
16971362findElemWithRetry :: Selector -> WD WD.Element
16981363findElemWithRetry = withRetry . WD.findElem
16991364
1700−findElemsWithRetry :: Selector -> WD [WD.Element]
1701−findElemsWithRetry = withRetry . WD.findElems
1702−
17031365getBody :: WD WD.Element
17041366getBody = WD.findElem $ WD.ByTag "body"
17051367
@@ -1725,12 +1387,11 @@ testWidgetStaticDebug
17251387 -> (forall m js. TestWidget js (SpiderTimeline Global) m => m ())
17261388 -- ^ Widget we are testing
17271389 -> WD b
1728−testWidgetStaticDebug withDebugging w = testWidgetDebug True withDebugging (void w) w
1390+testWidgetStaticDebug withDebugging w = testWidgetDebug withDebugging (void w) w
17291391
17301392-- | TODO: do something about JSExceptions not causing tests to fail
17311393testWidgetDebug
17321394 :: Bool
1733− -> Bool
17341395 -> WD ()
17351396 -- ^ Webdriver commands to run before the JS runs (i.e. on the statically rendered page)
17361397 -> WD b
@@ -1738,16 +1399,12 @@ testWidgetDebug
17381399 -> (forall m js. TestWidget js (SpiderTimeline Global) m => m ())
17391400 -- ^ Widget we are testing
17401401 -> WD b
1741−testWidgetDebug hardFailure withDebugging beforeJS afterSwitchover =
1742− testWidgetDebug' hardFailure withDebugging beforeJS (const afterSwitchover)
1743−
1744−data HydrationFailedException = HydrationFailedException deriving Show
1745−instance Exception HydrationFailedException
1402+testWidgetDebug withDebugging beforeJS afterSwitchover =
1403+ testWidgetDebug' withDebugging beforeJS (const afterSwitchover)
17461404
17471405-- | TODO: do something about JSExceptions not causing tests to fail
17481406testWidgetDebug'
17491407 :: Bool
1750− -> Bool
17511408 -> WD a
17521409 -- ^ Webdriver commands to run before the JS runs (i.e. on the statically rendered page)
17531410 -> (a -> WD b)
@@ -1755,7 +1412,7 @@ testWidgetDebug'
17551412 -> (forall m js. TestWidget js (SpiderTimeline Global) m => m ())
17561413 -- ^ Widget we are testing (contents of body)
17571414 -> WD b
1758−testWidgetDebug' hardFailure withDebugging beforeJS afterSwitchover bodyWidget = do
1415+testWidgetDebug' withDebugging beforeJS afterSwitchover bodyWidget = do
17591416 let putStrLnDebug :: MonadIO m => Text -> m ()
17601417 putStrLnDebug m = when withDebugging $ liftIO $ putStrLn $ T.unpack m
17611418 staticApp = do
@@ -1767,7 +1424,6 @@ testWidgetDebug' hardFailure withDebugging beforeJS afterSwitchover bodyWidget =
17671424 ((), html) <- liftIO $ renderStatic $ runHydratableT staticApp
17681425 putStrLnDebug "rendered static"
17691426 waitBeforeJS <- liftIO newEmptyMVar -- Empty until JS should be run
1770− onFailure <- if hardFailure then (`throwTo` HydrationFailedException) <$> liftIO myThreadId else pure $ pure ()
17711427 waitUntilSwitchover <- liftIO newEmptyMVar -- Empty until switchover
17721428 let entryPoint = do
17731429 putStrLnDebug "taking waitBeforeJS"
@@ -1779,7 +1435,7 @@ testWidgetDebug' hardFailure withDebugging beforeJS afterSwitchover bodyWidget =
17791435 liftIO $ putMVar waitUntilSwitchover ()
17801436 putStrLnDebug "put waitUntilSwitchover"
17811437 putStrLnDebug "running mainHydrationWidgetWithSwitchoverAction"
1782− mainHydrationWidgetWithSwitchoverActionWithFailure' onFailure switchOverAction blank bodyWidget
1438+ mainHydrationWidgetWithSwitchoverAction switchOverAction blank bodyWidget
17831439 putStrLnDebug "syncPoint after mainHydrationWidgetWithSwitchoverAction"
17841440 syncPoint
17851441 application <- liftIO $ jsaddleOr defaultConnectionOptions entryPoint $ \_ sendResponse -> do