@@ -20,14 +20,6 @@
2020
2121{-# OPTIONS_GHC -fno-warn-orphans #-}
2222
23−-- Notice to those working on this test suite:
24−-- It doesn't appear to be possible to use --match to run a particular test, in
25−-- this situation the test may hang before reaching our code. This seems to
26−-- happen when the test is not the first test in the block. As a workaround, you
27−-- can just comment out the other tests. Also, using `xit` will cause the same
28−-- issue. `xit` tests must be the last tests in the session, or the session will
29−-- hang in the following test.
30−
3123import Prelude hiding (fail)
3224import Control.Concurrent
3325import qualified Control.Concurrent.Async as Async
@@ -145,7 +137,7 @@ deriving instance MonadFail WD
145137
146138main :: IO ()
147139main = do
148− unshareNetwork
140+ unshareNetork
149141 isHeadless <- (== Nothing) <$> lookupEnv "NO_HEADLESS"
150142 withSandboxedChromeFlags isHeadless $ \chromeFlags -> do
151143 withSeleniumServer $ \selenium -> do
@@ -154,13 +146,13 @@ main = do
154146 withDebugging <- isNothing <$> lookupEnv "NO_DEBUG"
155147 let wdConfig = WD.defaultConfig { WD.wdPort = fromIntegral $ _selenium_portNumber selenium }
156148 chromeCaps' = WD.getCaps $ chromeConfig browserPath chromeFlags
157− hspec (tests withDebugging wdConfig [(chromeCaps', "chrome")] selenium) `finally` _selenium_stopServer selenium
149+ hspec (tests withDebugging wdConfig [chromeCaps'] selenium) `finally` _selenium_stopServer selenium
158150
159−tests :: Bool -> WD.WDConfig -> [(Capabilities, String)] -> Selenium -> Spec
151+tests :: Bool -> WD.WDConfig -> [Capabilities] -> Selenium -> Spec
160152tests withDebugging wdConfig caps _selenium = do
161153 let putStrLnDebug :: MonadIO m => Text -> m ()
162154 putStrLnDebug m = when withDebugging $ liftIO $ putStrLn $ T.unpack m
163− session' t = sessionWith wdConfig t . using caps
155+ session' = sessionWith wdConfig "" . using (map (,"") caps)
164156 runWD m = runWDOptions (WdOptions False) $ do
165157 putStrLnDebug "before"
166158 r <- m
@@ -169,10 +161,10 @@ tests withDebugging wdConfig caps _selenium = do
169161 testWidgetStatic :: WD b -> (forall m js. TestWidget js (SpiderTimeline Global) m => m ()) -> WD b
170162 testWidgetStatic = testWidgetStaticDebug withDebugging
171163 testWidget :: WD () -> WD b -> (forall m js. TestWidget js (SpiderTimeline Global) m => m ()) -> WD b
172− testWidget = testWidgetDebug True withDebugging
164+ testWidget = testWidgetDebug withDebugging
173165 testWidget' :: WD a -> (a -> WD b) -> (forall m js. TestWidget js (SpiderTimeline Global) m => m ()) -> WD b
174− testWidget' = testWidgetDebug' True withDebugging
175− session' "text" $ do
166+ testWidget' = testWidgetDebug' withDebugging
167+ describe "text" $ session' $ do
176168 it "works" $ runWD $ do
177169 testWidgetStatic (checkBodyText "hello world") $ do
178170 text "hello world"
@@ -233,7 +225,7 @@ tests withDebugging wdConfig caps _selenium = do
233225 click <- button ""
234226 void $ textNode $ TextNodeConfig "initial" $ Just $ "after" <$ click
235227
236− session' "element" $ do
228+ describe "element" $ session' $ do
237229 it "works with domEvent Click" $ runWD $ do
238230 clickedRef <- liftIO $ newRef False
239231 testWidget' (findElemWithRetry $ WD.ByTag "div") WD.click $ do
@@ -297,8 +289,8 @@ tests withDebugging wdConfig caps _selenium = do
297289 let click = domEvent Click e
298290 return ()
299291
300− session' "inputElement" $ do
301− describe "static renderer" $ do
292+ describe "inputElement" $ do
293+ describe "static renderer" $ session' $ do
302294 it "sets value attribute" $ runWD $ do
303295 let checkStatic = do
304296 e <- findElemWithRetry $ WD.ByTag "input"
@@ -321,41 +313,7 @@ tests withDebugging wdConfig caps _selenium = do
321313 & inputElementConfig_initialValue .~ "test"
322314 & inputElementConfig_setValue .~ ("test-updated" <$ pb)
323315 pure ()
324− it "sets checked attr appropriately" $ runWD $ do
325− setCheckedChan <- liftIO newChan
326− let checkStatic = do
327− e <- findElemWithRetry $ WD.ByTag "input"
328− WD.attr e "checked" `shouldBeWithRetryM` Just "true"
329− pure e
330− checkValue e = do
331− WD.attr e "checked" `shouldBeWithRetryM` Just "true"
332− WD.moveToCenter e
333− WD.click e -- Click to uncheck
334− WD.attr e "checked" `shouldBeWithRetryM` Nothing
335− liftIO $ writeChan setCheckedChan True -- Programatically check the checkbox
336− WD.attr e "checked" `shouldBeWithRetryM` Just "true"
337− testWidget' checkStatic checkValue $ do
338− setChecked <- triggerEventWithChan setCheckedChan
339− _ <- inputElement $ def
340− & initialAttributes .~ "type" =: "checkbox"
341− & inputElementConfig_initialChecked .~ True
342− & inputElementConfig_setChecked .~ setChecked
343− pure ()
344− it "sets checked attr appropriately at postbuild" $ runWD $ do
345− let checkStatic = do
346− e <- findElemWithRetry $ WD.ByTag "input"
347− WD.attr e "checked" `shouldBeWithRetryM` Just "true"
348− pure e
349− checkValue e = do
350− WD.attr e "checked" `shouldBeWithRetryM` Just "true"
351− testWidget' checkStatic checkValue $ do
352− pb <- getPostBuild
353− _ <- inputElement $ def
354− & initialAttributes .~ "type" =: "checkbox"
355− & inputElementConfig_initialChecked .~ False
356− & inputElementConfig_setChecked .~ (True <$ pb)
357− pure ()
358− describe "hydration" $ do
316+ describe "hydration" $ session' $ do
359317 it "doesn't wipe user input when switching over" $ runWD $ do
360318 inputRef <- newRef ("hello " :: Text)
361319 testWidget'
@@ -425,49 +383,24 @@ tests withDebugging wdConfig caps _selenium = do
425383 checkedByUIRef <- newRef False
426384 checkedRef <- newRef False
427385 setCheckedChan <- liftIO newChan
428− let checkStatic = do
429− e <- findElemWithRetry $ WD.ByTag "input"
430− WD.attr e "checked" `shouldBeWithRetryM` Nothing
431− pure e
432− checkValue e = do
386+ let checkValue = do
433387 readRef checkedByUIRef `shouldBeWithRetryM` False
434388 readRef checkedRef `shouldBeWithRetryM` False
435− WD.attr e "checked" `shouldBeWithRetryM` Nothing
389+ e <- findElemWithRetry $ WD.ByTag "input"
436390 WD.moveToCenter e
437391 WD.click e
438392 readRef checkedByUIRef `shouldBeWithRetryM` True
439393 readRef checkedRef `shouldBeWithRetryM` True
440− WD.attr e "checked" `shouldBeWithRetryM` Just "true"
441394 liftIO $ writeChan setCheckedChan False
442395 readRef checkedByUIRef `shouldBeWithRetryM` True
443396 readRef checkedRef `shouldBeWithRetryM` False
444− WD.attr e "checked" `shouldBeWithRetryM` Nothing
445− testWidget' checkStatic checkValue $ do
397+ testWidget (pure ()) checkValue $ do
446398 setChecked <- triggerEventWithChan setCheckedChan
447399 e <- inputElement $ def
448400 & initialAttributes .~ "type" =: "checkbox"
449401 & inputElementConfig_setChecked .~ setChecked
450402 performEvent_ $ liftIO . writeRef checkedByUIRef <$> _inputElement_checkedChange e
451403 performEvent_ $ liftIO . writeRef checkedRef <$> updated (_inputElement_checked e)
452− it "respects user updates to checked which happen before hydration" $ runWD $ do
453− checkedByUIRef <- newRef False
454− checkedRef <- newRef False
455− let checkStatic = do
456− e <- findElemWithRetry $ WD.ByTag "input"
457− WD.attr e "checked" `shouldBeWithRetryM` Nothing
458− WD.moveToCenter e
459− WD.click e
460− WD.attr e "checked" `shouldBeWithRetryM` Just "true"
461− pure e
462− checkValue e = do
463− WD.attr e "checked" `shouldBeWithRetryM` Just "true"
464− readRef checkedByUIRef `shouldBeWithRetryM` True
465− readRef checkedRef `shouldBeWithRetryM` True
466− testWidget' checkStatic checkValue $ do
467− e <- inputElement $ def
468− & initialAttributes .~ "type" =: "checkbox"
469− performEvent_ $ liftIO . writeRef checkedByUIRef <$> _inputElement_checkedChange e
470− performEvent_ $ liftIO . writeRef checkedRef <$> updated (_inputElement_checked e)
471404 it "captures file uploads" $ runWD $ do
472405 filesRef :: IORef [Text] <- newRef []
473406 let uploadFile = do
@@ -483,117 +416,8 @@ tests withDebugging wdConfig caps _selenium = do
483416 prerender_ (pure ()) $ performEvent_ $ ffor (tag (current (_inputElement_files e)) click) $ \fs -> do
484417 names <- liftJSM $ traverse File.getName fs
485418 liftIO $ writeRef filesRef names
486− it "fires _input event if the user altered the value before hydration" $ runWD $ do
487− input <- newRef ("" :: Text)
488− update <- newRef ("" :: Text)
489− let checkStatic = do
490− e <- findElemWithRetry $ WD.ByTag "input"
491− WD.attr e "value" `shouldBeWithRetryM` Just ""
492− WD.sendKeys "test" e
493− WD.attr e "value" `shouldBeWithRetryM` Just "test"
494− pure e
495− checkHydrated e = do
496− WD.attr e "value" `shouldBeWithRetryM` Just "test"
497− readRef input `shouldBeWithRetryM` "test"
498− readRef update `shouldBeWithRetryM` "test"
499− testWidget' checkStatic checkHydrated $ do
500− e <- inputElement def
501− performEvent_ $ liftIO . writeRef input <$> _inputElement_input e
502− performEvent_ $ liftIO . writeRef update <$> updated (_inputElement_value e)
503− it "does not fire _input event when the value is updated at postBuild" $ runWD $ do
504− input <- newRef (Nothing :: Maybe Text)
505− let checkStatic = do
506− e <- findElemWithRetry $ WD.ByTag "input"
507− WD.attr e "value" `shouldBeWithRetryM` Just "pb"
508− pure e
509− checkHydrated e = do
510− WD.attr e "value" `shouldBeWithRetryM` Just "pb"
511− readRef input `shouldBeWithRetryM` Nothing
512− testWidget' checkStatic checkHydrated $ do
513− pb <- getPostBuild
514− e <- inputElement $ def & inputElementConfig_setValue .~ ("pb" <$ pb)
515− performEvent_ $ liftIO . writeRef input . Just <$> _inputElement_input e
516− it "SSR produces correct DOM based on inputElement values when setValue happens at postBuild" $ runWD $ do
517− let checkBoth = do
518− input <- findElemWithRetry $ WD.ByTag "input"
519− WD.attr input "value" `shouldBeWithRetryM` Just "pb"
520− p <- findElemWithRetry (WD.ByTag "p")
521− shouldContainText "pb" p
522− testWidget checkBoth checkBoth $ do
523− pb <- getPostBuild
524− e <- inputElement $ def & inputElementConfig_setValue .~ ("pb" <$ pb)
525− el "p" $ dynText $ _inputElement_value e
526− it "does not fail when both setValue AND user updated value happen before switchover" $ runWD $ do
527− let checkStatic = do
528− input <- findElemWithRetry $ WD.ByTag "input"
529− h2_value <- findElemWithRetry (WD.ByTag "h2")
530− h3_input <- findElemWithRetry (WD.ByTag "h3")
531− WD.attr input "value" `shouldBeWithRetryM` Just "pb"
532− shouldContainText "pb" h2_value
533− shouldContainText "" h3_input
534− WD.sendKeys "abc" input
535− WD.attr input "value" `shouldBeWithRetryM` Just "pbabc"
536− shouldContainText "pb" h2_value
537− shouldContainText "" h3_input
538− pure (input, h2_value, h3_input)
539− checkHydrated (input, h2_value, h3_input) = do
540− WD.attr input "value" `shouldBeWithRetryM` Just "pbabc"
541− shouldContainText "pbabc" h3_input
542− shouldContainText "pbabc pb" h2_value
543− pure ()
544− testWidget' checkStatic checkHydrated $ do
545− pb <- getPostBuild
546− e <- inputElement $ def & inputElementConfig_setValue .~ ("pb" <$ pb)
547− el "h1" $ dynText $ _inputElement_value e
548− el "h2" $ dynText . fmap T.unwords <=< foldDyn (:) [] $ updated $ _inputElement_value e
549− el "h3" $ dynText . fmap T.unwords <=< foldDyn (:) [] $ _inputElement_input e
550− it "value is correct when both setValue AND user updated value happen before switchover" $ runWD $ do
551− let checkStatic = do
552− input <- findElemWithRetry $ WD.ByTag "input"
553− p <- findElemWithRetry (WD.ByTag "p")
554− WD.attr input "value" `shouldBeWithRetryM` Just "pb"
555− shouldContainText "pb" p
556− WD.sendKeys "abc" input
557− WD.attr input "value" `shouldBeWithRetryM` Just "pbabc"
558− shouldContainText "pb" p -- It won't be updated yet
559− pure (input, p)
560− checkHydrated (input, p) = do
561− WD.attr input "value" `shouldBeWithRetryM` Just "pbabc"
562− shouldContainText "pbabc" p
563− pure ()
564− testWidget' checkStatic checkHydrated $ do
565− pb <- getPostBuild
566− e <- inputElement $ def & inputElementConfig_setValue .~ ("pb" <$ pb)
567− el "p" $ dynText $ _inputElement_value e
568− it "input event and (updated value) fire correctly when both setValue AND user updated value happen before switchover" $ runWD $ do
569− valRef <- newRef ([] :: [Text])
570− inputRef <- newRef ([] :: [Text])
571− let consRef ref a = liftIO $ atomicModifyRef ref $ \as -> (a:as, ())
572− checkStatic = do
573− input <- findElemWithRetry $ WD.ByTag "input"
574− p <- findElemWithRetry (WD.ByTag "p")
575− WD.attr input "value" `shouldBeWithRetryM` Just "pb"
576− shouldContainText "pb" p
577− WD.sendKeys "abc" input
578− WD.attr input "value" `shouldBeWithRetryM` Just "pbabc"
579− shouldContainText "pb" p -- It won't be updated yet
580− readRef inputRef `shouldBeWithRetryM` [] -- Should never fire input ref during SSR
581− readRef valRef `shouldBeWithRetryM` ["pb"]
582− pure (input, p)
583− checkHydrated (input, p) = do
584− readRef inputRef `shouldBeWithRetryM` ["pbabc"]
585− readRef valRef `shouldBeWithRetryM` ["pbabc", "pb"]
586− WD.attr input "value" `shouldBeWithRetryM` Just "pbabc"
587− shouldContainText "pbabc" p
588− pure ()
589− testWidget' checkStatic checkHydrated $ do
590− liftIO $ writeRef valRef []
591− pb <- getPostBuild
592− e <- inputElement $ def & inputElementConfig_setValue .~ ("pb" <$ pb)
593− el "p" $ dynText $ _inputElement_value e
594− performEvent_ $ consRef valRef <$> updated (_inputElement_value e)
595− performEvent_ $ consRef inputRef <$> _inputElement_input e
596− describe "hydration/immediate" $ do
419+
420+ describe "hydration/immediate" $ session' $ do
597421 it "captures user input after switchover" $ runWD $ do
598422 inputRef :: IORef Text <- newRef ""
599423 let checkValue = do
@@ -673,8 +497,8 @@ tests withDebugging wdConfig caps _selenium = do
673497 names <- liftJSM $ traverse File.getName fs
674498 liftIO $ writeRef filesRef names
675499
676− session' "textAreaElement" $ do
677− describe "static renderer" $ do
500+ describe "textAreaElement" $ do
501+ describe "static renderer" $ session' $ do
678502 it "sets value attribute" $ runWD $ do
679503 let checkStatic = do
680504 e <- findElemWithRetry $ WD.ByTag "textarea"
@@ -697,7 +521,7 @@ tests withDebugging wdConfig caps _selenium = do
697521 & textAreaElementConfig_initialValue .~ "test"
698522 & textAreaElementConfig_setValue .~ ("test-updated" <$ pb)
699523 pure ()
700− describe "hydration" $ do
524+ describe "hydration" $ session' $ do
701525 it "doesn't wipe user input when switching over" $ runWD $ do
702526 inputRef <- newRef ("" :: Text)
703527 testWidget'
@@ -763,90 +587,8 @@ tests withDebugging wdConfig caps _selenium = do
763587 e <- textAreaElement $ def { _textAreaElementConfig_setValue = Just setValue' }
764588 performEvent_ $ liftIO . writeRef valueByUIRef <$> _textAreaElement_input e
765589 performEvent_ $ liftIO . writeRef valueRef <$> updated (value e)
766− it "fires _input event if the user altered the value before hydration" $ runWD $ do
767− textarea <- newRef ("" :: Text)
768− update <- newRef ("" :: Text)
769− let checkStatic = do
770− e <- findElemWithRetry $ WD.ByTag "textarea"
771− WD.attr e "value" `shouldBeWithRetryM` Just ""
772− WD.sendKeys "test" e
773− WD.attr e "value" `shouldBeWithRetryM` Just "test"
774− pure e
775− checkHydrated e = do
776− WD.attr e "value" `shouldBeWithRetryM` Just "test"
777− readRef textarea `shouldBeWithRetryM` "test"
778− readRef update `shouldBeWithRetryM` "test"
779− testWidget' checkStatic checkHydrated $ do
780− e <- textAreaElement def
781− performEvent_ $ liftIO . writeRef textarea <$> _textAreaElement_input e
782− performEvent_ $ liftIO . writeRef update <$> updated (_textAreaElement_value e)
783− it "does not fire _input event when the value is updated at postBuild" $ runWD $ do
784− textarea <- newRef (Nothing :: Maybe Text)
785− let checkStatic = do
786− e <- findElemWithRetry $ WD.ByTag "textarea"
787− WD.attr e "value" `shouldBeWithRetryM` Just "pb"
788− pure e
789− checkHydrated e = do
790− WD.attr e "value" `shouldBeWithRetryM` Just "pb"
791− readRef textarea `shouldBeWithRetryM` Nothing
792− testWidget' checkStatic checkHydrated $ do
793− pb <- getPostBuild
794− e <- textAreaElement $ def & textAreaElementConfig_setValue .~ ("pb" <$ pb)
795− performEvent_ $ liftIO . writeRef textarea . Just <$> _textAreaElement_input e
796− it "SSR produces correct DOM based on textAreaElement values when setValue happens at postBuild" $ runWD $ do
797− let checkBoth = do
798− textarea <- findElemWithRetry $ WD.ByTag "textarea"
799− WD.attr textarea "value" `shouldBeWithRetryM` Just "pb"
800− p <- findElemWithRetry (WD.ByTag "p")
801− shouldContainText "pb" p
802− testWidget checkBoth checkBoth $ do
803− pb <- getPostBuild
804− e <- textAreaElement $ def & textAreaElementConfig_setValue .~ ("pb" <$ pb)
805− el "p" $ dynText $ _textAreaElement_value e
806− it "does not fail when both setValue AND user updated value happen before switchover" $ runWD $ do
807− let checkStatic = do
808− textarea <- findElemWithRetry $ WD.ByTag "textarea"
809− h2_value <- findElemWithRetry (WD.ByTag "h2")
810− h3_input <- findElemWithRetry (WD.ByTag "h3")
811− WD.attr textarea "value" `shouldBeWithRetryM` Just "pb"
812− shouldContainText "pb" h2_value
813− shouldContainText "" h3_input
814− WD.sendKeys "abc" textarea
815− WD.attr textarea "value" `shouldBeWithRetryM` Just "pbabc"
816− shouldContainText "pb" h2_value
817− shouldContainText "" h3_input
818− pure (textarea, h2_value, h3_input)
819− checkHydrated (textarea, h2_value, h3_input) = do
820− WD.attr textarea "value" `shouldBeWithRetryM` Just "pbabc"
821− shouldContainText "pbabc" h3_input
822− shouldContainText "pbabc pb" h2_value
823− pure ()
824− testWidget' checkStatic checkHydrated $ do
825− pb <- getPostBuild
826− e <- textAreaElement $ def & textAreaElementConfig_setValue .~ ("pb" <$ pb)
827− el "h1" $ dynText $ _textAreaElement_value e
828− el "h2" $ dynText . fmap T.unwords <=< foldDyn (:) [] $ updated $ _textAreaElement_value e
829− el "h3" $ dynText . fmap T.unwords <=< foldDyn (:) [] $ _textAreaElement_input e
830− it "value is correct when both setValue AND user updated value happen before switchover" $ runWD $ do
831− let checkStatic = do
832− textarea <- findElemWithRetry $ WD.ByTag "textarea"
833− p <- findElemWithRetry (WD.ByTag "p")
834− WD.attr textarea "value" `shouldBeWithRetryM` Just "pb"
835− shouldContainText "pb" p
836− WD.sendKeys "abc" textarea
837− WD.attr textarea "value" `shouldBeWithRetryM` Just "pbabc"
838− shouldContainText "pb" p -- It won't be updated yet
839− pure (textarea, p)
840− checkHydrated (textarea, p) = do
841− WD.attr textarea "value" `shouldBeWithRetryM` Just "pbabc"
842− shouldContainText "pbabc" p
843− pure ()
844− testWidget' checkStatic checkHydrated $ do
845− pb <- getPostBuild
846− e <- textAreaElement $ def & textAreaElementConfig_setValue .~ ("pb" <$ pb)
847− el "p" $ dynText $ _textAreaElement_value e
848590
849− describe "hydration/immediate" $ do
591+ describe "hydration/immediate" $ session' $ do
850592 it "captures user input after switchover" $ runWD $ do
851593 inputRef :: IORef Text <- newRef ""
852594 let checkValue = do
@@ -888,13 +630,13 @@ tests withDebugging wdConfig caps _selenium = do
888630 performEvent_ $ liftIO . writeRef valueByUIRef <$> _textAreaElement_input e
889631 performEvent_ $ liftIO . writeRef valueRef <$> updated (value e)
890632
891− session' "selectElement" $ do
633+ describe "selectElement" $ do
892634 let options :: DomBuilder t m => m ()
893635 options = do
894636 elAttr "option" ("value" =: "one" <> "id" =: "one") $ text "one"
895637 elAttr "option" ("value" =: "two" <> "id" =: "two") $ text "two"
896638 elAttr "option" ("value" =: "three" <> "id" =: "three") $ text "three"
897− describe "hydration" $ do
639+ describe "hydration" $ session' $ do
898640 it "sets initial value correctly" $ runWD $ do
899641 inputRef <- newRef ("" :: Text)
900642 let setup = do
@@ -968,7 +710,7 @@ tests withDebugging wdConfig caps _selenium = do
968710 performEvent_ $ liftIO . writeRef valueByUIRef <$> _selectElement_change e
969711 performEvent_ $ liftIO . writeRef valueRef <$> updated (_selectElement_value e)
970712
971− describe "hydration/immediate" $ do
713+ describe "hydration/immediate" $ session' $ do
972714 it "captures user input after switchover" $ runWD $ do
973715 inputRef :: IORef Text <- newRef ""
974716 let checkValue = do
@@ -1014,7 +756,7 @@ tests withDebugging wdConfig caps _selenium = do
1014756 performEvent_ $ liftIO . writeRef valueByUIRef <$> _selectElement_change e
1015757 performEvent_ $ liftIO . writeRef valueRef <$> updated (_selectElement_value e)
1016758
1017− session' "prerender" $ do
759+ describe "prerender" $ session' $ do
1018760 it "works in simple case" $ runWD $ do
1019761 testWidget (checkBodyText "One") (checkBodyText "Two") $ do
1020762 prerender_ (text "One") (text "Two")
@@ -1083,7 +825,7 @@ tests withDebugging wdConfig caps _selenium = do
1083825 prerender_ (pure ()) (liftIO $ trigger "Client")
1084826 textNode $ TextNodeConfig "Initial" $ Just e
1085827
1086− session' "namespaces" $ do
828+ describe "namespaces" $ session' $ do
1087829 it "dyn can be nested in namespaced widget" $ runWD $ do
1088830 testWidget (pure ()) (checkTextInTag "svg" "one") $ do
1089831 let svgRootCfg = def
@@ -1092,7 +834,7 @@ tests withDebugging wdConfig caps _selenium = do
1092834 void $ element "svg" svgRootCfg $ do
1093835 dyn_ $ text "one" <$ pure ()
1094836
1095− session' "runWithReplace" $ do
837+ describe "runWithReplace" $ session' $ do
1096838 it "works" $ runWD $ do
1097839 replaceChan :: Chan Text <- liftIO newChan
1098840 let setup = findElemWithRetry $ WD.ByTag "div"
@@ -1266,9 +1008,7 @@ tests withDebugging wdConfig caps _selenium = do
12661008 _ <- runWithReplace (text "inner1" *> comment "replace-end-0") $ text "inner2" <$ replace
12671009 text "|after"
12681010 void $ runWithReplace blank $ el "p" blank <$ replace -- Signal tag for end of test
1269− -- TODO This test actually causes a hydration failure, but it wasn't
1270− -- previously detected, so I've marked it pending
1271− xit "ignores missing ending bracketing comments" $ runWD $ do
1011+ it "ignores missing ending bracketing comments" $ runWD $ do
12721012 replaceChan :: Chan () <- liftIO newChan
12731013 let
12741014 preSwitchover = do
@@ -1290,7 +1030,7 @@ tests withDebugging wdConfig caps _selenium = do
12901030 _ <- runWithReplace (text "inner1") $ el "p" (text "inner2") <$ replace
12911031 text "|after"
12921032
1293− session' "traverseDMapWithKeyWithAdjust" $ do
1033+ describe "traverseDMapWithKeyWithAdjust" $ session' $ do
12941034 let widget :: DomBuilder t m => DKey a -> Identity a -> m (Identity a)
12951035 widget k (Identity v) = elAttr "li" ("id" =: textKey k) $ do
12961036 elClass "span" "key" $ text $ textKey k
@@ -1393,7 +1133,7 @@ tests withDebugging wdConfig caps _selenium = do
13931133 (dmap, _evt) <- traverseDMapWithKeyWithAdjust widget keyMap $ leftmost [postBuildPatch <$ pb, replace]
13941134 liftIO $ dmap `H.shouldBe` keyMap
13951135
1396− session' "traverseIntMapWithKeyWithAdjust" $ do
1136+ describe "traverseIntMapWithKeyWithAdjust" $ session' $ do
13971137 let textKeyInt k = "key" <> T.pack (show k)
13981138 intMap = IntMap.fromList
13991139 [ (1, "one")
@@ -1500,7 +1240,7 @@ tests withDebugging wdConfig caps _selenium = do
15001240 (dmap, _evt) <- traverseIntMapWithKeyWithAdjust widget intMap $ leftmost [postBuildPatch <$ pb, replace]
15011241 liftIO $ dmap `H.shouldBe` intMap
15021242
1503− session' "traverseDMapWithKeyWithAdjustWithMove" $ do
1243+ describe "traverseDMapWithKeyWithAdjustWithMove" $ session' $ do
15041244 let widget :: DomBuilder t m => Key2 a -> Identity a -> m (Identity a)
15051245 widget k (Identity v) = elAttr "li" ("id" =: textKey2 k) $ do
15061246 elClass "span" "key" $ text $ textKey2 k
@@ -1580,8 +1320,8 @@ tests withDebugging wdConfig caps _selenium = do
15801320 (dmap, _evt) <- traverseDMapWithKeyWithAdjustWithMove widget initMap =<< triggerEventWithChan chan
15811321 liftIO $ assertEqual "DMap" initMap dmap
15821322
1583− session' "hydrating invalid HTML" $ do
1584− xit "can hydrate list in paragraph" $ runWD $ do
1323+ describe "hydrating invalid HTML" $ session' $ do
1324+ it "can hydrate list in paragraph" $ runWD $ do
15851325 let preSwitchover = do
15861326 checkBodyText "before\ninner\nafter"
15871327 -- Two <p> tags should be present
@@ -1598,8 +1338,7 @@ tests withDebugging wdConfig caps _selenium = do
15981338 shouldContainText "before\ninner\nafter" p1
15991339 elementShouldBeRemoved ol
16001340 elementShouldBeRemoved p2
1601− -- Don't fail fatally when hydration encounters the invalid DOM
1602− testWidgetDebug' False withDebugging preSwitchover check $ do
1341+ testWidget' preSwitchover check $ do
16031342 -- This is deliberately invalid HTML, the browser will interpret it as
16041343 -- <p>before</p><ol>inner</ol>after<p></p>
16051344 el "p" $ do
@@ -1610,7 +1349,7 @@ tests withDebugging wdConfig caps _selenium = do
16101349 -- TODO: This test presupposes the exact set of labels that "dropdown" places in the "value" fields to distinguish options.
16111350 -- This dependence on internal implementation details is undesirable in a test case, but seems fairly tricky to avoid.
16121351 -- It seems expedient for the time being to expect this test case to be updated, should those implementation details ever change.
1613− session' "dropdown" $ do
1352+ describe "dropdown" $ session' $ do
16141353 let doTest expectedOpts (initialValue :: Text) = do
16151354 let doCheck = do
16161355 es <- findElemsWithRetry $ WD.ByTag "option"
@@ -1725,12 +1464,11 @@ testWidgetStaticDebug
17251464 -> (forall m js. TestWidget js (SpiderTimeline Global) m => m ())
17261465 -- ^ Widget we are testing
17271466 -> WD b
1728−testWidgetStaticDebug withDebugging w = testWidgetDebug True withDebugging (void w) w
1467+testWidgetStaticDebug withDebugging w = testWidgetDebug withDebugging (void w) w
17291468
17301469-- | TODO: do something about JSExceptions not causing tests to fail
17311470testWidgetDebug
17321471 :: Bool
1733− -> Bool
17341472 -> WD ()
17351473 -- ^ Webdriver commands to run before the JS runs (i.e. on the statically rendered page)
17361474 -> WD b
@@ -1738,16 +1476,12 @@ testWidgetDebug
17381476 -> (forall m js. TestWidget js (SpiderTimeline Global) m => m ())
17391477 -- ^ Widget we are testing
17401478 -> WD b
1741−testWidgetDebug hardFailure withDebugging beforeJS afterSwitchover =
1742− testWidgetDebug' hardFailure withDebugging beforeJS (const afterSwitchover)
1743−
1744−data HydrationFailedException = HydrationFailedException deriving Show
1745−instance Exception HydrationFailedException
1479+testWidgetDebug withDebugging beforeJS afterSwitchover =
1480+ testWidgetDebug' withDebugging beforeJS (const afterSwitchover)
17461481
17471482-- | TODO: do something about JSExceptions not causing tests to fail
17481483testWidgetDebug'
17491484 :: Bool
1750− -> Bool
17511485 -> WD a
17521486 -- ^ Webdriver commands to run before the JS runs (i.e. on the statically rendered page)
17531487 -> (a -> WD b)
@@ -1755,7 +1489,7 @@ testWidgetDebug'
17551489 -> (forall m js. TestWidget js (SpiderTimeline Global) m => m ())
17561490 -- ^ Widget we are testing (contents of body)
17571491 -> WD b
1758−testWidgetDebug' hardFailure withDebugging beforeJS afterSwitchover bodyWidget = do
1492+testWidgetDebug' withDebugging beforeJS afterSwitchover bodyWidget = do
17591493 let putStrLnDebug :: MonadIO m => Text -> m ()
17601494 putStrLnDebug m = when withDebugging $ liftIO $ putStrLn $ T.unpack m
17611495 staticApp = do
@@ -1767,7 +1501,6 @@ testWidgetDebug' hardFailure withDebugging beforeJS afterSwitchover bodyWidget =
17671501 ((), html) <- liftIO $ renderStatic $ runHydratableT staticApp
17681502 putStrLnDebug "rendered static"
17691503 waitBeforeJS <- liftIO newEmptyMVar -- Empty until JS should be run
1770− onFailure <- if hardFailure then (`throwTo` HydrationFailedException) <$> liftIO myThreadId else pure $ pure ()
17711504 waitUntilSwitchover <- liftIO newEmptyMVar -- Empty until switchover
17721505 let entryPoint = do
17731506 putStrLnDebug "taking waitBeforeJS"
@@ -1779,7 +1512,7 @@ testWidgetDebug' hardFailure withDebugging beforeJS afterSwitchover bodyWidget =
17791512 liftIO $ putMVar waitUntilSwitchover ()
17801513 putStrLnDebug "put waitUntilSwitchover"
17811514 putStrLnDebug "running mainHydrationWidgetWithSwitchoverAction"
1782− mainHydrationWidgetWithSwitchoverActionWithFailure' onFailure switchOverAction blank bodyWidget
1515+ mainHydrationWidgetWithSwitchoverAction switchOverAction blank bodyWidget
17831516 putStrLnDebug "syncPoint after mainHydrationWidgetWithSwitchoverAction"
17841517 syncPoint
17851518 application <- liftIO $ jsaddleOr defaultConnectionOptions entryPoint $ \_ sendResponse -> do