on develop help sign in
Add contribution guidelines
commitd5d5831a9360ee1a09f9338c14edf2b196d61363 authorAli Abrar <aliabrar@gmail.com> dateFri 29 Mar 2019, 16:01 (8 years ago) parent376cded
1 file changed+57
CONTRIBUTING.md+57
CONTRIBUTING.mdnew file+57
@@ -0,0 +1,57 @@
1+# Contribution Guide
2+
3+Contributions and issue reports are encouraged and appreciated!
4+
5+- [Opening Issues](#opening-issues)
6+- [Submitting Changes](#submitting-changes)
7+ - [Guidelines for Commit Messages](#guidelines-for-commit-messages)
8+ - [Code Quality](#code-quality)
9+ - [Documentation](#documentation)
10+
11+## Opening Issues
12+
13+Before opening an issue, please check whether your issue has already been reported. Assuming it has not:
14+
15+* Describe the issue you're encountering or the suggestion you're making
16+* Include any relevant steps to reproduce or code samples you can. It's always easier for us to debug if we have something that demonstrates the error.
17+* Let us know what version of reflex you were using. If you're using a github checkout, provide the git hash.
18+* Describe how you're building reflex (i.e., via reflex-platform, cabal install, stack, obelisk, etc.). If you're using reflex-platform or obelisk, provide the git hash of your checkout.
19+
20+## Submitting Changes
21+
22+### Guidelines for Commit Messages
23+
24+#### Summary Line
25+The summary line of your commit message should summarize the changes being made. Commit messages should be written in the imperative mood and should describe what happens when the commit is applied.
26+
27+One way to think about it is that your commit message should be able to complete the sentence:
28+"When applied, this commit will..."
29+
30+#### Body
31+For breaking changes, new features, refactors, or other major changes, the body of the commit message should describe the motivation behind the change in greater detail and may include references to the issue tracker. The body shouldn't repeat code/comments from the diff.
32+
33+### Code Quality
34+
35+#### Warnings
36+
37+Your pull request should add no new warnings to the project. It should also generally not disable any warnings.
38+
39+#### Build and Test
40+
41+Make sure the project builds and that the tests pass! This will generally also be checked by CI before merge, but trying it yourself first means you'll catch problems earlier and your contribution can be merged that much sooner!
42+
43+### Documentation
44+
45+#### In the code
46+We're always striving to improve documentation. Please include [haddock](https://haskell-haddock.readthedocs.io/en/latest/index.html) documentation for any added code, and update the documentation for any code you modify.
47+
48+#### In the [Changelog](ChangeLog.md)
49+Add an entry to the changelog when your PR:
50+* Adds a feature
51+* Deprecates something
52+* Includes a breaking change
53+* Makes any other change that will impact users
54+
55+#### In the [Readme](README.md)
56+The readme is the first place a lot of people look for information about the repository. Update any parts of the readme that are affected by your PR.
57+