@@ -9,8 +9,6 @@
99{-# LANGUAGE GADTs #-}
1010{-# LANGUAGE GeneralizedNewtypeDeriving #-}
1111{-# LANGUAGE LambdaCase #-}
12−{-# LANGUAGE MultiParamTypeClasses #-}
13−{-# LANGUAGE MultiWayIf #-}
1412{-# LANGUAGE RankNTypes #-}
1513{-# LANGUAGE RoleAnnotations #-}
1614{-# LANGUAGE ScopedTypeVariables #-}
@@ -18,7 +16,11 @@
1816{-# LANGUAGE TypeOperators #-}
1917{-# LANGUAGE UndecidableInstances #-}
2018{-# LANGUAGE PolyKinds #-}
19+{-# LANGUAGE DeriveFunctor #-}
20+{-# LANGUAGE StandaloneDeriving #-}
2121{-# LANGUAGE InstanceSigs #-}
22+{-# LANGUAGE MultiWayIf #-}
23+
2224#ifdef USE_REFLEX_OPTIMIZER
2325{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
2426#endif
@@ -36,12 +38,17 @@ import Control.Monad hiding (forM, forM_, mapM, mapM_)
3638import Control.Monad.Exception
3739import Control.Monad.Identity hiding (forM, forM_, mapM, mapM_)
3840import Control.Monad.Primitive
39−import Control.Monad.Reader hiding (forM, forM_, mapM, mapM_)
41+import Control.Monad.Reader.Class
42+import Control.Monad.IO.Class
43+import Control.Monad.ReaderIO
4044import Control.Monad.Ref
45+import Control.Monad.Fail (MonadFail)
46+import qualified Control.Monad.Fail as MonadFail
4147import Data.Align
4248import Data.Coerce
43−import Data.Dependent.Map (DMap, DSum (..))
49+import Data.Dependent.Map (DMap)
4450import qualified Data.Dependent.Map as DMap
51+import Data.Dependent.Sum (DSum (..))
4552import Data.FastMutableIntMap (FastMutableIntMap, PatchIntMap (..))
4653import qualified Data.FastMutableIntMap as FastMutableIntMap
4754import Data.Foldable hiding (concat, elem, sequence_)
@@ -54,12 +61,13 @@ import qualified Data.IntMap.Strict as IntMap
5461import Data.IORef
5562import Data.Kind (Type)
5663import Data.Maybe hiding (mapMaybe)
57−import Data.Monoid ((<>))
64+import Data.Monoid (mempty, (<>))
5865import Data.Proxy
5966import Data.These
6067import Data.Traversable
68+import Data.Type.Equality ((:~:)(Refl))
6169import Data.Witherable (Filterable, mapMaybe)
62−import GHC.Exts
70+import GHC.Exts hiding (toList)
6371import GHC.IORef (IORef (..))
6472import GHC.Stack
6573import Reflex.FastWeak
@@ -67,19 +75,29 @@ import System.IO.Unsafe
6775import System.Mem.Weak
6876import Unsafe.Coerce
6977
78+#ifdef MIN_VERSION_semialign
79+#if MIN_VERSION_these(0,8,0)
80+import Data.These.Combinators (justThese)
81+#endif
82+#if MIN_VERSION_semialign(1,1,0)
83+import Data.Zip (Zip (..))
84+#endif
85+#endif
86+
7087#ifdef DEBUG_CYCLES
7188import Control.Monad.State hiding (forM, forM_, mapM, mapM_, sequence)
89+#endif
90+
7291import Data.List.NonEmpty (NonEmpty (..), nonEmpty)
7392import qualified Data.List.NonEmpty as NonEmpty
74−import Data.Monoid (mempty)
7593import Data.Tree (Forest, Tree (..), drawForest)
76−#endif
94+import Data.List (isPrefixOf)
7795
78−import Data.FastWeakBag (FastWeakBag)
96+import Data.FastWeakBag (FastWeakBag, FastWeakBagTicket)
7997import qualified Data.FastWeakBag as FastWeakBag
98+
8099import Data.Reflection
81−import Data.Some (Some)
82−import qualified Data.Some as Some
100+import Data.Some (Some(Some))
83101import Data.Type.Coercion
84102import Data.Profunctor.Unsafe ((#.), (.#))
85103import Data.WeakBag (WeakBag, WeakBagTicket, _weakBag_children)
@@ -88,20 +106,26 @@ import qualified Reflex.Class
88106import qualified Reflex.Class as R
89107import qualified Reflex.Host.Class
90108import Reflex.NotReady.Class
91−import Reflex.Patch
92−import qualified Reflex.Patch.DMapWithMove as PatchDMapWithMove
109+import Data.Patch
110+import qualified Data.Patch.DMapWithMove as PatchDMapWithMove
111+import Reflex.PerformEvent.Base (PerformEventT)
93112
94113#ifdef DEBUG_TRACE_EVENTS
95114import qualified Data.ByteString.Char8 as BS8
96115import System.IO (stderr)
116+import Data.List (isPrefixOf)
97117#endif
98118
99−#ifdef DEBUG_TRACE_EVENTS
119+-- TODO stdout might not be the best channel for debug output
120+debugStrLn :: String -> IO ()
121+debugStrLn = putStrLn
100122
123+#ifdef DEBUG_TRACE_EVENTS
101124withStackOneLine :: (BS8.ByteString -> a) -> a
102125withStackOneLine expr = unsafePerformIO $ do
103126 stack <- currentCallStack
104− return (expr (BS8.pack (unwords (reverse stack))))
127+ return (expr . BS8.pack . unwords . dropInternal . reverse $ stack)
128+ where dropInternal = filterStack "Reflex.Spider.Internal"
105129
106130#endif
107131
@@ -112,28 +136,42 @@ debugInvalidateHeight :: Bool
112136debugInvalidate :: Bool
113137
114138#ifdef DEBUG
115−
116139#define DEBUG_NODEIDS
117140
141+#ifdef DEBUG_TRACE_PROPAGATION
118142debugPropagate = True
143+#else
144+debugPropagate = False
145+#endif
119146
147+#ifdef DEBUG_TRACE_HEIGHT
148+debugInvalidateHeight = True
149+#else
120150debugInvalidateHeight = False
151+#endif
121152
153+#ifdef DEBUG_TRACE_INVALIDATION
122154debugInvalidate = True
155+#else
156+debugInvalidate = False
157+#endif
123158
124159class HasNodeId a where
125160 getNodeId :: a -> Int
126161
127−instance HasNodeId (Hold x p a) where
128− getNodeId = holdNodeId
162+instance HasNodeId (CacheSubscribed x a) where
163+ getNodeId = _cacheSubscribed_nodeId
164+
165+instance HasNodeId (FanInt x a) where
166+ getNodeId = _fanInt_nodeId
129167
130−instance HasNodeId (PushSubscribed x a b) where
131− getNodeId = pushSubscribedNodeId
168+instance HasNodeId (Hold x p) where
169+ getNodeId = holdNodeId
132170
133171instance HasNodeId (SwitchSubscribed x a) where
134172 getNodeId = switchSubscribedNodeId
135173
136−instance HasNodeId (FanSubscribed x a) where
174+instance HasNodeId (FanSubscribed x v a) where
137175 getNodeId = fanSubscribedNodeId
138176
139177instance HasNodeId (CoincidenceSubscribed x a) where
@@ -147,41 +185,16 @@ instance HasNodeId (Pull x a) where
147185
148186{-# INLINE showNodeId #-}
149187showNodeId :: HasNodeId a => a -> String
150−showNodeId = ("#"<>) . show . getNodeId
151−
152−showSubscriberType :: Subscriber x a -> String
153−showSubscriberType = \case
154− SubscriberPush _ _ -> "SubscriberPush"
155− SubscriberMerge _ _ -> "SubscriberMerge"
156− SubscriberFan _ -> "SubscriberFan"
157− SubscriberMergeChange _ -> "SubscriberMergeChange"
158− SubscriberHold _ -> "SubscriberHold"
159− SubscriberHoldIdentity _ -> "SubscriberHoldIdentity"
160− SubscriberSwitch _ -> "SubscriberSwitch"
161− SubscriberCoincidenceOuter _ -> "SubscriberCoincidenceOuter"
162− SubscriberCoincidenceInner _ -> "SubscriberCoincidenceInner"
163− SubscriberHandle -> "SubscriberHandle"
164−
165−showEventType :: Event x a -> String
166−showEventType = \case
167− EventRoot _ _ -> "EventRoot"
168− EventNever -> "EventNever"
169− EventPush _ -> "EventPush"
170− EventMerge _ -> "EventMerge"
171− EventFan _ _ -> "EventFan"
172− EventSwitch _ -> "EventSwitch"
173− EventCoincidence _ -> "EventCoincidence"
174− EventHold _ -> "EventHold"
175− EventDyn _ -> "EventDyn"
176− EventHoldIdentity _ -> "EventHoldIdentity"
177− EventDynIdentity _ -> "EventDynIdentity"
188+showNodeId = showNodeId' . getNodeId
189+
190+showNodeId' :: Int -> String
191+showNodeId' = ("#"<>) . show
192+
178193
179194#else
180195
181196debugPropagate = False
182−
183197debugInvalidateHeight = False
184−
185198debugInvalidate = False
186199
187200-- This must be inline, or error messages will cause memory leaks due to retaining the node in question
@@ -189,6 +202,10 @@ debugInvalidate = False
189202showNodeId :: a -> String
190203showNodeId _ = ""
191204
205+{-# INLINE showNodeId' #-}
206+showNodeId' :: Int -> String
207+showNodeId' _ = ""
208+
192209#endif
193210
194211#ifdef DEBUG_NODEIDS
@@ -198,12 +215,6 @@ nextNodeIdRef = unsafePerformIO $ newIORef 1
198215
199216newNodeId :: IO Int
200217newNodeId = atomicModifyIORef' nextNodeIdRef $ \n -> (succ n, n)
201−
202−{-# NOINLINE unsafeNodeId #-}
203−unsafeNodeId :: a -> Int
204−unsafeNodeId a = unsafePerformIO $ do
205− touch a
206− newNodeId
207218#endif
208219
209220--------------------------------------------------------------------------------
@@ -240,9 +251,9 @@ subscribeAndRead = unEvent
240251-- caching; if the computation function is very cheap, this is (much) more
241252-- efficient than 'push'
242253{-# INLINE [1] pushCheap #-}
243−pushCheap :: (a -> ComputeM x (Maybe b)) -> Event x a -> Event x b
254+pushCheap :: HasSpiderTimeline x => (a -> ComputeM x (Maybe b)) -> Event x a -> Event x b
244255pushCheap !f e = Event $ \sub -> do
245− (subscription, occ) <- subscribeAndRead e $ sub
256+ (subscription, occ) <- subscribeAndRead e $ debugSubscriber' "push" $ sub
246257 { subscriberPropagate = \a -> do
247258 mb <- f a
248259 mapM_ (subscriberPropagate sub) mb
@@ -261,10 +272,10 @@ terminalSubscriber p = Subscriber
261272
262273-- | Subscribe to an Event only for the duration of one occurrence
263274{-# INLINE subscribeAndReadHead #-}
264−subscribeAndReadHead :: Event x a -> Subscriber x a -> EventM x (EventSubscription x, Maybe a)
275+subscribeAndReadHead :: HasSpiderTimeline x => Event x a -> Subscriber x a -> EventM x (EventSubscription x, Maybe a)
265276subscribeAndReadHead e sub = do
266277 subscriptionRef <- liftIO $ newIORef $ error "subscribeAndReadHead: not initialized"
267− (subscription, occ) <- subscribeAndRead e $ sub
278+ (subscription, occ) <- subscribeAndRead e $ debugSubscriber' "head" $ sub
268279 { subscriberPropagate = \a -> do
269280 liftIO $ unsubscribe =<< readIORef subscriptionRef
270281 subscriberPropagate sub a
@@ -275,24 +286,42 @@ subscribeAndReadHead e sub = do
275286 return (subscription, occ)
276287
277288--TODO: Make this lazy in its input event
278−headE :: (MonadIO m, Defer (SomeMergeInit x) m) => Event x a -> m (Event x a)
289+headE :: (MonadIO m, Defer (SomeMergeInit x) m, HasSpiderTimeline x) => Event x a -> m (Event x a)
279290headE originalE = do
280291 parent <- liftIO $ newIORef $ Just originalE
281292 defer $ SomeMergeInit $ do --TODO: Rename SomeMergeInit appropriately
282293 let clearParent = liftIO $ writeIORef parent Nothing
283− (_, occ) <- subscribeAndReadHead originalE $ terminalSubscriber $ \_ -> clearParent
294+ (_, occ) <- subscribeAndReadHead originalE $ terminalSubscriber $ const clearParent
284295 when (isJust occ) clearParent
285− return $ Event $ \sub -> do
296+ return $ Event $ \sub ->
286297 liftIO (readIORef parent) >>= \case
287− Nothing -> return (EventSubscription (return ()) $ EventSubscribed zeroRef $ toAny (), Nothing)
298+ Nothing -> subscribeAndReadNever
288299 Just e -> subscribeAndReadHead e sub
289300
290301data CacheSubscribed x a
291302 = CacheSubscribed { _cacheSubscribed_subscribers :: {-# UNPACK #-} !(FastWeakBag (Subscriber x a))
292303 , _cacheSubscribed_parent :: {-# UNPACK #-} !(EventSubscription x)
293304 , _cacheSubscribed_occurrence :: {-# UNPACK #-} !(IORef (Maybe a))
305+#ifdef DEBUG_NODEIDS
306+ , _cacheSubscribed_nodeId :: {-# UNPACK #-} !Int
307+#endif
294308 }
295309
310+nowSpiderEventM :: (HasSpiderTimeline x) => EventM x (R.Event (SpiderTimeline x) ())
311+nowSpiderEventM =
312+ SpiderEvent <$> now
313+
314+now :: (MonadIO m, Defer (Some Clear) m, HasSpiderTimeline x
315+ ) => m (Event x ())
316+now = do
317+ nowOrNot <- liftIO $ newIORef $ Just ()
318+ scheduleClear nowOrNot
319+ return . Event $ \_ -> do
320+ occ <- liftIO . readIORef $ nowOrNot
321+ return ( EventSubscription (return ()) eventSubscribedNow
322+ , occ
323+ )
324+
296325-- | Construct an 'Event' whose value is guaranteed not to be recomputed
297326-- repeatedly
298327--
@@ -307,27 +336,33 @@ cacheEvent e =
307336#else
308337 Event $
309338#endif
310− let mSubscribedRef :: IORef (FastWeak (CacheSubscribed x a))
311− !mSubscribedRef = unsafeNewIORef e emptyFastWeak
312− in \sub -> {-# SCC "cacheEvent" #-} do
339+ unsafePerformIO $ do
340+ mSubscribedRef :: IORef (FastWeak (CacheSubscribed x a))
341+ <- newIORef emptyFastWeak
342+ pure $ \sub -> {-# SCC "cacheEvent" #-} do
313343#ifdef DEBUG_TRACE_EVENTS
314344 unless (BS8.null callSite) $ liftIO $ BS8.hPutStrLn stderr callSite
315345#endif
316346 subscribedTicket <- liftIO (readIORef mSubscribedRef >>= getFastWeakTicket) >>= \case
317347 Just subscribedTicket -> return subscribedTicket
318348 Nothing -> do
349+#ifdef DEBUG_NODEIDS
350+ nodeId <- liftIO newNodeId
351+#endif
319352 subscribers <- liftIO FastWeakBag.empty
320353 occRef <- liftIO $ newIORef Nothing -- This should never be read prior to being set below
354+#ifdef DEBUG_NODEIDS
355+ (parentSub, occ) <- subscribeAndRead e $ debugSubscriber' ("cacheEvent" <> showNodeId' nodeId) $ Subscriber
356+#else
321357 (parentSub, occ) <- subscribeAndRead e $ Subscriber
322− { subscriberPropagate = \a -> do
323− liftIO $ writeIORef occRef $ Just a
324− scheduleClear occRef
325− propagateFast a subscribers
326− , subscriberInvalidateHeight = \old -> do
327− FastWeakBag.traverse subscribers $ invalidateSubscriberHeight old
328− , subscriberRecalculateHeight = \new -> do
329− FastWeakBag.traverse subscribers $ recalculateSubscriberHeight new
330− }
358+#endif
359+ { subscriberPropagate = \a -> do
360+ liftIO $ writeIORef occRef (Just a)
361+ scheduleClear occRef
362+ propagateFast a subscribers
363+ , subscriberInvalidateHeight = FastWeakBag.traverse_ subscribers . invalidateSubscriberHeight
364+ , subscriberRecalculateHeight = FastWeakBag.traverse_ subscribers . recalculateSubscriberHeight
365+ }
331366 when (isJust occ) $ do
332367 liftIO $ writeIORef occRef occ -- Set the initial value of occRef; we don't need to do this if occ is Nothing
333368 scheduleClear occRef
@@ -335,29 +370,45 @@ cacheEvent e =
335370 { _cacheSubscribed_subscribers = subscribers
336371 , _cacheSubscribed_parent = parentSub
337372 , _cacheSubscribed_occurrence = occRef
373+#ifdef DEBUG_NODEIDS
374+ , _cacheSubscribed_nodeId = nodeId
375+#endif
338376 }
339377 subscribedTicket <- liftIO $ mkFastWeakTicket subscribed
340378 liftIO $ writeIORef mSubscribedRef =<< getFastWeakTicketWeak subscribedTicket
341379 return subscribedTicket
342− liftIO $ do
343− subscribed <- getFastWeakTicketValue subscribedTicket
344− ticket <- FastWeakBag.insert sub $ _cacheSubscribed_subscribers subscribed
345− occ <- readIORef $ _cacheSubscribed_occurrence subscribed
346− let es = EventSubscription
347− { _eventSubscription_unsubscribe = do
348− FastWeakBag.remove ticket
349− isEmpty <- FastWeakBag.isEmpty $ _cacheSubscribed_subscribers subscribed
350− when isEmpty $ do
351− writeIORef mSubscribedRef emptyFastWeak
352− unsubscribe $ _cacheSubscribed_parent subscribed
353− touch ticket
354− touch subscribedTicket
355− , _eventSubscription_subscribed = EventSubscribed
356− { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed $ _cacheSubscribed_parent subscribed
357− , eventSubscribedRetained = toAny subscribedTicket
358− }
359− }
360− return (es, occ)
380+ liftIO $ cacheSubscription sub mSubscribedRef subscribedTicket
381+
382+cacheSubscription :: Subscriber x a -> IORef (FastWeak (CacheSubscribed x a))
383+ -> FastWeakTicket (CacheSubscribed x a) -> IO (EventSubscription x, Maybe a)
384+cacheSubscription sub mSubscribedRef subscribedTicket = do
385+ subscribed <- getFastWeakTicketValue subscribedTicket
386+ ticket <- FastWeakBag.insert sub $ _cacheSubscribed_subscribers subscribed
387+ occ <- readIORef $ _cacheSubscribed_occurrence subscribed
388+
389+ let parentSub = _cacheSubscribed_parent subscribed
390+ es = EventSubscription
391+ { _eventSubscription_unsubscribe = do
392+ FastWeakBag.remove ticket
393+
394+ isEmpty <- FastWeakBag.isEmpty $ _cacheSubscribed_subscribers subscribed
395+ when isEmpty $ do
396+ writeIORef mSubscribedRef emptyFastWeak
397+ unsubscribe parentSub
398+ touch ticket
399+ touch subscribedTicket
400+ , _eventSubscription_subscribed = EventSubscribed
401+ { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed parentSub
402+ , eventSubscribedRetained = toAny subscribedTicket
403+#ifdef DEBUG_CYCLES
404+ , eventSubscribedGetParents = return [_eventSubscription_subscribed parentSub]
405+ , eventSubscribedHasOwnHeightRef = False
406+ , eventSubscribedWhoCreated = whoCreatedIORef mSubscribedRef
407+#endif
408+ }
409+ }
410+ return (es, occ)
411+
361412
362413subscribe :: Event x a -> Subscriber x a -> EventM x (EventSubscription x)
363414subscribe e s = fst <$> subscribeAndRead e s
@@ -369,13 +420,16 @@ wrap tag getSpecificSubscribed sub = do
369420 let es = tag subd
370421 return (EventSubscription (WeakBag.remove sln >> touch sln) es, occ)
371422
372−eventRoot :: GCompare k => k a -> Root x k -> Event x a
423+eventRoot :: (GCompare k, HasSpiderTimeline x) => k a -> Root x k -> Event x a
373424eventRoot !k !r = Event $ wrap eventSubscribedRoot $ liftIO . getRootSubscribed k r
374425
426+subscribeAndReadNever :: EventM x (EventSubscription x, Maybe a)
427+subscribeAndReadNever = return (EventSubscription (return ()) eventSubscribedNever, Nothing)
428+
375429eventNever :: Event x a
376−eventNever = Event $ \_ -> return (EventSubscription (return ()) eventSubscribedNever, Nothing)
430+eventNever = Event $ const subscribeAndReadNever
377431
378−eventFan :: (GCompare k, HasSpiderTimeline x) => k a -> Fan x k -> Event x a
432+eventFan :: (GCompare k, HasSpiderTimeline x) => k a -> Fan x k v -> Event x (v a)
379433eventFan !k !f = Event $ wrap eventSubscribedFan $ getFanSubscribed k f
380434
381435eventSwitch :: HasSpiderTimeline x => Switch x a -> Event x a
@@ -410,16 +464,6 @@ data Subscriber x a = Subscriber
410464 , subscriberRecalculateHeight :: !(Height -> IO ())
411465 }
412466
413−--TODO: Move this comment to WeakBag
414−-- These function are constructor functions that are marked NOINLINE so they are
415−-- opaque to GHC. If we do not do this, then GHC will sometimes fuse the constructor away
416−-- so any weak references that are attached to the constructors will have their
417−-- finalizer run. Using the opaque constructor, does not see the
418−-- constructor application, so it behaves like an IORef and cannot be fused away.
419−--
420−-- The result is also evaluated to WHNF, since forcing a thunk invalidates
421−-- the weak pointer to it in some cases.
422−
423467newSubscriberHold :: (HasSpiderTimeline x, Patch p) => Hold x p -> IO (Subscriber x p)
424468newSubscriberHold h = return $ Subscriber
425469 { subscriberPropagate = {-# SCC "traverseHold" #-} propagateSubscriberHold h
@@ -427,85 +471,68 @@ newSubscriberHold h = return $ Subscriber
427471 , subscriberRecalculateHeight = \_ -> return ()
428472 }
429473
430−newSubscriberFan :: forall x k. (HasSpiderTimeline x, GCompare k) => FanSubscribed x k -> IO (Subscriber x (DMap k Identity))
431−newSubscriberFan subscribed = return $ Subscriber
474+newSubscriberFan :: forall x k v. (HasSpiderTimeline x, GCompare k) => FanSubscribed x k v -> IO (Subscriber x (DMap k v))
475+newSubscriberFan subscribed = debugSubscriber ("SubscriberFan " <> showNodeId subscribed) $ Subscriber
432476 { subscriberPropagate = \a -> {-# SCC "traverseFan" #-} do
433477 subs <- liftIO $ readIORef $ fanSubscribedSubscribers subscribed
434− tracePropagate (Proxy :: Proxy x) $ "SubscriberFan" <> showNodeId subscribed <> ": " ++ show (DMap.size subs) ++ " keys subscribed, " ++ show (DMap.size a) ++ " keys firing"
478+ tracePropagate (Proxy :: Proxy x) $ show (DMap.size subs) <> " keys subscribed, " <> show (DMap.size a) <> " keys firing"
435479 liftIO $ writeIORef (fanSubscribedOccurrence subscribed) $ Just a
436480 scheduleClear $ fanSubscribedOccurrence subscribed
437− let f _ (Pair (Identity v) subsubs) = do
481+ let f _ (Pair v subsubs) = do
438482 propagate v $ _fanSubscribedChildren_list subsubs
439483 return $ Constant ()
440484 _ <- DMap.traverseWithKey f $ DMap.intersectionWithKey (\_ -> Pair) a subs --TODO: Would be nice to have DMap.traverse_
441485 return ()
442486 , subscriberInvalidateHeight = \old -> do
443− when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberFan" <> showNodeId subscribed
444487 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
445− forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse (_fanSubscribedChildren_list v) $ invalidateSubscriberHeight old
446− when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberFan" <> showNodeId subscribed <> " done"
488+ forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse_ (_fanSubscribedChildren_list v) $ invalidateSubscriberHeight old
447489 , subscriberRecalculateHeight = \new -> do
448− when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberFan" <> showNodeId subscribed
449490 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
450− forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse (_fanSubscribedChildren_list v) $ recalculateSubscriberHeight new
451− when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberFan" <> showNodeId subscribed <> " done"
491+ forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse_ (_fanSubscribedChildren_list v) $ recalculateSubscriberHeight new
452492 }
453493
454494newSubscriberSwitch :: forall x a. HasSpiderTimeline x => SwitchSubscribed x a -> IO (Subscriber x a)
455−newSubscriberSwitch subscribed = return $ Subscriber
495+newSubscriberSwitch subscribed = debugSubscriber ("SubscriberCoincidenceOuter" <> showNodeId subscribed) $ Subscriber
456496 { subscriberPropagate = \a -> {-# SCC "traverseSwitch" #-} do
457− tracePropagate (Proxy :: Proxy x) $ "SubscriberSwitch" <> showNodeId subscribed
458497 liftIO $ writeIORef (switchSubscribedOccurrence subscribed) $ Just a
459498 scheduleClear $ switchSubscribedOccurrence subscribed
460499 propagate a $ switchSubscribedSubscribers subscribed
461500 , subscriberInvalidateHeight = \_ -> do
462− when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed
463501 oldHeight <- readIORef $ switchSubscribedHeight subscribed
464502 when (oldHeight /= invalidHeight) $ do
465503 writeIORef (switchSubscribedHeight subscribed) $! invalidHeight
466− WeakBag.traverse (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
467− when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed <> " done"
468− , subscriberRecalculateHeight = \new -> do
469− when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed
470− updateSwitchHeight new subscribed
471− when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed <> " done"
472− }
504+ WeakBag.traverse_ (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
505+ , subscriberRecalculateHeight = (`updateSwitchHeight` subscribed)
506+ }
473507
474508newSubscriberCoincidenceOuter :: forall x b. HasSpiderTimeline x => CoincidenceSubscribed x b -> IO (Subscriber x (Event x b))
475−newSubscriberCoincidenceOuter subscribed = return $ Subscriber
509+newSubscriberCoincidenceOuter subscribed = debugSubscriber ("SubscriberCoincidenceOuter" <> showNodeId subscribed) $ Subscriber
476510 { subscriberPropagate = \a -> {-# SCC "traverseCoincidenceOuter" #-} do
477− tracePropagate (Proxy :: Proxy x) $ "SubscriberCoincidenceOuter" <> showNodeId subscribed
478511 outerHeight <- liftIO $ readIORef $ coincidenceSubscribedHeight subscribed
479512 tracePropagate (Proxy :: Proxy x) $ " outerHeight = " <> show outerHeight
480513 (occ, innerHeight, innerSubd) <- subscribeCoincidenceInner a outerHeight subscribed
481514 tracePropagate (Proxy :: Proxy x) $ " isJust occ = " <> show (isJust occ)
482515 tracePropagate (Proxy :: Proxy x) $ " innerHeight = " <> show innerHeight
516+
483517 liftIO $ writeIORef (coincidenceSubscribedInnerParent subscribed) $ Just innerSubd
484518 scheduleClear $ coincidenceSubscribedInnerParent subscribed
485519 case occ of
486− Nothing -> do
520+ Nothing ->
487521 when (innerHeight > outerHeight) $ liftIO $ do -- If the event fires, it will fire at a later height
488522 writeIORef (coincidenceSubscribedHeight subscribed) $! innerHeight
489− WeakBag.traverse (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight outerHeight
490− WeakBag.traverse (coincidenceSubscribedSubscribers subscribed) $ recalculateSubscriberHeight innerHeight
523+ WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight outerHeight
524+ WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ recalculateSubscriberHeight innerHeight
491525 Just o -> do -- Since it's already firing, no need to adjust height
492526 liftIO $ writeIORef (coincidenceSubscribedOccurrence subscribed) occ
493527 scheduleClear $ coincidenceSubscribedOccurrence subscribed
494528 propagate o $ coincidenceSubscribedSubscribers subscribed
495− , subscriberInvalidateHeight = \_ -> do
496− when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed
497− invalidateCoincidenceHeight subscribed
498− when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed <> " done"
499− , subscriberRecalculateHeight = \_ -> do
500− when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed
501− recalculateCoincidenceHeight subscribed
502− when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed <> " done"
529+ , subscriberInvalidateHeight = \_ -> invalidateCoincidenceHeight subscribed
530+ , subscriberRecalculateHeight = \_ -> recalculateCoincidenceHeight subscribed
503531 }
504532
505533newSubscriberCoincidenceInner :: forall x a. HasSpiderTimeline x => CoincidenceSubscribed x a -> IO (Subscriber x a)
506−newSubscriberCoincidenceInner subscribed = return $ Subscriber
534+newSubscriberCoincidenceInner subscribed = debugSubscriber ("SubscriberCoincidenceInner" <> showNodeId subscribed) $ Subscriber
507535 { subscriberPropagate = \a -> {-# SCC "traverseCoincidenceInner" #-} do
508− tracePropagate (Proxy :: Proxy x) $ "SubscriberCoincidenceInner" <> showNodeId subscribed
509536 occ <- liftIO $ readIORef $ coincidenceSubscribedOccurrence subscribed
510537 case occ of
511538 Just _ -> return () -- SubscriberCoincidenceOuter must have already propagated this event
@@ -513,14 +540,8 @@ newSubscriberCoincidenceInner subscribed = return $ Subscriber
513540 liftIO $ writeIORef (coincidenceSubscribedOccurrence subscribed) $ Just a
514541 scheduleClear $ coincidenceSubscribedOccurrence subscribed
515542 propagate a $ coincidenceSubscribedSubscribers subscribed
516− , subscriberInvalidateHeight = \_ -> do
517− when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed
518− invalidateCoincidenceHeight subscribed
519− when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed <> " done"
520− , subscriberRecalculateHeight = \_ -> do
521− when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed
522− recalculateCoincidenceHeight subscribed
523− when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed <> " done"
543+ , subscriberInvalidateHeight = \_ -> invalidateCoincidenceHeight subscribed
544+ , subscriberRecalculateHeight = \_ -> recalculateCoincidenceHeight subscribed
524545 }
525546
526547invalidateSubscriberHeight :: Height -> Subscriber x a -> IO ()
@@ -530,18 +551,18 @@ recalculateSubscriberHeight :: Height -> Subscriber x a -> IO ()
530551recalculateSubscriberHeight = flip subscriberRecalculateHeight
531552
532553-- | Propagate everything at the current height
533−propagate :: a -> WeakBag (Subscriber x a) -> EventM x ()
534−propagate a subscribers = withIncreasedDepth $ do
554+propagate :: forall x a. HasSpiderTimeline x => a -> WeakBag (Subscriber x a) -> EventM x ()
555+propagate a subscribers = withIncreasedDepth (Proxy::Proxy x) $
535556 -- Note: in the following traversal, we do not visit nodes that are added to the list during our traversal; they are new events, which will necessarily have full information already, so there is no need to traverse them
536557 --TODO: Should we check if nodes already have their values before propagating? Maybe we're re-doing work
537− WeakBag.traverse subscribers $ \s -> subscriberPropagate s a
558+ WeakBag.traverse_ subscribers $ \s -> subscriberPropagate s a
538559
539560-- | Propagate everything at the current height
540−propagateFast :: a -> FastWeakBag (Subscriber x a) -> EventM x ()
541−propagateFast a subscribers = withIncreasedDepth $ do
561+propagateFast :: forall x a. HasSpiderTimeline x => a -> FastWeakBag (Subscriber x a) -> EventM x ()
562+propagateFast a subscribers = withIncreasedDepth (Proxy::Proxy x) $
542563 -- Note: in the following traversal, we do not visit nodes that are added to the list during our traversal; they are new events, which will necessarily have full information already, so there is no need to traverse them
543564 --TODO: Should we check if nodes already have their values before propagating? Maybe we're re-doing work
544− FastWeakBag.traverse subscribers $ \s -> subscriberPropagate s a
565+ FastWeakBag.traverse_ subscribers $ \s -> subscriberPropagate s a
545566
546567--------------------------------------------------------------------------------
547568-- EventSubscribed
@@ -550,11 +571,16 @@ propagateFast a subscribers = withIncreasedDepth $ do
550571toAny :: a -> Any
551572toAny = unsafeCoerce
552573
574+-- Why do we use Any here, instead of just giving eventSubscribedRetained an
575+-- existential type? Sadly, GHC does not currently know how to unbox types
576+-- with existentially quantified fields. So instead we just coerce values
577+-- to type Any on the way in. Since we never coerce them back, this is
578+-- perfectly safe.
553579data EventSubscribed x = EventSubscribed
554580 { eventSubscribedHeightRef :: {-# UNPACK #-} !(IORef Height)
555581 , eventSubscribedRetained :: {-# NOUNPACK #-} !Any
556582#ifdef DEBUG_CYCLES
557− , eventSubscribedGetParents :: !(IO [Some (EventSubscribed x)]) -- For debugging loops
583+ , eventSubscribedGetParents :: !(IO [EventSubscribed x]) -- For debugging loops
558584 , eventSubscribedHasOwnHeightRef :: !Bool
559585 , eventSubscribedWhoCreated :: !(IO [String])
560586#endif
@@ -581,13 +607,23 @@ eventSubscribedNever = EventSubscribed
581607 , eventSubscribedWhoCreated = return ["never"]
582608#endif
583609 }
610+eventSubscribedNow :: EventSubscribed x
611+eventSubscribedNow = EventSubscribed
612+ { eventSubscribedHeightRef = zeroRef
613+ , eventSubscribedRetained = toAny ()
614+#ifdef DEBUG_CYCLES
615+ , eventSubscribedGetParents = return []
616+ , eventSubscribedHasOwnHeightRef = False
617+ , eventSubscribedWhoCreated = return ["now"]
618+#endif
619+ }
584620
585−eventSubscribedFan :: FanSubscribed x k -> EventSubscribed x
621+eventSubscribedFan :: FanSubscribed x k v -> EventSubscribed x
586622eventSubscribedFan !subscribed = EventSubscribed
587623 { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed $ fanSubscribedParent subscribed
588624 , eventSubscribedRetained = toAny subscribed
589625#ifdef DEBUG_CYCLES
590− , eventSubscribedGetParents = return [Some.This $ _eventSubscription_subscribed $ fanSubscribedParent subscribed]
626+ , eventSubscribedGetParents = return [_eventSubscription_subscribed $ fanSubscribedParent subscribed]
591627 , eventSubscribedHasOwnHeightRef = False
592628 , eventSubscribedWhoCreated = whoCreatedIORef $ fanSubscribedCachedSubscribed subscribed
593629#endif
@@ -600,7 +636,7 @@ eventSubscribedSwitch !subscribed = EventSubscribed
600636#ifdef DEBUG_CYCLES
601637 , eventSubscribedGetParents = do
602638 s <- readIORef $ switchSubscribedCurrentParent subscribed
603− return [Some.This $ _eventSubscription_subscribed s]
639+ return [_eventSubscription_subscribed s]
604640 , eventSubscribedHasOwnHeightRef = True
605641 , eventSubscribedWhoCreated = whoCreatedIORef $ switchSubscribedCachedSubscribed subscribed
606642#endif
@@ -613,8 +649,8 @@ eventSubscribedCoincidence !subscribed = EventSubscribed
613649#ifdef DEBUG_CYCLES
614650 , eventSubscribedGetParents = do
615651 innerSubscription <- readIORef $ coincidenceSubscribedInnerParent subscribed
616− let outerParent = Some.This $ _eventSubscription_subscribed $ coincidenceSubscribedOuterParent subscribed
617− innerParents = maybeToList $ fmap Some.This innerSubscription
652+ let outerParent = _eventSubscription_subscribed $ coincidenceSubscribedOuterParent subscribed
653+ innerParents = maybeToList $ innerSubscription
618654 return $ outerParent : innerParents
619655 , eventSubscribedHasOwnHeightRef = True
620656 , eventSubscribedWhoCreated = whoCreatedIORef $ coincidenceSubscribedCachedSubscribed subscribed
@@ -628,15 +664,15 @@ getEventSubscribedHeight es = readIORef $ eventSubscribedHeightRef es
628664whoCreatedEventSubscribed :: EventSubscribed x -> IO [String]
629665whoCreatedEventSubscribed = eventSubscribedWhoCreated
630666
631−walkInvalidHeightParents :: EventSubscribed x -> IO [Some (EventSubscribed x)]
667+walkInvalidHeightParents :: EventSubscribed x -> IO [EventSubscribed x]
632668walkInvalidHeightParents s0 = do
633− subscribers <- flip execStateT mempty $ ($ Some.This s0) $ fix $ \loop (Some.This s) -> do
669+ subscribers <- flip execStateT mempty $ ($ s0) $ fix $ \loop s -> do
634670 h <- liftIO $ readIORef $ eventSubscribedHeightRef s
635671 when (h == invalidHeight) $ do
636672 when (eventSubscribedHasOwnHeightRef s) $ liftIO $ writeIORef (eventSubscribedHeightRef s) $! invalidHeightBeingTraversed
637− modify (Some.This s :)
673+ modify (s :)
638674 mapM_ loop =<< liftIO (eventSubscribedGetParents s)
639− forM_ subscribers $ \(Some.This s) -> writeIORef (eventSubscribedHeightRef s) $! invalidHeight
675+ forM_ subscribers $ \s -> writeIORef (eventSubscribedHeightRef s) $! invalidHeight
640676 return subscribers
641677#endif
642678
@@ -664,7 +700,7 @@ behaviorPull !p = Behavior $ do
664700 val <- liftIO $ readIORef $ pullValue p
665701 case val of
666702 Just subscribed -> do
667− askParentsRef >>= mapM_ (\r -> liftIO $ modifyIORef' r (SomeBehaviorSubscribed (Some.This (BehaviorSubscribedPull subscribed)) :))
703+ askParentsRef >>= mapM_ (\r -> liftIO $ modifyIORef' r (SomeBehaviorSubscribed (Some (BehaviorSubscribedPull subscribed)) :))
668704 askInvalidator >>= mapM_ (\wi -> liftIO $ modifyIORef' (pullSubscribedInvalidators subscribed) (wi:))
669705 liftIO $ touch $ pullSubscribedOwnInvalidator subscribed
670706 return $ pullSubscribedValue subscribed
@@ -673,7 +709,7 @@ behaviorPull !p = Behavior $ do
673709 wi <- liftIO $ mkWeakPtrWithDebug i "InvalidatorPull"
674710 parentsRef <- liftIO $ newIORef []
675711 holdInits <- askBehaviorHoldInits
676− a <- liftIO $ runReaderT (unBehaviorM $ pullCompute p) (Just (wi, parentsRef), holdInits)
712+ a <- liftIO $ runReaderIO (unBehaviorM $ pullCompute p) (Just (wi, parentsRef), holdInits)
677713 invsRef <- liftIO . newIORef . maybeToList =<< askInvalidator
678714 parents <- liftIO $ readIORef parentsRef
679715 let subscribed = PullSubscribed
@@ -683,7 +719,7 @@ behaviorPull !p = Behavior $ do
683719 , pullSubscribedParents = parents
684720 }
685721 liftIO $ writeIORef (pullValue p) $ Just subscribed
686− askParentsRef >>= mapM_ (\r -> liftIO $ modifyIORef' r (SomeBehaviorSubscribed (Some.This (BehaviorSubscribedPull subscribed)) :))
722+ askParentsRef >>= mapM_ (\r -> liftIO $ modifyIORef' r (SomeBehaviorSubscribed (Some (BehaviorSubscribedPull subscribed)) :))
687723 return a
688724
689725behaviorDyn :: Patch p => Dyn x p -> Behavior x (PatchTarget p)
@@ -694,7 +730,7 @@ readHoldTracked :: Hold x p -> BehaviorM x (PatchTarget p)
694730readHoldTracked h = do
695731 result <- liftIO $ readIORef $ holdValue h
696732 askInvalidator >>= mapM_ (\wi -> liftIO $ modifyIORef' (holdInvalidators h) (wi:))
697− askParentsRef >>= mapM_ (\r -> liftIO $ modifyIORef' r (SomeBehaviorSubscribed (Some.This (BehaviorSubscribedHold h)) :))
733+ askParentsRef >>= mapM_ (\r -> liftIO $ modifyIORef' r (SomeBehaviorSubscribed (Some (BehaviorSubscribedHold h)) :))
698734 liftIO $ touch h -- Otherwise, if this gets inlined enough, the hold's parent reference may get collected
699735 return result
700736
@@ -708,42 +744,46 @@ readBehaviorUntracked b = do
708744-- Dynamic
709745--------------------------------------------------------------------------------
710746
711−data Dynamic x p = Dynamic
712− { dynamicCurrent :: !(Behavior x (PatchTarget p))
747+type DynamicS x p = Dynamic x (PatchTarget p) p
748+
749+data Dynamic x target p = Dynamic
750+ { dynamicCurrent :: !(Behavior x target)
713751 , dynamicUpdated :: Event x p -- This must be lazy; see the comment on holdEvent --TODO: Would this let us eliminate `Dyn`?
714752 }
715753
716−dynamicHold :: Hold x p -> Dynamic x p
754+deriving instance (HasSpiderTimeline x) => Functor (Dynamic x target)
755+
756+
757+
758+
759+dynamicHold :: Hold x p -> DynamicS x p
717760dynamicHold !h = Dynamic
718761 { dynamicCurrent = behaviorHold h
719762 , dynamicUpdated = eventHold h
720763 }
721764
722−dynamicHoldIdentity :: Hold x (Identity a) -> Dynamic x (Identity a)
765+dynamicHoldIdentity :: Hold x (Identity a) -> DynamicS x (Identity a)
723766dynamicHoldIdentity = dynamicHold
724767
725−dynamicConst :: PatchTarget p -> Dynamic x p
768+dynamicConst :: PatchTarget p -> DynamicS x p
726769dynamicConst !a = Dynamic
727770 { dynamicCurrent = behaviorConst a
728771 , dynamicUpdated = eventNever
729772 }
730773
731−dynamicDyn :: (HasSpiderTimeline x, Patch p) => Dyn x p -> Dynamic x p
774+dynamicDyn :: (HasSpiderTimeline x, Patch p) => Dyn x p -> DynamicS x p
732775dynamicDyn !d = Dynamic
733776 { dynamicCurrent = behaviorDyn d
734777 , dynamicUpdated = eventDyn d
735778 }
736779
737−dynamicDynIdentity :: HasSpiderTimeline x => Dyn x (Identity a) -> Dynamic x (Identity a)
780+dynamicDynIdentity :: HasSpiderTimeline x => Dyn x (Identity a) -> DynamicS x (Identity a)
738781dynamicDynIdentity = dynamicDyn
739782
740783--------------------------------------------------------------------------------
741784-- Combinators
742785--------------------------------------------------------------------------------
743786
744−--TODO: Figure out why certain things are not 'representational', then make them
745−--representational so we can use coerce
746−
747787--type role Hold representational
748788data Hold x p
749789 = Hold { holdValue :: !(IORef (PatchTarget p))
@@ -764,20 +804,25 @@ globalSpiderTimelineEnv = unsafePerformIO unsafeNewSpiderTimelineEnv
764804
765805-- | Stores all global data relevant to a particular Spider timeline; only one
766806-- value should exist for each type @x@
767−data SpiderTimelineEnv x = SpiderTimelineEnv
807+newtype SpiderTimelineEnv x = STE {unSTE :: SpiderTimelineEnv' x}
808+-- We implement SpiderTimelineEnv with a newtype wrapper so
809+-- we can get the coercions we want safely.
810+type role SpiderTimelineEnv nominal
811+
812+data SpiderTimelineEnv' x = SpiderTimelineEnv
768813 { _spiderTimeline_lock :: {-# UNPACK #-} !(MVar ())
769814 , _spiderTimeline_eventEnv :: {-# UNPACK #-} !(EventEnv x)
770815#ifdef DEBUG
771816 , _spiderTimeline_depth :: {-# UNPACK #-} !(IORef Int)
772817#endif
773818 }
774−type role SpiderTimelineEnv nominal
819+type role SpiderTimelineEnv' phantom
775820
776821instance Eq (SpiderTimelineEnv x) where
777822 _ == _ = True -- Since only one exists of each type
778823
779824instance GEq SpiderTimelineEnv where
780− a `geq` b = if _spiderTimeline_lock a == _spiderTimeline_lock b
825+ a `geq` b = if _spiderTimeline_lock (unSTE a) == _spiderTimeline_lock (unSTE b)
781826 then Just $ unsafeCoerce Refl -- This unsafeCoerce is safe because the same SpiderTimelineEnv can't have two different 'x' arguments
782827 else Nothing
783828
@@ -800,7 +845,7 @@ runEventM :: EventM x a -> IO a
800845runEventM = unEventM
801846
802847asksEventEnv :: forall x a. HasSpiderTimeline x => (EventEnv x -> a) -> EventM x a
803−asksEventEnv f = return $ f $ _spiderTimeline_eventEnv (spiderTimeline :: SpiderTimelineEnv x)
848+asksEventEnv f = return $ f $ _spiderTimeline_eventEnv (unSTE (spiderTimeline :: SpiderTimelineEnv x))
804849
805850class MonadIO m => Defer a m where
806851 getDeferralQueue :: m (IORef [a])
@@ -867,7 +912,7 @@ instance HasSpiderTimeline x => Defer (Some Clear) (EventM x) where
867912
868913{-# INLINE scheduleClear #-}
869914scheduleClear :: Defer (Some Clear) m => IORef (Maybe a) -> m ()
870−scheduleClear r = defer $ Some.This $ Clear r
915+scheduleClear r = defer $ Some $ Clear r
871916
872917instance HasSpiderTimeline x => Defer (Some IntClear) (EventM x) where
873918 {-# INLINE getDeferralQueue #-}
@@ -875,7 +920,7 @@ instance HasSpiderTimeline x => Defer (Some IntClear) (EventM x) where
875920
876921{-# INLINE scheduleIntClear #-}
877922scheduleIntClear :: Defer (Some IntClear) m => IORef (IntMap a) -> m ()
878−scheduleIntClear r = defer $ Some.This $ IntClear r
923+scheduleIntClear r = defer $ Some $ IntClear r
879924
880925instance HasSpiderTimeline x => Defer (Some RootClear) (EventM x) where
881926 {-# INLINE getDeferralQueue #-}
@@ -883,7 +928,7 @@ instance HasSpiderTimeline x => Defer (Some RootClear) (EventM x) where
883928
884929{-# INLINE scheduleRootClear #-}
885930scheduleRootClear :: Defer (Some RootClear) m => IORef (DMap k Identity) -> m ()
886−scheduleRootClear r = defer $ Some.This $ RootClear r
931+scheduleRootClear r = defer $ Some $ RootClear r
887932
888933instance HasSpiderTimeline x => Defer (SomeResetCoincidence x) (EventM x) where
889934 {-# INLINE getDeferralQueue #-}
@@ -938,9 +983,9 @@ getHoldEventSubscription h = do
938983
939984type BehaviorEnv x = (Maybe (Weak (Invalidator x), IORef [SomeBehaviorSubscribed x]), IORef [SomeHoldInit x])
940985
941−--type role BehaviorM representational
942986-- BehaviorM can sample behaviors
943−newtype BehaviorM x a = BehaviorM { unBehaviorM :: ReaderT (BehaviorEnv x) IO a } deriving (Functor, Applicative, MonadIO, MonadFix)
987+newtype BehaviorM x a = BehaviorM { unBehaviorM :: ReaderIO (BehaviorEnv x) a }
988+ deriving (Functor, Applicative, MonadIO, MonadFix, MonadReader (BehaviorEnv x))
944989
945990instance Monad (BehaviorM x) where
946991 {-# INLINE (>>=) #-}
@@ -949,8 +994,10 @@ instance Monad (BehaviorM x) where
949994 BehaviorM x >> BehaviorM y = BehaviorM $ x >> y
950995 {-# INLINE return #-}
951996 return x = BehaviorM $ return x
997+#if !MIN_VERSION_base(4,13,0)
952998 {-# INLINE fail #-}
953999 fail s = BehaviorM $ fail s
1000+#endif
9541001
9551002data BehaviorSubscribed x a
9561003 = forall p. BehaviorSubscribedHold (Hold x p)
@@ -991,7 +1038,7 @@ data RootSubscribed x a = forall k. GCompare k => RootSubscribed
9911038#endif
9921039 }
9931040
994−data Root x (k :: * -> *)
1041+data Root x k
9951042 = Root { rootOccurrence :: !(IORef (DMap k Identity)) -- The currently-firing occurrence of this event
9961043 , rootSubscribed :: !(IORef (DMap k (RootSubscribed x)))
9971044 , rootInit :: !(forall a. k a -> RootTrigger x a -> IO (IO ()))
@@ -1010,7 +1057,7 @@ data SomeMergeUpdate x = SomeMergeUpdate
10101057newtype SomeMergeInit x = SomeMergeInit { unSomeMergeInit :: EventM x () }
10111058
10121059-- EventM can do everything BehaviorM can, plus create holds
1013−newtype EventM x a = EventM { unEventM :: IO a } deriving (Functor, Applicative, Monad, MonadIO, MonadFix, MonadException, MonadAsyncException) -- The environment should be Nothing if we are not in a frame, and Just if we are - in which case it is a list of assignments to be done after the frame is over
1060+newtype EventM x a = EventM { unEventM :: IO a } deriving (Functor, Applicative, Monad, MonadIO, MonadFix, MonadException, MonadAsyncException)
10141061
10151062newtype MergeSubscribedParent x a = MergeSubscribedParent { unMergeSubscribedParent :: EventSubscription x }
10161063
@@ -1035,7 +1082,8 @@ heightBagFromList :: [Height] -> HeightBag
10351082heightBagFromList heights = heightBagVerify $ foldl' (flip heightBagAdd) heightBagEmpty heights
10361083
10371084heightBagAdd :: Height -> HeightBag -> HeightBag
1038−heightBagAdd (Height h) (HeightBag s c) = heightBagVerify $ HeightBag (succ s) $ IntMap.insertWithKey (\_ _ old -> succ old) h 0 c
1085+heightBagAdd (Height h) (HeightBag s c) = heightBagVerify $ HeightBag (succ s) $
1086+ IntMap.insertWithKey (\_ _ old -> succ old) h 0 c
10391087
10401088heightBagRemove :: Height -> HeightBag -> HeightBag
10411089heightBagRemove (Height h) b@(HeightBag s c) = heightBagVerify $ case IntMap.lookup h c of
@@ -1044,6 +1092,13 @@ heightBagRemove (Height h) b@(HeightBag s c) = heightBagVerify $ case IntMap.loo
10441092 0 -> IntMap.delete h c
10451093 _ -> IntMap.insert h (pred old) c
10461094
1095+heightBagRemoveMaybe :: Height -> HeightBag -> Maybe HeightBag
1096+heightBagRemoveMaybe (Height h) b@(HeightBag s c) = heightBagVerify . removed <$> IntMap.lookup h c where
1097+ removed old = HeightBag (pred s) $ case old of
1098+ 0 -> IntMap.delete h c
1099+ _ -> IntMap.insert h (pred old) c
1100+
1101+
10471102heightBagMax :: HeightBag -> Height
10481103heightBagMax (HeightBag _ c) = case IntMap.maxViewWithKey c of
10491104 Just ((h, _), _) -> Height h
@@ -1061,25 +1116,25 @@ heightBagVerify b@(HeightBag s c) = if
10611116heightBagVerify = id
10621117#endif
10631118
1064−data FanSubscribedChildren (x :: *) k a = FanSubscribedChildren
1065− { _fanSubscribedChildren_list :: !(WeakBag (Subscriber x a))
1066− , _fanSubscribedChildren_self :: {-# NOUNPACK #-} !(k a, FanSubscribed x k)
1067− , _fanSubscribedChildren_weakSelf :: !(IORef (Weak (k a, FanSubscribed x k)))
1119+data FanSubscribedChildren x k v a = FanSubscribedChildren
1120+ { _fanSubscribedChildren_list :: !(WeakBag (Subscriber x (v a)))
1121+ , _fanSubscribedChildren_self :: {-# NOUNPACK #-} !(k a, FanSubscribed x k v)
1122+ , _fanSubscribedChildren_weakSelf :: !(IORef (Weak (k a, FanSubscribed x k v)))
10681123 }
10691124
1070−data FanSubscribed (x :: *) k
1071− = FanSubscribed { fanSubscribedCachedSubscribed :: !(IORef (Maybe (FanSubscribed x k)))
1072− , fanSubscribedOccurrence :: !(IORef (Maybe (DMap k Identity)))
1073− , fanSubscribedSubscribers :: !(IORef (DMap k (FanSubscribedChildren x k))) -- This DMap should never be empty
1125+data FanSubscribed x k v
1126+ = FanSubscribed { fanSubscribedCachedSubscribed :: !(IORef (Maybe (FanSubscribed x k v)))
1127+ , fanSubscribedOccurrence :: !(IORef (Maybe (DMap k v)))
1128+ , fanSubscribedSubscribers :: !(IORef (DMap k (FanSubscribedChildren x k v))) -- This DMap should never be empty
10741129 , fanSubscribedParent :: !(EventSubscription x)
10751130#ifdef DEBUG_NODEIDS
10761131 , fanSubscribedNodeId :: Int
10771132#endif
10781133 }
10791134
1080−data Fan x k
1081− = Fan { fanParent :: !(Event x (DMap k Identity))
1082− , fanSubscribed :: !(IORef (Maybe (FanSubscribed x k)))
1135+data Fan x k v
1136+ = Fan { fanParent :: !(Event x (DMap k v))
1137+ , fanSubscribed :: !(IORef (Maybe (FanSubscribed x k v)))
10831138 }
10841139
10851140data SwitchSubscribed x a
@@ -1144,17 +1199,24 @@ instance HasSpiderTimeline x => Semialign (Event x) where
11441199 align ea eb = mapMaybe dmapToThese $ mergeG coerce $ dynamicConst $
11451200 DMap.fromDistinctAscList [LeftTag :=> ea, RightTag :=> eb]
11461201
1202+#ifdef MIN_VERSION_semialign
1203+#if MIN_VERSION_semialign(1,1,0)
1204+instance HasSpiderTimeline x => Zip (Event x) where
1205+#endif
1206+ zip x y = mapMaybe justThese $ align x y
1207+#endif
1208+
11471209data DynType x p = UnsafeDyn !(BehaviorM x (PatchTarget p), Event x p)
11481210 | BuildDyn !(EventM x (PatchTarget p), Event x p)
11491211 | HoldDyn !(Hold x p)
11501212
11511213newtype Dyn (x :: Type) p = Dyn { unDyn :: IORef (DynType x p) }
11521214
1153−newMapDyn :: HasSpiderTimeline x => (a -> b) -> Dynamic x (Identity a) -> Dynamic x (Identity b)
1215+newMapDyn :: HasSpiderTimeline x => (a -> b) -> DynamicS x (Identity a) -> DynamicS x (Identity b)
11541216newMapDyn f d = dynamicDynIdentity $ unsafeBuildDynamic (fmap f $ readBehaviorTracked $ dynamicCurrent d) (Identity . f . runIdentity <$> dynamicUpdated d)
11551217
11561218--TODO: Avoid the duplication between this and R.zipDynWith
1157−zipDynWith :: HasSpiderTimeline x => (a -> b -> c) -> Dynamic x (Identity a) -> Dynamic x (Identity b) -> Dynamic x (Identity c)
1219+zipDynWith :: HasSpiderTimeline x => (a -> b -> c) -> DynamicS x (Identity a) -> DynamicS x (Identity b) -> DynamicS x (Identity c)
11581220zipDynWith f da db =
11591221 let eab = align (dynamicUpdated da) (dynamicUpdated db)
11601222 ec = flip push eab $ \o -> do
@@ -1177,18 +1239,12 @@ buildDynamic readV0 v' = do
11771239 return d
11781240
11791241unsafeBuildDynamic :: BehaviorM x (PatchTarget p) -> Event x p -> Dyn x p
1180−unsafeBuildDynamic readV0 v' = Dyn $ unsafeNewIORef x $ UnsafeDyn x
1181− where x = (readV0, v')
1242+unsafeBuildDynamic readV0 v' =
1243+ Dyn $ unsafePerformIO $ newIORef $ UnsafeDyn (readV0, v')
11821244
11831245-- ResultM can read behaviors and events
11841246type ResultM = EventM
11851247
1186−{-# NOINLINE unsafeNewIORef #-}
1187−unsafeNewIORef :: a -> b -> IORef b
1188−unsafeNewIORef a b = unsafePerformIO $ do
1189− touch a
1190− newIORef b
1191−
11921248instance HasSpiderTimeline x => Functor (Event x) where
11931249 fmap f = push $ return . Just . f
11941250
@@ -1201,33 +1257,42 @@ push f e = cacheEvent (pushCheap f e)
12011257
12021258{-# INLINABLE pull #-}
12031259pull :: BehaviorM x a -> Behavior x a
1204−pull a = behaviorPull $ Pull
1205− { pullCompute = a
1206− , pullValue = unsafeNewIORef a Nothing
1260+pull a = unsafePerformIO $ do
1261+ ref <- newIORef Nothing
12071262#ifdef DEBUG_NODEIDS
1208− , pullNodeId = unsafeNodeId a
1263+ nid <- newNodeId
12091264#endif
1210− }
1265+ pure $ behaviorPull $ Pull
1266+ { pullCompute = a
1267+ , pullValue = ref
1268+#ifdef DEBUG_NODEIDS
1269+ , pullNodeId = nid
1270+#endif
1271+ }
12111272
12121273{-# INLINABLE switch #-}
12131274switch :: HasSpiderTimeline x => Behavior x (Event x a) -> Event x a
1214−switch a = eventSwitch $ Switch
1215− { switchParent = a
1216− , switchSubscribed = unsafeNewIORef a Nothing
1217− }
1275+switch a = unsafePerformIO $ do
1276+ ref <- newIORef Nothing
1277+ pure $ eventSwitch $ Switch
1278+ { switchParent = a
1279+ , switchSubscribed = ref
1280+ }
12181281
12191282coincidence :: HasSpiderTimeline x => Event x (Event x a) -> Event x a
1220−coincidence a = eventCoincidence $ Coincidence
1221− { coincidenceParent = a
1222− , coincidenceSubscribed = unsafeNewIORef a Nothing
1223− }
1283+coincidence a = unsafePerformIO $ do
1284+ ref <- newIORef Nothing
1285+ pure $ eventCoincidence $ Coincidence
1286+ { coincidenceParent = a
1287+ , coincidenceSubscribed = ref
1288+ }
12241289
12251290-- Propagate the given event occurrence; before cleaning up, run the given action, which may read the state of events and behaviors
12261291run :: forall x b. HasSpiderTimeline x => [DSum (RootTrigger x) Identity] -> ResultM x b -> SpiderHost x b
12271292run roots after = do
12281293 tracePropagate (Proxy :: Proxy x) $ "Running an event frame with " <> show (length roots) <> " events"
12291294 let t = spiderTimeline :: SpiderTimelineEnv x
1230− result <- SpiderHost $ withMVar (_spiderTimeline_lock t) $ \_ -> unSpiderHost $ runFrame $ do
1295+ result <- SpiderHost $ withMVar (_spiderTimeline_lock (unSTE t)) $ \_ -> unSpiderHost $ runFrame $ do
12311296 rootsToPropagate <- forM roots $ \r@(RootTrigger (_, occRef, k) :=> a) -> do
12321297 occBefore <- liftIO $ do
12331298 occBefore <- readIORef occRef
@@ -1281,55 +1346,110 @@ mkWeakPtrWithDebug x debugNote = do
12811346 x' <- evaluate x
12821347 mkWeakPtr x' $
12831348 if debugFinalize
1284− then Just $ putStrLn $ "finalizing: " ++ debugNote
1349+ then Just $ debugStrLn $ "finalizing: " ++ debugNote
12851350 else Nothing
12861351
12871352type WeakList a = [Weak a]
12881353
1289−{-# INLINE withIncreasedDepth #-}
1354+type CanTrace x m = (HasSpiderTimeline x, MonadIO m)
1355+
1356+
1357+
1358+
12901359#ifdef DEBUG
1291−withIncreasedDepth :: CanTrace x m => m a -> m a
1292−withIncreasedDepth a = do
1293− spiderTimeline <- askSpiderTimelineEnv
1294− liftIO $ modifyIORef' (_spiderTimeline_depth spiderTimeline) succ
1360+
1361+debugSubscriber :: forall x a. HasSpiderTimeline x => String -> Subscriber x a -> IO (Subscriber x a)
1362+debugSubscriber description = return . debugSubscriber' description
1363+
1364+debugSubscriber' :: forall x a. HasSpiderTimeline x => String -> Subscriber x a -> Subscriber x a
1365+debugSubscriber' description subscribed = Subscriber
1366+ {
1367+ subscriberPropagate = \m -> do
1368+ tracePropagate (Proxy :: Proxy x) ("subscriberPropagate: " <> description)
1369+ subscriberPropagate subscribed m
1370+ , subscriberInvalidateHeight = \old -> do
1371+ traceInvalidateHeight $ "invalidateSubscriberHeight: " <> description <> ", old = " <> show (unHeight old)
1372+ subscriberInvalidateHeight subscribed old
1373+ traceInvalidateHeight $ "invalidateSubscriberHeight: " <> description <> ", done"
1374+ , subscriberRecalculateHeight = \new -> do
1375+ traceInvalidateHeight $ "subscriberRecalculateHeight: " <> description <> ", new = " <> show (unHeight new)
1376+ subscriberRecalculateHeight subscribed new
1377+ traceInvalidateHeight $ "subscriberRecalculateHeight: " <> description <> ", done"
1378+ }
1379+
1380+
1381+{-# INLINE withIncreasedDepth #-}
1382+withIncreasedDepth :: forall proxy x m a. CanTrace x m => proxy x -> m a -> m a
1383+withIncreasedDepth _ a = do
1384+ liftIO $ modifyIORef' (_spiderTimeline_depth $ unSTE (spiderTimeline :: SpiderTimelineEnv x)) succ
12951385 result <- a
1296− liftIO $ modifyIORef' (_spiderTimeline_depth spiderTimeline) pred
1386+ liftIO $ modifyIORef' (_spiderTimeline_depth $ unSTE (spiderTimeline :: SpiderTimelineEnv x)) pred
12971387 return result
1298−#else
1299−withIncreasedDepth :: m a -> m a
1300−withIncreasedDepth = id
1301−#endif
1302−
1303−type CanTrace x m = (HasSpiderTimeline x, MonadIO m)
13041388
13051389{-# INLINE tracePropagate #-}
13061390tracePropagate :: (CanTrace x m) => proxy x -> String -> m ()
1307−tracePropagate p = traceWhen p debugPropagate
1391+tracePropagate p = when debugPropagate . trace p
13081392
13091393{-# INLINE traceInvalidate #-}
13101394traceInvalidate :: String -> IO ()
1311−traceInvalidate = when debugInvalidate . liftIO . putStrLn
1395+traceInvalidate = when debugInvalidate . liftIO . debugStrLn
13121396
1313−{-# INLINE traceWhen #-}
1314−traceWhen :: (CanTrace x m) => proxy x -> Bool -> String -> m ()
1315−traceWhen p b message = traceMWhen p b $ return message
1397+{-# INLINE traceInvalidateHeight #-}
1398+traceInvalidateHeight :: String -> IO ()
1399+traceInvalidateHeight = when debugInvalidateHeight . liftIO . debugStrLn
13161400
1317−{-# INLINE traceMWhen #-}
1318−traceMWhen :: (CanTrace x m) => proxy x -> Bool -> m String -> m ()
1319−traceMWhen _ b getMessage = when b $ do
1401+{-# INLINE trace #-}
1402+trace :: (CanTrace x m) => proxy x -> String -> m ()
1403+trace p message = traceM p $ return message
1404+
1405+{-# INLINE traceM #-}
1406+traceM :: forall x proxy m. (CanTrace x m) => proxy x -> m String -> m ()
1407+traceM _ getMessage = do
13201408 message <- getMessage
1321−#ifdef DEBUG
1322− spiderTimeline <- askSpiderTimelineEnv
1323− d <- liftIO $ readIORef $ _spiderTimeline_depth spiderTimeline
1409+ d <- liftIO $ readIORef $ _spiderTimeline_depth $ unSTE (spiderTimeline :: SpiderTimelineEnv x)
1410+ liftIO $ debugStrLn $ replicate d ' ' <> message
1411+
13241412#else
1325− let d = 0
1413+
1414+{-# INLINE withIncreasedDepth #-}
1415+withIncreasedDepth :: proxy x -> m a -> m a
1416+withIncreasedDepth _ = id
1417+
1418+{-# INLINE tracePropagate #-}
1419+tracePropagate :: (CanTrace x m) => proxy x -> String -> m ()
1420+tracePropagate _ _ = return ()
1421+
1422+{-# INLINE traceInvalidate #-}
1423+traceInvalidate :: String -> IO ()
1424+traceInvalidate _ = return ()
1425+
1426+{-# INLINE traceInvalidateHeight #-}
1427+traceInvalidateHeight :: String -> IO ()
1428+traceInvalidateHeight _ = return ()
1429+
1430+{-# INLINE debugSubscriber #-}
1431+debugSubscriber :: String -> Subscriber x a -> IO (Subscriber x a)
1432+debugSubscriber _ = return
1433+
1434+{-# INLINE debugSubscriber' #-}
1435+debugSubscriber' :: String -> Subscriber x a -> Subscriber x a
1436+debugSubscriber' _ = id
1437+
1438+
1439+
1440+{-# INLINE trace #-}
1441+trace :: (CanTrace x m) => proxy x -> String -> m ()
1442+trace _ _ = return ()
1443+
1444+{-# INLINE traceM #-}
1445+traceM :: (CanTrace x m) => proxy x -> m String -> m ()
1446+traceM _ _ = return ()
1447+
13261448#endif
1327− liftIO $ putStrLn $ replicate d ' ' <> message
13281449
13291450whoCreatedIORef :: IORef a -> IO [String]
13301451whoCreatedIORef (IORef a) = whoCreated $! a
13311452
1332−#ifdef DEBUG_CYCLES
13331453groupByHead :: Eq a => [NonEmpty a] -> [(a, NonEmpty [a])]
13341454groupByHead = \case
13351455 [] -> []
@@ -1340,20 +1460,54 @@ groupByHead = \case
13401460 | otherwise -> (x, xs :| []) : l
13411461
13421462listsToForest :: Eq a => [[a]] -> Forest a
1343−listsToForest l = fmap (\(a, l') -> Node a $ listsToForest $ toList l') $ groupByHead $ catMaybes $ fmap nonEmpty l
1463+listsToForest lists = buildForest <$> groupByHead (mapMaybe nonEmpty lists)
1464+ where buildForest (a, lists') = Node a $ listsToForest $ toList lists'
1465+
1466+showStacks :: [[String]] -> String
1467+showStacks = drawForest . listsToForest . fmap (filterStack "Reflex.Spider.Internal")
1468+
1469+filterStack :: String -> [String] -> [String]
1470+#ifdef DEBUG_HIDE_INTERNALS
1471+filterStack prefix = filter (not . (prefix `isPrefixOf`))
1472+#else
1473+filterStack prefix = id
13441474#endif
13451475
1476+#ifdef DEBUG_CYCLES
1477+
1478+data EventLoopException = EventLoopException [[String]]
1479+instance Exception EventLoopException
1480+
1481+instance Show EventLoopException where
1482+ show (EventLoopException stacks) = "causality loop detected:\n" <> if null stacks
1483+ then "no location information, compile with profiling enabled for stack tree"
1484+ else showStacks stacks
1485+
1486+#else
1487+
1488+data EventLoopException = EventLoopException
1489+instance Exception EventLoopException
1490+
1491+instance Show EventLoopException where
1492+ show EventLoopException = "causality loop detected: \n" <>
1493+ "compile reflex with flag 'debug-cycles' and compile with profiling enabled for stack tree"
1494+
1495+#endif
1496+
1497+
13461498{-# INLINE propagateSubscriberHold #-}
13471499propagateSubscriberHold :: forall x p. (HasSpiderTimeline x, Patch p) => Hold x p -> p -> EventM x ()
13481500propagateSubscriberHold h a = do
1349− {-# SCC "trace" #-} traceMWhen (Proxy :: Proxy x) debugPropagate $ liftIO $ do
1501+ {-# SCC "trace" #-} when debugPropagate $ traceM (Proxy :: Proxy x) $ liftIO $ do
13501502 invalidators <- liftIO $ readIORef $ holdInvalidators h
13511503 return $ "SubscriberHold" <> showNodeId h <> ": " ++ show (length invalidators)
1504+
13521505 v <- {-# SCC "read" #-} liftIO $ readIORef $ holdValue h
13531506 case {-# SCC "apply" #-} apply a v of
13541507 Nothing -> return ()
13551508 Just v' -> do
1356− {-# SCC "trace2" #-} withIncreasedDepth $ tracePropagate (Proxy :: Proxy x) $ "propagateSubscriberHold: assigning Hold" <> showNodeId h
1509+ {-# SCC "trace2" #-} withIncreasedDepth (Proxy :: Proxy x) $
1510+ tracePropagate (Proxy :: Proxy x) ("propagateSubscriberHold: assigning Hold" <> showNodeId h)
13571511 vRef <- {-# SCC "vRef" #-} liftIO $ evaluate $ holdValue h
13581512 iRef <- {-# SCC "iRef" #-} liftIO $ evaluate $ holdInvalidators h
13591513 defer $ {-# SCC "assignment" #-} SomeAssignment vRef iRef v'
@@ -1361,25 +1515,25 @@ propagateSubscriberHold h a = do
13611515data SomeResetCoincidence x = forall a. SomeResetCoincidence !(EventSubscription x) !(Maybe (CoincidenceSubscribed x a)) -- The CoincidenceSubscriber will be present only if heights need to be reset
13621516
13631517runBehaviorM :: BehaviorM x a -> Maybe (Weak (Invalidator x), IORef [SomeBehaviorSubscribed x]) -> IORef [SomeHoldInit x] -> IO a
1364−runBehaviorM a mwi holdInits = runReaderT (unBehaviorM a) (mwi, holdInits)
1518+runBehaviorM a mwi holdInits = runReaderIO (unBehaviorM a) (mwi, holdInits)
13651519
13661520askInvalidator :: BehaviorM x (Maybe (Weak (Invalidator x)))
13671521askInvalidator = do
1368− (!m, _) <- BehaviorM ask
1522+ (!m, _) <- ask
13691523 case m of
13701524 Nothing -> return Nothing
13711525 Just (!wi, _) -> return $ Just wi
13721526
13731527askParentsRef :: BehaviorM x (Maybe (IORef [SomeBehaviorSubscribed x]))
13741528askParentsRef = do
1375− (!m, _) <- BehaviorM ask
1529+ (!m, _) <- ask
13761530 case m of
13771531 Nothing -> return Nothing
13781532 Just (_, !p) -> return $ Just p
13791533
13801534askBehaviorHoldInits :: BehaviorM x (IORef [SomeHoldInit x])
13811535askBehaviorHoldInits = do
1382− (_, !his) <- BehaviorM ask
1536+ (_, !his) <- ask
13831537 return his
13841538
13851539{-# INLINE getDynHold #-}
@@ -1407,7 +1561,7 @@ getDynHold d = do
14071561zeroRef :: IORef Height
14081562zeroRef = unsafePerformIO $ newIORef zeroHeight
14091563
1410−getRootSubscribed :: GCompare k => k a -> Root x k -> Subscriber x a -> IO (WeakBagTicket, RootSubscribed x a, Maybe a)
1564+getRootSubscribed :: forall k x a. (GCompare k, HasSpiderTimeline x) => k a -> Root x k -> Subscriber x a -> IO (WeakBagTicket, RootSubscribed x a, Maybe a)
14111565getRootSubscribed k r sub = do
14121566 mSubscribed <- readIORef $ rootSubscribed r
14131567 let getOcc = fmap (coerce . DMap.lookup k) $ readIORef $ rootOccurrence r
@@ -1421,9 +1575,14 @@ getRootSubscribed k r sub = do
14211575 let !cached = rootSubscribed r
14221576 uninitRef <- newIORef $ error "getRootsubscribed: uninitRef not initialized"
14231577 (subs, sln) <- WeakBag.singleton sub weakSelf cleanupRootSubscribed
1424− when debugPropagate $ putStrLn $ "getRootSubscribed: calling rootInit"
1578+
1579+ tracePropagate (Proxy::Proxy x) $ "getRootSubscribed: calling rootInit"
1580+
14251581 uninit <- rootInit r k $ RootTrigger (subs, rootOccurrence r, k)
14261582 writeIORef uninitRef $! uninit
1583+#ifdef DEBUG_NODEIDS
1584+ nid <- newNodeId
1585+#endif
14271586 let !subscribed = RootSubscribed
14281587 { rootSubscribedKey = k
14291588 , rootSubscribedCachedSubscribed = cached
@@ -1432,7 +1591,7 @@ getRootSubscribed k r sub = do
14321591 , rootSubscribedUninit = uninit
14331592 , rootSubscribedWeakSelf = weakSelf
14341593#ifdef DEBUG_NODEIDS
1435− , rootSubscribedNodeId = unsafeNodeId (k, r, subs)
1594+ , rootSubscribedNodeId = nid
14361595#endif
14371596 }
14381597 -- If we die at the same moment that all our children die, they will
@@ -1468,6 +1627,9 @@ data FanInt x a = FanInt
14681627 { _fanInt_subscribers :: {-# UNPACK #-} !(FastMutableIntMap (FastWeakBag (Subscriber x a))) --TODO: Clean up the keys in here when their child weak bags get empty --TODO: Remove our own subscription when the subscribers list is completely empty
14691628 , _fanInt_subscriptionRef :: {-# UNPACK #-} !(IORef (EventSubscription x)) -- This should have a valid subscription iff subscribers is non-empty
14701629 , _fanInt_occRef :: {-# UNPACK #-} !(IORef (IntMap a))
1630+#ifdef DEBUG_NODEIDS
1631+ , _fanInt_nodeId :: {-# UNPACK #-} !Int
1632+#endif
14711633 }
14721634
14731635newFanInt :: IO (FanInt x a)
@@ -1475,38 +1637,39 @@ newFanInt = do
14751637 subscribers <- FastMutableIntMap.newEmpty --TODO: Clean up the keys in here when their child weak bags get empty --TODO: Remove our own subscription when the subscribers list is completely empty
14761638 subscriptionRef <- newIORef $ error "fanInt: no subscription"
14771639 occRef <- newIORef $ error "fanInt: no occurrence"
1640+#ifdef DEBUG_NODEIDS
1641+ nodeId <- newNodeId
1642+#endif
14781643 return $ FanInt
14791644 { _fanInt_subscribers = subscribers
14801645 , _fanInt_subscriptionRef = subscriptionRef
14811646 , _fanInt_occRef = occRef
1647+#ifdef DEBUG_NODEIDS
1648+ , _fanInt_nodeId = nodeId
1649+#endif
14821650 }
14831651
1484−{-# NOINLINE unsafeNewFanInt #-}
1485−unsafeNewFanInt :: b -> FanInt x a
1486−unsafeNewFanInt b = unsafePerformIO $ do
1487− touch b
1488− newFanInt
1489−
14901652fanInt :: HasSpiderTimeline x => Event x (IntMap a) -> EventSelectorInt x a
1491−fanInt p =
1492− let self = unsafeNewFanInt p
1493− in EventSelectorInt $ \k -> Event $ \sub -> do
1653+fanInt p = unsafePerformIO $ do
1654+ self <- newFanInt
1655+ pure $ EventSelectorInt $ \k -> Event $ \sub -> do
14941656 isEmpty <- liftIO $ FastMutableIntMap.isEmpty (_fanInt_subscribers self)
14951657 when isEmpty $ do -- This is the first subscriber, so we need to subscribe to our input
1496− (subscription, parentOcc) <- subscribeAndRead p $ Subscriber
1658+ let desc = "fanInt" <> showNodeId self <> ", k = " <> show k
1659+ (subscription, parentOcc) <- subscribeAndRead p $ debugSubscriber' desc $ Subscriber
14971660 { subscriberPropagate = \m -> do
14981661 liftIO $ writeIORef (_fanInt_occRef self) m
14991662 scheduleIntClear $ _fanInt_occRef self
1500− FastMutableIntMap.forIntersectionWithImmutable_ (_fanInt_subscribers self) m $ \b v -> do --TODO: Do we need to know that no subscribers are being added as we traverse?
1501− FastWeakBag.traverse b $ \s -> do
1663+ FastMutableIntMap.forIntersectionWithImmutable_ (_fanInt_subscribers self) m $ \b v -> --TODO: Do we need to know that no subscribers are being added as we traverse?
1664+ FastWeakBag.traverse_ b $ \s ->
15021665 subscriberPropagate s v
1503− , subscriberInvalidateHeight = \old -> do
1504− FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b -> do
1505− FastWeakBag.traverse b $ \s -> do
1666+ , subscriberInvalidateHeight = \old ->
1667+ FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b ->
1668+ FastWeakBag.traverse_ b $ \s ->
15061669 subscriberInvalidateHeight s old
1507− , subscriberRecalculateHeight = \new -> do
1508− FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b -> do
1509− FastWeakBag.traverse b $ \s -> do
1670+ , subscriberRecalculateHeight = \new ->
1671+ FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b ->
1672+ FastWeakBag.traverse_ b $ \s ->
15101673 subscriberRecalculateHeight s new
15111674 }
15121675 liftIO $ do
@@ -1520,13 +1683,28 @@ fanInt p =
15201683 FastMutableIntMap.insert (_fanInt_subscribers self) k b
15211684 return b
15221685 Just b -> return b
1523− t <- liftIO $ FastWeakBag.insert sub b
1686+ ticket <- liftIO $ FastWeakBag.insert sub b
15241687 currentOcc <- readIORef (_fanInt_occRef self)
1525− (EventSubscription _ (EventSubscribed !heightRef _)) <- readIORef (_fanInt_subscriptionRef self)
1526− return (EventSubscription (FastWeakBag.remove t) $! EventSubscribed heightRef $! toAny (_fanInt_subscriptionRef self, t), IntMap.lookup k currentOcc)
1688+
1689+ subscribed <- fanIntSubscribed ticket self
1690+ return (EventSubscription (FastWeakBag.remove ticket) subscribed, IntMap.lookup k currentOcc)
1691+
1692+fanIntSubscribed :: FastWeakBagTicket k -> FanInt x a -> IO (EventSubscribed x)
1693+fanIntSubscribed ticket self = do
1694+ subscribedParent <- _eventSubscription_subscribed <$> readIORef (_fanInt_subscriptionRef self)
1695+ return $ EventSubscribed
1696+ { eventSubscribedHeightRef = eventSubscribedHeightRef subscribedParent
1697+ , eventSubscribedRetained = toAny (_fanInt_subscriptionRef self, ticket)
1698+#ifdef DEBUG_CYCLES
1699+ , eventSubscribedGetParents = return [subscribedParent]
1700+ , eventSubscribedHasOwnHeightRef = False
1701+ , eventSubscribedWhoCreated = whoCreatedIORef $ _fanInt_subscriptionRef self
1702+#endif
1703+ }
1704+
15271705
15281706{-# INLINABLE getFanSubscribed #-}
1529−getFanSubscribed :: (HasSpiderTimeline x, GCompare k) => k a -> Fan x k -> Subscriber x a -> EventM x (WeakBagTicket, FanSubscribed x k, Maybe a)
1707+getFanSubscribed :: (HasSpiderTimeline x, GCompare k) => k a -> Fan x k v -> Subscriber x (v a) -> EventM x (WeakBagTicket, FanSubscribed x k v, Maybe (v a))
15301708getFanSubscribed k f sub = do
15311709 mSubscribed <- liftIO $ readIORef $ fanSubscribed f
15321710 case mSubscribed of
@@ -1544,13 +1722,16 @@ getFanSubscribed k f sub = do
15441722 subscribersRef <- liftIO $ newIORef $ error "getFanSubscribed: subscribersRef not yet initialized"
15451723 occRef <- liftIO $ newIORef parentOcc
15461724 when (isJust parentOcc) $ scheduleClear occRef
1725+#ifdef DEBUG_NODEIDS
1726+ nid <- liftIO newNodeId
1727+#endif
15471728 let subscribed = FanSubscribed
15481729 { fanSubscribedCachedSubscribed = fanSubscribed f
15491730 , fanSubscribedOccurrence = occRef
15501731 , fanSubscribedParent = subscription
15511732 , fanSubscribedSubscribers = subscribersRef
15521733#ifdef DEBUG_NODEIDS
1553− , fanSubscribedNodeId = unsafeNodeId f
1734+ , fanSubscribedNodeId = nid
15541735#endif
15551736 }
15561737 let !self = (k, subscribed)
@@ -1560,7 +1741,7 @@ getFanSubscribed k f sub = do
15601741 liftIO $ writeIORef (fanSubscribed f) $ Just subscribed
15611742 return (slnForSub, subscribed, coerce $ DMap.lookup k =<< parentOcc)
15621743
1563−cleanupFanSubscribed :: GCompare k => (k a, FanSubscribed x k) -> IO ()
1744+cleanupFanSubscribed :: GCompare k => (k a, FanSubscribed x k v) -> IO ()
15641745cleanupFanSubscribed (k, subscribed) = do
15651746 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
15661747 let reducedSubscribers = DMap.delete k subscribers
@@ -1572,7 +1753,7 @@ cleanupFanSubscribed (k, subscribed) = do
15721753 else writeIORef (fanSubscribedSubscribers subscribed) $! reducedSubscribers
15731754
15741755{-# INLINE subscribeFanSubscribed #-}
1575−subscribeFanSubscribed :: GCompare k => k a -> FanSubscribed x k -> Subscriber x a -> IO WeakBagTicket
1756+subscribeFanSubscribed :: GCompare k => k a -> FanSubscribed x k v -> Subscriber x (v a) -> IO WeakBagTicket
15761757subscribeFanSubscribed k subscribed sub = do
15771758 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
15781759 case DMap.lookup k subscribers of
@@ -1610,6 +1791,9 @@ getSwitchSubscribed s sub = do
16101791 when (isJust parentOcc) $ scheduleClear occRef
16111792 weakSelf <- liftIO $ newIORef $ error "getSwitchSubscribed: weakSelf not yet initialized"
16121793 (subs, slnForSub) <- liftIO $ WeakBag.singleton sub weakSelf cleanupSwitchSubscribed
1794+#ifdef DEBUG_NODEIDS
1795+ nid <- liftIO newNodeId
1796+#endif
16131797 let !subscribed = SwitchSubscribed
16141798 { switchSubscribedCachedSubscribed = switchSubscribed s
16151799 , switchSubscribedOccurrence = occRef
@@ -1622,7 +1806,7 @@ getSwitchSubscribed s sub = do
16221806 , switchSubscribedCurrentParent = subscriptionRef
16231807 , switchSubscribedWeakSelf = weakSelf
16241808#ifdef DEBUG_NODEIDS
1625− , switchSubscribedNodeId = unsafeNodeId s
1809+ , switchSubscribedNodeId = nid
16261810#endif
16271811 }
16281812 liftIO $ writeIORef weakSelf =<< evaluate =<< mkWeakPtrWithDebug subscribed "switchSubscribedWeakSelf"
@@ -1667,6 +1851,9 @@ getCoincidenceSubscribed c sub = do
16671851 scheduleClear innerSubdRef
16681852 weakSelf <- liftIO $ newIORef $ error "getCoincidenceSubscribed: weakSelf not yet implemented"
16691853 (subs, slnForSub) <- liftIO $ WeakBag.singleton sub weakSelf cleanupCoincidenceSubscribed
1854+#ifdef DEBUG_NODEIDS
1855+ nid <- liftIO newNodeId
1856+#endif
16701857 let subscribed = CoincidenceSubscribed
16711858 { coincidenceSubscribedCachedSubscribed = coincidenceSubscribed c
16721859 , coincidenceSubscribedOccurrence = occRef
@@ -1677,7 +1864,7 @@ getCoincidenceSubscribed c sub = do
16771864 , coincidenceSubscribedInnerParent = innerSubdRef
16781865 , coincidenceSubscribedWeakSelf = weakSelf
16791866#ifdef DEBUG_NODEIDS
1680− , coincidenceSubscribedNodeId = unsafeNodeId c
1867+ , coincidenceSubscribedNodeId = nid
16811868#endif
16821869 }
16831870 liftIO $ writeIORef weakSelf =<< evaluate =<< mkWeakPtrWithDebug subscribed "CoincidenceSubscribed"
@@ -1697,22 +1884,22 @@ subscribeCoincidenceSubscribed subscribed sub = WeakBag.insert sub (coincidenceS
16971884{-# INLINE mergeG #-}
16981885mergeG :: forall k q x v. (HasSpiderTimeline x, GCompare k)
16991886 => (forall a. q a -> Event x (v a))
1700− -> Dynamic x (PatchDMap k q) -> Event x (DMap k v)
1887+ -> DynamicS x (PatchDMap k q) -> Event x (DMap k v)
17011888mergeG nt d = cacheEvent (mergeCheap nt d)
17021889
17031890{-# INLINE mergeWithMove #-}
17041891mergeWithMove :: forall k v q x. (HasSpiderTimeline x, GCompare k)
17051892 => (forall a. q a -> Event x (v a))
1706− -> Dynamic x (PatchDMapWithMove k q) -> Event x (DMap k v)
1893+ -> DynamicS x (PatchDMapWithMove k q) -> Event x (DMap k v)
17071894mergeWithMove nt d = cacheEvent (mergeCheapWithMove nt d)
17081895
17091896{-# INLINE [1] mergeCheap #-}
17101897mergeCheap
17111898 :: forall k x q v. (HasSpiderTimeline x, GCompare k)
17121899 => (forall a. q a -> Event x (v a))
1713− -> Dynamic x (PatchDMap k q)
1900+ -> DynamicS x (PatchDMap k q)
17141901 -> Event x (DMap k v)
1715−mergeCheap nt = mergeGCheap' getInitialSubscribers updateMe destroy
1902+mergeCheap nt = mergeGCheap' unMergeSubscribedParent getInitialSubscribers updateMe destroy
17161903 where
17171904 updateMe :: MergeUpdateFunc k v x (PatchDMap k q) (MergeSubscribedParent x)
17181905 updateMe subscriber heightBagRef oldParents (PatchDMap p) = do
@@ -1727,7 +1914,9 @@ mergeCheap nt = mergeGCheap' getInitialSubscribers updateMe destroy
17271914 liftIO $ modifyIORef' heightBagRef $ heightBagAdd newParentHeight
17281915 return $ DMap.insertLookupWithKey' (\_ new _ -> new) k newParent ps
17291916 forM_ mOldSubd $ \oldSubd -> do
1730− oldHeight <- liftIO $ getEventSubscribedHeight $ _eventSubscription_subscribed $ unMergeSubscribedParent oldSubd
1917+ oldHeight <- liftIO $ getEventSubscribedHeight $
1918+ _eventSubscription_subscribed $ unMergeSubscribedParent oldSubd
1919+
17311920 liftIO $ modifyIORef heightBagRef $ heightBagRemove oldHeight
17321921 return (maybeToList (unMergeSubscribedParent <$> mOldSubd) ++ subscriptionsToKill, newPs)
17331922 foldM f ([], oldParents) $ DMap.toList p
@@ -1738,7 +1927,7 @@ mergeCheap nt = mergeGCheap' getInitialSubscribers updateMe destroy
17381927 let s = subscriber $ return k
17391928 (subscription@(EventSubscription _ parentSubd), parentOcc) <- subscribeAndRead (nt e) s
17401929 height <- liftIO $ getEventSubscribedHeight parentSubd
1741− return (fmap (\x -> k :=> x) parentOcc, height, k :=> MergeSubscribedParent subscription)
1930+ return (fmap (k :=>) parentOcc, height, k :=> MergeSubscribedParent subscription)
17421931 return ( DMap.fromDistinctAscList $ mapMaybe (\(x, _, _) -> x) subscribers
17431932 , fmap (\(_, h, _) -> h) subscribers --TODO: Assert that there's no invalidHeight in here
17441933 , DMap.fromDistinctAscList $ map (\(_, _, x) -> x) subscribers
@@ -1750,9 +1939,9 @@ mergeCheap nt = mergeGCheap' getInitialSubscribers updateMe destroy
17501939{-# INLINE [1] mergeCheapWithMove #-}
17511940mergeCheapWithMove :: forall k x v q. (HasSpiderTimeline x, GCompare k)
17521941 => (forall a. q a -> Event x (v a))
1753− -> Dynamic x (PatchDMapWithMove k q)
1942+ -> DynamicS x (PatchDMapWithMove k q)
17541943 -> Event x (DMap k v)
1755−mergeCheapWithMove nt = mergeGCheap' getInitialSubscribers updateMe destroy
1944+mergeCheapWithMove nt = mergeGCheap' _mergeSubscribedParentWithMove_subscription getInitialSubscribers updateMe destroy
17561945 where
17571946 updateMe :: MergeUpdateFunc k v x (PatchDMapWithMove k q) (MergeSubscribedParentWithMove x k)
17581947 updateMe subscriber heightBagRef oldParents p = do
@@ -1771,13 +1960,17 @@ mergeCheapWithMove nt = mergeGCheap' getInitialSubscribers updateMe destroy
17711960 let moveOrDelete :: forall a. k a -> PatchDMapWithMove.NodeInfo k q a -> MergeSubscribedParentWithMove x k a -> Constant (EventM x (Maybe (EventSubscription x))) a
17721961 moveOrDelete _ ni parent = Constant $ case getComposeMaybe $ PatchDMapWithMove._nodeInfo_to ni of
17731962 Nothing -> do
1774− oldHeight <- liftIO $ getEventSubscribedHeight $ _eventSubscription_subscribed $ _mergeSubscribedParentWithMove_subscription parent
1963+ oldHeight <- liftIO $ getEventSubscribedHeight $ _eventSubscription_subscribed $
1964+ _mergeSubscribedParentWithMove_subscription parent
1965+
17751966 liftIO $ modifyIORef heightBagRef $ heightBagRemove oldHeight
17761967 return $ Just $ _mergeSubscribedParentWithMove_subscription parent
17771968 Just toKey -> do
17781969 liftIO $ writeIORef (_mergeSubscribedParentWithMove_key parent) $! toKey
17791970 return Nothing
1780− toDelete <- fmap catMaybes $ mapM (\(_ :=> v) -> getConstant v) $ DMap.toList $ DMap.intersectionWithKey moveOrDelete (unPatchDMapWithMove p) oldParents
1971+ toDelete <- fmap catMaybes $ mapM (\(_ :=> v) -> getConstant v) $ DMap.toList $
1972+ DMap.intersectionWithKey moveOrDelete (unPatchDMapWithMove p) oldParents
1973+
17811974 return (toDelete, applyAlways p' oldParents)
17821975 getInitialSubscribers :: MergeInitFunc k v q x (MergeSubscribedParentWithMove x k)
17831976 getInitialSubscribers initialParents subscriber = do
@@ -1786,7 +1979,7 @@ mergeCheapWithMove nt = mergeGCheap' getInitialSubscribers updateMe destroy
17861979 let s = subscriber $ liftIO $ readIORef keyRef
17871980 (subscription@(EventSubscription _ parentSubd), parentOcc) <- subscribeAndRead (nt e) s
17881981 height <- liftIO $ getEventSubscribedHeight parentSubd
1789− return (fmap (\x -> k :=> x) parentOcc, height, k :=> MergeSubscribedParentWithMove subscription keyRef)
1982+ return (fmap (k :=>) parentOcc, height, k :=> MergeSubscribedParentWithMove subscription keyRef)
17901983 return ( DMap.fromDistinctAscList $ mapMaybe (\(x, _, _) -> x) subscribers
17911984 , fmap (\(_, h, _) -> h) subscribers --TODO: Assert that there's no invalidHeight in here
17921985 , DMap.fromDistinctAscList $ map (\(_, _, x) -> x) subscribers
@@ -1802,6 +1995,8 @@ type MergeUpdateFunc k v x p s
18021995 -> p
18031996 -> EventM x ([EventSubscription x], DMap k s)
18041997
1998+type MergeGetSubscription x s = forall a. s a -> EventSubscription x
1999+
18052000type MergeInitFunc k v q x s
18062001 = DMap k q
18072002 -> (forall a. EventM x (k a) -> Subscriber x (v a))
@@ -1825,14 +2020,17 @@ invalidateMergeHeight m = invalidateMergeHeight' (_merge_heightRef m) (_merge_su
18252020invalidateMergeHeight' :: IORef Height -> Subscriber x a -> IO ()
18262021invalidateMergeHeight' heightRef sub = do
18272022 oldHeight <- readIORef heightRef
1828− when (oldHeight /= invalidHeight) $ do -- If the height used to be valid, it must be invalid now; we should never have *more* heights than we have parents
2023+ -- If the height used to be valid, it must be invalid now; we should never have *more* heights than we have parents
2024+ when (oldHeight /= invalidHeight) $ do
18292025 writeIORef heightRef $! invalidHeight
18302026 subscriberInvalidateHeight sub oldHeight
18312027
18322028revalidateMergeHeight :: Merge x k v s -> IO ()
18332029revalidateMergeHeight m = do
18342030 currentHeight <- readIORef $ _merge_heightRef m
1835− when (currentHeight == invalidHeight) $ do -- revalidateMergeHeight may be called multiple times; perhaps the's a way to finesse it to avoid this check
2031+
2032+ -- revalidateMergeHeight may be called multiple times; perhaps the's a way to finesse it to avoid this check
2033+ when (currentHeight == invalidHeight) $ do
18362034 heights <- readIORef $ _merge_heightBagRef m
18372035 parents <- readIORef $ _merge_parentsRef m
18382036 -- When the number of heights in the bag reaches the number of parents, we should have a valid height
@@ -1840,7 +2038,7 @@ revalidateMergeHeight m = do
18402038 LT -> return ()
18412039 EQ -> do
18422040 let height = succHeight $ heightBagMax heights
1843− when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: height: " <> show height
2041+ traceInvalidateHeight $ "recalculateSubscriberHeight: height: " <> show height
18442042 writeIORef (_merge_heightRef m) $! height
18452043 subscriberRecalculateHeight (_merge_sub m) height
18462044 GT -> error $ "revalidateMergeHeight: more heights (" <> show (heightBagSize heights) <> ") than parents (" <> show (DMap.size parents) <> ") for Merge"
@@ -1848,36 +2046,45 @@ revalidateMergeHeight m = do
18482046scheduleMergeSelf :: HasSpiderTimeline x => Merge x k v s -> Height -> EventM x ()
18492047scheduleMergeSelf m height = scheduleMerge' height (_merge_heightRef m) $ do
18502048 vals <- liftIO $ readIORef $ _merge_accumRef m
1851− liftIO $ writeIORef (_merge_accumRef m) $! DMap.empty -- Once we're done with this, we can clear it immediately, because if there's a cacheEvent in front of us, it'll handle subsequent subscribers, and if not, we won't get subsequent subscribers
2049+ -- Once we're done with this, we can clear it immediately, because if there's a cacheEvent in front of us,
2050+ -- it'll handle subsequent subscribers, and if not, we won't get subsequent subscribers
2051+ liftIO $ writeIORef (_merge_accumRef m) $! DMap.empty
18522052 --TODO: Assert that m is not empty
18532053 subscriberPropagate (_merge_sub m) vals
18542054
1855−mergeSubscriber :: forall x k v s a. (HasSpiderTimeline x, GCompare k) => Merge x k v s -> EventM x (k a) -> Subscriber x (v a)
1856−mergeSubscriber m getKey = Subscriber
2055+checkCycle :: HasSpiderTimeline x => EventSubscribed x -> EventM x ()
2056+checkCycle subscribed = liftIO $ do
2057+ height <- readIORef (eventSubscribedHeightRef subscribed)
2058+
2059+ -- currentHeight <- getCurrentHeight
2060+ -- when (height <= currentHeight) $ if height /= invalidHeight
2061+ -- then do
2062+ -- myStack <- liftIO $ whoCreatedIORef undefined --TODO
2063+ -- error $ "Height (" ++ show height ++ ") is not greater than current height (" ++ show currentHeight ++ ")\n" ++ unlines (reverse myStack)
2064+ -- else liftIO $
2065+ when (height == invalidHeight) $
2066+#ifdef DEBUG_CYCLES
2067+ do
2068+ nodesInvolvedInCycle <- walkInvalidHeightParents subscribed
2069+ stacks <- forM nodesInvolvedInCycle whoCreatedEventSubscribed
2070+ throwIO (EventLoopException stacks)
2071+#else
2072+ throwIO EventLoopException
2073+#endif
2074+
2075+
2076+mergeSubscriber :: forall x k v s a. (HasSpiderTimeline x, GCompare k) => EventSubscribed x -> Merge x k v s -> EventM x (k a) -> Subscriber x (v a)
2077+mergeSubscriber subscribed m getKey = Subscriber
18572078 { subscriberPropagate = \a -> do
18582079 oldM <- liftIO $ readIORef $ _merge_accumRef m
18592080 k <- getKey
1860− let newM = DMap.insertWith (error $ "Same key fired multiple times for Merge") k a oldM
2081+ let newM = DMap.insertWith (error "Same key fired multiple times for Merge") k a oldM
18612082 tracePropagate (Proxy :: Proxy x) $ " DMap.size oldM = " <> show (DMap.size oldM) <> "; DMap.size newM = " <> show (DMap.size newM)
18622083 liftIO $ writeIORef (_merge_accumRef m) $! newM
18632084 when (DMap.null oldM) $ do -- Only schedule the firing once
18642085 height <- liftIO $ readIORef $ _merge_heightRef m
1865− --TODO: assertions about height
1866− currentHeight <- getCurrentHeight
1867− when (height <= currentHeight) $ do
1868− if height /= invalidHeight
1869− then do
1870− myStack <- liftIO $ whoCreatedIORef undefined --TODO
1871− error $ "Height (" ++ show height ++ ") is not greater than current height (" ++ show currentHeight ++ ")\n" ++ unlines (reverse myStack)
1872− else liftIO $ do
1873−#ifdef DEBUG_CYCLES
1874− nodesInvolvedInCycle <- walkInvalidHeightParents $ eventSubscribedMerge subscribed
1875− stacks <- forM nodesInvolvedInCycle $ \(Some.This es) -> whoCreatedEventSubscribed es
1876− let cycleInfo = ":\n" <> drawForest (listsToForest stacks)
1877−#else
1878− let cycleInfo = ""
1879−#endif
1880− error $ "Causality loop found" <> cycleInfo
2086+ checkCycle subscribed
2087+
18812088 scheduleMergeSelf m height
18822089 , subscriberInvalidateHeight = \old -> do --TODO: When removing a parent doesn't actually change the height, maybe we can avoid invalidating
18832090 modifyIORef' (_merge_heightBagRef m) $ heightBagRemove old
@@ -1888,31 +2095,45 @@ mergeSubscriber m getKey = Subscriber
18882095 }
18892096
18902097--TODO: Be able to run as much of this as possible promptly
1891−updateMerge :: (HasSpiderTimeline x, GCompare k) => Merge x k v s -> MergeUpdateFunc k v x p s -> p -> SomeMergeUpdate x
1892−updateMerge m updateFunc p = SomeMergeUpdate updateMe (invalidateMergeHeight m) (revalidateMergeHeight m)
2098+updateMerge :: (HasSpiderTimeline x, GCompare k) => EventSubscribed x -> Merge x k v s -> MergeUpdateFunc k v x p s -> p -> SomeMergeUpdate x
2099+updateMerge subscribed m updateFunc p = SomeMergeUpdate updateMe (invalidateMergeHeight m) (revalidateMergeHeight m)
18932100 where updateMe = do
18942101 oldParents <- liftIO $ readIORef $ _merge_parentsRef m
1895− (subscriptionsToKill, newParents) <- updateFunc (mergeSubscriber m) (_merge_heightBagRef m) oldParents p
2102+ (subscriptionsToKill, newParents) <- updateFunc (mergeSubscriber subscribed m) (_merge_heightBagRef m) oldParents p
18962103 liftIO $ writeIORef (_merge_parentsRef m) $! newParents
18972104 return subscriptionsToKill
18982105
18992106{-# INLINE mergeGCheap' #-}
19002107mergeGCheap' :: forall k v x p s q. (HasSpiderTimeline x, GCompare k, PatchTarget p ~ DMap k q)
1901− => MergeInitFunc k v q x s -> MergeUpdateFunc k v x p s -> MergeDestroyFunc k s -> Dynamic x p -> Event x (DMap k v)
1902−mergeGCheap' getInitialSubscribers updateFunc destroy d = Event $ \sub -> do
2108+ => MergeGetSubscription x s -> MergeInitFunc k v q x s -> MergeUpdateFunc k v x p s -> MergeDestroyFunc k s -> DynamicS x p -> Event x (DMap k v)
2109+mergeGCheap' getParent getInitialSubscribers updateFunc destroy d = Event $ \sub -> do
19032110 initialParents <- readBehaviorUntracked $ dynamicCurrent d
19042111 accumRef <- liftIO $ newIORef $ error "merge: accumRef not yet initialized"
19052112 heightRef <- liftIO $ newIORef $ error "merge: heightRef not yet initialized"
19062113 heightBagRef <- liftIO $ newIORef $ error "merge: heightBagRef not yet initialized"
19072114 parentsRef :: IORef (DMap k s) <- liftIO $ newIORef $ error "merge: parentsRef not yet initialized"
1908− let m = Merge
2115+ changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
2116+
2117+ let subscribed = EventSubscribed
2118+ { eventSubscribedHeightRef = heightRef
2119+ , eventSubscribedRetained = toAny (parentsRef, changeSubdRef)
2120+#ifdef DEBUG_CYCLES
2121+ , eventSubscribedGetParents = do
2122+ let getParent' (_ :=> v) = _eventSubscription_subscribed (getParent v)
2123+ fmap getParent' . DMap.toList <$> readIORef parentsRef
2124+ , eventSubscribedHasOwnHeightRef = False
2125+ , eventSubscribedWhoCreated = whoCreatedIORef heightRef
2126+#endif
2127+ }
2128+
2129+ m = Merge
19092130 { _merge_parentsRef = parentsRef
19102131 , _merge_heightBagRef = heightBagRef
19112132 , _merge_heightRef = heightRef
19122133 , _merge_sub = sub
19132134 , _merge_accumRef = accumRef
19142135 }
1915− (dm, heights, initialParentState) <- getInitialSubscribers initialParents $ mergeSubscriber m
2136+ (dm, heights, initialParentState) <- getInitialSubscribers initialParents $ mergeSubscriber subscribed m
19162137 let myHeightBag = heightBagFromList $ filter (/= invalidHeight) heights
19172138 myHeight = if invalidHeight `elem` heights
19182139 then invalidHeight
@@ -1921,50 +2142,57 @@ mergeGCheap' getInitialSubscribers updateFunc destroy d = Event $ \sub -> do
19212142 let (occ, accum) = if currentHeight >= myHeight -- If we should have fired by now
19222143 then (if DMap.null dm then Nothing else Just dm, DMap.empty)
19232144 else (Nothing, dm)
1924− unless (DMap.null accum) $ do
1925− scheduleMergeSelf m myHeight
2145+ unless (DMap.null accum) $ scheduleMergeSelf m myHeight
19262146 liftIO $ writeIORef accumRef $! accum
19272147 liftIO $ writeIORef heightRef $! myHeight
19282148 liftIO $ writeIORef heightBagRef $! myHeightBag
1929− changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
19302149 liftIO $ writeIORef parentsRef $! initialParentState
19312150 defer $ SomeMergeInit $ do
1932− let s = Subscriber
2151+ let changeSubscriber = Subscriber
19332152 { subscriberPropagate = \a -> {-# SCC "traverseMergeChange" #-} do
1934− tracePropagate (Proxy :: Proxy x) $ "SubscriberMerge/Change"
1935− defer $ updateMerge m updateFunc a
2153+ tracePropagate (Proxy :: Proxy x) "SubscriberMerge/Change"
2154+ defer $ updateMerge subscribed m updateFunc a
19362155 , subscriberInvalidateHeight = \_ -> return ()
19372156 , subscriberRecalculateHeight = \_ -> return ()
19382157 }
1939− (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) s
1940− forM_ change $ \c -> defer $ updateMerge m updateFunc c
2158+ (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) changeSubscriber
2159+ forM_ change $ \c -> defer $ updateMerge subscribed m updateFunc c
19412160 -- We explicitly hold on to the unsubscribe function from subscribing to the update event.
19422161 -- If we don't do this, there are certain cases where mergeCheap will fail to properly retain
19432162 -- its subscription.
1944− liftIO $ writeIORef changeSubdRef (s, changeSubscription)
2163+ liftIO $ writeIORef changeSubdRef (changeSubscriber, changeSubscription)
19452164 let unsubscribeAll = destroy =<< readIORef parentsRef
1946− return ( EventSubscription unsubscribeAll $ EventSubscribed heightRef $ toAny (parentsRef, changeSubdRef)
1947− , occ
1948− )
19492165
1950−mergeInt :: forall x a. (HasSpiderTimeline x) => Dynamic x (PatchIntMap (Event x a)) -> Event x (IntMap a)
2166+ return (EventSubscription unsubscribeAll subscribed, occ)
2167+
2168+
2169+mergeInt :: forall x a. (HasSpiderTimeline x) => DynamicS x (PatchIntMap (Event x a)) -> Event x (IntMap a)
19512170mergeInt = cacheEvent . mergeIntCheap
19522171
19532172{-# INLINABLE mergeIntCheap #-}
1954−mergeIntCheap :: forall x a. (HasSpiderTimeline x) => Dynamic x (PatchIntMap (Event x a)) -> Event x (IntMap a)
2173+mergeIntCheap :: forall x a. (HasSpiderTimeline x) => DynamicS x (PatchIntMap (Event x a)) -> Event x (IntMap a)
19552174mergeIntCheap d = Event $ \sub -> do
19562175 initialParents <- readBehaviorUntracked $ dynamicCurrent d
19572176 accum <- liftIO $ FastMutableIntMap.newEmpty
19582177 heightRef <- liftIO $ newIORef zeroHeight
19592178 heightBagRef <- liftIO $ newIORef heightBagEmpty
19602179 parents <- liftIO $ FastMutableIntMap.newEmpty
2180+ changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
2181+ let subscribed = EventSubscribed
2182+ { eventSubscribedHeightRef = heightRef
2183+ , eventSubscribedRetained = toAny (parents, changeSubdRef)
2184+#ifdef DEBUG_CYCLES
2185+ , eventSubscribedGetParents = fmap (_eventSubscription_subscribed . snd) <$> FastMutableIntMap.toList parents
2186+ , eventSubscribedHasOwnHeightRef = False
2187+ , eventSubscribedWhoCreated = whoCreatedIORef heightRef
2188+#endif
2189+ }
19612190 let scheduleSelf = do
19622191 height <- liftIO $ readIORef $ heightRef
19632192 scheduleMerge' height heightRef $ do
19642193 vals <- liftIO $ FastMutableIntMap.getFrozenAndClear accum
19652194 subscriberPropagate sub vals
1966− invalidateMyHeight = do
1967− invalidateMergeHeight' heightRef sub
2195+ invalidateMyHeight = invalidateMergeHeight' heightRef sub
19682196 recalculateMyHeight = do
19692197 currentHeight <- readIORef heightRef
19702198 when (currentHeight == invalidHeight) $ do --TODO: This will almost always be true; can we get rid of this check and just proceed to the next one always?
@@ -1974,12 +2202,14 @@ mergeIntCheap d = Event $ \sub -> do
19742202 LT -> return ()
19752203 EQ -> do
19762204 let height = succHeight $ heightBagMax heights
1977− when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: height: " <> show height
2205+ traceInvalidateHeight $ "recalculateSubscriberHeight: height: " <> show height
19782206 writeIORef heightRef $! height
19792207 subscriberRecalculateHeight sub height
19802208 GT -> error $ "revalidateMergeHeight: more heights (" <> show (heightBagSize heights) <> ") than parents (" <> show numParents <> ") for Merge"
19812209 mySubscriber k = Subscriber
19822210 { subscriberPropagate = \a -> do
2211+ checkCycle subscribed
2212+
19832213 wasEmpty <- liftIO $ FastMutableIntMap.isEmpty accum
19842214 liftIO $ FastMutableIntMap.insert accum k a
19852215 when wasEmpty scheduleSelf
@@ -2013,7 +2243,6 @@ mergeIntCheap d = Event $ \sub -> do
20132243 else liftIO $ Just <$> FastMutableIntMap.getFrozenAndClear accum
20142244 else do when (not isEmpty) scheduleSelf -- We have things accumulated, but we shouldn't have fired them yet
20152245 return Nothing
2016− changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
20172246 defer $ SomeMergeInit $ do
20182247 let updateMe a = SomeMergeUpdate u invalidateMyHeight recalculateMyHeight
20192248 where
@@ -2027,35 +2256,39 @@ mergeIntCheap d = Event $ \sub -> do
20272256 oldParents <- liftIO $ FastMutableIntMap.applyPatch parents newSubscriptions
20282257 liftIO $ for_ oldParents $ \oldParent -> do
20292258 oldParentHeight <- getEventSubscribedHeight $ _eventSubscription_subscribed oldParent
2259+
2260+ print ("updateMe", oldParentHeight)
20302261 modifyIORef' heightBagRef $ heightBagRemove oldParentHeight
20312262 return $ IntMap.elems oldParents
2032− let s = Subscriber
2263+ let changeSubscriber = Subscriber
20332264 { subscriberPropagate = \a -> {-# SCC "traverseMergeChange" #-} do
20342265 tracePropagate (Proxy :: Proxy x) $ "SubscriberMergeInt/Change"
20352266 defer $ updateMe a
20362267 , subscriberInvalidateHeight = \_ -> return ()
20372268 , subscriberRecalculateHeight = \_ -> return ()
20382269 }
2039− (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) s
2270+ (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) changeSubscriber
20402271 forM_ change $ \c -> defer $ updateMe c
20412272 -- We explicitly hold on to the unsubscribe function from subscribing to the update event.
20422273 -- If we don't do this, there are certain cases where mergeCheap will fail to properly retain
20432274 -- its subscription.
2044− liftIO $ writeIORef changeSubdRef (s, changeSubscription)
2275+ liftIO $ writeIORef changeSubdRef (changeSubscriber, changeSubscription)
20452276 let unsubscribeAll = traverse_ unsubscribe =<< FastMutableIntMap.getFrozenAndClear parents
2046− return ( EventSubscription unsubscribeAll $ EventSubscribed heightRef $ toAny (parents, changeSubdRef)
2047− , occ
2048− )
2277+
2278+
2279+ return (EventSubscription unsubscribeAll subscribed, occ)
20492280
20502281newtype EventSelector x k = EventSelector { select :: forall a. k a -> Event x a }
2282+newtype EventSelectorG x k v = EventSelectorG { selectG :: forall a. k a -> Event x (v a) }
20512283
2052−fan :: (HasSpiderTimeline x, GCompare k) => Event x (DMap k Identity) -> EventSelector x k
2053−fan e =
2284+fanG :: (HasSpiderTimeline x, GCompare k) => Event x (DMap k v) -> EventSelectorG x k v
2285+fanG e = unsafePerformIO $ do
2286+ ref <- newIORef Nothing
20542287 let f = Fan
20552288 { fanParent = e
2056− , fanSubscribed = unsafeNewIORef e Nothing
2289+ , fanSubscribed = ref
20572290 }
2058− in EventSelector $ \k -> eventFan k f
2291+ pure $ EventSelectorG $ \k -> eventFan k f
20592292
20602293runHoldInits :: HasSpiderTimeline x => IORef [SomeHoldInit x] -> IORef [SomeDynInit x] -> IORef [SomeMergeInit x] -> EventM x ()
20612294runHoldInits holdInitRef dynInitRef mergeInitRef = do
@@ -2109,36 +2342,36 @@ clearEventEnv (EventEnv toAssignRef holdInitRef dynInitRef mergeUpdateRef mergeI
21092342-- | Run an event action outside of a frame
21102343runFrame :: forall x a. HasSpiderTimeline x => EventM x a -> SpiderHost x a --TODO: This function also needs to hold the mutex
21112344runFrame a = SpiderHost $ do
2112− let env = _spiderTimeline_eventEnv (spiderTimeline :: SpiderTimelineEnv x)
2345+ let env = _spiderTimeline_eventEnv $ unSTE (spiderTimeline :: SpiderTimelineEnv x)
21132346 let go = do
21142347 result <- a
21152348 runHoldInits (eventEnvHoldInits env) (eventEnvDynInits env) (eventEnvMergeInits env) -- This must happen before doing the assignments, in case subscribing a Hold causes existing Holds to be read by the newly-propagated events
21162349 return result
21172350 result <- runEventM go
21182351 toClear <- readIORef $ eventEnvClears env
2119− forM_ toClear $ \(Some.This (Clear ref)) -> {-# SCC "clear" #-} writeIORef ref Nothing
2352+ forM_ toClear $ \(Some (Clear ref)) -> {-# SCC "clear" #-} writeIORef ref Nothing
21202353 toClearInt <- readIORef $ eventEnvIntClears env
2121− forM_ toClearInt $ \(Some.This (IntClear ref)) -> {-# SCC "intClear" #-} writeIORef ref $! IntMap.empty
2354+ forM_ toClearInt $ \(Some (IntClear ref)) -> {-# SCC "intClear" #-} writeIORef ref $! IntMap.empty
21222355 toClearRoot <- readIORef $ eventEnvRootClears env
2123− forM_ toClearRoot $ \(Some.This (RootClear ref)) -> {-# SCC "rootClear" #-} writeIORef ref $! DMap.empty
2356+ forM_ toClearRoot $ \(Some (RootClear ref)) -> {-# SCC "rootClear" #-} writeIORef ref $! DMap.empty
21242357 toAssign <- readIORef $ eventEnvAssignments env
21252358 toReconnectRef <- newIORef []
21262359 coincidenceInfos <- readIORef $ eventEnvResetCoincidences env
21272360 forM_ toAssign $ \(SomeAssignment vRef iRef v) -> {-# SCC "assignment" #-} do
21282361 writeIORef vRef v
2129− when debugInvalidate $ putStrLn $ "Invalidating Hold"
2362+ traceInvalidate $ "Invalidating Hold"
21302363 writeIORef iRef =<< evaluate =<< invalidate toReconnectRef =<< readIORef iRef
21312364 mergeUpdates <- readIORef $ eventEnvMergeUpdates env
21322365 writeIORef (eventEnvMergeUpdates env) []
2133− when debugPropagate $ putStrLn "Updating merges"
2366+ tracePropagate (Proxy::Proxy x) $ "Updating merges"
21342367 mergeSubscriptionsToKill <- runEventM $ concat <$> mapM _someMergeUpdate_update mergeUpdates
2135− when debugPropagate $ putStrLn "Updating merges done"
2368+ tracePropagate (Proxy::Proxy x) $ "Updating merges done"
21362369 toReconnect <- readIORef toReconnectRef
21372370 clearEventEnv env
21382371 switchSubscriptionsToKill <- forM toReconnect $ \(SomeSwitchSubscribed subscribed) -> {-# SCC "switchSubscribed" #-} do
21392372 oldSubscription <- readIORef $ switchSubscribedCurrentParent subscribed
21402373 wi <- readIORef $ switchSubscribedOwnWeakInvalidator subscribed
2141− when debugInvalidate $ putStrLn $ "Finalizing invalidator for Switch" <> showNodeId subscribed
2374+ traceInvalidate $ "Finalizing invalidator for Switch" <> showNodeId subscribed
21422375 finalize wi
21432376 i <- evaluate $ switchSubscribedOwnInvalidator subscribed
21442377 wi' <- mkWeakPtrWithDebug i "wi'"
@@ -2152,7 +2385,7 @@ runFrame a = SpiderHost $ do
21522385 subscription <- unSpiderHost $ runFrame $ {-# SCC "subscribeSwitch" #-} subscribe e sub --TODO: Assert that the event isn't firing --TODO: This should not loop because none of the events should be firing, but still, it is inefficient
21532386 {-
21542387 stackTrace <- liftIO $ fmap renderStack $ ccsToStrings =<< (getCCSOf $! switchSubscribedParent subscribed)
2155− liftIO $ putStrLn $ (++stackTrace) $ "subd' subscribed to " ++ case e of
2388+ liftIO $ debugStrLn $ (++stackTrace) $ "subd' subscribed to " ++ case e of
21562389 EventRoot _ -> "EventRoot"
21572390 EventNever -> "EventNever"
21582391 _ -> "something else"
@@ -2167,7 +2400,7 @@ runFrame a = SpiderHost $ do
21672400 myHeight <- readIORef $ switchSubscribedHeight subscribed
21682401 when (parentHeight /= myHeight) $ do
21692402 writeIORef (switchSubscribedHeight subscribed) $! invalidHeight
2170− WeakBag.traverse (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight myHeight
2403+ WeakBag.traverse_ (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight myHeight
21712404 mapM_ _someMergeUpdate_invalidateHeight mergeUpdates --TODO: In addition to when the patch is completely empty, we should also not run this if it has some Nothing values, but none of them have actually had any effect; potentially, we could even check for Just values with no effect (e.g. by comparing their IORefs and ignoring them if they are unchanged); actually, we could just check if the new height is different
21722405 forM_ coincidenceInfos $ \(SomeResetCoincidence subscription mcs) -> do
21732406 unsubscribe subscription
@@ -2208,7 +2441,7 @@ invalidateCoincidenceHeight subscribed = do
22082441 oldHeight <- readIORef $ coincidenceSubscribedHeight subscribed
22092442 when (oldHeight /= invalidHeight) $ do
22102443 writeIORef (coincidenceSubscribedHeight subscribed) $! invalidHeight
2211− WeakBag.traverse (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
2444+ WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
22122445
22132446updateSwitchHeight :: Height -> SwitchSubscribed x a -> IO ()
22142447updateSwitchHeight new subscribed = do
@@ -2216,7 +2449,7 @@ updateSwitchHeight new subscribed = do
22162449 when (oldHeight == invalidHeight) $ do --TODO: This 'when' should probably be an assertion
22172450 when (new /= invalidHeight) $ do --TODO: This 'when' should probably be an assertion
22182451 writeIORef (switchSubscribedHeight subscribed) $! new
2219− WeakBag.traverse (switchSubscribedSubscribers subscribed) $ recalculateSubscriberHeight new
2452+ WeakBag.traverse_ (switchSubscribedSubscribers subscribed) $ recalculateSubscriberHeight new
22202453
22212454recalculateCoincidenceHeight :: CoincidenceSubscribed x a -> IO ()
22222455recalculateCoincidenceHeight subscribed = do
@@ -2225,7 +2458,7 @@ recalculateCoincidenceHeight subscribed = do
22252458 height <- calculateCoincidenceHeight subscribed
22262459 when (height /= invalidHeight) $ do
22272460 writeIORef (coincidenceSubscribedHeight subscribed) $! height
2228− WeakBag.traverse (coincidenceSubscribedSubscribers subscribed) $ recalculateSubscriberHeight height
2461+ WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ recalculateSubscriberHeight height
22292462
22302463calculateSwitchHeight :: SwitchSubscribed x a -> IO Height
22312464calculateSwitchHeight subscribed = getEventSubscribedHeight . _eventSubscription_subscribed =<< readIORef (switchSubscribedCurrentParent subscribed)
@@ -2287,6 +2520,8 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Event
22872520 {-# INLINABLE headE #-}
22882521 headE = R.slowHeadE
22892522-- headE (SpiderEvent e) = SpiderEvent <$> Reflex.Spider.Internal.headE e
2523+ {-# INLINABLE now #-}
2524+ now = nowSpiderEventM
22902525
22912526instance Reflex.Class.MonadSample (SpiderTimeline x) (SpiderPullM x) where
22922527 {-# INLINABLE sample #-}
@@ -2308,6 +2543,9 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Spide
23082543 {-# INLINABLE headE #-}
23092544 headE = R.slowHeadE
23102545-- headE (SpiderEvent e) = SpiderPushM $ SpiderEvent <$> Reflex.Spider.Internal.headE e
2546+ {-# INLINABLE now #-}
2547+ now = SpiderPushM nowSpiderEventM
2548+
23112549
23122550instance HasSpiderTimeline x => Monad (Reflex.Class.Dynamic (SpiderTimeline x)) where
23132551 {-# INLINE return #-}
@@ -2316,11 +2554,13 @@ instance HasSpiderTimeline x => Monad (Reflex.Class.Dynamic (SpiderTimeline x))
23162554 x >>= f = SpiderDynamic $ dynamicDynIdentity $ newJoinDyn $ newMapDyn (unSpiderDynamic . f) $ unSpiderDynamic x
23172555 {-# INLINE (>>) #-}
23182556 (>>) = (*>)
2557+#if !MIN_VERSION_base(4,13,0)
23192558 {-# INLINE fail #-}
23202559 fail _ = error "Dynamic does not support 'fail'"
2560+#endif
23212561
23222562{-# INLINABLE newJoinDyn #-}
2323−newJoinDyn :: HasSpiderTimeline x => Reflex.Spider.Internal.Dynamic x (Identity (Reflex.Spider.Internal.Dynamic x (Identity a))) -> Reflex.Spider.Internal.Dyn x (Identity a)
2563+newJoinDyn :: HasSpiderTimeline x => DynamicS x (Identity (DynamicS x (Identity a))) -> Reflex.Spider.Internal.Dyn x (Identity a)
23242564newJoinDyn d =
23252565 let readV0 = readBehaviorTracked . dynamicCurrent =<< readBehaviorTracked (dynamicCurrent d)
23262566 eOuter = Reflex.Spider.Internal.push (fmap (Just . Identity) . readBehaviorUntracked . dynamicCurrent . runIdentity) $ dynamicUpdated d
@@ -2369,6 +2609,9 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Spide
23692609 buildDynamic getV0 e = runFrame . runSpiderHostFrame $ Reflex.Class.buildDynamic getV0 e
23702610 {-# INLINABLE headE #-}
23712611 headE e = runFrame . runSpiderHostFrame $ Reflex.Class.headE e
2612+ {-# INLINABLE now #-}
2613+ now = runFrame . runSpiderHostFrame $ Reflex.Class.now
2614+
23722615
23732616instance HasSpiderTimeline x => Reflex.Class.MonadSample (SpiderTimeline x) (SpiderHostFrame x) where
23742617 sample = SpiderHostFrame . readBehaviorUntracked . unSpiderBehavior --TODO: This can cause problems with laziness, so we should get rid of it if we can
@@ -2385,6 +2628,8 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Spide
23852628 {-# INLINABLE headE #-}
23862629 headE = R.slowHeadE
23872630-- headE (SpiderEvent e) = SpiderHostFrame $ SpiderEvent <$> Reflex.Spider.Internal.headE e
2631+ {-# INLINABLE now #-}
2632+ now = SpiderHostFrame Reflex.Class.now
23882633
23892634instance HasSpiderTimeline x => Reflex.Class.MonadSample (SpiderTimeline x) (SpiderHost x) where
23902635 {-# INLINABLE sample #-}
@@ -2405,6 +2650,8 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Refle
24052650 buildDynamic getV0 e = Reflex.Spider.Internal.ReadPhase $ Reflex.Class.buildDynamic getV0 e
24062651 {-# INLINABLE headE #-}
24072652 headE e = Reflex.Spider.Internal.ReadPhase $ Reflex.Class.headE e
2653+ {-# INLINABLE now #-}
2654+ now = Reflex.Spider.Internal.ReadPhase Reflex.Class.now
24082655
24092656--------------------------------------------------------------------------------
24102657-- Deprecated items
@@ -2442,13 +2689,13 @@ instance HasSpiderTimeline x => Reflex.Host.Class.MonadReadEvent (SpiderTimeline
24422689 touch h
24432690 return result
24442691
2445−instance Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHost x) where
2692+instance HasSpiderTimeline x => Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHost x) where
24462693 newEventWithTrigger = SpiderHost . fmap SpiderEvent . newEventWithTriggerIO
24472694 newFanEventWithTrigger f = SpiderHost $ do
24482695 es <- newFanEventWithTriggerIO f
24492696 return $ Reflex.Class.EventSelector $ SpiderEvent . Reflex.Spider.Internal.select es
24502697
2451−instance Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHostFrame x) where
2698+instance HasSpiderTimeline x => Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHostFrame x) where
24522699 newEventWithTrigger = SpiderHostFrame . EventM . liftIO . fmap SpiderEvent . newEventWithTriggerIO
24532700 newFanEventWithTrigger f = SpiderHostFrame $ EventM $ liftIO $ do
24542701 es <- newFanEventWithTriggerIO f
@@ -2470,7 +2717,7 @@ unsafeNewSpiderTimelineEnv = do
24702717#ifdef DEBUG
24712718 depthRef <- newIORef 0
24722719#endif
2473− return $ SpiderTimelineEnv
2720+ return $ STE $ SpiderTimelineEnv
24742721 { _spiderTimeline_lock = lock
24752722 , _spiderTimeline_eventEnv = env
24762723#ifdef DEBUG
@@ -2480,19 +2727,19 @@ unsafeNewSpiderTimelineEnv = do
24802727
24812728-- | Create a new SpiderTimelineEnv
24822729newSpiderTimeline :: IO (Some SpiderTimelineEnv)
2483−newSpiderTimeline = withSpiderTimeline (pure . Some.This)
2730+newSpiderTimeline = withSpiderTimeline (pure . Some)
24842731
24852732data LocalSpiderTimeline (x :: Type) s
24862733
24872734instance Reifies s (SpiderTimelineEnv x) =>
24882735 HasSpiderTimeline (LocalSpiderTimeline x s) where
2489− spiderTimeline = localSpiderTimeline (Proxy :: Proxy s) $ reflect (Proxy :: Proxy s)
2736+ spiderTimeline = localSpiderTimeline Proxy $ reflect (Proxy :: Proxy s)
24902737
24912738localSpiderTimeline
2492− :: Proxy s
2739+ :: proxy s
24932740 -> SpiderTimelineEnv x
24942741 -> SpiderTimelineEnv (LocalSpiderTimeline x s)
2495−localSpiderTimeline _ = unsafeCoerce
2742+localSpiderTimeline _ = coerce
24962743
24972744-- | Pass a new timeline to the given function.
24982745withSpiderTimeline :: (forall x. HasSpiderTimeline x => SpiderTimelineEnv x -> IO r) -> IO r
@@ -2510,8 +2757,8 @@ instance HasSpiderTimeline x => R.Reflex (SpiderTimeline x) where
25102757 {-# SPECIALIZE instance R.Reflex (SpiderTimeline Global) #-}
25112758 newtype Behavior (SpiderTimeline x) a = SpiderBehavior { unSpiderBehavior :: Behavior x a }
25122759 newtype Event (SpiderTimeline x) a = SpiderEvent { unSpiderEvent :: Event x a }
2513− newtype Dynamic (SpiderTimeline x) a = SpiderDynamic { unSpiderDynamic :: Dynamic x (Identity a) } -- deriving (Functor, Applicative, Monad)
2514− newtype Incremental (SpiderTimeline x) p = SpiderIncremental { unSpiderIncremental :: Dynamic x p }
2760+ newtype Dynamic (SpiderTimeline x) a = SpiderDynamic { unSpiderDynamic :: DynamicS x (Identity a) } -- deriving (Functor, Applicative, Monad)
2761+ newtype Incremental (SpiderTimeline x) p = SpiderIncremental { unSpiderIncremental :: DynamicS x p }
25152762 type PullM (SpiderTimeline x) = SpiderPullM x
25162763 type PushM (SpiderTimeline x) = SpiderPushM x
25172764 {-# INLINABLE never #-}
@@ -2524,15 +2771,15 @@ instance HasSpiderTimeline x => R.Reflex (SpiderTimeline x) where
25242771 pushCheap f = SpiderEvent . pushCheap (coerce f) . unSpiderEvent
25252772 {-# INLINABLE pull #-}
25262773 pull = SpiderBehavior . pull . coerce
2774+ {-# INLINABLE fanG #-}
2775+ fanG e = R.EventSelectorG $ SpiderEvent . selectG (fanG (unSpiderEvent e))
25272776 {-# INLINABLE mergeG #-}
25282777 mergeG
2529− :: forall (k :: k2 -> *) q (v :: k2 -> *). GCompare k
2778+ :: forall k2 (k :: k2 -> *) q (v :: k2 -> *). GCompare k
25302779 => (forall a. q a -> R.Event (SpiderTimeline x) (v a))
25312780 -> DMap k q
25322781 -> R.Event (SpiderTimeline x) (DMap k v)
25332782 mergeG nt = SpiderEvent . mergeG (unSpiderEvent #. nt) . dynamicConst
2534− {-# INLINABLE fan #-}
2535− fan e = R.EventSelector $ SpiderEvent . select (fan (unSpiderEvent e))
25362783 {-# INLINABLE switch #-}
25372784 switch = SpiderEvent . switch . (coerce :: Behavior x (R.Event (SpiderTimeline x) a) -> Behavior x (Event x a)) . unSpiderBehavior
25382785 {-# INLINABLE coincidence #-}
@@ -2540,7 +2787,7 @@ instance HasSpiderTimeline x => R.Reflex (SpiderTimeline x) where
25402787 {-# INLINABLE current #-}
25412788 current = SpiderBehavior . dynamicCurrent . unSpiderDynamic
25422789 {-# INLINABLE updated #-}
2543− updated = coerce $ SpiderEvent . dynamicUpdated . unSpiderDynamic
2790+ updated = SpiderEvent #. dynamicUpdated .# fmap coerce . unSpiderDynamic
25442791 {-# INLINABLE unsafeBuildDynamic #-}
25452792 unsafeBuildDynamic readV0 v' = SpiderDynamic $ dynamicDynIdentity $ unsafeBuildDynamic (coerce readV0) $ coerce $ unSpiderEvent v'
25462793 {-# INLINABLE unsafeBuildIncremental #-}
@@ -2559,9 +2806,10 @@ instance HasSpiderTimeline x => R.Reflex (SpiderTimeline x) where
25592806 return $ Identity <$> apply p c --TODO: Avoid the redundant 'apply'
25602807 eventCoercion Coercion = Coercion
25612808 behaviorCoercion Coercion = Coercion
2562− dynamicCoercion = unsafeCoerce --TODO: How can we avoid this unsafeCoerce? This is safe only because we know how Identity works as a Patch instance
2809+ dynamicCoercion Coercion = Coercion
2810+ incrementalCoercion Coercion Coercion = Coercion
25632811 {-# INLINABLE mergeIntIncremental #-}
2564− mergeIntIncremental = SpiderEvent . mergeInt . (unsafeCoerce :: Dynamic x (PatchIntMap (R.Event (SpiderTimeline x) a)) -> Dynamic x (PatchIntMap (Event x a))) . unSpiderIncremental
2812+ mergeIntIncremental = SpiderEvent . mergeInt . coerce
25652813 {-# INLINABLE fanInt #-}
25662814 fanInt e = R.EventSelectorInt $ SpiderEvent . selectInt (fanInt (unSpiderEvent e))
25672815
@@ -2595,8 +2843,14 @@ instance Monad (SpiderHost x) where
25952843 SpiderHost x >> SpiderHost y = SpiderHost $ x >> y
25962844 {-# INLINABLE return #-}
25972845 return x = SpiderHost $ return x
2846+#if !MIN_VERSION_base(4,13,0)
25982847 {-# INLINABLE fail #-}
2599− fail s = SpiderHost $ fail s
2848+ fail = MonadFail.fail
2849+#endif
2850+
2851+instance MonadFail (SpiderHost x) where
2852+ {-# INLINABLE fail #-}
2853+ fail s = SpiderHost $ MonadFail.fail s
26002854
26012855-- | Run an action affecting the global Spider timeline; this will be guarded by
26022856-- a mutex for that timeline
@@ -2618,19 +2872,21 @@ instance Monad (SpiderHostFrame x) where
26182872 SpiderHostFrame x >> SpiderHostFrame y = SpiderHostFrame $ x >> y
26192873 {-# INLINABLE return #-}
26202874 return x = SpiderHostFrame $ return x
2875+#if !MIN_VERSION_base(4,13,0)
26212876 {-# INLINABLE fail #-}
26222877 fail s = SpiderHostFrame $ fail s
2878+#endif
26232879
26242880instance NotReady (SpiderTimeline x) (SpiderHostFrame x) where
26252881 notReadyUntil _ = pure ()
26262882 notReady = pure ()
26272883
2628−newEventWithTriggerIO :: (RootTrigger x a -> IO (IO ())) -> IO (Event x a)
2884+newEventWithTriggerIO :: forall x a. HasSpiderTimeline x => (RootTrigger x a -> IO (IO ())) -> IO (Event x a)
26292885newEventWithTriggerIO f = do
26302886 es <- newFanEventWithTriggerIO $ \Refl -> f
26312887 return $ select es Refl
26322888
2633−newFanEventWithTriggerIO :: GCompare k => (forall a. k a -> RootTrigger x a -> IO (IO ())) -> IO (EventSelector x k)
2889+newFanEventWithTriggerIO :: (HasSpiderTimeline x, GCompare k) => (forall a. k a -> RootTrigger x a -> IO (IO ())) -> IO (EventSelector x k)
26342890newFanEventWithTriggerIO f = do
26352891 occRef <- newIORef DMap.empty
26362892 subscribedRef <- newIORef DMap.empty
@@ -2664,3 +2920,11 @@ instance MonadAtomicRef (SpiderHostFrame x) where
26642920instance PrimMonad (SpiderHostFrame x) where
26652921 type PrimState (SpiderHostFrame x) = PrimState IO
26662922 primitive = SpiderHostFrame . EventM . primitive
2923+
2924+instance NotReady (SpiderTimeline x) (SpiderHost x) where
2925+ notReadyUntil _ = return ()
2926+ notReady = return ()
2927+
2928+instance HasSpiderTimeline x => NotReady (SpiderTimeline x) (PerformEventT (SpiderTimeline x) (SpiderHost x)) where
2929+ notReadyUntil _ = return ()
2930+ notReady = return ()