on 0cbcdde help sign in
.github/workflows/haskell.ymldeleted−41
since splitsnapshots
unifiedsplit
@@ -1,41 +0,0 @@
1−name: github-action
2−
3−on: [push, pull_request]
4−
5−jobs:
6− build:
7− strategy:
8− matrix:
9− ghc: ['8.4.4', '8.6.5', '8.8.4', '8.10.2']
10− os: ['ubuntu-latest', 'macos-latest']
11− runs-on: ${{ matrix.os }}
12−
13− name: GHC ${{ matrix.ghc }} on ${{ matrix.os }}
14− steps:
15− - uses: actions/checkout@v2
16− - uses: actions/setup-haskell@v1
17− with:
18− ghc-version: ${{ matrix.ghc }}
19− - name: Cache
20− uses: actions/cache@v1
21− env:
22− cache-name: cache-cabal
23− with:
24− path: ~/.cabal
25− key: ${{ runner.os }}-${{ matrix.ghc }}-build-${{ env.cache-name }}-${{ hashFiles('**/*.cabal') }}-${{ hashFiles('**/cabal.project') }}
26− restore-keys: |
27− ${{ runner.os }}-${{ matrix.ghc }}-build-${{ env.cache-name }}-
28− ${{ runner.os }}-${{ matrix.ghc }}-build-
29− ${{ runner.os }}-${{ matrix.ghc }}-
30− ${{ runner.os }}
31−
32− - name: Install dependencies
33− run: |
34− cabal update
35− cabal build --only-dependencies --enable-tests --enable-benchmarks
36− - name: Build
37− run: cabal build --enable-tests --enable-benchmarks all
38− - name: Run tests
39− run: cabal test all
40− - name: Build Docs
41− run: cabal haddock
.travis.ymlnew file+173
@@ -0,0 +1,173 @@
1+# This Travis job script has been generated by a script via
2+#
3+# haskell-ci '--config=cabal.haskell-ci' 'cabal.project'
4+#
5+# For more information, see https://github.com/haskell-CI/haskell-ci
6+#
7+# version: 0.3.20190814
8+#
9+language: c
10+dist: xenial
11+sudo: required
12+git:
13+ # whether to recursively clone submodules
14+ submodules: false
15+cache:
16+ directories:
17+ - $HOME/.cabal/packages
18+ - $HOME/.cabal/store
19+before_cache:
20+ - rm -fv $CABALHOME/packages/hackage.haskell.org/build-reports.log
21+ # remove files that are regenerated by 'cabal update'
22+ - rm -fv $CABALHOME/packages/hackage.haskell.org/00-index.*
23+ - rm -fv $CABALHOME/packages/hackage.haskell.org/*.json
24+ - rm -fv $CABALHOME/packages/hackage.haskell.org/01-index.cache
25+ - rm -fv $CABALHOME/packages/hackage.haskell.org/01-index.tar
26+ - rm -fv $CABALHOME/packages/hackage.haskell.org/01-index.tar.idx
27+ - rm -rfv $CABALHOME/packages/head.hackage
28+matrix:
29+ include:
30+ - compiler: ghcjs-8.4
31+ addons: {"apt":{"sources":["hvr-ghc"],"packages":["cabal-install-3.0"]}}
32+ - compiler: ghc-8.8.1
33+ addons: {"apt":{"sources":["hvr-ghc"],"packages":["ghc-8.8.1","cabal-install-3.0"]}}
34+ - compiler: ghc-8.6.5
35+ addons: {"apt":{"sources":["hvr-ghc"],"packages":["ghc-8.6.5","cabal-install-2.4"]}}
36+ - compiler: ghc-8.4.4
37+ addons: {"apt":{"sources":["hvr-ghc"],"packages":["ghc-8.4.4","cabal-install-2.4"]}}
38+ - compiler: ghc-8.2.2
39+ addons: {"apt":{"sources":["hvr-ghc"],"packages":["ghc-8.2.2","cabal-install-2.4"]}}
40+ - compiler: ghc-8.0.2
41+ addons: {"apt":{"sources":["hvr-ghc"],"packages":["ghc-8.0.2","cabal-install-2.4"]}}
42+before_install:
43+ - |
44+ if [ "$TRAVIS_OS_NAME" = "linux" ]; then
45+ sudo add-apt-repository -y ppa:hvr/ghcjs;
46+ curl -s https://deb.nodesource.com/gpgkey/nodesource.gpg.key | sudo apt-key add -
47+ sudo apt-add-repository 'https://deb.nodesource.com/node_8.x xenial main'
48+ sudo apt-get update;
49+ sudo apt-get install $CC cabal-install-3.0 nodejs;
50+ fi
51+ - HC=$(echo "/opt/$CC/bin/ghc" | sed 's/-/\//')
52+ - WITHCOMPILER="-w $HC"
53+ - |
54+ if echo $CC | grep -q ghcjs; then
55+ GHCJS=true
56+ HC=${HC}js
57+ WITHCOMPILER="--ghcjs ${WITHCOMPILER}js"
58+ else
59+ GHCJS=false;
60+ fi
61+ - if $GHCJS ; then sudo apt-get install -y ghc-8.4.4 ; fi
62+ - if $GHCJS ; then PATH="/opt/ghc/8.4.4/bin:$PATH" ; fi
63+ - HCPKG="$HC-pkg"
64+ - unset CC
65+ - CABAL=/opt/ghc/bin/cabal
66+ - CABALHOME=$HOME/.cabal
67+ - export PATH="$CABALHOME/bin:$PATH"
68+ - TOP=$(pwd)
69+ - "HCNUMVER=$(${HC} --numeric-version|perl -ne '/^(\\d+)\\.(\\d+)\\.(\\d+)(\\.(\\d+))?$/; print(10000 * $1 + 100 * $2 + ($3 == 0 ? $5 != 1 : $3))')"
70+ - echo $HCNUMVER
71+ - CABAL="$CABAL -vnormal+nowrap+markoutput"
72+ - set -o pipefail
73+ - |
74+ echo 'function blue(s) { printf "\033[0;34m" s "\033[0m " }' >> .colorful.awk
75+ echo 'BEGIN { state = "output"; }' >> .colorful.awk
76+ echo '/^-----BEGIN CABAL OUTPUT-----$/ { state = "cabal" }' >> .colorful.awk
77+ echo '/^-----END CABAL OUTPUT-----$/ { state = "output" }' >> .colorful.awk
78+ echo '!/^(-----BEGIN CABAL OUTPUT-----|-----END CABAL OUTPUT-----)/ {' >> .colorful.awk
79+ echo ' if (state == "cabal") {' >> .colorful.awk
80+ echo ' print blue($0)' >> .colorful.awk
81+ echo ' } else {' >> .colorful.awk
82+ echo ' print $0' >> .colorful.awk
83+ echo ' }' >> .colorful.awk
84+ echo '}' >> .colorful.awk
85+ - cat .colorful.awk
86+ - |
87+ color_cabal_output () {
88+ awk -f $TOP/.colorful.awk
89+ }
90+ - echo text | color_cabal_output
91+install:
92+ - ${CABAL} --version
93+ - echo "$(${HC} --version) [$(${HC} --print-project-git-commit-id 2> /dev/null || echo '?')]"
94+ - node --version
95+ - echo $GHCJS
96+ - TEST=--enable-tests
97+ - BENCH=--enable-benchmarks
98+ - BENCH=--disable-benchmarks
99+ - HEADHACKAGE=false
100+ - rm -f $CABALHOME/config
101+ - |
102+ echo "verbose: normal +nowrap +markoutput" >> $CABALHOME/config
103+ echo "remote-build-reporting: anonymous" >> $CABALHOME/config
104+ echo "write-ghc-environment-files: always" >> $CABALHOME/config
105+ echo "remote-repo-cache: $CABALHOME/packages" >> $CABALHOME/config
106+ echo "logs-dir: $CABALHOME/logs" >> $CABALHOME/config
107+ echo "world-file: $CABALHOME/world" >> $CABALHOME/config
108+ echo "extra-prog-path: $CABALHOME/bin" >> $CABALHOME/config
109+ echo "symlink-bindir: $CABALHOME/bin" >> $CABALHOME/config
110+ echo "installdir: $CABALHOME/bin" >> $CABALHOME/config
111+ echo "build-summary: $CABALHOME/logs/build.log" >> $CABALHOME/config
112+ echo "store-dir: $CABALHOME/store" >> $CABALHOME/config
113+ echo "install-dirs user" >> $CABALHOME/config
114+ echo " prefix: $CABALHOME" >> $CABALHOME/config
115+ echo "repository hackage.haskell.org" >> $CABALHOME/config
116+ echo " url: http://hackage.haskell.org/" >> $CABALHOME/config
117+ - cat $CABALHOME/config
118+ - rm -fv cabal.project cabal.project.local cabal.project.freeze
119+ - travis_retry ${CABAL} v2-update -v
120+ - if $GHCJS ; then (cd /tmp && ${CABAL} v2-install -w ghc-8.4.4 happy) ; fi
121+ # Generate cabal.project
122+ - rm -rf cabal.project cabal.project.local cabal.project.freeze
123+ - touch cabal.project
124+ - |
125+ echo "packages: ." >> cabal.project
126+ - |
127+ - cat cabal.project || true
128+ - cat cabal.project.local || true
129+ - if [ -f "./configure.ac" ]; then (cd "." && autoreconf -i); fi
130+ - ${CABAL} v2-freeze $WITHCOMPILER ${TEST} ${BENCH} | color_cabal_output
131+ - "cat cabal.project.freeze | sed -E 's/^(constraints: *| *)//' | sed 's/any.//'"
132+ - rm cabal.project.freeze
133+script:
134+ - DISTDIR=$(mktemp -d /tmp/dist-test.XXXX)
135+ # Packaging...
136+ - ${CABAL} v2-sdist all | color_cabal_output
137+ # Unpacking...
138+ - mv dist-newstyle/sdist/*.tar.gz ${DISTDIR}/
139+ - cd ${DISTDIR} || false
140+ - find . -maxdepth 1 -type f -name '*.tar.gz' -exec tar -xvf '{}' \;
141+ - find . -maxdepth 1 -type f -name '*.tar.gz' -exec rm '{}' \;
142+ - PKGDIR_reflex="$(find . -maxdepth 1 -type d -regex '.*/reflex-[0-9.]*')"
143+ # Generate cabal.project
144+ - rm -rf cabal.project cabal.project.local cabal.project.freeze
145+ - touch cabal.project
146+ - |
147+ echo "packages: ${PKGDIR_reflex}" >> cabal.project
148+ - |
149+ - cat cabal.project || true
150+ - cat cabal.project.local || true
151+ # Building...
152+ # this builds all libraries and executables (without tests/benchmarks)
153+ - ${CABAL} v2-build $WITHCOMPILER --disable-tests --disable-benchmarks all | color_cabal_output
154+ # Building with tests and benchmarks...
155+ # build & run tests, build benchmarks
156+ - ${CABAL} v2-build $WITHCOMPILER ${TEST} ${BENCH} all | color_cabal_output
157+ # Testing...
158+ - if ! $GHCJS ; then ${CABAL} v2-test $WITHCOMPILER ${TEST} ${BENCH} all | color_cabal_output ; fi
159+ # cabal check...
160+ - (cd ${PKGDIR_reflex} && ${CABAL} -vnormal check)
161+ # haddock...
162+ - if ! $GHCJS ; then ${CABAL} v2-haddock $WITHCOMPILER ${TEST} ${BENCH} all | color_cabal_output ; fi
163+ # Constraint sets
164+ - rm -rf cabal.project.local
165+ # Constraint set no-th
166+ - ${CABAL} v2-build $WITHCOMPILER --disable-tests --disable-benchmarks --constraint='reflex -use-template-haskell' all | color_cabal_output
167+ # Constraint set old-these
168+ - ${CABAL} v2-build $WITHCOMPILER --disable-tests --disable-benchmarks --constraint='these <1' all | color_cabal_output
169+ # Constraint set old-witherable
170+ - ${CABAL} v2-build $WITHCOMPILER --disable-tests --disable-benchmarks --constraint='witherable <0.3.2' all | color_cabal_output
171+
172+# REGENDATA ["--config=cabal.haskell-ci","cabal.project"]
173+# EOF
ChangeLog.md−71
@@ -1,76 +1,5 @@
1# Revision history for reflex
1# Revision history for reflex
2
2
3−## 0.8.2.0
4−
5−* Add `matchResponseMapWithRequests`, which it similar to `matchResponsesWithRequests` but allows processing of multiple responses at once.
6−
7−## 0.8.1.1
8−
9−* Allow newer hlint for older GHCs, and add upper bound for newer GHCs
10−
11−## 0.8.1.0
12−
13−* Add support for GHC 8.10
14−* Drop support for GHC < 8.4
15−
16−## 0.8.0.0
17−
18−* Replace 0.7.2.0 with 0.8.0.0 to reflect the `MonadHold` interface change. Deprecates 0.7.2.0.
19−
20−## 0.7.2.0 -- *Deprecated*
21−
22−* ([#416](https://github.com/reflex-frp/reflex/pull/416)) Add `now :: m (Event t ())` to `MonadHold`.
23−* Extend some dependency version bounds
24−* Fix HLint 3 test
25−
26−## 0.7.1.1
27−
28−*Backport release*.
29−Changes do not carry forward to 0.7.2.0.
30−
31−* Add support for GHC 8.10
32−* Drop support for GHC < 8.4
33−* Extend some dependency version bounds
34−* Fix HLint 3 test
35−
36−## 0.7.1.0
37−
38−* ([#413](https://github.com/reflex-frp/reflex/pull/413), [#417](https://github.com/reflex-frp/reflex/pull/417)) Add `Reflex.Host.Headless` module which provides `runHeadlessApp` as an easy way to run a Reflex network in a "headless" environment.
39−* ([#420](https://github.com/reflex-frp/reflex/pull/420)) Add a [`Data.Zip.Unzip`](https://hackage.haskell.org/package/semialign-1.1/docs/Data-Zip.html#t:Unzip) instance for `Event`.
40−* ([#419](https://github.com/reflex-frp/reflex/pull/419)) Add `distributeIntMapOverDynPure` and `joinDynThroughIntMap` as convenience functions for working with `Dynamic` `IntMap`s.
41−
42−
43−## 0.7.0.0
44−
45−* Add lifting instances for most classes to `Reflex.Profiled.Profiled`. ([#398](https://github.com/reflex-frp/reflex/pull/398))
46−* Class `MonadQuery t q m` now has a `Monad m` superclass constraint. ([#400](https://github.com/reflex-frp/reflex/pull/400))
47−* **(Breaking change)** Rename class `MonadBehaviorWriter` -> `BehaviorWriter` for consistency with `EventWriter`/`DynamicWriter`. ([#401](https://github.com/reflex-frp/reflex/pull/401))
48−* Introduce deprecated alias `MonadBehaviorWriter = BehaviorWriter`. ([#401](https://github.com/reflex-frp/reflex/pull/401))
49−* Fix bug in spider where event subscriptions would be prematurely finalized due to over-aggressive inlining. ([#409](https://github.com/reflex-frp/reflex/pull/409))
50−* Add instances of `PerformEvent` and `TriggerEvent` for `MaybeT`. ([#395](https://github.com/reflex-frp/reflex/pull/395))
51−
52−## 0.6.4.1
53−
54−* Fix a bug in the Reflex Profiled transformer where
55− `Reflex.Class.mergeIncrementalG` and
56− `Reflex.Class.mergeIncrementalWithMoveG` implementations referenced
57− itself instead of the inner transformed timeline, causing an
58− infinite loop.
59−
60−## 0.6.4
61−
62−* Support GHC 8.8
63−
64−* Add `Reflex.Query.Base.mapQueryT`. See that module for documentation
65−
66−* The `Reflex.Patch.*` modules were moved to the `patch` library.
67− They are `Data.Patch.*` there, but reexported under their old names for backwards compatability here.
68−
69−* Additional instances for `Query` classes for basic types.
70−
71−* Add cabal flags `debug-propagation` and `debug-event-cycles` to build in debugging
72− code for performance and for cyclic dependencies between events
73−
74## 0.6.3
3## 0.6.3
75
4
76* `Data.WeakBag.traverse` and `Data.FastWeakBag.traverse` have been deprecated.
5* `Data.WeakBag.traverse` and `Data.FastWeakBag.traverse` have been deprecated.
Quickref.md−1
@@ -54,7 +54,6 @@ Since MonadHold depends on MonadSample, any [S] function also runs in [H] contex
54[ ] difference :: Event a -> Event b -> Event a
54[ ] difference :: Event a -> Event b -> Event a
55[ ] align :: Event a -> Event b -> Event (These a b)
55[ ] align :: Event a -> Event b -> Event (These a b)
56[ ] alignWith :: (These a b -> c) -> Event a -> Event b -> Event c
56[ ] alignWith :: (These a b -> c) -> Event a -> Event b -> Event c
57− -- Note align functions from Data.Align in semialign package
58[ ] mergeWith :: (a -> a -> a) -> [Event a] -> Event a
57[ ] mergeWith :: (a -> a -> a) -> [Event a] -> Event a
59[ ] leftmost :: [Event a] -> Event a
58[ ] leftmost :: [Event a] -> Event a
60[ ] mergeList :: [Event a] -> Event (NonEmpty a)
59[ ] mergeList :: [Event a] -> Event (NonEmpty a)
README.md+17−15
@@ -1,23 +1,25 @@
1−# [Reflex](https://reflex-frp.org/)
1+## [Reflex](https://reflex-frp.org/)
2
2
3−[![Haskell](https://img.shields.io/badge/language-Haskell-orange.svg)](https://haskell.org) [![Hackage](https://img.shields.io/hackage/v/reflex.svg)](https://hackage.haskell.org/package/reflex) [![Hackage CI](https://matrix.hackage.haskell.org/api/v2/packages/reflex/badge)](https://matrix.hackage.haskell.org/#/package/reflex) [![BSD3 License](https://img.shields.io/badge/license-BSD3-blue.svg)](https://github.com/reflex-frp/reflex/blob/master/LICENSE)
3+[![Hackage](https://img.shields.io/hackage/v/reflex.svg)](http://hackage.haskell.org/package/reflex)
4
4
5−Interactive programs without callbacks or side-effects. Functional Reactive Programming (FRP) uses composable events and time-varying values to describe interactive systems as pure functions. Just like other pure functional code, functional reactive code is easier to get right on the first try, maintain, and reuse.
5+### Practical Functional Reactive Programming
6
6
7−Reflex is a fully-deterministic, higher-order Functional Reactive Programming interface and an engine that efficiently implements that interface.
7+Reflex is a fully-deterministic, higher-order Functional Reactive Programming (FRP) interface and an engine that efficiently implements that interface.
8
8
9−**Visit https://reflex-frp.org for more information, tutorials, documentation and [examples](https://examples.reflex-frp.org/).**
9+[Reflex-DOM](https://github.com/reflex-frp/reflex-dom) is a framework built on Reflex that facilitates the development of web pages, including highly-interactive single-page apps.
10
10
11−## Resources
11+A summary of Reflex functions is available in the [quick reference](Quickref.md).
12
12
13−* [Official Website](https://reflex-frp.org)
13+**Visit https://reflex-frp.org/ for more information, tutorials, documentation and [examples](https://examples.reflex-frp.org/).**
14−* [Quick Reference](Quickref.md)
15−* [Reflex-DOM](https://github.com/reflex-frp/reflex-dom): A framework built on Reflex that facilitates the development of web pages, including highly-interactive single-page apps.
16−* [Obelisk](https://github.com/obsidiansystems/obelisk#obelisk): A framework built on Reflex and Reflex-DOM for functional reactive web and mobile applications, with batteries included.
17−* [Get started with Reflex](https://github.com/reflex-frp/reflex-platform)
18−* [/r/reflexfrp](https://www.reddit.com/r/reflexfrp)
19−* [irc.freenode.net #reflex-frp](http://webchat.freenode.net?channels=%23reflex-frp&uio=d4)
20
14
21−## Hacking
15+### Resources
16+[Get started with Reflex](https://github.com/reflex-frp/reflex-platform)
22
17
23−From the root of a [Reflex Platform](https://github.com/reflex-frp/reflex-platform) checkout, run `./scripts/hack-on haskell-overlays/reflex-packages/dep/reflex`. This will check out the reflex source code into the `haskell-overlays/reflex-packages/dep/reflex` directory. You can then point that checkout at your fork, make changes, etc. Use the `./try-reflex` or `./scripts/work-on` scripts to start a shell in which you can test your changes.
18+[/r/reflexfrp](https://www.reddit.com/r/reflexfrp)
19+
20+[irc.freenode.net #reflex-frp](http://webchat.freenode.net?channels=%23reflex-frp&uio=d4)
21+
22+### Hacking
23+
24+Use the `./scripts/hack-on reflex` script in [Reflex Platform](https://github.com/reflex-frp/reflex-platform) to checkout the source code of `reflex` locally in `reflex-platform/reflex` directory.
25+Then do modifications to the source in place, and use the `./try-reflex` or `./scripts/work-on` scripts to create the shell to test your changes.
cabal.haskell-ci−7
@@ -10,14 +10,7 @@ constraint-set no-th
10 constraints: reflex -use-template-haskell
10 constraints: reflex -use-template-haskell
11
11
12constraint-set old-these
12constraint-set old-these
13− ghc: <8.8
14 constraints: these <1
13 constraints: these <1
15
14
16constraint-set old-witherable
15constraint-set old-witherable
17 constraints: witherable <0.3.2
16 constraints: witherable <0.3.2
18−
19−constraint-set debug-propagation
20− constraints: reflex +debug-propagation
21−
22−constraint-set debug-cycles
23− constraints: reflex +debug-cycles
cabal.project.freezenew file+1
@@ -0,0 +1 @@
1+constraints: any.text < 1.2.4.0
dep/reflex-platform/github.json+2−2
@@ -2,6 +2,6 @@
2 "owner": "reflex-frp",
2 "owner": "reflex-frp",
3 "repo": "reflex-platform",
3 "repo": "reflex-platform",
4 "branch": "develop",
4 "branch": "develop",
5− "rev": "f628398d076243a0851b27e625b37f65dff9b89b",
5+ "rev": "e7b76dd552a10916c7d8702c11292dac4f4299ea",
6− "sha256": "0sl0hf1glgyb1vmf2mhw4r9ipmcqk1y19d3wsic7dix2jwywzrh9"
6+ "sha256": "0s1183arrwldcs50qhzgnv94v24n9bgq6dfq64wp0a3q2nzyvgwh"
7}
7}
reflex.cabal+33−134
@@ -1,17 +1,7 @@
1Name: reflex
1Name: reflex
2−Version: 0.8.2.0
2+Version: 0.6.3
3Synopsis: Higher-order Functional Reactive Programming
3Synopsis: Higher-order Functional Reactive Programming
4−Description:
5− Interactive programs without callbacks or side-effects.
6− Functional Reactive Programming (FRP) uses composable events and time-varying
7− values to describe interactive systems as pure functions.
8− Just like other pure functional code, functional reactive code is easier
9− to get right on the first try, maintain, and reuse.
10− .
11− Reflex is a fully-deterministic, higher-order Functional Reactive Programming
4+Description: Reflex is a high-performance, deterministic, higher-order Functional Reactive Programming system
12− interface and an engine that efficiently implements that interface.
13− .
14− <https://reflex-frp.org>
15License: BSD3
5License: BSD3
16License-file: LICENSE
6License-file: LICENSE
17Author: Ryan Trinkle
7Author: Ryan Trinkle
@@ -19,7 +9,7 @@ Maintainer: ryan.trinkle@gmail.com
19Stability: Experimental
9Stability: Experimental
20Category: FRP
10Category: FRP
21Build-type: Simple
11Build-type: Simple
22−Cabal-version: 1.22
12+Cabal-version: >=1.9.2
23homepage: https://reflex-frp.org
13homepage: https://reflex-frp.org
24bug-reports: https://github.com/reflex-frp/reflex/issues
14bug-reports: https://github.com/reflex-frp/reflex/issues
25extra-source-files:
15extra-source-files:
@@ -28,8 +18,8 @@ extra-source-files:
28 ChangeLog.md
18 ChangeLog.md
29
19
30tested-with:
20tested-with:
31− GHC ==8.4.4 || ==8.6.5 || ==8.8.1 || ==8.10.2,
21+ GHC ==8.0.2 || ==8.2.2 || ==8.4.4 || ==8.6.5 || ==8.8.1,
32− GHCJS ==8.6
22+ GHCJS ==8.4
33
23
34flag use-reflex-optimizer
24flag use-reflex-optimizer
35 description: Use the GHC plugin Reflex.Optimizer on some of the modules in the package. This is still experimental.
25 description: Use the GHC plugin Reflex.Optimizer on some of the modules in the package. This is still experimental.
@@ -51,43 +41,29 @@ flag fast-weak
51 default: False
41 default: False
52 manual: True
42 manual: True
53
43
54−flag debug-propagation
55− description: Enable debugging of spider internals
56− default: False
57− manual: True
58−
59−flag debug-cycles
60− description: Enable debugging of event cycles
61− default: False
62− manual: True
63−
64flag split-these
44flag split-these
65 description: Use split these/semialign packages
45 description: Use split these/semialign packages
66 manual: False
46 manual: False
67 default: True
47 default: True
68
48
69library
49library
70− default-language: Haskell2010
71 hs-source-dirs: src
50 hs-source-dirs: src
72 build-depends:
51 build-depends:
73 MemoTrie == 0.6.*,
52 MemoTrie == 0.6.*,
74− base >= 4.11 && < 4.15,
53+ base >= 4.9 && < 4.14,
75 bifunctors >= 5.2 && < 5.6,
54 bifunctors >= 5.2 && < 5.6,
76 comonad >= 5.0.4 && < 5.1,
55 comonad >= 5.0.4 && < 5.1,
77− constraints >= 0.10 && <0.14,
78 constraints-extras >= 0.3 && < 0.4,
56 constraints-extras >= 0.3 && < 0.4,
79 containers >= 0.6 && < 0.7,
57 containers >= 0.6 && < 0.7,
80 data-default >= 0.5 && < 0.8,
58 data-default >= 0.5 && < 0.8,
81− dependent-map >= 0.3 && < 0.5,
59+ dependent-map >= 0.3 && < 0.4,
82 exception-transformers == 0.4.*,
60 exception-transformers == 0.4.*,
83 lens >= 4.7 && < 5,
61 lens >= 4.7 && < 5,
84− mmorph >= 1.0 && < 1.2,
85 monad-control >= 1.0.1 && < 1.1,
62 monad-control >= 1.0.1 && < 1.1,
86 mtl >= 2.1 && < 2.3,
63 mtl >= 2.1 && < 2.3,
87− patch >= 0.0.1 && < 0.1,
88− prim-uniq >= 0.1.0.1 && < 0.3,
64+ prim-uniq >= 0.1.0.1 && < 0.2,
89 primitive >= 0.5 && < 0.8,
65 primitive >= 0.5 && < 0.8,
90− profunctors >= 5.3 && < 5.7,
66+ profunctors >= 5.3 && < 5.6,
91 random == 1.1.*,
67 random == 1.1.*,
92 ref-tf == 0.4.*,
68 ref-tf == 0.4.*,
93 reflection == 2.1.*,
69 reflection == 2.1.*,
@@ -97,10 +73,10 @@ library
97 time >= 1.4 && < 1.10,
73 time >= 1.4 && < 1.10,
98 transformers >= 0.5.6.0 && < 0.6,
74 transformers >= 0.5.6.0 && < 0.6,
99 unbounded-delays >= 0.1.0.0 && < 0.2,
75 unbounded-delays >= 0.1.0.0 && < 0.2,
100− witherable >= 0.3 && < 0.5
76+ witherable >= 0.3 && < 0.3.2
101
77
102 if flag(split-these)
78 if flag(split-these)
103− build-depends: these >= 1 && <1.2,
79+ build-depends: these >= 1 && <1.1,
104 semialign >=1 && <1.2,
80 semialign >=1 && <1.2,
105 monoidal-containers >= 0.6 && < 0.7
81 monoidal-containers >= 0.6 && < 0.7
106 else
82 else
@@ -112,6 +88,7 @@ library
112 Data.AppendMap,
88 Data.AppendMap,
113 Data.FastMutableIntMap,
89 Data.FastMutableIntMap,
114 Data.FastWeakBag,
90 Data.FastWeakBag,
91+ Data.Functor.Misc,
115 Data.Map.Misc,
92 Data.Map.Misc,
116 Data.WeakBag,
93 Data.WeakBag,
117 Reflex,
94 Reflex,
@@ -131,9 +108,15 @@ library
131 Reflex.FastWeak,
108 Reflex.FastWeak,
132 Reflex.FunctorMaybe,
109 Reflex.FunctorMaybe,
133 Reflex.Host.Class,
110 Reflex.Host.Class,
134− Reflex.Host.Headless,
135 Reflex.Network,
111 Reflex.Network,
136 Reflex.NotReady.Class,
112 Reflex.NotReady.Class,
113+ Reflex.Patch,
114+ Reflex.Patch.Class,
115+ Reflex.Patch.DMap,
116+ Reflex.Patch.DMapWithMove,
117+ Reflex.Patch.IntMap,
118+ Reflex.Patch.Map,
119+ Reflex.Patch.MapWithMove,
137 Reflex.PerformEvent.Base,
120 Reflex.PerformEvent.Base,
138 Reflex.PerformEvent.Class,
121 Reflex.PerformEvent.Class,
139 Reflex.PostBuild.Base,
122 Reflex.PostBuild.Base,
@@ -152,57 +135,38 @@ library
152 Reflex.Widget.Basic,
135 Reflex.Widget.Basic,
153 Reflex.Workflow
136 Reflex.Workflow
154
137
155− reexported-modules:
156− patch:Data.Functor.Misc,
157− patch:Data.Patch as Reflex.Patch,
158− patch:Data.Patch.Class as Reflex.Patch.Class,
159− patch:Data.Patch.DMap as Reflex.Patch.DMap,
160− patch:Data.Patch.DMapWithMove as Reflex.Patch.DMapWithMove,
161− patch:Data.Patch.IntMap as Reflex.Patch.IntMap,
162− patch:Data.Patch.Map as Reflex.Patch.Map,
163− patch:Data.Patch.MapWithMove as Reflex.Patch.MapWithMove
164−
165 ghc-options: -Wall -fwarn-redundant-constraints -fwarn-tabs -funbox-strict-fields -O2 -fspecialise-aggressively
138 ghc-options: -Wall -fwarn-redundant-constraints -fwarn-tabs -funbox-strict-fields -O2 -fspecialise-aggressively
166
139
167 if flag(debug-trace-events)
140 if flag(debug-trace-events)
168 cpp-options: -DDEBUG_TRACE_EVENTS
141 cpp-options: -DDEBUG_TRACE_EVENTS
169− build-depends:
142+ build-depends: bytestring
170− bytestring >= 0.10.8 && < 0.11
171
143
172 if flag(use-reflex-optimizer)
144 if flag(use-reflex-optimizer)
173 cpp-options: -DUSE_REFLEX_OPTIMIZER
145 cpp-options: -DUSE_REFLEX_OPTIMIZER
174 build-depends: ghc
146 build-depends: ghc
175 exposed-modules: Reflex.Optimizer
147 exposed-modules: Reflex.Optimizer
176
148
177− if flag(debug-propagation)
178− cpp-options: -DDEBUG -DDEBUG_TRACE_PROPAGATION -DDEBUG_TRACE_INVALIDATION
179−
180− if flag(debug-cycles)
181− cpp-options: -DDEBUG_CYCLES
182−
183 if flag(use-template-haskell)
149 if flag(use-template-haskell)
184 cpp-options: -DUSE_TEMPLATE_HASKELL
150 cpp-options: -DUSE_TEMPLATE_HASKELL
185 build-depends:
151 build-depends:
186− dependent-sum >= 0.6 && < 0.8,
152+ dependent-sum >= 0.6 && < 0.7,
187− haskell-src-exts >= 1.16 && < 1.24,
153+ haskell-src-exts >= 1.16 && < 1.23,
188 haskell-src-meta >= 0.6 && < 0.9,
154 haskell-src-meta >= 0.6 && < 0.9,
189− template-haskell >= 2.9 && < 2.17
155+ template-haskell >= 2.9 && < 2.16
190 exposed-modules:
156 exposed-modules:
191 Reflex.Dynamic.TH
157 Reflex.Dynamic.TH
192 other-extensions: TemplateHaskell
158 other-extensions: TemplateHaskell
193 else
159 else
194 build-depends:
160 build-depends:
195− dependent-sum >= 0.6 && < 0.8
161+ dependent-sum >= 0.6 && < 0.7
196
162
197 if flag(fast-weak) && impl(ghcjs)
163 if flag(fast-weak) && impl(ghcjs)
198 cpp-options: -DGHCJS_FAST_WEAK
164 cpp-options: -DGHCJS_FAST_WEAK
199
165
200 if impl(ghcjs)
166 if impl(ghcjs)
201− build-depends:
167+ build-depends: ghcjs-base
202− ghcjs-base == 0.2.*
203
168
204test-suite semantics
169test-suite semantics
205− default-language: Haskell2010
206 type: exitcode-stdio-1.0
170 type: exitcode-stdio-1.0
207 main-is: semantics.hs
171 main-is: semantics.hs
208 hs-source-dirs: test
172 hs-source-dirs: test
@@ -228,7 +192,6 @@ test-suite semantics
228 Reflex.TestPlan
192 Reflex.TestPlan
229
193
230test-suite CrossImpl
194test-suite CrossImpl
231− default-language: Haskell2010
232 type: exitcode-stdio-1.0
195 type: exitcode-stdio-1.0
233 main-is: Reflex/Test/CrossImpl.hs
196 main-is: Reflex/Test/CrossImpl.hs
234 hs-source-dirs: test
197 hs-source-dirs: test
@@ -250,7 +213,6 @@ test-suite CrossImpl
250 Reflex.Plan.Pure
213 Reflex.Plan.Pure
251
214
252test-suite hlint
215test-suite hlint
253− default-language: Haskell2010
254 type: exitcode-stdio-1.0
216 type: exitcode-stdio-1.0
255 main-is: hlint.hs
217 main-is: hlint.hs
256 hs-source-dirs: test
218 hs-source-dirs: test
@@ -258,15 +220,11 @@ test-suite hlint
258 , directory
220 , directory
259 , filepath
221 , filepath
260 , filemanip
222 , filemanip
261− if impl(ghc >= 8.8)
262− build-depends: hlint >= 3 && < 4
263− else
264− build-depends: hlint (< 2.1 || >= 2.2.2) && < 4
223+ , hlint < 2.1 || >= 2.2.2
265 if impl(ghcjs)
224 if impl(ghcjs)
266 buildable: False
225 buildable: False
267
226
268test-suite EventWriterT
227test-suite EventWriterT
269− default-language: Haskell2010
270 type: exitcode-stdio-1.0
228 type: exitcode-stdio-1.0
271 main-is: EventWriterT.hs
229 main-is: EventWriterT.hs
272 hs-source-dirs: test
230 hs-source-dirs: test
@@ -286,57 +244,28 @@ test-suite EventWriterT
286 build-depends: these-lens
244 build-depends: these-lens
287
245
288 other-modules:
246 other-modules:
289− Test.Run
247+ Reflex.Test
290−
248+ Reflex.TestPlan
291−
249+ Reflex.Plan.Reflex
292−test-suite DebugCycles
250+ Reflex.Plan.Pure
293− default-language: Haskell2010
294− type: exitcode-stdio-1.0
295− main-is: DebugCycles.hs
296− hs-source-dirs: test
297− ghc-options: -threaded
298− build-depends: base
299− , containers
300− , deepseq
301− , dependent-map
302− , dependent-sum
303− , hspec
304− , lens
305− , mtl
306− , these
307− , transformers
308− , reflex
309− , ref-tf
310− , witherable
311− , proctest
312−
313−
314− if flag(split-these)
315− build-depends: these-lens, semialign
316−
317− other-modules:
318 Test.Run
251 Test.Run
319
252
320
253
321test-suite RequesterT
254test-suite RequesterT
322− default-language: Haskell2010
323 type: exitcode-stdio-1.0
255 type: exitcode-stdio-1.0
324 main-is: RequesterT.hs
256 main-is: RequesterT.hs
325 hs-source-dirs: test
257 hs-source-dirs: test
326 build-depends: base
258 build-depends: base
327− , constraints
328− , constraints-extras
329 , containers
259 , containers
330 , deepseq
260 , deepseq
331− , dependent-map
332 , dependent-sum
261 , dependent-sum
262+ , dependent-map
333 , lens
263 , lens
334 , mtl
264 , mtl
335− , ref-tf
336− , reflex
337− , text
338 , these
265 , these
339 , transformers
266 , transformers
267+ , reflex
268+ , ref-tf
340
269
341 if flag(split-these)
270 if flag(split-these)
342 build-depends: these-lens
271 build-depends: these-lens
@@ -346,31 +275,7 @@ test-suite RequesterT
346 Reflex.Plan.Pure
275 Reflex.Plan.Pure
347 Test.Run
276 Test.Run
348
277
349−test-suite Headless
350− default-language: Haskell2010
351− type: exitcode-stdio-1.0
352− main-is: Headless.hs
353− hs-source-dirs: test
354− build-depends: base
355− , reflex
356−
357−test-suite Adjustable
358− default-language: Haskell2010
359− type: exitcode-stdio-1.0
360− main-is: Adjustable.hs
361− hs-source-dirs: test
362− build-depends: base
363− , containers
364− , dependent-sum
365− , reflex
366− , ref-tf
367− , these
368−
369− other-modules:
370− Test.Run
371−
372test-suite QueryT
278test-suite QueryT
373− default-language: Haskell2010
374 type: exitcode-stdio-1.0
279 type: exitcode-stdio-1.0
375 main-is: QueryT.hs
280 main-is: QueryT.hs
376 hs-source-dirs: test
281 hs-source-dirs: test
@@ -382,7 +287,6 @@ test-suite QueryT
382 , lens
287 , lens
383 , monoidal-containers
288 , monoidal-containers
384 , mtl
289 , mtl
385− , patch
386 , ref-tf
290 , ref-tf
387 , reflex
291 , reflex
388 , these
292 , these
@@ -398,7 +302,6 @@ test-suite QueryT
398 Reflex.Plan.Pure
302 Reflex.Plan.Pure
399
303
400test-suite GC-Semantics
304test-suite GC-Semantics
401− default-language: Haskell2010
402 type: exitcode-stdio-1.0
305 type: exitcode-stdio-1.0
403 main-is: GC.hs
306 main-is: GC.hs
404 hs-source-dirs: test
307 hs-source-dirs: test
@@ -408,7 +311,6 @@ test-suite GC-Semantics
408 , dependent-map
311 , dependent-map
409 , deepseq
312 , deepseq
410 , mtl
313 , mtl
411− , patch
412 , these
314 , these
413 , transformers
315 , transformers
414 , reflex
316 , reflex
@@ -424,7 +326,6 @@ test-suite GC-Semantics
424 Test.Run
326 Test.Run
425
327
426test-suite rootCleanup
328test-suite rootCleanup
427− default-language: Haskell2010
428 type: exitcode-stdio-1.0
329 type: exitcode-stdio-1.0
429 main-is: rootCleanup.hs
330 main-is: rootCleanup.hs
430 hs-source-dirs: test
331 hs-source-dirs: test
@@ -442,7 +343,6 @@ test-suite rootCleanup
442 Test.Run
343 Test.Run
443
344
444benchmark spider-bench
345benchmark spider-bench
445− default-language: Haskell2010
446 type: exitcode-stdio-1.0
346 type: exitcode-stdio-1.0
447 hs-source-dirs: bench test
347 hs-source-dirs: bench test
448 main-is: Main.hs
348 main-is: Main.hs
@@ -467,7 +367,6 @@ benchmark spider-bench
467 Reflex.Bench.Focused
367 Reflex.Bench.Focused
468
368
469benchmark saulzar-bench
369benchmark saulzar-bench
470− default-language: Haskell2010
471 type: exitcode-stdio-1.0
370 type: exitcode-stdio-1.0
472 hs-source-dirs: bench test
371 hs-source-dirs: bench test
473 c-sources: bench-cbits/checkCapability.c
372 c-sources: bench-cbits/checkCapability.c
release.nix+2−5
@@ -1,12 +1,12 @@
1{ reflex-platform-fun ? import ./dep/reflex-platform
1{ reflex-platform-fun ? import ./dep/reflex-platform
2−, supportedSystems ? ["x86_64-linux" "x86_64-darwin"]
3}:
2}:
4
3
5let
4let
6 native-reflex-platform = reflex-platform-fun {};
5 native-reflex-platform = reflex-platform-fun {};
7 inherit (native-reflex-platform.nixpkgs) lib;
6 inherit (native-reflex-platform.nixpkgs) lib;
7+ systems = ["x86_64-linux" "x86_64-darwin"];
8
8
9− perPlatform = lib.genAttrs supportedSystems (system: let
9+ perPlatform = lib.genAttrs systems (system: let
10 reflex-platform = reflex-platform-fun { inherit system; };
10 reflex-platform = reflex-platform-fun { inherit system; };
11 compilers = [
11 compilers = [
12 "ghc"
12 "ghc"
@@ -34,9 +34,6 @@ let
34 "release.nix"
34 "release.nix"
35 ".git"
35 ".git"
36 "dist"
36 "dist"
37− "cabal.haskell-ci"
38− "cabal.project"
39− ".travis.yml"
40 ])) ./.;
37 ])) ./.;
41 };
38 };
42 })
39 })
src/Data/AppendMap.hs+1−1
@@ -71,7 +71,7 @@ mapMaybeNoNull f as =
71 then Nothing
71 then Nothing
72 else Just bs
72 else Just bs
73
73
74−-- TODO: Move instances to `Data.Patch`
74+-- TODO: Move instances to `Reflex.Patch`
75-- | Displays a 'MonoidalMap' as a tree. See 'Data.Map.Lazy.showTree' for details.
75-- | Displays a 'MonoidalMap' as a tree. See 'Data.Map.Lazy.showTree' for details.
76showTree :: forall k a. (Show k, Show a) => MonoidalMap k a -> String
76showTree :: forall k a. (Show k, Show a) => MonoidalMap k a -> String
77showTree = coerce (Map.showTree :: Map k a -> String)
77showTree = coerce (Map.showTree :: Map k a -> String)
src/Data/FastMutableIntMap.hs+3−7
@@ -21,7 +21,6 @@ module Data.FastMutableIntMap
21 , patchIntMapNewElements
21 , patchIntMapNewElements
22 , patchIntMapNewElementsMap
22 , patchIntMapNewElementsMap
23 , getDeletions
23 , getDeletions
24− , toList
25 ) where
24 ) where
26
25
27--TODO: Pure JS version
26--TODO: Pure JS version
@@ -35,8 +34,8 @@ import Data.Foldable (traverse_)
35import Data.IntMap.Strict (IntMap)
34import Data.IntMap.Strict (IntMap)
36import qualified Data.IntMap.Strict as IntMap
35import qualified Data.IntMap.Strict as IntMap
37import Data.IORef
36import Data.IORef
38−import Data.Patch.Class
37+import Reflex.Patch.Class
39−import Data.Patch.IntMap
38+import Reflex.Patch.IntMap
40
39
41-- | A 'FastMutableIntMap' holds a map of values of type @a@ and allows low-overhead modifications via IO.
40-- | A 'FastMutableIntMap' holds a map of values of type @a@ and allows low-overhead modifications via IO.
42-- Operations on 'FastMutableIntMap' run in IO.
41-- Operations on 'FastMutableIntMap' run in IO.
@@ -85,13 +84,10 @@ getFrozenAndClear (FastMutableIntMap r) = do
85 writeIORef r IntMap.empty
84 writeIORef r IntMap.empty
86 return result
85 return result
87
86
88−-- | Updates the value of a 'FastMutableIntMap' with the given patch (see 'Data.Patch.IntMap'),
87+-- | Updates the value of a 'FastMutableIntMap' with the given patch (see 'Reflex.Patch.IntMap'),
89-- and returns an 'IntMap' with the modified keys and values.
88-- and returns an 'IntMap' with the modified keys and values.
90applyPatch :: FastMutableIntMap a -> PatchIntMap a -> IO (IntMap a)
89applyPatch :: FastMutableIntMap a -> PatchIntMap a -> IO (IntMap a)
91applyPatch (FastMutableIntMap r) p@(PatchIntMap m) = do
90applyPatch (FastMutableIntMap r) p@(PatchIntMap m) = do
92 v <- readIORef r
91 v <- readIORef r
93 writeIORef r $! applyAlways p v
92 writeIORef r $! applyAlways p v
94 return $ IntMap.intersection v m
93 return $ IntMap.intersection v m
95−
96−toList :: FastMutableIntMap a -> IO [(Int, a)]
97−toList (FastMutableIntMap r) = IntMap.toList <$> readIORef r
src/Data/Functor/Misc.hsnew file+234
@@ -0,0 +1,234 @@
1+{-# LANGUAGE CPP #-}
2+{-# LANGUAGE DeriveDataTypeable #-}
3+{-# LANGUAGE DeriveFunctor #-}
4+{-# LANGUAGE FlexibleContexts #-}
5+{-# LANGUAGE FlexibleInstances #-}
6+{-# LANGUAGE GADTs #-}
7+{-# LANGUAGE LambdaCase #-}
8+{-# LANGUAGE MultiParamTypeClasses #-}
9+{-# LANGUAGE PatternSynonyms #-}
10+{-# LANGUAGE PolyKinds #-}
11+{-# LANGUAGE RankNTypes #-}
12+{-# LANGUAGE ScopedTypeVariables #-}
13+{-# LANGUAGE StandaloneDeriving #-}
14+#ifdef USE_REFLEX_OPTIMIZER
15+{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
16+#endif
17+-- | This module provides types and functions with no particular theme, but
18+-- which are relevant to the use of 'Functor'-based datastructures like
19+-- 'Data.Dependent.Map.DMap'.
20+module Data.Functor.Misc
21+ ( -- * Const2
22+ Const2 (..)
23+ , unConst2
24+ , dmapToMap
25+ , dmapToIntMap
26+ , dmapToMapWith
27+ , mapToDMap
28+ , weakenDMapWith
29+ -- * WrapArg
30+ , WrapArg (..)
31+ -- * Convenience functions for DMap
32+ , mapWithFunctorToDMap
33+ , intMapWithFunctorToDMap
34+ , mapKeyValuePairsMonotonic
35+ , combineDMapsWithKey
36+ , EitherTag (..)
37+ , dmapToThese
38+ , eitherToDSum
39+ , dsumToEither
40+ , ComposeMaybe (..)
41+ ) where
42+
43+import Control.Applicative ((<$>))
44+import Control.Monad.Identity
45+import Data.Dependent.Map (DMap)
46+import qualified Data.Dependent.Map as DMap
47+import Data.Dependent.Sum
48+import Data.GADT.Compare
49+import Data.GADT.Show
50+import Data.IntMap (IntMap)
51+import qualified Data.IntMap as IntMap
52+import Data.Map (Map)
53+import qualified Data.Map as Map
54+import Data.Some (Some(Some))
55+import Data.These
56+import Data.Typeable hiding (Refl)
57+
58+--------------------------------------------------------------------------------
59+-- Const2
60+--------------------------------------------------------------------------------
61+
62+-- | 'Const2' stores a value of a given type 'k' and ensures that a particular
63+-- type 'v' is always given for the last type parameter
64+data Const2 :: * -> x -> x -> * where
65+ Const2 :: k -> Const2 k v v
66+ deriving (Typeable)
67+
68+-- | Extract the value from a Const2
69+unConst2 :: Const2 k v v' -> k
70+unConst2 (Const2 k) = k
71+
72+deriving instance Eq k => Eq (Const2 k v v')
73+deriving instance Ord k => Ord (Const2 k v v')
74+deriving instance Show k => Show (Const2 k v v')
75+deriving instance Read k => Read (Const2 k v v)
76+
77+instance Show k => GShow (Const2 k v) where
78+ gshowsPrec n x@(Const2 _) = showsPrec n x
79+
80+instance Eq k => GEq (Const2 k v) where
81+ geq (Const2 a) (Const2 b) =
82+ if a == b
83+ then Just Refl
84+ else Nothing
85+
86+instance Ord k => GCompare (Const2 k v) where
87+ gcompare (Const2 a) (Const2 b) = case compare a b of
88+ LT -> GLT
89+ EQ -> GEQ
90+ GT -> GGT
91+
92+-- | Convert a 'DMap' to a regular 'Map'
93+dmapToMap :: DMap (Const2 k v) Identity -> Map k v
94+dmapToMap = Map.fromDistinctAscList . map (\(Const2 k :=> Identity v) -> (k, v)) . DMap.toAscList
95+
96+-- | Convert a 'DMap' to an 'IntMap'
97+dmapToIntMap :: DMap (Const2 IntMap.Key v) Identity -> IntMap v
98+dmapToIntMap = IntMap.fromDistinctAscList . map (\(Const2 k :=> Identity v) -> (k, v)) . DMap.toAscList
99+
100+-- | Convert a 'DMap' to a regular 'Map', applying the given function to remove
101+-- the wrapping 'Functor'
102+dmapToMapWith :: (f v -> v') -> DMap (Const2 k v) f -> Map k v'
103+dmapToMapWith f = Map.fromDistinctAscList . map (\(Const2 k :=> v) -> (k, f v)) . DMap.toAscList
104+
105+-- | Convert a regular 'Map' to a 'DMap'
106+mapToDMap :: Map k v -> DMap (Const2 k v) Identity
107+mapToDMap = DMap.fromDistinctAscList . map (\(k, v) -> Const2 k :=> Identity v) . Map.toAscList
108+
109+-- | Convert a regular 'Map', where the values are already wrapped in a functor,
110+-- to a 'DMap'
111+mapWithFunctorToDMap :: Map k (f v) -> DMap (Const2 k v) f
112+mapWithFunctorToDMap = DMap.fromDistinctAscList . map (\(k, v) -> Const2 k :=> v) . Map.toAscList
113+
114+-- | Convert a regular 'IntMap', where the values are already wrapped in a
115+-- functor, to a 'DMap'
116+intMapWithFunctorToDMap :: IntMap (f v) -> DMap (Const2 IntMap.Key v) f
117+intMapWithFunctorToDMap = DMap.fromDistinctAscList . map (\(k, v) -> Const2 k :=> v) . IntMap.toAscList
118+
119+-- | Convert a 'DMap' to a regular 'Map' by forgetting the types associated with
120+-- the keys, using a function to remove the wrapping 'Functor'
121+weakenDMapWith :: (forall a. v a -> v') -> DMap k v -> Map (Some k) v'
122+weakenDMapWith f = Map.fromDistinctAscList . map (\(k :=> v) -> (Some k, f v)) . DMap.toAscList
123+
124+--------------------------------------------------------------------------------
125+-- WrapArg
126+--------------------------------------------------------------------------------
127+
128+-- | 'WrapArg' can be used to tag a value in one functor with a type
129+-- representing another functor. This was primarily used with dependent-map <
130+-- 0.2, in which the value type was not wrapped in a separate functor.
131+data WrapArg :: (k -> *) -> (k -> *) -> * -> * where
132+ WrapArg :: f a -> WrapArg g f (g a)
133+
134+deriving instance Eq (f a) => Eq (WrapArg g f (g' a))
135+deriving instance Ord (f a) => Ord (WrapArg g f (g' a))
136+deriving instance Show (f a) => Show (WrapArg g f (g' a))
137+deriving instance Read (f a) => Read (WrapArg g f (g a))
138+
139+instance GEq f => GEq (WrapArg g f) where
140+ geq (WrapArg a) (WrapArg b) = (\Refl -> Refl) <$> geq a b
141+
142+instance GCompare f => GCompare (WrapArg g f) where
143+ gcompare (WrapArg a) (WrapArg b) = case gcompare a b of
144+ GLT -> GLT
145+ GEQ -> GEQ
146+ GGT -> GGT
147+
148+--------------------------------------------------------------------------------
149+-- Convenience functions for DMap
150+--------------------------------------------------------------------------------
151+
152+-- | Map over all key/value pairs in a 'DMap', potentially altering the key as
153+-- well as the value. The provided function MUST preserve the ordering of the
154+-- keys, or the resulting 'DMap' will be malformed.
155+mapKeyValuePairsMonotonic :: (DSum k v -> DSum k' v') -> DMap k v -> DMap k' v'
156+mapKeyValuePairsMonotonic f = DMap.fromDistinctAscList . map f . DMap.toAscList
157+
158+{-# INLINE combineDMapsWithKey #-}
159+-- | Union two 'DMap's of different types, yielding another type. Each key that
160+-- is present in either input map will be present in the output.
161+combineDMapsWithKey :: forall f g h i.
162+ GCompare f
163+ => (forall a. f a -> These (g a) (h a) -> i a)
164+ -> DMap f g
165+ -> DMap f h
166+ -> DMap f i
167+combineDMapsWithKey f mg mh = DMap.fromList $ go (DMap.toList mg) (DMap.toList mh)
168+ where go :: [DSum f g] -> [DSum f h] -> [DSum f i]
169+ go [] hs = map (\(hk :=> hv) -> hk :=> f hk (That hv)) hs
170+ go gs [] = map (\(gk :=> gv) -> gk :=> f gk (This gv)) gs
171+ go gs@((gk :=> gv) : gs') hs@((hk :=> hv) : hs') = case gk `gcompare` hk of
172+ GLT -> (gk :=> f gk (This gv)) : go gs' hs
173+ GEQ -> (gk :=> f gk (These gv hv)) : go gs' hs'
174+ GGT -> (hk :=> f hk (That hv)) : go gs hs'
175+
176+-- | Extract the values of a 'DMap' of 'EitherTag's.
177+dmapToThese :: DMap (EitherTag a b) Identity -> Maybe (These a b)
178+dmapToThese m = case (DMap.lookup LeftTag m, DMap.lookup RightTag m) of
179+ (Nothing, Nothing) -> Nothing
180+ (Just (Identity a), Nothing) -> Just $ This a
181+ (Nothing, Just (Identity b)) -> Just $ That b
182+ (Just (Identity a), Just (Identity b)) -> Just $ These a b
183+
184+-- | Tag type for 'Either' to use it as a 'DSum'.
185+data EitherTag l r a where
186+ LeftTag :: EitherTag l r l
187+ RightTag :: EitherTag l r r
188+ deriving (Typeable)
189+
190+deriving instance Show (EitherTag l r a)
191+deriving instance Eq (EitherTag l r a)
192+deriving instance Ord (EitherTag l r a)
193+
194+instance GEq (EitherTag l r) where
195+ geq a b = case (a, b) of
196+ (LeftTag, LeftTag) -> Just Refl
197+ (RightTag, RightTag) -> Just Refl
198+ _ -> Nothing
199+
200+instance GCompare (EitherTag l r) where
201+ gcompare a b = case (a, b) of
202+ (LeftTag, LeftTag) -> GEQ
203+ (LeftTag, RightTag) -> GLT
204+ (RightTag, LeftTag) -> GGT
205+ (RightTag, RightTag) -> GEQ
206+
207+instance GShow (EitherTag l r) where
208+ gshowsPrec _ a = case a of
209+ LeftTag -> showString "LeftTag"
210+ RightTag -> showString "RightTag"
211+
212+-- | Convert 'Either' to a 'DSum'. Inverse of 'dsumToEither'.
213+eitherToDSum :: Either a b -> DSum (EitherTag a b) Identity
214+eitherToDSum = \case
215+ Left a -> (LeftTag :=> Identity a)
216+ Right b -> (RightTag :=> Identity b)
217+
218+-- | Convert 'DSum' to 'Either'. Inverse of 'eitherToDSum'.
219+dsumToEither :: DSum (EitherTag a b) Identity -> Either a b
220+dsumToEither = \case
221+ (LeftTag :=> Identity a) -> Left a
222+ (RightTag :=> Identity b) -> Right b
223+
224+--------------------------------------------------------------------------------
225+-- ComposeMaybe
226+--------------------------------------------------------------------------------
227+
228+-- | We can't use @Compose Maybe@ instead of 'ComposeMaybe', because that would
229+-- make the 'f' parameter have a nominal type role. We need f to be
230+-- representational so that we can use safe 'coerce'.
231+newtype ComposeMaybe f a =
232+ ComposeMaybe { getComposeMaybe :: Maybe (f a) } deriving (Show, Eq, Ord)
233+
234+deriving instance Functor f => Functor (ComposeMaybe f)
src/Data/Map/Misc.hs+1−1
@@ -43,7 +43,7 @@ diffMap olds news = flip Map.mapMaybe (align olds news) $ \case
43
43
44-- |Given a @'Map' k (Maybe v)@ representing keys to insert/update (@Just@) or delete (@Nothing@), produce a new map from the given input @'Map' k v@.
44-- |Given a @'Map' k (Maybe v)@ representing keys to insert/update (@Just@) or delete (@Nothing@), produce a new map from the given input @'Map' k v@.
45--
45--
46−-- See also 'Data.Patch.Map' and 'Data.Patch.MapWithMove'.
46+-- See also 'Reflex.Patch.Map' and 'Reflex.Patch.MapWithMove'.
47applyMap :: Ord k => Map k (Maybe v) -> Map k v -> Map k v
47applyMap :: Ord k => Map k (Maybe v) -> Map k v -> Map k v
48applyMap patch old = insertions `Map.union` (old `Map.difference` deletions)
48applyMap patch old = insertions `Map.union` (old `Map.difference` deletions)
49 where (deletions, insertions) = Map.mapEither maybeToEither patch
49 where (deletions, insertions) = Map.mapEither maybeToEither patch
src/Reflex/Adjustable/Class.hs+2−3
@@ -30,8 +30,7 @@ module Reflex.Adjustable.Class
30
30
31import Control.Monad.Identity
31import Control.Monad.Identity
32import Control.Monad.Reader
32import Control.Monad.Reader
33−import Data.Dependent.Map (DMap)
33+import Data.Dependent.Map (DMap, GCompare (..))
34−import Data.GADT.Compare (GCompare(..))
35import qualified Data.Dependent.Map as DMap
34import qualified Data.Dependent.Map as DMap
36import Data.Functor.Constant
35import Data.Functor.Constant
37import Data.Functor.Misc
36import Data.Functor.Misc
@@ -40,7 +39,7 @@ import qualified Data.IntMap.Strict as IntMap
40import Data.Map (Map)
39import Data.Map (Map)
41
40
42import Reflex.Class
41import Reflex.Class
43−import Data.Patch.DMapWithMove
42+import Reflex.Patch.DMapWithMove
44
43
45-- | A 'Monad' that supports adjustment over time. After an action has been
44-- | A 'Monad' that supports adjustment over time. After an action has been
46-- run, if the given events fire, it will adjust itself so that its net effect
45-- run, if the given events fire, it will adjust itself so that its net effect
src/Reflex/BehaviorWriter/Base.hs+7−16
@@ -1,6 +1,6 @@
1{-|
1{-|
2Module: Reflex.BehaviorWriter.Base
2Module: Reflex.BehaviorWriter.Base
3−Description: Implementation of BehaviorWriter
3+Description: Implementation of MonadBehaviorWriter
4-}
4-}
5{-# LANGUAGE CPP #-}
5{-# LANGUAGE CPP #-}
6{-# LANGUAGE FlexibleInstances #-}
6{-# LANGUAGE FlexibleInstances #-}
@@ -24,7 +24,6 @@ module Reflex.BehaviorWriter.Base
24import Control.Monad.Exception
24import Control.Monad.Exception
25import Control.Monad.Identity
25import Control.Monad.Identity
26import Control.Monad.IO.Class
26import Control.Monad.IO.Class
27−import Control.Monad.Morph
28import Control.Monad.Reader
27import Control.Monad.Reader
29import Control.Monad.Ref
28import Control.Monad.Ref
30import Control.Monad.State.Strict
29import Control.Monad.State.Strict
@@ -47,20 +46,9 @@ import Reflex.Query.Class
47import Reflex.Requester.Class
46import Reflex.Requester.Class
48import Reflex.TriggerEvent.Class
47import Reflex.TriggerEvent.Class
49
48
50−-- | A basic implementation of 'BehaviorWriter'.
49+-- | A basic implementation of 'MonadBehaviorWriter'.
51newtype BehaviorWriterT t w m a = BehaviorWriterT { unBehaviorWriterT :: StateT [Behavior t w] m a }
50newtype BehaviorWriterT t w m a = BehaviorWriterT { unBehaviorWriterT :: StateT [Behavior t w] m a }
52− -- The list is kept in reverse order
51+ deriving (Functor, Applicative, Monad, MonadIO, MonadFix, MonadAsyncException, MonadException) -- The list is kept in reverse order
53− deriving
54− ( Functor
55− , Applicative
56− , Monad
57− , MonadTrans
58− , MFunctor
59− , MonadIO
60− , MonadFix
61− , MonadAsyncException
62− , MonadException
63− )
64
52
65-- | Run a 'BehaviorWriterT' action. The behavior writer output will be provided
53-- | Run a 'BehaviorWriterT' action. The behavior writer output will be provided
66-- along with the result of the action.
54-- along with the result of the action.
@@ -85,6 +73,9 @@ withBehaviorWriterT f dw = do
85deriving instance MonadHold t m => MonadHold t (BehaviorWriterT t w m)
73deriving instance MonadHold t m => MonadHold t (BehaviorWriterT t w m)
86deriving instance MonadSample t m => MonadSample t (BehaviorWriterT t w m)
74deriving instance MonadSample t m => MonadSample t (BehaviorWriterT t w m)
87
75
76+instance MonadTrans (BehaviorWriterT t w) where
77+ lift = BehaviorWriterT . lift
78+
88instance MonadRef m => MonadRef (BehaviorWriterT t w m) where
79instance MonadRef m => MonadRef (BehaviorWriterT t w m) where
89 type Ref (BehaviorWriterT t w m) = Ref m
80 type Ref (BehaviorWriterT t w m) = Ref m
90 newRef = lift . newRef
81 newRef = lift . newRef
@@ -98,7 +89,7 @@ instance MonadReflexCreateTrigger t m => MonadReflexCreateTrigger t (BehaviorWri
98 newEventWithTrigger = lift . newEventWithTrigger
89 newEventWithTrigger = lift . newEventWithTrigger
99 newFanEventWithTrigger f = lift $ newFanEventWithTrigger f
90 newFanEventWithTrigger f = lift $ newFanEventWithTrigger f
100
91
101−instance (Monad m, Monoid w, Reflex t) => BehaviorWriter t w (BehaviorWriterT t w m) where
92+instance (Monad m, Monoid w, Reflex t) => MonadBehaviorWriter t w (BehaviorWriterT t w m) where
102 tellBehavior w = BehaviorWriterT $ modify (w :)
93 tellBehavior w = BehaviorWriterT $ modify (w :)
103
94
104instance MonadReader r m => MonadReader r (BehaviorWriterT t w m) where
95instance MonadReader r m => MonadReader r (BehaviorWriterT t w m) where
src/Reflex/BehaviorWriter/Class.hs+5−11
@@ -1,9 +1,8 @@
1{-|
1{-|
2Module: Reflex.BehaviorWriter.Class
2Module: Reflex.BehaviorWriter.Class
3−Description: This module defines the 'BehaviorWriter' class
3+Description: This module defines the 'MonadBehaviorWriter' class
4-}
4-}
5{-# LANGUAGE CPP #-}
5{-# LANGUAGE CPP #-}
6−{-# LANGUAGE ConstraintKinds #-}
7{-# LANGUAGE FlexibleInstances #-}
6{-# LANGUAGE FlexibleInstances #-}
8{-# LANGUAGE FunctionalDependencies #-}
7{-# LANGUAGE FunctionalDependencies #-}
9{-# LANGUAGE UndecidableInstances #-}
8{-# LANGUAGE UndecidableInstances #-}
@@ -11,21 +10,16 @@ Description: This module defines the 'BehaviorWriter' class
11{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
10{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
12#endif
11#endif
13module Reflex.BehaviorWriter.Class
12module Reflex.BehaviorWriter.Class
14− ( MonadBehaviorWriter
13+ ( MonadBehaviorWriter (..)
15− , BehaviorWriter(..)
16 ) where
14 ) where
17
15
18import Control.Monad.Reader (ReaderT, lift)
16import Control.Monad.Reader (ReaderT, lift)
19import Reflex.Class (Behavior)
17import Reflex.Class (Behavior)
20
18
21−{-# DEPRECATED MonadBehaviorWriter "Use 'BehaviorWriter' instead" #-}
22−-- | Type synonym for 'BehaviorWriter'
23−type MonadBehaviorWriter = BehaviorWriter
24−
25−-- | 'BehaviorWriter' efficiently collects 'Behavior' values using 'tellBehavior'
19+-- | 'MonadBehaviorWriter' efficiently collects 'Behavior' values using 'tellBehavior'
26-- and combines them monoidally to provide a 'Behavior' result.
20-- and combines them monoidally to provide a 'Behavior' result.
27−class (Monad m, Monoid w) => BehaviorWriter t w m | m -> t w where
21+class (Monad m, Monoid w) => MonadBehaviorWriter t w m | m -> t w where
28 tellBehavior :: Behavior t w -> m ()
22 tellBehavior :: Behavior t w -> m ()
29
23
30−instance BehaviorWriter t w m => BehaviorWriter t w (ReaderT r m) where
24+instance MonadBehaviorWriter t w m => MonadBehaviorWriter t w (ReaderT r m) where
31 tellBehavior = lift . tellBehavior
25 tellBehavior = lift . tellBehavior
src/Reflex/Class.hs+7−28
@@ -29,7 +29,7 @@
29-- convenience functions for working with 'Event's, 'Behavior's, and other
29-- convenience functions for working with 'Event's, 'Behavior's, and other
30-- signals.
30-- signals.
31module Reflex.Class
31module Reflex.Class
32− ( module Data.Patch
32+ ( module Reflex.Patch
33 -- * Primitives
33 -- * Primitives
34 , Reflex (..)
34 , Reflex (..)
35 , mergeInt
35 , mergeInt
@@ -180,7 +180,7 @@ import Prelude hiding (zip, zipWith)
180import Data.These.Combinators (justThese)
180import Data.These.Combinators (justThese)
181#endif
181#endif
182#if MIN_VERSION_semialign(1,1,0)
182#if MIN_VERSION_semialign(1,1,0)
183−import Data.Zip (Zip (..), Unzip (..))
183+import Data.Zip (Zip (..))
184#endif
184#endif
185#endif
185#endif
186
186
@@ -196,12 +196,11 @@ import Data.Align
196import Data.Bifunctor
196import Data.Bifunctor
197import Data.Coerce
197import Data.Coerce
198import Data.Default
198import Data.Default
199−import Data.Dependent.Map (DMap)
199+import Data.Dependent.Map (DMap, DSum (..))
200−import Data.Dependent.Sum (DSum (..))
201import qualified Data.Dependent.Map as DMap
200import qualified Data.Dependent.Map as DMap
202import Data.Functor.Compose
201import Data.Functor.Compose
203import Data.Functor.Product
202import Data.Functor.Product
204−import Data.GADT.Compare (GEq (..), GCompare (..))
203+import Data.GADT.Compare (GEq (..), GCompare (..), (:~:) (..))
205import Data.FastMutableIntMap (PatchIntMap)
204import Data.FastMutableIntMap (PatchIntMap)
206import Data.Foldable
205import Data.Foldable
207import Data.Functor.Bind
206import Data.Functor.Bind
@@ -211,18 +210,17 @@ import Data.IntMap.Strict (IntMap)
211import qualified Data.IntMap.Strict as IntMap
210import qualified Data.IntMap.Strict as IntMap
212import Data.List.NonEmpty (NonEmpty (..))
211import Data.List.NonEmpty (NonEmpty (..))
213import Data.Map (Map)
212import Data.Map (Map)
214−import Data.Semigroup (Semigroup (..))
213+import Data.Semigroup (Semigroup, sconcat, stimes, (<>))
215import Data.Some (Some(Some))
214import Data.Some (Some(Some))
216import Data.String
215import Data.String
217import Data.These
216import Data.These
218import Data.Type.Coercion
217import Data.Type.Coercion
219−import Data.Type.Equality ((:~:) (..))
220import Data.Witherable (Filterable(..))
218import Data.Witherable (Filterable(..))
221import qualified Data.Witherable as W
219import qualified Data.Witherable as W
222import Reflex.FunctorMaybe (FunctorMaybe)
220import Reflex.FunctorMaybe (FunctorMaybe)
223import qualified Reflex.FunctorMaybe
221import qualified Reflex.FunctorMaybe
224−import Data.Patch
222+import Reflex.Patch
225−import qualified Data.Patch.MapWithMove as PatchMapWithMove
223+import qualified Reflex.Patch.MapWithMove as PatchMapWithMove
226
224
227import Debug.Trace (trace)
225import Debug.Trace (trace)
228
226
@@ -421,13 +419,6 @@ class MonadSample t m => MonadHold t m where
421 -- | Create a new 'Event' that only occurs only once, on the first occurrence of
419 -- | Create a new 'Event' that only occurs only once, on the first occurrence of
422 -- the supplied 'Event'.
420 -- the supplied 'Event'.
423 headE :: Event t a -> m (Event t a)
421 headE :: Event t a -> m (Event t a)
424− -- | An event which only occurs at the current moment in time, such that:
425− --
426− -- > coincidence (pushAlways (\a -> (a <$) <$> now) e) = e
427− --
428− now :: m (Event t ())
429− default now :: (m ~ f m', MonadTrans f, MonadHold t m') => m (Event t ())
430− now = lift now
431
422
432-- | Accumulate an 'Incremental' with the supplied initial value and the firings of the provided 'Event',
423-- | Accumulate an 'Incremental' with the supplied initial value and the firings of the provided 'Event',
433-- using the combining function to produce a patch.
424-- using the combining function to produce a patch.
@@ -573,7 +564,6 @@ instance MonadHold t m => MonadHold t (ReaderT r m) where
573 holdIncremental a0 = lift . holdIncremental a0
564 holdIncremental a0 = lift . holdIncremental a0
574 buildDynamic a0 = lift . buildDynamic a0
565 buildDynamic a0 = lift . buildDynamic a0
575 headE = lift . headE
566 headE = lift . headE
576− now = lift now
577
567
578instance (MonadSample t m, Monoid r) => MonadSample t (WriterT r m) where
568instance (MonadSample t m, Monoid r) => MonadSample t (WriterT r m) where
579 sample = lift . sample
569 sample = lift . sample
@@ -584,7 +574,6 @@ instance (MonadHold t m, Monoid r) => MonadHold t (WriterT r m) where
584 holdIncremental a0 = lift . holdIncremental a0
574 holdIncremental a0 = lift . holdIncremental a0
585 buildDynamic a0 = lift . buildDynamic a0
575 buildDynamic a0 = lift . buildDynamic a0
586 headE = lift . headE
576 headE = lift . headE
587− now = lift now
588
577
589instance MonadSample t m => MonadSample t (StateT s m) where
578instance MonadSample t m => MonadSample t (StateT s m) where
590 sample = lift . sample
579 sample = lift . sample
@@ -595,7 +584,6 @@ instance MonadHold t m => MonadHold t (StateT s m) where
595 holdIncremental a0 = lift . holdIncremental a0
584 holdIncremental a0 = lift . holdIncremental a0
596 buildDynamic a0 = lift . buildDynamic a0
585 buildDynamic a0 = lift . buildDynamic a0
597 headE = lift . headE
586 headE = lift . headE
598− now = lift now
599
587
600instance MonadSample t m => MonadSample t (ExceptT e m) where
588instance MonadSample t m => MonadSample t (ExceptT e m) where
601 sample = lift . sample
589 sample = lift . sample
@@ -606,7 +594,6 @@ instance MonadHold t m => MonadHold t (ExceptT e m) where
606 holdIncremental a0 = lift . holdIncremental a0
594 holdIncremental a0 = lift . holdIncremental a0
607 buildDynamic a0 = lift . buildDynamic a0
595 buildDynamic a0 = lift . buildDynamic a0
608 headE = lift . headE
596 headE = lift . headE
609− now = lift now
610
597
611instance (MonadSample t m, Monoid w) => MonadSample t (RWST r w s m) where
598instance (MonadSample t m, Monoid w) => MonadSample t (RWST r w s m) where
612 sample = lift . sample
599 sample = lift . sample
@@ -617,7 +604,6 @@ instance (MonadHold t m, Monoid w) => MonadHold t (RWST r w s m) where
617 holdIncremental a0 = lift . holdIncremental a0
604 holdIncremental a0 = lift . holdIncremental a0
618 buildDynamic a0 = lift . buildDynamic a0
605 buildDynamic a0 = lift . buildDynamic a0
619 headE = lift . headE
606 headE = lift . headE
620− now = lift now
621
607
622instance MonadSample t m => MonadSample t (ContT r m) where
608instance MonadSample t m => MonadSample t (ContT r m) where
623 sample = lift . sample
609 sample = lift . sample
@@ -628,7 +614,6 @@ instance MonadHold t m => MonadHold t (ContT r m) where
628 holdIncremental a0 = lift . holdIncremental a0
614 holdIncremental a0 = lift . holdIncremental a0
629 buildDynamic a0 = lift . buildDynamic a0
615 buildDynamic a0 = lift . buildDynamic a0
630 headE = lift . headE
616 headE = lift . headE
631− now = lift now
632
617
633--------------------------------------------------------------------------------
618--------------------------------------------------------------------------------
634-- Convenience functions
619-- Convenience functions
@@ -1105,12 +1090,6 @@ instance Reflex t => Zip (Event t) where
1105 zip x y = mapMaybe justThese $ align x y
1090 zip x y = mapMaybe justThese $ align x y
1106#endif
1091#endif
1107
1092
1108−#ifdef MIN_VERSION_semialign
1109−#if MIN_VERSION_semialign(1,1,0)
1110−instance Reflex t => Unzip (Event t) where
1111− unzip = splitE
1112−#endif
1113−#endif
1114
1093
1115-- | Create a new 'Event' that only occurs if the supplied 'Event' occurs and
1094-- | Create a new 'Event' that only occurs if the supplied 'Event' occurs and
1116-- the 'Behavior' is true at the time of occurrence.
1095-- the 'Behavior' is true at the time of occurrence.
src/Reflex/Dynamic.hs+2−17
@@ -53,12 +53,10 @@ module Reflex.Dynamic
53 , foldDynMaybe
53 , foldDynMaybe
54 , foldDynMaybeM
54 , foldDynMaybeM
55 , joinDynThroughMap
55 , joinDynThroughMap
56− , joinDynThroughIntMap
57 , traceDyn
56 , traceDyn
58 , traceDynWith
57 , traceDynWith
59 , splitDynPure
58 , splitDynPure
60 , distributeMapOverDynPure
59 , distributeMapOverDynPure
61− , distributeIntMapOverDynPure
62 , distributeDMapOverDynPure
60 , distributeDMapOverDynPure
63 , distributeListOverDynPure
61 , distributeListOverDynPure
64 , Demux
62 , Demux
@@ -89,14 +87,11 @@ import Data.Align
89import Data.Dependent.Map (DMap)
87import Data.Dependent.Map (DMap)
90import qualified Data.Dependent.Map as DMap
88import qualified Data.Dependent.Map as DMap
91import Data.Dependent.Sum (DSum (..))
89import Data.Dependent.Sum (DSum (..))
92−import Data.GADT.Compare (GCompare (..), GEq (..), GOrdering (..))
90+import Data.GADT.Compare ((:~:) (..), GCompare (..), GEq (..), GOrdering (..))
93−import Data.IntMap (IntMap)
94−import qualified Data.IntMap as IntMap
95import Data.Map (Map)
91import Data.Map (Map)
96import Data.Maybe
92import Data.Maybe
97import Data.Monoid ((<>))
93import Data.Monoid ((<>))
98import Data.These
94import Data.These
99−import Data.Type.Equality ((:~:) (..))
100
95
101import Debug.Trace
96import Debug.Trace
102
97
@@ -206,11 +201,6 @@ splitDynPure d = (fmap fst d, fmap snd d)
206distributeMapOverDynPure :: (Reflex t, Ord k) => Map k (Dynamic t v) -> Dynamic t (Map k v)
201distributeMapOverDynPure :: (Reflex t, Ord k) => Map k (Dynamic t v) -> Dynamic t (Map k v)
207distributeMapOverDynPure = fmap dmapToMap . distributeDMapOverDynPure . mapWithFunctorToDMap
202distributeMapOverDynPure = fmap dmapToMap . distributeDMapOverDynPure . mapWithFunctorToDMap
208
203
209−-- | Convert an 'IntMap' with 'Dynamic' elements into a 'Dynamic' of an 'IntMap' with
210−-- non-'Dynamic' elements.
211−distributeIntMapOverDynPure :: (Reflex t) => IntMap (Dynamic t v) -> Dynamic t (IntMap v)
212−distributeIntMapOverDynPure = fmap dmapToIntMap . distributeDMapOverDynPure . intMapWithFunctorToDMap
213−
214-- | Convert a list with 'Dynamic' elements into a 'Dynamic' of a list with
204-- | Convert a list with 'Dynamic' elements into a 'Dynamic' of a list with
215-- non-'Dynamic' elements, preserving the order of the elements.
205-- non-'Dynamic' elements, preserving the order of the elements.
216{-# DEPRECATED distributeListOverDynPure "Use 'distributeListOverDyn' instead" #-}
206{-# DEPRECATED distributeListOverDynPure "Use 'distributeListOverDyn' instead" #-}
@@ -223,11 +213,6 @@ distributeListOverDynPure = distributeListOverDyn
223joinDynThroughMap :: forall t k a. (Reflex t, Ord k) => Dynamic t (Map k (Dynamic t a)) -> Dynamic t (Map k a)
213joinDynThroughMap :: forall t k a. (Reflex t, Ord k) => Dynamic t (Map k (Dynamic t a)) -> Dynamic t (Map k a)
224joinDynThroughMap = (distributeMapOverDynPure =<<)
214joinDynThroughMap = (distributeMapOverDynPure =<<)
225
215
226−-- | Combine a 'Dynamic' of an 'IntMap' of 'Dynamic's into a 'Dynamic'
227−-- with the current values of the 'Dynamic's in a map.
228−joinDynThroughIntMap :: forall t a. (Reflex t) => Dynamic t (IntMap (Dynamic t a)) -> Dynamic t (IntMap a)
229−joinDynThroughIntMap = (distributeIntMapOverDynPure =<<)
230−
231-- | Print the value of the 'Dynamic' when it is first read and on each
216-- | Print the value of the 'Dynamic' when it is first read and on each
232-- subsequent change that is observed (as 'traceEvent'), prefixed with the
217-- subsequent change that is observed (as 'traceEvent'), prefixed with the
233-- provided string. This should /only/ be used for debugging.
218-- provided string. This should /only/ be used for debugging.
@@ -348,7 +333,7 @@ factorDyn d = buildDynamic (sample (current d) >>= holdKey) update where
348--
333--
349-- > demuxed (demux d) k === fmap (== k) d
334-- > demuxed (demux d) k === fmap (== k) d
350--
335--
351−-- However, when 'demuxed' is used multiple times, the complexity is only
336+-- However, when getDemuxed is used multiple times, the complexity is only
352-- /O(log(n))/, rather than /O(n)/ for fmap.
337-- /O(log(n))/, rather than /O(n)/ for fmap.
353data Demux t k = Demux { demuxValue :: Behavior t k
338data Demux t k = Demux { demuxValue :: Behavior t k
354 , demuxSelector :: EventSelector t (Const2 k Bool)
339 , demuxSelector :: EventSelector t (Const2 k Bool)
src/Reflex/DynamicWriter/Base.hs+5−14
@@ -22,7 +22,6 @@ module Reflex.DynamicWriter.Base
22import Control.Monad.Exception
22import Control.Monad.Exception
23import Control.Monad.Identity
23import Control.Monad.Identity
24import Control.Monad.IO.Class
24import Control.Monad.IO.Class
25−import Control.Monad.Morph
26import Control.Monad.Primitive
25import Control.Monad.Primitive
27import Control.Monad.Reader
26import Control.Monad.Reader
28import Control.Monad.Ref
27import Control.Monad.Ref
@@ -45,13 +44,16 @@ import Reflex.Class
45import Reflex.DynamicWriter.Class
44import Reflex.DynamicWriter.Class
46import Reflex.EventWriter.Class (EventWriter, tellEvent)
45import Reflex.EventWriter.Class (EventWriter, tellEvent)
47import Reflex.Host.Class
46import Reflex.Host.Class
48−import qualified Data.Patch.MapWithMove as MapWithMove
47+import qualified Reflex.Patch.MapWithMove as MapWithMove
49import Reflex.PerformEvent.Class
48import Reflex.PerformEvent.Class
50import Reflex.PostBuild.Class
49import Reflex.PostBuild.Class
51import Reflex.Query.Class
50import Reflex.Query.Class
52import Reflex.Requester.Class
51import Reflex.Requester.Class
53import Reflex.TriggerEvent.Class
52import Reflex.TriggerEvent.Class
54
53
54+instance MonadTrans (DynamicWriterT t w) where
55+ lift = DynamicWriterT . lift
56+
55mapIncrementalMapValues :: (Reflex t, Patch (p v), Patch (p v'), PatchTarget (p v) ~ f v, PatchTarget (p v') ~ f v', Functor p, Functor f) => (v -> v') -> Incremental t (p v) -> Incremental t (p v')
57mapIncrementalMapValues :: (Reflex t, Patch (p v), Patch (p v'), PatchTarget (p v) ~ f v, PatchTarget (p v') ~ f v', Functor p, Functor f) => (v -> v') -> Incremental t (p v) -> Incremental t (p v')
56mapIncrementalMapValues f = unsafeMapIncremental (fmap f) (fmap f)
58mapIncrementalMapValues f = unsafeMapIncremental (fmap f) (fmap f)
57
59
@@ -88,18 +90,7 @@ mergeDynIncrementalWithMove a = unsafeBuildIncremental (mapM (sample . current)
88
90
89-- | A basic implementation of 'DynamicWriter'.
91-- | A basic implementation of 'DynamicWriter'.
90newtype DynamicWriterT t w m a = DynamicWriterT { unDynamicWriterT :: StateT [Dynamic t w] m a }
92newtype DynamicWriterT t w m a = DynamicWriterT { unDynamicWriterT :: StateT [Dynamic t w] m a }
91− -- The list is kept in reverse order
93+ deriving (Functor, Applicative, Monad, MonadIO, MonadFix, MonadAsyncException, MonadException) -- The list is kept in reverse order
92− deriving
93− ( Functor
94− , Applicative
95− , Monad
96− , MonadTrans
97− , MFunctor
98− , MonadIO
99− , MonadFix
100− , MonadAsyncException
101− , MonadException
102− )
103
94
104deriving instance MonadHold t m => MonadHold t (DynamicWriterT t w m)
95deriving instance MonadHold t m => MonadHold t (DynamicWriterT t w m)
105deriving instance MonadSample t m => MonadSample t (DynamicWriterT t w m)
96deriving instance MonadSample t m => MonadSample t (DynamicWriterT t w m)
src/Reflex/EventWriter/Base.hs+5−16
@@ -35,14 +35,12 @@ import Reflex.TriggerEvent.Class
35
35
36import Control.Monad.Exception
36import Control.Monad.Exception
37import Control.Monad.Identity
37import Control.Monad.Identity
38−import Control.Monad.Morph
39import Control.Monad.Primitive
38import Control.Monad.Primitive
40import Control.Monad.Reader
39import Control.Monad.Reader
41import Control.Monad.Ref
40import Control.Monad.Ref
42import Control.Monad.State.Strict
41import Control.Monad.State.Strict
43−import Data.Dependent.Map (DMap)
42+import Data.Dependent.Map (DMap, DSum (..))
44import qualified Data.Dependent.Map as DMap
43import qualified Data.Dependent.Map as DMap
45−import Data.Dependent.Sum (DSum (..))
46import Data.Functor.Compose
44import Data.Functor.Compose
47import Data.Functor.Misc
45import Data.Functor.Misc
48import Data.GADT.Compare (GCompare (..), GEq (..), GOrdering (..))
46import Data.GADT.Compare (GCompare (..), GEq (..), GOrdering (..))
@@ -98,17 +96,7 @@ data EventWriterState t w = EventWriterState
98
96
99-- | A basic implementation of 'EventWriter'.
97-- | A basic implementation of 'EventWriter'.
100newtype EventWriterT t w m a = EventWriterT { unEventWriterT :: StateT (EventWriterState t w) m a }
98newtype EventWriterT t w m a = EventWriterT { unEventWriterT :: StateT (EventWriterState t w) m a }
101− deriving
99+ deriving (Functor, Applicative, Monad, MonadFix, MonadIO, MonadException, MonadAsyncException)
102− ( Functor
103− , Applicative
104− , Monad
105− , MonadTrans
106− , MFunctor
107− , MonadFix
108− , MonadIO
109− , MonadException
110− , MonadAsyncException
111− )
112
100
113-- | Run a 'EventWriterT' action.
101-- | Run a 'EventWriterT' action.
114runEventWriterT :: forall t m w a. (Reflex t, Monad m, Semigroup w) => EventWriterT t w m a -> m (a, Event t w)
102runEventWriterT :: forall t m w a. (Reflex t, Monad m, Semigroup w) => EventWriterT t w m a -> m (a, Event t w)
@@ -128,6 +116,9 @@ instance (Reflex t, Monad m, Semigroup w) => EventWriter t w (EventWriterT t w m
128 , _eventWriterState_told = (tellId myId :=> w) : _eventWriterState_told old
116 , _eventWriterState_told = (tellId myId :=> w) : _eventWriterState_told old
129 }
117 }
130
118
119+instance MonadTrans (EventWriterT t w) where
120+ lift = EventWriterT . lift
121+
131instance MonadSample t m => MonadSample t (EventWriterT t w m) where
122instance MonadSample t m => MonadSample t (EventWriterT t w m) where
132 sample = lift . sample
123 sample = lift . sample
133
124
@@ -142,8 +133,6 @@ instance MonadHold t m => MonadHold t (EventWriterT t w m) where
142 buildDynamic a0 = lift . buildDynamic a0
133 buildDynamic a0 = lift . buildDynamic a0
143 {-# INLINABLE headE #-}
134 {-# INLINABLE headE #-}
144 headE = lift . headE
135 headE = lift . headE
145− {-# INLINABLE now #-}
146− now = lift now
147
136
148instance (Reflex t, Adjustable t m, MonadHold t m, Semigroup w) => Adjustable t (EventWriterT t w m) where
137instance (Reflex t, Adjustable t m, MonadHold t m, Semigroup w) => Adjustable t (EventWriterT t w m) where
149 runWithReplace = runWithReplaceEventWriterTWith $ \dm0 dm' -> lift $ runWithReplace dm0 dm'
138 runWithReplace = runWithReplaceEventWriterTWith $ \dm0 dm' -> lift $ runWithReplace dm0 dm'
src/Reflex/FastWeak.hs−10
@@ -151,16 +151,6 @@ getFastWeakTicket w = do
151
151
152-- | Create a 'FastWeakTicket' directly from a value, creating a 'FastWeak' in the process
152-- | Create a 'FastWeakTicket' directly from a value, creating a 'FastWeak' in the process
153-- which can be obtained with 'getFastWeakTicketValue'.
153-- which can be obtained with 'getFastWeakTicketValue'.
154−--
155−-- This function is marked NOINLINE so it is opaque to GHC.
156−-- If we do not do this, then GHC will sometimes fuse the constructor away
157−-- so any weak references that are attached to the ticket will have their
158−-- finalizer run. Using the opaque constructor, GHC does not see the
159−-- constructor application, so it behaves like an IORef and cannot be fused away.
160−--
161−-- The result is also evaluated to WHNF, since forcing a thunk invalidates
162−-- the weak pointer to it in some cases.
163−{-# NOINLINE mkFastWeakTicket #-}
164mkFastWeakTicket :: a -> IO (FastWeakTicket a)
154mkFastWeakTicket :: a -> IO (FastWeakTicket a)
165-- I think it's fine if this is lazy - it'll retain the 'a', but so would the output; we just need to make sure it's forced before we start relying on the
155-- I think it's fine if this is lazy - it'll retain the 'a', but so would the output; we just need to make sure it's forced before we start relying on the
166-- associated FastWeak to actually be weak
156-- associated FastWeak to actually be weak
src/Reflex/Host/Headless.hsdeleted−128
@@ -1,128 +0,0 @@
1−{-# LANGUAGE LambdaCase #-}
2−{-# LANGUAGE FlexibleContexts #-}
3−{-# LANGUAGE RankNTypes #-}
4−{-# LANGUAGE TypeFamilies #-}
5−{-# LANGUAGE ConstraintKinds #-}
6−
7−module Reflex.Host.Headless where
8−
9−import Control.Concurrent.Chan (newChan, readChan)
10−import Control.Monad (unless)
11−import Control.Monad.Fix (MonadFix, fix)
12−import Control.Monad.IO.Class (MonadIO, liftIO)
13−import Control.Monad.Primitive (PrimMonad)
14−import Control.Monad.Ref (MonadRef, Ref, readRef)
15−import Data.Dependent.Sum (DSum (..), (==>))
16−import Data.Foldable (for_)
17−import Data.Functor.Identity (Identity(..))
18−import Data.IORef (IORef, readIORef)
19−import Data.Maybe (catMaybes, fromMaybe)
20−import Data.Traversable (for)
21−
22−import Reflex
23−import Reflex.Host.Class
24−
25−type MonadHeadlessApp t m =
26− ( Adjustable t m
27− , MonadFix m
28− , MonadHold t m
29− , MonadIO (HostFrame t)
30− , MonadIO (Performable m)
31− , MonadIO m
32− , MonadRef (HostFrame t)
33− , NotReady t m
34− , PerformEvent t m
35− , PostBuild t m
36− , PrimMonad (HostFrame t)
37− , Ref (HostFrame t) ~ IORef
38− , Ref m ~ IORef
39− , Reflex t
40− , ReflexHost t
41− , TriggerEvent t m
42− )
43−
44−-- | Run a headless FRP network. Inside the action, you will most probably use
45−-- the capabilities provided by the 'TriggerEvent' and 'PerformEvent' type
46−-- classes to interface the FRP network with the outside world. Useful for
47−-- testing. Each headless network runs on its own spider timeline.
48−runHeadlessApp
49− :: (forall t m. MonadHeadlessApp t m => m (Event t ()))
50− -- ^ The action to be run in the headless FRP network. The FRP network is
51− -- closed at the first occurrence of the resulting 'Event'.
52− -> IO ()
53−runHeadlessApp guest =
54− -- We are using the 'Spider' implementation of reflex. Running the host
55− -- allows us to take actions on the FRP timeline.
56− withSpiderTimeline $ runSpiderHostForTimeline $ do
57− -- Create the "post-build" event and associated trigger. This event fires
58− -- once, when the application starts.
59− (postBuild, postBuildTriggerRef) <- newEventWithTriggerRef
60− -- Create a queue to which we will write 'Event's that need to be
61− -- processed.
62− events <- liftIO newChan
63− -- Run the "guest" application, providing the appropriate context. We'll
64− -- pure the result of the action, and a 'FireCommand' that will be used to
65− -- trigger events.
66− (result, fc@(FireCommand fire)) <- do
67− hostPerformEventT $ -- Allows the guest app to run
68− -- 'performEvent', so that actions
69− -- (e.g., IO actions) can be run when
70− -- 'Event's fire.
71−
72− flip runPostBuildT postBuild $ -- Allows the guest app to access to
73− -- a "post-build" 'Event'
74−
75− flip runTriggerEventT events $ -- Allows the guest app to create new
76− -- events and triggers and write
77− -- those triggers to a channel from
78− -- which they will be read and
79− -- processed.
80− guest
81−
82− -- Read the trigger reference for the post-build event. This will be
83− -- 'Nothing' if the guest application hasn't subscribed to this event.
84− mPostBuildTrigger <- readRef postBuildTriggerRef
85−
86− -- Subscribe to an 'Event' of that the guest application can use to
87− -- request application shutdown. We'll check whether this 'Event' is firing
88− -- to determine whether to terminate.
89− shutdown <- subscribeEvent result
90−
91− -- When there is a subscriber to the post-build event, fire the event.
92− soa <- for mPostBuildTrigger $ \postBuildTrigger ->
93− fire [postBuildTrigger :=> Identity ()] $ isFiring shutdown
94−
95− -- The main application loop. We wait for new events and fire those that
96− -- have subscribers. If we detect a shutdown request, the application
97− -- terminates.
98− unless (or (fromMaybe [] soa)) $ fix $ \loop -> do
99− -- Read the next event (blocking).
100− ers <- liftIO $ readChan events
101− stop <- do
102− -- Fire events that have subscribers.
103− fireEventTriggerRefs fc ers $
104− -- Check if the shutdown 'Event' is firing.
105− isFiring shutdown
106− if or stop
107− then pure ()
108− else loop
109− where
110− isFiring ev = readEvent ev >>= \case
111− Nothing -> pure False
112− Just _ -> pure True
113− -- Use the given 'FireCommand' to fire events that have subscribers
114− -- and call the callback for the 'TriggerInvocation' of each.
115− fireEventTriggerRefs
116− :: MonadIO m
117− => FireCommand t m
118− -> [DSum (EventTriggerRef t) TriggerInvocation]
119− -> ReadPhase m a
120− -> m [a]
121− fireEventTriggerRefs (FireCommand fire) ers rcb = do
122− mes <- liftIO $
123− for ers $ \(EventTriggerRef er :=> TriggerInvocation a _) -> do
124− me <- readIORef er
125− pure $ fmap (==> a) me
126− a <- fire (catMaybes mes) rcb
127− liftIO $ for_ ers $ \(_ :=> TriggerInvocation _ cb) -> cb
128− pure a
src/Reflex/Patch.hsnew file+46
@@ -0,0 +1,46 @@
1+{-# LANGUAGE TypeFamilies #-}
2+-- |
3+-- Module:
4+-- Reflex.Patch
5+-- Description:
6+-- This module defines the 'Patch' class, which is used by Reflex to manage
7+-- changes to 'Reflex.Class.Incremental' values.
8+module Reflex.Patch
9+ ( module Reflex.Patch
10+ , module X
11+ ) where
12+
13+import Reflex.Patch.Class as X
14+import Reflex.Patch.DMap as X hiding (getDeletions)
15+import Reflex.Patch.DMapWithMove as X (PatchDMapWithMove, const2PatchDMapWithMoveWith, mapPatchDMapWithMove,
16+ patchDMapWithMoveToPatchMapWithMoveWith,
17+ traversePatchDMapWithMoveWithKey, unPatchDMapWithMove,
18+ unsafePatchDMapWithMove, weakenPatchDMapWithMoveWith)
19+import Reflex.Patch.IntMap as X hiding (getDeletions)
20+import Reflex.Patch.Map as X
21+import Reflex.Patch.MapWithMove as X (PatchMapWithMove, patchMapWithMoveNewElements,
22+ patchMapWithMoveNewElementsMap, unPatchMapWithMove,
23+ unsafePatchMapWithMove)
24+import Data.Map.Monoidal (MonoidalMap)
25+import Data.Semigroup (Semigroup (..), (<>))
26+
27+-- | A 'Group' is a 'Monoid' where every element has an inverse.
28+class (Semigroup q, Monoid q) => Group q where
29+ negateG :: q -> q
30+ (~~) :: q -> q -> q
31+ r ~~ s = r <> negateG s
32+
33+-- | An 'Additive' 'Semigroup' is one where (<>) is commutative
34+class Semigroup q => Additive q where
35+
36+-- | The elements of an 'Additive' 'Semigroup' can be considered as patches of their own type.
37+newtype AdditivePatch p = AdditivePatch { unAdditivePatch :: p }
38+
39+instance Additive p => Patch (AdditivePatch p) where
40+ type PatchTarget (AdditivePatch p) = p
41+ apply (AdditivePatch p) q = Just $ p <> q
42+
43+instance (Ord k, Group q) => Group (MonoidalMap k q) where
44+ negateG = fmap negateG
45+
46+instance (Ord k, Additive q) => Additive (MonoidalMap k q)
src/Reflex/Patch/Class.hsnew file+34
@@ -0,0 +1,34 @@
1+{-# LANGUAGE TypeFamilies #-}
2+-- | The interface for types which represent changes made to other types
3+module Reflex.Patch.Class where
4+
5+import Control.Monad.Identity
6+import Data.Maybe
7+import Data.Semigroup (Semigroup(..))
8+
9+-- | A 'Patch' type represents a kind of change made to a datastructure.
10+--
11+-- If an instance of 'Patch' is also an instance of 'Semigroup', it should obey
12+-- the law that @applyAlways (f <> g) == applyAlways f . applyAlways g@.
13+class Patch p where
14+ type PatchTarget p :: *
15+ -- | Apply the patch @p a@ to the value @a@. If no change is needed, return
16+ -- 'Nothing'.
17+ apply :: p -> PatchTarget p -> Maybe (PatchTarget p)
18+
19+-- | Apply a 'Patch'; if it does nothing, return the original value
20+applyAlways :: Patch p => p -> PatchTarget p -> PatchTarget p
21+applyAlways p t = fromMaybe t $ apply p t
22+
23+-- | 'Identity' can be used as a 'Patch' that always fully replaces the value
24+instance Patch (Identity a) where
25+ type PatchTarget (Identity a) = a
26+ apply (Identity a) _ = Just a
27+
28+-- | Like '(.)', but composes functions that return patches rather than
29+-- functions that return new values. The Semigroup instance for patches must
30+-- apply patches right-to-left, like '(.)'.
31+composePatchFunctions :: (Patch p, Semigroup p) => (PatchTarget p -> p) -> (PatchTarget p -> p) -> PatchTarget p -> p
32+composePatchFunctions g f a =
33+ let fp = f a
34+ in g (applyAlways fp a) <> fp
src/Reflex/Patch/DMap.hsnew file+82
@@ -0,0 +1,82 @@
1+{-# LANGUAGE GeneralizedNewtypeDeriving #-}
2+{-# LANGUAGE LambdaCase #-}
3+{-# LANGUAGE PolyKinds #-}
4+{-# LANGUAGE Rank2Types #-}
5+{-# LANGUAGE ScopedTypeVariables #-}
6+{-# LANGUAGE StandaloneDeriving #-}
7+{-# LANGUAGE TypeFamilies #-}
8+-- | 'Patch'es on 'DMap' that consist only of insertions (or overwrites) and deletions.
9+module Reflex.Patch.DMap where
10+
11+import Reflex.Patch.Class
12+import Reflex.Patch.IntMap
13+import Reflex.Patch.Map
14+
15+import Data.Dependent.Map (DMap, DSum (..), GCompare (..))
16+import qualified Data.Dependent.Map as DMap
17+import Data.Functor.Constant
18+import Data.Functor.Misc
19+import qualified Data.IntMap as IntMap
20+import qualified Data.Map as Map
21+import Data.Semigroup (Semigroup (..))
22+import Data.Some (Some)
23+
24+-- | A set of changes to a 'DMap'. Any element may be inserted/updated or deleted.
25+-- Insertions are represented as @'ComposeMaybe' (Just value)@,
26+-- while deletions are represented as @'ComposeMaybe' Nothing@.
27+newtype PatchDMap k v = PatchDMap { unPatchDMap :: DMap k (ComposeMaybe v) }
28+
29+deriving instance GCompare k => Semigroup (PatchDMap k v)
30+
31+deriving instance GCompare k => Monoid (PatchDMap k v)
32+
33+-- | Apply the insertions or deletions to a given 'DMap'.
34+instance GCompare k => Patch (PatchDMap k v) where
35+ type PatchTarget (PatchDMap k v) = DMap k v
36+ apply (PatchDMap diff) old = Just $! insertions `DMap.union` (old `DMap.difference` deletions) --TODO: return Nothing sometimes --Note: the strict application here is critical to ensuring that incremental merges don't hold onto all their prerequisite events forever; can we make this more robust?
37+ where insertions = DMap.mapMaybeWithKey (const $ getComposeMaybe) diff
38+ deletions = DMap.mapMaybeWithKey (const $ nothingToJust . getComposeMaybe) diff
39+ nothingToJust = \case
40+ Nothing -> Just $ Constant ()
41+ Just _ -> Nothing
42+
43+-- | Map a function @v a -> v' a@ over any inserts/updates in the given
44+-- @'PatchDMap' k v@ to produce a @'PatchDMap' k v'@.
45+mapPatchDMap :: (forall a. v a -> v' a) -> PatchDMap k v -> PatchDMap k v'
46+mapPatchDMap f (PatchDMap p) = PatchDMap $ DMap.map (ComposeMaybe . fmap f . getComposeMaybe) p
47+
48+-- | Map an effectful function @v a -> f (v' a)@ over any inserts/updates in the given
49+-- @'PatchDMap' k v@ to produce a @'PatchDMap' k v'@.
50+traversePatchDMap :: Applicative f => (forall a. v a -> f (v' a)) -> PatchDMap k v -> f (PatchDMap k v')
51+traversePatchDMap f = traversePatchDMapWithKey $ const f
52+
53+-- | Map an effectful function @k a -> v a -> f (v' a)@ over any inserts/updates
54+-- in the given @'PatchDMap' k v@ to produce a @'PatchDMap' k v'@.
55+traversePatchDMapWithKey :: Applicative m => (forall a. k a -> v a -> m (v' a)) -> PatchDMap k v -> m (PatchDMap k v')
56+traversePatchDMapWithKey f (PatchDMap p) = PatchDMap <$> DMap.traverseWithKey (\k (ComposeMaybe v) -> ComposeMaybe <$> traverse (f k) v) p
57+
58+-- | Weaken a @'PatchDMap' k v@ to a @'PatchMap' (Some k) v'@ using a function
59+-- @v a -> v'@ to weaken each value contained in the patch.
60+weakenPatchDMapWith :: (forall a. v a -> v') -> PatchDMap k v -> PatchMap (Some k) v'
61+weakenPatchDMapWith f (PatchDMap p) = PatchMap $ weakenDMapWith (fmap f . getComposeMaybe) p
62+
63+-- | Convert a weak @'PatchDMap' ('Const2' k a) v@ where the @a@ is known by way of
64+-- the @Const2@ into a @'PatchMap' k v'@ using a rank 1 function @v a -> v'@.
65+patchDMapToPatchMapWith :: (v a -> v') -> PatchDMap (Const2 k a) v -> PatchMap k v'
66+patchDMapToPatchMapWith f (PatchDMap p) = PatchMap $ dmapToMapWith (fmap f . getComposeMaybe) p
67+
68+-- | Convert a @'PatchMap' k v@ into a @'PatchDMap' ('Const2' k a) v'@ using a function @v -> v' a@.
69+const2PatchDMapWith :: forall k v v' a. (v -> v' a) -> PatchMap k v -> PatchDMap (Const2 k a) v'
70+const2PatchDMapWith f (PatchMap p) = PatchDMap $ DMap.fromDistinctAscList $ g <$> Map.toAscList p
71+ where g :: (k, Maybe v) -> DSum (Const2 k a) (ComposeMaybe v')
72+ g (k, e) = Const2 k :=> ComposeMaybe (f <$> e)
73+
74+-- | Convert a @'PatchIntMap' v@ into a @'PatchDMap' ('Const2' Int a) v'@ using a function @v -> v' a@.
75+const2IntPatchDMapWith :: forall v f a. (v -> f a) -> PatchIntMap v -> PatchDMap (Const2 IntMap.Key a) f
76+const2IntPatchDMapWith f (PatchIntMap p) = PatchDMap $ DMap.fromDistinctAscList $ g <$> IntMap.toAscList p
77+ where g :: (IntMap.Key, Maybe v) -> DSum (Const2 IntMap.Key a) (ComposeMaybe f)
78+ g (k, e) = Const2 k :=> ComposeMaybe (f <$> e)
79+
80+-- | Get the values that will be replaced or deleted if the given patch is applied to the given 'DMap'.
81+getDeletions :: GCompare k => PatchDMap k v -> DMap k v' -> DMap k v'
82+getDeletions (PatchDMap p) m = DMap.intersectionWithKey (\_ v _ -> v) m p
src/Reflex/Patch/DMapWithMove.hsnew file+363
@@ -0,0 +1,363 @@
1+{-# LANGUAGE CPP #-}
2+{-# LANGUAGE FlexibleContexts #-}
3+{-# LANGUAGE FlexibleInstances #-}
4+{-# LANGUAGE GADTs #-}
5+{-# LANGUAGE LambdaCase #-}
6+{-# LANGUAGE MultiParamTypeClasses #-}
7+{-# LANGUAGE PatternGuards #-}
8+{-# LANGUAGE PolyKinds #-}
9+{-# LANGUAGE Rank2Types #-}
10+{-# LANGUAGE ScopedTypeVariables #-}
11+{-# LANGUAGE TypeFamilies #-}
12+{-# LANGUAGE UndecidableInstances #-}
13+
14+-- |Module containing @'PatchDMapWithMove' k v@ and associated functions, which represents a 'Patch' to a @'DMap' k v@ which can insert, update, delete, and
15+-- move values between keys.
16+module Reflex.Patch.DMapWithMove where
17+
18+import Reflex.Patch.Class
19+import Reflex.Patch.MapWithMove (PatchMapWithMove (..))
20+import qualified Reflex.Patch.MapWithMove as MapWithMove
21+
22+import Data.Constraint.Extras
23+import Data.Dependent.Map (DMap, DSum (..), GCompare (..))
24+import qualified Data.Dependent.Map as DMap
25+import Data.Functor.Constant
26+import Data.Functor.Misc
27+import Data.Functor.Product
28+import Data.GADT.Compare (GEq (..))
29+import Data.GADT.Show (GShow, gshow)
30+import qualified Data.Map as Map
31+import Data.Maybe
32+import Data.Semigroup (Semigroup (..), (<>))
33+import Data.Some (Some(Some))
34+import Data.These
35+
36+-- | Like 'PatchMapWithMove', but for 'DMap'. Each key carries a 'NodeInfo' which describes how it will be changed by the patch and connects move sources and
37+-- destinations.
38+--
39+-- Invariants:
40+--
41+-- * A key should not move to itself.
42+-- * A move should always be represented with both the destination key (as a 'From_Move') and the source key (as a @'ComposeMaybe' ('Just' destination)@)
43+newtype PatchDMapWithMove k v = PatchDMapWithMove (DMap k (NodeInfo k v))
44+
45+-- |Structure which represents what changes apply to a particular key. @_nodeInfo_from@ specifies what happens to this key, and in particular what other key
46+-- the current key is moving from, while @_nodeInfo_to@ specifies what key the current key is moving to if involved in a move.
47+data NodeInfo k v a = NodeInfo
48+ { _nodeInfo_from :: !(From k v a)
49+ -- ^Change applying to the current key, be it an insert, move, or delete.
50+ , _nodeInfo_to :: !(To k a)
51+ -- ^Where this key is moving to, if involved in a move. Should only be @ComposeMaybe (Just k)@ when there is a corresponding 'From_Move'.
52+ }
53+ deriving (Show)
54+
55+-- |Structure describing a particular change to a key, be it inserting a new key (@From_Insert@), updating an existing key (@From_Insert@ again), deleting a
56+-- key (@From_Delete@), or moving a key (@From_Move@).
57+data From (k :: a -> *) (v :: a -> *) :: a -> * where
58+ -- |Insert a new or update an existing key with the given value @v a@
59+ From_Insert :: v a -> From k v a
60+ -- |Delete the existing key
61+ From_Delete :: From k v a
62+ -- |Move the value from the given key @k a@ to this key. The source key should also have an entry in the patch giving the current key as @_nodeInfo_to@,
63+ -- usually but not necessarily with @From_Delete@.
64+ From_Move :: !(k a) -> From k v a
65+ deriving (Show, Read, Eq, Ord)
66+
67+-- |Type alias for the "to" part of a 'NodeInfo'. @'ComposeMaybe' ('Just' k)@ means the key is moving to another key, @ComposeMaybe Nothing@ for any other
68+-- operation.
69+type To = ComposeMaybe
70+
71+-- |Test whether a 'PatchDMapWithMove' satisfies its invariants.
72+validPatchDMapWithMove :: forall k v. (GCompare k, GShow k) => DMap k (NodeInfo k v) -> Bool
73+validPatchDMapWithMove = not . null . validationErrorsForPatchDMapWithMove
74+
75+-- |Enumerate what reasons a 'PatchDMapWithMove' doesn't satisfy its invariants, returning @[]@ if it's valid.
76+validationErrorsForPatchDMapWithMove :: forall k v. (GCompare k, GShow k) => DMap k (NodeInfo k v) -> [String]
77+validationErrorsForPatchDMapWithMove m =
78+ noSelfMoves <> movesBalanced
79+ where
80+ noSelfMoves = mapMaybe selfMove . DMap.toAscList $ m
81+ selfMove (dst :=> NodeInfo (From_Move src) _) | Just _ <- dst `geq` src = Just $ "self move of key " <> gshow src <> " at destination side"
82+ selfMove (src :=> NodeInfo _ (ComposeMaybe (Just dst))) | Just _ <- src `geq` dst = Just $ "self move of key " <> gshow dst <> " at source side"
83+ selfMove _ = Nothing
84+ movesBalanced = mapMaybe unbalancedMove . DMap.toAscList $ m
85+ unbalancedMove (dst :=> NodeInfo (From_Move src) _) =
86+ case DMap.lookup src m of
87+ Nothing -> Just $ "unbalanced move at destination key " <> gshow dst <> " supposedly from " <> gshow src <> " but source key is not in the patch"
88+ Just (NodeInfo _ (ComposeMaybe (Just dst'))) ->
89+ if isNothing (dst' `geq` dst)
90+ then Just $ "unbalanced move at destination key " <> gshow dst <> " from " <> gshow src <> " is going to " <> gshow dst' <> " instead"
91+ else Nothing
92+ _ ->
93+ Just $ "unbalanced move at destination key " <> gshow dst <> " supposedly from " <> gshow src <> " but source key has no move to key"
94+ unbalancedMove (src :=> NodeInfo _ (ComposeMaybe (Just dst))) =
95+ case DMap.lookup dst m of
96+ Nothing -> Just $ " unbalanced move at source key " <> gshow src <> " supposedly going to " <> gshow dst <> " but destination key is not in the patch"
97+ Just (NodeInfo (From_Move src') _) ->
98+ if isNothing (src' `geq` src)
99+ then Just $ "unbalanced move at source key " <> gshow src <> " to " <> gshow dst <> " is coming from " <> gshow src' <> " instead"
100+ else Nothing
101+
102+ _ ->
103+ Just $ "unbalanced move at source key " <> gshow src <> " supposedly going to " <> gshow dst <> " but destination key is not moving"
104+ unbalancedMove _ = Nothing
105+
106+-- |Test whether two @'PatchDMapWithMove' k v@ contain the same patch operations.
107+instance (GEq k, Has' Eq k (NodeInfo k v)) => Eq (PatchDMapWithMove k v) where
108+ PatchDMapWithMove a == PatchDMapWithMove b = a == b
109+
110+-- |Higher kinded 2-tuple, identical to @Data.Functor.Product@ from base ≥ 4.9
111+data Pair1 f g a = Pair1 (f a) (g a)
112+
113+-- |Helper data structure used for composing patches using the monoid instance.
114+data Fixup k v a
115+ = Fixup_Delete
116+ | Fixup_Update (These (From k v a) (To k a))
117+
118+-- |Compose patches having the same effect as applying the patches in turn: @'applyAlways' (p <> q) == 'applyAlways' p . 'applyAlways' q@
119+instance GCompare k => Semigroup (PatchDMapWithMove k v) where
120+ PatchDMapWithMove ma <> PatchDMapWithMove mb = PatchDMapWithMove m
121+ where
122+ connections = DMap.toList $ DMap.intersectionWithKey (\_ a b -> Pair1 (_nodeInfo_to a) (_nodeInfo_from b)) ma mb
123+ h :: DSum k (Pair1 (ComposeMaybe k) (From k v)) -> [DSum k (Fixup k v)]
124+ h (_ :=> Pair1 (ComposeMaybe mToAfter) editBefore) = case (mToAfter, editBefore) of
125+ (Just toAfter, From_Move fromBefore)
126+ | isJust $ fromBefore `geq` toAfter
127+ -> [toAfter :=> Fixup_Delete]
128+ | otherwise
129+ -> [ toAfter :=> Fixup_Update (This editBefore)
130+ , fromBefore :=> Fixup_Update (That (ComposeMaybe mToAfter))
131+ ]
132+ (Nothing, From_Move fromBefore) -> [fromBefore :=> Fixup_Update (That (ComposeMaybe mToAfter))] -- The item is destroyed in the second patch, so indicate that it is destroyed in the source map
133+ (Just toAfter, _) -> [toAfter :=> Fixup_Update (This editBefore)]
134+ (Nothing, _) -> []
135+ mergeFixups _ Fixup_Delete Fixup_Delete = Fixup_Delete
136+ mergeFixups _ (Fixup_Update a) (Fixup_Update b)
137+ | This x <- a, That y <- b
138+ = Fixup_Update $ These x y
139+ | That y <- a, This x <- b
140+ = Fixup_Update $ These x y
141+ mergeFixups _ _ _ = error "PatchDMapWithMove: incompatible fixups"
142+ fixups = DMap.fromListWithKey mergeFixups $ concatMap h connections
143+ combineNodeInfos _ nia nib = NodeInfo
144+ { _nodeInfo_from = _nodeInfo_from nia
145+ , _nodeInfo_to = _nodeInfo_to nib
146+ }
147+ applyFixup _ ni = \case
148+ Fixup_Delete -> Nothing
149+ Fixup_Update u -> Just $ NodeInfo
150+ { _nodeInfo_from = fromMaybe (_nodeInfo_from ni) $ getHere u
151+ , _nodeInfo_to = fromMaybe (_nodeInfo_to ni) $ getThere u
152+ }
153+ m = DMap.differenceWithKey applyFixup (DMap.unionWithKey combineNodeInfos ma mb) fixups
154+ getHere :: These a b -> Maybe a
155+ getHere = \case
156+ This a -> Just a
157+ These a _ -> Just a
158+ That _ -> Nothing
159+ getThere :: These a b -> Maybe b
160+ getThere = \case
161+ This _ -> Nothing
162+ These _ b -> Just b
163+ That b -> Just b
164+
165+-- |Compose patches having the same effect as applying the patches in turn: @'applyAlways' (p <> q) == 'applyAlways' p . 'applyAlways' q@
166+instance GCompare k => Monoid (PatchDMapWithMove k v) where
167+ mempty = PatchDMapWithMove mempty
168+ mappend = (<>)
169+
170+{-
171+mappendPatchDMapWithMoveSlow :: forall k v. (ShowTag k v, GCompare k) => PatchDMapWithMove k v -> PatchDMapWithMove k v -> PatchDMapWithMove k v
172+PatchDMapWithMove dstAfter srcAfter `mappendPatchDMapWithMoveSlow` PatchDMapWithMove dstBefore srcBefore = PatchDMapWithMove dst src
173+ where
174+ getDstAction k m = fromMaybe (From_Move k) $ DMap.lookup k m -- Any key that isn't present is treated as that key moving to itself
175+ removeRedundantDst toKey (From_Move fromKey) | isJust (toKey `geq` fromKey) = Nothing
176+ removeRedundantDst _ a = Just a
177+ f :: forall a. k a -> From k v a -> Maybe (From k v a)
178+ f toKey _ = removeRedundantDst toKey $ case getDstAction toKey dstAfter of
179+ From_Move fromKey -> getDstAction fromKey dstBefore
180+ nonMove -> nonMove
181+ dst = DMap.mapMaybeWithKey f $ DMap.union dstAfter dstBefore
182+ getSrcAction k m = fromMaybe (ComposeMaybe $ Just k) $ DMap.lookup k m
183+ removeRedundantSrc fromKey (ComposeMaybe (Just toKey)) | isJust (fromKey `geq` toKey) = Nothing
184+ removeRedundantSrc _ a = Just a
185+ g :: forall a. k a -> ComposeMaybe k a -> Maybe (ComposeMaybe k a)
186+ g fromKey _ = removeRedundantSrc fromKey $ case getSrcAction fromKey srcBefore of
187+ ComposeMaybe Nothing -> ComposeMaybe Nothing
188+ ComposeMaybe (Just toKeyBefore) -> getSrcAction toKeyBefore srcAfter
189+ src = DMap.mapMaybeWithKey g $ DMap.union srcAfter srcBefore
190+-}
191+
192+-- |Make a @'PatchDMapWithMove' k v@ which has the effect of inserting or updating a value @v a@ to the given key @k a@, like 'DMap.insert'.
193+insertDMapKey :: k a -> v a -> PatchDMapWithMove k v
194+insertDMapKey k v =
195+ PatchDMapWithMove . DMap.singleton k $ NodeInfo (From_Insert v) (ComposeMaybe Nothing)
196+
197+-- |Make a @'PatchDMapWithMove' k v@ which has the effect of moving the value from the first key @k a@ to the second key @k a@, equivalent to:
198+--
199+-- @
200+-- 'DMap.delete' src (maybe dmap ('DMap.insert' dst) (DMap.lookup src dmap))
201+-- @
202+moveDMapKey :: GCompare k => k a -> k a -> PatchDMapWithMove k v
203+moveDMapKey src dst = case src `geq` dst of
204+ Nothing -> PatchDMapWithMove $ DMap.fromList
205+ [ dst :=> NodeInfo (From_Move src) (ComposeMaybe Nothing)
206+ , src :=> NodeInfo From_Delete (ComposeMaybe $ Just dst)
207+ ]
208+ Just _ -> mempty
209+
210+-- |Make a @'PatchDMapWithMove' k v@ which has the effect of swapping two keys in the mapping, equivalent to:
211+--
212+-- @
213+-- let aMay = DMap.lookup a dmap
214+-- bMay = DMap.lookup b dmap
215+-- in maybe id (DMap.insert a) (bMay `mplus` aMay)
216+-- . maybe id (DMap.insert b) (aMay `mplus` bMay)
217+-- . DMap.delete a . DMap.delete b $ dmap
218+-- @
219+swapDMapKey :: GCompare k => k a -> k a -> PatchDMapWithMove k v
220+swapDMapKey src dst = case src `geq` dst of
221+ Nothing -> PatchDMapWithMove $ DMap.fromList
222+ [ dst :=> NodeInfo (From_Move src) (ComposeMaybe $ Just src)
223+ , src :=> NodeInfo (From_Move dst) (ComposeMaybe $ Just dst)
224+ ]
225+ Just _ -> mempty
226+
227+-- |Make a @'PatchDMapWithMove' k v@ which has the effect of deleting a key in the mapping, equivalent to 'DMap.delete'.
228+deleteDMapKey :: k a -> PatchDMapWithMove k v
229+deleteDMapKey k = PatchDMapWithMove $ DMap.singleton k $ NodeInfo From_Delete $ ComposeMaybe Nothing
230+
231+{-
232+k1, k2 :: Const2 Int () ()
233+k1 = Const2 1
234+k2 = Const2 2
235+p1, p2 :: PatchDMapWithMove (Const2 Int ()) Identity
236+p1 = moveDMapKey k1 k2
237+p2 = moveDMapKey k2 k1
238+p12 = p1 <> p2
239+p21 = p2 <> p1
240+p12Slow = p1 `mappendPatchDMapWithMoveSlow` p2
241+p21Slow = p2 `mappendPatchDMapWithMoveSlow` p1
242+
243+testPatchDMapWithMove = do
244+ print p1
245+ print p2
246+ print $ p12 == deleteDMapKey k1
247+ print $ p21 == deleteDMapKey k2
248+ print $ p12Slow == deleteDMapKey k1
249+ print $ p21Slow == deleteDMapKey k2
250+
251+dst (PatchDMapWithMove x _) = x
252+src (PatchDMapWithMove _ x) = x
253+-}
254+
255+-- |Extract the 'DMap' representing the patch changes from the 'PatchDMapWithMove'.
256+unPatchDMapWithMove :: PatchDMapWithMove k v -> DMap k (NodeInfo k v)
257+unPatchDMapWithMove (PatchDMapWithMove p) = p
258+
259+-- |Wrap a 'DMap' representing patch changes into a 'PatchDMapWithMove', without checking any invariants.
260+--
261+-- __Warning:__ when using this function, you must ensure that the invariants of 'PatchDMapWithMove' are preserved; they will not be checked.
262+unsafePatchDMapWithMove :: DMap k (NodeInfo k v) -> PatchDMapWithMove k v
263+unsafePatchDMapWithMove = PatchDMapWithMove
264+
265+-- |Wrap a 'DMap' representing patch changes into a 'PatchDMapWithMove' while checking invariants. If the invariants are satisfied, @Right p@ is returned
266+-- otherwise @Left errors@.
267+patchDMapWithMove :: (GCompare k, GShow k) => DMap k (NodeInfo k v) -> Either [String] (PatchDMapWithMove k v)
268+patchDMapWithMove dm =
269+ case validationErrorsForPatchDMapWithMove dm of
270+ [] -> Right $ unsafePatchDMapWithMove dm
271+ errs -> Left errs
272+
273+-- |Map a natural transform @v -> v'@ over the given patch, transforming @'PatchDMapWithMove' k v@ into @'PatchDMapWithMove' k v'@.
274+mapPatchDMapWithMove :: forall k v v'. (forall a. v a -> v' a) -> PatchDMapWithMove k v -> PatchDMapWithMove k v'
275+mapPatchDMapWithMove f (PatchDMapWithMove p) = PatchDMapWithMove $
276+ DMap.map (\ni -> ni { _nodeInfo_from = g $ _nodeInfo_from ni }) p
277+ where g :: forall a. From k v a -> From k v' a
278+ g = \case
279+ From_Insert v -> From_Insert $ f v
280+ From_Delete -> From_Delete
281+ From_Move k -> From_Move k
282+
283+-- |Traverse an effectful function @forall a. v a -> m (v ' a)@ over the given patch, transforming @'PatchDMapWithMove' k v@ into @m ('PatchDMapWithMove' k v')@.
284+traversePatchDMapWithMove :: forall m k v v'. Applicative m => (forall a. v a -> m (v' a)) -> PatchDMapWithMove k v -> m (PatchDMapWithMove k v')
285+traversePatchDMapWithMove f = traversePatchDMapWithMoveWithKey $ const f
286+
287+-- |Map an effectful function @forall a. k a -> v a -> m (v ' a)@ over the given patch, transforming @'PatchDMapWithMove' k v@ into @m ('PatchDMapWithMove' k v')@.
288+traversePatchDMapWithMoveWithKey :: forall m k v v'. Applicative m => (forall a. k a -> v a -> m (v' a)) -> PatchDMapWithMove k v -> m (PatchDMapWithMove k v')
289+traversePatchDMapWithMoveWithKey f (PatchDMapWithMove p) = PatchDMapWithMove <$> DMap.traverseWithKey (nodeInfoMapFromM . g) p
290+ where g :: forall a. k a -> From k v a -> m (From k v' a)
291+ g k = \case
292+ From_Insert v -> From_Insert <$> f k v
293+ From_Delete -> pure From_Delete
294+ From_Move fromKey -> pure $ From_Move fromKey
295+
296+-- |Map a function which transforms @'From' k v a@ into a @'From' k v' a@ over a @'NodeInfo' k v a@.
297+nodeInfoMapFrom :: (From k v a -> From k v' a) -> NodeInfo k v a -> NodeInfo k v' a
298+nodeInfoMapFrom f ni = ni { _nodeInfo_from = f $ _nodeInfo_from ni }
299+
300+-- |Map an effectful function which transforms @'From' k v a@ into a @f ('From' k v' a)@ over a @'NodeInfo' k v a@.
301+nodeInfoMapFromM :: Functor f => (From k v a -> f (From k v' a)) -> NodeInfo k v a -> f (NodeInfo k v' a)
302+nodeInfoMapFromM f ni = fmap (\result -> ni { _nodeInfo_from = result }) $ f $ _nodeInfo_from ni
303+
304+-- |Weaken a 'PatchDMapWithMove' to a 'PatchMapWithMove' by weakening the keys from @k a@ to @'Some' k@ and applying a given weakening function @v a -> v'@ to
305+-- values.
306+weakenPatchDMapWithMoveWith :: forall k v v'. (forall a. v a -> v') -> PatchDMapWithMove k v -> PatchMapWithMove (Some k) v'
307+weakenPatchDMapWithMoveWith f (PatchDMapWithMove p) = PatchMapWithMove $ weakenDMapWith g p
308+ where g :: forall a. NodeInfo k v a -> MapWithMove.NodeInfo (Some k) v'
309+ g ni = MapWithMove.NodeInfo
310+ { MapWithMove._nodeInfo_from = case _nodeInfo_from ni of
311+ From_Insert v -> MapWithMove.From_Insert $ f v
312+ From_Delete -> MapWithMove.From_Delete
313+ From_Move k -> MapWithMove.From_Move $ Some k
314+ , MapWithMove._nodeInfo_to = Some <$> getComposeMaybe (_nodeInfo_to ni)
315+ }
316+
317+-- |"Weaken" a @'PatchDMapWithMove' (Const2 k a) v@ to a @'PatchMapWithMove' k v'@. Weaken is in scare quotes because the 'Const2' has already disabled any
318+-- dependency in the typing and all points are already @a@, hence the function to map each value to @v'@ is not higher rank.
319+patchDMapWithMoveToPatchMapWithMoveWith :: forall k v v' a. (v a -> v') -> PatchDMapWithMove (Const2 k a) v -> PatchMapWithMove k v'
320+patchDMapWithMoveToPatchMapWithMoveWith f (PatchDMapWithMove p) = PatchMapWithMove $ dmapToMapWith g p
321+ where g :: NodeInfo (Const2 k a) v a -> MapWithMove.NodeInfo k v'
322+ g ni = MapWithMove.NodeInfo
323+ { MapWithMove._nodeInfo_from = case _nodeInfo_from ni of
324+ From_Insert v -> MapWithMove.From_Insert $ f v
325+ From_Delete -> MapWithMove.From_Delete
326+ From_Move (Const2 k) -> MapWithMove.From_Move k
327+ , MapWithMove._nodeInfo_to = unConst2 <$> getComposeMaybe (_nodeInfo_to ni)
328+ }
329+
330+-- |"Strengthen" a @'PatchMapWithMove' k v@ into a @'PatchDMapWithMove ('Const2' k a)@; that is, turn a non-dependently-typed patch into a dependently typed
331+-- one but which always has a constant key type represented by 'Const2'. Apply the given function to each @v@ to produce a @v' a@.
332+-- Completemented by 'patchDMapWithMoveToPatchMapWithMoveWith'
333+const2PatchDMapWithMoveWith :: forall k v v' a. (v -> v' a) -> PatchMapWithMove k v -> PatchDMapWithMove (Const2 k a) v'
334+const2PatchDMapWithMoveWith f (PatchMapWithMove p) = PatchDMapWithMove $ DMap.fromDistinctAscList $ g <$> Map.toAscList p
335+ where g :: (k, MapWithMove.NodeInfo k v) -> DSum (Const2 k a) (NodeInfo (Const2 k a) v')
336+ g (k, ni) = Const2 k :=> NodeInfo
337+ { _nodeInfo_from = case MapWithMove._nodeInfo_from ni of
338+ MapWithMove.From_Insert v -> From_Insert $ f v
339+ MapWithMove.From_Delete -> From_Delete
340+ MapWithMove.From_Move fromKey -> From_Move $ Const2 fromKey
341+ , _nodeInfo_to = ComposeMaybe $ Const2 <$> MapWithMove._nodeInfo_to ni
342+ }
343+
344+-- | Apply the insertions, deletions, and moves to a given 'DMap'.
345+instance GCompare k => Patch (PatchDMapWithMove k v) where
346+ type PatchTarget (PatchDMapWithMove k v) = DMap k v
347+ apply (PatchDMapWithMove p) old = Just $! insertions `DMap.union` (old `DMap.difference` deletions) --TODO: return Nothing sometimes --Note: the strict application here is critical to ensuring that incremental merges don't hold onto all their prerequisite events forever; can we make this more robust?
348+ where insertions = DMap.mapMaybeWithKey insertFunc p
349+ insertFunc :: forall a. k a -> NodeInfo k v a -> Maybe (v a)
350+ insertFunc _ ni = case _nodeInfo_from ni of
351+ From_Insert v -> Just v
352+ From_Move k -> DMap.lookup k old
353+ From_Delete -> Nothing
354+ deletions = DMap.mapMaybeWithKey deleteFunc p
355+ deleteFunc :: forall a. k a -> NodeInfo k v a -> Maybe (Constant () a)
356+ deleteFunc _ ni = case _nodeInfo_from ni of
357+ From_Delete -> Just $ Constant ()
358+ _ -> Nothing
359+
360+-- | Get the values that will be replaced, deleted, or moved if the given patch is applied to the given 'DMap'.
361+getDeletionsAndMoves :: GCompare k => PatchDMapWithMove k v -> DMap k v' -> DMap k (Product v' (ComposeMaybe k))
362+getDeletionsAndMoves (PatchDMapWithMove p) m = DMap.intersectionWithKey f m p
363+ where f _ v ni = Pair v $ _nodeInfo_to ni
src/Reflex/Patch/IntMap.hsnew file+59
@@ -0,0 +1,59 @@
1+{-# LANGUAGE DeriveFoldable #-}
2+{-# LANGUAGE DeriveFunctor #-}
3+{-# LANGUAGE DeriveTraversable #-}
4+{-# LANGUAGE GeneralizedNewtypeDeriving #-}
5+{-# LANGUAGE TypeFamilies #-}
6+-- | Module containing 'PatchIntMap', a 'Patch' for 'IntMap' which allows for
7+-- insert/update or delete of associations.
8+module Reflex.Patch.IntMap where
9+
10+import Data.IntMap.Strict (IntMap)
11+import qualified Data.IntMap.Strict as IntMap
12+import Data.Maybe
13+import Data.Semigroup
14+import Reflex.Patch.Class
15+
16+-- | 'Patch' for 'IntMap' which represents insertion or deletion of keys in the mapping.
17+-- Internally represented by 'IntMap (Maybe a)', where @Just@ means insert/update
18+-- and @Nothing@ means delete.
19+newtype PatchIntMap a = PatchIntMap (IntMap (Maybe a)) deriving (Functor, Foldable, Traversable, Monoid)
20+
21+-- | Apply the insertions or deletions to a given 'IntMap'.
22+instance Patch (PatchIntMap a) where
23+ type PatchTarget (PatchIntMap a) = IntMap a
24+ apply (PatchIntMap p) v = if IntMap.null p then Nothing else Just $
25+ let removes = IntMap.filter isNothing p
26+ adds = IntMap.mapMaybe id p
27+ in IntMap.union adds $ v `IntMap.difference` removes
28+
29+-- | @a <> b@ will apply the changes of @b@ and then apply the changes of @a@.
30+-- If the same key is modified by both patches, the one on the left will take
31+-- precedence.
32+instance Semigroup (PatchIntMap v) where
33+ PatchIntMap a <> PatchIntMap b = PatchIntMap $ a `mappend` b --TODO: Add a semigroup instance for Map
34+ -- PatchMap is idempotent, so stimes n is id for every n
35+ stimes = stimesIdempotentMonoid
36+
37+-- | Map a function @Int -> a -> b@ over all @a@s in the given @'PatchIntMap' a@
38+-- (that is, all inserts/updates), producing a @PatchIntMap b@.
39+mapIntMapPatchWithKey :: (Int -> a -> b) -> PatchIntMap a -> PatchIntMap b
40+mapIntMapPatchWithKey f (PatchIntMap m) = PatchIntMap $ IntMap.mapWithKey (\ k mv -> f k <$> mv) m
41+
42+-- | Map an effectful function @Int -> a -> f b@ over all @a@s in the given @'PatchIntMap' a@
43+-- (that is, all inserts/updates), producing a @f (PatchIntMap b)@.
44+traverseIntMapPatchWithKey :: Applicative f => (Int -> a -> f b) -> PatchIntMap a -> f (PatchIntMap b)
45+traverseIntMapPatchWithKey f (PatchIntMap m) = PatchIntMap <$> IntMap.traverseWithKey (\k mv -> traverse (f k) mv) m
46+
47+-- | Extract all @a@s inserted/updated by the given @'PatchIntMap' a@.
48+patchIntMapNewElements :: PatchIntMap a -> [a]
49+patchIntMapNewElements (PatchIntMap m) = catMaybes $ IntMap.elems m
50+
51+-- | Convert the given @'PatchIntMap' a@ into an @'IntMap' a@ with all
52+-- the inserts/updates in the given patch.
53+patchIntMapNewElementsMap :: PatchIntMap a -> IntMap a
54+patchIntMapNewElementsMap (PatchIntMap m) = IntMap.mapMaybe id m
55+
56+-- | Subset the given @'IntMap' a@ to contain only the keys that would be
57+-- deleted by the given @'PatchIntMap' a@.
58+getDeletions :: PatchIntMap v -> IntMap v' -> IntMap v'
59+getDeletions (PatchIntMap m) v = IntMap.intersection v m
src/Reflex/Patch/Map.hsnew file+55
@@ -0,0 +1,55 @@
1+{-# LANGUAGE LambdaCase #-}
2+{-# LANGUAGE TypeFamilies #-}
3+-- | 'Patch'es on 'Map' that consist only of insertions (including overwrites)
4+-- and deletions
5+module Reflex.Patch.Map where
6+
7+import Reflex.Patch.Class
8+
9+import Data.Map (Map)
10+import qualified Data.Map as Map
11+import Data.Maybe
12+import Data.Semigroup
13+
14+-- | A set of changes to a 'Map'. Any element may be inserted/updated or
15+-- deleted. Insertions are represented as values wrapped in 'Just', while
16+-- deletions are represented as 'Nothing's
17+newtype PatchMap k v = PatchMap { unPatchMap :: Map k (Maybe v) }
18+ deriving (Show, Read, Eq, Ord)
19+
20+-- | Apply the insertions or deletions to a given 'Map'.
21+instance Ord k => Patch (PatchMap k v) where
22+ type PatchTarget (PatchMap k v) = Map k v
23+ {-# INLINABLE apply #-}
24+ apply (PatchMap p) old = Just $! insertions `Map.union` (old `Map.difference` deletions) --TODO: return Nothing sometimes --Note: the strict application here is critical to ensuring that incremental merges don't hold onto all their prerequisite events forever; can we make this more robust?
25+ where insertions = Map.mapMaybeWithKey (const id) p
26+ deletions = Map.mapMaybeWithKey (const nothingToJust) p
27+ nothingToJust = \case
28+ Nothing -> Just ()
29+ Just _ -> Nothing
30+
31+-- | @a <> b@ will apply the changes of @b@ and then apply the changes of @a@.
32+-- If the same key is modified by both patches, the one on the left will take
33+-- precedence.
34+instance Ord k => Semigroup (PatchMap k v) where
35+ PatchMap a <> PatchMap b = PatchMap $ a `mappend` b --TODO: Add a semigroup instance for Map
36+ -- PatchMap is idempotent, so stimes n is id for every n
37+ stimes = stimesIdempotentMonoid
38+
39+-- | The empty 'PatchMap' contains no insertions or deletions
40+instance Ord k => Monoid (PatchMap k v) where
41+ mempty = PatchMap mempty
42+ mappend = (<>)
43+
44+-- | 'fmap'ping a 'PatchMap' will alter all of the values it will insert.
45+-- Deletions are unaffected.
46+instance Functor (PatchMap k) where
47+ fmap f = PatchMap . fmap (fmap f) . unPatchMap
48+
49+-- | Returns all the new elements that will be added to the 'Map'
50+patchMapNewElements :: PatchMap k v -> [v]
51+patchMapNewElements (PatchMap p) = catMaybes $ Map.elems p
52+
53+-- | Returns all the new elements that will be added to the 'Map'
54+patchMapNewElementsMap :: PatchMap k v -> Map k v
55+patchMapNewElementsMap (PatchMap p) = Map.mapMaybe id p
src/Reflex/Patch/MapWithMove.hsnew file+270
@@ -0,0 +1,270 @@
1+{-# LANGUAGE DeriveFoldable #-}
2+{-# LANGUAGE DeriveFunctor #-}
3+{-# LANGUAGE DeriveTraversable #-}
4+{-# LANGUAGE FlexibleContexts #-}
5+{-# LANGUAGE LambdaCase #-}
6+{-# LANGUAGE PatternGuards #-}
7+{-# LANGUAGE ScopedTypeVariables #-}
8+{-# LANGUAGE TypeFamilies #-}
9+-- | 'Patch'es on 'Map' that can insert, delete, and move values from one key to
10+-- another
11+module Reflex.Patch.MapWithMove where
12+
13+import Reflex.Patch.Class
14+
15+import Control.Arrow
16+import Control.Monad.State
17+import Data.Foldable
18+import Data.Function
19+import Data.List
20+import Data.Map (Map)
21+import qualified Data.Map as Map
22+import Data.Maybe
23+import Data.Semigroup (Semigroup (..), (<>))
24+import qualified Data.Set as Set
25+import Data.These (These(..))
26+import Data.Tuple
27+
28+-- | Patch a DMap with additions, deletions, and moves. Invariant: If key @k1@
29+-- is coming from @From_Move k2@, then key @k2@ should be going to @Just k1@,
30+-- and vice versa. There should never be any unpaired From/To keys.
31+newtype PatchMapWithMove k v = PatchMapWithMove (Map k (NodeInfo k v)) deriving (Show, Eq, Ord, Functor, Foldable, Traversable)
32+
33+-- | Holds the information about each key: where its new value should come from,
34+-- and where its old value should go to
35+data NodeInfo k v = NodeInfo
36+ { _nodeInfo_from :: !(From k v)
37+ -- ^ Where do we get the new value for this key?
38+ , _nodeInfo_to :: !(To k)
39+ -- ^ If the old value is being kept (i.e. moved rather than deleted or
40+ -- replaced), where is it going?
41+ }
42+ deriving (Show, Read, Eq, Ord, Functor, Foldable, Traversable)
43+
44+-- | Describe how a key's new value should be produced
45+data From k v
46+ = From_Insert v -- ^ Insert the given value here
47+ | From_Delete -- ^ Delete the existing value, if any, from here
48+ | From_Move !k -- ^ Move the value here from the given key
49+ deriving (Show, Read, Eq, Ord, Functor, Foldable, Traversable)
50+
51+-- | Describe where a key's old value will go. If this is 'Just', that means
52+-- the key's old value will be moved to the given other key; if it is 'Nothing',
53+-- that means it will be deleted.
54+type To = Maybe
55+
56+-- | Create a 'PatchMapWithMove', validating it
57+patchMapWithMove :: Ord k => Map k (NodeInfo k v) -> Maybe (PatchMapWithMove k v)
58+patchMapWithMove m = if valid then Just $ PatchMapWithMove m else Nothing
59+ where valid = forwardLinks == backwardLinks
60+ forwardLinks = Map.mapMaybe _nodeInfo_to m
61+ backwardLinks = Map.fromList $ catMaybes $ flip fmap (Map.toList m) $ \(to, v) ->
62+ case _nodeInfo_from v of
63+ From_Move from -> Just (from, to)
64+ _ -> Nothing
65+
66+-- | Create a 'PatchMapWithMove' that inserts everything in the given 'Map'
67+patchMapWithMoveInsertAll :: Map k v -> PatchMapWithMove k v
68+patchMapWithMoveInsertAll m = PatchMapWithMove $ flip fmap m $ \v -> NodeInfo
69+ { _nodeInfo_from = From_Insert v
70+ , _nodeInfo_to = Nothing
71+ }
72+
73+-- | Extract the internal representation of the 'PatchMapWithMove'
74+unPatchMapWithMove :: PatchMapWithMove k v -> Map k (NodeInfo k v)
75+unPatchMapWithMove (PatchMapWithMove p) = p
76+
77+-- | Make a @'PatchMapWithMove' k v@ which has the effect of inserting or updating a value @v@ to the given key @k@, like 'Map.insert'.
78+insertMapKey :: k -> v -> PatchMapWithMove k v
79+insertMapKey k v = PatchMapWithMove . Map.singleton k $ NodeInfo (From_Insert v) Nothing
80+
81+-- |Make a @'PatchMapWithMove' k v@ which has the effect of moving the value from the first key @k@ to the second key @k@, equivalent to:
82+--
83+-- @
84+-- 'Map.delete' src (maybe map ('Map.insert' dst) (Map.lookup src map))
85+-- @
86+moveMapKey :: Ord k => k -> k -> PatchMapWithMove k v
87+moveMapKey src dst
88+ | src == dst = mempty
89+ | otherwise =
90+ PatchMapWithMove $ Map.fromList
91+ [ (dst, NodeInfo (From_Move src) Nothing)
92+ , (src, NodeInfo From_Delete (Just dst))
93+ ]
94+
95+-- |Make a @'PatchMapWithMove' k v@ which has the effect of swapping two keys in the mapping, equivalent to:
96+--
97+-- @
98+-- let aMay = Map.lookup a map
99+-- bMay = Map.lookup b map
100+-- in maybe id (Map.insert a) (bMay `mplus` aMay)
101+-- . maybe id (Map.insert b) (aMay `mplus` bMay)
102+-- . Map.delete a . Map.delete b $ map
103+-- @
104+swapMapKey :: Ord k => k -> k -> PatchMapWithMove k v
105+swapMapKey src dst
106+ | src == dst = mempty
107+ | otherwise =
108+ PatchMapWithMove $ Map.fromList
109+ [ (dst, NodeInfo (From_Move src) (Just src))
110+ , (src, NodeInfo (From_Move dst) (Just dst))
111+ ]
112+
113+-- |Make a @'PatchMapWithMove' k v@ which has the effect of deleting a key in the mapping, equivalent to 'Map.delete'.
114+deleteMapKey :: k -> PatchMapWithMove k v
115+deleteMapKey k = PatchMapWithMove . Map.singleton k $ NodeInfo From_Delete Nothing
116+
117+-- | Wrap a @'Map' k (NodeInfo k v)@ representing patch changes into a @'PatchMapWithMove' k v@, without checking any invariants.
118+--
119+-- __Warning:__ when using this function, you must ensure that the invariants of 'PatchMapWithMove' are preserved; they will not be checked.
120+unsafePatchMapWithMove :: Map k (NodeInfo k v) -> PatchMapWithMove k v
121+unsafePatchMapWithMove = PatchMapWithMove
122+
123+-- | Apply the insertions, deletions, and moves to a given 'Map'
124+instance Ord k => Patch (PatchMapWithMove k v) where
125+ type PatchTarget (PatchMapWithMove k v) = Map k v
126+ apply (PatchMapWithMove p) old = Just $! insertions `Map.union` (old `Map.difference` deletions) --TODO: return Nothing sometimes --Note: the strict application here is critical to ensuring that incremental merges don't hold onto all their prerequisite events forever; can we make this more robust?
127+ where insertions = flip Map.mapMaybeWithKey p $ \_ ni -> case _nodeInfo_from ni of
128+ From_Insert v -> Just v
129+ From_Move k -> Map.lookup k old
130+ From_Delete -> Nothing
131+ deletions = flip Map.mapMaybeWithKey p $ \_ ni -> case _nodeInfo_from ni of
132+ From_Delete -> Just ()
133+ _ -> Nothing
134+
135+-- | Returns all the new elements that will be added to the 'Map'.
136+patchMapWithMoveNewElements :: PatchMapWithMove k v -> [v]
137+patchMapWithMoveNewElements = Map.elems . patchMapWithMoveNewElementsMap
138+
139+-- | Return a @'Map' k v@ with all the inserts/updates from the given @'PatchMapWithMove' k v@.
140+patchMapWithMoveNewElementsMap :: PatchMapWithMove k v -> Map k v
141+patchMapWithMoveNewElementsMap (PatchMapWithMove p) = Map.mapMaybe f p
142+ where f ni = case _nodeInfo_from ni of
143+ From_Insert v -> Just v
144+ From_Move _ -> Nothing
145+ From_Delete -> Nothing
146+
147+-- | Create a 'PatchMapWithMove' that, if applied to the given 'Map', will sort
148+-- its values using the given ordering function. The set keys of the 'Map' is
149+-- not changed.
150+patchThatSortsMapWith :: Ord k => (v -> v -> Ordering) -> Map k v -> PatchMapWithMove k v
151+patchThatSortsMapWith cmp m = PatchMapWithMove $ Map.fromList $ catMaybes $ zipWith g unsorted sorted
152+ where unsorted = Map.toList m
153+ sorted = sortBy (cmp `on` snd) unsorted
154+ f (to, _) (from, _) = if to == from then Nothing else
155+ Just (from, to)
156+ reverseMapping = Map.fromList $ catMaybes $ zipWith f unsorted sorted
157+ g (to, _) (from, _) = if to == from then Nothing else
158+ let Just movingTo = Map.lookup to reverseMapping
159+ in Just (to, NodeInfo (From_Move from) $ Just movingTo)
160+
161+-- | Create a 'PatchMapWithMove' that, if applied to the first 'Map' provided,
162+-- will produce a 'Map' with the same values as the second 'Map' but with the
163+-- values sorted with the given ordering function.
164+patchThatChangesAndSortsMapWith :: forall k v. (Ord k, Ord v) => (v -> v -> Ordering) -> Map k v -> Map k v -> PatchMapWithMove k v
165+patchThatChangesAndSortsMapWith cmp oldByIndex newByIndexUnsorted = patchThatChangesMap oldByIndex newByIndex
166+ where newList = Map.toList newByIndexUnsorted
167+ newByIndex = Map.fromList $ zip (fst <$> newList) $ sortBy cmp $ snd <$> newList
168+
169+-- | Create a 'PatchMapWithMove' that, if applied to the first 'Map' provided,
170+-- will produce the second 'Map'.
171+patchThatChangesMap :: (Ord k, Ord v) => Map k v -> Map k v -> PatchMapWithMove k v
172+patchThatChangesMap oldByIndex newByIndex = patch
173+ where oldByValue = Map.fromListWith Set.union $ swap . first Set.singleton <$> Map.toList oldByIndex
174+ (insertsAndMoves, unusedValuesByValue) = flip runState oldByValue $ do
175+ let f k v = do
176+ remainingValues <- get
177+ let putRemainingKeys remainingKeys = put $ if Set.null remainingKeys
178+ then Map.delete v remainingValues
179+ else Map.insert v remainingKeys remainingValues
180+ case Map.lookup v remainingValues of
181+ Nothing -> return $ NodeInfo (From_Insert v) $ Just undefined -- There's no existing value we can take
182+ Just fromKs ->
183+ if k `Set.member` fromKs
184+ then do
185+ putRemainingKeys $ Set.delete k fromKs
186+ return $ NodeInfo (From_Move k) $ Just undefined -- There's an existing value, and it's here, so no patch necessary
187+ else do
188+ (fromK, remainingKeys) <- return . fromJust $ Set.minView fromKs -- There's an existing value, but it's not here; move it here
189+ putRemainingKeys remainingKeys
190+ return $ NodeInfo (From_Move fromK) $ Just undefined
191+ Map.traverseWithKey f newByIndex
192+ unusedOldKeys = fold unusedValuesByValue
193+ pointlessMove k = \case
194+ From_Move k' | k == k' -> True
195+ _ -> False
196+ keyWasMoved k = if k `Map.member` oldByIndex && not (k `Set.member` unusedOldKeys)
197+ then Just undefined
198+ else Nothing
199+ patch = unsafePatchMapWithMove $ Map.filterWithKey (\k -> not . pointlessMove k . _nodeInfo_from) $ Map.mergeWithKey (\k a _ -> Just $ nodeInfoSetTo (keyWasMoved k) a) (Map.mapWithKey $ \k -> nodeInfoSetTo $ keyWasMoved k) (Map.mapWithKey $ \k _ -> NodeInfo From_Delete $ keyWasMoved k) insertsAndMoves oldByIndex
200+
201+-- | Change the 'From' value of a 'NodeInfo'
202+nodeInfoMapFrom :: (From k v -> From k v) -> NodeInfo k v -> NodeInfo k v
203+nodeInfoMapFrom f ni = ni { _nodeInfo_from = f $ _nodeInfo_from ni }
204+
205+-- | Change the 'From' value of a 'NodeInfo', using a 'Functor' (or
206+-- 'Applicative', 'Monad', etc.) action to get the new value
207+nodeInfoMapMFrom :: Functor f => (From k v -> f (From k v)) -> NodeInfo k v -> f (NodeInfo k v)
208+nodeInfoMapMFrom f ni = fmap (\result -> ni { _nodeInfo_from = result }) $ f $ _nodeInfo_from ni
209+
210+-- | Set the 'To' field of a 'NodeInfo'
211+nodeInfoSetTo :: To k -> NodeInfo k v -> NodeInfo k v
212+nodeInfoSetTo to ni = ni { _nodeInfo_to = to }
213+
214+-- |Helper data structure used for composing patches using the monoid instance.
215+data Fixup k v
216+ = Fixup_Delete
217+ | Fixup_Update (These (From k v) (To k))
218+
219+-- |Compose patches having the same effect as applying the patches in turn: @'applyAlways' (p <> q) == 'applyAlways' p . 'applyAlways' q@
220+instance Ord k => Semigroup (PatchMapWithMove k v) where
221+ PatchMapWithMove ma <> PatchMapWithMove mb = PatchMapWithMove m
222+ where
223+ connections = Map.toList $ Map.intersectionWithKey (\_ a b -> (_nodeInfo_to a, _nodeInfo_from b)) ma mb
224+ h :: (k, (Maybe k, From k v)) -> [(k, Fixup k v)]
225+ h (_, (mToAfter, editBefore)) = case (mToAfter, editBefore) of
226+ (Just toAfter, From_Move fromBefore)
227+ | fromBefore == toAfter
228+ -> [(toAfter, Fixup_Delete)]
229+ | otherwise
230+ -> [ (toAfter, Fixup_Update (This editBefore))
231+ , (fromBefore, Fixup_Update (That mToAfter))
232+ ]
233+ (Nothing, From_Move fromBefore) -> [(fromBefore, Fixup_Update (That mToAfter))] -- The item is destroyed in the second patch, so indicate that it is destroyed in the source map
234+ (Just toAfter, _) -> [(toAfter, Fixup_Update (This editBefore))]
235+ (Nothing, _) -> []
236+ mergeFixups _ Fixup_Delete Fixup_Delete = Fixup_Delete
237+ mergeFixups _ (Fixup_Update a) (Fixup_Update b)
238+ | This x <- a, That y <- b
239+ = Fixup_Update $ These x y
240+ | That y <- a, This x <- b
241+ = Fixup_Update $ These x y
242+ mergeFixups _ _ _ = error "PatchMapWithMove: incompatible fixups"
243+ fixups = Map.fromListWithKey mergeFixups $ concatMap h connections
244+ combineNodeInfos _ nia nib = NodeInfo
245+ { _nodeInfo_from = _nodeInfo_from nia
246+ , _nodeInfo_to = _nodeInfo_to nib
247+ }
248+ applyFixup _ ni = \case
249+ Fixup_Delete -> Nothing
250+ Fixup_Update u -> Just $ NodeInfo
251+ { _nodeInfo_from = fromMaybe (_nodeInfo_from ni) $ getHere u
252+ , _nodeInfo_to = fromMaybe (_nodeInfo_to ni) $ getThere u
253+ }
254+ m = Map.differenceWithKey applyFixup (Map.unionWithKey combineNodeInfos ma mb) fixups
255+ getHere :: These a b -> Maybe a
256+ getHere = \case
257+ This a -> Just a
258+ These a _ -> Just a
259+ That _ -> Nothing
260+ getThere :: These a b -> Maybe b
261+ getThere = \case
262+ This _ -> Nothing
263+ These _ b -> Just b
264+ That b -> Just b
265+
266+--TODO: Figure out how to implement this in terms of PatchDMapWithMove rather than duplicating it here
267+-- |Compose patches having the same effect as applying the patches in turn: @'applyAlways' (p <> q) == 'applyAlways' p . 'applyAlways' q@
268+instance Ord k => Monoid (PatchMapWithMove k v) where
269+ mempty = PatchMapWithMove mempty
270+ mappend = (<>)
src/Reflex/PerformEvent/Base.hs−2
@@ -164,8 +164,6 @@ instance (ReflexHost t, MonadHold t m) => MonadHold t (PerformEventT t m) where
164 buildDynamic getV0 v' = PerformEventT $ lift $ buildDynamic getV0 v'
164 buildDynamic getV0 v' = PerformEventT $ lift $ buildDynamic getV0 v'
165 {-# INLINABLE headE #-}
165 {-# INLINABLE headE #-}
166 headE = PerformEventT . lift . headE
166 headE = PerformEventT . lift . headE
167− {-# INLINABLE now #-}
168− now = PerformEventT . lift $ now
169
167
170instance (MonadRef (HostFrame t), ReflexHost t) => MonadRef (PerformEventT t m) where
168instance (MonadRef (HostFrame t), ReflexHost t) => MonadRef (PerformEventT t m) where
171 type Ref (PerformEventT t m) = Ref (HostFrame t)
169 type Ref (PerformEventT t m) = Ref (HostFrame t)
src/Reflex/PerformEvent/Class.hs+1−6
@@ -8,6 +8,7 @@
8{-# LANGUAGE RankNTypes #-}
8{-# LANGUAGE RankNTypes #-}
9{-# LANGUAGE ScopedTypeVariables #-}
9{-# LANGUAGE ScopedTypeVariables #-}
10{-# LANGUAGE TypeFamilies #-}
10{-# LANGUAGE TypeFamilies #-}
11+{-# LANGUAGE TypeOperators #-}
11{-# LANGUAGE UndecidableInstances #-}
12{-# LANGUAGE UndecidableInstances #-}
12#ifdef USE_REFLEX_OPTIMIZER
13#ifdef USE_REFLEX_OPTIMIZER
13{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
14{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
@@ -21,7 +22,6 @@ import Reflex.Class
21import Reflex.TriggerEvent.Class
22import Reflex.TriggerEvent.Class
22
23
23import Control.Monad.Reader
24import Control.Monad.Reader
24−import Control.Monad.Trans.Maybe (MaybeT (..))
25
25
26-- | 'PerformEvent' represents actions that can trigger other actions based on
26-- | 'PerformEvent' represents actions that can trigger other actions based on
27-- 'Event's.
27-- 'Event's.
@@ -61,8 +61,3 @@ instance PerformEvent t m => PerformEvent t (ReaderT r m) where
61 performEvent e = do
61 performEvent e = do
62 r <- ask
62 r <- ask
63 lift $ performEvent $ flip runReaderT r <$> e
63 lift $ performEvent $ flip runReaderT r <$> e
64−
65−instance PerformEvent t m => PerformEvent t (MaybeT m) where
66− type Performable (MaybeT m) = MaybeT (Performable m)
67− performEvent_ = lift . performEvent_ . fmapCheap (void . runMaybeT)
68− performEvent = lift . fmap (fmapMaybe id) . performEvent . fmapCheap runMaybeT
src/Reflex/PostBuild/Base.hs+1−2
@@ -9,6 +9,7 @@
9{-# LANGUAGE RecursiveDo #-}
9{-# LANGUAGE RecursiveDo #-}
10{-# LANGUAGE ScopedTypeVariables #-}
10{-# LANGUAGE ScopedTypeVariables #-}
11{-# LANGUAGE TypeFamilies #-}
11{-# LANGUAGE TypeFamilies #-}
12+{-# LANGUAGE TypeOperators #-}
12{-# LANGUAGE UndecidableInstances #-}
13{-# LANGUAGE UndecidableInstances #-}
13#ifdef USE_REFLEX_OPTIMIZER
14#ifdef USE_REFLEX_OPTIMIZER
14{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
15{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
@@ -83,8 +84,6 @@ instance MonadHold t m => MonadHold t (PostBuildT t m) where
83 buildDynamic a0 = lift . buildDynamic a0
84 buildDynamic a0 = lift . buildDynamic a0
84 {-# INLINABLE headE #-}
85 {-# INLINABLE headE #-}
85 headE = lift . headE
86 headE = lift . headE
86− {-# INLINABLE now #-}
87− now = lift now
88
87
89instance PerformEvent t m => PerformEvent t (PostBuildT t m) where
88instance PerformEvent t m => PerformEvent t (PostBuildT t m) where
90 type Performable (PostBuildT t m) = Performable m
89 type Performable (PostBuildT t m) = Performable m
src/Reflex/PostBuild/Class.hs+1
@@ -6,6 +6,7 @@
6{-# LANGUAGE FunctionalDependencies #-}
6{-# LANGUAGE FunctionalDependencies #-}
7{-# LANGUAGE ScopedTypeVariables #-}
7{-# LANGUAGE ScopedTypeVariables #-}
8{-# LANGUAGE TypeFamilies #-}
8{-# LANGUAGE TypeFamilies #-}
9+{-# LANGUAGE TypeOperators #-}
9{-# LANGUAGE UndecidableInstances #-}
10{-# LANGUAGE UndecidableInstances #-}
10#ifdef USE_REFLEX_OPTIMIZER
11#ifdef USE_REFLEX_OPTIMIZER
11{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
12{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
src/Reflex/Profiled.hs+5−59
@@ -26,10 +26,8 @@ import Control.Monad.Primitive
26import Control.Monad.Reader
26import Control.Monad.Reader
27import Control.Monad.Ref
27import Control.Monad.Ref
28import Control.Monad.State.Strict (StateT, execStateT, modify)
28import Control.Monad.State.Strict (StateT, execStateT, modify)
29−import Data.Bifunctor
30import Data.Coerce
29import Data.Coerce
31−import Data.Dependent.Map (DMap)
30+import Data.Dependent.Map (DMap, GCompare)
32−import Data.GADT.Compare (GCompare)
33import Data.FastMutableIntMap
31import Data.FastMutableIntMap
34import Data.IORef
32import Data.IORef
35import Data.List
33import Data.List
@@ -44,20 +42,12 @@ import Foreign.Ptr
44import GHC.Foreign
42import GHC.Foreign
45import GHC.IO.Encoding
43import GHC.IO.Encoding
46import GHC.Stack
44import GHC.Stack
47−import Reflex.Adjustable.Class
48−import Reflex.BehaviorWriter.Class
49import Reflex.Class
45import Reflex.Class
50−import Reflex.DynamicWriter.Class
51−import Reflex.EventWriter.Class
52import Reflex.Host.Class
46import Reflex.Host.Class
53−import Reflex.NotReady.Class
54import Reflex.PerformEvent.Class
47import Reflex.PerformEvent.Class
55−import Reflex.PostBuild.Class
56−import Reflex.Query.Class
57−import Reflex.Requester.Class
58−import Reflex.TriggerEvent.Class
59
48
60import System.IO.Unsafe
49import System.IO.Unsafe
50+import Unsafe.Coerce
61
51
62data ProfiledTimeline t
52data ProfiledTimeline t
63
53
@@ -147,7 +137,7 @@ instance Reflex t => Reflex (ProfiledTimeline t) where
147 pushCheap f (Event_Profiled e) = coerce $ pushCheap (coerce f) $ profileEvent e
137 pushCheap f (Event_Profiled e) = coerce $ pushCheap (coerce f) $ profileEvent e
148 pull = Behavior_Profiled . pull . coerce
138 pull = Behavior_Profiled . pull . coerce
149 fanG (Event_Profiled e) = EventSelectorG $ coerce $ selectG (fanG $ profileEvent e)
139 fanG (Event_Profiled e) = EventSelectorG $ coerce $ selectG (fanG $ profileEvent e)
150− mergeG :: forall z (k :: z -> *) q v. GCompare k
140+ mergeG :: forall (k :: z -> *) q v. GCompare k
151 => (forall a. q a -> Event (ProfiledTimeline t) (v a))
141 => (forall a. q a -> Event (ProfiledTimeline t) (v a))
152 -> DMap k q -> Event (ProfiledTimeline t) (DMap k v)
142 -> DMap k q -> Event (ProfiledTimeline t) (DMap k v)
153 mergeG nt = Event_Profiled #. mergeG (coerce nt)
143 mergeG nt = Event_Profiled #. mergeG (coerce nt)
@@ -157,8 +147,8 @@ instance Reflex t => Reflex (ProfiledTimeline t) where
157 updated (Dynamic_Profiled d) = coerce $ profileEvent $ updated d
147 updated (Dynamic_Profiled d) = coerce $ profileEvent $ updated d
158 unsafeBuildDynamic (ProfiledM a0) (Event_Profiled a') = coerce $ unsafeBuildDynamic a0 a'
148 unsafeBuildDynamic (ProfiledM a0) (Event_Profiled a') = coerce $ unsafeBuildDynamic a0 a'
159 unsafeBuildIncremental (ProfiledM a0) (Event_Profiled a') = coerce $ unsafeBuildIncremental a0 a'
149 unsafeBuildIncremental (ProfiledM a0) (Event_Profiled a') = coerce $ unsafeBuildIncremental a0 a'
160− mergeIncrementalG nt res = Event_Profiled $ mergeIncrementalG (coerce nt) (coerce res)
150+ mergeIncrementalG nt = (Event_Profiled . coerce) #. mergeIncrementalG nt
161− mergeIncrementalWithMoveG nt res = Event_Profiled $ mergeIncrementalWithMoveG (coerce nt) (coerce res)
151+ mergeIncrementalWithMoveG nt = (Event_Profiled . coerce) #. mergeIncrementalWithMoveG nt
162 currentIncremental (Incremental_Profiled i) = coerce $ currentIncremental i
152 currentIncremental (Incremental_Profiled i) = coerce $ currentIncremental i
163 updatedIncremental (Incremental_Profiled i) = coerce $ profileEvent $ updatedIncremental i
153 updatedIncremental (Incremental_Profiled i) = coerce $ profileEvent $ updatedIncremental i
164 incrementalToDynamic (Incremental_Profiled i) = coerce $ incrementalToDynamic i
154 incrementalToDynamic (Incremental_Profiled i) = coerce $ incrementalToDynamic i
@@ -184,21 +174,10 @@ instance MonadHold t m => MonadHold (ProfiledTimeline t) (ProfiledM m) where
184 holdIncremental v0 (Event_Profiled v') = ProfiledM $ Incremental_Profiled <$> holdIncremental v0 v'
174 holdIncremental v0 (Event_Profiled v') = ProfiledM $ Incremental_Profiled <$> holdIncremental v0 v'
185 buildDynamic (ProfiledM v0) (Event_Profiled v') = ProfiledM $ Dynamic_Profiled <$> buildDynamic v0 v'
175 buildDynamic (ProfiledM v0) (Event_Profiled v') = ProfiledM $ Dynamic_Profiled <$> buildDynamic v0 v'
186 headE (Event_Profiled e) = ProfiledM $ Event_Profiled <$> headE e
176 headE (Event_Profiled e) = ProfiledM $ Event_Profiled <$> headE e
187− now = ProfiledM $ Event_Profiled <$> now
188
177
189instance MonadSample t m => MonadSample (ProfiledTimeline t) (ProfiledM m) where
178instance MonadSample t m => MonadSample (ProfiledTimeline t) (ProfiledM m) where
190 sample (Behavior_Profiled b) = ProfiledM $ sample b
179 sample (Behavior_Profiled b) = ProfiledM $ sample b
191
180
192−instance Adjustable t m => Adjustable (ProfiledTimeline t) (ProfiledM m) where
193− runWithReplace a0 a' = (fmap . fmap) coerce . lift $
194− runWithReplace (coerce a0) (coerce $ coerce <$> a')
195− traverseIntMapWithKeyWithAdjust f dm0 dm' = (fmap . fmap) coerce . lift $
196− traverseIntMapWithKeyWithAdjust (\k v -> coerce $ f k v) dm0 (coerce dm')
197− traverseDMapWithKeyWithAdjust f dm0 dm' = (fmap . fmap) coerce . lift $
198− traverseDMapWithKeyWithAdjust (\k v -> coerce $ f k v) dm0 (coerce dm')
199− traverseDMapWithKeyWithAdjustWithMove f dm0 dm' = (fmap . fmap) coerce . lift $
200− traverseDMapWithKeyWithAdjustWithMove (\k v -> coerce $ f k v) dm0 (coerce dm')
201−
202instance MonadTrans ProfiledM where
181instance MonadTrans ProfiledM where
203 lift = ProfiledM
182 lift = ProfiledM
204
183
@@ -210,39 +189,6 @@ instance PerformEvent t m => PerformEvent (ProfiledTimeline t) (ProfiledM m) whe
210 performEvent_ = lift . performEvent_ . coerce
189 performEvent_ = lift . performEvent_ . coerce
211 performEvent = lift . fmap coerce . performEvent . coerce
190 performEvent = lift . fmap coerce . performEvent . coerce
212
191
213−instance TriggerEvent t m => TriggerEvent (ProfiledTimeline t) (ProfiledM m) where
214− newTriggerEvent = first coerce <$> lift newTriggerEvent
215− newTriggerEventWithOnComplete = first coerce <$> lift newTriggerEventWithOnComplete
216− newEventWithLazyTriggerWithOnComplete f = coerce <$> lift (newEventWithLazyTriggerWithOnComplete f)
217−
218−instance PostBuild t m => PostBuild (ProfiledTimeline t) (ProfiledM m) where
219− getPostBuild = coerce <$> lift getPostBuild
220−
221−instance NotReady t m => NotReady (ProfiledTimeline t) (ProfiledM m) where
222− notReady = lift notReady
223− notReadyUntil = lift . notReadyUntil . coerce
224−
225−instance BehaviorWriter t w m => BehaviorWriter (ProfiledTimeline t) w (ProfiledM m) where
226− tellBehavior = lift . tellBehavior . coerce
227−
228−instance DynamicWriter t w m => DynamicWriter (ProfiledTimeline t) w (ProfiledM m) where
229− tellDyn = lift . tellDyn . coerce
230−
231−instance EventWriter t w m => EventWriter (ProfiledTimeline t) w (ProfiledM m) where
232− tellEvent = lift . tellEvent . coerce
233−
234−instance MonadQuery t q m => MonadQuery (ProfiledTimeline t) q (ProfiledM m) where
235− tellQueryIncremental = lift . tellQueryIncremental . coerce
236− askQueryResult = coerce <$> lift askQueryResult
237− queryIncremental = fmap coerce . lift . queryIncremental . coerce
238−
239−instance Requester t m => Requester (ProfiledTimeline t) (ProfiledM m) where
240− type Request (ProfiledM m) = Request m
241− type Response (ProfiledM m) = Response m
242−
243− requesting = fmap coerce . lift . requesting . coerce
244− requesting_ = lift . requesting_ . coerce
245−
246instance MonadRef m => MonadRef (ProfiledM m) where
192instance MonadRef m => MonadRef (ProfiledM m) where
247 type Ref (ProfiledM m) = Ref m
193 type Ref (ProfiledM m) = Ref m
248 newRef = lift . newRef
194 newRef = lift . newRef
src/Reflex/Pure.hs+1−6
@@ -32,8 +32,7 @@ module Reflex.Pure
32 ) where
32 ) where
33
33
34import Control.Monad
34import Control.Monad
35−import Data.Dependent.Map (DMap)
35+import Data.Dependent.Map (DMap, GCompare)
36−import Data.GADT.Compare (GCompare)
37import qualified Data.Dependent.Map as DMap
36import qualified Data.Dependent.Map as DMap
38import Data.IntMap (IntMap)
37import Data.IntMap (IntMap)
39import qualified Data.IntMap as IntMap
38import qualified Data.IntMap as IntMap
@@ -211,7 +210,3 @@ instance (Enum t, HasTrie t, Ord t) => MonadHold (Pure t) ((->) t) where
211 Just x -> fromMaybe lastValue $ apply x lastValue
210 Just x -> fromMaybe lastValue $ apply x lastValue
212
211
213 headE = slowHeadE
212 headE = slowHeadE
214− now t = Event $ guard . (t ==)
215−
216−
217−
src/Reflex/Query/Base.hs+4−15
@@ -16,25 +16,21 @@ module Reflex.Query.Base
16 , mapQueryResult
16 , mapQueryResult
17 , dynWithQueryT
17 , dynWithQueryT
18 , withQueryT
18 , withQueryT
19− , mapQueryT
20 ) where
19 ) where
21
20
22import Control.Applicative (liftA2)
21import Control.Applicative (liftA2)
23import Control.Monad.Exception
22import Control.Monad.Exception
24import Control.Monad.Fix
23import Control.Monad.Fix
25−import Control.Monad.Morph
26import Control.Monad.Primitive
24import Control.Monad.Primitive
27import Control.Monad.Reader
25import Control.Monad.Reader
28import Control.Monad.Ref
26import Control.Monad.Ref
29import Control.Monad.State.Strict
27import Control.Monad.State.Strict
30import Data.Align
28import Data.Align
31−import Data.Dependent.Map (DMap)
29+import Data.Dependent.Map (DMap, DSum (..))
32import qualified Data.Dependent.Map as DMap
30import qualified Data.Dependent.Map as DMap
33−import Data.Dependent.Sum (DSum(..))
34import Data.Foldable
31import Data.Foldable
35import Data.Functor.Compose
32import Data.Functor.Compose
36import Data.Functor.Misc
33import Data.Functor.Misc
37−import Data.GADT.Compare (GCompare)
38import Data.IntMap (IntMap)
34import Data.IntMap (IntMap)
39import qualified Data.IntMap as IntMap
35import qualified Data.IntMap as IntMap
40import Data.Map (Map)
36import Data.Map (Map)
@@ -50,7 +46,7 @@ import Reflex.DynamicWriter.Class
50import Reflex.EventWriter.Base
46import Reflex.EventWriter.Base
51import Reflex.EventWriter.Class
47import Reflex.EventWriter.Class
52import Reflex.Host.Class
48import Reflex.Host.Class
53−import qualified Data.Patch.MapWithMove as MapWithMove
49+import qualified Reflex.Patch.MapWithMove as MapWithMove
54import Reflex.PerformEvent.Class
50import Reflex.PerformEvent.Class
55import Reflex.PostBuild.Class
51import Reflex.PostBuild.Class
56import Reflex.Query.Class
52import Reflex.Query.Class
@@ -138,7 +134,7 @@ instance (Reflex t, MonadFix m, Group q, Additive q, Query q, Eq q, MonadHold t
138 tellQueryIncremental $ unsafeBuildIncremental (fold <$> mapM sampleBs liftedBs0) qpatch
134 tellQueryIncremental $ unsafeBuildIncremental (fold <$> mapM sampleBs liftedBs0) qpatch
139 return (liftedResult0, liftedResult')
135 return (liftedResult0, liftedResult')
140
136
141− traverseDMapWithKeyWithAdjust :: forall (k :: * -> *) v v'. (GCompare k) => (forall a. k a -> v a -> QueryT t q m (v' a)) -> DMap k v -> Event t (PatchDMap k v) -> QueryT t q m (DMap k v', Event t (PatchDMap k v'))
137+ traverseDMapWithKeyWithAdjust :: forall (k :: * -> *) v v'. (DMap.GCompare k) => (forall a. k a -> v a -> QueryT t q m (v' a)) -> DMap k v -> Event t (PatchDMap k v) -> QueryT t q m (DMap k v', Event t (PatchDMap k v'))
142 traverseDMapWithKeyWithAdjust f dm0 dm' = do
138 traverseDMapWithKeyWithAdjust f dm0 dm' = do
143 let f' :: forall a. k a -> v a -> EventWriterT t q (ReaderT (Dynamic t (QueryResult q)) m) (Compose (QueryTLoweredResult t q) v' a)
139 let f' :: forall a. k a -> v a -> EventWriterT t q (ReaderT (Dynamic t (QueryResult q)) m) (Compose (QueryTLoweredResult t q) v' a)
144 f' k v = fmap (Compose . QueryTLoweredResult) $ flip runStateT [] $ unQueryT $ f k v
140 f' k v = fmap (Compose . QueryTLoweredResult) $ flip runStateT [] $ unQueryT $ f k v
@@ -183,7 +179,7 @@ instance (Reflex t, MonadFix m, Group q, Additive q, Query q, Eq q, MonadHold t
183 tellQueryIncremental $ unsafeBuildIncremental (fold <$> mapM sampleBs liftedBs0) qpatch
179 tellQueryIncremental $ unsafeBuildIncremental (fold <$> mapM sampleBs liftedBs0) qpatch
184 return (liftedResult0, liftedResult')
180 return (liftedResult0, liftedResult')
185
181
186− traverseDMapWithKeyWithAdjustWithMove :: forall (k :: * -> *) v v'. (GCompare k) => (forall a. k a -> v a -> QueryT t q m (v' a)) -> DMap k v -> Event t (PatchDMapWithMove k v) -> QueryT t q m (DMap k v', Event t (PatchDMapWithMove k v'))
182+ traverseDMapWithKeyWithAdjustWithMove :: forall (k :: * -> *) v v'. (DMap.GCompare k) => (forall a. k a -> v a -> QueryT t q m (v' a)) -> DMap k v -> Event t (PatchDMapWithMove k v) -> QueryT t q m (DMap k v', Event t (PatchDMapWithMove k v'))
187 traverseDMapWithKeyWithAdjustWithMove f dm0 dm' = do
183 traverseDMapWithKeyWithAdjustWithMove f dm0 dm' = do
188 let f' :: forall a. k a -> v a -> EventWriterT t q (ReaderT (Dynamic t (QueryResult q)) m) (Compose (QueryTLoweredResult t q) v' a)
184 let f' :: forall a. k a -> v a -> EventWriterT t q (ReaderT (Dynamic t (QueryResult q)) m) (Compose (QueryTLoweredResult t q) v' a)
189 f' k v = fmap (Compose . QueryTLoweredResult) $ flip runStateT [] $ unQueryT $ f k v
185 f' k v = fmap (Compose . QueryTLoweredResult) $ flip runStateT [] $ unQueryT $ f k v
@@ -240,9 +236,6 @@ instance (Reflex t, MonadFix m, Group q, Additive q, Query q, Eq q, MonadHold t
240instance MonadTrans (QueryT t q) where
236instance MonadTrans (QueryT t q) where
241 lift = QueryT . lift . lift . lift
237 lift = QueryT . lift . lift . lift
242
238
243−instance MFunctor (QueryT t q) where
244− hoist = mapQueryT
245−
246instance PrimMonad m => PrimMonad (QueryT t q m) where
239instance PrimMonad m => PrimMonad (QueryT t q m) where
247 type PrimState (QueryT t q m) = PrimState m
240 type PrimState (QueryT t q m) = PrimState m
248 primitive = lift . primitive
241 primitive = lift . primitive
@@ -294,10 +287,6 @@ withQueryT f a = do
294 (fmapCheap (AdditivePatch . mapQuery f . unAdditivePatch) $ updatedIncremental q)
287 (fmapCheap (AdditivePatch . mapQuery f . unAdditivePatch) $ updatedIncremental q)
295 return result
288 return result
296
289
297−-- | Maps a function over a 'QueryT' that can change the underlying monad
298−mapQueryT :: (forall b. m b -> n b) -> QueryT t q m a -> QueryT t q n a
299−mapQueryT f (QueryT a) = QueryT $ mapStateT (mapEventWriterT (mapReaderT f)) a
300−
301-- | dynWithQueryT's (Dynamic t QueryMorphism) argument needs to be a group homomorphism at all times in order to behave correctly
290-- | dynWithQueryT's (Dynamic t QueryMorphism) argument needs to be a group homomorphism at all times in order to behave correctly
302dynWithQueryT :: (MonadFix m, PostBuild t m, Group q, Additive q, Group q', Additive q', Query q')
291dynWithQueryT :: (MonadFix m, PostBuild t m, Group q, Additive q, Group q', Additive q', Query q')
303 => Dynamic t (QueryMorphism q q')
292 => Dynamic t (QueryMorphism q q')
src/Reflex/Query/Class.hs+4−44
@@ -1,4 +1,3 @@
1−{-# LANGUAGE CPP #-}
2{-# LANGUAGE DeriveDataTypeable #-}
1{-# LANGUAGE DeriveDataTypeable #-}
3{-# LANGUAGE FlexibleContexts #-}
2{-# LANGUAGE FlexibleContexts #-}
4{-# LANGUAGE FlexibleInstances #-}
3{-# LANGUAGE FlexibleInstances #-}
@@ -22,7 +21,6 @@ module Reflex.Query.Class
22 , MonadQuery (..)
21 , MonadQuery (..)
23 , tellQueryDyn
22 , tellQueryDyn
24 , queryDyn
23 , queryDyn
25− , subQuery
26 , mapQuery
24 , mapQuery
27 , mapQueryResult
25 , mapQueryResult
28 ) where
26 ) where
@@ -37,9 +35,6 @@ import Data.Map.Monoidal (MonoidalMap)
37import qualified Data.Map.Monoidal as MonoidalMap
35import qualified Data.Map.Monoidal as MonoidalMap
38import Data.Semigroup (Semigroup(..))
36import Data.Semigroup (Semigroup(..))
39import Foreign.Storable
37import Foreign.Storable
40−import Data.Void
41−import Data.Monoid hiding ((<>))
42−import Control.Applicative
43
38
44import Reflex.Class
39import Reflex.Class
45
40
@@ -55,37 +50,6 @@ instance (Ord k, Query v) => Query (MonoidalMap k v) where
55 type QueryResult (MonoidalMap k v) = MonoidalMap k (QueryResult v)
50 type QueryResult (MonoidalMap k v) = MonoidalMap k (QueryResult v)
56 crop q r = MonoidalMap.intersectionWith (flip crop) r q
51 crop q r = MonoidalMap.intersectionWith (flip crop) r q
57
52
58−-- | the result of two queries is both results.
59−instance (Query a, Query b) => Query (a, b) where
60− type QueryResult (a, b) = (QueryResult a, QueryResult b)
61− crop (x, x') (y, y') = (crop x y, crop x' y')
62−
63−-- | Trivial queries have trivial results.
64−instance Query () where
65− type QueryResult () = ()
66− crop _ _ = ()
67−
68−-- | The result of an absurd query is trivial; If you can ask the question, the
69−-- answer cannot tell you anything you didn't already know.
70−--
71−-- 'QueryResult Void = @Void@' seems like it would also work, but that has
72−-- problems of robustness. In some applications, an unasked question can still
73−-- be answered, so it is important that the result is inhabited even when the
74−-- question isn't. Applications that wish to prevent this can mandate that the
75−-- query result be paired with the query: then the whole response will be
76−-- uninhabited as desired.
77−instance Query Void where
78− type QueryResult Void = ()
79− crop = absurd
80−
81−#if MIN_VERSION_base(4,12,0)
82−-- | We can lift queries into monoidal containers.
83−-- But beware of Applicatives whose monoid is different from (pure mempty, liftA2 mappend)
84−instance (Query q, Applicative f) => Query (Ap f q) where
85− type QueryResult (Ap f q) = Ap f (QueryResult q)
86− crop = liftA2 crop
87−#endif
88−
89-- | QueryMorphism's must be group homomorphisms when acting on the query type
53-- | QueryMorphism's must be group homomorphisms when acting on the query type
90-- and compatible with the query relationship when acting on the query result.
54-- and compatible with the query relationship when acting on the query result.
91data QueryMorphism q q' = QueryMorphism
55data QueryMorphism q q' = QueryMorphism
@@ -125,7 +89,7 @@ instance Group SelectedCount where
125
89
126instance Additive SelectedCount
90instance Additive SelectedCount
127
91
128−-- | The Semigroup\/Monoid\/Group instances for a Query containing 'SelectedCount's should use
92+-- | The Semigroup/Monoid/Group instances for a Query containing 'SelectedCount's should use
129-- this function which returns Nothing if the result is 0. This allows the pruning of leaves
93-- this function which returns Nothing if the result is 0. This allows the pruning of leaves
130-- of the 'Query' that are no longer wanted.
94-- of the 'Query' that are no longer wanted.
131combineSelectedCounts :: SelectedCount -> SelectedCount -> Maybe SelectedCount
95combineSelectedCounts :: SelectedCount -> SelectedCount -> Maybe SelectedCount
@@ -133,12 +97,12 @@ combineSelectedCounts (SelectedCount i) (SelectedCount j) = if i == negate j the
133
97
134-- | A class that allows sending of 'Query's and retrieval of 'QueryResult's. See 'queryDyn' for a commonly
98-- | A class that allows sending of 'Query's and retrieval of 'QueryResult's. See 'queryDyn' for a commonly
135-- used interface.
99-- used interface.
136−class (Group q, Additive q, Query q, Monad m) => MonadQuery t q m | m -> q t where
100+class (Group q, Additive q, Query q) => MonadQuery t q m | m -> q t where
137 tellQueryIncremental :: Incremental t (AdditivePatch q) -> m ()
101 tellQueryIncremental :: Incremental t (AdditivePatch q) -> m ()
138 askQueryResult :: m (Dynamic t (QueryResult q))
102 askQueryResult :: m (Dynamic t (QueryResult q))
139 queryIncremental :: Incremental t (AdditivePatch q) -> m (Dynamic t (QueryResult q))
103 queryIncremental :: Incremental t (AdditivePatch q) -> m (Dynamic t (QueryResult q))
140
104
141−instance MonadQuery t q m => MonadQuery t q (ReaderT r m) where
105+instance (Monad m, MonadQuery t q m) => MonadQuery t q (ReaderT r m) where
142 tellQueryIncremental = lift . tellQueryIncremental
106 tellQueryIncremental = lift . tellQueryIncremental
143 askQueryResult = lift askQueryResult
107 askQueryResult = lift askQueryResult
144 queryIncremental = lift . queryIncremental
108 queryIncremental = lift . queryIncremental
@@ -148,11 +112,7 @@ tellQueryDyn :: (Reflex t, MonadQuery t q m) => Dynamic t q -> m ()
148tellQueryDyn d = tellQueryIncremental $ unsafeBuildIncremental (sample (current d)) $ attachWith (\old new -> AdditivePatch $ new ~~ old) (current d) (updated d)
112tellQueryDyn d = tellQueryIncremental $ unsafeBuildIncremental (sample (current d)) $ attachWith (\old new -> AdditivePatch $ new ~~ old) (current d) (updated d)
149
113
150-- | Retrieve 'Dynamic'ally updating 'QueryResult's for a 'Dynamic'ally updating 'Query'.
114-- | Retrieve 'Dynamic'ally updating 'QueryResult's for a 'Dynamic'ally updating 'Query'.
151−queryDyn :: (Reflex t, MonadQuery t q m) => Dynamic t q -> m (Dynamic t (QueryResult q))
115+queryDyn :: (Reflex t, Monad m, MonadQuery t q m) => Dynamic t q -> m (Dynamic t (QueryResult q))
152queryDyn q = do
116queryDyn q = do
153 tellQueryDyn q
117 tellQueryDyn q
154 zipDynWith crop q <$> askQueryResult
118 zipDynWith crop q <$> askQueryResult
155−
156−-- | Use a query morphism to operate on a smaller version of a query.
157−subQuery :: (Reflex t, MonadQuery t q2 m) => QueryMorphism q1 q2 -> Dynamic t q1 -> m (Dynamic t (QueryResult q1))
158−subQuery (QueryMorphism f g) x = fmap g <$> queryDyn (fmap f x)
src/Reflex/Requester/Base.hs+27−97
@@ -1,7 +1,6 @@
1-- | This module provides 'RequesterT', the standard implementation of
1-- | This module provides 'RequesterT', the standard implementation of
2-- 'Requester'.
2-- 'Requester'.
3{-# LANGUAGE AllowAmbiguousTypes #-}
3{-# LANGUAGE AllowAmbiguousTypes #-}
4−{-# LANGUAGE ApplicativeDo #-}
5{-# LANGUAGE CPP #-}
4{-# LANGUAGE CPP #-}
6{-# LANGUAGE EmptyDataDecls #-}
5{-# LANGUAGE EmptyDataDecls #-}
7{-# LANGUAGE ExistentialQuantification #-}
6{-# LANGUAGE ExistentialQuantification #-}
@@ -33,7 +32,6 @@ module Reflex.Requester.Base
33 , requesterDataToList
32 , requesterDataToList
34 , singletonRequesterData
33 , singletonRequesterData
35 , matchResponsesWithRequests
34 , matchResponsesWithRequests
36− , matchResponseMapWithRequests
37 , multiEntry
35 , multiEntry
38 , unMultiEntry
36 , unMultiEntry
39 , requesting'
37 , requesting'
@@ -51,17 +49,14 @@ import Reflex.TriggerEvent.Class
51import Control.Applicative (liftA2)
49import Control.Applicative (liftA2)
52import Control.Monad.Exception
50import Control.Monad.Exception
53import Control.Monad.Identity
51import Control.Monad.Identity
54−import Control.Monad.Morph
55import Control.Monad.Primitive
52import Control.Monad.Primitive
56import Control.Monad.Reader
53import Control.Monad.Reader
57import Control.Monad.Ref
54import Control.Monad.Ref
58import Control.Monad.State.Strict
55import Control.Monad.State.Strict
59import Data.Bits
56import Data.Bits
60import Data.Coerce
57import Data.Coerce
61−import Data.Constraint
62−import Data.Dependent.Map (DMap)
58+import Data.Dependent.Map (DMap, DSum (..))
63import qualified Data.Dependent.Map as DMap
59import qualified Data.Dependent.Map as DMap
64−import Data.Dependent.Sum (DSum (..))
65import Data.Functor.Compose
60import Data.Functor.Compose
66import Data.Functor.Misc
61import Data.Functor.Misc
67import Data.IntMap.Strict (IntMap)
62import Data.IntMap.Strict (IntMap)
@@ -84,51 +79,19 @@ newtype TagMap (f :: * -> *) = TagMap (IntMap Any)
84
79
85newtype RequesterData f = RequesterData (TagMap (Entry f))
80newtype RequesterData f = RequesterData (TagMap (Entry f))
86
81
87−emptyRequesterData :: RequesterData f
88−emptyRequesterData = RequesterData $ TagMap IntMap.empty
89−
90data RequesterDataKey a where
82data RequesterDataKey a where
91 RequesterDataKey_Single :: {-# UNPACK #-} !(MyTag (Single a)) -> RequesterDataKey a
83 RequesterDataKey_Single :: {-# UNPACK #-} !(MyTag (Single a)) -> RequesterDataKey a
92 RequesterDataKey_Multi :: {-# UNPACK #-} !(MyTag Multi) -> {-# UNPACK #-} !Int -> !(RequesterDataKey a) -> RequesterDataKey a --TODO: Don't put a second Int here (or in the other Multis); use a single Int instead
84 RequesterDataKey_Multi :: {-# UNPACK #-} !(MyTag Multi) -> {-# UNPACK #-} !Int -> !(RequesterDataKey a) -> RequesterDataKey a --TODO: Don't put a second Int here (or in the other Multis); use a single Int instead
93− RequesterDataKey_Multi2 :: GCompare k => {-# UNPACK #-} !(MyTag (Multi2 k)) -> !(Some k) -> {-# UNPACK #-} !Int -> !(RequesterDataKey a) -> RequesterDataKey a
85+ RequesterDataKey_Multi2 :: {-# UNPACK #-} !(MyTag (Multi2 k)) -> !(Some k) -> {-# UNPACK #-} !Int -> !(RequesterDataKey a) -> RequesterDataKey a
94 RequesterDataKey_Multi3 :: {-# UNPACK #-} !(MyTag Multi3) -> {-# UNPACK #-} !Int -> {-# UNPACK #-} !Int -> !(RequesterDataKey a) -> RequesterDataKey a
86 RequesterDataKey_Multi3 :: {-# UNPACK #-} !(MyTag Multi3) -> {-# UNPACK #-} !Int -> {-# UNPACK #-} !Int -> !(RequesterDataKey a) -> RequesterDataKey a
95
87
96singletonRequesterData :: RequesterDataKey a -> f a -> RequesterData f
88singletonRequesterData :: RequesterDataKey a -> f a -> RequesterData f
97singletonRequesterData rdk v = case rdk of
89singletonRequesterData rdk v = case rdk of
98 RequesterDataKey_Single k -> RequesterData $ singletonTagMap k $ Entry v
90 RequesterDataKey_Single k -> RequesterData $ singletonTagMap k $ Entry v
99 RequesterDataKey_Multi k k' k'' -> RequesterData $ singletonTagMap k $ Entry $ IntMap.singleton k' $ singletonRequesterData k'' v
91 RequesterDataKey_Multi k k' k'' -> RequesterData $ singletonTagMap k $ Entry $ IntMap.singleton k' $ singletonRequesterData k'' v
100− RequesterDataKey_Multi2 k k' k'' k''' -> RequesterData $ singletonTagMap k $ Entry $ Multi2Contents
92+ RequesterDataKey_Multi2 k k' k'' k''' -> RequesterData $ singletonTagMap k $ Entry $ Map.singleton k' $ IntMap.singleton k'' $ singletonRequesterData k''' v
101− { _multi2Contents_values = Map.singleton k' $ IntMap.singleton k'' $ singletonRequesterData k''' v
102− , _multi2Contents_dict = Dict
103− }
104 RequesterDataKey_Multi3 k k' k'' k''' -> RequesterData $ singletonTagMap k $ Entry $ IntMap.singleton k' $ IntMap.singleton k'' $ singletonRequesterData k''' v
93 RequesterDataKey_Multi3 k k' k'' k''' -> RequesterData $ singletonTagMap k $ Entry $ IntMap.singleton k' $ IntMap.singleton k'' $ singletonRequesterData k''' v
105
94
106−mergeRequesterData :: RequesterData f -> RequesterData f -> RequesterData f
107−mergeRequesterData (RequesterData a) (RequesterData b) = RequesterData $ mergeTagMap a b
108−
109−mergeTagMap :: forall f. TagMap (Entry f) -> TagMap (Entry f) -> TagMap (Entry f)
110−mergeTagMap (TagMap m) (TagMap n) =
111− TagMap $ IntMap.unionWithKey (g' combiner) m n
112− where
113− combiner :: forall a. MyTag a -> Entry f a -> Entry f a -> Entry f a
114− combiner k (Entry a) (Entry b) = Entry $ case myKeyType k of
115− MyTagType_Single -> a
116− MyTagType_Multi -> IntMap.unionWith mergeRequesterData a b
117− MyTagType_Multi2 -> case _multi2Contents_dict a of
118− Dict -> Multi2Contents
119− { _multi2Contents_values = Map.unionWith (IntMap.unionWith mergeRequesterData) (_multi2Contents_values a) (_multi2Contents_values b)
120− , _multi2Contents_dict = Dict
121− }
122− MyTagType_Multi3 -> IntMap.unionWith (IntMap.unionWith mergeRequesterData) a b
123− g' :: (forall a. MyTag a -> Entry f a -> Entry f a -> Entry f a) -> Int -> Any -> Any -> Any
124− g' f rawKey a b =
125− let k = MyTag rawKey :: MyTag a
126− fromAny :: Any -> Entry f a
127− fromAny = unsafeCoerce
128− toAny :: Entry f a -> Any
129− toAny = unsafeCoerce
130− in toAny $ f k (fromAny a) (fromAny b)
131−
132requesterDataToList :: RequesterData f -> [DSum RequesterDataKey f]
95requesterDataToList :: RequesterData f -> [DSum RequesterDataKey f]
133requesterDataToList (RequesterData m) = do
96requesterDataToList (RequesterData m) = do
134 k :=> Entry e <- tagMapToList m
97 k :=> Entry e <- tagMapToList m
@@ -138,12 +101,11 @@ requesterDataToList (RequesterData m) = do
138 (k', e') <- IntMap.toList e
101 (k', e') <- IntMap.toList e
139 k'' :=> e'' <- requesterDataToList e'
102 k'' :=> e'' <- requesterDataToList e'
140 return $ RequesterDataKey_Multi k k' k'' :=> e''
103 return $ RequesterDataKey_Multi k k' k'' :=> e''
141− MyTagType_Multi2 -> case _multi2Contents_dict e of
104+ MyTagType_Multi2 -> do
142− Dict -> do
143− (k', e') <- Map.toList $ _multi2Contents_values e
105+ (k', e') <- Map.toList e
144− (k'', e'') <- IntMap.toList e'
106+ (k'', e'') <- IntMap.toList e'
145− k''' :=> e''' <- requesterDataToList e''
107+ k''' :=> e''' <- requesterDataToList e''
146− return $ RequesterDataKey_Multi2 k k' k'' k''' :=> e'''
108+ return $ RequesterDataKey_Multi2 k k' k'' k''' :=> e'''
147 MyTagType_Multi3 -> do
109 MyTagType_Multi3 -> do
148 (k', e') <- IntMap.toList e
110 (k', e') <- IntMap.toList e
149 (k'', e'') <- IntMap.toList e'
111 (k'', e'') <- IntMap.toList e'
@@ -171,13 +133,7 @@ traverseRequesterData f (RequesterData m) = RequesterData <$> traverseTagMapWith
171 go k (Entry request) = Entry <$> case myKeyType k of
133 go k (Entry request) = Entry <$> case myKeyType k of
172 MyTagType_Single -> f request
134 MyTagType_Single -> f request
173 MyTagType_Multi -> traverse (traverseRequesterData f) request
135 MyTagType_Multi -> traverse (traverseRequesterData f) request
174− MyTagType_Multi2 -> case request of
175− Multi2Contents { _multi2Contents_values = request', _multi2Contents_dict = Dict } -> do
176− v <- traverse (traverse (traverseRequesterData f)) request'
136+ MyTagType_Multi2 -> traverse (traverse (traverseRequesterData f)) request
177− pure $ Multi2Contents
178− { _multi2Contents_values = v
179− , _multi2Contents_dict = Dict
180− }
181 MyTagType_Multi3 -> traverse (traverse (traverseRequesterData f)) request
137 MyTagType_Multi3 -> traverse (traverse (traverseRequesterData f)) request
182
138
183-- | 'traverseRequesterData' with its arguments flipped
139-- | 'traverseRequesterData' with its arguments flipped
@@ -221,14 +177,9 @@ instance MyTagTypeOffset Multi3 where
221type family EntryContents request a where
177type family EntryContents request a where
222 EntryContents request (Single a) = request a
178 EntryContents request (Single a) = request a
223 EntryContents request Multi = IntMap (RequesterData request)
179 EntryContents request Multi = IntMap (RequesterData request)
224− EntryContents request (Multi2 k) = Multi2Contents k request
180+ EntryContents request (Multi2 k) = Map (Some k) (IntMap (RequesterData request))
225 EntryContents request Multi3 = IntMap (IntMap (RequesterData request))
181 EntryContents request Multi3 = IntMap (IntMap (RequesterData request))
226
182
227−data Multi2Contents k request = Multi2Contents
228− { _multi2Contents_dict :: {-# UNPACK #-} !(Dict (GCompare k)) -- This is a Dict instead of an existential context because we only want to use it in certain circumstances
229− , _multi2Contents_values :: {-# UNPACK #-} !(Map (Some k) (IntMap (RequesterData request)))
230− }
231−
232newtype Entry request x = Entry { unEntry :: EntryContents request x }
183newtype Entry request x = Entry { unEntry :: EntryContents request x }
233
184
234{-# INLINE singleEntry #-}
185{-# INLINE singleEntry #-}
@@ -357,7 +308,7 @@ tagRequest req = do
357 return t
308 return t
358
309
359{-# INLINE responseFromTag #-}
310{-# INLINE responseFromTag #-}
360−responseFromTag :: forall m t request response x. Monad m => MyTagWrap response (Entry response x) -> RequesterT t request response m (Event t (Entry response x))
311+responseFromTag :: Monad m => MyTagWrap response (Entry response x) -> RequesterT t request response m (Event t (Entry response x))
361responseFromTag (MyTagWrap t) = do
312responseFromTag (MyTagWrap t) = do
362 responses :: EventSelectorInt t Any <- RequesterT ask
313 responses :: EventSelectorInt t Any <- RequesterT ask
363 return $ (unsafeCoerce :: Event t Any -> Event t (Entry response x)) $ selectInt responses t
314 return $ (unsafeCoerce :: Event t Any -> Event t (Entry response x)) $ selectInt responses t
@@ -365,9 +316,6 @@ responseFromTag (MyTagWrap t) = do
365instance MonadTrans (RequesterT t request response) where
316instance MonadTrans (RequesterT t request response) where
366 lift = RequesterT . lift . lift
317 lift = RequesterT . lift . lift
367
318
368−instance MFunctor (RequesterT t request response) where
369− hoist f = RequesterT . hoist (hoist f) . unRequesterT
370−
371instance PerformEvent t m => PerformEvent t (RequesterT t request response m) where
319instance PerformEvent t m => PerformEvent t (RequesterT t request response m) where
372 type Performable (RequesterT t request response m) = Performable m
320 type Performable (RequesterT t request response m) = Performable m
373 performEvent_ = lift . performEvent_
321 performEvent_ = lift . performEvent_
@@ -487,9 +435,9 @@ traverseDMapWithKeyWithAdjustRequesterTWith base mapPatch weakenPatchWith patchN
487 let responses :: EventSelector t (Const2 (Some k) (IntMap (RequesterData response)))
435 let responses :: EventSelector t (Const2 (Some k) (IntMap (RequesterData response)))
488 responses = fanMap $ fmapCheap unpack response
436 responses = fanMap $ fmapCheap unpack response
489 unpack :: Entry response (Multi2 k) -> Map (Some k) (IntMap (RequesterData response))
437 unpack :: Entry response (Multi2 k) -> Map (Some k) (IntMap (RequesterData response))
490− unpack = _multi2Contents_values . unEntry
438+ unpack = unEntry
491 pack :: Map (Some k) (IntMap (RequesterData request)) -> Entry request (Multi2 k)
439 pack :: Map (Some k) (IntMap (RequesterData request)) -> Entry request (Multi2 k)
492− pack m = Entry $ Multi2Contents { _multi2Contents_values = m, _multi2Contents_dict = Dict }
440+ pack = Entry
493 f' :: forall a. k a -> Compose ((,) Int) v a -> m (Compose ((,) (Event t (IntMap (RequesterData request)))) v' a)
441 f' :: forall a. k a -> Compose ((,) Int) v a -> m (Compose ((,) (Event t (IntMap (RequesterData request)))) v' a)
494 f' k (Compose (n, v)) = do
442 f' k (Compose (n, v)) = do
495 (result, myRequests) <- runRequesterT (f k v) $ mapMaybeCheap (IntMap.lookup n) $ select responses (Const2 (Some k))
443 (result, myRequests) <- runRequesterT (f k v) $ mapMaybeCheap (IntMap.lookup n) $ select responses (Const2 (Some k))
@@ -510,30 +458,10 @@ traverseDMapWithKeyWithAdjustRequesterTWith base mapPatch weakenPatchWith patchN
510data Decoder rawResponse response =
458data Decoder rawResponse response =
511 forall a. Decoder (RequesterDataKey a) (rawResponse -> response a)
459 forall a. Decoder (RequesterDataKey a) (rawResponse -> response a)
512
460
513−matchResponsesWithRequests
514− :: forall t rawRequest rawResponse request response m.
515− ( MonadFix m
516− , MonadHold t m
517− , Reflex t
518− )
519− => (forall a. request a -> (rawRequest, rawResponse -> response a))
520− -- ^ Given a request (from 'Requester'), produces the wire format of the
521− -- request and a function used to process the associated response
522− -> Event t (RequesterData request)
523− -- ^ The outgoing requests
524− -> Event t (Int, rawResponse)
525− -- ^ The incoming responses, tagged by an identifying key
526− -> m ( Event t (Map Int rawRequest)
527− , Event t (RequesterData response)
528− )
529− -- ^ A map of outgoing wire-format requests and an event of responses keyed
530− -- by the 'RequesterData' key of the associated outgoing request
531−matchResponsesWithRequests f send recv = matchResponseMapWithRequests f send $ uncurry Map.singleton <$> recv
532−
533-- | Matches incoming responses with previously-sent requests
461-- | Matches incoming responses with previously-sent requests
534-- and uses the provided request "decoder" function to process
462-- and uses the provided request "decoder" function to process
535-- incoming responses.
463-- incoming responses.
536−matchResponseMapWithRequests
464+matchResponsesWithRequests
537 :: forall t rawRequest rawResponse request response m.
465 :: forall t rawRequest rawResponse request response m.
538 ( MonadFix m
466 ( MonadFix m
539 , MonadHold t m
467 , MonadHold t m
@@ -544,14 +472,14 @@ matchResponseMapWithRequests
544 -- request and a function used to process the associated response
472 -- request and a function used to process the associated response
545 -> Event t (RequesterData request)
473 -> Event t (RequesterData request)
546 -- ^ The outgoing requests
474 -- ^ The outgoing requests
547− -> Event t (Map Int rawResponse)
475+ -> Event t (Int, rawResponse)
548− -- ^ A map of incoming responses, tagged by an identifying key
476+ -- ^ The incoming responses, tagged by an identifying key
549 -> m ( Event t (Map Int rawRequest)
477 -> m ( Event t (Map Int rawRequest)
550 , Event t (RequesterData response)
478 , Event t (RequesterData response)
551 )
479 )
552 -- ^ A map of outgoing wire-format requests and an event of responses keyed
480 -- ^ A map of outgoing wire-format requests and an event of responses keyed
553 -- by the 'RequesterData' key of the associated outgoing request
481 -- by the 'RequesterData' key of the associated outgoing request
554−matchResponseMapWithRequests f send recv = do
482+matchResponsesWithRequests f send recv = do
555 rec nextId <- hold 1 $ fmap (\(next, _, _) -> next) outgoing
483 rec nextId <- hold 1 $ fmap (\(next, _, _) -> next) outgoing
556 waitingFor :: Incremental t (PatchMap Int (Decoder rawResponse response)) <-
484 waitingFor :: Incremental t (PatchMap Int (Decoder rawResponse response)) <-
557 holdIncremental mempty $ leftmost
485 holdIncremental mempty $ leftmost
@@ -593,15 +521,17 @@ matchResponseMapWithRequests f send recv = do
593 processIncoming
521 processIncoming
594 :: Incremental t (PatchMap Int (Decoder rawResponse response))
522 :: Incremental t (PatchMap Int (Decoder rawResponse response))
595 -- A map of outstanding expected responses
523 -- A map of outstanding expected responses
596− -> Event t (Map Int rawResponse)
524+ -> Event t (Int, rawResponse)
597 -- A incoming response paired with its identifying key
525 -- A incoming response paired with its identifying key
598 -> Event t (RequesterData response, PatchMap Int v)
526 -> Event t (RequesterData response, PatchMap Int v)
599 -- The decoded response and a patch that clears the outstanding responses queue
527 -- The decoded response and a patch that clears the outstanding responses queue
600− processIncoming waitingFor inc = flip push inc $ \rspMap -> do
528+ processIncoming waitingFor inc = flip push inc $ \(n, rawRsp) -> do
601 wf <- sample $ currentIncremental waitingFor
529 wf <- sample $ currentIncremental waitingFor
602− let match rawRsp (Decoder k rspF) =
530+ case Map.lookup n wf of
603− let rsp = rspF rawRsp
531+ Nothing -> return Nothing -- TODO How should lookup failures be handled here? They shouldn't ever happen..
604− in singletonRequesterData k rsp
532+ Just (Decoder k rspF) -> do
605− matches = Map.intersectionWith match rspMap wf
533+ let rsp = rspF rawRsp
606− pure $ if Map.null matches then Nothing else Just
534+ return $ Just
607− (Map.foldl' mergeRequesterData emptyRequesterData matches, PatchMap $ Nothing <$ matches)
535+ ( singletonRequesterData k rsp
536+ , PatchMap $ Map.singleton n Nothing
537+ )
src/Reflex/Spider/Internal.hs+270−462
@@ -9,6 +9,7 @@
9{-# LANGUAGE GADTs #-}
9{-# LANGUAGE GADTs #-}
10{-# LANGUAGE GeneralizedNewtypeDeriving #-}
10{-# LANGUAGE GeneralizedNewtypeDeriving #-}
11{-# LANGUAGE LambdaCase #-}
11{-# LANGUAGE LambdaCase #-}
12+{-# LANGUAGE MultiWayIf #-}
12{-# LANGUAGE RankNTypes #-}
13{-# LANGUAGE RankNTypes #-}
13{-# LANGUAGE RoleAnnotations #-}
14{-# LANGUAGE RoleAnnotations #-}
14{-# LANGUAGE ScopedTypeVariables #-}
15{-# LANGUAGE ScopedTypeVariables #-}
@@ -19,7 +20,6 @@
19{-# LANGUAGE DeriveFunctor #-}
20{-# LANGUAGE DeriveFunctor #-}
20{-# LANGUAGE StandaloneDeriving #-}
21{-# LANGUAGE StandaloneDeriving #-}
21{-# LANGUAGE InstanceSigs #-}
22{-# LANGUAGE InstanceSigs #-}
22−{-# LANGUAGE MultiWayIf #-}
23
23
24#ifdef USE_REFLEX_OPTIMIZER
24#ifdef USE_REFLEX_OPTIMIZER
25{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
25{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
@@ -38,6 +38,7 @@ import Control.Monad hiding (forM, forM_, mapM, mapM_)
38import Control.Monad.Exception
38import Control.Monad.Exception
39import Control.Monad.Identity hiding (forM, forM_, mapM, mapM_)
39import Control.Monad.Identity hiding (forM, forM_, mapM, mapM_)
40import Control.Monad.Primitive
40import Control.Monad.Primitive
41+--import Control.Monad.Reader hiding (forM, forM_, mapM, mapM_)
41import Control.Monad.Reader.Class
42import Control.Monad.Reader.Class
42import Control.Monad.IO.Class
43import Control.Monad.IO.Class
43import Control.Monad.ReaderIO
44import Control.Monad.ReaderIO
@@ -46,9 +47,8 @@ import Control.Monad.Fail (MonadFail)
46import qualified Control.Monad.Fail as MonadFail
47import qualified Control.Monad.Fail as MonadFail
47import Data.Align
48import Data.Align
48import Data.Coerce
49import Data.Coerce
49−import Data.Dependent.Map (DMap)
50+import Data.Dependent.Map (DMap, DSum (..))
50import qualified Data.Dependent.Map as DMap
51import qualified Data.Dependent.Map as DMap
51−import Data.Dependent.Sum (DSum (..))
52import Data.FastMutableIntMap (FastMutableIntMap, PatchIntMap (..))
52import Data.FastMutableIntMap (FastMutableIntMap, PatchIntMap (..))
53import qualified Data.FastMutableIntMap as FastMutableIntMap
53import qualified Data.FastMutableIntMap as FastMutableIntMap
54import Data.Foldable hiding (concat, elem, sequence_)
54import Data.Foldable hiding (concat, elem, sequence_)
@@ -61,13 +61,12 @@ import qualified Data.IntMap.Strict as IntMap
61import Data.IORef
61import Data.IORef
62import Data.Kind (Type)
62import Data.Kind (Type)
63import Data.Maybe hiding (mapMaybe)
63import Data.Maybe hiding (mapMaybe)
64−import Data.Monoid (mempty, (<>))
64+import Data.Monoid ((<>))
65import Data.Proxy
65import Data.Proxy
66import Data.These
66import Data.These
67import Data.Traversable
67import Data.Traversable
68−import Data.Type.Equality ((:~:)(Refl))
69import Data.Witherable (Filterable, mapMaybe)
68import Data.Witherable (Filterable, mapMaybe)
70−import GHC.Exts hiding (toList)
69+import GHC.Exts
71import GHC.IORef (IORef (..))
70import GHC.IORef (IORef (..))
72import GHC.Stack
71import GHC.Stack
73import Reflex.FastWeak
72import Reflex.FastWeak
@@ -86,16 +85,14 @@ import Data.Zip (Zip (..))
86
85
87#ifdef DEBUG_CYCLES
86#ifdef DEBUG_CYCLES
88import Control.Monad.State hiding (forM, forM_, mapM, mapM_, sequence)
87import Control.Monad.State hiding (forM, forM_, mapM, mapM_, sequence)
89−#endif
90−
91import Data.List.NonEmpty (NonEmpty (..), nonEmpty)
88import Data.List.NonEmpty (NonEmpty (..), nonEmpty)
92import qualified Data.List.NonEmpty as NonEmpty
89import qualified Data.List.NonEmpty as NonEmpty
90+import Data.Monoid (mempty)
93import Data.Tree (Forest, Tree (..), drawForest)
91import Data.Tree (Forest, Tree (..), drawForest)
94−import Data.List (isPrefixOf)
92+#endif
95
93
96−import Data.FastWeakBag (FastWeakBag, FastWeakBagTicket)
94+import Data.FastWeakBag (FastWeakBag)
97import qualified Data.FastWeakBag as FastWeakBag
95import qualified Data.FastWeakBag as FastWeakBag
98−
99import Data.Reflection
96import Data.Reflection
100import Data.Some (Some(Some))
97import Data.Some (Some(Some))
101import Data.Type.Coercion
98import Data.Type.Coercion
@@ -106,26 +103,21 @@ import qualified Reflex.Class
106import qualified Reflex.Class as R
103import qualified Reflex.Class as R
107import qualified Reflex.Host.Class
104import qualified Reflex.Host.Class
108import Reflex.NotReady.Class
105import Reflex.NotReady.Class
109−import Data.Patch
106+import Reflex.Patch
110−import qualified Data.Patch.DMapWithMove as PatchDMapWithMove
107+import qualified Reflex.Patch.DMapWithMove as PatchDMapWithMove
111import Reflex.PerformEvent.Base (PerformEventT)
108import Reflex.PerformEvent.Base (PerformEventT)
112
109
113#ifdef DEBUG_TRACE_EVENTS
110#ifdef DEBUG_TRACE_EVENTS
114import qualified Data.ByteString.Char8 as BS8
111import qualified Data.ByteString.Char8 as BS8
115import System.IO (stderr)
112import System.IO (stderr)
116−import Data.List (isPrefixOf)
117#endif
113#endif
118
114
119−-- TODO stdout might not be the best channel for debug output
120−debugStrLn :: String -> IO ()
121−debugStrLn = putStrLn
122−
123#ifdef DEBUG_TRACE_EVENTS
115#ifdef DEBUG_TRACE_EVENTS
116+
124withStackOneLine :: (BS8.ByteString -> a) -> a
117withStackOneLine :: (BS8.ByteString -> a) -> a
125withStackOneLine expr = unsafePerformIO $ do
118withStackOneLine expr = unsafePerformIO $ do
126 stack <- currentCallStack
119 stack <- currentCallStack
127− return (expr . BS8.pack . unwords . dropInternal . reverse $ stack)
120+ return (expr (BS8.pack (unwords (reverse stack))))
128− where dropInternal = filterStack "Reflex.Spider.Internal"
129
121
130#endif
122#endif
131
123
@@ -136,42 +128,28 @@ debugInvalidateHeight :: Bool
136debugInvalidate :: Bool
128debugInvalidate :: Bool
137
129
138#ifdef DEBUG
130#ifdef DEBUG
131+
139#define DEBUG_NODEIDS
132#define DEBUG_NODEIDS
140
133
141−#ifdef DEBUG_TRACE_PROPAGATION
142debugPropagate = True
134debugPropagate = True
143−#else
144−debugPropagate = False
145−#endif
146
135
147−#ifdef DEBUG_TRACE_HEIGHT
148−debugInvalidateHeight = True
149−#else
150debugInvalidateHeight = False
136debugInvalidateHeight = False
151−#endif
152
137
153−#ifdef DEBUG_TRACE_INVALIDATION
154debugInvalidate = True
138debugInvalidate = True
155−#else
156−debugInvalidate = False
157−#endif
158
139
159class HasNodeId a where
140class HasNodeId a where
160 getNodeId :: a -> Int
141 getNodeId :: a -> Int
161
142
162−instance HasNodeId (CacheSubscribed x a) where
143+instance HasNodeId (Hold x p a) where
163− getNodeId = _cacheSubscribed_nodeId
164−
165−instance HasNodeId (FanInt x a) where
166− getNodeId = _fanInt_nodeId
167−
168−instance HasNodeId (Hold x p) where
169 getNodeId = holdNodeId
144 getNodeId = holdNodeId
170
145
146+instance HasNodeId (PushSubscribed x a b) where
147+ getNodeId = pushSubscribedNodeId
148+
171instance HasNodeId (SwitchSubscribed x a) where
149instance HasNodeId (SwitchSubscribed x a) where
172 getNodeId = switchSubscribedNodeId
150 getNodeId = switchSubscribedNodeId
173
151
174−instance HasNodeId (FanSubscribed x v a) where
152+instance HasNodeId (FanSubscribed x a) where
175 getNodeId = fanSubscribedNodeId
153 getNodeId = fanSubscribedNodeId
176
154
177instance HasNodeId (CoincidenceSubscribed x a) where
155instance HasNodeId (CoincidenceSubscribed x a) where
@@ -185,16 +163,41 @@ instance HasNodeId (Pull x a) where
185
163
186{-# INLINE showNodeId #-}
164{-# INLINE showNodeId #-}
187showNodeId :: HasNodeId a => a -> String
165showNodeId :: HasNodeId a => a -> String
188−showNodeId = showNodeId' . getNodeId
166+showNodeId = ("#"<>) . show . getNodeId
189−
167+
190−showNodeId' :: Int -> String
168+showSubscriberType :: Subscriber x a -> String
191−showNodeId' = ("#"<>) . show
169+showSubscriberType = \case
192−
170+ SubscriberPush _ _ -> "SubscriberPush"
171+ SubscriberMerge _ _ -> "SubscriberMerge"
172+ SubscriberFan _ -> "SubscriberFan"
173+ SubscriberMergeChange _ -> "SubscriberMergeChange"
174+ SubscriberHold _ -> "SubscriberHold"
175+ SubscriberHoldIdentity _ -> "SubscriberHoldIdentity"
176+ SubscriberSwitch _ -> "SubscriberSwitch"
177+ SubscriberCoincidenceOuter _ -> "SubscriberCoincidenceOuter"
178+ SubscriberCoincidenceInner _ -> "SubscriberCoincidenceInner"
179+ SubscriberHandle -> "SubscriberHandle"
180+
181+showEventType :: Event x a -> String
182+showEventType = \case
183+ EventRoot _ _ -> "EventRoot"
184+ EventNever -> "EventNever"
185+ EventPush _ -> "EventPush"
186+ EventMerge _ -> "EventMerge"
187+ EventFan _ _ -> "EventFan"
188+ EventSwitch _ -> "EventSwitch"
189+ EventCoincidence _ -> "EventCoincidence"
190+ EventHold _ -> "EventHold"
191+ EventDyn _ -> "EventDyn"
192+ EventHoldIdentity _ -> "EventHoldIdentity"
193+ EventDynIdentity _ -> "EventDynIdentity"
193
194
194#else
195#else
195
196
196debugPropagate = False
197debugPropagate = False
198+
197debugInvalidateHeight = False
199debugInvalidateHeight = False
200+
198debugInvalidate = False
201debugInvalidate = False
199
202
200-- This must be inline, or error messages will cause memory leaks due to retaining the node in question
203-- This must be inline, or error messages will cause memory leaks due to retaining the node in question
@@ -202,10 +205,6 @@ debugInvalidate = False
202showNodeId :: a -> String
205showNodeId :: a -> String
203showNodeId _ = ""
206showNodeId _ = ""
204
207
205−{-# INLINE showNodeId' #-}
206−showNodeId' :: Int -> String
207−showNodeId' _ = ""
208−
209#endif
208#endif
210
209
211#ifdef DEBUG_NODEIDS
210#ifdef DEBUG_NODEIDS
@@ -251,9 +250,9 @@ subscribeAndRead = unEvent
251-- caching; if the computation function is very cheap, this is (much) more
250-- caching; if the computation function is very cheap, this is (much) more
252-- efficient than 'push'
251-- efficient than 'push'
253{-# INLINE [1] pushCheap #-}
252{-# INLINE [1] pushCheap #-}
254−pushCheap :: HasSpiderTimeline x => (a -> ComputeM x (Maybe b)) -> Event x a -> Event x b
253+pushCheap :: (a -> ComputeM x (Maybe b)) -> Event x a -> Event x b
255pushCheap !f e = Event $ \sub -> do
254pushCheap !f e = Event $ \sub -> do
256− (subscription, occ) <- subscribeAndRead e $ debugSubscriber' "push" $ sub
255+ (subscription, occ) <- subscribeAndRead e $ sub
257 { subscriberPropagate = \a -> do
256 { subscriberPropagate = \a -> do
258 mb <- f a
257 mb <- f a
259 mapM_ (subscriberPropagate sub) mb
258 mapM_ (subscriberPropagate sub) mb
@@ -272,10 +271,10 @@ terminalSubscriber p = Subscriber
272
271
273-- | Subscribe to an Event only for the duration of one occurrence
272-- | Subscribe to an Event only for the duration of one occurrence
274{-# INLINE subscribeAndReadHead #-}
273{-# INLINE subscribeAndReadHead #-}
275−subscribeAndReadHead :: HasSpiderTimeline x => Event x a -> Subscriber x a -> EventM x (EventSubscription x, Maybe a)
274+subscribeAndReadHead :: Event x a -> Subscriber x a -> EventM x (EventSubscription x, Maybe a)
276subscribeAndReadHead e sub = do
275subscribeAndReadHead e sub = do
277 subscriptionRef <- liftIO $ newIORef $ error "subscribeAndReadHead: not initialized"
276 subscriptionRef <- liftIO $ newIORef $ error "subscribeAndReadHead: not initialized"
278− (subscription, occ) <- subscribeAndRead e $ debugSubscriber' "head" $ sub
277+ (subscription, occ) <- subscribeAndRead e $ sub
279 { subscriberPropagate = \a -> do
278 { subscriberPropagate = \a -> do
280 liftIO $ unsubscribe =<< readIORef subscriptionRef
279 liftIO $ unsubscribe =<< readIORef subscriptionRef
281 subscriberPropagate sub a
280 subscriberPropagate sub a
@@ -286,42 +285,24 @@ subscribeAndReadHead e sub = do
286 return (subscription, occ)
285 return (subscription, occ)
287
286
288--TODO: Make this lazy in its input event
287--TODO: Make this lazy in its input event
289−headE :: (MonadIO m, Defer (SomeMergeInit x) m, HasSpiderTimeline x) => Event x a -> m (Event x a)
288+headE :: (MonadIO m, Defer (SomeMergeInit x) m) => Event x a -> m (Event x a)
290headE originalE = do
289headE originalE = do
291 parent <- liftIO $ newIORef $ Just originalE
290 parent <- liftIO $ newIORef $ Just originalE
292 defer $ SomeMergeInit $ do --TODO: Rename SomeMergeInit appropriately
291 defer $ SomeMergeInit $ do --TODO: Rename SomeMergeInit appropriately
293 let clearParent = liftIO $ writeIORef parent Nothing
292 let clearParent = liftIO $ writeIORef parent Nothing
294− (_, occ) <- subscribeAndReadHead originalE $ terminalSubscriber $ const clearParent
293+ (_, occ) <- subscribeAndReadHead originalE $ terminalSubscriber $ \_ -> clearParent
295 when (isJust occ) clearParent
294 when (isJust occ) clearParent
296− return $ Event $ \sub ->
295+ return $ Event $ \sub -> do
297 liftIO (readIORef parent) >>= \case
296 liftIO (readIORef parent) >>= \case
298− Nothing -> subscribeAndReadNever
297+ Nothing -> return (EventSubscription (return ()) $ EventSubscribed zeroRef $ toAny (), Nothing)
299 Just e -> subscribeAndReadHead e sub
298 Just e -> subscribeAndReadHead e sub
300
299
301data CacheSubscribed x a
300data CacheSubscribed x a
302 = CacheSubscribed { _cacheSubscribed_subscribers :: {-# UNPACK #-} !(FastWeakBag (Subscriber x a))
301 = CacheSubscribed { _cacheSubscribed_subscribers :: {-# UNPACK #-} !(FastWeakBag (Subscriber x a))
303 , _cacheSubscribed_parent :: {-# UNPACK #-} !(EventSubscription x)
302 , _cacheSubscribed_parent :: {-# UNPACK #-} !(EventSubscription x)
304 , _cacheSubscribed_occurrence :: {-# UNPACK #-} !(IORef (Maybe a))
303 , _cacheSubscribed_occurrence :: {-# UNPACK #-} !(IORef (Maybe a))
305−#ifdef DEBUG_NODEIDS
306− , _cacheSubscribed_nodeId :: {-# UNPACK #-} !Int
307−#endif
308 }
304 }
309
305
310−nowSpiderEventM :: (HasSpiderTimeline x) => EventM x (R.Event (SpiderTimeline x) ())
311−nowSpiderEventM =
312− SpiderEvent <$> now
313−
314−now :: (MonadIO m, Defer (Some Clear) m, HasSpiderTimeline x
315− ) => m (Event x ())
316−now = do
317− nowOrNot <- liftIO $ newIORef $ Just ()
318− scheduleClear nowOrNot
319− return . Event $ \_ -> do
320− occ <- liftIO . readIORef $ nowOrNot
321− return ( EventSubscription (return ()) eventSubscribedNow
322− , occ
323− )
324−
325-- | Construct an 'Event' whose value is guaranteed not to be recomputed
306-- | Construct an 'Event' whose value is guaranteed not to be recomputed
326-- repeatedly
307-- repeatedly
327--
308--
@@ -346,23 +327,18 @@ cacheEvent e =
346 subscribedTicket <- liftIO (readIORef mSubscribedRef >>= getFastWeakTicket) >>= \case
327 subscribedTicket <- liftIO (readIORef mSubscribedRef >>= getFastWeakTicket) >>= \case
347 Just subscribedTicket -> return subscribedTicket
328 Just subscribedTicket -> return subscribedTicket
348 Nothing -> do
329 Nothing -> do
349−#ifdef DEBUG_NODEIDS
350− nodeId <- liftIO newNodeId
351−#endif
352 subscribers <- liftIO FastWeakBag.empty
330 subscribers <- liftIO FastWeakBag.empty
353 occRef <- liftIO $ newIORef Nothing -- This should never be read prior to being set below
331 occRef <- liftIO $ newIORef Nothing -- This should never be read prior to being set below
354−#ifdef DEBUG_NODEIDS
355− (parentSub, occ) <- subscribeAndRead e $ debugSubscriber' ("cacheEvent" <> showNodeId' nodeId) $ Subscriber
356−#else
357 (parentSub, occ) <- subscribeAndRead e $ Subscriber
332 (parentSub, occ) <- subscribeAndRead e $ Subscriber
358−#endif
359− { subscriberPropagate = \a -> do
333+ { subscriberPropagate = \a -> do
360− liftIO $ writeIORef occRef (Just a)
334+ liftIO $ writeIORef occRef $ Just a
361− scheduleClear occRef
335+ scheduleClear occRef
362− propagateFast a subscribers
336+ propagateFast a subscribers
337+ , subscriberInvalidateHeight = \old -> do
363− , subscriberInvalidateHeight = FastWeakBag.traverse_ subscribers . invalidateSubscriberHeight
338+ FastWeakBag.traverse_ subscribers $ invalidateSubscriberHeight old
339+ , subscriberRecalculateHeight = \new -> do
364− , subscriberRecalculateHeight = FastWeakBag.traverse_ subscribers . recalculateSubscriberHeight
340+ FastWeakBag.traverse_ subscribers $ recalculateSubscriberHeight new
365− }
341+ }
366 when (isJust occ) $ do
342 when (isJust occ) $ do
367 liftIO $ writeIORef occRef occ -- Set the initial value of occRef; we don't need to do this if occ is Nothing
343 liftIO $ writeIORef occRef occ -- Set the initial value of occRef; we don't need to do this if occ is Nothing
368 scheduleClear occRef
344 scheduleClear occRef
@@ -370,45 +346,29 @@ cacheEvent e =
370 { _cacheSubscribed_subscribers = subscribers
346 { _cacheSubscribed_subscribers = subscribers
371 , _cacheSubscribed_parent = parentSub
347 , _cacheSubscribed_parent = parentSub
372 , _cacheSubscribed_occurrence = occRef
348 , _cacheSubscribed_occurrence = occRef
373−#ifdef DEBUG_NODEIDS
374− , _cacheSubscribed_nodeId = nodeId
375−#endif
376 }
349 }
377 subscribedTicket <- liftIO $ mkFastWeakTicket subscribed
350 subscribedTicket <- liftIO $ mkFastWeakTicket subscribed
378 liftIO $ writeIORef mSubscribedRef =<< getFastWeakTicketWeak subscribedTicket
351 liftIO $ writeIORef mSubscribedRef =<< getFastWeakTicketWeak subscribedTicket
379 return subscribedTicket
352 return subscribedTicket
380− liftIO $ cacheSubscription sub mSubscribedRef subscribedTicket
353+ liftIO $ do
381−
382−cacheSubscription :: Subscriber x a -> IORef (FastWeak (CacheSubscribed x a))
383− -> FastWeakTicket (CacheSubscribed x a) -> IO (EventSubscription x, Maybe a)
384−cacheSubscription sub mSubscribedRef subscribedTicket = do
385− subscribed <- getFastWeakTicketValue subscribedTicket
354+ subscribed <- getFastWeakTicketValue subscribedTicket
386− ticket <- FastWeakBag.insert sub $ _cacheSubscribed_subscribers subscribed
355+ ticket <- FastWeakBag.insert sub $ _cacheSubscribed_subscribers subscribed
387− occ <- readIORef $ _cacheSubscribed_occurrence subscribed
356+ occ <- readIORef $ _cacheSubscribed_occurrence subscribed
388−
389− let parentSub = _cacheSubscribed_parent subscribed
390− es = EventSubscription
357+ let es = EventSubscription
391− { _eventSubscription_unsubscribe = do
358+ { _eventSubscription_unsubscribe = do
392− FastWeakBag.remove ticket
359+ FastWeakBag.remove ticket
393−
394− isEmpty <- FastWeakBag.isEmpty $ _cacheSubscribed_subscribers subscribed
360+ isEmpty <- FastWeakBag.isEmpty $ _cacheSubscribed_subscribers subscribed
395− when isEmpty $ do
361+ when isEmpty $ do
396− writeIORef mSubscribedRef emptyFastWeak
362+ writeIORef mSubscribedRef emptyFastWeak
397− unsubscribe parentSub
363+ unsubscribe $ _cacheSubscribed_parent subscribed
398− touch ticket
364+ touch ticket
399− touch subscribedTicket
365+ touch subscribedTicket
400− , _eventSubscription_subscribed = EventSubscribed
366+ , _eventSubscription_subscribed = EventSubscribed
401− { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed parentSub
367+ { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed $ _cacheSubscribed_parent subscribed
402− , eventSubscribedRetained = toAny subscribedTicket
368+ , eventSubscribedRetained = toAny subscribedTicket
403−#ifdef DEBUG_CYCLES
404− , eventSubscribedGetParents = return [_eventSubscription_subscribed parentSub]
405− , eventSubscribedHasOwnHeightRef = False
406− , eventSubscribedWhoCreated = whoCreatedIORef mSubscribedRef
407−#endif
408− }
369+ }
409− }
370+ }
410− return (es, occ)
371+ return (es, occ)
411−
412
372
413subscribe :: Event x a -> Subscriber x a -> EventM x (EventSubscription x)
373subscribe :: Event x a -> Subscriber x a -> EventM x (EventSubscription x)
414subscribe e s = fst <$> subscribeAndRead e s
374subscribe e s = fst <$> subscribeAndRead e s
@@ -420,14 +380,11 @@ wrap tag getSpecificSubscribed sub = do
420 let es = tag subd
380 let es = tag subd
421 return (EventSubscription (WeakBag.remove sln >> touch sln) es, occ)
381 return (EventSubscription (WeakBag.remove sln >> touch sln) es, occ)
422
382
423−eventRoot :: (GCompare k, HasSpiderTimeline x) => k a -> Root x k -> Event x a
383+eventRoot :: GCompare k => k a -> Root x k -> Event x a
424eventRoot !k !r = Event $ wrap eventSubscribedRoot $ liftIO . getRootSubscribed k r
384eventRoot !k !r = Event $ wrap eventSubscribedRoot $ liftIO . getRootSubscribed k r
425
385
426−subscribeAndReadNever :: EventM x (EventSubscription x, Maybe a)
427−subscribeAndReadNever = return (EventSubscription (return ()) eventSubscribedNever, Nothing)
428−
429eventNever :: Event x a
386eventNever :: Event x a
430−eventNever = Event $ const subscribeAndReadNever
387+eventNever = Event $ \_ -> return (EventSubscription (return ()) eventSubscribedNever, Nothing)
431
388
432eventFan :: (GCompare k, HasSpiderTimeline x) => k a -> Fan x k v -> Event x (v a)
389eventFan :: (GCompare k, HasSpiderTimeline x) => k a -> Fan x k v -> Event x (v a)
433eventFan !k !f = Event $ wrap eventSubscribedFan $ getFanSubscribed k f
390eventFan !k !f = Event $ wrap eventSubscribedFan $ getFanSubscribed k f
@@ -464,6 +421,16 @@ data Subscriber x a = Subscriber
464 , subscriberRecalculateHeight :: !(Height -> IO ())
421 , subscriberRecalculateHeight :: !(Height -> IO ())
465 }
422 }
466
423
424+--TODO: Move this comment to WeakBag
425+-- These function are constructor functions that are marked NOINLINE so they are
426+-- opaque to GHC. If we do not do this, then GHC will sometimes fuse the constructor away
427+-- so any weak references that are attached to the constructors will have their
428+-- finalizer run. Using the opaque constructor, does not see the
429+-- constructor application, so it behaves like an IORef and cannot be fused away.
430+--
431+-- The result is also evaluated to WHNF, since forcing a thunk invalidates
432+-- the weak pointer to it in some cases.
433+
467newSubscriberHold :: (HasSpiderTimeline x, Patch p) => Hold x p -> IO (Subscriber x p)
434newSubscriberHold :: (HasSpiderTimeline x, Patch p) => Hold x p -> IO (Subscriber x p)
468newSubscriberHold h = return $ Subscriber
435newSubscriberHold h = return $ Subscriber
469 { subscriberPropagate = {-# SCC "traverseHold" #-} propagateSubscriberHold h
436 { subscriberPropagate = {-# SCC "traverseHold" #-} propagateSubscriberHold h
@@ -472,10 +439,10 @@ newSubscriberHold h = return $ Subscriber
472 }
439 }
473
440
474newSubscriberFan :: forall x k v. (HasSpiderTimeline x, GCompare k) => FanSubscribed x k v -> IO (Subscriber x (DMap k v))
441newSubscriberFan :: forall x k v. (HasSpiderTimeline x, GCompare k) => FanSubscribed x k v -> IO (Subscriber x (DMap k v))
475−newSubscriberFan subscribed = debugSubscriber ("SubscriberFan " <> showNodeId subscribed) $ Subscriber
442+newSubscriberFan subscribed = return $ Subscriber
476 { subscriberPropagate = \a -> {-# SCC "traverseFan" #-} do
443 { subscriberPropagate = \a -> {-# SCC "traverseFan" #-} do
477 subs <- liftIO $ readIORef $ fanSubscribedSubscribers subscribed
444 subs <- liftIO $ readIORef $ fanSubscribedSubscribers subscribed
478− tracePropagate (Proxy :: Proxy x) $ show (DMap.size subs) <> " keys subscribed, " <> show (DMap.size a) <> " keys firing"
445+ tracePropagate (Proxy :: Proxy x) $ "SubscriberFan" <> showNodeId subscribed <> ": " ++ show (DMap.size subs) ++ " keys subscribed, " ++ show (DMap.size a) ++ " keys firing"
479 liftIO $ writeIORef (fanSubscribedOccurrence subscribed) $ Just a
446 liftIO $ writeIORef (fanSubscribedOccurrence subscribed) $ Just a
480 scheduleClear $ fanSubscribedOccurrence subscribed
447 scheduleClear $ fanSubscribedOccurrence subscribed
481 let f _ (Pair v subsubs) = do
448 let f _ (Pair v subsubs) = do
@@ -484,40 +451,50 @@ newSubscriberFan subscribed = debugSubscriber ("SubscriberFan " <> showNodeId su
484 _ <- DMap.traverseWithKey f $ DMap.intersectionWithKey (\_ -> Pair) a subs --TODO: Would be nice to have DMap.traverse_
451 _ <- DMap.traverseWithKey f $ DMap.intersectionWithKey (\_ -> Pair) a subs --TODO: Would be nice to have DMap.traverse_
485 return ()
452 return ()
486 , subscriberInvalidateHeight = \old -> do
453 , subscriberInvalidateHeight = \old -> do
454+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberFan" <> showNodeId subscribed
487 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
455 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
488 forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse_ (_fanSubscribedChildren_list v) $ invalidateSubscriberHeight old
456 forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse_ (_fanSubscribedChildren_list v) $ invalidateSubscriberHeight old
457+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberFan" <> showNodeId subscribed <> " done"
489 , subscriberRecalculateHeight = \new -> do
458 , subscriberRecalculateHeight = \new -> do
459+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberFan" <> showNodeId subscribed
490 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
460 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
491 forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse_ (_fanSubscribedChildren_list v) $ recalculateSubscriberHeight new
461 forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse_ (_fanSubscribedChildren_list v) $ recalculateSubscriberHeight new
462+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberFan" <> showNodeId subscribed <> " done"
492 }
463 }
493
464
494newSubscriberSwitch :: forall x a. HasSpiderTimeline x => SwitchSubscribed x a -> IO (Subscriber x a)
465newSubscriberSwitch :: forall x a. HasSpiderTimeline x => SwitchSubscribed x a -> IO (Subscriber x a)
495−newSubscriberSwitch subscribed = debugSubscriber ("SubscriberCoincidenceOuter" <> showNodeId subscribed) $ Subscriber
466+newSubscriberSwitch subscribed = return $ Subscriber
496 { subscriberPropagate = \a -> {-# SCC "traverseSwitch" #-} do
467 { subscriberPropagate = \a -> {-# SCC "traverseSwitch" #-} do
468+ tracePropagate (Proxy :: Proxy x) $ "SubscriberSwitch" <> showNodeId subscribed
497 liftIO $ writeIORef (switchSubscribedOccurrence subscribed) $ Just a
469 liftIO $ writeIORef (switchSubscribedOccurrence subscribed) $ Just a
498 scheduleClear $ switchSubscribedOccurrence subscribed
470 scheduleClear $ switchSubscribedOccurrence subscribed
499 propagate a $ switchSubscribedSubscribers subscribed
471 propagate a $ switchSubscribedSubscribers subscribed
500 , subscriberInvalidateHeight = \_ -> do
472 , subscriberInvalidateHeight = \_ -> do
473+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed
501 oldHeight <- readIORef $ switchSubscribedHeight subscribed
474 oldHeight <- readIORef $ switchSubscribedHeight subscribed
502 when (oldHeight /= invalidHeight) $ do
475 when (oldHeight /= invalidHeight) $ do
503 writeIORef (switchSubscribedHeight subscribed) $! invalidHeight
476 writeIORef (switchSubscribedHeight subscribed) $! invalidHeight
504 WeakBag.traverse_ (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
477 WeakBag.traverse_ (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
478+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed <> " done"
479+ , subscriberRecalculateHeight = \new -> do
480+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed
505− , subscriberRecalculateHeight = (`updateSwitchHeight` subscribed)
481+ updateSwitchHeight new subscribed
482+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed <> " done"
506− }
483+ }
507
484
508newSubscriberCoincidenceOuter :: forall x b. HasSpiderTimeline x => CoincidenceSubscribed x b -> IO (Subscriber x (Event x b))
485newSubscriberCoincidenceOuter :: forall x b. HasSpiderTimeline x => CoincidenceSubscribed x b -> IO (Subscriber x (Event x b))
509−newSubscriberCoincidenceOuter subscribed = debugSubscriber ("SubscriberCoincidenceOuter" <> showNodeId subscribed) $ Subscriber
486+newSubscriberCoincidenceOuter subscribed = return $ Subscriber
510 { subscriberPropagate = \a -> {-# SCC "traverseCoincidenceOuter" #-} do
487 { subscriberPropagate = \a -> {-# SCC "traverseCoincidenceOuter" #-} do
488+ tracePropagate (Proxy :: Proxy x) $ "SubscriberCoincidenceOuter" <> showNodeId subscribed
511 outerHeight <- liftIO $ readIORef $ coincidenceSubscribedHeight subscribed
489 outerHeight <- liftIO $ readIORef $ coincidenceSubscribedHeight subscribed
512 tracePropagate (Proxy :: Proxy x) $ " outerHeight = " <> show outerHeight
490 tracePropagate (Proxy :: Proxy x) $ " outerHeight = " <> show outerHeight
513 (occ, innerHeight, innerSubd) <- subscribeCoincidenceInner a outerHeight subscribed
491 (occ, innerHeight, innerSubd) <- subscribeCoincidenceInner a outerHeight subscribed
514 tracePropagate (Proxy :: Proxy x) $ " isJust occ = " <> show (isJust occ)
492 tracePropagate (Proxy :: Proxy x) $ " isJust occ = " <> show (isJust occ)
515 tracePropagate (Proxy :: Proxy x) $ " innerHeight = " <> show innerHeight
493 tracePropagate (Proxy :: Proxy x) $ " innerHeight = " <> show innerHeight
516−
517 liftIO $ writeIORef (coincidenceSubscribedInnerParent subscribed) $ Just innerSubd
494 liftIO $ writeIORef (coincidenceSubscribedInnerParent subscribed) $ Just innerSubd
518 scheduleClear $ coincidenceSubscribedInnerParent subscribed
495 scheduleClear $ coincidenceSubscribedInnerParent subscribed
519 case occ of
496 case occ of
520− Nothing ->
497+ Nothing -> do
521 when (innerHeight > outerHeight) $ liftIO $ do -- If the event fires, it will fire at a later height
498 when (innerHeight > outerHeight) $ liftIO $ do -- If the event fires, it will fire at a later height
522 writeIORef (coincidenceSubscribedHeight subscribed) $! innerHeight
499 writeIORef (coincidenceSubscribedHeight subscribed) $! innerHeight
523 WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight outerHeight
500 WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight outerHeight
@@ -526,13 +503,20 @@ newSubscriberCoincidenceOuter subscribed = debugSubscriber ("SubscriberCoinciden
526 liftIO $ writeIORef (coincidenceSubscribedOccurrence subscribed) occ
503 liftIO $ writeIORef (coincidenceSubscribedOccurrence subscribed) occ
527 scheduleClear $ coincidenceSubscribedOccurrence subscribed
504 scheduleClear $ coincidenceSubscribedOccurrence subscribed
528 propagate o $ coincidenceSubscribedSubscribers subscribed
505 propagate o $ coincidenceSubscribedSubscribers subscribed
506+ , subscriberInvalidateHeight = \_ -> do
507+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed
529− , subscriberInvalidateHeight = \_ -> invalidateCoincidenceHeight subscribed
508+ invalidateCoincidenceHeight subscribed
509+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed <> " done"
510+ , subscriberRecalculateHeight = \_ -> do
511+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed
530− , subscriberRecalculateHeight = \_ -> recalculateCoincidenceHeight subscribed
512+ recalculateCoincidenceHeight subscribed
513+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed <> " done"
531 }
514 }
532
515
533newSubscriberCoincidenceInner :: forall x a. HasSpiderTimeline x => CoincidenceSubscribed x a -> IO (Subscriber x a)
516newSubscriberCoincidenceInner :: forall x a. HasSpiderTimeline x => CoincidenceSubscribed x a -> IO (Subscriber x a)
534−newSubscriberCoincidenceInner subscribed = debugSubscriber ("SubscriberCoincidenceInner" <> showNodeId subscribed) $ Subscriber
517+newSubscriberCoincidenceInner subscribed = return $ Subscriber
535 { subscriberPropagate = \a -> {-# SCC "traverseCoincidenceInner" #-} do
518 { subscriberPropagate = \a -> {-# SCC "traverseCoincidenceInner" #-} do
519+ tracePropagate (Proxy :: Proxy x) $ "SubscriberCoincidenceInner" <> showNodeId subscribed
536 occ <- liftIO $ readIORef $ coincidenceSubscribedOccurrence subscribed
520 occ <- liftIO $ readIORef $ coincidenceSubscribedOccurrence subscribed
537 case occ of
521 case occ of
538 Just _ -> return () -- SubscriberCoincidenceOuter must have already propagated this event
522 Just _ -> return () -- SubscriberCoincidenceOuter must have already propagated this event
@@ -540,8 +524,14 @@ newSubscriberCoincidenceInner subscribed = debugSubscriber ("SubscriberCoinciden
540 liftIO $ writeIORef (coincidenceSubscribedOccurrence subscribed) $ Just a
524 liftIO $ writeIORef (coincidenceSubscribedOccurrence subscribed) $ Just a
541 scheduleClear $ coincidenceSubscribedOccurrence subscribed
525 scheduleClear $ coincidenceSubscribedOccurrence subscribed
542 propagate a $ coincidenceSubscribedSubscribers subscribed
526 propagate a $ coincidenceSubscribedSubscribers subscribed
527+ , subscriberInvalidateHeight = \_ -> do
528+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed
543− , subscriberInvalidateHeight = \_ -> invalidateCoincidenceHeight subscribed
529+ invalidateCoincidenceHeight subscribed
530+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed <> " done"
531+ , subscriberRecalculateHeight = \_ -> do
532+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed
544− , subscriberRecalculateHeight = \_ -> recalculateCoincidenceHeight subscribed
533+ recalculateCoincidenceHeight subscribed
534+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed <> " done"
545 }
535 }
546
536
547invalidateSubscriberHeight :: Height -> Subscriber x a -> IO ()
537invalidateSubscriberHeight :: Height -> Subscriber x a -> IO ()
@@ -551,15 +541,15 @@ recalculateSubscriberHeight :: Height -> Subscriber x a -> IO ()
551recalculateSubscriberHeight = flip subscriberRecalculateHeight
541recalculateSubscriberHeight = flip subscriberRecalculateHeight
552
542
553-- | Propagate everything at the current height
543-- | Propagate everything at the current height
554−propagate :: forall x a. HasSpiderTimeline x => a -> WeakBag (Subscriber x a) -> EventM x ()
544+propagate :: a -> WeakBag (Subscriber x a) -> EventM x ()
555−propagate a subscribers = withIncreasedDepth (Proxy::Proxy x) $
545+propagate a subscribers = withIncreasedDepth $ do
556 -- Note: in the following traversal, we do not visit nodes that are added to the list during our traversal; they are new events, which will necessarily have full information already, so there is no need to traverse them
546 -- Note: in the following traversal, we do not visit nodes that are added to the list during our traversal; they are new events, which will necessarily have full information already, so there is no need to traverse them
557 --TODO: Should we check if nodes already have their values before propagating? Maybe we're re-doing work
547 --TODO: Should we check if nodes already have their values before propagating? Maybe we're re-doing work
558 WeakBag.traverse_ subscribers $ \s -> subscriberPropagate s a
548 WeakBag.traverse_ subscribers $ \s -> subscriberPropagate s a
559
549
560-- | Propagate everything at the current height
550-- | Propagate everything at the current height
561−propagateFast :: forall x a. HasSpiderTimeline x => a -> FastWeakBag (Subscriber x a) -> EventM x ()
551+propagateFast :: a -> FastWeakBag (Subscriber x a) -> EventM x ()
562−propagateFast a subscribers = withIncreasedDepth (Proxy::Proxy x) $
552+propagateFast a subscribers = withIncreasedDepth $ do
563 -- Note: in the following traversal, we do not visit nodes that are added to the list during our traversal; they are new events, which will necessarily have full information already, so there is no need to traverse them
553 -- Note: in the following traversal, we do not visit nodes that are added to the list during our traversal; they are new events, which will necessarily have full information already, so there is no need to traverse them
564 --TODO: Should we check if nodes already have their values before propagating? Maybe we're re-doing work
554 --TODO: Should we check if nodes already have their values before propagating? Maybe we're re-doing work
565 FastWeakBag.traverse_ subscribers $ \s -> subscriberPropagate s a
555 FastWeakBag.traverse_ subscribers $ \s -> subscriberPropagate s a
@@ -580,7 +570,7 @@ data EventSubscribed x = EventSubscribed
580 { eventSubscribedHeightRef :: {-# UNPACK #-} !(IORef Height)
570 { eventSubscribedHeightRef :: {-# UNPACK #-} !(IORef Height)
581 , eventSubscribedRetained :: {-# NOUNPACK #-} !Any
571 , eventSubscribedRetained :: {-# NOUNPACK #-} !Any
582#ifdef DEBUG_CYCLES
572#ifdef DEBUG_CYCLES
583− , eventSubscribedGetParents :: !(IO [EventSubscribed x]) -- For debugging loops
573+ , eventSubscribedGetParents :: !(IO [Some (EventSubscribed x)]) -- For debugging loops
584 , eventSubscribedHasOwnHeightRef :: !Bool
574 , eventSubscribedHasOwnHeightRef :: !Bool
585 , eventSubscribedWhoCreated :: !(IO [String])
575 , eventSubscribedWhoCreated :: !(IO [String])
586#endif
576#endif
@@ -607,23 +597,13 @@ eventSubscribedNever = EventSubscribed
607 , eventSubscribedWhoCreated = return ["never"]
597 , eventSubscribedWhoCreated = return ["never"]
608#endif
598#endif
609 }
599 }
610−eventSubscribedNow :: EventSubscribed x
611−eventSubscribedNow = EventSubscribed
612− { eventSubscribedHeightRef = zeroRef
613− , eventSubscribedRetained = toAny ()
614−#ifdef DEBUG_CYCLES
615− , eventSubscribedGetParents = return []
616− , eventSubscribedHasOwnHeightRef = False
617− , eventSubscribedWhoCreated = return ["now"]
618−#endif
619− }
620
600
621eventSubscribedFan :: FanSubscribed x k v -> EventSubscribed x
601eventSubscribedFan :: FanSubscribed x k v -> EventSubscribed x
622eventSubscribedFan !subscribed = EventSubscribed
602eventSubscribedFan !subscribed = EventSubscribed
623 { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed $ fanSubscribedParent subscribed
603 { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed $ fanSubscribedParent subscribed
624 , eventSubscribedRetained = toAny subscribed
604 , eventSubscribedRetained = toAny subscribed
625#ifdef DEBUG_CYCLES
605#ifdef DEBUG_CYCLES
626− , eventSubscribedGetParents = return [_eventSubscription_subscribed $ fanSubscribedParent subscribed]
606+ , eventSubscribedGetParents = return [Some $ _eventSubscription_subscribed $ fanSubscribedParent subscribed]
627 , eventSubscribedHasOwnHeightRef = False
607 , eventSubscribedHasOwnHeightRef = False
628 , eventSubscribedWhoCreated = whoCreatedIORef $ fanSubscribedCachedSubscribed subscribed
608 , eventSubscribedWhoCreated = whoCreatedIORef $ fanSubscribedCachedSubscribed subscribed
629#endif
609#endif
@@ -636,7 +616,7 @@ eventSubscribedSwitch !subscribed = EventSubscribed
636#ifdef DEBUG_CYCLES
616#ifdef DEBUG_CYCLES
637 , eventSubscribedGetParents = do
617 , eventSubscribedGetParents = do
638 s <- readIORef $ switchSubscribedCurrentParent subscribed
618 s <- readIORef $ switchSubscribedCurrentParent subscribed
639− return [_eventSubscription_subscribed s]
619+ return [Some $ _eventSubscription_subscribed s]
640 , eventSubscribedHasOwnHeightRef = True
620 , eventSubscribedHasOwnHeightRef = True
641 , eventSubscribedWhoCreated = whoCreatedIORef $ switchSubscribedCachedSubscribed subscribed
621 , eventSubscribedWhoCreated = whoCreatedIORef $ switchSubscribedCachedSubscribed subscribed
642#endif
622#endif
@@ -649,8 +629,8 @@ eventSubscribedCoincidence !subscribed = EventSubscribed
649#ifdef DEBUG_CYCLES
629#ifdef DEBUG_CYCLES
650 , eventSubscribedGetParents = do
630 , eventSubscribedGetParents = do
651 innerSubscription <- readIORef $ coincidenceSubscribedInnerParent subscribed
631 innerSubscription <- readIORef $ coincidenceSubscribedInnerParent subscribed
652− let outerParent = _eventSubscription_subscribed $ coincidenceSubscribedOuterParent subscribed
632+ let outerParent = Some $ _eventSubscription_subscribed $ coincidenceSubscribedOuterParent subscribed
653− innerParents = maybeToList $ innerSubscription
633+ innerParents = maybeToList $ fmap Some innerSubscription
654 return $ outerParent : innerParents
634 return $ outerParent : innerParents
655 , eventSubscribedHasOwnHeightRef = True
635 , eventSubscribedHasOwnHeightRef = True
656 , eventSubscribedWhoCreated = whoCreatedIORef $ coincidenceSubscribedCachedSubscribed subscribed
636 , eventSubscribedWhoCreated = whoCreatedIORef $ coincidenceSubscribedCachedSubscribed subscribed
@@ -664,15 +644,15 @@ getEventSubscribedHeight es = readIORef $ eventSubscribedHeightRef es
664whoCreatedEventSubscribed :: EventSubscribed x -> IO [String]
644whoCreatedEventSubscribed :: EventSubscribed x -> IO [String]
665whoCreatedEventSubscribed = eventSubscribedWhoCreated
645whoCreatedEventSubscribed = eventSubscribedWhoCreated
666
646
667−walkInvalidHeightParents :: EventSubscribed x -> IO [EventSubscribed x]
647+walkInvalidHeightParents :: EventSubscribed x -> IO [Some (EventSubscribed x)]
668walkInvalidHeightParents s0 = do
648walkInvalidHeightParents s0 = do
669− subscribers <- flip execStateT mempty $ ($ s0) $ fix $ \loop s -> do
649+ subscribers <- flip execStateT mempty $ ($ Some s0) $ fix $ \loop (Some s) -> do
670 h <- liftIO $ readIORef $ eventSubscribedHeightRef s
650 h <- liftIO $ readIORef $ eventSubscribedHeightRef s
671 when (h == invalidHeight) $ do
651 when (h == invalidHeight) $ do
672 when (eventSubscribedHasOwnHeightRef s) $ liftIO $ writeIORef (eventSubscribedHeightRef s) $! invalidHeightBeingTraversed
652 when (eventSubscribedHasOwnHeightRef s) $ liftIO $ writeIORef (eventSubscribedHeightRef s) $! invalidHeightBeingTraversed
673− modify (s :)
653+ modify (Some s :)
674 mapM_ loop =<< liftIO (eventSubscribedGetParents s)
654 mapM_ loop =<< liftIO (eventSubscribedGetParents s)
675− forM_ subscribers $ \s -> writeIORef (eventSubscribedHeightRef s) $! invalidHeight
655+ forM_ subscribers $ \(Some s) -> writeIORef (eventSubscribedHeightRef s) $! invalidHeight
676 return subscribers
656 return subscribers
677#endif
657#endif
678
658
@@ -996,9 +976,13 @@ instance Monad (BehaviorM x) where
996 return x = BehaviorM $ return x
976 return x = BehaviorM $ return x
997#if !MIN_VERSION_base(4,13,0)
977#if !MIN_VERSION_base(4,13,0)
998 {-# INLINE fail #-}
978 {-# INLINE fail #-}
999− fail s = BehaviorM $ fail s
979+ fail s = MonadFail.fail
1000#endif
980#endif
1001
981
982+instance MonadFail (BehaviorM x) where
983+ {-# INLINABLE fail #-}
984+ fail s = BehaviorM $ fail s
985+
1002data BehaviorSubscribed x a
986data BehaviorSubscribed x a
1003 = forall p. BehaviorSubscribedHold (Hold x p)
987 = forall p. BehaviorSubscribedHold (Hold x p)
1004 | BehaviorSubscribedPull (PullSubscribed x a)
988 | BehaviorSubscribedPull (PullSubscribed x a)
@@ -1057,7 +1041,7 @@ data SomeMergeUpdate x = SomeMergeUpdate
1057newtype SomeMergeInit x = SomeMergeInit { unSomeMergeInit :: EventM x () }
1041newtype SomeMergeInit x = SomeMergeInit { unSomeMergeInit :: EventM x () }
1058
1042
1059-- EventM can do everything BehaviorM can, plus create holds
1043-- EventM can do everything BehaviorM can, plus create holds
1060−newtype EventM x a = EventM { unEventM :: IO a } deriving (Functor, Applicative, Monad, MonadIO, MonadFix, MonadException, MonadAsyncException)
1044+newtype EventM x a = EventM { unEventM :: IO a } deriving (Functor, Applicative, Monad, MonadIO, MonadFix, MonadException, MonadAsyncException) -- The environment should be Nothing if we are not in a frame, and Just if we are - in which case it is a list of assignments to be done after the frame is over
1061
1045
1062newtype MergeSubscribedParent x a = MergeSubscribedParent { unMergeSubscribedParent :: EventSubscription x }
1046newtype MergeSubscribedParent x a = MergeSubscribedParent { unMergeSubscribedParent :: EventSubscription x }
1063
1047
@@ -1082,8 +1066,7 @@ heightBagFromList :: [Height] -> HeightBag
1082heightBagFromList heights = heightBagVerify $ foldl' (flip heightBagAdd) heightBagEmpty heights
1066heightBagFromList heights = heightBagVerify $ foldl' (flip heightBagAdd) heightBagEmpty heights
1083
1067
1084heightBagAdd :: Height -> HeightBag -> HeightBag
1068heightBagAdd :: Height -> HeightBag -> HeightBag
1085−heightBagAdd (Height h) (HeightBag s c) = heightBagVerify $ HeightBag (succ s) $
1069+heightBagAdd (Height h) (HeightBag s c) = heightBagVerify $ HeightBag (succ s) $ IntMap.insertWithKey (\_ _ old -> succ old) h 0 c
1086− IntMap.insertWithKey (\_ _ old -> succ old) h 0 c
1087
1070
1088heightBagRemove :: Height -> HeightBag -> HeightBag
1071heightBagRemove :: Height -> HeightBag -> HeightBag
1089heightBagRemove (Height h) b@(HeightBag s c) = heightBagVerify $ case IntMap.lookup h c of
1072heightBagRemove (Height h) b@(HeightBag s c) = heightBagVerify $ case IntMap.lookup h c of
@@ -1092,13 +1075,6 @@ heightBagRemove (Height h) b@(HeightBag s c) = heightBagVerify $ case IntMap.loo
1092 0 -> IntMap.delete h c
1075 0 -> IntMap.delete h c
1093 _ -> IntMap.insert h (pred old) c
1076 _ -> IntMap.insert h (pred old) c
1094
1077
1095−heightBagRemoveMaybe :: Height -> HeightBag -> Maybe HeightBag
1096−heightBagRemoveMaybe (Height h) b@(HeightBag s c) = heightBagVerify . removed <$> IntMap.lookup h c where
1097− removed old = HeightBag (pred s) $ case old of
1098− 0 -> IntMap.delete h c
1099− _ -> IntMap.insert h (pred old) c
1100−
1101−
1102heightBagMax :: HeightBag -> Height
1078heightBagMax :: HeightBag -> Height
1103heightBagMax (HeightBag _ c) = case IntMap.maxViewWithKey c of
1079heightBagMax (HeightBag _ c) = case IntMap.maxViewWithKey c of
1104 Just ((h, _), _) -> Height h
1080 Just ((h, _), _) -> Height h
@@ -1346,110 +1322,55 @@ mkWeakPtrWithDebug x debugNote = do
1346 x' <- evaluate x
1322 x' <- evaluate x
1347 mkWeakPtr x' $
1323 mkWeakPtr x' $
1348 if debugFinalize
1324 if debugFinalize
1349− then Just $ debugStrLn $ "finalizing: " ++ debugNote
1325+ then Just $ putStrLn $ "finalizing: " ++ debugNote
1350 else Nothing
1326 else Nothing
1351
1327
1352type WeakList a = [Weak a]
1328type WeakList a = [Weak a]
1353
1329
1354−type CanTrace x m = (HasSpiderTimeline x, MonadIO m)
1355−
1356−
1357−
1358−
1359−#ifdef DEBUG
1360−
1361−debugSubscriber :: forall x a. HasSpiderTimeline x => String -> Subscriber x a -> IO (Subscriber x a)
1362−debugSubscriber description = return . debugSubscriber' description
1363−
1364−debugSubscriber' :: forall x a. HasSpiderTimeline x => String -> Subscriber x a -> Subscriber x a
1365−debugSubscriber' description subscribed = Subscriber
1366− {
1367− subscriberPropagate = \m -> do
1368− tracePropagate (Proxy :: Proxy x) ("subscriberPropagate: " <> description)
1369− subscriberPropagate subscribed m
1370− , subscriberInvalidateHeight = \old -> do
1371− traceInvalidateHeight $ "invalidateSubscriberHeight: " <> description <> ", old = " <> show (unHeight old)
1372− subscriberInvalidateHeight subscribed old
1373− traceInvalidateHeight $ "invalidateSubscriberHeight: " <> description <> ", done"
1374− , subscriberRecalculateHeight = \new -> do
1375− traceInvalidateHeight $ "subscriberRecalculateHeight: " <> description <> ", new = " <> show (unHeight new)
1376− subscriberRecalculateHeight subscribed new
1377− traceInvalidateHeight $ "subscriberRecalculateHeight: " <> description <> ", done"
1378− }
1379−
1380−
1381{-# INLINE withIncreasedDepth #-}
1330{-# INLINE withIncreasedDepth #-}
1331+#ifdef DEBUG
1382−withIncreasedDepth :: forall proxy x m a. CanTrace x m => proxy x -> m a -> m a
1332+withIncreasedDepth :: CanTrace x m => m a -> m a
1383−withIncreasedDepth _ a = do
1333+withIncreasedDepth a = do
1334+ spiderTimeline <- askSpiderTimelineEnv
1384− liftIO $ modifyIORef' (_spiderTimeline_depth $ unSTE (spiderTimeline :: SpiderTimelineEnv x)) succ
1335+ liftIO $ modifyIORef' (_spiderTimeline_depth (unSTE spiderTimeline)) succ
1385 result <- a
1336 result <- a
1386− liftIO $ modifyIORef' (_spiderTimeline_depth $ unSTE (spiderTimeline :: SpiderTimelineEnv x)) pred
1337+ liftIO $ modifyIORef' (_spiderTimeline_depth (unSTE spiderTimeline)) pred
1387 return result
1338 return result
1388−
1389−{-# INLINE tracePropagate #-}
1390−tracePropagate :: (CanTrace x m) => proxy x -> String -> m ()
1391−tracePropagate p = when debugPropagate . trace p
1392−
1393−{-# INLINE traceInvalidate #-}
1394−traceInvalidate :: String -> IO ()
1395−traceInvalidate = when debugInvalidate . liftIO . debugStrLn
1396−
1397−{-# INLINE traceInvalidateHeight #-}
1398−traceInvalidateHeight :: String -> IO ()
1399−traceInvalidateHeight = when debugInvalidateHeight . liftIO . debugStrLn
1400−
1401−{-# INLINE trace #-}
1402−trace :: (CanTrace x m) => proxy x -> String -> m ()
1403−trace p message = traceM p $ return message
1404−
1405−{-# INLINE traceM #-}
1406−traceM :: forall x proxy m. (CanTrace x m) => proxy x -> m String -> m ()
1407−traceM _ getMessage = do
1408− message <- getMessage
1409− d <- liftIO $ readIORef $ _spiderTimeline_depth $ unSTE (spiderTimeline :: SpiderTimelineEnv x)
1410− liftIO $ debugStrLn $ replicate d ' ' <> message
1411−
1412#else
1339#else
1340+withIncreasedDepth :: m a -> m a
1341+withIncreasedDepth = id
1342+#endif
1413
1343
1414−{-# INLINE withIncreasedDepth #-}
1344+type CanTrace x m = (HasSpiderTimeline x, MonadIO m)
1415−withIncreasedDepth :: proxy x -> m a -> m a
1416−withIncreasedDepth _ = id
1417
1345
1418{-# INLINE tracePropagate #-}
1346{-# INLINE tracePropagate #-}
1419tracePropagate :: (CanTrace x m) => proxy x -> String -> m ()
1347tracePropagate :: (CanTrace x m) => proxy x -> String -> m ()
1420−tracePropagate _ _ = return ()
1348+tracePropagate p = traceWhen p debugPropagate
1421
1349
1422{-# INLINE traceInvalidate #-}
1350{-# INLINE traceInvalidate #-}
1423traceInvalidate :: String -> IO ()
1351traceInvalidate :: String -> IO ()
1424−traceInvalidate _ = return ()
1352+traceInvalidate = when debugInvalidate . liftIO . putStrLn
1425−
1426−{-# INLINE traceInvalidateHeight #-}
1427−traceInvalidateHeight :: String -> IO ()
1428−traceInvalidateHeight _ = return ()
1429−
1430−{-# INLINE debugSubscriber #-}
1431−debugSubscriber :: String -> Subscriber x a -> IO (Subscriber x a)
1432−debugSubscriber _ = return
1433−
1434−{-# INLINE debugSubscriber' #-}
1435−debugSubscriber' :: String -> Subscriber x a -> Subscriber x a
1436−debugSubscriber' _ = id
1437
1353
1354+{-# INLINE traceWhen #-}
1355+traceWhen :: (CanTrace x m) => proxy x -> Bool -> String -> m ()
1356+traceWhen p b message = traceMWhen p b $ return message
1438
1357
1439−
1440−{-# INLINE trace #-}
1358+{-# INLINE traceMWhen #-}
1441−trace :: (CanTrace x m) => proxy x -> String -> m ()
1359+traceMWhen :: (CanTrace x m) => proxy x -> Bool -> m String -> m ()
1442−trace _ _ = return ()
1360+traceMWhen _ b getMessage = when b $ do
1443−
1361+ message <- getMessage
1444−{-# INLINE traceM #-}
1362+#ifdef DEBUG
1445−traceM :: (CanTrace x m) => proxy x -> m String -> m ()
1363+ spiderTimeline <- askSpiderTimelineEnv
1446−traceM _ _ = return ()
1364+ d <- liftIO $ readIORef $ _spiderTimeline_depth $ unSTE spiderTimeline
1447−
1365+#else
1366+ let d = 0
1448#endif
1367#endif
1368+ liftIO $ putStrLn $ replicate d ' ' <> message
1449
1369
1450whoCreatedIORef :: IORef a -> IO [String]
1370whoCreatedIORef :: IORef a -> IO [String]
1451whoCreatedIORef (IORef a) = whoCreated $! a
1371whoCreatedIORef (IORef a) = whoCreated $! a
1452
1372
1373+#ifdef DEBUG_CYCLES
1453groupByHead :: Eq a => [NonEmpty a] -> [(a, NonEmpty [a])]
1374groupByHead :: Eq a => [NonEmpty a] -> [(a, NonEmpty [a])]
1454groupByHead = \case
1375groupByHead = \case
1455 [] -> []
1376 [] -> []
@@ -1460,54 +1381,20 @@ groupByHead = \case
1460 | otherwise -> (x, xs :| []) : l
1381 | otherwise -> (x, xs :| []) : l
1461
1382
1462listsToForest :: Eq a => [[a]] -> Forest a
1383listsToForest :: Eq a => [[a]] -> Forest a
1463−listsToForest lists = buildForest <$> groupByHead (mapMaybe nonEmpty lists)
1384+listsToForest l = fmap (\(a, l') -> Node a $ listsToForest $ toList l') $ groupByHead $ catMaybes $ fmap nonEmpty l
1464− where buildForest (a, lists') = Node a $ listsToForest $ toList lists'
1465−
1466−showStacks :: [[String]] -> String
1467−showStacks = drawForest . listsToForest . fmap (filterStack "Reflex.Spider.Internal")
1468−
1469−filterStack :: String -> [String] -> [String]
1470−#ifdef DEBUG_HIDE_INTERNALS
1471−filterStack prefix = filter (not . (prefix `isPrefixOf`))
1472−#else
1473−filterStack prefix = id
1474−#endif
1475−
1476−#ifdef DEBUG_CYCLES
1477−
1478−data EventLoopException = EventLoopException [[String]]
1479−instance Exception EventLoopException
1480−
1481−instance Show EventLoopException where
1482− show (EventLoopException stacks) = "causality loop detected:\n" <> if null stacks
1483− then "no location information, compile with profiling enabled for stack tree"
1484− else showStacks stacks
1485−
1486−#else
1487−
1488−data EventLoopException = EventLoopException
1489−instance Exception EventLoopException
1490−
1491−instance Show EventLoopException where
1492− show EventLoopException = "causality loop detected: \n" <>
1493− "compile reflex with flag 'debug-cycles' and compile with profiling enabled for stack tree"
1494−
1495#endif
1385#endif
1496
1386
1497−
1498{-# INLINE propagateSubscriberHold #-}
1387{-# INLINE propagateSubscriberHold #-}
1499propagateSubscriberHold :: forall x p. (HasSpiderTimeline x, Patch p) => Hold x p -> p -> EventM x ()
1388propagateSubscriberHold :: forall x p. (HasSpiderTimeline x, Patch p) => Hold x p -> p -> EventM x ()
1500propagateSubscriberHold h a = do
1389propagateSubscriberHold h a = do
1501− {-# SCC "trace" #-} when debugPropagate $ traceM (Proxy :: Proxy x) $ liftIO $ do
1390+ {-# SCC "trace" #-} traceMWhen (Proxy :: Proxy x) debugPropagate $ liftIO $ do
1502 invalidators <- liftIO $ readIORef $ holdInvalidators h
1391 invalidators <- liftIO $ readIORef $ holdInvalidators h
1503 return $ "SubscriberHold" <> showNodeId h <> ": " ++ show (length invalidators)
1392 return $ "SubscriberHold" <> showNodeId h <> ": " ++ show (length invalidators)
1504−
1505 v <- {-# SCC "read" #-} liftIO $ readIORef $ holdValue h
1393 v <- {-# SCC "read" #-} liftIO $ readIORef $ holdValue h
1506 case {-# SCC "apply" #-} apply a v of
1394 case {-# SCC "apply" #-} apply a v of
1507 Nothing -> return ()
1395 Nothing -> return ()
1508 Just v' -> do
1396 Just v' -> do
1509− {-# SCC "trace2" #-} withIncreasedDepth (Proxy :: Proxy x) $
1510− tracePropagate (Proxy :: Proxy x) ("propagateSubscriberHold: assigning Hold" <> showNodeId h)
1397+ {-# SCC "trace2" #-} withIncreasedDepth $ tracePropagate (Proxy :: Proxy x) $ "propagateSubscriberHold: assigning Hold" <> showNodeId h
1511 vRef <- {-# SCC "vRef" #-} liftIO $ evaluate $ holdValue h
1398 vRef <- {-# SCC "vRef" #-} liftIO $ evaluate $ holdValue h
1512 iRef <- {-# SCC "iRef" #-} liftIO $ evaluate $ holdInvalidators h
1399 iRef <- {-# SCC "iRef" #-} liftIO $ evaluate $ holdInvalidators h
1513 defer $ {-# SCC "assignment" #-} SomeAssignment vRef iRef v'
1400 defer $ {-# SCC "assignment" #-} SomeAssignment vRef iRef v'
@@ -1561,7 +1448,7 @@ getDynHold d = do
1561zeroRef :: IORef Height
1448zeroRef :: IORef Height
1562zeroRef = unsafePerformIO $ newIORef zeroHeight
1449zeroRef = unsafePerformIO $ newIORef zeroHeight
1563
1450
1564−getRootSubscribed :: forall k x a. (GCompare k, HasSpiderTimeline x) => k a -> Root x k -> Subscriber x a -> IO (WeakBagTicket, RootSubscribed x a, Maybe a)
1451+getRootSubscribed :: GCompare k => k a -> Root x k -> Subscriber x a -> IO (WeakBagTicket, RootSubscribed x a, Maybe a)
1565getRootSubscribed k r sub = do
1452getRootSubscribed k r sub = do
1566 mSubscribed <- readIORef $ rootSubscribed r
1453 mSubscribed <- readIORef $ rootSubscribed r
1567 let getOcc = fmap (coerce . DMap.lookup k) $ readIORef $ rootOccurrence r
1454 let getOcc = fmap (coerce . DMap.lookup k) $ readIORef $ rootOccurrence r
@@ -1575,9 +1462,7 @@ getRootSubscribed k r sub = do
1575 let !cached = rootSubscribed r
1462 let !cached = rootSubscribed r
1576 uninitRef <- newIORef $ error "getRootsubscribed: uninitRef not initialized"
1463 uninitRef <- newIORef $ error "getRootsubscribed: uninitRef not initialized"
1577 (subs, sln) <- WeakBag.singleton sub weakSelf cleanupRootSubscribed
1464 (subs, sln) <- WeakBag.singleton sub weakSelf cleanupRootSubscribed
1578−
1579− tracePropagate (Proxy::Proxy x) $ "getRootSubscribed: calling rootInit"
1465+ when debugPropagate $ putStrLn $ "getRootSubscribed: calling rootInit"
1580−
1581 uninit <- rootInit r k $ RootTrigger (subs, rootOccurrence r, k)
1466 uninit <- rootInit r k $ RootTrigger (subs, rootOccurrence r, k)
1582 writeIORef uninitRef $! uninit
1467 writeIORef uninitRef $! uninit
1583#ifdef DEBUG_NODEIDS
1468#ifdef DEBUG_NODEIDS
@@ -1627,9 +1512,6 @@ data FanInt x a = FanInt
1627 { _fanInt_subscribers :: {-# UNPACK #-} !(FastMutableIntMap (FastWeakBag (Subscriber x a))) --TODO: Clean up the keys in here when their child weak bags get empty --TODO: Remove our own subscription when the subscribers list is completely empty
1512 { _fanInt_subscribers :: {-# UNPACK #-} !(FastMutableIntMap (FastWeakBag (Subscriber x a))) --TODO: Clean up the keys in here when their child weak bags get empty --TODO: Remove our own subscription when the subscribers list is completely empty
1628 , _fanInt_subscriptionRef :: {-# UNPACK #-} !(IORef (EventSubscription x)) -- This should have a valid subscription iff subscribers is non-empty
1513 , _fanInt_subscriptionRef :: {-# UNPACK #-} !(IORef (EventSubscription x)) -- This should have a valid subscription iff subscribers is non-empty
1629 , _fanInt_occRef :: {-# UNPACK #-} !(IORef (IntMap a))
1514 , _fanInt_occRef :: {-# UNPACK #-} !(IORef (IntMap a))
1630−#ifdef DEBUG_NODEIDS
1631− , _fanInt_nodeId :: {-# UNPACK #-} !Int
1632−#endif
1633 }
1515 }
1634
1516
1635newFanInt :: IO (FanInt x a)
1517newFanInt :: IO (FanInt x a)
@@ -1637,16 +1519,10 @@ newFanInt = do
1637 subscribers <- FastMutableIntMap.newEmpty --TODO: Clean up the keys in here when their child weak bags get empty --TODO: Remove our own subscription when the subscribers list is completely empty
1519 subscribers <- FastMutableIntMap.newEmpty --TODO: Clean up the keys in here when their child weak bags get empty --TODO: Remove our own subscription when the subscribers list is completely empty
1638 subscriptionRef <- newIORef $ error "fanInt: no subscription"
1520 subscriptionRef <- newIORef $ error "fanInt: no subscription"
1639 occRef <- newIORef $ error "fanInt: no occurrence"
1521 occRef <- newIORef $ error "fanInt: no occurrence"
1640−#ifdef DEBUG_NODEIDS
1641− nodeId <- newNodeId
1642−#endif
1643 return $ FanInt
1522 return $ FanInt
1644 { _fanInt_subscribers = subscribers
1523 { _fanInt_subscribers = subscribers
1645 , _fanInt_subscriptionRef = subscriptionRef
1524 , _fanInt_subscriptionRef = subscriptionRef
1646 , _fanInt_occRef = occRef
1525 , _fanInt_occRef = occRef
1647−#ifdef DEBUG_NODEIDS
1648− , _fanInt_nodeId = nodeId
1649−#endif
1650 }
1526 }
1651
1527
1652fanInt :: HasSpiderTimeline x => Event x (IntMap a) -> EventSelectorInt x a
1528fanInt :: HasSpiderTimeline x => Event x (IntMap a) -> EventSelectorInt x a
@@ -1655,21 +1531,20 @@ fanInt p = unsafePerformIO $ do
1655 pure $ EventSelectorInt $ \k -> Event $ \sub -> do
1531 pure $ EventSelectorInt $ \k -> Event $ \sub -> do
1656 isEmpty <- liftIO $ FastMutableIntMap.isEmpty (_fanInt_subscribers self)
1532 isEmpty <- liftIO $ FastMutableIntMap.isEmpty (_fanInt_subscribers self)
1657 when isEmpty $ do -- This is the first subscriber, so we need to subscribe to our input
1533 when isEmpty $ do -- This is the first subscriber, so we need to subscribe to our input
1658− let desc = "fanInt" <> showNodeId self <> ", k = " <> show k
1659− (subscription, parentOcc) <- subscribeAndRead p $ debugSubscriber' desc $ Subscriber
1534+ (subscription, parentOcc) <- subscribeAndRead p $ Subscriber
1660 { subscriberPropagate = \m -> do
1535 { subscriberPropagate = \m -> do
1661 liftIO $ writeIORef (_fanInt_occRef self) m
1536 liftIO $ writeIORef (_fanInt_occRef self) m
1662 scheduleIntClear $ _fanInt_occRef self
1537 scheduleIntClear $ _fanInt_occRef self
1663− FastMutableIntMap.forIntersectionWithImmutable_ (_fanInt_subscribers self) m $ \b v -> --TODO: Do we need to know that no subscribers are being added as we traverse?
1538+ FastMutableIntMap.forIntersectionWithImmutable_ (_fanInt_subscribers self) m $ \b v -> do --TODO: Do we need to know that no subscribers are being added as we traverse?
1664− FastWeakBag.traverse_ b $ \s ->
1539+ FastWeakBag.traverse_ b $ \s -> do
1665 subscriberPropagate s v
1540 subscriberPropagate s v
1666− , subscriberInvalidateHeight = \old ->
1541+ , subscriberInvalidateHeight = \old -> do
1667− FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b ->
1542+ FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b -> do
1668− FastWeakBag.traverse_ b $ \s ->
1543+ FastWeakBag.traverse_ b $ \s -> do
1669 subscriberInvalidateHeight s old
1544 subscriberInvalidateHeight s old
1670− , subscriberRecalculateHeight = \new ->
1545+ , subscriberRecalculateHeight = \new -> do
1671− FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b ->
1546+ FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b -> do
1672− FastWeakBag.traverse_ b $ \s ->
1547+ FastWeakBag.traverse_ b $ \s -> do
1673 subscriberRecalculateHeight s new
1548 subscriberRecalculateHeight s new
1674 }
1549 }
1675 liftIO $ do
1550 liftIO $ do
@@ -1683,25 +1558,10 @@ fanInt p = unsafePerformIO $ do
1683 FastMutableIntMap.insert (_fanInt_subscribers self) k b
1558 FastMutableIntMap.insert (_fanInt_subscribers self) k b
1684 return b
1559 return b
1685 Just b -> return b
1560 Just b -> return b
1686− ticket <- liftIO $ FastWeakBag.insert sub b
1561+ t <- liftIO $ FastWeakBag.insert sub b
1687 currentOcc <- readIORef (_fanInt_occRef self)
1562 currentOcc <- readIORef (_fanInt_occRef self)
1688−
1563+ (EventSubscription _ (EventSubscribed !heightRef _)) <- readIORef (_fanInt_subscriptionRef self)
1689− subscribed <- fanIntSubscribed ticket self
1690− return (EventSubscription (FastWeakBag.remove ticket) subscribed, IntMap.lookup k currentOcc)
1564+ return (EventSubscription (FastWeakBag.remove t) $! EventSubscribed heightRef $! toAny (_fanInt_subscriptionRef self, t), IntMap.lookup k currentOcc)
1691−
1692−fanIntSubscribed :: FastWeakBagTicket k -> FanInt x a -> IO (EventSubscribed x)
1693−fanIntSubscribed ticket self = do
1694− subscribedParent <- _eventSubscription_subscribed <$> readIORef (_fanInt_subscriptionRef self)
1695− return $ EventSubscribed
1696− { eventSubscribedHeightRef = eventSubscribedHeightRef subscribedParent
1697− , eventSubscribedRetained = toAny (_fanInt_subscriptionRef self, ticket)
1698−#ifdef DEBUG_CYCLES
1699− , eventSubscribedGetParents = return [subscribedParent]
1700− , eventSubscribedHasOwnHeightRef = False
1701− , eventSubscribedWhoCreated = whoCreatedIORef $ _fanInt_subscriptionRef self
1702−#endif
1703− }
1704−
1705
1565
1706{-# INLINABLE getFanSubscribed #-}
1566{-# INLINABLE getFanSubscribed #-}
1707getFanSubscribed :: (HasSpiderTimeline x, GCompare k) => k a -> Fan x k v -> Subscriber x (v a) -> EventM x (WeakBagTicket, FanSubscribed x k v, Maybe (v a))
1567getFanSubscribed :: (HasSpiderTimeline x, GCompare k) => k a -> Fan x k v -> Subscriber x (v a) -> EventM x (WeakBagTicket, FanSubscribed x k v, Maybe (v a))
@@ -1899,7 +1759,7 @@ mergeCheap
1899 => (forall a. q a -> Event x (v a))
1759 => (forall a. q a -> Event x (v a))
1900 -> DynamicS x (PatchDMap k q)
1760 -> DynamicS x (PatchDMap k q)
1901 -> Event x (DMap k v)
1761 -> Event x (DMap k v)
1902−mergeCheap nt = mergeGCheap' unMergeSubscribedParent getInitialSubscribers updateMe destroy
1762+mergeCheap nt = mergeGCheap' getInitialSubscribers updateMe destroy
1903 where
1763 where
1904 updateMe :: MergeUpdateFunc k v x (PatchDMap k q) (MergeSubscribedParent x)
1764 updateMe :: MergeUpdateFunc k v x (PatchDMap k q) (MergeSubscribedParent x)
1905 updateMe subscriber heightBagRef oldParents (PatchDMap p) = do
1765 updateMe subscriber heightBagRef oldParents (PatchDMap p) = do
@@ -1914,9 +1774,7 @@ mergeCheap nt = mergeGCheap' unMergeSubscribedParent getInitialSubscribers updat
1914 liftIO $ modifyIORef' heightBagRef $ heightBagAdd newParentHeight
1774 liftIO $ modifyIORef' heightBagRef $ heightBagAdd newParentHeight
1915 return $ DMap.insertLookupWithKey' (\_ new _ -> new) k newParent ps
1775 return $ DMap.insertLookupWithKey' (\_ new _ -> new) k newParent ps
1916 forM_ mOldSubd $ \oldSubd -> do
1776 forM_ mOldSubd $ \oldSubd -> do
1917− oldHeight <- liftIO $ getEventSubscribedHeight $
1918− _eventSubscription_subscribed $ unMergeSubscribedParent oldSubd
1777+ oldHeight <- liftIO $ getEventSubscribedHeight $ _eventSubscription_subscribed $ unMergeSubscribedParent oldSubd
1919−
1920 liftIO $ modifyIORef heightBagRef $ heightBagRemove oldHeight
1778 liftIO $ modifyIORef heightBagRef $ heightBagRemove oldHeight
1921 return (maybeToList (unMergeSubscribedParent <$> mOldSubd) ++ subscriptionsToKill, newPs)
1779 return (maybeToList (unMergeSubscribedParent <$> mOldSubd) ++ subscriptionsToKill, newPs)
1922 foldM f ([], oldParents) $ DMap.toList p
1780 foldM f ([], oldParents) $ DMap.toList p
@@ -1941,7 +1799,7 @@ mergeCheapWithMove :: forall k x v q. (HasSpiderTimeline x, GCompare k)
1941 => (forall a. q a -> Event x (v a))
1799 => (forall a. q a -> Event x (v a))
1942 -> DynamicS x (PatchDMapWithMove k q)
1800 -> DynamicS x (PatchDMapWithMove k q)
1943 -> Event x (DMap k v)
1801 -> Event x (DMap k v)
1944−mergeCheapWithMove nt = mergeGCheap' _mergeSubscribedParentWithMove_subscription getInitialSubscribers updateMe destroy
1802+mergeCheapWithMove nt = mergeGCheap' getInitialSubscribers updateMe destroy
1945 where
1803 where
1946 updateMe :: MergeUpdateFunc k v x (PatchDMapWithMove k q) (MergeSubscribedParentWithMove x k)
1804 updateMe :: MergeUpdateFunc k v x (PatchDMapWithMove k q) (MergeSubscribedParentWithMove x k)
1947 updateMe subscriber heightBagRef oldParents p = do
1805 updateMe subscriber heightBagRef oldParents p = do
@@ -1960,17 +1818,13 @@ mergeCheapWithMove nt = mergeGCheap' _mergeSubscribedParentWithMove_subscription
1960 let moveOrDelete :: forall a. k a -> PatchDMapWithMove.NodeInfo k q a -> MergeSubscribedParentWithMove x k a -> Constant (EventM x (Maybe (EventSubscription x))) a
1818 let moveOrDelete :: forall a. k a -> PatchDMapWithMove.NodeInfo k q a -> MergeSubscribedParentWithMove x k a -> Constant (EventM x (Maybe (EventSubscription x))) a
1961 moveOrDelete _ ni parent = Constant $ case getComposeMaybe $ PatchDMapWithMove._nodeInfo_to ni of
1819 moveOrDelete _ ni parent = Constant $ case getComposeMaybe $ PatchDMapWithMove._nodeInfo_to ni of
1962 Nothing -> do
1820 Nothing -> do
1963− oldHeight <- liftIO $ getEventSubscribedHeight $ _eventSubscription_subscribed $
1821+ oldHeight <- liftIO $ getEventSubscribedHeight $ _eventSubscription_subscribed $ _mergeSubscribedParentWithMove_subscription parent
1964− _mergeSubscribedParentWithMove_subscription parent
1965−
1966 liftIO $ modifyIORef heightBagRef $ heightBagRemove oldHeight
1822 liftIO $ modifyIORef heightBagRef $ heightBagRemove oldHeight
1967 return $ Just $ _mergeSubscribedParentWithMove_subscription parent
1823 return $ Just $ _mergeSubscribedParentWithMove_subscription parent
1968 Just toKey -> do
1824 Just toKey -> do
1969 liftIO $ writeIORef (_mergeSubscribedParentWithMove_key parent) $! toKey
1825 liftIO $ writeIORef (_mergeSubscribedParentWithMove_key parent) $! toKey
1970 return Nothing
1826 return Nothing
1971− toDelete <- fmap catMaybes $ mapM (\(_ :=> v) -> getConstant v) $ DMap.toList $
1972− DMap.intersectionWithKey moveOrDelete (unPatchDMapWithMove p) oldParents
1827+ toDelete <- fmap catMaybes $ mapM (\(_ :=> v) -> getConstant v) $ DMap.toList $ DMap.intersectionWithKey moveOrDelete (unPatchDMapWithMove p) oldParents
1973−
1974 return (toDelete, applyAlways p' oldParents)
1828 return (toDelete, applyAlways p' oldParents)
1975 getInitialSubscribers :: MergeInitFunc k v q x (MergeSubscribedParentWithMove x k)
1829 getInitialSubscribers :: MergeInitFunc k v q x (MergeSubscribedParentWithMove x k)
1976 getInitialSubscribers initialParents subscriber = do
1830 getInitialSubscribers initialParents subscriber = do
@@ -1995,8 +1849,6 @@ type MergeUpdateFunc k v x p s
1995 -> p
1849 -> p
1996 -> EventM x ([EventSubscription x], DMap k s)
1850 -> EventM x ([EventSubscription x], DMap k s)
1997
1851
1998−type MergeGetSubscription x s = forall a. s a -> EventSubscription x
1999−
2000type MergeInitFunc k v q x s
1852type MergeInitFunc k v q x s
2001 = DMap k q
1853 = DMap k q
2002 -> (forall a. EventM x (k a) -> Subscriber x (v a))
1854 -> (forall a. EventM x (k a) -> Subscriber x (v a))
@@ -2020,17 +1872,14 @@ invalidateMergeHeight m = invalidateMergeHeight' (_merge_heightRef m) (_merge_su
2020invalidateMergeHeight' :: IORef Height -> Subscriber x a -> IO ()
1872invalidateMergeHeight' :: IORef Height -> Subscriber x a -> IO ()
2021invalidateMergeHeight' heightRef sub = do
1873invalidateMergeHeight' heightRef sub = do
2022 oldHeight <- readIORef heightRef
1874 oldHeight <- readIORef heightRef
2023− -- If the height used to be valid, it must be invalid now; we should never have *more* heights than we have parents
1875+ when (oldHeight /= invalidHeight) $ do -- If the height used to be valid, it must be invalid now; we should never have *more* heights than we have parents
2024− when (oldHeight /= invalidHeight) $ do
2025 writeIORef heightRef $! invalidHeight
1876 writeIORef heightRef $! invalidHeight
2026 subscriberInvalidateHeight sub oldHeight
1877 subscriberInvalidateHeight sub oldHeight
2027
1878
2028revalidateMergeHeight :: Merge x k v s -> IO ()
1879revalidateMergeHeight :: Merge x k v s -> IO ()
2029revalidateMergeHeight m = do
1880revalidateMergeHeight m = do
2030 currentHeight <- readIORef $ _merge_heightRef m
1881 currentHeight <- readIORef $ _merge_heightRef m
2031−
2032− -- revalidateMergeHeight may be called multiple times; perhaps the's a way to finesse it to avoid this check
1882+ when (currentHeight == invalidHeight) $ do -- revalidateMergeHeight may be called multiple times; perhaps the's a way to finesse it to avoid this check
2033− when (currentHeight == invalidHeight) $ do
2034 heights <- readIORef $ _merge_heightBagRef m
1883 heights <- readIORef $ _merge_heightBagRef m
2035 parents <- readIORef $ _merge_parentsRef m
1884 parents <- readIORef $ _merge_parentsRef m
2036 -- When the number of heights in the bag reaches the number of parents, we should have a valid height
1885 -- When the number of heights in the bag reaches the number of parents, we should have a valid height
@@ -2038,7 +1887,7 @@ revalidateMergeHeight m = do
2038 LT -> return ()
1887 LT -> return ()
2039 EQ -> do
1888 EQ -> do
2040 let height = succHeight $ heightBagMax heights
1889 let height = succHeight $ heightBagMax heights
2041− traceInvalidateHeight $ "recalculateSubscriberHeight: height: " <> show height
1890+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: height: " <> show height
2042 writeIORef (_merge_heightRef m) $! height
1891 writeIORef (_merge_heightRef m) $! height
2043 subscriberRecalculateHeight (_merge_sub m) height
1892 subscriberRecalculateHeight (_merge_sub m) height
2044 GT -> error $ "revalidateMergeHeight: more heights (" <> show (heightBagSize heights) <> ") than parents (" <> show (DMap.size parents) <> ") for Merge"
1893 GT -> error $ "revalidateMergeHeight: more heights (" <> show (heightBagSize heights) <> ") than parents (" <> show (DMap.size parents) <> ") for Merge"
@@ -2046,45 +1895,36 @@ revalidateMergeHeight m = do
2046scheduleMergeSelf :: HasSpiderTimeline x => Merge x k v s -> Height -> EventM x ()
1895scheduleMergeSelf :: HasSpiderTimeline x => Merge x k v s -> Height -> EventM x ()
2047scheduleMergeSelf m height = scheduleMerge' height (_merge_heightRef m) $ do
1896scheduleMergeSelf m height = scheduleMerge' height (_merge_heightRef m) $ do
2048 vals <- liftIO $ readIORef $ _merge_accumRef m
1897 vals <- liftIO $ readIORef $ _merge_accumRef m
2049− -- Once we're done with this, we can clear it immediately, because if there's a cacheEvent in front of us,
1898+ liftIO $ writeIORef (_merge_accumRef m) $! DMap.empty -- Once we're done with this, we can clear it immediately, because if there's a cacheEvent in front of us, it'll handle subsequent subscribers, and if not, we won't get subsequent subscribers
2050− -- it'll handle subsequent subscribers, and if not, we won't get subsequent subscribers
2051− liftIO $ writeIORef (_merge_accumRef m) $! DMap.empty
2052 --TODO: Assert that m is not empty
1899 --TODO: Assert that m is not empty
2053 subscriberPropagate (_merge_sub m) vals
1900 subscriberPropagate (_merge_sub m) vals
2054
1901
2055−checkCycle :: HasSpiderTimeline x => EventSubscribed x -> EventM x ()
2056−checkCycle subscribed = liftIO $ do
2057− height <- readIORef (eventSubscribedHeightRef subscribed)
2058−
2059− -- currentHeight <- getCurrentHeight
2060− -- when (height <= currentHeight) $ if height /= invalidHeight
2061− -- then do
2062− -- myStack <- liftIO $ whoCreatedIORef undefined --TODO
2063− -- error $ "Height (" ++ show height ++ ") is not greater than current height (" ++ show currentHeight ++ ")\n" ++ unlines (reverse myStack)
2064− -- else liftIO $
2065− when (height == invalidHeight) $
2066−#ifdef DEBUG_CYCLES
2067− do
2068− nodesInvolvedInCycle <- walkInvalidHeightParents subscribed
2069− stacks <- forM nodesInvolvedInCycle whoCreatedEventSubscribed
2070− throwIO (EventLoopException stacks)
2071−#else
2072− throwIO EventLoopException
2073−#endif
2074−
2075−
2076−mergeSubscriber :: forall x k v s a. (HasSpiderTimeline x, GCompare k) => EventSubscribed x -> Merge x k v s -> EventM x (k a) -> Subscriber x (v a)
1902+mergeSubscriber :: forall x k v s a. (HasSpiderTimeline x, GCompare k) => Merge x k v s -> EventM x (k a) -> Subscriber x (v a)
2077−mergeSubscriber subscribed m getKey = Subscriber
1903+mergeSubscriber m getKey = Subscriber
2078 { subscriberPropagate = \a -> do
1904 { subscriberPropagate = \a -> do
2079 oldM <- liftIO $ readIORef $ _merge_accumRef m
1905 oldM <- liftIO $ readIORef $ _merge_accumRef m
2080 k <- getKey
1906 k <- getKey
2081− let newM = DMap.insertWith (error "Same key fired multiple times for Merge") k a oldM
1907+ let newM = DMap.insertWith (error $ "Same key fired multiple times for Merge") k a oldM
2082 tracePropagate (Proxy :: Proxy x) $ " DMap.size oldM = " <> show (DMap.size oldM) <> "; DMap.size newM = " <> show (DMap.size newM)
1908 tracePropagate (Proxy :: Proxy x) $ " DMap.size oldM = " <> show (DMap.size oldM) <> "; DMap.size newM = " <> show (DMap.size newM)
2083 liftIO $ writeIORef (_merge_accumRef m) $! newM
1909 liftIO $ writeIORef (_merge_accumRef m) $! newM
2084 when (DMap.null oldM) $ do -- Only schedule the firing once
1910 when (DMap.null oldM) $ do -- Only schedule the firing once
2085 height <- liftIO $ readIORef $ _merge_heightRef m
1911 height <- liftIO $ readIORef $ _merge_heightRef m
2086− checkCycle subscribed
1912+ --TODO: assertions about height
2087−
1913+ currentHeight <- getCurrentHeight
1914+ when (height <= currentHeight) $ do
1915+ if height /= invalidHeight
1916+ then do
1917+ myStack <- liftIO $ whoCreatedIORef undefined --TODO
1918+ error $ "Height (" ++ show height ++ ") is not greater than current height (" ++ show currentHeight ++ ")\n" ++ unlines (reverse myStack)
1919+ else liftIO $ do
1920+#ifdef DEBUG_CYCLES
1921+ nodesInvolvedInCycle <- walkInvalidHeightParents $ eventSubscribedMerge subscribed
1922+ stacks <- forM nodesInvolvedInCycle $ \(Some es) -> whoCreatedEventSubscribed es
1923+ let cycleInfo = ":\n" <> drawForest (listsToForest stacks)
1924+#else
1925+ let cycleInfo = ""
1926+#endif
1927+ error $ "Causality loop found" <> cycleInfo
2088 scheduleMergeSelf m height
1928 scheduleMergeSelf m height
2089 , subscriberInvalidateHeight = \old -> do --TODO: When removing a parent doesn't actually change the height, maybe we can avoid invalidating
1929 , subscriberInvalidateHeight = \old -> do --TODO: When removing a parent doesn't actually change the height, maybe we can avoid invalidating
2090 modifyIORef' (_merge_heightBagRef m) $ heightBagRemove old
1930 modifyIORef' (_merge_heightBagRef m) $ heightBagRemove old
@@ -2095,45 +1935,31 @@ mergeSubscriber subscribed m getKey = Subscriber
2095 }
1935 }
2096
1936
2097--TODO: Be able to run as much of this as possible promptly
1937--TODO: Be able to run as much of this as possible promptly
2098−updateMerge :: (HasSpiderTimeline x, GCompare k) => EventSubscribed x -> Merge x k v s -> MergeUpdateFunc k v x p s -> p -> SomeMergeUpdate x
1938+updateMerge :: (HasSpiderTimeline x, GCompare k) => Merge x k v s -> MergeUpdateFunc k v x p s -> p -> SomeMergeUpdate x
2099−updateMerge subscribed m updateFunc p = SomeMergeUpdate updateMe (invalidateMergeHeight m) (revalidateMergeHeight m)
1939+updateMerge m updateFunc p = SomeMergeUpdate updateMe (invalidateMergeHeight m) (revalidateMergeHeight m)
2100 where updateMe = do
1940 where updateMe = do
2101 oldParents <- liftIO $ readIORef $ _merge_parentsRef m
1941 oldParents <- liftIO $ readIORef $ _merge_parentsRef m
2102− (subscriptionsToKill, newParents) <- updateFunc (mergeSubscriber subscribed m) (_merge_heightBagRef m) oldParents p
1942+ (subscriptionsToKill, newParents) <- updateFunc (mergeSubscriber m) (_merge_heightBagRef m) oldParents p
2103 liftIO $ writeIORef (_merge_parentsRef m) $! newParents
1943 liftIO $ writeIORef (_merge_parentsRef m) $! newParents
2104 return subscriptionsToKill
1944 return subscriptionsToKill
2105
1945
2106{-# INLINE mergeGCheap' #-}
1946{-# INLINE mergeGCheap' #-}
2107mergeGCheap' :: forall k v x p s q. (HasSpiderTimeline x, GCompare k, PatchTarget p ~ DMap k q)
1947mergeGCheap' :: forall k v x p s q. (HasSpiderTimeline x, GCompare k, PatchTarget p ~ DMap k q)
2108− => MergeGetSubscription x s -> MergeInitFunc k v q x s -> MergeUpdateFunc k v x p s -> MergeDestroyFunc k s -> DynamicS x p -> Event x (DMap k v)
1948+ => MergeInitFunc k v q x s -> MergeUpdateFunc k v x p s -> MergeDestroyFunc k s -> DynamicS x p -> Event x (DMap k v)
2109−mergeGCheap' getParent getInitialSubscribers updateFunc destroy d = Event $ \sub -> do
1949+mergeGCheap' getInitialSubscribers updateFunc destroy d = Event $ \sub -> do
2110 initialParents <- readBehaviorUntracked $ dynamicCurrent d
1950 initialParents <- readBehaviorUntracked $ dynamicCurrent d
2111 accumRef <- liftIO $ newIORef $ error "merge: accumRef not yet initialized"
1951 accumRef <- liftIO $ newIORef $ error "merge: accumRef not yet initialized"
2112 heightRef <- liftIO $ newIORef $ error "merge: heightRef not yet initialized"
1952 heightRef <- liftIO $ newIORef $ error "merge: heightRef not yet initialized"
2113 heightBagRef <- liftIO $ newIORef $ error "merge: heightBagRef not yet initialized"
1953 heightBagRef <- liftIO $ newIORef $ error "merge: heightBagRef not yet initialized"
2114 parentsRef :: IORef (DMap k s) <- liftIO $ newIORef $ error "merge: parentsRef not yet initialized"
1954 parentsRef :: IORef (DMap k s) <- liftIO $ newIORef $ error "merge: parentsRef not yet initialized"
2115− changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
2116−
2117− let subscribed = EventSubscribed
2118− { eventSubscribedHeightRef = heightRef
2119− , eventSubscribedRetained = toAny (parentsRef, changeSubdRef)
2120−#ifdef DEBUG_CYCLES
2121− , eventSubscribedGetParents = do
2122− let getParent' (_ :=> v) = _eventSubscription_subscribed (getParent v)
2123− fmap getParent' . DMap.toList <$> readIORef parentsRef
2124− , eventSubscribedHasOwnHeightRef = False
2125− , eventSubscribedWhoCreated = whoCreatedIORef heightRef
2126−#endif
2127− }
2128−
2129− m = Merge
1955+ let m = Merge
2130 { _merge_parentsRef = parentsRef
1956 { _merge_parentsRef = parentsRef
2131 , _merge_heightBagRef = heightBagRef
1957 , _merge_heightBagRef = heightBagRef
2132 , _merge_heightRef = heightRef
1958 , _merge_heightRef = heightRef
2133 , _merge_sub = sub
1959 , _merge_sub = sub
2134 , _merge_accumRef = accumRef
1960 , _merge_accumRef = accumRef
2135 }
1961 }
2136− (dm, heights, initialParentState) <- getInitialSubscribers initialParents $ mergeSubscriber subscribed m
1962+ (dm, heights, initialParentState) <- getInitialSubscribers initialParents $ mergeSubscriber m
2137 let myHeightBag = heightBagFromList $ filter (/= invalidHeight) heights
1963 let myHeightBag = heightBagFromList $ filter (/= invalidHeight) heights
2138 myHeight = if invalidHeight `elem` heights
1964 myHeight = if invalidHeight `elem` heights
2139 then invalidHeight
1965 then invalidHeight
@@ -2142,29 +1968,31 @@ mergeGCheap' getParent getInitialSubscribers updateFunc destroy d = Event $ \sub
2142 let (occ, accum) = if currentHeight >= myHeight -- If we should have fired by now
1968 let (occ, accum) = if currentHeight >= myHeight -- If we should have fired by now
2143 then (if DMap.null dm then Nothing else Just dm, DMap.empty)
1969 then (if DMap.null dm then Nothing else Just dm, DMap.empty)
2144 else (Nothing, dm)
1970 else (Nothing, dm)
1971+ unless (DMap.null accum) $ do
2145− unless (DMap.null accum) $ scheduleMergeSelf m myHeight
1972+ scheduleMergeSelf m myHeight
2146 liftIO $ writeIORef accumRef $! accum
1973 liftIO $ writeIORef accumRef $! accum
2147 liftIO $ writeIORef heightRef $! myHeight
1974 liftIO $ writeIORef heightRef $! myHeight
2148 liftIO $ writeIORef heightBagRef $! myHeightBag
1975 liftIO $ writeIORef heightBagRef $! myHeightBag
1976+ changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
2149 liftIO $ writeIORef parentsRef $! initialParentState
1977 liftIO $ writeIORef parentsRef $! initialParentState
2150 defer $ SomeMergeInit $ do
1978 defer $ SomeMergeInit $ do
2151− let changeSubscriber = Subscriber
1979+ let s = Subscriber
2152 { subscriberPropagate = \a -> {-# SCC "traverseMergeChange" #-} do
1980 { subscriberPropagate = \a -> {-# SCC "traverseMergeChange" #-} do
2153− tracePropagate (Proxy :: Proxy x) "SubscriberMerge/Change"
1981+ tracePropagate (Proxy :: Proxy x) $ "SubscriberMerge/Change"
2154− defer $ updateMerge subscribed m updateFunc a
1982+ defer $ updateMerge m updateFunc a
2155 , subscriberInvalidateHeight = \_ -> return ()
1983 , subscriberInvalidateHeight = \_ -> return ()
2156 , subscriberRecalculateHeight = \_ -> return ()
1984 , subscriberRecalculateHeight = \_ -> return ()
2157 }
1985 }
2158− (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) changeSubscriber
1986+ (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) s
2159− forM_ change $ \c -> defer $ updateMerge subscribed m updateFunc c
1987+ forM_ change $ \c -> defer $ updateMerge m updateFunc c
2160 -- We explicitly hold on to the unsubscribe function from subscribing to the update event.
1988 -- We explicitly hold on to the unsubscribe function from subscribing to the update event.
2161 -- If we don't do this, there are certain cases where mergeCheap will fail to properly retain
1989 -- If we don't do this, there are certain cases where mergeCheap will fail to properly retain
2162 -- its subscription.
1990 -- its subscription.
2163− liftIO $ writeIORef changeSubdRef (changeSubscriber, changeSubscription)
1991+ liftIO $ writeIORef changeSubdRef (s, changeSubscription)
2164 let unsubscribeAll = destroy =<< readIORef parentsRef
1992 let unsubscribeAll = destroy =<< readIORef parentsRef
2165−
2166− return (EventSubscription unsubscribeAll subscribed, occ)
1993+ return ( EventSubscription unsubscribeAll $ EventSubscribed heightRef $ toAny (parentsRef, changeSubdRef)
2167−
1994+ , occ
1995+ )
2168
1996
2169mergeInt :: forall x a. (HasSpiderTimeline x) => DynamicS x (PatchIntMap (Event x a)) -> Event x (IntMap a)
1997mergeInt :: forall x a. (HasSpiderTimeline x) => DynamicS x (PatchIntMap (Event x a)) -> Event x (IntMap a)
2170mergeInt = cacheEvent . mergeIntCheap
1998mergeInt = cacheEvent . mergeIntCheap
@@ -2177,22 +2005,13 @@ mergeIntCheap d = Event $ \sub -> do
2177 heightRef <- liftIO $ newIORef zeroHeight
2005 heightRef <- liftIO $ newIORef zeroHeight
2178 heightBagRef <- liftIO $ newIORef heightBagEmpty
2006 heightBagRef <- liftIO $ newIORef heightBagEmpty
2179 parents <- liftIO $ FastMutableIntMap.newEmpty
2007 parents <- liftIO $ FastMutableIntMap.newEmpty
2180− changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
2181− let subscribed = EventSubscribed
2182− { eventSubscribedHeightRef = heightRef
2183− , eventSubscribedRetained = toAny (parents, changeSubdRef)
2184−#ifdef DEBUG_CYCLES
2185− , eventSubscribedGetParents = fmap (_eventSubscription_subscribed . snd) <$> FastMutableIntMap.toList parents
2186− , eventSubscribedHasOwnHeightRef = False
2187− , eventSubscribedWhoCreated = whoCreatedIORef heightRef
2188−#endif
2189− }
2190 let scheduleSelf = do
2008 let scheduleSelf = do
2191 height <- liftIO $ readIORef $ heightRef
2009 height <- liftIO $ readIORef $ heightRef
2192 scheduleMerge' height heightRef $ do
2010 scheduleMerge' height heightRef $ do
2193 vals <- liftIO $ FastMutableIntMap.getFrozenAndClear accum
2011 vals <- liftIO $ FastMutableIntMap.getFrozenAndClear accum
2194 subscriberPropagate sub vals
2012 subscriberPropagate sub vals
2013+ invalidateMyHeight = do
2195− invalidateMyHeight = invalidateMergeHeight' heightRef sub
2014+ invalidateMergeHeight' heightRef sub
2196 recalculateMyHeight = do
2015 recalculateMyHeight = do
2197 currentHeight <- readIORef heightRef
2016 currentHeight <- readIORef heightRef
2198 when (currentHeight == invalidHeight) $ do --TODO: This will almost always be true; can we get rid of this check and just proceed to the next one always?
2017 when (currentHeight == invalidHeight) $ do --TODO: This will almost always be true; can we get rid of this check and just proceed to the next one always?
@@ -2202,14 +2021,12 @@ mergeIntCheap d = Event $ \sub -> do
2202 LT -> return ()
2021 LT -> return ()
2203 EQ -> do
2022 EQ -> do
2204 let height = succHeight $ heightBagMax heights
2023 let height = succHeight $ heightBagMax heights
2205− traceInvalidateHeight $ "recalculateSubscriberHeight: height: " <> show height
2024+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: height: " <> show height
2206 writeIORef heightRef $! height
2025 writeIORef heightRef $! height
2207 subscriberRecalculateHeight sub height
2026 subscriberRecalculateHeight sub height
2208 GT -> error $ "revalidateMergeHeight: more heights (" <> show (heightBagSize heights) <> ") than parents (" <> show numParents <> ") for Merge"
2027 GT -> error $ "revalidateMergeHeight: more heights (" <> show (heightBagSize heights) <> ") than parents (" <> show numParents <> ") for Merge"
2209 mySubscriber k = Subscriber
2028 mySubscriber k = Subscriber
2210 { subscriberPropagate = \a -> do
2029 { subscriberPropagate = \a -> do
2211− checkCycle subscribed
2212−
2213 wasEmpty <- liftIO $ FastMutableIntMap.isEmpty accum
2030 wasEmpty <- liftIO $ FastMutableIntMap.isEmpty accum
2214 liftIO $ FastMutableIntMap.insert accum k a
2031 liftIO $ FastMutableIntMap.insert accum k a
2215 when wasEmpty scheduleSelf
2032 when wasEmpty scheduleSelf
@@ -2243,6 +2060,7 @@ mergeIntCheap d = Event $ \sub -> do
2243 else liftIO $ Just <$> FastMutableIntMap.getFrozenAndClear accum
2060 else liftIO $ Just <$> FastMutableIntMap.getFrozenAndClear accum
2244 else do when (not isEmpty) scheduleSelf -- We have things accumulated, but we shouldn't have fired them yet
2061 else do when (not isEmpty) scheduleSelf -- We have things accumulated, but we shouldn't have fired them yet
2245 return Nothing
2062 return Nothing
2063+ changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
2246 defer $ SomeMergeInit $ do
2064 defer $ SomeMergeInit $ do
2247 let updateMe a = SomeMergeUpdate u invalidateMyHeight recalculateMyHeight
2065 let updateMe a = SomeMergeUpdate u invalidateMyHeight recalculateMyHeight
2248 where
2066 where
@@ -2256,27 +2074,25 @@ mergeIntCheap d = Event $ \sub -> do
2256 oldParents <- liftIO $ FastMutableIntMap.applyPatch parents newSubscriptions
2074 oldParents <- liftIO $ FastMutableIntMap.applyPatch parents newSubscriptions
2257 liftIO $ for_ oldParents $ \oldParent -> do
2075 liftIO $ for_ oldParents $ \oldParent -> do
2258 oldParentHeight <- getEventSubscribedHeight $ _eventSubscription_subscribed oldParent
2076 oldParentHeight <- getEventSubscribedHeight $ _eventSubscription_subscribed oldParent
2259−
2260− print ("updateMe", oldParentHeight)
2261 modifyIORef' heightBagRef $ heightBagRemove oldParentHeight
2077 modifyIORef' heightBagRef $ heightBagRemove oldParentHeight
2262 return $ IntMap.elems oldParents
2078 return $ IntMap.elems oldParents
2263− let changeSubscriber = Subscriber
2079+ let s = Subscriber
2264 { subscriberPropagate = \a -> {-# SCC "traverseMergeChange" #-} do
2080 { subscriberPropagate = \a -> {-# SCC "traverseMergeChange" #-} do
2265 tracePropagate (Proxy :: Proxy x) $ "SubscriberMergeInt/Change"
2081 tracePropagate (Proxy :: Proxy x) $ "SubscriberMergeInt/Change"
2266 defer $ updateMe a
2082 defer $ updateMe a
2267 , subscriberInvalidateHeight = \_ -> return ()
2083 , subscriberInvalidateHeight = \_ -> return ()
2268 , subscriberRecalculateHeight = \_ -> return ()
2084 , subscriberRecalculateHeight = \_ -> return ()
2269 }
2085 }
2270− (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) changeSubscriber
2086+ (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) s
2271 forM_ change $ \c -> defer $ updateMe c
2087 forM_ change $ \c -> defer $ updateMe c
2272 -- We explicitly hold on to the unsubscribe function from subscribing to the update event.
2088 -- We explicitly hold on to the unsubscribe function from subscribing to the update event.
2273 -- If we don't do this, there are certain cases where mergeCheap will fail to properly retain
2089 -- If we don't do this, there are certain cases where mergeCheap will fail to properly retain
2274 -- its subscription.
2090 -- its subscription.
2275− liftIO $ writeIORef changeSubdRef (changeSubscriber, changeSubscription)
2091+ liftIO $ writeIORef changeSubdRef (s, changeSubscription)
2276 let unsubscribeAll = traverse_ unsubscribe =<< FastMutableIntMap.getFrozenAndClear parents
2092 let unsubscribeAll = traverse_ unsubscribe =<< FastMutableIntMap.getFrozenAndClear parents
2277−
2278−
2279− return (EventSubscription unsubscribeAll subscribed, occ)
2093+ return ( EventSubscription unsubscribeAll $ EventSubscribed heightRef $ toAny (parents, changeSubdRef)
2094+ , occ
2095+ )
2280
2096
2281newtype EventSelector x k = EventSelector { select :: forall a. k a -> Event x a }
2097newtype EventSelector x k = EventSelector { select :: forall a. k a -> Event x a }
2282newtype EventSelectorG x k v = EventSelectorG { selectG :: forall a. k a -> Event x (v a) }
2098newtype EventSelectorG x k v = EventSelectorG { selectG :: forall a. k a -> Event x (v a) }
@@ -2359,19 +2175,19 @@ runFrame a = SpiderHost $ do
2359 coincidenceInfos <- readIORef $ eventEnvResetCoincidences env
2175 coincidenceInfos <- readIORef $ eventEnvResetCoincidences env
2360 forM_ toAssign $ \(SomeAssignment vRef iRef v) -> {-# SCC "assignment" #-} do
2176 forM_ toAssign $ \(SomeAssignment vRef iRef v) -> {-# SCC "assignment" #-} do
2361 writeIORef vRef v
2177 writeIORef vRef v
2362− traceInvalidate $ "Invalidating Hold"
2178+ when debugInvalidate $ putStrLn $ "Invalidating Hold"
2363 writeIORef iRef =<< evaluate =<< invalidate toReconnectRef =<< readIORef iRef
2179 writeIORef iRef =<< evaluate =<< invalidate toReconnectRef =<< readIORef iRef
2364 mergeUpdates <- readIORef $ eventEnvMergeUpdates env
2180 mergeUpdates <- readIORef $ eventEnvMergeUpdates env
2365 writeIORef (eventEnvMergeUpdates env) []
2181 writeIORef (eventEnvMergeUpdates env) []
2366− tracePropagate (Proxy::Proxy x) $ "Updating merges"
2182+ when debugPropagate $ putStrLn "Updating merges"
2367 mergeSubscriptionsToKill <- runEventM $ concat <$> mapM _someMergeUpdate_update mergeUpdates
2183 mergeSubscriptionsToKill <- runEventM $ concat <$> mapM _someMergeUpdate_update mergeUpdates
2368− tracePropagate (Proxy::Proxy x) $ "Updating merges done"
2184+ when debugPropagate $ putStrLn "Updating merges done"
2369 toReconnect <- readIORef toReconnectRef
2185 toReconnect <- readIORef toReconnectRef
2370 clearEventEnv env
2186 clearEventEnv env
2371 switchSubscriptionsToKill <- forM toReconnect $ \(SomeSwitchSubscribed subscribed) -> {-# SCC "switchSubscribed" #-} do
2187 switchSubscriptionsToKill <- forM toReconnect $ \(SomeSwitchSubscribed subscribed) -> {-# SCC "switchSubscribed" #-} do
2372 oldSubscription <- readIORef $ switchSubscribedCurrentParent subscribed
2188 oldSubscription <- readIORef $ switchSubscribedCurrentParent subscribed
2373 wi <- readIORef $ switchSubscribedOwnWeakInvalidator subscribed
2189 wi <- readIORef $ switchSubscribedOwnWeakInvalidator subscribed
2374− traceInvalidate $ "Finalizing invalidator for Switch" <> showNodeId subscribed
2190+ when debugInvalidate $ putStrLn $ "Finalizing invalidator for Switch" <> showNodeId subscribed
2375 finalize wi
2191 finalize wi
2376 i <- evaluate $ switchSubscribedOwnInvalidator subscribed
2192 i <- evaluate $ switchSubscribedOwnInvalidator subscribed
2377 wi' <- mkWeakPtrWithDebug i "wi'"
2193 wi' <- mkWeakPtrWithDebug i "wi'"
@@ -2385,7 +2201,7 @@ runFrame a = SpiderHost $ do
2385 subscription <- unSpiderHost $ runFrame $ {-# SCC "subscribeSwitch" #-} subscribe e sub --TODO: Assert that the event isn't firing --TODO: This should not loop because none of the events should be firing, but still, it is inefficient
2201 subscription <- unSpiderHost $ runFrame $ {-# SCC "subscribeSwitch" #-} subscribe e sub --TODO: Assert that the event isn't firing --TODO: This should not loop because none of the events should be firing, but still, it is inefficient
2386 {-
2202 {-
2387 stackTrace <- liftIO $ fmap renderStack $ ccsToStrings =<< (getCCSOf $! switchSubscribedParent subscribed)
2203 stackTrace <- liftIO $ fmap renderStack $ ccsToStrings =<< (getCCSOf $! switchSubscribedParent subscribed)
2388− liftIO $ debugStrLn $ (++stackTrace) $ "subd' subscribed to " ++ case e of
2204+ liftIO $ putStrLn $ (++stackTrace) $ "subd' subscribed to " ++ case e of
2389 EventRoot _ -> "EventRoot"
2205 EventRoot _ -> "EventRoot"
2390 EventNever -> "EventNever"
2206 EventNever -> "EventNever"
2391 _ -> "something else"
2207 _ -> "something else"
@@ -2520,8 +2336,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Event
2520 {-# INLINABLE headE #-}
2336 {-# INLINABLE headE #-}
2521 headE = R.slowHeadE
2337 headE = R.slowHeadE
2522-- headE (SpiderEvent e) = SpiderEvent <$> Reflex.Spider.Internal.headE e
2338-- headE (SpiderEvent e) = SpiderEvent <$> Reflex.Spider.Internal.headE e
2523− {-# INLINABLE now #-}
2524− now = nowSpiderEventM
2525
2339
2526instance Reflex.Class.MonadSample (SpiderTimeline x) (SpiderPullM x) where
2340instance Reflex.Class.MonadSample (SpiderTimeline x) (SpiderPullM x) where
2527 {-# INLINABLE sample #-}
2341 {-# INLINABLE sample #-}
@@ -2543,9 +2357,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Spide
2543 {-# INLINABLE headE #-}
2357 {-# INLINABLE headE #-}
2544 headE = R.slowHeadE
2358 headE = R.slowHeadE
2545-- headE (SpiderEvent e) = SpiderPushM $ SpiderEvent <$> Reflex.Spider.Internal.headE e
2359-- headE (SpiderEvent e) = SpiderPushM $ SpiderEvent <$> Reflex.Spider.Internal.headE e
2546− {-# INLINABLE now #-}
2547− now = SpiderPushM nowSpiderEventM
2548−
2549
2360
2550instance HasSpiderTimeline x => Monad (Reflex.Class.Dynamic (SpiderTimeline x)) where
2361instance HasSpiderTimeline x => Monad (Reflex.Class.Dynamic (SpiderTimeline x)) where
2551 {-# INLINE return #-}
2362 {-# INLINE return #-}
@@ -2609,9 +2420,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Spide
2609 buildDynamic getV0 e = runFrame . runSpiderHostFrame $ Reflex.Class.buildDynamic getV0 e
2420 buildDynamic getV0 e = runFrame . runSpiderHostFrame $ Reflex.Class.buildDynamic getV0 e
2610 {-# INLINABLE headE #-}
2421 {-# INLINABLE headE #-}
2611 headE e = runFrame . runSpiderHostFrame $ Reflex.Class.headE e
2422 headE e = runFrame . runSpiderHostFrame $ Reflex.Class.headE e
2612− {-# INLINABLE now #-}
2613− now = runFrame . runSpiderHostFrame $ Reflex.Class.now
2614−
2615
2423
2616instance HasSpiderTimeline x => Reflex.Class.MonadSample (SpiderTimeline x) (SpiderHostFrame x) where
2424instance HasSpiderTimeline x => Reflex.Class.MonadSample (SpiderTimeline x) (SpiderHostFrame x) where
2617 sample = SpiderHostFrame . readBehaviorUntracked . unSpiderBehavior --TODO: This can cause problems with laziness, so we should get rid of it if we can
2425 sample = SpiderHostFrame . readBehaviorUntracked . unSpiderBehavior --TODO: This can cause problems with laziness, so we should get rid of it if we can
@@ -2628,8 +2436,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Spide
2628 {-# INLINABLE headE #-}
2436 {-# INLINABLE headE #-}
2629 headE = R.slowHeadE
2437 headE = R.slowHeadE
2630-- headE (SpiderEvent e) = SpiderHostFrame $ SpiderEvent <$> Reflex.Spider.Internal.headE e
2438-- headE (SpiderEvent e) = SpiderHostFrame $ SpiderEvent <$> Reflex.Spider.Internal.headE e
2631− {-# INLINABLE now #-}
2632− now = SpiderHostFrame Reflex.Class.now
2633
2439
2634instance HasSpiderTimeline x => Reflex.Class.MonadSample (SpiderTimeline x) (SpiderHost x) where
2440instance HasSpiderTimeline x => Reflex.Class.MonadSample (SpiderTimeline x) (SpiderHost x) where
2635 {-# INLINABLE sample #-}
2441 {-# INLINABLE sample #-}
@@ -2650,8 +2456,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Refle
2650 buildDynamic getV0 e = Reflex.Spider.Internal.ReadPhase $ Reflex.Class.buildDynamic getV0 e
2456 buildDynamic getV0 e = Reflex.Spider.Internal.ReadPhase $ Reflex.Class.buildDynamic getV0 e
2651 {-# INLINABLE headE #-}
2457 {-# INLINABLE headE #-}
2652 headE e = Reflex.Spider.Internal.ReadPhase $ Reflex.Class.headE e
2458 headE e = Reflex.Spider.Internal.ReadPhase $ Reflex.Class.headE e
2653− {-# INLINABLE now #-}
2654− now = Reflex.Spider.Internal.ReadPhase Reflex.Class.now
2655
2459
2656--------------------------------------------------------------------------------
2460--------------------------------------------------------------------------------
2657-- Deprecated items
2461-- Deprecated items
@@ -2689,13 +2493,13 @@ instance HasSpiderTimeline x => Reflex.Host.Class.MonadReadEvent (SpiderTimeline
2689 touch h
2493 touch h
2690 return result
2494 return result
2691
2495
2692−instance HasSpiderTimeline x => Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHost x) where
2496+instance Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHost x) where
2693 newEventWithTrigger = SpiderHost . fmap SpiderEvent . newEventWithTriggerIO
2497 newEventWithTrigger = SpiderHost . fmap SpiderEvent . newEventWithTriggerIO
2694 newFanEventWithTrigger f = SpiderHost $ do
2498 newFanEventWithTrigger f = SpiderHost $ do
2695 es <- newFanEventWithTriggerIO f
2499 es <- newFanEventWithTriggerIO f
2696 return $ Reflex.Class.EventSelector $ SpiderEvent . Reflex.Spider.Internal.select es
2500 return $ Reflex.Class.EventSelector $ SpiderEvent . Reflex.Spider.Internal.select es
2697
2501
2698−instance HasSpiderTimeline x => Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHostFrame x) where
2502+instance Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHostFrame x) where
2699 newEventWithTrigger = SpiderHostFrame . EventM . liftIO . fmap SpiderEvent . newEventWithTriggerIO
2503 newEventWithTrigger = SpiderHostFrame . EventM . liftIO . fmap SpiderEvent . newEventWithTriggerIO
2700 newFanEventWithTrigger f = SpiderHostFrame $ EventM $ liftIO $ do
2504 newFanEventWithTrigger f = SpiderHostFrame $ EventM $ liftIO $ do
2701 es <- newFanEventWithTriggerIO f
2505 es <- newFanEventWithTriggerIO f
@@ -2775,7 +2579,7 @@ instance HasSpiderTimeline x => R.Reflex (SpiderTimeline x) where
2775 fanG e = R.EventSelectorG $ SpiderEvent . selectG (fanG (unSpiderEvent e))
2579 fanG e = R.EventSelectorG $ SpiderEvent . selectG (fanG (unSpiderEvent e))
2776 {-# INLINABLE mergeG #-}
2580 {-# INLINABLE mergeG #-}
2777 mergeG
2581 mergeG
2778− :: forall k2 (k :: k2 -> *) q (v :: k2 -> *). GCompare k
2582+ :: forall (k :: k2 -> *) q (v :: k2 -> *). GCompare k
2779 => (forall a. q a -> R.Event (SpiderTimeline x) (v a))
2583 => (forall a. q a -> R.Event (SpiderTimeline x) (v a))
2780 -> DMap k q
2584 -> DMap k q
2781 -> R.Event (SpiderTimeline x) (DMap k v)
2585 -> R.Event (SpiderTimeline x) (DMap k v)
@@ -2845,12 +2649,12 @@ instance Monad (SpiderHost x) where
2845 return x = SpiderHost $ return x
2649 return x = SpiderHost $ return x
2846#if !MIN_VERSION_base(4,13,0)
2650#if !MIN_VERSION_base(4,13,0)
2847 {-# INLINABLE fail #-}
2651 {-# INLINABLE fail #-}
2848− fail = MonadFail.fail
2652+ fail s = MonadFail.fail
2849#endif
2653#endif
2850
2654
2851instance MonadFail (SpiderHost x) where
2655instance MonadFail (SpiderHost x) where
2852 {-# INLINABLE fail #-}
2656 {-# INLINABLE fail #-}
2853− fail s = SpiderHost $ MonadFail.fail s
2657+ fail s = SpiderHost $ fail s
2854
2658
2855-- | Run an action affecting the global Spider timeline; this will be guarded by
2659-- | Run an action affecting the global Spider timeline; this will be guarded by
2856-- a mutex for that timeline
2660-- a mutex for that timeline
@@ -2874,19 +2678,23 @@ instance Monad (SpiderHostFrame x) where
2874 return x = SpiderHostFrame $ return x
2678 return x = SpiderHostFrame $ return x
2875#if !MIN_VERSION_base(4,13,0)
2679#if !MIN_VERSION_base(4,13,0)
2876 {-# INLINABLE fail #-}
2680 {-# INLINABLE fail #-}
2877− fail s = SpiderHostFrame $ fail s
2681+ fail s = MonadFail.fail
2878#endif
2682#endif
2879
2683
2684+instance MonadFail (SpiderHostFrame x) where
2685+ {-# INLINABLE fail #-}
2686+ fail s = SpiderHostFrame $ fail s
2687+
2880instance NotReady (SpiderTimeline x) (SpiderHostFrame x) where
2688instance NotReady (SpiderTimeline x) (SpiderHostFrame x) where
2881 notReadyUntil _ = pure ()
2689 notReadyUntil _ = pure ()
2882 notReady = pure ()
2690 notReady = pure ()
2883
2691
2884−newEventWithTriggerIO :: forall x a. HasSpiderTimeline x => (RootTrigger x a -> IO (IO ())) -> IO (Event x a)
2692+newEventWithTriggerIO :: (RootTrigger x a -> IO (IO ())) -> IO (Event x a)
2885newEventWithTriggerIO f = do
2693newEventWithTriggerIO f = do
2886 es <- newFanEventWithTriggerIO $ \Refl -> f
2694 es <- newFanEventWithTriggerIO $ \Refl -> f
2887 return $ select es Refl
2695 return $ select es Refl
2888
2696
2889−newFanEventWithTriggerIO :: (HasSpiderTimeline x, GCompare k) => (forall a. k a -> RootTrigger x a -> IO (IO ())) -> IO (EventSelector x k)
2697+newFanEventWithTriggerIO :: GCompare k => (forall a. k a -> RootTrigger x a -> IO (IO ())) -> IO (EventSelector x k)
2890newFanEventWithTriggerIO f = do
2698newFanEventWithTriggerIO f = do
2891 occRef <- newIORef DMap.empty
2699 occRef <- newIORef DMap.empty
2892 subscribedRef <- newIORef DMap.empty
2700 subscribedRef <- newIORef DMap.empty
src/Reflex/TriggerEvent/Base.hs−2
@@ -122,8 +122,6 @@ instance MonadHold t m => MonadHold t (TriggerEventT t m) where
122 buildDynamic a0 = lift . buildDynamic a0
122 buildDynamic a0 = lift . buildDynamic a0
123 {-# INLINABLE headE #-}
123 {-# INLINABLE headE #-}
124 headE = lift . headE
124 headE = lift . headE
125− {-# INLINABLE now #-}
126− now = lift now
127
125
128instance Adjustable t m => Adjustable t (TriggerEventT t m) where
126instance Adjustable t m => Adjustable t (TriggerEventT t m) where
129 {-# INLINABLE runWithReplace #-}
127 {-# INLINABLE runWithReplace #-}
src/Reflex/TriggerEvent/Class.hs−6
@@ -12,7 +12,6 @@ import Reflex.Class
12import Control.Monad.Reader
12import Control.Monad.Reader
13import Control.Monad.State
13import Control.Monad.State
14import qualified Control.Monad.State.Strict as Strict
14import qualified Control.Monad.State.Strict as Strict
15−import Control.Monad.Trans.Maybe (MaybeT)
16
15
17--TODO: Shouldn't have IO hard-coded
16--TODO: Shouldn't have IO hard-coded
18-- | 'TriggerEvent' represents actions that can create 'Event's that can be
17-- | 'TriggerEvent' represents actions that can create 'Event's that can be
@@ -48,8 +47,3 @@ instance TriggerEvent t m => TriggerEvent t (Strict.StateT s m) where
48 newTriggerEvent = lift newTriggerEvent
47 newTriggerEvent = lift newTriggerEvent
49 newTriggerEventWithOnComplete = lift newTriggerEventWithOnComplete
48 newTriggerEventWithOnComplete = lift newTriggerEventWithOnComplete
50 newEventWithLazyTriggerWithOnComplete = lift . newEventWithLazyTriggerWithOnComplete
49 newEventWithLazyTriggerWithOnComplete = lift . newEventWithLazyTriggerWithOnComplete
51−
52−instance TriggerEvent t m => TriggerEvent t (MaybeT m) where
53− newTriggerEvent = lift newTriggerEvent
54− newTriggerEventWithOnComplete = lift newTriggerEventWithOnComplete
55− newEventWithLazyTriggerWithOnComplete = lift . newEventWithLazyTriggerWithOnComplete
src/Reflex/Widget/Basic.hs+1−1
@@ -13,7 +13,7 @@ import Data.Map (Map)
13
13
14import Reflex.Class
14import Reflex.Class
15import Reflex.Adjustable.Class
15import Reflex.Adjustable.Class
16−import Data.Patch.MapWithMove
16+import Reflex.Patch.MapWithMove
17
17
18
18
19-- | Build sortable content in such a way that re-sorting it can cause minimal
19-- | Build sortable content in such a way that re-sorting it can cause minimal
test/Adjustable.hsdeleted−62
@@ -1,62 +0,0 @@
1−{-# LANGUAGE BangPatterns #-}
2−{-# LANGUAGE LambdaCase #-}
3−{-# LANGUAGE RankNTypes #-}
4−{-# LANGUAGE RecursiveDo #-}
5−
6−module Main where
7−
8−import Control.Monad.Fix
9−import Data.Maybe
10−import qualified Data.Map as Map
11−
12−import Reflex
13−import Reflex.EventWriter.Base
14−import Reflex.Network
15−import Reflex.Patch.MapWithMove
16−import Test.Run
17−
18−main :: IO ()
19−main = do
20− let actions = [ Increment, Update0th, Increment, Swap, Increment, Increment ]
21− os <- runAppB testPatchMapWithMove $ map Just actions
22− -- If the final counter value in the adjusted widgets corresponds to the number of times it has
23− -- been incremented, we know that the networks haven't broken.
24− let expectedCount = length $ ffilter (== Increment) actions
25− -- let !True = last (last os) == [expectedCount,expectedCount] -- TODO re-enable this test after issue #369 has been resolved
26− return ()
27−
28−data PatchMapTestAction
29− = Increment
30− | Swap
31− | Update0th
32− deriving Eq
33−
34−-- See https://github.com/reflex-frp/reflex/issues/369 for the bug that this is testing.
35−testPatchMapWithMove
36− :: forall t m
37− . ( Reflex t
38− , Adjustable t m
39− , MonadHold t m
40− , MonadFix m
41− )
42− => Event t PatchMapTestAction
43− -> m (Behavior t [Int])
44−testPatchMapWithMove pulse = do
45− let pulseAction = ffor pulse $ \case
46− Increment -> Nothing
47− Swap -> patchMapWithMove $ Map.fromList
48− [ (0, NodeInfo (From_Move 1) (Just 1))
49− , (1, NodeInfo (From_Move 0) (Just 0))
50− ]
51− Update0th -> patchMapWithMove $ Map.fromList
52− [ (0, NodeInfo (From_Insert 'z') Nothing) ]
53− (_, result) <- runBehaviorWriterT $ mdo
54− counter <- foldDyn (+) 1 $ fmapMaybe (\e -> if isNothing e then Just 1 else Nothing) pulseAction
55− _ <- mapMapWithAdjustWithMove
56− (\_ _ -> networkHold
57− (tellBehavior $ constant [])
58− ((\t -> tellBehavior $ constant [t]) <$> updated counter))
59− (Map.fromList $ zip [0..] "ab")
60− (fmapMaybe id pulseAction)
61− return ()
62− return result
test/DebugCycles.hsdeleted−171
@@ -1,171 +0,0 @@
1−{-# LANGUAGE CPP #-}
2−{-# LANGUAGE ConstraintKinds #-}
3−{-# LANGUAGE FlexibleContexts #-}
4−{-# LANGUAGE GADTs #-}
5−{-# LANGUAGE RecursiveDo #-}
6−{-# LANGUAGE ScopedTypeVariables #-}
7−{-# LANGUAGE PatternSynonyms #-}
8−{-# LANGUAGE RankNTypes #-}
9−
10−module Main where
11−
12−import Data.Foldable
13−import Control.Lens
14−import Control.Applicative
15−import Control.Monad
16−import Control.Monad.Fix
17−import Control.Exception
18−import System.Timeout
19−import Data.Maybe (isJust)
20−import Data.Functor.Misc
21−import qualified Data.Map as Map
22−import Data.Map (Map)
23−import qualified Data.IntMap as IntMap
24−import Data.IntMap (IntMap)
25−import Data.These
26−import Data.Align
27−import Reflex
28−import Reflex.EventWriter.Base
29−import Test.Run
30−import Test.Hspec
31−import Reflex.Spider.Internal (EventLoopException)
32−import Data.Witherable (Filterable)
33−
34−#if defined(MIN_VERSION_these_lens) || (MIN_VERSION_these(0,8,0) && !MIN_VERSION_these(0,9,0))
35−import Data.These.Lens
36−#endif
37−
38−type Widget t m = (MonadHold t m, Reflex t, MonadFix m)
39−
40−connectDyn :: Widget t m => Event t () -> (Dynamic t a, Dynamic t a) -> m (Dynamic t a)
41−connectDyn e (d, d') = do
42− dd <- holdDyn d (d' <$ e)
43− return $ join dd
44−
45−dynLoop :: Widget t m => (Event t Int, Event t ()) -> m (Event t Int)
46−dynLoop (e1, e2) = do
47− -- "heightBagRemove: Height 2 not present in bag HeightBag {_heightBag_size = 2, _heightBag_contents = fromList [(0,1)]}"
48− rec
49− d <- count e1
50− d' <- connectDyn e2 (d, liftA2 (+) d d')
51− return $ updated d'
52−
53−connectOnCoincidence :: Widget t m => Event t () -> Event t a -> m (Event t a)
54−connectOnCoincidence click e = do
55− d <- holdDyn never (e <$ click)
56− return $ coincidence (updated d)
57−
58−coincidenceLoop :: Widget t m => (Event t Int, Event t ()) -> m (Event t Int)
59−coincidenceLoop (e1, e2) = do
60−-- "heightBagRemove: Height 1 not present in bag HeightBag {_heightBag_size = 1, _heightBag_contents = fromList [(0,0)]}"
61−-- (simpler version of dynLoop)
62− rec
63− e' <- connectOnCoincidence e2 (updated d)
64− d <- count (align e' e1)
65− return $ updated d
66−
67−addHeight :: Reflex t => Event t a -> Event t a
68−addHeight e = leftmost [e4, e4] where
69− e1 = leftmost [e, e]
70− e2 = leftmost [e1, e1]
71− e3 = leftmost [e2, e2]
72− e4 = leftmost [e3, e3]
73−
74−-- Take an existing test and build it inside a
75−buildLoop :: Widget t m => (forall t m. Widget t m => (Event t Int, Event t ()) -> m (Event t Int)) -> (Event t Int, Event t ()) -> m (Event t Int)
76−buildLoop test (e1, e2) = switchHold never buildLoop
77− where buildLoop = pushAlways (const $ test (e1, e2)) e2
78−
79−connectButtonPromptly :: Widget t m => Event t () -> Event t a -> m (Event t a)
80−connectButtonPromptly click e = do
81− d <- holdDyn never (e <$ click)
82− return (switchDyn d)
83−
84−connectButton :: Widget t m => Event t () -> Event t a -> m (Event t a)
85−connectButton click e = do
86− d <- hold never (e <$ click)
87− return (switch d)
88−
89−switchLoop01 :: Widget t m => (Event t Int, Event t ()) -> m (Event t Int)
90−switchLoop01 (e1, e2) = do
91− rec
92− e' <- connectButton e2 (updated d)
93− d <- count (align e' e1)
94− return $ updated d
95−
96−mergeLoop :: forall t m. (Adjustable t m, Widget t m) => (Event t Int, Event t ()) -> m (Event t Int)
97−mergeLoop (e1, e2) = do
98− rec
99− (_, e) <- runEventWriterT $
100− runWithReplace w (leftmost [w <$ e1])
101− return (sum <$> e)
102− where
103− w = do
104− c <- count e1
105− tellEvent (updated ((pure <$> c) :: Dynamic t [Int]))
106−
107−switchLoop02 :: Widget t m => (Event t Int, Event t ()) -> m (Event t Int)
108−switchLoop02 (e1, e2) = do
109− rec
110− e' <- connectButton e2 (updated d)
111− d <- count (leftmost [e', e1])
112− return $ updated d
113−
114−switchLoop03 :: Widget t m => (Event t Int, Event t ()) -> m (Event t Int)
115−switchLoop03 (e1, e2) = do
116− rec
117− e' <- connectButton e2 (addHeight $ updated d)
118− d <- count (align e' e1)
119− return $ updated d
120−
121−staticLoop01 :: Widget t m => (Event t Int, Event t ()) -> m (Event t Int)
122−staticLoop01 (e1, e2) = do
123− rec
124− d <- foldDyn (+) (0 :: Int) (1 <$ align e1 (updated d))
125− return $ updated d
126−
127−staticLoop02 :: Widget t m => (Event t Int, Event t ()) -> m (Event t Int)
128−staticLoop02 (e1, e2) = do
129− rec
130− d <- foldDyn (+) (0 :: Int) (leftmost [e1, updated d])
131− return $ updated d
132−
133−buildStaticLoop :: Widget t m => (Event t Int, Event t ()) -> m (Event t Int)
134−buildStaticLoop (e1, e2) = switchHold never buildLoop
135− where buildLoop = pushAlways (const $ staticLoop01 (e1, e2)) e2
136−
137−splitThese :: Filterable f => f (These a b) -> (f a, f b)
138−splitThese f = (mapMaybe (preview here) f, mapMaybe (preview there) f)
139−
140−main :: IO ()
141−main = hspec $ do
142− describe "DebugCycles" $ do
143− it "throws EventLoopException on switchLoop01" $ do
144− check switchLoop01
145− it "throws EventLoopException on switchLoop02" $ do
146− check switchLoop02
147− it "throws EventLoopException on switchLoop03" $ do
148− check switchLoop03
149− it "throws EventLoopException on buildSwitchLoop" $ do
150− check $ buildLoop switchLoop01
151− xit "throws EventLoopException on mergeLoop" $ do
152− check mergeLoop
153− xit "throws EventLoopException on staticLoop01" $ do
154− check staticLoop01
155− xit "throws EventLoopException on staticLoop02" $ do
156− check staticLoop02
157− xit "throws EventLoopException on buildStaticLoop" $ do
158− check buildStaticLoop
159− xit "throws EventLoopException on coincidenceLoop" $ do
160− check coincidenceLoop
161− xit "throws EventLoopException on dynLoop" $ do
162− check dynLoop
163− xit "throws EventLoopException on buildCoincidenceLoop" $ do
164− check $ buildLoop coincidenceLoop
165− where
166− milliseconds = (*1000)
167− occs = [ This 1, This 2, That (), This 3, That (), This 1 ]
168− check test = do
169− let action = timeout (milliseconds 50) $ do
170− runApp' (test . splitThese) (Just <$> occs)
171− action `shouldThrow` (const True :: Selector EventLoopException)
test/GC.hs+2−2
@@ -18,10 +18,9 @@ import Data.GADT.Compare
18import Data.IORef
18import Data.IORef
19import Data.Semigroup
19import Data.Semigroup
20import Data.These
20import Data.These
21−import Data.Type.Equality ((:~:)(Refl))
22
21
23import Data.Functor.Misc
22import Data.Functor.Misc
24−import Data.Patch
23+import Reflex.Patch
25
24
26import qualified Reflex.Host.Class as Host
25import qualified Reflex.Host.Class as Host
27import qualified Reflex.Spider.Internal as S
26import qualified Reflex.Spider.Internal as S
@@ -84,6 +83,7 @@ hostPerf ref = S.runSpiderHost $ do
84 Nothing -> []
83 Nothing -> []
85 Host.fireEventsAndRead followupEventTriggers $ return ()
84 Host.fireEventsAndRead followupEventTriggers $ return ()
86 return ()
85 return ()
86+ return ()
87
87
88data Tell a where
88data Tell a where
89 Action :: Tell ()
89 Action :: Tell ()
test/Headless.hsdeleted−10
@@ -1,10 +0,0 @@
1−module Main where
2−
3−import Reflex
4−import Reflex.Host.Headless (runHeadlessApp)
5−
6−main :: IO ()
7−main = do
8− runHeadlessApp $ do
9− pb <- getPostBuild
10− performEvent (pure <$> pb)
test/QueryT.hs+1−1
@@ -24,7 +24,7 @@ import Data.These.Lens
24#endif
24#endif
25
25
26import Reflex
26import Reflex
27−import Data.Patch.MapWithMove
27+import Reflex.Patch.MapWithMove
28import Test.Run
28import Test.Run
29
29
30newtype MyQuery = MyQuery SelectedCount
30newtype MyQuery = MyQuery SelectedCount
test/Reflex/Plan/Pure.hs−1
@@ -41,7 +41,6 @@ instance MonadHold (Pure Int) PurePlan where
41 holdIncremental initial = liftPlan . holdIncremental initial
41 holdIncremental initial = liftPlan . holdIncremental initial
42 buildDynamic getInitial = liftPlan . buildDynamic getInitial
42 buildDynamic getInitial = liftPlan . buildDynamic getInitial
43 headE = liftPlan . headE
43 headE = liftPlan . headE
44− now = liftPlan now
45
44
46instance MonadSample (Pure Int) PurePlan where
45instance MonadSample (Pure Int) PurePlan where
47 sample = liftPlan . sample
46 sample = liftPlan . sample
test/Reflex/Test/CrossImpl.hs+8−13
@@ -21,12 +21,11 @@ import Reflex.Dynamic
21import Reflex.Host.Class
21import Reflex.Host.Class
22import qualified Reflex.Pure as P
22import qualified Reflex.Pure as P
23import qualified Reflex.Spider.Internal as S
23import qualified Reflex.Spider.Internal as S
24−import qualified Reflex.Profiled as Prof
25
24
26import Control.Arrow (second, (&&&))
25import Control.Arrow (second, (&&&))
27import Control.Monad.Identity hiding (forM, forM_, mapM, mapM_, sequence, sequence_)
26import Control.Monad.Identity hiding (forM, forM_, mapM, mapM_, sequence, sequence_)
28import Control.Monad.State.Strict hiding (forM, forM_, mapM, mapM_, sequence, sequence_)
27import Control.Monad.State.Strict hiding (forM, forM_, mapM, mapM_, sequence, sequence_)
29−import Data.Dependent.Sum (DSum (..))
28+import Data.Dependent.Map (DSum (..))
30import Data.Foldable
29import Data.Foldable
31import Data.Map.Strict (Map)
30import Data.Map.Strict (Map)
32import qualified Data.Map.Strict as Map
31import qualified Data.Map.Strict as Map
@@ -36,6 +35,8 @@ import Data.Traversable
36import System.Exit
35import System.Exit
37import System.Mem
36import System.Mem
38
37
38+import System.IO.Unsafe
39+
39mapToPureBehavior :: Map Int a -> Behavior PureReflexDomain a
40mapToPureBehavior :: Map Int a -> Behavior PureReflexDomain a
40mapToPureBehavior m = P.Behavior $ \t -> case Map.lookupLE t m of
41mapToPureBehavior m = P.Behavior $ \t -> case Map.lookupLE t m of
41 Nothing -> error $ "mapToPureBehavior: no value for time " <> show t
42 Nothing -> error $ "mapToPureBehavior: no value for time " <> show t
@@ -72,14 +73,11 @@ instance MapMSignals (Event t a) (Event t' a) t t' where
72instance (MapMSignals a a' t t', MapMSignals b b' t t') => MapMSignals (a, b) (a', b') t t' where
73instance (MapMSignals a a' t t', MapMSignals b b' t t') => MapMSignals (a, b) (a', b') t t' where
73 mapMSignals fb fe (a, b) = liftM2 (,) (mapMSignals fb fe a) (mapMSignals fb fe b)
74 mapMSignals fb fe (a, b) = liftM2 (,) (mapMSignals fb fe a) (mapMSignals fb fe b)
74
75
75−testTimeline
76− :: (forall m t. TestCaseConstraint t m => (Behavior t a, Event t b) -> m (Behavior t c, Event t d))
76+testSpider :: (forall m t. TestCaseConstraint t m => (Behavior t a, Event t b) -> m (Behavior t c, Event t d)) -> (Map Int a, Map Int b) -> (Map Int c, Map Int d)
77− -> (Map Int a, Map Int b)
78− -> (forall m t. (MonadReflexHost t m, MonadIO m, MonadRef m, Ref m ~ Ref IO, MonadSample t m) => m (Map Int c, Map Int d))
79−testTimeline builder (bMap, eMap) = do
77+testSpider builder (bMap, eMap) = unsafePerformIO $ S.runSpiderHost $ do
80 (re, reTrigger) <- newEventWithTriggerRef
78 (re, reTrigger) <- newEventWithTriggerRef
81 (rb, rbTrigger) <- newEventWithTriggerRef
79 (rb, rbTrigger) <- newEventWithTriggerRef
82− b <- runHostFrame $ hold (error "testTimeline: No value for input behavior yet") rb
80+ b <- runHostFrame $ hold (error "testSpider: No value for input behavior yet") rb
83 (b', e') <- runHostFrame $ builder (b, re)
81 (b', e') <- runHostFrame $ builder (b, re)
84 e'Handle <- subscribeEvent e' --TODO: This should be unnecessary
82 e'Handle <- subscribeEvent e' --TODO: This should be unnecessary
85 let times = relevantTestingTimes (bMap, eMap)
83 let times = relevantTestingTimes (bMap, eMap)
@@ -104,11 +102,9 @@ testAgreement :: (Eq c, Eq d, Show c, Show d) => (forall m t. TestCaseConstraint
104testAgreement builder inputs = do
102testAgreement builder inputs = do
105 let identityResult = testPure builder inputs
103 let identityResult = testPure builder inputs
106 tracePerf "---------" $ return ()
104 tracePerf "---------" $ return ()
107− spiderResult <- S.runSpiderHost $ testTimeline builder inputs
105+ let spiderResult = testSpider builder inputs
108− tracePerf "---------" $ return ()
109− profiledResult <- S.runSpiderHost $ Prof.runProfiledM $ testTimeline builder inputs
110 tracePerf "---------" $ return ()
106 tracePerf "---------" $ return ()
111− let resultsAgree = identityResult == spiderResult && identityResult == profiledResult
107+ let resultsAgree = identityResult == spiderResult
112 if resultsAgree
108 if resultsAgree
113 then do --putStrLn "Success:"
109 then do --putStrLn "Success:"
114 --print identityResult
110 --print identityResult
@@ -116,7 +112,6 @@ testAgreement builder inputs = do
116 else do putStrLn "Failure:"
112 else do putStrLn "Failure:"
117 putStrLn $ "Pure result: " <> show identityResult
113 putStrLn $ "Pure result: " <> show identityResult
118 putStrLn $ "Spider result: " <> show spiderResult
114 putStrLn $ "Spider result: " <> show spiderResult
119− putStrLn $ "Profiled result: " <> show profiledResult
120 return resultsAgree
115 return resultsAgree
121
116
122type TestCaseConstraint t m = (Reflex t, MonadSample t m, MonadHold t m, MonadFix m, MonadFix (PushM t))
117type TestCaseConstraint t m = (Reflex t, MonadSample t m, MonadHold t m, MonadFix m, MonadFix (PushM t))
test/Reflex/Test/Micro.hs+2−8
@@ -322,14 +322,8 @@ testCases =
322 let e = never <$ switch b
322 let e = never <$ switch b
323 return $ void e
323 return $ void e
324 lazyHold
324 lazyHold
325− , testE "now-1" $ do
325+
326− e1 <- events1
326+
327− switchHoldPromptly never . pushAlways (\a -> fmap (a <$) now) $ e1
328− , testE "now-2" $ do
329− e1 <- events1
330− let e = pushAlways (\a -> if a == "a" then now else return never) e1
331− x <- accumDyn (<>) never e
332− return . coincidence $ updated x
333 ] where
327 ] where
334
328
335 events1, events2, events3 :: TestPlan t m => m (Event t String)
329 events1, events2, events3 :: TestPlan t m => m (Event t String)
test/RequesterT.hs+2−63
@@ -1,36 +1,20 @@
1{-# LANGUAGE CPP #-}
1{-# LANGUAGE CPP #-}
2{-# LANGUAGE BangPatterns #-}
2{-# LANGUAGE BangPatterns #-}
3{-# LANGUAGE FlexibleContexts #-}
3{-# LANGUAGE FlexibleContexts #-}
4−{-# LANGUAGE FlexibleInstances #-}
5{-# LANGUAGE GADTs #-}
4{-# LANGUAGE GADTs #-}
6−{-# LANGUAGE LambdaCase #-}
5+{-# LANGUAGE RankNTypes #-}
7−{-# LANGUAGE MultiParamTypeClasses #-}
8{-# LANGUAGE RecursiveDo #-}
6{-# LANGUAGE RecursiveDo #-}
9{-# LANGUAGE ScopedTypeVariables #-}
7{-# LANGUAGE ScopedTypeVariables #-}
10−{-# LANGUAGE TemplateHaskell #-}
11−{-# LANGUAGE TypeApplications #-}
12−{-# LANGUAGE TypeFamilies #-}
13module Main where
8module Main where
14
9
15−import Control.Lens hiding (has)
10+import Control.Lens
16import Control.Monad
11import Control.Monad
17import Control.Monad.Fix
12import Control.Monad.Fix
18−import Control.Monad.IO.Class (MonadIO)
19−import Data.Constraint.Extras
20−import Data.Constraint.Extras.TH
21−import Data.Constraint.Forall
22import qualified Data.Dependent.Map as DMap
13import qualified Data.Dependent.Map as DMap
23import Data.Dependent.Sum
14import Data.Dependent.Sum
24import Data.Functor.Misc
15import Data.Functor.Misc
25−import Data.List (words)
26−import Data.Map (Map)
27import qualified Data.Map as M
16import qualified Data.Map as M
28−#if !MIN_VERSION_these(4,11,0)
29−import Data.Semigroup ((<>))
30−#endif
31−import Data.Text (Text)
32import Data.These
17import Data.These
33−import Text.Read (readMaybe)
34
18
35#if defined(MIN_VERSION_these_lens) || (MIN_VERSION_these(0,8,0) && !MIN_VERSION_these(0,9,0))
19#if defined(MIN_VERSION_these_lens) || (MIN_VERSION_these(0,8,0) && !MIN_VERSION_these(0,9,0))
36import Data.These.Lens
20import Data.These.Lens
@@ -65,19 +49,12 @@ main = do
65 print os5
49 print os5
66 os6 <- runApp' (unwrapApp delayedPulse) [Just ()]
50 os6 <- runApp' (unwrapApp delayedPulse) [Just ()]
67 print os6
51 print os6
68− os7 <- runApp' testMatchRequestsWithResponses [ Just $ TestRequest_Increment 1 ]
69− print os7
70− os8 <- runApp' testMatchRequestsWithResponses [ Just $ TestRequest_Reverse "yoyo" ]
71− print os8
72 let ![[Just [1,2,3,4,5,6,7,8,9,10]]] = os1 -- The order is reversed here: see the documentation for 'runRequesterT'
52 let ![[Just [1,2,3,4,5,6,7,8,9,10]]] = os1 -- The order is reversed here: see the documentation for 'runRequesterT'
73 let ![[Just [9,7,5,3,1]],[Nothing,Nothing],[Just [10,8,6,4,2]],[Just [10,8,6,4,2],Nothing]] = os2
53 let ![[Just [9,7,5,3,1]],[Nothing,Nothing],[Just [10,8,6,4,2]],[Just [10,8,6,4,2],Nothing]] = os2
74 let ![[Nothing, Just [2]]] = os3
54 let ![[Nothing, Just [2]]] = os3
75 let ![[Nothing, Just [2]]] = os4
55 let ![[Nothing, Just [2]]] = os4
76 let ![[Nothing, Just [1, 2]]] = os5
56 let ![[Nothing, Just [1, 2]]] = os5
77 -- let ![[Nothing, Nothing]] = os6 -- TODO re-enable this test after issue #233 has been resolved
57 -- let ![[Nothing, Nothing]] = os6 -- TODO re-enable this test after issue #233 has been resolved
78− let !(Just [(1,"2")]) = M.toList <$> head (head os7)
79− let !(Just [(1,"oyoy")]) = M.toList <$> head (head os8)
80−
81 return ()
58 return ()
82
59
83unwrapRequest :: DSum tag RequestInt -> Int
60unwrapRequest :: DSum tag RequestInt -> Int
@@ -195,41 +172,3 @@ delayedPulse pulse = void $ flip runWithReplace (pure () <$ pulse) $ do
195 -- This has the effect of delaying pulse' from pulse
172 -- This has the effect of delaying pulse' from pulse
196 (_, pulse') <- runWithReplace (pure ()) $ pure (RequestInt 1) <$ pulse
173 (_, pulse') <- runWithReplace (pure ()) $ pure (RequestInt 1) <$ pulse
197 requestingIdentity pulse'
174 requestingIdentity pulse'
198−
199−data TestRequest a where
200− TestRequest_Reverse :: String -> TestRequest String
201− TestRequest_Increment :: Int -> TestRequest Int
202−
203−testMatchRequestsWithResponses
204− :: forall m t req a
205− . ( MonadFix m
206− , MonadHold t m
207− , Reflex t
208− , PerformEvent t m
209− , MonadIO (Performable m)
210− , ForallF Show req
211− , Has Read req
212− )
213− => Event t (req a) -> m (Event t (Map Int String))
214−testMatchRequestsWithResponses pulse = mdo
215− (_, requests) <- runRequesterT (requesting pulse) responses
216− let rawResponses = M.map (\v ->
217− case words v of
218− ["reverse", str] -> reverse str
219− ["increment", i] -> show $ succ $ (read i :: Int)
220− ) <$> rawRequestMap
221− (rawRequestMap, responses) <- matchResponsesWithRequests reqEncoder requests (head . M.toList <$> rawResponses)
222− pure rawResponses
223− where
224− reqEncoder :: forall a. req a -> (String, String -> Maybe a)
225− reqEncoder r =
226− ( whichever @Show @req @a $ show r
227− , \x -> has @Read r $ readMaybe x
228− )
229−
230−deriveArgDict ''TestRequest
231−
232−instance Show (TestRequest a) where
233− show = \case
234− TestRequest_Reverse str -> "reverse " <> str
235− TestRequest_Increment i -> "increment " <> show i
test/hlint.hs+1−2
@@ -1,7 +1,7 @@
1module Main where
1module Main where
2
2
3import Control.Monad
3import Control.Monad
4−import Language.Haskell.HLint (hlint)
4+import Language.Haskell.HLint3 (hlint)
5import System.Directory
5import System.Directory
6import System.Exit (exitFailure, exitSuccess)
6import System.Exit (exitFailure, exitSuccess)
7import System.FilePath
7import System.FilePath
@@ -22,7 +22,6 @@ main = do
22 , "--ignore=Use unless"
22 , "--ignore=Use unless"
23 , "--ignore=Reduce duplication"
23 , "--ignore=Reduce duplication"
24 , "--cpp-define=USE_TEMPLATE_HASKELL"
24 , "--cpp-define=USE_TEMPLATE_HASKELL"
25− , "--cpp-define=DEBUG"
26 , "--ignore=Use tuple-section"
25 , "--ignore=Use tuple-section"
27 ]
26 ]
28 recurseInto = and <$> sequence
27 recurseInto = and <$> sequence