@@ -9,6 +9,7 @@
99{-# LANGUAGE GADTs #-}
1010{-# LANGUAGE GeneralizedNewtypeDeriving #-}
1111{-# LANGUAGE LambdaCase #-}
12+{-# LANGUAGE MultiWayIf #-}
1213{-# LANGUAGE RankNTypes #-}
1314{-# LANGUAGE RoleAnnotations #-}
1415{-# LANGUAGE ScopedTypeVariables #-}
@@ -19,7 +20,6 @@
1920{-# LANGUAGE DeriveFunctor #-}
2021{-# LANGUAGE StandaloneDeriving #-}
2122{-# LANGUAGE InstanceSigs #-}
22−{-# LANGUAGE MultiWayIf #-}
2323
2424#ifdef USE_REFLEX_OPTIMIZER
2525{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
@@ -38,17 +38,15 @@ import Control.Monad hiding (forM, forM_, mapM, mapM_)
3838import Control.Monad.Exception
3939import Control.Monad.Identity hiding (forM, forM_, mapM, mapM_)
4040import Control.Monad.Primitive
41+--import Control.Monad.Reader hiding (forM, forM_, mapM, mapM_)
4142import Control.Monad.Reader.Class
4243import Control.Monad.IO.Class
4344import Control.Monad.ReaderIO
4445import Control.Monad.Ref
45−import Control.Monad.Fail (MonadFail)
46−import qualified Control.Monad.Fail as MonadFail
4746import Data.Align
4847import Data.Coerce
49−import Data.Dependent.Map (DMap)
48+import Data.Dependent.Map (DMap, DSum (..))
5049import qualified Data.Dependent.Map as DMap
51−import Data.Dependent.Sum (DSum (..))
5250import Data.FastMutableIntMap (FastMutableIntMap, PatchIntMap (..))
5351import qualified Data.FastMutableIntMap as FastMutableIntMap
5452import Data.Foldable hiding (concat, elem, sequence_)
@@ -61,13 +59,12 @@ import qualified Data.IntMap.Strict as IntMap
6159import Data.IORef
6260import Data.Kind (Type)
6361import Data.Maybe hiding (mapMaybe)
64−import Data.Monoid (mempty, (<>))
62+import Data.Monoid ((<>))
6563import Data.Proxy
6664import Data.These
6765import Data.Traversable
68−import Data.Type.Equality ((:~:)(Refl))
6966import Data.Witherable (Filterable, mapMaybe)
70−import GHC.Exts hiding (toList)
67+import GHC.Exts
7168import GHC.IORef (IORef (..))
7269import GHC.Stack
7370import Reflex.FastWeak
@@ -86,16 +83,14 @@ import Data.Zip (Zip (..))
8683
8784#ifdef DEBUG_CYCLES
8885import Control.Monad.State hiding (forM, forM_, mapM, mapM_, sequence)
89−#endif
90−
9186import Data.List.NonEmpty (NonEmpty (..), nonEmpty)
9287import qualified Data.List.NonEmpty as NonEmpty
88+import Data.Monoid (mempty)
9389import Data.Tree (Forest, Tree (..), drawForest)
94−import Data.List (isPrefixOf)
90+#endif
9591
96−import Data.FastWeakBag (FastWeakBag, FastWeakBagTicket)
92+import Data.FastWeakBag (FastWeakBag)
9793import qualified Data.FastWeakBag as FastWeakBag
98−
9994import Data.Reflection
10095import Data.Some (Some(Some))
10196import Data.Type.Coercion
@@ -106,26 +101,20 @@ import qualified Reflex.Class
106101import qualified Reflex.Class as R
107102import qualified Reflex.Host.Class
108103import Reflex.NotReady.Class
109−import Data.Patch
110−import qualified Data.Patch.DMapWithMove as PatchDMapWithMove
111−import Reflex.PerformEvent.Base (PerformEventT)
104+import Reflex.Patch
105+import qualified Reflex.Patch.DMapWithMove as PatchDMapWithMove
112106
113107#ifdef DEBUG_TRACE_EVENTS
114108import qualified Data.ByteString.Char8 as BS8
115109import System.IO (stderr)
116−import Data.List (isPrefixOf)
117110#endif
118111
119−-- TODO stdout might not be the best channel for debug output
120−debugStrLn :: String -> IO ()
121−debugStrLn = putStrLn
122−
123112#ifdef DEBUG_TRACE_EVENTS
113+
124114withStackOneLine :: (BS8.ByteString -> a) -> a
125115withStackOneLine expr = unsafePerformIO $ do
126116 stack <- currentCallStack
127− return (expr . BS8.pack . unwords . dropInternal . reverse $ stack)
128− where dropInternal = filterStack "Reflex.Spider.Internal"
117+ return (expr (BS8.pack (unwords (reverse stack))))
129118
130119#endif
131120
@@ -136,42 +125,28 @@ debugInvalidateHeight :: Bool
136125debugInvalidate :: Bool
137126
138127#ifdef DEBUG
128+
139129#define DEBUG_NODEIDS
140130
141−#ifdef DEBUG_TRACE_PROPAGATION
142131debugPropagate = True
143−#else
144−debugPropagate = False
145−#endif
146132
147−#ifdef DEBUG_TRACE_HEIGHT
148−debugInvalidateHeight = True
149−#else
150133debugInvalidateHeight = False
151−#endif
152134
153−#ifdef DEBUG_TRACE_INVALIDATION
154135debugInvalidate = True
155−#else
156−debugInvalidate = False
157−#endif
158136
159137class HasNodeId a where
160138 getNodeId :: a -> Int
161139
162−instance HasNodeId (CacheSubscribed x a) where
163− getNodeId = _cacheSubscribed_nodeId
164−
165−instance HasNodeId (FanInt x a) where
166− getNodeId = _fanInt_nodeId
167−
168−instance HasNodeId (Hold x p) where
140+instance HasNodeId (Hold x p a) where
169141 getNodeId = holdNodeId
170142
143+instance HasNodeId (PushSubscribed x a b) where
144+ getNodeId = pushSubscribedNodeId
145+
171146instance HasNodeId (SwitchSubscribed x a) where
172147 getNodeId = switchSubscribedNodeId
173148
174−instance HasNodeId (FanSubscribed x v a) where
149+instance HasNodeId (FanSubscribed x a) where
175150 getNodeId = fanSubscribedNodeId
176151
177152instance HasNodeId (CoincidenceSubscribed x a) where
@@ -185,16 +160,41 @@ instance HasNodeId (Pull x a) where
185160
186161{-# INLINE showNodeId #-}
187162showNodeId :: HasNodeId a => a -> String
188−showNodeId = showNodeId' . getNodeId
189−
190−showNodeId' :: Int -> String
191−showNodeId' = ("#"<>) . show
192−
163+showNodeId = ("#"<>) . show . getNodeId
164+
165+showSubscriberType :: Subscriber x a -> String
166+showSubscriberType = \case
167+ SubscriberPush _ _ -> "SubscriberPush"
168+ SubscriberMerge _ _ -> "SubscriberMerge"
169+ SubscriberFan _ -> "SubscriberFan"
170+ SubscriberMergeChange _ -> "SubscriberMergeChange"
171+ SubscriberHold _ -> "SubscriberHold"
172+ SubscriberHoldIdentity _ -> "SubscriberHoldIdentity"
173+ SubscriberSwitch _ -> "SubscriberSwitch"
174+ SubscriberCoincidenceOuter _ -> "SubscriberCoincidenceOuter"
175+ SubscriberCoincidenceInner _ -> "SubscriberCoincidenceInner"
176+ SubscriberHandle -> "SubscriberHandle"
177+
178+showEventType :: Event x a -> String
179+showEventType = \case
180+ EventRoot _ _ -> "EventRoot"
181+ EventNever -> "EventNever"
182+ EventPush _ -> "EventPush"
183+ EventMerge _ -> "EventMerge"
184+ EventFan _ _ -> "EventFan"
185+ EventSwitch _ -> "EventSwitch"
186+ EventCoincidence _ -> "EventCoincidence"
187+ EventHold _ -> "EventHold"
188+ EventDyn _ -> "EventDyn"
189+ EventHoldIdentity _ -> "EventHoldIdentity"
190+ EventDynIdentity _ -> "EventDynIdentity"
193191
194192#else
195193
196194debugPropagate = False
195+
197196debugInvalidateHeight = False
197+
198198debugInvalidate = False
199199
200200-- This must be inline, or error messages will cause memory leaks due to retaining the node in question
@@ -202,10 +202,6 @@ debugInvalidate = False
202202showNodeId :: a -> String
203203showNodeId _ = ""
204204
205−{-# INLINE showNodeId' #-}
206−showNodeId' :: Int -> String
207−showNodeId' _ = ""
208−
209205#endif
210206
211207#ifdef DEBUG_NODEIDS
@@ -215,6 +211,12 @@ nextNodeIdRef = unsafePerformIO $ newIORef 1
215211
216212newNodeId :: IO Int
217213newNodeId = atomicModifyIORef' nextNodeIdRef $ \n -> (succ n, n)
214+
215+{-# NOINLINE unsafeNodeId #-}
216+unsafeNodeId :: a -> Int
217+unsafeNodeId a = unsafePerformIO $ do
218+ touch a
219+ newNodeId
218220#endif
219221
220222--------------------------------------------------------------------------------
@@ -251,9 +253,9 @@ subscribeAndRead = unEvent
251253-- caching; if the computation function is very cheap, this is (much) more
252254-- efficient than 'push'
253255{-# INLINE [1] pushCheap #-}
254−pushCheap :: HasSpiderTimeline x => (a -> ComputeM x (Maybe b)) -> Event x a -> Event x b
256+pushCheap :: (a -> ComputeM x (Maybe b)) -> Event x a -> Event x b
255257pushCheap !f e = Event $ \sub -> do
256− (subscription, occ) <- subscribeAndRead e $ debugSubscriber' "push" $ sub
258+ (subscription, occ) <- subscribeAndRead e $ sub
257259 { subscriberPropagate = \a -> do
258260 mb <- f a
259261 mapM_ (subscriberPropagate sub) mb
@@ -272,10 +274,10 @@ terminalSubscriber p = Subscriber
272274
273275-- | Subscribe to an Event only for the duration of one occurrence
274276{-# INLINE subscribeAndReadHead #-}
275−subscribeAndReadHead :: HasSpiderTimeline x => Event x a -> Subscriber x a -> EventM x (EventSubscription x, Maybe a)
277+subscribeAndReadHead :: Event x a -> Subscriber x a -> EventM x (EventSubscription x, Maybe a)
276278subscribeAndReadHead e sub = do
277279 subscriptionRef <- liftIO $ newIORef $ error "subscribeAndReadHead: not initialized"
278− (subscription, occ) <- subscribeAndRead e $ debugSubscriber' "head" $ sub
280+ (subscription, occ) <- subscribeAndRead e $ sub
279281 { subscriberPropagate = \a -> do
280282 liftIO $ unsubscribe =<< readIORef subscriptionRef
281283 subscriberPropagate sub a
@@ -286,42 +288,24 @@ subscribeAndReadHead e sub = do
286288 return (subscription, occ)
287289
288290--TODO: Make this lazy in its input event
289−headE :: (MonadIO m, Defer (SomeMergeInit x) m, HasSpiderTimeline x) => Event x a -> m (Event x a)
291+headE :: (MonadIO m, Defer (SomeMergeInit x) m) => Event x a -> m (Event x a)
290292headE originalE = do
291293 parent <- liftIO $ newIORef $ Just originalE
292294 defer $ SomeMergeInit $ do --TODO: Rename SomeMergeInit appropriately
293295 let clearParent = liftIO $ writeIORef parent Nothing
294− (_, occ) <- subscribeAndReadHead originalE $ terminalSubscriber $ const clearParent
296+ (_, occ) <- subscribeAndReadHead originalE $ terminalSubscriber $ \_ -> clearParent
295297 when (isJust occ) clearParent
296− return $ Event $ \sub ->
298+ return $ Event $ \sub -> do
297299 liftIO (readIORef parent) >>= \case
298− Nothing -> subscribeAndReadNever
300+ Nothing -> return (EventSubscription (return ()) $ EventSubscribed zeroRef $ toAny (), Nothing)
299301 Just e -> subscribeAndReadHead e sub
300302
301303data CacheSubscribed x a
302304 = CacheSubscribed { _cacheSubscribed_subscribers :: {-# UNPACK #-} !(FastWeakBag (Subscriber x a))
303305 , _cacheSubscribed_parent :: {-# UNPACK #-} !(EventSubscription x)
304306 , _cacheSubscribed_occurrence :: {-# UNPACK #-} !(IORef (Maybe a))
305−#ifdef DEBUG_NODEIDS
306− , _cacheSubscribed_nodeId :: {-# UNPACK #-} !Int
307−#endif
308307 }
309308
310−nowSpiderEventM :: (HasSpiderTimeline x) => EventM x (R.Event (SpiderTimeline x) ())
311−nowSpiderEventM =
312− SpiderEvent <$> now
313−
314−now :: (MonadIO m, Defer (Some Clear) m, HasSpiderTimeline x
315− ) => m (Event x ())
316−now = do
317− nowOrNot <- liftIO $ newIORef $ Just ()
318− scheduleClear nowOrNot
319− return . Event $ \_ -> do
320− occ <- liftIO . readIORef $ nowOrNot
321− return ( EventSubscription (return ()) eventSubscribedNow
322− , occ
323− )
324−
325309-- | Construct an 'Event' whose value is guaranteed not to be recomputed
326310-- repeatedly
327311--
@@ -336,33 +320,27 @@ cacheEvent e =
336320#else
337321 Event $
338322#endif
339− unsafePerformIO $ do
340− mSubscribedRef :: IORef (FastWeak (CacheSubscribed x a))
341− <- newIORef emptyFastWeak
342− pure $ \sub -> {-# SCC "cacheEvent" #-} do
323+ let mSubscribedRef :: IORef (FastWeak (CacheSubscribed x a))
324+ !mSubscribedRef = unsafeNewIORef e emptyFastWeak
325+ in \sub -> {-# SCC "cacheEvent" #-} do
343326#ifdef DEBUG_TRACE_EVENTS
344327 unless (BS8.null callSite) $ liftIO $ BS8.hPutStrLn stderr callSite
345328#endif
346329 subscribedTicket <- liftIO (readIORef mSubscribedRef >>= getFastWeakTicket) >>= \case
347330 Just subscribedTicket -> return subscribedTicket
348331 Nothing -> do
349−#ifdef DEBUG_NODEIDS
350− nodeId <- liftIO newNodeId
351−#endif
352332 subscribers <- liftIO FastWeakBag.empty
353333 occRef <- liftIO $ newIORef Nothing -- This should never be read prior to being set below
354−#ifdef DEBUG_NODEIDS
355− (parentSub, occ) <- subscribeAndRead e $ debugSubscriber' ("cacheEvent" <> showNodeId' nodeId) $ Subscriber
356−#else
357334 (parentSub, occ) <- subscribeAndRead e $ Subscriber
358−#endif
359− { subscriberPropagate = \a -> do
360− liftIO $ writeIORef occRef (Just a)
361− scheduleClear occRef
362− propagateFast a subscribers
363− , subscriberInvalidateHeight = FastWeakBag.traverse_ subscribers . invalidateSubscriberHeight
364− , subscriberRecalculateHeight = FastWeakBag.traverse_ subscribers . recalculateSubscriberHeight
365− }
335+ { subscriberPropagate = \a -> do
336+ liftIO $ writeIORef occRef $ Just a
337+ scheduleClear occRef
338+ propagateFast a subscribers
339+ , subscriberInvalidateHeight = \old -> do
340+ FastWeakBag.traverse subscribers $ invalidateSubscriberHeight old
341+ , subscriberRecalculateHeight = \new -> do
342+ FastWeakBag.traverse subscribers $ recalculateSubscriberHeight new
343+ }
366344 when (isJust occ) $ do
367345 liftIO $ writeIORef occRef occ -- Set the initial value of occRef; we don't need to do this if occ is Nothing
368346 scheduleClear occRef
@@ -370,45 +348,29 @@ cacheEvent e =
370348 { _cacheSubscribed_subscribers = subscribers
371349 , _cacheSubscribed_parent = parentSub
372350 , _cacheSubscribed_occurrence = occRef
373−#ifdef DEBUG_NODEIDS
374− , _cacheSubscribed_nodeId = nodeId
375−#endif
376351 }
377352 subscribedTicket <- liftIO $ mkFastWeakTicket subscribed
378353 liftIO $ writeIORef mSubscribedRef =<< getFastWeakTicketWeak subscribedTicket
379354 return subscribedTicket
380− liftIO $ cacheSubscription sub mSubscribedRef subscribedTicket
381−
382−cacheSubscription :: Subscriber x a -> IORef (FastWeak (CacheSubscribed x a))
383− -> FastWeakTicket (CacheSubscribed x a) -> IO (EventSubscription x, Maybe a)
384−cacheSubscription sub mSubscribedRef subscribedTicket = do
385− subscribed <- getFastWeakTicketValue subscribedTicket
386− ticket <- FastWeakBag.insert sub $ _cacheSubscribed_subscribers subscribed
387− occ <- readIORef $ _cacheSubscribed_occurrence subscribed
388−
389− let parentSub = _cacheSubscribed_parent subscribed
390− es = EventSubscription
391− { _eventSubscription_unsubscribe = do
392− FastWeakBag.remove ticket
393−
394− isEmpty <- FastWeakBag.isEmpty $ _cacheSubscribed_subscribers subscribed
395− when isEmpty $ do
396− writeIORef mSubscribedRef emptyFastWeak
397− unsubscribe parentSub
398− touch ticket
399− touch subscribedTicket
400− , _eventSubscription_subscribed = EventSubscribed
401− { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed parentSub
402− , eventSubscribedRetained = toAny subscribedTicket
403−#ifdef DEBUG_CYCLES
404− , eventSubscribedGetParents = return [_eventSubscription_subscribed parentSub]
405− , eventSubscribedHasOwnHeightRef = False
406− , eventSubscribedWhoCreated = whoCreatedIORef mSubscribedRef
407−#endif
408− }
409− }
410− return (es, occ)
411−
355+ liftIO $ do
356+ subscribed <- getFastWeakTicketValue subscribedTicket
357+ ticket <- FastWeakBag.insert sub $ _cacheSubscribed_subscribers subscribed
358+ occ <- readIORef $ _cacheSubscribed_occurrence subscribed
359+ let es = EventSubscription
360+ { _eventSubscription_unsubscribe = do
361+ FastWeakBag.remove ticket
362+ isEmpty <- FastWeakBag.isEmpty $ _cacheSubscribed_subscribers subscribed
363+ when isEmpty $ do
364+ writeIORef mSubscribedRef emptyFastWeak
365+ unsubscribe $ _cacheSubscribed_parent subscribed
366+ touch ticket
367+ touch subscribedTicket
368+ , _eventSubscription_subscribed = EventSubscribed
369+ { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed $ _cacheSubscribed_parent subscribed
370+ , eventSubscribedRetained = toAny subscribedTicket
371+ }
372+ }
373+ return (es, occ)
412374
413375subscribe :: Event x a -> Subscriber x a -> EventM x (EventSubscription x)
414376subscribe e s = fst <$> subscribeAndRead e s
@@ -420,14 +382,11 @@ wrap tag getSpecificSubscribed sub = do
420382 let es = tag subd
421383 return (EventSubscription (WeakBag.remove sln >> touch sln) es, occ)
422384
423−eventRoot :: (GCompare k, HasSpiderTimeline x) => k a -> Root x k -> Event x a
385+eventRoot :: GCompare k => k a -> Root x k -> Event x a
424386eventRoot !k !r = Event $ wrap eventSubscribedRoot $ liftIO . getRootSubscribed k r
425387
426−subscribeAndReadNever :: EventM x (EventSubscription x, Maybe a)
427−subscribeAndReadNever = return (EventSubscription (return ()) eventSubscribedNever, Nothing)
428−
429388eventNever :: Event x a
430−eventNever = Event $ const subscribeAndReadNever
389+eventNever = Event $ \_ -> return (EventSubscription (return ()) eventSubscribedNever, Nothing)
431390
432391eventFan :: (GCompare k, HasSpiderTimeline x) => k a -> Fan x k v -> Event x (v a)
433392eventFan !k !f = Event $ wrap eventSubscribedFan $ getFanSubscribed k f
@@ -464,6 +423,16 @@ data Subscriber x a = Subscriber
464423 , subscriberRecalculateHeight :: !(Height -> IO ())
465424 }
466425
426+--TODO: Move this comment to WeakBag
427+-- These function are constructor functions that are marked NOINLINE so they are
428+-- opaque to GHC. If we do not do this, then GHC will sometimes fuse the constructor away
429+-- so any weak references that are attached to the constructors will have their
430+-- finalizer run. Using the opaque constructor, does not see the
431+-- constructor application, so it behaves like an IORef and cannot be fused away.
432+--
433+-- The result is also evaluated to WHNF, since forcing a thunk invalidates
434+-- the weak pointer to it in some cases.
435+
467436newSubscriberHold :: (HasSpiderTimeline x, Patch p) => Hold x p -> IO (Subscriber x p)
468437newSubscriberHold h = return $ Subscriber
469438 { subscriberPropagate = {-# SCC "traverseHold" #-} propagateSubscriberHold h
@@ -472,10 +441,10 @@ newSubscriberHold h = return $ Subscriber
472441 }
473442
474443newSubscriberFan :: forall x k v. (HasSpiderTimeline x, GCompare k) => FanSubscribed x k v -> IO (Subscriber x (DMap k v))
475−newSubscriberFan subscribed = debugSubscriber ("SubscriberFan " <> showNodeId subscribed) $ Subscriber
444+newSubscriberFan subscribed = return $ Subscriber
476445 { subscriberPropagate = \a -> {-# SCC "traverseFan" #-} do
477446 subs <- liftIO $ readIORef $ fanSubscribedSubscribers subscribed
478− tracePropagate (Proxy :: Proxy x) $ show (DMap.size subs) <> " keys subscribed, " <> show (DMap.size a) <> " keys firing"
447+ tracePropagate (Proxy :: Proxy x) $ "SubscriberFan" <> showNodeId subscribed <> ": " ++ show (DMap.size subs) ++ " keys subscribed, " ++ show (DMap.size a) ++ " keys firing"
479448 liftIO $ writeIORef (fanSubscribedOccurrence subscribed) $ Just a
480449 scheduleClear $ fanSubscribedOccurrence subscribed
481450 let f _ (Pair v subsubs) = do
@@ -484,55 +453,72 @@ newSubscriberFan subscribed = debugSubscriber ("SubscriberFan " <> showNodeId su
484453 _ <- DMap.traverseWithKey f $ DMap.intersectionWithKey (\_ -> Pair) a subs --TODO: Would be nice to have DMap.traverse_
485454 return ()
486455 , subscriberInvalidateHeight = \old -> do
456+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberFan" <> showNodeId subscribed
487457 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
488− forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse_ (_fanSubscribedChildren_list v) $ invalidateSubscriberHeight old
458+ forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse (_fanSubscribedChildren_list v) $ invalidateSubscriberHeight old
459+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberFan" <> showNodeId subscribed <> " done"
489460 , subscriberRecalculateHeight = \new -> do
461+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberFan" <> showNodeId subscribed
490462 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
491− forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse_ (_fanSubscribedChildren_list v) $ recalculateSubscriberHeight new
463+ forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse (_fanSubscribedChildren_list v) $ recalculateSubscriberHeight new
464+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberFan" <> showNodeId subscribed <> " done"
492465 }
493466
494467newSubscriberSwitch :: forall x a. HasSpiderTimeline x => SwitchSubscribed x a -> IO (Subscriber x a)
495−newSubscriberSwitch subscribed = debugSubscriber ("SubscriberCoincidenceOuter" <> showNodeId subscribed) $ Subscriber
468+newSubscriberSwitch subscribed = return $ Subscriber
496469 { subscriberPropagate = \a -> {-# SCC "traverseSwitch" #-} do
470+ tracePropagate (Proxy :: Proxy x) $ "SubscriberSwitch" <> showNodeId subscribed
497471 liftIO $ writeIORef (switchSubscribedOccurrence subscribed) $ Just a
498472 scheduleClear $ switchSubscribedOccurrence subscribed
499473 propagate a $ switchSubscribedSubscribers subscribed
500474 , subscriberInvalidateHeight = \_ -> do
475+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed
501476 oldHeight <- readIORef $ switchSubscribedHeight subscribed
502477 when (oldHeight /= invalidHeight) $ do
503478 writeIORef (switchSubscribedHeight subscribed) $! invalidHeight
504− WeakBag.traverse_ (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
505− , subscriberRecalculateHeight = (`updateSwitchHeight` subscribed)
506− }
479+ WeakBag.traverse (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
480+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed <> " done"
481+ , subscriberRecalculateHeight = \new -> do
482+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed
483+ updateSwitchHeight new subscribed
484+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed <> " done"
485+ }
507486
508487newSubscriberCoincidenceOuter :: forall x b. HasSpiderTimeline x => CoincidenceSubscribed x b -> IO (Subscriber x (Event x b))
509−newSubscriberCoincidenceOuter subscribed = debugSubscriber ("SubscriberCoincidenceOuter" <> showNodeId subscribed) $ Subscriber
488+newSubscriberCoincidenceOuter subscribed = return $ Subscriber
510489 { subscriberPropagate = \a -> {-# SCC "traverseCoincidenceOuter" #-} do
490+ tracePropagate (Proxy :: Proxy x) $ "SubscriberCoincidenceOuter" <> showNodeId subscribed
511491 outerHeight <- liftIO $ readIORef $ coincidenceSubscribedHeight subscribed
512492 tracePropagate (Proxy :: Proxy x) $ " outerHeight = " <> show outerHeight
513493 (occ, innerHeight, innerSubd) <- subscribeCoincidenceInner a outerHeight subscribed
514494 tracePropagate (Proxy :: Proxy x) $ " isJust occ = " <> show (isJust occ)
515495 tracePropagate (Proxy :: Proxy x) $ " innerHeight = " <> show innerHeight
516−
517496 liftIO $ writeIORef (coincidenceSubscribedInnerParent subscribed) $ Just innerSubd
518497 scheduleClear $ coincidenceSubscribedInnerParent subscribed
519498 case occ of
520− Nothing ->
499+ Nothing -> do
521500 when (innerHeight > outerHeight) $ liftIO $ do -- If the event fires, it will fire at a later height
522501 writeIORef (coincidenceSubscribedHeight subscribed) $! innerHeight
523− WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight outerHeight
524− WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ recalculateSubscriberHeight innerHeight
502+ WeakBag.traverse (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight outerHeight
503+ WeakBag.traverse (coincidenceSubscribedSubscribers subscribed) $ recalculateSubscriberHeight innerHeight
525504 Just o -> do -- Since it's already firing, no need to adjust height
526505 liftIO $ writeIORef (coincidenceSubscribedOccurrence subscribed) occ
527506 scheduleClear $ coincidenceSubscribedOccurrence subscribed
528507 propagate o $ coincidenceSubscribedSubscribers subscribed
529− , subscriberInvalidateHeight = \_ -> invalidateCoincidenceHeight subscribed
530− , subscriberRecalculateHeight = \_ -> recalculateCoincidenceHeight subscribed
508+ , subscriberInvalidateHeight = \_ -> do
509+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed
510+ invalidateCoincidenceHeight subscribed
511+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed <> " done"
512+ , subscriberRecalculateHeight = \_ -> do
513+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed
514+ recalculateCoincidenceHeight subscribed
515+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed <> " done"
531516 }
532517
533518newSubscriberCoincidenceInner :: forall x a. HasSpiderTimeline x => CoincidenceSubscribed x a -> IO (Subscriber x a)
534−newSubscriberCoincidenceInner subscribed = debugSubscriber ("SubscriberCoincidenceInner" <> showNodeId subscribed) $ Subscriber
519+newSubscriberCoincidenceInner subscribed = return $ Subscriber
535520 { subscriberPropagate = \a -> {-# SCC "traverseCoincidenceInner" #-} do
521+ tracePropagate (Proxy :: Proxy x) $ "SubscriberCoincidenceInner" <> showNodeId subscribed
536522 occ <- liftIO $ readIORef $ coincidenceSubscribedOccurrence subscribed
537523 case occ of
538524 Just _ -> return () -- SubscriberCoincidenceOuter must have already propagated this event
@@ -540,8 +526,14 @@ newSubscriberCoincidenceInner subscribed = debugSubscriber ("SubscriberCoinciden
540526 liftIO $ writeIORef (coincidenceSubscribedOccurrence subscribed) $ Just a
541527 scheduleClear $ coincidenceSubscribedOccurrence subscribed
542528 propagate a $ coincidenceSubscribedSubscribers subscribed
543− , subscriberInvalidateHeight = \_ -> invalidateCoincidenceHeight subscribed
544− , subscriberRecalculateHeight = \_ -> recalculateCoincidenceHeight subscribed
529+ , subscriberInvalidateHeight = \_ -> do
530+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed
531+ invalidateCoincidenceHeight subscribed
532+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed <> " done"
533+ , subscriberRecalculateHeight = \_ -> do
534+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed
535+ recalculateCoincidenceHeight subscribed
536+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed <> " done"
545537 }
546538
547539invalidateSubscriberHeight :: Height -> Subscriber x a -> IO ()
@@ -551,18 +543,18 @@ recalculateSubscriberHeight :: Height -> Subscriber x a -> IO ()
551543recalculateSubscriberHeight = flip subscriberRecalculateHeight
552544
553545-- | Propagate everything at the current height
554−propagate :: forall x a. HasSpiderTimeline x => a -> WeakBag (Subscriber x a) -> EventM x ()
555−propagate a subscribers = withIncreasedDepth (Proxy::Proxy x) $
546+propagate :: a -> WeakBag (Subscriber x a) -> EventM x ()
547+propagate a subscribers = withIncreasedDepth $ do
556548 -- Note: in the following traversal, we do not visit nodes that are added to the list during our traversal; they are new events, which will necessarily have full information already, so there is no need to traverse them
557549 --TODO: Should we check if nodes already have their values before propagating? Maybe we're re-doing work
558− WeakBag.traverse_ subscribers $ \s -> subscriberPropagate s a
550+ WeakBag.traverse subscribers $ \s -> subscriberPropagate s a
559551
560552-- | Propagate everything at the current height
561−propagateFast :: forall x a. HasSpiderTimeline x => a -> FastWeakBag (Subscriber x a) -> EventM x ()
562−propagateFast a subscribers = withIncreasedDepth (Proxy::Proxy x) $
553+propagateFast :: a -> FastWeakBag (Subscriber x a) -> EventM x ()
554+propagateFast a subscribers = withIncreasedDepth $ do
563555 -- Note: in the following traversal, we do not visit nodes that are added to the list during our traversal; they are new events, which will necessarily have full information already, so there is no need to traverse them
564556 --TODO: Should we check if nodes already have their values before propagating? Maybe we're re-doing work
565− FastWeakBag.traverse_ subscribers $ \s -> subscriberPropagate s a
557+ FastWeakBag.traverse subscribers $ \s -> subscriberPropagate s a
566558
567559--------------------------------------------------------------------------------
568560-- EventSubscribed
@@ -580,7 +572,7 @@ data EventSubscribed x = EventSubscribed
580572 { eventSubscribedHeightRef :: {-# UNPACK #-} !(IORef Height)
581573 , eventSubscribedRetained :: {-# NOUNPACK #-} !Any
582574#ifdef DEBUG_CYCLES
583− , eventSubscribedGetParents :: !(IO [EventSubscribed x]) -- For debugging loops
575+ , eventSubscribedGetParents :: !(IO [Some (EventSubscribed x)]) -- For debugging loops
584576 , eventSubscribedHasOwnHeightRef :: !Bool
585577 , eventSubscribedWhoCreated :: !(IO [String])
586578#endif
@@ -607,23 +599,13 @@ eventSubscribedNever = EventSubscribed
607599 , eventSubscribedWhoCreated = return ["never"]
608600#endif
609601 }
610−eventSubscribedNow :: EventSubscribed x
611−eventSubscribedNow = EventSubscribed
612− { eventSubscribedHeightRef = zeroRef
613− , eventSubscribedRetained = toAny ()
614−#ifdef DEBUG_CYCLES
615− , eventSubscribedGetParents = return []
616− , eventSubscribedHasOwnHeightRef = False
617− , eventSubscribedWhoCreated = return ["now"]
618−#endif
619− }
620602
621603eventSubscribedFan :: FanSubscribed x k v -> EventSubscribed x
622604eventSubscribedFan !subscribed = EventSubscribed
623605 { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed $ fanSubscribedParent subscribed
624606 , eventSubscribedRetained = toAny subscribed
625607#ifdef DEBUG_CYCLES
626− , eventSubscribedGetParents = return [_eventSubscription_subscribed $ fanSubscribedParent subscribed]
608+ , eventSubscribedGetParents = return [Some $ _eventSubscription_subscribed $ fanSubscribedParent subscribed]
627609 , eventSubscribedHasOwnHeightRef = False
628610 , eventSubscribedWhoCreated = whoCreatedIORef $ fanSubscribedCachedSubscribed subscribed
629611#endif
@@ -636,7 +618,7 @@ eventSubscribedSwitch !subscribed = EventSubscribed
636618#ifdef DEBUG_CYCLES
637619 , eventSubscribedGetParents = do
638620 s <- readIORef $ switchSubscribedCurrentParent subscribed
639− return [_eventSubscription_subscribed s]
621+ return [Some $ _eventSubscription_subscribed s]
640622 , eventSubscribedHasOwnHeightRef = True
641623 , eventSubscribedWhoCreated = whoCreatedIORef $ switchSubscribedCachedSubscribed subscribed
642624#endif
@@ -649,8 +631,8 @@ eventSubscribedCoincidence !subscribed = EventSubscribed
649631#ifdef DEBUG_CYCLES
650632 , eventSubscribedGetParents = do
651633 innerSubscription <- readIORef $ coincidenceSubscribedInnerParent subscribed
652− let outerParent = _eventSubscription_subscribed $ coincidenceSubscribedOuterParent subscribed
653− innerParents = maybeToList $ innerSubscription
634+ let outerParent = Some $ _eventSubscription_subscribed $ coincidenceSubscribedOuterParent subscribed
635+ innerParents = maybeToList $ fmap Some innerSubscription
654636 return $ outerParent : innerParents
655637 , eventSubscribedHasOwnHeightRef = True
656638 , eventSubscribedWhoCreated = whoCreatedIORef $ coincidenceSubscribedCachedSubscribed subscribed
@@ -664,15 +646,15 @@ getEventSubscribedHeight es = readIORef $ eventSubscribedHeightRef es
664646whoCreatedEventSubscribed :: EventSubscribed x -> IO [String]
665647whoCreatedEventSubscribed = eventSubscribedWhoCreated
666648
667−walkInvalidHeightParents :: EventSubscribed x -> IO [EventSubscribed x]
649+walkInvalidHeightParents :: EventSubscribed x -> IO [Some (EventSubscribed x)]
668650walkInvalidHeightParents s0 = do
669− subscribers <- flip execStateT mempty $ ($ s0) $ fix $ \loop s -> do
651+ subscribers <- flip execStateT mempty $ ($ Some s0) $ fix $ \loop (Some s) -> do
670652 h <- liftIO $ readIORef $ eventSubscribedHeightRef s
671653 when (h == invalidHeight) $ do
672654 when (eventSubscribedHasOwnHeightRef s) $ liftIO $ writeIORef (eventSubscribedHeightRef s) $! invalidHeightBeingTraversed
673− modify (s :)
655+ modify (Some s :)
674656 mapM_ loop =<< liftIO (eventSubscribedGetParents s)
675− forM_ subscribers $ \s -> writeIORef (eventSubscribedHeightRef s) $! invalidHeight
657+ forM_ subscribers $ \(Some s) -> writeIORef (eventSubscribedHeightRef s) $! invalidHeight
676658 return subscribers
677659#endif
678660
@@ -994,10 +976,8 @@ instance Monad (BehaviorM x) where
994976 BehaviorM x >> BehaviorM y = BehaviorM $ x >> y
995977 {-# INLINE return #-}
996978 return x = BehaviorM $ return x
997−#if !MIN_VERSION_base(4,13,0)
998979 {-# INLINE fail #-}
999980 fail s = BehaviorM $ fail s
1000−#endif
1001981
1002982data BehaviorSubscribed x a
1003983 = forall p. BehaviorSubscribedHold (Hold x p)
@@ -1057,7 +1037,7 @@ data SomeMergeUpdate x = SomeMergeUpdate
10571037newtype SomeMergeInit x = SomeMergeInit { unSomeMergeInit :: EventM x () }
10581038
10591039-- EventM can do everything BehaviorM can, plus create holds
1060−newtype EventM x a = EventM { unEventM :: IO a } deriving (Functor, Applicative, Monad, MonadIO, MonadFix, MonadException, MonadAsyncException)
1040+newtype EventM x a = EventM { unEventM :: IO a } deriving (Functor, Applicative, Monad, MonadIO, MonadFix, MonadException, MonadAsyncException) -- The environment should be Nothing if we are not in a frame, and Just if we are - in which case it is a list of assignments to be done after the frame is over
10611041
10621042newtype MergeSubscribedParent x a = MergeSubscribedParent { unMergeSubscribedParent :: EventSubscription x }
10631043
@@ -1082,8 +1062,7 @@ heightBagFromList :: [Height] -> HeightBag
10821062heightBagFromList heights = heightBagVerify $ foldl' (flip heightBagAdd) heightBagEmpty heights
10831063
10841064heightBagAdd :: Height -> HeightBag -> HeightBag
1085−heightBagAdd (Height h) (HeightBag s c) = heightBagVerify $ HeightBag (succ s) $
1086− IntMap.insertWithKey (\_ _ old -> succ old) h 0 c
1065+heightBagAdd (Height h) (HeightBag s c) = heightBagVerify $ HeightBag (succ s) $ IntMap.insertWithKey (\_ _ old -> succ old) h 0 c
10871066
10881067heightBagRemove :: Height -> HeightBag -> HeightBag
10891068heightBagRemove (Height h) b@(HeightBag s c) = heightBagVerify $ case IntMap.lookup h c of
@@ -1092,13 +1071,6 @@ heightBagRemove (Height h) b@(HeightBag s c) = heightBagVerify $ case IntMap.loo
10921071 0 -> IntMap.delete h c
10931072 _ -> IntMap.insert h (pred old) c
10941073
1095−heightBagRemoveMaybe :: Height -> HeightBag -> Maybe HeightBag
1096−heightBagRemoveMaybe (Height h) b@(HeightBag s c) = heightBagVerify . removed <$> IntMap.lookup h c where
1097− removed old = HeightBag (pred s) $ case old of
1098− 0 -> IntMap.delete h c
1099− _ -> IntMap.insert h (pred old) c
1100−
1101−
11021074heightBagMax :: HeightBag -> Height
11031075heightBagMax (HeightBag _ c) = case IntMap.maxViewWithKey c of
11041076 Just ((h, _), _) -> Height h
@@ -1239,12 +1211,18 @@ buildDynamic readV0 v' = do
12391211 return d
12401212
12411213unsafeBuildDynamic :: BehaviorM x (PatchTarget p) -> Event x p -> Dyn x p
1242−unsafeBuildDynamic readV0 v' =
1243− Dyn $ unsafePerformIO $ newIORef $ UnsafeDyn (readV0, v')
1214+unsafeBuildDynamic readV0 v' = Dyn $ unsafeNewIORef x $ UnsafeDyn x
1215+ where x = (readV0, v')
12441216
12451217-- ResultM can read behaviors and events
12461218type ResultM = EventM
12471219
1220+{-# NOINLINE unsafeNewIORef #-}
1221+unsafeNewIORef :: a -> b -> IORef b
1222+unsafeNewIORef a b = unsafePerformIO $ do
1223+ touch a
1224+ newIORef b
1225+
12481226instance HasSpiderTimeline x => Functor (Event x) where
12491227 fmap f = push $ return . Just . f
12501228
@@ -1257,35 +1235,26 @@ push f e = cacheEvent (pushCheap f e)
12571235
12581236{-# INLINABLE pull #-}
12591237pull :: BehaviorM x a -> Behavior x a
1260−pull a = unsafePerformIO $ do
1261− ref <- newIORef Nothing
1238+pull a = behaviorPull $ Pull
1239+ { pullCompute = a
1240+ , pullValue = unsafeNewIORef a Nothing
12621241#ifdef DEBUG_NODEIDS
1263− nid <- newNodeId
1242+ , pullNodeId = unsafeNodeId a
12641243#endif
1265− pure $ behaviorPull $ Pull
1266− { pullCompute = a
1267− , pullValue = ref
1268−#ifdef DEBUG_NODEIDS
1269− , pullNodeId = nid
1270−#endif
1271− }
1244+ }
12721245
12731246{-# INLINABLE switch #-}
12741247switch :: HasSpiderTimeline x => Behavior x (Event x a) -> Event x a
1275−switch a = unsafePerformIO $ do
1276− ref <- newIORef Nothing
1277− pure $ eventSwitch $ Switch
1278− { switchParent = a
1279− , switchSubscribed = ref
1280− }
1248+switch a = eventSwitch $ Switch
1249+ { switchParent = a
1250+ , switchSubscribed = unsafeNewIORef a Nothing
1251+ }
12811252
12821253coincidence :: HasSpiderTimeline x => Event x (Event x a) -> Event x a
1283−coincidence a = unsafePerformIO $ do
1284− ref <- newIORef Nothing
1285− pure $ eventCoincidence $ Coincidence
1286− { coincidenceParent = a
1287− , coincidenceSubscribed = ref
1288− }
1254+coincidence a = eventCoincidence $ Coincidence
1255+ { coincidenceParent = a
1256+ , coincidenceSubscribed = unsafeNewIORef a Nothing
1257+ }
12891258
12901259-- Propagate the given event occurrence; before cleaning up, run the given action, which may read the state of events and behaviors
12911260run :: forall x b. HasSpiderTimeline x => [DSum (RootTrigger x) Identity] -> ResultM x b -> SpiderHost x b
@@ -1346,110 +1315,55 @@ mkWeakPtrWithDebug x debugNote = do
13461315 x' <- evaluate x
13471316 mkWeakPtr x' $
13481317 if debugFinalize
1349− then Just $ debugStrLn $ "finalizing: " ++ debugNote
1318+ then Just $ putStrLn $ "finalizing: " ++ debugNote
13501319 else Nothing
13511320
13521321type WeakList a = [Weak a]
13531322
1354−type CanTrace x m = (HasSpiderTimeline x, MonadIO m)
1355−
1356−
1357−
1358−
1359−#ifdef DEBUG
1360−
1361−debugSubscriber :: forall x a. HasSpiderTimeline x => String -> Subscriber x a -> IO (Subscriber x a)
1362−debugSubscriber description = return . debugSubscriber' description
1363−
1364−debugSubscriber' :: forall x a. HasSpiderTimeline x => String -> Subscriber x a -> Subscriber x a
1365−debugSubscriber' description subscribed = Subscriber
1366− {
1367− subscriberPropagate = \m -> do
1368− tracePropagate (Proxy :: Proxy x) ("subscriberPropagate: " <> description)
1369− subscriberPropagate subscribed m
1370− , subscriberInvalidateHeight = \old -> do
1371− traceInvalidateHeight $ "invalidateSubscriberHeight: " <> description <> ", old = " <> show (unHeight old)
1372− subscriberInvalidateHeight subscribed old
1373− traceInvalidateHeight $ "invalidateSubscriberHeight: " <> description <> ", done"
1374− , subscriberRecalculateHeight = \new -> do
1375− traceInvalidateHeight $ "subscriberRecalculateHeight: " <> description <> ", new = " <> show (unHeight new)
1376− subscriberRecalculateHeight subscribed new
1377− traceInvalidateHeight $ "subscriberRecalculateHeight: " <> description <> ", done"
1378− }
1379−
1380−
13811323{-# INLINE withIncreasedDepth #-}
1382−withIncreasedDepth :: forall proxy x m a. CanTrace x m => proxy x -> m a -> m a
1383−withIncreasedDepth _ a = do
1384− liftIO $ modifyIORef' (_spiderTimeline_depth $ unSTE (spiderTimeline :: SpiderTimelineEnv x)) succ
1324+#ifdef DEBUG
1325+withIncreasedDepth :: CanTrace x m => m a -> m a
1326+withIncreasedDepth a = do
1327+ spiderTimeline <- askSpiderTimelineEnv
1328+ liftIO $ modifyIORef' (_spiderTimeline_depth (unSTE spiderTimeline)) succ
13851329 result <- a
1386− liftIO $ modifyIORef' (_spiderTimeline_depth $ unSTE (spiderTimeline :: SpiderTimelineEnv x)) pred
1330+ liftIO $ modifyIORef' (_spiderTimeline_depth (unSTE spiderTimeline)) pred
13871331 return result
1388−
1389−{-# INLINE tracePropagate #-}
1390−tracePropagate :: (CanTrace x m) => proxy x -> String -> m ()
1391−tracePropagate p = when debugPropagate . trace p
1392−
1393−{-# INLINE traceInvalidate #-}
1394−traceInvalidate :: String -> IO ()
1395−traceInvalidate = when debugInvalidate . liftIO . debugStrLn
1396−
1397−{-# INLINE traceInvalidateHeight #-}
1398−traceInvalidateHeight :: String -> IO ()
1399−traceInvalidateHeight = when debugInvalidateHeight . liftIO . debugStrLn
1400−
1401−{-# INLINE trace #-}
1402−trace :: (CanTrace x m) => proxy x -> String -> m ()
1403−trace p message = traceM p $ return message
1404−
1405−{-# INLINE traceM #-}
1406−traceM :: forall x proxy m. (CanTrace x m) => proxy x -> m String -> m ()
1407−traceM _ getMessage = do
1408− message <- getMessage
1409− d <- liftIO $ readIORef $ _spiderTimeline_depth $ unSTE (spiderTimeline :: SpiderTimelineEnv x)
1410− liftIO $ debugStrLn $ replicate d ' ' <> message
1411−
14121332#else
1333+withIncreasedDepth :: m a -> m a
1334+withIncreasedDepth = id
1335+#endif
14131336
1414−{-# INLINE withIncreasedDepth #-}
1415−withIncreasedDepth :: proxy x -> m a -> m a
1416−withIncreasedDepth _ = id
1337+type CanTrace x m = (HasSpiderTimeline x, MonadIO m)
14171338
14181339{-# INLINE tracePropagate #-}
14191340tracePropagate :: (CanTrace x m) => proxy x -> String -> m ()
1420−tracePropagate _ _ = return ()
1341+tracePropagate p = traceWhen p debugPropagate
14211342
14221343{-# INLINE traceInvalidate #-}
14231344traceInvalidate :: String -> IO ()
1424−traceInvalidate _ = return ()
1425−
1426−{-# INLINE traceInvalidateHeight #-}
1427−traceInvalidateHeight :: String -> IO ()
1428−traceInvalidateHeight _ = return ()
1345+traceInvalidate = when debugInvalidate . liftIO . putStrLn
14291346
1430−{-# INLINE debugSubscriber #-}
1431−debugSubscriber :: String -> Subscriber x a -> IO (Subscriber x a)
1432−debugSubscriber _ = return
1433−
1434−{-# INLINE debugSubscriber' #-}
1435−debugSubscriber' :: String -> Subscriber x a -> Subscriber x a
1436−debugSubscriber' _ = id
1437−
1438−
1439−
1440−{-# INLINE trace #-}
1441−trace :: (CanTrace x m) => proxy x -> String -> m ()
1442−trace _ _ = return ()
1443−
1444−{-# INLINE traceM #-}
1445−traceM :: (CanTrace x m) => proxy x -> m String -> m ()
1446−traceM _ _ = return ()
1347+{-# INLINE traceWhen #-}
1348+traceWhen :: (CanTrace x m) => proxy x -> Bool -> String -> m ()
1349+traceWhen p b message = traceMWhen p b $ return message
14471350
1351+{-# INLINE traceMWhen #-}
1352+traceMWhen :: (CanTrace x m) => proxy x -> Bool -> m String -> m ()
1353+traceMWhen _ b getMessage = when b $ do
1354+ message <- getMessage
1355+#ifdef DEBUG
1356+ spiderTimeline <- askSpiderTimelineEnv
1357+ d <- liftIO $ readIORef $ _spiderTimeline_depth $ unSTE spiderTimeline
1358+#else
1359+ let d = 0
14481360#endif
1361+ liftIO $ putStrLn $ replicate d ' ' <> message
14491362
14501363whoCreatedIORef :: IORef a -> IO [String]
14511364whoCreatedIORef (IORef a) = whoCreated $! a
14521365
1366+#ifdef DEBUG_CYCLES
14531367groupByHead :: Eq a => [NonEmpty a] -> [(a, NonEmpty [a])]
14541368groupByHead = \case
14551369 [] -> []
@@ -1460,54 +1374,20 @@ groupByHead = \case
14601374 | otherwise -> (x, xs :| []) : l
14611375
14621376listsToForest :: Eq a => [[a]] -> Forest a
1463−listsToForest lists = buildForest <$> groupByHead (mapMaybe nonEmpty lists)
1464− where buildForest (a, lists') = Node a $ listsToForest $ toList lists'
1465−
1466−showStacks :: [[String]] -> String
1467−showStacks = drawForest . listsToForest . fmap (filterStack "Reflex.Spider.Internal")
1468−
1469−filterStack :: String -> [String] -> [String]
1470−#ifdef DEBUG_HIDE_INTERNALS
1471−filterStack prefix = filter (not . (prefix `isPrefixOf`))
1472−#else
1473−filterStack prefix = id
1377+listsToForest l = fmap (\(a, l') -> Node a $ listsToForest $ toList l') $ groupByHead $ catMaybes $ fmap nonEmpty l
14741378#endif
14751379
1476−#ifdef DEBUG_CYCLES
1477−
1478−data EventLoopException = EventLoopException [[String]]
1479−instance Exception EventLoopException
1480−
1481−instance Show EventLoopException where
1482− show (EventLoopException stacks) = "causality loop detected:\n" <> if null stacks
1483− then "no location information, compile with profiling enabled for stack tree"
1484− else showStacks stacks
1485−
1486−#else
1487−
1488−data EventLoopException = EventLoopException
1489−instance Exception EventLoopException
1490−
1491−instance Show EventLoopException where
1492− show EventLoopException = "causality loop detected: \n" <>
1493− "compile reflex with flag 'debug-cycles' and compile with profiling enabled for stack tree"
1494−
1495−#endif
1496−
1497−
14981380{-# INLINE propagateSubscriberHold #-}
14991381propagateSubscriberHold :: forall x p. (HasSpiderTimeline x, Patch p) => Hold x p -> p -> EventM x ()
15001382propagateSubscriberHold h a = do
1501− {-# SCC "trace" #-} when debugPropagate $ traceM (Proxy :: Proxy x) $ liftIO $ do
1383+ {-# SCC "trace" #-} traceMWhen (Proxy :: Proxy x) debugPropagate $ liftIO $ do
15021384 invalidators <- liftIO $ readIORef $ holdInvalidators h
15031385 return $ "SubscriberHold" <> showNodeId h <> ": " ++ show (length invalidators)
1504−
15051386 v <- {-# SCC "read" #-} liftIO $ readIORef $ holdValue h
15061387 case {-# SCC "apply" #-} apply a v of
15071388 Nothing -> return ()
15081389 Just v' -> do
1509− {-# SCC "trace2" #-} withIncreasedDepth (Proxy :: Proxy x) $
1510− tracePropagate (Proxy :: Proxy x) ("propagateSubscriberHold: assigning Hold" <> showNodeId h)
1390+ {-# SCC "trace2" #-} withIncreasedDepth $ tracePropagate (Proxy :: Proxy x) $ "propagateSubscriberHold: assigning Hold" <> showNodeId h
15111391 vRef <- {-# SCC "vRef" #-} liftIO $ evaluate $ holdValue h
15121392 iRef <- {-# SCC "iRef" #-} liftIO $ evaluate $ holdInvalidators h
15131393 defer $ {-# SCC "assignment" #-} SomeAssignment vRef iRef v'
@@ -1561,7 +1441,7 @@ getDynHold d = do
15611441zeroRef :: IORef Height
15621442zeroRef = unsafePerformIO $ newIORef zeroHeight
15631443
1564−getRootSubscribed :: forall k x a. (GCompare k, HasSpiderTimeline x) => k a -> Root x k -> Subscriber x a -> IO (WeakBagTicket, RootSubscribed x a, Maybe a)
1444+getRootSubscribed :: GCompare k => k a -> Root x k -> Subscriber x a -> IO (WeakBagTicket, RootSubscribed x a, Maybe a)
15651445getRootSubscribed k r sub = do
15661446 mSubscribed <- readIORef $ rootSubscribed r
15671447 let getOcc = fmap (coerce . DMap.lookup k) $ readIORef $ rootOccurrence r
@@ -1575,14 +1455,9 @@ getRootSubscribed k r sub = do
15751455 let !cached = rootSubscribed r
15761456 uninitRef <- newIORef $ error "getRootsubscribed: uninitRef not initialized"
15771457 (subs, sln) <- WeakBag.singleton sub weakSelf cleanupRootSubscribed
1578−
1579− tracePropagate (Proxy::Proxy x) $ "getRootSubscribed: calling rootInit"
1580−
1458+ when debugPropagate $ putStrLn $ "getRootSubscribed: calling rootInit"
15811459 uninit <- rootInit r k $ RootTrigger (subs, rootOccurrence r, k)
15821460 writeIORef uninitRef $! uninit
1583−#ifdef DEBUG_NODEIDS
1584− nid <- newNodeId
1585−#endif
15861461 let !subscribed = RootSubscribed
15871462 { rootSubscribedKey = k
15881463 , rootSubscribedCachedSubscribed = cached
@@ -1591,7 +1466,7 @@ getRootSubscribed k r sub = do
15911466 , rootSubscribedUninit = uninit
15921467 , rootSubscribedWeakSelf = weakSelf
15931468#ifdef DEBUG_NODEIDS
1594− , rootSubscribedNodeId = nid
1469+ , rootSubscribedNodeId = unsafeNodeId (k, r, subs)
15951470#endif
15961471 }
15971472 -- If we die at the same moment that all our children die, they will
@@ -1627,9 +1502,6 @@ data FanInt x a = FanInt
16271502 { _fanInt_subscribers :: {-# UNPACK #-} !(FastMutableIntMap (FastWeakBag (Subscriber x a))) --TODO: Clean up the keys in here when their child weak bags get empty --TODO: Remove our own subscription when the subscribers list is completely empty
16281503 , _fanInt_subscriptionRef :: {-# UNPACK #-} !(IORef (EventSubscription x)) -- This should have a valid subscription iff subscribers is non-empty
16291504 , _fanInt_occRef :: {-# UNPACK #-} !(IORef (IntMap a))
1630−#ifdef DEBUG_NODEIDS
1631− , _fanInt_nodeId :: {-# UNPACK #-} !Int
1632−#endif
16331505 }
16341506
16351507newFanInt :: IO (FanInt x a)
@@ -1637,39 +1509,38 @@ newFanInt = do
16371509 subscribers <- FastMutableIntMap.newEmpty --TODO: Clean up the keys in here when their child weak bags get empty --TODO: Remove our own subscription when the subscribers list is completely empty
16381510 subscriptionRef <- newIORef $ error "fanInt: no subscription"
16391511 occRef <- newIORef $ error "fanInt: no occurrence"
1640−#ifdef DEBUG_NODEIDS
1641− nodeId <- newNodeId
1642−#endif
16431512 return $ FanInt
16441513 { _fanInt_subscribers = subscribers
16451514 , _fanInt_subscriptionRef = subscriptionRef
16461515 , _fanInt_occRef = occRef
1647−#ifdef DEBUG_NODEIDS
1648− , _fanInt_nodeId = nodeId
1649−#endif
16501516 }
16511517
1518+{-# NOINLINE unsafeNewFanInt #-}
1519+unsafeNewFanInt :: b -> FanInt x a
1520+unsafeNewFanInt b = unsafePerformIO $ do
1521+ touch b
1522+ newFanInt
1523+
16521524fanInt :: HasSpiderTimeline x => Event x (IntMap a) -> EventSelectorInt x a
1653−fanInt p = unsafePerformIO $ do
1654− self <- newFanInt
1655− pure $ EventSelectorInt $ \k -> Event $ \sub -> do
1525+fanInt p =
1526+ let self = unsafeNewFanInt p
1527+ in EventSelectorInt $ \k -> Event $ \sub -> do
16561528 isEmpty <- liftIO $ FastMutableIntMap.isEmpty (_fanInt_subscribers self)
16571529 when isEmpty $ do -- This is the first subscriber, so we need to subscribe to our input
1658− let desc = "fanInt" <> showNodeId self <> ", k = " <> show k
1659− (subscription, parentOcc) <- subscribeAndRead p $ debugSubscriber' desc $ Subscriber
1530+ (subscription, parentOcc) <- subscribeAndRead p $ Subscriber
16601531 { subscriberPropagate = \m -> do
16611532 liftIO $ writeIORef (_fanInt_occRef self) m
16621533 scheduleIntClear $ _fanInt_occRef self
1663− FastMutableIntMap.forIntersectionWithImmutable_ (_fanInt_subscribers self) m $ \b v -> --TODO: Do we need to know that no subscribers are being added as we traverse?
1664− FastWeakBag.traverse_ b $ \s ->
1534+ FastMutableIntMap.forIntersectionWithImmutable_ (_fanInt_subscribers self) m $ \b v -> do --TODO: Do we need to know that no subscribers are being added as we traverse?
1535+ FastWeakBag.traverse b $ \s -> do
16651536 subscriberPropagate s v
1666− , subscriberInvalidateHeight = \old ->
1667− FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b ->
1668− FastWeakBag.traverse_ b $ \s ->
1537+ , subscriberInvalidateHeight = \old -> do
1538+ FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b -> do
1539+ FastWeakBag.traverse b $ \s -> do
16691540 subscriberInvalidateHeight s old
1670− , subscriberRecalculateHeight = \new ->
1671− FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b ->
1672− FastWeakBag.traverse_ b $ \s ->
1541+ , subscriberRecalculateHeight = \new -> do
1542+ FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b -> do
1543+ FastWeakBag.traverse b $ \s -> do
16731544 subscriberRecalculateHeight s new
16741545 }
16751546 liftIO $ do
@@ -1683,25 +1554,10 @@ fanInt p = unsafePerformIO $ do
16831554 FastMutableIntMap.insert (_fanInt_subscribers self) k b
16841555 return b
16851556 Just b -> return b
1686− ticket <- liftIO $ FastWeakBag.insert sub b
1557+ t <- liftIO $ FastWeakBag.insert sub b
16871558 currentOcc <- readIORef (_fanInt_occRef self)
1688−
1689− subscribed <- fanIntSubscribed ticket self
1690− return (EventSubscription (FastWeakBag.remove ticket) subscribed, IntMap.lookup k currentOcc)
1691−
1692−fanIntSubscribed :: FastWeakBagTicket k -> FanInt x a -> IO (EventSubscribed x)
1693−fanIntSubscribed ticket self = do
1694− subscribedParent <- _eventSubscription_subscribed <$> readIORef (_fanInt_subscriptionRef self)
1695− return $ EventSubscribed
1696− { eventSubscribedHeightRef = eventSubscribedHeightRef subscribedParent
1697− , eventSubscribedRetained = toAny (_fanInt_subscriptionRef self, ticket)
1698−#ifdef DEBUG_CYCLES
1699− , eventSubscribedGetParents = return [subscribedParent]
1700− , eventSubscribedHasOwnHeightRef = False
1701− , eventSubscribedWhoCreated = whoCreatedIORef $ _fanInt_subscriptionRef self
1702−#endif
1703− }
1704−
1559+ (EventSubscription _ (EventSubscribed !heightRef _)) <- readIORef (_fanInt_subscriptionRef self)
1560+ return (EventSubscription (FastWeakBag.remove t) $! EventSubscribed heightRef $! toAny (_fanInt_subscriptionRef self, t), IntMap.lookup k currentOcc)
17051561
17061562{-# INLINABLE getFanSubscribed #-}
17071563getFanSubscribed :: (HasSpiderTimeline x, GCompare k) => k a -> Fan x k v -> Subscriber x (v a) -> EventM x (WeakBagTicket, FanSubscribed x k v, Maybe (v a))
@@ -1722,16 +1578,13 @@ getFanSubscribed k f sub = do
17221578 subscribersRef <- liftIO $ newIORef $ error "getFanSubscribed: subscribersRef not yet initialized"
17231579 occRef <- liftIO $ newIORef parentOcc
17241580 when (isJust parentOcc) $ scheduleClear occRef
1725−#ifdef DEBUG_NODEIDS
1726− nid <- liftIO newNodeId
1727−#endif
17281581 let subscribed = FanSubscribed
17291582 { fanSubscribedCachedSubscribed = fanSubscribed f
17301583 , fanSubscribedOccurrence = occRef
17311584 , fanSubscribedParent = subscription
17321585 , fanSubscribedSubscribers = subscribersRef
17331586#ifdef DEBUG_NODEIDS
1734− , fanSubscribedNodeId = nid
1587+ , fanSubscribedNodeId = unsafeNodeId f
17351588#endif
17361589 }
17371590 let !self = (k, subscribed)
@@ -1791,9 +1644,6 @@ getSwitchSubscribed s sub = do
17911644 when (isJust parentOcc) $ scheduleClear occRef
17921645 weakSelf <- liftIO $ newIORef $ error "getSwitchSubscribed: weakSelf not yet initialized"
17931646 (subs, slnForSub) <- liftIO $ WeakBag.singleton sub weakSelf cleanupSwitchSubscribed
1794−#ifdef DEBUG_NODEIDS
1795− nid <- liftIO newNodeId
1796−#endif
17971647 let !subscribed = SwitchSubscribed
17981648 { switchSubscribedCachedSubscribed = switchSubscribed s
17991649 , switchSubscribedOccurrence = occRef
@@ -1806,7 +1656,7 @@ getSwitchSubscribed s sub = do
18061656 , switchSubscribedCurrentParent = subscriptionRef
18071657 , switchSubscribedWeakSelf = weakSelf
18081658#ifdef DEBUG_NODEIDS
1809− , switchSubscribedNodeId = nid
1659+ , switchSubscribedNodeId = unsafeNodeId s
18101660#endif
18111661 }
18121662 liftIO $ writeIORef weakSelf =<< evaluate =<< mkWeakPtrWithDebug subscribed "switchSubscribedWeakSelf"
@@ -1851,9 +1701,6 @@ getCoincidenceSubscribed c sub = do
18511701 scheduleClear innerSubdRef
18521702 weakSelf <- liftIO $ newIORef $ error "getCoincidenceSubscribed: weakSelf not yet implemented"
18531703 (subs, slnForSub) <- liftIO $ WeakBag.singleton sub weakSelf cleanupCoincidenceSubscribed
1854−#ifdef DEBUG_NODEIDS
1855− nid <- liftIO newNodeId
1856−#endif
18571704 let subscribed = CoincidenceSubscribed
18581705 { coincidenceSubscribedCachedSubscribed = coincidenceSubscribed c
18591706 , coincidenceSubscribedOccurrence = occRef
@@ -1864,7 +1711,7 @@ getCoincidenceSubscribed c sub = do
18641711 , coincidenceSubscribedInnerParent = innerSubdRef
18651712 , coincidenceSubscribedWeakSelf = weakSelf
18661713#ifdef DEBUG_NODEIDS
1867− , coincidenceSubscribedNodeId = nid
1714+ , coincidenceSubscribedNodeId = unsafeNodeId c
18681715#endif
18691716 }
18701717 liftIO $ writeIORef weakSelf =<< evaluate =<< mkWeakPtrWithDebug subscribed "CoincidenceSubscribed"
@@ -1899,7 +1746,7 @@ mergeCheap
18991746 => (forall a. q a -> Event x (v a))
19001747 -> DynamicS x (PatchDMap k q)
19011748 -> Event x (DMap k v)
1902−mergeCheap nt = mergeGCheap' unMergeSubscribedParent getInitialSubscribers updateMe destroy
1749+mergeCheap nt = mergeGCheap' getInitialSubscribers updateMe destroy
19031750 where
19041751 updateMe :: MergeUpdateFunc k v x (PatchDMap k q) (MergeSubscribedParent x)
19051752 updateMe subscriber heightBagRef oldParents (PatchDMap p) = do
@@ -1914,9 +1761,7 @@ mergeCheap nt = mergeGCheap' unMergeSubscribedParent getInitialSubscribers updat
19141761 liftIO $ modifyIORef' heightBagRef $ heightBagAdd newParentHeight
19151762 return $ DMap.insertLookupWithKey' (\_ new _ -> new) k newParent ps
19161763 forM_ mOldSubd $ \oldSubd -> do
1917− oldHeight <- liftIO $ getEventSubscribedHeight $
1918− _eventSubscription_subscribed $ unMergeSubscribedParent oldSubd
1919−
1764+ oldHeight <- liftIO $ getEventSubscribedHeight $ _eventSubscription_subscribed $ unMergeSubscribedParent oldSubd
19201765 liftIO $ modifyIORef heightBagRef $ heightBagRemove oldHeight
19211766 return (maybeToList (unMergeSubscribedParent <$> mOldSubd) ++ subscriptionsToKill, newPs)
19221767 foldM f ([], oldParents) $ DMap.toList p
@@ -1941,7 +1786,7 @@ mergeCheapWithMove :: forall k x v q. (HasSpiderTimeline x, GCompare k)
19411786 => (forall a. q a -> Event x (v a))
19421787 -> DynamicS x (PatchDMapWithMove k q)
19431788 -> Event x (DMap k v)
1944−mergeCheapWithMove nt = mergeGCheap' _mergeSubscribedParentWithMove_subscription getInitialSubscribers updateMe destroy
1789+mergeCheapWithMove nt = mergeGCheap' getInitialSubscribers updateMe destroy
19451790 where
19461791 updateMe :: MergeUpdateFunc k v x (PatchDMapWithMove k q) (MergeSubscribedParentWithMove x k)
19471792 updateMe subscriber heightBagRef oldParents p = do
@@ -1960,17 +1805,13 @@ mergeCheapWithMove nt = mergeGCheap' _mergeSubscribedParentWithMove_subscription
19601805 let moveOrDelete :: forall a. k a -> PatchDMapWithMove.NodeInfo k q a -> MergeSubscribedParentWithMove x k a -> Constant (EventM x (Maybe (EventSubscription x))) a
19611806 moveOrDelete _ ni parent = Constant $ case getComposeMaybe $ PatchDMapWithMove._nodeInfo_to ni of
19621807 Nothing -> do
1963− oldHeight <- liftIO $ getEventSubscribedHeight $ _eventSubscription_subscribed $
1964− _mergeSubscribedParentWithMove_subscription parent
1965−
1808+ oldHeight <- liftIO $ getEventSubscribedHeight $ _eventSubscription_subscribed $ _mergeSubscribedParentWithMove_subscription parent
19661809 liftIO $ modifyIORef heightBagRef $ heightBagRemove oldHeight
19671810 return $ Just $ _mergeSubscribedParentWithMove_subscription parent
19681811 Just toKey -> do
19691812 liftIO $ writeIORef (_mergeSubscribedParentWithMove_key parent) $! toKey
19701813 return Nothing
1971− toDelete <- fmap catMaybes $ mapM (\(_ :=> v) -> getConstant v) $ DMap.toList $
1972− DMap.intersectionWithKey moveOrDelete (unPatchDMapWithMove p) oldParents
1973−
1814+ toDelete <- fmap catMaybes $ mapM (\(_ :=> v) -> getConstant v) $ DMap.toList $ DMap.intersectionWithKey moveOrDelete (unPatchDMapWithMove p) oldParents
19741815 return (toDelete, applyAlways p' oldParents)
19751816 getInitialSubscribers :: MergeInitFunc k v q x (MergeSubscribedParentWithMove x k)
19761817 getInitialSubscribers initialParents subscriber = do
@@ -1995,8 +1836,6 @@ type MergeUpdateFunc k v x p s
19951836 -> p
19961837 -> EventM x ([EventSubscription x], DMap k s)
19971838
1998−type MergeGetSubscription x s = forall a. s a -> EventSubscription x
1999−
20001839type MergeInitFunc k v q x s
20011840 = DMap k q
20021841 -> (forall a. EventM x (k a) -> Subscriber x (v a))
@@ -2020,17 +1859,14 @@ invalidateMergeHeight m = invalidateMergeHeight' (_merge_heightRef m) (_merge_su
20201859invalidateMergeHeight' :: IORef Height -> Subscriber x a -> IO ()
20211860invalidateMergeHeight' heightRef sub = do
20221861 oldHeight <- readIORef heightRef
2023− -- If the height used to be valid, it must be invalid now; we should never have *more* heights than we have parents
2024− when (oldHeight /= invalidHeight) $ do
1862+ when (oldHeight /= invalidHeight) $ do -- If the height used to be valid, it must be invalid now; we should never have *more* heights than we have parents
20251863 writeIORef heightRef $! invalidHeight
20261864 subscriberInvalidateHeight sub oldHeight
20271865
20281866revalidateMergeHeight :: Merge x k v s -> IO ()
20291867revalidateMergeHeight m = do
20301868 currentHeight <- readIORef $ _merge_heightRef m
2031−
2032− -- revalidateMergeHeight may be called multiple times; perhaps the's a way to finesse it to avoid this check
2033− when (currentHeight == invalidHeight) $ do
1869+ when (currentHeight == invalidHeight) $ do -- revalidateMergeHeight may be called multiple times; perhaps the's a way to finesse it to avoid this check
20341870 heights <- readIORef $ _merge_heightBagRef m
20351871 parents <- readIORef $ _merge_parentsRef m
20361872 -- When the number of heights in the bag reaches the number of parents, we should have a valid height
@@ -2038,7 +1874,7 @@ revalidateMergeHeight m = do
20381874 LT -> return ()
20391875 EQ -> do
20401876 let height = succHeight $ heightBagMax heights
2041− traceInvalidateHeight $ "recalculateSubscriberHeight: height: " <> show height
1877+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: height: " <> show height
20421878 writeIORef (_merge_heightRef m) $! height
20431879 subscriberRecalculateHeight (_merge_sub m) height
20441880 GT -> error $ "revalidateMergeHeight: more heights (" <> show (heightBagSize heights) <> ") than parents (" <> show (DMap.size parents) <> ") for Merge"
@@ -2046,45 +1882,36 @@ revalidateMergeHeight m = do
20461882scheduleMergeSelf :: HasSpiderTimeline x => Merge x k v s -> Height -> EventM x ()
20471883scheduleMergeSelf m height = scheduleMerge' height (_merge_heightRef m) $ do
20481884 vals <- liftIO $ readIORef $ _merge_accumRef m
2049− -- Once we're done with this, we can clear it immediately, because if there's a cacheEvent in front of us,
2050− -- it'll handle subsequent subscribers, and if not, we won't get subsequent subscribers
2051− liftIO $ writeIORef (_merge_accumRef m) $! DMap.empty
1885+ liftIO $ writeIORef (_merge_accumRef m) $! DMap.empty -- Once we're done with this, we can clear it immediately, because if there's a cacheEvent in front of us, it'll handle subsequent subscribers, and if not, we won't get subsequent subscribers
20521886 --TODO: Assert that m is not empty
20531887 subscriberPropagate (_merge_sub m) vals
20541888
2055−checkCycle :: HasSpiderTimeline x => EventSubscribed x -> EventM x ()
2056−checkCycle subscribed = liftIO $ do
2057− height <- readIORef (eventSubscribedHeightRef subscribed)
2058−
2059− -- currentHeight <- getCurrentHeight
2060− -- when (height <= currentHeight) $ if height /= invalidHeight
2061− -- then do
2062− -- myStack <- liftIO $ whoCreatedIORef undefined --TODO
2063− -- error $ "Height (" ++ show height ++ ") is not greater than current height (" ++ show currentHeight ++ ")\n" ++ unlines (reverse myStack)
2064− -- else liftIO $
2065− when (height == invalidHeight) $
2066−#ifdef DEBUG_CYCLES
2067− do
2068− nodesInvolvedInCycle <- walkInvalidHeightParents subscribed
2069− stacks <- forM nodesInvolvedInCycle whoCreatedEventSubscribed
2070− throwIO (EventLoopException stacks)
2071−#else
2072− throwIO EventLoopException
2073−#endif
2074−
2075−
2076−mergeSubscriber :: forall x k v s a. (HasSpiderTimeline x, GCompare k) => EventSubscribed x -> Merge x k v s -> EventM x (k a) -> Subscriber x (v a)
2077−mergeSubscriber subscribed m getKey = Subscriber
1889+mergeSubscriber :: forall x k v s a. (HasSpiderTimeline x, GCompare k) => Merge x k v s -> EventM x (k a) -> Subscriber x (v a)
1890+mergeSubscriber m getKey = Subscriber
20781891 { subscriberPropagate = \a -> do
20791892 oldM <- liftIO $ readIORef $ _merge_accumRef m
20801893 k <- getKey
2081− let newM = DMap.insertWith (error "Same key fired multiple times for Merge") k a oldM
1894+ let newM = DMap.insertWith (error $ "Same key fired multiple times for Merge") k a oldM
20821895 tracePropagate (Proxy :: Proxy x) $ " DMap.size oldM = " <> show (DMap.size oldM) <> "; DMap.size newM = " <> show (DMap.size newM)
20831896 liftIO $ writeIORef (_merge_accumRef m) $! newM
20841897 when (DMap.null oldM) $ do -- Only schedule the firing once
20851898 height <- liftIO $ readIORef $ _merge_heightRef m
2086− checkCycle subscribed
2087−
1899+ --TODO: assertions about height
1900+ currentHeight <- getCurrentHeight
1901+ when (height <= currentHeight) $ do
1902+ if height /= invalidHeight
1903+ then do
1904+ myStack <- liftIO $ whoCreatedIORef undefined --TODO
1905+ error $ "Height (" ++ show height ++ ") is not greater than current height (" ++ show currentHeight ++ ")\n" ++ unlines (reverse myStack)
1906+ else liftIO $ do
1907+#ifdef DEBUG_CYCLES
1908+ nodesInvolvedInCycle <- walkInvalidHeightParents $ eventSubscribedMerge subscribed
1909+ stacks <- forM nodesInvolvedInCycle $ \(Some es) -> whoCreatedEventSubscribed es
1910+ let cycleInfo = ":\n" <> drawForest (listsToForest stacks)
1911+#else
1912+ let cycleInfo = ""
1913+#endif
1914+ error $ "Causality loop found" <> cycleInfo
20881915 scheduleMergeSelf m height
20891916 , subscriberInvalidateHeight = \old -> do --TODO: When removing a parent doesn't actually change the height, maybe we can avoid invalidating
20901917 modifyIORef' (_merge_heightBagRef m) $ heightBagRemove old
@@ -2095,45 +1922,31 @@ mergeSubscriber subscribed m getKey = Subscriber
20951922 }
20961923
20971924--TODO: Be able to run as much of this as possible promptly
2098−updateMerge :: (HasSpiderTimeline x, GCompare k) => EventSubscribed x -> Merge x k v s -> MergeUpdateFunc k v x p s -> p -> SomeMergeUpdate x
2099−updateMerge subscribed m updateFunc p = SomeMergeUpdate updateMe (invalidateMergeHeight m) (revalidateMergeHeight m)
1925+updateMerge :: (HasSpiderTimeline x, GCompare k) => Merge x k v s -> MergeUpdateFunc k v x p s -> p -> SomeMergeUpdate x
1926+updateMerge m updateFunc p = SomeMergeUpdate updateMe (invalidateMergeHeight m) (revalidateMergeHeight m)
21001927 where updateMe = do
21011928 oldParents <- liftIO $ readIORef $ _merge_parentsRef m
2102− (subscriptionsToKill, newParents) <- updateFunc (mergeSubscriber subscribed m) (_merge_heightBagRef m) oldParents p
1929+ (subscriptionsToKill, newParents) <- updateFunc (mergeSubscriber m) (_merge_heightBagRef m) oldParents p
21031930 liftIO $ writeIORef (_merge_parentsRef m) $! newParents
21041931 return subscriptionsToKill
21051932
21061933{-# INLINE mergeGCheap' #-}
21071934mergeGCheap' :: forall k v x p s q. (HasSpiderTimeline x, GCompare k, PatchTarget p ~ DMap k q)
2108− => MergeGetSubscription x s -> MergeInitFunc k v q x s -> MergeUpdateFunc k v x p s -> MergeDestroyFunc k s -> DynamicS x p -> Event x (DMap k v)
2109−mergeGCheap' getParent getInitialSubscribers updateFunc destroy d = Event $ \sub -> do
1935+ => MergeInitFunc k v q x s -> MergeUpdateFunc k v x p s -> MergeDestroyFunc k s -> DynamicS x p -> Event x (DMap k v)
1936+mergeGCheap' getInitialSubscribers updateFunc destroy d = Event $ \sub -> do
21101937 initialParents <- readBehaviorUntracked $ dynamicCurrent d
21111938 accumRef <- liftIO $ newIORef $ error "merge: accumRef not yet initialized"
21121939 heightRef <- liftIO $ newIORef $ error "merge: heightRef not yet initialized"
21131940 heightBagRef <- liftIO $ newIORef $ error "merge: heightBagRef not yet initialized"
21141941 parentsRef :: IORef (DMap k s) <- liftIO $ newIORef $ error "merge: parentsRef not yet initialized"
2115− changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
2116−
2117− let subscribed = EventSubscribed
2118− { eventSubscribedHeightRef = heightRef
2119− , eventSubscribedRetained = toAny (parentsRef, changeSubdRef)
2120−#ifdef DEBUG_CYCLES
2121− , eventSubscribedGetParents = do
2122− let getParent' (_ :=> v) = _eventSubscription_subscribed (getParent v)
2123− fmap getParent' . DMap.toList <$> readIORef parentsRef
2124− , eventSubscribedHasOwnHeightRef = False
2125− , eventSubscribedWhoCreated = whoCreatedIORef heightRef
2126−#endif
2127− }
2128−
2129− m = Merge
1942+ let m = Merge
21301943 { _merge_parentsRef = parentsRef
21311944 , _merge_heightBagRef = heightBagRef
21321945 , _merge_heightRef = heightRef
21331946 , _merge_sub = sub
21341947 , _merge_accumRef = accumRef
21351948 }
2136− (dm, heights, initialParentState) <- getInitialSubscribers initialParents $ mergeSubscriber subscribed m
1949+ (dm, heights, initialParentState) <- getInitialSubscribers initialParents $ mergeSubscriber m
21371950 let myHeightBag = heightBagFromList $ filter (/= invalidHeight) heights
21381951 myHeight = if invalidHeight `elem` heights
21391952 then invalidHeight
@@ -2142,29 +1955,31 @@ mergeGCheap' getParent getInitialSubscribers updateFunc destroy d = Event $ \sub
21421955 let (occ, accum) = if currentHeight >= myHeight -- If we should have fired by now
21431956 then (if DMap.null dm then Nothing else Just dm, DMap.empty)
21441957 else (Nothing, dm)
2145− unless (DMap.null accum) $ scheduleMergeSelf m myHeight
1958+ unless (DMap.null accum) $ do
1959+ scheduleMergeSelf m myHeight
21461960 liftIO $ writeIORef accumRef $! accum
21471961 liftIO $ writeIORef heightRef $! myHeight
21481962 liftIO $ writeIORef heightBagRef $! myHeightBag
1963+ changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
21491964 liftIO $ writeIORef parentsRef $! initialParentState
21501965 defer $ SomeMergeInit $ do
2151− let changeSubscriber = Subscriber
1966+ let s = Subscriber
21521967 { subscriberPropagate = \a -> {-# SCC "traverseMergeChange" #-} do
2153− tracePropagate (Proxy :: Proxy x) "SubscriberMerge/Change"
2154− defer $ updateMerge subscribed m updateFunc a
1968+ tracePropagate (Proxy :: Proxy x) $ "SubscriberMerge/Change"
1969+ defer $ updateMerge m updateFunc a
21551970 , subscriberInvalidateHeight = \_ -> return ()
21561971 , subscriberRecalculateHeight = \_ -> return ()
21571972 }
2158− (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) changeSubscriber
2159− forM_ change $ \c -> defer $ updateMerge subscribed m updateFunc c
1973+ (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) s
1974+ forM_ change $ \c -> defer $ updateMerge m updateFunc c
21601975 -- We explicitly hold on to the unsubscribe function from subscribing to the update event.
21611976 -- If we don't do this, there are certain cases where mergeCheap will fail to properly retain
21621977 -- its subscription.
2163− liftIO $ writeIORef changeSubdRef (changeSubscriber, changeSubscription)
1978+ liftIO $ writeIORef changeSubdRef (s, changeSubscription)
21641979 let unsubscribeAll = destroy =<< readIORef parentsRef
2165−
2166− return (EventSubscription unsubscribeAll subscribed, occ)
2167−
1980+ return ( EventSubscription unsubscribeAll $ EventSubscribed heightRef $ toAny (parentsRef, changeSubdRef)
1981+ , occ
1982+ )
21681983
21691984mergeInt :: forall x a. (HasSpiderTimeline x) => DynamicS x (PatchIntMap (Event x a)) -> Event x (IntMap a)
21701985mergeInt = cacheEvent . mergeIntCheap
@@ -2177,22 +1992,13 @@ mergeIntCheap d = Event $ \sub -> do
21771992 heightRef <- liftIO $ newIORef zeroHeight
21781993 heightBagRef <- liftIO $ newIORef heightBagEmpty
21791994 parents <- liftIO $ FastMutableIntMap.newEmpty
2180− changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
2181− let subscribed = EventSubscribed
2182− { eventSubscribedHeightRef = heightRef
2183− , eventSubscribedRetained = toAny (parents, changeSubdRef)
2184−#ifdef DEBUG_CYCLES
2185− , eventSubscribedGetParents = fmap (_eventSubscription_subscribed . snd) <$> FastMutableIntMap.toList parents
2186− , eventSubscribedHasOwnHeightRef = False
2187− , eventSubscribedWhoCreated = whoCreatedIORef heightRef
2188−#endif
2189− }
21901995 let scheduleSelf = do
21911996 height <- liftIO $ readIORef $ heightRef
21921997 scheduleMerge' height heightRef $ do
21931998 vals <- liftIO $ FastMutableIntMap.getFrozenAndClear accum
21941999 subscriberPropagate sub vals
2195− invalidateMyHeight = invalidateMergeHeight' heightRef sub
2000+ invalidateMyHeight = do
2001+ invalidateMergeHeight' heightRef sub
21962002 recalculateMyHeight = do
21972003 currentHeight <- readIORef heightRef
21982004 when (currentHeight == invalidHeight) $ do --TODO: This will almost always be true; can we get rid of this check and just proceed to the next one always?
@@ -2202,14 +2008,12 @@ mergeIntCheap d = Event $ \sub -> do
22022008 LT -> return ()
22032009 EQ -> do
22042010 let height = succHeight $ heightBagMax heights
2205− traceInvalidateHeight $ "recalculateSubscriberHeight: height: " <> show height
2011+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: height: " <> show height
22062012 writeIORef heightRef $! height
22072013 subscriberRecalculateHeight sub height
22082014 GT -> error $ "revalidateMergeHeight: more heights (" <> show (heightBagSize heights) <> ") than parents (" <> show numParents <> ") for Merge"
22092015 mySubscriber k = Subscriber
22102016 { subscriberPropagate = \a -> do
2211− checkCycle subscribed
2212−
22132017 wasEmpty <- liftIO $ FastMutableIntMap.isEmpty accum
22142018 liftIO $ FastMutableIntMap.insert accum k a
22152019 when wasEmpty scheduleSelf
@@ -2243,6 +2047,7 @@ mergeIntCheap d = Event $ \sub -> do
22432047 else liftIO $ Just <$> FastMutableIntMap.getFrozenAndClear accum
22442048 else do when (not isEmpty) scheduleSelf -- We have things accumulated, but we shouldn't have fired them yet
22452049 return Nothing
2050+ changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
22462051 defer $ SomeMergeInit $ do
22472052 let updateMe a = SomeMergeUpdate u invalidateMyHeight recalculateMyHeight
22482053 where
@@ -2256,39 +2061,36 @@ mergeIntCheap d = Event $ \sub -> do
22562061 oldParents <- liftIO $ FastMutableIntMap.applyPatch parents newSubscriptions
22572062 liftIO $ for_ oldParents $ \oldParent -> do
22582063 oldParentHeight <- getEventSubscribedHeight $ _eventSubscription_subscribed oldParent
2259−
2260− print ("updateMe", oldParentHeight)
22612064 modifyIORef' heightBagRef $ heightBagRemove oldParentHeight
22622065 return $ IntMap.elems oldParents
2263− let changeSubscriber = Subscriber
2066+ let s = Subscriber
22642067 { subscriberPropagate = \a -> {-# SCC "traverseMergeChange" #-} do
22652068 tracePropagate (Proxy :: Proxy x) $ "SubscriberMergeInt/Change"
22662069 defer $ updateMe a
22672070 , subscriberInvalidateHeight = \_ -> return ()
22682071 , subscriberRecalculateHeight = \_ -> return ()
22692072 }
2270− (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) changeSubscriber
2073+ (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) s
22712074 forM_ change $ \c -> defer $ updateMe c
22722075 -- We explicitly hold on to the unsubscribe function from subscribing to the update event.
22732076 -- If we don't do this, there are certain cases where mergeCheap will fail to properly retain
22742077 -- its subscription.
2275− liftIO $ writeIORef changeSubdRef (changeSubscriber, changeSubscription)
2078+ liftIO $ writeIORef changeSubdRef (s, changeSubscription)
22762079 let unsubscribeAll = traverse_ unsubscribe =<< FastMutableIntMap.getFrozenAndClear parents
2277−
2278−
2279− return (EventSubscription unsubscribeAll subscribed, occ)
2080+ return ( EventSubscription unsubscribeAll $ EventSubscribed heightRef $ toAny (parents, changeSubdRef)
2081+ , occ
2082+ )
22802083
22812084newtype EventSelector x k = EventSelector { select :: forall a. k a -> Event x a }
22822085newtype EventSelectorG x k v = EventSelectorG { selectG :: forall a. k a -> Event x (v a) }
22832086
22842087fanG :: (HasSpiderTimeline x, GCompare k) => Event x (DMap k v) -> EventSelectorG x k v
2285−fanG e = unsafePerformIO $ do
2286− ref <- newIORef Nothing
2088+fanG e =
22872089 let f = Fan
22882090 { fanParent = e
2289− , fanSubscribed = ref
2091+ , fanSubscribed = unsafeNewIORef e Nothing
22902092 }
2291− pure $ EventSelectorG $ \k -> eventFan k f
2093+ in EventSelectorG $ \k -> eventFan k f
22922094
22932095runHoldInits :: HasSpiderTimeline x => IORef [SomeHoldInit x] -> IORef [SomeDynInit x] -> IORef [SomeMergeInit x] -> EventM x ()
22942096runHoldInits holdInitRef dynInitRef mergeInitRef = do
@@ -2359,19 +2161,19 @@ runFrame a = SpiderHost $ do
23592161 coincidenceInfos <- readIORef $ eventEnvResetCoincidences env
23602162 forM_ toAssign $ \(SomeAssignment vRef iRef v) -> {-# SCC "assignment" #-} do
23612163 writeIORef vRef v
2362− traceInvalidate $ "Invalidating Hold"
2164+ when debugInvalidate $ putStrLn $ "Invalidating Hold"
23632165 writeIORef iRef =<< evaluate =<< invalidate toReconnectRef =<< readIORef iRef
23642166 mergeUpdates <- readIORef $ eventEnvMergeUpdates env
23652167 writeIORef (eventEnvMergeUpdates env) []
2366− tracePropagate (Proxy::Proxy x) $ "Updating merges"
2168+ when debugPropagate $ putStrLn "Updating merges"
23672169 mergeSubscriptionsToKill <- runEventM $ concat <$> mapM _someMergeUpdate_update mergeUpdates
2368− tracePropagate (Proxy::Proxy x) $ "Updating merges done"
2170+ when debugPropagate $ putStrLn "Updating merges done"
23692171 toReconnect <- readIORef toReconnectRef
23702172 clearEventEnv env
23712173 switchSubscriptionsToKill <- forM toReconnect $ \(SomeSwitchSubscribed subscribed) -> {-# SCC "switchSubscribed" #-} do
23722174 oldSubscription <- readIORef $ switchSubscribedCurrentParent subscribed
23732175 wi <- readIORef $ switchSubscribedOwnWeakInvalidator subscribed
2374− traceInvalidate $ "Finalizing invalidator for Switch" <> showNodeId subscribed
2176+ when debugInvalidate $ putStrLn $ "Finalizing invalidator for Switch" <> showNodeId subscribed
23752177 finalize wi
23762178 i <- evaluate $ switchSubscribedOwnInvalidator subscribed
23772179 wi' <- mkWeakPtrWithDebug i "wi'"
@@ -2385,7 +2187,7 @@ runFrame a = SpiderHost $ do
23852187 subscription <- unSpiderHost $ runFrame $ {-# SCC "subscribeSwitch" #-} subscribe e sub --TODO: Assert that the event isn't firing --TODO: This should not loop because none of the events should be firing, but still, it is inefficient
23862188 {-
23872189 stackTrace <- liftIO $ fmap renderStack $ ccsToStrings =<< (getCCSOf $! switchSubscribedParent subscribed)
2388− liftIO $ debugStrLn $ (++stackTrace) $ "subd' subscribed to " ++ case e of
2190+ liftIO $ putStrLn $ (++stackTrace) $ "subd' subscribed to " ++ case e of
23892191 EventRoot _ -> "EventRoot"
23902192 EventNever -> "EventNever"
23912193 _ -> "something else"
@@ -2400,7 +2202,7 @@ runFrame a = SpiderHost $ do
24002202 myHeight <- readIORef $ switchSubscribedHeight subscribed
24012203 when (parentHeight /= myHeight) $ do
24022204 writeIORef (switchSubscribedHeight subscribed) $! invalidHeight
2403− WeakBag.traverse_ (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight myHeight
2205+ WeakBag.traverse (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight myHeight
24042206 mapM_ _someMergeUpdate_invalidateHeight mergeUpdates --TODO: In addition to when the patch is completely empty, we should also not run this if it has some Nothing values, but none of them have actually had any effect; potentially, we could even check for Just values with no effect (e.g. by comparing their IORefs and ignoring them if they are unchanged); actually, we could just check if the new height is different
24052207 forM_ coincidenceInfos $ \(SomeResetCoincidence subscription mcs) -> do
24062208 unsubscribe subscription
@@ -2441,7 +2243,7 @@ invalidateCoincidenceHeight subscribed = do
24412243 oldHeight <- readIORef $ coincidenceSubscribedHeight subscribed
24422244 when (oldHeight /= invalidHeight) $ do
24432245 writeIORef (coincidenceSubscribedHeight subscribed) $! invalidHeight
2444− WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
2246+ WeakBag.traverse (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
24452247
24462248updateSwitchHeight :: Height -> SwitchSubscribed x a -> IO ()
24472249updateSwitchHeight new subscribed = do
@@ -2449,7 +2251,7 @@ updateSwitchHeight new subscribed = do
24492251 when (oldHeight == invalidHeight) $ do --TODO: This 'when' should probably be an assertion
24502252 when (new /= invalidHeight) $ do --TODO: This 'when' should probably be an assertion
24512253 writeIORef (switchSubscribedHeight subscribed) $! new
2452− WeakBag.traverse_ (switchSubscribedSubscribers subscribed) $ recalculateSubscriberHeight new
2254+ WeakBag.traverse (switchSubscribedSubscribers subscribed) $ recalculateSubscriberHeight new
24532255
24542256recalculateCoincidenceHeight :: CoincidenceSubscribed x a -> IO ()
24552257recalculateCoincidenceHeight subscribed = do
@@ -2458,7 +2260,7 @@ recalculateCoincidenceHeight subscribed = do
24582260 height <- calculateCoincidenceHeight subscribed
24592261 when (height /= invalidHeight) $ do
24602262 writeIORef (coincidenceSubscribedHeight subscribed) $! height
2461− WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ recalculateSubscriberHeight height
2263+ WeakBag.traverse (coincidenceSubscribedSubscribers subscribed) $ recalculateSubscriberHeight height
24622264
24632265calculateSwitchHeight :: SwitchSubscribed x a -> IO Height
24642266calculateSwitchHeight subscribed = getEventSubscribedHeight . _eventSubscription_subscribed =<< readIORef (switchSubscribedCurrentParent subscribed)
@@ -2520,8 +2322,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Event
25202322 {-# INLINABLE headE #-}
25212323 headE = R.slowHeadE
25222324-- headE (SpiderEvent e) = SpiderEvent <$> Reflex.Spider.Internal.headE e
2523− {-# INLINABLE now #-}
2524− now = nowSpiderEventM
25252325
25262326instance Reflex.Class.MonadSample (SpiderTimeline x) (SpiderPullM x) where
25272327 {-# INLINABLE sample #-}
@@ -2543,9 +2343,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Spide
25432343 {-# INLINABLE headE #-}
25442344 headE = R.slowHeadE
25452345-- headE (SpiderEvent e) = SpiderPushM $ SpiderEvent <$> Reflex.Spider.Internal.headE e
2546− {-# INLINABLE now #-}
2547− now = SpiderPushM nowSpiderEventM
2548−
25492346
25502347instance HasSpiderTimeline x => Monad (Reflex.Class.Dynamic (SpiderTimeline x)) where
25512348 {-# INLINE return #-}
@@ -2554,10 +2351,8 @@ instance HasSpiderTimeline x => Monad (Reflex.Class.Dynamic (SpiderTimeline x))
25542351 x >>= f = SpiderDynamic $ dynamicDynIdentity $ newJoinDyn $ newMapDyn (unSpiderDynamic . f) $ unSpiderDynamic x
25552352 {-# INLINE (>>) #-}
25562353 (>>) = (*>)
2557−#if !MIN_VERSION_base(4,13,0)
25582354 {-# INLINE fail #-}
25592355 fail _ = error "Dynamic does not support 'fail'"
2560−#endif
25612356
25622357{-# INLINABLE newJoinDyn #-}
25632358newJoinDyn :: HasSpiderTimeline x => DynamicS x (Identity (DynamicS x (Identity a))) -> Reflex.Spider.Internal.Dyn x (Identity a)
@@ -2609,9 +2404,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Spide
26092404 buildDynamic getV0 e = runFrame . runSpiderHostFrame $ Reflex.Class.buildDynamic getV0 e
26102405 {-# INLINABLE headE #-}
26112406 headE e = runFrame . runSpiderHostFrame $ Reflex.Class.headE e
2612− {-# INLINABLE now #-}
2613− now = runFrame . runSpiderHostFrame $ Reflex.Class.now
2614−
26152407
26162408instance HasSpiderTimeline x => Reflex.Class.MonadSample (SpiderTimeline x) (SpiderHostFrame x) where
26172409 sample = SpiderHostFrame . readBehaviorUntracked . unSpiderBehavior --TODO: This can cause problems with laziness, so we should get rid of it if we can
@@ -2628,8 +2420,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Spide
26282420 {-# INLINABLE headE #-}
26292421 headE = R.slowHeadE
26302422-- headE (SpiderEvent e) = SpiderHostFrame $ SpiderEvent <$> Reflex.Spider.Internal.headE e
2631− {-# INLINABLE now #-}
2632− now = SpiderHostFrame Reflex.Class.now
26332423
26342424instance HasSpiderTimeline x => Reflex.Class.MonadSample (SpiderTimeline x) (SpiderHost x) where
26352425 {-# INLINABLE sample #-}
@@ -2650,8 +2440,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Refle
26502440 buildDynamic getV0 e = Reflex.Spider.Internal.ReadPhase $ Reflex.Class.buildDynamic getV0 e
26512441 {-# INLINABLE headE #-}
26522442 headE e = Reflex.Spider.Internal.ReadPhase $ Reflex.Class.headE e
2653− {-# INLINABLE now #-}
2654− now = Reflex.Spider.Internal.ReadPhase Reflex.Class.now
26552443
26562444--------------------------------------------------------------------------------
26572445-- Deprecated items
@@ -2689,13 +2477,13 @@ instance HasSpiderTimeline x => Reflex.Host.Class.MonadReadEvent (SpiderTimeline
26892477 touch h
26902478 return result
26912479
2692−instance HasSpiderTimeline x => Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHost x) where
2480+instance Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHost x) where
26932481 newEventWithTrigger = SpiderHost . fmap SpiderEvent . newEventWithTriggerIO
26942482 newFanEventWithTrigger f = SpiderHost $ do
26952483 es <- newFanEventWithTriggerIO f
26962484 return $ Reflex.Class.EventSelector $ SpiderEvent . Reflex.Spider.Internal.select es
26972485
2698−instance HasSpiderTimeline x => Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHostFrame x) where
2486+instance Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHostFrame x) where
26992487 newEventWithTrigger = SpiderHostFrame . EventM . liftIO . fmap SpiderEvent . newEventWithTriggerIO
27002488 newFanEventWithTrigger f = SpiderHostFrame $ EventM $ liftIO $ do
27012489 es <- newFanEventWithTriggerIO f
@@ -2775,7 +2563,7 @@ instance HasSpiderTimeline x => R.Reflex (SpiderTimeline x) where
27752563 fanG e = R.EventSelectorG $ SpiderEvent . selectG (fanG (unSpiderEvent e))
27762564 {-# INLINABLE mergeG #-}
27772565 mergeG
2778− :: forall k2 (k :: k2 -> *) q (v :: k2 -> *). GCompare k
2566+ :: forall (k :: k2 -> *) q (v :: k2 -> *). GCompare k
27792567 => (forall a. q a -> R.Event (SpiderTimeline x) (v a))
27802568 -> DMap k q
27812569 -> R.Event (SpiderTimeline x) (DMap k v)
@@ -2843,14 +2631,8 @@ instance Monad (SpiderHost x) where
28432631 SpiderHost x >> SpiderHost y = SpiderHost $ x >> y
28442632 {-# INLINABLE return #-}
28452633 return x = SpiderHost $ return x
2846−#if !MIN_VERSION_base(4,13,0)
28472634 {-# INLINABLE fail #-}
2848− fail = MonadFail.fail
2849−#endif
2850−
2851−instance MonadFail (SpiderHost x) where
2852− {-# INLINABLE fail #-}
2853− fail s = SpiderHost $ MonadFail.fail s
2635+ fail s = SpiderHost $ fail s
28542636
28552637-- | Run an action affecting the global Spider timeline; this will be guarded by
28562638-- a mutex for that timeline
@@ -2872,21 +2654,19 @@ instance Monad (SpiderHostFrame x) where
28722654 SpiderHostFrame x >> SpiderHostFrame y = SpiderHostFrame $ x >> y
28732655 {-# INLINABLE return #-}
28742656 return x = SpiderHostFrame $ return x
2875−#if !MIN_VERSION_base(4,13,0)
28762657 {-# INLINABLE fail #-}
28772658 fail s = SpiderHostFrame $ fail s
2878−#endif
28792659
28802660instance NotReady (SpiderTimeline x) (SpiderHostFrame x) where
28812661 notReadyUntil _ = pure ()
28822662 notReady = pure ()
28832663
2884−newEventWithTriggerIO :: forall x a. HasSpiderTimeline x => (RootTrigger x a -> IO (IO ())) -> IO (Event x a)
2664+newEventWithTriggerIO :: (RootTrigger x a -> IO (IO ())) -> IO (Event x a)
28852665newEventWithTriggerIO f = do
28862666 es <- newFanEventWithTriggerIO $ \Refl -> f
28872667 return $ select es Refl
28882668
2889−newFanEventWithTriggerIO :: (HasSpiderTimeline x, GCompare k) => (forall a. k a -> RootTrigger x a -> IO (IO ())) -> IO (EventSelector x k)
2669+newFanEventWithTriggerIO :: GCompare k => (forall a. k a -> RootTrigger x a -> IO (IO ())) -> IO (EventSelector x k)
28902670newFanEventWithTriggerIO f = do
28912671 occRef <- newIORef DMap.empty
28922672 subscribedRef <- newIORef DMap.empty
@@ -2920,11 +2700,3 @@ instance MonadAtomicRef (SpiderHostFrame x) where
29202700instance PrimMonad (SpiderHostFrame x) where
29212701 type PrimState (SpiderHostFrame x) = PrimState IO
29222702 primitive = SpiderHostFrame . EventM . primitive
2923−
2924−instance NotReady (SpiderTimeline x) (SpiderHost x) where
2925− notReadyUntil _ = return ()
2926− notReady = return ()
2927−
2928−instance HasSpiderTimeline x => NotReady (SpiderTimeline x) (PerformEventT (SpiderTimeline x) (SpiderHost x)) where
2929− notReadyUntil _ = return ()
2930− notReady = return ()