@@ -9,6 +9,7 @@
99{-# LANGUAGE GADTs #-}
1010{-# LANGUAGE GeneralizedNewtypeDeriving #-}
1111{-# LANGUAGE LambdaCase #-}
12+{-# LANGUAGE MultiWayIf #-}
1213{-# LANGUAGE RankNTypes #-}
1314{-# LANGUAGE RoleAnnotations #-}
1415{-# LANGUAGE ScopedTypeVariables #-}
@@ -19,7 +20,6 @@
1920{-# LANGUAGE DeriveFunctor #-}
2021{-# LANGUAGE StandaloneDeriving #-}
2122{-# LANGUAGE InstanceSigs #-}
22−{-# LANGUAGE MultiWayIf #-}
2323
2424#ifdef USE_REFLEX_OPTIMIZER
2525{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
@@ -38,17 +38,15 @@ import Control.Monad hiding (forM, forM_, mapM, mapM_)
3838import Control.Monad.Exception
3939import Control.Monad.Identity hiding (forM, forM_, mapM, mapM_)
4040import Control.Monad.Primitive
41+--import Control.Monad.Reader hiding (forM, forM_, mapM, mapM_)
4142import Control.Monad.Reader.Class
4243import Control.Monad.IO.Class
4344import Control.Monad.ReaderIO
4445import Control.Monad.Ref
45−import Control.Monad.Fail (MonadFail)
46−import qualified Control.Monad.Fail as MonadFail
4746import Data.Align
4847import Data.Coerce
49−import Data.Dependent.Map (DMap)
48+import Data.Dependent.Map (DMap, DSum (..))
5049import qualified Data.Dependent.Map as DMap
51−import Data.Dependent.Sum (DSum (..))
5250import Data.FastMutableIntMap (FastMutableIntMap, PatchIntMap (..))
5351import qualified Data.FastMutableIntMap as FastMutableIntMap
5452import Data.Foldable hiding (concat, elem, sequence_)
@@ -61,13 +59,12 @@ import qualified Data.IntMap.Strict as IntMap
6159import Data.IORef
6260import Data.Kind (Type)
6361import Data.Maybe hiding (mapMaybe)
64−import Data.Monoid (mempty, (<>))
62+import Data.Monoid ((<>))
6563import Data.Proxy
6664import Data.These
6765import Data.Traversable
68−import Data.Type.Equality ((:~:)(Refl))
6966import Data.Witherable (Filterable, mapMaybe)
70−import GHC.Exts hiding (toList)
67+import GHC.Exts
7168import GHC.IORef (IORef (..))
7269import GHC.Stack
7370import Reflex.FastWeak
@@ -75,27 +72,22 @@ import System.IO.Unsafe
7572import System.Mem.Weak
7673import Unsafe.Coerce
7774
78−#ifdef MIN_VERSION_semialign
75+#if defined(MIN_VERSION_semialign)
7976#if MIN_VERSION_these(0,8,0)
8077import Data.These.Combinators (justThese)
8178#endif
82−#if MIN_VERSION_semialign(1,1,0)
83−import Data.Zip (Zip (..))
84−#endif
8579#endif
8680
8781#ifdef DEBUG_CYCLES
8882import Control.Monad.State hiding (forM, forM_, mapM, mapM_, sequence)
89−#endif
90−
9183import Data.List.NonEmpty (NonEmpty (..), nonEmpty)
9284import qualified Data.List.NonEmpty as NonEmpty
85+import Data.Monoid (mempty)
9386import Data.Tree (Forest, Tree (..), drawForest)
94−import Data.List (isPrefixOf)
87+#endif
9588
96−import Data.FastWeakBag (FastWeakBag, FastWeakBagTicket)
89+import Data.FastWeakBag (FastWeakBag)
9790import qualified Data.FastWeakBag as FastWeakBag
98−
9991import Data.Reflection
10092import Data.Some (Some(Some))
10193import Data.Type.Coercion
@@ -106,65 +98,28 @@ import qualified Reflex.Class
10698import qualified Reflex.Class as R
10799import qualified Reflex.Host.Class
108100import Reflex.NotReady.Class
109−import Data.Patch
110−import qualified Data.Patch.DMapWithMove as PatchDMapWithMove
111−import Reflex.PerformEvent.Base (PerformEventT)
101+import Reflex.Patch
102+import qualified Reflex.Patch.DMapWithMove as PatchDMapWithMove
112103
113104#ifdef DEBUG_TRACE_EVENTS
114105import qualified Data.ByteString.Char8 as BS8
115106import System.IO (stderr)
116107import Data.List (isPrefixOf)
117−#endif
118108
119−-- TODO stdout might not be the best channel for debug output
120−debugStrLn :: String -> IO ()
121−debugStrLn = putStrLn
122−
123−#ifdef DEBUG_TRACE_EVENTS
124109withStackOneLine :: (BS8.ByteString -> a) -> a
125110withStackOneLine expr = unsafePerformIO $ do
126111 stack <- currentCallStack
127112 return (expr . BS8.pack . unwords . dropInternal . reverse $ stack)
128− where dropInternal = filterStack "Reflex.Spider.Internal"
113+ where dropInternal = filter (not . isPrefixOf "Reflex.Spider.Internal")
129114
130115#endif
131116
132−debugPropagate :: Bool
133−
134−debugInvalidateHeight :: Bool
135−
136−debugInvalidate :: Bool
137−
138117#ifdef DEBUG
139118#define DEBUG_NODEIDS
140119
141−#ifdef DEBUG_TRACE_PROPAGATION
142−debugPropagate = True
143−#else
144−debugPropagate = False
145−#endif
146−
147−#ifdef DEBUG_TRACE_HEIGHT
148−debugInvalidateHeight = True
149−#else
150−debugInvalidateHeight = False
151−#endif
152−
153−#ifdef DEBUG_TRACE_INVALIDATION
154−debugInvalidate = True
155−#else
156−debugInvalidate = False
157−#endif
158−
159120class HasNodeId a where
160121 getNodeId :: a -> Int
161122
162−instance HasNodeId (CacheSubscribed x a) where
163− getNodeId = _cacheSubscribed_nodeId
164−
165−instance HasNodeId (FanInt x a) where
166− getNodeId = _fanInt_nodeId
167−
168123instance HasNodeId (Hold x p) where
169124 getNodeId = holdNodeId
170125
@@ -185,27 +140,16 @@ instance HasNodeId (Pull x a) where
185140
186141{-# INLINE showNodeId #-}
187142showNodeId :: HasNodeId a => a -> String
188−showNodeId = showNodeId' . getNodeId
189−
190−showNodeId' :: Int -> String
191−showNodeId' = ("#"<>) . show
143+showNodeId = ("#"<>) . show . getNodeId
192144
193145
194146#else
195147
196−debugPropagate = False
197−debugInvalidateHeight = False
198−debugInvalidate = False
199−
200148-- This must be inline, or error messages will cause memory leaks due to retaining the node in question
201149{-# INLINE showNodeId #-}
202150showNodeId :: a -> String
203151showNodeId _ = ""
204152
205−{-# INLINE showNodeId' #-}
206−showNodeId' :: Int -> String
207−showNodeId' _ = ""
208−
209153#endif
210154
211155#ifdef DEBUG_NODEIDS
@@ -251,9 +195,9 @@ subscribeAndRead = unEvent
251195-- caching; if the computation function is very cheap, this is (much) more
252196-- efficient than 'push'
253197{-# INLINE [1] pushCheap #-}
254−pushCheap :: HasSpiderTimeline x => (a -> ComputeM x (Maybe b)) -> Event x a -> Event x b
198+pushCheap :: (a -> ComputeM x (Maybe b)) -> Event x a -> Event x b
255199pushCheap !f e = Event $ \sub -> do
256− (subscription, occ) <- subscribeAndRead e $ debugSubscriber' "push" $ sub
200+ (subscription, occ) <- subscribeAndRead e $ sub
257201 { subscriberPropagate = \a -> do
258202 mb <- f a
259203 mapM_ (subscriberPropagate sub) mb
@@ -272,10 +216,10 @@ terminalSubscriber p = Subscriber
272216
273217-- | Subscribe to an Event only for the duration of one occurrence
274218{-# INLINE subscribeAndReadHead #-}
275−subscribeAndReadHead :: HasSpiderTimeline x => Event x a -> Subscriber x a -> EventM x (EventSubscription x, Maybe a)
219+subscribeAndReadHead :: Event x a -> Subscriber x a -> EventM x (EventSubscription x, Maybe a)
276220subscribeAndReadHead e sub = do
277221 subscriptionRef <- liftIO $ newIORef $ error "subscribeAndReadHead: not initialized"
278− (subscription, occ) <- subscribeAndRead e $ debugSubscriber' "head" $ sub
222+ (subscription, occ) <- subscribeAndRead e $ sub
279223 { subscriberPropagate = \a -> do
280224 liftIO $ unsubscribe =<< readIORef subscriptionRef
281225 subscriberPropagate sub a
@@ -286,42 +230,24 @@ subscribeAndReadHead e sub = do
286230 return (subscription, occ)
287231
288232--TODO: Make this lazy in its input event
289−headE :: (MonadIO m, Defer (SomeMergeInit x) m, HasSpiderTimeline x) => Event x a -> m (Event x a)
233+headE :: (MonadIO m, Defer (SomeMergeInit x) m) => Event x a -> m (Event x a)
290234headE originalE = do
291235 parent <- liftIO $ newIORef $ Just originalE
292236 defer $ SomeMergeInit $ do --TODO: Rename SomeMergeInit appropriately
293237 let clearParent = liftIO $ writeIORef parent Nothing
294− (_, occ) <- subscribeAndReadHead originalE $ terminalSubscriber $ const clearParent
238+ (_, occ) <- subscribeAndReadHead originalE $ terminalSubscriber $ \_ -> clearParent
295239 when (isJust occ) clearParent
296− return $ Event $ \sub ->
240+ return $ Event $ \sub -> do
297241 liftIO (readIORef parent) >>= \case
298− Nothing -> subscribeAndReadNever
242+ Nothing -> return (EventSubscription (return ()) $ EventSubscribed zeroRef $ toAny (), Nothing)
299243 Just e -> subscribeAndReadHead e sub
300244
301245data CacheSubscribed x a
302246 = CacheSubscribed { _cacheSubscribed_subscribers :: {-# UNPACK #-} !(FastWeakBag (Subscriber x a))
303247 , _cacheSubscribed_parent :: {-# UNPACK #-} !(EventSubscription x)
304248 , _cacheSubscribed_occurrence :: {-# UNPACK #-} !(IORef (Maybe a))
305−#ifdef DEBUG_NODEIDS
306− , _cacheSubscribed_nodeId :: {-# UNPACK #-} !Int
307−#endif
308249 }
309250
310−nowSpiderEventM :: (HasSpiderTimeline x) => EventM x (R.Event (SpiderTimeline x) ())
311−nowSpiderEventM =
312− SpiderEvent <$> now
313−
314−now :: (MonadIO m, Defer (Some Clear) m, HasSpiderTimeline x
315− ) => m (Event x ())
316−now = do
317− nowOrNot <- liftIO $ newIORef $ Just ()
318− scheduleClear nowOrNot
319− return . Event $ \_ -> do
320− occ <- liftIO . readIORef $ nowOrNot
321− return ( EventSubscription (return ()) eventSubscribedNow
322− , occ
323− )
324−
325251-- | Construct an 'Event' whose value is guaranteed not to be recomputed
326252-- repeatedly
327253--
@@ -346,23 +272,16 @@ cacheEvent e =
346272 subscribedTicket <- liftIO (readIORef mSubscribedRef >>= getFastWeakTicket) >>= \case
347273 Just subscribedTicket -> return subscribedTicket
348274 Nothing -> do
349−#ifdef DEBUG_NODEIDS
350− nodeId <- liftIO newNodeId
351−#endif
352275 subscribers <- liftIO FastWeakBag.empty
353276 occRef <- liftIO $ newIORef Nothing -- This should never be read prior to being set below
354−#ifdef DEBUG_NODEIDS
355− (parentSub, occ) <- subscribeAndRead e $ debugSubscriber' ("cacheEvent" <> showNodeId' nodeId) $ Subscriber
356−#else
357277 (parentSub, occ) <- subscribeAndRead e $ Subscriber
358−#endif
359− { subscriberPropagate = \a -> do
360− liftIO $ writeIORef occRef (Just a)
361− scheduleClear occRef
362− propagateFast a subscribers
363− , subscriberInvalidateHeight = FastWeakBag.traverse_ subscribers . invalidateSubscriberHeight
364− , subscriberRecalculateHeight = FastWeakBag.traverse_ subscribers . recalculateSubscriberHeight
365− }
278+ { subscriberPropagate = \a -> do
279+ liftIO $ writeIORef occRef (Just a)
280+ scheduleClear occRef
281+ propagateFast a subscribers
282+ , subscriberInvalidateHeight = FastWeakBag.traverse subscribers . invalidateSubscriberHeight
283+ , subscriberRecalculateHeight = FastWeakBag.traverse subscribers . recalculateSubscriberHeight
284+ }
366285 when (isJust occ) $ do
367286 liftIO $ writeIORef occRef occ -- Set the initial value of occRef; we don't need to do this if occ is Nothing
368287 scheduleClear occRef
@@ -370,45 +289,29 @@ cacheEvent e =
370289 { _cacheSubscribed_subscribers = subscribers
371290 , _cacheSubscribed_parent = parentSub
372291 , _cacheSubscribed_occurrence = occRef
373−#ifdef DEBUG_NODEIDS
374− , _cacheSubscribed_nodeId = nodeId
375−#endif
376292 }
377293 subscribedTicket <- liftIO $ mkFastWeakTicket subscribed
378294 liftIO $ writeIORef mSubscribedRef =<< getFastWeakTicketWeak subscribedTicket
379295 return subscribedTicket
380− liftIO $ cacheSubscription sub mSubscribedRef subscribedTicket
381−
382−cacheSubscription :: Subscriber x a -> IORef (FastWeak (CacheSubscribed x a))
383− -> FastWeakTicket (CacheSubscribed x a) -> IO (EventSubscription x, Maybe a)
384−cacheSubscription sub mSubscribedRef subscribedTicket = do
385− subscribed <- getFastWeakTicketValue subscribedTicket
386− ticket <- FastWeakBag.insert sub $ _cacheSubscribed_subscribers subscribed
387− occ <- readIORef $ _cacheSubscribed_occurrence subscribed
388−
389− let parentSub = _cacheSubscribed_parent subscribed
390− es = EventSubscription
391− { _eventSubscription_unsubscribe = do
392− FastWeakBag.remove ticket
393−
394− isEmpty <- FastWeakBag.isEmpty $ _cacheSubscribed_subscribers subscribed
395− when isEmpty $ do
396− writeIORef mSubscribedRef emptyFastWeak
397− unsubscribe parentSub
398− touch ticket
399− touch subscribedTicket
400− , _eventSubscription_subscribed = EventSubscribed
401− { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed parentSub
402− , eventSubscribedRetained = toAny subscribedTicket
403−#ifdef DEBUG_CYCLES
404− , eventSubscribedGetParents = return [_eventSubscription_subscribed parentSub]
405− , eventSubscribedHasOwnHeightRef = False
406− , eventSubscribedWhoCreated = whoCreatedIORef mSubscribedRef
407−#endif
408− }
409− }
410− return (es, occ)
411−
296+ liftIO $ do
297+ subscribed <- getFastWeakTicketValue subscribedTicket
298+ ticket <- FastWeakBag.insert sub $ _cacheSubscribed_subscribers subscribed
299+ occ <- readIORef $ _cacheSubscribed_occurrence subscribed
300+ let es = EventSubscription
301+ { _eventSubscription_unsubscribe = do
302+ FastWeakBag.remove ticket
303+ isEmpty <- FastWeakBag.isEmpty $ _cacheSubscribed_subscribers subscribed
304+ when isEmpty $ do
305+ writeIORef mSubscribedRef emptyFastWeak
306+ unsubscribe $ _cacheSubscribed_parent subscribed
307+ touch ticket
308+ touch subscribedTicket
309+ , _eventSubscription_subscribed = EventSubscribed
310+ { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed $ _cacheSubscribed_parent subscribed
311+ , eventSubscribedRetained = toAny subscribedTicket
312+ }
313+ }
314+ return (es, occ)
412315
413316subscribe :: Event x a -> Subscriber x a -> EventM x (EventSubscription x)
414317subscribe e s = fst <$> subscribeAndRead e s
@@ -423,11 +326,8 @@ wrap tag getSpecificSubscribed sub = do
423326eventRoot :: (GCompare k, HasSpiderTimeline x) => k a -> Root x k -> Event x a
424327eventRoot !k !r = Event $ wrap eventSubscribedRoot $ liftIO . getRootSubscribed k r
425328
426−subscribeAndReadNever :: EventM x (EventSubscription x, Maybe a)
427−subscribeAndReadNever = return (EventSubscription (return ()) eventSubscribedNever, Nothing)
428−
429329eventNever :: Event x a
430−eventNever = Event $ const subscribeAndReadNever
330+eventNever = Event $ \_ -> return (EventSubscription (return ()) eventSubscribedNever, Nothing)
431331
432332eventFan :: (GCompare k, HasSpiderTimeline x) => k a -> Fan x k v -> Event x (v a)
433333eventFan !k !f = Event $ wrap eventSubscribedFan $ getFanSubscribed k f
@@ -464,6 +364,16 @@ data Subscriber x a = Subscriber
464364 , subscriberRecalculateHeight :: !(Height -> IO ())
465365 }
466366
367+--TODO: Move this comment to WeakBag
368+-- These function are constructor functions that are marked NOINLINE so they are
369+-- opaque to GHC. If we do not do this, then GHC will sometimes fuse the constructor away
370+-- so any weak references that are attached to the constructors will have their
371+-- finalizer run. Using the opaque constructor, does not see the
372+-- constructor application, so it behaves like an IORef and cannot be fused away.
373+--
374+-- The result is also evaluated to WHNF, since forcing a thunk invalidates
375+-- the weak pointer to it in some cases.
376+
467377newSubscriberHold :: (HasSpiderTimeline x, Patch p) => Hold x p -> IO (Subscriber x p)
468378newSubscriberHold h = return $ Subscriber
469379 { subscriberPropagate = {-# SCC "traverseHold" #-} propagateSubscriberHold h
@@ -485,12 +395,14 @@ newSubscriberFan subscribed = debugSubscriber ("SubscriberFan " <> showNodeId su
485395 return ()
486396 , subscriberInvalidateHeight = \old -> do
487397 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
488− forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse_ (_fanSubscribedChildren_list v) $ invalidateSubscriberHeight old
398+ forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse (_fanSubscribedChildren_list v) $ invalidateSubscriberHeight old
399+
489400 , subscriberRecalculateHeight = \new -> do
490401 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
491− forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse_ (_fanSubscribedChildren_list v) $ recalculateSubscriberHeight new
402+ forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse (_fanSubscribedChildren_list v) $ recalculateSubscriberHeight new
492403 }
493404
405+
494406newSubscriberSwitch :: forall x a. HasSpiderTimeline x => SwitchSubscribed x a -> IO (Subscriber x a)
495407newSubscriberSwitch subscribed = debugSubscriber ("SubscriberCoincidenceOuter" <> showNodeId subscribed) $ Subscriber
496408 { subscriberPropagate = \a -> {-# SCC "traverseSwitch" #-} do
@@ -501,7 +413,7 @@ newSubscriberSwitch subscribed = debugSubscriber ("SubscriberCoincidenceOuter" <
501413 oldHeight <- readIORef $ switchSubscribedHeight subscribed
502414 when (oldHeight /= invalidHeight) $ do
503415 writeIORef (switchSubscribedHeight subscribed) $! invalidHeight
504− WeakBag.traverse_ (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
416+ WeakBag.traverse (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
505417 , subscriberRecalculateHeight = (`updateSwitchHeight` subscribed)
506418 }
507419
@@ -517,17 +429,17 @@ newSubscriberCoincidenceOuter subscribed = debugSubscriber ("SubscriberCoinciden
517429 liftIO $ writeIORef (coincidenceSubscribedInnerParent subscribed) $ Just innerSubd
518430 scheduleClear $ coincidenceSubscribedInnerParent subscribed
519431 case occ of
520− Nothing ->
432+ Nothing -> do
521433 when (innerHeight > outerHeight) $ liftIO $ do -- If the event fires, it will fire at a later height
522434 writeIORef (coincidenceSubscribedHeight subscribed) $! innerHeight
523− WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight outerHeight
524− WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ recalculateSubscriberHeight innerHeight
435+ WeakBag.traverse (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight outerHeight
436+ WeakBag.traverse (coincidenceSubscribedSubscribers subscribed) $ recalculateSubscriberHeight innerHeight
525437 Just o -> do -- Since it's already firing, no need to adjust height
526438 liftIO $ writeIORef (coincidenceSubscribedOccurrence subscribed) occ
527439 scheduleClear $ coincidenceSubscribedOccurrence subscribed
528440 propagate o $ coincidenceSubscribedSubscribers subscribed
529441 , subscriberInvalidateHeight = \_ -> invalidateCoincidenceHeight subscribed
530− , subscriberRecalculateHeight = \_ -> recalculateCoincidenceHeight subscribed
442+ , subscriberRecalculateHeight = \_ -> recalculateCoincidenceHeight subscribed
531443 }
532444
533445newSubscriberCoincidenceInner :: forall x a. HasSpiderTimeline x => CoincidenceSubscribed x a -> IO (Subscriber x a)
@@ -551,18 +463,18 @@ recalculateSubscriberHeight :: Height -> Subscriber x a -> IO ()
551463recalculateSubscriberHeight = flip subscriberRecalculateHeight
552464
553465-- | Propagate everything at the current height
554−propagate :: forall x a. HasSpiderTimeline x => a -> WeakBag (Subscriber x a) -> EventM x ()
555−propagate a subscribers = withIncreasedDepth (Proxy::Proxy x) $
466+propagate :: a -> WeakBag (Subscriber x a) -> EventM x ()
467+propagate a subscribers = withIncreasedDepth (Proxy::Proxy x) $ do
556468 -- Note: in the following traversal, we do not visit nodes that are added to the list during our traversal; they are new events, which will necessarily have full information already, so there is no need to traverse them
557469 --TODO: Should we check if nodes already have their values before propagating? Maybe we're re-doing work
558− WeakBag.traverse_ subscribers $ \s -> subscriberPropagate s a
470+ WeakBag.traverse subscribers $ \s -> subscriberPropagate s a
559471
560472-- | Propagate everything at the current height
561−propagateFast :: forall x a. HasSpiderTimeline x => a -> FastWeakBag (Subscriber x a) -> EventM x ()
562−propagateFast a subscribers = withIncreasedDepth (Proxy::Proxy x) $
473+propagateFast :: a -> FastWeakBag (Subscriber x a) -> EventM x ()
474+propagateFast a subscribers = withIncreasedDepth (Proxy::Proxy x) $ do
563475 -- Note: in the following traversal, we do not visit nodes that are added to the list during our traversal; they are new events, which will necessarily have full information already, so there is no need to traverse them
564476 --TODO: Should we check if nodes already have their values before propagating? Maybe we're re-doing work
565− FastWeakBag.traverse_ subscribers $ \s -> subscriberPropagate s a
477+ FastWeakBag.traverse subscribers $ \s -> subscriberPropagate s a
566478
567479--------------------------------------------------------------------------------
568480-- EventSubscribed
@@ -580,7 +492,7 @@ data EventSubscribed x = EventSubscribed
580492 { eventSubscribedHeightRef :: {-# UNPACK #-} !(IORef Height)
581493 , eventSubscribedRetained :: {-# NOUNPACK #-} !Any
582494#ifdef DEBUG_CYCLES
583− , eventSubscribedGetParents :: !(IO [EventSubscribed x]) -- For debugging loops
495+ , eventSubscribedGetParents :: !(IO [Some (EventSubscribed x)]) -- For debugging loops
584496 , eventSubscribedHasOwnHeightRef :: !Bool
585497 , eventSubscribedWhoCreated :: !(IO [String])
586498#endif
@@ -607,23 +519,13 @@ eventSubscribedNever = EventSubscribed
607519 , eventSubscribedWhoCreated = return ["never"]
608520#endif
609521 }
610−eventSubscribedNow :: EventSubscribed x
611−eventSubscribedNow = EventSubscribed
612− { eventSubscribedHeightRef = zeroRef
613− , eventSubscribedRetained = toAny ()
614−#ifdef DEBUG_CYCLES
615− , eventSubscribedGetParents = return []
616− , eventSubscribedHasOwnHeightRef = False
617− , eventSubscribedWhoCreated = return ["now"]
618−#endif
619− }
620522
621523eventSubscribedFan :: FanSubscribed x k v -> EventSubscribed x
622524eventSubscribedFan !subscribed = EventSubscribed
623525 { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed $ fanSubscribedParent subscribed
624526 , eventSubscribedRetained = toAny subscribed
625527#ifdef DEBUG_CYCLES
626− , eventSubscribedGetParents = return [_eventSubscription_subscribed $ fanSubscribedParent subscribed]
528+ , eventSubscribedGetParents = return [Some $ _eventSubscription_subscribed $ fanSubscribedParent subscribed]
627529 , eventSubscribedHasOwnHeightRef = False
628530 , eventSubscribedWhoCreated = whoCreatedIORef $ fanSubscribedCachedSubscribed subscribed
629531#endif
@@ -636,7 +538,7 @@ eventSubscribedSwitch !subscribed = EventSubscribed
636538#ifdef DEBUG_CYCLES
637539 , eventSubscribedGetParents = do
638540 s <- readIORef $ switchSubscribedCurrentParent subscribed
639− return [_eventSubscription_subscribed s]
541+ return [Some $ _eventSubscription_subscribed s]
640542 , eventSubscribedHasOwnHeightRef = True
641543 , eventSubscribedWhoCreated = whoCreatedIORef $ switchSubscribedCachedSubscribed subscribed
642544#endif
@@ -649,8 +551,8 @@ eventSubscribedCoincidence !subscribed = EventSubscribed
649551#ifdef DEBUG_CYCLES
650552 , eventSubscribedGetParents = do
651553 innerSubscription <- readIORef $ coincidenceSubscribedInnerParent subscribed
652− let outerParent = _eventSubscription_subscribed $ coincidenceSubscribedOuterParent subscribed
653− innerParents = maybeToList $ innerSubscription
554+ let outerParent = Some $ _eventSubscription_subscribed $ coincidenceSubscribedOuterParent subscribed
555+ innerParents = maybeToList $ fmap Some innerSubscription
654556 return $ outerParent : innerParents
655557 , eventSubscribedHasOwnHeightRef = True
656558 , eventSubscribedWhoCreated = whoCreatedIORef $ coincidenceSubscribedCachedSubscribed subscribed
@@ -664,15 +566,15 @@ getEventSubscribedHeight es = readIORef $ eventSubscribedHeightRef es
664566whoCreatedEventSubscribed :: EventSubscribed x -> IO [String]
665567whoCreatedEventSubscribed = eventSubscribedWhoCreated
666568
667−walkInvalidHeightParents :: EventSubscribed x -> IO [EventSubscribed x]
569+walkInvalidHeightParents :: EventSubscribed x -> IO [Some (EventSubscribed x)]
668570walkInvalidHeightParents s0 = do
669− subscribers <- flip execStateT mempty $ ($ s0) $ fix $ \loop s -> do
571+ subscribers <- flip execStateT mempty $ ($ Some s0) $ fix $ \loop (Some s) -> do
670572 h <- liftIO $ readIORef $ eventSubscribedHeightRef s
671573 when (h == invalidHeight) $ do
672574 when (eventSubscribedHasOwnHeightRef s) $ liftIO $ writeIORef (eventSubscribedHeightRef s) $! invalidHeightBeingTraversed
673− modify (s :)
575+ modify (Some s :)
674576 mapM_ loop =<< liftIO (eventSubscribedGetParents s)
675− forM_ subscribers $ \s -> writeIORef (eventSubscribedHeightRef s) $! invalidHeight
577+ forM_ subscribers $ \(Some s) -> writeIORef (eventSubscribedHeightRef s) $! invalidHeight
676578 return subscribers
677579#endif
678580
@@ -994,10 +896,8 @@ instance Monad (BehaviorM x) where
994896 BehaviorM x >> BehaviorM y = BehaviorM $ x >> y
995897 {-# INLINE return #-}
996898 return x = BehaviorM $ return x
997−#if !MIN_VERSION_base(4,13,0)
998899 {-# INLINE fail #-}
999900 fail s = BehaviorM $ fail s
1000−#endif
1001901
1002902data BehaviorSubscribed x a
1003903 = forall p. BehaviorSubscribedHold (Hold x p)
@@ -1057,7 +957,7 @@ data SomeMergeUpdate x = SomeMergeUpdate
1057957newtype SomeMergeInit x = SomeMergeInit { unSomeMergeInit :: EventM x () }
1058958
1059959-- EventM can do everything BehaviorM can, plus create holds
1060−newtype EventM x a = EventM { unEventM :: IO a } deriving (Functor, Applicative, Monad, MonadIO, MonadFix, MonadException, MonadAsyncException)
960+newtype EventM x a = EventM { unEventM :: IO a } deriving (Functor, Applicative, Monad, MonadIO, MonadFix, MonadException, MonadAsyncException)
1061961
1062962newtype MergeSubscribedParent x a = MergeSubscribedParent { unMergeSubscribedParent :: EventSubscription x }
1063963
@@ -1082,8 +982,7 @@ heightBagFromList :: [Height] -> HeightBag
1082982heightBagFromList heights = heightBagVerify $ foldl' (flip heightBagAdd) heightBagEmpty heights
1083983
1084984heightBagAdd :: Height -> HeightBag -> HeightBag
1085−heightBagAdd (Height h) (HeightBag s c) = heightBagVerify $ HeightBag (succ s) $
1086− IntMap.insertWithKey (\_ _ old -> succ old) h 0 c
985+heightBagAdd (Height h) (HeightBag s c) = heightBagVerify $ HeightBag (succ s) $ IntMap.insertWithKey (\_ _ old -> succ old) h 0 c
1087986
1088987heightBagRemove :: Height -> HeightBag -> HeightBag
1089988heightBagRemove (Height h) b@(HeightBag s c) = heightBagVerify $ case IntMap.lookup h c of
@@ -1092,13 +991,6 @@ heightBagRemove (Height h) b@(HeightBag s c) = heightBagVerify $ case IntMap.loo
1092991 0 -> IntMap.delete h c
1093992 _ -> IntMap.insert h (pred old) c
1094993
1095−heightBagRemoveMaybe :: Height -> HeightBag -> Maybe HeightBag
1096−heightBagRemoveMaybe (Height h) b@(HeightBag s c) = heightBagVerify . removed <$> IntMap.lookup h c where
1097− removed old = HeightBag (pred s) $ case old of
1098− 0 -> IntMap.delete h c
1099− _ -> IntMap.insert h (pred old) c
1100−
1101−
1102994heightBagMax :: HeightBag -> Height
1103995heightBagMax (HeightBag _ c) = case IntMap.maxViewWithKey c of
1104996 Just ((h, _), _) -> Height h
@@ -1199,10 +1091,7 @@ instance HasSpiderTimeline x => Semialign (Event x) where
11991091 align ea eb = mapMaybe dmapToThese $ mergeG coerce $ dynamicConst $
12001092 DMap.fromDistinctAscList [LeftTag :=> ea, RightTag :=> eb]
12011093
1202−#ifdef MIN_VERSION_semialign
1203−#if MIN_VERSION_semialign(1,1,0)
1204−instance HasSpiderTimeline x => Zip (Event x) where
1205−#endif
1094+#if defined(MIN_VERSION_semialign)
12061095 zip x y = mapMaybe justThese $ align x y
12071096#endif
12081097
@@ -1346,7 +1235,7 @@ mkWeakPtrWithDebug x debugNote = do
13461235 x' <- evaluate x
13471236 mkWeakPtr x' $
13481237 if debugFinalize
1349− then Just $ debugStrLn $ "finalizing: " ++ debugNote
1238+ then Just $ putStrLn $ "finalizing: " ++ debugNote
13501239 else Nothing
13511240
13521241type WeakList a = [Weak a]
@@ -1359,22 +1248,19 @@ type CanTrace x m = (HasSpiderTimeline x, MonadIO m)
13591248#ifdef DEBUG
13601249
13611250debugSubscriber :: forall x a. HasSpiderTimeline x => String -> Subscriber x a -> IO (Subscriber x a)
1362−debugSubscriber description = return . debugSubscriber' description
1363−
1364−debugSubscriber' :: forall x a. HasSpiderTimeline x => String -> Subscriber x a -> Subscriber x a
1365−debugSubscriber' description subscribed = Subscriber
1251+debugSubscriber description subscribed = return $ Subscriber
13661252 {
13671253 subscriberPropagate = \m -> do
13681254 tracePropagate (Proxy :: Proxy x) ("subscriberPropagate: " <> description)
13691255 subscriberPropagate subscribed m
13701256 , subscriberInvalidateHeight = \old -> do
1371− traceInvalidateHeight $ "invalidateSubscriberHeight: " <> description <> ", old = " <> show (unHeight old)
1257+ putStrLn $ "invalidateSubscriberHeight: " <> description
13721258 subscriberInvalidateHeight subscribed old
1373− traceInvalidateHeight $ "invalidateSubscriberHeight: " <> description <> ", done"
1259+ putStrLn $ "invalidateSubscriberHeight: " <> description <> ", done"
13741260 , subscriberRecalculateHeight = \new -> do
1375− traceInvalidateHeight $ "subscriberRecalculateHeight: " <> description <> ", new = " <> show (unHeight new)
1261+ putStrLn $ "subscriberRecalculateHeight: " <> description
13761262 subscriberRecalculateHeight subscribed new
1377− traceInvalidateHeight $ "subscriberRecalculateHeight: " <> description <> ", done"
1263+ putStrLn $ "subscriberRecalculateHeight: " <> description <> ", done"
13781264 }
13791265
13801266
@@ -1388,15 +1274,11 @@ withIncreasedDepth _ a = do
13881274
13891275{-# INLINE tracePropagate #-}
13901276tracePropagate :: (CanTrace x m) => proxy x -> String -> m ()
1391−tracePropagate p = when debugPropagate . trace p
1277+tracePropagate p = trace p
13921278
13931279{-# INLINE traceInvalidate #-}
13941280traceInvalidate :: String -> IO ()
1395−traceInvalidate = when debugInvalidate . liftIO . debugStrLn
1396−
1397−{-# INLINE traceInvalidateHeight #-}
1398−traceInvalidateHeight :: String -> IO ()
1399−traceInvalidateHeight = when debugInvalidateHeight . liftIO . debugStrLn
1281+traceInvalidate = liftIO . putStrLn
14001282
14011283{-# INLINE trace #-}
14021284trace :: (CanTrace x m) => proxy x -> String -> m ()
@@ -1407,7 +1289,7 @@ traceM :: forall x proxy m. (CanTrace x m) => proxy x -> m String -> m ()
14071289traceM _ getMessage = do
14081290 message <- getMessage
14091291 d <- liftIO $ readIORef $ _spiderTimeline_depth $ unSTE (spiderTimeline :: SpiderTimelineEnv x)
1410− liftIO $ debugStrLn $ replicate d ' ' <> message
1292+ liftIO $ putStrLn $ replicate d ' ' <> message
14111293
14121294#else
14131295
@@ -1423,20 +1305,10 @@ tracePropagate _ _ = return ()
14231305traceInvalidate :: String -> IO ()
14241306traceInvalidate _ = return ()
14251307
1426−{-# INLINE traceInvalidateHeight #-}
1427−traceInvalidateHeight :: String -> IO ()
1428−traceInvalidateHeight _ = return ()
1429−
14301308{-# INLINE debugSubscriber #-}
14311309debugSubscriber :: String -> Subscriber x a -> IO (Subscriber x a)
14321310debugSubscriber _ = return
14331311
1434−{-# INLINE debugSubscriber' #-}
1435−debugSubscriber' :: String -> Subscriber x a -> Subscriber x a
1436−debugSubscriber' _ = id
1437−
1438−
1439−
14401312{-# INLINE trace #-}
14411313trace :: (CanTrace x m) => proxy x -> String -> m ()
14421314trace _ _ = return ()
@@ -1447,9 +1319,18 @@ traceM _ _ = return ()
14471319
14481320#endif
14491321
1322+
14501323whoCreatedIORef :: IORef a -> IO [String]
14511324whoCreatedIORef (IORef a) = whoCreated $! a
14521325
1326+#ifdef DEBUG_CYCLES
1327+
1328+data EventLoopException = EventLoopException (Forest String)
1329+instance Exception EventLoopException
1330+
1331+instance Show EventLoopException where
1332+ show (EventLoopException stacks) = "Causality loop detected:\n" <> drawForest stacks
1333+
14531334groupByHead :: Eq a => [NonEmpty a] -> [(a, NonEmpty [a])]
14541335groupByHead = \case
14551336 [] -> []
@@ -1460,28 +1341,7 @@ groupByHead = \case
14601341 | otherwise -> (x, xs :| []) : l
14611342
14621343listsToForest :: Eq a => [[a]] -> Forest a
1463−listsToForest lists = buildForest <$> groupByHead (mapMaybe nonEmpty lists)
1464− where buildForest (a, lists') = Node a $ listsToForest $ toList lists'
1465−
1466−showStacks :: [[String]] -> String
1467−showStacks = drawForest . listsToForest . fmap (filterStack "Reflex.Spider.Internal")
1468−
1469−filterStack :: String -> [String] -> [String]
1470−#ifdef DEBUG_HIDE_INTERNALS
1471−filterStack prefix = filter (not . (prefix `isPrefixOf`))
1472−#else
1473−filterStack prefix = id
1474−#endif
1475−
1476−#ifdef DEBUG_CYCLES
1477−
1478−data EventLoopException = EventLoopException [[String]]
1479−instance Exception EventLoopException
1480−
1481−instance Show EventLoopException where
1482− show (EventLoopException stacks) = "causality loop detected:\n" <> if null stacks
1483− then "no location information, compile with profiling enabled for stack tree"
1484− else showStacks stacks
1344+listsToForest l = fmap (\(a, l') -> Node a $ listsToForest $ toList l') $ groupByHead $ catMaybes $ fmap nonEmpty l
14851345
14861346#else
14871347
@@ -1489,8 +1349,8 @@ data EventLoopException = EventLoopException
14891349instance Exception EventLoopException
14901350
14911351instance Show EventLoopException where
1492− show EventLoopException = "causality loop detected: \n" <>
1493− "compile reflex with flag 'debug-cycles' and compile with profiling enabled for stack tree"
1352+ show EventLoopException = "Causality loop detected: \n" <>
1353+ "no location information, compile with --enable-profiling and reflex with flag 'debug-cycles'"
14941354
14951355#endif
14961356
@@ -1498,7 +1358,7 @@ instance Show EventLoopException where
14981358{-# INLINE propagateSubscriberHold #-}
14991359propagateSubscriberHold :: forall x p. (HasSpiderTimeline x, Patch p) => Hold x p -> p -> EventM x ()
15001360propagateSubscriberHold h a = do
1501− {-# SCC "trace" #-} when debugPropagate $ traceM (Proxy :: Proxy x) $ liftIO $ do
1361+ traceM (Proxy :: Proxy x) $ liftIO $ do
15021362 invalidators <- liftIO $ readIORef $ holdInvalidators h
15031363 return $ "SubscriberHold" <> showNodeId h <> ": " ++ show (length invalidators)
15041364
@@ -1506,7 +1366,7 @@ propagateSubscriberHold h a = do
15061366 case {-# SCC "apply" #-} apply a v of
15071367 Nothing -> return ()
15081368 Just v' -> do
1509− {-# SCC "trace2" #-} withIncreasedDepth (Proxy :: Proxy x) $
1369+ withIncreasedDepth (Proxy :: Proxy x) $
15101370 tracePropagate (Proxy :: Proxy x) ("propagateSubscriberHold: assigning Hold" <> showNodeId h)
15111371 vRef <- {-# SCC "vRef" #-} liftIO $ evaluate $ holdValue h
15121372 iRef <- {-# SCC "iRef" #-} liftIO $ evaluate $ holdInvalidators h
@@ -1627,9 +1487,6 @@ data FanInt x a = FanInt
16271487 { _fanInt_subscribers :: {-# UNPACK #-} !(FastMutableIntMap (FastWeakBag (Subscriber x a))) --TODO: Clean up the keys in here when their child weak bags get empty --TODO: Remove our own subscription when the subscribers list is completely empty
16281488 , _fanInt_subscriptionRef :: {-# UNPACK #-} !(IORef (EventSubscription x)) -- This should have a valid subscription iff subscribers is non-empty
16291489 , _fanInt_occRef :: {-# UNPACK #-} !(IORef (IntMap a))
1630−#ifdef DEBUG_NODEIDS
1631− , _fanInt_nodeId :: {-# UNPACK #-} !Int
1632−#endif
16331490 }
16341491
16351492newFanInt :: IO (FanInt x a)
@@ -1637,16 +1494,10 @@ newFanInt = do
16371494 subscribers <- FastMutableIntMap.newEmpty --TODO: Clean up the keys in here when their child weak bags get empty --TODO: Remove our own subscription when the subscribers list is completely empty
16381495 subscriptionRef <- newIORef $ error "fanInt: no subscription"
16391496 occRef <- newIORef $ error "fanInt: no occurrence"
1640−#ifdef DEBUG_NODEIDS
1641− nodeId <- newNodeId
1642−#endif
16431497 return $ FanInt
16441498 { _fanInt_subscribers = subscribers
16451499 , _fanInt_subscriptionRef = subscriptionRef
16461500 , _fanInt_occRef = occRef
1647−#ifdef DEBUG_NODEIDS
1648− , _fanInt_nodeId = nodeId
1649−#endif
16501501 }
16511502
16521503fanInt :: HasSpiderTimeline x => Event x (IntMap a) -> EventSelectorInt x a
@@ -1655,21 +1506,20 @@ fanInt p = unsafePerformIO $ do
16551506 pure $ EventSelectorInt $ \k -> Event $ \sub -> do
16561507 isEmpty <- liftIO $ FastMutableIntMap.isEmpty (_fanInt_subscribers self)
16571508 when isEmpty $ do -- This is the first subscriber, so we need to subscribe to our input
1658− let desc = "fanInt" <> showNodeId self <> ", k = " <> show k
1659− (subscription, parentOcc) <- subscribeAndRead p $ debugSubscriber' desc $ Subscriber
1509+ (subscription, parentOcc) <- subscribeAndRead p $ Subscriber
16601510 { subscriberPropagate = \m -> do
16611511 liftIO $ writeIORef (_fanInt_occRef self) m
16621512 scheduleIntClear $ _fanInt_occRef self
1663− FastMutableIntMap.forIntersectionWithImmutable_ (_fanInt_subscribers self) m $ \b v -> --TODO: Do we need to know that no subscribers are being added as we traverse?
1664− FastWeakBag.traverse_ b $ \s ->
1513+ FastMutableIntMap.forIntersectionWithImmutable_ (_fanInt_subscribers self) m $ \b v -> do --TODO: Do we need to know that no subscribers are being added as we traverse?
1514+ FastWeakBag.traverse b $ \s -> do
16651515 subscriberPropagate s v
1666− , subscriberInvalidateHeight = \old ->
1667− FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b ->
1668− FastWeakBag.traverse_ b $ \s ->
1516+ , subscriberInvalidateHeight = \old -> do
1517+ FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b -> do
1518+ FastWeakBag.traverse b $ \s -> do
16691519 subscriberInvalidateHeight s old
1670− , subscriberRecalculateHeight = \new ->
1671− FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b ->
1672− FastWeakBag.traverse_ b $ \s ->
1520+ , subscriberRecalculateHeight = \new -> do
1521+ FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b -> do
1522+ FastWeakBag.traverse b $ \s -> do
16731523 subscriberRecalculateHeight s new
16741524 }
16751525 liftIO $ do
@@ -1683,25 +1533,10 @@ fanInt p = unsafePerformIO $ do
16831533 FastMutableIntMap.insert (_fanInt_subscribers self) k b
16841534 return b
16851535 Just b -> return b
1686− ticket <- liftIO $ FastWeakBag.insert sub b
1536+ t <- liftIO $ FastWeakBag.insert sub b
16871537 currentOcc <- readIORef (_fanInt_occRef self)
1688−
1689− subscribed <- fanIntSubscribed ticket self
1690− return (EventSubscription (FastWeakBag.remove ticket) subscribed, IntMap.lookup k currentOcc)
1691−
1692−fanIntSubscribed :: FastWeakBagTicket k -> FanInt x a -> IO (EventSubscribed x)
1693−fanIntSubscribed ticket self = do
1694− subscribedParent <- _eventSubscription_subscribed <$> readIORef (_fanInt_subscriptionRef self)
1695− return $ EventSubscribed
1696− { eventSubscribedHeightRef = eventSubscribedHeightRef subscribedParent
1697− , eventSubscribedRetained = toAny (_fanInt_subscriptionRef self, ticket)
1698−#ifdef DEBUG_CYCLES
1699− , eventSubscribedGetParents = return [subscribedParent]
1700− , eventSubscribedHasOwnHeightRef = False
1701− , eventSubscribedWhoCreated = whoCreatedIORef $ _fanInt_subscriptionRef self
1702−#endif
1703− }
1704−
1538+ (EventSubscription _ (EventSubscribed !heightRef _)) <- readIORef (_fanInt_subscriptionRef self)
1539+ return (EventSubscription (FastWeakBag.remove t) $! EventSubscribed heightRef $! toAny (_fanInt_subscriptionRef self, t), IntMap.lookup k currentOcc)
17051540
17061541{-# INLINABLE getFanSubscribed #-}
17071542getFanSubscribed :: (HasSpiderTimeline x, GCompare k) => k a -> Fan x k v -> Subscriber x (v a) -> EventM x (WeakBagTicket, FanSubscribed x k v, Maybe (v a))
@@ -1899,7 +1734,7 @@ mergeCheap
18991734 => (forall a. q a -> Event x (v a))
19001735 -> DynamicS x (PatchDMap k q)
19011736 -> Event x (DMap k v)
1902−mergeCheap nt = mergeGCheap' unMergeSubscribedParent getInitialSubscribers updateMe destroy
1737+mergeCheap nt = mergeGCheap' getInitialSubscribers updateMe destroy
19031738 where
19041739 updateMe :: MergeUpdateFunc k v x (PatchDMap k q) (MergeSubscribedParent x)
19051740 updateMe subscriber heightBagRef oldParents (PatchDMap p) = do
@@ -1914,9 +1749,7 @@ mergeCheap nt = mergeGCheap' unMergeSubscribedParent getInitialSubscribers updat
19141749 liftIO $ modifyIORef' heightBagRef $ heightBagAdd newParentHeight
19151750 return $ DMap.insertLookupWithKey' (\_ new _ -> new) k newParent ps
19161751 forM_ mOldSubd $ \oldSubd -> do
1917− oldHeight <- liftIO $ getEventSubscribedHeight $
1918− _eventSubscription_subscribed $ unMergeSubscribedParent oldSubd
1919−
1752+ oldHeight <- liftIO $ getEventSubscribedHeight $ _eventSubscription_subscribed $ unMergeSubscribedParent oldSubd
19201753 liftIO $ modifyIORef heightBagRef $ heightBagRemove oldHeight
19211754 return (maybeToList (unMergeSubscribedParent <$> mOldSubd) ++ subscriptionsToKill, newPs)
19221755 foldM f ([], oldParents) $ DMap.toList p
@@ -1941,7 +1774,7 @@ mergeCheapWithMove :: forall k x v q. (HasSpiderTimeline x, GCompare k)
19411774 => (forall a. q a -> Event x (v a))
19421775 -> DynamicS x (PatchDMapWithMove k q)
19431776 -> Event x (DMap k v)
1944−mergeCheapWithMove nt = mergeGCheap' _mergeSubscribedParentWithMove_subscription getInitialSubscribers updateMe destroy
1777+mergeCheapWithMove nt = mergeGCheap' getInitialSubscribers updateMe destroy
19451778 where
19461779 updateMe :: MergeUpdateFunc k v x (PatchDMapWithMove k q) (MergeSubscribedParentWithMove x k)
19471780 updateMe subscriber heightBagRef oldParents p = do
@@ -1960,17 +1793,13 @@ mergeCheapWithMove nt = mergeGCheap' _mergeSubscribedParentWithMove_subscription
19601793 let moveOrDelete :: forall a. k a -> PatchDMapWithMove.NodeInfo k q a -> MergeSubscribedParentWithMove x k a -> Constant (EventM x (Maybe (EventSubscription x))) a
19611794 moveOrDelete _ ni parent = Constant $ case getComposeMaybe $ PatchDMapWithMove._nodeInfo_to ni of
19621795 Nothing -> do
1963− oldHeight <- liftIO $ getEventSubscribedHeight $ _eventSubscription_subscribed $
1964− _mergeSubscribedParentWithMove_subscription parent
1965−
1796+ oldHeight <- liftIO $ getEventSubscribedHeight $ _eventSubscription_subscribed $ _mergeSubscribedParentWithMove_subscription parent
19661797 liftIO $ modifyIORef heightBagRef $ heightBagRemove oldHeight
19671798 return $ Just $ _mergeSubscribedParentWithMove_subscription parent
19681799 Just toKey -> do
19691800 liftIO $ writeIORef (_mergeSubscribedParentWithMove_key parent) $! toKey
19701801 return Nothing
1971− toDelete <- fmap catMaybes $ mapM (\(_ :=> v) -> getConstant v) $ DMap.toList $
1972− DMap.intersectionWithKey moveOrDelete (unPatchDMapWithMove p) oldParents
1973−
1802+ toDelete <- fmap catMaybes $ mapM (\(_ :=> v) -> getConstant v) $ DMap.toList $ DMap.intersectionWithKey moveOrDelete (unPatchDMapWithMove p) oldParents
19741803 return (toDelete, applyAlways p' oldParents)
19751804 getInitialSubscribers :: MergeInitFunc k v q x (MergeSubscribedParentWithMove x k)
19761805 getInitialSubscribers initialParents subscriber = do
@@ -1995,8 +1824,6 @@ type MergeUpdateFunc k v x p s
19951824 -> p
19961825 -> EventM x ([EventSubscription x], DMap k s)
19971826
1998−type MergeGetSubscription x s = forall a. s a -> EventSubscription x
1999−
20001827type MergeInitFunc k v q x s
20011828 = DMap k q
20021829 -> (forall a. EventM x (k a) -> Subscriber x (v a))
@@ -2020,17 +1847,14 @@ invalidateMergeHeight m = invalidateMergeHeight' (_merge_heightRef m) (_merge_su
20201847invalidateMergeHeight' :: IORef Height -> Subscriber x a -> IO ()
20211848invalidateMergeHeight' heightRef sub = do
20221849 oldHeight <- readIORef heightRef
2023− -- If the height used to be valid, it must be invalid now; we should never have *more* heights than we have parents
2024− when (oldHeight /= invalidHeight) $ do
1850+ when (oldHeight /= invalidHeight) $ do -- If the height used to be valid, it must be invalid now; we should never have *more* heights than we have parents
20251851 writeIORef heightRef $! invalidHeight
20261852 subscriberInvalidateHeight sub oldHeight
20271853
20281854revalidateMergeHeight :: Merge x k v s -> IO ()
20291855revalidateMergeHeight m = do
20301856 currentHeight <- readIORef $ _merge_heightRef m
2031−
2032− -- revalidateMergeHeight may be called multiple times; perhaps the's a way to finesse it to avoid this check
2033− when (currentHeight == invalidHeight) $ do
1857+ when (currentHeight == invalidHeight) $ do -- revalidateMergeHeight may be called multiple times; perhaps the's a way to finesse it to avoid this check
20341858 heights <- readIORef $ _merge_heightBagRef m
20351859 parents <- readIORef $ _merge_parentsRef m
20361860 -- When the number of heights in the bag reaches the number of parents, we should have a valid height
@@ -2038,7 +1862,7 @@ revalidateMergeHeight m = do
20381862 LT -> return ()
20391863 EQ -> do
20401864 let height = succHeight $ heightBagMax heights
2041− traceInvalidateHeight $ "recalculateSubscriberHeight: height: " <> show height
1865+ traceInvalidate $ "recalculateSubscriberHeight: height: " <> show height
20421866 writeIORef (_merge_heightRef m) $! height
20431867 subscriberRecalculateHeight (_merge_sub m) height
20441868 GT -> error $ "revalidateMergeHeight: more heights (" <> show (heightBagSize heights) <> ") than parents (" <> show (DMap.size parents) <> ") for Merge"
@@ -2046,44 +1870,38 @@ revalidateMergeHeight m = do
20461870scheduleMergeSelf :: HasSpiderTimeline x => Merge x k v s -> Height -> EventM x ()
20471871scheduleMergeSelf m height = scheduleMerge' height (_merge_heightRef m) $ do
20481872 vals <- liftIO $ readIORef $ _merge_accumRef m
2049− -- Once we're done with this, we can clear it immediately, because if there's a cacheEvent in front of us,
2050− -- it'll handle subsequent subscribers, and if not, we won't get subsequent subscribers
2051− liftIO $ writeIORef (_merge_accumRef m) $! DMap.empty
1873+ liftIO $ writeIORef (_merge_accumRef m) $! DMap.empty -- Once we're done with this, we can clear it immediately, because if there's a cacheEvent in front of us, it'll handle subsequent subscribers, and if not, we won't get subsequent subscribers
20521874 --TODO: Assert that m is not empty
20531875 subscriberPropagate (_merge_sub m) vals
20541876
2055−checkCycle :: HasSpiderTimeline x => EventSubscribed x -> EventM x ()
2056−checkCycle subscribed = liftIO $ do
2057− height <- readIORef (eventSubscribedHeightRef subscribed)
2058−
2059− -- currentHeight <- getCurrentHeight
2060− -- when (height <= currentHeight) $ if height /= invalidHeight
2061− -- then do
2062− -- myStack <- liftIO $ whoCreatedIORef undefined --TODO
2063− -- error $ "Height (" ++ show height ++ ") is not greater than current height (" ++ show currentHeight ++ ")\n" ++ unlines (reverse myStack)
2064− -- else liftIO $
2065− when (height == invalidHeight) $
1877+checkCycle :: HasSpiderTimeline x => Height -> EventM x ()
1878+checkCycle height = do
1879+ currentHeight <- getCurrentHeight
1880+ when (height <= currentHeight) $ if height /= invalidHeight
1881+ then do
1882+ myStack <- liftIO $ whoCreatedIORef undefined --TODO
1883+ error $ "Height (" ++ show height ++ ") is not greater than current height (" ++ show currentHeight ++ ")\n" ++ unlines (reverse myStack)
1884+ else liftIO $ do
20661885#ifdef DEBUG_CYCLES
2067− do
2068− nodesInvolvedInCycle <- walkInvalidHeightParents subscribed
2069− stacks <- forM nodesInvolvedInCycle whoCreatedEventSubscribed
2070− throwIO (EventLoopException stacks)
1886+ nodesInvolvedInCycle <- walkInvalidHeightParents $ eventSubscribedMerge subscribed
1887+ stacks <- forM nodesInvolvedInCycle $ \(Some es) -> whoCreatedEventSubscribed es
1888+ throwIO (EventLoopException stacks)
20711889#else
2072− throwIO EventLoopException
1890+ throwIO EventLoopException
20731891#endif
1892+
20741893
2075−
2076−mergeSubscriber :: forall x k v s a. (HasSpiderTimeline x, GCompare k) => EventSubscribed x -> Merge x k v s -> EventM x (k a) -> Subscriber x (v a)
2077−mergeSubscriber subscribed m getKey = Subscriber
1894+mergeSubscriber :: forall x k v s a. (HasSpiderTimeline x, GCompare k) => Merge x k v s -> EventM x (k a) -> Subscriber x (v a)
1895+mergeSubscriber m getKey = Subscriber
20781896 { subscriberPropagate = \a -> do
20791897 oldM <- liftIO $ readIORef $ _merge_accumRef m
20801898 k <- getKey
2081− let newM = DMap.insertWith (error "Same key fired multiple times for Merge") k a oldM
1899+ let newM = DMap.insertWith (error $ "Same key fired multiple times for Merge") k a oldM
20821900 tracePropagate (Proxy :: Proxy x) $ " DMap.size oldM = " <> show (DMap.size oldM) <> "; DMap.size newM = " <> show (DMap.size newM)
20831901 liftIO $ writeIORef (_merge_accumRef m) $! newM
20841902 when (DMap.null oldM) $ do -- Only schedule the firing once
20851903 height <- liftIO $ readIORef $ _merge_heightRef m
2086− checkCycle subscribed
1904+ checkCycle height --TODO: assertions about height
20871905
20881906 scheduleMergeSelf m height
20891907 , subscriberInvalidateHeight = \old -> do --TODO: When removing a parent doesn't actually change the height, maybe we can avoid invalidating
@@ -2095,45 +1913,31 @@ mergeSubscriber subscribed m getKey = Subscriber
20951913 }
20961914
20971915--TODO: Be able to run as much of this as possible promptly
2098−updateMerge :: (HasSpiderTimeline x, GCompare k) => EventSubscribed x -> Merge x k v s -> MergeUpdateFunc k v x p s -> p -> SomeMergeUpdate x
2099−updateMerge subscribed m updateFunc p = SomeMergeUpdate updateMe (invalidateMergeHeight m) (revalidateMergeHeight m)
1916+updateMerge :: (HasSpiderTimeline x, GCompare k) => Merge x k v s -> MergeUpdateFunc k v x p s -> p -> SomeMergeUpdate x
1917+updateMerge m updateFunc p = SomeMergeUpdate updateMe (invalidateMergeHeight m) (revalidateMergeHeight m)
21001918 where updateMe = do
21011919 oldParents <- liftIO $ readIORef $ _merge_parentsRef m
2102− (subscriptionsToKill, newParents) <- updateFunc (mergeSubscriber subscribed m) (_merge_heightBagRef m) oldParents p
1920+ (subscriptionsToKill, newParents) <- updateFunc (mergeSubscriber m) (_merge_heightBagRef m) oldParents p
21031921 liftIO $ writeIORef (_merge_parentsRef m) $! newParents
21041922 return subscriptionsToKill
21051923
21061924{-# INLINE mergeGCheap' #-}
21071925mergeGCheap' :: forall k v x p s q. (HasSpiderTimeline x, GCompare k, PatchTarget p ~ DMap k q)
2108− => MergeGetSubscription x s -> MergeInitFunc k v q x s -> MergeUpdateFunc k v x p s -> MergeDestroyFunc k s -> DynamicS x p -> Event x (DMap k v)
2109−mergeGCheap' getParent getInitialSubscribers updateFunc destroy d = Event $ \sub -> do
1926+ => MergeInitFunc k v q x s -> MergeUpdateFunc k v x p s -> MergeDestroyFunc k s -> DynamicS x p -> Event x (DMap k v)
1927+mergeGCheap' getInitialSubscribers updateFunc destroy d = Event $ \sub -> do
21101928 initialParents <- readBehaviorUntracked $ dynamicCurrent d
21111929 accumRef <- liftIO $ newIORef $ error "merge: accumRef not yet initialized"
21121930 heightRef <- liftIO $ newIORef $ error "merge: heightRef not yet initialized"
21131931 heightBagRef <- liftIO $ newIORef $ error "merge: heightBagRef not yet initialized"
21141932 parentsRef :: IORef (DMap k s) <- liftIO $ newIORef $ error "merge: parentsRef not yet initialized"
2115− changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
2116−
2117− let subscribed = EventSubscribed
2118− { eventSubscribedHeightRef = heightRef
2119− , eventSubscribedRetained = toAny (parentsRef, changeSubdRef)
2120−#ifdef DEBUG_CYCLES
2121− , eventSubscribedGetParents = do
2122− let getParent' (_ :=> v) = _eventSubscription_subscribed (getParent v)
2123− fmap getParent' . DMap.toList <$> readIORef parentsRef
2124− , eventSubscribedHasOwnHeightRef = False
2125− , eventSubscribedWhoCreated = whoCreatedIORef heightRef
2126−#endif
2127− }
2128−
2129− m = Merge
1933+ let m = Merge
21301934 { _merge_parentsRef = parentsRef
21311935 , _merge_heightBagRef = heightBagRef
21321936 , _merge_heightRef = heightRef
21331937 , _merge_sub = sub
21341938 , _merge_accumRef = accumRef
21351939 }
2136− (dm, heights, initialParentState) <- getInitialSubscribers initialParents $ mergeSubscriber subscribed m
1940+ (dm, heights, initialParentState) <- getInitialSubscribers initialParents $ mergeSubscriber m
21371941 let myHeightBag = heightBagFromList $ filter (/= invalidHeight) heights
21381942 myHeight = if invalidHeight `elem` heights
21391943 then invalidHeight
@@ -2142,29 +1946,31 @@ mergeGCheap' getParent getInitialSubscribers updateFunc destroy d = Event $ \sub
21421946 let (occ, accum) = if currentHeight >= myHeight -- If we should have fired by now
21431947 then (if DMap.null dm then Nothing else Just dm, DMap.empty)
21441948 else (Nothing, dm)
2145− unless (DMap.null accum) $ scheduleMergeSelf m myHeight
1949+ unless (DMap.null accum) $ do
1950+ scheduleMergeSelf m myHeight
21461951 liftIO $ writeIORef accumRef $! accum
21471952 liftIO $ writeIORef heightRef $! myHeight
21481953 liftIO $ writeIORef heightBagRef $! myHeightBag
1954+ changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
21491955 liftIO $ writeIORef parentsRef $! initialParentState
21501956 defer $ SomeMergeInit $ do
2151− let changeSubscriber = Subscriber
1957+ let s = Subscriber
21521958 { subscriberPropagate = \a -> {-# SCC "traverseMergeChange" #-} do
2153− tracePropagate (Proxy :: Proxy x) "SubscriberMerge/Change"
2154− defer $ updateMerge subscribed m updateFunc a
1959+ tracePropagate (Proxy :: Proxy x) $ "SubscriberMerge/Change"
1960+ defer $ updateMerge m updateFunc a
21551961 , subscriberInvalidateHeight = \_ -> return ()
21561962 , subscriberRecalculateHeight = \_ -> return ()
21571963 }
2158− (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) changeSubscriber
2159− forM_ change $ \c -> defer $ updateMerge subscribed m updateFunc c
1964+ (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) s
1965+ forM_ change $ \c -> defer $ updateMerge m updateFunc c
21601966 -- We explicitly hold on to the unsubscribe function from subscribing to the update event.
21611967 -- If we don't do this, there are certain cases where mergeCheap will fail to properly retain
21621968 -- its subscription.
2163− liftIO $ writeIORef changeSubdRef (changeSubscriber, changeSubscription)
1969+ liftIO $ writeIORef changeSubdRef (s, changeSubscription)
21641970 let unsubscribeAll = destroy =<< readIORef parentsRef
2165−
2166− return (EventSubscription unsubscribeAll subscribed, occ)
2167−
1971+ return ( EventSubscription unsubscribeAll $ EventSubscribed heightRef $ toAny (parentsRef, changeSubdRef)
1972+ , occ
1973+ )
21681974
21691975mergeInt :: forall x a. (HasSpiderTimeline x) => DynamicS x (PatchIntMap (Event x a)) -> Event x (IntMap a)
21701976mergeInt = cacheEvent . mergeIntCheap
@@ -2177,22 +1983,13 @@ mergeIntCheap d = Event $ \sub -> do
21771983 heightRef <- liftIO $ newIORef zeroHeight
21781984 heightBagRef <- liftIO $ newIORef heightBagEmpty
21791985 parents <- liftIO $ FastMutableIntMap.newEmpty
2180− changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
2181− let subscribed = EventSubscribed
2182− { eventSubscribedHeightRef = heightRef
2183− , eventSubscribedRetained = toAny (parents, changeSubdRef)
2184−#ifdef DEBUG_CYCLES
2185− , eventSubscribedGetParents = fmap (_eventSubscription_subscribed . snd) <$> FastMutableIntMap.toList parents
2186− , eventSubscribedHasOwnHeightRef = False
2187− , eventSubscribedWhoCreated = whoCreatedIORef heightRef
2188−#endif
2189− }
21901986 let scheduleSelf = do
21911987 height <- liftIO $ readIORef $ heightRef
21921988 scheduleMerge' height heightRef $ do
21931989 vals <- liftIO $ FastMutableIntMap.getFrozenAndClear accum
21941990 subscriberPropagate sub vals
2195− invalidateMyHeight = invalidateMergeHeight' heightRef sub
1991+ invalidateMyHeight = do
1992+ invalidateMergeHeight' heightRef sub
21961993 recalculateMyHeight = do
21971994 currentHeight <- readIORef heightRef
21981995 when (currentHeight == invalidHeight) $ do --TODO: This will almost always be true; can we get rid of this check and just proceed to the next one always?
@@ -2202,14 +1999,14 @@ mergeIntCheap d = Event $ \sub -> do
22021999 LT -> return ()
22032000 EQ -> do
22042001 let height = succHeight $ heightBagMax heights
2205− traceInvalidateHeight $ "recalculateSubscriberHeight: height: " <> show height
2002+ traceInvalidate $ "recalculateSubscriberHeight: height: " <> show height
22062003 writeIORef heightRef $! height
22072004 subscriberRecalculateHeight sub height
22082005 GT -> error $ "revalidateMergeHeight: more heights (" <> show (heightBagSize heights) <> ") than parents (" <> show numParents <> ") for Merge"
22092006 mySubscriber k = Subscriber
22102007 { subscriberPropagate = \a -> do
2211− checkCycle subscribed
2212−
2008+ liftIO (readIORef heightRef) >>= checkCycle
2009+
22132010 wasEmpty <- liftIO $ FastMutableIntMap.isEmpty accum
22142011 liftIO $ FastMutableIntMap.insert accum k a
22152012 when wasEmpty scheduleSelf
@@ -2243,6 +2040,7 @@ mergeIntCheap d = Event $ \sub -> do
22432040 else liftIO $ Just <$> FastMutableIntMap.getFrozenAndClear accum
22442041 else do when (not isEmpty) scheduleSelf -- We have things accumulated, but we shouldn't have fired them yet
22452042 return Nothing
2043+ changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
22462044 defer $ SomeMergeInit $ do
22472045 let updateMe a = SomeMergeUpdate u invalidateMyHeight recalculateMyHeight
22482046 where
@@ -2256,27 +2054,25 @@ mergeIntCheap d = Event $ \sub -> do
22562054 oldParents <- liftIO $ FastMutableIntMap.applyPatch parents newSubscriptions
22572055 liftIO $ for_ oldParents $ \oldParent -> do
22582056 oldParentHeight <- getEventSubscribedHeight $ _eventSubscription_subscribed oldParent
2259−
2260− print ("updateMe", oldParentHeight)
22612057 modifyIORef' heightBagRef $ heightBagRemove oldParentHeight
22622058 return $ IntMap.elems oldParents
2263− let changeSubscriber = Subscriber
2059+ let s = Subscriber
22642060 { subscriberPropagate = \a -> {-# SCC "traverseMergeChange" #-} do
22652061 tracePropagate (Proxy :: Proxy x) $ "SubscriberMergeInt/Change"
22662062 defer $ updateMe a
22672063 , subscriberInvalidateHeight = \_ -> return ()
22682064 , subscriberRecalculateHeight = \_ -> return ()
22692065 }
2270− (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) changeSubscriber
2066+ (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) s
22712067 forM_ change $ \c -> defer $ updateMe c
22722068 -- We explicitly hold on to the unsubscribe function from subscribing to the update event.
22732069 -- If we don't do this, there are certain cases where mergeCheap will fail to properly retain
22742070 -- its subscription.
2275− liftIO $ writeIORef changeSubdRef (changeSubscriber, changeSubscription)
2071+ liftIO $ writeIORef changeSubdRef (s, changeSubscription)
22762072 let unsubscribeAll = traverse_ unsubscribe =<< FastMutableIntMap.getFrozenAndClear parents
2277−
2278−
2279− return (EventSubscription unsubscribeAll subscribed, occ)
2073+ return ( EventSubscription unsubscribeAll $ EventSubscribed heightRef $ toAny (parents, changeSubdRef)
2074+ , occ
2075+ )
22802076
22812077newtype EventSelector x k = EventSelector { select :: forall a. k a -> Event x a }
22822078newtype EventSelectorG x k v = EventSelectorG { selectG :: forall a. k a -> Event x (v a) }
@@ -2385,7 +2181,7 @@ runFrame a = SpiderHost $ do
23852181 subscription <- unSpiderHost $ runFrame $ {-# SCC "subscribeSwitch" #-} subscribe e sub --TODO: Assert that the event isn't firing --TODO: This should not loop because none of the events should be firing, but still, it is inefficient
23862182 {-
23872183 stackTrace <- liftIO $ fmap renderStack $ ccsToStrings =<< (getCCSOf $! switchSubscribedParent subscribed)
2388− liftIO $ debugStrLn $ (++stackTrace) $ "subd' subscribed to " ++ case e of
2184+ liftIO $ putStrLn $ (++stackTrace) $ "subd' subscribed to " ++ case e of
23892185 EventRoot _ -> "EventRoot"
23902186 EventNever -> "EventNever"
23912187 _ -> "something else"
@@ -2400,7 +2196,7 @@ runFrame a = SpiderHost $ do
24002196 myHeight <- readIORef $ switchSubscribedHeight subscribed
24012197 when (parentHeight /= myHeight) $ do
24022198 writeIORef (switchSubscribedHeight subscribed) $! invalidHeight
2403− WeakBag.traverse_ (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight myHeight
2199+ WeakBag.traverse (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight myHeight
24042200 mapM_ _someMergeUpdate_invalidateHeight mergeUpdates --TODO: In addition to when the patch is completely empty, we should also not run this if it has some Nothing values, but none of them have actually had any effect; potentially, we could even check for Just values with no effect (e.g. by comparing their IORefs and ignoring them if they are unchanged); actually, we could just check if the new height is different
24052201 forM_ coincidenceInfos $ \(SomeResetCoincidence subscription mcs) -> do
24062202 unsubscribe subscription
@@ -2441,7 +2237,7 @@ invalidateCoincidenceHeight subscribed = do
24412237 oldHeight <- readIORef $ coincidenceSubscribedHeight subscribed
24422238 when (oldHeight /= invalidHeight) $ do
24432239 writeIORef (coincidenceSubscribedHeight subscribed) $! invalidHeight
2444− WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
2240+ WeakBag.traverse (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
24452241
24462242updateSwitchHeight :: Height -> SwitchSubscribed x a -> IO ()
24472243updateSwitchHeight new subscribed = do
@@ -2449,7 +2245,7 @@ updateSwitchHeight new subscribed = do
24492245 when (oldHeight == invalidHeight) $ do --TODO: This 'when' should probably be an assertion
24502246 when (new /= invalidHeight) $ do --TODO: This 'when' should probably be an assertion
24512247 writeIORef (switchSubscribedHeight subscribed) $! new
2452− WeakBag.traverse_ (switchSubscribedSubscribers subscribed) $ recalculateSubscriberHeight new
2248+ WeakBag.traverse (switchSubscribedSubscribers subscribed) $ recalculateSubscriberHeight new
24532249
24542250recalculateCoincidenceHeight :: CoincidenceSubscribed x a -> IO ()
24552251recalculateCoincidenceHeight subscribed = do
@@ -2458,7 +2254,7 @@ recalculateCoincidenceHeight subscribed = do
24582254 height <- calculateCoincidenceHeight subscribed
24592255 when (height /= invalidHeight) $ do
24602256 writeIORef (coincidenceSubscribedHeight subscribed) $! height
2461− WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ recalculateSubscriberHeight height
2257+ WeakBag.traverse (coincidenceSubscribedSubscribers subscribed) $ recalculateSubscriberHeight height
24622258
24632259calculateSwitchHeight :: SwitchSubscribed x a -> IO Height
24642260calculateSwitchHeight subscribed = getEventSubscribedHeight . _eventSubscription_subscribed =<< readIORef (switchSubscribedCurrentParent subscribed)
@@ -2520,8 +2316,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Event
25202316 {-# INLINABLE headE #-}
25212317 headE = R.slowHeadE
25222318-- headE (SpiderEvent e) = SpiderEvent <$> Reflex.Spider.Internal.headE e
2523− {-# INLINABLE now #-}
2524− now = nowSpiderEventM
25252319
25262320instance Reflex.Class.MonadSample (SpiderTimeline x) (SpiderPullM x) where
25272321 {-# INLINABLE sample #-}
@@ -2543,9 +2337,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Spide
25432337 {-# INLINABLE headE #-}
25442338 headE = R.slowHeadE
25452339-- headE (SpiderEvent e) = SpiderPushM $ SpiderEvent <$> Reflex.Spider.Internal.headE e
2546− {-# INLINABLE now #-}
2547− now = SpiderPushM nowSpiderEventM
2548−
25492340
25502341instance HasSpiderTimeline x => Monad (Reflex.Class.Dynamic (SpiderTimeline x)) where
25512342 {-# INLINE return #-}
@@ -2554,10 +2345,8 @@ instance HasSpiderTimeline x => Monad (Reflex.Class.Dynamic (SpiderTimeline x))
25542345 x >>= f = SpiderDynamic $ dynamicDynIdentity $ newJoinDyn $ newMapDyn (unSpiderDynamic . f) $ unSpiderDynamic x
25552346 {-# INLINE (>>) #-}
25562347 (>>) = (*>)
2557−#if !MIN_VERSION_base(4,13,0)
25582348 {-# INLINE fail #-}
25592349 fail _ = error "Dynamic does not support 'fail'"
2560−#endif
25612350
25622351{-# INLINABLE newJoinDyn #-}
25632352newJoinDyn :: HasSpiderTimeline x => DynamicS x (Identity (DynamicS x (Identity a))) -> Reflex.Spider.Internal.Dyn x (Identity a)
@@ -2609,9 +2398,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Spide
26092398 buildDynamic getV0 e = runFrame . runSpiderHostFrame $ Reflex.Class.buildDynamic getV0 e
26102399 {-# INLINABLE headE #-}
26112400 headE e = runFrame . runSpiderHostFrame $ Reflex.Class.headE e
2612− {-# INLINABLE now #-}
2613− now = runFrame . runSpiderHostFrame $ Reflex.Class.now
2614−
26152401
26162402instance HasSpiderTimeline x => Reflex.Class.MonadSample (SpiderTimeline x) (SpiderHostFrame x) where
26172403 sample = SpiderHostFrame . readBehaviorUntracked . unSpiderBehavior --TODO: This can cause problems with laziness, so we should get rid of it if we can
@@ -2628,8 +2414,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Spide
26282414 {-# INLINABLE headE #-}
26292415 headE = R.slowHeadE
26302416-- headE (SpiderEvent e) = SpiderHostFrame $ SpiderEvent <$> Reflex.Spider.Internal.headE e
2631− {-# INLINABLE now #-}
2632− now = SpiderHostFrame Reflex.Class.now
26332417
26342418instance HasSpiderTimeline x => Reflex.Class.MonadSample (SpiderTimeline x) (SpiderHost x) where
26352419 {-# INLINABLE sample #-}
@@ -2650,8 +2434,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Refle
26502434 buildDynamic getV0 e = Reflex.Spider.Internal.ReadPhase $ Reflex.Class.buildDynamic getV0 e
26512435 {-# INLINABLE headE #-}
26522436 headE e = Reflex.Spider.Internal.ReadPhase $ Reflex.Class.headE e
2653− {-# INLINABLE now #-}
2654− now = Reflex.Spider.Internal.ReadPhase Reflex.Class.now
26552437
26562438--------------------------------------------------------------------------------
26572439-- Deprecated items
@@ -2775,7 +2557,7 @@ instance HasSpiderTimeline x => R.Reflex (SpiderTimeline x) where
27752557 fanG e = R.EventSelectorG $ SpiderEvent . selectG (fanG (unSpiderEvent e))
27762558 {-# INLINABLE mergeG #-}
27772559 mergeG
2778− :: forall k2 (k :: k2 -> *) q (v :: k2 -> *). GCompare k
2560+ :: forall (k :: k2 -> *) q (v :: k2 -> *). GCompare k
27792561 => (forall a. q a -> R.Event (SpiderTimeline x) (v a))
27802562 -> DMap k q
27812563 -> R.Event (SpiderTimeline x) (DMap k v)
@@ -2843,14 +2625,8 @@ instance Monad (SpiderHost x) where
28432625 SpiderHost x >> SpiderHost y = SpiderHost $ x >> y
28442626 {-# INLINABLE return #-}
28452627 return x = SpiderHost $ return x
2846−#if !MIN_VERSION_base(4,13,0)
2847− {-# INLINABLE fail #-}
2848− fail = MonadFail.fail
2849−#endif
2850−
2851−instance MonadFail (SpiderHost x) where
28522628 {-# INLINABLE fail #-}
2853− fail s = SpiderHost $ MonadFail.fail s
2629+ fail s = SpiderHost $ fail s
28542630
28552631-- | Run an action affecting the global Spider timeline; this will be guarded by
28562632-- a mutex for that timeline
@@ -2872,10 +2648,8 @@ instance Monad (SpiderHostFrame x) where
28722648 SpiderHostFrame x >> SpiderHostFrame y = SpiderHostFrame $ x >> y
28732649 {-# INLINABLE return #-}
28742650 return x = SpiderHostFrame $ return x
2875−#if !MIN_VERSION_base(4,13,0)
28762651 {-# INLINABLE fail #-}
28772652 fail s = SpiderHostFrame $ fail s
2878−#endif
28792653
28802654instance NotReady (SpiderTimeline x) (SpiderHostFrame x) where
28812655 notReadyUntil _ = pure ()
@@ -2920,11 +2694,3 @@ instance MonadAtomicRef (SpiderHostFrame x) where
29202694instance PrimMonad (SpiderHostFrame x) where
29212695 type PrimState (SpiderHostFrame x) = PrimState IO
29222696 primitive = SpiderHostFrame . EventM . primitive
2923−
2924−instance NotReady (SpiderTimeline x) (SpiderHost x) where
2925− notReadyUntil _ = return ()
2926− notReady = return ()
2927−
2928−instance HasSpiderTimeline x => NotReady (SpiderTimeline x) (PerformEventT (SpiderTimeline x) (SpiderHost x)) where
2929− notReadyUntil _ = return ()
2930− notReady = return ()