on 4aa722a help sign in
.github/workflows/haskell.ymldeleted−41
since splitsnapshots
unifiedsplit
@@ -1,41 +0,0 @@
1−name: github-action
2−
3−on: [push, pull_request]
4−
5−jobs:
6− build:
7− strategy:
8− matrix:
9− ghc: ['8.4.4', '8.6.5', '8.8.4', '8.10.2']
10− os: ['ubuntu-latest', 'macos-latest']
11− runs-on: ${{ matrix.os }}
12−
13− name: GHC ${{ matrix.ghc }} on ${{ matrix.os }}
14− steps:
15− - uses: actions/checkout@v2
16− - uses: actions/setup-haskell@v1
17− with:
18− ghc-version: ${{ matrix.ghc }}
19− - name: Cache
20− uses: actions/cache@v1
21− env:
22− cache-name: cache-cabal
23− with:
24− path: ~/.cabal
25− key: ${{ runner.os }}-${{ matrix.ghc }}-build-${{ env.cache-name }}-${{ hashFiles('**/*.cabal') }}-${{ hashFiles('**/cabal.project') }}
26− restore-keys: |
27− ${{ runner.os }}-${{ matrix.ghc }}-build-${{ env.cache-name }}-
28− ${{ runner.os }}-${{ matrix.ghc }}-build-
29− ${{ runner.os }}-${{ matrix.ghc }}-
30− ${{ runner.os }}
31−
32− - name: Install dependencies
33− run: |
34− cabal update
35− cabal build --only-dependencies --enable-tests --enable-benchmarks
36− - name: Build
37− run: cabal build --enable-tests --enable-benchmarks all
38− - name: Run tests
39− run: cabal test all
40− - name: Build Docs
41− run: cabal haddock
CONTRIBUTING.mddeleted−66
@@ -1,66 +0,0 @@
1−# Contribution Guide
2−
3−Contributions and issue reports are encouraged and appreciated!
4−
5−- [Opening Issues](#opening-issues)
6−- [Submitting Changes](#submitting-changes)
7− - [Guidelines for Commit Messages](#guidelines-for-commit-messages)
8− - [Guidelines for Pull Requests](#guidelines-for-pull-requests)
9− - [Code Quality](#code-quality)
10− - [Documentation](#documentation)
11−
12−## Opening Issues
13−
14−Before opening an issue, please check whether your issue has already been reported. Assuming it has not:
15−
16−* Describe the issue you're encountering or the suggestion you're making
17−* Include any relevant steps to reproduce or code samples you can. It's always easier for us to debug if we have something that demonstrates the error.
18−* Let us know what version of reflex you were using. If you're using a github checkout, provide the git hash.
19−* Describe how you're building reflex (i.e., via reflex-platform, cabal install, stack, obelisk, etc.). If you're using reflex-platform or obelisk, provide the git hash of your checkout.
20−
21−## Submitting Changes
22−
23−### Guidelines for Commit Messages
24−
25−#### Summary Line
26−The summary line of your commit message should summarize the changes being made. Commit messages should be written in the imperative mood and should describe what happens when the commit is applied.
27−
28−One way to think about it is that your commit message should be able to complete the sentence:
29−"When applied, this commit will..."
30−
31−#### Body
32−For breaking changes, new features, refactors, or other major changes, the body of the commit message should describe the motivation behind the change in greater detail and may include references to the issue tracker. The body shouldn't repeat code/comments from the diff.
33−
34−### Guidelines for Pull Requests
35−
36−Wherever possible, pull requests should add a single feature or fix a single bug. Pull requests should not bundle several unrelated changes.
37−
38−### Code Quality
39−
40−#### Warnings
41−
42−Your pull request should add no new warnings to the project. It should also generally not disable any warnings.
43−
44−#### Build and Test
45−
46−Make sure the project builds and that the tests pass! This will generally also be checked by CI before merge, but trying it yourself first means you'll catch problems earlier and your contribution can be merged that much sooner!
47−
48−#### Dependencies
49−
50−Include version bounds whenever adding a dependency to the library stanza of the cabal file. Note that libraries added to reflex.cabal also need to be added to default.nix.
51−
52−### Documentation
53−
54−#### In the code
55−We're always striving to improve documentation. Please include [haddock](https://haskell-haddock.readthedocs.io/en/latest/index.html) documentation for any added code, and update the documentation for any code you modify.
56−
57−#### In the [Changelog](ChangeLog.md)
58−Add an entry to the changelog when your PR:
59−* Adds a feature
60−* Deprecates something
61−* Includes a breaking change
62−* Makes any other change that will impact users
63−
64−#### In the [Readme](README.md)
65−The readme is the first place a lot of people look for information about the repository. Update any parts of the readme that are affected by your PR.
66−
ChangeLog.mddeleted−151
@@ -1,151 +0,0 @@
1−# Revision history for reflex
2−
3−## 0.8.2.0
4−
5−* Add `matchResponseMapWithRequests`, which it similar to `matchResponsesWithRequests` but allows processing of multiple responses at once.
6−
7−## 0.8.1.1
8−
9−* Allow newer hlint for older GHCs, and add upper bound for newer GHCs
10−
11−## 0.8.1.0
12−
13−* Add support for GHC 8.10
14−* Drop support for GHC < 8.4
15−
16−## 0.8.0.0
17−
18−* Replace 0.7.2.0 with 0.8.0.0 to reflect the `MonadHold` interface change. Deprecates 0.7.2.0.
19−
20−## 0.7.2.0 -- *Deprecated*
21−
22−* ([#416](https://github.com/reflex-frp/reflex/pull/416)) Add `now :: m (Event t ())` to `MonadHold`.
23−* Extend some dependency version bounds
24−* Fix HLint 3 test
25−
26−## 0.7.1.1
27−
28−*Backport release*.
29−Changes do not carry forward to 0.7.2.0.
30−
31−* Add support for GHC 8.10
32−* Drop support for GHC < 8.4
33−* Extend some dependency version bounds
34−* Fix HLint 3 test
35−
36−## 0.7.1.0
37−
38−* ([#413](https://github.com/reflex-frp/reflex/pull/413), [#417](https://github.com/reflex-frp/reflex/pull/417)) Add `Reflex.Host.Headless` module which provides `runHeadlessApp` as an easy way to run a Reflex network in a "headless" environment.
39−* ([#420](https://github.com/reflex-frp/reflex/pull/420)) Add a [`Data.Zip.Unzip`](https://hackage.haskell.org/package/semialign-1.1/docs/Data-Zip.html#t:Unzip) instance for `Event`.
40−* ([#419](https://github.com/reflex-frp/reflex/pull/419)) Add `distributeIntMapOverDynPure` and `joinDynThroughIntMap` as convenience functions for working with `Dynamic` `IntMap`s.
41−
42−
43−## 0.7.0.0
44−
45−* Add lifting instances for most classes to `Reflex.Profiled.Profiled`. ([#398](https://github.com/reflex-frp/reflex/pull/398))
46−* Class `MonadQuery t q m` now has a `Monad m` superclass constraint. ([#400](https://github.com/reflex-frp/reflex/pull/400))
47−* **(Breaking change)** Rename class `MonadBehaviorWriter` -> `BehaviorWriter` for consistency with `EventWriter`/`DynamicWriter`. ([#401](https://github.com/reflex-frp/reflex/pull/401))
48−* Introduce deprecated alias `MonadBehaviorWriter = BehaviorWriter`. ([#401](https://github.com/reflex-frp/reflex/pull/401))
49−* Fix bug in spider where event subscriptions would be prematurely finalized due to over-aggressive inlining. ([#409](https://github.com/reflex-frp/reflex/pull/409))
50−* Add instances of `PerformEvent` and `TriggerEvent` for `MaybeT`. ([#395](https://github.com/reflex-frp/reflex/pull/395))
51−
52−## 0.6.4.1
53−
54−* Fix a bug in the Reflex Profiled transformer where
55− `Reflex.Class.mergeIncrementalG` and
56− `Reflex.Class.mergeIncrementalWithMoveG` implementations referenced
57− itself instead of the inner transformed timeline, causing an
58− infinite loop.
59−
60−## 0.6.4
61−
62−* Support GHC 8.8
63−
64−* Add `Reflex.Query.Base.mapQueryT`. See that module for documentation
65−
66−* The `Reflex.Patch.*` modules were moved to the `patch` library.
67− They are `Data.Patch.*` there, but reexported under their old names for backwards compatability here.
68−
69−* Additional instances for `Query` classes for basic types.
70−
71−* Add cabal flags `debug-propagation` and `debug-event-cycles` to build in debugging
72− code for performance and for cyclic dependencies between events
73−
74−## 0.6.3
75−
76−* `Data.WeakBag.traverse` and `Data.FastWeakBag.traverse` have been deprecated.
77− They are replaced with `Data.WeakBag.traverse_` and `Data.FastWeakBag.traverse_`, respectively.
78−
79−* Fixes a bug in `Reflex.Patch.MapWithMove.patchThatSortsMapWith` that was producing invalid `PatchMapWithMove`.
80−
81−* Add missing `NotReady` instances:
82− - `instance NotReady (SpiderTimeline x) (SpiderHost x)`
83− - `instance HasSpiderTimeline x => NotReady (SpiderTimeline x) (PerformEventT (SpiderTimeline x) (SpiderHost x))`
84−
85−## 0.6.2.4
86−
87−* Update to monoidal-containers 0.6
88−
89−## 0.6.2.3
90−
91−* Add an upper-bound to witherable
92−
93−## 0.6.2.2
94−
95−* Support these >= 1. Add `split-these` flag to control whether to use new these/semialign combination or not.
96−
97−* Update version bounds to fix some CI failures
98−
99−* Add travis CI configuration
100−
101−## 0.6.2.1
102−
103−* Generalize `fan` to `fanG` to take a `DMap` with non-`Identity`
104− functor:
105− * `fan` to `fanG`
106− * `EventSelectorG` for `fanG` result selector.
107−
108−* Reduce the amount of unsafeCoerce in coercing newtypes under Event/Dynamic/Behavior.
109− * Add fused ReaderIO for the purpose of coercion (ReaderT's third argument has nominal role preventing automated coerce)
110− * Add incrementalCoercion/coerceIncremental to go with dynamicCoercion/coerceDynamic
111−
112−* Generalize merging functions:
113− `merge` to `mergeG`,
114− `mergeIncremental` to `mergeIncrementalG`,
115− `mergeIncrementalWithMove` to `mergeIncrementalWithMoveG`.
116−
117−* Generalize distribute function:
118− `distributeDMapOverDynPure` to `distributeDMapOverDynPureG`,
119−
120−## 0.6.2.0
121−
122−* Fix `holdDyn` so that it is lazy in its event argument
123− These produce `DMap`s whose values needn't be `Identity`.
124−
125−* Stop using the now-deprecated `*Tag` classes (e.g., `ShowTag`).
126−
127−* Fix `holdDyn` so that it is lazy in its event argument.
128−
129−## 0.6.1.0
130−
131−* Re-export all of `Data.Map.Monoidal`
132−
133−* Fix `QueryT` and `RequesterT` tests
134−
135−## 0.6.0.0 -- 2019-03-20
136−
137−* Deprecate `FunctorMaybe` in favor of `Data.Witherable.Filterable`. We still export `fmapMaybe`, `ffilter`, etc., but they all rely on `Filterable` now.
138−
139−* Rename `MonadDynamicWriter` to `DynamicWriter` and add a deprecation for the old name.
140−
141−* Remove many deprecated functions.
142−
143−* Add a `Num` instance for `Dynamic`.
144−
145−* Add `matchRequestsWithResponses` to make it easier to use `Requester` with protocols that don't do this matching for you.
146−
147−* Add `withRequesterT` to map functions over the request and response of a `RequesterT`.
148−
149−* Suppress nil patches in `QueryT` as an optimization. The `Query` type must now have an `Eq` instance.
150−
151−* Add `throttleBatchWithLag` to `Reflex.Time`. See that module for details.
Quickref.md+18−22
@@ -54,19 +54,18 @@ Since MonadHold depends on MonadSample, any [S] function also runs in [H] contex
54[ ] difference :: Event a -> Event b -> Event a
54[ ] difference :: Event a -> Event b -> Event a
55[ ] align :: Event a -> Event b -> Event (These a b)
55[ ] align :: Event a -> Event b -> Event (These a b)
56[ ] alignWith :: (These a b -> c) -> Event a -> Event b -> Event c
56[ ] alignWith :: (These a b -> c) -> Event a -> Event b -> Event c
57− -- Note align functions from Data.Align in semialign package
58[ ] mergeWith :: (a -> a -> a) -> [Event a] -> Event a
57[ ] mergeWith :: (a -> a -> a) -> [Event a] -> Event a
59[ ] leftmost :: [Event a] -> Event a
58[ ] leftmost :: [Event a] -> Event a
60[ ] mergeList :: [Event a] -> Event (NonEmpty a)
59[ ] mergeList :: [Event a] -> Event (NonEmpty a)
61−[ ] merge :: GCompare k => DMap k Event -> Event (DMap k Identity)
60+[ ] merge :: GCompare k => DMap (WrapArg Event k) -> Event (DMap k)
62[ ] mergeMap :: Ord k => Map k (Event a) -> Event (Map k a)
61[ ] mergeMap :: Ord k => Map k (Event a) -> Event (Map k a)
63
62
64-- Efficient one-to-many fanout
63-- Efficient one-to-many fanout
65−[ ] fanMap :: Ord k => Event (Map k a) -> EventSelector (Const2 k a)
64+[ ] fanMap :: Ord k => Event (Map k a) -> EventSelector (Const2 k a)
66−[ ] fan :: GCompare k => Event (DMap k Identity) -> EventSelector k
65+[ ] fan :: GCompare k => Event (DMap k) -> EventSelector k
67−[ ] select :: EventSelector k -> k a -> Event a
66+[ ] select :: EventSelector k -> k a -> Event a
68−[ ] fanEither :: Event (Either a b) -> (Event a, Event b)
67+[ ] fanEither :: Event (Either a b) -> (Event a, Event b)
69−[ ] fanThese :: Event (These a b) -> (Event a, Event b)
68+[ ] fanThese :: Event (These a b) -> (Event a, Event b)
70
69
71-- Event to Event via function that can sample current values
70-- Event to Event via function that can sample current values
72[ ] push :: (a -> m (Maybe b)) -> Event a -> Event b
71[ ] push :: (a -> m (Maybe b)) -> Event a -> Event b
@@ -167,7 +166,7 @@ For Events, the returned Event fires whenever the latest Event supplied by the w
167-- Flatten Behavior-of-Event to Event. Old Event is used during switchover.
166-- Flatten Behavior-of-Event to Event. Old Event is used during switchover.
168[ ] switch :: Behavior (Event a) -> Event a
167[ ] switch :: Behavior (Event a) -> Event a
169
168
170−-- Flatten Dynamic-of-Event to Event. New Event is used immediately.
169+-- Flatten Dyanmic-of-Event to Event. New Event is used immediately.
171[ ] switchDyn :: Dynamic (Event a) -> Event a
170[ ] switchDyn :: Dynamic (Event a) -> Event a
172
171
173-- Flatten Event-of-Event to Event that fires when both wrapper AND new Event fire.
172-- Flatten Event-of-Event to Event that fires when both wrapper AND new Event fire.
@@ -199,7 +198,7 @@ For Events, the returned Event fires whenever the latest Event supplied by the w
199The functions mentioned above are used to create a static FRP network.
198The functions mentioned above are used to create a static FRP network.
200There are additional typeclasses that can be used to modify the FRP network, to have it interact with IO action, or to introspect the building of the network.
199There are additional typeclasses that can be used to modify the FRP network, to have it interact with IO action, or to introspect the building of the network.
201
200
202−The typeclasses and their associated annotations include:
201+Th typeclasses and their associated annotations include:
203
202
204- `PostBuild`
203- `PostBuild`
205 Fire an Event when an FRP network has been set up.
204 Fire an Event when an FRP network has been set up.
@@ -207,7 +206,7 @@ The typeclasses and their associated annotations include:
207 [B] -- Function runs in any monad supporting PostBuild
206 [B] -- Function runs in any monad supporting PostBuild
208 ```
207 ```
209
208
210−- `Adjustable`
209+- `Adjustable`
211 Use Events to add or remove pieces of an FRP network.
210 Use Events to add or remove pieces of an FRP network.
212 ```haskell
211 ```haskell
213 [A] -- Function runs in any monad supporting Adjustable
212 [A] -- Function runs in any monad supporting Adjustable
@@ -272,7 +271,7 @@ The typeclasses and their associated annotations include:
272```haskell
271```haskell
273-- Run side-effecting actions in Event when it occurs; returned Event contains
272-- Run side-effecting actions in Event when it occurs; returned Event contains
274-- results. Side effects run in the (Performable m) monad which is associated with
273-- results. Side effects run in the (Performable m) monad which is associated with
275−-- the (PerformEvent t m) typeclass constraint.
274+-- the (PerformEvent t m) typeclass constraint.
276-- This allows for working with IO when a ((MonadIO (Performable m)) constraint is available.
275-- This allows for working with IO when a ((MonadIO (Performable m)) constraint is available.
277[P] performEvent :: Event (Performable m a ) -> m (Event a)
276[P] performEvent :: Event (Performable m a ) -> m (Event a)
278
277
@@ -296,20 +295,17 @@ The typeclasses and their associated annotations include:
296## Networks
295## Networks
297
296
298```haskell
297```haskell
299−-- Functions from Reflex.Adjustable / Reflex.Network used to deal with Dynamics/Events carrying (m a)
298+-- Functions from Reflex.Network used to deal with Dynamics/Events carrying (m a)
300
299
301−[A] runWithReplace :: m a -> Event t (m b) -> m (a, Event t b)
302−
303−-- Given a Dynamic of network-creating actions, create a network that is recreated whenever the Dynamic updates.
300+-- Given a Dynamic of network-creating actions, create a network that is recreated whenever the Dynamic updates.
304−-- The returned Event of network results occurs when the Dynamic does. Note: Often, the type a is an Event,
301+-- The returned Event of network results occurs when the Dynamic does. Note: Often, the type a is an Event,
305-- in which case the return value is an Event-of-Events that would typically be flattened (via switchHold).
302-- in which case the return value is an Event-of-Events that would typically be flattened (via switchHold).
306−[P,A] networkView :: Dynamic (m a) -> m (Event a)
303+[P,A] networkView :: Dynamic (m a) -> m (Event a)
307
304
308−-- Given an initial network and an Event of network-creating actions, create a network that is recreated whenever the
305+-- Given an initial network and an Event of network-creating actions, create a network that is recreated whenever the
309−-- Event fires. The returned Dynamic of network results occurs when the Event does. Note: Often, the type a is an
306+-- Event fires. The returned Dynamic of network results occurs when the Event does. Note: Often, the type a is an
310-- Event, in which case the return value is a Dynamic-of-Events that would typically be flattened.
307-- Event, in which case the return value is a Dynamic-of-Events that would typically be flattened.
311−[H,A] networkHold :: m a -> Event (m a) -> m (Dynamic a)
308+[H,A] networkHold :: m a -> Event (m a) -> m (Dynamic a)
312
309
313-- Render a placeholder network to be shown while another network is not yet done building
310-- Render a placeholder network to be shown while another network is not yet done building
314−[P,A] untilReady :: m a -> m b -> m (a, Event b)
311+[P,A] untilReady :: m a -> m b -> m (a, Event b)
315−```
README.md+11−15
@@ -1,23 +1,19 @@
1−# [Reflex](https://reflex-frp.org/)
1+## Reflex
2+### Practical Functional Reactive Programming
2
3
3−[![Haskell](https://img.shields.io/badge/language-Haskell-orange.svg)](https://haskell.org) [![Hackage](https://img.shields.io/hackage/v/reflex.svg)](https://hackage.haskell.org/package/reflex) [![Hackage CI](https://matrix.hackage.haskell.org/api/v2/packages/reflex/badge)](https://matrix.hackage.haskell.org/#/package/reflex) [![BSD3 License](https://img.shields.io/badge/license-BSD3-blue.svg)](https://github.com/reflex-frp/reflex/blob/master/LICENSE)
4+Reflex is an fully-deterministic, higher-order Functional Reactive Programming (FRP) interface and an engine that efficiently implements that interface.
4
5
5−Interactive programs without callbacks or side-effects. Functional Reactive Programming (FRP) uses composable events and time-varying values to describe interactive systems as pure functions. Just like other pure functional code, functional reactive code is easier to get right on the first try, maintain, and reuse.
6+[Reflex-DOM](https://github.com/reflex-frp/reflex-dom) is a framework built on Reflex that facilitates the development of web pages, including highly-interactive single-page apps.
6
7
7−Reflex is a fully-deterministic, higher-order Functional Reactive Programming interface and an engine that efficiently implements that interface.
8+Comprehensive documentation is still a work in progress, but a tutorial for Reflex and Reflex-DOM is available at https://github.com/reflex-frp/reflex-platform and an introductory talk given at the New York Haskell Meetup is available here: [Part 1](https://www.youtube.com/watch?v=mYvkcskJbc4) / [Part 2](https://www.youtube.com/watch?v=3qfc9XFVo2c).
8
9
9−**Visit https://reflex-frp.org for more information, tutorials, documentation and [examples](https://examples.reflex-frp.org/).**
10+A summary of Reflex functions is available in the [quick reference](Quickref.md).
10
11
11−## Resources
12+### Additional resources
13+[Get started with Reflex](https://github.com/reflex-frp/reflex-platform)
12
14
13−* [Official Website](https://reflex-frp.org)
14−* [Quick Reference](Quickref.md)
15−* [Reflex-DOM](https://github.com/reflex-frp/reflex-dom): A framework built on Reflex that facilitates the development of web pages, including highly-interactive single-page apps.
16−* [Obelisk](https://github.com/obsidiansystems/obelisk#obelisk): A framework built on Reflex and Reflex-DOM for functional reactive web and mobile applications, with batteries included.
17−* [Get started with Reflex](https://github.com/reflex-frp/reflex-platform)
18−* [/r/reflexfrp](https://www.reddit.com/r/reflexfrp)
15+[/r/reflexfrp](https://www.reddit.com/r/reflexfrp)
19−* [irc.freenode.net #reflex-frp](http://webchat.freenode.net?channels=%23reflex-frp&uio=d4)
20
16
21−## Hacking
17+[hackage](https://hackage.haskell.org/package/reflex)
22
18
23−From the root of a [Reflex Platform](https://github.com/reflex-frp/reflex-platform) checkout, run `./scripts/hack-on haskell-overlays/reflex-packages/dep/reflex`. This will check out the reflex source code into the `haskell-overlays/reflex-packages/dep/reflex` directory. You can then point that checkout at your fork, make changes, etc. Use the `./try-reflex` or `./scripts/work-on` scripts to start a shell in which you can test your changes.
19+[irc.freenode.net #reflex-frp](http://webchat.freenode.net?channels=%23reflex-frp&uio=d4)
cabal.haskell-cideleted−23
@@ -1,23 +0,0 @@
1−distribution: xenial
2−benchmarks: False
3−unconstrained: False
4−installed: -all
5−
6−-- https://github.com/haskell/cabal/issues/6106
7−install-dependencies: False
8−
9−constraint-set no-th
10− constraints: reflex -use-template-haskell
11−
12−constraint-set old-these
13− ghc: <8.8
14− constraints: these <1
15−
16−constraint-set old-witherable
17− constraints: witherable <0.3.2
18−
19−constraint-set debug-propagation
20− constraints: reflex +debug-propagation
21−
22−constraint-set debug-cycles
23− constraints: reflex +debug-cycles
cabal.projectdeleted−1
@@ -1 +0,0 @@
1−packages: .
default.nixnew file+39
@@ -0,0 +1,39 @@
1+{ mkDerivation, ghc, base, bifunctors, containers, deepseq
2+, dependent-map, dependent-sum, exception-transformers
3+, haskell-src-exts, haskell-src-meta, hlint, lens, MemoTrie
4+, monad-control, mtl, primitive, random, ref-tf
5+, semigroupoids , semigroups, split, stdenv, stm, syb
6+, template-haskell , these, time, transformers
7+, transformers-compat, unbounded-delays, prim-uniq
8+, data-default, filepath, directory, filemanip, ghcjs-base
9+, monoidal-containers
10+, useTemplateHaskell ? true
11+}:
12+mkDerivation {
13+ pname = "reflex";
14+ version = "0.5";
15+ src = builtins.filterSource (path: type: !(builtins.elem (baseNameOf path) [ ".git" "dist" ])) ./.;
16+ libraryHaskellDepends = [
17+ base bifunctors containers dependent-map dependent-sum
18+ exception-transformers lens
19+ MemoTrie monad-control mtl primitive ref-tf semigroupoids
20+ semigroups stm syb template-haskell these transformers
21+ transformers-compat prim-uniq
22+ base bifunctors containers deepseq dependent-map dependent-sum
23+ mtl ref-tf split transformers data-default
24+ random time unbounded-delays monoidal-containers
25+ ] ++ (if ghc.isGhcjs or false then [
26+ ghcjs-base
27+ ] else []) ++ (if !useTemplateHaskell then [] else [
28+ haskell-src-exts haskell-src-meta
29+ ]);
30+ testHaskellDepends = if ghc.isGhcjs or false then [] else [
31+ hlint filepath directory filemanip
32+ ];
33+ configureFlags = if useTemplateHaskell then [] else [
34+ "-f-use-template-haskell"
35+ ];
36+ homepage = "https://github.com/reflex-frp/reflex";
37+ description = "Higher-order Functional Reactive Programming";
38+ license = stdenv.lib.licenses.bsd3;
39+}
dep/reflex-platform/default.nixdeleted−7
@@ -1,7 +0,0 @@
1−# DO NOT HAND-EDIT THIS FILE
2−import ((import <nixpkgs> {}).fetchFromGitHub (
3− let json = builtins.fromJSON (builtins.readFile ./github.json);
4− in { inherit (json) owner repo rev sha256;
5− private = json.private or false;
6− }
7−))
dep/reflex-platform/github.jsondeleted−7
@@ -1,7 +0,0 @@
1−{
2− "owner": "reflex-frp",
3− "repo": "reflex-platform",
4− "branch": "develop",
5− "rev": "f628398d076243a0851b27e625b37f65dff9b89b",
6− "sha256": "0sl0hf1glgyb1vmf2mhw4r9ipmcqk1y19d3wsic7dix2jwywzrh9"
7−}
hydra.jsonnew file+29
@@ -0,0 +1,29 @@
1+{
2+ "enabled": 1,
3+ "hidden": true,
4+ "description": "Jobsets",
5+ "nixexprinput": "src",
6+ "nixexprpath": "jobsets.nix",
7+ "checkinterval": 300,
8+ "schedulingshares": 100,
9+ "enableemail": false,
10+ "emailoverride": "",
11+ "keepnr": 10,
12+ "inputs": {
13+ "src": {
14+ "type": "git",
15+ "value": "https://github.com/reflex-frp/reflex.git develop",
16+ "emailresponsible": false
17+ },
18+ "nixpkgs": {
19+ "type": "git",
20+ "value": "https://github.com/NixOS/nixpkgs-channels nixos-unstable",
21+ "emailresponsible": false
22+ },
23+ "prs": {
24+ "type": "githubpulls",
25+ "value": "reflex-frp reflex",
26+ "emailresponsible": false
27+ }
28+ }
29+}
jobsets.nixnew file+70
@@ -0,0 +1,70 @@
1+{ prs }:
2+
3+let
4+ pkgs = (import ./reflex-platform.nix {}).nixpkgs;
5+ mkFetchGithub = value: {
6+ inherit value;
7+ type = "git";
8+ emailresponsible = false;
9+ };
10+in
11+with pkgs.lib;
12+let
13+ defaults = jobs: {
14+ inherit (jobs) description;
15+ enabled = 1;
16+ hidden = false;
17+ keepnr = 10;
18+ schedulingshares = 100;
19+ checkinterval = 120;
20+ enableemail = false;
21+ emailoverride = "";
22+ nixexprinput = "reflex";
23+ nixexprpath = "release.nix";
24+ inputs = jobs.inputs // {
25+ nixpkgs = {
26+ type = "git";
27+ value = "https://github.com/NixOS/nixpkgs-channels nixos-unstable";
28+ emailresponsible = false;
29+ };
30+ config = {
31+ type = "nix";
32+ value = "{ android_sdk.accept_license = true; }";
33+ emailresponsible = false;
34+ };
35+ };
36+ };
37+ branchJobset = branch: defaults {
38+ description = "reflex-${branch}";
39+ inputs = {
40+ reflex = {
41+ value = "https://github.com/reflex-frp/reflex ${branch}";
42+ type = "git";
43+ emailresponsible = false;
44+ };
45+ };
46+ };
47+ makePr = num: info: {
48+ name = "reflex-pr-${num}";
49+ value = defaults {
50+ description = "#${num}: ${info.title}";
51+ inputs = {
52+ reflex = {
53+ #NOTE: This should really use "pull/${num}/merge"; however, GitHub's
54+ #status checks only operate on PR heads. This creates a race
55+ #condition, which can currently only be solved by requiring PRs to be
56+ #up to date before they're merged. See
57+ #https://github.com/isaacs/github/issues/1002
58+ value = "https://github.com/reflex-frp/reflex pull/${num}/head";
59+ type = "git";
60+ emailresponsible = false;
61+ };
62+ };
63+ };
64+ };
65+ processedPrs = mapAttrs' makePr (builtins.fromJSON (builtins.readFile prs));
66+ jobsetsAttrs = processedPrs //
67+ genAttrs ["develop"] branchJobset;
68+in {
69+ jobsets = pkgs.writeText "spec.json" (builtins.toJSON jobsetsAttrs);
70+}
reflex-platform.nixnew file+8
@@ -0,0 +1,8 @@
1+let
2+ reflex-platform-src = (import <nixpkgs> {}).fetchFromGitHub {
3+ owner = "reflex-frp";
4+ repo = "reflex-platform";
5+ rev = "384cd850f3adf1d404bced2424b5f6efb0f415f2";
6+ sha256 = "1ws77prqx8khmp8j6br1ij4k2v4dlgv170r9fmg0p1jivfbn8y9d";
7+ };
8+in import reflex-platform-src
reflex.cabal+56−192
@@ -1,17 +1,7 @@
1Name: reflex
1Name: reflex
2−Version: 0.8.2.0
2+Version: 0.5
3Synopsis: Higher-order Functional Reactive Programming
3Synopsis: Higher-order Functional Reactive Programming
4−Description:
5− Interactive programs without callbacks or side-effects.
6− Functional Reactive Programming (FRP) uses composable events and time-varying
7− values to describe interactive systems as pure functions.
8− Just like other pure functional code, functional reactive code is easier
9− to get right on the first try, maintain, and reuse.
10− .
11− Reflex is a fully-deterministic, higher-order Functional Reactive Programming
4+Description: Reflex is a high-performance, deterministic, higher-order Functional Reactive Programming system
12− interface and an engine that efficiently implements that interface.
13− .
14− <https://reflex-frp.org>
15License: BSD3
5License: BSD3
16License-file: LICENSE
6License-file: LICENSE
17Author: Ryan Trinkle
7Author: Ryan Trinkle
@@ -19,17 +9,12 @@ Maintainer: ryan.trinkle@gmail.com
19Stability: Experimental
9Stability: Experimental
20Category: FRP
10Category: FRP
21Build-type: Simple
11Build-type: Simple
22−Cabal-version: 1.22
12+Cabal-version: >=1.9.2
23homepage: https://reflex-frp.org
13homepage: https://reflex-frp.org
24bug-reports: https://github.com/reflex-frp/reflex/issues
14bug-reports: https://github.com/reflex-frp/reflex/issues
25extra-source-files:
15extra-source-files:
26 README.md
16 README.md
27 Quickref.md
17 Quickref.md
28− ChangeLog.md
29−
30−tested-with:
31− GHC ==8.4.4 || ==8.6.5 || ==8.8.1 || ==8.10.2,
32− GHCJS ==8.6
33
18
34flag use-reflex-optimizer
19flag use-reflex-optimizer
35 description: Use the GHC plugin Reflex.Optimizer on some of the modules in the package. This is still experimental.
20 description: Use the GHC plugin Reflex.Optimizer on some of the modules in the package. This is still experimental.
@@ -51,67 +36,41 @@ flag fast-weak
51 default: False
36 default: False
52 manual: True
37 manual: True
53
38
54−flag debug-propagation
55− description: Enable debugging of spider internals
56− default: False
57− manual: True
58−
59−flag debug-cycles
60− description: Enable debugging of event cycles
61− default: False
62− manual: True
63−
64−flag split-these
65− description: Use split these/semialign packages
66− manual: False
67− default: True
68−
69library
39library
70− default-language: Haskell2010
71 hs-source-dirs: src
40 hs-source-dirs: src
72 build-depends:
41 build-depends:
73 MemoTrie == 0.6.*,
42 MemoTrie == 0.6.*,
74− base >= 4.11 && < 4.15,
43+ base >= 4.9 && < 4.13,
75 bifunctors >= 5.2 && < 5.6,
44 bifunctors >= 5.2 && < 5.6,
76− comonad >= 5.0.4 && < 5.1,
45+ comonad,
77− constraints >= 0.10 && <0.14,
78− constraints-extras >= 0.3 && < 0.4,
79− containers >= 0.6 && < 0.7,
46+ containers >= 0.5 && < 0.7,
80 data-default >= 0.5 && < 0.8,
47 data-default >= 0.5 && < 0.8,
81− dependent-map >= 0.3 && < 0.5,
48+ dependent-map >= 0.2.4 && < 0.3,
82 exception-transformers == 0.4.*,
49 exception-transformers == 0.4.*,
83 lens >= 4.7 && < 5,
50 lens >= 4.7 && < 5,
84− mmorph >= 1.0 && < 1.2,
85 monad-control >= 1.0.1 && < 1.1,
51 monad-control >= 1.0.1 && < 1.1,
52+ monoidal-containers == 0.4.*,
86 mtl >= 2.1 && < 2.3,
53 mtl >= 2.1 && < 2.3,
87− patch >= 0.0.1 && < 0.1,
88− prim-uniq >= 0.1.0.1 && < 0.3,
54+ prim-uniq >= 0.1.0.1 && < 0.2,
89− primitive >= 0.5 && < 0.8,
55+ primitive >= 0.5 && < 0.7,
90− profunctors >= 5.3 && < 5.7,
91 random == 1.1.*,
56 random == 1.1.*,
92 ref-tf == 0.4.*,
57 ref-tf == 0.4.*,
93 reflection == 2.1.*,
58 reflection == 2.1.*,
94 semigroupoids >= 4.0 && < 6,
59 semigroupoids >= 4.0 && < 6,
60+ semigroups >= 0.16 && < 0.19,
95 stm >= 2.4 && < 2.6,
61 stm >= 2.4 && < 2.6,
96 syb >= 0.5 && < 0.8,
62 syb >= 0.5 && < 0.8,
63+ these >= 0.4 && < 0.7.6,
97− time >= 1.4 && < 1.10,
64+ time >= 1.4 && < 1.9,
98− transformers >= 0.5.6.0 && < 0.6,
65+ transformers >= 0.2,
66+ transformers-compat >= 0.3,
99− unbounded-delays >= 0.1.0.0 && < 0.2,
67+ unbounded-delays >= 0.1.0.0 && < 0.2
100− witherable >= 0.3 && < 0.5
101−
102− if flag(split-these)
103− build-depends: these >= 1 && <1.2,
104− semialign >=1 && <1.2,
105− monoidal-containers >= 0.6 && < 0.7
106− else
107− build-depends: these >= 0.4 && <0.9,
108− monoidal-containers == 0.4.0.0
109
68
110 exposed-modules:
69 exposed-modules:
111− Control.Monad.ReaderIO
112 Data.AppendMap,
70 Data.AppendMap,
113 Data.FastMutableIntMap,
71 Data.FastMutableIntMap,
114 Data.FastWeakBag,
72 Data.FastWeakBag,
73+ Data.Functor.Misc,
115 Data.Map.Misc,
74 Data.Map.Misc,
116 Data.WeakBag,
75 Data.WeakBag,
117 Reflex,
76 Reflex,
@@ -131,9 +90,15 @@ library
131 Reflex.FastWeak,
90 Reflex.FastWeak,
132 Reflex.FunctorMaybe,
91 Reflex.FunctorMaybe,
133 Reflex.Host.Class,
92 Reflex.Host.Class,
134− Reflex.Host.Headless,
135 Reflex.Network,
93 Reflex.Network,
136 Reflex.NotReady.Class,
94 Reflex.NotReady.Class,
95+ Reflex.Patch,
96+ Reflex.Patch.Class,
97+ Reflex.Patch.DMap,
98+ Reflex.Patch.DMapWithMove,
99+ Reflex.Patch.IntMap,
100+ Reflex.Patch.Map,
101+ Reflex.Patch.MapWithMove,
137 Reflex.PerformEvent.Base,
102 Reflex.PerformEvent.Base,
138 Reflex.PerformEvent.Class,
103 Reflex.PerformEvent.Class,
139 Reflex.PostBuild.Base,
104 Reflex.PostBuild.Base,
@@ -152,57 +117,38 @@ library
152 Reflex.Widget.Basic,
117 Reflex.Widget.Basic,
153 Reflex.Workflow
118 Reflex.Workflow
154
119
155− reexported-modules:
156− patch:Data.Functor.Misc,
157− patch:Data.Patch as Reflex.Patch,
158− patch:Data.Patch.Class as Reflex.Patch.Class,
159− patch:Data.Patch.DMap as Reflex.Patch.DMap,
160− patch:Data.Patch.DMapWithMove as Reflex.Patch.DMapWithMove,
161− patch:Data.Patch.IntMap as Reflex.Patch.IntMap,
162− patch:Data.Patch.Map as Reflex.Patch.Map,
163− patch:Data.Patch.MapWithMove as Reflex.Patch.MapWithMove
164−
165 ghc-options: -Wall -fwarn-redundant-constraints -fwarn-tabs -funbox-strict-fields -O2 -fspecialise-aggressively
120 ghc-options: -Wall -fwarn-redundant-constraints -fwarn-tabs -funbox-strict-fields -O2 -fspecialise-aggressively
166
121
167 if flag(debug-trace-events)
122 if flag(debug-trace-events)
168 cpp-options: -DDEBUG_TRACE_EVENTS
123 cpp-options: -DDEBUG_TRACE_EVENTS
169− build-depends:
124+ build-depends: bytestring
170− bytestring >= 0.10.8 && < 0.11
171
125
172 if flag(use-reflex-optimizer)
126 if flag(use-reflex-optimizer)
173 cpp-options: -DUSE_REFLEX_OPTIMIZER
127 cpp-options: -DUSE_REFLEX_OPTIMIZER
174 build-depends: ghc
128 build-depends: ghc
175 exposed-modules: Reflex.Optimizer
129 exposed-modules: Reflex.Optimizer
176
130
177− if flag(debug-propagation)
178− cpp-options: -DDEBUG -DDEBUG_TRACE_PROPAGATION -DDEBUG_TRACE_INVALIDATION
179−
180− if flag(debug-cycles)
181− cpp-options: -DDEBUG_CYCLES
182−
183 if flag(use-template-haskell)
131 if flag(use-template-haskell)
184 cpp-options: -DUSE_TEMPLATE_HASKELL
132 cpp-options: -DUSE_TEMPLATE_HASKELL
185 build-depends:
133 build-depends:
186− dependent-sum >= 0.6 && < 0.8,
134+ dependent-sum >= 0.3 && < 0.5,
187− haskell-src-exts >= 1.16 && < 1.24,
135+ haskell-src-exts >= 1.16 && < 1.21,
188 haskell-src-meta >= 0.6 && < 0.9,
136 haskell-src-meta >= 0.6 && < 0.9,
189− template-haskell >= 2.9 && < 2.17
137+ template-haskell >= 2.9 && < 2.15
190 exposed-modules:
138 exposed-modules:
191 Reflex.Dynamic.TH
139 Reflex.Dynamic.TH
192 other-extensions: TemplateHaskell
140 other-extensions: TemplateHaskell
193 else
141 else
194 build-depends:
142 build-depends:
195− dependent-sum >= 0.6 && < 0.8
143+ dependent-sum == 0.4.*
196
144
197 if flag(fast-weak) && impl(ghcjs)
145 if flag(fast-weak) && impl(ghcjs)
198 cpp-options: -DGHCJS_FAST_WEAK
146 cpp-options: -DGHCJS_FAST_WEAK
199
147
200 if impl(ghcjs)
148 if impl(ghcjs)
201− build-depends:
149+ build-depends: ghcjs-base
202− ghcjs-base == 0.2.*
203
150
204test-suite semantics
151test-suite semantics
205− default-language: Haskell2010
206 type: exitcode-stdio-1.0
152 type: exitcode-stdio-1.0
207 main-is: semantics.hs
153 main-is: semantics.hs
208 hs-source-dirs: test
154 hs-source-dirs: test
@@ -211,14 +157,14 @@ test-suite semantics
211 base,
157 base,
212 bifunctors,
158 bifunctors,
213 containers,
159 containers,
214− deepseq,
160+ deepseq >= 1.3 && < 1.5,
215 dependent-map,
161 dependent-map,
216 dependent-sum,
162 dependent-sum,
217 mtl,
163 mtl,
218 ref-tf,
164 ref-tf,
219 reflex,
165 reflex,
220 split,
166 split,
221− transformers
167+ transformers >= 0.3
222 other-modules:
168 other-modules:
223 Reflex.Bench.Focused
169 Reflex.Bench.Focused
224 Reflex.Plan.Pure
170 Reflex.Plan.Pure
@@ -228,7 +174,6 @@ test-suite semantics
228 Reflex.TestPlan
174 Reflex.TestPlan
229
175
230test-suite CrossImpl
176test-suite CrossImpl
231− default-language: Haskell2010
232 type: exitcode-stdio-1.0
177 type: exitcode-stdio-1.0
233 main-is: Reflex/Test/CrossImpl.hs
178 main-is: Reflex/Test/CrossImpl.hs
234 hs-source-dirs: test
179 hs-source-dirs: test
@@ -238,7 +183,7 @@ test-suite CrossImpl
238 containers,
183 containers,
239 dependent-map,
184 dependent-map,
240 dependent-sum,
185 dependent-sum,
241− deepseq,
186+ deepseq >= 1.3 && < 1.5,
242 mtl,
187 mtl,
243 transformers,
188 transformers,
244 ref-tf,
189 ref-tf,
@@ -250,7 +195,6 @@ test-suite CrossImpl
250 Reflex.Plan.Pure
195 Reflex.Plan.Pure
251
196
252test-suite hlint
197test-suite hlint
253− default-language: Haskell2010
254 type: exitcode-stdio-1.0
198 type: exitcode-stdio-1.0
255 main-is: hlint.hs
199 main-is: hlint.hs
256 hs-source-dirs: test
200 hs-source-dirs: test
@@ -258,119 +202,50 @@ test-suite hlint
258 , directory
202 , directory
259 , filepath
203 , filepath
260 , filemanip
204 , filemanip
261− if impl(ghc >= 8.8)
205+ , hlint
262− build-depends: hlint >= 3 && < 4
263− else
264− build-depends: hlint (< 2.1 || >= 2.2.2) && < 4
265 if impl(ghcjs)
206 if impl(ghcjs)
266 buildable: False
207 buildable: False
267
208
268test-suite EventWriterT
209test-suite EventWriterT
269− default-language: Haskell2010
270 type: exitcode-stdio-1.0
210 type: exitcode-stdio-1.0
271 main-is: EventWriterT.hs
211 main-is: EventWriterT.hs
272 hs-source-dirs: test
212 hs-source-dirs: test
273 build-depends: base
213 build-depends: base
274 , containers
214 , containers
275− , deepseq
215+ , deepseq >= 1.3 && < 1.5
276− , dependent-map
277− , dependent-sum
278− , lens
279− , mtl
280− , these
281− , transformers
282− , reflex
283− , ref-tf
284−
285− if flag(split-these)
286− build-depends: these-lens
287−
288− other-modules:
289− Test.Run
290−
291−
292−test-suite DebugCycles
293− default-language: Haskell2010
294− type: exitcode-stdio-1.0
295− main-is: DebugCycles.hs
296− hs-source-dirs: test
297− ghc-options: -threaded
298− build-depends: base
299− , containers
300− , deepseq
301 , dependent-map
216 , dependent-map
302 , dependent-sum
217 , dependent-sum
303− , hspec
304 , lens
218 , lens
305 , mtl
219 , mtl
306 , these
220 , these
307 , transformers
221 , transformers
308 , reflex
222 , reflex
309 , ref-tf
223 , ref-tf
310− , witherable
311− , proctest
312−
313−
314− if flag(split-these)
315− build-depends: these-lens, semialign
316−
317 other-modules:
224 other-modules:
225+ Reflex.Test
226+ Reflex.TestPlan
227+ Reflex.Plan.Reflex
228+ Reflex.Plan.Pure
318 Test.Run
229 Test.Run
319
230
320−
321test-suite RequesterT
231test-suite RequesterT
322− default-language: Haskell2010
323 type: exitcode-stdio-1.0
232 type: exitcode-stdio-1.0
324 main-is: RequesterT.hs
233 main-is: RequesterT.hs
325 hs-source-dirs: test
234 hs-source-dirs: test
326 build-depends: base
235 build-depends: base
327− , constraints
328− , constraints-extras
329− , containers
330− , deepseq
331− , dependent-map
332 , dependent-sum
236 , dependent-sum
237+ , dependent-map
333 , lens
238 , lens
334− , mtl
335− , ref-tf
336− , reflex
337− , text
338 , these
239 , these
339 , transformers
240 , transformers
340−
341− if flag(split-these)
342− build-depends: these-lens
343−
344− other-modules:
345− Reflex.TestPlan
346− Reflex.Plan.Pure
347− Test.Run
348−
349−test-suite Headless
350− default-language: Haskell2010
351− type: exitcode-stdio-1.0
352− main-is: Headless.hs
353− hs-source-dirs: test
354− build-depends: base
355− , reflex
356−
357−test-suite Adjustable
358− default-language: Haskell2010
359− type: exitcode-stdio-1.0
360− main-is: Adjustable.hs
361− hs-source-dirs: test
362− build-depends: base
363− , containers
364− , dependent-sum
365 , reflex
241 , reflex
366 , ref-tf
242 , ref-tf
367− , these
243+ buildable: False
368−
369 other-modules:
244 other-modules:
370− Test.Run
245+ Reflex.TestPlan
246+ Reflex.Plan.Pure
371
247
372test-suite QueryT
248test-suite QueryT
373− default-language: Haskell2010
374 type: exitcode-stdio-1.0
249 type: exitcode-stdio-1.0
375 main-is: QueryT.hs
250 main-is: QueryT.hs
376 hs-source-dirs: test
251 hs-source-dirs: test
@@ -378,19 +253,15 @@ test-suite QueryT
378 , containers
253 , containers
379 , dependent-map
254 , dependent-map
380 , dependent-sum
255 , dependent-sum
381− , deepseq
256+ , deepseq >= 1.3 && < 1.5
382 , lens
257 , lens
383 , monoidal-containers
258 , monoidal-containers
384 , mtl
259 , mtl
385− , patch
386 , ref-tf
260 , ref-tf
387 , reflex
261 , reflex
262+ , semigroups
388 , these
263 , these
389 , transformers
264 , transformers
390−
391− if flag(split-these)
392− build-depends: semialign, these-lens
393−
394 other-modules:
265 other-modules:
395 Test.Run
266 Test.Run
396 Reflex.TestPlan
267 Reflex.TestPlan
@@ -398,7 +269,6 @@ test-suite QueryT
398 Reflex.Plan.Pure
269 Reflex.Plan.Pure
399
270
400test-suite GC-Semantics
271test-suite GC-Semantics
401− default-language: Haskell2010
402 type: exitcode-stdio-1.0
272 type: exitcode-stdio-1.0
403 main-is: GC.hs
273 main-is: GC.hs
404 hs-source-dirs: test
274 hs-source-dirs: test
@@ -406,17 +276,14 @@ test-suite GC-Semantics
406 , containers
276 , containers
407 , dependent-sum
277 , dependent-sum
408 , dependent-map
278 , dependent-map
409− , deepseq
279+ , deepseq >= 1.3 && < 1.5
410 , mtl
280 , mtl
411− , patch
412 , these
281 , these
413 , transformers
282 , transformers
414 , reflex
283 , reflex
415 , ref-tf
284 , ref-tf
416−
285+ if impl(ghc < 8)
417− if flag(split-these)
418− build-depends: semialign
286+ build-depends: semigroups
419−
420 other-modules:
287 other-modules:
421 Reflex.Plan.Pure
288 Reflex.Plan.Pure
422 Reflex.Plan.Reflex
289 Reflex.Plan.Reflex
@@ -424,13 +291,12 @@ test-suite GC-Semantics
424 Test.Run
291 Test.Run
425
292
426test-suite rootCleanup
293test-suite rootCleanup
427− default-language: Haskell2010
428 type: exitcode-stdio-1.0
294 type: exitcode-stdio-1.0
429 main-is: rootCleanup.hs
295 main-is: rootCleanup.hs
430 hs-source-dirs: test
296 hs-source-dirs: test
431 build-depends: base
297 build-depends: base
432 , containers
298 , containers
433− , deepseq
299+ , deepseq >= 1.3 && < 1.5
434 , dependent-sum
300 , dependent-sum
435 , mtl
301 , mtl
436 , reflex
302 , reflex
@@ -442,7 +308,6 @@ test-suite rootCleanup
442 Test.Run
308 Test.Run
443
309
444benchmark spider-bench
310benchmark spider-bench
445− default-language: Haskell2010
446 type: exitcode-stdio-1.0
311 type: exitcode-stdio-1.0
447 hs-source-dirs: bench test
312 hs-source-dirs: bench test
448 main-is: Main.hs
313 main-is: Main.hs
@@ -450,8 +315,8 @@ benchmark spider-bench
450 build-depends:
315 build-depends:
451 base,
316 base,
452 containers,
317 containers,
453− criterion,
318+ criterion >= 1.1 && < 1.6,
454− deepseq,
319+ deepseq >= 1.3 && < 1.5,
455 dependent-map,
320 dependent-map,
456 dependent-sum,
321 dependent-sum,
457 ref-tf,
322 ref-tf,
@@ -460,14 +325,13 @@ benchmark spider-bench
460 reflex,
325 reflex,
461 split,
326 split,
462 stm,
327 stm,
463− transformers
328+ transformers >= 0.3
464 other-modules:
329 other-modules:
465 Reflex.TestPlan
330 Reflex.TestPlan
466 Reflex.Plan.Reflex
331 Reflex.Plan.Reflex
467 Reflex.Bench.Focused
332 Reflex.Bench.Focused
468
333
469benchmark saulzar-bench
334benchmark saulzar-bench
470− default-language: Haskell2010
471 type: exitcode-stdio-1.0
335 type: exitcode-stdio-1.0
472 hs-source-dirs: bench test
336 hs-source-dirs: bench test
473 c-sources: bench-cbits/checkCapability.c
337 c-sources: bench-cbits/checkCapability.c
@@ -475,9 +339,9 @@ benchmark saulzar-bench
475 ghc-options: -Wall -O2 -rtsopts -threaded
339 ghc-options: -Wall -O2 -rtsopts -threaded
476 build-depends:
340 build-depends:
477 base,
341 base,
478− containers,
342+ containers >= 0.5 && < 0.7,
479− criterion,
343+ criterion >= 1.1 && < 1.6,
480− deepseq,
344+ deepseq >= 1.3 && < 1.5,
481 dependent-map,
345 dependent-map,
482 dependent-sum,
346 dependent-sum,
483 loch-th,
347 loch-th,
@@ -489,7 +353,7 @@ benchmark saulzar-bench
489 split,
353 split,
490 stm,
354 stm,
491 time,
355 time,
492− transformers
356+ transformers >= 0.3
493 other-modules:
357 other-modules:
494 Reflex.TestPlan
358 Reflex.TestPlan
495 Reflex.Plan.Reflex
359 Reflex.Plan.Reflex
release.nix+7−56
@@ -1,58 +1,9 @@
1−{ reflex-platform-fun ? import ./dep/reflex-platform
1+{ rp ? import ./reflex-platform.nix {}
2−, supportedSystems ? ["x86_64-linux" "x86_64-darwin"]
3}:
2}:
4−
5let
3let
6− native-reflex-platform = reflex-platform-fun {};
7− inherit (native-reflex-platform.nixpkgs) lib;
4+ inherit (rp.nixpkgs) lib;
8−
5+ compilers = ["ghc8_4" "ghc8_0" "ghcjs8_4" "ghcjs8_0"];
9− perPlatform = lib.genAttrs supportedSystems (system: let
10− reflex-platform = reflex-platform-fun { inherit system; };
11− compilers = [
12− "ghc"
13− "ghcjs"
14− ] ++ lib.optionals (reflex-platform.androidSupport) [
15− "ghcAndroidAarch64"
16− "ghcAndroidAarch32"
17− ] ++ lib.optionals (reflex-platform.iosSupport) [
18− "ghcIosAarch64"
19− ];
20− variations = map (v: "reflex" + v) [
21− "-dontUseTemplateHaskell"
22− ""
23− ];
24− compilerPkgs = lib.genAttrs compilers (ghc: let
6+in lib.genAttrs compilers (ghc: {
25− variationPkgs = lib.genAttrs variations (variation: let
7+ reflex-useTemplateHaskell = rp.${ghc}.callPackage ./. { useTemplateHaskell = true; };
26− reflex-platform = reflex-platform-fun {
8+ reflex = rp.${ghc}.callPackage ./. { useTemplateHaskell = false; };
27− inherit system;
9+})
28− __useTemplateHaskell = variation == "reflex"; # TODO hack
29− haskellOverlays = [
30− # Use this package's source for reflex
31− (self: super: {
32− _dep = super._dep // {
33− reflex = builtins.filterSource (path: type: !(builtins.elem (baseNameOf path) [
34− "release.nix"
35− ".git"
36− "dist"
37− "cabal.haskell-ci"
38− "cabal.project"
39− ".travis.yml"
40− ])) ./.;
41− };
42− })
43− ];
44− };
45− in reflex-platform.${ghc}.reflex);
46− in variationPkgs // {
47− cache = reflex-platform.pinBuildInputs "reflex-${system}-${ghc}"
48− (builtins.attrValues variationPkgs);
49− });
50− in compilerPkgs // {
51− cache = reflex-platform.pinBuildInputs "reflex-${system}"
52− (map (a: a.cache) (builtins.attrValues compilerPkgs));
53− });
54−
55− metaCache = native-reflex-platform.pinBuildInputs "reflex-everywhere"
56− (map (a: a.cache) (builtins.attrValues perPlatform));
57−
58−in perPlatform // { inherit metaCache; }
src/Control/Monad/ReaderIO.hsdeleted−60
@@ -1,60 +0,0 @@
1−{-# language RoleAnnotations #-}
2−{-# language MultiParamTypeClasses #-}
3−{-# language FlexibleInstances #-}
4−{-# language CPP #-}
5−module Control.Monad.ReaderIO
6− (
7− ReaderIO (..)
8− )
9− where
10−
11−import Control.Monad.Fix
12−#if MIN_VERSION_base(4,10,0)
13−import Control.Applicative
14−#endif
15−import Control.Monad
16−import Control.Monad.Reader.Class
17−import Control.Monad.IO.Class
18−
19−-- | An approximate clone of @RIO@ from the @rio@ package, but not based on
20−-- @ReaderT@. The trouble with @ReaderT@ is that its third type argument has a
21−-- @nominal@ role, so we can't coerce through it when it's wrapped in some
22−-- other @data@ type. Ugh.
23−newtype ReaderIO e a = ReaderIO { runReaderIO :: e -> IO a }
24−type role ReaderIO representational representational
25−
26−instance Functor (ReaderIO e) where
27− fmap = liftM
28− {-# INLINE fmap #-}
29− a <$ m = m >> pure a
30− {-# INLINE (<$) #-}
31−
32−instance Applicative (ReaderIO e) where
33− pure a = ReaderIO $ \_ -> pure a
34− {-# INLINE pure #-}
35− (<*>) = ap
36− {-# INLINE (<*>) #-}
37−#if MIN_VERSION_base(4,10,0)
38− liftA2 = liftM2
39− {-# INLINE liftA2 #-}
40−#endif
41− (*>) = (>>)
42− {-# INLINE (*>) #-}
43−
44−instance Monad (ReaderIO e) where
45− ReaderIO q >>= f = ReaderIO $ \e -> q e >>= \a -> runReaderIO (f a) e
46− {-# INLINE (>>=) #-}
47−
48−instance MonadFix (ReaderIO e) where
49− mfix f = ReaderIO $ \e -> mfix $ \r -> runReaderIO (f r) e
50− {-# INLINE mfix #-}
51−
52−instance MonadIO (ReaderIO e) where
53− liftIO m = ReaderIO $ \_ -> m
54− {-# INLINE liftIO #-}
55−
56−instance MonadReader e (ReaderIO e) where
57− ask = ReaderIO pure
58− {-# INLINE ask #-}
59− local f (ReaderIO m) = ReaderIO (m . f)
60− {-# INLINE local #-}
src/Data/AppendMap.hs+21−24
@@ -1,26 +1,27 @@
1{-# LANGUAGE CPP #-}
1{-# LANGUAGE CPP #-}
2+{-# LANGUAGE DeriveFunctor #-}
3+{-# LANGUAGE DeriveGeneric #-}
4+{-# LANGUAGE DeriveTraversable #-}
2{-# LANGUAGE FlexibleContexts #-}
5{-# LANGUAGE FlexibleContexts #-}
3{-# LANGUAGE FlexibleInstances #-}
6{-# LANGUAGE FlexibleInstances #-}
7+{-# LANGUAGE GeneralizedNewtypeDeriving #-}
4{-# LANGUAGE MultiParamTypeClasses #-}
8{-# LANGUAGE MultiParamTypeClasses #-}
5{-# LANGUAGE PatternSynonyms #-}
9{-# LANGUAGE PatternSynonyms #-}
6{-# LANGUAGE RoleAnnotations #-}
10{-# LANGUAGE RoleAnnotations #-}
7{-# LANGUAGE ScopedTypeVariables #-}
11{-# LANGUAGE ScopedTypeVariables #-}
12+{-# LANGUAGE StandaloneDeriving #-}
8{-# LANGUAGE TypeFamilies #-}
13{-# LANGUAGE TypeFamilies #-}
9{-# OPTIONS_GHC -fno-warn-orphans #-}
14{-# OPTIONS_GHC -fno-warn-orphans #-}
10−-- |
15+-- | 'Data.Map' with a better 'Monoid' instance
11−-- Module:
16+--
12−-- Data.AppendMap
13−-- Description:
14−-- Instances and convenience functions for 'Data.Map.Monoidal'. We use
15−-- monoidal-containers to take advantage of its better monoid instance.
16−-- 'Data.Map' has @mappend = union@, which is left-biased. 'MonoidalMap'
17+-- 'Data.Map' has @mappend = union@, which is left-biased. AppendMap has
17−-- has @mappend = unionWith mappend@ instead.
18+-- @mappend = unionWith mappend@ instead.
18module Data.AppendMap
19module Data.AppendMap
19 ( module Data.AppendMap
20 ( module Data.AppendMap
20 , module Data.Map.Monoidal
21 , module Data.Map.Monoidal
21 ) where
22 ) where
22
23
23−import Prelude hiding (null)
24+import Prelude hiding (map, null)
24
25
25import Data.Coerce
26import Data.Coerce
26import Data.Default
27import Data.Default
@@ -30,28 +31,22 @@ import qualified Data.Map.Internal.Debug as Map (showTree, showTreeWith)
30#else
31#else
31import qualified Data.Map as Map (showTree, showTreeWith)
32import qualified Data.Map as Map (showTree, showTreeWith)
32#endif
33#endif
33−import qualified Data.Witherable as W
34import Data.Map.Monoidal
34import Data.Map.Monoidal
35−import qualified Data.Map.Monoidal as MonoidalMap
35+import Reflex.Class (FunctorMaybe (..))
36−
36+import Reflex.Patch (Additive, Group (..))
37
37
38{-# DEPRECATED AppendMap "Use 'MonoidalMap' instead" #-}
38{-# DEPRECATED AppendMap "Use 'MonoidalMap' instead" #-}
39−-- | AppendMap is a synonym for 'Data.Map.Monoidal.MonoidalMap'
40type AppendMap = MonoidalMap
39type AppendMap = MonoidalMap
41
40
42{-# DEPRECATED _unAppendMap "Use 'getMonoidalMap' instead" #-}
41{-# DEPRECATED _unAppendMap "Use 'getMonoidalMap' instead" #-}
43−-- | A synonym for 'getMonoidalMap'
44_unAppendMap :: MonoidalMap k v -> Map k v
42_unAppendMap :: MonoidalMap k v -> Map k v
45_unAppendMap = getMonoidalMap
43_unAppendMap = getMonoidalMap
46
44
47−-- | Pattern synonym for 'MonoidalMap'
48pattern AppendMap :: Map k v -> MonoidalMap k v
45pattern AppendMap :: Map k v -> MonoidalMap k v
49pattern AppendMap m = MonoidalMap m
46pattern AppendMap m = MonoidalMap m
50
47
51−#if !MIN_VERSION_witherable(0,3,2)
52−instance W.Filterable (MonoidalMap k) where
48+instance FunctorMaybe (MonoidalMap k) where
53− mapMaybe = MonoidalMap.mapMaybe
49+ fmapMaybe = mapMaybe
54−#endif
55
50
56-- | Deletes a key, returning 'Nothing' if the result is empty.
51-- | Deletes a key, returning 'Nothing' if the result is empty.
57nonEmptyDelete :: Ord k => k -> MonoidalMap k a -> Maybe (MonoidalMap k a)
52nonEmptyDelete :: Ord k => k -> MonoidalMap k a -> Maybe (MonoidalMap k a)
@@ -61,22 +56,24 @@ nonEmptyDelete k vs =
61 then Nothing
56 then Nothing
62 else Just deleted
57 else Just deleted
63
58
64−-- | Like 'mapMaybe' but indicates whether the resulting container is empty
65mapMaybeNoNull :: (a -> Maybe b)
59mapMaybeNoNull :: (a -> Maybe b)
66 -> MonoidalMap token a
60 -> MonoidalMap token a
67 -> Maybe (MonoidalMap token b)
61 -> Maybe (MonoidalMap token b)
68mapMaybeNoNull f as =
62mapMaybeNoNull f as =
69− let bs = mapMaybe f as
63+ let bs = fmapMaybe f as
70 in if null bs
64 in if null bs
71 then Nothing
65 then Nothing
72 else Just bs
66 else Just bs
73
67
74−-- TODO: Move instances to `Data.Patch`
68+-- TODO: Move instances to `Reflex.Patch`
75−-- | Displays a 'MonoidalMap' as a tree. See 'Data.Map.Lazy.showTree' for details.
69+instance (Ord k, Group q) => Group (MonoidalMap k q) where
70+ negateG = map negateG
71+
72+instance (Ord k, Additive q) => Additive (MonoidalMap k q)
73+
76showTree :: forall k a. (Show k, Show a) => MonoidalMap k a -> String
74showTree :: forall k a. (Show k, Show a) => MonoidalMap k a -> String
77showTree = coerce (Map.showTree :: Map k a -> String)
75showTree = coerce (Map.showTree :: Map k a -> String)
78
76
79−-- | Displays a 'MonoidalMap' as a tree, using the supplied function to convert nodes to string.
80showTreeWith :: forall k a. (k -> a -> String) -> Bool -> Bool -> MonoidalMap k a -> String
77showTreeWith :: forall k a. (k -> a -> String) -> Bool -> Bool -> MonoidalMap k a -> String
81showTreeWith = coerce (Map.showTreeWith :: (k -> a -> String) -> Bool -> Bool -> Map k a -> String)
78showTreeWith = coerce (Map.showTreeWith :: (k -> a -> String) -> Bool -> Bool -> Map k a -> String)
82
79
src/Data/FastMutableIntMap.hs+2−23
@@ -1,9 +1,4 @@
1{-# LANGUAGE TypeFamilies #-}
1{-# LANGUAGE TypeFamilies #-}
2−-- |
3−-- Module:
4−-- Data.FastMutableIntMap
5−-- Description:
6−-- A mutable version of 'IntMap'
7module Data.FastMutableIntMap
2module Data.FastMutableIntMap
8 ( FastMutableIntMap
3 ( FastMutableIntMap
9 , new
4 , new
@@ -21,7 +16,6 @@ module Data.FastMutableIntMap
21 , patchIntMapNewElements
16 , patchIntMapNewElements
22 , patchIntMapNewElementsMap
17 , patchIntMapNewElementsMap
23 , getDeletions
18 , getDeletions
24− , toList
25 ) where
19 ) where
26
20
27--TODO: Pure JS version
21--TODO: Pure JS version
@@ -35,46 +29,36 @@ import Data.Foldable (traverse_)
35import Data.IntMap.Strict (IntMap)
29import Data.IntMap.Strict (IntMap)
36import qualified Data.IntMap.Strict as IntMap
30import qualified Data.IntMap.Strict as IntMap
37import Data.IORef
31import Data.IORef
38−import Data.Patch.Class
32+import Reflex.Patch.Class
39−import Data.Patch.IntMap
33+import Reflex.Patch.IntMap
40
34
41−-- | A 'FastMutableIntMap' holds a map of values of type @a@ and allows low-overhead modifications via IO.
42−-- Operations on 'FastMutableIntMap' run in IO.
43newtype FastMutableIntMap a = FastMutableIntMap (IORef (IntMap a))
35newtype FastMutableIntMap a = FastMutableIntMap (IORef (IntMap a))
44
36
45−-- | Create a new 'FastMutableIntMap' out of an 'IntMap'
46new :: IntMap a -> IO (FastMutableIntMap a)
37new :: IntMap a -> IO (FastMutableIntMap a)
47new m = FastMutableIntMap <$> newIORef m
38new m = FastMutableIntMap <$> newIORef m
48
39
49−-- | Create a new empty 'FastMutableIntMap'
50newEmpty :: IO (FastMutableIntMap a)
40newEmpty :: IO (FastMutableIntMap a)
51newEmpty = FastMutableIntMap <$> newIORef IntMap.empty
41newEmpty = FastMutableIntMap <$> newIORef IntMap.empty
52
42
53−-- | Insert an element into a 'FastMutableIntMap' at the given key
54insert :: FastMutableIntMap a -> Int -> a -> IO ()
43insert :: FastMutableIntMap a -> Int -> a -> IO ()
55insert (FastMutableIntMap r) k v = modifyIORef' r $ IntMap.insert k v
44insert (FastMutableIntMap r) k v = modifyIORef' r $ IntMap.insert k v
56
45
57−-- | Attempt to lookup an element by key in a 'FastMutableIntMap'
58lookup :: FastMutableIntMap a -> Int -> IO (Maybe a)
46lookup :: FastMutableIntMap a -> Int -> IO (Maybe a)
59lookup (FastMutableIntMap r) k = IntMap.lookup k <$> readIORef r
47lookup (FastMutableIntMap r) k = IntMap.lookup k <$> readIORef r
60
48
61−-- | Runs the provided action over the intersection of a 'FastMutableIntMap' and an 'IntMap'
62forIntersectionWithImmutable_ :: MonadIO m => FastMutableIntMap a -> IntMap b -> (a -> b -> m ()) -> m ()
49forIntersectionWithImmutable_ :: MonadIO m => FastMutableIntMap a -> IntMap b -> (a -> b -> m ()) -> m ()
63forIntersectionWithImmutable_ (FastMutableIntMap r) b f = do
50forIntersectionWithImmutable_ (FastMutableIntMap r) b f = do
64 a <- liftIO $ readIORef r
51 a <- liftIO $ readIORef r
65 traverse_ (uncurry f) $ IntMap.intersectionWith (,) a b
52 traverse_ (uncurry f) $ IntMap.intersectionWith (,) a b
66
53
67−-- | Runs the provided action over the values of a 'FastMutableIntMap'
68for_ :: MonadIO m => FastMutableIntMap a -> (a -> m ()) -> m ()
54for_ :: MonadIO m => FastMutableIntMap a -> (a -> m ()) -> m ()
69for_ (FastMutableIntMap r) f = do
55for_ (FastMutableIntMap r) f = do
70 a <- liftIO $ readIORef r
56 a <- liftIO $ readIORef r
71 traverse_ f a
57 traverse_ f a
72
58
73−-- | Checks whether a 'FastMutableIntMap' is empty
74isEmpty :: FastMutableIntMap a -> IO Bool
59isEmpty :: FastMutableIntMap a -> IO Bool
75isEmpty (FastMutableIntMap r) = IntMap.null <$> readIORef r
60isEmpty (FastMutableIntMap r) = IntMap.null <$> readIORef r
76
61
77−-- | Retrieves the size of a 'FastMutableIntMap'
78size :: FastMutableIntMap a -> IO Int
62size :: FastMutableIntMap a -> IO Int
79size (FastMutableIntMap r) = IntMap.size <$> readIORef r
63size (FastMutableIntMap r) = IntMap.size <$> readIORef r
80
64
@@ -85,13 +69,8 @@ getFrozenAndClear (FastMutableIntMap r) = do
85 writeIORef r IntMap.empty
69 writeIORef r IntMap.empty
86 return result
70 return result
87
71
88−-- | Updates the value of a 'FastMutableIntMap' with the given patch (see 'Data.Patch.IntMap'),
89−-- and returns an 'IntMap' with the modified keys and values.
90applyPatch :: FastMutableIntMap a -> PatchIntMap a -> IO (IntMap a)
72applyPatch :: FastMutableIntMap a -> PatchIntMap a -> IO (IntMap a)
91applyPatch (FastMutableIntMap r) p@(PatchIntMap m) = do
73applyPatch (FastMutableIntMap r) p@(PatchIntMap m) = do
92 v <- readIORef r
74 v <- readIORef r
93 writeIORef r $! applyAlways p v
75 writeIORef r $! applyAlways p v
94 return $ IntMap.intersection v m
76 return $ IntMap.intersection v m
95−
96−toList :: FastMutableIntMap a -> IO [(Int, a)]
97−toList (FastMutableIntMap r) = IntMap.toList <$> readIORef r
src/Data/FastWeakBag.hs+5−10
@@ -18,7 +18,6 @@ module Data.FastWeakBag
18 , isEmpty
18 , isEmpty
19 , insert
19 , insert
20 , traverse
20 , traverse
21− , traverse_
22 , remove
21 , remove
23 -- * Internal functions
22 -- * Internal functions
24 -- These will not always be available.
23 -- These will not always be available.
@@ -51,7 +50,7 @@ newtype FastWeakBag a = FastWeakBag JSVal
51#else
50#else
52data FastWeakBag a = FastWeakBag
51data FastWeakBag a = FastWeakBag
53 { _weakBag_nextId :: {-# UNPACK #-} !(IORef Int) --TODO: what if this wraps around?
52 { _weakBag_nextId :: {-# UNPACK #-} !(IORef Int) --TODO: what if this wraps around?
54− , _weakBag_children :: {-# UNPACK #-} !(IORef (IntMap (Weak a))) -- ^ Map of items contained by the 'FastWeakBag'
53+ , _weakBag_children :: {-# UNPACK #-} !(IORef (IntMap (Weak a)))
55 }
54 }
56#endif
55#endif
57
56
@@ -117,14 +116,14 @@ foreign import javascript unsafe "(function(){ for(var i = 0; i < $1.tickets.len
117isEmpty bag = {-# SCC "isEmpty" #-} IntMap.null <$> readIORef (_weakBag_children bag)
116isEmpty bag = {-# SCC "isEmpty" #-} IntMap.null <$> readIORef (_weakBag_children bag)
118#endif
117#endif
119
118
120−{-# INLINE traverse_ #-}
119+{-# INLINE traverse #-}
121-- | Visit every node in the given list. If new nodes are appended during the
120-- | Visit every node in the given list. If new nodes are appended during the
122-- traversal, they will not be visited. Every live node that was in the list
121-- traversal, they will not be visited. Every live node that was in the list
123-- when the traversal began will be visited exactly once; however, no guarantee
122-- when the traversal began will be visited exactly once; however, no guarantee
124-- is made about the order of the traversal.
123-- is made about the order of the traversal.
125−traverse_ :: forall a m. MonadIO m => FastWeakBag a -> (a -> m ()) -> m ()
124+traverse :: forall a m. MonadIO m => FastWeakBag a -> (a -> m ()) -> m ()
126#ifdef GHCJS_FAST_WEAK
125#ifdef GHCJS_FAST_WEAK
127−traverse_ wb f = do
126+traverse wb f = do
128 let go cursor = when (not $ js_isNull cursor) $ do
127 let go cursor = when (not $ js_isNull cursor) $ do
129 val <- liftIO $ js_getTicketValue cursor
128 val <- liftIO $ js_getTicketValue cursor
130 f $ unsafeFromRawJSVal val
129 f $ unsafeFromRawJSVal val
@@ -135,17 +134,13 @@ foreign import javascript unsafe "$r = $1.val;" js_getTicketValue :: JSVal -> IO
135--TODO: Fix the race condition where if a cursor is deleted (presumably using 'remove', below) while we're holding it, it can't find its way back to the correct bag
134--TODO: Fix the race condition where if a cursor is deleted (presumably using 'remove', below) while we're holding it, it can't find its way back to the correct bag
136foreign import javascript unsafe "(function(){ for(var i = $1.pos - 1; i >= 0; i--) { if($1.bag.tickets[i] !== null) { return $1.bag.tickets[i]; } }; return null; })()" js_getNext :: FastWeakBagTicket a -> IO JSVal --TODO: Clean up as we go along so this isn't O(n) every time -- Result can be null or a FastWeakBagTicket a
135foreign import javascript unsafe "(function(){ for(var i = $1.pos - 1; i >= 0; i--) { if($1.bag.tickets[i] !== null) { return $1.bag.tickets[i]; } }; return null; })()" js_getNext :: FastWeakBagTicket a -> IO JSVal --TODO: Clean up as we go along so this isn't O(n) every time -- Result can be null or a FastWeakBagTicket a
137#else
136#else
138−traverse_ (FastWeakBag _ children) f = {-# SCC "traverse_" #-} do
137+traverse (FastWeakBag _ children) f = {-# SCC "traverse" #-} do
139 cs <- liftIO $ readIORef children
138 cs <- liftIO $ readIORef children
140 forM_ cs $ \c -> do
139 forM_ cs $ \c -> do
141 ma <- liftIO $ deRefWeak c
140 ma <- liftIO $ deRefWeak c
142 mapM_ f ma
141 mapM_ f ma
143#endif
142#endif
144
143
145−{-# DEPRECATED traverse "Use 'traverse_' instead" #-}
146−traverse :: forall a m. MonadIO m => FastWeakBag a -> (a -> m ()) -> m ()
147−traverse = traverse_
148−
149-- | Remove an item from the 'FastWeakBag'; does nothing if invoked multiple times
144-- | Remove an item from the 'FastWeakBag'; does nothing if invoked multiple times
150-- on the same 'FastWeakBagTicket'.
145-- on the same 'FastWeakBagTicket'.
151{-# INLINE remove #-}
146{-# INLINE remove #-}
src/Data/Functor/Misc.hsnew file+287
@@ -0,0 +1,287 @@
1+{-# LANGUAGE CPP #-}
2+{-# LANGUAGE DeriveDataTypeable #-}
3+{-# LANGUAGE DeriveFunctor #-}
4+{-# LANGUAGE FlexibleContexts #-}
5+{-# LANGUAGE FlexibleInstances #-}
6+{-# LANGUAGE GADTs #-}
7+{-# LANGUAGE KindSignatures #-}
8+{-# LANGUAGE LambdaCase #-}
9+{-# LANGUAGE MultiParamTypeClasses #-}
10+{-# LANGUAGE PatternSynonyms #-}
11+{-# LANGUAGE PolyKinds #-}
12+{-# LANGUAGE RankNTypes #-}
13+{-# LANGUAGE ScopedTypeVariables #-}
14+{-# LANGUAGE StandaloneDeriving #-}
15+#ifdef USE_REFLEX_OPTIMIZER
16+{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
17+#endif
18+-- | This module provides types and functions with no particular theme, but
19+-- which are relevant to the use of 'Functor'-based datastructures like
20+-- 'Data.Dependent.Map.DMap'.
21+module Data.Functor.Misc
22+ ( -- * Const2
23+ Const2 (..)
24+ , unConst2
25+ , dmapToMap
26+ , dmapToIntMap
27+ , dmapToMapWith
28+ , mapToDMap
29+ , weakenDMapWith
30+ -- * WrapArg
31+ , WrapArg (..)
32+ -- * Convenience functions for DMap
33+ , mapWithFunctorToDMap
34+ , intMapWithFunctorToDMap
35+ , mapKeyValuePairsMonotonic
36+ , combineDMapsWithKey
37+ , EitherTag (..)
38+ , dmapToThese
39+ , eitherToDSum
40+ , dsumToEither
41+ -- * Deprecated functions
42+ , sequenceDmap
43+ , wrapDMap
44+ , rewrapDMap
45+ , unwrapDMap
46+ , unwrapDMapMaybe
47+ , extractFunctorDMap
48+ , ComposeMaybe (..)
49+ ) where
50+
51+import Control.Applicative (Applicative, (<$>))
52+import Control.Monad.Identity
53+import Data.Dependent.Map (DMap)
54+import qualified Data.Dependent.Map as DMap
55+import Data.Dependent.Sum
56+import Data.GADT.Compare
57+import Data.GADT.Show
58+import Data.IntMap (IntMap)
59+import qualified Data.IntMap as IntMap
60+import Data.Map (Map)
61+import qualified Data.Map as Map
62+import Data.Some (Some)
63+import qualified Data.Some as Some
64+import Data.These
65+import Data.Typeable hiding (Refl)
66+
67+--------------------------------------------------------------------------------
68+-- Const2
69+--------------------------------------------------------------------------------
70+
71+-- | 'Const2' stores a value of a given type 'k' and ensures that a particular
72+-- type 'v' is always given for the last type parameter
73+data Const2 :: * -> x -> x -> * where
74+ Const2 :: k -> Const2 k v v
75+ deriving (Typeable)
76+
77+-- | Extract the value from a Const2
78+unConst2 :: Const2 k v v' -> k
79+unConst2 (Const2 k) = k
80+
81+deriving instance Eq k => Eq (Const2 k v v')
82+deriving instance Ord k => Ord (Const2 k v v')
83+deriving instance Show k => Show (Const2 k v v')
84+deriving instance Read k => Read (Const2 k v v)
85+
86+instance Show k => GShow (Const2 k v) where
87+ gshowsPrec n x@(Const2 _) = showsPrec n x
88+
89+instance (Show k, Show (f v)) => ShowTag (Const2 k v) f where
90+ showTaggedPrec (Const2 _) = showsPrec
91+
92+instance Eq k => GEq (Const2 k v) where
93+ geq (Const2 a) (Const2 b) =
94+ if a == b
95+ then Just Refl
96+ else Nothing
97+
98+instance Ord k => GCompare (Const2 k v) where
99+ gcompare (Const2 a) (Const2 b) = case compare a b of
100+ LT -> GLT
101+ EQ -> GEQ
102+ GT -> GGT
103+
104+-- | Convert a 'DMap' to a regular 'Map'
105+dmapToMap :: DMap (Const2 k v) Identity -> Map k v
106+dmapToMap = Map.fromDistinctAscList . map (\(Const2 k :=> Identity v) -> (k, v)) . DMap.toAscList
107+
108+-- | Convert a 'DMap' to an 'IntMap'
109+dmapToIntMap :: DMap (Const2 IntMap.Key v) Identity -> IntMap v
110+dmapToIntMap = IntMap.fromDistinctAscList . map (\(Const2 k :=> Identity v) -> (k, v)) . DMap.toAscList
111+
112+-- | Convert a 'DMap' to a regular 'Map', applying the given function to remove
113+-- the wrapping 'Functor'
114+dmapToMapWith :: (f v -> v') -> DMap (Const2 k v) f -> Map k v'
115+dmapToMapWith f = Map.fromDistinctAscList . map (\(Const2 k :=> v) -> (k, f v)) . DMap.toAscList
116+
117+-- | Convert a regular 'Map' to a 'DMap'
118+mapToDMap :: Map k v -> DMap (Const2 k v) Identity
119+mapToDMap = DMap.fromDistinctAscList . map (\(k, v) -> Const2 k :=> Identity v) . Map.toAscList
120+
121+-- | Convert a regular 'Map', where the values are already wrapped in a functor,
122+-- to a 'DMap'
123+mapWithFunctorToDMap :: Map k (f v) -> DMap (Const2 k v) f
124+mapWithFunctorToDMap = DMap.fromDistinctAscList . map (\(k, v) -> Const2 k :=> v) . Map.toAscList
125+
126+-- | Convert a regular 'IntMap', where the values are already wrapped in a
127+-- functor, to a 'DMap'
128+intMapWithFunctorToDMap :: IntMap (f v) -> DMap (Const2 IntMap.Key v) f
129+intMapWithFunctorToDMap = DMap.fromDistinctAscList . map (\(k, v) -> Const2 k :=> v) . IntMap.toAscList
130+
131+-- | Convert a 'DMap' to a regular 'Map' by forgetting the types associated with
132+-- the keys, using a function to remove the wrapping 'Functor'
133+weakenDMapWith :: (forall a. v a -> v') -> DMap k v -> Map (Some k) v'
134+weakenDMapWith f = Map.fromDistinctAscList . map (\(k :=> v) -> (Some.This k, f v)) . DMap.toAscList
135+
136+--------------------------------------------------------------------------------
137+-- WrapArg
138+--------------------------------------------------------------------------------
139+
140+-- | 'WrapArg' can be used to tag a value in one functor with a type
141+-- representing another functor. This was primarily used with dependent-map <
142+-- 0.2, in which the value type was not wrapped in a separate functor.
143+data WrapArg :: (k -> *) -> (k -> *) -> * -> * where
144+ WrapArg :: f a -> WrapArg g f (g a)
145+
146+deriving instance Eq (f a) => Eq (WrapArg g f (g' a))
147+deriving instance Ord (f a) => Ord (WrapArg g f (g' a))
148+deriving instance Show (f a) => Show (WrapArg g f (g' a))
149+deriving instance Read (f a) => Read (WrapArg g f (g a))
150+
151+instance GEq f => GEq (WrapArg g f) where
152+ geq (WrapArg a) (WrapArg b) = (\Refl -> Refl) <$> geq a b
153+
154+instance GCompare f => GCompare (WrapArg g f) where
155+ gcompare (WrapArg a) (WrapArg b) = case gcompare a b of
156+ GLT -> GLT
157+ GEQ -> GEQ
158+ GGT -> GGT
159+
160+--------------------------------------------------------------------------------
161+-- Convenience functions for DMap
162+--------------------------------------------------------------------------------
163+
164+-- | Map over all key/value pairs in a 'DMap', potentially altering the key as
165+-- well as the value. The provided function MUST preserve the ordering of the
166+-- keys, or the resulting 'DMap' will be malformed.
167+mapKeyValuePairsMonotonic :: (DSum k v -> DSum k' v') -> DMap k v -> DMap k' v'
168+mapKeyValuePairsMonotonic f = DMap.fromDistinctAscList . map f . DMap.toAscList
169+
170+{-# INLINE combineDMapsWithKey #-}
171+-- | Union two 'DMap's of different types, yielding another type. Each key that
172+-- is present in either input map will be present in the output.
173+combineDMapsWithKey :: forall f g h i.
174+ GCompare f
175+ => (forall a. f a -> These (g a) (h a) -> i a)
176+ -> DMap f g
177+ -> DMap f h
178+ -> DMap f i
179+combineDMapsWithKey f mg mh = DMap.fromList $ go (DMap.toList mg) (DMap.toList mh)
180+ where go :: [DSum f g] -> [DSum f h] -> [DSum f i]
181+ go [] hs = map (\(hk :=> hv) -> hk :=> f hk (That hv)) hs
182+ go gs [] = map (\(gk :=> gv) -> gk :=> f gk (This gv)) gs
183+ go gs@((gk :=> gv) : gs') hs@((hk :=> hv) : hs') = case gk `gcompare` hk of
184+ GLT -> (gk :=> f gk (This gv)) : go gs' hs
185+ GEQ -> (gk :=> f gk (These gv hv)) : go gs' hs'
186+ GGT -> (hk :=> f hk (That hv)) : go gs hs'
187+
188+-- | Extract the values of a 'DMap' of 'EitherTag's.
189+dmapToThese :: DMap (EitherTag a b) Identity -> Maybe (These a b)
190+dmapToThese m = case (DMap.lookup LeftTag m, DMap.lookup RightTag m) of
191+ (Nothing, Nothing) -> Nothing
192+ (Just (Identity a), Nothing) -> Just $ This a
193+ (Nothing, Just (Identity b)) -> Just $ That b
194+ (Just (Identity a), Just (Identity b)) -> Just $ These a b
195+
196+-- | Tag type for 'Either' to use it as a 'DSum'.
197+data EitherTag l r a where
198+ LeftTag :: EitherTag l r l
199+ RightTag :: EitherTag l r r
200+ deriving (Typeable)
201+
202+deriving instance Show (EitherTag l r a)
203+deriving instance Eq (EitherTag l r a)
204+deriving instance Ord (EitherTag l r a)
205+
206+instance GEq (EitherTag l r) where
207+ geq a b = case (a, b) of
208+ (LeftTag, LeftTag) -> Just Refl
209+ (RightTag, RightTag) -> Just Refl
210+ _ -> Nothing
211+
212+instance GCompare (EitherTag l r) where
213+ gcompare a b = case (a, b) of
214+ (LeftTag, LeftTag) -> GEQ
215+ (LeftTag, RightTag) -> GLT
216+ (RightTag, LeftTag) -> GGT
217+ (RightTag, RightTag) -> GEQ
218+
219+instance GShow (EitherTag l r) where
220+ gshowsPrec _ a = case a of
221+ LeftTag -> showString "LeftTag"
222+ RightTag -> showString "RightTag"
223+
224+instance (Show l, Show r) => ShowTag (EitherTag l r) Identity where
225+ showTaggedPrec t n (Identity a) = case t of
226+ LeftTag -> showsPrec n a
227+ RightTag -> showsPrec n a
228+
229+-- | Convert 'Either' to a 'DSum'. Inverse of 'dsumToEither'.
230+eitherToDSum :: Either a b -> DSum (EitherTag a b) Identity
231+eitherToDSum = \case
232+ Left a -> (LeftTag :=> Identity a)
233+ Right b -> (RightTag :=> Identity b)
234+
235+-- | Convert 'DSum' to 'Either'. Inverse of 'eitherToDSum'.
236+dsumToEither :: DSum (EitherTag a b) Identity -> Either a b
237+dsumToEither = \case
238+ (LeftTag :=> Identity a) -> Left a
239+ (RightTag :=> Identity b) -> Right b
240+
241+--------------------------------------------------------------------------------
242+-- ComposeMaybe
243+--------------------------------------------------------------------------------
244+
245+-- | We can't use @Compose Maybe@ instead of 'ComposeMaybe', because that would
246+-- make the 'f' parameter have a nominal type role. We need f to be
247+-- representational so that we can use safe 'coerce'.
248+newtype ComposeMaybe f a =
249+ ComposeMaybe { getComposeMaybe :: Maybe (f a) } deriving (Show, Eq, Ord)
250+
251+deriving instance Functor f => Functor (ComposeMaybe f)
252+
253+--------------------------------------------------------------------------------
254+-- Deprecated functions
255+--------------------------------------------------------------------------------
256+
257+{-# INLINE sequenceDmap #-}
258+{-# DEPRECATED sequenceDmap "Use 'Data.Dependent.Map.traverseWithKey (\\_ -> fmap Identity)' instead" #-}
259+-- | Run the actions contained in the 'DMap'
260+sequenceDmap :: Applicative t => DMap f t -> t (DMap f Identity)
261+sequenceDmap = DMap.traverseWithKey $ \_ t -> Identity <$> t
262+
263+{-# DEPRECATED wrapDMap "Use 'Data.Dependent.Map.map (f . runIdentity)' instead" #-}
264+-- | Replace the 'Identity' functor for a 'DMap''s values with a different functor
265+wrapDMap :: (forall a. a -> f a) -> DMap k Identity -> DMap k f
266+wrapDMap f = DMap.map $ f . runIdentity
267+
268+{-# DEPRECATED rewrapDMap "Use 'Data.Dependent.Map.map' instead" #-}
269+-- | Replace one functor for a 'DMap''s values with a different functor
270+rewrapDMap :: (forall (a :: *). f a -> g a) -> DMap k f -> DMap k g
271+rewrapDMap = DMap.map
272+
273+{-# DEPRECATED unwrapDMap "Use 'Data.Dependent.Map.map (Identity . f)' instead" #-}
274+-- | Replace one functor for a 'DMap''s values with the 'Identity' functor
275+unwrapDMap :: (forall a. f a -> a) -> DMap k f -> DMap k Identity
276+unwrapDMap f = DMap.map $ Identity . f
277+
278+{-# DEPRECATED unwrapDMapMaybe "Use 'Data.Dependent.Map.mapMaybeWithKey (\\_ a -> fmap Identity $ f a)' instead" #-}
279+-- | Like 'unwrapDMap', but possibly delete some values from the DMap
280+unwrapDMapMaybe :: GCompare k => (forall a. f a -> Maybe a) -> DMap k f -> DMap k Identity
281+unwrapDMapMaybe f = DMap.mapMaybeWithKey $ \_ a -> Identity <$> f a
282+
283+{-# DEPRECATED extractFunctorDMap "Use 'mapKeyValuePairsMonotonic (\\(Const2 k :=> Identity v) -> Const2 k :=> v)' instead" #-}
284+-- | Eliminate the 'Identity' functor in a 'DMap' and replace it with the
285+-- underlying functor
286+extractFunctorDMap :: DMap (Const2 k (f v)) Identity -> DMap (Const2 k v) f
287+extractFunctorDMap = mapKeyValuePairsMonotonic $ \(Const2 k :=> Identity v) -> Const2 k :=> v
src/Data/Map/Misc.hs+1−1
@@ -43,7 +43,7 @@ diffMap olds news = flip Map.mapMaybe (align olds news) $ \case
43
43
44-- |Given a @'Map' k (Maybe v)@ representing keys to insert/update (@Just@) or delete (@Nothing@), produce a new map from the given input @'Map' k v@.
44-- |Given a @'Map' k (Maybe v)@ representing keys to insert/update (@Just@) or delete (@Nothing@), produce a new map from the given input @'Map' k v@.
45--
45--
46−-- See also 'Data.Patch.Map' and 'Data.Patch.MapWithMove'.
46+-- See also 'Reflex.Patch.Map' and 'Reflex.Patch.MapWithMove'.
47applyMap :: Ord k => Map k (Maybe v) -> Map k v -> Map k v
47applyMap :: Ord k => Map k (Maybe v) -> Map k v -> Map k v
48applyMap patch old = insertions `Map.union` (old `Map.difference` deletions)
48applyMap patch old = insertions `Map.union` (old `Map.difference` deletions)
49 where (deletions, insertions) = Map.mapEither maybeToEither patch
49 where (deletions, insertions) = Map.mapEither maybeToEither patch
src/Data/WeakBag.hs+3−8
@@ -15,7 +15,6 @@ module Data.WeakBag
15 , singleton
15 , singleton
16 , insert
16 , insert
17 , traverse
17 , traverse
18− , traverse_
19 , remove
18 , remove
20 -- * Internal functions
19 -- * Internal functions
21 -- These will not always be available.
20 -- These will not always be available.
@@ -100,22 +99,18 @@ singleton a wbRef finalizer = {-# SCC "singleton" #-} do
100 ticket <- insert a bag wbRef finalizer
99 ticket <- insert a bag wbRef finalizer
101 return (bag, ticket)
100 return (bag, ticket)
102
101
103−{-# INLINE traverse_ #-}
102+{-# INLINE traverse #-}
104-- | Visit every node in the given list. If new nodes are appended during the
103-- | Visit every node in the given list. If new nodes are appended during the
105-- traversal, they will not be visited. Every live node that was in the list
104-- traversal, they will not be visited. Every live node that was in the list
106-- when the traversal began will be visited exactly once; however, no guarantee
105-- when the traversal began will be visited exactly once; however, no guarantee
107-- is made about the order of the traversal.
106-- is made about the order of the traversal.
108−traverse_ :: MonadIO m => WeakBag a -> (a -> m ()) -> m ()
107+traverse :: MonadIO m => WeakBag a -> (a -> m ()) -> m ()
109−traverse_ (WeakBag _ children) f = {-# SCC "traverse" #-} do
108+traverse (WeakBag _ children) f = {-# SCC "traverse" #-} do
110 cs <- liftIO $ readIORef children
109 cs <- liftIO $ readIORef children
111 forM_ cs $ \c -> do
110 forM_ cs $ \c -> do
112 ma <- liftIO $ deRefWeak c
111 ma <- liftIO $ deRefWeak c
113 mapM_ f ma
112 mapM_ f ma
114
113
115−{-# DEPRECATED traverse "Use 'traverse_' instead" #-}
116−traverse :: MonadIO m => WeakBag a -> (a -> m ()) -> m ()
117−traverse = traverse_
118−
119-- | Remove an item from the 'WeakBag'; does nothing if invoked multiple times
114-- | Remove an item from the 'WeakBag'; does nothing if invoked multiple times
120-- on the same 'WeakBagTicket'.
115-- on the same 'WeakBagTicket'.
121{-# INLINE remove #-}
116{-# INLINE remove #-}
src/Reflex.hs−1
@@ -19,7 +19,6 @@ import Reflex.Dynamic.TH as X
19import Reflex.Dynamic.Uniq as X
19import Reflex.Dynamic.Uniq as X
20import Reflex.DynamicWriter.Base as X
20import Reflex.DynamicWriter.Base as X
21import Reflex.DynamicWriter.Class as X
21import Reflex.DynamicWriter.Class as X
22−import Reflex.NotReady.Class as X
23import Reflex.PerformEvent.Base as X
22import Reflex.PerformEvent.Base as X
24import Reflex.PerformEvent.Class as X
23import Reflex.PerformEvent.Class as X
25import Reflex.PostBuild.Base as X
24import Reflex.PostBuild.Base as X
src/Reflex/Adjustable/Class.hs+6−33
@@ -3,6 +3,7 @@
3{-# LANGUAGE FlexibleInstances #-}
3{-# LANGUAGE FlexibleInstances #-}
4{-# LANGUAGE FunctionalDependencies #-}
4{-# LANGUAGE FunctionalDependencies #-}
5{-# LANGUAGE LambdaCase #-}
5{-# LANGUAGE LambdaCase #-}
6+{-# LANGUAGE MultiParamTypeClasses #-}
6{-# LANGUAGE RankNTypes #-}
7{-# LANGUAGE RankNTypes #-}
7{-# LANGUAGE ScopedTypeVariables #-}
8{-# LANGUAGE ScopedTypeVariables #-}
8{-# LANGUAGE TypeFamilies #-}
9{-# LANGUAGE TypeFamilies #-}
@@ -10,13 +11,6 @@
10#ifdef USE_REFLEX_OPTIMIZER
11#ifdef USE_REFLEX_OPTIMIZER
11{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
12{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
12#endif
13#endif
13−-- |
14−-- Module:
15−-- Reflex.Adjustable.Class
16−-- Description:
17−-- A class for actions that can be "adjusted" over time based on some 'Event'
18−-- such that, when observed after the firing of any such 'Event', the result
19−-- is as though the action was originally run with the 'Event's value.
20module Reflex.Adjustable.Class
14module Reflex.Adjustable.Class
21 (
15 (
22 -- * The Adjustable typeclass
16 -- * The Adjustable typeclass
@@ -30,8 +24,7 @@ module Reflex.Adjustable.Class
30
24
31import Control.Monad.Identity
25import Control.Monad.Identity
32import Control.Monad.Reader
26import Control.Monad.Reader
33−import Data.Dependent.Map (DMap)
27+import Data.Dependent.Map (DMap, GCompare (..))
34−import Data.GADT.Compare (GCompare(..))
35import qualified Data.Dependent.Map as DMap
28import qualified Data.Dependent.Map as DMap
36import Data.Functor.Constant
29import Data.Functor.Constant
37import Data.Functor.Misc
30import Data.Functor.Misc
@@ -40,7 +33,7 @@ import qualified Data.IntMap.Strict as IntMap
40import Data.Map (Map)
33import Data.Map (Map)
41
34
42import Reflex.Class
35import Reflex.Class
43−import Data.Patch.DMapWithMove
36+import Reflex.Patch.DMapWithMove
44
37
45-- | A 'Monad' that supports adjustment over time. After an action has been
38-- | A 'Monad' that supports adjustment over time. After an action has been
46-- run, if the given events fire, it will adjust itself so that its net effect
39-- run, if the given events fire, it will adjust itself so that its net effect
@@ -101,32 +94,13 @@ instance Adjustable t m => Adjustable t (ReaderT r m) where
101 r <- ask
94 r <- ask
102 lift $ traverseDMapWithKeyWithAdjustWithMove (\k v -> runReaderT (f k v) r) dm0 dm'
95 lift $ traverseDMapWithKeyWithAdjustWithMove (\k v -> runReaderT (f k v) r) dm0 dm'
103
96
104−-- | Traverse a 'DMap' of 'Adjustable' actions, running each of them. The provided 'Event' of patches
105−-- to the 'DMap' can add, remove, or update values.
106−sequenceDMapWithAdjust
107− :: (GCompare k, Adjustable t m)
108− => DMap k m
109− -> Event t (PatchDMap k m)
110− -> m (DMap k Identity, Event t (PatchDMap k Identity))
97+sequenceDMapWithAdjust :: (GCompare k, Adjustable t m) => DMap k m -> Event t (PatchDMap k m) -> m (DMap k Identity, Event t (PatchDMap k Identity))
111sequenceDMapWithAdjust = traverseDMapWithKeyWithAdjust $ \_ -> fmap Identity
98sequenceDMapWithAdjust = traverseDMapWithKeyWithAdjust $ \_ -> fmap Identity
112
99
113−-- | Traverses a 'DMap' of 'Adjustable' actions, running each of them. The provided 'Event' of patches
114−-- to the 'DMap' can add, remove, update, move, or swap values.
115−sequenceDMapWithAdjustWithMove
116− :: (GCompare k, Adjustable t m)
117− => DMap k m
118− -> Event t (PatchDMapWithMove k m)
119− -> m (DMap k Identity, Event t (PatchDMapWithMove k Identity))
100+sequenceDMapWithAdjustWithMove :: (GCompare k, Adjustable t m) => DMap k m -> Event t (PatchDMapWithMove k m) -> m (DMap k Identity, Event t (PatchDMapWithMove k Identity))
120sequenceDMapWithAdjustWithMove = traverseDMapWithKeyWithAdjustWithMove $ \_ -> fmap Identity
101sequenceDMapWithAdjustWithMove = traverseDMapWithKeyWithAdjustWithMove $ \_ -> fmap Identity
121
102
122−-- | Traverses a 'Map', running the provided 'Adjustable' action. The provided 'Event' of patches to the 'Map'
123−-- can add, remove, update, move, or swap values.
124−mapMapWithAdjustWithMove
125− :: forall t m k v v'. (Adjustable t m, Ord k)
126− => (k -> v -> m v')
127− -> Map k v
128− -> Event t (PatchMapWithMove k v)
129− -> m (Map k v', Event t (PatchMapWithMove k v'))
103+mapMapWithAdjustWithMove :: forall t m k v v'. (Adjustable t m, Ord k) => (k -> v -> m v') -> Map k v -> Event t (PatchMapWithMove k v) -> m (Map k v', Event t (PatchMapWithMove k v'))
130mapMapWithAdjustWithMove f m0 m' = do
104mapMapWithAdjustWithMove f m0 m' = do
131 (out0 :: DMap (Const2 k v) (Constant v'), out') <- traverseDMapWithKeyWithAdjustWithMove (\(Const2 k) (Identity v) -> Constant <$> f k v) (mapToDMap m0) (const2PatchDMapWithMoveWith Identity <$> m')
105 (out0 :: DMap (Const2 k v) (Constant v'), out') <- traverseDMapWithKeyWithAdjustWithMove (\(Const2 k) (Identity v) -> Constant <$> f k v) (mapToDMap m0) (const2PatchDMapWithMoveWith Identity <$> m')
132 return (dmapToMapWith (\(Constant v') -> v') out0, patchDMapWithMoveToPatchMapWithMoveWith (\(Constant v') -> v') <$> out')
106 return (dmapToMapWith (\(Constant v') -> v') out0, patchDMapWithMoveToPatchMapWithMoveWith (\(Constant v') -> v') <$> out')
@@ -136,5 +110,4 @@ mapMapWithAdjustWithMove f m0 m' = do
136--------------------------------------------------------------------------------
110--------------------------------------------------------------------------------
137
111
138{-# DEPRECATED MonadAdjust "Use Adjustable instead" #-}
112{-# DEPRECATED MonadAdjust "Use Adjustable instead" #-}
139−-- | Synonym for 'Adjustable'
140type MonadAdjust = Adjustable
113type MonadAdjust = Adjustable
src/Reflex/BehaviorWriter/Base.hs+7−16
@@ -1,6 +1,6 @@
1{-|
1{-|
2Module: Reflex.BehaviorWriter.Base
2Module: Reflex.BehaviorWriter.Base
3−Description: Implementation of BehaviorWriter
3+Description: Implementation of MonadBehaviorWriter
4-}
4-}
5{-# LANGUAGE CPP #-}
5{-# LANGUAGE CPP #-}
6{-# LANGUAGE FlexibleInstances #-}
6{-# LANGUAGE FlexibleInstances #-}
@@ -24,7 +24,6 @@ module Reflex.BehaviorWriter.Base
24import Control.Monad.Exception
24import Control.Monad.Exception
25import Control.Monad.Identity
25import Control.Monad.Identity
26import Control.Monad.IO.Class
26import Control.Monad.IO.Class
27−import Control.Monad.Morph
28import Control.Monad.Reader
27import Control.Monad.Reader
29import Control.Monad.Ref
28import Control.Monad.Ref
30import Control.Monad.State.Strict
29import Control.Monad.State.Strict
@@ -47,20 +46,9 @@ import Reflex.Query.Class
47import Reflex.Requester.Class
46import Reflex.Requester.Class
48import Reflex.TriggerEvent.Class
47import Reflex.TriggerEvent.Class
49
48
50−-- | A basic implementation of 'BehaviorWriter'.
49+-- | A basic implementation of 'MonadBehaviorWriter'.
51newtype BehaviorWriterT t w m a = BehaviorWriterT { unBehaviorWriterT :: StateT [Behavior t w] m a }
50newtype BehaviorWriterT t w m a = BehaviorWriterT { unBehaviorWriterT :: StateT [Behavior t w] m a }
52− -- The list is kept in reverse order
51+ deriving (Functor, Applicative, Monad, MonadIO, MonadFix, MonadAsyncException, MonadException) -- The list is kept in reverse order
53− deriving
54− ( Functor
55− , Applicative
56− , Monad
57− , MonadTrans
58− , MFunctor
59− , MonadIO
60− , MonadFix
61− , MonadAsyncException
62− , MonadException
63− )
64
52
65-- | Run a 'BehaviorWriterT' action. The behavior writer output will be provided
53-- | Run a 'BehaviorWriterT' action. The behavior writer output will be provided
66-- along with the result of the action.
54-- along with the result of the action.
@@ -85,6 +73,9 @@ withBehaviorWriterT f dw = do
85deriving instance MonadHold t m => MonadHold t (BehaviorWriterT t w m)
73deriving instance MonadHold t m => MonadHold t (BehaviorWriterT t w m)
86deriving instance MonadSample t m => MonadSample t (BehaviorWriterT t w m)
74deriving instance MonadSample t m => MonadSample t (BehaviorWriterT t w m)
87
75
76+instance MonadTrans (BehaviorWriterT t w) where
77+ lift = BehaviorWriterT . lift
78+
88instance MonadRef m => MonadRef (BehaviorWriterT t w m) where
79instance MonadRef m => MonadRef (BehaviorWriterT t w m) where
89 type Ref (BehaviorWriterT t w m) = Ref m
80 type Ref (BehaviorWriterT t w m) = Ref m
90 newRef = lift . newRef
81 newRef = lift . newRef
@@ -98,7 +89,7 @@ instance MonadReflexCreateTrigger t m => MonadReflexCreateTrigger t (BehaviorWri
98 newEventWithTrigger = lift . newEventWithTrigger
89 newEventWithTrigger = lift . newEventWithTrigger
99 newFanEventWithTrigger f = lift $ newFanEventWithTrigger f
90 newFanEventWithTrigger f = lift $ newFanEventWithTrigger f
100
91
101−instance (Monad m, Monoid w, Reflex t) => BehaviorWriter t w (BehaviorWriterT t w m) where
92+instance (Monad m, Monoid w, Reflex t) => MonadBehaviorWriter t w (BehaviorWriterT t w m) where
102 tellBehavior w = BehaviorWriterT $ modify (w :)
93 tellBehavior w = BehaviorWriterT $ modify (w :)
103
94
104instance MonadReader r m => MonadReader r (BehaviorWriterT t w m) where
95instance MonadReader r m => MonadReader r (BehaviorWriterT t w m) where
src/Reflex/BehaviorWriter/Class.hs+6−11
@@ -1,31 +1,26 @@
1{-|
1{-|
2Module: Reflex.BehaviorWriter.Class
2Module: Reflex.BehaviorWriter.Class
3−Description: This module defines the 'BehaviorWriter' class
3+Description: This module defines the 'MonadBehaviorWriter' class
4-}
4-}
5{-# LANGUAGE CPP #-}
5{-# LANGUAGE CPP #-}
6−{-# LANGUAGE ConstraintKinds #-}
7{-# LANGUAGE FlexibleInstances #-}
6{-# LANGUAGE FlexibleInstances #-}
8{-# LANGUAGE FunctionalDependencies #-}
7{-# LANGUAGE FunctionalDependencies #-}
8+{-# LANGUAGE MultiParamTypeClasses #-}
9{-# LANGUAGE UndecidableInstances #-}
9{-# LANGUAGE UndecidableInstances #-}
10#ifdef USE_REFLEX_OPTIMIZER
10#ifdef USE_REFLEX_OPTIMIZER
11{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
11{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
12#endif
12#endif
13module Reflex.BehaviorWriter.Class
13module Reflex.BehaviorWriter.Class
14− ( MonadBehaviorWriter
14+ ( MonadBehaviorWriter (..)
15− , BehaviorWriter(..)
16 ) where
15 ) where
17
16
18import Control.Monad.Reader (ReaderT, lift)
17import Control.Monad.Reader (ReaderT, lift)
19import Reflex.Class (Behavior)
18import Reflex.Class (Behavior)
20
19
21−{-# DEPRECATED MonadBehaviorWriter "Use 'BehaviorWriter' instead" #-}
22−-- | Type synonym for 'BehaviorWriter'
23−type MonadBehaviorWriter = BehaviorWriter
24−
25−-- | 'BehaviorWriter' efficiently collects 'Behavior' values using 'tellBehavior'
20+-- | 'MonadBehaviorWriter' efficiently collects 'Behavior' values using 'tellBehavior'
26-- and combines them monoidally to provide a 'Behavior' result.
21-- and combines them monoidally to provide a 'Behavior' result.
27−class (Monad m, Monoid w) => BehaviorWriter t w m | m -> t w where
22+class (Monad m, Monoid w) => MonadBehaviorWriter t w m | m -> t w where
28 tellBehavior :: Behavior t w -> m ()
23 tellBehavior :: Behavior t w -> m ()
29
24
30−instance BehaviorWriter t w m => BehaviorWriter t w (ReaderT r m) where
25+instance MonadBehaviorWriter t w m => MonadBehaviorWriter t w (ReaderT r m) where
31 tellBehavior = lift . tellBehavior
26 tellBehavior = lift . tellBehavior
src/Reflex/Class.hs+126−467
@@ -7,6 +7,7 @@
7{-# LANGUAGE FunctionalDependencies #-}
7{-# LANGUAGE FunctionalDependencies #-}
8{-# LANGUAGE GADTs #-}
8{-# LANGUAGE GADTs #-}
9{-# LANGUAGE LambdaCase #-}
9{-# LANGUAGE LambdaCase #-}
10+{-# LANGUAGE MultiParamTypeClasses #-}
10{-# LANGUAGE NoMonomorphismRestriction #-}
11{-# LANGUAGE NoMonomorphismRestriction #-}
11{-# LANGUAGE PolyKinds #-}
12{-# LANGUAGE PolyKinds #-}
12{-# LANGUAGE RankNTypes #-}
13{-# LANGUAGE RankNTypes #-}
@@ -16,41 +17,31 @@
16{-# LANGUAGE TypeFamilies #-}
17{-# LANGUAGE TypeFamilies #-}
17{-# LANGUAGE TypeOperators #-}
18{-# LANGUAGE TypeOperators #-}
18{-# LANGUAGE UndecidableInstances #-}
19{-# LANGUAGE UndecidableInstances #-}
19−{-# LANGUAGE Trustworthy #-}
20#ifdef USE_REFLEX_OPTIMIZER
20#ifdef USE_REFLEX_OPTIMIZER
21{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
21{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
22#endif
22#endif
23
23
24−-- |
25−-- Module:
26−-- Reflex.Class
27−-- Description:
28−-- This module contains the Reflex interface, as well as a variety of
24+-- | This module contains the Reflex interface, as well as a variety of
29−-- convenience functions for working with 'Event's, 'Behavior's, and other
25+-- convenience functions for working with 'Event's, 'Behavior's, and other
30−-- signals.
26+-- signals.
31module Reflex.Class
27module Reflex.Class
32− ( module Data.Patch
28+ ( module Reflex.Patch
33 -- * Primitives
29 -- * Primitives
34 , Reflex (..)
30 , Reflex (..)
35 , mergeInt
31 , mergeInt
36 , coerceBehavior
32 , coerceBehavior
37 , coerceEvent
33 , coerceEvent
38 , coerceDynamic
34 , coerceDynamic
39− , coerceIncremental
40 , MonadSample (..)
35 , MonadSample (..)
41 , MonadHold (..)
36 , MonadHold (..)
42 -- ** 'fan' related types
37 -- ** 'fan' related types
43 , EventSelector (..)
38 , EventSelector (..)
44− , EventSelectorG (..)
45 , EventSelectorInt (..)
39 , EventSelectorInt (..)
46 -- * Convenience functions
40 -- * Convenience functions
47 , constDyn
41 , constDyn
48 , pushAlways
42 , pushAlways
49 -- ** Combining 'Event's
43 -- ** Combining 'Event's
50 , leftmost
44 , leftmost
51− , merge
52− , mergeIncremental
53− , mergeIncrementalWithMove
54 , mergeMap
45 , mergeMap
55 , mergeIntMap
46 , mergeIntMap
56 , mergeMapIncremental
47 , mergeMapIncremental
@@ -65,7 +56,6 @@ module Reflex.Class
65 , alignEventWithMaybe
56 , alignEventWithMaybe
66 -- ** Breaking up 'Event's
57 -- ** Breaking up 'Event's
67 , splitE
58 , splitE
68− , fan
69 , fanEither
59 , fanEither
70 , fanThese
60 , fanThese
71 , fanMap
61 , fanMap
@@ -90,7 +80,6 @@ module Reflex.Class
90 , gate
80 , gate
91 -- ** Combining 'Dynamic's
81 -- ** Combining 'Dynamic's
92 , distributeDMapOverDynPure
82 , distributeDMapOverDynPure
93− , distributeDMapOverDynPureG
94 , distributeListOverDyn
83 , distributeListOverDyn
95 , distributeListOverDynWith
84 , distributeListOverDynWith
96 , zipDyn
85 , zipDyn
@@ -144,10 +133,8 @@ module Reflex.Class
144 -- * Unsafe functions
133 -- * Unsafe functions
145 , unsafeDynamic
134 , unsafeDynamic
146 , unsafeMapIncremental
135 , unsafeMapIncremental
147− -- * 'Filterable' convenience functions
136+ -- * 'FunctorMaybe'
148− , FunctorMaybe -- fmapMaybe is purposely not exported from deprecated 'FunctorMaybe' and the new alias is exported instead
137+ , FunctorMaybe (..)
149− , mapMaybe -- Re-exported for convenience
150− , fmapMaybe
151 , fforMaybe
138 , fforMaybe
152 , ffilter
139 , ffilter
153 , filterLeft
140 , filterLeft
@@ -157,11 +144,10 @@ module Reflex.Class
157 , ffor2
144 , ffor2
158 , ffor3
145 , ffor3
159 -- * Deprecated functions
146 -- * Deprecated functions
160− , switchPromptly
147+ , appendEvents
161− , switchPromptOnly
148+ , onceE
162− -- * "Cheap" functions
149+ , sequenceThese
163 , fmapMaybeCheap
150 , fmapMaybeCheap
164− , mapMaybeCheap
165 , fmapCheap
151 , fmapCheap
166 , fforCheap
152 , fforCheap
167 , fforMaybeCheap
153 , fforMaybeCheap
@@ -169,21 +155,12 @@ module Reflex.Class
169 , tagCheap
155 , tagCheap
170 , mergeWithCheap
156 , mergeWithCheap
171 , mergeWithCheap'
157 , mergeWithCheap'
158+ , switchPromptly
159+ , switchPromptOnly
172 -- * Slow, but general, implementations
160 -- * Slow, but general, implementations
173 , slowHeadE
161 , slowHeadE
174 ) where
162 ) where
175
163
176−#ifdef MIN_VERSION_semialign
177−import Prelude hiding (zip, zipWith)
178−
179−#if MIN_VERSION_these(0,8,0)
180−import Data.These.Combinators (justThese)
181−#endif
182−#if MIN_VERSION_semialign(1,1,0)
183−import Data.Zip (Zip (..), Unzip (..))
184−#endif
185−#endif
186−
187import Control.Applicative
164import Control.Applicative
188import Control.Monad.Identity
165import Control.Monad.Identity
189import Control.Monad.Reader
166import Control.Monad.Reader
@@ -196,12 +173,11 @@ import Data.Align
196import Data.Bifunctor
173import Data.Bifunctor
197import Data.Coerce
174import Data.Coerce
198import Data.Default
175import Data.Default
199−import Data.Dependent.Map (DMap)
176+import Data.Dependent.Map (DMap, DSum (..))
200−import Data.Dependent.Sum (DSum (..))
201import qualified Data.Dependent.Map as DMap
177import qualified Data.Dependent.Map as DMap
202import Data.Functor.Compose
178import Data.Functor.Compose
203import Data.Functor.Product
179import Data.Functor.Product
204−import Data.GADT.Compare (GEq (..), GCompare (..))
180+import Data.GADT.Compare (GEq (..), GCompare (..), (:~:) (..))
205import Data.FastMutableIntMap (PatchIntMap)
181import Data.FastMutableIntMap (PatchIntMap)
206import Data.Foldable
182import Data.Foldable
207import Data.Functor.Bind
183import Data.Functor.Bind
@@ -211,18 +187,15 @@ import Data.IntMap.Strict (IntMap)
211import qualified Data.IntMap.Strict as IntMap
187import qualified Data.IntMap.Strict as IntMap
212import Data.List.NonEmpty (NonEmpty (..))
188import Data.List.NonEmpty (NonEmpty (..))
213import Data.Map (Map)
189import Data.Map (Map)
214−import Data.Semigroup (Semigroup (..))
190+import Data.Semigroup (Semigroup, sconcat, stimes, (<>))
215−import Data.Some (Some(Some))
191+import Data.Some (Some)
192+import qualified Data.Some as Some
216import Data.String
193import Data.String
217import Data.These
194import Data.These
218import Data.Type.Coercion
195import Data.Type.Coercion
219−import Data.Type.Equality ((:~:) (..))
220−import Data.Witherable (Filterable(..))
221−import qualified Data.Witherable as W
222−import Reflex.FunctorMaybe (FunctorMaybe)
196+import Reflex.FunctorMaybe
223−import qualified Reflex.FunctorMaybe
197+import Reflex.Patch
224−import Data.Patch
225−import qualified Data.Patch.MapWithMove as PatchMapWithMove
198+import qualified Reflex.Patch.MapWithMove as PatchMapWithMove
226
199
227import Debug.Trace (trace)
200import Debug.Trace (trace)
228
201
@@ -275,21 +248,16 @@ class ( MonadHold t (PushM t)
275 -- | Merge a collection of events; the resulting 'Event' will only occur if at
248 -- | Merge a collection of events; the resulting 'Event' will only occur if at
276 -- least one input event is occurring, and will contain all of the input keys
249 -- least one input event is occurring, and will contain all of the input keys
277 -- that are occurring simultaneously
250 -- that are occurring simultaneously
278−
279− --TODO: Generalize to get rid of DMap use --TODO: Provide a type-level guarantee that the result is not empty
251+ merge :: GCompare k => DMap k (Event t) -> Event t (DMap k Identity) --TODO: Generalize to get rid of DMap use --TODO: Provide a type-level guarantee that the result is not empty
280− mergeG :: GCompare k => (forall a. q a -> Event t (v a))
281− -> DMap k q -> Event t (DMap k v)
282−
283− -- | Efficiently fan-out an event to many destinations. You should save the
252+ -- | Efficiently fan-out an event to many destinations. This function should
284− -- result in a @let@-binding, and then repeatedly 'selectG' on the result to
253+ -- be partially applied, and then the result applied repeatedly to create
285− -- create child events
254+ -- child events
286− fanG :: GCompare k => Event t (DMap k v) -> EventSelectorG t k v
255+ fan :: GCompare k => Event t (DMap k Identity) -> EventSelector t k --TODO: Can we help enforce the partial application discipline here? The combinator is worthless without it
287−
288 -- | Create an 'Event' that will occur whenever the currently-selected input
256 -- | Create an 'Event' that will occur whenever the currently-selected input
289 -- 'Event' occurs
257 -- 'Event' occurs
290 switch :: Behavior t (Event t a) -> Event t a
258 switch :: Behavior t (Event t a) -> Event t a
291− -- | Create an 'Event' that will occur whenever the input event is occurring -- and its occurrence value, another 'Event', is also occurring.
259+ -- | Create an 'Event' that will occur whenever the input event is occurring
292− -- You maybe looking for '@switchHold@ @never@' instead.
260+ -- and its occurrence value, another 'Event', is also occurring
293 coincidence :: Event t (Event t a) -> Event t a
261 coincidence :: Event t (Event t a) -> Event t a
294 -- | Extract the 'Behavior' of a 'Dynamic'.
262 -- | Extract the 'Behavior' of a 'Dynamic'.
295 current :: Dynamic t a -> Behavior t a
263 current :: Dynamic t a -> Behavior t a
@@ -303,14 +271,9 @@ class ( MonadHold t (PushM t)
303 -- that value.
271 -- that value.
304 unsafeBuildIncremental :: Patch p => PullM t (PatchTarget p) -> Event t p -> Incremental t p
272 unsafeBuildIncremental :: Patch p => PullM t (PatchTarget p) -> Event t p -> Incremental t p
305 -- | Create a merge whose parents can change over time
273 -- | Create a merge whose parents can change over time
306− mergeIncrementalG :: GCompare k
307− => (forall a. q a -> Event t (v a))
308− -> Incremental t (PatchDMap k q)
274+ mergeIncremental :: GCompare k => Incremental t (PatchDMap k (Event t)) -> Event t (DMap k Identity)
309− -> Event t (DMap k v)
310 -- | Experimental: Create a merge whose parents can change over time; changing the key of an Event is more efficient than with mergeIncremental
275 -- | Experimental: Create a merge whose parents can change over time; changing the key of an Event is more efficient than with mergeIncremental
311− mergeIncrementalWithMoveG :: GCompare k
312− => (forall a. q a -> Event t (v a))
313− -> Incremental t (PatchDMapWithMove k q) -> Event t (DMap k v)
276+ mergeIncrementalWithMove :: GCompare k => Incremental t (PatchDMapWithMove k (Event t)) -> Event t (DMap k Identity)
314 -- | Extract the 'Behavior' component of an 'Incremental'
277 -- | Extract the 'Behavior' component of an 'Incremental'
315 currentIncremental :: Patch p => Incremental t p -> Behavior t (PatchTarget p)
278 currentIncremental :: Patch p => Incremental t p -> Behavior t (PatchTarget p)
316 -- | Extract the 'Event' component of an 'Incremental'
279 -- | Extract the 'Event' component of an 'Incremental'
@@ -326,28 +289,10 @@ class ( MonadHold t (PushM t)
326 -- | Construct a 'Coercion' for a 'Dynamic' given an 'Coercion' for its
289 -- | Construct a 'Coercion' for a 'Dynamic' given an 'Coercion' for its
327 -- occurrence type
290 -- occurrence type
328 dynamicCoercion :: Coercion a b -> Coercion (Dynamic t a) (Dynamic t b)
291 dynamicCoercion :: Coercion a b -> Coercion (Dynamic t a) (Dynamic t b)
329− -- | Construct a 'Coercion' for an 'Incremental' given 'Coercion's for its
330− -- patch target and patch types.
331− incrementalCoercion
332− :: Coercion (PatchTarget a) (PatchTarget b) -> Coercion a b -> Coercion (Incremental t a) (Incremental t b)
333 mergeIntIncremental :: Incremental t (PatchIntMap (Event t a)) -> Event t (IntMap a)
292 mergeIntIncremental :: Incremental t (PatchIntMap (Event t a)) -> Event t (IntMap a)
334 fanInt :: Event t (IntMap a) -> EventSelectorInt t a
293 fanInt :: Event t (IntMap a) -> EventSelectorInt t a
335
294
336−-- | Efficiently fan-out an event to many destinations. You should save the
337−-- result in a @let@-binding, and then repeatedly 'select' on the result to
338−-- create child events
339−fan :: forall t k. (Reflex t, GCompare k)
340− => Event t (DMap k Identity) -> EventSelector t k
341− --TODO: Can we help enforce the partial application discipline here? The combinator is worthless without it
342−fan e = EventSelector (fixup (selectG (fanG e) :: k a -> Event t (Identity a)) :: forall a. k a -> Event t a)
343− where
344− fixup :: forall a. (k a -> Event t (Identity a)) -> k a -> Event t a
345− fixup = case eventCoercion Coercion :: Coercion (Event t (Identity a)) (Event t a) of
346− Coercion -> coerce
347−
348--TODO: Specialize this so that we can take advantage of knowing that there's no changing going on
295--TODO: Specialize this so that we can take advantage of knowing that there's no changing going on
349−-- | Constructs a single 'Event' out of a map of events. The output event may fire with multiple
350−-- keys simultaneously.
351mergeInt :: Reflex t => IntMap (Event t a) -> Event t (IntMap a)
296mergeInt :: Reflex t => IntMap (Event t a) -> Event t (IntMap a)
352mergeInt m = mergeIntIncremental $ unsafeBuildIncremental (return m) never
297mergeInt m = mergeIntIncremental $ unsafeBuildIncremental (return m) never
353
298
@@ -363,12 +308,6 @@ coerceEvent = coerceWith $ eventCoercion Coercion
363coerceDynamic :: (Reflex t, Coercible a b) => Dynamic t a -> Dynamic t b
308coerceDynamic :: (Reflex t, Coercible a b) => Dynamic t a -> Dynamic t b
364coerceDynamic = coerceWith $ dynamicCoercion Coercion
309coerceDynamic = coerceWith $ dynamicCoercion Coercion
365
310
366−-- | Coerce an 'Incremental' between representationally-equivalent value types
367−coerceIncremental
368− :: (Reflex t, Coercible a b, Coercible (PatchTarget a) (PatchTarget b))
369− => Incremental t a -> Incremental t b
370−coerceIncremental = coerceWith $ incrementalCoercion Coercion Coercion
371−
372-- | Construct a 'Dynamic' from a 'Behavior' and an 'Event'. The 'Behavior'
311-- | Construct a 'Dynamic' from a 'Behavior' and an 'Event'. The 'Behavior'
373-- __must__ change when and only when the 'Event' fires, such that the
312-- __must__ change when and only when the 'Event' fires, such that the
374-- 'Behavior''s value is always equal to the most recent firing of the 'Event';
313-- 'Behavior''s value is always equal to the most recent firing of the 'Event';
@@ -421,99 +360,27 @@ class MonadSample t m => MonadHold t m where
421 -- | Create a new 'Event' that only occurs only once, on the first occurrence of
360 -- | Create a new 'Event' that only occurs only once, on the first occurrence of
422 -- the supplied 'Event'.
361 -- the supplied 'Event'.
423 headE :: Event t a -> m (Event t a)
362 headE :: Event t a -> m (Event t a)
424− -- | An event which only occurs at the current moment in time, such that:
425− --
426− -- > coincidence (pushAlways (\a -> (a <$) <$> now) e) = e
427− --
428− now :: m (Event t ())
429− default now :: (m ~ f m', MonadTrans f, MonadHold t m') => m (Event t ())
430− now = lift now
431−
432−-- | Accumulate an 'Incremental' with the supplied initial value and the firings of the provided 'Event',
433−-- using the combining function to produce a patch.
434−accumIncremental
435− :: (Reflex t, Patch p, MonadHold t m, MonadFix m)
436− => (PatchTarget p -> b -> p)
437− -> PatchTarget p
438− -> Event t b
439− -> m (Incremental t p)
440−accumIncremental f = accumMaybeIncremental $ \v o -> Just $ f v o
441
363
442−-- | Similar to 'accumIncremental' but the combining function runs in 'PushM'
364+accumIncremental :: (Reflex t, Patch p, MonadHold t m, MonadFix m) => (PatchTarget p -> b -> p) -> PatchTarget p -> Event t b -> m (Incremental t p)
443−accumMIncremental
365+accumIncremental f = accumMaybeIncremental $ \v o -> Just $ f v o
444− :: (Reflex t, Patch p, MonadHold t m, MonadFix m)
366+accumMIncremental :: (Reflex t, Patch p, MonadHold t m, MonadFix m) => (PatchTarget p -> b -> PushM t p) -> PatchTarget p -> Event t b -> m (Incremental t p)
445− => (PatchTarget p -> b -> PushM t p)
446− -> PatchTarget p
447− -> Event t b
448− -> m (Incremental t p)
449accumMIncremental f = accumMaybeMIncremental $ \v o -> Just <$> f v o
367accumMIncremental f = accumMaybeMIncremental $ \v o -> Just <$> f v o
450−
451−-- | Similar to 'accumIncremental' but allows filtering of updates (by dropping updates when the
452−-- combining function produces @Nothing@)
453−accumMaybeIncremental
454− :: (Reflex t, Patch p, MonadHold t m, MonadFix m)
368+accumMaybeIncremental :: (Reflex t, Patch p, MonadHold t m, MonadFix m) => (PatchTarget p -> b -> Maybe p) -> PatchTarget p -> Event t b -> m (Incremental t p)
455− => (PatchTarget p -> b -> Maybe p)
456− -> PatchTarget p
457− -> Event t b
458− -> m (Incremental t p)
459accumMaybeIncremental f = accumMaybeMIncremental $ \v o -> return $ f v o
369accumMaybeIncremental f = accumMaybeMIncremental $ \v o -> return $ f v o
460−
461−-- | Similar to 'accumMaybeMIncremental' but the combining function runs in 'PushM'
462−accumMaybeMIncremental
463− :: (Reflex t, Patch p, MonadHold t m, MonadFix m)
370+accumMaybeMIncremental :: (Reflex t, Patch p, MonadHold t m, MonadFix m) => (PatchTarget p -> b -> PushM t (Maybe p)) -> PatchTarget p -> Event t b -> m (Incremental t p)
464− => (PatchTarget p -> b -> PushM t (Maybe p))
465− -> PatchTarget p
466− -> Event t b
467− -> m (Incremental t p)
468accumMaybeMIncremental f z e = do
371accumMaybeMIncremental f z e = do
469 rec let e' = flip push e $ \o -> do
372 rec let e' = flip push e $ \o -> do
470 v <- sample $ currentIncremental d'
373 v <- sample $ currentIncremental d'
471 f v o
374 f v o
472 d' <- holdIncremental z e'
375 d' <- holdIncremental z e'
473 return d'
376 return d'
474−
475−-- | Accumulate an 'Incremental' by folding occurrences of an 'Event'
476−-- with a function that both accumulates and produces a value to fire
477−-- as an 'Event'. Returns both the accumulated value and the constructed
478−-- 'Event'.
479−mapAccumIncremental
480− :: (Reflex t, Patch p, MonadHold t m, MonadFix m)
377+mapAccumIncremental :: (Reflex t, Patch p, MonadHold t m, MonadFix m) => (PatchTarget p -> b -> (p, c)) -> PatchTarget p -> Event t b -> m (Incremental t p, Event t c)
481− => (PatchTarget p -> b -> (p, c))
482− -> PatchTarget p
483− -> Event t b
484− -> m (Incremental t p, Event t c)
485mapAccumIncremental f = mapAccumMaybeIncremental $ \v o -> bimap Just Just $ f v o
378mapAccumIncremental f = mapAccumMaybeIncremental $ \v o -> bimap Just Just $ f v o
486−
487−-- | Like 'mapAccumIncremental' but the combining function runs in 'PushM'
488−mapAccumMIncremental
489− :: (Reflex t, Patch p, MonadHold t m, MonadFix m)
379+mapAccumMIncremental :: (Reflex t, Patch p, MonadHold t m, MonadFix m) => (PatchTarget p -> b -> PushM t (p, c)) -> PatchTarget p -> Event t b -> m (Incremental t p, Event t c)
490− => (PatchTarget p -> b -> PushM t (p, c))
491− -> PatchTarget p
492− -> Event t b
493− -> m (Incremental t p, Event t c)
494mapAccumMIncremental f = mapAccumMaybeMIncremental $ \v o -> bimap Just Just <$> f v o
380mapAccumMIncremental f = mapAccumMaybeMIncremental $ \v o -> bimap Just Just <$> f v o
495−
496−-- | Accumulate an 'Incremental' by folding occurrences of an 'Event' with
497−-- a function that both optionally accumulates and optionally produces
498−-- a value to fire as a separate output 'Event'.
499−-- Note that because 'Nothing's are discarded in both cases, the output
500−-- 'Event' may fire even though the output 'Incremental' has not changed, and
501−-- the output 'Incremental' may update even when the output 'Event' is not firing.
502−mapAccumMaybeIncremental
503− :: (Reflex t, Patch p, MonadHold t m, MonadFix m)
381+mapAccumMaybeIncremental :: (Reflex t, Patch p, MonadHold t m, MonadFix m) => (PatchTarget p -> b -> (Maybe p, Maybe c)) -> PatchTarget p -> Event t b -> m (Incremental t p, Event t c)
504− => (PatchTarget p -> b -> (Maybe p, Maybe c))
505− -> PatchTarget p
506− -> Event t b
507− -> m (Incremental t p, Event t c)
508mapAccumMaybeIncremental f = mapAccumMaybeMIncremental $ \v o -> return $ f v o
382mapAccumMaybeIncremental f = mapAccumMaybeMIncremental $ \v o -> return $ f v o
509−
510−-- | Like 'mapAccumMaybeIncremental' but the combining function is a 'PushM' action
511−mapAccumMaybeMIncremental
512− :: (Reflex t, Patch p, MonadHold t m, MonadFix m)
383+mapAccumMaybeMIncremental :: (Reflex t, Patch p, MonadHold t m, MonadFix m) => (PatchTarget p -> b -> PushM t (Maybe p, Maybe c)) -> PatchTarget p -> Event t b -> m (Incremental t p, Event t c)
513− => (PatchTarget p -> b -> PushM t (Maybe p, Maybe c))
514− -> PatchTarget p
515− -> Event t b
516− -> m (Incremental t p, Event t c)
517mapAccumMaybeMIncremental f z e = do
384mapAccumMaybeMIncremental f z e = do
518 rec let e' = flip push e $ \o -> do
385 rec let e' = flip push e $ \o -> do
519 v <- sample $ currentIncremental d'
386 v <- sample $ currentIncremental d'
@@ -521,10 +388,9 @@ mapAccumMaybeMIncremental f z e = do
521 return $ case result of
388 return $ case result of
522 (Nothing, Nothing) -> Nothing
389 (Nothing, Nothing) -> Nothing
523 _ -> Just result
390 _ -> Just result
524− d' <- holdIncremental z $ mapMaybe fst e'
391+ d' <- holdIncremental z $ fmapMaybe fst e'
525− return (d', mapMaybe snd e')
392+ return (d', fmapMaybe snd e')
526
393
527−-- | A somewhat slow implementation of 'headE'
528slowHeadE :: (Reflex t, MonadHold t m, MonadFix m) => Event t a -> m (Event t a)
394slowHeadE :: (Reflex t, MonadHold t m, MonadFix m) => Event t a -> m (Event t a)
529slowHeadE e = do
395slowHeadE e = do
530 rec be <- hold e $ fmapCheap (const never) e'
396 rec be <- hold e $ fmapCheap (const never) e'
@@ -533,31 +399,18 @@ slowHeadE e = do
533
399
534-- | An 'EventSelector' allows you to efficiently 'select' an 'Event' based on a
400-- | An 'EventSelector' allows you to efficiently 'select' an 'Event' based on a
535-- key. This is much more efficient than filtering for each key with
401-- key. This is much more efficient than filtering for each key with
536−-- 'mapMaybe'.
402+-- 'fmapMaybe'.
537newtype EventSelector t k = EventSelector
403newtype EventSelector t k = EventSelector
538 { -- | Retrieve the 'Event' for the given key. The type of the 'Event' is
404 { -- | Retrieve the 'Event' for the given key. The type of the 'Event' is
539 -- determined by the type of the key, so this can be used to fan-out
405 -- determined by the type of the key, so this can be used to fan-out
540 -- 'Event's whose sub-'Event's have different types.
406 -- 'Event's whose sub-'Event's have different types.
541 --
407 --
542 -- Using 'EventSelector's and the 'fan' primitive is far more efficient than
408 -- Using 'EventSelector's and the 'fan' primitive is far more efficient than
543− -- (but equivalent to) using 'mapMaybe' to select only the relevant
409+ -- (but equivalent to) using 'fmapMaybe' to select only the relevant
544 -- occurrences of an 'Event'.
410 -- occurrences of an 'Event'.
545 select :: forall a. k a -> Event t a
411 select :: forall a. k a -> Event t a
546 }
412 }
547
413
548−newtype EventSelectorG t k v = EventSelectorG
549− { -- | Retrieve the 'Event' for the given key. The type of the 'Event' is
550− -- determined by the type of the key, so this can be used to fan-out
551− -- 'Event's whose sub-'Event's have different types.
552− --
553− -- Using 'EventSelector's and the 'fan' primitive is far more efficient than
554− -- (but equivalent to) using 'mapMaybe' to select only the relevant
555− -- occurrences of an 'Event'.
556− selectG :: forall a. k a -> Event t (v a)
557− }
558−
559−-- | Efficiently select an 'Event' keyed on 'Int'. This is more efficient than manually
560−-- filtering by key.
561newtype EventSelectorInt t a = EventSelectorInt { selectInt :: Int -> Event t a }
414newtype EventSelectorInt t a = EventSelectorInt { selectInt :: Int -> Event t a }
562
415
563--------------------------------------------------------------------------------
416--------------------------------------------------------------------------------
@@ -573,7 +426,6 @@ instance MonadHold t m => MonadHold t (ReaderT r m) where
573 holdIncremental a0 = lift . holdIncremental a0
426 holdIncremental a0 = lift . holdIncremental a0
574 buildDynamic a0 = lift . buildDynamic a0
427 buildDynamic a0 = lift . buildDynamic a0
575 headE = lift . headE
428 headE = lift . headE
576− now = lift now
577
429
578instance (MonadSample t m, Monoid r) => MonadSample t (WriterT r m) where
430instance (MonadSample t m, Monoid r) => MonadSample t (WriterT r m) where
579 sample = lift . sample
431 sample = lift . sample
@@ -584,7 +436,6 @@ instance (MonadHold t m, Monoid r) => MonadHold t (WriterT r m) where
584 holdIncremental a0 = lift . holdIncremental a0
436 holdIncremental a0 = lift . holdIncremental a0
585 buildDynamic a0 = lift . buildDynamic a0
437 buildDynamic a0 = lift . buildDynamic a0
586 headE = lift . headE
438 headE = lift . headE
587− now = lift now
588
439
589instance MonadSample t m => MonadSample t (StateT s m) where
440instance MonadSample t m => MonadSample t (StateT s m) where
590 sample = lift . sample
441 sample = lift . sample
@@ -595,7 +446,6 @@ instance MonadHold t m => MonadHold t (StateT s m) where
595 holdIncremental a0 = lift . holdIncremental a0
446 holdIncremental a0 = lift . holdIncremental a0
596 buildDynamic a0 = lift . buildDynamic a0
447 buildDynamic a0 = lift . buildDynamic a0
597 headE = lift . headE
448 headE = lift . headE
598− now = lift now
599
449
600instance MonadSample t m => MonadSample t (ExceptT e m) where
450instance MonadSample t m => MonadSample t (ExceptT e m) where
601 sample = lift . sample
451 sample = lift . sample
@@ -606,7 +456,6 @@ instance MonadHold t m => MonadHold t (ExceptT e m) where
606 holdIncremental a0 = lift . holdIncremental a0
456 holdIncremental a0 = lift . holdIncremental a0
607 buildDynamic a0 = lift . buildDynamic a0
457 buildDynamic a0 = lift . buildDynamic a0
608 headE = lift . headE
458 headE = lift . headE
609− now = lift now
610
459
611instance (MonadSample t m, Monoid w) => MonadSample t (RWST r w s m) where
460instance (MonadSample t m, Monoid w) => MonadSample t (RWST r w s m) where
612 sample = lift . sample
461 sample = lift . sample
@@ -617,7 +466,6 @@ instance (MonadHold t m, Monoid w) => MonadHold t (RWST r w s m) where
617 holdIncremental a0 = lift . holdIncremental a0
466 holdIncremental a0 = lift . holdIncremental a0
618 buildDynamic a0 = lift . buildDynamic a0
467 buildDynamic a0 = lift . buildDynamic a0
619 headE = lift . headE
468 headE = lift . headE
620− now = lift now
621
469
622instance MonadSample t m => MonadSample t (ContT r m) where
470instance MonadSample t m => MonadSample t (ContT r m) where
623 sample = lift . sample
471 sample = lift . sample
@@ -628,7 +476,6 @@ instance MonadHold t m => MonadHold t (ContT r m) where
628 holdIncremental a0 = lift . holdIncremental a0
476 holdIncremental a0 = lift . holdIncremental a0
629 buildDynamic a0 = lift . buildDynamic a0
477 buildDynamic a0 = lift . buildDynamic a0
630 headE = lift . headE
478 headE = lift . headE
631− now = lift now
632
479
633--------------------------------------------------------------------------------
480--------------------------------------------------------------------------------
634-- Convenience functions
481-- Convenience functions
@@ -678,9 +525,7 @@ instance Reflex t => Monad (Behavior t) where
678 a >>= f = pull $ sample a >>= sample . f
525 a >>= f = pull $ sample a >>= sample . f
679 -- Note: it is tempting to write (_ >> b = b); however, this would result in (fail x >> return y) succeeding (returning y), which violates the law that (a >> b = a >>= \_ -> b), since the implementation of (>>=) above actually will fail. Since we can't examine 'Behavior's other than by using sample, I don't think it's possible to write (>>) to be more efficient than the (>>=) above.
526 -- Note: it is tempting to write (_ >> b = b); however, this would result in (fail x >> return y) succeeding (returning y), which violates the law that (a >> b = a >>= \_ -> b), since the implementation of (>>=) above actually will fail. Since we can't examine 'Behavior's other than by using sample, I don't think it's possible to write (>>) to be more efficient than the (>>=) above.
680 return = constant
527 return = constant
681−#if !MIN_VERSION_base(4,13,0)
682 fail = error "Monad (Behavior t) does not support fail"
528 fail = error "Monad (Behavior t) does not support fail"
683−#endif
684
529
685instance (Reflex t, Monoid a) => Monoid (Behavior t a) where
530instance (Reflex t, Monoid a) => Monoid (Behavior t a) where
686 mempty = constant mempty
531 mempty = constant mempty
@@ -696,51 +541,40 @@ instance (Reflex t, Num a) => Num (Behavior t a) where
696 negate = fmap negate
541 negate = fmap negate
697 signum = fmap signum
542 signum = fmap signum
698
543
699−instance (Num a, Reflex t) => Num (Dynamic t a) where
700− (+) = liftA2 (+)
701− (*) = liftA2 (*)
702− abs = fmap abs
703− signum = fmap signum
704− fromInteger = pure . fromInteger
705− negate = fmap negate
706− (-) = liftA2 (-)
707−
708instance (Reflex t, Semigroup a) => Semigroup (Behavior t a) where
544instance (Reflex t, Semigroup a) => Semigroup (Behavior t a) where
709 a <> b = pull $ liftM2 (<>) (sample a) (sample b)
545 a <> b = pull $ liftM2 (<>) (sample a) (sample b)
710 sconcat = pull . fmap sconcat . mapM sample
546 sconcat = pull . fmap sconcat . mapM sample
547+#if MIN_VERSION_semigroups(0,17,0)
711 stimes n = fmap $ stimes n
548 stimes n = fmap $ stimes n
549+#else
550+ times1p n = fmap $ times1p n
551+#endif
712
552
713−-- | Alias for 'mapMaybe'
714−fmapMaybe :: Filterable f => (a -> Maybe b) -> f a -> f b
715−fmapMaybe = mapMaybe
716−
717−-- | Flipped version of 'mapMaybe'.
553+-- | Flipped version of 'fmapMaybe'.
718−fforMaybe :: Filterable f => f a -> (a -> Maybe b) -> f b
554+fforMaybe :: FunctorMaybe f => f a -> (a -> Maybe b) -> f b
719−fforMaybe = flip mapMaybe
555+fforMaybe = flip fmapMaybe
720
556
721-- | Filter 'f a' using the provided predicate.
557-- | Filter 'f a' using the provided predicate.
558+-- Relies on 'fforMaybe'.
722−ffilter :: Filterable f => (a -> Bool) -> f a -> f a
559+ffilter :: FunctorMaybe f => (a -> Bool) -> f a -> f a
723−ffilter = W.filter
560+ffilter f = fmapMaybe $ \x -> if f x then Just x else Nothing
724
561
725-- | Filter 'Left's from 'f (Either a b)' into 'a'.
562-- | Filter 'Left's from 'f (Either a b)' into 'a'.
726−filterLeft :: Filterable f => f (Either a b) -> f a
563+filterLeft :: FunctorMaybe f => f (Either a b) -> f a
727−filterLeft = mapMaybe (either Just (const Nothing))
564+filterLeft = fmapMaybe (either Just (const Nothing))
728
565
729-- | Filter 'Right's from 'f (Either a b)' into 'b'.
566-- | Filter 'Right's from 'f (Either a b)' into 'b'.
730−filterRight :: Filterable f => f (Either a b) -> f b
567+filterRight :: FunctorMaybe f => f (Either a b) -> f b
731−filterRight = mapMaybe (either (const Nothing) Just)
568+filterRight = fmapMaybe (either (const Nothing) Just)
732
569
733-- | Left-biased event union (prefers left event on simultaneous
570-- | Left-biased event union (prefers left event on simultaneous
734-- occurrence).
571-- occurrence).
735instance Reflex t => Alt (Event t) where
572instance Reflex t => Alt (Event t) where
736 ev1 <!> ev2 = leftmost [ev1, ev2]
573 ev1 <!> ev2 = leftmost [ev1, ev2]
737
574
738−-- | 'Event' intersection. Only occurs when both events are co-incident.
575+-- | 'Event' intersection (convenient interface to 'coincidence').
739instance Reflex t => Apply (Event t) where
576instance Reflex t => Apply (Event t) where
740− evf <.> evx = mapMaybe f (align evf evx) where
577+ evf <.> evx = coincidence (fmap (<$> evx) evf)
741− f (These g a) = Just (g a)
742− f _ = Nothing
743−
744
578
745-- | 'Event' intersection (convenient interface to 'coincidence').
579-- | 'Event' intersection (convenient interface to 'coincidence').
746instance Reflex t => Bind (Event t) where
580instance Reflex t => Bind (Event t) where
@@ -749,18 +583,13 @@ instance Reflex t => Bind (Event t) where
749
583
750instance Reflex t => Functor (Event t) where
584instance Reflex t => Functor (Event t) where
751 {-# INLINE fmap #-}
585 {-# INLINE fmap #-}
752− fmap f = mapMaybe $ Just . f
586+ fmap f = fmapMaybe $ Just . f
753 {-# INLINE (<$) #-}
587 {-# INLINE (<$) #-}
754 x <$ e = fmapCheap (const x) e
588 x <$ e = fmapCheap (const x) e
755
589
756−-- TODO Remove this instance
757instance Reflex t => FunctorMaybe (Event t) where
590instance Reflex t => FunctorMaybe (Event t) where
758 {-# INLINE fmapMaybe #-}
591 {-# INLINE fmapMaybe #-}
759− fmapMaybe = mapMaybe
760−
761−instance Reflex t => Filterable (Event t) where
762− {-# INLINE mapMaybe #-}
763− mapMaybe f = push $ return . f
592+ fmapMaybe f = push $ return . f
764
593
765-- | Never: @'zero' = 'never'@.
594-- | Never: @'zero' = 'never'@.
766instance Reflex t => Plus (Event t) where
595instance Reflex t => Plus (Event t) where
@@ -909,7 +738,11 @@ traceEventWith f = push $ \x -> trace (f x) $ return $ Just x
909instance (Semigroup a, Reflex t) => Semigroup (Event t a) where
738instance (Semigroup a, Reflex t) => Semigroup (Event t a) where
910 (<>) = alignWith (mergeThese (<>))
739 (<>) = alignWith (mergeThese (<>))
911 sconcat = fmap sconcat . mergeList . toList
740 sconcat = fmap sconcat . mergeList . toList
741+#if MIN_VERSION_semigroups(0,17,0)
912 stimes n = fmap $ stimes n
742 stimes n = fmap $ stimes n
743+#else
744+ times1p n = fmap $ times1p n
745+#endif
913
746
914instance (Semigroup a, Reflex t) => Monoid (Event t a) where
747instance (Semigroup a, Reflex t) => Monoid (Event t a) where
915 mempty = never
748 mempty = never
@@ -944,12 +777,7 @@ mergeList :: Reflex t => [Event t a] -> Event t (NonEmpty a)
944mergeList [] = never
777mergeList [] = never
945mergeList es = mergeWithFoldCheap' id es
778mergeList es = mergeWithFoldCheap' id es
946
779
947−unsafeMapIncremental
948− :: (Reflex t, Patch p, Patch p')
949− => (PatchTarget p -> PatchTarget p')
780+unsafeMapIncremental :: (Reflex t, Patch p, Patch p') => (PatchTarget p -> PatchTarget p') -> (p -> p') -> Incremental t p -> Incremental t p'
950− -> (p -> p')
951− -> Incremental t p
952− -> Incremental t p'
953unsafeMapIncremental f g a = unsafeBuildIncremental (fmap f $ sample $ currentIncremental a) $ g <$> updatedIncremental a
781unsafeMapIncremental f g a = unsafeBuildIncremental (fmap f $ sample $ currentIncremental a) $ g <$> updatedIncremental a
954
782
955-- | Create a new 'Event' combining the map of 'Event's into an 'Event' that
783-- | Create a new 'Event' combining the map of 'Event's into an 'Event' that
@@ -979,7 +807,7 @@ fanEither :: Reflex t => Event t (Either a b) -> (Event t a, Event t b)
979fanEither e =
807fanEither e =
980 let justLeft = either Just (const Nothing)
808 let justLeft = either Just (const Nothing)
981 justRight = either (const Nothing) Just
809 justRight = either (const Nothing) Just
982− in (mapMaybe justLeft e, mapMaybe justRight e)
810+ in (fmapMaybe justLeft e, fmapMaybe justRight e)
983
811
984-- | Split the event into separate events for 'This' and 'That' values,
812-- | Split the event into separate events for 'This' and 'That' values,
985-- allowing them to fire simultaneously when the input value is 'These'.
813-- allowing them to fire simultaneously when the input value is 'These'.
@@ -991,7 +819,7 @@ fanThese e =
991 that (That y) = Just y
819 that (That y) = Just y
992 that (These _ y) = Just y
820 that (These _ y) = Just y
993 that _ = Nothing
821 that _ = Nothing
994− in (mapMaybe this e, mapMaybe that e)
822+ in (fmapMaybe this e, fmapMaybe that e)
995
823
996-- | Split the event into an 'EventSelector' that allows efficient selection of
824-- | Split the event into an 'EventSelector' that allows efficient selection of
997-- the individual 'Event's.
825-- the individual 'Event's.
@@ -1066,9 +894,6 @@ coincidencePatchMapWithMove e = fmapCheap unsafePatchMapWithMove $ coincidence $
1066 ni { PatchMapWithMove._nodeInfo_from = PatchMapWithMove.From_Delete }
894 ni { PatchMapWithMove._nodeInfo_from = PatchMapWithMove.From_Delete }
1067 ]
895 ]
1068
896
1069−-- | Given a 'PatchTarget' of events (e.g., a 'Map' with 'Event' values) and an event of 'Patch'es
1070−-- (e.g., a 'PatchMap' with 'Event' values), produce an 'Event' of the 'PatchTarget' type that
1071−-- fires with the patched value.
1072switchHoldPromptOnlyIncremental
897switchHoldPromptOnlyIncremental
1073 :: forall t m p pt w
898 :: forall t m p pt w
1074 . ( Reflex t
899 . ( Reflex t
@@ -1093,25 +918,8 @@ switchHoldPromptOnlyIncremental mergePatchIncremental coincidencePatch e0 e' = d
1093
918
1094instance Reflex t => Align (Event t) where
919instance Reflex t => Align (Event t) where
1095 nil = never
920 nil = never
1096−#if MIN_VERSION_these(0, 8, 0)
1097−instance Reflex t => Semialign (Event t) where
1098−#endif
1099 align = alignEventWithMaybe Just
921 align = alignEventWithMaybe Just
1100
922
1101−#ifdef MIN_VERSION_semialign
1102−#if MIN_VERSION_semialign(1,1,0)
1103−instance Reflex t => Zip (Event t) where
1104−#endif
1105− zip x y = mapMaybe justThese $ align x y
1106−#endif
1107−
1108−#ifdef MIN_VERSION_semialign
1109−#if MIN_VERSION_semialign(1,1,0)
1110−instance Reflex t => Unzip (Event t) where
1111− unzip = splitE
1112−#endif
1113−#endif
1114−
1115-- | Create a new 'Event' that only occurs if the supplied 'Event' occurs and
923-- | Create a new 'Event' that only occurs if the supplied 'Event' occurs and
1116-- the 'Behavior' is true at the time of occurrence.
924-- the 'Behavior' is true at the time of occurrence.
1117gate :: Reflex t => Behavior t Bool -> Event t a -> Event t a
925gate :: Reflex t => Behavior t Bool -> Event t a -> Event t a
@@ -1151,7 +959,11 @@ zipDynWith f da db =
1151
959
1152instance (Reflex t, Semigroup a) => Semigroup (Dynamic t a) where
960instance (Reflex t, Semigroup a) => Semigroup (Dynamic t a) where
1153 (<>) = zipDynWith (<>)
961 (<>) = zipDynWith (<>)
962+#if MIN_VERSION_semigroups(0,17,0)
1154 stimes n = fmap $ stimes n
963 stimes n = fmap $ stimes n
964+#else
965+ times1p n = fmap $ times1p n
966+#endif
1155
967
1156instance (Reflex t, Monoid a) => Monoid (Dynamic t a) where
968instance (Reflex t, Monoid a) => Monoid (Dynamic t a) where
1157 mconcat = distributeListOverDynWith mconcat
969 mconcat = distributeListOverDynWith mconcat
@@ -1162,21 +974,12 @@ instance (Reflex t, Monoid a) => Monoid (Dynamic t a) where
1162-- 'Dynamic' 'DMap'. Its implementation is more efficient than doing the same
974-- 'Dynamic' 'DMap'. Its implementation is more efficient than doing the same
1163-- through the use of multiple uses of 'zipDynWith' or 'Applicative' operators.
975-- through the use of multiple uses of 'zipDynWith' or 'Applicative' operators.
1164distributeDMapOverDynPure :: forall t k. (Reflex t, GCompare k) => DMap k (Dynamic t) -> Dynamic t (DMap k Identity)
976distributeDMapOverDynPure :: forall t k. (Reflex t, GCompare k) => DMap k (Dynamic t) -> Dynamic t (DMap k Identity)
1165−distributeDMapOverDynPure = distributeDMapOverDynPureG coerceDynamic
977+distributeDMapOverDynPure dm = case DMap.toList dm of
1166−
1167−-- | This function converts a 'DMap' whose elements are 'Dynamic's into a
1168−-- 'Dynamic' 'DMap'. Its implementation is more efficient than doing the same
1169−-- through the use of multiple uses of 'zipDynWith' or 'Applicative' operators.
1170−distributeDMapOverDynPureG
1171− :: forall t k q v. (Reflex t, GCompare k)
1172− => (forall a. q a -> Dynamic t (v a))
1173− -> DMap k q -> Dynamic t (DMap k v)
1174−distributeDMapOverDynPureG nt dm = case DMap.toList dm of
1175 [] -> constDyn DMap.empty
978 [] -> constDyn DMap.empty
1176− [k :=> v] -> DMap.singleton k <$> nt v
979+ [k :=> v] -> fmap (DMap.singleton k . Identity) v
1177 _ ->
980 _ ->
1178− let getInitial = DMap.traverseWithKey (\_ -> sample . current . nt) dm
981+ let getInitial = DMap.traverseWithKey (\_ -> fmap Identity . sample . current) dm
1179− edmPre = mergeG getCompose $ DMap.map (Compose . updated . nt) dm
982+ edmPre = merge $ DMap.map updated dm
1180 result = unsafeBuildDynamic getInitial $ flip pushAlways edmPre $ \news -> do
983 result = unsafeBuildDynamic getInitial $ flip pushAlways edmPre $ \news -> do
1181 olds <- sample $ current result
984 olds <- sample $ current result
1182 return $ DMap.unionWithKey (\_ _ new -> new) olds news
985 return $ DMap.unionWithKey (\_ _ new -> new) olds news
@@ -1188,32 +991,21 @@ distributeListOverDyn = distributeListOverDynWith id
1188
991
1189-- | Create a new 'Dynamic' by applying a combining function to a list of 'Dynamic's
992-- | Create a new 'Dynamic' by applying a combining function to a list of 'Dynamic's
1190distributeListOverDynWith :: Reflex t => ([a] -> b) -> [Dynamic t a] -> Dynamic t b
993distributeListOverDynWith :: Reflex t => ([a] -> b) -> [Dynamic t a] -> Dynamic t b
1191−distributeListOverDynWith f =
994+distributeListOverDynWith f = fmap (f . map (\(Const2 _ :=> Identity v) -> v) . DMap.toList) . distributeDMapOverDynPure . DMap.fromList . map (\(k, v) -> Const2 k :=> v) . zip [0 :: Int ..]
1192− fmap (f . map fromDSum . DMap.toAscList) .
1193− distributeDMapOverDynPure .
1194− DMap.fromDistinctAscList .
1195− zipWith toDSum [0..]
1196− where
1197− toDSum :: Int -> Dynamic t a -> DSum (Const2 Int a) (Dynamic t)
1198− toDSum k v = Const2 k :=> v
1199− fromDSum :: DSum (Const2 Int a) Identity -> a
1200− fromDSum (Const2 _ :=> Identity v) = v
1201
995
1202-- | Create a new 'Event' that occurs when the first supplied 'Event' occurs
996-- | Create a new 'Event' that occurs when the first supplied 'Event' occurs
1203-- unless the second supplied 'Event' occurs simultaneously.
997-- unless the second supplied 'Event' occurs simultaneously.
1204difference :: Reflex t => Event t a -> Event t b -> Event t a
998difference :: Reflex t => Event t a -> Event t b -> Event t a
1205difference = alignEventWithMaybe $ \case
999difference = alignEventWithMaybe $ \case
1206 This a -> Just a
1000 This a -> Just a
1207− _ -> Nothing
1001+ _ -> Nothing
1208
1002
1209−-- | Zips two values by taking the union of their shapes and combining with the provided function.
1210−-- 'Nothing' values are dropped.
1211alignEventWithMaybe :: Reflex t => (These a b -> Maybe c) -> Event t a -> Event t b -> Event t c
1003alignEventWithMaybe :: Reflex t => (These a b -> Maybe c) -> Event t a -> Event t b -> Event t c
1212−alignEventWithMaybe f ea eb = mapMaybe (f <=< dmapToThese) $
1004+alignEventWithMaybe f ea eb =
1005+ fmapMaybe (f <=< dmapToThese)
1006+ $ merge
1213− merge $ DMap.fromList [LeftTag :=> ea, RightTag :=> eb]
1007+ $ DMap.fromList [LeftTag :=> ea, RightTag :=> eb]
1214
1008
1215−-- | Produces an 'Event' that fires only when the input event fires with a 'DSum' key that
1216−-- matches the provided key.
1217filterEventKey
1009filterEventKey
1218 :: forall t m k v a.
1010 :: forall t m k v a.
1219 ( Reflex t
1011 ( Reflex t
@@ -1231,10 +1023,7 @@ filterEventKey k kv' = do
1231 Nothing -> Nothing
1023 Nothing -> Nothing
1232 takeWhileJustE f kv'
1024 takeWhileJustE f kv'
1233
1025
1234−-- | "Factor" the input 'DSum' 'Event' to produce an 'Event' which
1026+
1235−-- fires when the 'DSum' key changes and contains both the value of the
1236−-- 'DSum' at switchover and an 'Event' of values produced by subsequent
1237−-- firings of the input 'Event' that do not change the 'DSum' key.
1238factorEvent
1027factorEvent
1239 :: forall t m k v a.
1028 :: forall t m k v a.
1240 ( Reflex t
1029 ( Reflex t
@@ -1246,9 +1035,9 @@ factorEvent
1246 -> Event t (DSum k v)
1035 -> Event t (DSum k v)
1247 -> m (Event t (v a), Event t (DSum k (Product v (Compose (Event t) v))))
1036 -> m (Event t (v a), Event t (DSum k (Product v (Compose (Event t) v))))
1248factorEvent k0 kv' = do
1037factorEvent k0 kv' = do
1249− key :: Behavior t (Some k) <- hold (Some k0) $ fmapCheap (\(k :=> _) -> Some k) kv'
1038+ key :: Behavior t (Some k) <- hold (Some.This k0) $ fmapCheap (\(k :=> _) -> Some.This k) kv'
1250 let update = flip push kv' $ \(newKey :=> newVal) -> sample key >>= \case
1039 let update = flip push kv' $ \(newKey :=> newVal) -> sample key >>= \case
1251− Some oldKey -> case newKey `geq` oldKey of
1040+ Some.This oldKey -> case newKey `geq` oldKey of
1252 Just Refl -> return Nothing
1041 Just Refl -> return Nothing
1253 Nothing -> do
1042 Nothing -> do
1254 newInner <- filterEventKey newKey kv'
1043 newInner <- filterEventKey newKey kv'
@@ -1284,94 +1073,26 @@ class Reflex t => Accumulator t f | f -> t where
1284 mapAccumMaybe f = mapAccumMaybeM $ \v o -> return $ f v o
1073 mapAccumMaybe f = mapAccumMaybeM $ \v o -> return $ f v o
1285 mapAccumMaybeM :: (MonadHold t m, MonadFix m) => (a -> b -> PushM t (Maybe a, Maybe c)) -> a -> Event t b -> m (f a, Event t c)
1074 mapAccumMaybeM :: (MonadHold t m, MonadFix m) => (a -> b -> PushM t (Maybe a, Maybe c)) -> a -> Event t b -> m (f a, Event t c)
1286
1075
1287−-- | Accumulate a 'Dynamic' by folding occurrences of an 'Event'
1288−-- with the provided function. See 'foldDyn'.
1289−accumDyn
1290− :: (Reflex t, MonadHold t m, MonadFix m)
1076+accumDyn :: (Reflex t, MonadHold t m, MonadFix m) => (a -> b -> a) -> a -> Event t b -> m (Dynamic t a)
1291− => (a -> b -> a)
1292− -> a
1293− -> Event t b
1294− -> m (Dynamic t a)
1295accumDyn f = accumMaybeDyn $ \v o -> Just $ f v o
1077accumDyn f = accumMaybeDyn $ \v o -> Just $ f v o
1296−
1297−-- | Accumulate a 'Dynamic' by folding occurrences of an 'Event'
1298−-- with the provided 'PushM' action.
1299−accumMDyn
1300− :: (Reflex t, MonadHold t m, MonadFix m)
1078+accumMDyn :: (Reflex t, MonadHold t m, MonadFix m) => (a -> b -> PushM t a) -> a -> Event t b -> m (Dynamic t a)
1301− => (a -> b -> PushM t a)
1302− -> a
1303− -> Event t b
1304− -> m (Dynamic t a)
1305accumMDyn f = accumMaybeMDyn $ \v o -> Just <$> f v o
1079accumMDyn f = accumMaybeMDyn $ \v o -> Just <$> f v o
1306−
1307−-- | Accumulate a 'Dynamic' by folding occurrences of an 'Event'
1308−-- with the provided function, discarding 'Nothing' results.
1309−accumMaybeDyn
1310− :: (Reflex t, MonadHold t m, MonadFix m)
1080+accumMaybeDyn :: (Reflex t, MonadHold t m, MonadFix m) => (a -> b -> Maybe a) -> a -> Event t b -> m (Dynamic t a)
1311− => (a -> b -> Maybe a)
1312− -> a
1313− -> Event t b
1314− -> m (Dynamic t a)
1315accumMaybeDyn f = accumMaybeMDyn $ \v o -> return $ f v o
1081accumMaybeDyn f = accumMaybeMDyn $ \v o -> return $ f v o
1316−
1317−-- | Accumulate a 'Dynamic' by folding occurrences of an 'Event'
1318−-- with the provided 'PushM' action, discarding 'Nothing' results.
1319−accumMaybeMDyn
1320− :: (Reflex t, MonadHold t m, MonadFix m)
1082+accumMaybeMDyn :: (Reflex t, MonadHold t m, MonadFix m) => (a -> b -> PushM t (Maybe a)) -> a -> Event t b -> m (Dynamic t a)
1321− => (a -> b -> PushM t (Maybe a))
1322− -> a
1323− -> Event t b
1324− -> m (Dynamic t a)
1325accumMaybeMDyn f z e = do
1083accumMaybeMDyn f z e = do
1326 rec let e' = flip push e $ \o -> do
1084 rec let e' = flip push e $ \o -> do
1327 v <- sample $ current d'
1085 v <- sample $ current d'
1328 f v o
1086 f v o
1329 d' <- holdDyn z e'
1087 d' <- holdDyn z e'
1330 return d'
1088 return d'
1331−
1332−-- | Accumulate a 'Dynamic' by folding occurrences of an 'Event'
1333−-- with a function that both accumulates and produces a value to fire
1334−-- as an 'Event'. Returns both the accumulated value and an 'Event'.
1335−mapAccumDyn
1336− :: (Reflex t, MonadHold t m, MonadFix m)
1089+mapAccumDyn :: (Reflex t, MonadHold t m, MonadFix m) => (a -> b -> (a, c)) -> a -> Event t b -> m (Dynamic t a, Event t c)
1337− => (a -> b -> (a, c))
1338− -> a
1339− -> Event t b
1340− -> m (Dynamic t a, Event t c)
1341mapAccumDyn f = mapAccumMaybeDyn $ \v o -> bimap Just Just $ f v o
1090mapAccumDyn f = mapAccumMaybeDyn $ \v o -> bimap Just Just $ f v o
1342−
1343−-- | Similar to 'mapAccumDyn' except that the combining function is a
1344−-- 'PushM' action.
1345−mapAccumMDyn
1346− :: (Reflex t, MonadHold t m, MonadFix m)
1091+mapAccumMDyn :: (Reflex t, MonadHold t m, MonadFix m) => (a -> b -> PushM t (a, c)) -> a -> Event t b -> m (Dynamic t a, Event t c)
1347− => (a -> b -> PushM t (a, c))
1348− -> a
1349− -> Event t b
1350− -> m (Dynamic t a, Event t c)
1351mapAccumMDyn f = mapAccumMaybeMDyn $ \v o -> bimap Just Just <$> f v o
1092mapAccumMDyn f = mapAccumMaybeMDyn $ \v o -> bimap Just Just <$> f v o
1352−
1353−-- | Accumulate a 'Dynamic' by folding occurrences of an 'Event' with
1354−-- a function that both optionally accumulates and optionally produces
1355−-- a value to fire as a separate output 'Event'.
1356−-- Note that because 'Nothing's are discarded in both cases, the output
1357−-- 'Event' may fire even though the output 'Dynamic' has not changed, and
1358−-- the output 'Dynamic' may update even when the output 'Event' is not firing.
1359−mapAccumMaybeDyn
1360− :: (Reflex t, MonadHold t m, MonadFix m)
1093+mapAccumMaybeDyn :: (Reflex t, MonadHold t m, MonadFix m) => (a -> b -> (Maybe a, Maybe c)) -> a -> Event t b -> m (Dynamic t a, Event t c)
1361− => (a -> b -> (Maybe a, Maybe c))
1362− -> a
1363− -> Event t b
1364− -> m (Dynamic t a, Event t c)
1365mapAccumMaybeDyn f = mapAccumMaybeMDyn $ \v o -> return $ f v o
1094mapAccumMaybeDyn f = mapAccumMaybeMDyn $ \v o -> return $ f v o
1366−
1367−-- | Like 'mapAccumMaybeDyn' except that the combining function is a
1368−-- 'PushM' action.
1369−mapAccumMaybeMDyn
1370− :: (Reflex t, MonadHold t m, MonadFix m)
1095+mapAccumMaybeMDyn :: (Reflex t, MonadHold t m, MonadFix m) => (a -> b -> PushM t (Maybe a, Maybe c)) -> a -> Event t b -> m (Dynamic t a, Event t c)
1371− => (a -> b -> PushM t (Maybe a, Maybe c))
1372− -> a
1373− -> Event t b
1374− -> m (Dynamic t a, Event t c)
1375mapAccumMaybeMDyn f z e = do
1096mapAccumMaybeMDyn f z e = do
1376 rec let e' = flip push e $ \o -> do
1097 rec let e' = flip push e $ \o -> do
1377 v <- sample $ current d'
1098 v <- sample $ current d'
@@ -1379,42 +1100,18 @@ mapAccumMaybeMDyn f z e = do
1379 return $ case result of
1100 return $ case result of
1380 (Nothing, Nothing) -> Nothing
1101 (Nothing, Nothing) -> Nothing
1381 _ -> Just result
1102 _ -> Just result
1382− d' <- holdDyn z $ mapMaybe fst e'
1103+ d' <- holdDyn z $ fmapMaybe fst e'
1383− return (d', mapMaybe snd e')
1104+ return (d', fmapMaybe snd e')
1384
1105
1385−-- | Accumulate a 'Behavior' by folding occurrences of an 'Event'
1386−-- with the provided function.
1387{-# INLINE accumB #-}
1106{-# INLINE accumB #-}
1388−accumB
1389− :: (Reflex t, MonadHold t m, MonadFix m)
1107+accumB :: (Reflex t, MonadHold t m, MonadFix m) => (a -> b -> a) -> a -> Event t b -> m (Behavior t a)
1390− => (a -> b -> a)
1391− -> a
1392− -> Event t b
1393− -> m (Behavior t a)
1394accumB f = accumMaybeB $ \v o -> Just $ f v o
1108accumB f = accumMaybeB $ \v o -> Just $ f v o
1395−
1396−-- | Like 'accumB' except that the combining function is a 'PushM' action.
1397{-# INLINE accumMB #-}
1109{-# INLINE accumMB #-}
1398−accumMB
1399− :: (Reflex t, MonadHold t m, MonadFix m)
1110+accumMB :: (Reflex t, MonadHold t m, MonadFix m) => (a -> b -> PushM t a) -> a -> Event t b -> m (Behavior t a)
1400− => (a -> b -> PushM t a)
1401− -> a
1402− -> Event t b
1403− -> m (Behavior t a)
1404accumMB f = accumMaybeMB $ \v o -> Just <$> f v o
1111accumMB f = accumMaybeMB $ \v o -> Just <$> f v o
1405−
1406−-- | Accumulate a 'Behavior' by folding occurrences of an 'Event'
1407−-- with the provided function, discarding 'Nothing' results.
1408{-# INLINE accumMaybeB #-}
1112{-# INLINE accumMaybeB #-}
1409−accumMaybeB
1410− :: (Reflex t, MonadHold t m, MonadFix m)
1113+accumMaybeB :: (Reflex t, MonadHold t m, MonadFix m) => (a -> b -> Maybe a) -> a -> Event t b -> m (Behavior t a)
1411− => (a -> b -> Maybe a)
1412− -> a
1413− -> Event t b
1414− -> m (Behavior t a)
1415accumMaybeB f = accumMaybeMB $ \v o -> return $ f v o
1114accumMaybeB f = accumMaybeMB $ \v o -> return $ f v o
1416−
1417−-- | Like 'accumMaybeB' except that the combining function is a 'PushM' action.
1418{-# INLINE accumMaybeMB #-}
1115{-# INLINE accumMaybeMB #-}
1419accumMaybeMB :: (Reflex t, MonadHold t m, MonadFix m) => (a -> b -> PushM t (Maybe a)) -> a -> Event t b -> m (Behavior t a)
1116accumMaybeMB :: (Reflex t, MonadHold t m, MonadFix m) => (a -> b -> PushM t (Maybe a)) -> a -> Event t b -> m (Behavior t a)
1420accumMaybeMB f z e = do
1117accumMaybeMB f z e = do
@@ -1423,42 +1120,16 @@ accumMaybeMB f z e = do
1423 f v o
1120 f v o
1424 d' <- hold z e'
1121 d' <- hold z e'
1425 return d'
1122 return d'
1426−
1427−-- | Accumulate a 'Behavior' by folding occurrences of an 'Event'
1428−-- with a function that both accumulates and produces a value to fire
1429−-- as an 'Event'. Returns both the accumulated value and an 'Event'.
1430{-# INLINE mapAccumB #-}
1123{-# INLINE mapAccumB #-}
1431−mapAccumB
1432− :: (Reflex t, MonadHold t m, MonadFix m)
1124+mapAccumB :: (Reflex t, MonadHold t m, MonadFix m) => (a -> b -> (a, c)) -> a -> Event t b -> m (Behavior t a, Event t c)
1433− => (a -> b -> (a, c))
1434− -> a
1435− -> Event t b
1436− -> m (Behavior t a, Event t c)
1437mapAccumB f = mapAccumMaybeB $ \v o -> bimap Just Just $ f v o
1125mapAccumB f = mapAccumMaybeB $ \v o -> bimap Just Just $ f v o
1438−
1439−-- | Like 'mapAccumB' except that the combining function is a 'PushM' action.
1440{-# INLINE mapAccumMB #-}
1126{-# INLINE mapAccumMB #-}
1441−mapAccumMB
1442− :: (Reflex t, MonadHold t m, MonadFix m)
1127+mapAccumMB :: (Reflex t, MonadHold t m, MonadFix m) => (a -> b -> PushM t (a, c)) -> a -> Event t b -> m (Behavior t a, Event t c)
1443− => (a -> b -> PushM t (a, c))
1444− -> a
1445− -> Event t b
1446− -> m (Behavior t a, Event t c)
1447mapAccumMB f = mapAccumMaybeMB $ \v o -> bimap Just Just <$> f v o
1128mapAccumMB f = mapAccumMaybeMB $ \v o -> bimap Just Just <$> f v o
1448−
1449−-- | Accumulate a 'Behavior' by folding occurrences of an 'Event' with
1450−-- a function that both optionally accumulates and optionally produces
1451−-- a value to fire as a separate output 'Event'. 'Nothing's are discarded.
1452{-# INLINE mapAccumMaybeB #-}
1129{-# INLINE mapAccumMaybeB #-}
1453−mapAccumMaybeB
1454− :: (Reflex t, MonadHold t m, MonadFix m)
1130+mapAccumMaybeB :: (Reflex t, MonadHold t m, MonadFix m) => (a -> b -> (Maybe a, Maybe c)) -> a -> Event t b -> m (Behavior t a, Event t c)
1455− => (a -> b -> (Maybe a, Maybe c))
1456− -> a
1457− -> Event t b
1458− -> m (Behavior t a, Event t c)
1459mapAccumMaybeB f = mapAccumMaybeMB $ \v o -> return $ f v o
1131mapAccumMaybeB f = mapAccumMaybeMB $ \v o -> return $ f v o
1460
1132
1461−-- | Like 'mapAccumMaybeB' except that the combining function is a 'PushM' action.
1462{-# INLINE mapAccumMaybeMB #-}
1133{-# INLINE mapAccumMaybeMB #-}
1463mapAccumMaybeMB :: (Reflex t, MonadHold t m, MonadFix m) => (a -> b -> PushM t (Maybe a, Maybe c)) -> a -> Event t b -> m (Behavior t a, Event t c)
1134mapAccumMaybeMB :: (Reflex t, MonadHold t m, MonadFix m) => (a -> b -> PushM t (Maybe a, Maybe c)) -> a -> Event t b -> m (Behavior t a, Event t c)
1464mapAccumMaybeMB f z e = do
1135mapAccumMaybeMB f z e = do
@@ -1468,8 +1139,8 @@ mapAccumMaybeMB f z e = do
1468 return $ case result of
1139 return $ case result of
1469 (Nothing, Nothing) -> Nothing
1140 (Nothing, Nothing) -> Nothing
1470 _ -> Just result
1141 _ -> Just result
1471− d' <- hold z $ mapMaybe fst e'
1142+ d' <- hold z $ fmapMaybe fst e'
1472− return (d', mapMaybe snd e')
1143+ return (d', fmapMaybe snd e')
1473
1144
1474-- | Accumulate occurrences of an 'Event', producing an output occurrence each
1145-- | Accumulate occurrences of an 'Event', producing an output occurrence each
1475-- time. Discard the underlying 'Accumulator'.
1146-- time. Discard the underlying 'Accumulator'.
@@ -1613,70 +1284,38 @@ infixl 4 <@
1613-- Cheap Functions
1284-- Cheap Functions
1614------------------
1285------------------
1615
1286
1616−-- | A "cheap" version of 'pushAlways'. See the performance note on 'pushCheap'.
1617{-# INLINE pushAlwaysCheap #-}
1287{-# INLINE pushAlwaysCheap #-}
1618pushAlwaysCheap :: Reflex t => (a -> PushM t b) -> Event t a -> Event t b
1288pushAlwaysCheap :: Reflex t => (a -> PushM t b) -> Event t a -> Event t b
1619pushAlwaysCheap f = pushCheap (fmap Just . f)
1289pushAlwaysCheap f = pushCheap (fmap Just . f)
1620
1290
1621−-- | A "cheap" version of 'mapMaybe'. See the performance note on 'pushCheap'.
1622−{-# INLINE mapMaybeCheap #-}
1623−mapMaybeCheap :: Reflex t => (a -> Maybe b) -> Event t a -> Event t b
1624−mapMaybeCheap f = pushCheap $ return . f
1625−
1626−-- | An alias for 'mapMaybeCheap'
1627{-# INLINE fmapMaybeCheap #-}
1291{-# INLINE fmapMaybeCheap #-}
1628fmapMaybeCheap :: Reflex t => (a -> Maybe b) -> Event t a -> Event t b
1292fmapMaybeCheap :: Reflex t => (a -> Maybe b) -> Event t a -> Event t b
1629−fmapMaybeCheap = mapMaybeCheap
1293+fmapMaybeCheap f = pushCheap $ return . f
1630−
1631
1294
1632−-- | A "cheap" version of 'fforMaybe'. See the performance note on 'pushCheap'.
1633{-# INLINE fforMaybeCheap #-}
1295{-# INLINE fforMaybeCheap #-}
1634fforMaybeCheap :: Reflex t => Event t a -> (a -> Maybe b) -> Event t b
1296fforMaybeCheap :: Reflex t => Event t a -> (a -> Maybe b) -> Event t b
1635−fforMaybeCheap = flip mapMaybeCheap
1297+fforMaybeCheap = flip fmapMaybeCheap
1636
1298
1637−-- | A "cheap" version of 'ffor'. See the performance note on 'pushCheap'.
1638{-# INLINE fforCheap #-}
1299{-# INLINE fforCheap #-}
1639fforCheap :: Reflex t => Event t a -> (a -> b) -> Event t b
1300fforCheap :: Reflex t => Event t a -> (a -> b) -> Event t b
1640fforCheap = flip fmapCheap
1301fforCheap = flip fmapCheap
1641
1302
1642−-- | A "cheap" version of 'fmap'. See the performance note on 'pushCheap'.
1643{-# INLINE fmapCheap #-}
1303{-# INLINE fmapCheap #-}
1644fmapCheap :: Reflex t => (a -> b) -> Event t a -> Event t b
1304fmapCheap :: Reflex t => (a -> b) -> Event t a -> Event t b
1645fmapCheap f = pushCheap $ return . Just . f
1305fmapCheap f = pushCheap $ return . Just . f
1646
1306
1647−-- | A "cheap" version of 'tag'. See the performance note on 'pushCheap'.
1648{-# INLINE tagCheap #-}
1307{-# INLINE tagCheap #-}
1649tagCheap :: Reflex t => Behavior t b -> Event t a -> Event t b
1308tagCheap :: Reflex t => Behavior t b -> Event t a -> Event t b
1650tagCheap b = pushAlwaysCheap $ \_ -> sample b
1309tagCheap b = pushAlwaysCheap $ \_ -> sample b
1651
1310
1652−-- | Merge a collection of events; the resulting 'Event' will only occur if at
1653−-- least one input event is occurring, and will contain all of the input keys
1654−-- that are occurring simultaneously
1655−merge :: (Reflex t, GCompare k) => DMap k (Event t) -> Event t (DMap k Identity)
1656−merge = mergeG coerceEvent
1657−{-# INLINE merge #-}
1658−
1659−-- | Create a merge whose parents can change over time
1660−mergeIncremental :: (Reflex t, GCompare k)
1661− => Incremental t (PatchDMap k (Event t)) -> Event t (DMap k Identity)
1662−mergeIncremental = mergeIncrementalG coerceEvent
1663−
1664−-- | Experimental: Create a merge whose parents can change over time; changing the key of an Event is more efficient than with mergeIncremental
1665−mergeIncrementalWithMove :: (Reflex t, GCompare k)
1666− => Incremental t (PatchDMapWithMove k (Event t)) -> Event t (DMap k Identity)
1667−mergeIncrementalWithMove = mergeIncrementalWithMoveG coerceEvent
1668−
1669−-- | A "cheap" version of 'mergeWithCheap'. See the performance note on 'pushCheap'.
1670{-# INLINE mergeWithCheap #-}
1311{-# INLINE mergeWithCheap #-}
1671mergeWithCheap :: Reflex t => (a -> a -> a) -> [Event t a] -> Event t a
1312mergeWithCheap :: Reflex t => (a -> a -> a) -> [Event t a] -> Event t a
1672mergeWithCheap = mergeWithCheap' id
1313mergeWithCheap = mergeWithCheap' id
1673
1314
1674−-- | A "cheap" version of 'mergeWithCheap''. See the performance note on 'pushCheap'.
1675{-# INLINE mergeWithCheap' #-}
1315{-# INLINE mergeWithCheap' #-}
1676mergeWithCheap' :: Reflex t => (a -> b) -> (b -> b -> b) -> [Event t a] -> Event t b
1316mergeWithCheap' :: Reflex t => (a -> b) -> (b -> b -> b) -> [Event t a] -> Event t b
1677mergeWithCheap' f g = mergeWithFoldCheap' $ foldl1 g . fmap f
1317mergeWithCheap' f g = mergeWithFoldCheap' $ foldl1 g . fmap f
1678
1318
1679−-- | A "cheap" version of 'mergeWithFoldCheap''. See the performance note on 'pushCheap'.
1680{-# INLINE mergeWithFoldCheap' #-}
1319{-# INLINE mergeWithFoldCheap' #-}
1681mergeWithFoldCheap' :: Reflex t => (NonEmpty a -> b) -> [Event t a] -> Event t b
1320mergeWithFoldCheap' :: Reflex t => (NonEmpty a -> b) -> [Event t a] -> Event t b
1682mergeWithFoldCheap' f es =
1321mergeWithFoldCheap' f es =
@@ -1689,11 +1328,31 @@ mergeWithFoldCheap' f es =
1689-- Deprecated functions
1328-- Deprecated functions
1690--------------------------------------------------------------------------------
1329--------------------------------------------------------------------------------
1691
1330
1331+-- | Create a new 'Event' that occurs if at least one of the supplied 'Event's
1332+-- occurs. If both occur at the same time they are combined using 'mappend'.
1333+{-# DEPRECATED appendEvents "If a 'Semigroup a' instance is available, use 'mappend'; otherwise, use 'alignWith (mergeThese mappend)' instead" #-}
1334+appendEvents :: (Reflex t, Monoid a) => Event t a -> Event t a -> Event t a
1335+appendEvents = alignWith $ mergeThese mappend
1336+
1337+-- | Alias for 'headE'
1338+{-# DEPRECATED onceE "Use 'headE' instead" #-}
1339+onceE :: MonadHold t m => Event t a -> m (Event t a)
1340+onceE = headE
1341+
1342+-- | Run both sides of a 'These' monadically, combining the results.
1343+{-# DEPRECATED sequenceThese "Use bisequenceA or bisequence from the bifunctors package instead" #-}
1344+#ifdef USE_TEMPLATE_HASKELL
1345+{-# ANN sequenceThese "HLint: ignore Use fmap" #-}
1346+#endif
1347+sequenceThese :: Monad m => These (m a) (m b) -> m (These a b)
1348+sequenceThese t = case t of
1349+ This ma -> fmap This ma
1350+ These ma mb -> liftM2 These ma mb
1351+ That mb -> fmap That mb
1352+
1692{-# DEPRECATED switchPromptly "Use 'switchHoldPromptly' instead. The 'switchHold*' naming convention was chosen because those functions are more closely related to each other than they are to 'switch'. " #-}
1353{-# DEPRECATED switchPromptly "Use 'switchHoldPromptly' instead. The 'switchHold*' naming convention was chosen because those functions are more closely related to each other than they are to 'switch'. " #-}
1693−-- | See 'switchHoldPromptly'
1694switchPromptly :: (Reflex t, MonadHold t m) => Event t a -> Event t (Event t a) -> m (Event t a)
1354switchPromptly :: (Reflex t, MonadHold t m) => Event t a -> Event t (Event t a) -> m (Event t a)
1695switchPromptly = switchHoldPromptly
1355switchPromptly = switchHoldPromptly
1696{-# DEPRECATED switchPromptOnly "Use 'switchHoldPromptOnly' instead. The 'switchHold*' naming convention was chosen because those functions are more closely related to each other than they are to 'switch'. " #-}
1356{-# DEPRECATED switchPromptOnly "Use 'switchHoldPromptOnly' instead. The 'switchHold*' naming convention was chosen because those functions are more closely related to each other than they are to 'switch'. " #-}
1697−-- | See 'switchHoldPromptOnly'
1698switchPromptOnly :: (Reflex t, MonadHold t m) => Event t a -> Event t (Event t a) -> m (Event t a)
1357switchPromptOnly :: (Reflex t, MonadHold t m) => Event t a -> Event t (Event t a) -> m (Event t a)
1699switchPromptOnly = switchHoldPromptOnly
1358switchPromptOnly = switchHoldPromptOnly
src/Reflex/Collection.hs+11−16
@@ -10,14 +10,12 @@
10#ifdef USE_REFLEX_OPTIMIZER
10#ifdef USE_REFLEX_OPTIMIZER
11{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
11{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
12#endif
12#endif
13−-- |
14−-- Module:
15−-- Reflex.Collection
16module Reflex.Collection
13module Reflex.Collection
17 (
14 (
18 -- * Widgets on Collections
15 -- * Widgets on Collections
19 listHoldWithKey
16 listHoldWithKey
20 , listWithKey
17 , listWithKey
18+ , listWithKey'
21 , listWithKeyShallowDiff
19 , listWithKeyShallowDiff
22 , listViewWithKey
20 , listViewWithKey
23 , selectViewListWithKey
21 , selectViewListWithKey
@@ -27,13 +25,6 @@ module Reflex.Collection
27 , simpleList
25 , simpleList
28 ) where
26 ) where
29
27
30−#ifdef MIN_VERSION_semialign
31−import Prelude hiding (zip, zipWith)
32−#if MIN_VERSION_semialign(1,1,0)
33−import Data.Zip (Zip (..))
34−#endif
35−#endif
36−
37import Control.Monad.Identity
28import Control.Monad.Identity
38import Data.Align
29import Data.Align
39import Data.Functor.Misc
30import Data.Functor.Misc
@@ -47,9 +38,6 @@ import Reflex.Adjustable.Class
47import Reflex.Dynamic
38import Reflex.Dynamic
48import Reflex.PostBuild.Class
39import Reflex.PostBuild.Class
49
40
50−-- | Create a set of widgets based on the provided 'Map'. When the
51−-- input 'Event' fires, remove widgets for keys with the value 'Nothing'
52−-- and add/replace widgets for keys with 'Just' values.
53listHoldWithKey
41listHoldWithKey
54 :: forall t m k v a
42 :: forall t m k v a
55 . (Ord k, Adjustable t m, MonadHold t m)
43 . (Ord k, Adjustable t m, MonadHold t m)
@@ -108,6 +96,15 @@ listWithKey vals mkChild = do
108 listHoldWithKey Map.empty changeVals $ \k v ->
96 listHoldWithKey Map.empty changeVals $ \k v ->
109 mkChild k =<< holdDyn v (select childValChangedSelector $ Const2 k)
97 mkChild k =<< holdDyn v (select childValChangedSelector $ Const2 k)
110
98
99+{-# DEPRECATED listWithKey' "listWithKey' has been renamed to listWithKeyShallowDiff; also, its behavior has changed to fix a bug where children were always rebuilt (never updated)" #-}
100+listWithKey'
101+ :: (Ord k, Adjustable t m, MonadFix m, MonadHold t m)
102+ => Map k v
103+ -> Event t (Map k (Maybe v))
104+ -> (k -> v -> Event t v -> m a)
105+ -> m (Dynamic t (Map k a))
106+listWithKey' = listWithKeyShallowDiff
107+
111-- | Display the given map of items (in key order) using the builder
108-- | Display the given map of items (in key order) using the builder
112-- function provided, and update it with the given event. 'Nothing'
109-- function provided, and update it with the given event. 'Nothing'
113-- update entries will delete the corresponding children, and 'Just'
110-- update entries will delete the corresponding children, and 'Just'
@@ -130,7 +127,7 @@ listWithKeyShallowDiff initialVals valsChanged mkChild = do
130 Nothing -> Just Nothing
127 Nothing -> Just Nothing
131
128
132 -- We don't want to let spurious re-creations of items through
129 -- We don't want to let spurious re-creations of items through
133− Just _ -> Nothing
130+ Just _ -> Nothing
134 listHoldWithKey
131 listHoldWithKey
135 initialVals
132 initialVals
136 (attachWith (flip (Map.differenceWith relevantPatch))
133 (attachWith (flip (Map.differenceWith relevantPatch))
@@ -185,8 +182,6 @@ selectViewListWithKey selection vals mkChild = do
185 return $ fmap ((,) k) selectSelf
182 return $ fmap ((,) k) selectSelf
186 return $ switchPromptlyDyn $ leftmost . Map.elems <$> selectChild
183 return $ switchPromptlyDyn $ leftmost . Map.elems <$> selectChild
187
184
188−-- | Like 'selectViewListWithKey' but discards the value of the list
189−-- item widget's output 'Event'.
190selectViewListWithKey_
185selectViewListWithKey_
191 :: forall t m k v a
186 :: forall t m k v a
192 . (Adjustable t m, Ord k, PostBuild t m, MonadHold t m, MonadFix m)
187 . (Adjustable t m, Ord k, PostBuild t m, MonadHold t m, MonadFix m)
src/Reflex/Dynamic.hs+169−34
@@ -17,12 +17,8 @@
17#ifdef USE_REFLEX_OPTIMIZER
17#ifdef USE_REFLEX_OPTIMIZER
18{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
18{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
19#endif
19#endif
20−-- |
21−-- Module:
22−-- Reflex.Dynamic
23−-- Description:
24−-- This module contains various functions for working with 'Dynamic' values.
20+-- | This module contains various functions for working with 'Dynamic' values.
25−-- 'Dynamic' and its primitives have been moved to the 'Reflex' class.
21+-- 'Dynamic' and its primitives have been moved to the 'Reflex' class.
26module Reflex.Dynamic
22module Reflex.Dynamic
27 ( -- * Basics
23 ( -- * Basics
28 Dynamic -- Abstract so we can preserve the law that the current value is always equal to the most recent update
24 Dynamic -- Abstract so we can preserve the law that the current value is always equal to the most recent update
@@ -53,12 +49,10 @@ module Reflex.Dynamic
53 , foldDynMaybe
49 , foldDynMaybe
54 , foldDynMaybeM
50 , foldDynMaybeM
55 , joinDynThroughMap
51 , joinDynThroughMap
56− , joinDynThroughIntMap
57 , traceDyn
52 , traceDyn
58 , traceDynWith
53 , traceDynWith
59 , splitDynPure
54 , splitDynPure
60 , distributeMapOverDynPure
55 , distributeMapOverDynPure
61− , distributeIntMapOverDynPure
62 , distributeDMapOverDynPure
56 , distributeDMapOverDynPure
63 , distributeListOverDynPure
57 , distributeListOverDynPure
64 , Demux
58 , Demux
@@ -76,12 +70,32 @@ module Reflex.Dynamic
76 , distributeFHListOverDynPure
70 , distributeFHListOverDynPure
77 -- * Unsafe
71 -- * Unsafe
78 , unsafeDynamic
72 , unsafeDynamic
73+ -- * Deprecated functions
74+ , apDyn
75+ , attachDyn
76+ , attachDynWith
77+ , attachDynWithMaybe
78+ , collectDyn
79+ , combineDyn
80+ , distributeDMapOverDyn
81+ , distributeFHListOverDyn
82+ , forDyn
83+ , getDemuxed
84+ , joinDyn
85+ , mapDyn
86+ , mconcatDyn
87+ , nubDyn
88+ , splitDyn
89+ , tagDyn
90+ , uniqDyn
91+ , uniqDynBy
79 ) where
92 ) where
80
93
81import Data.Functor.Compose
94import Data.Functor.Compose
82import Data.Functor.Misc
95import Data.Functor.Misc
83import Reflex.Class
96import Reflex.Class
84
97
98+import Control.Applicative ((<*>))
85import Control.Monad
99import Control.Monad
86import Control.Monad.Fix
100import Control.Monad.Fix
87import Control.Monad.Identity
101import Control.Monad.Identity
@@ -89,14 +103,12 @@ import Data.Align
89import Data.Dependent.Map (DMap)
103import Data.Dependent.Map (DMap)
90import qualified Data.Dependent.Map as DMap
104import qualified Data.Dependent.Map as DMap
91import Data.Dependent.Sum (DSum (..))
105import Data.Dependent.Sum (DSum (..))
106+import Data.Functor.Product
92−import Data.GADT.Compare (GCompare (..), GEq (..), GOrdering (..))
107+import Data.GADT.Compare ((:~:) (..), GCompare (..), GEq (..), GOrdering (..))
93−import Data.IntMap (IntMap)
94−import qualified Data.IntMap as IntMap
95import Data.Map (Map)
108import Data.Map (Map)
96import Data.Maybe
109import Data.Maybe
97−import Data.Monoid ((<>))
110+import Data.Monoid hiding (Product)
98import Data.These
111import Data.These
99−import Data.Type.Equality ((:~:) (..))
100
112
101import Debug.Trace
113import Debug.Trace
102
114
@@ -206,27 +218,25 @@ splitDynPure d = (fmap fst d, fmap snd d)
206distributeMapOverDynPure :: (Reflex t, Ord k) => Map k (Dynamic t v) -> Dynamic t (Map k v)
218distributeMapOverDynPure :: (Reflex t, Ord k) => Map k (Dynamic t v) -> Dynamic t (Map k v)
207distributeMapOverDynPure = fmap dmapToMap . distributeDMapOverDynPure . mapWithFunctorToDMap
219distributeMapOverDynPure = fmap dmapToMap . distributeDMapOverDynPure . mapWithFunctorToDMap
208
220
209−-- | Convert an 'IntMap' with 'Dynamic' elements into a 'Dynamic' of an 'IntMap' with
210−-- non-'Dynamic' elements.
211−distributeIntMapOverDynPure :: (Reflex t) => IntMap (Dynamic t v) -> Dynamic t (IntMap v)
212−distributeIntMapOverDynPure = fmap dmapToIntMap . distributeDMapOverDynPure . intMapWithFunctorToDMap
213−
214-- | Convert a list with 'Dynamic' elements into a 'Dynamic' of a list with
221-- | Convert a list with 'Dynamic' elements into a 'Dynamic' of a list with
215-- non-'Dynamic' elements, preserving the order of the elements.
222-- non-'Dynamic' elements, preserving the order of the elements.
216−{-# DEPRECATED distributeListOverDynPure "Use 'distributeListOverDyn' instead" #-}
217distributeListOverDynPure :: Reflex t => [Dynamic t v] -> Dynamic t [v]
223distributeListOverDynPure :: Reflex t => [Dynamic t v] -> Dynamic t [v]
218−distributeListOverDynPure = distributeListOverDyn
224+distributeListOverDynPure =
225+ fmap (map fromDSum . DMap.toAscList) .
226+ distributeDMapOverDynPure .
227+ DMap.fromDistinctAscList .
228+ zipWith toDSum [0..]
229+ where
230+ toDSum :: Int -> Dynamic t a -> DSum (Const2 Int a) (Dynamic t)
231+ toDSum k v = Const2 k :=> v
232+ fromDSum :: DSum (Const2 Int a) Identity -> a
233+ fromDSum (Const2 _ :=> Identity v) = v
219
234
220--TODO: Generalize this to functors other than Maps
235--TODO: Generalize this to functors other than Maps
221-- | Combine a 'Dynamic' of a 'Map' of 'Dynamic's into a 'Dynamic'
236-- | Combine a 'Dynamic' of a 'Map' of 'Dynamic's into a 'Dynamic'
222-- with the current values of the 'Dynamic's in a map.
237-- with the current values of the 'Dynamic's in a map.
223joinDynThroughMap :: forall t k a. (Reflex t, Ord k) => Dynamic t (Map k (Dynamic t a)) -> Dynamic t (Map k a)
238joinDynThroughMap :: forall t k a. (Reflex t, Ord k) => Dynamic t (Map k (Dynamic t a)) -> Dynamic t (Map k a)
224−joinDynThroughMap = (distributeMapOverDynPure =<<)
239+joinDynThroughMap = joinDyn . fmap distributeMapOverDynPure
225−
226−-- | Combine a 'Dynamic' of an 'IntMap' of 'Dynamic's into a 'Dynamic'
227−-- with the current values of the 'Dynamic's in a map.
228−joinDynThroughIntMap :: forall t a. (Reflex t) => Dynamic t (IntMap (Dynamic t a)) -> Dynamic t (IntMap a)
229−joinDynThroughIntMap = (distributeIntMapOverDynPure =<<)
230
240
231-- | Print the value of the 'Dynamic' when it is first read and on each
241-- | Print the value of the 'Dynamic' when it is first read and on each
232-- subsequent change that is observed (as 'traceEvent'), prefixed with the
242-- subsequent change that is observed (as 'traceEvent'), prefixed with the
@@ -308,8 +318,6 @@ maybeDyn = fmap (fmap unpack) . eitherDyn . fmap pack
308 Left _ -> Nothing
318 Left _ -> Nothing
309 Right a -> Just a
319 Right a -> Just a
310
320
311−-- | Turns a 'Dynamic t (Either a b)' into a 'Dynamic t (Either (Dynamic t a) (Dynamic t b))' such that
312−-- the outer 'Dynamic' is updated only when the 'Either' constructor changes (e.g., from 'Left' to 'Right').
313eitherDyn :: forall t a b m. (Reflex t, MonadFix m, MonadHold t m) => Dynamic t (Either a b) -> m (Dynamic t (Either (Dynamic t a) (Dynamic t b)))
321eitherDyn :: forall t a b m. (Reflex t, MonadFix m, MonadHold t m) => Dynamic t (Either a b) -> m (Dynamic t (Either (Dynamic t a) (Dynamic t b)))
314eitherDyn = fmap (fmap unpack) . factorDyn . fmap eitherToDSum
322eitherDyn = fmap (fmap unpack) . factorDyn . fmap eitherToDSum
315 where unpack :: DSum (EitherTag a b) (Compose (Dynamic t) Identity) -> Either (Dynamic t a) (Dynamic t b)
323 where unpack :: DSum (EitherTag a b) (Compose (Dynamic t) Identity) -> Either (Dynamic t a) (Dynamic t b)
@@ -317,9 +325,6 @@ eitherDyn = fmap (fmap unpack) . factorDyn . fmap eitherToDSum
317 LeftTag :=> Compose a -> Left $ coerceDynamic a
325 LeftTag :=> Compose a -> Left $ coerceDynamic a
318 RightTag :=> Compose b -> Right $ coerceDynamic b
326 RightTag :=> Compose b -> Right $ coerceDynamic b
319
327
320−-- | Factor a 'Dynamic t DSum' into a 'Dynamic' 'DSum' containing nested 'Dynamic' values.
321−-- The outer 'Dynamic' updates only when the key of the 'DSum' changes, while the update of the inner
322−-- 'Dynamic' represents updates within the current key.
323factorDyn :: forall t m k v. (Reflex t, MonadHold t m, GEq k)
328factorDyn :: forall t m k v. (Reflex t, MonadHold t m, GEq k)
324 => Dynamic t (DSum k v) -> m (Dynamic t (DSum k (Compose (Dynamic t) v)))
329 => Dynamic t (DSum k v) -> m (Dynamic t (DSum k (Compose (Dynamic t) v)))
325factorDyn d = buildDynamic (sample (current d) >>= holdKey) update where
330factorDyn d = buildDynamic (sample (current d) >>= holdKey) update where
@@ -334,7 +339,6 @@ factorDyn d = buildDynamic (sample (current d) >>= holdKey) update where
334 inner' <- filterEventKey k (updated d)
339 inner' <- filterEventKey k (updated d)
335 inner <- holdDyn v inner'
340 inner <- holdDyn v inner'
336 return $ k :=> Compose inner
341 return $ k :=> Compose inner
337−
338--------------------------------------------------------------------------------
342--------------------------------------------------------------------------------
339-- Demux
343-- Demux
340--------------------------------------------------------------------------------
344--------------------------------------------------------------------------------
@@ -348,7 +352,7 @@ factorDyn d = buildDynamic (sample (current d) >>= holdKey) update where
348--
352--
349-- > demuxed (demux d) k === fmap (== k) d
353-- > demuxed (demux d) k === fmap (== k) d
350--
354--
351−-- However, when 'demuxed' is used multiple times, the complexity is only
355+-- However, the when getDemuxed is used multiple times, the complexity is only
352-- /O(log(n))/, rather than /O(n)/ for fmap.
356-- /O(log(n))/, rather than /O(n)/ for fmap.
353data Demux t k = Demux { demuxValue :: Behavior t k
357data Demux t k = Demux { demuxValue :: Behavior t k
354 , demuxSelector :: EventSelector t (Const2 k Bool)
358 , demuxSelector :: EventSelector t (Const2 k Bool)
@@ -502,7 +506,7 @@ instance AllAreFunctors f t => AllAreFunctors f (h ': t) where
502
506
503-- | Convert a datastructure whose constituent parts are all 'Dynamic's into a
507-- | Convert a datastructure whose constituent parts are all 'Dynamic's into a
504-- single 'Dynamic' whose value represents all the current values of the input's
508-- single 'Dynamic' whose value represents all the current values of the input's
505−-- constituent 'Dynamic's.
509+-- consitutent 'Dynamic's.
506collectDynPure :: ( RebuildSortedHList (HListElems b)
510collectDynPure :: ( RebuildSortedHList (HListElems b)
507 , IsHList a, IsHList b
511 , IsHList a, IsHList b
508 , AllAreFunctors (Dynamic t) (HListElems b)
512 , AllAreFunctors (Dynamic t) (HListElems b)
@@ -543,3 +547,134 @@ instance IsHList (a, b, c, d, e, f) where
543#if !defined(__GLASGOW_HASKELL__) || __GLASGOW_HASKELL__ < 800
547#if !defined(__GLASGOW_HASKELL__) || __GLASGOW_HASKELL__ < 800
544 _ -> error "fromHList: impossible" -- Otherwise, GHC complains of a non-exhaustive pattern match; see https://ghc.haskell.org/trac/ghc/ticket/4139
548 _ -> error "fromHList: impossible" -- Otherwise, GHC complains of a non-exhaustive pattern match; see https://ghc.haskell.org/trac/ghc/ticket/4139
545#endif
549#endif
550+
551+--------------------------------------------------------------------------------
552+-- Deprecated functions
553+--------------------------------------------------------------------------------
554+
555+-- | Map a function over a 'Dynamic'.
556+{-# DEPRECATED mapDyn "Use 'return . fmap f' instead of 'mapDyn f'; consider eliminating monadic style" #-}
557+mapDyn :: (Reflex t, Monad m) => (a -> b) -> Dynamic t a -> m (Dynamic t b)
558+mapDyn f = return . fmap f
559+
560+-- | Flipped version of 'mapDyn'.
561+{-# DEPRECATED forDyn "Use 'return . ffor a' instead of 'forDyn a'; consider eliminating monadic style" #-}
562+forDyn :: (Reflex t, Monad m) => Dynamic t a -> (a -> b) -> m (Dynamic t b)
563+forDyn a = return . ffor a
564+
565+-- | Split the 'Dynamic' into two 'Dynamic's, each taking the respective value
566+-- of the tuple.
567+{-# DEPRECATED splitDyn "Use 'return . splitDynPure' instead; consider eliminating monadic style" #-}
568+splitDyn :: (Reflex t, Monad m) => Dynamic t (a, b) -> m (Dynamic t a, Dynamic t b)
569+splitDyn = return . splitDynPure
570+
571+-- | Merge the 'Dynamic' values using their 'Monoid' instance.
572+{-# DEPRECATED mconcatDyn "Use 'return . mconcat' instead; consider eliminating monadic style" #-}
573+mconcatDyn :: forall t m a. (Reflex t, Monad m, Monoid a) => [Dynamic t a] -> m (Dynamic t a)
574+mconcatDyn = return . mconcat
575+
576+-- | This function no longer needs to be monadic; see 'distributeMapOverDynPure'.
577+{-# DEPRECATED distributeDMapOverDyn "Use 'return . distributeDMapOverDynPure' instead; consider eliminating monadic style" #-}
578+distributeDMapOverDyn :: (Reflex t, Monad m, GCompare k) => DMap k (Dynamic t) -> m (Dynamic t (DMap k Identity))
579+distributeDMapOverDyn = return . distributeDMapOverDynPure
580+
581+-- | Merge two 'Dynamic's into a new one using the provided function. The new
582+-- 'Dynamic' changes its value each time one of the original 'Dynamic's changes
583+-- its value.
584+{-# DEPRECATED combineDyn "Use 'return (zipDynWith f a b)' instead of 'combineDyn f a b'; consider eliminating monadic style" #-}
585+combineDyn :: forall t m a b c. (Reflex t, Monad m) => (a -> b -> c) -> Dynamic t a -> Dynamic t b -> m (Dynamic t c)
586+combineDyn f a b = return $ zipDynWith f a b
587+
588+-- | A psuedo applicative version of ap for 'Dynamic'. Example useage:
589+--
590+-- > do
591+-- > person <- Person `mapDyn` dynFirstName
592+-- > `apDyn` dynListName
593+-- > `apDyn` dynAge
594+-- > `apDyn` dynAddress
595+{-# DEPRECATED apDyn "Use 'ffor m (<*> a)' instead of 'apDyn m a'; consider eliminating monadic style, since Dynamics are now Applicative and can be used with applicative style directly" #-}
596+#ifdef USE_TEMPLATE_HASKELL
597+{-# ANN apDyn "HLint: ignore Use fmap" #-}
598+#endif
599+apDyn :: forall t m a b. (Reflex t, Monad m)
600+ => m (Dynamic t (a -> b))
601+ -> Dynamic t a
602+ -> m (Dynamic t b)
603+apDyn m a = fmap (<*> a) m
604+
605+--TODO: The pattern of using hold (sample b0) can be reused in various places as a safe way of building certain kinds of Dynamics; see if we can factor this out
606+-- | This function no longer needs to be monadic, so it has been replaced by
607+-- 'demuxed', which is pure.
608+{-# DEPRECATED getDemuxed "Use 'return . demuxed d' instead of 'getDemuxed d'; consider eliminating monadic style" #-}
609+getDemuxed :: (Reflex t, Monad m, Eq k) => Demux t k -> k -> m (Dynamic t Bool)
610+getDemuxed d = return . demuxed d
611+
612+-- | This function no longer needs to be monadic, so it has been replaced by
613+-- 'distributeFHListOverDynPure', which is pure.
614+{-# DEPRECATED distributeFHListOverDyn "Use 'return . distributeFHListOverDynPure' instead; consider eliminating monadic style" #-}
615+distributeFHListOverDyn :: forall t m l. (Reflex t, Monad m, RebuildSortedHList l) => FHList (Dynamic t) l -> m (Dynamic t (HList l))
616+distributeFHListOverDyn = return . distributeFHListOverDynPure
617+
618+-- | This function no longer needs to be monadic, so it has been replaced by
619+-- 'collectDynPure', which is pure.
620+{-# DEPRECATED collectDyn "Use 'return . collectDynPure' instead; consider eliminating monadic style" #-}
621+collectDyn :: ( RebuildSortedHList (HListElems b)
622+ , IsHList a, IsHList b
623+ , AllAreFunctors (Dynamic t) (HListElems b)
624+ , Reflex t, Monad m
625+ , HListElems a ~ FunctorList (Dynamic t) (HListElems b)
626+ ) => a -> m (Dynamic t b)
627+collectDyn = return . collectDynPure
628+
629+-- | This function has been renamed to 'tagPromptlyDyn' to clarify its
630+-- semantics.
631+{-# DEPRECATED tagDyn "Use 'tagPromptlyDyn' instead" #-}
632+tagDyn :: Reflex t => Dynamic t a -> Event t b -> Event t a
633+tagDyn = tagPromptlyDyn
634+
635+-- | This function has been renamed to 'attachPromptlyDyn' to clarify its
636+-- semantics.
637+{-# DEPRECATED attachDyn "Use 'attachPromptlyDyn' instead" #-}
638+attachDyn :: Reflex t => Dynamic t a -> Event t b -> Event t (a, b)
639+attachDyn = attachPromptlyDyn
640+
641+-- | This function has been renamed to 'attachPromptlyDynWith' to clarify its
642+-- semantics.
643+{-# DEPRECATED attachDynWith "Use 'attachPromptlyDynWith' instead" #-}
644+attachDynWith :: Reflex t => (a -> b -> c) -> Dynamic t a -> Event t b -> Event t c
645+attachDynWith = attachPromptlyDynWith
646+
647+-- | This function has been renamed to 'attachPromptlyDynWithMaybe' to clarify
648+-- its semantics.
649+{-# DEPRECATED attachDynWithMaybe "Use 'attachPromptlyDynWithMaybe' instead" #-}
650+attachDynWithMaybe :: Reflex t => (a -> b -> Maybe c) -> Dynamic t a -> Event t b -> Event t c
651+attachDynWithMaybe = attachPromptlyDynWithMaybe
652+
653+-- | Combine an inner and outer 'Dynamic' such that the resulting 'Dynamic''s
654+-- current value will always be equal to the current value's current value, and
655+-- will change whenever either the inner or the outer (or both) values change.
656+{-# DEPRECATED joinDyn "Use 'join' instead" #-}
657+joinDyn :: Reflex t => Dynamic t (Dynamic t a) -> Dynamic t a
658+joinDyn = join
659+
660+-- | WARNING: This function is only pure if @a@'s 'Eq' instance tests
661+-- representational equality. Use 'holdUniqDyn' instead, which is pure in all
662+-- circumstances. Also, note that, unlike 'nub', this function does not prevent
663+-- all recurrences of a value, only consecutive recurrences.
664+{-# DEPRECATED nubDyn "Use 'holdUniqDyn' instead; note that it returns a MonadHold action rather than a pure Dynamic" #-}
665+nubDyn :: (Reflex t, Eq a) => Dynamic t a -> Dynamic t a
666+nubDyn = uniqDyn
667+
668+-- | WARNING: This function is only pure if @a@'s 'Eq' instance tests
669+-- representational equality. Use 'holdUniqDyn' instead, which is pure in all
670+-- circumstances.
671+{-# DEPRECATED uniqDyn "Use 'holdUniqDyn' instead; note that it returns a MonadHold action rather than a pure Dynamic" #-}
672+uniqDyn :: (Reflex t, Eq a) => Dynamic t a -> Dynamic t a
673+uniqDyn = uniqDynBy (==)
674+
675+-- | WARNING: This function is impure. Use 'holdUniqDynBy' instead.
676+{-# DEPRECATED uniqDynBy "Use 'holdUniqDynBy' instead; note that it returns a MonadHold action rather than a pure Dynamic" #-}
677+uniqDynBy :: Reflex t => (a -> a -> Bool) -> Dynamic t a -> Dynamic t a
678+uniqDynBy eq d =
679+ let e' = attachWithMaybe (\x x' -> if x' `eq` x then Nothing else Just x') (current d) (updated d)
680+ in unsafeDynamic (current d) e'
src/Reflex/Dynamic/TH.hs+26−2
@@ -13,6 +13,9 @@ module Reflex.Dynamic.TH
13 ( qDynPure
13 ( qDynPure
14 , unqDyn
14 , unqDyn
15 , mkDynPure
15 , mkDynPure
16+ -- * Deprecated functions
17+ , qDyn
18+ , mkDyn
16 ) where
19 ) where
17
20
18import Reflex.Dynamic
21import Reflex.Dynamic
@@ -20,7 +23,7 @@ import Reflex.Dynamic
20import Control.Monad.State
23import Control.Monad.State
21import Data.Data
24import Data.Data
22import Data.Generics
25import Data.Generics
23−import Data.Monoid ((<>))
26+import Data.Monoid
24import qualified Language.Haskell.Exts as Hs
27import qualified Language.Haskell.Exts as Hs
25import qualified Language.Haskell.Meta.Syntax.Translate as Hs
28import qualified Language.Haskell.Meta.Syntax.Translate as Hs
26import Language.Haskell.TH
29import Language.Haskell.TH
@@ -81,7 +84,7 @@ mkDynPure = QuasiQuoter
81 }
84 }
82
85
83mkDynExp :: String -> Q Exp
86mkDynExp :: String -> Q Exp
84−mkDynExp s = case Hs.parseExpWithMode Hs.defaultParseMode { Hs.extensions = [ Hs.EnableExtension Hs.TemplateHaskell ] } s of
87+mkDynExp s = case Hs.parseExpWithMode (Hs.defaultParseMode { Hs.extensions = [ Hs.EnableExtension Hs.TemplateHaskell ] }) s of
85 Hs.ParseFailed (Hs.SrcLoc _ l c) err -> fail $ "mkDyn:" <> show l <> ":" <> show c <> ": " <> err
88 Hs.ParseFailed (Hs.SrcLoc _ l c) err -> fail $ "mkDyn:" <> show l <> ":" <> show c <> ": " <> err
86 Hs.ParseOk e -> qDynPure $ return $ everywhere (id `extT` reinstateUnqDyn) $ Hs.toExp $ everywhere (id `extT` antiE) e
89 Hs.ParseOk e -> qDynPure $ return $ everywhere (id `extT` reinstateUnqDyn) $ Hs.toExp $ everywhere (id `extT` antiE) e
87 where TH.Name (TH.OccName occName) (TH.NameG _ _ (TH.ModName modName)) = 'unqMarker
90 where TH.Name (TH.OccName occName) (TH.NameG _ _ (TH.ModName modName)) = 'unqMarker
@@ -104,3 +107,24 @@ mkDynExp s = case Hs.parseExpWithMode Hs.defaultParseMode { Hs.extensions = [ Hs
104 reinstateUnqDyn (TH.Name (TH.OccName occName') (TH.NameQ (TH.ModName modName')))
107 reinstateUnqDyn (TH.Name (TH.OccName occName') (TH.NameQ (TH.ModName modName')))
105 | modName == modName' && occName == occName' = 'unqMarker
108 | modName == modName' && occName == occName' = 'unqMarker
106 reinstateUnqDyn x = x
109 reinstateUnqDyn x = x
110+
111+--------------------------------------------------------------------------------
112+-- Deprecated
113+--------------------------------------------------------------------------------
114+
115+{-# DEPRECATED qDyn "Instead of $(qDyn x), use return $(qDynPure x)" #-}
116+-- | Like 'qDynPure', but wraps its result monadically using 'return'. This is
117+-- no longer necessary, due to 'Dynamic' being an instance of 'Functor'.
118+qDyn :: Q Exp -> Q Exp
119+qDyn qe = [| return $(qDynPure qe) |]
120+
121+{-# DEPRECATED mkDyn "Instead of [mkDyn| x |], use return [mkDynPure| x |]" #-}
122+-- | Like 'mkDynPure', but wraps its result monadically using 'return'. This is
123+-- no longer necessary, due to 'Dynamic' being an instance of 'Functor'.
124+mkDyn :: QuasiQuoter
125+mkDyn = QuasiQuoter
126+ { quoteExp = \s -> [| return $(mkDynExp s) |]
127+ , quotePat = error "mkDyn: pattern splices are not supported"
128+ , quoteType = error "mkDyn: type splices are not supported"
129+ , quoteDec = error "mkDyn: declaration splices are not supported"
130+ }
src/Reflex/DynamicWriter/Base.hs+8−17
@@ -22,7 +22,6 @@ module Reflex.DynamicWriter.Base
22import Control.Monad.Exception
22import Control.Monad.Exception
23import Control.Monad.Identity
23import Control.Monad.Identity
24import Control.Monad.IO.Class
24import Control.Monad.IO.Class
25−import Control.Monad.Morph
26import Control.Monad.Primitive
25import Control.Monad.Primitive
27import Control.Monad.Reader
26import Control.Monad.Reader
28import Control.Monad.Ref
27import Control.Monad.Ref
@@ -36,7 +35,7 @@ import Data.IntMap (IntMap)
36import qualified Data.IntMap as IntMap
35import qualified Data.IntMap as IntMap
37import Data.Map (Map)
36import Data.Map (Map)
38import qualified Data.Map as Map
37import qualified Data.Map as Map
39−import Data.Semigroup (Semigroup(..))
38+import Data.Semigroup
40import Data.Some (Some)
39import Data.Some (Some)
41import Data.These
40import Data.These
42
41
@@ -45,13 +44,16 @@ import Reflex.Class
45import Reflex.DynamicWriter.Class
44import Reflex.DynamicWriter.Class
46import Reflex.EventWriter.Class (EventWriter, tellEvent)
45import Reflex.EventWriter.Class (EventWriter, tellEvent)
47import Reflex.Host.Class
46import Reflex.Host.Class
48−import qualified Data.Patch.MapWithMove as MapWithMove
47+import qualified Reflex.Patch.MapWithMove as MapWithMove
49import Reflex.PerformEvent.Class
48import Reflex.PerformEvent.Class
50import Reflex.PostBuild.Class
49import Reflex.PostBuild.Class
51import Reflex.Query.Class
50import Reflex.Query.Class
52import Reflex.Requester.Class
51import Reflex.Requester.Class
53import Reflex.TriggerEvent.Class
52import Reflex.TriggerEvent.Class
54
53
54+instance MonadTrans (DynamicWriterT t w) where
55+ lift = DynamicWriterT . lift
56+
55mapIncrementalMapValues :: (Reflex t, Patch (p v), Patch (p v'), PatchTarget (p v) ~ f v, PatchTarget (p v') ~ f v', Functor p, Functor f) => (v -> v') -> Incremental t (p v) -> Incremental t (p v')
57mapIncrementalMapValues :: (Reflex t, Patch (p v), Patch (p v'), PatchTarget (p v) ~ f v, PatchTarget (p v') ~ f v', Functor p, Functor f) => (v -> v') -> Incremental t (p v) -> Incremental t (p v')
56mapIncrementalMapValues f = unsafeMapIncremental (fmap f) (fmap f)
58mapIncrementalMapValues f = unsafeMapIncremental (fmap f) (fmap f)
57
59
@@ -86,20 +88,9 @@ mergeDynIncrementalWithMove a = unsafeBuildIncremental (mapM (sample . current)
86 noLongerMovedMap = Map.fromList $ fmap (, ()) noLongerMoved
88 noLongerMovedMap = Map.fromList $ fmap (, ()) noLongerMoved
87 in Map.differenceWith (\e _ -> Just $ MapWithMove.nodeInfoSetTo Nothing e) pWithNewVals noLongerMovedMap --TODO: Check if any in the second map are not covered?
89 in Map.differenceWith (\e _ -> Just $ MapWithMove.nodeInfoSetTo Nothing e) pWithNewVals noLongerMovedMap --TODO: Check if any in the second map are not covered?
88
90
89−-- | A basic implementation of 'DynamicWriter'.
91+-- | A basic implementation of 'MonadDynamicWriter'.
90newtype DynamicWriterT t w m a = DynamicWriterT { unDynamicWriterT :: StateT [Dynamic t w] m a }
92newtype DynamicWriterT t w m a = DynamicWriterT { unDynamicWriterT :: StateT [Dynamic t w] m a }
91− -- The list is kept in reverse order
93+ deriving (Functor, Applicative, Monad, MonadIO, MonadFix, MonadAsyncException, MonadException) -- The list is kept in reverse order
92− deriving
93− ( Functor
94− , Applicative
95− , Monad
96− , MonadTrans
97− , MFunctor
98− , MonadIO
99− , MonadFix
100− , MonadAsyncException
101− , MonadException
102− )
103
94
104deriving instance MonadHold t m => MonadHold t (DynamicWriterT t w m)
95deriving instance MonadHold t m => MonadHold t (DynamicWriterT t w m)
105deriving instance MonadSample t m => MonadSample t (DynamicWriterT t w m)
96deriving instance MonadSample t m => MonadSample t (DynamicWriterT t w m)
@@ -125,7 +116,7 @@ runDynamicWriterT (DynamicWriterT a) = do
125 (result, ws) <- runStateT a []
116 (result, ws) <- runStateT a []
126 return (result, mconcat $ reverse ws)
117 return (result, mconcat $ reverse ws)
127
118
128−instance (Monad m, Monoid w, Reflex t) => DynamicWriter t w (DynamicWriterT t w m) where
119+instance (Monad m, Monoid w, Reflex t) => MonadDynamicWriter t w (DynamicWriterT t w m) where
129 tellDyn w = DynamicWriterT $ modify (w :)
120 tellDyn w = DynamicWriterT $ modify (w :)
130
121
131instance MonadReader r m => MonadReader r (DynamicWriterT t w m) where
122instance MonadReader r m => MonadReader r (DynamicWriterT t w m) where
src/Reflex/DynamicWriter/Class.hs+6−10
@@ -1,28 +1,24 @@
1−-- | This module defines the 'DynamicWriter' class.
1+-- | This module defines the 'MonadDynamicWriter' class.
2−{-# LANGUAGE ConstraintKinds #-}
3{-# LANGUAGE CPP #-}
2{-# LANGUAGE CPP #-}
4{-# LANGUAGE FlexibleInstances #-}
3{-# LANGUAGE FlexibleInstances #-}
5{-# LANGUAGE FunctionalDependencies #-}
4{-# LANGUAGE FunctionalDependencies #-}
5+{-# LANGUAGE MultiParamTypeClasses #-}
6{-# LANGUAGE UndecidableInstances #-}
6{-# LANGUAGE UndecidableInstances #-}
7#ifdef USE_REFLEX_OPTIMIZER
7#ifdef USE_REFLEX_OPTIMIZER
8{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
8{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
9#endif
9#endif
10module Reflex.DynamicWriter.Class
10module Reflex.DynamicWriter.Class
11− ( MonadDynamicWriter
11+ ( MonadDynamicWriter (..)
12− , DynamicWriter(..)
13 ) where
12 ) where
14
13
15import Control.Monad.Reader (ReaderT, lift)
14import Control.Monad.Reader (ReaderT, lift)
16import Reflex.Class (Dynamic)
15import Reflex.Class (Dynamic)
17
16
18−{-# DEPRECATED MonadDynamicWriter "Use 'DynamicWriter' instead" #-}
19−-- | Type synonym for 'DynamicWriter'
20−type MonadDynamicWriter = DynamicWriter
21−
22-- | 'MonadDynamicWriter' efficiently collects 'Dynamic' values using 'tellDyn'
17-- | 'MonadDynamicWriter' efficiently collects 'Dynamic' values using 'tellDyn'
23-- and combines them monoidally to provide a 'Dynamic' result.
18-- and combines them monoidally to provide a 'Dynamic' result.
24−class (Monad m, Monoid w) => DynamicWriter t w m | m -> t w where
19+class (Monad m, Monoid w) => MonadDynamicWriter t w m | m -> t w where
25 tellDyn :: Dynamic t w -> m ()
20 tellDyn :: Dynamic t w -> m ()
26
21
27−instance DynamicWriter t w m => DynamicWriter t w (ReaderT r m) where
22+instance MonadDynamicWriter t w m => MonadDynamicWriter t w (ReaderT r m) where
28 tellDyn = lift . tellDyn
23 tellDyn = lift . tellDyn
24+
src/Reflex/EventWriter/Base.hs+8−19
@@ -25,7 +25,7 @@ module Reflex.EventWriter.Base
25import Reflex.Adjustable.Class
25import Reflex.Adjustable.Class
26import Reflex.Class
26import Reflex.Class
27import Reflex.EventWriter.Class (EventWriter, tellEvent)
27import Reflex.EventWriter.Class (EventWriter, tellEvent)
28−import Reflex.DynamicWriter.Class (DynamicWriter, tellDyn)
28+import Reflex.DynamicWriter.Class (MonadDynamicWriter, tellDyn)
29import Reflex.Host.Class
29import Reflex.Host.Class
30import Reflex.PerformEvent.Class
30import Reflex.PerformEvent.Class
31import Reflex.PostBuild.Class
31import Reflex.PostBuild.Class
@@ -35,14 +35,12 @@ import Reflex.TriggerEvent.Class
35
35
36import Control.Monad.Exception
36import Control.Monad.Exception
37import Control.Monad.Identity
37import Control.Monad.Identity
38−import Control.Monad.Morph
39import Control.Monad.Primitive
38import Control.Monad.Primitive
40import Control.Monad.Reader
39import Control.Monad.Reader
41import Control.Monad.Ref
40import Control.Monad.Ref
42import Control.Monad.State.Strict
41import Control.Monad.State.Strict
43−import Data.Dependent.Map (DMap)
42+import Data.Dependent.Map (DMap, DSum (..))
44import qualified Data.Dependent.Map as DMap
43import qualified Data.Dependent.Map as DMap
45−import Data.Dependent.Sum (DSum (..))
46import Data.Functor.Compose
44import Data.Functor.Compose
47import Data.Functor.Misc
45import Data.Functor.Misc
48import Data.GADT.Compare (GCompare (..), GEq (..), GOrdering (..))
46import Data.GADT.Compare (GCompare (..), GEq (..), GOrdering (..))
@@ -54,7 +52,7 @@ import qualified Data.Map as Map
54import Data.Semigroup
52import Data.Semigroup
55import Data.Some (Some)
53import Data.Some (Some)
56import Data.Tuple
54import Data.Tuple
57−import Data.Type.Equality
55+import Data.Type.Equality hiding (apply)
58
56
59import Unsafe.Coerce
57import Unsafe.Coerce
60
58
@@ -98,17 +96,7 @@ data EventWriterState t w = EventWriterState
98
96
99-- | A basic implementation of 'EventWriter'.
97-- | A basic implementation of 'EventWriter'.
100newtype EventWriterT t w m a = EventWriterT { unEventWriterT :: StateT (EventWriterState t w) m a }
98newtype EventWriterT t w m a = EventWriterT { unEventWriterT :: StateT (EventWriterState t w) m a }
101− deriving
99+ deriving (Functor, Applicative, Monad, MonadFix, MonadIO, MonadException, MonadAsyncException)
102− ( Functor
103− , Applicative
104− , Monad
105− , MonadTrans
106− , MFunctor
107− , MonadFix
108− , MonadIO
109− , MonadException
110− , MonadAsyncException
111− )
112
100
113-- | Run a 'EventWriterT' action.
101-- | Run a 'EventWriterT' action.
114runEventWriterT :: forall t m w a. (Reflex t, Monad m, Semigroup w) => EventWriterT t w m a -> m (a, Event t w)
102runEventWriterT :: forall t m w a. (Reflex t, Monad m, Semigroup w) => EventWriterT t w m a -> m (a, Event t w)
@@ -128,6 +116,9 @@ instance (Reflex t, Monad m, Semigroup w) => EventWriter t w (EventWriterT t w m
128 , _eventWriterState_told = (tellId myId :=> w) : _eventWriterState_told old
116 , _eventWriterState_told = (tellId myId :=> w) : _eventWriterState_told old
129 }
117 }
130
118
119+instance MonadTrans (EventWriterT t w) where
120+ lift = EventWriterT . lift
121+
131instance MonadSample t m => MonadSample t (EventWriterT t w m) where
122instance MonadSample t m => MonadSample t (EventWriterT t w m) where
132 sample = lift . sample
123 sample = lift . sample
133
124
@@ -142,8 +133,6 @@ instance MonadHold t m => MonadHold t (EventWriterT t w m) where
142 buildDynamic a0 = lift . buildDynamic a0
133 buildDynamic a0 = lift . buildDynamic a0
143 {-# INLINABLE headE #-}
134 {-# INLINABLE headE #-}
144 headE = lift . headE
135 headE = lift . headE
145− {-# INLINABLE now #-}
146− now = lift now
147
136
148instance (Reflex t, Adjustable t m, MonadHold t m, Semigroup w) => Adjustable t (EventWriterT t w m) where
137instance (Reflex t, Adjustable t m, MonadHold t m, Semigroup w) => Adjustable t (EventWriterT t w m) where
149 runWithReplace = runWithReplaceEventWriterTWith $ \dm0 dm' -> lift $ runWithReplace dm0 dm'
138 runWithReplace = runWithReplaceEventWriterTWith $ \dm0 dm' -> lift $ runWithReplace dm0 dm'
@@ -289,7 +278,7 @@ instance (MonadQuery t q m, Monad m) => MonadQuery t q (EventWriterT t w m) wher
289 askQueryResult = lift askQueryResult
278 askQueryResult = lift askQueryResult
290 queryIncremental = lift . queryIncremental
279 queryIncremental = lift . queryIncremental
291
280
292−instance DynamicWriter t w m => DynamicWriter t w (EventWriterT t v m) where
281+instance MonadDynamicWriter t w m => MonadDynamicWriter t w (EventWriterT t v m) where
293 tellDyn = lift . tellDyn
282 tellDyn = lift . tellDyn
294
283
295instance PrimMonad m => PrimMonad (EventWriterT t w m) where
284instance PrimMonad m => PrimMonad (EventWriterT t w m) where
src/Reflex/EventWriter/Class.hs+1
@@ -2,6 +2,7 @@
2{-# LANGUAGE CPP #-}
2{-# LANGUAGE CPP #-}
3{-# LANGUAGE FlexibleInstances #-}
3{-# LANGUAGE FlexibleInstances #-}
4{-# LANGUAGE FunctionalDependencies #-}
4{-# LANGUAGE FunctionalDependencies #-}
5+{-# LANGUAGE MultiParamTypeClasses #-}
5{-# LANGUAGE UndecidableInstances #-}
6{-# LANGUAGE UndecidableInstances #-}
6#ifdef USE_REFLEX_OPTIMIZER
7#ifdef USE_REFLEX_OPTIMIZER
7{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
8{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
src/Reflex/FastWeak.hs+6−20
@@ -6,18 +6,14 @@
6{-# LANGUAGE JavaScriptFFI #-}
6{-# LANGUAGE JavaScriptFFI #-}
7#endif
7#endif
8
8
9−-- |
10−-- Module:
11−-- Reflex.FastWeak
12−-- Description:
13−-- 'FastWeak' is a weak pointer to some value, and 'FastWeakTicket' ensures the value
9+-- | 'FastWeak' is a weak pointer to some value, and 'FastWeakTicket' ensures the value
14−-- referred to by a 'FastWeak' stays live while the ticket is held (live).
10+-- referred to by a 'FastWeak' stays live while the ticket is held (live).
15--
11--
16−-- On GHC or GHCJS when not built with the @fast-weak@ cabal flag, 'FastWeak' is a wrapper
12+-- On GHC or GHCJS when not built with the @fast-weak@ cabal flag, 'FastWeak' is a wrapper
17−-- around the simple version of 'System.Mem.Weak.Weak' where the key and value are the same.
13+-- around the simple version of 'System.Mem.Weak.Weak' where the key and value are the same.
18--
14--
19−-- On GHCJS when built with the @fast-weak@ cabal flag, 'FastWeak' is implemented directly
15+-- On GHCJS when built with the @fast-weak@ cabal flag, 'FastWeak' is implemented directly
20−-- in JS using @h$FastWeak@ and @h$FastWeakTicket@ which are a nonstandard part of the GHCJS RTS.
16+-- in JS using @h$FastWeak@ and @h$FastWeakTicket@ which are a nonstandard part of the GHCJS RTS.
21module Reflex.FastWeak
17module Reflex.FastWeak
22 ( FastWeakTicket
18 ( FastWeakTicket
23 , FastWeak
19 , FastWeak
@@ -151,16 +147,6 @@ getFastWeakTicket w = do
151
147
152-- | Create a 'FastWeakTicket' directly from a value, creating a 'FastWeak' in the process
148-- | Create a 'FastWeakTicket' directly from a value, creating a 'FastWeak' in the process
153-- which can be obtained with 'getFastWeakTicketValue'.
149-- which can be obtained with 'getFastWeakTicketValue'.
154−--
155−-- This function is marked NOINLINE so it is opaque to GHC.
156−-- If we do not do this, then GHC will sometimes fuse the constructor away
157−-- so any weak references that are attached to the ticket will have their
158−-- finalizer run. Using the opaque constructor, GHC does not see the
159−-- constructor application, so it behaves like an IORef and cannot be fused away.
160−--
161−-- The result is also evaluated to WHNF, since forcing a thunk invalidates
162−-- the weak pointer to it in some cases.
163−{-# NOINLINE mkFastWeakTicket #-}
164mkFastWeakTicket :: a -> IO (FastWeakTicket a)
150mkFastWeakTicket :: a -> IO (FastWeakTicket a)
165-- I think it's fine if this is lazy - it'll retain the 'a', but so would the output; we just need to make sure it's forced before we start relying on the
151-- I think it's fine if this is lazy - it'll retain the 'a', but so would the output; we just need to make sure it's forced before we start relying on the
166-- associated FastWeak to actually be weak
152-- associated FastWeak to actually be weak
src/Reflex/FunctorMaybe.hs+21−25
@@ -1,47 +1,43 @@
1−{-# LANGUAGE CPP #-}
2−#if MIN_VERSION_base(4,9,0)
3−{-# LANGUAGE GeneralizedNewtypeDeriving #-}
4−{-# LANGUAGE StandaloneDeriving #-}
5−#endif
6−
7−-- |
8−-- Module:
9−-- Reflex.FunctorMaybe
10−-- Description:
11−-- This module defines the FunctorMaybe class, which extends Functors with the
1+-- | This module defines the FunctorMaybe class, which extends Functors with the
12−-- ability to delete values.
2+-- ability to delete values.
13module Reflex.FunctorMaybe
3module Reflex.FunctorMaybe
14 ( FunctorMaybe (..)
4 ( FunctorMaybe (..)
15 ) where
5 ) where
16
6
17import Data.IntMap (IntMap)
7import Data.IntMap (IntMap)
8+import qualified Data.IntMap as IntMap
18import Data.Map (Map)
9import Data.Map (Map)
19−#if MIN_VERSION_base(4,9,0)
10+import qualified Data.Map as Map
20−import Data.Semigroup (Option(..))
21−#endif
22−import Data.Witherable
11+import Data.Maybe
23
12
24--TODO: See if there's a better class in the standard libraries already
13--TODO: See if there's a better class in the standard libraries already
25
14
26-- | A class for values that combines filtering and mapping using 'Maybe'.
15-- | A class for values that combines filtering and mapping using 'Maybe'.
27−-- Morally, @'FunctorMaybe' ~ KleisliFunctor 'Maybe'@.
16+-- Morally, @'FunctorMaybe' ~ KleisliFunctor 'Maybe'@. Also similar is the
28−{-# DEPRECATED FunctorMaybe "Use 'Filterable' from Data.Witherable instead" #-}
17+-- @Witherable@ typeclass, but it requires @Foldable f@ and @Traverable f@,
18+-- and e.g. 'Event' is instance of neither.
19+--
20+-- A definition of 'fmapMaybe' must satisfy the following laws:
21+--
22+-- [/identity/]
23+-- @'fmapMaybe' 'Just' ≡ 'id'@
24+--
25+-- [/composition/]
26+-- @'fmapMaybe' (f <=< g) ≡ 'fmapMaybe' f . 'fmapMaybe' g@
29class FunctorMaybe f where
27class FunctorMaybe f where
30 -- | Combined mapping and filtering function.
28 -- | Combined mapping and filtering function.
31 fmapMaybe :: (a -> Maybe b) -> f a -> f b
29 fmapMaybe :: (a -> Maybe b) -> f a -> f b
32
30
31+-- | @fmapMaybe = (=<<)
33instance FunctorMaybe Maybe where
32instance FunctorMaybe Maybe where
34− fmapMaybe = mapMaybe
33+ fmapMaybe = (=<<)
35−
36−#if MIN_VERSION_base(4,9,0)
37−deriving instance FunctorMaybe Option
38−#endif
39
34
35+-- | @fmapMaybe = mapMaybe@
40instance FunctorMaybe [] where
36instance FunctorMaybe [] where
41 fmapMaybe = mapMaybe
37 fmapMaybe = mapMaybe
42
38
43instance FunctorMaybe (Map k) where
39instance FunctorMaybe (Map k) where
44− fmapMaybe = mapMaybe
40+ fmapMaybe = Map.mapMaybe
45
41
46instance FunctorMaybe IntMap where
42instance FunctorMaybe IntMap where
47− fmapMaybe = mapMaybe
43+ fmapMaybe = IntMap.mapMaybe
src/Reflex/Host/Class.hs+1
@@ -4,6 +4,7 @@
4{-# LANGUAGE FlexibleInstances #-}
4{-# LANGUAGE FlexibleInstances #-}
5{-# LANGUAGE FunctionalDependencies #-}
5{-# LANGUAGE FunctionalDependencies #-}
6{-# LANGUAGE GADTs #-}
6{-# LANGUAGE GADTs #-}
7+{-# LANGUAGE MultiParamTypeClasses #-}
7{-# LANGUAGE RankNTypes #-}
8{-# LANGUAGE RankNTypes #-}
8{-# LANGUAGE RoleAnnotations #-}
9{-# LANGUAGE RoleAnnotations #-}
9{-# LANGUAGE ScopedTypeVariables #-}
10{-# LANGUAGE ScopedTypeVariables #-}
src/Reflex/Host/Headless.hsdeleted−128
@@ -1,128 +0,0 @@
1−{-# LANGUAGE LambdaCase #-}
2−{-# LANGUAGE FlexibleContexts #-}
3−{-# LANGUAGE RankNTypes #-}
4−{-# LANGUAGE TypeFamilies #-}
5−{-# LANGUAGE ConstraintKinds #-}
6−
7−module Reflex.Host.Headless where
8−
9−import Control.Concurrent.Chan (newChan, readChan)
10−import Control.Monad (unless)
11−import Control.Monad.Fix (MonadFix, fix)
12−import Control.Monad.IO.Class (MonadIO, liftIO)
13−import Control.Monad.Primitive (PrimMonad)
14−import Control.Monad.Ref (MonadRef, Ref, readRef)
15−import Data.Dependent.Sum (DSum (..), (==>))
16−import Data.Foldable (for_)
17−import Data.Functor.Identity (Identity(..))
18−import Data.IORef (IORef, readIORef)
19−import Data.Maybe (catMaybes, fromMaybe)
20−import Data.Traversable (for)
21−
22−import Reflex
23−import Reflex.Host.Class
24−
25−type MonadHeadlessApp t m =
26− ( Adjustable t m
27− , MonadFix m
28− , MonadHold t m
29− , MonadIO (HostFrame t)
30− , MonadIO (Performable m)
31− , MonadIO m
32− , MonadRef (HostFrame t)
33− , NotReady t m
34− , PerformEvent t m
35− , PostBuild t m
36− , PrimMonad (HostFrame t)
37− , Ref (HostFrame t) ~ IORef
38− , Ref m ~ IORef
39− , Reflex t
40− , ReflexHost t
41− , TriggerEvent t m
42− )
43−
44−-- | Run a headless FRP network. Inside the action, you will most probably use
45−-- the capabilities provided by the 'TriggerEvent' and 'PerformEvent' type
46−-- classes to interface the FRP network with the outside world. Useful for
47−-- testing. Each headless network runs on its own spider timeline.
48−runHeadlessApp
49− :: (forall t m. MonadHeadlessApp t m => m (Event t ()))
50− -- ^ The action to be run in the headless FRP network. The FRP network is
51− -- closed at the first occurrence of the resulting 'Event'.
52− -> IO ()
53−runHeadlessApp guest =
54− -- We are using the 'Spider' implementation of reflex. Running the host
55− -- allows us to take actions on the FRP timeline.
56− withSpiderTimeline $ runSpiderHostForTimeline $ do
57− -- Create the "post-build" event and associated trigger. This event fires
58− -- once, when the application starts.
59− (postBuild, postBuildTriggerRef) <- newEventWithTriggerRef
60− -- Create a queue to which we will write 'Event's that need to be
61− -- processed.
62− events <- liftIO newChan
63− -- Run the "guest" application, providing the appropriate context. We'll
64− -- pure the result of the action, and a 'FireCommand' that will be used to
65− -- trigger events.
66− (result, fc@(FireCommand fire)) <- do
67− hostPerformEventT $ -- Allows the guest app to run
68− -- 'performEvent', so that actions
69− -- (e.g., IO actions) can be run when
70− -- 'Event's fire.
71−
72− flip runPostBuildT postBuild $ -- Allows the guest app to access to
73− -- a "post-build" 'Event'
74−
75− flip runTriggerEventT events $ -- Allows the guest app to create new
76− -- events and triggers and write
77− -- those triggers to a channel from
78− -- which they will be read and
79− -- processed.
80− guest
81−
82− -- Read the trigger reference for the post-build event. This will be
83− -- 'Nothing' if the guest application hasn't subscribed to this event.
84− mPostBuildTrigger <- readRef postBuildTriggerRef
85−
86− -- Subscribe to an 'Event' of that the guest application can use to
87− -- request application shutdown. We'll check whether this 'Event' is firing
88− -- to determine whether to terminate.
89− shutdown <- subscribeEvent result
90−
91− -- When there is a subscriber to the post-build event, fire the event.
92− soa <- for mPostBuildTrigger $ \postBuildTrigger ->
93− fire [postBuildTrigger :=> Identity ()] $ isFiring shutdown
94−
95− -- The main application loop. We wait for new events and fire those that
96− -- have subscribers. If we detect a shutdown request, the application
97− -- terminates.
98− unless (or (fromMaybe [] soa)) $ fix $ \loop -> do
99− -- Read the next event (blocking).
100− ers <- liftIO $ readChan events
101− stop <- do
102− -- Fire events that have subscribers.
103− fireEventTriggerRefs fc ers $
104− -- Check if the shutdown 'Event' is firing.
105− isFiring shutdown
106− if or stop
107− then pure ()
108− else loop
109− where
110− isFiring ev = readEvent ev >>= \case
111− Nothing -> pure False
112− Just _ -> pure True
113− -- Use the given 'FireCommand' to fire events that have subscribers
114− -- and call the callback for the 'TriggerInvocation' of each.
115− fireEventTriggerRefs
116− :: MonadIO m
117− => FireCommand t m
118− -> [DSum (EventTriggerRef t) TriggerInvocation]
119− -> ReadPhase m a
120− -> m [a]
121− fireEventTriggerRefs (FireCommand fire) ers rcb = do
122− mes <- liftIO $
123− for ers $ \(EventTriggerRef er :=> TriggerInvocation a _) -> do
124− me <- readIORef er
125− pure $ fmap (==> a) me
126− a <- fire (catMaybes mes) rcb
127− liftIO $ for_ ers $ \(_ :=> TriggerInvocation _ cb) -> cb
128− pure a
src/Reflex/Network.hs+4−10
@@ -3,11 +3,6 @@
3#ifdef USE_REFLEX_OPTIMIZER
3#ifdef USE_REFLEX_OPTIMIZER
4{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
4{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
5#endif
5#endif
6−-- |
7−-- Module:
8−-- Reflex.Network
9−-- Description:
10−-- This module provides combinators for building FRP graphs/networks and modifying them dynamically.
11module Reflex.Network
6module Reflex.Network
12 ( networkView
7 ( networkView
13 , networkHold
8 , networkHold
@@ -19,17 +14,16 @@ import Reflex.Adjustable.Class
19import Reflex.NotReady.Class
14import Reflex.NotReady.Class
20import Reflex.PostBuild.Class
15import Reflex.PostBuild.Class
21
16
22−-- | A 'Dynamic' "network": Takes a 'Dynamic' of network-creating actions and replaces the network whenever the 'Dynamic' updates.
17+-- | Given a Dynamic of network-creating actions, create a network that is recreated whenever the Dynamic updates.
23−-- The returned Event of network results fires at post-build time and when the 'Dynamic' updates.
18+-- The returned Event of network results occurs when the Dynamic does.
24−-- Note: Often, the type 'a' is an Event, in which case the return value is an Event-of-Events, where the outer 'Event' fires
19+-- Note: Often, the type 'a' is an Event, in which case the return value is an Event-of-Events that would typically be flattened (via 'switchPromptly').
25−-- when switching networks. Such an 'Event' would typically be flattened (via 'switchPromptly').
26networkView :: (NotReady t m, Adjustable t m, PostBuild t m) => Dynamic t (m a) -> m (Event t a)
20networkView :: (NotReady t m, Adjustable t m, PostBuild t m) => Dynamic t (m a) -> m (Event t a)
27networkView child = do
21networkView child = do
28 postBuild <- getPostBuild
22 postBuild <- getPostBuild
29 let newChild = leftmost [updated child, tagCheap (current child) postBuild]
23 let newChild = leftmost [updated child, tagCheap (current child) postBuild]
30 snd <$> runWithReplace notReady newChild
24 snd <$> runWithReplace notReady newChild
31
25
32−-- | Given an initial "network" and an 'Event' of network-creating actions, create a network that is recreated whenever the Event fires.
26+-- | Given an initial network and an Event of network-creating actions, create a network that is recreated whenever the Event fires.
33-- The returned Dynamic of network results occurs when the Event does.
27-- The returned Dynamic of network results occurs when the Event does.
34-- Note: Often, the type 'a' is an Event, in which case the return value is a Dynamic-of-Events that would typically be flattened.
28-- Note: Often, the type 'a' is an Event, in which case the return value is a Dynamic-of-Events that would typically be flattened.
35networkHold :: (Adjustable t m, MonadHold t m) => m a -> Event t (m a) -> m (Dynamic t a)
29networkHold :: (Adjustable t m, MonadHold t m) => m a -> Event t (m a) -> m (Dynamic t a)
src/Reflex/NotReady/Class.hs+1−10
@@ -3,6 +3,7 @@
3{-# LANGUAGE FlexibleContexts #-}
3{-# LANGUAGE FlexibleContexts #-}
4{-# LANGUAGE FlexibleInstances #-}
4{-# LANGUAGE FlexibleInstances #-}
5{-# LANGUAGE FunctionalDependencies #-}
5{-# LANGUAGE FunctionalDependencies #-}
6+{-# LANGUAGE MultiParamTypeClasses #-}
6{-# LANGUAGE TypeFamilies #-}
7{-# LANGUAGE TypeFamilies #-}
7{-# LANGUAGE UndecidableInstances #-}
8{-# LANGUAGE UndecidableInstances #-}
8#ifdef USE_REFLEX_OPTIMIZER
9#ifdef USE_REFLEX_OPTIMIZER
@@ -14,9 +15,7 @@ module Reflex.NotReady.Class
14
15
15import Control.Monad.Reader (ReaderT)
16import Control.Monad.Reader (ReaderT)
16import Control.Monad.Trans
17import Control.Monad.Trans
17−import Control.Monad.Trans.Writer (WriterT)
18
18
19−import Reflex.BehaviorWriter.Base (BehaviorWriterT)
20import Reflex.Class
19import Reflex.Class
21import Reflex.DynamicWriter.Base (DynamicWriterT)
20import Reflex.DynamicWriter.Base (DynamicWriterT)
22import Reflex.EventWriter.Base (EventWriterT)
21import Reflex.EventWriter.Base (EventWriterT)
@@ -40,10 +39,6 @@ instance NotReady t m => NotReady t (ReaderT r m) where
40 notReadyUntil = lift . notReadyUntil
39 notReadyUntil = lift . notReadyUntil
41 notReady = lift notReady
40 notReady = lift notReady
42
41
43−instance (NotReady t m, Monoid w) => NotReady t (WriterT w m) where
44− notReadyUntil = lift . notReadyUntil
45− notReady = lift notReady
46−
47instance NotReady t m => NotReady t (PostBuildT t m) where
42instance NotReady t m => NotReady t (PostBuildT t m) where
48 notReadyUntil = lift . notReadyUntil
43 notReadyUntil = lift . notReadyUntil
49 notReady = lift notReady
44 notReady = lift notReady
@@ -56,10 +51,6 @@ instance NotReady t m => NotReady t (DynamicWriterT t w m) where
56 notReadyUntil = lift . notReadyUntil
51 notReadyUntil = lift . notReadyUntil
57 notReady = lift notReady
52 notReady = lift notReady
58
53
59−instance NotReady t m => NotReady t (BehaviorWriterT t w m) where
60− notReadyUntil = lift . notReadyUntil
61− notReady = lift notReady
62−
63instance NotReady t m => NotReady t (QueryT t q m) where
54instance NotReady t m => NotReady t (QueryT t q m) where
64 notReadyUntil = lift . notReadyUntil
55 notReadyUntil = lift . notReadyUntil
65 notReady = lift notReady
56 notReady = lift notReady
src/Reflex/Optimizer.hs+4−8
@@ -1,14 +1,10 @@
1+-- | This module provides a GHC plugin designed to improve code that uses
2+-- Reflex. Currently, it just adds an INLINABLE pragma to any top-level
3+-- definition that doesn't have an explicit inlining pragma. In the future,
4+-- additional optimizations are likely to be added.
1{-# LANGUAGE CPP #-}
5{-# LANGUAGE CPP #-}
2{-# LANGUAGE LambdaCase #-}
6{-# LANGUAGE LambdaCase #-}
3{-# LANGUAGE OverloadedStrings #-}
7{-# LANGUAGE OverloadedStrings #-}
4−-- |
5−-- Module:
6−-- Reflex.Optimizer
7−-- Description:
8−-- This module provides a GHC plugin designed to improve code that uses
9−-- Reflex. Currently, it just adds an INLINABLE pragma to any top-level
10−-- definition that doesn't have an explicit inlining pragma. In the future,
11−-- additional optimizations are likely to be added.
12module Reflex.Optimizer
8module Reflex.Optimizer
13 ( plugin
9 ( plugin
14 ) where
10 ) where
src/Reflex/Patch.hsnew file+39
@@ -0,0 +1,39 @@
1+-- | This module defines the 'Patch' class, which is used by Reflex to manage
2+-- changes to 'Reflex.Class.Incremental' values.
3+{-# LANGUAGE TypeFamilies #-}
4+module Reflex.Patch
5+ ( module Reflex.Patch
6+ , module X
7+ ) where
8+
9+import Reflex.Patch.Class as X
10+import Reflex.Patch.DMap as X hiding (getDeletions)
11+import Reflex.Patch.DMapWithMove as X (PatchDMapWithMove, const2PatchDMapWithMoveWith, mapPatchDMapWithMove,
12+ patchDMapWithMoveToPatchMapWithMoveWith,
13+ traversePatchDMapWithMoveWithKey, unPatchDMapWithMove,
14+ unsafePatchDMapWithMove, weakenPatchDMapWithMoveWith)
15+import Reflex.Patch.IntMap as X hiding (getDeletions)
16+import Reflex.Patch.Map as X
17+import Reflex.Patch.MapWithMove as X (PatchMapWithMove, patchMapWithMoveNewElements,
18+ patchMapWithMoveNewElementsMap, unPatchMapWithMove,
19+ unsafePatchMapWithMove)
20+
21+import Data.Semigroup (Semigroup (..), (<>))
22+
23+---- Patches based on commutative groups
24+
25+-- | A 'Group' is a 'Monoid' where every element has an inverse.
26+class (Semigroup q, Monoid q) => Group q where
27+ negateG :: q -> q
28+ (~~) :: q -> q -> q
29+ r ~~ s = r <> negateG s
30+
31+-- | An 'Additive' 'Semigroup' is one where (<>) is commutative
32+class Semigroup q => Additive q where
33+
34+-- | The elements of an 'Additive' 'Semigroup' can be considered as patches of their own type.
35+newtype AdditivePatch p = AdditivePatch { unAdditivePatch :: p }
36+
37+instance Additive p => Patch (AdditivePatch p) where
38+ type PatchTarget (AdditivePatch p) = p
39+ apply (AdditivePatch p) q = Just $ p <> q
src/Reflex/Patch/Class.hsnew file+34
@@ -0,0 +1,34 @@
1+{-# LANGUAGE TypeFamilies #-}
2+-- | The interface for types which represent changes made to other types
3+module Reflex.Patch.Class where
4+
5+import Control.Monad.Identity
6+import Data.Maybe
7+import Data.Semigroup
8+
9+-- | A 'Patch' type represents a kind of change made to a datastructure.
10+--
11+-- If an instance of 'Patch' is also an instance of 'Semigroup', it should obey
12+-- the law that @applyAlways (f <> g) == applyAlways f . applyAlways g@.
13+class Patch p where
14+ type PatchTarget p :: *
15+ -- | Apply the patch @p a@ to the value @a@. If no change is needed, return
16+ -- 'Nothing'.
17+ apply :: p -> PatchTarget p -> Maybe (PatchTarget p)
18+
19+-- | Apply a 'Patch'; if it does nothing, return the original value
20+applyAlways :: Patch p => p -> PatchTarget p -> PatchTarget p
21+applyAlways p t = fromMaybe t $ apply p t
22+
23+-- | 'Identity' can be used as a 'Patch' that always fully replaces the value
24+instance Patch (Identity a) where
25+ type PatchTarget (Identity a) = a
26+ apply (Identity a) _ = Just a
27+
28+-- | Like '(.)', but composes functions that return patches rather than
29+-- functions that return new values. The Semigroup instance for patches must
30+-- apply patches right-to-left, like '(.)'.
31+composePatchFunctions :: (Patch p, Semigroup p) => (PatchTarget p -> p) -> (PatchTarget p -> p) -> PatchTarget p -> p
32+composePatchFunctions g f a =
33+ let fp = f a
34+ in g (applyAlways fp a) <> fp
src/Reflex/Patch/DMap.hsnew file+82
@@ -0,0 +1,82 @@
1+{-# LANGUAGE GeneralizedNewtypeDeriving #-}
2+{-# LANGUAGE LambdaCase #-}
3+{-# LANGUAGE PolyKinds #-}
4+{-# LANGUAGE Rank2Types #-}
5+{-# LANGUAGE ScopedTypeVariables #-}
6+{-# LANGUAGE StandaloneDeriving #-}
7+{-# LANGUAGE TypeFamilies #-}
8+-- | 'Patch'es on 'DMap' that consist only of insertions (or overwrites) and deletions.
9+module Reflex.Patch.DMap where
10+
11+import Reflex.Patch.Class
12+import Reflex.Patch.IntMap
13+import Reflex.Patch.Map
14+
15+import Data.Dependent.Map (DMap, DSum (..), GCompare (..))
16+import qualified Data.Dependent.Map as DMap
17+import Data.Functor.Constant
18+import Data.Functor.Misc
19+import qualified Data.IntMap as IntMap
20+import qualified Data.Map as Map
21+import Data.Semigroup (Semigroup (..))
22+import Data.Some (Some)
23+
24+-- | A set of changes to a 'DMap'. Any element may be inserted/updated or deleted.
25+-- Insertions are represented as @'ComposeMaybe' (Just value)@,
26+-- while deletions are represented as @'ComposeMaybe' Nothing@.
27+newtype PatchDMap k v = PatchDMap { unPatchDMap :: DMap k (ComposeMaybe v) }
28+
29+deriving instance GCompare k => Semigroup (PatchDMap k v)
30+
31+deriving instance GCompare k => Monoid (PatchDMap k v)
32+
33+-- | Apply the insertions or deletions to a given 'DMap'.
34+instance GCompare k => Patch (PatchDMap k v) where
35+ type PatchTarget (PatchDMap k v) = DMap k v
36+ apply (PatchDMap diff) old = Just $! insertions `DMap.union` (old `DMap.difference` deletions) --TODO: return Nothing sometimes --Note: the strict application here is critical to ensuring that incremental merges don't hold onto all their prerequisite events forever; can we make this more robust?
37+ where insertions = DMap.mapMaybeWithKey (const $ getComposeMaybe) diff
38+ deletions = DMap.mapMaybeWithKey (const $ nothingToJust . getComposeMaybe) diff
39+ nothingToJust = \case
40+ Nothing -> Just $ Constant ()
41+ Just _ -> Nothing
42+
43+-- | Map a function @v a -> v' a@ over any inserts/updates in the given
44+-- @'PatchDMap' k v@ to produce a @'PatchDMap' k v'@.
45+mapPatchDMap :: (forall a. v a -> v' a) -> PatchDMap k v -> PatchDMap k v'
46+mapPatchDMap f (PatchDMap p) = PatchDMap $ DMap.map (ComposeMaybe . fmap f . getComposeMaybe) p
47+
48+-- | Map an effectful function @v a -> f (v' a)@ over any inserts/updates in the given
49+-- @'PatchDMap' k v@ to produce a @'PatchDMap' k v'@.
50+traversePatchDMap :: Applicative f => (forall a. v a -> f (v' a)) -> PatchDMap k v -> f (PatchDMap k v')
51+traversePatchDMap f = traversePatchDMapWithKey $ const f
52+
53+-- | Map an effectful function @k a -> v a -> f (v' a)@ over any inserts/updates
54+-- in the given @'PatchDMap' k v@ to produce a @'PatchDMap' k v'@.
55+traversePatchDMapWithKey :: Applicative m => (forall a. k a -> v a -> m (v' a)) -> PatchDMap k v -> m (PatchDMap k v')
56+traversePatchDMapWithKey f (PatchDMap p) = PatchDMap <$> DMap.traverseWithKey (\k (ComposeMaybe v) -> ComposeMaybe <$> traverse (f k) v) p
57+
58+-- | Weaken a @'PatchDMap' k v@ to a @'PatchMap' (Some k) v'@ using a function
59+-- @v a -> v'@ to weaken each value contained in the patch.
60+weakenPatchDMapWith :: (forall a. v a -> v') -> PatchDMap k v -> PatchMap (Some k) v'
61+weakenPatchDMapWith f (PatchDMap p) = PatchMap $ weakenDMapWith (fmap f . getComposeMaybe) p
62+
63+-- | Convert a weak @'PatchDMap' ('Const2' k a) v@ where the @a@ is known by way of
64+-- the @Const2@ into a @'PatchMap' k v'@ using a rank 1 function @v a -> v'@.
65+patchDMapToPatchMapWith :: (v a -> v') -> PatchDMap (Const2 k a) v -> PatchMap k v'
66+patchDMapToPatchMapWith f (PatchDMap p) = PatchMap $ dmapToMapWith (fmap f . getComposeMaybe) p
67+
68+-- | Convert a @'PatchMap' k v@ into a @'PatchDMap' ('Const2' k a) v'@ using a function @v -> v' a@.
69+const2PatchDMapWith :: forall k v v' a. (v -> v' a) -> PatchMap k v -> PatchDMap (Const2 k a) v'
70+const2PatchDMapWith f (PatchMap p) = PatchDMap $ DMap.fromDistinctAscList $ g <$> Map.toAscList p
71+ where g :: (k, Maybe v) -> DSum (Const2 k a) (ComposeMaybe v')
72+ g (k, e) = Const2 k :=> ComposeMaybe (f <$> e)
73+
74+-- | Convert a @'PatchIntMap' v@ into a @'PatchDMap' ('Const2' Int a) v'@ using a function @v -> v' a@.
75+const2IntPatchDMapWith :: forall v f a. (v -> f a) -> PatchIntMap v -> PatchDMap (Const2 IntMap.Key a) f
76+const2IntPatchDMapWith f (PatchIntMap p) = PatchDMap $ DMap.fromDistinctAscList $ g <$> IntMap.toAscList p
77+ where g :: (IntMap.Key, Maybe v) -> DSum (Const2 IntMap.Key a) (ComposeMaybe f)
78+ g (k, e) = Const2 k :=> ComposeMaybe (f <$> e)
79+
80+-- | Get the values that will be replaced or deleted if the given patch is applied to the given 'DMap'.
81+getDeletions :: GCompare k => PatchDMap k v -> DMap k v' -> DMap k v'
82+getDeletions (PatchDMap p) m = DMap.intersectionWithKey (\_ v _ -> v) m p
src/Reflex/Patch/DMapWithMove.hsnew file+364
@@ -0,0 +1,364 @@
1+{-# LANGUAGE CPP #-}
2+{-# LANGUAGE FlexibleContexts #-}
3+{-# LANGUAGE FlexibleInstances #-}
4+{-# LANGUAGE GADTs #-}
5+{-# LANGUAGE LambdaCase #-}
6+{-# LANGUAGE MultiParamTypeClasses #-}
7+{-# LANGUAGE PatternGuards #-}
8+{-# LANGUAGE PolyKinds #-}
9+{-# LANGUAGE Rank2Types #-}
10+{-# LANGUAGE ScopedTypeVariables #-}
11+{-# LANGUAGE TypeFamilies #-}
12+{-# LANGUAGE UndecidableInstances #-}
13+
14+-- |Module containing @'PatchDMapWithMove' k v@ and associated functions, which represents a 'Patch' to a @'DMap' k v@ which can insert, update, delete, and
15+-- move values between keys.
16+module Reflex.Patch.DMapWithMove where
17+
18+import Reflex.Patch.Class
19+import Reflex.Patch.MapWithMove (PatchMapWithMove (..))
20+import qualified Reflex.Patch.MapWithMove as MapWithMove
21+
22+import Data.Dependent.Map (DMap, DSum (..), GCompare (..))
23+import qualified Data.Dependent.Map as DMap
24+import Data.Dependent.Sum (EqTag (..))
25+import Data.Functor.Constant
26+import Data.Functor.Misc
27+import Data.Functor.Product
28+import Data.GADT.Compare (GEq (..))
29+import Data.GADT.Show (GShow, gshow)
30+import qualified Data.Map as Map
31+import Data.Maybe
32+import Data.Semigroup (Semigroup (..), (<>))
33+import Data.Some (Some)
34+import qualified Data.Some as Some
35+import Data.These
36+
37+-- | Like 'PatchMapWithMove', but for 'DMap'. Each key carries a 'NodeInfo' which describes how it will be changed by the patch and connects move sources and
38+-- destinations.
39+--
40+-- Invariants:
41+--
42+-- * A key should not move to itself.
43+-- * A move should always be represented with both the destination key (as a 'From_Move') and the source key (as a @'ComposeMaybe' ('Just' destination)@)
44+newtype PatchDMapWithMove k v = PatchDMapWithMove (DMap k (NodeInfo k v))
45+
46+-- |Structure which represents what changes apply to a particular key. @_nodeInfo_from@ specifies what happens to this key, and in particular what other key
47+-- the current key is moving from, while @_nodeInfo_to@ specifies what key the current key is moving to if involved in a move.
48+data NodeInfo k v a = NodeInfo
49+ { _nodeInfo_from :: !(From k v a)
50+ -- ^Change applying to the current key, be it an insert, move, or delete.
51+ , _nodeInfo_to :: !(To k a)
52+ -- ^Where this key is moving to, if involved in a move. Should only be @ComposeMaybe (Just k)@ when there is a corresponding 'From_Move'.
53+ }
54+ deriving (Show)
55+
56+-- |Structure describing a particular change to a key, be it inserting a new key (@From_Insert@), updating an existing key (@From_Insert@ again), deleting a
57+-- key (@From_Delete@), or moving a key (@From_Move@).
58+data From (k :: a -> *) (v :: a -> *) :: a -> * where
59+ -- |Insert a new or update an existing key with the given value @v a@
60+ From_Insert :: v a -> From k v a
61+ -- |Delete the existing key
62+ From_Delete :: From k v a
63+ -- |Move the value from the given key @k a@ to this key. The source key should also have an entry in the patch giving the current key as @_nodeInfo_to@,
64+ -- usually but not necessarily with @From_Delete@.
65+ From_Move :: !(k a) -> From k v a
66+ deriving (Show, Read, Eq, Ord)
67+
68+-- |Type alias for the "to" part of a 'NodeInfo'. @'ComposeMaybe' ('Just' k)@ means the key is moving to another key, @ComposeMaybe Nothing@ for any other
69+-- operation.
70+type To = ComposeMaybe
71+
72+-- |Test whether a 'PatchDMapWithMove' satisfies its invariants.
73+validPatchDMapWithMove :: forall k v. (GCompare k, GShow k) => DMap k (NodeInfo k v) -> Bool
74+validPatchDMapWithMove = not . null . validationErrorsForPatchDMapWithMove
75+
76+-- |Enumerate what reasons a 'PatchDMapWithMove' doesn't satisfy its invariants, returning @[]@ if it's valid.
77+validationErrorsForPatchDMapWithMove :: forall k v. (GCompare k, GShow k) => DMap k (NodeInfo k v) -> [String]
78+validationErrorsForPatchDMapWithMove m =
79+ noSelfMoves <> movesBalanced
80+ where
81+ noSelfMoves = mapMaybe selfMove . DMap.toAscList $ m
82+ selfMove (dst :=> NodeInfo (From_Move src) _) | Just _ <- dst `geq` src = Just $ "self move of key " <> gshow src <> " at destination side"
83+ selfMove (src :=> NodeInfo _ (ComposeMaybe (Just dst))) | Just _ <- src `geq` dst = Just $ "self move of key " <> gshow dst <> " at source side"
84+ selfMove _ = Nothing
85+ movesBalanced = mapMaybe unbalancedMove . DMap.toAscList $ m
86+ unbalancedMove (dst :=> NodeInfo (From_Move src) _) =
87+ case DMap.lookup src m of
88+ Nothing -> Just $ "unbalanced move at destination key " <> gshow dst <> " supposedly from " <> gshow src <> " but source key is not in the patch"
89+ Just (NodeInfo _ (ComposeMaybe (Just dst'))) ->
90+ if isNothing (dst' `geq` dst)
91+ then Just $ "unbalanced move at destination key " <> gshow dst <> " from " <> gshow src <> " is going to " <> gshow dst' <> " instead"
92+ else Nothing
93+ _ ->
94+ Just $ "unbalanced move at destination key " <> gshow dst <> " supposedly from " <> gshow src <> " but source key has no move to key"
95+ unbalancedMove (src :=> NodeInfo _ (ComposeMaybe (Just dst))) =
96+ case DMap.lookup dst m of
97+ Nothing -> Just $ " unbalanced move at source key " <> gshow src <> " supposedly going to " <> gshow dst <> " but destination key is not in the patch"
98+ Just (NodeInfo (From_Move src') _) ->
99+ if isNothing (src' `geq` src)
100+ then Just $ "unbalanced move at source key " <> gshow src <> " to " <> gshow dst <> " is coming from " <> gshow src' <> " instead"
101+ else Nothing
102+
103+ _ ->
104+ Just $ "unbalanced move at source key " <> gshow src <> " supposedly going to " <> gshow dst <> " but destination key is not moving"
105+ unbalancedMove _ = Nothing
106+
107+-- |Test whether two @'PatchDMapWithMove' k v@ contain the same patch operations.
108+instance EqTag k (NodeInfo k v) => Eq (PatchDMapWithMove k v) where
109+ PatchDMapWithMove a == PatchDMapWithMove b = a == b
110+
111+-- |Higher kinded 2-tuple, identical to @Data.Functor.Product@ from base ≥ 4.9
112+data Pair1 f g a = Pair1 (f a) (g a)
113+
114+-- |Helper data structure used for composing patches using the monoid instance.
115+data Fixup k v a
116+ = Fixup_Delete
117+ | Fixup_Update (These (From k v a) (To k a))
118+
119+-- |Compose patches having the same effect as applying the patches in turn: @'applyAlways' (p <> q) == 'applyAlways' p . 'applyAlways' q@
120+instance GCompare k => Semigroup (PatchDMapWithMove k v) where
121+ PatchDMapWithMove ma <> PatchDMapWithMove mb = PatchDMapWithMove m
122+ where
123+ connections = DMap.toList $ DMap.intersectionWithKey (\_ a b -> Pair1 (_nodeInfo_to a) (_nodeInfo_from b)) ma mb
124+ h :: DSum k (Pair1 (ComposeMaybe k) (From k v)) -> [DSum k (Fixup k v)]
125+ h (_ :=> Pair1 (ComposeMaybe mToAfter) editBefore) = case (mToAfter, editBefore) of
126+ (Just toAfter, From_Move fromBefore)
127+ | isJust $ fromBefore `geq` toAfter
128+ -> [toAfter :=> Fixup_Delete]
129+ | otherwise
130+ -> [ toAfter :=> Fixup_Update (This editBefore)
131+ , fromBefore :=> Fixup_Update (That (ComposeMaybe mToAfter))
132+ ]
133+ (Nothing, From_Move fromBefore) -> [fromBefore :=> Fixup_Update (That (ComposeMaybe mToAfter))] -- The item is destroyed in the second patch, so indicate that it is destroyed in the source map
134+ (Just toAfter, _) -> [toAfter :=> Fixup_Update (This editBefore)]
135+ (Nothing, _) -> []
136+ mergeFixups _ Fixup_Delete Fixup_Delete = Fixup_Delete
137+ mergeFixups _ (Fixup_Update a) (Fixup_Update b)
138+ | This x <- a, That y <- b
139+ = Fixup_Update $ These x y
140+ | That y <- a, This x <- b
141+ = Fixup_Update $ These x y
142+ mergeFixups _ _ _ = error "PatchDMapWithMove: incompatible fixups"
143+ fixups = DMap.fromListWithKey mergeFixups $ concatMap h connections
144+ combineNodeInfos _ nia nib = NodeInfo
145+ { _nodeInfo_from = _nodeInfo_from nia
146+ , _nodeInfo_to = _nodeInfo_to nib
147+ }
148+ applyFixup _ ni = \case
149+ Fixup_Delete -> Nothing
150+ Fixup_Update u -> Just $ NodeInfo
151+ { _nodeInfo_from = fromMaybe (_nodeInfo_from ni) $ getHere u
152+ , _nodeInfo_to = fromMaybe (_nodeInfo_to ni) $ getThere u
153+ }
154+ m = DMap.differenceWithKey applyFixup (DMap.unionWithKey combineNodeInfos ma mb) fixups
155+ getHere :: These a b -> Maybe a
156+ getHere = \case
157+ This a -> Just a
158+ These a _ -> Just a
159+ That _ -> Nothing
160+ getThere :: These a b -> Maybe b
161+ getThere = \case
162+ This _ -> Nothing
163+ These _ b -> Just b
164+ That b -> Just b
165+
166+-- |Compose patches having the same effect as applying the patches in turn: @'applyAlways' (p <> q) == 'applyAlways' p . 'applyAlways' q@
167+instance GCompare k => Monoid (PatchDMapWithMove k v) where
168+ mempty = PatchDMapWithMove mempty
169+ mappend = (<>)
170+
171+{-
172+mappendPatchDMapWithMoveSlow :: forall k v. (ShowTag k v, GCompare k) => PatchDMapWithMove k v -> PatchDMapWithMove k v -> PatchDMapWithMove k v
173+PatchDMapWithMove dstAfter srcAfter `mappendPatchDMapWithMoveSlow` PatchDMapWithMove dstBefore srcBefore = PatchDMapWithMove dst src
174+ where
175+ getDstAction k m = fromMaybe (From_Move k) $ DMap.lookup k m -- Any key that isn't present is treated as that key moving to itself
176+ removeRedundantDst toKey (From_Move fromKey) | isJust (toKey `geq` fromKey) = Nothing
177+ removeRedundantDst _ a = Just a
178+ f :: forall a. k a -> From k v a -> Maybe (From k v a)
179+ f toKey _ = removeRedundantDst toKey $ case getDstAction toKey dstAfter of
180+ From_Move fromKey -> getDstAction fromKey dstBefore
181+ nonMove -> nonMove
182+ dst = DMap.mapMaybeWithKey f $ DMap.union dstAfter dstBefore
183+ getSrcAction k m = fromMaybe (ComposeMaybe $ Just k) $ DMap.lookup k m
184+ removeRedundantSrc fromKey (ComposeMaybe (Just toKey)) | isJust (fromKey `geq` toKey) = Nothing
185+ removeRedundantSrc _ a = Just a
186+ g :: forall a. k a -> ComposeMaybe k a -> Maybe (ComposeMaybe k a)
187+ g fromKey _ = removeRedundantSrc fromKey $ case getSrcAction fromKey srcBefore of
188+ ComposeMaybe Nothing -> ComposeMaybe Nothing
189+ ComposeMaybe (Just toKeyBefore) -> getSrcAction toKeyBefore srcAfter
190+ src = DMap.mapMaybeWithKey g $ DMap.union srcAfter srcBefore
191+-}
192+
193+-- |Make a @'PatchDMapWithMove' k v@ which has the effect of inserting or updating a value @v a@ to the given key @k a@, like 'DMap.insert'.
194+insertDMapKey :: k a -> v a -> PatchDMapWithMove k v
195+insertDMapKey k v =
196+ PatchDMapWithMove . DMap.singleton k $ NodeInfo (From_Insert v) (ComposeMaybe Nothing)
197+
198+-- |Make a @'PatchDMapWithMove' k v@ which has the effect of moving the value from the first key @k a@ to the second key @k a@, equivalent to:
199+--
200+-- @
201+-- 'DMap.delete' src (maybe dmap ('DMap.insert' dst) (DMap.lookup src dmap))
202+-- @
203+moveDMapKey :: GCompare k => k a -> k a -> PatchDMapWithMove k v
204+moveDMapKey src dst = case src `geq` dst of
205+ Nothing -> PatchDMapWithMove $ DMap.fromList
206+ [ dst :=> NodeInfo (From_Move src) (ComposeMaybe Nothing)
207+ , src :=> NodeInfo From_Delete (ComposeMaybe $ Just dst)
208+ ]
209+ Just _ -> mempty
210+
211+-- |Make a @'PatchDMapWithMove' k v@ which has the effect of swapping two keys in the mapping, equivalent to:
212+--
213+-- @
214+-- let aMay = DMap.lookup a dmap
215+-- bMay = DMap.lookup b dmap
216+-- in maybe id (DMap.insert a) (bMay `mplus` aMay)
217+-- . maybe id (DMap.insert b) (aMay `mplus` bMay)
218+-- . DMap.delete a . DMap.delete b $ dmap
219+-- @
220+swapDMapKey :: GCompare k => k a -> k a -> PatchDMapWithMove k v
221+swapDMapKey src dst = case src `geq` dst of
222+ Nothing -> PatchDMapWithMove $ DMap.fromList
223+ [ dst :=> NodeInfo (From_Move src) (ComposeMaybe $ Just src)
224+ , src :=> NodeInfo (From_Move dst) (ComposeMaybe $ Just dst)
225+ ]
226+ Just _ -> mempty
227+
228+-- |Make a @'PatchDMapWithMove' k v@ which has the effect of deleting a key in the mapping, equivalent to 'DMap.delete'.
229+deleteDMapKey :: k a -> PatchDMapWithMove k v
230+deleteDMapKey k = PatchDMapWithMove $ DMap.singleton k $ NodeInfo From_Delete $ ComposeMaybe Nothing
231+
232+{-
233+k1, k2 :: Const2 Int () ()
234+k1 = Const2 1
235+k2 = Const2 2
236+p1, p2 :: PatchDMapWithMove (Const2 Int ()) Identity
237+p1 = moveDMapKey k1 k2
238+p2 = moveDMapKey k2 k1
239+p12 = p1 <> p2
240+p21 = p2 <> p1
241+p12Slow = p1 `mappendPatchDMapWithMoveSlow` p2
242+p21Slow = p2 `mappendPatchDMapWithMoveSlow` p1
243+
244+testPatchDMapWithMove = do
245+ print p1
246+ print p2
247+ print $ p12 == deleteDMapKey k1
248+ print $ p21 == deleteDMapKey k2
249+ print $ p12Slow == deleteDMapKey k1
250+ print $ p21Slow == deleteDMapKey k2
251+
252+dst (PatchDMapWithMove x _) = x
253+src (PatchDMapWithMove _ x) = x
254+-}
255+
256+-- |Extract the 'DMap' representing the patch changes from the 'PatchDMapWithMove'.
257+unPatchDMapWithMove :: PatchDMapWithMove k v -> DMap k (NodeInfo k v)
258+unPatchDMapWithMove (PatchDMapWithMove p) = p
259+
260+-- |Wrap a 'DMap' representing patch changes into a 'PatchDMapWithMove', without checking any invariants.
261+--
262+-- __Warning:__ when using this function, you must ensure that the invariants of 'PatchDMapWithMove' are preserved; they will not be checked.
263+unsafePatchDMapWithMove :: DMap k (NodeInfo k v) -> PatchDMapWithMove k v
264+unsafePatchDMapWithMove = PatchDMapWithMove
265+
266+-- |Wrap a 'DMap' representing patch changes into a 'PatchDMapWithMove' while checking invariants. If the invariants are satisfied, @Right p@ is returned
267+-- otherwise @Left errors@.
268+patchDMapWithMove :: (GCompare k, GShow k) => DMap k (NodeInfo k v) -> Either [String] (PatchDMapWithMove k v)
269+patchDMapWithMove dm =
270+ case validationErrorsForPatchDMapWithMove dm of
271+ [] -> Right $ unsafePatchDMapWithMove dm
272+ errs -> Left errs
273+
274+-- |Map a natural transform @v -> v'@ over the given patch, transforming @'PatchDMapWithMove' k v@ into @'PatchDMapWithMove' k v'@.
275+mapPatchDMapWithMove :: forall k v v'. (forall a. v a -> v' a) -> PatchDMapWithMove k v -> PatchDMapWithMove k v'
276+mapPatchDMapWithMove f (PatchDMapWithMove p) = PatchDMapWithMove $
277+ DMap.map (\ni -> ni { _nodeInfo_from = g $ _nodeInfo_from ni }) p
278+ where g :: forall a. From k v a -> From k v' a
279+ g = \case
280+ From_Insert v -> From_Insert $ f v
281+ From_Delete -> From_Delete
282+ From_Move k -> From_Move k
283+
284+-- |Traverse an effectful function @forall a. v a -> m (v ' a)@ over the given patch, transforming @'PatchDMapWithMove' k v@ into @m ('PatchDMapWithMove' k v')@.
285+traversePatchDMapWithMove :: forall m k v v'. Applicative m => (forall a. v a -> m (v' a)) -> PatchDMapWithMove k v -> m (PatchDMapWithMove k v')
286+traversePatchDMapWithMove f = traversePatchDMapWithMoveWithKey $ const f
287+
288+-- |Map an effectful function @forall a. k a -> v a -> m (v ' a)@ over the given patch, transforming @'PatchDMapWithMove' k v@ into @m ('PatchDMapWithMove' k v')@.
289+traversePatchDMapWithMoveWithKey :: forall m k v v'. Applicative m => (forall a. k a -> v a -> m (v' a)) -> PatchDMapWithMove k v -> m (PatchDMapWithMove k v')
290+traversePatchDMapWithMoveWithKey f (PatchDMapWithMove p) = PatchDMapWithMove <$> DMap.traverseWithKey (nodeInfoMapFromM . g) p
291+ where g :: forall a. k a -> From k v a -> m (From k v' a)
292+ g k = \case
293+ From_Insert v -> From_Insert <$> f k v
294+ From_Delete -> pure From_Delete
295+ From_Move fromKey -> pure $ From_Move fromKey
296+
297+-- |Map a function which transforms @'From' k v a@ into a @'From' k v' a@ over a @'NodeInfo' k v a@.
298+nodeInfoMapFrom :: (From k v a -> From k v' a) -> NodeInfo k v a -> NodeInfo k v' a
299+nodeInfoMapFrom f ni = ni { _nodeInfo_from = f $ _nodeInfo_from ni }
300+
301+-- |Map an effectful function which transforms @'From' k v a@ into a @f ('From' k v' a)@ over a @'NodeInfo' k v a@.
302+nodeInfoMapFromM :: Functor f => (From k v a -> f (From k v' a)) -> NodeInfo k v a -> f (NodeInfo k v' a)
303+nodeInfoMapFromM f ni = fmap (\result -> ni { _nodeInfo_from = result }) $ f $ _nodeInfo_from ni
304+
305+-- |Weaken a 'PatchDMapWithMove' to a 'PatchMapWithMove' by weakening the keys from @k a@ to @'Some' k@ and applying a given weakening function @v a -> v'@ to
306+-- values.
307+weakenPatchDMapWithMoveWith :: forall k v v'. (forall a. v a -> v') -> PatchDMapWithMove k v -> PatchMapWithMove (Some k) v'
308+weakenPatchDMapWithMoveWith f (PatchDMapWithMove p) = PatchMapWithMove $ weakenDMapWith g p
309+ where g :: forall a. NodeInfo k v a -> MapWithMove.NodeInfo (Some k) v'
310+ g ni = MapWithMove.NodeInfo
311+ { MapWithMove._nodeInfo_from = case _nodeInfo_from ni of
312+ From_Insert v -> MapWithMove.From_Insert $ f v
313+ From_Delete -> MapWithMove.From_Delete
314+ From_Move k -> MapWithMove.From_Move $ Some.This k
315+ , MapWithMove._nodeInfo_to = Some.This <$> getComposeMaybe (_nodeInfo_to ni)
316+ }
317+
318+-- |"Weaken" a @'PatchDMapWithMove' (Const2 k a) v@ to a @'PatchMapWithMove' k v'@. Weaken is in scare quotes because the 'Const2' has already disabled any
319+-- dependency in the typing and all points are already @a@, hence the function to map each value to @v'@ is not higher rank.
320+patchDMapWithMoveToPatchMapWithMoveWith :: forall k v v' a. (v a -> v') -> PatchDMapWithMove (Const2 k a) v -> PatchMapWithMove k v'
321+patchDMapWithMoveToPatchMapWithMoveWith f (PatchDMapWithMove p) = PatchMapWithMove $ dmapToMapWith g p
322+ where g :: NodeInfo (Const2 k a) v a -> MapWithMove.NodeInfo k v'
323+ g ni = MapWithMove.NodeInfo
324+ { MapWithMove._nodeInfo_from = case _nodeInfo_from ni of
325+ From_Insert v -> MapWithMove.From_Insert $ f v
326+ From_Delete -> MapWithMove.From_Delete
327+ From_Move (Const2 k) -> MapWithMove.From_Move k
328+ , MapWithMove._nodeInfo_to = unConst2 <$> getComposeMaybe (_nodeInfo_to ni)
329+ }
330+
331+-- |"Strengthen" a @'PatchMapWithMove' k v@ into a @'PatchDMapWithMove ('Const2' k a)@; that is, turn a non-dependently-typed patch into a dependently typed
332+-- one but which always has a constant key type represented by 'Const2'. Apply the given function to each @v@ to produce a @v' a@.
333+-- Completemented by 'patchDMapWithMoveToPatchMapWithMoveWith'
334+const2PatchDMapWithMoveWith :: forall k v v' a. (v -> v' a) -> PatchMapWithMove k v -> PatchDMapWithMove (Const2 k a) v'
335+const2PatchDMapWithMoveWith f (PatchMapWithMove p) = PatchDMapWithMove $ DMap.fromDistinctAscList $ g <$> Map.toAscList p
336+ where g :: (k, MapWithMove.NodeInfo k v) -> DSum (Const2 k a) (NodeInfo (Const2 k a) v')
337+ g (k, ni) = Const2 k :=> NodeInfo
338+ { _nodeInfo_from = case MapWithMove._nodeInfo_from ni of
339+ MapWithMove.From_Insert v -> From_Insert $ f v
340+ MapWithMove.From_Delete -> From_Delete
341+ MapWithMove.From_Move fromKey -> From_Move $ Const2 fromKey
342+ , _nodeInfo_to = ComposeMaybe $ Const2 <$> MapWithMove._nodeInfo_to ni
343+ }
344+
345+-- | Apply the insertions, deletions, and moves to a given 'DMap'.
346+instance GCompare k => Patch (PatchDMapWithMove k v) where
347+ type PatchTarget (PatchDMapWithMove k v) = DMap k v
348+ apply (PatchDMapWithMove p) old = Just $! insertions `DMap.union` (old `DMap.difference` deletions) --TODO: return Nothing sometimes --Note: the strict application here is critical to ensuring that incremental merges don't hold onto all their prerequisite events forever; can we make this more robust?
349+ where insertions = DMap.mapMaybeWithKey insertFunc p
350+ insertFunc :: forall a. k a -> NodeInfo k v a -> Maybe (v a)
351+ insertFunc _ ni = case _nodeInfo_from ni of
352+ From_Insert v -> Just v
353+ From_Move k -> DMap.lookup k old
354+ From_Delete -> Nothing
355+ deletions = DMap.mapMaybeWithKey deleteFunc p
356+ deleteFunc :: forall a. k a -> NodeInfo k v a -> Maybe (Constant () a)
357+ deleteFunc _ ni = case _nodeInfo_from ni of
358+ From_Delete -> Just $ Constant ()
359+ _ -> Nothing
360+
361+-- | Get the values that will be replaced, deleted, or moved if the given patch is applied to the given 'DMap'.
362+getDeletionsAndMoves :: GCompare k => PatchDMapWithMove k v -> DMap k v' -> DMap k (Product v' (ComposeMaybe k))
363+getDeletionsAndMoves (PatchDMapWithMove p) m = DMap.intersectionWithKey f m p
364+ where f _ v ni = Pair v $ _nodeInfo_to ni
src/Reflex/Patch/IntMap.hsnew file+67
@@ -0,0 +1,67 @@
1+{-# LANGUAGE CPP #-}
2+{-# LANGUAGE DeriveFoldable #-}
3+{-# LANGUAGE DeriveFunctor #-}
4+{-# LANGUAGE DeriveTraversable #-}
5+{-# LANGUAGE GeneralizedNewtypeDeriving #-}
6+{-# LANGUAGE TypeFamilies #-}
7+-- | Module containing 'PatchIntMap', a 'Patch' for 'IntMap' which allows for
8+-- insert/update or delete of associations.
9+module Reflex.Patch.IntMap where
10+
11+import Data.IntMap.Strict (IntMap)
12+import qualified Data.IntMap.Strict as IntMap
13+import Data.Maybe
14+import Data.Semigroup
15+import Reflex.Patch.Class
16+
17+-- | 'Patch' for 'IntMap' which represents insertion or deletion of keys in the mapping.
18+-- Internally represented by 'IntMap (Maybe a)', where @Just@ means insert/update
19+-- and @Nothing@ means delete.
20+newtype PatchIntMap a = PatchIntMap (IntMap (Maybe a)) deriving (Functor, Foldable, Traversable, Monoid)
21+
22+-- | Apply the insertions or deletions to a given 'IntMap'.
23+instance Patch (PatchIntMap a) where
24+ type PatchTarget (PatchIntMap a) = IntMap a
25+ apply (PatchIntMap p) v = if IntMap.null p then Nothing else Just $
26+ let removes = IntMap.filter isNothing p
27+ adds = IntMap.mapMaybe id p
28+ in IntMap.union adds $ v `IntMap.difference` removes
29+
30+-- | @a <> b@ will apply the changes of @b@ and then apply the changes of @a@.
31+-- If the same key is modified by both patches, the one on the left will take
32+-- precedence.
33+instance Semigroup (PatchIntMap v) where
34+ PatchIntMap a <> PatchIntMap b = PatchIntMap $ a `mappend` b --TODO: Add a semigroup instance for Map
35+ -- PatchMap is idempotent, so stimes n is id for every n
36+#if MIN_VERSION_semigroups(0,17,0)
37+ stimes = stimesIdempotentMonoid
38+#else
39+ times1p n x = case compare n 0 of
40+ LT -> error "stimesIdempotentMonoid: negative multiplier"
41+ EQ -> mempty
42+ GT -> x
43+#endif
44+
45+-- | Map a function @Int -> a -> b@ over all @a@s in the given @'PatchIntMap' a@
46+-- (that is, all inserts/updates), producing a @PatchIntMap b@.
47+mapIntMapPatchWithKey :: (Int -> a -> b) -> PatchIntMap a -> PatchIntMap b
48+mapIntMapPatchWithKey f (PatchIntMap m) = PatchIntMap $ IntMap.mapWithKey (\ k mv -> f k <$> mv) m
49+
50+-- | Map an effectful function @Int -> a -> f b@ over all @a@s in the given @'PatchIntMap' a@
51+-- (that is, all inserts/updates), producing a @f (PatchIntMap b)@.
52+traverseIntMapPatchWithKey :: Applicative f => (Int -> a -> f b) -> PatchIntMap a -> f (PatchIntMap b)
53+traverseIntMapPatchWithKey f (PatchIntMap m) = PatchIntMap <$> IntMap.traverseWithKey (\k mv -> traverse (f k) mv) m
54+
55+-- | Extract all @a@s inserted/updated by the given @'PatchIntMap' a@.
56+patchIntMapNewElements :: PatchIntMap a -> [a]
57+patchIntMapNewElements (PatchIntMap m) = catMaybes $ IntMap.elems m
58+
59+-- | Convert the given @'PatchIntMap' a@ into an @'IntMap' a@ with all
60+-- the inserts/updates in the given patch.
61+patchIntMapNewElementsMap :: PatchIntMap a -> IntMap a
62+patchIntMapNewElementsMap (PatchIntMap m) = IntMap.mapMaybe id m
63+
64+-- | Subset the given @'IntMap' a@ to contain only the keys that would be
65+-- deleted by the given @'PatchIntMap' a@.
66+getDeletions :: PatchIntMap v -> IntMap v' -> IntMap v'
67+getDeletions (PatchIntMap m) v = IntMap.intersection v m
src/Reflex/Patch/Map.hsnew file+63
@@ -0,0 +1,63 @@
1+{-# LANGUAGE CPP #-}
2+{-# LANGUAGE LambdaCase #-}
3+{-# LANGUAGE TypeFamilies #-}
4+-- | 'Patch'es on 'Map' that consist only of insertions (including overwrites)
5+-- and deletions
6+module Reflex.Patch.Map where
7+
8+import Reflex.Patch.Class
9+
10+import Data.Map (Map)
11+import qualified Data.Map as Map
12+import Data.Maybe
13+import Data.Semigroup
14+
15+-- | A set of changes to a 'Map'. Any element may be inserted/updated or
16+-- deleted. Insertions are represented as values wrapped in 'Just', while
17+-- deletions are represented as 'Nothing's
18+newtype PatchMap k v = PatchMap { unPatchMap :: Map k (Maybe v) }
19+ deriving (Show, Read, Eq, Ord)
20+
21+-- | Apply the insertions or deletions to a given 'Map'.
22+instance Ord k => Patch (PatchMap k v) where
23+ type PatchTarget (PatchMap k v) = Map k v
24+ {-# INLINABLE apply #-}
25+ apply (PatchMap p) old = Just $! insertions `Map.union` (old `Map.difference` deletions) --TODO: return Nothing sometimes --Note: the strict application here is critical to ensuring that incremental merges don't hold onto all their prerequisite events forever; can we make this more robust?
26+ where insertions = Map.mapMaybeWithKey (const id) p
27+ deletions = Map.mapMaybeWithKey (const nothingToJust) p
28+ nothingToJust = \case
29+ Nothing -> Just ()
30+ Just _ -> Nothing
31+
32+-- | @a <> b@ will apply the changes of @b@ and then apply the changes of @a@.
33+-- If the same key is modified by both patches, the one on the left will take
34+-- precedence.
35+instance Ord k => Semigroup (PatchMap k v) where
36+ PatchMap a <> PatchMap b = PatchMap $ a `mappend` b --TODO: Add a semigroup instance for Map
37+ -- PatchMap is idempotent, so stimes n is id for every n
38+#if MIN_VERSION_semigroups(0,17,0)
39+ stimes = stimesIdempotentMonoid
40+#else
41+ times1p n x = case compare n 0 of
42+ LT -> error "stimesIdempotentMonoid: negative multiplier"
43+ EQ -> mempty
44+ GT -> x
45+#endif
46+
47+-- | The empty 'PatchMap' contains no insertions or deletions
48+instance Ord k => Monoid (PatchMap k v) where
49+ mempty = PatchMap mempty
50+ mappend = (<>)
51+
52+-- | 'fmap'ping a 'PatchMap' will alter all of the values it will insert.
53+-- Deletions are unaffected.
54+instance Functor (PatchMap k) where
55+ fmap f = PatchMap . fmap (fmap f) . unPatchMap
56+
57+-- | Returns all the new elements that will be added to the 'Map'
58+patchMapNewElements :: PatchMap k v -> [v]
59+patchMapNewElements (PatchMap p) = catMaybes $ Map.elems p
60+
61+-- | Returns all the new elements that will be added to the 'Map'
62+patchMapNewElementsMap :: PatchMap k v -> Map k v
63+patchMapNewElementsMap (PatchMap p) = Map.mapMaybe id p
src/Reflex/Patch/MapWithMove.hsnew file+270
@@ -0,0 +1,270 @@
1+{-# LANGUAGE DeriveFoldable #-}
2+{-# LANGUAGE DeriveFunctor #-}
3+{-# LANGUAGE DeriveTraversable #-}
4+{-# LANGUAGE FlexibleContexts #-}
5+{-# LANGUAGE LambdaCase #-}
6+{-# LANGUAGE PatternGuards #-}
7+{-# LANGUAGE ScopedTypeVariables #-}
8+{-# LANGUAGE TypeFamilies #-}
9+-- | 'Patch'es on 'Map' that can insert, delete, and move values from one key to
10+-- another
11+module Reflex.Patch.MapWithMove where
12+
13+import Reflex.Patch.Class
14+
15+import Control.Arrow
16+import Control.Monad.State
17+import Data.Foldable
18+import Data.Function
19+import Data.List
20+import Data.Map (Map)
21+import qualified Data.Map as Map
22+import Data.Maybe
23+import Data.Semigroup (Semigroup (..), (<>))
24+import qualified Data.Set as Set
25+import Data.These
26+import Data.Tuple
27+
28+-- | Patch a DMap with additions, deletions, and moves. Invariant: If key @k1@
29+-- is coming from @From_Move k2@, then key @k2@ should be going to @Just k1@,
30+-- and vice versa. There should never be any unpaired From/To keys.
31+newtype PatchMapWithMove k v = PatchMapWithMove (Map k (NodeInfo k v)) deriving (Show, Eq, Ord, Functor, Foldable, Traversable)
32+
33+-- | Holds the information about each key: where its new value should come from,
34+-- and where its old value should go to
35+data NodeInfo k v = NodeInfo
36+ { _nodeInfo_from :: !(From k v)
37+ -- ^ Where do we get the new value for this key?
38+ , _nodeInfo_to :: !(To k)
39+ -- ^ If the old value is being kept (i.e. moved rather than deleted or
40+ -- replaced), where is it going?
41+ }
42+ deriving (Show, Read, Eq, Ord, Functor, Foldable, Traversable)
43+
44+-- | Describe how a key's new value should be produced
45+data From k v
46+ = From_Insert v -- ^ Insert the given value here
47+ | From_Delete -- ^ Delete the existing value, if any, from here
48+ | From_Move !k -- ^ Move the value here from the given key
49+ deriving (Show, Read, Eq, Ord, Functor, Foldable, Traversable)
50+
51+-- | Describe where a key's old value will go. If this is 'Just', that means
52+-- the key's old value will be moved to the given other key; if it is 'Nothing',
53+-- that means it will be deleted.
54+type To = Maybe
55+
56+-- | Create a 'PatchMapWithMove', validating it
57+patchMapWithMove :: Ord k => Map k (NodeInfo k v) -> Maybe (PatchMapWithMove k v)
58+patchMapWithMove m = if valid then Just $ PatchMapWithMove m else Nothing
59+ where valid = forwardLinks == backwardLinks
60+ forwardLinks = Map.mapMaybe _nodeInfo_to m
61+ backwardLinks = Map.fromList $ catMaybes $ flip fmap (Map.toList m) $ \(to, v) ->
62+ case _nodeInfo_from v of
63+ From_Move from -> Just (from, to)
64+ _ -> Nothing
65+
66+-- | Create a 'PatchMapWithMove' that inserts everything in the given 'Map'
67+patchMapWithMoveInsertAll :: Map k v -> PatchMapWithMove k v
68+patchMapWithMoveInsertAll m = PatchMapWithMove $ flip fmap m $ \v -> NodeInfo
69+ { _nodeInfo_from = From_Insert v
70+ , _nodeInfo_to = Nothing
71+ }
72+
73+-- | Extract the internal representation of the 'PatchMapWithMove'
74+unPatchMapWithMove :: PatchMapWithMove k v -> Map k (NodeInfo k v)
75+unPatchMapWithMove (PatchMapWithMove p) = p
76+
77+-- | Make a @'PatchMapWithMove' k v@ which has the effect of inserting or updating a value @v@ to the given key @k@, like 'Map.insert'.
78+insertMapKey :: k -> v -> PatchMapWithMove k v
79+insertMapKey k v = PatchMapWithMove . Map.singleton k $ NodeInfo (From_Insert v) Nothing
80+
81+-- |Make a @'PatchMapWithMove' k v@ which has the effect of moving the value from the first key @k@ to the second key @k@, equivalent to:
82+--
83+-- @
84+-- 'Map.delete' src (maybe map ('Map.insert' dst) (Map.lookup src map))
85+-- @
86+moveMapKey :: Ord k => k -> k -> PatchMapWithMove k v
87+moveMapKey src dst
88+ | src == dst = mempty
89+ | otherwise =
90+ PatchMapWithMove $ Map.fromList
91+ [ (dst, NodeInfo (From_Move src) Nothing)
92+ , (src, NodeInfo From_Delete (Just dst))
93+ ]
94+
95+-- |Make a @'PatchMapWithMove' k v@ which has the effect of swapping two keys in the mapping, equivalent to:
96+--
97+-- @
98+-- let aMay = Map.lookup a map
99+-- bMay = Map.lookup b map
100+-- in maybe id (Map.insert a) (bMay `mplus` aMay)
101+-- . maybe id (Map.insert b) (aMay `mplus` bMay)
102+-- . Map.delete a . Map.delete b $ map
103+-- @
104+swapMapKey :: Ord k => k -> k -> PatchMapWithMove k v
105+swapMapKey src dst
106+ | src == dst = mempty
107+ | otherwise =
108+ PatchMapWithMove $ Map.fromList
109+ [ (dst, NodeInfo (From_Move src) (Just src))
110+ , (src, NodeInfo (From_Move dst) (Just dst))
111+ ]
112+
113+-- |Make a @'PatchMapWithMove' k v@ which has the effect of deleting a key in the mapping, equivalent to 'Map.delete'.
114+deleteMapKey :: k -> PatchMapWithMove k v
115+deleteMapKey k = PatchMapWithMove . Map.singleton k $ NodeInfo From_Delete Nothing
116+
117+-- | Wrap a @'Map' k (NodeInfo k v)@ representing patch changes into a @'PatchMapWithMove' k v@, without checking any invariants.
118+--
119+-- __Warning:__ when using this function, you must ensure that the invariants of 'PatchMapWithMove' are preserved; they will not be checked.
120+unsafePatchMapWithMove :: Map k (NodeInfo k v) -> PatchMapWithMove k v
121+unsafePatchMapWithMove = PatchMapWithMove
122+
123+-- | Apply the insertions, deletions, and moves to a given 'Map'
124+instance Ord k => Patch (PatchMapWithMove k v) where
125+ type PatchTarget (PatchMapWithMove k v) = Map k v
126+ apply (PatchMapWithMove p) old = Just $! insertions `Map.union` (old `Map.difference` deletions) --TODO: return Nothing sometimes --Note: the strict application here is critical to ensuring that incremental merges don't hold onto all their prerequisite events forever; can we make this more robust?
127+ where insertions = flip Map.mapMaybeWithKey p $ \_ ni -> case _nodeInfo_from ni of
128+ From_Insert v -> Just v
129+ From_Move k -> Map.lookup k old
130+ From_Delete -> Nothing
131+ deletions = flip Map.mapMaybeWithKey p $ \_ ni -> case _nodeInfo_from ni of
132+ From_Delete -> Just ()
133+ _ -> Nothing
134+
135+-- | Returns all the new elements that will be added to the 'Map'.
136+patchMapWithMoveNewElements :: PatchMapWithMove k v -> [v]
137+patchMapWithMoveNewElements = Map.elems . patchMapWithMoveNewElementsMap
138+
139+-- | Return a @'Map' k v@ with all the inserts/updates from the given @'PatchMapWithMove' k v@.
140+patchMapWithMoveNewElementsMap :: PatchMapWithMove k v -> Map k v
141+patchMapWithMoveNewElementsMap (PatchMapWithMove p) = Map.mapMaybe f p
142+ where f ni = case _nodeInfo_from ni of
143+ From_Insert v -> Just v
144+ From_Move _ -> Nothing
145+ From_Delete -> Nothing
146+
147+-- | Create a 'PatchMapWithMove' that, if applied to the given 'Map', will sort
148+-- its values using the given ordering function. The set keys of the 'Map' is
149+-- not changed.
150+patchThatSortsMapWith :: Ord k => (v -> v -> Ordering) -> Map k v -> PatchMapWithMove k v
151+patchThatSortsMapWith cmp m = PatchMapWithMove $ Map.fromList $ catMaybes $ zipWith g unsorted sorted
152+ where unsorted = Map.toList m
153+ sorted = sortBy (cmp `on` snd) unsorted
154+ f (to, _) (from, _) = if to == from then Nothing else
155+ Just (from, to)
156+ reverseMapping = Map.fromList $ catMaybes $ zipWith f unsorted sorted
157+ g (to, _) (from, _) = if to == from then Nothing else
158+ let Just movingTo = Map.lookup from reverseMapping
159+ in Just (to, NodeInfo (From_Move from) $ Just movingTo)
160+
161+-- | Create a 'PatchMapWithMove' that, if applied to the first 'Map' provided,
162+-- will produce a 'Map' with the same values as the second 'Map' but with the
163+-- values sorted with the given ordering function.
164+patchThatChangesAndSortsMapWith :: forall k v. (Ord k, Ord v) => (v -> v -> Ordering) -> Map k v -> Map k v -> PatchMapWithMove k v
165+patchThatChangesAndSortsMapWith cmp oldByIndex newByIndexUnsorted = patchThatChangesMap oldByIndex newByIndex
166+ where newList = Map.toList newByIndexUnsorted
167+ newByIndex = Map.fromList $ zip (fst <$> newList) $ sortBy cmp $ snd <$> newList
168+
169+-- | Create a 'PatchMapWithMove' that, if applied to the first 'Map' provided,
170+-- will produce the second 'Map'.
171+patchThatChangesMap :: (Ord k, Ord v) => Map k v -> Map k v -> PatchMapWithMove k v
172+patchThatChangesMap oldByIndex newByIndex = patch
173+ where oldByValue = Map.fromListWith Set.union $ swap . first Set.singleton <$> Map.toList oldByIndex
174+ (insertsAndMoves, unusedValuesByValue) = flip runState oldByValue $ do
175+ let f k v = do
176+ remainingValues <- get
177+ let putRemainingKeys remainingKeys = put $ if Set.null remainingKeys
178+ then Map.delete v remainingValues
179+ else Map.insert v remainingKeys remainingValues
180+ case Map.lookup v remainingValues of
181+ Nothing -> return $ NodeInfo (From_Insert v) $ Just undefined -- There's no existing value we can take
182+ Just fromKs ->
183+ if k `Set.member` fromKs
184+ then do
185+ putRemainingKeys $ Set.delete k fromKs
186+ return $ NodeInfo (From_Move k) $ Just undefined -- There's an existing value, and it's here, so no patch necessary
187+ else do
188+ (fromK, remainingKeys) <- return . fromJust $ Set.minView fromKs -- There's an existing value, but it's not here; move it here
189+ putRemainingKeys remainingKeys
190+ return $ NodeInfo (From_Move fromK) $ Just undefined
191+ Map.traverseWithKey f newByIndex
192+ unusedOldKeys = fold unusedValuesByValue
193+ pointlessMove k = \case
194+ From_Move k' | k == k' -> True
195+ _ -> False
196+ keyWasMoved k = if k `Map.member` oldByIndex && not (k `Set.member` unusedOldKeys)
197+ then Just undefined
198+ else Nothing
199+ patch = unsafePatchMapWithMove $ Map.filterWithKey (\k -> not . pointlessMove k . _nodeInfo_from) $ Map.mergeWithKey (\k a _ -> Just $ nodeInfoSetTo (keyWasMoved k) a) (Map.mapWithKey $ \k -> nodeInfoSetTo $ keyWasMoved k) (Map.mapWithKey $ \k _ -> NodeInfo From_Delete $ keyWasMoved k) insertsAndMoves oldByIndex
200+
201+-- | Change the 'From' value of a 'NodeInfo'
202+nodeInfoMapFrom :: (From k v -> From k v) -> NodeInfo k v -> NodeInfo k v
203+nodeInfoMapFrom f ni = ni { _nodeInfo_from = f $ _nodeInfo_from ni }
204+
205+-- | Change the 'From' value of a 'NodeInfo', using a 'Functor' (or
206+-- 'Applicative', 'Monad', etc.) action to get the new value
207+nodeInfoMapMFrom :: Functor f => (From k v -> f (From k v)) -> NodeInfo k v -> f (NodeInfo k v)
208+nodeInfoMapMFrom f ni = fmap (\result -> ni { _nodeInfo_from = result }) $ f $ _nodeInfo_from ni
209+
210+-- | Set the 'To' field of a 'NodeInfo'
211+nodeInfoSetTo :: To k -> NodeInfo k v -> NodeInfo k v
212+nodeInfoSetTo to ni = ni { _nodeInfo_to = to }
213+
214+-- |Helper data structure used for composing patches using the monoid instance.
215+data Fixup k v
216+ = Fixup_Delete
217+ | Fixup_Update (These (From k v) (To k))
218+
219+-- |Compose patches having the same effect as applying the patches in turn: @'applyAlways' (p <> q) == 'applyAlways' p . 'applyAlways' q@
220+instance Ord k => Semigroup (PatchMapWithMove k v) where
221+ PatchMapWithMove ma <> PatchMapWithMove mb = PatchMapWithMove m
222+ where
223+ connections = Map.toList $ Map.intersectionWithKey (\_ a b -> (_nodeInfo_to a, _nodeInfo_from b)) ma mb
224+ h :: (k, (Maybe k, From k v)) -> [(k, Fixup k v)]
225+ h (_, (mToAfter, editBefore)) = case (mToAfter, editBefore) of
226+ (Just toAfter, From_Move fromBefore)
227+ | fromBefore == toAfter
228+ -> [(toAfter, Fixup_Delete)]
229+ | otherwise
230+ -> [ (toAfter, Fixup_Update (This editBefore))
231+ , (fromBefore, Fixup_Update (That mToAfter))
232+ ]
233+ (Nothing, From_Move fromBefore) -> [(fromBefore, Fixup_Update (That mToAfter))] -- The item is destroyed in the second patch, so indicate that it is destroyed in the source map
234+ (Just toAfter, _) -> [(toAfter, Fixup_Update (This editBefore))]
235+ (Nothing, _) -> []
236+ mergeFixups _ Fixup_Delete Fixup_Delete = Fixup_Delete
237+ mergeFixups _ (Fixup_Update a) (Fixup_Update b)
238+ | This x <- a, That y <- b
239+ = Fixup_Update $ These x y
240+ | That y <- a, This x <- b
241+ = Fixup_Update $ These x y
242+ mergeFixups _ _ _ = error "PatchMapWithMove: incompatible fixups"
243+ fixups = Map.fromListWithKey mergeFixups $ concatMap h connections
244+ combineNodeInfos _ nia nib = NodeInfo
245+ { _nodeInfo_from = _nodeInfo_from nia
246+ , _nodeInfo_to = _nodeInfo_to nib
247+ }
248+ applyFixup _ ni = \case
249+ Fixup_Delete -> Nothing
250+ Fixup_Update u -> Just $ NodeInfo
251+ { _nodeInfo_from = fromMaybe (_nodeInfo_from ni) $ getHere u
252+ , _nodeInfo_to = fromMaybe (_nodeInfo_to ni) $ getThere u
253+ }
254+ m = Map.differenceWithKey applyFixup (Map.unionWithKey combineNodeInfos ma mb) fixups
255+ getHere :: These a b -> Maybe a
256+ getHere = \case
257+ This a -> Just a
258+ These a _ -> Just a
259+ That _ -> Nothing
260+ getThere :: These a b -> Maybe b
261+ getThere = \case
262+ This _ -> Nothing
263+ These _ b -> Just b
264+ That b -> Just b
265+
266+--TODO: Figure out how to implement this in terms of PatchDMapWithMove rather than duplicating it here
267+-- |Compose patches having the same effect as applying the patches in turn: @'applyAlways' (p <> q) == 'applyAlways' p . 'applyAlways' q@
268+instance Ord k => Monoid (PatchMapWithMove k v) where
269+ mempty = PatchMapWithMove mempty
270+ mappend = (<>)
src/Reflex/PerformEvent/Base.hs+1−3
@@ -141,7 +141,7 @@ hostPerformEventT a = do
141 case mToPerform of
141 case mToPerform of
142 Nothing -> return [result']
142 Nothing -> return [result']
143 Just toPerform -> do
143 Just toPerform -> do
144− responses <- runHostFrame $ traverseRequesterData (fmap Identity) toPerform
144+ responses <- runHostFrame $ traverseRequesterData (\v -> Identity <$> v) toPerform
145 mrt <- readRef responseTrigger
145 mrt <- readRef responseTrigger
146 let followupEventTriggers = case mrt of
146 let followupEventTriggers = case mrt of
147 Just rt -> [rt :=> Identity responses]
147 Just rt -> [rt :=> Identity responses]
@@ -164,8 +164,6 @@ instance (ReflexHost t, MonadHold t m) => MonadHold t (PerformEventT t m) where
164 buildDynamic getV0 v' = PerformEventT $ lift $ buildDynamic getV0 v'
164 buildDynamic getV0 v' = PerformEventT $ lift $ buildDynamic getV0 v'
165 {-# INLINABLE headE #-}
165 {-# INLINABLE headE #-}
166 headE = PerformEventT . lift . headE
166 headE = PerformEventT . lift . headE
167− {-# INLINABLE now #-}
168− now = PerformEventT . lift $ now
169
167
170instance (MonadRef (HostFrame t), ReflexHost t) => MonadRef (PerformEventT t m) where
168instance (MonadRef (HostFrame t), ReflexHost t) => MonadRef (PerformEventT t m) where
171 type Ref (PerformEventT t m) = Ref (HostFrame t)
169 type Ref (PerformEventT t m) = Ref (HostFrame t)
src/Reflex/PerformEvent/Class.hs+2−6
@@ -5,9 +5,11 @@
5{-# LANGUAGE FlexibleContexts #-}
5{-# LANGUAGE FlexibleContexts #-}
6{-# LANGUAGE FlexibleInstances #-}
6{-# LANGUAGE FlexibleInstances #-}
7{-# LANGUAGE FunctionalDependencies #-}
7{-# LANGUAGE FunctionalDependencies #-}
8+{-# LANGUAGE MultiParamTypeClasses #-}
8{-# LANGUAGE RankNTypes #-}
9{-# LANGUAGE RankNTypes #-}
9{-# LANGUAGE ScopedTypeVariables #-}
10{-# LANGUAGE ScopedTypeVariables #-}
10{-# LANGUAGE TypeFamilies #-}
11{-# LANGUAGE TypeFamilies #-}
12+{-# LANGUAGE TypeOperators #-}
11{-# LANGUAGE UndecidableInstances #-}
13{-# LANGUAGE UndecidableInstances #-}
12#ifdef USE_REFLEX_OPTIMIZER
14#ifdef USE_REFLEX_OPTIMIZER
13{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
15{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
@@ -21,7 +23,6 @@ import Reflex.Class
21import Reflex.TriggerEvent.Class
23import Reflex.TriggerEvent.Class
22
24
23import Control.Monad.Reader
25import Control.Monad.Reader
24−import Control.Monad.Trans.Maybe (MaybeT (..))
25
26
26-- | 'PerformEvent' represents actions that can trigger other actions based on
27-- | 'PerformEvent' represents actions that can trigger other actions based on
27-- 'Event's.
28-- 'Event's.
@@ -61,8 +62,3 @@ instance PerformEvent t m => PerformEvent t (ReaderT r m) where
61 performEvent e = do
62 performEvent e = do
62 r <- ask
63 r <- ask
63 lift $ performEvent $ flip runReaderT r <$> e
64 lift $ performEvent $ flip runReaderT r <$> e
64−
65−instance PerformEvent t m => PerformEvent t (MaybeT m) where
66− type Performable (MaybeT m) = MaybeT (Performable m)
67− performEvent_ = lift . performEvent_ . fmapCheap (void . runMaybeT)
68− performEvent = lift . fmap (fmapMaybe id) . performEvent . fmapCheap runMaybeT
src/Reflex/PostBuild/Base.hs+1−2
@@ -9,6 +9,7 @@
9{-# LANGUAGE RecursiveDo #-}
9{-# LANGUAGE RecursiveDo #-}
10{-# LANGUAGE ScopedTypeVariables #-}
10{-# LANGUAGE ScopedTypeVariables #-}
11{-# LANGUAGE TypeFamilies #-}
11{-# LANGUAGE TypeFamilies #-}
12+{-# LANGUAGE TypeOperators #-}
12{-# LANGUAGE UndecidableInstances #-}
13{-# LANGUAGE UndecidableInstances #-}
13#ifdef USE_REFLEX_OPTIMIZER
14#ifdef USE_REFLEX_OPTIMIZER
14{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
15{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
@@ -83,8 +84,6 @@ instance MonadHold t m => MonadHold t (PostBuildT t m) where
83 buildDynamic a0 = lift . buildDynamic a0
84 buildDynamic a0 = lift . buildDynamic a0
84 {-# INLINABLE headE #-}
85 {-# INLINABLE headE #-}
85 headE = lift . headE
86 headE = lift . headE
86− {-# INLINABLE now #-}
87− now = lift now
88
87
89instance PerformEvent t m => PerformEvent t (PostBuildT t m) where
88instance PerformEvent t m => PerformEvent t (PostBuildT t m) where
90 type Performable (PostBuildT t m) = Performable m
89 type Performable (PostBuildT t m) = Performable m
src/Reflex/PostBuild/Class.hs+2
@@ -4,8 +4,10 @@
4{-# LANGUAGE DataKinds #-}
4{-# LANGUAGE DataKinds #-}
5{-# LANGUAGE FlexibleInstances #-}
5{-# LANGUAGE FlexibleInstances #-}
6{-# LANGUAGE FunctionalDependencies #-}
6{-# LANGUAGE FunctionalDependencies #-}
7+{-# LANGUAGE MultiParamTypeClasses #-}
7{-# LANGUAGE ScopedTypeVariables #-}
8{-# LANGUAGE ScopedTypeVariables #-}
8{-# LANGUAGE TypeFamilies #-}
9{-# LANGUAGE TypeFamilies #-}
10+{-# LANGUAGE TypeOperators #-}
9{-# LANGUAGE UndecidableInstances #-}
11{-# LANGUAGE UndecidableInstances #-}
10#ifdef USE_REFLEX_OPTIMIZER
12#ifdef USE_REFLEX_OPTIMIZER
11{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
13{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
src/Reflex/Profiled.hs+18−86
@@ -8,17 +8,9 @@
8{-# LANGUAGE StandaloneDeriving #-}
8{-# LANGUAGE StandaloneDeriving #-}
9{-# LANGUAGE TypeFamilies #-}
9{-# LANGUAGE TypeFamilies #-}
10{-# LANGUAGE UndecidableInstances #-}
10{-# LANGUAGE UndecidableInstances #-}
11−{-# LANGUAGE PolyKinds #-}
12−{-# LANGUAGE TypeApplications #-}
13−{-# LANGUAGE RankNTypes #-}
14−-- |
15−-- Module:
16−-- Reflex.Profiled
17−-- Description:
18−-- This module contains an instance of the 'Reflex' class that provides
19−-- profiling/cost-center information.
20module Reflex.Profiled where
11module Reflex.Profiled where
21
12
13+import Control.Lens hiding (children)
22import Control.Monad
14import Control.Monad
23import Control.Monad.Exception
15import Control.Monad.Exception
24import Control.Monad.Fix
16import Control.Monad.Fix
@@ -26,10 +18,8 @@ import Control.Monad.Primitive
26import Control.Monad.Reader
18import Control.Monad.Reader
27import Control.Monad.Ref
19import Control.Monad.Ref
28import Control.Monad.State.Strict (StateT, execStateT, modify)
20import Control.Monad.State.Strict (StateT, execStateT, modify)
29−import Data.Bifunctor
30import Data.Coerce
21import Data.Coerce
31−import Data.Dependent.Map (DMap)
22+import Data.Dependent.Map (DMap, GCompare)
32−import Data.GADT.Compare (GCompare)
33import Data.FastMutableIntMap
23import Data.FastMutableIntMap
34import Data.IORef
24import Data.IORef
35import Data.List
25import Data.List
@@ -37,27 +27,18 @@ import Data.Map (Map)
37import qualified Data.Map.Strict as Map
27import qualified Data.Map.Strict as Map
38import Data.Monoid ((<>))
28import Data.Monoid ((<>))
39import Data.Ord
29import Data.Ord
40−import Data.Profunctor.Unsafe ((#.))
41import qualified Data.Semigroup as S
30import qualified Data.Semigroup as S
42import Data.Type.Coercion
31import Data.Type.Coercion
43import Foreign.Ptr
32import Foreign.Ptr
44import GHC.Foreign
33import GHC.Foreign
45import GHC.IO.Encoding
34import GHC.IO.Encoding
46import GHC.Stack
35import GHC.Stack
47−import Reflex.Adjustable.Class
48−import Reflex.BehaviorWriter.Class
49import Reflex.Class
36import Reflex.Class
50−import Reflex.DynamicWriter.Class
51−import Reflex.EventWriter.Class
52import Reflex.Host.Class
37import Reflex.Host.Class
53−import Reflex.NotReady.Class
54import Reflex.PerformEvent.Class
38import Reflex.PerformEvent.Class
55−import Reflex.PostBuild.Class
56−import Reflex.Query.Class
57−import Reflex.Requester.Class
58−import Reflex.TriggerEvent.Class
59
39
60import System.IO.Unsafe
40import System.IO.Unsafe
41+import Unsafe.Coerce
61
42
62data ProfiledTimeline t
43data ProfiledTimeline t
63
44
@@ -90,9 +71,9 @@ getCostCentreStack = go []
90 go (cc : l) parent
71 go (cc : l) parent
91
72
92toCostCentreTree :: Ptr CostCentreStack -> Int -> IO CostCentreTree
73toCostCentreTree :: Ptr CostCentreStack -> Int -> IO CostCentreTree
93−toCostCentreTree ccs n =
74+toCostCentreTree ccs n = do
75+ ccList <- getCostCentreStack ccs
94− foldr (\cc child -> CostCentreTree 0 n $ Map.singleton cc child) (CostCentreTree n n mempty)
76+ return $ foldr (\cc child -> CostCentreTree 0 n $ Map.singleton cc child) (CostCentreTree n n mempty) ccList
95− <$> getCostCentreStack ccs
96
77
97getCostCentreTree :: IO CostCentreTree
78getCostCentreTree :: IO CostCentreTree
98getCostCentreTree = do
79getCostCentreTree = do
@@ -146,32 +127,27 @@ instance Reflex t => Reflex (ProfiledTimeline t) where
146 push f (Event_Profiled e) = coerce $ push (coerce f) $ profileEvent e -- Profile before rather than after; this way fanout won't count against us
127 push f (Event_Profiled e) = coerce $ push (coerce f) $ profileEvent e -- Profile before rather than after; this way fanout won't count against us
147 pushCheap f (Event_Profiled e) = coerce $ pushCheap (coerce f) $ profileEvent e
128 pushCheap f (Event_Profiled e) = coerce $ pushCheap (coerce f) $ profileEvent e
148 pull = Behavior_Profiled . pull . coerce
129 pull = Behavior_Profiled . pull . coerce
149− fanG (Event_Profiled e) = EventSelectorG $ coerce $ selectG (fanG $ profileEvent e)
130+ merge :: forall k. GCompare k => DMap k (Event (ProfiledTimeline t)) -> Event (ProfiledTimeline t) (DMap k Identity)
150− mergeG :: forall z (k :: z -> *) q v. GCompare k
151− => (forall a. q a -> Event (ProfiledTimeline t) (v a))
152− -> DMap k q -> Event (ProfiledTimeline t) (DMap k v)
131+ merge = Event_Profiled . merge . (unsafeCoerce :: DMap k (Event (ProfiledTimeline t)) -> DMap k (Event t))
153− mergeG nt = Event_Profiled #. mergeG (coerce nt)
132+ fan (Event_Profiled e) = EventSelector $ coerce $ select (fan $ profileEvent e)
154 switch (Behavior_Profiled b) = coerce $ profileEvent $ switch (coerceBehavior b)
133 switch (Behavior_Profiled b) = coerce $ profileEvent $ switch (coerceBehavior b)
155 coincidence (Event_Profiled e) = coerce $ profileEvent $ coincidence (coerceEvent e)
134 coincidence (Event_Profiled e) = coerce $ profileEvent $ coincidence (coerceEvent e)
156 current (Dynamic_Profiled d) = coerce $ current d
135 current (Dynamic_Profiled d) = coerce $ current d
157 updated (Dynamic_Profiled d) = coerce $ profileEvent $ updated d
136 updated (Dynamic_Profiled d) = coerce $ profileEvent $ updated d
158 unsafeBuildDynamic (ProfiledM a0) (Event_Profiled a') = coerce $ unsafeBuildDynamic a0 a'
137 unsafeBuildDynamic (ProfiledM a0) (Event_Profiled a') = coerce $ unsafeBuildDynamic a0 a'
159 unsafeBuildIncremental (ProfiledM a0) (Event_Profiled a') = coerce $ unsafeBuildIncremental a0 a'
138 unsafeBuildIncremental (ProfiledM a0) (Event_Profiled a') = coerce $ unsafeBuildIncremental a0 a'
160− mergeIncrementalG nt res = Event_Profiled $ mergeIncrementalG (coerce nt) (coerce res)
139+ mergeIncremental = Event_Profiled . mergeIncremental . (unsafeCoerce :: Incremental (ProfiledTimeline t) (PatchDMap k (Event (ProfiledTimeline t))) -> Incremental t (PatchDMap k (Event t)))
161− mergeIncrementalWithMoveG nt res = Event_Profiled $ mergeIncrementalWithMoveG (coerce nt) (coerce res)
140+ mergeIncrementalWithMove = Event_Profiled . mergeIncrementalWithMove . (unsafeCoerce :: Incremental (ProfiledTimeline t) (PatchDMapWithMove k (Event (ProfiledTimeline t))) -> Incremental t (PatchDMapWithMove k (Event t)))
162 currentIncremental (Incremental_Profiled i) = coerce $ currentIncremental i
141 currentIncremental (Incremental_Profiled i) = coerce $ currentIncremental i
163 updatedIncremental (Incremental_Profiled i) = coerce $ profileEvent $ updatedIncremental i
142 updatedIncremental (Incremental_Profiled i) = coerce $ profileEvent $ updatedIncremental i
164 incrementalToDynamic (Incremental_Profiled i) = coerce $ incrementalToDynamic i
143 incrementalToDynamic (Incremental_Profiled i) = coerce $ incrementalToDynamic i
165− behaviorCoercion c =
144+ behaviorCoercion (c :: Coercion a b) = case behaviorCoercion c :: Coercion (Behavior t a) (Behavior t b) of
166− Coercion `trans` behaviorCoercion @t c `trans` Coercion
145+ Coercion -> unsafeCoerce (Coercion :: Coercion (Behavior (ProfiledTimeline t) a) (Behavior (ProfiledTimeline t) a)) --TODO: Figure out how to make this typecheck without the unsafeCoerce
167− eventCoercion c =
146+ eventCoercion (c :: Coercion a b) = case eventCoercion c :: Coercion (Event t a) (Event t b) of
168− Coercion `trans` eventCoercion @t c `trans` Coercion
147+ Coercion -> unsafeCoerce (Coercion :: Coercion (Event (ProfiledTimeline t) a) (Event (ProfiledTimeline t) a)) --TODO: Figure out how to make this typecheck without the unsafeCoerce
169− dynamicCoercion c =
148+ dynamicCoercion (c :: Coercion a b) = case dynamicCoercion c :: Coercion (Dynamic t a) (Dynamic t b) of
170− Coercion `trans` dynamicCoercion @t c `trans` Coercion
149+ Coercion -> unsafeCoerce (Coercion :: Coercion (Dynamic (ProfiledTimeline t) a) (Dynamic (ProfiledTimeline t) a)) --TODO: Figure out how to make this typecheck without the unsafeCoerce
171− incrementalCoercion c d =
172− Coercion `trans` incrementalCoercion @t c d `trans` Coercion
173− mergeIntIncremental = Event_Profiled . mergeIntIncremental .
150+ mergeIntIncremental = Event_Profiled . mergeIntIncremental . (unsafeCoerce :: Incremental (ProfiledTimeline t) (PatchIntMap (Event (ProfiledTimeline t) a)) -> Incremental t (PatchIntMap (Event t a)))
174− coerceWith (Coercion `trans` incrementalCoercion Coercion Coercion `trans` Coercion)
175 fanInt (Event_Profiled e) = coerce $ fanInt $ profileEvent e
151 fanInt (Event_Profiled e) = coerce $ fanInt $ profileEvent e
176
152
177deriving instance Functor (Dynamic t) => Functor (Dynamic (ProfiledTimeline t))
153deriving instance Functor (Dynamic t) => Functor (Dynamic (ProfiledTimeline t))
@@ -184,21 +160,10 @@ instance MonadHold t m => MonadHold (ProfiledTimeline t) (ProfiledM m) where
184 holdIncremental v0 (Event_Profiled v') = ProfiledM $ Incremental_Profiled <$> holdIncremental v0 v'
160 holdIncremental v0 (Event_Profiled v') = ProfiledM $ Incremental_Profiled <$> holdIncremental v0 v'
185 buildDynamic (ProfiledM v0) (Event_Profiled v') = ProfiledM $ Dynamic_Profiled <$> buildDynamic v0 v'
161 buildDynamic (ProfiledM v0) (Event_Profiled v') = ProfiledM $ Dynamic_Profiled <$> buildDynamic v0 v'
186 headE (Event_Profiled e) = ProfiledM $ Event_Profiled <$> headE e
162 headE (Event_Profiled e) = ProfiledM $ Event_Profiled <$> headE e
187− now = ProfiledM $ Event_Profiled <$> now
188
163
189instance MonadSample t m => MonadSample (ProfiledTimeline t) (ProfiledM m) where
164instance MonadSample t m => MonadSample (ProfiledTimeline t) (ProfiledM m) where
190 sample (Behavior_Profiled b) = ProfiledM $ sample b
165 sample (Behavior_Profiled b) = ProfiledM $ sample b
191
166
192−instance Adjustable t m => Adjustable (ProfiledTimeline t) (ProfiledM m) where
193− runWithReplace a0 a' = (fmap . fmap) coerce . lift $
194− runWithReplace (coerce a0) (coerce $ coerce <$> a')
195− traverseIntMapWithKeyWithAdjust f dm0 dm' = (fmap . fmap) coerce . lift $
196− traverseIntMapWithKeyWithAdjust (\k v -> coerce $ f k v) dm0 (coerce dm')
197− traverseDMapWithKeyWithAdjust f dm0 dm' = (fmap . fmap) coerce . lift $
198− traverseDMapWithKeyWithAdjust (\k v -> coerce $ f k v) dm0 (coerce dm')
199− traverseDMapWithKeyWithAdjustWithMove f dm0 dm' = (fmap . fmap) coerce . lift $
200− traverseDMapWithKeyWithAdjustWithMove (\k v -> coerce $ f k v) dm0 (coerce dm')
201−
202instance MonadTrans ProfiledM where
167instance MonadTrans ProfiledM where
203 lift = ProfiledM
168 lift = ProfiledM
204
169
@@ -210,39 +175,6 @@ instance PerformEvent t m => PerformEvent (ProfiledTimeline t) (ProfiledM m) whe
210 performEvent_ = lift . performEvent_ . coerce
175 performEvent_ = lift . performEvent_ . coerce
211 performEvent = lift . fmap coerce . performEvent . coerce
176 performEvent = lift . fmap coerce . performEvent . coerce
212
177
213−instance TriggerEvent t m => TriggerEvent (ProfiledTimeline t) (ProfiledM m) where
214− newTriggerEvent = first coerce <$> lift newTriggerEvent
215− newTriggerEventWithOnComplete = first coerce <$> lift newTriggerEventWithOnComplete
216− newEventWithLazyTriggerWithOnComplete f = coerce <$> lift (newEventWithLazyTriggerWithOnComplete f)
217−
218−instance PostBuild t m => PostBuild (ProfiledTimeline t) (ProfiledM m) where
219− getPostBuild = coerce <$> lift getPostBuild
220−
221−instance NotReady t m => NotReady (ProfiledTimeline t) (ProfiledM m) where
222− notReady = lift notReady
223− notReadyUntil = lift . notReadyUntil . coerce
224−
225−instance BehaviorWriter t w m => BehaviorWriter (ProfiledTimeline t) w (ProfiledM m) where
226− tellBehavior = lift . tellBehavior . coerce
227−
228−instance DynamicWriter t w m => DynamicWriter (ProfiledTimeline t) w (ProfiledM m) where
229− tellDyn = lift . tellDyn . coerce
230−
231−instance EventWriter t w m => EventWriter (ProfiledTimeline t) w (ProfiledM m) where
232− tellEvent = lift . tellEvent . coerce
233−
234−instance MonadQuery t q m => MonadQuery (ProfiledTimeline t) q (ProfiledM m) where
235− tellQueryIncremental = lift . tellQueryIncremental . coerce
236− askQueryResult = coerce <$> lift askQueryResult
237− queryIncremental = fmap coerce . lift . queryIncremental . coerce
238−
239−instance Requester t m => Requester (ProfiledTimeline t) (ProfiledM m) where
240− type Request (ProfiledM m) = Request m
241− type Response (ProfiledM m) = Response m
242−
243− requesting = fmap coerce . lift . requesting . coerce
244− requesting_ = lift . requesting_ . coerce
245−
246instance MonadRef m => MonadRef (ProfiledM m) where
178instance MonadRef m => MonadRef (ProfiledM m) where
247 type Ref (ProfiledM m) = Ref m
179 type Ref (ProfiledM m) = Ref m
248 newRef = lift . newRef
180 newRef = lift . newRef
src/Reflex/Pure.hs+23−34
@@ -5,9 +5,6 @@
5{-# LANGUAGE MultiParamTypeClasses #-}
5{-# LANGUAGE MultiParamTypeClasses #-}
6{-# LANGUAGE ScopedTypeVariables #-}
6{-# LANGUAGE ScopedTypeVariables #-}
7{-# LANGUAGE TypeFamilies #-}
7{-# LANGUAGE TypeFamilies #-}
8−{-# LANGUAGE RankNTypes #-}
9−{-# LANGUAGE PolyKinds #-}
10−
11#ifdef USE_REFLEX_OPTIMIZER
8#ifdef USE_REFLEX_OPTIMIZER
12{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
9{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
13#endif
10#endif
@@ -16,13 +13,11 @@
16-- * MonadSample (Pure t) ((->) t)
13-- * MonadSample (Pure t) ((->) t)
17-- * MonadHold (Pure t) ((->) t)
14-- * MonadHold (Pure t) ((->) t)
18{-# OPTIONS_GHC -fno-warn-orphans #-}
15{-# OPTIONS_GHC -fno-warn-orphans #-}
19−-- |
16+
20−-- Module: Reflex.Pure
21−-- Description:
22−-- This module provides a pure implementation of Reflex, which is intended to
17+-- | This module provides a pure implementation of Reflex, which is intended to
23−-- serve as a reference for the semantics of the Reflex class. All
18+-- serve as a reference for the semantics of the Reflex class. All
24−-- implementations of Reflex should produce the same results as this
19+-- implementations of Reflex should produce the same results as this
25−-- implementation, although performance and laziness/strictness may differ.
20+-- implementation, although performance and laziness/strictness may differ.
26module Reflex.Pure
21module Reflex.Pure
27 ( Pure
22 ( Pure
28 , Behavior (..)
23 , Behavior (..)
@@ -31,10 +26,14 @@ module Reflex.Pure
31 , Incremental (..)
26 , Incremental (..)
32 ) where
27 ) where
33
28
29+#if !MIN_VERSION_base(4,8,0)
30+import Control.Applicative
31+#endif
32+
34import Control.Monad
33import Control.Monad
35−import Data.Dependent.Map (DMap)
34+import Data.Dependent.Map (DMap, GCompare)
36−import Data.GADT.Compare (GCompare)
37import qualified Data.Dependent.Map as DMap
35import qualified Data.Dependent.Map as DMap
36+import Data.Functor.Identity
38import Data.IntMap (IntMap)
37import Data.IntMap (IntMap)
39import qualified Data.IntMap as IntMap
38import qualified Data.IntMap as IntMap
40import Data.Maybe
39import Data.Maybe
@@ -42,11 +41,10 @@ import Data.MemoTrie
42import Data.Monoid
41import Data.Monoid
43import Data.Type.Coercion
42import Data.Type.Coercion
44import Reflex.Class
43import Reflex.Class
45−import Data.Kind (Type)
46
44
47-- | A completely pure-functional 'Reflex' timeline, identifying moments in time
45-- | A completely pure-functional 'Reflex' timeline, identifying moments in time
48-- with the type @/t/@.
46-- with the type @/t/@.
49−data Pure (t :: Type)
47+data Pure t
50
48
51-- | The 'Enum' instance of @/t/@ must be dense: for all @/x :: t/@, there must not exist
49-- | The 'Enum' instance of @/t/@ must be dense: for all @/x :: t/@, there must not exist
52-- any @/y :: t/@ such that @/'pred' x < y < x/@. The 'HasTrie' instance will be used
50-- any @/y :: t/@ such that @/'pred' x < y < x/@. The 'HasTrie' instance will be used
@@ -79,19 +77,17 @@ instance (Enum t, HasTrie t, Ord t) => Reflex (Pure t) where
79 -- [UNUSED_CONSTRAINT]: The following type signature for merge will produce a
77 -- [UNUSED_CONSTRAINT]: The following type signature for merge will produce a
80 -- warning because the GCompare instance is not used; however, removing the
78 -- warning because the GCompare instance is not used; however, removing the
81 -- GCompare instance produces a different warning, due to that constraint
79 -- GCompare instance produces a different warning, due to that constraint
82− -- being present in the original class definition.
80+ -- being present in the original class definition
83
81
84− --mergeG :: GCompare k => (forall a. q a -> Event (Pure t) (v a))
82+ --merge :: GCompare k => DMap k (Event (Pure t)) -> Event (Pure t) (DMap k Identity)
85− -- -> DMap k q -> Event (Pure t) (DMap k v)
86− mergeG nt events = Event $ memo $ \t ->
83+ merge events = Event $ memo $ \t ->
87− let currentOccurrences = DMap.mapMaybeWithKey (\_ q -> case nt q of Event a -> a t) events
84+ let currentOccurrences = DMap.mapMaybeWithKey (\_ (Event a) -> Identity <$> a t) events
88 in if DMap.null currentOccurrences
85 in if DMap.null currentOccurrences
89 then Nothing
86 then Nothing
90 else Just currentOccurrences
87 else Just currentOccurrences
91
88
92−-- The instance signature doeesn't compile, leave commented for documentation
93−-- fanG :: GCompare k => Event (Pure t) (DMap k v) -> EventSelectorG (Pure t) k v
89+ fan :: GCompare k => Event (Pure t) (DMap k Identity) -> EventSelector (Pure t) k
94− fanG e = EventSelectorG $ \k -> Event $ \t -> unEvent e t >>= DMap.lookup k
90+ fan e = EventSelector $ \k -> Event $ \t -> unEvent e t >>= fmap runIdentity . DMap.lookup k
95
91
96 switch :: Behavior (Pure t) (Event (Pure t) a) -> Event (Pure t) a
92 switch :: Behavior (Pure t) (Event (Pure t) a) -> Event (Pure t) a
97 switch b = Event $ memo $ \t -> unEvent (unBehavior b t) t
93 switch b = Event $ memo $ \t -> unEvent (unBehavior b t) t
@@ -114,8 +110,8 @@ instance (Enum t, HasTrie t, Ord t) => Reflex (Pure t) where
114 --a) -> Incremental (Pure t) p a
110 --a) -> Incremental (Pure t) p a
115 unsafeBuildIncremental readV0 p = Incremental $ \t -> (readV0 t, unEvent p t)
111 unsafeBuildIncremental readV0 p = Incremental $ \t -> (readV0 t, unEvent p t)
116
112
117− mergeIncrementalG = mergeIncrementalImpl
113+ mergeIncremental = mergeIncrementalImpl
118− mergeIncrementalWithMoveG = mergeIncrementalImpl
114+ mergeIncrementalWithMove = mergeIncrementalImpl
119
115
120 currentIncremental i = Behavior $ \t -> fst $ unIncremental i t
116 currentIncremental i = Behavior $ \t -> fst $ unIncremental i t
121
117
@@ -130,17 +126,14 @@ instance (Enum t, HasTrie t, Ord t) => Reflex (Pure t) where
130 behaviorCoercion Coercion = Coercion
126 behaviorCoercion Coercion = Coercion
131 eventCoercion Coercion = Coercion
127 eventCoercion Coercion = Coercion
132 dynamicCoercion Coercion = Coercion
128 dynamicCoercion Coercion = Coercion
133− incrementalCoercion Coercion Coercion = Coercion
134
129
135 fanInt e = EventSelectorInt $ \k -> Event $ \t -> unEvent e t >>= IntMap.lookup k
130 fanInt e = EventSelectorInt $ \k -> Event $ \t -> unEvent e t >>= IntMap.lookup k
136
131
137 mergeIntIncremental = mergeIntIncrementalImpl
132 mergeIntIncremental = mergeIntIncrementalImpl
138
133
139−mergeIncrementalImpl :: (PatchTarget p ~ DMap k q, GCompare k)
134+mergeIncrementalImpl :: (PatchTarget p ~ DMap k (Event (Pure t)), GCompare k) => Incremental (Pure t) p -> Event (Pure t) (DMap k Identity)
140− => (forall a. q a -> Event (Pure t) (v a))
141− -> Incremental (Pure t) p -> Event (Pure t) (DMap k v)
142−mergeIncrementalImpl nt i = Event $ \t ->
135+mergeIncrementalImpl i = Event $ \t ->
143− let results = DMap.mapMaybeWithKey (\_ q -> case nt q of Event e -> e t) $ fst $ unIncremental i t
136+ let results = DMap.mapMaybeWithKey (\_ (Event e) -> Identity <$> e t) $ fst $ unIncremental i t
144 in if DMap.null results
137 in if DMap.null results
145 then Nothing
138 then Nothing
146 else Just results
139 else Just results
@@ -211,7 +204,3 @@ instance (Enum t, HasTrie t, Ord t) => MonadHold (Pure t) ((->) t) where
211 Just x -> fromMaybe lastValue $ apply x lastValue
204 Just x -> fromMaybe lastValue $ apply x lastValue
212
205
213 headE = slowHeadE
206 headE = slowHeadE
214− now t = Event $ guard . (t ==)
215−
216−
217−
src/Reflex/Query/Base.hs+42−44
@@ -1,6 +1,7 @@
1{-# LANGUAGE FlexibleInstances #-}
1{-# LANGUAGE FlexibleInstances #-}
2{-# LANGUAGE GeneralizedNewtypeDeriving #-}
2{-# LANGUAGE GeneralizedNewtypeDeriving #-}
3{-# LANGUAGE InstanceSigs #-}
3{-# LANGUAGE InstanceSigs #-}
4+{-# LANGUAGE KindSignatures #-}
4{-# LANGUAGE LambdaCase #-}
5{-# LANGUAGE LambdaCase #-}
5{-# LANGUAGE MultiParamTypeClasses #-}
6{-# LANGUAGE MultiParamTypeClasses #-}
6{-# LANGUAGE RankNTypes #-}
7{-# LANGUAGE RankNTypes #-}
@@ -16,32 +17,29 @@ module Reflex.Query.Base
16 , mapQueryResult
17 , mapQueryResult
17 , dynWithQueryT
18 , dynWithQueryT
18 , withQueryT
19 , withQueryT
19− , mapQueryT
20 ) where
20 ) where
21
21
22import Control.Applicative (liftA2)
22import Control.Applicative (liftA2)
23import Control.Monad.Exception
23import Control.Monad.Exception
24import Control.Monad.Fix
24import Control.Monad.Fix
25−import Control.Monad.Morph
26import Control.Monad.Primitive
25import Control.Monad.Primitive
27import Control.Monad.Reader
26import Control.Monad.Reader
28import Control.Monad.Ref
27import Control.Monad.Ref
29import Control.Monad.State.Strict
28import Control.Monad.State.Strict
30import Data.Align
29import Data.Align
31−import Data.Dependent.Map (DMap)
30+import Data.Dependent.Map (DMap, DSum (..))
32import qualified Data.Dependent.Map as DMap
31import qualified Data.Dependent.Map as DMap
33−import Data.Dependent.Sum (DSum(..))
34import Data.Foldable
32import Data.Foldable
35import Data.Functor.Compose
33import Data.Functor.Compose
36import Data.Functor.Misc
34import Data.Functor.Misc
37−import Data.GADT.Compare (GCompare)
38import Data.IntMap (IntMap)
35import Data.IntMap (IntMap)
39import qualified Data.IntMap as IntMap
36import qualified Data.IntMap as IntMap
40import Data.Map (Map)
37import Data.Map (Map)
41import qualified Data.Map as Map
38import qualified Data.Map as Map
42import Data.Monoid ((<>))
39import Data.Monoid ((<>))
43import qualified Data.Semigroup as S
40import qualified Data.Semigroup as S
44−import Data.Some (Some(Some))
41+import Data.Some (Some)
42+import qualified Data.Some as Some
45import Data.These
43import Data.These
46
44
47import Reflex.Class
45import Reflex.Class
@@ -50,7 +48,7 @@ import Reflex.DynamicWriter.Class
50import Reflex.EventWriter.Base
48import Reflex.EventWriter.Base
51import Reflex.EventWriter.Class
49import Reflex.EventWriter.Class
52import Reflex.Host.Class
50import Reflex.Host.Class
53−import qualified Data.Patch.MapWithMove as MapWithMove
51+import qualified Reflex.Patch.MapWithMove as MapWithMove
54import Reflex.PerformEvent.Class
52import Reflex.PerformEvent.Class
55import Reflex.PostBuild.Class
53import Reflex.PostBuild.Class
56import Reflex.Query.Class
54import Reflex.Query.Class
@@ -76,19 +74,26 @@ getQueryTLoweredResultValue (QueryTLoweredResult (v, _)) = v
76getQueryTLoweredResultWritten :: QueryTLoweredResult t q v -> [Behavior t q]
74getQueryTLoweredResultWritten :: QueryTLoweredResult t q v -> [Behavior t q]
77getQueryTLoweredResultWritten (QueryTLoweredResult (_, w)) = w
75getQueryTLoweredResultWritten (QueryTLoweredResult (_, w)) = w
78
76
79−maskMempty :: (Eq a, Monoid a) => a -> Maybe a
77+{-
80−maskMempty x = if x == mempty then Nothing else Just x
78+let sampleBs :: forall m'. MonadSample t m' => [Behavior t q] -> m' q
81−
79+ sampleBs = foldlM (\b a -> (b <>) <$> sample a) mempty
80+ bs' = fmapCheap snd $ r'
81+ patches = unsafeBuildIncremental (sampleBs bs0) $
82+ flip pushCheap bs' $ \bs -> do
83+ p <- (~~) <$> sampleBs bs <*> sample (currentIncremental patches)
84+ return (Just (AdditivePatch p))
85+-}
86+
82−instance (Reflex t, MonadFix m, Group q, Additive q, Query q, Eq q, MonadHold t m, Adjustable t m) => Adjustable t (QueryT t q m) where
87+instance (Reflex t, MonadFix m, Group q, Additive q, Query q, MonadHold t m, Adjustable t m) => Adjustable t (QueryT t q m) where
83 runWithReplace (QueryT a0) a' = do
88 runWithReplace (QueryT a0) a' = do
84 ((r0, bs0), r') <- QueryT $ lift $ runWithReplace (runStateT a0 []) $ fmapCheap (flip runStateT [] . unQueryT) a'
89 ((r0, bs0), r') <- QueryT $ lift $ runWithReplace (runStateT a0 []) $ fmapCheap (flip runStateT [] . unQueryT) a'
85 let sampleBs :: forall m'. MonadSample t m' => [Behavior t q] -> m' q
90 let sampleBs :: forall m'. MonadSample t m' => [Behavior t q] -> m' q
86 sampleBs = foldlM (\b a -> (b <>) <$> sample a) mempty
91 sampleBs = foldlM (\b a -> (b <>) <$> sample a) mempty
87 bs' = fmapCheap snd $ r'
92 bs' = fmapCheap snd $ r'
88 bbs <- hold bs0 bs'
93 bbs <- hold bs0 bs'
89− let patches = flip pushCheap bs' $ \newBs -> do
94+ let patches = flip pushAlwaysCheap bs' $ \newBs -> do
90 oldBs <- sample bbs
95 oldBs <- sample bbs
91− maskMempty <$> ((~~) <$> sampleBs newBs <*> sampleBs oldBs)
96+ (~~) <$> sampleBs newBs <*> sampleBs oldBs
92 QueryT $ modify $ (:) $ pull $ sampleBs =<< sample bbs
97 QueryT $ modify $ (:) $ pull $ sampleBs =<< sample bbs
93 QueryT $ lift $ tellEvent patches
98 QueryT $ lift $ tellEvent patches
94 return (r0, fmapCheap fst r')
99 return (r0, fmapCheap fst r')
@@ -138,7 +143,7 @@ instance (Reflex t, MonadFix m, Group q, Additive q, Query q, Eq q, MonadHold t
138 tellQueryIncremental $ unsafeBuildIncremental (fold <$> mapM sampleBs liftedBs0) qpatch
143 tellQueryIncremental $ unsafeBuildIncremental (fold <$> mapM sampleBs liftedBs0) qpatch
139 return (liftedResult0, liftedResult')
144 return (liftedResult0, liftedResult')
140
145
141− traverseDMapWithKeyWithAdjust :: forall (k :: * -> *) v v'. (GCompare k) => (forall a. k a -> v a -> QueryT t q m (v' a)) -> DMap k v -> Event t (PatchDMap k v) -> QueryT t q m (DMap k v', Event t (PatchDMap k v'))
146+ traverseDMapWithKeyWithAdjust :: forall (k :: * -> *) v v'. (DMap.GCompare k) => (forall a. k a -> v a -> QueryT t q m (v' a)) -> DMap k v -> Event t (PatchDMap k v) -> QueryT t q m (DMap k v', Event t (PatchDMap k v'))
142 traverseDMapWithKeyWithAdjust f dm0 dm' = do
147 traverseDMapWithKeyWithAdjust f dm0 dm' = do
143 let f' :: forall a. k a -> v a -> EventWriterT t q (ReaderT (Dynamic t (QueryResult q)) m) (Compose (QueryTLoweredResult t q) v' a)
148 let f' :: forall a. k a -> v a -> EventWriterT t q (ReaderT (Dynamic t (QueryResult q)) m) (Compose (QueryTLoweredResult t q) v' a)
144 f' k v = fmap (Compose . QueryTLoweredResult) $ flip runStateT [] $ unQueryT $ f k v
149 f' k v = fmap (Compose . QueryTLoweredResult) $ flip runStateT [] $ unQueryT $ f k v
@@ -147,10 +152,10 @@ instance (Reflex t, MonadFix m, Group q, Additive q, Query q, Eq q, MonadHold t
147 liftedResult' = fforCheap result' $ \(PatchDMap p) -> PatchDMap $
152 liftedResult' = fforCheap result' $ \(PatchDMap p) -> PatchDMap $
148 mapKeyValuePairsMonotonic (\(k :=> ComposeMaybe mr) -> k :=> ComposeMaybe (fmap (getQueryTLoweredResultValue . getCompose) mr)) p
153 mapKeyValuePairsMonotonic (\(k :=> ComposeMaybe mr) -> k :=> ComposeMaybe (fmap (getQueryTLoweredResultValue . getCompose) mr)) p
149 liftedBs0 :: Map (Some k) [Behavior t q]
154 liftedBs0 :: Map (Some k) [Behavior t q]
150− liftedBs0 = Map.fromDistinctAscList $ (\(k :=> Compose r) -> (Some k, getQueryTLoweredResultWritten r)) <$> DMap.toList result0
155+ liftedBs0 = Map.fromDistinctAscList $ (\(k :=> Compose r) -> (Some.This k, getQueryTLoweredResultWritten r)) <$> DMap.toList result0
151 liftedBs' :: Event t (PatchMap (Some k) [Behavior t q])
156 liftedBs' :: Event t (PatchMap (Some k) [Behavior t q])
152 liftedBs' = fforCheap result' $ \(PatchDMap p) -> PatchMap $
157 liftedBs' = fforCheap result' $ \(PatchDMap p) -> PatchMap $
153− Map.fromDistinctAscList $ (\(k :=> ComposeMaybe mr) -> (Some k, fmap (getQueryTLoweredResultWritten . getCompose) mr)) <$> DMap.toList p
158+ Map.fromDistinctAscList $ (\(k :=> ComposeMaybe mr) -> (Some.This k, fmap (getQueryTLoweredResultWritten . getCompose) mr)) <$> DMap.toList p
154 sampleBs :: forall m'. MonadSample t m' => [Behavior t q] -> m' q
159 sampleBs :: forall m'. MonadSample t m' => [Behavior t q] -> m' q
155 sampleBs = foldlM (\b a -> (b <>) <$> sample a) mempty
160 sampleBs = foldlM (\b a -> (b <>) <$> sample a) mempty
156 accumBehaviors :: forall m'. MonadHold t m'
161 accumBehaviors :: forall m'. MonadHold t m'
@@ -166,24 +171,24 @@ instance (Reflex t, MonadFix m, Group q, Additive q, Query q, Eq q, MonadHold t
166 let p k bs = case Map.lookup k bs0 of
171 let p k bs = case Map.lookup k bs0 of
167 Nothing -> case bs of
172 Nothing -> case bs of
168 -- If the update is to delete the state for a child that doesn't exist, the patch is mempty.
173 -- If the update is to delete the state for a child that doesn't exist, the patch is mempty.
169− Nothing -> return Nothing
174+ Nothing -> return mempty
170 -- If the update is to update the state for a child that doesn't exist, the patch is the sample of the new state.
175 -- If the update is to update the state for a child that doesn't exist, the patch is the sample of the new state.
171− Just newBs -> maskMempty <$> sampleBs newBs
176+ Just newBs -> sampleBs newBs
172 Just oldBs -> case bs of
177 Just oldBs -> case bs of
173 -- If the update is to delete the state for a child that already exists, the patch is the negation of the child's current state
178 -- If the update is to delete the state for a child that already exists, the patch is the negation of the child's current state
174− Nothing -> maskMempty . negateG <$> sampleBs oldBs
179+ Nothing -> negateG <$> sampleBs oldBs
175 -- If the update is to update the state for a child that already exists, the patch is the negation of sampling the child's current state
180 -- If the update is to update the state for a child that already exists, the patch is the negation of sampling the child's current state
176 -- composed with the sampling the child's new state.
181 -- composed with the sampling the child's new state.
177− Just newBs -> maskMempty <$> ((~~) <$> sampleBs newBs <*> sampleBs oldBs)
182+ Just newBs -> (~~) <$> sampleBs newBs <*> sampleBs oldBs
178 -- we compute the patch by iterating over the update PatchMap and proceeding by cases. Then we fold over the
183 -- we compute the patch by iterating over the update PatchMap and proceeding by cases. Then we fold over the
179 -- child patches and wrap them in AdditivePatch.
184 -- child patches and wrap them in AdditivePatch.
180− patch <- fold <$> Map.traverseWithKey p bs'
185+ patch <- AdditivePatch . fold <$> Map.traverseWithKey p bs'
181− return (apply pbs bs0, AdditivePatch <$> patch)
186+ return (apply pbs bs0, Just patch)
182 (qpatch :: Event t (AdditivePatch q)) <- mapAccumMaybeM_ accumBehaviors liftedBs0 liftedBs'
187 (qpatch :: Event t (AdditivePatch q)) <- mapAccumMaybeM_ accumBehaviors liftedBs0 liftedBs'
183 tellQueryIncremental $ unsafeBuildIncremental (fold <$> mapM sampleBs liftedBs0) qpatch
188 tellQueryIncremental $ unsafeBuildIncremental (fold <$> mapM sampleBs liftedBs0) qpatch
184 return (liftedResult0, liftedResult')
189 return (liftedResult0, liftedResult')
185
190
186− traverseDMapWithKeyWithAdjustWithMove :: forall (k :: * -> *) v v'. (GCompare k) => (forall a. k a -> v a -> QueryT t q m (v' a)) -> DMap k v -> Event t (PatchDMapWithMove k v) -> QueryT t q m (DMap k v', Event t (PatchDMapWithMove k v'))
191+ traverseDMapWithKeyWithAdjustWithMove :: forall (k :: * -> *) v v'. (DMap.GCompare k) => (forall a. k a -> v a -> QueryT t q m (v' a)) -> DMap k v -> Event t (PatchDMapWithMove k v) -> QueryT t q m (DMap k v', Event t (PatchDMapWithMove k v'))
187 traverseDMapWithKeyWithAdjustWithMove f dm0 dm' = do
192 traverseDMapWithKeyWithAdjustWithMove f dm0 dm' = do
188 let f' :: forall a. k a -> v a -> EventWriterT t q (ReaderT (Dynamic t (QueryResult q)) m) (Compose (QueryTLoweredResult t q) v' a)
193 let f' :: forall a. k a -> v a -> EventWriterT t q (ReaderT (Dynamic t (QueryResult q)) m) (Compose (QueryTLoweredResult t q) v' a)
189 f' k v = fmap (Compose . QueryTLoweredResult) $ flip runStateT [] $ unQueryT $ f k v
194 f' k v = fmap (Compose . QueryTLoweredResult) $ flip runStateT [] $ unQueryT $ f k v
@@ -191,10 +196,10 @@ instance (Reflex t, MonadFix m, Group q, Additive q, Query q, Eq q, MonadHold t
191 let liftedResult0 = mapKeyValuePairsMonotonic (\(k :=> Compose r) -> k :=> getQueryTLoweredResultValue r) result0
196 let liftedResult0 = mapKeyValuePairsMonotonic (\(k :=> Compose r) -> k :=> getQueryTLoweredResultValue r) result0
192 liftedResult' = fforCheap result' $ mapPatchDMapWithMove (getQueryTLoweredResultValue . getCompose)
197 liftedResult' = fforCheap result' $ mapPatchDMapWithMove (getQueryTLoweredResultValue . getCompose)
193 liftedBs0 :: Map (Some k) [Behavior t q]
198 liftedBs0 :: Map (Some k) [Behavior t q]
194− liftedBs0 = Map.fromDistinctAscList $ (\(k :=> Compose r) -> (Some k, getQueryTLoweredResultWritten r)) <$> DMap.toList result0
199+ liftedBs0 = Map.fromDistinctAscList $ (\(k :=> Compose r) -> (Some.This k, getQueryTLoweredResultWritten r)) <$> DMap.toList result0
195 liftedBs' :: Event t (PatchMapWithMove (Some k) [Behavior t q])
200 liftedBs' :: Event t (PatchMapWithMove (Some k) [Behavior t q])
196 liftedBs' = fforCheap result' $ weakenPatchDMapWithMoveWith (getQueryTLoweredResultWritten . getCompose) {- \(PatchDMap p) -> PatchMapWithMove $
201 liftedBs' = fforCheap result' $ weakenPatchDMapWithMoveWith (getQueryTLoweredResultWritten . getCompose) {- \(PatchDMap p) -> PatchMapWithMove $
197− Map.fromDistinctAscList $ (\(k :=> mr) -> (Some k, fmap (fmap (getQueryTLoweredResultWritten . getCompose)) mr)) <$> DMap.toList p -}
202+ Map.fromDistinctAscList $ (\(k :=> mr) -> (Some.This k, fmap (fmap (getQueryTLoweredResultWritten . getCompose)) mr)) <$> DMap.toList p -}
198 sampleBs :: forall m'. MonadSample t m' => [Behavior t q] -> m' q
203 sampleBs :: forall m'. MonadSample t m' => [Behavior t q] -> m' q
199 sampleBs = foldlM (\b a -> (b <>) <$> sample a) mempty
204 sampleBs = foldlM (\b a -> (b <>) <$> sample a) mempty
200 accumBehaviors' :: forall m'. MonadHold t m'
205 accumBehaviors' :: forall m'. MonadHold t m'
@@ -211,28 +216,28 @@ instance (Reflex t, MonadFix m, Group q, Additive q, Query q, Eq q, MonadHold t
211 p k bs = case Map.lookup k bs0 of
216 p k bs = case Map.lookup k bs0 of
212 Nothing -> case MapWithMove._nodeInfo_from bs of
217 Nothing -> case MapWithMove._nodeInfo_from bs of
213 -- If the update is to delete the state for a child that doesn't exist, the patch is mempty.
218 -- If the update is to delete the state for a child that doesn't exist, the patch is mempty.
214− MapWithMove.From_Delete -> return Nothing
219+ MapWithMove.From_Delete -> return mempty
215 -- If the update is to update the state for a child that doesn't exist, the patch is the sample of the new state.
220 -- If the update is to update the state for a child that doesn't exist, the patch is the sample of the new state.
216− MapWithMove.From_Insert newBs -> maskMempty <$> sampleBs newBs
221+ MapWithMove.From_Insert newBs -> sampleBs newBs
217 MapWithMove.From_Move k' -> case Map.lookup k' bs0 of
222 MapWithMove.From_Move k' -> case Map.lookup k' bs0 of
218− Nothing -> return Nothing
223+ Nothing -> return mempty
219− Just newBs -> maskMempty <$> sampleBs newBs
224+ Just newBs -> sampleBs newBs
220 Just oldBs -> case MapWithMove._nodeInfo_from bs of
225 Just oldBs -> case MapWithMove._nodeInfo_from bs of
221 -- If the update is to delete the state for a child that already exists, the patch is the negation of the child's current state
226 -- If the update is to delete the state for a child that already exists, the patch is the negation of the child's current state
222− MapWithMove.From_Delete -> maskMempty . negateG <$> sampleBs oldBs
227+ MapWithMove.From_Delete -> negateG <$> sampleBs oldBs
223 -- If the update is to update the state for a child that already exists, the patch is the negation of sampling the child's current state
228 -- If the update is to update the state for a child that already exists, the patch is the negation of sampling the child's current state
224 -- composed with the sampling the child's new state.
229 -- composed with the sampling the child's new state.
225− MapWithMove.From_Insert newBs -> maskMempty <$> ((~~) <$> sampleBs newBs <*> sampleBs oldBs)
230+ MapWithMove.From_Insert newBs -> (~~) <$> sampleBs newBs <*> sampleBs oldBs
226 MapWithMove.From_Move k'
231 MapWithMove.From_Move k'
227− | k' == k -> return Nothing
232+ | k' == k -> return mempty
228 | otherwise -> case Map.lookup k' bs0 of
233 | otherwise -> case Map.lookup k' bs0 of
229 -- If we are moving from a non-existent key, that is a delete
234 -- If we are moving from a non-existent key, that is a delete
230− Nothing -> maskMempty . negateG <$> sampleBs oldBs
235+ Nothing -> negateG <$> sampleBs oldBs
231− Just newBs -> maskMempty <$> ((~~) <$> sampleBs newBs <*> sampleBs oldBs)
236+ Just newBs -> (~~) <$> sampleBs newBs <*> sampleBs oldBs
232 -- we compute the patch by iterating over the update PatchMap and proceeding by cases. Then we fold over the
237 -- we compute the patch by iterating over the update PatchMap and proceeding by cases. Then we fold over the
233 -- child patches and wrap them in AdditivePatch.
238 -- child patches and wrap them in AdditivePatch.
234− patch <- fold <$> Map.traverseWithKey p bs'
239+ patch <- AdditivePatch . fold <$> Map.traverseWithKey p bs'
235− return (apply pbs bs0, AdditivePatch <$> patch)
240+ return (apply pbs bs0, Just patch)
236 (qpatch :: Event t (AdditivePatch q)) <- mapAccumMaybeM_ accumBehaviors' liftedBs0 liftedBs'
241 (qpatch :: Event t (AdditivePatch q)) <- mapAccumMaybeM_ accumBehaviors' liftedBs0 liftedBs'
237 tellQueryIncremental $ unsafeBuildIncremental (fold <$> mapM sampleBs liftedBs0) qpatch
242 tellQueryIncremental $ unsafeBuildIncremental (fold <$> mapM sampleBs liftedBs0) qpatch
238 return (liftedResult0, liftedResult')
243 return (liftedResult0, liftedResult')
@@ -240,9 +245,6 @@ instance (Reflex t, MonadFix m, Group q, Additive q, Query q, Eq q, MonadHold t
240instance MonadTrans (QueryT t q) where
245instance MonadTrans (QueryT t q) where
241 lift = QueryT . lift . lift . lift
246 lift = QueryT . lift . lift . lift
242
247
243−instance MFunctor (QueryT t q) where
244− hoist = mapQueryT
245−
246instance PrimMonad m => PrimMonad (QueryT t q m) where
248instance PrimMonad m => PrimMonad (QueryT t q m) where
247 type PrimState (QueryT t q m) = PrimState m
249 type PrimState (QueryT t q m) = PrimState m
248 primitive = lift . primitive
250 primitive = lift . primitive
@@ -294,10 +296,6 @@ withQueryT f a = do
294 (fmapCheap (AdditivePatch . mapQuery f . unAdditivePatch) $ updatedIncremental q)
296 (fmapCheap (AdditivePatch . mapQuery f . unAdditivePatch) $ updatedIncremental q)
295 return result
297 return result
296
298
297−-- | Maps a function over a 'QueryT' that can change the underlying monad
298−mapQueryT :: (forall b. m b -> n b) -> QueryT t q m a -> QueryT t q n a
299−mapQueryT f (QueryT a) = QueryT $ mapStateT (mapEventWriterT (mapReaderT f)) a
300−
301-- | dynWithQueryT's (Dynamic t QueryMorphism) argument needs to be a group homomorphism at all times in order to behave correctly
299-- | dynWithQueryT's (Dynamic t QueryMorphism) argument needs to be a group homomorphism at all times in order to behave correctly
302dynWithQueryT :: (MonadFix m, PostBuild t m, Group q, Additive q, Group q', Additive q', Query q')
300dynWithQueryT :: (MonadFix m, PostBuild t m, Group q, Additive q, Group q', Additive q', Query q')
303 => Dynamic t (QueryMorphism q q')
301 => Dynamic t (QueryMorphism q q')
@@ -342,5 +340,5 @@ instance Requester t m => Requester t (QueryT t q m) where
342instance EventWriter t w m => EventWriter t w (QueryT t q m) where
340instance EventWriter t w m => EventWriter t w (QueryT t q m) where
343 tellEvent = lift . tellEvent
341 tellEvent = lift . tellEvent
344
342
345−instance DynamicWriter t w m => DynamicWriter t w (QueryT t q m) where
343+instance MonadDynamicWriter t w m => MonadDynamicWriter t w (QueryT t q m) where
346 tellDyn = lift . tellDyn
344 tellDyn = lift . tellDyn
src/Reflex/Query/Class.hs+9−68
@@ -1,18 +1,11 @@
1−{-# LANGUAGE CPP #-}
2{-# LANGUAGE DeriveDataTypeable #-}
1{-# LANGUAGE DeriveDataTypeable #-}
3{-# LANGUAGE FlexibleContexts #-}
2{-# LANGUAGE FlexibleContexts #-}
4{-# LANGUAGE FlexibleInstances #-}
3{-# LANGUAGE FlexibleInstances #-}
5{-# LANGUAGE FunctionalDependencies #-}
4{-# LANGUAGE FunctionalDependencies #-}
6{-# LANGUAGE GeneralizedNewtypeDeriving #-}
5{-# LANGUAGE GeneralizedNewtypeDeriving #-}
6+{-# LANGUAGE MultiParamTypeClasses #-}
7{-# LANGUAGE TypeFamilies #-}
7{-# LANGUAGE TypeFamilies #-}
8{-# LANGUAGE UndecidableInstances #-}
8{-# LANGUAGE UndecidableInstances #-}
9−-- |
10−-- Module:
11−-- Reflex.Query.Class
12−-- Description:
13−-- A class that ties together queries to some data source and their results,
14−-- providing methods for requesting data from the source and accumulating
15−-- streamed results.
16module Reflex.Query.Class
9module Reflex.Query.Class
17 ( Query (..)
10 ( Query (..)
18 , QueryMorphism (..)
11 , QueryMorphism (..)
@@ -22,7 +15,6 @@ module Reflex.Query.Class
22 , MonadQuery (..)
15 , MonadQuery (..)
23 , tellQueryDyn
16 , tellQueryDyn
24 , queryDyn
17 , queryDyn
25− , subQuery
26 , mapQuery
18 , mapQuery
27 , mapQueryResult
19 , mapQueryResult
28 ) where
20 ) where
@@ -35,18 +27,11 @@ import Data.Data
35import Data.Ix
27import Data.Ix
36import Data.Map.Monoidal (MonoidalMap)
28import Data.Map.Monoidal (MonoidalMap)
37import qualified Data.Map.Monoidal as MonoidalMap
29import qualified Data.Map.Monoidal as MonoidalMap
38−import Data.Semigroup (Semigroup(..))
30+import Data.Semigroup
39import Foreign.Storable
31import Foreign.Storable
40−import Data.Void
41−import Data.Monoid hiding ((<>))
42−import Control.Applicative
43
32
44import Reflex.Class
33import Reflex.Class
45
34
46−-- | A 'Query' can be thought of as a declaration of interest in some set of data.
47−-- A 'QueryResult' is the set of data associated with that interest set.
48−-- The @crop@ function provides a way to determine what part of a given 'QueryResult'
49−-- is relevant to a given 'Query'.
50class (Monoid (QueryResult a), Semigroup (QueryResult a)) => Query a where
35class (Monoid (QueryResult a), Semigroup (QueryResult a)) => Query a where
51 type QueryResult a :: *
36 type QueryResult a :: *
52 crop :: a -> QueryResult a -> QueryResult a
37 crop :: a -> QueryResult a -> QueryResult a
@@ -55,39 +40,8 @@ instance (Ord k, Query v) => Query (MonoidalMap k v) where
55 type QueryResult (MonoidalMap k v) = MonoidalMap k (QueryResult v)
40 type QueryResult (MonoidalMap k v) = MonoidalMap k (QueryResult v)
56 crop q r = MonoidalMap.intersectionWith (flip crop) r q
41 crop q r = MonoidalMap.intersectionWith (flip crop) r q
57
42
58−-- | the result of two queries is both results.
59−instance (Query a, Query b) => Query (a, b) where
60− type QueryResult (a, b) = (QueryResult a, QueryResult b)
61− crop (x, x') (y, y') = (crop x y, crop x' y')
62−
63−-- | Trivial queries have trivial results.
64−instance Query () where
65− type QueryResult () = ()
66− crop _ _ = ()
67−
68−-- | The result of an absurd query is trivial; If you can ask the question, the
69−-- answer cannot tell you anything you didn't already know.
70−--
71−-- 'QueryResult Void = @Void@' seems like it would also work, but that has
72−-- problems of robustness. In some applications, an unasked question can still
73−-- be answered, so it is important that the result is inhabited even when the
74−-- question isn't. Applications that wish to prevent this can mandate that the
75−-- query result be paired with the query: then the whole response will be
76−-- uninhabited as desired.
77−instance Query Void where
78− type QueryResult Void = ()
79− crop = absurd
80−
81−#if MIN_VERSION_base(4,12,0)
82−-- | We can lift queries into monoidal containers.
83−-- But beware of Applicatives whose monoid is different from (pure mempty, liftA2 mappend)
84−instance (Query q, Applicative f) => Query (Ap f q) where
85− type QueryResult (Ap f q) = Ap f (QueryResult q)
86− crop = liftA2 crop
87−#endif
88−
89−-- | QueryMorphism's must be group homomorphisms when acting on the query type
43+-- | NB: QueryMorphism's must be group homomorphisms when acting on the query type
90−-- and compatible with the query relationship when acting on the query result.
44+-- and compatible with the query relationship when acting on the query result
91data QueryMorphism q q' = QueryMorphism
45data QueryMorphism q q' = QueryMorphism
92 { _queryMorphism_mapQuery :: q -> q'
46 { _queryMorphism_mapQuery :: q -> q'
93 , _queryMorphism_mapQueryResult :: QueryResult q' -> QueryResult q
47 , _queryMorphism_mapQueryResult :: QueryResult q' -> QueryResult q
@@ -100,16 +54,13 @@ instance Category QueryMorphism where
100 , _queryMorphism_mapQueryResult = mapQueryResult qm' . mapQueryResult qm
54 , _queryMorphism_mapQueryResult = mapQueryResult qm' . mapQueryResult qm
101 }
55 }
102
56
103−-- | Apply a 'QueryMorphism' to a 'Query'
104mapQuery :: QueryMorphism q q' -> q -> q'
57mapQuery :: QueryMorphism q q' -> q -> q'
105mapQuery = _queryMorphism_mapQuery
58mapQuery = _queryMorphism_mapQuery
106
59
107−-- | Map a 'QueryMorphism' to a 'QueryResult'
108mapQueryResult :: QueryMorphism q q' -> QueryResult q' -> QueryResult q
60mapQueryResult :: QueryMorphism q q' -> QueryResult q' -> QueryResult q
109mapQueryResult = _queryMorphism_mapQueryResult
61mapQueryResult = _queryMorphism_mapQueryResult
110
62
111−-- | This type can be used to track of the frequency of interest in a given 'Query'. See note on
63+-- | This type keeps track of the multiplicity of elements of the view selector that are being used by the app
112−-- 'combineSelectedCounts'
113newtype SelectedCount = SelectedCount { unSelectedCount :: Int }
64newtype SelectedCount = SelectedCount { unSelectedCount :: Int }
114 deriving (Eq, Ord, Show, Read, Integral, Num, Bounded, Enum, Real, Ix, Bits, FiniteBits, Storable, Data)
65 deriving (Eq, Ord, Show, Read, Integral, Num, Bounded, Enum, Real, Ix, Bits, FiniteBits, Storable, Data)
115
66
@@ -125,34 +76,24 @@ instance Group SelectedCount where
125
76
126instance Additive SelectedCount
77instance Additive SelectedCount
127
78
128−-- | The Semigroup\/Monoid\/Group instances for a Query containing 'SelectedCount's should use
129−-- this function which returns Nothing if the result is 0. This allows the pruning of leaves
79+-- | The Semigroup/Monoid/Group instances for a ViewSelector should use this function which returns Nothing if the result is 0. This allows the pruning of leaves that are no longer wanted.
130−-- of the 'Query' that are no longer wanted.
131combineSelectedCounts :: SelectedCount -> SelectedCount -> Maybe SelectedCount
80combineSelectedCounts :: SelectedCount -> SelectedCount -> Maybe SelectedCount
132combineSelectedCounts (SelectedCount i) (SelectedCount j) = if i == negate j then Nothing else Just $ SelectedCount (i + j)
81combineSelectedCounts (SelectedCount i) (SelectedCount j) = if i == negate j then Nothing else Just $ SelectedCount (i + j)
133
82
134−-- | A class that allows sending of 'Query's and retrieval of 'QueryResult's. See 'queryDyn' for a commonly
135−-- used interface.
136−class (Group q, Additive q, Query q, Monad m) => MonadQuery t q m | m -> q t where
83+class (Group q, Additive q, Query q) => MonadQuery t q m | m -> q t where
137 tellQueryIncremental :: Incremental t (AdditivePatch q) -> m ()
84 tellQueryIncremental :: Incremental t (AdditivePatch q) -> m ()
138 askQueryResult :: m (Dynamic t (QueryResult q))
85 askQueryResult :: m (Dynamic t (QueryResult q))
139 queryIncremental :: Incremental t (AdditivePatch q) -> m (Dynamic t (QueryResult q))
86 queryIncremental :: Incremental t (AdditivePatch q) -> m (Dynamic t (QueryResult q))
140
87
141−instance MonadQuery t q m => MonadQuery t q (ReaderT r m) where
88+instance (Monad m, MonadQuery t q m) => MonadQuery t q (ReaderT r m) where
142 tellQueryIncremental = lift . tellQueryIncremental
89 tellQueryIncremental = lift . tellQueryIncremental
143 askQueryResult = lift askQueryResult
90 askQueryResult = lift askQueryResult
144 queryIncremental = lift . queryIncremental
91 queryIncremental = lift . queryIncremental
145
92
146−-- | Produce and send an 'Incremental' 'Query' from a 'Dynamic' 'Query'.
147tellQueryDyn :: (Reflex t, MonadQuery t q m) => Dynamic t q -> m ()
93tellQueryDyn :: (Reflex t, MonadQuery t q m) => Dynamic t q -> m ()
148tellQueryDyn d = tellQueryIncremental $ unsafeBuildIncremental (sample (current d)) $ attachWith (\old new -> AdditivePatch $ new ~~ old) (current d) (updated d)
94tellQueryDyn d = tellQueryIncremental $ unsafeBuildIncremental (sample (current d)) $ attachWith (\old new -> AdditivePatch $ new ~~ old) (current d) (updated d)
149
95
150−-- | Retrieve 'Dynamic'ally updating 'QueryResult's for a 'Dynamic'ally updating 'Query'.
151−queryDyn :: (Reflex t, MonadQuery t q m) => Dynamic t q -> m (Dynamic t (QueryResult q))
96+queryDyn :: (Reflex t, Monad m, MonadQuery t q m) => Dynamic t q -> m (Dynamic t (QueryResult q))
152queryDyn q = do
97queryDyn q = do
153 tellQueryDyn q
98 tellQueryDyn q
154 zipDynWith crop q <$> askQueryResult
99 zipDynWith crop q <$> askQueryResult
155−
156−-- | Use a query morphism to operate on a smaller version of a query.
157−subQuery :: (Reflex t, MonadQuery t q2 m) => QueryMorphism q1 q2 -> Dynamic t q1 -> m (Dynamic t (QueryResult q1))
158−subQuery (QueryMorphism f g) x = fmap g <$> queryDyn (fmap f x)
src/Reflex/Requester/Base.hs+18−183
@@ -1,7 +1,6 @@
1-- | This module provides 'RequesterT', the standard implementation of
1-- | This module provides 'RequesterT', the standard implementation of
2-- 'Requester'.
2-- 'Requester'.
3{-# LANGUAGE AllowAmbiguousTypes #-}
3{-# LANGUAGE AllowAmbiguousTypes #-}
4−{-# LANGUAGE ApplicativeDo #-}
5{-# LANGUAGE CPP #-}
4{-# LANGUAGE CPP #-}
6{-# LANGUAGE EmptyDataDecls #-}
5{-# LANGUAGE EmptyDataDecls #-}
7{-# LANGUAGE ExistentialQuantification #-}
6{-# LANGUAGE ExistentialQuantification #-}
@@ -22,7 +21,6 @@
22module Reflex.Requester.Base
21module Reflex.Requester.Base
23 ( RequesterT (..)
22 ( RequesterT (..)
24 , runRequesterT
23 , runRequesterT
25− , withRequesterT
26 , runWithReplaceRequesterTWith
24 , runWithReplaceRequesterTWith
27 , traverseIntMapWithKeyWithAdjustRequesterTWith
25 , traverseIntMapWithKeyWithAdjustRequesterTWith
28 , traverseDMapWithKeyWithAdjustRequesterTWith
26 , traverseDMapWithKeyWithAdjustRequesterTWith
@@ -32,8 +30,6 @@ module Reflex.Requester.Base
32 , forRequesterData
30 , forRequesterData
33 , requesterDataToList
31 , requesterDataToList
34 , singletonRequesterData
32 , singletonRequesterData
35− , matchResponsesWithRequests
36− , matchResponseMapWithRequests
37 , multiEntry
33 , multiEntry
38 , unMultiEntry
34 , unMultiEntry
39 , requesting'
35 , requesting'
@@ -51,17 +47,14 @@ import Reflex.TriggerEvent.Class
51import Control.Applicative (liftA2)
47import Control.Applicative (liftA2)
52import Control.Monad.Exception
48import Control.Monad.Exception
53import Control.Monad.Identity
49import Control.Monad.Identity
54−import Control.Monad.Morph
55import Control.Monad.Primitive
50import Control.Monad.Primitive
56import Control.Monad.Reader
51import Control.Monad.Reader
57import Control.Monad.Ref
52import Control.Monad.Ref
58import Control.Monad.State.Strict
53import Control.Monad.State.Strict
59import Data.Bits
54import Data.Bits
60import Data.Coerce
55import Data.Coerce
61−import Data.Constraint
62−import Data.Dependent.Map (DMap)
56+import Data.Dependent.Map (DMap, DSum (..))
63import qualified Data.Dependent.Map as DMap
57import qualified Data.Dependent.Map as DMap
64−import Data.Dependent.Sum (DSum (..))
65import Data.Functor.Compose
58import Data.Functor.Compose
66import Data.Functor.Misc
59import Data.Functor.Misc
67import Data.IntMap.Strict (IntMap)
60import Data.IntMap.Strict (IntMap)
@@ -71,7 +64,8 @@ import qualified Data.Map as Map
71import Data.Monoid ((<>))
64import Data.Monoid ((<>))
72import Data.Proxy
65import Data.Proxy
73import qualified Data.Semigroup as S
66import qualified Data.Semigroup as S
74−import Data.Some (Some(Some))
67+import Data.Some (Some)
68+import qualified Data.Some as Some
75import Data.Type.Equality
69import Data.Type.Equality
76import Data.Unique.Tag
70import Data.Unique.Tag
77
71
@@ -84,51 +78,19 @@ newtype TagMap (f :: * -> *) = TagMap (IntMap Any)
84
78
85newtype RequesterData f = RequesterData (TagMap (Entry f))
79newtype RequesterData f = RequesterData (TagMap (Entry f))
86
80
87−emptyRequesterData :: RequesterData f
88−emptyRequesterData = RequesterData $ TagMap IntMap.empty
89−
90data RequesterDataKey a where
81data RequesterDataKey a where
91 RequesterDataKey_Single :: {-# UNPACK #-} !(MyTag (Single a)) -> RequesterDataKey a
82 RequesterDataKey_Single :: {-# UNPACK #-} !(MyTag (Single a)) -> RequesterDataKey a
92 RequesterDataKey_Multi :: {-# UNPACK #-} !(MyTag Multi) -> {-# UNPACK #-} !Int -> !(RequesterDataKey a) -> RequesterDataKey a --TODO: Don't put a second Int here (or in the other Multis); use a single Int instead
83 RequesterDataKey_Multi :: {-# UNPACK #-} !(MyTag Multi) -> {-# UNPACK #-} !Int -> !(RequesterDataKey a) -> RequesterDataKey a --TODO: Don't put a second Int here (or in the other Multis); use a single Int instead
93− RequesterDataKey_Multi2 :: GCompare k => {-# UNPACK #-} !(MyTag (Multi2 k)) -> !(Some k) -> {-# UNPACK #-} !Int -> !(RequesterDataKey a) -> RequesterDataKey a
84+ RequesterDataKey_Multi2 :: {-# UNPACK #-} !(MyTag (Multi2 k)) -> !(Some k) -> {-# UNPACK #-} !Int -> !(RequesterDataKey a) -> RequesterDataKey a
94 RequesterDataKey_Multi3 :: {-# UNPACK #-} !(MyTag Multi3) -> {-# UNPACK #-} !Int -> {-# UNPACK #-} !Int -> !(RequesterDataKey a) -> RequesterDataKey a
85 RequesterDataKey_Multi3 :: {-# UNPACK #-} !(MyTag Multi3) -> {-# UNPACK #-} !Int -> {-# UNPACK #-} !Int -> !(RequesterDataKey a) -> RequesterDataKey a
95
86
96singletonRequesterData :: RequesterDataKey a -> f a -> RequesterData f
87singletonRequesterData :: RequesterDataKey a -> f a -> RequesterData f
97singletonRequesterData rdk v = case rdk of
88singletonRequesterData rdk v = case rdk of
98 RequesterDataKey_Single k -> RequesterData $ singletonTagMap k $ Entry v
89 RequesterDataKey_Single k -> RequesterData $ singletonTagMap k $ Entry v
99 RequesterDataKey_Multi k k' k'' -> RequesterData $ singletonTagMap k $ Entry $ IntMap.singleton k' $ singletonRequesterData k'' v
90 RequesterDataKey_Multi k k' k'' -> RequesterData $ singletonTagMap k $ Entry $ IntMap.singleton k' $ singletonRequesterData k'' v
100− RequesterDataKey_Multi2 k k' k'' k''' -> RequesterData $ singletonTagMap k $ Entry $ Multi2Contents
91+ RequesterDataKey_Multi2 k k' k'' k''' -> RequesterData $ singletonTagMap k $ Entry $ Map.singleton k' $ IntMap.singleton k'' $ singletonRequesterData k''' v
101− { _multi2Contents_values = Map.singleton k' $ IntMap.singleton k'' $ singletonRequesterData k''' v
102− , _multi2Contents_dict = Dict
103− }
104 RequesterDataKey_Multi3 k k' k'' k''' -> RequesterData $ singletonTagMap k $ Entry $ IntMap.singleton k' $ IntMap.singleton k'' $ singletonRequesterData k''' v
92 RequesterDataKey_Multi3 k k' k'' k''' -> RequesterData $ singletonTagMap k $ Entry $ IntMap.singleton k' $ IntMap.singleton k'' $ singletonRequesterData k''' v
105
93
106−mergeRequesterData :: RequesterData f -> RequesterData f -> RequesterData f
107−mergeRequesterData (RequesterData a) (RequesterData b) = RequesterData $ mergeTagMap a b
108−
109−mergeTagMap :: forall f. TagMap (Entry f) -> TagMap (Entry f) -> TagMap (Entry f)
110−mergeTagMap (TagMap m) (TagMap n) =
111− TagMap $ IntMap.unionWithKey (g' combiner) m n
112− where
113− combiner :: forall a. MyTag a -> Entry f a -> Entry f a -> Entry f a
114− combiner k (Entry a) (Entry b) = Entry $ case myKeyType k of
115− MyTagType_Single -> a
116− MyTagType_Multi -> IntMap.unionWith mergeRequesterData a b
117− MyTagType_Multi2 -> case _multi2Contents_dict a of
118− Dict -> Multi2Contents
119− { _multi2Contents_values = Map.unionWith (IntMap.unionWith mergeRequesterData) (_multi2Contents_values a) (_multi2Contents_values b)
120− , _multi2Contents_dict = Dict
121− }
122− MyTagType_Multi3 -> IntMap.unionWith (IntMap.unionWith mergeRequesterData) a b
123− g' :: (forall a. MyTag a -> Entry f a -> Entry f a -> Entry f a) -> Int -> Any -> Any -> Any
124− g' f rawKey a b =
125− let k = MyTag rawKey :: MyTag a
126− fromAny :: Any -> Entry f a
127− fromAny = unsafeCoerce
128− toAny :: Entry f a -> Any
129− toAny = unsafeCoerce
130− in toAny $ f k (fromAny a) (fromAny b)
131−
132requesterDataToList :: RequesterData f -> [DSum RequesterDataKey f]
94requesterDataToList :: RequesterData f -> [DSum RequesterDataKey f]
133requesterDataToList (RequesterData m) = do
95requesterDataToList (RequesterData m) = do
134 k :=> Entry e <- tagMapToList m
96 k :=> Entry e <- tagMapToList m
@@ -138,12 +100,11 @@ requesterDataToList (RequesterData m) = do
138 (k', e') <- IntMap.toList e
100 (k', e') <- IntMap.toList e
139 k'' :=> e'' <- requesterDataToList e'
101 k'' :=> e'' <- requesterDataToList e'
140 return $ RequesterDataKey_Multi k k' k'' :=> e''
102 return $ RequesterDataKey_Multi k k' k'' :=> e''
141− MyTagType_Multi2 -> case _multi2Contents_dict e of
103+ MyTagType_Multi2 -> do
142− Dict -> do
143− (k', e') <- Map.toList $ _multi2Contents_values e
104+ (k', e') <- Map.toList e
144− (k'', e'') <- IntMap.toList e'
105+ (k'', e'') <- IntMap.toList e'
145− k''' :=> e''' <- requesterDataToList e''
106+ k''' :=> e''' <- requesterDataToList e''
146− return $ RequesterDataKey_Multi2 k k' k'' k''' :=> e'''
107+ return $ RequesterDataKey_Multi2 k k' k'' k''' :=> e'''
147 MyTagType_Multi3 -> do
108 MyTagType_Multi3 -> do
148 (k', e') <- IntMap.toList e
109 (k', e') <- IntMap.toList e
149 (k'', e'') <- IntMap.toList e'
110 (k'', e'') <- IntMap.toList e'
@@ -171,13 +132,7 @@ traverseRequesterData f (RequesterData m) = RequesterData <$> traverseTagMapWith
171 go k (Entry request) = Entry <$> case myKeyType k of
132 go k (Entry request) = Entry <$> case myKeyType k of
172 MyTagType_Single -> f request
133 MyTagType_Single -> f request
173 MyTagType_Multi -> traverse (traverseRequesterData f) request
134 MyTagType_Multi -> traverse (traverseRequesterData f) request
174− MyTagType_Multi2 -> case request of
175− Multi2Contents { _multi2Contents_values = request', _multi2Contents_dict = Dict } -> do
176− v <- traverse (traverse (traverseRequesterData f)) request'
135+ MyTagType_Multi2 -> traverse (traverse (traverseRequesterData f)) request
177− pure $ Multi2Contents
178− { _multi2Contents_values = v
179− , _multi2Contents_dict = Dict
180− }
181 MyTagType_Multi3 -> traverse (traverse (traverseRequesterData f)) request
136 MyTagType_Multi3 -> traverse (traverse (traverseRequesterData f)) request
182
137
183-- | 'traverseRequesterData' with its arguments flipped
138-- | 'traverseRequesterData' with its arguments flipped
@@ -221,14 +176,9 @@ instance MyTagTypeOffset Multi3 where
221type family EntryContents request a where
176type family EntryContents request a where
222 EntryContents request (Single a) = request a
177 EntryContents request (Single a) = request a
223 EntryContents request Multi = IntMap (RequesterData request)
178 EntryContents request Multi = IntMap (RequesterData request)
224− EntryContents request (Multi2 k) = Multi2Contents k request
179+ EntryContents request (Multi2 k) = Map (Some k) (IntMap (RequesterData request))
225 EntryContents request Multi3 = IntMap (IntMap (RequesterData request))
180 EntryContents request Multi3 = IntMap (IntMap (RequesterData request))
226
181
227−data Multi2Contents k request = Multi2Contents
228− { _multi2Contents_dict :: {-# UNPACK #-} !(Dict (GCompare k)) -- This is a Dict instead of an existential context because we only want to use it in certain circumstances
229− , _multi2Contents_values :: {-# UNPACK #-} !(Map (Some k) (IntMap (RequesterData request)))
230− }
231−
232newtype Entry request x = Entry { unEntry :: EntryContents request x }
182newtype Entry request x = Entry { unEntry :: EntryContents request x }
233
183
234{-# INLINE singleEntry #-}
184{-# INLINE singleEntry #-}
@@ -315,6 +265,7 @@ instance (S.Semigroup a, Monad m) => S.Semigroup (RequesterT t request response
315-- requests are made, and responses should be provided in the input 'Event'.
265-- requests are made, and responses should be provided in the input 'Event'.
316-- The 'Tag' keys will be used to return the responses to the same place the
266-- The 'Tag' keys will be used to return the responses to the same place the
317-- requests were issued.
267-- requests were issued.
268+
318runRequesterT :: (Reflex t, Monad m)
269runRequesterT :: (Reflex t, Monad m)
319 => RequesterT t request response m a
270 => RequesterT t request response m a
320 -> Event t (RequesterData response) --TODO: This DMap will be in reverse order, so we need to make sure the caller traverses it in reverse
271 -> Event t (RequesterData response) --TODO: This DMap will be in reverse order, so we need to make sure the caller traverses it in reverse
@@ -324,20 +275,6 @@ runRequesterT (RequesterT a) responses = do
324 coerceEvent responses
275 coerceEvent responses
325 return (result, fmapCheap (RequesterData . TagMap) $ mergeInt $ IntMap.fromDistinctAscList $ _requesterState_requests s)
276 return (result, fmapCheap (RequesterData . TagMap) $ mergeInt $ IntMap.fromDistinctAscList $ _requesterState_requests s)
326
277
327−-- | Map a function over the request and response of a 'RequesterT'
328−withRequesterT
329− :: (Reflex t, MonadFix m)
330− => (forall x. req x -> req' x) -- ^ The function to map over the request
331− -> (forall x. rsp' x -> rsp x) -- ^ The function to map over the response
332− -> RequesterT t req rsp m a -- ^ The internal 'RequesterT' whose input and output will be transformed
333− -> RequesterT t req' rsp' m a -- ^ The resulting 'RequesterT'
334−withRequesterT freq frsp child = do
335− rec let rsp = fmap (runIdentity . traverseRequesterData (Identity . frsp)) rsp'
336− (a, req) <- lift $ runRequesterT child rsp
337− rsp' <- fmap (flip selectInt 0 . fanInt . fmapCheap unMultiEntry) $ requesting' $
338− fmapCheap (multiEntry . IntMap.singleton 0) $ fmap (runIdentity . traverseRequesterData (Identity . freq)) req
339− return a
340−
341instance (Reflex t, Monad m) => Requester t (RequesterT t request response m) where
278instance (Reflex t, Monad m) => Requester t (RequesterT t request response m) where
342 type Request (RequesterT t request response m) = request
279 type Request (RequesterT t request response m) = request
343 type Response (RequesterT t request response m) = response
280 type Response (RequesterT t request response m) = response
@@ -357,7 +294,7 @@ tagRequest req = do
357 return t
294 return t
358
295
359{-# INLINE responseFromTag #-}
296{-# INLINE responseFromTag #-}
360−responseFromTag :: forall m t request response x. Monad m => MyTagWrap response (Entry response x) -> RequesterT t request response m (Event t (Entry response x))
297+responseFromTag :: Monad m => MyTagWrap response (Entry response x) -> RequesterT t request response m (Event t (Entry response x))
361responseFromTag (MyTagWrap t) = do
298responseFromTag (MyTagWrap t) = do
362 responses :: EventSelectorInt t Any <- RequesterT ask
299 responses :: EventSelectorInt t Any <- RequesterT ask
363 return $ (unsafeCoerce :: Event t Any -> Event t (Entry response x)) $ selectInt responses t
300 return $ (unsafeCoerce :: Event t Any -> Event t (Entry response x)) $ selectInt responses t
@@ -365,9 +302,6 @@ responseFromTag (MyTagWrap t) = do
365instance MonadTrans (RequesterT t request response) where
302instance MonadTrans (RequesterT t request response) where
366 lift = RequesterT . lift . lift
303 lift = RequesterT . lift . lift
367
304
368−instance MFunctor (RequesterT t request response) where
369− hoist f = RequesterT . hoist (hoist f) . unRequesterT
370−
371instance PerformEvent t m => PerformEvent t (RequesterT t request response m) where
305instance PerformEvent t m => PerformEvent t (RequesterT t request response m) where
372 type Performable (RequesterT t request response m) = Performable m
306 type Performable (RequesterT t request response m) = Performable m
373 performEvent_ = lift . performEvent_
307 performEvent_ = lift . performEvent_
@@ -444,7 +378,7 @@ traverseIntMapWithKeyWithAdjustRequesterTWith base patchNewElements mergePatchIn
444 pack = Entry
378 pack = Entry
445 f' :: IntMap.Key -> (Int, v) -> m (Event t (IntMap (RequesterData request)), v')
379 f' :: IntMap.Key -> (Int, v) -> m (Event t (IntMap (RequesterData request)), v')
446 f' k (n, v) = do
380 f' k (n, v) = do
447− (result, myRequests) <- runRequesterT (f k v) $ mapMaybeCheap (IntMap.lookup n) $ selectInt responses k --TODO: Instead of doing mapMaybeCheap, can we share a fanInt across all instances of a given key, or at least the ones that are adjacent in time?
381+ (result, myRequests) <- runRequesterT (f k v) $ fmapMaybeCheap (IntMap.lookup n) $ selectInt responses k --TODO: Instead of doing fmapMaybeCheap, can we share a fanInt across all instances of a given key, or at least the ones that are adjacent in time?
448 return (fmapCheap (IntMap.singleton n) myRequests, result)
382 return (fmapCheap (IntMap.singleton n) myRequests, result)
449 ndm' <- numberOccurrencesFrom 1 dm'
383 ndm' <- numberOccurrencesFrom 1 dm'
450 (children0, children') <- base f' (fmap ((,) 0) dm0) $ fmap (\(n, dm) -> fmap ((,) n) dm) ndm' --TODO: Avoid this somehow, probably by adding some sort of per-cohort information passing to Adjustable
384 (children0, children') <- base f' (fmap ((,) 0) dm0) $ fmap (\(n, dm) -> fmap ((,) n) dm) ndm' --TODO: Avoid this somehow, probably by adding some sort of per-cohort information passing to Adjustable
@@ -487,12 +421,12 @@ traverseDMapWithKeyWithAdjustRequesterTWith base mapPatch weakenPatchWith patchN
487 let responses :: EventSelector t (Const2 (Some k) (IntMap (RequesterData response)))
421 let responses :: EventSelector t (Const2 (Some k) (IntMap (RequesterData response)))
488 responses = fanMap $ fmapCheap unpack response
422 responses = fanMap $ fmapCheap unpack response
489 unpack :: Entry response (Multi2 k) -> Map (Some k) (IntMap (RequesterData response))
423 unpack :: Entry response (Multi2 k) -> Map (Some k) (IntMap (RequesterData response))
490− unpack = _multi2Contents_values . unEntry
424+ unpack = unEntry
491 pack :: Map (Some k) (IntMap (RequesterData request)) -> Entry request (Multi2 k)
425 pack :: Map (Some k) (IntMap (RequesterData request)) -> Entry request (Multi2 k)
492− pack m = Entry $ Multi2Contents { _multi2Contents_values = m, _multi2Contents_dict = Dict }
426+ pack = Entry
493 f' :: forall a. k a -> Compose ((,) Int) v a -> m (Compose ((,) (Event t (IntMap (RequesterData request)))) v' a)
427 f' :: forall a. k a -> Compose ((,) Int) v a -> m (Compose ((,) (Event t (IntMap (RequesterData request)))) v' a)
494 f' k (Compose (n, v)) = do
428 f' k (Compose (n, v)) = do
495− (result, myRequests) <- runRequesterT (f k v) $ mapMaybeCheap (IntMap.lookup n) $ select responses (Const2 (Some k))
429+ (result, myRequests) <- runRequesterT (f k v) $ fmapMaybeCheap (IntMap.lookup n) $ select responses (Const2 (Some.This k))
496 return $ Compose (fmapCheap (IntMap.singleton n) myRequests, result)
430 return $ Compose (fmapCheap (IntMap.singleton n) myRequests, result)
497 ndm' <- numberOccurrencesFrom 1 dm'
431 ndm' <- numberOccurrencesFrom 1 dm'
498 (children0, children') <- base f' (DMap.map (\v -> Compose (0, v)) dm0) $ fmap (\(n, dm) -> mapPatch (\v -> Compose (n, v)) dm) ndm'
432 (children0, children') <- base f' (DMap.map (\v -> Compose (0, v)) dm0) $ fmap (\(n, dm) -> mapPatch (\v -> Compose (n, v)) dm) ndm'
@@ -506,102 +440,3 @@ traverseDMapWithKeyWithAdjustRequesterTWith base mapPatch weakenPatchWith patchN
506 promptRequests = coincidence $ fmapCheap (mergeMap . patchNewElements) requests' --TODO: Create a mergeIncrementalPromptly, and use that to eliminate this 'coincidence'
440 promptRequests = coincidence $ fmapCheap (mergeMap . patchNewElements) requests' --TODO: Create a mergeIncrementalPromptly, and use that to eliminate this 'coincidence'
507 requests <- holdIncremental requests0 requests'
441 requests <- holdIncremental requests0 requests'
508 return (result0, result')
442 return (result0, result')
509−
510−data Decoder rawResponse response =
511− forall a. Decoder (RequesterDataKey a) (rawResponse -> response a)
512−
513−matchResponsesWithRequests
514− :: forall t rawRequest rawResponse request response m.
515− ( MonadFix m
516− , MonadHold t m
517− , Reflex t
518− )
519− => (forall a. request a -> (rawRequest, rawResponse -> response a))
520− -- ^ Given a request (from 'Requester'), produces the wire format of the
521− -- request and a function used to process the associated response
522− -> Event t (RequesterData request)
523− -- ^ The outgoing requests
524− -> Event t (Int, rawResponse)
525− -- ^ The incoming responses, tagged by an identifying key
526− -> m ( Event t (Map Int rawRequest)
527− , Event t (RequesterData response)
528− )
529− -- ^ A map of outgoing wire-format requests and an event of responses keyed
530− -- by the 'RequesterData' key of the associated outgoing request
531−matchResponsesWithRequests f send recv = matchResponseMapWithRequests f send $ uncurry Map.singleton <$> recv
532−
533−-- | Matches incoming responses with previously-sent requests
534−-- and uses the provided request "decoder" function to process
535−-- incoming responses.
536−matchResponseMapWithRequests
537− :: forall t rawRequest rawResponse request response m.
538− ( MonadFix m
539− , MonadHold t m
540− , Reflex t
541− )
542− => (forall a. request a -> (rawRequest, rawResponse -> response a))
543− -- ^ Given a request (from 'Requester'), produces the wire format of the
544− -- request and a function used to process the associated response
545− -> Event t (RequesterData request)
546− -- ^ The outgoing requests
547− -> Event t (Map Int rawResponse)
548− -- ^ A map of incoming responses, tagged by an identifying key
549− -> m ( Event t (Map Int rawRequest)
550− , Event t (RequesterData response)
551− )
552− -- ^ A map of outgoing wire-format requests and an event of responses keyed
553− -- by the 'RequesterData' key of the associated outgoing request
554−matchResponseMapWithRequests f send recv = do
555− rec nextId <- hold 1 $ fmap (\(next, _, _) -> next) outgoing
556− waitingFor :: Incremental t (PatchMap Int (Decoder rawResponse response)) <-
557− holdIncremental mempty $ leftmost
558− [ fmap (\(_, outstanding, _) -> outstanding) outgoing
559− , snd <$> incoming
560− ]
561− let outgoing = processOutgoing nextId send
562− incoming = processIncoming waitingFor recv
563− return (fmap (\(_, _, rawReqs) -> rawReqs) outgoing, fst <$> incoming)
564− where
565− -- Tags each outgoing request with an identifying integer key
566− -- and returns the next available key, a map of response decoders
567− -- for requests for which there are outstanding responses, and the
568− -- raw requests to be sent out.
569− processOutgoing
570− :: Behavior t Int
571− -- The next available key
572− -> Event t (RequesterData request)
573− -- The outgoing request
574− -> Event t ( Int
575− , PatchMap Int (Decoder rawResponse response)
576− , Map Int rawRequest )
577− -- The new next-available-key, a map of requests expecting responses, and the tagged raw requests
578− processOutgoing nextId out = flip pushAlways out $ \dm -> do
579− oldNextId <- sample nextId
580− let (result, newNextId) = flip runState oldNextId $ forM (requesterDataToList dm) $ \(k :=> v) -> do
581− n <- get
582− put $ succ n
583− let (rawReq, rspF) = f v
584− return (n, rawReq, Decoder k rspF)
585− patchWaitingFor = PatchMap $ Map.fromList $
586− (\(n, _, dec) -> (n, Just dec)) <$> result
587− toSend = Map.fromList $ (\(n, rawReq, _) -> (n, rawReq)) <$> result
588− return (newNextId, patchWaitingFor, toSend)
589− -- Looks up the each incoming raw response in a map of response
590− -- decoders and returns the decoded response and a patch that can
591− -- be used to clear the ID of the consumed response out of the queue
592− -- of expected responses.
593− processIncoming
594− :: Incremental t (PatchMap Int (Decoder rawResponse response))
595− -- A map of outstanding expected responses
596− -> Event t (Map Int rawResponse)
597− -- A incoming response paired with its identifying key
598− -> Event t (RequesterData response, PatchMap Int v)
599− -- The decoded response and a patch that clears the outstanding responses queue
600− processIncoming waitingFor inc = flip push inc $ \rspMap -> do
601− wf <- sample $ currentIncremental waitingFor
602− let match rawRsp (Decoder k rspF) =
603− let rsp = rspF rawRsp
604− in singletonRequesterData k rsp
605− matches = Map.intersectionWith match rspMap wf
606− pure $ if Map.null matches then Nothing else Just
607− (Map.foldl' mergeRequesterData emptyRequesterData matches, PatchMap $ Nothing <$ matches)
src/Reflex/Requester/Class.hs+1
@@ -6,6 +6,7 @@
6{-# LANGUAGE CPP #-}
6{-# LANGUAGE CPP #-}
7{-# LANGUAGE FlexibleInstances #-}
7{-# LANGUAGE FlexibleInstances #-}
8{-# LANGUAGE FunctionalDependencies #-}
8{-# LANGUAGE FunctionalDependencies #-}
9+{-# LANGUAGE MultiParamTypeClasses #-}
9{-# LANGUAGE RecursiveDo #-}
10{-# LANGUAGE RecursiveDo #-}
10{-# LANGUAGE TypeFamilies #-}
11{-# LANGUAGE TypeFamilies #-}
11{-# LANGUAGE UndecidableInstances #-}
12{-# LANGUAGE UndecidableInstances #-}
src/Reflex/Spider.hs+2−5
@@ -1,9 +1,6 @@
1{-# LANGUAGE CPP #-}
1{-# LANGUAGE CPP #-}
2−-- |
3−-- Module:
4−-- Reflex.Spider
5−-- Description:
6−-- This module exports all of the user-facing functionality of the 'Spider' 'Reflex' engine
2+-- | This module exports all of the user-facing functionality of the 'Spider'
3+-- 'Reflex' engine
7module Reflex.Spider
4module Reflex.Spider
8 ( Spider
5 ( Spider
9 , SpiderTimeline
6 , SpiderTimeline
src/Reflex/Spider/Internal.hs+451−743
@@ -9,22 +9,17 @@
9{-# LANGUAGE GADTs #-}
9{-# LANGUAGE GADTs #-}
10{-# LANGUAGE GeneralizedNewtypeDeriving #-}
10{-# LANGUAGE GeneralizedNewtypeDeriving #-}
11{-# LANGUAGE LambdaCase #-}
11{-# LANGUAGE LambdaCase #-}
12+{-# LANGUAGE MultiParamTypeClasses #-}
13+{-# LANGUAGE MultiWayIf #-}
12{-# LANGUAGE RankNTypes #-}
14{-# LANGUAGE RankNTypes #-}
13{-# LANGUAGE RoleAnnotations #-}
15{-# LANGUAGE RoleAnnotations #-}
14{-# LANGUAGE ScopedTypeVariables #-}
16{-# LANGUAGE ScopedTypeVariables #-}
15{-# LANGUAGE TypeFamilies #-}
17{-# LANGUAGE TypeFamilies #-}
16{-# LANGUAGE TypeOperators #-}
18{-# LANGUAGE TypeOperators #-}
17{-# LANGUAGE UndecidableInstances #-}
19{-# LANGUAGE UndecidableInstances #-}
18−{-# LANGUAGE PolyKinds #-}
19−{-# LANGUAGE DeriveFunctor #-}
20−{-# LANGUAGE StandaloneDeriving #-}
21−{-# LANGUAGE InstanceSigs #-}
22−{-# LANGUAGE MultiWayIf #-}
23−
24#ifdef USE_REFLEX_OPTIMIZER
20#ifdef USE_REFLEX_OPTIMIZER
25{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
21{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
26#endif
22#endif
27−{-# OPTIONS_GHC -Wunused-binds #-}
28-- | This module is the implementation of the 'Spider' 'Reflex' engine. It uses
23-- | This module is the implementation of the 'Spider' 'Reflex' engine. It uses
29-- a graph traversal algorithm to propagate 'Event's and 'Behavior's.
24-- a graph traversal algorithm to propagate 'Event's and 'Behavior's.
30module Reflex.Spider.Internal (module Reflex.Spider.Internal) where
25module Reflex.Spider.Internal (module Reflex.Spider.Internal) where
@@ -38,17 +33,12 @@ import Control.Monad hiding (forM, forM_, mapM, mapM_)
38import Control.Monad.Exception
33import Control.Monad.Exception
39import Control.Monad.Identity hiding (forM, forM_, mapM, mapM_)
34import Control.Monad.Identity hiding (forM, forM_, mapM, mapM_)
40import Control.Monad.Primitive
35import Control.Monad.Primitive
41−import Control.Monad.Reader.Class
36+import Control.Monad.Reader hiding (forM, forM_, mapM, mapM_)
42−import Control.Monad.IO.Class
43−import Control.Monad.ReaderIO
44import Control.Monad.Ref
37import Control.Monad.Ref
45−import Control.Monad.Fail (MonadFail)
46−import qualified Control.Monad.Fail as MonadFail
47import Data.Align
38import Data.Align
48import Data.Coerce
39import Data.Coerce
49−import Data.Dependent.Map (DMap)
40+import Data.Dependent.Map (DMap, DSum (..))
50import qualified Data.Dependent.Map as DMap
41import qualified Data.Dependent.Map as DMap
51−import Data.Dependent.Sum (DSum (..))
52import Data.FastMutableIntMap (FastMutableIntMap, PatchIntMap (..))
42import Data.FastMutableIntMap (FastMutableIntMap, PatchIntMap (..))
53import qualified Data.FastMutableIntMap as FastMutableIntMap
43import qualified Data.FastMutableIntMap as FastMutableIntMap
54import Data.Foldable hiding (concat, elem, sequence_)
44import Data.Foldable hiding (concat, elem, sequence_)
@@ -59,73 +49,54 @@ import Data.GADT.Compare
59import Data.IntMap.Strict (IntMap)
49import Data.IntMap.Strict (IntMap)
60import qualified Data.IntMap.Strict as IntMap
50import qualified Data.IntMap.Strict as IntMap
61import Data.IORef
51import Data.IORef
62−import Data.Kind (Type)
52+import Data.Maybe
63−import Data.Maybe hiding (mapMaybe)
64−import Data.Monoid (mempty, (<>))
53+import Data.Monoid ((<>))
65import Data.Proxy
54import Data.Proxy
66import Data.These
55import Data.These
67import Data.Traversable
56import Data.Traversable
68−import Data.Type.Equality ((:~:)(Refl))
57+import GHC.Exts
69−import Data.Witherable (Filterable, mapMaybe)
70−import GHC.Exts hiding (toList)
71import GHC.IORef (IORef (..))
58import GHC.IORef (IORef (..))
72import GHC.Stack
59import GHC.Stack
73import Reflex.FastWeak
60import Reflex.FastWeak
61+import Reflex.FunctorMaybe
74import System.IO.Unsafe
62import System.IO.Unsafe
75import System.Mem.Weak
63import System.Mem.Weak
76import Unsafe.Coerce
64import Unsafe.Coerce
77
65
78−#ifdef MIN_VERSION_semialign
79−#if MIN_VERSION_these(0,8,0)
80−import Data.These.Combinators (justThese)
81−#endif
82−#if MIN_VERSION_semialign(1,1,0)
83−import Data.Zip (Zip (..))
84−#endif
85−#endif
86−
87#ifdef DEBUG_CYCLES
66#ifdef DEBUG_CYCLES
88import Control.Monad.State hiding (forM, forM_, mapM, mapM_, sequence)
67import Control.Monad.State hiding (forM, forM_, mapM, mapM_, sequence)
89−#endif
90−
91import Data.List.NonEmpty (NonEmpty (..), nonEmpty)
68import Data.List.NonEmpty (NonEmpty (..), nonEmpty)
92import qualified Data.List.NonEmpty as NonEmpty
69import qualified Data.List.NonEmpty as NonEmpty
70+import Data.Monoid (mempty)
93import Data.Tree (Forest, Tree (..), drawForest)
71import Data.Tree (Forest, Tree (..), drawForest)
94−import Data.List (isPrefixOf)
72+#endif
95
73
96−import Data.FastWeakBag (FastWeakBag, FastWeakBagTicket)
74+import Data.FastWeakBag (FastWeakBag)
97import qualified Data.FastWeakBag as FastWeakBag
75import qualified Data.FastWeakBag as FastWeakBag
98−
99import Data.Reflection
76import Data.Reflection
100−import Data.Some (Some(Some))
77+import Data.Some (Some)
78+import qualified Data.Some as Some
101import Data.Type.Coercion
79import Data.Type.Coercion
102−import Data.Profunctor.Unsafe ((#.), (.#))
103import Data.WeakBag (WeakBag, WeakBagTicket, _weakBag_children)
80import Data.WeakBag (WeakBag, WeakBagTicket, _weakBag_children)
104import qualified Data.WeakBag as WeakBag
81import qualified Data.WeakBag as WeakBag
105import qualified Reflex.Class
82import qualified Reflex.Class
106import qualified Reflex.Class as R
83import qualified Reflex.Class as R
107import qualified Reflex.Host.Class
84import qualified Reflex.Host.Class
108import Reflex.NotReady.Class
85import Reflex.NotReady.Class
109−import Data.Patch
86+import Reflex.Patch
110−import qualified Data.Patch.DMapWithMove as PatchDMapWithMove
87+import qualified Reflex.Patch.DMapWithMove as PatchDMapWithMove
111−import Reflex.PerformEvent.Base (PerformEventT)
112
88
113#ifdef DEBUG_TRACE_EVENTS
89#ifdef DEBUG_TRACE_EVENTS
114import qualified Data.ByteString.Char8 as BS8
90import qualified Data.ByteString.Char8 as BS8
115import System.IO (stderr)
91import System.IO (stderr)
116−import Data.List (isPrefixOf)
117#endif
92#endif
118
93
119−-- TODO stdout might not be the best channel for debug output
120−debugStrLn :: String -> IO ()
121−debugStrLn = putStrLn
122−
123#ifdef DEBUG_TRACE_EVENTS
94#ifdef DEBUG_TRACE_EVENTS
95+
124withStackOneLine :: (BS8.ByteString -> a) -> a
96withStackOneLine :: (BS8.ByteString -> a) -> a
125withStackOneLine expr = unsafePerformIO $ do
97withStackOneLine expr = unsafePerformIO $ do
126 stack <- currentCallStack
98 stack <- currentCallStack
127− return (expr . BS8.pack . unwords . dropInternal . reverse $ stack)
99+ return (expr (BS8.pack (unwords (reverse stack))))
128− where dropInternal = filterStack "Reflex.Spider.Internal"
129
100
130#endif
101#endif
131
102
@@ -136,42 +107,28 @@ debugInvalidateHeight :: Bool
136debugInvalidate :: Bool
107debugInvalidate :: Bool
137
108
138#ifdef DEBUG
109#ifdef DEBUG
110+
139#define DEBUG_NODEIDS
111#define DEBUG_NODEIDS
140
112
141−#ifdef DEBUG_TRACE_PROPAGATION
142debugPropagate = True
113debugPropagate = True
143−#else
144−debugPropagate = False
145−#endif
146
114
147−#ifdef DEBUG_TRACE_HEIGHT
148−debugInvalidateHeight = True
149−#else
150debugInvalidateHeight = False
115debugInvalidateHeight = False
151−#endif
152
116
153−#ifdef DEBUG_TRACE_INVALIDATION
154debugInvalidate = True
117debugInvalidate = True
155−#else
156−debugInvalidate = False
157−#endif
158
118
159class HasNodeId a where
119class HasNodeId a where
160 getNodeId :: a -> Int
120 getNodeId :: a -> Int
161
121
162−instance HasNodeId (CacheSubscribed x a) where
122+instance HasNodeId (Hold x p a) where
163− getNodeId = _cacheSubscribed_nodeId
164−
165−instance HasNodeId (FanInt x a) where
166− getNodeId = _fanInt_nodeId
167−
168−instance HasNodeId (Hold x p) where
169 getNodeId = holdNodeId
123 getNodeId = holdNodeId
170
124
125+instance HasNodeId (PushSubscribed x a b) where
126+ getNodeId = pushSubscribedNodeId
127+
171instance HasNodeId (SwitchSubscribed x a) where
128instance HasNodeId (SwitchSubscribed x a) where
172 getNodeId = switchSubscribedNodeId
129 getNodeId = switchSubscribedNodeId
173
130
174−instance HasNodeId (FanSubscribed x v a) where
131+instance HasNodeId (FanSubscribed x a) where
175 getNodeId = fanSubscribedNodeId
132 getNodeId = fanSubscribedNodeId
176
133
177instance HasNodeId (CoincidenceSubscribed x a) where
134instance HasNodeId (CoincidenceSubscribed x a) where
@@ -185,16 +142,41 @@ instance HasNodeId (Pull x a) where
185
142
186{-# INLINE showNodeId #-}
143{-# INLINE showNodeId #-}
187showNodeId :: HasNodeId a => a -> String
144showNodeId :: HasNodeId a => a -> String
188−showNodeId = showNodeId' . getNodeId
145+showNodeId = ("#"<>) . show . getNodeId
189−
146+
190−showNodeId' :: Int -> String
147+showSubscriberType :: Subscriber x a -> String
191−showNodeId' = ("#"<>) . show
148+showSubscriberType = \case
192−
149+ SubscriberPush _ _ -> "SubscriberPush"
150+ SubscriberMerge _ _ -> "SubscriberMerge"
151+ SubscriberFan _ -> "SubscriberFan"
152+ SubscriberMergeChange _ -> "SubscriberMergeChange"
153+ SubscriberHold _ -> "SubscriberHold"
154+ SubscriberHoldIdentity _ -> "SubscriberHoldIdentity"
155+ SubscriberSwitch _ -> "SubscriberSwitch"
156+ SubscriberCoincidenceOuter _ -> "SubscriberCoincidenceOuter"
157+ SubscriberCoincidenceInner _ -> "SubscriberCoincidenceInner"
158+ SubscriberHandle -> "SubscriberHandle"
159+
160+showEventType :: Event x a -> String
161+showEventType = \case
162+ EventRoot _ _ -> "EventRoot"
163+ EventNever -> "EventNever"
164+ EventPush _ -> "EventPush"
165+ EventMerge _ -> "EventMerge"
166+ EventFan _ _ -> "EventFan"
167+ EventSwitch _ -> "EventSwitch"
168+ EventCoincidence _ -> "EventCoincidence"
169+ EventHold _ -> "EventHold"
170+ EventDyn _ -> "EventDyn"
171+ EventHoldIdentity _ -> "EventHoldIdentity"
172+ EventDynIdentity _ -> "EventDynIdentity"
193
173
194#else
174#else
195
175
196debugPropagate = False
176debugPropagate = False
177+
197debugInvalidateHeight = False
178debugInvalidateHeight = False
179+
198debugInvalidate = False
180debugInvalidate = False
199
181
200-- This must be inline, or error messages will cause memory leaks due to retaining the node in question
182-- This must be inline, or error messages will cause memory leaks due to retaining the node in question
@@ -202,10 +184,6 @@ debugInvalidate = False
202showNodeId :: a -> String
184showNodeId :: a -> String
203showNodeId _ = ""
185showNodeId _ = ""
204
186
205−{-# INLINE showNodeId' #-}
206−showNodeId' :: Int -> String
207−showNodeId' _ = ""
208−
209#endif
187#endif
210
188
211#ifdef DEBUG_NODEIDS
189#ifdef DEBUG_NODEIDS
@@ -215,6 +193,12 @@ nextNodeIdRef = unsafePerformIO $ newIORef 1
215
193
216newNodeId :: IO Int
194newNodeId :: IO Int
217newNodeId = atomicModifyIORef' nextNodeIdRef $ \n -> (succ n, n)
195newNodeId = atomicModifyIORef' nextNodeIdRef $ \n -> (succ n, n)
196+
197+{-# NOINLINE unsafeNodeId #-}
198+unsafeNodeId :: a -> Int
199+unsafeNodeId a = unsafePerformIO $ do
200+ touch a
201+ newNodeId
218#endif
202#endif
219
203
220--------------------------------------------------------------------------------
204--------------------------------------------------------------------------------
@@ -251,9 +235,9 @@ subscribeAndRead = unEvent
251-- caching; if the computation function is very cheap, this is (much) more
235-- caching; if the computation function is very cheap, this is (much) more
252-- efficient than 'push'
236-- efficient than 'push'
253{-# INLINE [1] pushCheap #-}
237{-# INLINE [1] pushCheap #-}
254−pushCheap :: HasSpiderTimeline x => (a -> ComputeM x (Maybe b)) -> Event x a -> Event x b
238+pushCheap :: (a -> ComputeM x (Maybe b)) -> Event x a -> Event x b
255pushCheap !f e = Event $ \sub -> do
239pushCheap !f e = Event $ \sub -> do
256− (subscription, occ) <- subscribeAndRead e $ debugSubscriber' "push" $ sub
240+ (subscription, occ) <- subscribeAndRead e $ sub
257 { subscriberPropagate = \a -> do
241 { subscriberPropagate = \a -> do
258 mb <- f a
242 mb <- f a
259 mapM_ (subscriberPropagate sub) mb
243 mapM_ (subscriberPropagate sub) mb
@@ -272,10 +256,10 @@ terminalSubscriber p = Subscriber
272
256
273-- | Subscribe to an Event only for the duration of one occurrence
257-- | Subscribe to an Event only for the duration of one occurrence
274{-# INLINE subscribeAndReadHead #-}
258{-# INLINE subscribeAndReadHead #-}
275−subscribeAndReadHead :: HasSpiderTimeline x => Event x a -> Subscriber x a -> EventM x (EventSubscription x, Maybe a)
259+subscribeAndReadHead :: Event x a -> Subscriber x a -> EventM x (EventSubscription x, Maybe a)
276subscribeAndReadHead e sub = do
260subscribeAndReadHead e sub = do
277 subscriptionRef <- liftIO $ newIORef $ error "subscribeAndReadHead: not initialized"
261 subscriptionRef <- liftIO $ newIORef $ error "subscribeAndReadHead: not initialized"
278− (subscription, occ) <- subscribeAndRead e $ debugSubscriber' "head" $ sub
262+ (subscription, occ) <- subscribeAndRead e $ sub
279 { subscriberPropagate = \a -> do
263 { subscriberPropagate = \a -> do
280 liftIO $ unsubscribe =<< readIORef subscriptionRef
264 liftIO $ unsubscribe =<< readIORef subscriptionRef
281 subscriberPropagate sub a
265 subscriberPropagate sub a
@@ -286,42 +270,24 @@ subscribeAndReadHead e sub = do
286 return (subscription, occ)
270 return (subscription, occ)
287
271
288--TODO: Make this lazy in its input event
272--TODO: Make this lazy in its input event
289−headE :: (MonadIO m, Defer (SomeMergeInit x) m, HasSpiderTimeline x) => Event x a -> m (Event x a)
273+headE :: (MonadIO m, Defer (SomeMergeInit x) m) => Event x a -> m (Event x a)
290headE originalE = do
274headE originalE = do
291 parent <- liftIO $ newIORef $ Just originalE
275 parent <- liftIO $ newIORef $ Just originalE
292 defer $ SomeMergeInit $ do --TODO: Rename SomeMergeInit appropriately
276 defer $ SomeMergeInit $ do --TODO: Rename SomeMergeInit appropriately
293 let clearParent = liftIO $ writeIORef parent Nothing
277 let clearParent = liftIO $ writeIORef parent Nothing
294− (_, occ) <- subscribeAndReadHead originalE $ terminalSubscriber $ const clearParent
278+ (_, occ) <- subscribeAndReadHead originalE $ terminalSubscriber $ \_ -> clearParent
295 when (isJust occ) clearParent
279 when (isJust occ) clearParent
296− return $ Event $ \sub ->
280+ return $ Event $ \sub -> do
297 liftIO (readIORef parent) >>= \case
281 liftIO (readIORef parent) >>= \case
298− Nothing -> subscribeAndReadNever
282+ Nothing -> return (EventSubscription (return ()) $ EventSubscribed zeroRef $ toAny (), Nothing)
299 Just e -> subscribeAndReadHead e sub
283 Just e -> subscribeAndReadHead e sub
300
284
301data CacheSubscribed x a
285data CacheSubscribed x a
302 = CacheSubscribed { _cacheSubscribed_subscribers :: {-# UNPACK #-} !(FastWeakBag (Subscriber x a))
286 = CacheSubscribed { _cacheSubscribed_subscribers :: {-# UNPACK #-} !(FastWeakBag (Subscriber x a))
303 , _cacheSubscribed_parent :: {-# UNPACK #-} !(EventSubscription x)
287 , _cacheSubscribed_parent :: {-# UNPACK #-} !(EventSubscription x)
304 , _cacheSubscribed_occurrence :: {-# UNPACK #-} !(IORef (Maybe a))
288 , _cacheSubscribed_occurrence :: {-# UNPACK #-} !(IORef (Maybe a))
305−#ifdef DEBUG_NODEIDS
306− , _cacheSubscribed_nodeId :: {-# UNPACK #-} !Int
307−#endif
308 }
289 }
309
290
310−nowSpiderEventM :: (HasSpiderTimeline x) => EventM x (R.Event (SpiderTimeline x) ())
311−nowSpiderEventM =
312− SpiderEvent <$> now
313−
314−now :: (MonadIO m, Defer (Some Clear) m, HasSpiderTimeline x
315− ) => m (Event x ())
316−now = do
317− nowOrNot <- liftIO $ newIORef $ Just ()
318− scheduleClear nowOrNot
319− return . Event $ \_ -> do
320− occ <- liftIO . readIORef $ nowOrNot
321− return ( EventSubscription (return ()) eventSubscribedNow
322− , occ
323− )
324−
325-- | Construct an 'Event' whose value is guaranteed not to be recomputed
291-- | Construct an 'Event' whose value is guaranteed not to be recomputed
326-- repeatedly
292-- repeatedly
327--
293--
@@ -336,33 +302,27 @@ cacheEvent e =
336#else
302#else
337 Event $
303 Event $
338#endif
304#endif
339− unsafePerformIO $ do
340− mSubscribedRef :: IORef (FastWeak (CacheSubscribed x a))
305+ let mSubscribedRef :: IORef (FastWeak (CacheSubscribed x a))
341− <- newIORef emptyFastWeak
306+ !mSubscribedRef = unsafeNewIORef e emptyFastWeak
342− pure $ \sub -> {-# SCC "cacheEvent" #-} do
307+ in \sub -> {-# SCC "cacheEvent" #-} do
343#ifdef DEBUG_TRACE_EVENTS
308#ifdef DEBUG_TRACE_EVENTS
344 unless (BS8.null callSite) $ liftIO $ BS8.hPutStrLn stderr callSite
309 unless (BS8.null callSite) $ liftIO $ BS8.hPutStrLn stderr callSite
345#endif
310#endif
346 subscribedTicket <- liftIO (readIORef mSubscribedRef >>= getFastWeakTicket) >>= \case
311 subscribedTicket <- liftIO (readIORef mSubscribedRef >>= getFastWeakTicket) >>= \case
347 Just subscribedTicket -> return subscribedTicket
312 Just subscribedTicket -> return subscribedTicket
348 Nothing -> do
313 Nothing -> do
349−#ifdef DEBUG_NODEIDS
350− nodeId <- liftIO newNodeId
351−#endif
352 subscribers <- liftIO FastWeakBag.empty
314 subscribers <- liftIO FastWeakBag.empty
353 occRef <- liftIO $ newIORef Nothing -- This should never be read prior to being set below
315 occRef <- liftIO $ newIORef Nothing -- This should never be read prior to being set below
354−#ifdef DEBUG_NODEIDS
355− (parentSub, occ) <- subscribeAndRead e $ debugSubscriber' ("cacheEvent" <> showNodeId' nodeId) $ Subscriber
356−#else
357 (parentSub, occ) <- subscribeAndRead e $ Subscriber
316 (parentSub, occ) <- subscribeAndRead e $ Subscriber
358−#endif
359− { subscriberPropagate = \a -> do
317+ { subscriberPropagate = \a -> do
360− liftIO $ writeIORef occRef (Just a)
318+ liftIO $ writeIORef occRef $ Just a
361− scheduleClear occRef
319+ scheduleClear occRef
362− propagateFast a subscribers
320+ propagateFast a subscribers
321+ , subscriberInvalidateHeight = \old -> do
363− , subscriberInvalidateHeight = FastWeakBag.traverse_ subscribers . invalidateSubscriberHeight
322+ FastWeakBag.traverse subscribers $ invalidateSubscriberHeight old
323+ , subscriberRecalculateHeight = \new -> do
364− , subscriberRecalculateHeight = FastWeakBag.traverse_ subscribers . recalculateSubscriberHeight
324+ FastWeakBag.traverse subscribers $ recalculateSubscriberHeight new
365− }
325+ }
366 when (isJust occ) $ do
326 when (isJust occ) $ do
367 liftIO $ writeIORef occRef occ -- Set the initial value of occRef; we don't need to do this if occ is Nothing
327 liftIO $ writeIORef occRef occ -- Set the initial value of occRef; we don't need to do this if occ is Nothing
368 scheduleClear occRef
328 scheduleClear occRef
@@ -370,45 +330,29 @@ cacheEvent e =
370 { _cacheSubscribed_subscribers = subscribers
330 { _cacheSubscribed_subscribers = subscribers
371 , _cacheSubscribed_parent = parentSub
331 , _cacheSubscribed_parent = parentSub
372 , _cacheSubscribed_occurrence = occRef
332 , _cacheSubscribed_occurrence = occRef
373−#ifdef DEBUG_NODEIDS
374− , _cacheSubscribed_nodeId = nodeId
375−#endif
376 }
333 }
377 subscribedTicket <- liftIO $ mkFastWeakTicket subscribed
334 subscribedTicket <- liftIO $ mkFastWeakTicket subscribed
378 liftIO $ writeIORef mSubscribedRef =<< getFastWeakTicketWeak subscribedTicket
335 liftIO $ writeIORef mSubscribedRef =<< getFastWeakTicketWeak subscribedTicket
379 return subscribedTicket
336 return subscribedTicket
380− liftIO $ cacheSubscription sub mSubscribedRef subscribedTicket
337+ liftIO $ do
381−
382−cacheSubscription :: Subscriber x a -> IORef (FastWeak (CacheSubscribed x a))
383− -> FastWeakTicket (CacheSubscribed x a) -> IO (EventSubscription x, Maybe a)
384−cacheSubscription sub mSubscribedRef subscribedTicket = do
385− subscribed <- getFastWeakTicketValue subscribedTicket
338+ subscribed <- getFastWeakTicketValue subscribedTicket
386− ticket <- FastWeakBag.insert sub $ _cacheSubscribed_subscribers subscribed
339+ ticket <- FastWeakBag.insert sub $ _cacheSubscribed_subscribers subscribed
387− occ <- readIORef $ _cacheSubscribed_occurrence subscribed
340+ occ <- readIORef $ _cacheSubscribed_occurrence subscribed
388−
389− let parentSub = _cacheSubscribed_parent subscribed
390− es = EventSubscription
341+ let es = EventSubscription
391− { _eventSubscription_unsubscribe = do
342+ { _eventSubscription_unsubscribe = do
392− FastWeakBag.remove ticket
343+ FastWeakBag.remove ticket
393−
394− isEmpty <- FastWeakBag.isEmpty $ _cacheSubscribed_subscribers subscribed
344+ isEmpty <- FastWeakBag.isEmpty $ _cacheSubscribed_subscribers subscribed
395− when isEmpty $ do
345+ when isEmpty $ do
396− writeIORef mSubscribedRef emptyFastWeak
346+ writeIORef mSubscribedRef emptyFastWeak
397− unsubscribe parentSub
347+ unsubscribe $ _cacheSubscribed_parent subscribed
398− touch ticket
348+ touch ticket
399− touch subscribedTicket
349+ touch subscribedTicket
400− , _eventSubscription_subscribed = EventSubscribed
350+ , _eventSubscription_subscribed = EventSubscribed
401− { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed parentSub
351+ { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed $ _cacheSubscribed_parent subscribed
402− , eventSubscribedRetained = toAny subscribedTicket
352+ , eventSubscribedRetained = toAny subscribedTicket
403−#ifdef DEBUG_CYCLES
404− , eventSubscribedGetParents = return [_eventSubscription_subscribed parentSub]
405− , eventSubscribedHasOwnHeightRef = False
406− , eventSubscribedWhoCreated = whoCreatedIORef mSubscribedRef
407−#endif
408− }
353+ }
409− }
354+ }
410− return (es, occ)
355+ return (es, occ)
411−
412
356
413subscribe :: Event x a -> Subscriber x a -> EventM x (EventSubscription x)
357subscribe :: Event x a -> Subscriber x a -> EventM x (EventSubscription x)
414subscribe e s = fst <$> subscribeAndRead e s
358subscribe e s = fst <$> subscribeAndRead e s
@@ -420,16 +364,13 @@ wrap tag getSpecificSubscribed sub = do
420 let es = tag subd
364 let es = tag subd
421 return (EventSubscription (WeakBag.remove sln >> touch sln) es, occ)
365 return (EventSubscription (WeakBag.remove sln >> touch sln) es, occ)
422
366
423−eventRoot :: (GCompare k, HasSpiderTimeline x) => k a -> Root x k -> Event x a
367+eventRoot :: GCompare k => k a -> Root x k -> Event x a
424eventRoot !k !r = Event $ wrap eventSubscribedRoot $ liftIO . getRootSubscribed k r
368eventRoot !k !r = Event $ wrap eventSubscribedRoot $ liftIO . getRootSubscribed k r
425
369
426−subscribeAndReadNever :: EventM x (EventSubscription x, Maybe a)
427−subscribeAndReadNever = return (EventSubscription (return ()) eventSubscribedNever, Nothing)
428−
429eventNever :: Event x a
370eventNever :: Event x a
430−eventNever = Event $ const subscribeAndReadNever
371+eventNever = Event $ \_ -> return (EventSubscription (return ()) eventSubscribedNever, Nothing)
431
372
432−eventFan :: (GCompare k, HasSpiderTimeline x) => k a -> Fan x k v -> Event x (v a)
373+eventFan :: (GCompare k, HasSpiderTimeline x) => k a -> Fan x k -> Event x a
433eventFan !k !f = Event $ wrap eventSubscribedFan $ getFanSubscribed k f
374eventFan !k !f = Event $ wrap eventSubscribedFan $ getFanSubscribed k f
434
375
435eventSwitch :: HasSpiderTimeline x => Switch x a -> Event x a
376eventSwitch :: HasSpiderTimeline x => Switch x a -> Event x a
@@ -464,6 +405,16 @@ data Subscriber x a = Subscriber
464 , subscriberRecalculateHeight :: !(Height -> IO ())
405 , subscriberRecalculateHeight :: !(Height -> IO ())
465 }
406 }
466
407
408+--TODO: Move this comment to WeakBag
409+-- These function are constructor functions that are marked NOINLINE so they are
410+-- opaque to GHC. If we do not do this, then GHC will sometimes fuse the constructor away
411+-- so any weak references that are attached to the constructors will have their
412+-- finalizer run. Using the opaque constructor, does not see the
413+-- constructor application, so it behaves like an IORef and cannot be fused away.
414+--
415+-- The result is also evaluated to WHNF, since forcing a thunk invalidates
416+-- the weak pointer to it in some cases.
417+
467newSubscriberHold :: (HasSpiderTimeline x, Patch p) => Hold x p -> IO (Subscriber x p)
418newSubscriberHold :: (HasSpiderTimeline x, Patch p) => Hold x p -> IO (Subscriber x p)
468newSubscriberHold h = return $ Subscriber
419newSubscriberHold h = return $ Subscriber
469 { subscriberPropagate = {-# SCC "traverseHold" #-} propagateSubscriberHold h
420 { subscriberPropagate = {-# SCC "traverseHold" #-} propagateSubscriberHold h
@@ -471,68 +422,85 @@ newSubscriberHold h = return $ Subscriber
471 , subscriberRecalculateHeight = \_ -> return ()
422 , subscriberRecalculateHeight = \_ -> return ()
472 }
423 }
473
424
474−newSubscriberFan :: forall x k v. (HasSpiderTimeline x, GCompare k) => FanSubscribed x k v -> IO (Subscriber x (DMap k v))
425+newSubscriberFan :: forall x k. (HasSpiderTimeline x, GCompare k) => FanSubscribed x k -> IO (Subscriber x (DMap k Identity))
475−newSubscriberFan subscribed = debugSubscriber ("SubscriberFan " <> showNodeId subscribed) $ Subscriber
426+newSubscriberFan subscribed = return $ Subscriber
476 { subscriberPropagate = \a -> {-# SCC "traverseFan" #-} do
427 { subscriberPropagate = \a -> {-# SCC "traverseFan" #-} do
477 subs <- liftIO $ readIORef $ fanSubscribedSubscribers subscribed
428 subs <- liftIO $ readIORef $ fanSubscribedSubscribers subscribed
478− tracePropagate (Proxy :: Proxy x) $ show (DMap.size subs) <> " keys subscribed, " <> show (DMap.size a) <> " keys firing"
429+ tracePropagate (Proxy :: Proxy x) $ "SubscriberFan" <> showNodeId subscribed <> ": " ++ show (DMap.size subs) ++ " keys subscribed, " ++ show (DMap.size a) ++ " keys firing"
479 liftIO $ writeIORef (fanSubscribedOccurrence subscribed) $ Just a
430 liftIO $ writeIORef (fanSubscribedOccurrence subscribed) $ Just a
480 scheduleClear $ fanSubscribedOccurrence subscribed
431 scheduleClear $ fanSubscribedOccurrence subscribed
481− let f _ (Pair v subsubs) = do
432+ let f _ (Pair (Identity v) subsubs) = do
482 propagate v $ _fanSubscribedChildren_list subsubs
433 propagate v $ _fanSubscribedChildren_list subsubs
483 return $ Constant ()
434 return $ Constant ()
484 _ <- DMap.traverseWithKey f $ DMap.intersectionWithKey (\_ -> Pair) a subs --TODO: Would be nice to have DMap.traverse_
435 _ <- DMap.traverseWithKey f $ DMap.intersectionWithKey (\_ -> Pair) a subs --TODO: Would be nice to have DMap.traverse_
485 return ()
436 return ()
486 , subscriberInvalidateHeight = \old -> do
437 , subscriberInvalidateHeight = \old -> do
438+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberFan" <> showNodeId subscribed
487 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
439 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
488− forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse_ (_fanSubscribedChildren_list v) $ invalidateSubscriberHeight old
440+ forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse (_fanSubscribedChildren_list v) $ invalidateSubscriberHeight old
441+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberFan" <> showNodeId subscribed <> " done"
489 , subscriberRecalculateHeight = \new -> do
442 , subscriberRecalculateHeight = \new -> do
443+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberFan" <> showNodeId subscribed
490 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
444 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
491− forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse_ (_fanSubscribedChildren_list v) $ recalculateSubscriberHeight new
445+ forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse (_fanSubscribedChildren_list v) $ recalculateSubscriberHeight new
446+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberFan" <> showNodeId subscribed <> " done"
492 }
447 }
493
448
494newSubscriberSwitch :: forall x a. HasSpiderTimeline x => SwitchSubscribed x a -> IO (Subscriber x a)
449newSubscriberSwitch :: forall x a. HasSpiderTimeline x => SwitchSubscribed x a -> IO (Subscriber x a)
495−newSubscriberSwitch subscribed = debugSubscriber ("SubscriberCoincidenceOuter" <> showNodeId subscribed) $ Subscriber
450+newSubscriberSwitch subscribed = return $ Subscriber
496 { subscriberPropagate = \a -> {-# SCC "traverseSwitch" #-} do
451 { subscriberPropagate = \a -> {-# SCC "traverseSwitch" #-} do
452+ tracePropagate (Proxy :: Proxy x) $ "SubscriberSwitch" <> showNodeId subscribed
497 liftIO $ writeIORef (switchSubscribedOccurrence subscribed) $ Just a
453 liftIO $ writeIORef (switchSubscribedOccurrence subscribed) $ Just a
498 scheduleClear $ switchSubscribedOccurrence subscribed
454 scheduleClear $ switchSubscribedOccurrence subscribed
499 propagate a $ switchSubscribedSubscribers subscribed
455 propagate a $ switchSubscribedSubscribers subscribed
500 , subscriberInvalidateHeight = \_ -> do
456 , subscriberInvalidateHeight = \_ -> do
457+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed
501 oldHeight <- readIORef $ switchSubscribedHeight subscribed
458 oldHeight <- readIORef $ switchSubscribedHeight subscribed
502 when (oldHeight /= invalidHeight) $ do
459 when (oldHeight /= invalidHeight) $ do
503 writeIORef (switchSubscribedHeight subscribed) $! invalidHeight
460 writeIORef (switchSubscribedHeight subscribed) $! invalidHeight
504− WeakBag.traverse_ (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
461+ WeakBag.traverse (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
462+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed <> " done"
463+ , subscriberRecalculateHeight = \new -> do
464+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed
505− , subscriberRecalculateHeight = (`updateSwitchHeight` subscribed)
465+ updateSwitchHeight new subscribed
466+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed <> " done"
506− }
467+ }
507
468
508newSubscriberCoincidenceOuter :: forall x b. HasSpiderTimeline x => CoincidenceSubscribed x b -> IO (Subscriber x (Event x b))
469newSubscriberCoincidenceOuter :: forall x b. HasSpiderTimeline x => CoincidenceSubscribed x b -> IO (Subscriber x (Event x b))
509−newSubscriberCoincidenceOuter subscribed = debugSubscriber ("SubscriberCoincidenceOuter" <> showNodeId subscribed) $ Subscriber
470+newSubscriberCoincidenceOuter subscribed = return $ Subscriber
510 { subscriberPropagate = \a -> {-# SCC "traverseCoincidenceOuter" #-} do
471 { subscriberPropagate = \a -> {-# SCC "traverseCoincidenceOuter" #-} do
472+ tracePropagate (Proxy :: Proxy x) $ "SubscriberCoincidenceOuter" <> showNodeId subscribed
511 outerHeight <- liftIO $ readIORef $ coincidenceSubscribedHeight subscribed
473 outerHeight <- liftIO $ readIORef $ coincidenceSubscribedHeight subscribed
512 tracePropagate (Proxy :: Proxy x) $ " outerHeight = " <> show outerHeight
474 tracePropagate (Proxy :: Proxy x) $ " outerHeight = " <> show outerHeight
513 (occ, innerHeight, innerSubd) <- subscribeCoincidenceInner a outerHeight subscribed
475 (occ, innerHeight, innerSubd) <- subscribeCoincidenceInner a outerHeight subscribed
514 tracePropagate (Proxy :: Proxy x) $ " isJust occ = " <> show (isJust occ)
476 tracePropagate (Proxy :: Proxy x) $ " isJust occ = " <> show (isJust occ)
515 tracePropagate (Proxy :: Proxy x) $ " innerHeight = " <> show innerHeight
477 tracePropagate (Proxy :: Proxy x) $ " innerHeight = " <> show innerHeight
516−
517 liftIO $ writeIORef (coincidenceSubscribedInnerParent subscribed) $ Just innerSubd
478 liftIO $ writeIORef (coincidenceSubscribedInnerParent subscribed) $ Just innerSubd
518 scheduleClear $ coincidenceSubscribedInnerParent subscribed
479 scheduleClear $ coincidenceSubscribedInnerParent subscribed
519 case occ of
480 case occ of
520− Nothing ->
481+ Nothing -> do
521 when (innerHeight > outerHeight) $ liftIO $ do -- If the event fires, it will fire at a later height
482 when (innerHeight > outerHeight) $ liftIO $ do -- If the event fires, it will fire at a later height
522 writeIORef (coincidenceSubscribedHeight subscribed) $! innerHeight
483 writeIORef (coincidenceSubscribedHeight subscribed) $! innerHeight
523− WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight outerHeight
484+ WeakBag.traverse (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight outerHeight
524− WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ recalculateSubscriberHeight innerHeight
485+ WeakBag.traverse (coincidenceSubscribedSubscribers subscribed) $ recalculateSubscriberHeight innerHeight
525 Just o -> do -- Since it's already firing, no need to adjust height
486 Just o -> do -- Since it's already firing, no need to adjust height
526 liftIO $ writeIORef (coincidenceSubscribedOccurrence subscribed) occ
487 liftIO $ writeIORef (coincidenceSubscribedOccurrence subscribed) occ
527 scheduleClear $ coincidenceSubscribedOccurrence subscribed
488 scheduleClear $ coincidenceSubscribedOccurrence subscribed
528 propagate o $ coincidenceSubscribedSubscribers subscribed
489 propagate o $ coincidenceSubscribedSubscribers subscribed
490+ , subscriberInvalidateHeight = \_ -> do
491+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed
529− , subscriberInvalidateHeight = \_ -> invalidateCoincidenceHeight subscribed
492+ invalidateCoincidenceHeight subscribed
493+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed <> " done"
494+ , subscriberRecalculateHeight = \_ -> do
495+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed
530− , subscriberRecalculateHeight = \_ -> recalculateCoincidenceHeight subscribed
496+ recalculateCoincidenceHeight subscribed
497+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed <> " done"
531 }
498 }
532
499
533newSubscriberCoincidenceInner :: forall x a. HasSpiderTimeline x => CoincidenceSubscribed x a -> IO (Subscriber x a)
500newSubscriberCoincidenceInner :: forall x a. HasSpiderTimeline x => CoincidenceSubscribed x a -> IO (Subscriber x a)
534−newSubscriberCoincidenceInner subscribed = debugSubscriber ("SubscriberCoincidenceInner" <> showNodeId subscribed) $ Subscriber
501+newSubscriberCoincidenceInner subscribed = return $ Subscriber
535 { subscriberPropagate = \a -> {-# SCC "traverseCoincidenceInner" #-} do
502 { subscriberPropagate = \a -> {-# SCC "traverseCoincidenceInner" #-} do
503+ tracePropagate (Proxy :: Proxy x) $ "SubscriberCoincidenceInner" <> showNodeId subscribed
536 occ <- liftIO $ readIORef $ coincidenceSubscribedOccurrence subscribed
504 occ <- liftIO $ readIORef $ coincidenceSubscribedOccurrence subscribed
537 case occ of
505 case occ of
538 Just _ -> return () -- SubscriberCoincidenceOuter must have already propagated this event
506 Just _ -> return () -- SubscriberCoincidenceOuter must have already propagated this event
@@ -540,8 +508,14 @@ newSubscriberCoincidenceInner subscribed = debugSubscriber ("SubscriberCoinciden
540 liftIO $ writeIORef (coincidenceSubscribedOccurrence subscribed) $ Just a
508 liftIO $ writeIORef (coincidenceSubscribedOccurrence subscribed) $ Just a
541 scheduleClear $ coincidenceSubscribedOccurrence subscribed
509 scheduleClear $ coincidenceSubscribedOccurrence subscribed
542 propagate a $ coincidenceSubscribedSubscribers subscribed
510 propagate a $ coincidenceSubscribedSubscribers subscribed
511+ , subscriberInvalidateHeight = \_ -> do
512+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed
543− , subscriberInvalidateHeight = \_ -> invalidateCoincidenceHeight subscribed
513+ invalidateCoincidenceHeight subscribed
514+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed <> " done"
515+ , subscriberRecalculateHeight = \_ -> do
516+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed
544− , subscriberRecalculateHeight = \_ -> recalculateCoincidenceHeight subscribed
517+ recalculateCoincidenceHeight subscribed
518+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed <> " done"
545 }
519 }
546
520
547invalidateSubscriberHeight :: Height -> Subscriber x a -> IO ()
521invalidateSubscriberHeight :: Height -> Subscriber x a -> IO ()
@@ -551,18 +525,18 @@ recalculateSubscriberHeight :: Height -> Subscriber x a -> IO ()
551recalculateSubscriberHeight = flip subscriberRecalculateHeight
525recalculateSubscriberHeight = flip subscriberRecalculateHeight
552
526
553-- | Propagate everything at the current height
527-- | Propagate everything at the current height
554−propagate :: forall x a. HasSpiderTimeline x => a -> WeakBag (Subscriber x a) -> EventM x ()
528+propagate :: a -> WeakBag (Subscriber x a) -> EventM x ()
555−propagate a subscribers = withIncreasedDepth (Proxy::Proxy x) $
529+propagate a subscribers = withIncreasedDepth $ do
556 -- Note: in the following traversal, we do not visit nodes that are added to the list during our traversal; they are new events, which will necessarily have full information already, so there is no need to traverse them
530 -- Note: in the following traversal, we do not visit nodes that are added to the list during our traversal; they are new events, which will necessarily have full information already, so there is no need to traverse them
557 --TODO: Should we check if nodes already have their values before propagating? Maybe we're re-doing work
531 --TODO: Should we check if nodes already have their values before propagating? Maybe we're re-doing work
558− WeakBag.traverse_ subscribers $ \s -> subscriberPropagate s a
532+ WeakBag.traverse subscribers $ \s -> subscriberPropagate s a
559
533
560-- | Propagate everything at the current height
534-- | Propagate everything at the current height
561−propagateFast :: forall x a. HasSpiderTimeline x => a -> FastWeakBag (Subscriber x a) -> EventM x ()
535+propagateFast :: a -> FastWeakBag (Subscriber x a) -> EventM x ()
562−propagateFast a subscribers = withIncreasedDepth (Proxy::Proxy x) $
536+propagateFast a subscribers = withIncreasedDepth $ do
563 -- Note: in the following traversal, we do not visit nodes that are added to the list during our traversal; they are new events, which will necessarily have full information already, so there is no need to traverse them
537 -- Note: in the following traversal, we do not visit nodes that are added to the list during our traversal; they are new events, which will necessarily have full information already, so there is no need to traverse them
564 --TODO: Should we check if nodes already have their values before propagating? Maybe we're re-doing work
538 --TODO: Should we check if nodes already have their values before propagating? Maybe we're re-doing work
565− FastWeakBag.traverse_ subscribers $ \s -> subscriberPropagate s a
539+ FastWeakBag.traverse subscribers $ \s -> subscriberPropagate s a
566
540
567--------------------------------------------------------------------------------
541--------------------------------------------------------------------------------
568-- EventSubscribed
542-- EventSubscribed
@@ -571,16 +545,11 @@ propagateFast a subscribers = withIncreasedDepth (Proxy::Proxy x) $
571toAny :: a -> Any
545toAny :: a -> Any
572toAny = unsafeCoerce
546toAny = unsafeCoerce
573
547
574−-- Why do we use Any here, instead of just giving eventSubscribedRetained an
575−-- existential type? Sadly, GHC does not currently know how to unbox types
576−-- with existentially quantified fields. So instead we just coerce values
577−-- to type Any on the way in. Since we never coerce them back, this is
578−-- perfectly safe.
579data EventSubscribed x = EventSubscribed
548data EventSubscribed x = EventSubscribed
580 { eventSubscribedHeightRef :: {-# UNPACK #-} !(IORef Height)
549 { eventSubscribedHeightRef :: {-# UNPACK #-} !(IORef Height)
581 , eventSubscribedRetained :: {-# NOUNPACK #-} !Any
550 , eventSubscribedRetained :: {-# NOUNPACK #-} !Any
582#ifdef DEBUG_CYCLES
551#ifdef DEBUG_CYCLES
583− , eventSubscribedGetParents :: !(IO [EventSubscribed x]) -- For debugging loops
552+ , eventSubscribedGetParents :: !(IO [Some (EventSubscribed x)]) -- For debugging loops
584 , eventSubscribedHasOwnHeightRef :: !Bool
553 , eventSubscribedHasOwnHeightRef :: !Bool
585 , eventSubscribedWhoCreated :: !(IO [String])
554 , eventSubscribedWhoCreated :: !(IO [String])
586#endif
555#endif
@@ -607,23 +576,13 @@ eventSubscribedNever = EventSubscribed
607 , eventSubscribedWhoCreated = return ["never"]
576 , eventSubscribedWhoCreated = return ["never"]
608#endif
577#endif
609 }
578 }
610−eventSubscribedNow :: EventSubscribed x
611−eventSubscribedNow = EventSubscribed
612− { eventSubscribedHeightRef = zeroRef
613− , eventSubscribedRetained = toAny ()
614−#ifdef DEBUG_CYCLES
615− , eventSubscribedGetParents = return []
616− , eventSubscribedHasOwnHeightRef = False
617− , eventSubscribedWhoCreated = return ["now"]
618−#endif
619− }
620
579
621−eventSubscribedFan :: FanSubscribed x k v -> EventSubscribed x
580+eventSubscribedFan :: FanSubscribed x k -> EventSubscribed x
622eventSubscribedFan !subscribed = EventSubscribed
581eventSubscribedFan !subscribed = EventSubscribed
623 { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed $ fanSubscribedParent subscribed
582 { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed $ fanSubscribedParent subscribed
624 , eventSubscribedRetained = toAny subscribed
583 , eventSubscribedRetained = toAny subscribed
625#ifdef DEBUG_CYCLES
584#ifdef DEBUG_CYCLES
626− , eventSubscribedGetParents = return [_eventSubscription_subscribed $ fanSubscribedParent subscribed]
585+ , eventSubscribedGetParents = return [Some.This $ _eventSubscription_subscribed $ fanSubscribedParent subscribed]
627 , eventSubscribedHasOwnHeightRef = False
586 , eventSubscribedHasOwnHeightRef = False
628 , eventSubscribedWhoCreated = whoCreatedIORef $ fanSubscribedCachedSubscribed subscribed
587 , eventSubscribedWhoCreated = whoCreatedIORef $ fanSubscribedCachedSubscribed subscribed
629#endif
588#endif
@@ -636,7 +595,7 @@ eventSubscribedSwitch !subscribed = EventSubscribed
636#ifdef DEBUG_CYCLES
595#ifdef DEBUG_CYCLES
637 , eventSubscribedGetParents = do
596 , eventSubscribedGetParents = do
638 s <- readIORef $ switchSubscribedCurrentParent subscribed
597 s <- readIORef $ switchSubscribedCurrentParent subscribed
639− return [_eventSubscription_subscribed s]
598+ return [Some.This $ _eventSubscription_subscribed s]
640 , eventSubscribedHasOwnHeightRef = True
599 , eventSubscribedHasOwnHeightRef = True
641 , eventSubscribedWhoCreated = whoCreatedIORef $ switchSubscribedCachedSubscribed subscribed
600 , eventSubscribedWhoCreated = whoCreatedIORef $ switchSubscribedCachedSubscribed subscribed
642#endif
601#endif
@@ -649,8 +608,8 @@ eventSubscribedCoincidence !subscribed = EventSubscribed
649#ifdef DEBUG_CYCLES
608#ifdef DEBUG_CYCLES
650 , eventSubscribedGetParents = do
609 , eventSubscribedGetParents = do
651 innerSubscription <- readIORef $ coincidenceSubscribedInnerParent subscribed
610 innerSubscription <- readIORef $ coincidenceSubscribedInnerParent subscribed
652− let outerParent = _eventSubscription_subscribed $ coincidenceSubscribedOuterParent subscribed
611+ let outerParent = Some.This $ _eventSubscription_subscribed $ coincidenceSubscribedOuterParent subscribed
653− innerParents = maybeToList $ innerSubscription
612+ innerParents = maybeToList $ fmap Some.This innerSubscription
654 return $ outerParent : innerParents
613 return $ outerParent : innerParents
655 , eventSubscribedHasOwnHeightRef = True
614 , eventSubscribedHasOwnHeightRef = True
656 , eventSubscribedWhoCreated = whoCreatedIORef $ coincidenceSubscribedCachedSubscribed subscribed
615 , eventSubscribedWhoCreated = whoCreatedIORef $ coincidenceSubscribedCachedSubscribed subscribed
@@ -664,15 +623,15 @@ getEventSubscribedHeight es = readIORef $ eventSubscribedHeightRef es
664whoCreatedEventSubscribed :: EventSubscribed x -> IO [String]
623whoCreatedEventSubscribed :: EventSubscribed x -> IO [String]
665whoCreatedEventSubscribed = eventSubscribedWhoCreated
624whoCreatedEventSubscribed = eventSubscribedWhoCreated
666
625
667−walkInvalidHeightParents :: EventSubscribed x -> IO [EventSubscribed x]
626+walkInvalidHeightParents :: EventSubscribed x -> IO [Some (EventSubscribed x)]
668walkInvalidHeightParents s0 = do
627walkInvalidHeightParents s0 = do
669− subscribers <- flip execStateT mempty $ ($ s0) $ fix $ \loop s -> do
628+ subscribers <- flip execStateT mempty $ ($ Some.This s0) $ fix $ \loop (Some.This s) -> do
670 h <- liftIO $ readIORef $ eventSubscribedHeightRef s
629 h <- liftIO $ readIORef $ eventSubscribedHeightRef s
671 when (h == invalidHeight) $ do
630 when (h == invalidHeight) $ do
672 when (eventSubscribedHasOwnHeightRef s) $ liftIO $ writeIORef (eventSubscribedHeightRef s) $! invalidHeightBeingTraversed
631 when (eventSubscribedHasOwnHeightRef s) $ liftIO $ writeIORef (eventSubscribedHeightRef s) $! invalidHeightBeingTraversed
673− modify (s :)
632+ modify (Some.This s :)
674 mapM_ loop =<< liftIO (eventSubscribedGetParents s)
633 mapM_ loop =<< liftIO (eventSubscribedGetParents s)
675− forM_ subscribers $ \s -> writeIORef (eventSubscribedHeightRef s) $! invalidHeight
634+ forM_ subscribers $ \(Some.This s) -> writeIORef (eventSubscribedHeightRef s) $! invalidHeight
676 return subscribers
635 return subscribers
677#endif
636#endif
678
637
@@ -700,7 +659,7 @@ behaviorPull !p = Behavior $ do
700 val <- liftIO $ readIORef $ pullValue p
659 val <- liftIO $ readIORef $ pullValue p
701 case val of
660 case val of
702 Just subscribed -> do
661 Just subscribed -> do
703− askParentsRef >>= mapM_ (\r -> liftIO $ modifyIORef' r (SomeBehaviorSubscribed (Some (BehaviorSubscribedPull subscribed)) :))
662+ askParentsRef >>= mapM_ (\r -> liftIO $ modifyIORef' r (SomeBehaviorSubscribed (BehaviorSubscribedPull subscribed) :))
704 askInvalidator >>= mapM_ (\wi -> liftIO $ modifyIORef' (pullSubscribedInvalidators subscribed) (wi:))
663 askInvalidator >>= mapM_ (\wi -> liftIO $ modifyIORef' (pullSubscribedInvalidators subscribed) (wi:))
705 liftIO $ touch $ pullSubscribedOwnInvalidator subscribed
664 liftIO $ touch $ pullSubscribedOwnInvalidator subscribed
706 return $ pullSubscribedValue subscribed
665 return $ pullSubscribedValue subscribed
@@ -709,7 +668,7 @@ behaviorPull !p = Behavior $ do
709 wi <- liftIO $ mkWeakPtrWithDebug i "InvalidatorPull"
668 wi <- liftIO $ mkWeakPtrWithDebug i "InvalidatorPull"
710 parentsRef <- liftIO $ newIORef []
669 parentsRef <- liftIO $ newIORef []
711 holdInits <- askBehaviorHoldInits
670 holdInits <- askBehaviorHoldInits
712− a <- liftIO $ runReaderIO (unBehaviorM $ pullCompute p) (Just (wi, parentsRef), holdInits)
671+ a <- liftIO $ runReaderT (unBehaviorM $ pullCompute p) (Just (wi, parentsRef), holdInits)
713 invsRef <- liftIO . newIORef . maybeToList =<< askInvalidator
672 invsRef <- liftIO . newIORef . maybeToList =<< askInvalidator
714 parents <- liftIO $ readIORef parentsRef
673 parents <- liftIO $ readIORef parentsRef
715 let subscribed = PullSubscribed
674 let subscribed = PullSubscribed
@@ -719,7 +678,7 @@ behaviorPull !p = Behavior $ do
719 , pullSubscribedParents = parents
678 , pullSubscribedParents = parents
720 }
679 }
721 liftIO $ writeIORef (pullValue p) $ Just subscribed
680 liftIO $ writeIORef (pullValue p) $ Just subscribed
722− askParentsRef >>= mapM_ (\r -> liftIO $ modifyIORef' r (SomeBehaviorSubscribed (Some (BehaviorSubscribedPull subscribed)) :))
681+ askParentsRef >>= mapM_ (\r -> liftIO $ modifyIORef' r (SomeBehaviorSubscribed (BehaviorSubscribedPull subscribed) :))
723 return a
682 return a
724
683
725behaviorDyn :: Patch p => Dyn x p -> Behavior x (PatchTarget p)
684behaviorDyn :: Patch p => Dyn x p -> Behavior x (PatchTarget p)
@@ -730,7 +689,7 @@ readHoldTracked :: Hold x p -> BehaviorM x (PatchTarget p)
730readHoldTracked h = do
689readHoldTracked h = do
731 result <- liftIO $ readIORef $ holdValue h
690 result <- liftIO $ readIORef $ holdValue h
732 askInvalidator >>= mapM_ (\wi -> liftIO $ modifyIORef' (holdInvalidators h) (wi:))
691 askInvalidator >>= mapM_ (\wi -> liftIO $ modifyIORef' (holdInvalidators h) (wi:))
733− askParentsRef >>= mapM_ (\r -> liftIO $ modifyIORef' r (SomeBehaviorSubscribed (Some (BehaviorSubscribedHold h)) :))
692+ askParentsRef >>= mapM_ (\r -> liftIO $ modifyIORef' r (SomeBehaviorSubscribed (BehaviorSubscribedHold h) :))
734 liftIO $ touch h -- Otherwise, if this gets inlined enough, the hold's parent reference may get collected
693 liftIO $ touch h -- Otherwise, if this gets inlined enough, the hold's parent reference may get collected
735 return result
694 return result
736
695
@@ -744,46 +703,42 @@ readBehaviorUntracked b = do
744-- Dynamic
703-- Dynamic
745--------------------------------------------------------------------------------
704--------------------------------------------------------------------------------
746
705
747−type DynamicS x p = Dynamic x (PatchTarget p) p
748−
749−data Dynamic x target p = Dynamic
706+data Dynamic x p = Dynamic
750− { dynamicCurrent :: !(Behavior x target)
707+ { dynamicCurrent :: !(Behavior x (PatchTarget p))
751− , dynamicUpdated :: Event x p -- This must be lazy; see the comment on holdEvent --TODO: Would this let us eliminate `Dyn`?
708+ , dynamicUpdated :: !(Event x p)
752 }
709 }
753
710
754−deriving instance (HasSpiderTimeline x) => Functor (Dynamic x target)
755−
756−
757−
758−
759−dynamicHold :: Hold x p -> DynamicS x p
711+dynamicHold :: Hold x p -> Dynamic x p
760dynamicHold !h = Dynamic
712dynamicHold !h = Dynamic
761 { dynamicCurrent = behaviorHold h
713 { dynamicCurrent = behaviorHold h
762 , dynamicUpdated = eventHold h
714 , dynamicUpdated = eventHold h
763 }
715 }
764
716
765−dynamicHoldIdentity :: Hold x (Identity a) -> DynamicS x (Identity a)
717+dynamicHoldIdentity :: Hold x (Identity a) -> Dynamic x (Identity a)
766dynamicHoldIdentity = dynamicHold
718dynamicHoldIdentity = dynamicHold
767
719
768−dynamicConst :: PatchTarget p -> DynamicS x p
720+dynamicConst :: PatchTarget p -> Dynamic x p
769dynamicConst !a = Dynamic
721dynamicConst !a = Dynamic
770 { dynamicCurrent = behaviorConst a
722 { dynamicCurrent = behaviorConst a
771 , dynamicUpdated = eventNever
723 , dynamicUpdated = eventNever
772 }
724 }
773
725
774−dynamicDyn :: (HasSpiderTimeline x, Patch p) => Dyn x p -> DynamicS x p
726+dynamicDyn :: (HasSpiderTimeline x, Patch p) => Dyn x p -> Dynamic x p
775dynamicDyn !d = Dynamic
727dynamicDyn !d = Dynamic
776 { dynamicCurrent = behaviorDyn d
728 { dynamicCurrent = behaviorDyn d
777 , dynamicUpdated = eventDyn d
729 , dynamicUpdated = eventDyn d
778 }
730 }
779
731
780−dynamicDynIdentity :: HasSpiderTimeline x => Dyn x (Identity a) -> DynamicS x (Identity a)
732+dynamicDynIdentity :: HasSpiderTimeline x => Dyn x (Identity a) -> Dynamic x (Identity a)
781dynamicDynIdentity = dynamicDyn
733dynamicDynIdentity = dynamicDyn
782
734
783--------------------------------------------------------------------------------
735--------------------------------------------------------------------------------
784-- Combinators
736-- Combinators
785--------------------------------------------------------------------------------
737--------------------------------------------------------------------------------
786
738
739+--TODO: Figure out why certain things are not 'representational', then make them
740+--representational so we can use coerce
741+
787--type role Hold representational
742--type role Hold representational
788data Hold x p
743data Hold x p
789 = Hold { holdValue :: !(IORef (PatchTarget p))
744 = Hold { holdValue :: !(IORef (PatchTarget p))
@@ -804,25 +759,20 @@ globalSpiderTimelineEnv = unsafePerformIO unsafeNewSpiderTimelineEnv
804
759
805-- | Stores all global data relevant to a particular Spider timeline; only one
760-- | Stores all global data relevant to a particular Spider timeline; only one
806-- value should exist for each type @x@
761-- value should exist for each type @x@
807−newtype SpiderTimelineEnv x = STE {unSTE :: SpiderTimelineEnv' x}
808−-- We implement SpiderTimelineEnv with a newtype wrapper so
809−-- we can get the coercions we want safely.
810−type role SpiderTimelineEnv nominal
811−
812−data SpiderTimelineEnv' x = SpiderTimelineEnv
762+data SpiderTimelineEnv x = SpiderTimelineEnv
813 { _spiderTimeline_lock :: {-# UNPACK #-} !(MVar ())
763 { _spiderTimeline_lock :: {-# UNPACK #-} !(MVar ())
814 , _spiderTimeline_eventEnv :: {-# UNPACK #-} !(EventEnv x)
764 , _spiderTimeline_eventEnv :: {-# UNPACK #-} !(EventEnv x)
815#ifdef DEBUG
765#ifdef DEBUG
816 , _spiderTimeline_depth :: {-# UNPACK #-} !(IORef Int)
766 , _spiderTimeline_depth :: {-# UNPACK #-} !(IORef Int)
817#endif
767#endif
818 }
768 }
819−type role SpiderTimelineEnv' phantom
769+type role SpiderTimelineEnv nominal
820
770
821instance Eq (SpiderTimelineEnv x) where
771instance Eq (SpiderTimelineEnv x) where
822 _ == _ = True -- Since only one exists of each type
772 _ == _ = True -- Since only one exists of each type
823
773
824instance GEq SpiderTimelineEnv where
774instance GEq SpiderTimelineEnv where
825− a `geq` b = if _spiderTimeline_lock (unSTE a) == _spiderTimeline_lock (unSTE b)
775+ a `geq` b = if _spiderTimeline_lock a == _spiderTimeline_lock b
826 then Just $ unsafeCoerce Refl -- This unsafeCoerce is safe because the same SpiderTimelineEnv can't have two different 'x' arguments
776 then Just $ unsafeCoerce Refl -- This unsafeCoerce is safe because the same SpiderTimelineEnv can't have two different 'x' arguments
827 else Nothing
777 else Nothing
828
778
@@ -832,9 +782,9 @@ data EventEnv x
832 , eventEnvDynInits :: !(IORef [SomeDynInit x])
782 , eventEnvDynInits :: !(IORef [SomeDynInit x])
833 , eventEnvMergeUpdates :: !(IORef [SomeMergeUpdate x])
783 , eventEnvMergeUpdates :: !(IORef [SomeMergeUpdate x])
834 , eventEnvMergeInits :: !(IORef [SomeMergeInit x]) -- Needed for Subscribe
784 , eventEnvMergeInits :: !(IORef [SomeMergeInit x]) -- Needed for Subscribe
835− , eventEnvClears :: !(IORef [Some Clear]) -- Needed for Subscribe
785+ , eventEnvClears :: !(IORef [SomeClear]) -- Needed for Subscribe
836− , eventEnvIntClears :: !(IORef [Some IntClear])
786+ , eventEnvIntClears :: !(IORef [SomeIntClear])
837− , eventEnvRootClears :: !(IORef [Some RootClear])
787+ , eventEnvRootClears :: !(IORef [SomeRootClear])
838 , eventEnvCurrentHeight :: !(IORef Height) -- Needed for Subscribe
788 , eventEnvCurrentHeight :: !(IORef Height) -- Needed for Subscribe
839 , eventEnvResetCoincidences :: !(IORef [SomeResetCoincidence x]) -- Needed for Subscribe
789 , eventEnvResetCoincidences :: !(IORef [SomeResetCoincidence x]) -- Needed for Subscribe
840 , eventEnvDelayedMerges :: !(IORef (IntMap [EventM x ()]))
790 , eventEnvDelayedMerges :: !(IORef (IntMap [EventM x ()]))
@@ -845,7 +795,7 @@ runEventM :: EventM x a -> IO a
845runEventM = unEventM
795runEventM = unEventM
846
796
847asksEventEnv :: forall x a. HasSpiderTimeline x => (EventEnv x -> a) -> EventM x a
797asksEventEnv :: forall x a. HasSpiderTimeline x => (EventEnv x -> a) -> EventM x a
848−asksEventEnv f = return $ f $ _spiderTimeline_eventEnv (unSTE (spiderTimeline :: SpiderTimelineEnv x))
798+asksEventEnv f = return $ f $ _spiderTimeline_eventEnv (spiderTimeline :: SpiderTimelineEnv x)
849
799
850class MonadIO m => Defer a m where
800class MonadIO m => Defer a m where
851 getDeferralQueue :: m (IORef [a])
801 getDeferralQueue :: m (IORef [a])
@@ -906,29 +856,29 @@ putCurrentHeight h = do
906 heightRef <- asksEventEnv eventEnvCurrentHeight
856 heightRef <- asksEventEnv eventEnvCurrentHeight
907 liftIO $ writeIORef heightRef $! h
857 liftIO $ writeIORef heightRef $! h
908
858
909−instance HasSpiderTimeline x => Defer (Some Clear) (EventM x) where
859+instance HasSpiderTimeline x => Defer SomeClear (EventM x) where
910 {-# INLINE getDeferralQueue #-}
860 {-# INLINE getDeferralQueue #-}
911 getDeferralQueue = asksEventEnv eventEnvClears
861 getDeferralQueue = asksEventEnv eventEnvClears
912
862
913{-# INLINE scheduleClear #-}
863{-# INLINE scheduleClear #-}
914−scheduleClear :: Defer (Some Clear) m => IORef (Maybe a) -> m ()
864+scheduleClear :: Defer SomeClear m => IORef (Maybe a) -> m ()
915−scheduleClear r = defer $ Some $ Clear r
865+scheduleClear r = defer $ SomeClear r
916
866
917−instance HasSpiderTimeline x => Defer (Some IntClear) (EventM x) where
867+instance HasSpiderTimeline x => Defer SomeIntClear (EventM x) where
918 {-# INLINE getDeferralQueue #-}
868 {-# INLINE getDeferralQueue #-}
919 getDeferralQueue = asksEventEnv eventEnvIntClears
869 getDeferralQueue = asksEventEnv eventEnvIntClears
920
870
921{-# INLINE scheduleIntClear #-}
871{-# INLINE scheduleIntClear #-}
922−scheduleIntClear :: Defer (Some IntClear) m => IORef (IntMap a) -> m ()
872+scheduleIntClear :: Defer SomeIntClear m => IORef (IntMap a) -> m ()
923−scheduleIntClear r = defer $ Some $ IntClear r
873+scheduleIntClear r = defer $ SomeIntClear r
924
874
925−instance HasSpiderTimeline x => Defer (Some RootClear) (EventM x) where
875+instance HasSpiderTimeline x => Defer SomeRootClear (EventM x) where
926 {-# INLINE getDeferralQueue #-}
876 {-# INLINE getDeferralQueue #-}
927 getDeferralQueue = asksEventEnv eventEnvRootClears
877 getDeferralQueue = asksEventEnv eventEnvRootClears
928
878
929{-# INLINE scheduleRootClear #-}
879{-# INLINE scheduleRootClear #-}
930−scheduleRootClear :: Defer (Some RootClear) m => IORef (DMap k Identity) -> m ()
880+scheduleRootClear :: Defer SomeRootClear m => IORef (DMap k Identity) -> m ()
931−scheduleRootClear r = defer $ Some $ RootClear r
881+scheduleRootClear r = defer $ SomeRootClear r
932
882
933instance HasSpiderTimeline x => Defer (SomeResetCoincidence x) (EventM x) where
883instance HasSpiderTimeline x => Defer (SomeResetCoincidence x) (EventM x) where
934 {-# INLINE getDeferralQueue #-}
884 {-# INLINE getDeferralQueue #-}
@@ -983,9 +933,9 @@ getHoldEventSubscription h = do
983
933
984type BehaviorEnv x = (Maybe (Weak (Invalidator x), IORef [SomeBehaviorSubscribed x]), IORef [SomeHoldInit x])
934type BehaviorEnv x = (Maybe (Weak (Invalidator x), IORef [SomeBehaviorSubscribed x]), IORef [SomeHoldInit x])
985
935
936+--type role BehaviorM representational
986-- BehaviorM can sample behaviors
937-- BehaviorM can sample behaviors
987−newtype BehaviorM x a = BehaviorM { unBehaviorM :: ReaderIO (BehaviorEnv x) a }
938+newtype BehaviorM x a = BehaviorM { unBehaviorM :: ReaderT (BehaviorEnv x) IO a } deriving (Functor, Applicative, MonadIO, MonadFix)
988− deriving (Functor, Applicative, MonadIO, MonadFix, MonadReader (BehaviorEnv x))
989
939
990instance Monad (BehaviorM x) where
940instance Monad (BehaviorM x) where
991 {-# INLINE (>>=) #-}
941 {-# INLINE (>>=) #-}
@@ -994,16 +944,14 @@ instance Monad (BehaviorM x) where
994 BehaviorM x >> BehaviorM y = BehaviorM $ x >> y
944 BehaviorM x >> BehaviorM y = BehaviorM $ x >> y
995 {-# INLINE return #-}
945 {-# INLINE return #-}
996 return x = BehaviorM $ return x
946 return x = BehaviorM $ return x
997−#if !MIN_VERSION_base(4,13,0)
998 {-# INLINE fail #-}
947 {-# INLINE fail #-}
999 fail s = BehaviorM $ fail s
948 fail s = BehaviorM $ fail s
1000−#endif
1001
949
1002data BehaviorSubscribed x a
950data BehaviorSubscribed x a
1003 = forall p. BehaviorSubscribedHold (Hold x p)
951 = forall p. BehaviorSubscribedHold (Hold x p)
1004 | BehaviorSubscribedPull (PullSubscribed x a)
952 | BehaviorSubscribedPull (PullSubscribed x a)
1005
953
1006−newtype SomeBehaviorSubscribed x = SomeBehaviorSubscribed (Some (BehaviorSubscribed x))
954+data SomeBehaviorSubscribed x = forall a. SomeBehaviorSubscribed (BehaviorSubscribed x a)
1007
955
1008--type role PullSubscribed representational
956--type role PullSubscribed representational
1009data PullSubscribed x a
957data PullSubscribed x a
@@ -1038,7 +986,7 @@ data RootSubscribed x a = forall k. GCompare k => RootSubscribed
1038#endif
986#endif
1039 }
987 }
1040
988
1041−data Root x k
989+data Root x (k :: * -> *)
1042 = Root { rootOccurrence :: !(IORef (DMap k Identity)) -- The currently-firing occurrence of this event
990 = Root { rootOccurrence :: !(IORef (DMap k Identity)) -- The currently-firing occurrence of this event
1043 , rootSubscribed :: !(IORef (DMap k (RootSubscribed x)))
991 , rootSubscribed :: !(IORef (DMap k (RootSubscribed x)))
1044 , rootInit :: !(forall a. k a -> RootTrigger x a -> IO (IO ()))
992 , rootInit :: !(forall a. k a -> RootTrigger x a -> IO (IO ()))
@@ -1057,7 +1005,7 @@ data SomeMergeUpdate x = SomeMergeUpdate
1057newtype SomeMergeInit x = SomeMergeInit { unSomeMergeInit :: EventM x () }
1005newtype SomeMergeInit x = SomeMergeInit { unSomeMergeInit :: EventM x () }
1058
1006
1059-- EventM can do everything BehaviorM can, plus create holds
1007-- EventM can do everything BehaviorM can, plus create holds
1060−newtype EventM x a = EventM { unEventM :: IO a } deriving (Functor, Applicative, Monad, MonadIO, MonadFix, MonadException, MonadAsyncException)
1008+newtype EventM x a = EventM { unEventM :: IO a } deriving (Functor, Applicative, Monad, MonadIO, MonadFix, MonadException, MonadAsyncException) -- The environment should be Nothing if we are not in a frame, and Just if we are - in which case it is a list of assignments to be done after the frame is over
1061
1009
1062newtype MergeSubscribedParent x a = MergeSubscribedParent { unMergeSubscribedParent :: EventSubscription x }
1010newtype MergeSubscribedParent x a = MergeSubscribedParent { unMergeSubscribedParent :: EventSubscription x }
1063
1011
@@ -1082,8 +1030,7 @@ heightBagFromList :: [Height] -> HeightBag
1082heightBagFromList heights = heightBagVerify $ foldl' (flip heightBagAdd) heightBagEmpty heights
1030heightBagFromList heights = heightBagVerify $ foldl' (flip heightBagAdd) heightBagEmpty heights
1083
1031
1084heightBagAdd :: Height -> HeightBag -> HeightBag
1032heightBagAdd :: Height -> HeightBag -> HeightBag
1085−heightBagAdd (Height h) (HeightBag s c) = heightBagVerify $ HeightBag (succ s) $
1033+heightBagAdd (Height h) (HeightBag s c) = heightBagVerify $ HeightBag (succ s) $ IntMap.insertWithKey (\_ _ old -> succ old) h 0 c
1086− IntMap.insertWithKey (\_ _ old -> succ old) h 0 c
1087
1034
1088heightBagRemove :: Height -> HeightBag -> HeightBag
1035heightBagRemove :: Height -> HeightBag -> HeightBag
1089heightBagRemove (Height h) b@(HeightBag s c) = heightBagVerify $ case IntMap.lookup h c of
1036heightBagRemove (Height h) b@(HeightBag s c) = heightBagVerify $ case IntMap.lookup h c of
@@ -1092,13 +1039,6 @@ heightBagRemove (Height h) b@(HeightBag s c) = heightBagVerify $ case IntMap.loo
1092 0 -> IntMap.delete h c
1039 0 -> IntMap.delete h c
1093 _ -> IntMap.insert h (pred old) c
1040 _ -> IntMap.insert h (pred old) c
1094
1041
1095−heightBagRemoveMaybe :: Height -> HeightBag -> Maybe HeightBag
1096−heightBagRemoveMaybe (Height h) b@(HeightBag s c) = heightBagVerify . removed <$> IntMap.lookup h c where
1097− removed old = HeightBag (pred s) $ case old of
1098− 0 -> IntMap.delete h c
1099− _ -> IntMap.insert h (pred old) c
1100−
1101−
1102heightBagMax :: HeightBag -> Height
1042heightBagMax :: HeightBag -> Height
1103heightBagMax (HeightBag _ c) = case IntMap.maxViewWithKey c of
1043heightBagMax (HeightBag _ c) = case IntMap.maxViewWithKey c of
1104 Just ((h, _), _) -> Height h
1044 Just ((h, _), _) -> Height h
@@ -1116,25 +1056,25 @@ heightBagVerify b@(HeightBag s c) = if
1116heightBagVerify = id
1056heightBagVerify = id
1117#endif
1057#endif
1118
1058
1119−data FanSubscribedChildren x k v a = FanSubscribedChildren
1059+data FanSubscribedChildren (x :: *) k a = FanSubscribedChildren
1120− { _fanSubscribedChildren_list :: !(WeakBag (Subscriber x (v a)))
1060+ { _fanSubscribedChildren_list :: !(WeakBag (Subscriber x a))
1121− , _fanSubscribedChildren_self :: {-# NOUNPACK #-} !(k a, FanSubscribed x k v)
1061+ , _fanSubscribedChildren_self :: {-# NOUNPACK #-} !(k a, FanSubscribed x k)
1122− , _fanSubscribedChildren_weakSelf :: !(IORef (Weak (k a, FanSubscribed x k v)))
1062+ , _fanSubscribedChildren_weakSelf :: !(IORef (Weak (k a, FanSubscribed x k)))
1123 }
1063 }
1124
1064
1125−data FanSubscribed x k v
1065+data FanSubscribed (x :: *) k
1126− = FanSubscribed { fanSubscribedCachedSubscribed :: !(IORef (Maybe (FanSubscribed x k v)))
1066+ = FanSubscribed { fanSubscribedCachedSubscribed :: !(IORef (Maybe (FanSubscribed x k)))
1127− , fanSubscribedOccurrence :: !(IORef (Maybe (DMap k v)))
1067+ , fanSubscribedOccurrence :: !(IORef (Maybe (DMap k Identity)))
1128− , fanSubscribedSubscribers :: !(IORef (DMap k (FanSubscribedChildren x k v))) -- This DMap should never be empty
1068+ , fanSubscribedSubscribers :: !(IORef (DMap k (FanSubscribedChildren x k))) -- This DMap should never be empty
1129 , fanSubscribedParent :: !(EventSubscription x)
1069 , fanSubscribedParent :: !(EventSubscription x)
1130#ifdef DEBUG_NODEIDS
1070#ifdef DEBUG_NODEIDS
1131 , fanSubscribedNodeId :: Int
1071 , fanSubscribedNodeId :: Int
1132#endif
1072#endif
1133 }
1073 }
1134
1074
1135−data Fan x k v
1075+data Fan x k
1136− = Fan { fanParent :: !(Event x (DMap k v))
1076+ = Fan { fanParent :: !(Event x (DMap k Identity))
1137− , fanSubscribed :: !(IORef (Maybe (FanSubscribed x k v)))
1077+ , fanSubscribed :: !(IORef (Maybe (FanSubscribed x k)))
1138 }
1078 }
1139
1079
1140data SwitchSubscribed x a
1080data SwitchSubscribed x a
@@ -1188,35 +1128,24 @@ newInvalidatorSwitch subd = return $! InvalidatorSwitch subd
1188newInvalidatorPull :: Pull x a -> IO (Invalidator x)
1128newInvalidatorPull :: Pull x a -> IO (Invalidator x)
1189newInvalidatorPull p = return $! InvalidatorPull p
1129newInvalidatorPull p = return $! InvalidatorPull p
1190
1130
1191−instance HasSpiderTimeline x => Filterable (Event x) where
1131+instance HasSpiderTimeline x => FunctorMaybe (Event x) where
1192− mapMaybe f = push $ return . f
1132+ fmapMaybe f = push $ return . f
1193
1133
1194instance HasSpiderTimeline x => Align (Event x) where
1134instance HasSpiderTimeline x => Align (Event x) where
1195 nil = eventNever
1135 nil = eventNever
1196−#if MIN_VERSION_these(0, 8, 0)
1197−instance HasSpiderTimeline x => Semialign (Event x) where
1198−#endif
1199− align ea eb = mapMaybe dmapToThese $ mergeG coerce $ dynamicConst $
1200− DMap.fromDistinctAscList [LeftTag :=> ea, RightTag :=> eb]
1136+ align ea eb = fmapMaybe dmapToThese $ merge $ dynamicConst $ DMap.fromDistinctAscList [LeftTag :=> ea, RightTag :=> eb]
1201−
1202−#ifdef MIN_VERSION_semialign
1203−#if MIN_VERSION_semialign(1,1,0)
1204−instance HasSpiderTimeline x => Zip (Event x) where
1205−#endif
1206− zip x y = mapMaybe justThese $ align x y
1207−#endif
1208
1137
1209data DynType x p = UnsafeDyn !(BehaviorM x (PatchTarget p), Event x p)
1138data DynType x p = UnsafeDyn !(BehaviorM x (PatchTarget p), Event x p)
1210 | BuildDyn !(EventM x (PatchTarget p), Event x p)
1139 | BuildDyn !(EventM x (PatchTarget p), Event x p)
1211 | HoldDyn !(Hold x p)
1140 | HoldDyn !(Hold x p)
1212
1141
1213−newtype Dyn (x :: Type) p = Dyn { unDyn :: IORef (DynType x p) }
1142+newtype Dyn x p = Dyn { unDyn :: IORef (DynType x p) }
1214
1143
1215−newMapDyn :: HasSpiderTimeline x => (a -> b) -> DynamicS x (Identity a) -> DynamicS x (Identity b)
1144+newMapDyn :: HasSpiderTimeline x => (a -> b) -> Dynamic x (Identity a) -> Dynamic x (Identity b)
1216newMapDyn f d = dynamicDynIdentity $ unsafeBuildDynamic (fmap f $ readBehaviorTracked $ dynamicCurrent d) (Identity . f . runIdentity <$> dynamicUpdated d)
1145newMapDyn f d = dynamicDynIdentity $ unsafeBuildDynamic (fmap f $ readBehaviorTracked $ dynamicCurrent d) (Identity . f . runIdentity <$> dynamicUpdated d)
1217
1146
1218--TODO: Avoid the duplication between this and R.zipDynWith
1147--TODO: Avoid the duplication between this and R.zipDynWith
1219−zipDynWith :: HasSpiderTimeline x => (a -> b -> c) -> DynamicS x (Identity a) -> DynamicS x (Identity b) -> DynamicS x (Identity c)
1148+zipDynWith :: HasSpiderTimeline x => (a -> b -> c) -> Dynamic x (Identity a) -> Dynamic x (Identity b) -> Dynamic x (Identity c)
1220zipDynWith f da db =
1149zipDynWith f da db =
1221 let eab = align (dynamicUpdated da) (dynamicUpdated db)
1150 let eab = align (dynamicUpdated da) (dynamicUpdated db)
1222 ec = flip push eab $ \o -> do
1151 ec = flip push eab $ \o -> do
@@ -1239,12 +1168,18 @@ buildDynamic readV0 v' = do
1239 return d
1168 return d
1240
1169
1241unsafeBuildDynamic :: BehaviorM x (PatchTarget p) -> Event x p -> Dyn x p
1170unsafeBuildDynamic :: BehaviorM x (PatchTarget p) -> Event x p -> Dyn x p
1242−unsafeBuildDynamic readV0 v' =
1171+unsafeBuildDynamic readV0 v' = Dyn $ unsafeNewIORef x $ UnsafeDyn x
1243− Dyn $ unsafePerformIO $ newIORef $ UnsafeDyn (readV0, v')
1172+ where x = (readV0, v')
1244
1173
1245-- ResultM can read behaviors and events
1174-- ResultM can read behaviors and events
1246type ResultM = EventM
1175type ResultM = EventM
1247
1176
1177+{-# NOINLINE unsafeNewIORef #-}
1178+unsafeNewIORef :: a -> b -> IORef b
1179+unsafeNewIORef a b = unsafePerformIO $ do
1180+ touch a
1181+ newIORef b
1182+
1248instance HasSpiderTimeline x => Functor (Event x) where
1183instance HasSpiderTimeline x => Functor (Event x) where
1249 fmap f = push $ return . Just . f
1184 fmap f = push $ return . Just . f
1250
1185
@@ -1257,42 +1192,33 @@ push f e = cacheEvent (pushCheap f e)
1257
1192
1258{-# INLINABLE pull #-}
1193{-# INLINABLE pull #-}
1259pull :: BehaviorM x a -> Behavior x a
1194pull :: BehaviorM x a -> Behavior x a
1260−pull a = unsafePerformIO $ do
1195+pull a = behaviorPull $ Pull
1261− ref <- newIORef Nothing
1196+ { pullCompute = a
1197+ , pullValue = unsafeNewIORef a Nothing
1262#ifdef DEBUG_NODEIDS
1198#ifdef DEBUG_NODEIDS
1263− nid <- newNodeId
1199+ , pullNodeId = unsafeNodeId a
1264#endif
1200#endif
1265− pure $ behaviorPull $ Pull
1266− { pullCompute = a
1267− , pullValue = ref
1268−#ifdef DEBUG_NODEIDS
1269− , pullNodeId = nid
1270−#endif
1271− }
1201+ }
1272
1202
1273{-# INLINABLE switch #-}
1203{-# INLINABLE switch #-}
1274switch :: HasSpiderTimeline x => Behavior x (Event x a) -> Event x a
1204switch :: HasSpiderTimeline x => Behavior x (Event x a) -> Event x a
1275−switch a = unsafePerformIO $ do
1276− ref <- newIORef Nothing
1277− pure $ eventSwitch $ Switch
1205+switch a = eventSwitch $ Switch
1278− { switchParent = a
1206+ { switchParent = a
1279− , switchSubscribed = ref
1207+ , switchSubscribed = unsafeNewIORef a Nothing
1280− }
1208+ }
1281
1209
1282coincidence :: HasSpiderTimeline x => Event x (Event x a) -> Event x a
1210coincidence :: HasSpiderTimeline x => Event x (Event x a) -> Event x a
1283−coincidence a = unsafePerformIO $ do
1284− ref <- newIORef Nothing
1285− pure $ eventCoincidence $ Coincidence
1211+coincidence a = eventCoincidence $ Coincidence
1286− { coincidenceParent = a
1212+ { coincidenceParent = a
1287− , coincidenceSubscribed = ref
1213+ , coincidenceSubscribed = unsafeNewIORef a Nothing
1288− }
1214+ }
1289
1215
1290-- Propagate the given event occurrence; before cleaning up, run the given action, which may read the state of events and behaviors
1216-- Propagate the given event occurrence; before cleaning up, run the given action, which may read the state of events and behaviors
1291run :: forall x b. HasSpiderTimeline x => [DSum (RootTrigger x) Identity] -> ResultM x b -> SpiderHost x b
1217run :: forall x b. HasSpiderTimeline x => [DSum (RootTrigger x) Identity] -> ResultM x b -> SpiderHost x b
1292run roots after = do
1218run roots after = do
1293 tracePropagate (Proxy :: Proxy x) $ "Running an event frame with " <> show (length roots) <> " events"
1219 tracePropagate (Proxy :: Proxy x) $ "Running an event frame with " <> show (length roots) <> " events"
1294 let t = spiderTimeline :: SpiderTimelineEnv x
1220 let t = spiderTimeline :: SpiderTimelineEnv x
1295− result <- SpiderHost $ withMVar (_spiderTimeline_lock (unSTE t)) $ \_ -> unSpiderHost $ runFrame $ do
1221+ result <- SpiderHost $ withMVar (_spiderTimeline_lock t) $ \_ -> unSpiderHost $ runFrame $ do
1296 rootsToPropagate <- forM roots $ \r@(RootTrigger (_, occRef, k) :=> a) -> do
1222 rootsToPropagate <- forM roots $ \r@(RootTrigger (_, occRef, k) :=> a) -> do
1297 occBefore <- liftIO $ do
1223 occBefore <- liftIO $ do
1298 occBefore <- readIORef occRef
1224 occBefore <- readIORef occRef
@@ -1330,11 +1256,11 @@ scheduleMerge' initialHeight heightRef a = scheduleMerge initialHeight $ do
1330 GT -> scheduleMerge' height heightRef a -- The height has been increased (by a coincidence event; TODO: is this the only way?)
1256 GT -> scheduleMerge' height heightRef a -- The height has been increased (by a coincidence event; TODO: is this the only way?)
1331 EQ -> a
1257 EQ -> a
1332
1258
1333−newtype Clear a = Clear (IORef (Maybe a))
1259+data SomeClear = forall a. SomeClear {-# UNPACK #-} !(IORef (Maybe a))
1334
1260
1335−newtype IntClear a = IntClear (IORef (IntMap a))
1261+data SomeIntClear = forall a. SomeIntClear {-# UNPACK #-} !(IORef (IntMap a))
1336
1262
1337−newtype RootClear k = RootClear (IORef (DMap k Identity))
1263+data SomeRootClear = forall k. SomeRootClear {-# UNPACK #-} !(IORef (DMap k Identity))
1338
1264
1339data SomeAssignment x = forall a. SomeAssignment {-# UNPACK #-} !(IORef a) {-# UNPACK #-} !(IORef [Weak (Invalidator x)]) a
1265data SomeAssignment x = forall a. SomeAssignment {-# UNPACK #-} !(IORef a) {-# UNPACK #-} !(IORef [Weak (Invalidator x)]) a
1340
1266
@@ -1346,110 +1272,55 @@ mkWeakPtrWithDebug x debugNote = do
1346 x' <- evaluate x
1272 x' <- evaluate x
1347 mkWeakPtr x' $
1273 mkWeakPtr x' $
1348 if debugFinalize
1274 if debugFinalize
1349− then Just $ debugStrLn $ "finalizing: " ++ debugNote
1275+ then Just $ putStrLn $ "finalizing: " ++ debugNote
1350 else Nothing
1276 else Nothing
1351
1277
1352type WeakList a = [Weak a]
1278type WeakList a = [Weak a]
1353
1279
1354−type CanTrace x m = (HasSpiderTimeline x, MonadIO m)
1355−
1356−
1357−
1358−
1359−#ifdef DEBUG
1360−
1361−debugSubscriber :: forall x a. HasSpiderTimeline x => String -> Subscriber x a -> IO (Subscriber x a)
1362−debugSubscriber description = return . debugSubscriber' description
1363−
1364−debugSubscriber' :: forall x a. HasSpiderTimeline x => String -> Subscriber x a -> Subscriber x a
1365−debugSubscriber' description subscribed = Subscriber
1366− {
1367− subscriberPropagate = \m -> do
1368− tracePropagate (Proxy :: Proxy x) ("subscriberPropagate: " <> description)
1369− subscriberPropagate subscribed m
1370− , subscriberInvalidateHeight = \old -> do
1371− traceInvalidateHeight $ "invalidateSubscriberHeight: " <> description <> ", old = " <> show (unHeight old)
1372− subscriberInvalidateHeight subscribed old
1373− traceInvalidateHeight $ "invalidateSubscriberHeight: " <> description <> ", done"
1374− , subscriberRecalculateHeight = \new -> do
1375− traceInvalidateHeight $ "subscriberRecalculateHeight: " <> description <> ", new = " <> show (unHeight new)
1376− subscriberRecalculateHeight subscribed new
1377− traceInvalidateHeight $ "subscriberRecalculateHeight: " <> description <> ", done"
1378− }
1379−
1380−
1381{-# INLINE withIncreasedDepth #-}
1280{-# INLINE withIncreasedDepth #-}
1281+#ifdef DEBUG
1382−withIncreasedDepth :: forall proxy x m a. CanTrace x m => proxy x -> m a -> m a
1282+withIncreasedDepth :: CanTrace x m => m a -> m a
1383−withIncreasedDepth _ a = do
1283+withIncreasedDepth a = do
1284+ spiderTimeline <- askSpiderTimelineEnv
1384− liftIO $ modifyIORef' (_spiderTimeline_depth $ unSTE (spiderTimeline :: SpiderTimelineEnv x)) succ
1285+ liftIO $ modifyIORef' (_spiderTimeline_depth spiderTimeline) succ
1385 result <- a
1286 result <- a
1386− liftIO $ modifyIORef' (_spiderTimeline_depth $ unSTE (spiderTimeline :: SpiderTimelineEnv x)) pred
1287+ liftIO $ modifyIORef' (_spiderTimeline_depth spiderTimeline) pred
1387 return result
1288 return result
1388−
1389−{-# INLINE tracePropagate #-}
1390−tracePropagate :: (CanTrace x m) => proxy x -> String -> m ()
1391−tracePropagate p = when debugPropagate . trace p
1392−
1393−{-# INLINE traceInvalidate #-}
1394−traceInvalidate :: String -> IO ()
1395−traceInvalidate = when debugInvalidate . liftIO . debugStrLn
1396−
1397−{-# INLINE traceInvalidateHeight #-}
1398−traceInvalidateHeight :: String -> IO ()
1399−traceInvalidateHeight = when debugInvalidateHeight . liftIO . debugStrLn
1400−
1401−{-# INLINE trace #-}
1402−trace :: (CanTrace x m) => proxy x -> String -> m ()
1403−trace p message = traceM p $ return message
1404−
1405−{-# INLINE traceM #-}
1406−traceM :: forall x proxy m. (CanTrace x m) => proxy x -> m String -> m ()
1407−traceM _ getMessage = do
1408− message <- getMessage
1409− d <- liftIO $ readIORef $ _spiderTimeline_depth $ unSTE (spiderTimeline :: SpiderTimelineEnv x)
1410− liftIO $ debugStrLn $ replicate d ' ' <> message
1411−
1412#else
1289#else
1290+withIncreasedDepth :: m a -> m a
1291+withIncreasedDepth = id
1292+#endif
1413
1293
1414−{-# INLINE withIncreasedDepth #-}
1294+type CanTrace x m = (HasSpiderTimeline x, MonadIO m)
1415−withIncreasedDepth :: proxy x -> m a -> m a
1416−withIncreasedDepth _ = id
1417
1295
1418{-# INLINE tracePropagate #-}
1296{-# INLINE tracePropagate #-}
1419tracePropagate :: (CanTrace x m) => proxy x -> String -> m ()
1297tracePropagate :: (CanTrace x m) => proxy x -> String -> m ()
1420−tracePropagate _ _ = return ()
1298+tracePropagate p = traceWhen p debugPropagate
1421
1299
1422{-# INLINE traceInvalidate #-}
1300{-# INLINE traceInvalidate #-}
1423traceInvalidate :: String -> IO ()
1301traceInvalidate :: String -> IO ()
1424−traceInvalidate _ = return ()
1302+traceInvalidate = when debugInvalidate . liftIO . putStrLn
1425−
1426−{-# INLINE traceInvalidateHeight #-}
1427−traceInvalidateHeight :: String -> IO ()
1428−traceInvalidateHeight _ = return ()
1429
1303
1430−{-# INLINE debugSubscriber #-}
1304+{-# INLINE traceWhen #-}
1431−debugSubscriber :: String -> Subscriber x a -> IO (Subscriber x a)
1432−debugSubscriber _ = return
1433−
1434−{-# INLINE debugSubscriber' #-}
1435−debugSubscriber' :: String -> Subscriber x a -> Subscriber x a
1436−debugSubscriber' _ = id
1437−
1438−
1439−
1440−{-# INLINE trace #-}
1441−trace :: (CanTrace x m) => proxy x -> String -> m ()
1305+traceWhen :: (CanTrace x m) => proxy x -> Bool -> String -> m ()
1442−trace _ _ = return ()
1306+traceWhen p b message = traceMWhen p b $ return message
1443−
1444−{-# INLINE traceM #-}
1445−traceM :: (CanTrace x m) => proxy x -> m String -> m ()
1446−traceM _ _ = return ()
1447
1307
1308+{-# INLINE traceMWhen #-}
1309+traceMWhen :: (CanTrace x m) => proxy x -> Bool -> m String -> m ()
1310+traceMWhen _ b getMessage = when b $ do
1311+ message <- getMessage
1312+#ifdef DEBUG
1313+ spiderTimeline <- askSpiderTimelineEnv
1314+ d <- liftIO $ readIORef $ _spiderTimeline_depth spiderTimeline
1315+#else
1316+ let d = 0
1448#endif
1317#endif
1318+ liftIO $ putStrLn $ replicate d ' ' <> message
1449
1319
1450whoCreatedIORef :: IORef a -> IO [String]
1320whoCreatedIORef :: IORef a -> IO [String]
1451whoCreatedIORef (IORef a) = whoCreated $! a
1321whoCreatedIORef (IORef a) = whoCreated $! a
1452
1322
1323+#ifdef DEBUG_CYCLES
1453groupByHead :: Eq a => [NonEmpty a] -> [(a, NonEmpty [a])]
1324groupByHead :: Eq a => [NonEmpty a] -> [(a, NonEmpty [a])]
1454groupByHead = \case
1325groupByHead = \case
1455 [] -> []
1326 [] -> []
@@ -1460,54 +1331,20 @@ groupByHead = \case
1460 | otherwise -> (x, xs :| []) : l
1331 | otherwise -> (x, xs :| []) : l
1461
1332
1462listsToForest :: Eq a => [[a]] -> Forest a
1333listsToForest :: Eq a => [[a]] -> Forest a
1463−listsToForest lists = buildForest <$> groupByHead (mapMaybe nonEmpty lists)
1334+listsToForest l = fmap (\(a, l') -> Node a $ listsToForest $ toList l') $ groupByHead $ catMaybes $ fmap nonEmpty l
1464− where buildForest (a, lists') = Node a $ listsToForest $ toList lists'
1465−
1466−showStacks :: [[String]] -> String
1467−showStacks = drawForest . listsToForest . fmap (filterStack "Reflex.Spider.Internal")
1468−
1469−filterStack :: String -> [String] -> [String]
1470−#ifdef DEBUG_HIDE_INTERNALS
1471−filterStack prefix = filter (not . (prefix `isPrefixOf`))
1472−#else
1473−filterStack prefix = id
1474−#endif
1475−
1476−#ifdef DEBUG_CYCLES
1477−
1478−data EventLoopException = EventLoopException [[String]]
1479−instance Exception EventLoopException
1480−
1481−instance Show EventLoopException where
1482− show (EventLoopException stacks) = "causality loop detected:\n" <> if null stacks
1483− then "no location information, compile with profiling enabled for stack tree"
1484− else showStacks stacks
1485−
1486−#else
1487−
1488−data EventLoopException = EventLoopException
1489−instance Exception EventLoopException
1490−
1491−instance Show EventLoopException where
1492− show EventLoopException = "causality loop detected: \n" <>
1493− "compile reflex with flag 'debug-cycles' and compile with profiling enabled for stack tree"
1494−
1495#endif
1335#endif
1496
1336
1497−
1498{-# INLINE propagateSubscriberHold #-}
1337{-# INLINE propagateSubscriberHold #-}
1499propagateSubscriberHold :: forall x p. (HasSpiderTimeline x, Patch p) => Hold x p -> p -> EventM x ()
1338propagateSubscriberHold :: forall x p. (HasSpiderTimeline x, Patch p) => Hold x p -> p -> EventM x ()
1500propagateSubscriberHold h a = do
1339propagateSubscriberHold h a = do
1501− {-# SCC "trace" #-} when debugPropagate $ traceM (Proxy :: Proxy x) $ liftIO $ do
1340+ {-# SCC "trace" #-} traceMWhen (Proxy :: Proxy x) debugPropagate $ liftIO $ do
1502 invalidators <- liftIO $ readIORef $ holdInvalidators h
1341 invalidators <- liftIO $ readIORef $ holdInvalidators h
1503 return $ "SubscriberHold" <> showNodeId h <> ": " ++ show (length invalidators)
1342 return $ "SubscriberHold" <> showNodeId h <> ": " ++ show (length invalidators)
1504−
1505 v <- {-# SCC "read" #-} liftIO $ readIORef $ holdValue h
1343 v <- {-# SCC "read" #-} liftIO $ readIORef $ holdValue h
1506 case {-# SCC "apply" #-} apply a v of
1344 case {-# SCC "apply" #-} apply a v of
1507 Nothing -> return ()
1345 Nothing -> return ()
1508 Just v' -> do
1346 Just v' -> do
1509− {-# SCC "trace2" #-} withIncreasedDepth (Proxy :: Proxy x) $
1510− tracePropagate (Proxy :: Proxy x) ("propagateSubscriberHold: assigning Hold" <> showNodeId h)
1347+ {-# SCC "trace2" #-} withIncreasedDepth $ tracePropagate (Proxy :: Proxy x) $ "propagateSubscriberHold: assigning Hold" <> showNodeId h
1511 vRef <- {-# SCC "vRef" #-} liftIO $ evaluate $ holdValue h
1348 vRef <- {-# SCC "vRef" #-} liftIO $ evaluate $ holdValue h
1512 iRef <- {-# SCC "iRef" #-} liftIO $ evaluate $ holdInvalidators h
1349 iRef <- {-# SCC "iRef" #-} liftIO $ evaluate $ holdInvalidators h
1513 defer $ {-# SCC "assignment" #-} SomeAssignment vRef iRef v'
1350 defer $ {-# SCC "assignment" #-} SomeAssignment vRef iRef v'
@@ -1515,25 +1352,25 @@ propagateSubscriberHold h a = do
1515data SomeResetCoincidence x = forall a. SomeResetCoincidence !(EventSubscription x) !(Maybe (CoincidenceSubscribed x a)) -- The CoincidenceSubscriber will be present only if heights need to be reset
1352data SomeResetCoincidence x = forall a. SomeResetCoincidence !(EventSubscription x) !(Maybe (CoincidenceSubscribed x a)) -- The CoincidenceSubscriber will be present only if heights need to be reset
1516
1353
1517runBehaviorM :: BehaviorM x a -> Maybe (Weak (Invalidator x), IORef [SomeBehaviorSubscribed x]) -> IORef [SomeHoldInit x] -> IO a
1354runBehaviorM :: BehaviorM x a -> Maybe (Weak (Invalidator x), IORef [SomeBehaviorSubscribed x]) -> IORef [SomeHoldInit x] -> IO a
1518−runBehaviorM a mwi holdInits = runReaderIO (unBehaviorM a) (mwi, holdInits)
1355+runBehaviorM a mwi holdInits = runReaderT (unBehaviorM a) (mwi, holdInits)
1519
1356
1520askInvalidator :: BehaviorM x (Maybe (Weak (Invalidator x)))
1357askInvalidator :: BehaviorM x (Maybe (Weak (Invalidator x)))
1521askInvalidator = do
1358askInvalidator = do
1522− (!m, _) <- ask
1359+ (!m, _) <- BehaviorM ask
1523 case m of
1360 case m of
1524 Nothing -> return Nothing
1361 Nothing -> return Nothing
1525 Just (!wi, _) -> return $ Just wi
1362 Just (!wi, _) -> return $ Just wi
1526
1363
1527askParentsRef :: BehaviorM x (Maybe (IORef [SomeBehaviorSubscribed x]))
1364askParentsRef :: BehaviorM x (Maybe (IORef [SomeBehaviorSubscribed x]))
1528askParentsRef = do
1365askParentsRef = do
1529− (!m, _) <- ask
1366+ (!m, _) <- BehaviorM ask
1530 case m of
1367 case m of
1531 Nothing -> return Nothing
1368 Nothing -> return Nothing
1532 Just (_, !p) -> return $ Just p
1369 Just (_, !p) -> return $ Just p
1533
1370
1534askBehaviorHoldInits :: BehaviorM x (IORef [SomeHoldInit x])
1371askBehaviorHoldInits :: BehaviorM x (IORef [SomeHoldInit x])
1535askBehaviorHoldInits = do
1372askBehaviorHoldInits = do
1536− (_, !his) <- ask
1373+ (_, !his) <- BehaviorM ask
1537 return his
1374 return his
1538
1375
1539{-# INLINE getDynHold #-}
1376{-# INLINE getDynHold #-}
@@ -1561,7 +1398,7 @@ getDynHold d = do
1561zeroRef :: IORef Height
1398zeroRef :: IORef Height
1562zeroRef = unsafePerformIO $ newIORef zeroHeight
1399zeroRef = unsafePerformIO $ newIORef zeroHeight
1563
1400
1564−getRootSubscribed :: forall k x a. (GCompare k, HasSpiderTimeline x) => k a -> Root x k -> Subscriber x a -> IO (WeakBagTicket, RootSubscribed x a, Maybe a)
1401+getRootSubscribed :: GCompare k => k a -> Root x k -> Subscriber x a -> IO (WeakBagTicket, RootSubscribed x a, Maybe a)
1565getRootSubscribed k r sub = do
1402getRootSubscribed k r sub = do
1566 mSubscribed <- readIORef $ rootSubscribed r
1403 mSubscribed <- readIORef $ rootSubscribed r
1567 let getOcc = fmap (coerce . DMap.lookup k) $ readIORef $ rootOccurrence r
1404 let getOcc = fmap (coerce . DMap.lookup k) $ readIORef $ rootOccurrence r
@@ -1575,14 +1412,9 @@ getRootSubscribed k r sub = do
1575 let !cached = rootSubscribed r
1412 let !cached = rootSubscribed r
1576 uninitRef <- newIORef $ error "getRootsubscribed: uninitRef not initialized"
1413 uninitRef <- newIORef $ error "getRootsubscribed: uninitRef not initialized"
1577 (subs, sln) <- WeakBag.singleton sub weakSelf cleanupRootSubscribed
1414 (subs, sln) <- WeakBag.singleton sub weakSelf cleanupRootSubscribed
1578−
1579− tracePropagate (Proxy::Proxy x) $ "getRootSubscribed: calling rootInit"
1415+ when debugPropagate $ putStrLn $ "getRootSubscribed: calling rootInit"
1580−
1581 uninit <- rootInit r k $ RootTrigger (subs, rootOccurrence r, k)
1416 uninit <- rootInit r k $ RootTrigger (subs, rootOccurrence r, k)
1582 writeIORef uninitRef $! uninit
1417 writeIORef uninitRef $! uninit
1583−#ifdef DEBUG_NODEIDS
1584− nid <- newNodeId
1585−#endif
1586 let !subscribed = RootSubscribed
1418 let !subscribed = RootSubscribed
1587 { rootSubscribedKey = k
1419 { rootSubscribedKey = k
1588 , rootSubscribedCachedSubscribed = cached
1420 , rootSubscribedCachedSubscribed = cached
@@ -1591,7 +1423,7 @@ getRootSubscribed k r sub = do
1591 , rootSubscribedUninit = uninit
1423 , rootSubscribedUninit = uninit
1592 , rootSubscribedWeakSelf = weakSelf
1424 , rootSubscribedWeakSelf = weakSelf
1593#ifdef DEBUG_NODEIDS
1425#ifdef DEBUG_NODEIDS
1594− , rootSubscribedNodeId = nid
1426+ , rootSubscribedNodeId = unsafeNodeId (k, r, subs)
1595#endif
1427#endif
1596 }
1428 }
1597 -- If we die at the same moment that all our children die, they will
1429 -- If we die at the same moment that all our children die, they will
@@ -1627,9 +1459,6 @@ data FanInt x a = FanInt
1627 { _fanInt_subscribers :: {-# UNPACK #-} !(FastMutableIntMap (FastWeakBag (Subscriber x a))) --TODO: Clean up the keys in here when their child weak bags get empty --TODO: Remove our own subscription when the subscribers list is completely empty
1459 { _fanInt_subscribers :: {-# UNPACK #-} !(FastMutableIntMap (FastWeakBag (Subscriber x a))) --TODO: Clean up the keys in here when their child weak bags get empty --TODO: Remove our own subscription when the subscribers list is completely empty
1628 , _fanInt_subscriptionRef :: {-# UNPACK #-} !(IORef (EventSubscription x)) -- This should have a valid subscription iff subscribers is non-empty
1460 , _fanInt_subscriptionRef :: {-# UNPACK #-} !(IORef (EventSubscription x)) -- This should have a valid subscription iff subscribers is non-empty
1629 , _fanInt_occRef :: {-# UNPACK #-} !(IORef (IntMap a))
1461 , _fanInt_occRef :: {-# UNPACK #-} !(IORef (IntMap a))
1630−#ifdef DEBUG_NODEIDS
1631− , _fanInt_nodeId :: {-# UNPACK #-} !Int
1632−#endif
1633 }
1462 }
1634
1463
1635newFanInt :: IO (FanInt x a)
1464newFanInt :: IO (FanInt x a)
@@ -1637,39 +1466,38 @@ newFanInt = do
1637 subscribers <- FastMutableIntMap.newEmpty --TODO: Clean up the keys in here when their child weak bags get empty --TODO: Remove our own subscription when the subscribers list is completely empty
1466 subscribers <- FastMutableIntMap.newEmpty --TODO: Clean up the keys in here when their child weak bags get empty --TODO: Remove our own subscription when the subscribers list is completely empty
1638 subscriptionRef <- newIORef $ error "fanInt: no subscription"
1467 subscriptionRef <- newIORef $ error "fanInt: no subscription"
1639 occRef <- newIORef $ error "fanInt: no occurrence"
1468 occRef <- newIORef $ error "fanInt: no occurrence"
1640−#ifdef DEBUG_NODEIDS
1641− nodeId <- newNodeId
1642−#endif
1643 return $ FanInt
1469 return $ FanInt
1644 { _fanInt_subscribers = subscribers
1470 { _fanInt_subscribers = subscribers
1645 , _fanInt_subscriptionRef = subscriptionRef
1471 , _fanInt_subscriptionRef = subscriptionRef
1646 , _fanInt_occRef = occRef
1472 , _fanInt_occRef = occRef
1647−#ifdef DEBUG_NODEIDS
1648− , _fanInt_nodeId = nodeId
1649−#endif
1650 }
1473 }
1651
1474
1475+{-# NOINLINE unsafeNewFanInt #-}
1476+unsafeNewFanInt :: b -> FanInt x a
1477+unsafeNewFanInt b = unsafePerformIO $ do
1478+ touch b
1479+ newFanInt
1480+
1652fanInt :: HasSpiderTimeline x => Event x (IntMap a) -> EventSelectorInt x a
1481fanInt :: HasSpiderTimeline x => Event x (IntMap a) -> EventSelectorInt x a
1653−fanInt p = unsafePerformIO $ do
1482+fanInt p =
1654− self <- newFanInt
1483+ let self = unsafeNewFanInt p
1655− pure $ EventSelectorInt $ \k -> Event $ \sub -> do
1484+ in EventSelectorInt $ \k -> Event $ \sub -> do
1656 isEmpty <- liftIO $ FastMutableIntMap.isEmpty (_fanInt_subscribers self)
1485 isEmpty <- liftIO $ FastMutableIntMap.isEmpty (_fanInt_subscribers self)
1657 when isEmpty $ do -- This is the first subscriber, so we need to subscribe to our input
1486 when isEmpty $ do -- This is the first subscriber, so we need to subscribe to our input
1658− let desc = "fanInt" <> showNodeId self <> ", k = " <> show k
1659− (subscription, parentOcc) <- subscribeAndRead p $ debugSubscriber' desc $ Subscriber
1487+ (subscription, parentOcc) <- subscribeAndRead p $ Subscriber
1660 { subscriberPropagate = \m -> do
1488 { subscriberPropagate = \m -> do
1661 liftIO $ writeIORef (_fanInt_occRef self) m
1489 liftIO $ writeIORef (_fanInt_occRef self) m
1662 scheduleIntClear $ _fanInt_occRef self
1490 scheduleIntClear $ _fanInt_occRef self
1663− FastMutableIntMap.forIntersectionWithImmutable_ (_fanInt_subscribers self) m $ \b v -> --TODO: Do we need to know that no subscribers are being added as we traverse?
1491+ FastMutableIntMap.forIntersectionWithImmutable_ (_fanInt_subscribers self) m $ \b v -> do --TODO: Do we need to know that no subscribers are being added as we traverse?
1664− FastWeakBag.traverse_ b $ \s ->
1492+ FastWeakBag.traverse b $ \s -> do
1665 subscriberPropagate s v
1493 subscriberPropagate s v
1666− , subscriberInvalidateHeight = \old ->
1494+ , subscriberInvalidateHeight = \old -> do
1667− FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b ->
1495+ FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b -> do
1668− FastWeakBag.traverse_ b $ \s ->
1496+ FastWeakBag.traverse b $ \s -> do
1669 subscriberInvalidateHeight s old
1497 subscriberInvalidateHeight s old
1670− , subscriberRecalculateHeight = \new ->
1498+ , subscriberRecalculateHeight = \new -> do
1671− FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b ->
1499+ FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b -> do
1672− FastWeakBag.traverse_ b $ \s ->
1500+ FastWeakBag.traverse b $ \s -> do
1673 subscriberRecalculateHeight s new
1501 subscriberRecalculateHeight s new
1674 }
1502 }
1675 liftIO $ do
1503 liftIO $ do
@@ -1683,28 +1511,13 @@ fanInt p = unsafePerformIO $ do
1683 FastMutableIntMap.insert (_fanInt_subscribers self) k b
1511 FastMutableIntMap.insert (_fanInt_subscribers self) k b
1684 return b
1512 return b
1685 Just b -> return b
1513 Just b -> return b
1686− ticket <- liftIO $ FastWeakBag.insert sub b
1514+ t <- liftIO $ FastWeakBag.insert sub b
1687 currentOcc <- readIORef (_fanInt_occRef self)
1515 currentOcc <- readIORef (_fanInt_occRef self)
1688−
1516+ (EventSubscription _ (EventSubscribed !heightRef _)) <- readIORef (_fanInt_subscriptionRef self)
1689− subscribed <- fanIntSubscribed ticket self
1690− return (EventSubscription (FastWeakBag.remove ticket) subscribed, IntMap.lookup k currentOcc)
1517+ return (EventSubscription (FastWeakBag.remove t) $! EventSubscribed heightRef $! toAny (_fanInt_subscriptionRef self, t), IntMap.lookup k currentOcc)
1691−
1692−fanIntSubscribed :: FastWeakBagTicket k -> FanInt x a -> IO (EventSubscribed x)
1693−fanIntSubscribed ticket self = do
1694− subscribedParent <- _eventSubscription_subscribed <$> readIORef (_fanInt_subscriptionRef self)
1695− return $ EventSubscribed
1696− { eventSubscribedHeightRef = eventSubscribedHeightRef subscribedParent
1697− , eventSubscribedRetained = toAny (_fanInt_subscriptionRef self, ticket)
1698−#ifdef DEBUG_CYCLES
1699− , eventSubscribedGetParents = return [subscribedParent]
1700− , eventSubscribedHasOwnHeightRef = False
1701− , eventSubscribedWhoCreated = whoCreatedIORef $ _fanInt_subscriptionRef self
1702−#endif
1703− }
1704−
1705
1518
1706{-# INLINABLE getFanSubscribed #-}
1519{-# INLINABLE getFanSubscribed #-}
1707−getFanSubscribed :: (HasSpiderTimeline x, GCompare k) => k a -> Fan x k v -> Subscriber x (v a) -> EventM x (WeakBagTicket, FanSubscribed x k v, Maybe (v a))
1520+getFanSubscribed :: (HasSpiderTimeline x, GCompare k) => k a -> Fan x k -> Subscriber x a -> EventM x (WeakBagTicket, FanSubscribed x k, Maybe a)
1708getFanSubscribed k f sub = do
1521getFanSubscribed k f sub = do
1709 mSubscribed <- liftIO $ readIORef $ fanSubscribed f
1522 mSubscribed <- liftIO $ readIORef $ fanSubscribed f
1710 case mSubscribed of
1523 case mSubscribed of
@@ -1722,16 +1535,13 @@ getFanSubscribed k f sub = do
1722 subscribersRef <- liftIO $ newIORef $ error "getFanSubscribed: subscribersRef not yet initialized"
1535 subscribersRef <- liftIO $ newIORef $ error "getFanSubscribed: subscribersRef not yet initialized"
1723 occRef <- liftIO $ newIORef parentOcc
1536 occRef <- liftIO $ newIORef parentOcc
1724 when (isJust parentOcc) $ scheduleClear occRef
1537 when (isJust parentOcc) $ scheduleClear occRef
1725−#ifdef DEBUG_NODEIDS
1726− nid <- liftIO newNodeId
1727−#endif
1728 let subscribed = FanSubscribed
1538 let subscribed = FanSubscribed
1729 { fanSubscribedCachedSubscribed = fanSubscribed f
1539 { fanSubscribedCachedSubscribed = fanSubscribed f
1730 , fanSubscribedOccurrence = occRef
1540 , fanSubscribedOccurrence = occRef
1731 , fanSubscribedParent = subscription
1541 , fanSubscribedParent = subscription
1732 , fanSubscribedSubscribers = subscribersRef
1542 , fanSubscribedSubscribers = subscribersRef
1733#ifdef DEBUG_NODEIDS
1543#ifdef DEBUG_NODEIDS
1734− , fanSubscribedNodeId = nid
1544+ , fanSubscribedNodeId = unsafeNodeId f
1735#endif
1545#endif
1736 }
1546 }
1737 let !self = (k, subscribed)
1547 let !self = (k, subscribed)
@@ -1741,7 +1551,7 @@ getFanSubscribed k f sub = do
1741 liftIO $ writeIORef (fanSubscribed f) $ Just subscribed
1551 liftIO $ writeIORef (fanSubscribed f) $ Just subscribed
1742 return (slnForSub, subscribed, coerce $ DMap.lookup k =<< parentOcc)
1552 return (slnForSub, subscribed, coerce $ DMap.lookup k =<< parentOcc)
1743
1553
1744−cleanupFanSubscribed :: GCompare k => (k a, FanSubscribed x k v) -> IO ()
1554+cleanupFanSubscribed :: GCompare k => (k a, FanSubscribed x k) -> IO ()
1745cleanupFanSubscribed (k, subscribed) = do
1555cleanupFanSubscribed (k, subscribed) = do
1746 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
1556 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
1747 let reducedSubscribers = DMap.delete k subscribers
1557 let reducedSubscribers = DMap.delete k subscribers
@@ -1753,7 +1563,7 @@ cleanupFanSubscribed (k, subscribed) = do
1753 else writeIORef (fanSubscribedSubscribers subscribed) $! reducedSubscribers
1563 else writeIORef (fanSubscribedSubscribers subscribed) $! reducedSubscribers
1754
1564
1755{-# INLINE subscribeFanSubscribed #-}
1565{-# INLINE subscribeFanSubscribed #-}
1756−subscribeFanSubscribed :: GCompare k => k a -> FanSubscribed x k v -> Subscriber x (v a) -> IO WeakBagTicket
1566+subscribeFanSubscribed :: GCompare k => k a -> FanSubscribed x k -> Subscriber x a -> IO WeakBagTicket
1757subscribeFanSubscribed k subscribed sub = do
1567subscribeFanSubscribed k subscribed sub = do
1758 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
1568 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
1759 case DMap.lookup k subscribers of
1569 case DMap.lookup k subscribers of
@@ -1791,9 +1601,6 @@ getSwitchSubscribed s sub = do
1791 when (isJust parentOcc) $ scheduleClear occRef
1601 when (isJust parentOcc) $ scheduleClear occRef
1792 weakSelf <- liftIO $ newIORef $ error "getSwitchSubscribed: weakSelf not yet initialized"
1602 weakSelf <- liftIO $ newIORef $ error "getSwitchSubscribed: weakSelf not yet initialized"
1793 (subs, slnForSub) <- liftIO $ WeakBag.singleton sub weakSelf cleanupSwitchSubscribed
1603 (subs, slnForSub) <- liftIO $ WeakBag.singleton sub weakSelf cleanupSwitchSubscribed
1794−#ifdef DEBUG_NODEIDS
1795− nid <- liftIO newNodeId
1796−#endif
1797 let !subscribed = SwitchSubscribed
1604 let !subscribed = SwitchSubscribed
1798 { switchSubscribedCachedSubscribed = switchSubscribed s
1605 { switchSubscribedCachedSubscribed = switchSubscribed s
1799 , switchSubscribedOccurrence = occRef
1606 , switchSubscribedOccurrence = occRef
@@ -1806,7 +1613,7 @@ getSwitchSubscribed s sub = do
1806 , switchSubscribedCurrentParent = subscriptionRef
1613 , switchSubscribedCurrentParent = subscriptionRef
1807 , switchSubscribedWeakSelf = weakSelf
1614 , switchSubscribedWeakSelf = weakSelf
1808#ifdef DEBUG_NODEIDS
1615#ifdef DEBUG_NODEIDS
1809− , switchSubscribedNodeId = nid
1616+ , switchSubscribedNodeId = unsafeNodeId s
1810#endif
1617#endif
1811 }
1618 }
1812 liftIO $ writeIORef weakSelf =<< evaluate =<< mkWeakPtrWithDebug subscribed "switchSubscribedWeakSelf"
1619 liftIO $ writeIORef weakSelf =<< evaluate =<< mkWeakPtrWithDebug subscribed "switchSubscribedWeakSelf"
@@ -1851,9 +1658,6 @@ getCoincidenceSubscribed c sub = do
1851 scheduleClear innerSubdRef
1658 scheduleClear innerSubdRef
1852 weakSelf <- liftIO $ newIORef $ error "getCoincidenceSubscribed: weakSelf not yet implemented"
1659 weakSelf <- liftIO $ newIORef $ error "getCoincidenceSubscribed: weakSelf not yet implemented"
1853 (subs, slnForSub) <- liftIO $ WeakBag.singleton sub weakSelf cleanupCoincidenceSubscribed
1660 (subs, slnForSub) <- liftIO $ WeakBag.singleton sub weakSelf cleanupCoincidenceSubscribed
1854−#ifdef DEBUG_NODEIDS
1855− nid <- liftIO newNodeId
1856−#endif
1857 let subscribed = CoincidenceSubscribed
1661 let subscribed = CoincidenceSubscribed
1858 { coincidenceSubscribedCachedSubscribed = coincidenceSubscribed c
1662 { coincidenceSubscribedCachedSubscribed = coincidenceSubscribed c
1859 , coincidenceSubscribedOccurrence = occRef
1663 , coincidenceSubscribedOccurrence = occRef
@@ -1864,7 +1668,7 @@ getCoincidenceSubscribed c sub = do
1864 , coincidenceSubscribedInnerParent = innerSubdRef
1668 , coincidenceSubscribedInnerParent = innerSubdRef
1865 , coincidenceSubscribedWeakSelf = weakSelf
1669 , coincidenceSubscribedWeakSelf = weakSelf
1866#ifdef DEBUG_NODEIDS
1670#ifdef DEBUG_NODEIDS
1867− , coincidenceSubscribedNodeId = nid
1671+ , coincidenceSubscribedNodeId = unsafeNodeId c
1868#endif
1672#endif
1869 }
1673 }
1870 liftIO $ writeIORef weakSelf =<< evaluate =<< mkWeakPtrWithDebug subscribed "CoincidenceSubscribed"
1674 liftIO $ writeIORef weakSelf =<< evaluate =<< mkWeakPtrWithDebug subscribed "CoincidenceSubscribed"
@@ -1881,72 +1685,57 @@ cleanupCoincidenceSubscribed subscribed = do
1881subscribeCoincidenceSubscribed :: CoincidenceSubscribed x a -> Subscriber x a -> IO WeakBagTicket
1685subscribeCoincidenceSubscribed :: CoincidenceSubscribed x a -> Subscriber x a -> IO WeakBagTicket
1882subscribeCoincidenceSubscribed subscribed sub = WeakBag.insert sub (coincidenceSubscribedSubscribers subscribed) (coincidenceSubscribedWeakSelf subscribed) cleanupCoincidenceSubscribed
1686subscribeCoincidenceSubscribed subscribed sub = WeakBag.insert sub (coincidenceSubscribedSubscribers subscribed) (coincidenceSubscribedWeakSelf subscribed) cleanupCoincidenceSubscribed
1883
1687
1884−{-# INLINE mergeG #-}
1688+{-# INLINE merge #-}
1885−mergeG :: forall k q x v. (HasSpiderTimeline x, GCompare k)
1689+merge :: forall k x. (HasSpiderTimeline x, GCompare k) => Dynamic x (PatchDMap k (Event x)) -> Event x (DMap k Identity)
1886− => (forall a. q a -> Event x (v a))
1887− -> DynamicS x (PatchDMap k q) -> Event x (DMap k v)
1888−mergeG nt d = cacheEvent (mergeCheap nt d)
1690+merge d = cacheEvent (mergeCheap d)
1889
1691
1890{-# INLINE mergeWithMove #-}
1692{-# INLINE mergeWithMove #-}
1891−mergeWithMove :: forall k v q x. (HasSpiderTimeline x, GCompare k)
1693+mergeWithMove :: forall k x. (HasSpiderTimeline x, GCompare k) => Dynamic x (PatchDMapWithMove k (Event x)) -> Event x (DMap k Identity)
1892− => (forall a. q a -> Event x (v a))
1893− -> DynamicS x (PatchDMapWithMove k q) -> Event x (DMap k v)
1894−mergeWithMove nt d = cacheEvent (mergeCheapWithMove nt d)
1694+mergeWithMove d = cacheEvent (mergeCheapWithMove d)
1895
1695
1896{-# INLINE [1] mergeCheap #-}
1696{-# INLINE [1] mergeCheap #-}
1897−mergeCheap
1898− :: forall k x q v. (HasSpiderTimeline x, GCompare k)
1697+mergeCheap :: forall k x. (HasSpiderTimeline x, GCompare k) => Dynamic x (PatchDMap k (Event x)) -> Event x (DMap k Identity)
1899− => (forall a. q a -> Event x (v a))
1900− -> DynamicS x (PatchDMap k q)
1901− -> Event x (DMap k v)
1902−mergeCheap nt = mergeGCheap' unMergeSubscribedParent getInitialSubscribers updateMe destroy
1698+mergeCheap = mergeCheap' getInitialSubscribers updateMe destroy
1903 where
1699 where
1904− updateMe :: MergeUpdateFunc k v x (PatchDMap k q) (MergeSubscribedParent x)
1700+ updateMe :: MergeUpdateFunc k x (PatchDMap k (Event x)) (MergeSubscribedParent x)
1905 updateMe subscriber heightBagRef oldParents (PatchDMap p) = do
1701 updateMe subscriber heightBagRef oldParents (PatchDMap p) = do
1906 let f (subscriptionsToKill, ps) (k :=> ComposeMaybe me) = do
1702 let f (subscriptionsToKill, ps) (k :=> ComposeMaybe me) = do
1907 (mOldSubd, newPs) <- case me of
1703 (mOldSubd, newPs) <- case me of
1908 Nothing -> return $ DMap.updateLookupWithKey (\_ _ -> Nothing) k ps
1704 Nothing -> return $ DMap.updateLookupWithKey (\_ _ -> Nothing) k ps
1909 Just e -> do
1705 Just e -> do
1910 let s = subscriber $ return k
1706 let s = subscriber $ return k
1911− subscription@(EventSubscription _ subd) <- subscribe (nt e) s
1707+ subscription@(EventSubscription _ subd) <- subscribe e s
1912 newParentHeight <- liftIO $ getEventSubscribedHeight subd
1708 newParentHeight <- liftIO $ getEventSubscribedHeight subd
1913 let newParent = MergeSubscribedParent subscription
1709 let newParent = MergeSubscribedParent subscription
1914 liftIO $ modifyIORef' heightBagRef $ heightBagAdd newParentHeight
1710 liftIO $ modifyIORef' heightBagRef $ heightBagAdd newParentHeight
1915 return $ DMap.insertLookupWithKey' (\_ new _ -> new) k newParent ps
1711 return $ DMap.insertLookupWithKey' (\_ new _ -> new) k newParent ps
1916 forM_ mOldSubd $ \oldSubd -> do
1712 forM_ mOldSubd $ \oldSubd -> do
1917− oldHeight <- liftIO $ getEventSubscribedHeight $
1918− _eventSubscription_subscribed $ unMergeSubscribedParent oldSubd
1713+ oldHeight <- liftIO $ getEventSubscribedHeight $ _eventSubscription_subscribed $ unMergeSubscribedParent oldSubd
1919−
1920 liftIO $ modifyIORef heightBagRef $ heightBagRemove oldHeight
1714 liftIO $ modifyIORef heightBagRef $ heightBagRemove oldHeight
1921 return (maybeToList (unMergeSubscribedParent <$> mOldSubd) ++ subscriptionsToKill, newPs)
1715 return (maybeToList (unMergeSubscribedParent <$> mOldSubd) ++ subscriptionsToKill, newPs)
1922 foldM f ([], oldParents) $ DMap.toList p
1716 foldM f ([], oldParents) $ DMap.toList p
1923−
1924− getInitialSubscribers :: MergeInitFunc k v q x (MergeSubscribedParent x)
1717+ getInitialSubscribers :: MergeInitFunc k x (MergeSubscribedParent x)
1925 getInitialSubscribers initialParents subscriber = do
1718 getInitialSubscribers initialParents subscriber = do
1926 subscribers <- forM (DMap.toList initialParents) $ \(k :=> e) -> do
1719 subscribers <- forM (DMap.toList initialParents) $ \(k :=> e) -> do
1927 let s = subscriber $ return k
1720 let s = subscriber $ return k
1928− (subscription@(EventSubscription _ parentSubd), parentOcc) <- subscribeAndRead (nt e) s
1721+ (subscription@(EventSubscription _ parentSubd), parentOcc) <- subscribeAndRead e s
1929 height <- liftIO $ getEventSubscribedHeight parentSubd
1722 height <- liftIO $ getEventSubscribedHeight parentSubd
1930− return (fmap (k :=>) parentOcc, height, k :=> MergeSubscribedParent subscription)
1723+ return (fmap (\x -> k :=> Identity x) parentOcc, height, k :=> MergeSubscribedParent subscription)
1931 return ( DMap.fromDistinctAscList $ mapMaybe (\(x, _, _) -> x) subscribers
1724 return ( DMap.fromDistinctAscList $ mapMaybe (\(x, _, _) -> x) subscribers
1932 , fmap (\(_, h, _) -> h) subscribers --TODO: Assert that there's no invalidHeight in here
1725 , fmap (\(_, h, _) -> h) subscribers --TODO: Assert that there's no invalidHeight in here
1933 , DMap.fromDistinctAscList $ map (\(_, _, x) -> x) subscribers
1726 , DMap.fromDistinctAscList $ map (\(_, _, x) -> x) subscribers
1934 )
1727 )
1935−
1936 destroy :: MergeDestroyFunc k (MergeSubscribedParent x)
1728 destroy :: MergeDestroyFunc k (MergeSubscribedParent x)
1937 destroy s = forM_ (DMap.toList s) $ \(_ :=> MergeSubscribedParent sub) -> unsubscribe sub
1729 destroy s = forM_ (DMap.toList s) $ \(_ :=> MergeSubscribedParent sub) -> unsubscribe sub
1938
1730
1939{-# INLINE [1] mergeCheapWithMove #-}
1731{-# INLINE [1] mergeCheapWithMove #-}
1940−mergeCheapWithMove :: forall k x v q. (HasSpiderTimeline x, GCompare k)
1732+mergeCheapWithMove :: forall k x. (HasSpiderTimeline x, GCompare k) => Dynamic x (PatchDMapWithMove k (Event x)) -> Event x (DMap k Identity)
1941− => (forall a. q a -> Event x (v a))
1942− -> DynamicS x (PatchDMapWithMove k q)
1943− -> Event x (DMap k v)
1944−mergeCheapWithMove nt = mergeGCheap' _mergeSubscribedParentWithMove_subscription getInitialSubscribers updateMe destroy
1733+mergeCheapWithMove = mergeCheap' getInitialSubscribers updateMe destroy
1945 where
1734 where
1946− updateMe :: MergeUpdateFunc k v x (PatchDMapWithMove k q) (MergeSubscribedParentWithMove x k)
1735+ updateMe :: MergeUpdateFunc k x (PatchDMapWithMove k (Event x)) (MergeSubscribedParentWithMove x k)
1947 updateMe subscriber heightBagRef oldParents p = do
1736 updateMe subscriber heightBagRef oldParents p = do
1948 -- Prepare new parents for insertion
1737 -- Prepare new parents for insertion
1949− let subscribeParent :: forall a. k a -> Event x (v a) -> EventM x (MergeSubscribedParentWithMove x k a)
1738+ let subscribeParent :: forall a. k a -> Event x a -> EventM x (MergeSubscribedParentWithMove x k a)
1950 subscribeParent k e = do
1739 subscribeParent k e = do
1951 keyRef <- liftIO $ newIORef k
1740 keyRef <- liftIO $ newIORef k
1952 let s = subscriber $ liftIO $ readIORef keyRef
1741 let s = subscriber $ liftIO $ readIORef keyRef
@@ -1955,82 +1744,73 @@ mergeCheapWithMove nt = mergeGCheap' _mergeSubscribedParentWithMove_subscription
1955 newParentHeight <- getEventSubscribedHeight subd
1744 newParentHeight <- getEventSubscribedHeight subd
1956 modifyIORef' heightBagRef $ heightBagAdd newParentHeight
1745 modifyIORef' heightBagRef $ heightBagAdd newParentHeight
1957 return $ MergeSubscribedParentWithMove subscription keyRef
1746 return $ MergeSubscribedParentWithMove subscription keyRef
1958− p' <- PatchDMapWithMove.traversePatchDMapWithMoveWithKey (\k q -> subscribeParent k (nt q)) p
1747+ p' <- PatchDMapWithMove.traversePatchDMapWithMoveWithKey subscribeParent p
1959 -- Collect old parents for deletion and update the keys of moved parents
1748 -- Collect old parents for deletion and update the keys of moved parents
1960− let moveOrDelete :: forall a. k a -> PatchDMapWithMove.NodeInfo k q a -> MergeSubscribedParentWithMove x k a -> Constant (EventM x (Maybe (EventSubscription x))) a
1749+ let moveOrDelete :: forall a. k a -> PatchDMapWithMove.NodeInfo k (Event x) a -> MergeSubscribedParentWithMove x k a -> Constant (EventM x (Maybe (EventSubscription x))) a
1961 moveOrDelete _ ni parent = Constant $ case getComposeMaybe $ PatchDMapWithMove._nodeInfo_to ni of
1750 moveOrDelete _ ni parent = Constant $ case getComposeMaybe $ PatchDMapWithMove._nodeInfo_to ni of
1962 Nothing -> do
1751 Nothing -> do
1963− oldHeight <- liftIO $ getEventSubscribedHeight $ _eventSubscription_subscribed $
1752+ oldHeight <- liftIO $ getEventSubscribedHeight $ _eventSubscription_subscribed $ _mergeSubscribedParentWithMove_subscription parent
1964− _mergeSubscribedParentWithMove_subscription parent
1965−
1966 liftIO $ modifyIORef heightBagRef $ heightBagRemove oldHeight
1753 liftIO $ modifyIORef heightBagRef $ heightBagRemove oldHeight
1967 return $ Just $ _mergeSubscribedParentWithMove_subscription parent
1754 return $ Just $ _mergeSubscribedParentWithMove_subscription parent
1968 Just toKey -> do
1755 Just toKey -> do
1969 liftIO $ writeIORef (_mergeSubscribedParentWithMove_key parent) $! toKey
1756 liftIO $ writeIORef (_mergeSubscribedParentWithMove_key parent) $! toKey
1970 return Nothing
1757 return Nothing
1971− toDelete <- fmap catMaybes $ mapM (\(_ :=> v) -> getConstant v) $ DMap.toList $
1972− DMap.intersectionWithKey moveOrDelete (unPatchDMapWithMove p) oldParents
1758+ toDelete <- fmap catMaybes $ mapM (\(_ :=> v) -> getConstant v) $ DMap.toList $ DMap.intersectionWithKey moveOrDelete (unPatchDMapWithMove p) oldParents
1973−
1974 return (toDelete, applyAlways p' oldParents)
1759 return (toDelete, applyAlways p' oldParents)
1975− getInitialSubscribers :: MergeInitFunc k v q x (MergeSubscribedParentWithMove x k)
1760+ getInitialSubscribers :: MergeInitFunc k x (MergeSubscribedParentWithMove x k)
1976 getInitialSubscribers initialParents subscriber = do
1761 getInitialSubscribers initialParents subscriber = do
1977 subscribers <- forM (DMap.toList initialParents) $ \(k :=> e) -> do
1762 subscribers <- forM (DMap.toList initialParents) $ \(k :=> e) -> do
1978 keyRef <- liftIO $ newIORef k
1763 keyRef <- liftIO $ newIORef k
1979 let s = subscriber $ liftIO $ readIORef keyRef
1764 let s = subscriber $ liftIO $ readIORef keyRef
1980− (subscription@(EventSubscription _ parentSubd), parentOcc) <- subscribeAndRead (nt e) s
1765+ (subscription@(EventSubscription _ parentSubd), parentOcc) <- subscribeAndRead e s
1981 height <- liftIO $ getEventSubscribedHeight parentSubd
1766 height <- liftIO $ getEventSubscribedHeight parentSubd
1982− return (fmap (k :=>) parentOcc, height, k :=> MergeSubscribedParentWithMove subscription keyRef)
1767+ return (fmap (\x -> k :=> Identity x) parentOcc, height, k :=> MergeSubscribedParentWithMove subscription keyRef)
1983 return ( DMap.fromDistinctAscList $ mapMaybe (\(x, _, _) -> x) subscribers
1768 return ( DMap.fromDistinctAscList $ mapMaybe (\(x, _, _) -> x) subscribers
1984 , fmap (\(_, h, _) -> h) subscribers --TODO: Assert that there's no invalidHeight in here
1769 , fmap (\(_, h, _) -> h) subscribers --TODO: Assert that there's no invalidHeight in here
1985 , DMap.fromDistinctAscList $ map (\(_, _, x) -> x) subscribers
1770 , DMap.fromDistinctAscList $ map (\(_, _, x) -> x) subscribers
1986 )
1771 )
1987−
1988 destroy :: MergeDestroyFunc k (MergeSubscribedParentWithMove x k)
1772 destroy :: MergeDestroyFunc k (MergeSubscribedParentWithMove x k)
1989 destroy s = forM_ (DMap.toList s) $ \(_ :=> MergeSubscribedParentWithMove sub _) -> unsubscribe sub
1773 destroy s = forM_ (DMap.toList s) $ \(_ :=> MergeSubscribedParentWithMove sub _) -> unsubscribe sub
1990
1774
1991−type MergeUpdateFunc k v x p s
1775+type MergeUpdateFunc k x p s
1992− = (forall a. EventM x (k a) -> Subscriber x (v a))
1776+ = (forall a. EventM x (k a) -> Subscriber x a)
1993 -> IORef HeightBag
1777 -> IORef HeightBag
1994 -> DMap k s
1778 -> DMap k s
1995 -> p
1779 -> p
1996 -> EventM x ([EventSubscription x], DMap k s)
1780 -> EventM x ([EventSubscription x], DMap k s)
1997
1781
1998−type MergeGetSubscription x s = forall a. s a -> EventSubscription x
1999−
2000−type MergeInitFunc k v q x s
1782+type MergeInitFunc k x s
2001− = DMap k q
1783+ = DMap k (Event x)
2002− -> (forall a. EventM x (k a) -> Subscriber x (v a))
1784+ -> (forall a. EventM x (k a) -> Subscriber x a)
2003− -> EventM x (DMap k v, [Height], DMap k s)
1785+ -> EventM x (DMap k Identity, [Height], DMap k s)
2004
1786
2005type MergeDestroyFunc k s
1787type MergeDestroyFunc k s
2006 = DMap k s
1788 = DMap k s
2007 -> IO ()
1789 -> IO ()
2008
1790
2009−data Merge x k v s = Merge
1791+data Merge x k s = Merge
2010 { _merge_parentsRef :: {-# UNPACK #-} !(IORef (DMap k s))
1792 { _merge_parentsRef :: {-# UNPACK #-} !(IORef (DMap k s))
2011 , _merge_heightBagRef :: {-# UNPACK #-} !(IORef HeightBag)
1793 , _merge_heightBagRef :: {-# UNPACK #-} !(IORef HeightBag)
2012 , _merge_heightRef :: {-# UNPACK #-} !(IORef Height)
1794 , _merge_heightRef :: {-# UNPACK #-} !(IORef Height)
2013− , _merge_sub :: {-# UNPACK #-} !(Subscriber x (DMap k v))
1795+ , _merge_sub :: {-# UNPACK #-} !(Subscriber x (DMap k Identity))
2014− , _merge_accumRef :: {-# UNPACK #-} !(IORef (DMap k v))
1796+ , _merge_accumRef :: {-# UNPACK #-} !(IORef (DMap k Identity))
2015 }
1797 }
2016
1798
2017−invalidateMergeHeight :: Merge x k v s -> IO ()
1799+invalidateMergeHeight :: Merge x k s -> IO ()
2018invalidateMergeHeight m = invalidateMergeHeight' (_merge_heightRef m) (_merge_sub m)
1800invalidateMergeHeight m = invalidateMergeHeight' (_merge_heightRef m) (_merge_sub m)
2019
1801
2020invalidateMergeHeight' :: IORef Height -> Subscriber x a -> IO ()
1802invalidateMergeHeight' :: IORef Height -> Subscriber x a -> IO ()
2021invalidateMergeHeight' heightRef sub = do
1803invalidateMergeHeight' heightRef sub = do
2022 oldHeight <- readIORef heightRef
1804 oldHeight <- readIORef heightRef
2023− -- If the height used to be valid, it must be invalid now; we should never have *more* heights than we have parents
1805+ when (oldHeight /= invalidHeight) $ do -- If the height used to be valid, it must be invalid now; we should never have *more* heights than we have parents
2024− when (oldHeight /= invalidHeight) $ do
2025 writeIORef heightRef $! invalidHeight
1806 writeIORef heightRef $! invalidHeight
2026 subscriberInvalidateHeight sub oldHeight
1807 subscriberInvalidateHeight sub oldHeight
2027
1808
1809+
2028−revalidateMergeHeight :: Merge x k v s -> IO ()
1810+revalidateMergeHeight :: Merge x k s -> IO ()
2029revalidateMergeHeight m = do
1811revalidateMergeHeight m = do
2030 currentHeight <- readIORef $ _merge_heightRef m
1812 currentHeight <- readIORef $ _merge_heightRef m
2031−
2032− -- revalidateMergeHeight may be called multiple times; perhaps the's a way to finesse it to avoid this check
1813+ when (currentHeight == invalidHeight) $ do -- revalidateMergeHeight may be called multiple times; perhaps the's a way to finesse it to avoid this check
2033− when (currentHeight == invalidHeight) $ do
2034 heights <- readIORef $ _merge_heightBagRef m
1814 heights <- readIORef $ _merge_heightBagRef m
2035 parents <- readIORef $ _merge_parentsRef m
1815 parents <- readIORef $ _merge_parentsRef m
2036 -- When the number of heights in the bag reaches the number of parents, we should have a valid height
1816 -- When the number of heights in the bag reaches the number of parents, we should have a valid height
@@ -2038,53 +1818,44 @@ revalidateMergeHeight m = do
2038 LT -> return ()
1818 LT -> return ()
2039 EQ -> do
1819 EQ -> do
2040 let height = succHeight $ heightBagMax heights
1820 let height = succHeight $ heightBagMax heights
2041− traceInvalidateHeight $ "recalculateSubscriberHeight: height: " <> show height
1821+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: height: " <> show height
2042 writeIORef (_merge_heightRef m) $! height
1822 writeIORef (_merge_heightRef m) $! height
2043 subscriberRecalculateHeight (_merge_sub m) height
1823 subscriberRecalculateHeight (_merge_sub m) height
2044 GT -> error $ "revalidateMergeHeight: more heights (" <> show (heightBagSize heights) <> ") than parents (" <> show (DMap.size parents) <> ") for Merge"
1824 GT -> error $ "revalidateMergeHeight: more heights (" <> show (heightBagSize heights) <> ") than parents (" <> show (DMap.size parents) <> ") for Merge"
2045
1825
2046−scheduleMergeSelf :: HasSpiderTimeline x => Merge x k v s -> Height -> EventM x ()
1826+scheduleMergeSelf :: HasSpiderTimeline x => Merge x k s -> Height -> EventM x ()
2047scheduleMergeSelf m height = scheduleMerge' height (_merge_heightRef m) $ do
1827scheduleMergeSelf m height = scheduleMerge' height (_merge_heightRef m) $ do
2048 vals <- liftIO $ readIORef $ _merge_accumRef m
1828 vals <- liftIO $ readIORef $ _merge_accumRef m
2049− -- Once we're done with this, we can clear it immediately, because if there's a cacheEvent in front of us,
1829+ liftIO $ writeIORef (_merge_accumRef m) $! DMap.empty -- Once we're done with this, we can clear it immediately, because if there's a cacheEvent in front of us, it'll handle subsequent subscribers, and if not, we won't get subsequent subscribers
2050− -- it'll handle subsequent subscribers, and if not, we won't get subsequent subscribers
2051− liftIO $ writeIORef (_merge_accumRef m) $! DMap.empty
2052 --TODO: Assert that m is not empty
1830 --TODO: Assert that m is not empty
2053 subscriberPropagate (_merge_sub m) vals
1831 subscriberPropagate (_merge_sub m) vals
2054
1832
2055−checkCycle :: HasSpiderTimeline x => EventSubscribed x -> EventM x ()
2056−checkCycle subscribed = liftIO $ do
2057− height <- readIORef (eventSubscribedHeightRef subscribed)
2058−
2059− -- currentHeight <- getCurrentHeight
2060− -- when (height <= currentHeight) $ if height /= invalidHeight
2061− -- then do
2062− -- myStack <- liftIO $ whoCreatedIORef undefined --TODO
2063− -- error $ "Height (" ++ show height ++ ") is not greater than current height (" ++ show currentHeight ++ ")\n" ++ unlines (reverse myStack)
2064− -- else liftIO $
2065− when (height == invalidHeight) $
2066−#ifdef DEBUG_CYCLES
2067− do
2068− nodesInvolvedInCycle <- walkInvalidHeightParents subscribed
2069− stacks <- forM nodesInvolvedInCycle whoCreatedEventSubscribed
2070− throwIO (EventLoopException stacks)
2071−#else
2072− throwIO EventLoopException
2073−#endif
2074−
2075−
2076−mergeSubscriber :: forall x k v s a. (HasSpiderTimeline x, GCompare k) => EventSubscribed x -> Merge x k v s -> EventM x (k a) -> Subscriber x (v a)
1833+mergeSubscriber :: forall x k s a. (HasSpiderTimeline x, GCompare k) => Merge x k s -> EventM x (k a) -> Subscriber x a
2077−mergeSubscriber subscribed m getKey = Subscriber
1834+mergeSubscriber m getKey = Subscriber
2078 { subscriberPropagate = \a -> do
1835 { subscriberPropagate = \a -> do
2079 oldM <- liftIO $ readIORef $ _merge_accumRef m
1836 oldM <- liftIO $ readIORef $ _merge_accumRef m
2080 k <- getKey
1837 k <- getKey
2081− let newM = DMap.insertWith (error "Same key fired multiple times for Merge") k a oldM
1838+ let newM = DMap.insertWith (error $ "Same key fired multiple times for Merge") k (Identity a) oldM
2082 tracePropagate (Proxy :: Proxy x) $ " DMap.size oldM = " <> show (DMap.size oldM) <> "; DMap.size newM = " <> show (DMap.size newM)
1839 tracePropagate (Proxy :: Proxy x) $ " DMap.size oldM = " <> show (DMap.size oldM) <> "; DMap.size newM = " <> show (DMap.size newM)
2083 liftIO $ writeIORef (_merge_accumRef m) $! newM
1840 liftIO $ writeIORef (_merge_accumRef m) $! newM
2084 when (DMap.null oldM) $ do -- Only schedule the firing once
1841 when (DMap.null oldM) $ do -- Only schedule the firing once
2085 height <- liftIO $ readIORef $ _merge_heightRef m
1842 height <- liftIO $ readIORef $ _merge_heightRef m
2086− checkCycle subscribed
1843+ --TODO: assertions about height
2087−
1844+ currentHeight <- getCurrentHeight
1845+ when (height <= currentHeight) $ do
1846+ if height /= invalidHeight
1847+ then do
1848+ myStack <- liftIO $ whoCreatedIORef undefined --TODO
1849+ error $ "Height (" ++ show height ++ ") is not greater than current height (" ++ show currentHeight ++ ")\n" ++ unlines (reverse myStack)
1850+ else liftIO $ do
1851+#ifdef DEBUG_CYCLES
1852+ nodesInvolvedInCycle <- walkInvalidHeightParents $ eventSubscribedMerge subscribed
1853+ stacks <- forM nodesInvolvedInCycle $ \(Some.This es) -> whoCreatedEventSubscribed es
1854+ let cycleInfo = ":\n" <> drawForest (listsToForest stacks)
1855+#else
1856+ let cycleInfo = ""
1857+#endif
1858+ error $ "Causality loop found" <> cycleInfo
2088 scheduleMergeSelf m height
1859 scheduleMergeSelf m height
2089 , subscriberInvalidateHeight = \old -> do --TODO: When removing a parent doesn't actually change the height, maybe we can avoid invalidating
1860 , subscriberInvalidateHeight = \old -> do --TODO: When removing a parent doesn't actually change the height, maybe we can avoid invalidating
2090 modifyIORef' (_merge_heightBagRef m) $ heightBagRemove old
1861 modifyIORef' (_merge_heightBagRef m) $ heightBagRemove old
@@ -2095,45 +1866,30 @@ mergeSubscriber subscribed m getKey = Subscriber
2095 }
1866 }
2096
1867
2097--TODO: Be able to run as much of this as possible promptly
1868--TODO: Be able to run as much of this as possible promptly
2098−updateMerge :: (HasSpiderTimeline x, GCompare k) => EventSubscribed x -> Merge x k v s -> MergeUpdateFunc k v x p s -> p -> SomeMergeUpdate x
1869+updateMerge :: (HasSpiderTimeline x, GCompare k) => Merge x k s -> MergeUpdateFunc k x p s -> p -> SomeMergeUpdate x
2099−updateMerge subscribed m updateFunc p = SomeMergeUpdate updateMe (invalidateMergeHeight m) (revalidateMergeHeight m)
1870+updateMerge m updateFunc p = SomeMergeUpdate updateMe (invalidateMergeHeight m) (revalidateMergeHeight m)
2100 where updateMe = do
1871 where updateMe = do
2101 oldParents <- liftIO $ readIORef $ _merge_parentsRef m
1872 oldParents <- liftIO $ readIORef $ _merge_parentsRef m
2102− (subscriptionsToKill, newParents) <- updateFunc (mergeSubscriber subscribed m) (_merge_heightBagRef m) oldParents p
1873+ (subscriptionsToKill, newParents) <- updateFunc (mergeSubscriber m) (_merge_heightBagRef m) oldParents p
2103 liftIO $ writeIORef (_merge_parentsRef m) $! newParents
1874 liftIO $ writeIORef (_merge_parentsRef m) $! newParents
2104 return subscriptionsToKill
1875 return subscriptionsToKill
2105
1876
2106−{-# INLINE mergeGCheap' #-}
1877+{-# INLINE mergeCheap' #-}
2107−mergeGCheap' :: forall k v x p s q. (HasSpiderTimeline x, GCompare k, PatchTarget p ~ DMap k q)
2108− => MergeGetSubscription x s -> MergeInitFunc k v q x s -> MergeUpdateFunc k v x p s -> MergeDestroyFunc k s -> DynamicS x p -> Event x (DMap k v)
1878+mergeCheap' :: forall k x p s. (HasSpiderTimeline x, GCompare k, PatchTarget p ~ DMap k (Event x)) => MergeInitFunc k x s -> MergeUpdateFunc k x p s -> MergeDestroyFunc k s -> Dynamic x p -> Event x (DMap k Identity)
2109−mergeGCheap' getParent getInitialSubscribers updateFunc destroy d = Event $ \sub -> do
1879+mergeCheap' getInitialSubscribers updateFunc destroy d = Event $ \sub -> do
2110 initialParents <- readBehaviorUntracked $ dynamicCurrent d
1880 initialParents <- readBehaviorUntracked $ dynamicCurrent d
2111 accumRef <- liftIO $ newIORef $ error "merge: accumRef not yet initialized"
1881 accumRef <- liftIO $ newIORef $ error "merge: accumRef not yet initialized"
2112 heightRef <- liftIO $ newIORef $ error "merge: heightRef not yet initialized"
1882 heightRef <- liftIO $ newIORef $ error "merge: heightRef not yet initialized"
2113 heightBagRef <- liftIO $ newIORef $ error "merge: heightBagRef not yet initialized"
1883 heightBagRef <- liftIO $ newIORef $ error "merge: heightBagRef not yet initialized"
2114 parentsRef :: IORef (DMap k s) <- liftIO $ newIORef $ error "merge: parentsRef not yet initialized"
1884 parentsRef :: IORef (DMap k s) <- liftIO $ newIORef $ error "merge: parentsRef not yet initialized"
2115− changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
2116−
2117− let subscribed = EventSubscribed
2118− { eventSubscribedHeightRef = heightRef
2119− , eventSubscribedRetained = toAny (parentsRef, changeSubdRef)
2120−#ifdef DEBUG_CYCLES
2121− , eventSubscribedGetParents = do
2122− let getParent' (_ :=> v) = _eventSubscription_subscribed (getParent v)
2123− fmap getParent' . DMap.toList <$> readIORef parentsRef
2124− , eventSubscribedHasOwnHeightRef = False
2125− , eventSubscribedWhoCreated = whoCreatedIORef heightRef
2126−#endif
2127− }
2128−
2129− m = Merge
1885+ let m = Merge
2130 { _merge_parentsRef = parentsRef
1886 { _merge_parentsRef = parentsRef
2131 , _merge_heightBagRef = heightBagRef
1887 , _merge_heightBagRef = heightBagRef
2132 , _merge_heightRef = heightRef
1888 , _merge_heightRef = heightRef
2133 , _merge_sub = sub
1889 , _merge_sub = sub
2134 , _merge_accumRef = accumRef
1890 , _merge_accumRef = accumRef
2135 }
1891 }
2136− (dm, heights, initialParentState) <- getInitialSubscribers initialParents $ mergeSubscriber subscribed m
1892+ (dm, heights, initialParentState) <- getInitialSubscribers initialParents $ mergeSubscriber m
2137 let myHeightBag = heightBagFromList $ filter (/= invalidHeight) heights
1893 let myHeightBag = heightBagFromList $ filter (/= invalidHeight) heights
2138 myHeight = if invalidHeight `elem` heights
1894 myHeight = if invalidHeight `elem` heights
2139 then invalidHeight
1895 then invalidHeight
@@ -2142,57 +1898,50 @@ mergeGCheap' getParent getInitialSubscribers updateFunc destroy d = Event $ \sub
2142 let (occ, accum) = if currentHeight >= myHeight -- If we should have fired by now
1898 let (occ, accum) = if currentHeight >= myHeight -- If we should have fired by now
2143 then (if DMap.null dm then Nothing else Just dm, DMap.empty)
1899 then (if DMap.null dm then Nothing else Just dm, DMap.empty)
2144 else (Nothing, dm)
1900 else (Nothing, dm)
1901+ unless (DMap.null accum) $ do
2145− unless (DMap.null accum) $ scheduleMergeSelf m myHeight
1902+ scheduleMergeSelf m myHeight
2146 liftIO $ writeIORef accumRef $! accum
1903 liftIO $ writeIORef accumRef $! accum
2147 liftIO $ writeIORef heightRef $! myHeight
1904 liftIO $ writeIORef heightRef $! myHeight
2148 liftIO $ writeIORef heightBagRef $! myHeightBag
1905 liftIO $ writeIORef heightBagRef $! myHeightBag
1906+ changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
2149 liftIO $ writeIORef parentsRef $! initialParentState
1907 liftIO $ writeIORef parentsRef $! initialParentState
2150 defer $ SomeMergeInit $ do
1908 defer $ SomeMergeInit $ do
2151− let changeSubscriber = Subscriber
1909+ let s = Subscriber
2152 { subscriberPropagate = \a -> {-# SCC "traverseMergeChange" #-} do
1910 { subscriberPropagate = \a -> {-# SCC "traverseMergeChange" #-} do
2153− tracePropagate (Proxy :: Proxy x) "SubscriberMerge/Change"
1911+ tracePropagate (Proxy :: Proxy x) $ "SubscriberMerge/Change"
2154− defer $ updateMerge subscribed m updateFunc a
1912+ defer $ updateMerge m updateFunc a
2155 , subscriberInvalidateHeight = \_ -> return ()
1913 , subscriberInvalidateHeight = \_ -> return ()
2156 , subscriberRecalculateHeight = \_ -> return ()
1914 , subscriberRecalculateHeight = \_ -> return ()
2157 }
1915 }
2158− (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) changeSubscriber
1916+ (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) s
2159− forM_ change $ \c -> defer $ updateMerge subscribed m updateFunc c
1917+ forM_ change $ \c -> defer $ updateMerge m updateFunc c
2160 -- We explicitly hold on to the unsubscribe function from subscribing to the update event.
1918 -- We explicitly hold on to the unsubscribe function from subscribing to the update event.
2161 -- If we don't do this, there are certain cases where mergeCheap will fail to properly retain
1919 -- If we don't do this, there are certain cases where mergeCheap will fail to properly retain
2162 -- its subscription.
1920 -- its subscription.
2163− liftIO $ writeIORef changeSubdRef (changeSubscriber, changeSubscription)
1921+ liftIO $ writeIORef changeSubdRef (s, changeSubscription)
2164 let unsubscribeAll = destroy =<< readIORef parentsRef
1922 let unsubscribeAll = destroy =<< readIORef parentsRef
1923+ return ( EventSubscription unsubscribeAll $ EventSubscribed heightRef $ toAny (parentsRef, changeSubdRef)
1924+ , occ
1925+ )
2165
1926
2166− return (EventSubscription unsubscribeAll subscribed, occ)
2167−
2168−
2169−mergeInt :: forall x a. (HasSpiderTimeline x) => DynamicS x (PatchIntMap (Event x a)) -> Event x (IntMap a)
1927+mergeInt :: forall x a. (HasSpiderTimeline x) => Dynamic x (PatchIntMap (Event x a)) -> Event x (IntMap a)
2170mergeInt = cacheEvent . mergeIntCheap
1928mergeInt = cacheEvent . mergeIntCheap
2171
1929
2172{-# INLINABLE mergeIntCheap #-}
1930{-# INLINABLE mergeIntCheap #-}
2173−mergeIntCheap :: forall x a. (HasSpiderTimeline x) => DynamicS x (PatchIntMap (Event x a)) -> Event x (IntMap a)
1931+mergeIntCheap :: forall x a. (HasSpiderTimeline x) => Dynamic x (PatchIntMap (Event x a)) -> Event x (IntMap a)
2174mergeIntCheap d = Event $ \sub -> do
1932mergeIntCheap d = Event $ \sub -> do
2175 initialParents <- readBehaviorUntracked $ dynamicCurrent d
1933 initialParents <- readBehaviorUntracked $ dynamicCurrent d
2176 accum <- liftIO $ FastMutableIntMap.newEmpty
1934 accum <- liftIO $ FastMutableIntMap.newEmpty
2177 heightRef <- liftIO $ newIORef zeroHeight
1935 heightRef <- liftIO $ newIORef zeroHeight
2178 heightBagRef <- liftIO $ newIORef heightBagEmpty
1936 heightBagRef <- liftIO $ newIORef heightBagEmpty
2179 parents <- liftIO $ FastMutableIntMap.newEmpty
1937 parents <- liftIO $ FastMutableIntMap.newEmpty
2180− changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
2181− let subscribed = EventSubscribed
2182− { eventSubscribedHeightRef = heightRef
2183− , eventSubscribedRetained = toAny (parents, changeSubdRef)
2184−#ifdef DEBUG_CYCLES
2185− , eventSubscribedGetParents = fmap (_eventSubscription_subscribed . snd) <$> FastMutableIntMap.toList parents
2186− , eventSubscribedHasOwnHeightRef = False
2187− , eventSubscribedWhoCreated = whoCreatedIORef heightRef
2188−#endif
2189− }
2190 let scheduleSelf = do
1938 let scheduleSelf = do
2191 height <- liftIO $ readIORef $ heightRef
1939 height <- liftIO $ readIORef $ heightRef
2192 scheduleMerge' height heightRef $ do
1940 scheduleMerge' height heightRef $ do
2193 vals <- liftIO $ FastMutableIntMap.getFrozenAndClear accum
1941 vals <- liftIO $ FastMutableIntMap.getFrozenAndClear accum
2194 subscriberPropagate sub vals
1942 subscriberPropagate sub vals
1943+ invalidateMyHeight = do
2195− invalidateMyHeight = invalidateMergeHeight' heightRef sub
1944+ invalidateMergeHeight' heightRef sub
2196 recalculateMyHeight = do
1945 recalculateMyHeight = do
2197 currentHeight <- readIORef heightRef
1946 currentHeight <- readIORef heightRef
2198 when (currentHeight == invalidHeight) $ do --TODO: This will almost always be true; can we get rid of this check and just proceed to the next one always?
1947 when (currentHeight == invalidHeight) $ do --TODO: This will almost always be true; can we get rid of this check and just proceed to the next one always?
@@ -2202,14 +1951,12 @@ mergeIntCheap d = Event $ \sub -> do
2202 LT -> return ()
1951 LT -> return ()
2203 EQ -> do
1952 EQ -> do
2204 let height = succHeight $ heightBagMax heights
1953 let height = succHeight $ heightBagMax heights
2205− traceInvalidateHeight $ "recalculateSubscriberHeight: height: " <> show height
1954+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: height: " <> show height
2206 writeIORef heightRef $! height
1955 writeIORef heightRef $! height
2207 subscriberRecalculateHeight sub height
1956 subscriberRecalculateHeight sub height
2208 GT -> error $ "revalidateMergeHeight: more heights (" <> show (heightBagSize heights) <> ") than parents (" <> show numParents <> ") for Merge"
1957 GT -> error $ "revalidateMergeHeight: more heights (" <> show (heightBagSize heights) <> ") than parents (" <> show numParents <> ") for Merge"
2209 mySubscriber k = Subscriber
1958 mySubscriber k = Subscriber
2210 { subscriberPropagate = \a -> do
1959 { subscriberPropagate = \a -> do
2211− checkCycle subscribed
2212−
2213 wasEmpty <- liftIO $ FastMutableIntMap.isEmpty accum
1960 wasEmpty <- liftIO $ FastMutableIntMap.isEmpty accum
2214 liftIO $ FastMutableIntMap.insert accum k a
1961 liftIO $ FastMutableIntMap.insert accum k a
2215 when wasEmpty scheduleSelf
1962 when wasEmpty scheduleSelf
@@ -2243,6 +1990,7 @@ mergeIntCheap d = Event $ \sub -> do
2243 else liftIO $ Just <$> FastMutableIntMap.getFrozenAndClear accum
1990 else liftIO $ Just <$> FastMutableIntMap.getFrozenAndClear accum
2244 else do when (not isEmpty) scheduleSelf -- We have things accumulated, but we shouldn't have fired them yet
1991 else do when (not isEmpty) scheduleSelf -- We have things accumulated, but we shouldn't have fired them yet
2245 return Nothing
1992 return Nothing
1993+ changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
2246 defer $ SomeMergeInit $ do
1994 defer $ SomeMergeInit $ do
2247 let updateMe a = SomeMergeUpdate u invalidateMyHeight recalculateMyHeight
1995 let updateMe a = SomeMergeUpdate u invalidateMyHeight recalculateMyHeight
2248 where
1996 where
@@ -2256,39 +2004,35 @@ mergeIntCheap d = Event $ \sub -> do
2256 oldParents <- liftIO $ FastMutableIntMap.applyPatch parents newSubscriptions
2004 oldParents <- liftIO $ FastMutableIntMap.applyPatch parents newSubscriptions
2257 liftIO $ for_ oldParents $ \oldParent -> do
2005 liftIO $ for_ oldParents $ \oldParent -> do
2258 oldParentHeight <- getEventSubscribedHeight $ _eventSubscription_subscribed oldParent
2006 oldParentHeight <- getEventSubscribedHeight $ _eventSubscription_subscribed oldParent
2259−
2260− print ("updateMe", oldParentHeight)
2261 modifyIORef' heightBagRef $ heightBagRemove oldParentHeight
2007 modifyIORef' heightBagRef $ heightBagRemove oldParentHeight
2262 return $ IntMap.elems oldParents
2008 return $ IntMap.elems oldParents
2263− let changeSubscriber = Subscriber
2009+ let s = Subscriber
2264 { subscriberPropagate = \a -> {-# SCC "traverseMergeChange" #-} do
2010 { subscriberPropagate = \a -> {-# SCC "traverseMergeChange" #-} do
2265 tracePropagate (Proxy :: Proxy x) $ "SubscriberMergeInt/Change"
2011 tracePropagate (Proxy :: Proxy x) $ "SubscriberMergeInt/Change"
2266 defer $ updateMe a
2012 defer $ updateMe a
2267 , subscriberInvalidateHeight = \_ -> return ()
2013 , subscriberInvalidateHeight = \_ -> return ()
2268 , subscriberRecalculateHeight = \_ -> return ()
2014 , subscriberRecalculateHeight = \_ -> return ()
2269 }
2015 }
2270− (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) changeSubscriber
2016+ (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) s
2271 forM_ change $ \c -> defer $ updateMe c
2017 forM_ change $ \c -> defer $ updateMe c
2272 -- We explicitly hold on to the unsubscribe function from subscribing to the update event.
2018 -- We explicitly hold on to the unsubscribe function from subscribing to the update event.
2273 -- If we don't do this, there are certain cases where mergeCheap will fail to properly retain
2019 -- If we don't do this, there are certain cases where mergeCheap will fail to properly retain
2274 -- its subscription.
2020 -- its subscription.
2275− liftIO $ writeIORef changeSubdRef (changeSubscriber, changeSubscription)
2021+ liftIO $ writeIORef changeSubdRef (s, changeSubscription)
2276 let unsubscribeAll = traverse_ unsubscribe =<< FastMutableIntMap.getFrozenAndClear parents
2022 let unsubscribeAll = traverse_ unsubscribe =<< FastMutableIntMap.getFrozenAndClear parents
2277−
2278−
2279− return (EventSubscription unsubscribeAll subscribed, occ)
2023+ return ( EventSubscription unsubscribeAll $ EventSubscribed heightRef $ toAny (parents, changeSubdRef)
2024+ , occ
2025+ )
2280
2026
2281newtype EventSelector x k = EventSelector { select :: forall a. k a -> Event x a }
2027newtype EventSelector x k = EventSelector { select :: forall a. k a -> Event x a }
2282−newtype EventSelectorG x k v = EventSelectorG { selectG :: forall a. k a -> Event x (v a) }
2283
2028
2284−fanG :: (HasSpiderTimeline x, GCompare k) => Event x (DMap k v) -> EventSelectorG x k v
2029+fan :: (HasSpiderTimeline x, GCompare k) => Event x (DMap k Identity) -> EventSelector x k
2285−fanG e = unsafePerformIO $ do
2030+fan e =
2286− ref <- newIORef Nothing
2287 let f = Fan
2031 let f = Fan
2288 { fanParent = e
2032 { fanParent = e
2289− , fanSubscribed = ref
2033+ , fanSubscribed = unsafeNewIORef e Nothing
2290 }
2034 }
2291− pure $ EventSelectorG $ \k -> eventFan k f
2035+ in EventSelector $ \k -> eventFan k f
2292
2036
2293runHoldInits :: HasSpiderTimeline x => IORef [SomeHoldInit x] -> IORef [SomeDynInit x] -> IORef [SomeMergeInit x] -> EventM x ()
2037runHoldInits :: HasSpiderTimeline x => IORef [SomeHoldInit x] -> IORef [SomeDynInit x] -> IORef [SomeMergeInit x] -> EventM x ()
2294runHoldInits holdInitRef dynInitRef mergeInitRef = do
2038runHoldInits holdInitRef dynInitRef mergeInitRef = do
@@ -2342,36 +2086,36 @@ clearEventEnv (EventEnv toAssignRef holdInitRef dynInitRef mergeUpdateRef mergeI
2342-- | Run an event action outside of a frame
2086-- | Run an event action outside of a frame
2343runFrame :: forall x a. HasSpiderTimeline x => EventM x a -> SpiderHost x a --TODO: This function also needs to hold the mutex
2087runFrame :: forall x a. HasSpiderTimeline x => EventM x a -> SpiderHost x a --TODO: This function also needs to hold the mutex
2344runFrame a = SpiderHost $ do
2088runFrame a = SpiderHost $ do
2345− let env = _spiderTimeline_eventEnv $ unSTE (spiderTimeline :: SpiderTimelineEnv x)
2089+ let env = _spiderTimeline_eventEnv (spiderTimeline :: SpiderTimelineEnv x)
2346 let go = do
2090 let go = do
2347 result <- a
2091 result <- a
2348 runHoldInits (eventEnvHoldInits env) (eventEnvDynInits env) (eventEnvMergeInits env) -- This must happen before doing the assignments, in case subscribing a Hold causes existing Holds to be read by the newly-propagated events
2092 runHoldInits (eventEnvHoldInits env) (eventEnvDynInits env) (eventEnvMergeInits env) -- This must happen before doing the assignments, in case subscribing a Hold causes existing Holds to be read by the newly-propagated events
2349 return result
2093 return result
2350 result <- runEventM go
2094 result <- runEventM go
2351 toClear <- readIORef $ eventEnvClears env
2095 toClear <- readIORef $ eventEnvClears env
2352− forM_ toClear $ \(Some (Clear ref)) -> {-# SCC "clear" #-} writeIORef ref Nothing
2096+ forM_ toClear $ \(SomeClear ref) -> {-# SCC "clear" #-} writeIORef ref Nothing
2353 toClearInt <- readIORef $ eventEnvIntClears env
2097 toClearInt <- readIORef $ eventEnvIntClears env
2354− forM_ toClearInt $ \(Some (IntClear ref)) -> {-# SCC "intClear" #-} writeIORef ref $! IntMap.empty
2098+ forM_ toClearInt $ \(SomeIntClear ref) -> {-# SCC "intClear" #-} writeIORef ref $! IntMap.empty
2355 toClearRoot <- readIORef $ eventEnvRootClears env
2099 toClearRoot <- readIORef $ eventEnvRootClears env
2356− forM_ toClearRoot $ \(Some (RootClear ref)) -> {-# SCC "rootClear" #-} writeIORef ref $! DMap.empty
2100+ forM_ toClearRoot $ \(SomeRootClear ref) -> {-# SCC "rootClear" #-} writeIORef ref $! DMap.empty
2357 toAssign <- readIORef $ eventEnvAssignments env
2101 toAssign <- readIORef $ eventEnvAssignments env
2358 toReconnectRef <- newIORef []
2102 toReconnectRef <- newIORef []
2359 coincidenceInfos <- readIORef $ eventEnvResetCoincidences env
2103 coincidenceInfos <- readIORef $ eventEnvResetCoincidences env
2360 forM_ toAssign $ \(SomeAssignment vRef iRef v) -> {-# SCC "assignment" #-} do
2104 forM_ toAssign $ \(SomeAssignment vRef iRef v) -> {-# SCC "assignment" #-} do
2361 writeIORef vRef v
2105 writeIORef vRef v
2362− traceInvalidate $ "Invalidating Hold"
2106+ when debugInvalidate $ putStrLn $ "Invalidating Hold"
2363 writeIORef iRef =<< evaluate =<< invalidate toReconnectRef =<< readIORef iRef
2107 writeIORef iRef =<< evaluate =<< invalidate toReconnectRef =<< readIORef iRef
2364 mergeUpdates <- readIORef $ eventEnvMergeUpdates env
2108 mergeUpdates <- readIORef $ eventEnvMergeUpdates env
2365 writeIORef (eventEnvMergeUpdates env) []
2109 writeIORef (eventEnvMergeUpdates env) []
2366− tracePropagate (Proxy::Proxy x) $ "Updating merges"
2110+ when debugPropagate $ putStrLn "Updating merges"
2367 mergeSubscriptionsToKill <- runEventM $ concat <$> mapM _someMergeUpdate_update mergeUpdates
2111 mergeSubscriptionsToKill <- runEventM $ concat <$> mapM _someMergeUpdate_update mergeUpdates
2368− tracePropagate (Proxy::Proxy x) $ "Updating merges done"
2112+ when debugPropagate $ putStrLn "Updating merges done"
2369 toReconnect <- readIORef toReconnectRef
2113 toReconnect <- readIORef toReconnectRef
2370 clearEventEnv env
2114 clearEventEnv env
2371 switchSubscriptionsToKill <- forM toReconnect $ \(SomeSwitchSubscribed subscribed) -> {-# SCC "switchSubscribed" #-} do
2115 switchSubscriptionsToKill <- forM toReconnect $ \(SomeSwitchSubscribed subscribed) -> {-# SCC "switchSubscribed" #-} do
2372 oldSubscription <- readIORef $ switchSubscribedCurrentParent subscribed
2116 oldSubscription <- readIORef $ switchSubscribedCurrentParent subscribed
2373 wi <- readIORef $ switchSubscribedOwnWeakInvalidator subscribed
2117 wi <- readIORef $ switchSubscribedOwnWeakInvalidator subscribed
2374− traceInvalidate $ "Finalizing invalidator for Switch" <> showNodeId subscribed
2118+ when debugInvalidate $ putStrLn $ "Finalizing invalidator for Switch" <> showNodeId subscribed
2375 finalize wi
2119 finalize wi
2376 i <- evaluate $ switchSubscribedOwnInvalidator subscribed
2120 i <- evaluate $ switchSubscribedOwnInvalidator subscribed
2377 wi' <- mkWeakPtrWithDebug i "wi'"
2121 wi' <- mkWeakPtrWithDebug i "wi'"
@@ -2385,7 +2129,7 @@ runFrame a = SpiderHost $ do
2385 subscription <- unSpiderHost $ runFrame $ {-# SCC "subscribeSwitch" #-} subscribe e sub --TODO: Assert that the event isn't firing --TODO: This should not loop because none of the events should be firing, but still, it is inefficient
2129 subscription <- unSpiderHost $ runFrame $ {-# SCC "subscribeSwitch" #-} subscribe e sub --TODO: Assert that the event isn't firing --TODO: This should not loop because none of the events should be firing, but still, it is inefficient
2386 {-
2130 {-
2387 stackTrace <- liftIO $ fmap renderStack $ ccsToStrings =<< (getCCSOf $! switchSubscribedParent subscribed)
2131 stackTrace <- liftIO $ fmap renderStack $ ccsToStrings =<< (getCCSOf $! switchSubscribedParent subscribed)
2388− liftIO $ debugStrLn $ (++stackTrace) $ "subd' subscribed to " ++ case e of
2132+ liftIO $ putStrLn $ (++stackTrace) $ "subd' subscribed to " ++ case e of
2389 EventRoot _ -> "EventRoot"
2133 EventRoot _ -> "EventRoot"
2390 EventNever -> "EventNever"
2134 EventNever -> "EventNever"
2391 _ -> "something else"
2135 _ -> "something else"
@@ -2400,7 +2144,7 @@ runFrame a = SpiderHost $ do
2400 myHeight <- readIORef $ switchSubscribedHeight subscribed
2144 myHeight <- readIORef $ switchSubscribedHeight subscribed
2401 when (parentHeight /= myHeight) $ do
2145 when (parentHeight /= myHeight) $ do
2402 writeIORef (switchSubscribedHeight subscribed) $! invalidHeight
2146 writeIORef (switchSubscribedHeight subscribed) $! invalidHeight
2403− WeakBag.traverse_ (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight myHeight
2147+ WeakBag.traverse (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight myHeight
2404 mapM_ _someMergeUpdate_invalidateHeight mergeUpdates --TODO: In addition to when the patch is completely empty, we should also not run this if it has some Nothing values, but none of them have actually had any effect; potentially, we could even check for Just values with no effect (e.g. by comparing their IORefs and ignoring them if they are unchanged); actually, we could just check if the new height is different
2148 mapM_ _someMergeUpdate_invalidateHeight mergeUpdates --TODO: In addition to when the patch is completely empty, we should also not run this if it has some Nothing values, but none of them have actually had any effect; potentially, we could even check for Just values with no effect (e.g. by comparing their IORefs and ignoring them if they are unchanged); actually, we could just check if the new height is different
2405 forM_ coincidenceInfos $ \(SomeResetCoincidence subscription mcs) -> do
2149 forM_ coincidenceInfos $ \(SomeResetCoincidence subscription mcs) -> do
2406 unsubscribe subscription
2150 unsubscribe subscription
@@ -2441,7 +2185,7 @@ invalidateCoincidenceHeight subscribed = do
2441 oldHeight <- readIORef $ coincidenceSubscribedHeight subscribed
2185 oldHeight <- readIORef $ coincidenceSubscribedHeight subscribed
2442 when (oldHeight /= invalidHeight) $ do
2186 when (oldHeight /= invalidHeight) $ do
2443 writeIORef (coincidenceSubscribedHeight subscribed) $! invalidHeight
2187 writeIORef (coincidenceSubscribedHeight subscribed) $! invalidHeight
2444− WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
2188+ WeakBag.traverse (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
2445
2189
2446updateSwitchHeight :: Height -> SwitchSubscribed x a -> IO ()
2190updateSwitchHeight :: Height -> SwitchSubscribed x a -> IO ()
2447updateSwitchHeight new subscribed = do
2191updateSwitchHeight new subscribed = do
@@ -2449,7 +2193,7 @@ updateSwitchHeight new subscribed = do
2449 when (oldHeight == invalidHeight) $ do --TODO: This 'when' should probably be an assertion
2193 when (oldHeight == invalidHeight) $ do --TODO: This 'when' should probably be an assertion
2450 when (new /= invalidHeight) $ do --TODO: This 'when' should probably be an assertion
2194 when (new /= invalidHeight) $ do --TODO: This 'when' should probably be an assertion
2451 writeIORef (switchSubscribedHeight subscribed) $! new
2195 writeIORef (switchSubscribedHeight subscribed) $! new
2452− WeakBag.traverse_ (switchSubscribedSubscribers subscribed) $ recalculateSubscriberHeight new
2196+ WeakBag.traverse (switchSubscribedSubscribers subscribed) $ recalculateSubscriberHeight new
2453
2197
2454recalculateCoincidenceHeight :: CoincidenceSubscribed x a -> IO ()
2198recalculateCoincidenceHeight :: CoincidenceSubscribed x a -> IO ()
2455recalculateCoincidenceHeight subscribed = do
2199recalculateCoincidenceHeight subscribed = do
@@ -2458,7 +2202,7 @@ recalculateCoincidenceHeight subscribed = do
2458 height <- calculateCoincidenceHeight subscribed
2202 height <- calculateCoincidenceHeight subscribed
2459 when (height /= invalidHeight) $ do
2203 when (height /= invalidHeight) $ do
2460 writeIORef (coincidenceSubscribedHeight subscribed) $! height
2204 writeIORef (coincidenceSubscribedHeight subscribed) $! height
2461− WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ recalculateSubscriberHeight height
2205+ WeakBag.traverse (coincidenceSubscribedSubscribers subscribed) $ recalculateSubscriberHeight height
2462
2206
2463calculateSwitchHeight :: SwitchSubscribed x a -> IO Height
2207calculateSwitchHeight :: SwitchSubscribed x a -> IO Height
2464calculateSwitchHeight subscribed = getEventSubscribedHeight . _eventSubscription_subscribed =<< readIORef (switchSubscribedCurrentParent subscribed)
2208calculateSwitchHeight subscribed = getEventSubscribedHeight . _eventSubscription_subscribed =<< readIORef (switchSubscribedCurrentParent subscribed)
@@ -2520,8 +2264,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Event
2520 {-# INLINABLE headE #-}
2264 {-# INLINABLE headE #-}
2521 headE = R.slowHeadE
2265 headE = R.slowHeadE
2522-- headE (SpiderEvent e) = SpiderEvent <$> Reflex.Spider.Internal.headE e
2266-- headE (SpiderEvent e) = SpiderEvent <$> Reflex.Spider.Internal.headE e
2523− {-# INLINABLE now #-}
2524− now = nowSpiderEventM
2525
2267
2526instance Reflex.Class.MonadSample (SpiderTimeline x) (SpiderPullM x) where
2268instance Reflex.Class.MonadSample (SpiderTimeline x) (SpiderPullM x) where
2527 {-# INLINABLE sample #-}
2269 {-# INLINABLE sample #-}
@@ -2543,9 +2285,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Spide
2543 {-# INLINABLE headE #-}
2285 {-# INLINABLE headE #-}
2544 headE = R.slowHeadE
2286 headE = R.slowHeadE
2545-- headE (SpiderEvent e) = SpiderPushM $ SpiderEvent <$> Reflex.Spider.Internal.headE e
2287-- headE (SpiderEvent e) = SpiderPushM $ SpiderEvent <$> Reflex.Spider.Internal.headE e
2546− {-# INLINABLE now #-}
2547− now = SpiderPushM nowSpiderEventM
2548−
2549
2288
2550instance HasSpiderTimeline x => Monad (Reflex.Class.Dynamic (SpiderTimeline x)) where
2289instance HasSpiderTimeline x => Monad (Reflex.Class.Dynamic (SpiderTimeline x)) where
2551 {-# INLINE return #-}
2290 {-# INLINE return #-}
@@ -2554,13 +2293,11 @@ instance HasSpiderTimeline x => Monad (Reflex.Class.Dynamic (SpiderTimeline x))
2554 x >>= f = SpiderDynamic $ dynamicDynIdentity $ newJoinDyn $ newMapDyn (unSpiderDynamic . f) $ unSpiderDynamic x
2293 x >>= f = SpiderDynamic $ dynamicDynIdentity $ newJoinDyn $ newMapDyn (unSpiderDynamic . f) $ unSpiderDynamic x
2555 {-# INLINE (>>) #-}
2294 {-# INLINE (>>) #-}
2556 (>>) = (*>)
2295 (>>) = (*>)
2557−#if !MIN_VERSION_base(4,13,0)
2558 {-# INLINE fail #-}
2296 {-# INLINE fail #-}
2559 fail _ = error "Dynamic does not support 'fail'"
2297 fail _ = error "Dynamic does not support 'fail'"
2560−#endif
2561
2298
2562{-# INLINABLE newJoinDyn #-}
2299{-# INLINABLE newJoinDyn #-}
2563−newJoinDyn :: HasSpiderTimeline x => DynamicS x (Identity (DynamicS x (Identity a))) -> Reflex.Spider.Internal.Dyn x (Identity a)
2300+newJoinDyn :: HasSpiderTimeline x => Reflex.Spider.Internal.Dynamic x (Identity (Reflex.Spider.Internal.Dynamic x (Identity a))) -> Reflex.Spider.Internal.Dyn x (Identity a)
2564newJoinDyn d =
2301newJoinDyn d =
2565 let readV0 = readBehaviorTracked . dynamicCurrent =<< readBehaviorTracked (dynamicCurrent d)
2302 let readV0 = readBehaviorTracked . dynamicCurrent =<< readBehaviorTracked (dynamicCurrent d)
2566 eOuter = Reflex.Spider.Internal.push (fmap (Just . Identity) . readBehaviorUntracked . dynamicCurrent . runIdentity) $ dynamicUpdated d
2303 eOuter = Reflex.Spider.Internal.push (fmap (Just . Identity) . readBehaviorUntracked . dynamicCurrent . runIdentity) $ dynamicUpdated d
@@ -2609,9 +2346,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Spide
2609 buildDynamic getV0 e = runFrame . runSpiderHostFrame $ Reflex.Class.buildDynamic getV0 e
2346 buildDynamic getV0 e = runFrame . runSpiderHostFrame $ Reflex.Class.buildDynamic getV0 e
2610 {-# INLINABLE headE #-}
2347 {-# INLINABLE headE #-}
2611 headE e = runFrame . runSpiderHostFrame $ Reflex.Class.headE e
2348 headE e = runFrame . runSpiderHostFrame $ Reflex.Class.headE e
2612− {-# INLINABLE now #-}
2613− now = runFrame . runSpiderHostFrame $ Reflex.Class.now
2614−
2615
2349
2616instance HasSpiderTimeline x => Reflex.Class.MonadSample (SpiderTimeline x) (SpiderHostFrame x) where
2350instance HasSpiderTimeline x => Reflex.Class.MonadSample (SpiderTimeline x) (SpiderHostFrame x) where
2617 sample = SpiderHostFrame . readBehaviorUntracked . unSpiderBehavior --TODO: This can cause problems with laziness, so we should get rid of it if we can
2351 sample = SpiderHostFrame . readBehaviorUntracked . unSpiderBehavior --TODO: This can cause problems with laziness, so we should get rid of it if we can
@@ -2628,8 +2362,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Spide
2628 {-# INLINABLE headE #-}
2362 {-# INLINABLE headE #-}
2629 headE = R.slowHeadE
2363 headE = R.slowHeadE
2630-- headE (SpiderEvent e) = SpiderHostFrame $ SpiderEvent <$> Reflex.Spider.Internal.headE e
2364-- headE (SpiderEvent e) = SpiderHostFrame $ SpiderEvent <$> Reflex.Spider.Internal.headE e
2631− {-# INLINABLE now #-}
2632− now = SpiderHostFrame Reflex.Class.now
2633
2365
2634instance HasSpiderTimeline x => Reflex.Class.MonadSample (SpiderTimeline x) (SpiderHost x) where
2366instance HasSpiderTimeline x => Reflex.Class.MonadSample (SpiderTimeline x) (SpiderHost x) where
2635 {-# INLINABLE sample #-}
2367 {-# INLINABLE sample #-}
@@ -2650,8 +2382,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Refle
2650 buildDynamic getV0 e = Reflex.Spider.Internal.ReadPhase $ Reflex.Class.buildDynamic getV0 e
2382 buildDynamic getV0 e = Reflex.Spider.Internal.ReadPhase $ Reflex.Class.buildDynamic getV0 e
2651 {-# INLINABLE headE #-}
2383 {-# INLINABLE headE #-}
2652 headE e = Reflex.Spider.Internal.ReadPhase $ Reflex.Class.headE e
2384 headE e = Reflex.Spider.Internal.ReadPhase $ Reflex.Class.headE e
2653− {-# INLINABLE now #-}
2654− now = Reflex.Spider.Internal.ReadPhase Reflex.Class.now
2655
2385
2656--------------------------------------------------------------------------------
2386--------------------------------------------------------------------------------
2657-- Deprecated items
2387-- Deprecated items
@@ -2689,13 +2419,13 @@ instance HasSpiderTimeline x => Reflex.Host.Class.MonadReadEvent (SpiderTimeline
2689 touch h
2419 touch h
2690 return result
2420 return result
2691
2421
2692−instance HasSpiderTimeline x => Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHost x) where
2422+instance Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHost x) where
2693 newEventWithTrigger = SpiderHost . fmap SpiderEvent . newEventWithTriggerIO
2423 newEventWithTrigger = SpiderHost . fmap SpiderEvent . newEventWithTriggerIO
2694 newFanEventWithTrigger f = SpiderHost $ do
2424 newFanEventWithTrigger f = SpiderHost $ do
2695 es <- newFanEventWithTriggerIO f
2425 es <- newFanEventWithTriggerIO f
2696 return $ Reflex.Class.EventSelector $ SpiderEvent . Reflex.Spider.Internal.select es
2426 return $ Reflex.Class.EventSelector $ SpiderEvent . Reflex.Spider.Internal.select es
2697
2427
2698−instance HasSpiderTimeline x => Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHostFrame x) where
2428+instance Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHostFrame x) where
2699 newEventWithTrigger = SpiderHostFrame . EventM . liftIO . fmap SpiderEvent . newEventWithTriggerIO
2429 newEventWithTrigger = SpiderHostFrame . EventM . liftIO . fmap SpiderEvent . newEventWithTriggerIO
2700 newFanEventWithTrigger f = SpiderHostFrame $ EventM $ liftIO $ do
2430 newFanEventWithTrigger f = SpiderHostFrame $ EventM $ liftIO $ do
2701 es <- newFanEventWithTriggerIO f
2431 es <- newFanEventWithTriggerIO f
@@ -2717,7 +2447,7 @@ unsafeNewSpiderTimelineEnv = do
2717#ifdef DEBUG
2447#ifdef DEBUG
2718 depthRef <- newIORef 0
2448 depthRef <- newIORef 0
2719#endif
2449#endif
2720− return $ STE $ SpiderTimelineEnv
2450+ return $ SpiderTimelineEnv
2721 { _spiderTimeline_lock = lock
2451 { _spiderTimeline_lock = lock
2722 , _spiderTimeline_eventEnv = env
2452 , _spiderTimeline_eventEnv = env
2723#ifdef DEBUG
2453#ifdef DEBUG
@@ -2727,19 +2457,19 @@ unsafeNewSpiderTimelineEnv = do
2727
2457
2728-- | Create a new SpiderTimelineEnv
2458-- | Create a new SpiderTimelineEnv
2729newSpiderTimeline :: IO (Some SpiderTimelineEnv)
2459newSpiderTimeline :: IO (Some SpiderTimelineEnv)
2730−newSpiderTimeline = withSpiderTimeline (pure . Some)
2460+newSpiderTimeline = withSpiderTimeline (pure . Some.This)
2731
2461
2732−data LocalSpiderTimeline (x :: Type) s
2462+data LocalSpiderTimeline x s
2733
2463
2734instance Reifies s (SpiderTimelineEnv x) =>
2464instance Reifies s (SpiderTimelineEnv x) =>
2735 HasSpiderTimeline (LocalSpiderTimeline x s) where
2465 HasSpiderTimeline (LocalSpiderTimeline x s) where
2736− spiderTimeline = localSpiderTimeline Proxy $ reflect (Proxy :: Proxy s)
2466+ spiderTimeline = localSpiderTimeline (Proxy :: Proxy s) $ reflect (Proxy :: Proxy s)
2737
2467
2738localSpiderTimeline
2468localSpiderTimeline
2739− :: proxy s
2469+ :: Proxy s
2740 -> SpiderTimelineEnv x
2470 -> SpiderTimelineEnv x
2741 -> SpiderTimelineEnv (LocalSpiderTimeline x s)
2471 -> SpiderTimelineEnv (LocalSpiderTimeline x s)
2742−localSpiderTimeline _ = coerce
2472+localSpiderTimeline _ = unsafeCoerce
2743
2473
2744-- | Pass a new timeline to the given function.
2474-- | Pass a new timeline to the given function.
2745withSpiderTimeline :: (forall x. HasSpiderTimeline x => SpiderTimelineEnv x -> IO r) -> IO r
2475withSpiderTimeline :: (forall x. HasSpiderTimeline x => SpiderTimelineEnv x -> IO r) -> IO r
@@ -2747,18 +2477,18 @@ withSpiderTimeline k = do
2747 env <- unsafeNewSpiderTimelineEnv
2477 env <- unsafeNewSpiderTimelineEnv
2748 reify env $ \s -> k $ localSpiderTimeline s env
2478 reify env $ \s -> k $ localSpiderTimeline s env
2749
2479
2750−newtype SpiderPullM (x :: Type) a = SpiderPullM (BehaviorM x a) deriving (Functor, Applicative, Monad, MonadIO, MonadFix)
2480+newtype SpiderPullM x a = SpiderPullM (BehaviorM x a) deriving (Functor, Applicative, Monad, MonadIO, MonadFix)
2751
2481
2752type ComputeM = EventM
2482type ComputeM = EventM
2753
2483
2754−newtype SpiderPushM (x :: Type) a = SpiderPushM (ComputeM x a) deriving (Functor, Applicative, Monad, MonadIO, MonadFix)
2484+newtype SpiderPushM x a = SpiderPushM (ComputeM x a) deriving (Functor, Applicative, Monad, MonadIO, MonadFix)
2755
2485
2756instance HasSpiderTimeline x => R.Reflex (SpiderTimeline x) where
2486instance HasSpiderTimeline x => R.Reflex (SpiderTimeline x) where
2757 {-# SPECIALIZE instance R.Reflex (SpiderTimeline Global) #-}
2487 {-# SPECIALIZE instance R.Reflex (SpiderTimeline Global) #-}
2758 newtype Behavior (SpiderTimeline x) a = SpiderBehavior { unSpiderBehavior :: Behavior x a }
2488 newtype Behavior (SpiderTimeline x) a = SpiderBehavior { unSpiderBehavior :: Behavior x a }
2759 newtype Event (SpiderTimeline x) a = SpiderEvent { unSpiderEvent :: Event x a }
2489 newtype Event (SpiderTimeline x) a = SpiderEvent { unSpiderEvent :: Event x a }
2760− newtype Dynamic (SpiderTimeline x) a = SpiderDynamic { unSpiderDynamic :: DynamicS x (Identity a) } -- deriving (Functor, Applicative, Monad)
2490+ newtype Dynamic (SpiderTimeline x) a = SpiderDynamic { unSpiderDynamic :: Dynamic x (Identity a) } -- deriving (Functor, Applicative, Monad)
2761− newtype Incremental (SpiderTimeline x) p = SpiderIncremental { unSpiderIncremental :: DynamicS x p }
2491+ newtype Incremental (SpiderTimeline x) p = SpiderIncremental { unSpiderIncremental :: Dynamic x p }
2762 type PullM (SpiderTimeline x) = SpiderPullM x
2492 type PullM (SpiderTimeline x) = SpiderPullM x
2763 type PushM (SpiderTimeline x) = SpiderPushM x
2493 type PushM (SpiderTimeline x) = SpiderPushM x
2764 {-# INLINABLE never #-}
2494 {-# INLINABLE never #-}
@@ -2771,15 +2501,10 @@ instance HasSpiderTimeline x => R.Reflex (SpiderTimeline x) where
2771 pushCheap f = SpiderEvent . pushCheap (coerce f) . unSpiderEvent
2501 pushCheap f = SpiderEvent . pushCheap (coerce f) . unSpiderEvent
2772 {-# INLINABLE pull #-}
2502 {-# INLINABLE pull #-}
2773 pull = SpiderBehavior . pull . coerce
2503 pull = SpiderBehavior . pull . coerce
2774− {-# INLINABLE fanG #-}
2504+ {-# INLINABLE merge #-}
2775− fanG e = R.EventSelectorG $ SpiderEvent . selectG (fanG (unSpiderEvent e))
2505+ merge = SpiderEvent . merge . dynamicConst . (coerce :: DMap k (R.Event (SpiderTimeline x)) -> DMap k (Event x))
2776− {-# INLINABLE mergeG #-}
2506+ {-# INLINABLE fan #-}
2777− mergeG
2507+ fan e = R.EventSelector $ SpiderEvent . select (fan (unSpiderEvent e))
2778− :: forall k2 (k :: k2 -> *) q (v :: k2 -> *). GCompare k
2779− => (forall a. q a -> R.Event (SpiderTimeline x) (v a))
2780− -> DMap k q
2781− -> R.Event (SpiderTimeline x) (DMap k v)
2782− mergeG nt = SpiderEvent . mergeG (unSpiderEvent #. nt) . dynamicConst
2783 {-# INLINABLE switch #-}
2508 {-# INLINABLE switch #-}
2784 switch = SpiderEvent . switch . (coerce :: Behavior x (R.Event (SpiderTimeline x) a) -> Behavior x (Event x a)) . unSpiderBehavior
2509 switch = SpiderEvent . switch . (coerce :: Behavior x (R.Event (SpiderTimeline x) a) -> Behavior x (Event x a)) . unSpiderBehavior
2785 {-# INLINABLE coincidence #-}
2510 {-# INLINABLE coincidence #-}
@@ -2787,15 +2512,15 @@ instance HasSpiderTimeline x => R.Reflex (SpiderTimeline x) where
2787 {-# INLINABLE current #-}
2512 {-# INLINABLE current #-}
2788 current = SpiderBehavior . dynamicCurrent . unSpiderDynamic
2513 current = SpiderBehavior . dynamicCurrent . unSpiderDynamic
2789 {-# INLINABLE updated #-}
2514 {-# INLINABLE updated #-}
2790− updated = SpiderEvent #. dynamicUpdated .# fmap coerce . unSpiderDynamic
2515+ updated = coerce $ SpiderEvent . dynamicUpdated . unSpiderDynamic
2791 {-# INLINABLE unsafeBuildDynamic #-}
2516 {-# INLINABLE unsafeBuildDynamic #-}
2792 unsafeBuildDynamic readV0 v' = SpiderDynamic $ dynamicDynIdentity $ unsafeBuildDynamic (coerce readV0) $ coerce $ unSpiderEvent v'
2517 unsafeBuildDynamic readV0 v' = SpiderDynamic $ dynamicDynIdentity $ unsafeBuildDynamic (coerce readV0) $ coerce $ unSpiderEvent v'
2793 {-# INLINABLE unsafeBuildIncremental #-}
2518 {-# INLINABLE unsafeBuildIncremental #-}
2794 unsafeBuildIncremental readV0 dv = SpiderIncremental $ dynamicDyn $ unsafeBuildDynamic (coerce readV0) $ unSpiderEvent dv
2519 unsafeBuildIncremental readV0 dv = SpiderIncremental $ dynamicDyn $ unsafeBuildDynamic (coerce readV0) $ unSpiderEvent dv
2795− {-# INLINABLE mergeIncrementalG #-}
2520+ {-# INLINABLE mergeIncremental #-}
2796− mergeIncrementalG nt = SpiderEvent #. mergeG (coerce #. nt) .# unSpiderIncremental
2521+ mergeIncremental = SpiderEvent . merge . (unsafeCoerce :: Dynamic x (PatchDMap k (R.Event (SpiderTimeline x))) -> Dynamic x (PatchDMap k (Event x))) . unSpiderIncremental
2797− {-# INLINABLE mergeIncrementalWithMoveG #-}
2522+ {-# INLINABLE mergeIncrementalWithMove #-}
2798− mergeIncrementalWithMoveG nt = SpiderEvent #. mergeWithMove (coerce #. nt) .# unSpiderIncremental
2523+ mergeIncrementalWithMove = SpiderEvent . mergeWithMove . (unsafeCoerce :: Dynamic x (PatchDMapWithMove k (R.Event (SpiderTimeline x))) -> Dynamic x (PatchDMapWithMove k (Event x))) . unSpiderIncremental
2799 {-# INLINABLE currentIncremental #-}
2524 {-# INLINABLE currentIncremental #-}
2800 currentIncremental = SpiderBehavior . dynamicCurrent . unSpiderIncremental
2525 currentIncremental = SpiderBehavior . dynamicCurrent . unSpiderIncremental
2801 {-# INLINABLE updatedIncremental #-}
2526 {-# INLINABLE updatedIncremental #-}
@@ -2806,10 +2531,9 @@ instance HasSpiderTimeline x => R.Reflex (SpiderTimeline x) where
2806 return $ Identity <$> apply p c --TODO: Avoid the redundant 'apply'
2531 return $ Identity <$> apply p c --TODO: Avoid the redundant 'apply'
2807 eventCoercion Coercion = Coercion
2532 eventCoercion Coercion = Coercion
2808 behaviorCoercion Coercion = Coercion
2533 behaviorCoercion Coercion = Coercion
2809− dynamicCoercion Coercion = Coercion
2534+ dynamicCoercion = unsafeCoerce --TODO: How can we avoid this unsafeCoerce? This is safe only because we know how Identity works as a Patch instance
2810− incrementalCoercion Coercion Coercion = Coercion
2811 {-# INLINABLE mergeIntIncremental #-}
2535 {-# INLINABLE mergeIntIncremental #-}
2812− mergeIntIncremental = SpiderEvent . mergeInt . coerce
2536+ mergeIntIncremental = SpiderEvent . mergeInt . (unsafeCoerce :: Dynamic x (PatchIntMap (R.Event (SpiderTimeline x) a)) -> Dynamic x (PatchIntMap (Event x a))) . unSpiderIncremental
2813 {-# INLINABLE fanInt #-}
2537 {-# INLINABLE fanInt #-}
2814 fanInt e = R.EventSelectorInt $ SpiderEvent . selectInt (fanInt (unSpiderEvent e))
2538 fanInt e = R.EventSelectorInt $ SpiderEvent . selectInt (fanInt (unSpiderEvent e))
2815
2539
@@ -2834,7 +2558,7 @@ instance MonadAtomicRef (EventM x) where
2834 atomicModifyRef r f = liftIO $ atomicModifyRef r f
2558 atomicModifyRef r f = liftIO $ atomicModifyRef r f
2835
2559
2836-- | The monad for actions that manipulate a Spider timeline identified by @x@
2560-- | The monad for actions that manipulate a Spider timeline identified by @x@
2837−newtype SpiderHost (x :: Type) a = SpiderHost { unSpiderHost :: IO a } deriving (Functor, Applicative, MonadFix, MonadIO, MonadException, MonadAsyncException)
2561+newtype SpiderHost x a = SpiderHost { unSpiderHost :: IO a } deriving (Functor, Applicative, MonadFix, MonadIO, MonadException, MonadAsyncException)
2838
2562
2839instance Monad (SpiderHost x) where
2563instance Monad (SpiderHost x) where
2840 {-# INLINABLE (>>=) #-}
2564 {-# INLINABLE (>>=) #-}
@@ -2843,14 +2567,8 @@ instance Monad (SpiderHost x) where
2843 SpiderHost x >> SpiderHost y = SpiderHost $ x >> y
2567 SpiderHost x >> SpiderHost y = SpiderHost $ x >> y
2844 {-# INLINABLE return #-}
2568 {-# INLINABLE return #-}
2845 return x = SpiderHost $ return x
2569 return x = SpiderHost $ return x
2846−#if !MIN_VERSION_base(4,13,0)
2847 {-# INLINABLE fail #-}
2570 {-# INLINABLE fail #-}
2848− fail = MonadFail.fail
2849−#endif
2850−
2851−instance MonadFail (SpiderHost x) where
2852− {-# INLINABLE fail #-}
2853− fail s = SpiderHost $ MonadFail.fail s
2571+ fail s = SpiderHost $ fail s
2854
2572
2855-- | Run an action affecting the global Spider timeline; this will be guarded by
2573-- | Run an action affecting the global Spider timeline; this will be guarded by
2856-- a mutex for that timeline
2574-- a mutex for that timeline
@@ -2862,7 +2580,7 @@ runSpiderHost (SpiderHost a) = a
2862runSpiderHostForTimeline :: SpiderHost x a -> SpiderTimelineEnv x -> IO a
2580runSpiderHostForTimeline :: SpiderHost x a -> SpiderTimelineEnv x -> IO a
2863runSpiderHostForTimeline (SpiderHost a) _ = a
2581runSpiderHostForTimeline (SpiderHost a) _ = a
2864
2582
2865−newtype SpiderHostFrame (x :: Type) a = SpiderHostFrame { runSpiderHostFrame :: EventM x a }
2583+newtype SpiderHostFrame x a = SpiderHostFrame { runSpiderHostFrame :: EventM x a }
2866 deriving (Functor, Applicative, MonadFix, MonadIO, MonadException, MonadAsyncException)
2584 deriving (Functor, Applicative, MonadFix, MonadIO, MonadException, MonadAsyncException)
2867
2585
2868instance Monad (SpiderHostFrame x) where
2586instance Monad (SpiderHostFrame x) where
@@ -2872,21 +2590,19 @@ instance Monad (SpiderHostFrame x) where
2872 SpiderHostFrame x >> SpiderHostFrame y = SpiderHostFrame $ x >> y
2590 SpiderHostFrame x >> SpiderHostFrame y = SpiderHostFrame $ x >> y
2873 {-# INLINABLE return #-}
2591 {-# INLINABLE return #-}
2874 return x = SpiderHostFrame $ return x
2592 return x = SpiderHostFrame $ return x
2875−#if !MIN_VERSION_base(4,13,0)
2876 {-# INLINABLE fail #-}
2593 {-# INLINABLE fail #-}
2877 fail s = SpiderHostFrame $ fail s
2594 fail s = SpiderHostFrame $ fail s
2878−#endif
2879
2595
2880instance NotReady (SpiderTimeline x) (SpiderHostFrame x) where
2596instance NotReady (SpiderTimeline x) (SpiderHostFrame x) where
2881 notReadyUntil _ = pure ()
2597 notReadyUntil _ = pure ()
2882 notReady = pure ()
2598 notReady = pure ()
2883
2599
2884−newEventWithTriggerIO :: forall x a. HasSpiderTimeline x => (RootTrigger x a -> IO (IO ())) -> IO (Event x a)
2600+newEventWithTriggerIO :: (RootTrigger x a -> IO (IO ())) -> IO (Event x a)
2885newEventWithTriggerIO f = do
2601newEventWithTriggerIO f = do
2886 es <- newFanEventWithTriggerIO $ \Refl -> f
2602 es <- newFanEventWithTriggerIO $ \Refl -> f
2887 return $ select es Refl
2603 return $ select es Refl
2888
2604
2889−newFanEventWithTriggerIO :: (HasSpiderTimeline x, GCompare k) => (forall a. k a -> RootTrigger x a -> IO (IO ())) -> IO (EventSelector x k)
2605+newFanEventWithTriggerIO :: GCompare k => (forall a. k a -> RootTrigger x a -> IO (IO ())) -> IO (EventSelector x k)
2890newFanEventWithTriggerIO f = do
2606newFanEventWithTriggerIO f = do
2891 occRef <- newIORef DMap.empty
2607 occRef <- newIORef DMap.empty
2892 subscribedRef <- newIORef DMap.empty
2608 subscribedRef <- newIORef DMap.empty
@@ -2920,11 +2636,3 @@ instance MonadAtomicRef (SpiderHostFrame x) where
2920instance PrimMonad (SpiderHostFrame x) where
2636instance PrimMonad (SpiderHostFrame x) where
2921 type PrimState (SpiderHostFrame x) = PrimState IO
2637 type PrimState (SpiderHostFrame x) = PrimState IO
2922 primitive = SpiderHostFrame . EventM . primitive
2638 primitive = SpiderHostFrame . EventM . primitive
2923−
2924−instance NotReady (SpiderTimeline x) (SpiderHost x) where
2925− notReadyUntil _ = return ()
2926− notReady = return ()
2927−
2928−instance HasSpiderTimeline x => NotReady (SpiderTimeline x) (PerformEventT (SpiderTimeline x) (SpiderHost x)) where
2929− notReadyUntil _ = return ()
2930− notReady = return ()
src/Reflex/Time.hs+14−24
@@ -11,11 +11,6 @@
11#ifdef USE_TEMPLATE_HASKELL
11#ifdef USE_TEMPLATE_HASKELL
12{-# LANGUAGE TemplateHaskell #-}
12{-# LANGUAGE TemplateHaskell #-}
13#endif
13#endif
14−-- |
15−-- Module:
16−-- Reflex.Time
17−-- Description:
18−-- Clocks, timers, and other time-related functions.
19module Reflex.Time where
14module Reflex.Time where
20
15
21import Reflex.Class
16import Reflex.Class
@@ -33,7 +28,7 @@ import Control.Monad.IO.Class
33import Data.Align
28import Data.Align
34import Data.Data (Data)
29import Data.Data (Data)
35import Data.Fixed
30import Data.Fixed
36−import Data.Semigroup (Semigroup(..))
31+import Data.Semigroup
37import Data.Sequence (Seq, (|>))
32import Data.Sequence (Seq, (|>))
38import qualified Data.Sequence as Seq
33import qualified Data.Sequence as Seq
39import Data.These
34import Data.These
@@ -42,39 +37,38 @@ import Data.Typeable
42import GHC.Generics (Generic)
37import GHC.Generics (Generic)
43import System.Random
38import System.Random
44
39
45−-- | Metadata associated with a timer "tick"
46data TickInfo
40data TickInfo
47 = TickInfo { _tickInfo_lastUTC :: UTCTime
41 = TickInfo { _tickInfo_lastUTC :: UTCTime
48 -- ^ UTC time immediately after the last tick.
42 -- ^ UTC time immediately after the last tick.
49 , _tickInfo_n :: Integer
43 , _tickInfo_n :: Integer
50− -- ^ Number of time periods or ticks since the start of the timer
44+ -- ^ Number of time periods since t0
51 , _tickInfo_alreadyElapsed :: NominalDiffTime
45 , _tickInfo_alreadyElapsed :: NominalDiffTime
52− -- ^ Amount of time that has elapsed in the current tick period.
46+ -- ^ Amount of time already elapsed in the current tick period.
53 }
47 }
54 deriving (Eq, Ord, Show, Typeable)
48 deriving (Eq, Ord, Show, Typeable)
55
49
56−-- | Fires an 'Event' once every time provided interval elapses, approximately.
57−-- The provided 'UTCTime' is used bootstrap the determination of how much time has elapsed with each tick.
58−-- This is a special case of 'tickLossyFrom' that uses the post-build event to start the tick thread.
50+-- | Special case of 'tickLossyFrom' that uses the post-build event to start the
51+-- tick thread.
59tickLossy :: (PostBuild t m, PerformEvent t m, TriggerEvent t m, MonadIO (Performable m), MonadFix m) => NominalDiffTime -> UTCTime -> m (Event t TickInfo)
52tickLossy :: (PostBuild t m, PerformEvent t m, TriggerEvent t m, MonadIO (Performable m), MonadFix m) => NominalDiffTime -> UTCTime -> m (Event t TickInfo)
60tickLossy dt t0 = tickLossyFrom dt t0 =<< getPostBuild
53tickLossy dt t0 = tickLossyFrom dt t0 =<< getPostBuild
61
54
62−-- | Fires an 'Event' once every time provided interval elapses, approximately.
55+-- | Special case of 'tickLossyFrom' that uses the post-build event to start the
63−-- This is a special case of 'tickLossyFrom' that uses the post-build event to start the tick thread and the time of the post-build as the tick basis time.
56+-- tick thread and the time of the post-build as the tick basis time.
64tickLossyFromPostBuildTime :: (PostBuild t m, PerformEvent t m, TriggerEvent t m, MonadIO (Performable m), MonadFix m) => NominalDiffTime -> m (Event t TickInfo)
57tickLossyFromPostBuildTime :: (PostBuild t m, PerformEvent t m, TriggerEvent t m, MonadIO (Performable m), MonadFix m) => NominalDiffTime -> m (Event t TickInfo)
65tickLossyFromPostBuildTime dt = do
58tickLossyFromPostBuildTime dt = do
66 postBuild <- getPostBuild
59 postBuild <- getPostBuild
67 postBuildTime <- performEvent $ liftIO getCurrentTime <$ postBuild
60 postBuildTime <- performEvent $ liftIO getCurrentTime <$ postBuild
68 tickLossyFrom' $ (dt,) <$> postBuildTime
61 tickLossyFrom' $ (dt,) <$> postBuildTime
69
62
63+-- | Send events over time with the given basis time and interval
70−-- | Fires an 'Event' approximately each time the provided interval elapses. If the system starts running behind, occurrences will be dropped rather than buffered.
64+-- If the system starts running behind, occurrences will be dropped rather than buffered
71−-- Each occurrence of the resulting event will contain the index of the current interval, with 0 representing the provided initial time.
65+-- Each occurrence of the resulting event will contain the index of the current interval, with 0 representing the basis time
72tickLossyFrom
66tickLossyFrom
73 :: (PerformEvent t m, TriggerEvent t m, MonadIO (Performable m), MonadFix m)
67 :: (PerformEvent t m, TriggerEvent t m, MonadIO (Performable m), MonadFix m)
74 => NominalDiffTime
68 => NominalDiffTime
75 -- ^ The length of a tick interval
69 -- ^ The length of a tick interval
76 -> UTCTime
70 -> UTCTime
77− -- ^ The basis time from which intervals count and with which the initial calculation of elapsed time will be made.
71+ -- ^ The basis time from which intervals count
78 -> Event t a
72 -> Event t a
79 -- ^ Event that starts a tick generation thread. Usually you want this to
73 -- ^ Event that starts a tick generation thread. Usually you want this to
80 -- be something like the result of getPostBuild that only fires once. But
74 -- be something like the result of getPostBuild that only fires once. But
@@ -82,12 +76,12 @@ tickLossyFrom
82 -> m (Event t TickInfo)
76 -> m (Event t TickInfo)
83tickLossyFrom dt t0 e = tickLossyFrom' $ (dt, t0) <$ e
77tickLossyFrom dt t0 e = tickLossyFrom' $ (dt, t0) <$ e
84
78
85−-- | Generalization of tickLossyFrom that takes the delay and initial time as an 'Event'.
79+-- | Generalization of tickLossyFrom that takes dt and t0 in the event.
86tickLossyFrom'
80tickLossyFrom'
87 :: (PerformEvent t m, TriggerEvent t m, MonadIO (Performable m), MonadFix m)
81 :: (PerformEvent t m, TriggerEvent t m, MonadIO (Performable m), MonadFix m)
88 => Event t (NominalDiffTime, UTCTime)
82 => Event t (NominalDiffTime, UTCTime)
89 -- ^ Event that starts a tick generation thread. Usually you want this to
83 -- ^ Event that starts a tick generation thread. Usually you want this to
90− -- be something like the result of 'getPostBuild' that only fires once. But
84+ -- be something like the result of getPostBuild that only fires once. But
91 -- there could be uses for starting multiple timer threads.
85 -- there could be uses for starting multiple timer threads.
92 -> m (Event t TickInfo)
86 -> m (Event t TickInfo)
93tickLossyFrom' e = do
87tickLossyFrom' e = do
@@ -98,16 +92,12 @@ tickLossyFrom' e = do
98 Concurrent.delay $ ceiling $ (fst pair - _tickInfo_alreadyElapsed tick) * 1000000
92 Concurrent.delay $ ceiling $ (fst pair - _tickInfo_alreadyElapsed tick) * 1000000
99 cb (tick, pair)
93 cb (tick, pair)
100
94
101−-- | Like 'tickLossy', but immediately calculates the first tick and provides a 'Dynamic' that is updated as ticks fire.
102clockLossy :: (MonadIO m, PerformEvent t m, TriggerEvent t m, MonadIO (Performable m), PostBuild t m, MonadHold t m, MonadFix m) => NominalDiffTime -> UTCTime -> m (Dynamic t TickInfo)
95clockLossy :: (MonadIO m, PerformEvent t m, TriggerEvent t m, MonadIO (Performable m), PostBuild t m, MonadHold t m, MonadFix m) => NominalDiffTime -> UTCTime -> m (Dynamic t TickInfo)
103clockLossy dt t0 = do
96clockLossy dt t0 = do
104 initial <- liftIO $ getCurrentTick dt t0
97 initial <- liftIO $ getCurrentTick dt t0
105 e <- tickLossy dt t0
98 e <- tickLossy dt t0
106 holdDyn initial e
99 holdDyn initial e
107
100
108−-- | Generates a 'TickInfo', given the specified interval and timestamp. The 'TickInfo' will include the
109−-- current time, the number of ticks that have elapsed since the timestamp, and the amount of time that
110−-- has elapsed since the start time of this tick.
111getCurrentTick :: NominalDiffTime -> UTCTime -> IO TickInfo
101getCurrentTick :: NominalDiffTime -> UTCTime -> IO TickInfo
112getCurrentTick dt t0 = do
102getCurrentTick dt t0 = do
113 t <- getCurrentTime
103 t <- getCurrentTime
@@ -288,7 +278,7 @@ data ThrottleState b
288
278
289data ThrottleBuffer b
279data ThrottleBuffer b
290 = ThrottleBuffer_Empty -- Empty conflicts with lens, and hiding it would require turning
280 = ThrottleBuffer_Empty -- Empty conflicts with lens, and hiding it would require turning
291− -- on PatternSynonyms
281+ -- on PatternSynonyms
292 | ThrottleBuffer_Full b
282 | ThrottleBuffer_Full b
293 deriving (Eq, Ord, Show, Functor, Foldable, Traversable, Generic, Data, Typeable)
283 deriving (Eq, Ord, Show, Functor, Foldable, Traversable, Generic, Data, Typeable)
294
284
src/Reflex/TriggerEvent/Base.hs−2
@@ -122,8 +122,6 @@ instance MonadHold t m => MonadHold t (TriggerEventT t m) where
122 buildDynamic a0 = lift . buildDynamic a0
122 buildDynamic a0 = lift . buildDynamic a0
123 {-# INLINABLE headE #-}
123 {-# INLINABLE headE #-}
124 headE = lift . headE
124 headE = lift . headE
125− {-# INLINABLE now #-}
126− now = lift now
127
125
128instance Adjustable t m => Adjustable t (TriggerEventT t m) where
126instance Adjustable t m => Adjustable t (TriggerEventT t m) where
129 {-# INLINABLE runWithReplace #-}
127 {-# INLINABLE runWithReplace #-}
src/Reflex/TriggerEvent/Class.hs+1−6
@@ -2,6 +2,7 @@
2-- new 'Event's that can be triggered from 'IO'.
2-- new 'Event's that can be triggered from 'IO'.
3{-# LANGUAGE FlexibleInstances #-}
3{-# LANGUAGE FlexibleInstances #-}
4{-# LANGUAGE FunctionalDependencies #-}
4{-# LANGUAGE FunctionalDependencies #-}
5+{-# LANGUAGE MultiParamTypeClasses #-}
5{-# LANGUAGE UndecidableInstances #-}
6{-# LANGUAGE UndecidableInstances #-}
6module Reflex.TriggerEvent.Class
7module Reflex.TriggerEvent.Class
7 ( TriggerEvent (..)
8 ( TriggerEvent (..)
@@ -12,7 +13,6 @@ import Reflex.Class
12import Control.Monad.Reader
13import Control.Monad.Reader
13import Control.Monad.State
14import Control.Monad.State
14import qualified Control.Monad.State.Strict as Strict
15import qualified Control.Monad.State.Strict as Strict
15−import Control.Monad.Trans.Maybe (MaybeT)
16
16
17--TODO: Shouldn't have IO hard-coded
17--TODO: Shouldn't have IO hard-coded
18-- | 'TriggerEvent' represents actions that can create 'Event's that can be
18-- | 'TriggerEvent' represents actions that can create 'Event's that can be
@@ -48,8 +48,3 @@ instance TriggerEvent t m => TriggerEvent t (Strict.StateT s m) where
48 newTriggerEvent = lift newTriggerEvent
48 newTriggerEvent = lift newTriggerEvent
49 newTriggerEventWithOnComplete = lift newTriggerEventWithOnComplete
49 newTriggerEventWithOnComplete = lift newTriggerEventWithOnComplete
50 newEventWithLazyTriggerWithOnComplete = lift . newEventWithLazyTriggerWithOnComplete
50 newEventWithLazyTriggerWithOnComplete = lift . newEventWithLazyTriggerWithOnComplete
51−
52−instance TriggerEvent t m => TriggerEvent t (MaybeT m) where
53− newTriggerEvent = lift newTriggerEvent
54− newTriggerEventWithOnComplete = lift newTriggerEventWithOnComplete
55− newEventWithLazyTriggerWithOnComplete = lift . newEventWithLazyTriggerWithOnComplete
src/Reflex/Widget/Basic.hs+1−1
@@ -13,7 +13,7 @@ import Data.Map (Map)
13
13
14import Reflex.Class
14import Reflex.Class
15import Reflex.Adjustable.Class
15import Reflex.Adjustable.Class
16−import Data.Patch.MapWithMove
16+import Reflex.Patch.MapWithMove
17
17
18
18
19-- | Build sortable content in such a way that re-sorting it can cause minimal
19-- | Build sortable content in such a way that re-sorting it can cause minimal
src/Reflex/Workflow.hs+1−13
@@ -1,13 +1,7 @@
1{-# LANGUAGE RecursiveDo #-}
1{-# LANGUAGE RecursiveDo #-}
2{-# LANGUAGE ScopedTypeVariables #-}
2{-# LANGUAGE ScopedTypeVariables #-}
3−-- |
4−-- Module:
5−-- Reflex.Workflow
6−-- Description:
7−-- Provides a convenient way to describe a series of interrelated widgets that
8−-- can send data to, invoke, and replace one another. Useful for modeling user interface
9−-- "workflows."
10module Reflex.Workflow (
3module Reflex.Workflow (
4+ -- * Workflows
11 Workflow (..)
5 Workflow (..)
12 , workflow
6 , workflow
13 , workflowView
7 , workflowView
@@ -24,27 +18,21 @@ import Reflex.Network
24import Reflex.NotReady.Class
18import Reflex.NotReady.Class
25import Reflex.PostBuild.Class
19import Reflex.PostBuild.Class
26
20
27−-- | A widget in a workflow
28−-- When the 'Event' returned by a 'Workflow' fires, the current 'Workflow' is replaced by the one inside the firing 'Event'. A series of 'Workflow's must share the same return type.
29newtype Workflow t m a = Workflow { unWorkflow :: m (a, Event t (Workflow t m a)) }
21newtype Workflow t m a = Workflow { unWorkflow :: m (a, Event t (Workflow t m a)) }
30
22
31−-- | Runs a 'Workflow' and returns the 'Dynamic' result of the 'Workflow' (i.e., a 'Dynamic' of the value produced by the current 'Workflow' node, and whose update 'Event' fires whenever one 'Workflow' is replaced by another).
32workflow :: forall t m a. (Reflex t, Adjustable t m, MonadFix m, MonadHold t m) => Workflow t m a -> m (Dynamic t a)
23workflow :: forall t m a. (Reflex t, Adjustable t m, MonadFix m, MonadHold t m) => Workflow t m a -> m (Dynamic t a)
33workflow w0 = do
24workflow w0 = do
34 rec eResult <- networkHold (unWorkflow w0) $ fmap unWorkflow $ switch $ snd <$> current eResult
25 rec eResult <- networkHold (unWorkflow w0) $ fmap unWorkflow $ switch $ snd <$> current eResult
35 return $ fmap fst eResult
26 return $ fmap fst eResult
36
27
37−-- | Similar to 'workflow', but outputs an 'Event' that fires at post-build time and whenever the current 'Workflow' is replaced by the next 'Workflow'.
38workflowView :: forall t m a. (Reflex t, NotReady t m, Adjustable t m, MonadFix m, MonadHold t m, PostBuild t m) => Workflow t m a -> m (Event t a)
28workflowView :: forall t m a. (Reflex t, NotReady t m, Adjustable t m, MonadFix m, MonadHold t m, PostBuild t m) => Workflow t m a -> m (Event t a)
39workflowView w0 = do
29workflowView w0 = do
40 rec eResult <- networkView . fmap unWorkflow =<< holdDyn w0 eReplace
30 rec eResult <- networkView . fmap unWorkflow =<< holdDyn w0 eReplace
41 eReplace <- fmap switch $ hold never $ fmap snd eResult
31 eReplace <- fmap switch $ hold never $ fmap snd eResult
42 return $ fmap fst eResult
32 return $ fmap fst eResult
43
33
44−-- | Map a function over a 'Workflow', possibly changing the return type.
45mapWorkflow :: (Reflex t, Functor m) => (a -> b) -> Workflow t m a -> Workflow t m b
34mapWorkflow :: (Reflex t, Functor m) => (a -> b) -> Workflow t m a -> Workflow t m b
46mapWorkflow f (Workflow x) = Workflow (fmap (f *** fmap (mapWorkflow f)) x)
35mapWorkflow f (Workflow x) = Workflow (fmap (f *** fmap (mapWorkflow f)) x)
47
36
48−-- | Map a "cheap" function over a 'Workflow'. Refer to the documentation for 'pushCheap' for more information and performance considerations.
49mapWorkflowCheap :: (Reflex t, Functor m) => (a -> b) -> Workflow t m a -> Workflow t m b
37mapWorkflowCheap :: (Reflex t, Functor m) => (a -> b) -> Workflow t m a -> Workflow t m b
50mapWorkflowCheap f (Workflow x) = Workflow (fmap (f *** fmapCheap (mapWorkflowCheap f)) x)
38mapWorkflowCheap f (Workflow x) = Workflow (fmap (f *** fmapCheap (mapWorkflowCheap f)) x)
test/Adjustable.hsdeleted−62
@@ -1,62 +0,0 @@
1−{-# LANGUAGE BangPatterns #-}
2−{-# LANGUAGE LambdaCase #-}
3−{-# LANGUAGE RankNTypes #-}
4−{-# LANGUAGE RecursiveDo #-}
5−
6−module Main where
7−
8−import Control.Monad.Fix
9−import Data.Maybe
10−import qualified Data.Map as Map
11−
12−import Reflex
13−import Reflex.EventWriter.Base
14−import Reflex.Network
15−import Reflex.Patch.MapWithMove
16−import Test.Run
17−
18−main :: IO ()
19−main = do
20− let actions = [ Increment, Update0th, Increment, Swap, Increment, Increment ]
21− os <- runAppB testPatchMapWithMove $ map Just actions
22− -- If the final counter value in the adjusted widgets corresponds to the number of times it has
23− -- been incremented, we know that the networks haven't broken.
24− let expectedCount = length $ ffilter (== Increment) actions
25− -- let !True = last (last os) == [expectedCount,expectedCount] -- TODO re-enable this test after issue #369 has been resolved
26− return ()
27−
28−data PatchMapTestAction
29− = Increment
30− | Swap
31− | Update0th
32− deriving Eq
33−
34−-- See https://github.com/reflex-frp/reflex/issues/369 for the bug that this is testing.
35−testPatchMapWithMove
36− :: forall t m
37− . ( Reflex t
38− , Adjustable t m
39− , MonadHold t m
40− , MonadFix m
41− )
42− => Event t PatchMapTestAction
43− -> m (Behavior t [Int])
44−testPatchMapWithMove pulse = do
45− let pulseAction = ffor pulse $ \case
46− Increment -> Nothing
47− Swap -> patchMapWithMove $ Map.fromList
48− [ (0, NodeInfo (From_Move 1) (Just 1))
49− , (1, NodeInfo (From_Move 0) (Just 0))
50− ]
51− Update0th -> patchMapWithMove $ Map.fromList
52− [ (0, NodeInfo (From_Insert 'z') Nothing) ]
53− (_, result) <- runBehaviorWriterT $ mdo
54− counter <- foldDyn (+) 1 $ fmapMaybe (\e -> if isNothing e then Just 1 else Nothing) pulseAction
55− _ <- mapMapWithAdjustWithMove
56− (\_ _ -> networkHold
57− (tellBehavior $ constant [])
58− ((\t -> tellBehavior $ constant [t]) <$> updated counter))
59− (Map.fromList $ zip [0..] "ab")
60− (fmapMaybe id pulseAction)
61− return ()
62− return result
test/DebugCycles.hsdeleted−171
@@ -1,171 +0,0 @@
1−{-# LANGUAGE CPP #-}
2−{-# LANGUAGE ConstraintKinds #-}
3−{-# LANGUAGE FlexibleContexts #-}
4−{-# LANGUAGE GADTs #-}
5−{-# LANGUAGE RecursiveDo #-}
6−{-# LANGUAGE ScopedTypeVariables #-}
7−{-# LANGUAGE PatternSynonyms #-}
8−{-# LANGUAGE RankNTypes #-}
9−
10−module Main where
11−
12−import Data.Foldable
13−import Control.Lens
14−import Control.Applicative
15−import Control.Monad
16−import Control.Monad.Fix
17−import Control.Exception
18−import System.Timeout
19−import Data.Maybe (isJust)
20−import Data.Functor.Misc
21−import qualified Data.Map as Map
22−import Data.Map (Map)
23−import qualified Data.IntMap as IntMap
24−import Data.IntMap (IntMap)
25−import Data.These
26−import Data.Align
27−import Reflex
28−import Reflex.EventWriter.Base
29−import Test.Run
30−import Test.Hspec
31−import Reflex.Spider.Internal (EventLoopException)
32−import Data.Witherable (Filterable)
33−
34−#if defined(MIN_VERSION_these_lens) || (MIN_VERSION_these(0,8,0) && !MIN_VERSION_these(0,9,0))
35−import Data.These.Lens
36−#endif
37−
38−type Widget t m = (MonadHold t m, Reflex t, MonadFix m)
39−
40−connectDyn :: Widget t m => Event t () -> (Dynamic t a, Dynamic t a) -> m (Dynamic t a)
41−connectDyn e (d, d') = do
42− dd <- holdDyn d (d' <$ e)
43− return $ join dd
44−
45−dynLoop :: Widget t m => (Event t Int, Event t ()) -> m (Event t Int)
46−dynLoop (e1, e2) = do
47− -- "heightBagRemove: Height 2 not present in bag HeightBag {_heightBag_size = 2, _heightBag_contents = fromList [(0,1)]}"
48− rec
49− d <- count e1
50− d' <- connectDyn e2 (d, liftA2 (+) d d')
51− return $ updated d'
52−
53−connectOnCoincidence :: Widget t m => Event t () -> Event t a -> m (Event t a)
54−connectOnCoincidence click e = do
55− d <- holdDyn never (e <$ click)
56− return $ coincidence (updated d)
57−
58−coincidenceLoop :: Widget t m => (Event t Int, Event t ()) -> m (Event t Int)
59−coincidenceLoop (e1, e2) = do
60−-- "heightBagRemove: Height 1 not present in bag HeightBag {_heightBag_size = 1, _heightBag_contents = fromList [(0,0)]}"
61−-- (simpler version of dynLoop)
62− rec
63− e' <- connectOnCoincidence e2 (updated d)
64− d <- count (align e' e1)
65− return $ updated d
66−
67−addHeight :: Reflex t => Event t a -> Event t a
68−addHeight e = leftmost [e4, e4] where
69− e1 = leftmost [e, e]
70− e2 = leftmost [e1, e1]
71− e3 = leftmost [e2, e2]
72− e4 = leftmost [e3, e3]
73−
74−-- Take an existing test and build it inside a
75−buildLoop :: Widget t m => (forall t m. Widget t m => (Event t Int, Event t ()) -> m (Event t Int)) -> (Event t Int, Event t ()) -> m (Event t Int)
76−buildLoop test (e1, e2) = switchHold never buildLoop
77− where buildLoop = pushAlways (const $ test (e1, e2)) e2
78−
79−connectButtonPromptly :: Widget t m => Event t () -> Event t a -> m (Event t a)
80−connectButtonPromptly click e = do
81− d <- holdDyn never (e <$ click)
82− return (switchDyn d)
83−
84−connectButton :: Widget t m => Event t () -> Event t a -> m (Event t a)
85−connectButton click e = do
86− d <- hold never (e <$ click)
87− return (switch d)
88−
89−switchLoop01 :: Widget t m => (Event t Int, Event t ()) -> m (Event t Int)
90−switchLoop01 (e1, e2) = do
91− rec
92− e' <- connectButton e2 (updated d)
93− d <- count (align e' e1)
94− return $ updated d
95−
96−mergeLoop :: forall t m. (Adjustable t m, Widget t m) => (Event t Int, Event t ()) -> m (Event t Int)
97−mergeLoop (e1, e2) = do
98− rec
99− (_, e) <- runEventWriterT $
100− runWithReplace w (leftmost [w <$ e1])
101− return (sum <$> e)
102− where
103− w = do
104− c <- count e1
105− tellEvent (updated ((pure <$> c) :: Dynamic t [Int]))
106−
107−switchLoop02 :: Widget t m => (Event t Int, Event t ()) -> m (Event t Int)
108−switchLoop02 (e1, e2) = do
109− rec
110− e' <- connectButton e2 (updated d)
111− d <- count (leftmost [e', e1])
112− return $ updated d
113−
114−switchLoop03 :: Widget t m => (Event t Int, Event t ()) -> m (Event t Int)
115−switchLoop03 (e1, e2) = do
116− rec
117− e' <- connectButton e2 (addHeight $ updated d)
118− d <- count (align e' e1)
119− return $ updated d
120−
121−staticLoop01 :: Widget t m => (Event t Int, Event t ()) -> m (Event t Int)
122−staticLoop01 (e1, e2) = do
123− rec
124− d <- foldDyn (+) (0 :: Int) (1 <$ align e1 (updated d))
125− return $ updated d
126−
127−staticLoop02 :: Widget t m => (Event t Int, Event t ()) -> m (Event t Int)
128−staticLoop02 (e1, e2) = do
129− rec
130− d <- foldDyn (+) (0 :: Int) (leftmost [e1, updated d])
131− return $ updated d
132−
133−buildStaticLoop :: Widget t m => (Event t Int, Event t ()) -> m (Event t Int)
134−buildStaticLoop (e1, e2) = switchHold never buildLoop
135− where buildLoop = pushAlways (const $ staticLoop01 (e1, e2)) e2
136−
137−splitThese :: Filterable f => f (These a b) -> (f a, f b)
138−splitThese f = (mapMaybe (preview here) f, mapMaybe (preview there) f)
139−
140−main :: IO ()
141−main = hspec $ do
142− describe "DebugCycles" $ do
143− it "throws EventLoopException on switchLoop01" $ do
144− check switchLoop01
145− it "throws EventLoopException on switchLoop02" $ do
146− check switchLoop02
147− it "throws EventLoopException on switchLoop03" $ do
148− check switchLoop03
149− it "throws EventLoopException on buildSwitchLoop" $ do
150− check $ buildLoop switchLoop01
151− xit "throws EventLoopException on mergeLoop" $ do
152− check mergeLoop
153− xit "throws EventLoopException on staticLoop01" $ do
154− check staticLoop01
155− xit "throws EventLoopException on staticLoop02" $ do
156− check staticLoop02
157− xit "throws EventLoopException on buildStaticLoop" $ do
158− check buildStaticLoop
159− xit "throws EventLoopException on coincidenceLoop" $ do
160− check coincidenceLoop
161− xit "throws EventLoopException on dynLoop" $ do
162− check dynLoop
163− xit "throws EventLoopException on buildCoincidenceLoop" $ do
164− check $ buildLoop coincidenceLoop
165− where
166− milliseconds = (*1000)
167− occs = [ This 1, This 2, That (), This 3, That (), This 1 ]
168− check test = do
169− let action = timeout (milliseconds 50) $ do
170− runApp' (test . splitThese) (Just <$> occs)
171− action `shouldThrow` (const True :: Selector EventLoopException)
test/EventWriterT.hs+4−24
@@ -1,5 +1,3 @@
1−{-# LANGUAGE CPP #-}
2−{-# LANGUAGE BangPatterns #-}
3{-# LANGUAGE FlexibleContexts #-}
1{-# LANGUAGE FlexibleContexts #-}
4{-# LANGUAGE GADTs #-}
2{-# LANGUAGE GADTs #-}
5{-# LANGUAGE RecursiveDo #-}
3{-# LANGUAGE RecursiveDo #-}
@@ -14,10 +12,6 @@ import Data.Functor.Misc
14import qualified Data.Map as M
12import qualified Data.Map as M
15import Data.These
13import Data.These
16
14
17−#if defined(MIN_VERSION_these_lens) || (MIN_VERSION_these(0,8,0) && !MIN_VERSION_these(0,9,0))
18−import Data.These.Lens
19−#endif
20−
21import Reflex
15import Reflex
22import Reflex.EventWriter.Base
16import Reflex.EventWriter.Base
23import Test.Run
17import Test.Run
@@ -42,9 +36,6 @@ main = do
42 print os4
36 print os4
43 os5@[[Nothing, Just [1, 2]]] <- runApp' (unwrapApp testLiveTellEventDMap) [Just ()]
37 os5@[[Nothing, Just [1, 2]]] <- runApp' (unwrapApp testLiveTellEventDMap) [Just ()]
44 print os5
38 print os5
45− os6 <- runApp' (unwrapApp delayedPulse) [Just ()]
46− print os6
47− let ![[Nothing, Nothing]] = os6
48 return ()
39 return ()
49
40
50unwrapApp :: (Reflex t, Monad m) => (a -> EventWriterT t [Int] m ()) -> a -> m (Event t [Int])
41unwrapApp :: (Reflex t, Monad m) => (a -> EventWriterT t [Int] m ()) -> a -> m (Event t [Int])
@@ -53,13 +44,16 @@ unwrapApp x appIn = do
53 return e
44 return e
54
45
55testOrdering :: (Reflex t, Monad m) => Event t () -> EventWriterT t [Int] m ()
46testOrdering :: (Reflex t, Monad m) => Event t () -> EventWriterT t [Int] m ()
47+testOrdering pulse = do
56−testOrdering pulse = forM_ [10,9..1] $ \i -> tellEvent ([i] <$ pulse)
48+ forM_ [10,9..1] $ \i -> tellEvent ([i] <$ pulse)
49+ return ()
57
50
58testSimultaneous :: (Reflex t, Adjustable t m, MonadHold t m) => Event t (These () ()) -> EventWriterT t [Int] m ()
51testSimultaneous :: (Reflex t, Adjustable t m, MonadHold t m) => Event t (These () ()) -> EventWriterT t [Int] m ()
59testSimultaneous pulse = do
52testSimultaneous pulse = do
60 let e0 = fmapMaybe (^? here) pulse
53 let e0 = fmapMaybe (^? here) pulse
61 e1 = fmapMaybe (^? there) pulse
54 e1 = fmapMaybe (^? there) pulse
62 forM_ [1,3..9] $ \i -> runWithReplace (tellEvent ([i] <$ e0)) $ ffor e1 $ \_ -> tellEvent ([i+1] <$ e0)
55 forM_ [1,3..9] $ \i -> runWithReplace (tellEvent ([i] <$ e0)) $ ffor e1 $ \_ -> tellEvent ([i+1] <$ e0)
56+ return ()
63
57
64-- | Test that a widget telling and event which fires at the same time it has been replaced
58-- | Test that a widget telling and event which fires at the same time it has been replaced
65-- doesn't count along with the new widget.
59-- doesn't count along with the new widget.
@@ -118,17 +112,3 @@ testLiveTellEventDMap pulse = do
118 (mapToDMap $ M.singleton 1 ())
112 (mapToDMap $ M.singleton 1 ())
119 ((PatchDMap $ DMap.map (ComposeMaybe . Just) $ mapToDMap $ M.singleton 2 ()) <$ pulse)
113 ((PatchDMap $ DMap.map (ComposeMaybe . Just) $ mapToDMap $ M.singleton 2 ()) <$ pulse)
120 return ()
114 return ()
121−
122−delayedPulse
123− :: forall t m
124− . ( Reflex t
125− , Adjustable t m
126− , MonadHold t m
127− , MonadFix m
128− )
129− => Event t ()
130− -> EventWriterT t [Int] m ()
131−delayedPulse pulse = void $ flip runWithReplace (pure () <$ pulse) $ do
132− -- This has the effect of delaying pulse' from pulse
133− (_, pulse') <- runWithReplace (pure ()) $ pure [1] <$ pulse
134− tellEvent pulse'
test/GC.hs+5−6
@@ -18,17 +18,15 @@ import Data.GADT.Compare
18import Data.IORef
18import Data.IORef
19import Data.Semigroup
19import Data.Semigroup
20import Data.These
20import Data.These
21−import Data.Type.Equality ((:~:)(Refl))
22
21
23import Data.Functor.Misc
22import Data.Functor.Misc
24−import Data.Patch
23+import Reflex.Patch
25
24
26import qualified Reflex.Host.Class as Host
25import qualified Reflex.Host.Class as Host
27import qualified Reflex.Spider.Internal as S
26import qualified Reflex.Spider.Internal as S
28
27
29import System.Exit
28import System.Exit
30import System.Mem
29import System.Mem
31−import Data.Coerce
32
30
33main :: IO ()
31main :: IO ()
34main = do
32main = do
@@ -48,7 +46,7 @@ hostPerf ref = S.runSpiderHost $ do
48 eventToPerform <- Host.runHostFrame $ do
46 eventToPerform <- Host.runHostFrame $ do
49 (reqMap :: S.Event S.Global (DMap (Const2 Int (DMap Tell (S.SpiderHostFrame S.Global))) Identity))
47 (reqMap :: S.Event S.Global (DMap (Const2 Int (DMap Tell (S.SpiderHostFrame S.Global))) Identity))
50 <- S.SpiderHostFrame
48 <- S.SpiderHostFrame
51− $ fmap ( S.mergeG coerce
49+ $ fmap ( S.merge
52 . S.dynamicHold)
50 . S.dynamicHold)
53 $ S.hold DMap.empty
51 $ S.hold DMap.empty
54 -- Construct a new heap object for the subscriber, invalidating any weak references to the subscriber if they are not retained
52 -- Construct a new heap object for the subscriber, invalidating any weak references to the subscriber if they are not retained
@@ -57,8 +55,8 @@ hostPerf ref = S.runSpiderHost $ do
57 { S.subscriberPropagate = S.subscriberPropagate sub
55 { S.subscriberPropagate = S.subscriberPropagate sub
58 }
56 }
59 return (s, o))
57 return (s, o))
60− $ runIdentity . runIdentity <$> S.selectG
58+ $ runIdentity <$> S.select
61− (S.fanG $ S.pushCheap (return . Just . mapKeyValuePairsMonotonic (\(t :=> e) -> WrapArg t :=> Identity e)) response)
59+ (S.fan $ S.pushCheap (return . Just . mapKeyValuePairsMonotonic (\(t :=> e) -> WrapArg t :=> Identity e)) response)
62 (WrapArg Request)
60 (WrapArg Request)
63 return $ alignWith (mergeThese (<>))
61 return $ alignWith (mergeThese (<>))
64 (flip S.pushCheap eadd $ \_ -> return $ Just $ DMap.singleton Request $ do
62 (flip S.pushCheap eadd $ \_ -> return $ Just $ DMap.singleton Request $ do
@@ -84,6 +82,7 @@ hostPerf ref = S.runSpiderHost $ do
84 Nothing -> []
82 Nothing -> []
85 Host.fireEventsAndRead followupEventTriggers $ return ()
83 Host.fireEventsAndRead followupEventTriggers $ return ()
86 return ()
84 return ()
85+ return ()
87
86
88data Tell a where
87data Tell a where
89 Action :: Tell ()
88 Action :: Tell ()
test/Headless.hsdeleted−10
@@ -1,10 +0,0 @@
1−module Main where
2−
3−import Reflex
4−import Reflex.Host.Headless (runHeadlessApp)
5−
6−main :: IO ()
7−main = do
8− runHeadlessApp $ do
9− pb <- getPostBuild
10− performEvent (pure <$> pb)
test/QueryT.hs+1−5
@@ -19,12 +19,8 @@ import Data.Map.Monoidal (MonoidalMap)
19import Data.Semigroup
19import Data.Semigroup
20import Data.These
20import Data.These
21
21
22−#if defined(MIN_VERSION_these_lens) || (MIN_VERSION_these(0,8,0) && !MIN_VERSION_these(0,9,0))
23−import Data.These.Lens
24−#endif
25−
26import Reflex
22import Reflex
27−import Data.Patch.MapWithMove
23+import Reflex.Patch.MapWithMove
28import Test.Run
24import Test.Run
29
25
30newtype MyQuery = MyQuery SelectedCount
26newtype MyQuery = MyQuery SelectedCount
test/Reflex/Bench/Focused.hs−12
@@ -130,16 +130,6 @@ mapDynChain = iterM (return . fmap (+1))
130joinDynChain :: (Reflex t, MonadHold t m) => Word -> Dynamic t Word -> m (Dynamic t Word)
130joinDynChain :: (Reflex t, MonadHold t m) => Word -> Dynamic t Word -> m (Dynamic t Word)
131joinDynChain = iterM (\d -> return $ join $ fmap (const d) d)
131joinDynChain = iterM (\d -> return $ join $ fmap (const d) d)
132
132
133−holdDynChain :: (Reflex t, MonadHold t m) => Word -> Dynamic t Word -> m (Dynamic t Word)
134−holdDynChain = iterM (\d -> sample (current d) >>= flip holdDyn (updated d))
135−
136−buildDynChain :: (Reflex t, MonadHold t m) => Word -> Dynamic t Word -> m (Dynamic t Word)
137−buildDynChain = iterM (\d -> do
138− let b = fmap (+1) (current d)
139− e = fmap (*2) (updated d)
140− buildDynamic (sample b) e)
141−
142−
143combineDynChain :: (Reflex t, MonadHold t m) => Word -> Dynamic t Word -> m (Dynamic t Word)
133combineDynChain :: (Reflex t, MonadHold t m) => Word -> Dynamic t Word -> m (Dynamic t Word)
144combineDynChain = iterM (\d -> return $ zipDynWith (+) d d)
134combineDynChain = iterM (\d -> return $ zipDynWith (+) d d)
145
135
@@ -318,8 +308,6 @@ dynamics :: Word -> [(String, TestCase)]
318dynamics n =
308dynamics n =
319 [ testE "mapDynChain" $ fmap updated $ mapDynChain n =<< d
309 [ testE "mapDynChain" $ fmap updated $ mapDynChain n =<< d
320 , testE "joinDynChain" $ fmap updated $ joinDynChain n =<< d
310 , testE "joinDynChain" $ fmap updated $ joinDynChain n =<< d
321− , testE "holdDynChain" $ fmap updated $ holdDynChain n =<< d
322− , testE "buildDynChain" $ fmap updated $ buildDynChain n =<< d
323 , testE "combineDynChain" $ fmap updated $ combineDynChain n =<< d
311 , testE "combineDynChain" $ fmap updated $ combineDynChain n =<< d
324 , testE "dense mergeTree" $ fmap (updated . mergeTreeDyn 8) dense
312 , testE "dense mergeTree" $ fmap (updated . mergeTreeDyn 8) dense
325 , testE "sparse mergeTree" $ fmap (updated . mergeTreeDyn 8) sparse
313 , testE "sparse mergeTree" $ fmap (updated . mergeTreeDyn 8) sparse
test/Reflex/Plan/Pure.hs−1
@@ -41,7 +41,6 @@ instance MonadHold (Pure Int) PurePlan where
41 holdIncremental initial = liftPlan . holdIncremental initial
41 holdIncremental initial = liftPlan . holdIncremental initial
42 buildDynamic getInitial = liftPlan . buildDynamic getInitial
42 buildDynamic getInitial = liftPlan . buildDynamic getInitial
43 headE = liftPlan . headE
43 headE = liftPlan . headE
44− now = liftPlan now
45
44
46instance MonadSample (Pure Int) PurePlan where
45instance MonadSample (Pure Int) PurePlan where
47 sample = liftPlan . sample
46 sample = liftPlan . sample
test/Reflex/Test/CrossImpl.hs+8−18
@@ -21,12 +21,11 @@ import Reflex.Dynamic
21import Reflex.Host.Class
21import Reflex.Host.Class
22import qualified Reflex.Pure as P
22import qualified Reflex.Pure as P
23import qualified Reflex.Spider.Internal as S
23import qualified Reflex.Spider.Internal as S
24−import qualified Reflex.Profiled as Prof
25
24
26import Control.Arrow (second, (&&&))
25import Control.Arrow (second, (&&&))
27import Control.Monad.Identity hiding (forM, forM_, mapM, mapM_, sequence, sequence_)
26import Control.Monad.Identity hiding (forM, forM_, mapM, mapM_, sequence, sequence_)
28import Control.Monad.State.Strict hiding (forM, forM_, mapM, mapM_, sequence, sequence_)
27import Control.Monad.State.Strict hiding (forM, forM_, mapM, mapM_, sequence, sequence_)
29−import Data.Dependent.Sum (DSum (..))
28+import Data.Dependent.Map (DSum (..))
30import Data.Foldable
29import Data.Foldable
31import Data.Map.Strict (Map)
30import Data.Map.Strict (Map)
32import qualified Data.Map.Strict as Map
31import qualified Data.Map.Strict as Map
@@ -36,6 +35,8 @@ import Data.Traversable
36import System.Exit
35import System.Exit
37import System.Mem
36import System.Mem
38
37
38+import System.IO.Unsafe
39+
39mapToPureBehavior :: Map Int a -> Behavior PureReflexDomain a
40mapToPureBehavior :: Map Int a -> Behavior PureReflexDomain a
40mapToPureBehavior m = P.Behavior $ \t -> case Map.lookupLE t m of
41mapToPureBehavior m = P.Behavior $ \t -> case Map.lookupLE t m of
41 Nothing -> error $ "mapToPureBehavior: no value for time " <> show t
42 Nothing -> error $ "mapToPureBehavior: no value for time " <> show t
@@ -72,14 +73,11 @@ instance MapMSignals (Event t a) (Event t' a) t t' where
72instance (MapMSignals a a' t t', MapMSignals b b' t t') => MapMSignals (a, b) (a', b') t t' where
73instance (MapMSignals a a' t t', MapMSignals b b' t t') => MapMSignals (a, b) (a', b') t t' where
73 mapMSignals fb fe (a, b) = liftM2 (,) (mapMSignals fb fe a) (mapMSignals fb fe b)
74 mapMSignals fb fe (a, b) = liftM2 (,) (mapMSignals fb fe a) (mapMSignals fb fe b)
74
75
75−testTimeline
76− :: (forall m t. TestCaseConstraint t m => (Behavior t a, Event t b) -> m (Behavior t c, Event t d))
76+testSpider :: (forall m t. TestCaseConstraint t m => (Behavior t a, Event t b) -> m (Behavior t c, Event t d)) -> (Map Int a, Map Int b) -> (Map Int c, Map Int d)
77− -> (Map Int a, Map Int b)
78− -> (forall m t. (MonadReflexHost t m, MonadIO m, MonadRef m, Ref m ~ Ref IO, MonadSample t m) => m (Map Int c, Map Int d))
79−testTimeline builder (bMap, eMap) = do
77+testSpider builder (bMap, eMap) = unsafePerformIO $ S.runSpiderHost $ do
80 (re, reTrigger) <- newEventWithTriggerRef
78 (re, reTrigger) <- newEventWithTriggerRef
81 (rb, rbTrigger) <- newEventWithTriggerRef
79 (rb, rbTrigger) <- newEventWithTriggerRef
82− b <- runHostFrame $ hold (error "testTimeline: No value for input behavior yet") rb
80+ b <- runHostFrame $ hold (error "testSpider: No value for input behavior yet") rb
83 (b', e') <- runHostFrame $ builder (b, re)
81 (b', e') <- runHostFrame $ builder (b, re)
84 e'Handle <- subscribeEvent e' --TODO: This should be unnecessary
82 e'Handle <- subscribeEvent e' --TODO: This should be unnecessary
85 let times = relevantTestingTimes (bMap, eMap)
83 let times = relevantTestingTimes (bMap, eMap)
@@ -104,11 +102,9 @@ testAgreement :: (Eq c, Eq d, Show c, Show d) => (forall m t. TestCaseConstraint
104testAgreement builder inputs = do
102testAgreement builder inputs = do
105 let identityResult = testPure builder inputs
103 let identityResult = testPure builder inputs
106 tracePerf "---------" $ return ()
104 tracePerf "---------" $ return ()
107− spiderResult <- S.runSpiderHost $ testTimeline builder inputs
105+ let spiderResult = testSpider builder inputs
108− tracePerf "---------" $ return ()
109− profiledResult <- S.runSpiderHost $ Prof.runProfiledM $ testTimeline builder inputs
110 tracePerf "---------" $ return ()
106 tracePerf "---------" $ return ()
111− let resultsAgree = identityResult == spiderResult && identityResult == profiledResult
107+ let resultsAgree = identityResult == spiderResult
112 if resultsAgree
108 if resultsAgree
113 then do --putStrLn "Success:"
109 then do --putStrLn "Success:"
114 --print identityResult
110 --print identityResult
@@ -116,7 +112,6 @@ testAgreement builder inputs = do
116 else do putStrLn "Failure:"
112 else do putStrLn "Failure:"
117 putStrLn $ "Pure result: " <> show identityResult
113 putStrLn $ "Pure result: " <> show identityResult
118 putStrLn $ "Spider result: " <> show spiderResult
114 putStrLn $ "Spider result: " <> show spiderResult
119− putStrLn $ "Profiled result: " <> show profiledResult
120 return resultsAgree
115 return resultsAgree
121
116
122type TestCaseConstraint t m = (Reflex t, MonadSample t m, MonadHold t m, MonadFix m, MonadFix (PushM t))
117type TestCaseConstraint t m = (Reflex t, MonadSample t m, MonadHold t m, MonadFix m, MonadFix (PushM t))
@@ -223,11 +218,6 @@ testCases =
223 bb <- hold b $ pushAlways (const $ hold "asdf" eo) eo
218 bb <- hold b $ pushAlways (const $ hold "asdf" eo) eo
224 let b' = pull $ sample =<< sample bb
219 let b' = pull $ sample =<< sample bb
225 return (b', e)
220 return (b', e)
226− , (,) "foldDynWhileFiring" $ TestCase (Map.singleton 0 "zxc", Map.fromList [(1, "qwer"), (2, "lkj")]) $ \(_, e) -> do
227− d <- foldDyn (:) [] $
228− pushAlways (\a -> foldDyn (:) [a] e) e
229− let b = current (join (fmap distributeListOverDynPure d))
230− return (b, e)
231 , (,) "joinDyn" $ TestCase (Map.singleton 0 (0 :: Int), Map.fromList [(1, "qwer"), (2, "lkj")]) $ \(b, e) -> do
221 , (,) "joinDyn" $ TestCase (Map.singleton 0 (0 :: Int), Map.fromList [(1, "qwer"), (2, "lkj")]) $ \(b, e) -> do
232 bb <- hold "b" e
222 bb <- hold "b" e
233 bd <- hold never . fmap (const e) =<< headE e
223 bd <- hold never . fmap (const e) =<< headE e
test/Reflex/Test/Micro.hs+2−8
@@ -322,14 +322,8 @@ testCases =
322 let e = never <$ switch b
322 let e = never <$ switch b
323 return $ void e
323 return $ void e
324 lazyHold
324 lazyHold
325− , testE "now-1" $ do
325+
326− e1 <- events1
326+
327− switchHoldPromptly never . pushAlways (\a -> fmap (a <$) now) $ e1
328− , testE "now-2" $ do
329− e1 <- events1
330− let e = pushAlways (\a -> if a == "a" then now else return never) e1
331− x <- accumDyn (<>) never e
332− return . coincidence $ updated x
333 ] where
327 ] where
334
328
335 events1, events2, events3 :: TestPlan t m => m (Event t String)
329 events1, events2, events3 :: TestPlan t m => m (Event t String)
test/RequesterT.hs+11−179
@@ -1,40 +1,14 @@
1−{-# LANGUAGE CPP #-}
2−{-# LANGUAGE BangPatterns #-}
3{-# LANGUAGE FlexibleContexts #-}
1{-# LANGUAGE FlexibleContexts #-}
4−{-# LANGUAGE FlexibleInstances #-}
5{-# LANGUAGE GADTs #-}
2{-# LANGUAGE GADTs #-}
6−{-# LANGUAGE LambdaCase #-}
3+{-# LANGUAGE RankNTypes #-}
7−{-# LANGUAGE MultiParamTypeClasses #-}
8−{-# LANGUAGE RecursiveDo #-}
9{-# LANGUAGE ScopedTypeVariables #-}
4{-# LANGUAGE ScopedTypeVariables #-}
10−{-# LANGUAGE TemplateHaskell #-}
11−{-# LANGUAGE TypeApplications #-}
12−{-# LANGUAGE TypeFamilies #-}
13module Main where
5module Main where
14
6
15−import Control.Lens hiding (has)
7+import Control.Lens
16import Control.Monad
8import Control.Monad
17−import Control.Monad.Fix
18−import Control.Monad.IO.Class (MonadIO)
19−import Data.Constraint.Extras
20−import Data.Constraint.Extras.TH
21−import Data.Constraint.Forall
22import qualified Data.Dependent.Map as DMap
9import qualified Data.Dependent.Map as DMap
23import Data.Dependent.Sum
10import Data.Dependent.Sum
24−import Data.Functor.Misc
25−import Data.List (words)
26−import Data.Map (Map)
27−import qualified Data.Map as M
28−#if !MIN_VERSION_these(4,11,0)
29−import Data.Semigroup ((<>))
30−#endif
31−import Data.Text (Text)
32import Data.These
11import Data.These
33−import Text.Read (readMaybe)
34−
35−#if defined(MIN_VERSION_these_lens) || (MIN_VERSION_these(0,8,0) && !MIN_VERSION_these(0,9,0))
36−import Data.These.Lens
37−#endif
38
12
39import Reflex
13import Reflex
40import Reflex.Requester.Base
14import Reflex.Requester.Base
@@ -46,38 +20,18 @@ data RequestInt a where
46
20
47main :: IO ()
21main :: IO ()
48main = do
22main = do
49− os1 <- runApp' (unwrapApp testOrdering) $
23+ os1@[[Just [10,9,8,7,6,5,4,3,2,1]]] <- runApp' (unwrapApp testOrdering) $
50 [ Just ()
24 [ Just ()
51 ]
25 ]
52 print os1
26 print os1
27+ os2@[[Just [1,3,5,7,9]],[Nothing,Nothing],[Just [2,4,6,8,10]],[Just [2,4,6,8,10],Nothing]]
53− os2 <- runApp' (unwrapApp testSimultaneous) $ map Just $
28+ <- runApp' (unwrapApp testSimultaneous) $ map Just $
54− [ This ()
29+ [ This ()
55− , That ()
30+ , That ()
56− , This ()
31+ , This ()
57− , These () ()
32+ , These () ()
58− ]
33+ ]
59 print os2
34 print os2
60− os3 <- runApp' (unwrapApp testMoribundRequest) [Just ()]
61− print os3
62− os4 <- runApp' (unwrapApp testMoribundRequestDMap) [Just ()]
63− print os4
64− os5 <- runApp' (unwrapApp testLiveRequestDMap) [Just ()]
65− print os5
66− os6 <- runApp' (unwrapApp delayedPulse) [Just ()]
67− print os6
68− os7 <- runApp' testMatchRequestsWithResponses [ Just $ TestRequest_Increment 1 ]
69− print os7
70− os8 <- runApp' testMatchRequestsWithResponses [ Just $ TestRequest_Reverse "yoyo" ]
71− print os8
72− let ![[Just [1,2,3,4,5,6,7,8,9,10]]] = os1 -- The order is reversed here: see the documentation for 'runRequesterT'
73− let ![[Just [9,7,5,3,1]],[Nothing,Nothing],[Just [10,8,6,4,2]],[Just [10,8,6,4,2],Nothing]] = os2
74− let ![[Nothing, Just [2]]] = os3
75− let ![[Nothing, Just [2]]] = os4
76− let ![[Nothing, Just [1, 2]]] = os5
77− -- let ![[Nothing, Nothing]] = os6 -- TODO re-enable this test after issue #233 has been resolved
78− let !(Just [(1,"2")]) = M.toList <$> head (head os7)
79− let !(Just [(1,"oyoy")]) = M.toList <$> head (head os8)
80−
81 return ()
35 return ()
82
36
83unwrapRequest :: DSum tag RequestInt -> Int
37unwrapRequest :: DSum tag RequestInt -> Int
@@ -89,7 +43,7 @@ unwrapApp :: ( Reflex t, Monad m )
89 -> m (Event t [Int])
43 -> m (Event t [Int])
90unwrapApp x appIn = do
44unwrapApp x appIn = do
91 ((), e) <- runRequesterT (x appIn) never
45 ((), e) <- runRequesterT (x appIn) never
92− return $ fmap (map unwrapRequest . requesterDataToList) e
46+ return $ fmap (map unwrapRequest . DMap.toList) e
93
47
94testOrdering :: ( Response m ~ Identity
48testOrdering :: ( Response m ~ Identity
95 , Request m ~ RequestInt
49 , Request m ~ RequestInt
@@ -111,125 +65,3 @@ testSimultaneous pulse = do
111 switchE = fmapMaybe (^? there) pulse
65 switchE = fmapMaybe (^? there) pulse
112 forM_ [1,3..9] $ \i -> runWithReplace (requestingIdentity (RequestInt i <$ tellE)) $ ffor switchE $ \_ ->
66 forM_ [1,3..9] $ \i -> runWithReplace (requestingIdentity (RequestInt i <$ tellE)) $ ffor switchE $ \_ ->
113 requestingIdentity (RequestInt (i+1) <$ tellE)
67 requestingIdentity (RequestInt (i+1) <$ tellE)
114−
115−-- | Test that a widget requesting and event which fires at the same time it has been replaced
116−-- doesn't count along with the new widget.
117−testMoribundRequest
118− :: forall t m
119− . ( Reflex t
120− , Adjustable t m
121− , MonadHold t m
122− , MonadFix m
123− , Response m ~ Identity
124− , Request m ~ RequestInt
125− , Requester t m
126− )
127− => Event t ()
128− -> m ()
129−testMoribundRequest pulse = do
130− rec let requestIntOnReplace x = requestingIdentity $ RequestInt x <$ rwrFinished
131− (_, rwrFinished) <- runWithReplace (requestIntOnReplace 1) $ requestIntOnReplace 2 <$ pulse
132− return ()
133−
134−-- | The equivalent of 'testMoribundRequest' for 'traverseDMapWithKeyWithAdjust'.
135−testMoribundRequestDMap
136− :: forall t m
137− . ( Reflex t
138− , Adjustable t m
139− , MonadHold t m
140− , MonadFix m
141− , Response m ~ Identity
142− , Request m ~ RequestInt
143− , Requester t m
144− )
145− => Event t ()
146− -> m ()
147−testMoribundRequestDMap pulse = do
148− rec let requestIntOnReplace :: Int -> m ()
149− requestIntOnReplace x = void $ requestingIdentity $ RequestInt x <$ rwrFinished
150− (_, rwrFinished :: Event t (PatchDMap (Const2 () Int) Identity)) <-
151− traverseDMapWithKeyWithAdjust
152− (\(Const2 ()) (Identity v) -> Identity . const v <$> requestIntOnReplace v)
153− (mapToDMap $ M.singleton () 1)
154− ((PatchDMap $ DMap.map (ComposeMaybe . Just) $ mapToDMap $ M.singleton () 2) <$ pulse)
155− return ()
156−
157−-- | Ensures that elements which are _not_ removed can still fire requests
158−-- during the same frame as other elements are updated.
159−testLiveRequestDMap
160− :: forall t m
161− . ( Reflex t
162− , Adjustable t m
163− , MonadHold t m
164− , MonadFix m
165− , Response m ~ Identity
166− , Request m ~ RequestInt
167− , Requester t m
168− )
169− => Event t ()
170− -> m ()
171−testLiveRequestDMap pulse = do
172− rec let requestIntOnReplace :: Int -> m ()
173− requestIntOnReplace x = void $ requestingIdentity $ RequestInt x <$ rwrFinished
174− (_, rwrFinished :: Event t (PatchDMap (Const2 Int ()) Identity)) <-
175− traverseDMapWithKeyWithAdjust
176− (\(Const2 k) (Identity ()) -> Identity <$> requestIntOnReplace k)
177− (mapToDMap $ M.singleton 1 ())
178− ((PatchDMap $ DMap.map (ComposeMaybe . Just) $ mapToDMap $ M.singleton 2 ()) <$ pulse)
179− return ()
180−
181−delayedPulse
182− :: forall t m
183− . ( Reflex t
184− , Adjustable t m
185− , MonadHold t m
186− , MonadFix m
187− , Response m ~ Identity
188− , Request m ~ RequestInt
189− , PerformEvent t m
190− , Requester t m
191− )
192− => Event t ()
193− -> m ()
194−delayedPulse pulse = void $ flip runWithReplace (pure () <$ pulse) $ do
195− -- This has the effect of delaying pulse' from pulse
196− (_, pulse') <- runWithReplace (pure ()) $ pure (RequestInt 1) <$ pulse
197− requestingIdentity pulse'
198−
199−data TestRequest a where
200− TestRequest_Reverse :: String -> TestRequest String
201− TestRequest_Increment :: Int -> TestRequest Int
202−
203−testMatchRequestsWithResponses
204− :: forall m t req a
205− . ( MonadFix m
206− , MonadHold t m
207− , Reflex t
208− , PerformEvent t m
209− , MonadIO (Performable m)
210− , ForallF Show req
211− , Has Read req
212− )
213− => Event t (req a) -> m (Event t (Map Int String))
214−testMatchRequestsWithResponses pulse = mdo
215− (_, requests) <- runRequesterT (requesting pulse) responses
216− let rawResponses = M.map (\v ->
217− case words v of
218− ["reverse", str] -> reverse str
219− ["increment", i] -> show $ succ $ (read i :: Int)
220− ) <$> rawRequestMap
221− (rawRequestMap, responses) <- matchResponsesWithRequests reqEncoder requests (head . M.toList <$> rawResponses)
222− pure rawResponses
223− where
224− reqEncoder :: forall a. req a -> (String, String -> Maybe a)
225− reqEncoder r =
226− ( whichever @Show @req @a $ show r
227− , \x -> has @Read r $ readMaybe x
228− )
229−
230−deriveArgDict ''TestRequest
231−
232−instance Show (TestRequest a) where
233− show = \case
234− TestRequest_Reverse str -> "reverse " <> str
235− TestRequest_Increment i -> "increment " <> show i
test/hlint.hs+8−3
@@ -1,7 +1,7 @@
1module Main where
1module Main where
2
2
3import Control.Monad
3import Control.Monad
4−import Language.Haskell.HLint (hlint)
4+import Language.Haskell.HLint3 (hlint)
5import System.Directory
5import System.Directory
6import System.Exit (exitFailure, exitSuccess)
6import System.Exit (exitFailure, exitSuccess)
7import System.FilePath
7import System.FilePath
@@ -22,8 +22,6 @@ main = do
22 , "--ignore=Use unless"
22 , "--ignore=Use unless"
23 , "--ignore=Reduce duplication"
23 , "--ignore=Reduce duplication"
24 , "--cpp-define=USE_TEMPLATE_HASKELL"
24 , "--cpp-define=USE_TEMPLATE_HASKELL"
25− , "--cpp-define=DEBUG"
26− , "--ignore=Use tuple-section"
27 ]
25 ]
28 recurseInto = and <$> sequence
26 recurseInto = and <$> sequence
29 [ fileType ==? Directory
27 [ fileType ==? Directory
@@ -31,9 +29,16 @@ main = do
31 ]
29 ]
32 matchFile = and <$> sequence
30 matchFile = and <$> sequence
33 [ extension ==? ".hs"
31 [ extension ==? ".hs"
32+ , let notElem' = liftOp notElem
33+ in filePath `notElem'` filePathExceptions pwd
34 ]
34 ]
35 files <- find recurseInto matchFile (pwd </> "src") --TODO: Someday fix all hints in tests, etc.
35 files <- find recurseInto matchFile (pwd </> "src") --TODO: Someday fix all hints in tests, etc.
36 ideas <- fmap concat $ forM files $ \f -> do
36 ideas <- fmap concat $ forM files $ \f -> do
37 putStr $ "linting file " ++ drop (length pwd + 1) f ++ "... "
37 putStr $ "linting file " ++ drop (length pwd + 1) f ++ "... "
38 runHlint f
38 runHlint f
39 if null ideas then exitSuccess else exitFailure
39 if null ideas then exitSuccess else exitFailure
40+
41+filePathExceptions :: FilePath -> [FilePath]
42+filePathExceptions pwd = map (pwd </>) $
43+ [ "src/Data/AppendMap.hs" -- parse error when hlint runs
44+ ]