@@ -9,6 +9,7 @@
99{-# LANGUAGE GADTs #-}
1010{-# LANGUAGE GeneralizedNewtypeDeriving #-}
1111{-# LANGUAGE LambdaCase #-}
12+{-# LANGUAGE MultiWayIf #-}
1213{-# LANGUAGE RankNTypes #-}
1314{-# LANGUAGE RoleAnnotations #-}
1415{-# LANGUAGE ScopedTypeVariables #-}
@@ -19,7 +20,6 @@
1920{-# LANGUAGE DeriveFunctor #-}
2021{-# LANGUAGE StandaloneDeriving #-}
2122{-# LANGUAGE InstanceSigs #-}
22−{-# LANGUAGE MultiWayIf #-}
2323
2424#ifdef USE_REFLEX_OPTIMIZER
2525{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
@@ -38,6 +38,7 @@ import Control.Monad hiding (forM, forM_, mapM, mapM_)
3838import Control.Monad.Exception
3939import Control.Monad.Identity hiding (forM, forM_, mapM, mapM_)
4040import Control.Monad.Primitive
41+--import Control.Monad.Reader hiding (forM, forM_, mapM, mapM_)
4142import Control.Monad.Reader.Class
4243import Control.Monad.IO.Class
4344import Control.Monad.ReaderIO
@@ -46,9 +47,8 @@ import Control.Monad.Fail (MonadFail)
4647import qualified Control.Monad.Fail as MonadFail
4748import Data.Align
4849import Data.Coerce
49−import Data.Dependent.Map (DMap)
50+import Data.Dependent.Map (DMap, DSum (..))
5051import qualified Data.Dependent.Map as DMap
51−import Data.Dependent.Sum (DSum (..))
5252import Data.FastMutableIntMap (FastMutableIntMap, PatchIntMap (..))
5353import qualified Data.FastMutableIntMap as FastMutableIntMap
5454import Data.Foldable hiding (concat, elem, sequence_)
@@ -61,13 +61,12 @@ import qualified Data.IntMap.Strict as IntMap
6161import Data.IORef
6262import Data.Kind (Type)
6363import Data.Maybe hiding (mapMaybe)
64−import Data.Monoid (mempty, (<>))
64+import Data.Monoid ((<>))
6565import Data.Proxy
6666import Data.These
6767import Data.Traversable
68−import Data.Type.Equality ((:~:)(Refl))
6968import Data.Witherable (Filterable, mapMaybe)
70−import GHC.Exts hiding (toList)
69+import GHC.Exts
7170import GHC.IORef (IORef (..))
7271import GHC.Stack
7372import Reflex.FastWeak
@@ -86,16 +85,14 @@ import Data.Zip (Zip (..))
8685
8786#ifdef DEBUG_CYCLES
8887import Control.Monad.State hiding (forM, forM_, mapM, mapM_, sequence)
89−#endif
90−
9188import Data.List.NonEmpty (NonEmpty (..), nonEmpty)
9289import qualified Data.List.NonEmpty as NonEmpty
90+import Data.Monoid (mempty)
9391import Data.Tree (Forest, Tree (..), drawForest)
94−import Data.List (isPrefixOf)
92+#endif
9593
96−import Data.FastWeakBag (FastWeakBag, FastWeakBagTicket)
94+import Data.FastWeakBag (FastWeakBag)
9795import qualified Data.FastWeakBag as FastWeakBag
98−
9996import Data.Reflection
10097import Data.Some (Some(Some))
10198import Data.Type.Coercion
@@ -106,26 +103,21 @@ import qualified Reflex.Class
106103import qualified Reflex.Class as R
107104import qualified Reflex.Host.Class
108105import Reflex.NotReady.Class
109−import Data.Patch
110−import qualified Data.Patch.DMapWithMove as PatchDMapWithMove
106+import Reflex.Patch
107+import qualified Reflex.Patch.DMapWithMove as PatchDMapWithMove
111108import Reflex.PerformEvent.Base (PerformEventT)
112109
113110#ifdef DEBUG_TRACE_EVENTS
114111import qualified Data.ByteString.Char8 as BS8
115112import System.IO (stderr)
116−import Data.List (isPrefixOf)
117113#endif
118114
119−-- TODO stdout might not be the best channel for debug output
120−debugStrLn :: String -> IO ()
121−debugStrLn = putStrLn
122−
123115#ifdef DEBUG_TRACE_EVENTS
116+
124117withStackOneLine :: (BS8.ByteString -> a) -> a
125118withStackOneLine expr = unsafePerformIO $ do
126119 stack <- currentCallStack
127− return (expr . BS8.pack . unwords . dropInternal . reverse $ stack)
128− where dropInternal = filterStack "Reflex.Spider.Internal"
120+ return (expr (BS8.pack (unwords (reverse stack))))
129121
130122#endif
131123
@@ -136,42 +128,28 @@ debugInvalidateHeight :: Bool
136128debugInvalidate :: Bool
137129
138130#ifdef DEBUG
131+
139132#define DEBUG_NODEIDS
140133
141−#ifdef DEBUG_TRACE_PROPAGATION
142134debugPropagate = True
143−#else
144−debugPropagate = False
145−#endif
146135
147−#ifdef DEBUG_TRACE_HEIGHT
148−debugInvalidateHeight = True
149−#else
150136debugInvalidateHeight = False
151−#endif
152137
153−#ifdef DEBUG_TRACE_INVALIDATION
154138debugInvalidate = True
155−#else
156−debugInvalidate = False
157−#endif
158139
159140class HasNodeId a where
160141 getNodeId :: a -> Int
161142
162−instance HasNodeId (CacheSubscribed x a) where
163− getNodeId = _cacheSubscribed_nodeId
164−
165−instance HasNodeId (FanInt x a) where
166− getNodeId = _fanInt_nodeId
167−
168−instance HasNodeId (Hold x p) where
143+instance HasNodeId (Hold x p a) where
169144 getNodeId = holdNodeId
170145
146+instance HasNodeId (PushSubscribed x a b) where
147+ getNodeId = pushSubscribedNodeId
148+
171149instance HasNodeId (SwitchSubscribed x a) where
172150 getNodeId = switchSubscribedNodeId
173151
174−instance HasNodeId (FanSubscribed x v a) where
152+instance HasNodeId (FanSubscribed x a) where
175153 getNodeId = fanSubscribedNodeId
176154
177155instance HasNodeId (CoincidenceSubscribed x a) where
@@ -185,16 +163,41 @@ instance HasNodeId (Pull x a) where
185163
186164{-# INLINE showNodeId #-}
187165showNodeId :: HasNodeId a => a -> String
188−showNodeId = showNodeId' . getNodeId
189−
190−showNodeId' :: Int -> String
191−showNodeId' = ("#"<>) . show
192−
166+showNodeId = ("#"<>) . show . getNodeId
167+
168+showSubscriberType :: Subscriber x a -> String
169+showSubscriberType = \case
170+ SubscriberPush _ _ -> "SubscriberPush"
171+ SubscriberMerge _ _ -> "SubscriberMerge"
172+ SubscriberFan _ -> "SubscriberFan"
173+ SubscriberMergeChange _ -> "SubscriberMergeChange"
174+ SubscriberHold _ -> "SubscriberHold"
175+ SubscriberHoldIdentity _ -> "SubscriberHoldIdentity"
176+ SubscriberSwitch _ -> "SubscriberSwitch"
177+ SubscriberCoincidenceOuter _ -> "SubscriberCoincidenceOuter"
178+ SubscriberCoincidenceInner _ -> "SubscriberCoincidenceInner"
179+ SubscriberHandle -> "SubscriberHandle"
180+
181+showEventType :: Event x a -> String
182+showEventType = \case
183+ EventRoot _ _ -> "EventRoot"
184+ EventNever -> "EventNever"
185+ EventPush _ -> "EventPush"
186+ EventMerge _ -> "EventMerge"
187+ EventFan _ _ -> "EventFan"
188+ EventSwitch _ -> "EventSwitch"
189+ EventCoincidence _ -> "EventCoincidence"
190+ EventHold _ -> "EventHold"
191+ EventDyn _ -> "EventDyn"
192+ EventHoldIdentity _ -> "EventHoldIdentity"
193+ EventDynIdentity _ -> "EventDynIdentity"
193194
194195#else
195196
196197debugPropagate = False
198+
197199debugInvalidateHeight = False
200+
198201debugInvalidate = False
199202
200203-- This must be inline, or error messages will cause memory leaks due to retaining the node in question
@@ -202,10 +205,6 @@ debugInvalidate = False
202205showNodeId :: a -> String
203206showNodeId _ = ""
204207
205−{-# INLINE showNodeId' #-}
206−showNodeId' :: Int -> String
207−showNodeId' _ = ""
208−
209208#endif
210209
211210#ifdef DEBUG_NODEIDS
@@ -251,9 +250,9 @@ subscribeAndRead = unEvent
251250-- caching; if the computation function is very cheap, this is (much) more
252251-- efficient than 'push'
253252{-# INLINE [1] pushCheap #-}
254−pushCheap :: HasSpiderTimeline x => (a -> ComputeM x (Maybe b)) -> Event x a -> Event x b
253+pushCheap :: (a -> ComputeM x (Maybe b)) -> Event x a -> Event x b
255254pushCheap !f e = Event $ \sub -> do
256− (subscription, occ) <- subscribeAndRead e $ debugSubscriber' "push" $ sub
255+ (subscription, occ) <- subscribeAndRead e $ sub
257256 { subscriberPropagate = \a -> do
258257 mb <- f a
259258 mapM_ (subscriberPropagate sub) mb
@@ -272,10 +271,10 @@ terminalSubscriber p = Subscriber
272271
273272-- | Subscribe to an Event only for the duration of one occurrence
274273{-# INLINE subscribeAndReadHead #-}
275−subscribeAndReadHead :: HasSpiderTimeline x => Event x a -> Subscriber x a -> EventM x (EventSubscription x, Maybe a)
274+subscribeAndReadHead :: Event x a -> Subscriber x a -> EventM x (EventSubscription x, Maybe a)
276275subscribeAndReadHead e sub = do
277276 subscriptionRef <- liftIO $ newIORef $ error "subscribeAndReadHead: not initialized"
278− (subscription, occ) <- subscribeAndRead e $ debugSubscriber' "head" $ sub
277+ (subscription, occ) <- subscribeAndRead e $ sub
279278 { subscriberPropagate = \a -> do
280279 liftIO $ unsubscribe =<< readIORef subscriptionRef
281280 subscriberPropagate sub a
@@ -286,42 +285,24 @@ subscribeAndReadHead e sub = do
286285 return (subscription, occ)
287286
288287--TODO: Make this lazy in its input event
289−headE :: (MonadIO m, Defer (SomeMergeInit x) m, HasSpiderTimeline x) => Event x a -> m (Event x a)
288+headE :: (MonadIO m, Defer (SomeMergeInit x) m) => Event x a -> m (Event x a)
290289headE originalE = do
291290 parent <- liftIO $ newIORef $ Just originalE
292291 defer $ SomeMergeInit $ do --TODO: Rename SomeMergeInit appropriately
293292 let clearParent = liftIO $ writeIORef parent Nothing
294− (_, occ) <- subscribeAndReadHead originalE $ terminalSubscriber $ const clearParent
293+ (_, occ) <- subscribeAndReadHead originalE $ terminalSubscriber $ \_ -> clearParent
295294 when (isJust occ) clearParent
296− return $ Event $ \sub ->
295+ return $ Event $ \sub -> do
297296 liftIO (readIORef parent) >>= \case
298− Nothing -> subscribeAndReadNever
297+ Nothing -> return (EventSubscription (return ()) $ EventSubscribed zeroRef $ toAny (), Nothing)
299298 Just e -> subscribeAndReadHead e sub
300299
301300data CacheSubscribed x a
302301 = CacheSubscribed { _cacheSubscribed_subscribers :: {-# UNPACK #-} !(FastWeakBag (Subscriber x a))
303302 , _cacheSubscribed_parent :: {-# UNPACK #-} !(EventSubscription x)
304303 , _cacheSubscribed_occurrence :: {-# UNPACK #-} !(IORef (Maybe a))
305−#ifdef DEBUG_NODEIDS
306− , _cacheSubscribed_nodeId :: {-# UNPACK #-} !Int
307−#endif
308304 }
309305
310−nowSpiderEventM :: (HasSpiderTimeline x) => EventM x (R.Event (SpiderTimeline x) ())
311−nowSpiderEventM =
312− SpiderEvent <$> now
313−
314−now :: (MonadIO m, Defer (Some Clear) m, HasSpiderTimeline x
315− ) => m (Event x ())
316−now = do
317− nowOrNot <- liftIO $ newIORef $ Just ()
318− scheduleClear nowOrNot
319− return . Event $ \_ -> do
320− occ <- liftIO . readIORef $ nowOrNot
321− return ( EventSubscription (return ()) eventSubscribedNow
322− , occ
323− )
324−
325306-- | Construct an 'Event' whose value is guaranteed not to be recomputed
326307-- repeatedly
327308--
@@ -346,23 +327,18 @@ cacheEvent e =
346327 subscribedTicket <- liftIO (readIORef mSubscribedRef >>= getFastWeakTicket) >>= \case
347328 Just subscribedTicket -> return subscribedTicket
348329 Nothing -> do
349−#ifdef DEBUG_NODEIDS
350− nodeId <- liftIO newNodeId
351−#endif
352330 subscribers <- liftIO FastWeakBag.empty
353331 occRef <- liftIO $ newIORef Nothing -- This should never be read prior to being set below
354−#ifdef DEBUG_NODEIDS
355− (parentSub, occ) <- subscribeAndRead e $ debugSubscriber' ("cacheEvent" <> showNodeId' nodeId) $ Subscriber
356−#else
357332 (parentSub, occ) <- subscribeAndRead e $ Subscriber
358−#endif
359− { subscriberPropagate = \a -> do
360− liftIO $ writeIORef occRef (Just a)
361− scheduleClear occRef
362− propagateFast a subscribers
363− , subscriberInvalidateHeight = FastWeakBag.traverse_ subscribers . invalidateSubscriberHeight
364− , subscriberRecalculateHeight = FastWeakBag.traverse_ subscribers . recalculateSubscriberHeight
365− }
333+ { subscriberPropagate = \a -> do
334+ liftIO $ writeIORef occRef $ Just a
335+ scheduleClear occRef
336+ propagateFast a subscribers
337+ , subscriberInvalidateHeight = \old -> do
338+ FastWeakBag.traverse_ subscribers $ invalidateSubscriberHeight old
339+ , subscriberRecalculateHeight = \new -> do
340+ FastWeakBag.traverse_ subscribers $ recalculateSubscriberHeight new
341+ }
366342 when (isJust occ) $ do
367343 liftIO $ writeIORef occRef occ -- Set the initial value of occRef; we don't need to do this if occ is Nothing
368344 scheduleClear occRef
@@ -370,45 +346,29 @@ cacheEvent e =
370346 { _cacheSubscribed_subscribers = subscribers
371347 , _cacheSubscribed_parent = parentSub
372348 , _cacheSubscribed_occurrence = occRef
373−#ifdef DEBUG_NODEIDS
374− , _cacheSubscribed_nodeId = nodeId
375−#endif
376349 }
377350 subscribedTicket <- liftIO $ mkFastWeakTicket subscribed
378351 liftIO $ writeIORef mSubscribedRef =<< getFastWeakTicketWeak subscribedTicket
379352 return subscribedTicket
380− liftIO $ cacheSubscription sub mSubscribedRef subscribedTicket
381−
382−cacheSubscription :: Subscriber x a -> IORef (FastWeak (CacheSubscribed x a))
383− -> FastWeakTicket (CacheSubscribed x a) -> IO (EventSubscription x, Maybe a)
384−cacheSubscription sub mSubscribedRef subscribedTicket = do
385− subscribed <- getFastWeakTicketValue subscribedTicket
386− ticket <- FastWeakBag.insert sub $ _cacheSubscribed_subscribers subscribed
387− occ <- readIORef $ _cacheSubscribed_occurrence subscribed
388−
389− let parentSub = _cacheSubscribed_parent subscribed
390− es = EventSubscription
391− { _eventSubscription_unsubscribe = do
392− FastWeakBag.remove ticket
393−
394− isEmpty <- FastWeakBag.isEmpty $ _cacheSubscribed_subscribers subscribed
395− when isEmpty $ do
396− writeIORef mSubscribedRef emptyFastWeak
397− unsubscribe parentSub
398− touch ticket
399− touch subscribedTicket
400− , _eventSubscription_subscribed = EventSubscribed
401− { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed parentSub
402− , eventSubscribedRetained = toAny subscribedTicket
403−#ifdef DEBUG_CYCLES
404− , eventSubscribedGetParents = return [_eventSubscription_subscribed parentSub]
405− , eventSubscribedHasOwnHeightRef = False
406− , eventSubscribedWhoCreated = whoCreatedIORef mSubscribedRef
407−#endif
408− }
409− }
410− return (es, occ)
411−
353+ liftIO $ do
354+ subscribed <- getFastWeakTicketValue subscribedTicket
355+ ticket <- FastWeakBag.insert sub $ _cacheSubscribed_subscribers subscribed
356+ occ <- readIORef $ _cacheSubscribed_occurrence subscribed
357+ let es = EventSubscription
358+ { _eventSubscription_unsubscribe = do
359+ FastWeakBag.remove ticket
360+ isEmpty <- FastWeakBag.isEmpty $ _cacheSubscribed_subscribers subscribed
361+ when isEmpty $ do
362+ writeIORef mSubscribedRef emptyFastWeak
363+ unsubscribe $ _cacheSubscribed_parent subscribed
364+ touch ticket
365+ touch subscribedTicket
366+ , _eventSubscription_subscribed = EventSubscribed
367+ { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed $ _cacheSubscribed_parent subscribed
368+ , eventSubscribedRetained = toAny subscribedTicket
369+ }
370+ }
371+ return (es, occ)
412372
413373subscribe :: Event x a -> Subscriber x a -> EventM x (EventSubscription x)
414374subscribe e s = fst <$> subscribeAndRead e s
@@ -420,14 +380,11 @@ wrap tag getSpecificSubscribed sub = do
420380 let es = tag subd
421381 return (EventSubscription (WeakBag.remove sln >> touch sln) es, occ)
422382
423−eventRoot :: (GCompare k, HasSpiderTimeline x) => k a -> Root x k -> Event x a
383+eventRoot :: GCompare k => k a -> Root x k -> Event x a
424384eventRoot !k !r = Event $ wrap eventSubscribedRoot $ liftIO . getRootSubscribed k r
425385
426−subscribeAndReadNever :: EventM x (EventSubscription x, Maybe a)
427−subscribeAndReadNever = return (EventSubscription (return ()) eventSubscribedNever, Nothing)
428−
429386eventNever :: Event x a
430−eventNever = Event $ const subscribeAndReadNever
387+eventNever = Event $ \_ -> return (EventSubscription (return ()) eventSubscribedNever, Nothing)
431388
432389eventFan :: (GCompare k, HasSpiderTimeline x) => k a -> Fan x k v -> Event x (v a)
433390eventFan !k !f = Event $ wrap eventSubscribedFan $ getFanSubscribed k f
@@ -464,6 +421,16 @@ data Subscriber x a = Subscriber
464421 , subscriberRecalculateHeight :: !(Height -> IO ())
465422 }
466423
424+--TODO: Move this comment to WeakBag
425+-- These function are constructor functions that are marked NOINLINE so they are
426+-- opaque to GHC. If we do not do this, then GHC will sometimes fuse the constructor away
427+-- so any weak references that are attached to the constructors will have their
428+-- finalizer run. Using the opaque constructor, does not see the
429+-- constructor application, so it behaves like an IORef and cannot be fused away.
430+--
431+-- The result is also evaluated to WHNF, since forcing a thunk invalidates
432+-- the weak pointer to it in some cases.
433+
467434newSubscriberHold :: (HasSpiderTimeline x, Patch p) => Hold x p -> IO (Subscriber x p)
468435newSubscriberHold h = return $ Subscriber
469436 { subscriberPropagate = {-# SCC "traverseHold" #-} propagateSubscriberHold h
@@ -472,10 +439,10 @@ newSubscriberHold h = return $ Subscriber
472439 }
473440
474441newSubscriberFan :: forall x k v. (HasSpiderTimeline x, GCompare k) => FanSubscribed x k v -> IO (Subscriber x (DMap k v))
475−newSubscriberFan subscribed = debugSubscriber ("SubscriberFan " <> showNodeId subscribed) $ Subscriber
442+newSubscriberFan subscribed = return $ Subscriber
476443 { subscriberPropagate = \a -> {-# SCC "traverseFan" #-} do
477444 subs <- liftIO $ readIORef $ fanSubscribedSubscribers subscribed
478− tracePropagate (Proxy :: Proxy x) $ show (DMap.size subs) <> " keys subscribed, " <> show (DMap.size a) <> " keys firing"
445+ tracePropagate (Proxy :: Proxy x) $ "SubscriberFan" <> showNodeId subscribed <> ": " ++ show (DMap.size subs) ++ " keys subscribed, " ++ show (DMap.size a) ++ " keys firing"
479446 liftIO $ writeIORef (fanSubscribedOccurrence subscribed) $ Just a
480447 scheduleClear $ fanSubscribedOccurrence subscribed
481448 let f _ (Pair v subsubs) = do
@@ -484,40 +451,50 @@ newSubscriberFan subscribed = debugSubscriber ("SubscriberFan " <> showNodeId su
484451 _ <- DMap.traverseWithKey f $ DMap.intersectionWithKey (\_ -> Pair) a subs --TODO: Would be nice to have DMap.traverse_
485452 return ()
486453 , subscriberInvalidateHeight = \old -> do
454+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberFan" <> showNodeId subscribed
487455 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
488456 forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse_ (_fanSubscribedChildren_list v) $ invalidateSubscriberHeight old
457+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberFan" <> showNodeId subscribed <> " done"
489458 , subscriberRecalculateHeight = \new -> do
459+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberFan" <> showNodeId subscribed
490460 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
491461 forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse_ (_fanSubscribedChildren_list v) $ recalculateSubscriberHeight new
462+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberFan" <> showNodeId subscribed <> " done"
492463 }
493464
494465newSubscriberSwitch :: forall x a. HasSpiderTimeline x => SwitchSubscribed x a -> IO (Subscriber x a)
495−newSubscriberSwitch subscribed = debugSubscriber ("SubscriberCoincidenceOuter" <> showNodeId subscribed) $ Subscriber
466+newSubscriberSwitch subscribed = return $ Subscriber
496467 { subscriberPropagate = \a -> {-# SCC "traverseSwitch" #-} do
468+ tracePropagate (Proxy :: Proxy x) $ "SubscriberSwitch" <> showNodeId subscribed
497469 liftIO $ writeIORef (switchSubscribedOccurrence subscribed) $ Just a
498470 scheduleClear $ switchSubscribedOccurrence subscribed
499471 propagate a $ switchSubscribedSubscribers subscribed
500472 , subscriberInvalidateHeight = \_ -> do
473+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed
501474 oldHeight <- readIORef $ switchSubscribedHeight subscribed
502475 when (oldHeight /= invalidHeight) $ do
503476 writeIORef (switchSubscribedHeight subscribed) $! invalidHeight
504477 WeakBag.traverse_ (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
505− , subscriberRecalculateHeight = (`updateSwitchHeight` subscribed)
506− }
478+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed <> " done"
479+ , subscriberRecalculateHeight = \new -> do
480+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed
481+ updateSwitchHeight new subscribed
482+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed <> " done"
483+ }
507484
508485newSubscriberCoincidenceOuter :: forall x b. HasSpiderTimeline x => CoincidenceSubscribed x b -> IO (Subscriber x (Event x b))
509−newSubscriberCoincidenceOuter subscribed = debugSubscriber ("SubscriberCoincidenceOuter" <> showNodeId subscribed) $ Subscriber
486+newSubscriberCoincidenceOuter subscribed = return $ Subscriber
510487 { subscriberPropagate = \a -> {-# SCC "traverseCoincidenceOuter" #-} do
488+ tracePropagate (Proxy :: Proxy x) $ "SubscriberCoincidenceOuter" <> showNodeId subscribed
511489 outerHeight <- liftIO $ readIORef $ coincidenceSubscribedHeight subscribed
512490 tracePropagate (Proxy :: Proxy x) $ " outerHeight = " <> show outerHeight
513491 (occ, innerHeight, innerSubd) <- subscribeCoincidenceInner a outerHeight subscribed
514492 tracePropagate (Proxy :: Proxy x) $ " isJust occ = " <> show (isJust occ)
515493 tracePropagate (Proxy :: Proxy x) $ " innerHeight = " <> show innerHeight
516−
517494 liftIO $ writeIORef (coincidenceSubscribedInnerParent subscribed) $ Just innerSubd
518495 scheduleClear $ coincidenceSubscribedInnerParent subscribed
519496 case occ of
520− Nothing ->
497+ Nothing -> do
521498 when (innerHeight > outerHeight) $ liftIO $ do -- If the event fires, it will fire at a later height
522499 writeIORef (coincidenceSubscribedHeight subscribed) $! innerHeight
523500 WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight outerHeight
@@ -526,13 +503,20 @@ newSubscriberCoincidenceOuter subscribed = debugSubscriber ("SubscriberCoinciden
526503 liftIO $ writeIORef (coincidenceSubscribedOccurrence subscribed) occ
527504 scheduleClear $ coincidenceSubscribedOccurrence subscribed
528505 propagate o $ coincidenceSubscribedSubscribers subscribed
529− , subscriberInvalidateHeight = \_ -> invalidateCoincidenceHeight subscribed
530− , subscriberRecalculateHeight = \_ -> recalculateCoincidenceHeight subscribed
506+ , subscriberInvalidateHeight = \_ -> do
507+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed
508+ invalidateCoincidenceHeight subscribed
509+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed <> " done"
510+ , subscriberRecalculateHeight = \_ -> do
511+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed
512+ recalculateCoincidenceHeight subscribed
513+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed <> " done"
531514 }
532515
533516newSubscriberCoincidenceInner :: forall x a. HasSpiderTimeline x => CoincidenceSubscribed x a -> IO (Subscriber x a)
534−newSubscriberCoincidenceInner subscribed = debugSubscriber ("SubscriberCoincidenceInner" <> showNodeId subscribed) $ Subscriber
517+newSubscriberCoincidenceInner subscribed = return $ Subscriber
535518 { subscriberPropagate = \a -> {-# SCC "traverseCoincidenceInner" #-} do
519+ tracePropagate (Proxy :: Proxy x) $ "SubscriberCoincidenceInner" <> showNodeId subscribed
536520 occ <- liftIO $ readIORef $ coincidenceSubscribedOccurrence subscribed
537521 case occ of
538522 Just _ -> return () -- SubscriberCoincidenceOuter must have already propagated this event
@@ -540,8 +524,14 @@ newSubscriberCoincidenceInner subscribed = debugSubscriber ("SubscriberCoinciden
540524 liftIO $ writeIORef (coincidenceSubscribedOccurrence subscribed) $ Just a
541525 scheduleClear $ coincidenceSubscribedOccurrence subscribed
542526 propagate a $ coincidenceSubscribedSubscribers subscribed
543− , subscriberInvalidateHeight = \_ -> invalidateCoincidenceHeight subscribed
544− , subscriberRecalculateHeight = \_ -> recalculateCoincidenceHeight subscribed
527+ , subscriberInvalidateHeight = \_ -> do
528+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed
529+ invalidateCoincidenceHeight subscribed
530+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed <> " done"
531+ , subscriberRecalculateHeight = \_ -> do
532+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed
533+ recalculateCoincidenceHeight subscribed
534+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed <> " done"
545535 }
546536
547537invalidateSubscriberHeight :: Height -> Subscriber x a -> IO ()
@@ -551,15 +541,15 @@ recalculateSubscriberHeight :: Height -> Subscriber x a -> IO ()
551541recalculateSubscriberHeight = flip subscriberRecalculateHeight
552542
553543-- | Propagate everything at the current height
554−propagate :: forall x a. HasSpiderTimeline x => a -> WeakBag (Subscriber x a) -> EventM x ()
555−propagate a subscribers = withIncreasedDepth (Proxy::Proxy x) $
544+propagate :: a -> WeakBag (Subscriber x a) -> EventM x ()
545+propagate a subscribers = withIncreasedDepth $ do
556546 -- Note: in the following traversal, we do not visit nodes that are added to the list during our traversal; they are new events, which will necessarily have full information already, so there is no need to traverse them
557547 --TODO: Should we check if nodes already have their values before propagating? Maybe we're re-doing work
558548 WeakBag.traverse_ subscribers $ \s -> subscriberPropagate s a
559549
560550-- | Propagate everything at the current height
561−propagateFast :: forall x a. HasSpiderTimeline x => a -> FastWeakBag (Subscriber x a) -> EventM x ()
562−propagateFast a subscribers = withIncreasedDepth (Proxy::Proxy x) $
551+propagateFast :: a -> FastWeakBag (Subscriber x a) -> EventM x ()
552+propagateFast a subscribers = withIncreasedDepth $ do
563553 -- Note: in the following traversal, we do not visit nodes that are added to the list during our traversal; they are new events, which will necessarily have full information already, so there is no need to traverse them
564554 --TODO: Should we check if nodes already have their values before propagating? Maybe we're re-doing work
565555 FastWeakBag.traverse_ subscribers $ \s -> subscriberPropagate s a
@@ -580,7 +570,7 @@ data EventSubscribed x = EventSubscribed
580570 { eventSubscribedHeightRef :: {-# UNPACK #-} !(IORef Height)
581571 , eventSubscribedRetained :: {-# NOUNPACK #-} !Any
582572#ifdef DEBUG_CYCLES
583− , eventSubscribedGetParents :: !(IO [EventSubscribed x]) -- For debugging loops
573+ , eventSubscribedGetParents :: !(IO [Some (EventSubscribed x)]) -- For debugging loops
584574 , eventSubscribedHasOwnHeightRef :: !Bool
585575 , eventSubscribedWhoCreated :: !(IO [String])
586576#endif
@@ -607,23 +597,13 @@ eventSubscribedNever = EventSubscribed
607597 , eventSubscribedWhoCreated = return ["never"]
608598#endif
609599 }
610−eventSubscribedNow :: EventSubscribed x
611−eventSubscribedNow = EventSubscribed
612− { eventSubscribedHeightRef = zeroRef
613− , eventSubscribedRetained = toAny ()
614−#ifdef DEBUG_CYCLES
615− , eventSubscribedGetParents = return []
616− , eventSubscribedHasOwnHeightRef = False
617− , eventSubscribedWhoCreated = return ["now"]
618−#endif
619− }
620600
621601eventSubscribedFan :: FanSubscribed x k v -> EventSubscribed x
622602eventSubscribedFan !subscribed = EventSubscribed
623603 { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed $ fanSubscribedParent subscribed
624604 , eventSubscribedRetained = toAny subscribed
625605#ifdef DEBUG_CYCLES
626− , eventSubscribedGetParents = return [_eventSubscription_subscribed $ fanSubscribedParent subscribed]
606+ , eventSubscribedGetParents = return [Some $ _eventSubscription_subscribed $ fanSubscribedParent subscribed]
627607 , eventSubscribedHasOwnHeightRef = False
628608 , eventSubscribedWhoCreated = whoCreatedIORef $ fanSubscribedCachedSubscribed subscribed
629609#endif
@@ -636,7 +616,7 @@ eventSubscribedSwitch !subscribed = EventSubscribed
636616#ifdef DEBUG_CYCLES
637617 , eventSubscribedGetParents = do
638618 s <- readIORef $ switchSubscribedCurrentParent subscribed
639− return [_eventSubscription_subscribed s]
619+ return [Some $ _eventSubscription_subscribed s]
640620 , eventSubscribedHasOwnHeightRef = True
641621 , eventSubscribedWhoCreated = whoCreatedIORef $ switchSubscribedCachedSubscribed subscribed
642622#endif
@@ -649,8 +629,8 @@ eventSubscribedCoincidence !subscribed = EventSubscribed
649629#ifdef DEBUG_CYCLES
650630 , eventSubscribedGetParents = do
651631 innerSubscription <- readIORef $ coincidenceSubscribedInnerParent subscribed
652− let outerParent = _eventSubscription_subscribed $ coincidenceSubscribedOuterParent subscribed
653− innerParents = maybeToList $ innerSubscription
632+ let outerParent = Some $ _eventSubscription_subscribed $ coincidenceSubscribedOuterParent subscribed
633+ innerParents = maybeToList $ fmap Some innerSubscription
654634 return $ outerParent : innerParents
655635 , eventSubscribedHasOwnHeightRef = True
656636 , eventSubscribedWhoCreated = whoCreatedIORef $ coincidenceSubscribedCachedSubscribed subscribed
@@ -664,15 +644,15 @@ getEventSubscribedHeight es = readIORef $ eventSubscribedHeightRef es
664644whoCreatedEventSubscribed :: EventSubscribed x -> IO [String]
665645whoCreatedEventSubscribed = eventSubscribedWhoCreated
666646
667−walkInvalidHeightParents :: EventSubscribed x -> IO [EventSubscribed x]
647+walkInvalidHeightParents :: EventSubscribed x -> IO [Some (EventSubscribed x)]
668648walkInvalidHeightParents s0 = do
669− subscribers <- flip execStateT mempty $ ($ s0) $ fix $ \loop s -> do
649+ subscribers <- flip execStateT mempty $ ($ Some s0) $ fix $ \loop (Some s) -> do
670650 h <- liftIO $ readIORef $ eventSubscribedHeightRef s
671651 when (h == invalidHeight) $ do
672652 when (eventSubscribedHasOwnHeightRef s) $ liftIO $ writeIORef (eventSubscribedHeightRef s) $! invalidHeightBeingTraversed
673− modify (s :)
653+ modify (Some s :)
674654 mapM_ loop =<< liftIO (eventSubscribedGetParents s)
675− forM_ subscribers $ \s -> writeIORef (eventSubscribedHeightRef s) $! invalidHeight
655+ forM_ subscribers $ \(Some s) -> writeIORef (eventSubscribedHeightRef s) $! invalidHeight
676656 return subscribers
677657#endif
678658
@@ -1057,7 +1037,7 @@ data SomeMergeUpdate x = SomeMergeUpdate
10571037newtype SomeMergeInit x = SomeMergeInit { unSomeMergeInit :: EventM x () }
10581038
10591039-- EventM can do everything BehaviorM can, plus create holds
1060−newtype EventM x a = EventM { unEventM :: IO a } deriving (Functor, Applicative, Monad, MonadIO, MonadFix, MonadException, MonadAsyncException)
1040+newtype EventM x a = EventM { unEventM :: IO a } deriving (Functor, Applicative, Monad, MonadIO, MonadFix, MonadException, MonadAsyncException) -- The environment should be Nothing if we are not in a frame, and Just if we are - in which case it is a list of assignments to be done after the frame is over
10611041
10621042newtype MergeSubscribedParent x a = MergeSubscribedParent { unMergeSubscribedParent :: EventSubscription x }
10631043
@@ -1082,8 +1062,7 @@ heightBagFromList :: [Height] -> HeightBag
10821062heightBagFromList heights = heightBagVerify $ foldl' (flip heightBagAdd) heightBagEmpty heights
10831063
10841064heightBagAdd :: Height -> HeightBag -> HeightBag
1085−heightBagAdd (Height h) (HeightBag s c) = heightBagVerify $ HeightBag (succ s) $
1086− IntMap.insertWithKey (\_ _ old -> succ old) h 0 c
1065+heightBagAdd (Height h) (HeightBag s c) = heightBagVerify $ HeightBag (succ s) $ IntMap.insertWithKey (\_ _ old -> succ old) h 0 c
10871066
10881067heightBagRemove :: Height -> HeightBag -> HeightBag
10891068heightBagRemove (Height h) b@(HeightBag s c) = heightBagVerify $ case IntMap.lookup h c of
@@ -1092,13 +1071,6 @@ heightBagRemove (Height h) b@(HeightBag s c) = heightBagVerify $ case IntMap.loo
10921071 0 -> IntMap.delete h c
10931072 _ -> IntMap.insert h (pred old) c
10941073
1095−heightBagRemoveMaybe :: Height -> HeightBag -> Maybe HeightBag
1096−heightBagRemoveMaybe (Height h) b@(HeightBag s c) = heightBagVerify . removed <$> IntMap.lookup h c where
1097− removed old = HeightBag (pred s) $ case old of
1098− 0 -> IntMap.delete h c
1099− _ -> IntMap.insert h (pred old) c
1100−
1101−
11021074heightBagMax :: HeightBag -> Height
11031075heightBagMax (HeightBag _ c) = case IntMap.maxViewWithKey c of
11041076 Just ((h, _), _) -> Height h
@@ -1346,110 +1318,55 @@ mkWeakPtrWithDebug x debugNote = do
13461318 x' <- evaluate x
13471319 mkWeakPtr x' $
13481320 if debugFinalize
1349− then Just $ debugStrLn $ "finalizing: " ++ debugNote
1321+ then Just $ putStrLn $ "finalizing: " ++ debugNote
13501322 else Nothing
13511323
13521324type WeakList a = [Weak a]
13531325
1354−type CanTrace x m = (HasSpiderTimeline x, MonadIO m)
1355−
1356−
1357−
1358−
1359−#ifdef DEBUG
1360−
1361−debugSubscriber :: forall x a. HasSpiderTimeline x => String -> Subscriber x a -> IO (Subscriber x a)
1362−debugSubscriber description = return . debugSubscriber' description
1363−
1364−debugSubscriber' :: forall x a. HasSpiderTimeline x => String -> Subscriber x a -> Subscriber x a
1365−debugSubscriber' description subscribed = Subscriber
1366− {
1367− subscriberPropagate = \m -> do
1368− tracePropagate (Proxy :: Proxy x) ("subscriberPropagate: " <> description)
1369− subscriberPropagate subscribed m
1370− , subscriberInvalidateHeight = \old -> do
1371− traceInvalidateHeight $ "invalidateSubscriberHeight: " <> description <> ", old = " <> show (unHeight old)
1372− subscriberInvalidateHeight subscribed old
1373− traceInvalidateHeight $ "invalidateSubscriberHeight: " <> description <> ", done"
1374− , subscriberRecalculateHeight = \new -> do
1375− traceInvalidateHeight $ "subscriberRecalculateHeight: " <> description <> ", new = " <> show (unHeight new)
1376− subscriberRecalculateHeight subscribed new
1377− traceInvalidateHeight $ "subscriberRecalculateHeight: " <> description <> ", done"
1378− }
1379−
1380−
13811326{-# INLINE withIncreasedDepth #-}
1382−withIncreasedDepth :: forall proxy x m a. CanTrace x m => proxy x -> m a -> m a
1383−withIncreasedDepth _ a = do
1384− liftIO $ modifyIORef' (_spiderTimeline_depth $ unSTE (spiderTimeline :: SpiderTimelineEnv x)) succ
1327+#ifdef DEBUG
1328+withIncreasedDepth :: CanTrace x m => m a -> m a
1329+withIncreasedDepth a = do
1330+ spiderTimeline <- askSpiderTimelineEnv
1331+ liftIO $ modifyIORef' (_spiderTimeline_depth (unSTE spiderTimeline)) succ
13851332 result <- a
1386− liftIO $ modifyIORef' (_spiderTimeline_depth $ unSTE (spiderTimeline :: SpiderTimelineEnv x)) pred
1333+ liftIO $ modifyIORef' (_spiderTimeline_depth (unSTE spiderTimeline)) pred
13871334 return result
1388−
1389−{-# INLINE tracePropagate #-}
1390−tracePropagate :: (CanTrace x m) => proxy x -> String -> m ()
1391−tracePropagate p = when debugPropagate . trace p
1392−
1393−{-# INLINE traceInvalidate #-}
1394−traceInvalidate :: String -> IO ()
1395−traceInvalidate = when debugInvalidate . liftIO . debugStrLn
1396−
1397−{-# INLINE traceInvalidateHeight #-}
1398−traceInvalidateHeight :: String -> IO ()
1399−traceInvalidateHeight = when debugInvalidateHeight . liftIO . debugStrLn
1400−
1401−{-# INLINE trace #-}
1402−trace :: (CanTrace x m) => proxy x -> String -> m ()
1403−trace p message = traceM p $ return message
1404−
1405−{-# INLINE traceM #-}
1406−traceM :: forall x proxy m. (CanTrace x m) => proxy x -> m String -> m ()
1407−traceM _ getMessage = do
1408− message <- getMessage
1409− d <- liftIO $ readIORef $ _spiderTimeline_depth $ unSTE (spiderTimeline :: SpiderTimelineEnv x)
1410− liftIO $ debugStrLn $ replicate d ' ' <> message
1411−
14121335#else
1336+withIncreasedDepth :: m a -> m a
1337+withIncreasedDepth = id
1338+#endif
14131339
1414−{-# INLINE withIncreasedDepth #-}
1415−withIncreasedDepth :: proxy x -> m a -> m a
1416−withIncreasedDepth _ = id
1340+type CanTrace x m = (HasSpiderTimeline x, MonadIO m)
14171341
14181342{-# INLINE tracePropagate #-}
14191343tracePropagate :: (CanTrace x m) => proxy x -> String -> m ()
1420−tracePropagate _ _ = return ()
1344+tracePropagate p = traceWhen p debugPropagate
14211345
14221346{-# INLINE traceInvalidate #-}
14231347traceInvalidate :: String -> IO ()
1424−traceInvalidate _ = return ()
1425−
1426−{-# INLINE traceInvalidateHeight #-}
1427−traceInvalidateHeight :: String -> IO ()
1428−traceInvalidateHeight _ = return ()
1429−
1430−{-# INLINE debugSubscriber #-}
1431−debugSubscriber :: String -> Subscriber x a -> IO (Subscriber x a)
1432−debugSubscriber _ = return
1433−
1434−{-# INLINE debugSubscriber' #-}
1435−debugSubscriber' :: String -> Subscriber x a -> Subscriber x a
1436−debugSubscriber' _ = id
1348+traceInvalidate = when debugInvalidate . liftIO . putStrLn
14371349
1350+{-# INLINE traceWhen #-}
1351+traceWhen :: (CanTrace x m) => proxy x -> Bool -> String -> m ()
1352+traceWhen p b message = traceMWhen p b $ return message
14381353
1439−
1440−{-# INLINE trace #-}
1441−trace :: (CanTrace x m) => proxy x -> String -> m ()
1442−trace _ _ = return ()
1443−
1444−{-# INLINE traceM #-}
1445−traceM :: (CanTrace x m) => proxy x -> m String -> m ()
1446−traceM _ _ = return ()
1447−
1354+{-# INLINE traceMWhen #-}
1355+traceMWhen :: (CanTrace x m) => proxy x -> Bool -> m String -> m ()
1356+traceMWhen _ b getMessage = when b $ do
1357+ message <- getMessage
1358+#ifdef DEBUG
1359+ spiderTimeline <- askSpiderTimelineEnv
1360+ d <- liftIO $ readIORef $ _spiderTimeline_depth $ unSTE spiderTimeline
1361+#else
1362+ let d = 0
14481363#endif
1364+ liftIO $ putStrLn $ replicate d ' ' <> message
14491365
14501366whoCreatedIORef :: IORef a -> IO [String]
14511367whoCreatedIORef (IORef a) = whoCreated $! a
14521368
1369+#ifdef DEBUG_CYCLES
14531370groupByHead :: Eq a => [NonEmpty a] -> [(a, NonEmpty [a])]
14541371groupByHead = \case
14551372 [] -> []
@@ -1460,54 +1377,20 @@ groupByHead = \case
14601377 | otherwise -> (x, xs :| []) : l
14611378
14621379listsToForest :: Eq a => [[a]] -> Forest a
1463−listsToForest lists = buildForest <$> groupByHead (mapMaybe nonEmpty lists)
1464− where buildForest (a, lists') = Node a $ listsToForest $ toList lists'
1465−
1466−showStacks :: [[String]] -> String
1467−showStacks = drawForest . listsToForest . fmap (filterStack "Reflex.Spider.Internal")
1468−
1469−filterStack :: String -> [String] -> [String]
1470−#ifdef DEBUG_HIDE_INTERNALS
1471−filterStack prefix = filter (not . (prefix `isPrefixOf`))
1472−#else
1473−filterStack prefix = id
1380+listsToForest l = fmap (\(a, l') -> Node a $ listsToForest $ toList l') $ groupByHead $ catMaybes $ fmap nonEmpty l
14741381#endif
14751382
1476−#ifdef DEBUG_CYCLES
1477−
1478−data EventLoopException = EventLoopException [[String]]
1479−instance Exception EventLoopException
1480−
1481−instance Show EventLoopException where
1482− show (EventLoopException stacks) = "causality loop detected:\n" <> if null stacks
1483− then "no location information, compile with profiling enabled for stack tree"
1484− else showStacks stacks
1485−
1486−#else
1487−
1488−data EventLoopException = EventLoopException
1489−instance Exception EventLoopException
1490−
1491−instance Show EventLoopException where
1492− show EventLoopException = "causality loop detected: \n" <>
1493− "compile reflex with flag 'debug-cycles' and compile with profiling enabled for stack tree"
1494−
1495−#endif
1496−
1497−
14981383{-# INLINE propagateSubscriberHold #-}
14991384propagateSubscriberHold :: forall x p. (HasSpiderTimeline x, Patch p) => Hold x p -> p -> EventM x ()
15001385propagateSubscriberHold h a = do
1501− {-# SCC "trace" #-} when debugPropagate $ traceM (Proxy :: Proxy x) $ liftIO $ do
1386+ {-# SCC "trace" #-} traceMWhen (Proxy :: Proxy x) debugPropagate $ liftIO $ do
15021387 invalidators <- liftIO $ readIORef $ holdInvalidators h
15031388 return $ "SubscriberHold" <> showNodeId h <> ": " ++ show (length invalidators)
1504−
15051389 v <- {-# SCC "read" #-} liftIO $ readIORef $ holdValue h
15061390 case {-# SCC "apply" #-} apply a v of
15071391 Nothing -> return ()
15081392 Just v' -> do
1509− {-# SCC "trace2" #-} withIncreasedDepth (Proxy :: Proxy x) $
1510− tracePropagate (Proxy :: Proxy x) ("propagateSubscriberHold: assigning Hold" <> showNodeId h)
1393+ {-# SCC "trace2" #-} withIncreasedDepth $ tracePropagate (Proxy :: Proxy x) $ "propagateSubscriberHold: assigning Hold" <> showNodeId h
15111394 vRef <- {-# SCC "vRef" #-} liftIO $ evaluate $ holdValue h
15121395 iRef <- {-# SCC "iRef" #-} liftIO $ evaluate $ holdInvalidators h
15131396 defer $ {-# SCC "assignment" #-} SomeAssignment vRef iRef v'
@@ -1561,7 +1444,7 @@ getDynHold d = do
15611444zeroRef :: IORef Height
15621445zeroRef = unsafePerformIO $ newIORef zeroHeight
15631446
1564−getRootSubscribed :: forall k x a. (GCompare k, HasSpiderTimeline x) => k a -> Root x k -> Subscriber x a -> IO (WeakBagTicket, RootSubscribed x a, Maybe a)
1447+getRootSubscribed :: GCompare k => k a -> Root x k -> Subscriber x a -> IO (WeakBagTicket, RootSubscribed x a, Maybe a)
15651448getRootSubscribed k r sub = do
15661449 mSubscribed <- readIORef $ rootSubscribed r
15671450 let getOcc = fmap (coerce . DMap.lookup k) $ readIORef $ rootOccurrence r
@@ -1575,9 +1458,7 @@ getRootSubscribed k r sub = do
15751458 let !cached = rootSubscribed r
15761459 uninitRef <- newIORef $ error "getRootsubscribed: uninitRef not initialized"
15771460 (subs, sln) <- WeakBag.singleton sub weakSelf cleanupRootSubscribed
1578−
1579− tracePropagate (Proxy::Proxy x) $ "getRootSubscribed: calling rootInit"
1580−
1461+ when debugPropagate $ putStrLn $ "getRootSubscribed: calling rootInit"
15811462 uninit <- rootInit r k $ RootTrigger (subs, rootOccurrence r, k)
15821463 writeIORef uninitRef $! uninit
15831464#ifdef DEBUG_NODEIDS
@@ -1627,9 +1508,6 @@ data FanInt x a = FanInt
16271508 { _fanInt_subscribers :: {-# UNPACK #-} !(FastMutableIntMap (FastWeakBag (Subscriber x a))) --TODO: Clean up the keys in here when their child weak bags get empty --TODO: Remove our own subscription when the subscribers list is completely empty
16281509 , _fanInt_subscriptionRef :: {-# UNPACK #-} !(IORef (EventSubscription x)) -- This should have a valid subscription iff subscribers is non-empty
16291510 , _fanInt_occRef :: {-# UNPACK #-} !(IORef (IntMap a))
1630−#ifdef DEBUG_NODEIDS
1631− , _fanInt_nodeId :: {-# UNPACK #-} !Int
1632−#endif
16331511 }
16341512
16351513newFanInt :: IO (FanInt x a)
@@ -1637,16 +1515,10 @@ newFanInt = do
16371515 subscribers <- FastMutableIntMap.newEmpty --TODO: Clean up the keys in here when their child weak bags get empty --TODO: Remove our own subscription when the subscribers list is completely empty
16381516 subscriptionRef <- newIORef $ error "fanInt: no subscription"
16391517 occRef <- newIORef $ error "fanInt: no occurrence"
1640−#ifdef DEBUG_NODEIDS
1641− nodeId <- newNodeId
1642−#endif
16431518 return $ FanInt
16441519 { _fanInt_subscribers = subscribers
16451520 , _fanInt_subscriptionRef = subscriptionRef
16461521 , _fanInt_occRef = occRef
1647−#ifdef DEBUG_NODEIDS
1648− , _fanInt_nodeId = nodeId
1649−#endif
16501522 }
16511523
16521524fanInt :: HasSpiderTimeline x => Event x (IntMap a) -> EventSelectorInt x a
@@ -1655,21 +1527,20 @@ fanInt p = unsafePerformIO $ do
16551527 pure $ EventSelectorInt $ \k -> Event $ \sub -> do
16561528 isEmpty <- liftIO $ FastMutableIntMap.isEmpty (_fanInt_subscribers self)
16571529 when isEmpty $ do -- This is the first subscriber, so we need to subscribe to our input
1658− let desc = "fanInt" <> showNodeId self <> ", k = " <> show k
1659− (subscription, parentOcc) <- subscribeAndRead p $ debugSubscriber' desc $ Subscriber
1530+ (subscription, parentOcc) <- subscribeAndRead p $ Subscriber
16601531 { subscriberPropagate = \m -> do
16611532 liftIO $ writeIORef (_fanInt_occRef self) m
16621533 scheduleIntClear $ _fanInt_occRef self
1663− FastMutableIntMap.forIntersectionWithImmutable_ (_fanInt_subscribers self) m $ \b v -> --TODO: Do we need to know that no subscribers are being added as we traverse?
1664− FastWeakBag.traverse_ b $ \s ->
1534+ FastMutableIntMap.forIntersectionWithImmutable_ (_fanInt_subscribers self) m $ \b v -> do --TODO: Do we need to know that no subscribers are being added as we traverse?
1535+ FastWeakBag.traverse_ b $ \s -> do
16651536 subscriberPropagate s v
1666− , subscriberInvalidateHeight = \old ->
1667− FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b ->
1668− FastWeakBag.traverse_ b $ \s ->
1537+ , subscriberInvalidateHeight = \old -> do
1538+ FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b -> do
1539+ FastWeakBag.traverse_ b $ \s -> do
16691540 subscriberInvalidateHeight s old
1670− , subscriberRecalculateHeight = \new ->
1671− FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b ->
1672− FastWeakBag.traverse_ b $ \s ->
1541+ , subscriberRecalculateHeight = \new -> do
1542+ FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b -> do
1543+ FastWeakBag.traverse_ b $ \s -> do
16731544 subscriberRecalculateHeight s new
16741545 }
16751546 liftIO $ do
@@ -1683,25 +1554,10 @@ fanInt p = unsafePerformIO $ do
16831554 FastMutableIntMap.insert (_fanInt_subscribers self) k b
16841555 return b
16851556 Just b -> return b
1686− ticket <- liftIO $ FastWeakBag.insert sub b
1557+ t <- liftIO $ FastWeakBag.insert sub b
16871558 currentOcc <- readIORef (_fanInt_occRef self)
1688−
1689− subscribed <- fanIntSubscribed ticket self
1690− return (EventSubscription (FastWeakBag.remove ticket) subscribed, IntMap.lookup k currentOcc)
1691−
1692−fanIntSubscribed :: FastWeakBagTicket k -> FanInt x a -> IO (EventSubscribed x)
1693−fanIntSubscribed ticket self = do
1694− subscribedParent <- _eventSubscription_subscribed <$> readIORef (_fanInt_subscriptionRef self)
1695− return $ EventSubscribed
1696− { eventSubscribedHeightRef = eventSubscribedHeightRef subscribedParent
1697− , eventSubscribedRetained = toAny (_fanInt_subscriptionRef self, ticket)
1698−#ifdef DEBUG_CYCLES
1699− , eventSubscribedGetParents = return [subscribedParent]
1700− , eventSubscribedHasOwnHeightRef = False
1701− , eventSubscribedWhoCreated = whoCreatedIORef $ _fanInt_subscriptionRef self
1702−#endif
1703− }
1704−
1559+ (EventSubscription _ (EventSubscribed !heightRef _)) <- readIORef (_fanInt_subscriptionRef self)
1560+ return (EventSubscription (FastWeakBag.remove t) $! EventSubscribed heightRef $! toAny (_fanInt_subscriptionRef self, t), IntMap.lookup k currentOcc)
17051561
17061562{-# INLINABLE getFanSubscribed #-}
17071563getFanSubscribed :: (HasSpiderTimeline x, GCompare k) => k a -> Fan x k v -> Subscriber x (v a) -> EventM x (WeakBagTicket, FanSubscribed x k v, Maybe (v a))
@@ -1899,7 +1755,7 @@ mergeCheap
18991755 => (forall a. q a -> Event x (v a))
19001756 -> DynamicS x (PatchDMap k q)
19011757 -> Event x (DMap k v)
1902−mergeCheap nt = mergeGCheap' unMergeSubscribedParent getInitialSubscribers updateMe destroy
1758+mergeCheap nt = mergeGCheap' getInitialSubscribers updateMe destroy
19031759 where
19041760 updateMe :: MergeUpdateFunc k v x (PatchDMap k q) (MergeSubscribedParent x)
19051761 updateMe subscriber heightBagRef oldParents (PatchDMap p) = do
@@ -1914,9 +1770,7 @@ mergeCheap nt = mergeGCheap' unMergeSubscribedParent getInitialSubscribers updat
19141770 liftIO $ modifyIORef' heightBagRef $ heightBagAdd newParentHeight
19151771 return $ DMap.insertLookupWithKey' (\_ new _ -> new) k newParent ps
19161772 forM_ mOldSubd $ \oldSubd -> do
1917− oldHeight <- liftIO $ getEventSubscribedHeight $
1918− _eventSubscription_subscribed $ unMergeSubscribedParent oldSubd
1919−
1773+ oldHeight <- liftIO $ getEventSubscribedHeight $ _eventSubscription_subscribed $ unMergeSubscribedParent oldSubd
19201774 liftIO $ modifyIORef heightBagRef $ heightBagRemove oldHeight
19211775 return (maybeToList (unMergeSubscribedParent <$> mOldSubd) ++ subscriptionsToKill, newPs)
19221776 foldM f ([], oldParents) $ DMap.toList p
@@ -1941,7 +1795,7 @@ mergeCheapWithMove :: forall k x v q. (HasSpiderTimeline x, GCompare k)
19411795 => (forall a. q a -> Event x (v a))
19421796 -> DynamicS x (PatchDMapWithMove k q)
19431797 -> Event x (DMap k v)
1944−mergeCheapWithMove nt = mergeGCheap' _mergeSubscribedParentWithMove_subscription getInitialSubscribers updateMe destroy
1798+mergeCheapWithMove nt = mergeGCheap' getInitialSubscribers updateMe destroy
19451799 where
19461800 updateMe :: MergeUpdateFunc k v x (PatchDMapWithMove k q) (MergeSubscribedParentWithMove x k)
19471801 updateMe subscriber heightBagRef oldParents p = do
@@ -1960,17 +1814,13 @@ mergeCheapWithMove nt = mergeGCheap' _mergeSubscribedParentWithMove_subscription
19601814 let moveOrDelete :: forall a. k a -> PatchDMapWithMove.NodeInfo k q a -> MergeSubscribedParentWithMove x k a -> Constant (EventM x (Maybe (EventSubscription x))) a
19611815 moveOrDelete _ ni parent = Constant $ case getComposeMaybe $ PatchDMapWithMove._nodeInfo_to ni of
19621816 Nothing -> do
1963− oldHeight <- liftIO $ getEventSubscribedHeight $ _eventSubscription_subscribed $
1964− _mergeSubscribedParentWithMove_subscription parent
1965−
1817+ oldHeight <- liftIO $ getEventSubscribedHeight $ _eventSubscription_subscribed $ _mergeSubscribedParentWithMove_subscription parent
19661818 liftIO $ modifyIORef heightBagRef $ heightBagRemove oldHeight
19671819 return $ Just $ _mergeSubscribedParentWithMove_subscription parent
19681820 Just toKey -> do
19691821 liftIO $ writeIORef (_mergeSubscribedParentWithMove_key parent) $! toKey
19701822 return Nothing
1971− toDelete <- fmap catMaybes $ mapM (\(_ :=> v) -> getConstant v) $ DMap.toList $
1972− DMap.intersectionWithKey moveOrDelete (unPatchDMapWithMove p) oldParents
1973−
1823+ toDelete <- fmap catMaybes $ mapM (\(_ :=> v) -> getConstant v) $ DMap.toList $ DMap.intersectionWithKey moveOrDelete (unPatchDMapWithMove p) oldParents
19741824 return (toDelete, applyAlways p' oldParents)
19751825 getInitialSubscribers :: MergeInitFunc k v q x (MergeSubscribedParentWithMove x k)
19761826 getInitialSubscribers initialParents subscriber = do
@@ -1995,8 +1845,6 @@ type MergeUpdateFunc k v x p s
19951845 -> p
19961846 -> EventM x ([EventSubscription x], DMap k s)
19971847
1998−type MergeGetSubscription x s = forall a. s a -> EventSubscription x
1999−
20001848type MergeInitFunc k v q x s
20011849 = DMap k q
20021850 -> (forall a. EventM x (k a) -> Subscriber x (v a))
@@ -2020,17 +1868,14 @@ invalidateMergeHeight m = invalidateMergeHeight' (_merge_heightRef m) (_merge_su
20201868invalidateMergeHeight' :: IORef Height -> Subscriber x a -> IO ()
20211869invalidateMergeHeight' heightRef sub = do
20221870 oldHeight <- readIORef heightRef
2023− -- If the height used to be valid, it must be invalid now; we should never have *more* heights than we have parents
2024− when (oldHeight /= invalidHeight) $ do
1871+ when (oldHeight /= invalidHeight) $ do -- If the height used to be valid, it must be invalid now; we should never have *more* heights than we have parents
20251872 writeIORef heightRef $! invalidHeight
20261873 subscriberInvalidateHeight sub oldHeight
20271874
20281875revalidateMergeHeight :: Merge x k v s -> IO ()
20291876revalidateMergeHeight m = do
20301877 currentHeight <- readIORef $ _merge_heightRef m
2031−
2032− -- revalidateMergeHeight may be called multiple times; perhaps the's a way to finesse it to avoid this check
2033− when (currentHeight == invalidHeight) $ do
1878+ when (currentHeight == invalidHeight) $ do -- revalidateMergeHeight may be called multiple times; perhaps the's a way to finesse it to avoid this check
20341879 heights <- readIORef $ _merge_heightBagRef m
20351880 parents <- readIORef $ _merge_parentsRef m
20361881 -- When the number of heights in the bag reaches the number of parents, we should have a valid height
@@ -2038,7 +1883,7 @@ revalidateMergeHeight m = do
20381883 LT -> return ()
20391884 EQ -> do
20401885 let height = succHeight $ heightBagMax heights
2041− traceInvalidateHeight $ "recalculateSubscriberHeight: height: " <> show height
1886+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: height: " <> show height
20421887 writeIORef (_merge_heightRef m) $! height
20431888 subscriberRecalculateHeight (_merge_sub m) height
20441889 GT -> error $ "revalidateMergeHeight: more heights (" <> show (heightBagSize heights) <> ") than parents (" <> show (DMap.size parents) <> ") for Merge"
@@ -2046,45 +1891,36 @@ revalidateMergeHeight m = do
20461891scheduleMergeSelf :: HasSpiderTimeline x => Merge x k v s -> Height -> EventM x ()
20471892scheduleMergeSelf m height = scheduleMerge' height (_merge_heightRef m) $ do
20481893 vals <- liftIO $ readIORef $ _merge_accumRef m
2049− -- Once we're done with this, we can clear it immediately, because if there's a cacheEvent in front of us,
2050− -- it'll handle subsequent subscribers, and if not, we won't get subsequent subscribers
2051− liftIO $ writeIORef (_merge_accumRef m) $! DMap.empty
1894+ liftIO $ writeIORef (_merge_accumRef m) $! DMap.empty -- Once we're done with this, we can clear it immediately, because if there's a cacheEvent in front of us, it'll handle subsequent subscribers, and if not, we won't get subsequent subscribers
20521895 --TODO: Assert that m is not empty
20531896 subscriberPropagate (_merge_sub m) vals
20541897
2055−checkCycle :: HasSpiderTimeline x => EventSubscribed x -> EventM x ()
2056−checkCycle subscribed = liftIO $ do
2057− height <- readIORef (eventSubscribedHeightRef subscribed)
2058−
2059− -- currentHeight <- getCurrentHeight
2060− -- when (height <= currentHeight) $ if height /= invalidHeight
2061− -- then do
2062− -- myStack <- liftIO $ whoCreatedIORef undefined --TODO
2063− -- error $ "Height (" ++ show height ++ ") is not greater than current height (" ++ show currentHeight ++ ")\n" ++ unlines (reverse myStack)
2064− -- else liftIO $
2065− when (height == invalidHeight) $
2066−#ifdef DEBUG_CYCLES
2067− do
2068− nodesInvolvedInCycle <- walkInvalidHeightParents subscribed
2069− stacks <- forM nodesInvolvedInCycle whoCreatedEventSubscribed
2070− throwIO (EventLoopException stacks)
2071−#else
2072− throwIO EventLoopException
2073−#endif
2074−
2075−
2076−mergeSubscriber :: forall x k v s a. (HasSpiderTimeline x, GCompare k) => EventSubscribed x -> Merge x k v s -> EventM x (k a) -> Subscriber x (v a)
2077−mergeSubscriber subscribed m getKey = Subscriber
1898+mergeSubscriber :: forall x k v s a. (HasSpiderTimeline x, GCompare k) => Merge x k v s -> EventM x (k a) -> Subscriber x (v a)
1899+mergeSubscriber m getKey = Subscriber
20781900 { subscriberPropagate = \a -> do
20791901 oldM <- liftIO $ readIORef $ _merge_accumRef m
20801902 k <- getKey
2081− let newM = DMap.insertWith (error "Same key fired multiple times for Merge") k a oldM
1903+ let newM = DMap.insertWith (error $ "Same key fired multiple times for Merge") k a oldM
20821904 tracePropagate (Proxy :: Proxy x) $ " DMap.size oldM = " <> show (DMap.size oldM) <> "; DMap.size newM = " <> show (DMap.size newM)
20831905 liftIO $ writeIORef (_merge_accumRef m) $! newM
20841906 when (DMap.null oldM) $ do -- Only schedule the firing once
20851907 height <- liftIO $ readIORef $ _merge_heightRef m
2086− checkCycle subscribed
2087−
1908+ --TODO: assertions about height
1909+ currentHeight <- getCurrentHeight
1910+ when (height <= currentHeight) $ do
1911+ if height /= invalidHeight
1912+ then do
1913+ myStack <- liftIO $ whoCreatedIORef undefined --TODO
1914+ error $ "Height (" ++ show height ++ ") is not greater than current height (" ++ show currentHeight ++ ")\n" ++ unlines (reverse myStack)
1915+ else liftIO $ do
1916+#ifdef DEBUG_CYCLES
1917+ nodesInvolvedInCycle <- walkInvalidHeightParents $ eventSubscribedMerge subscribed
1918+ stacks <- forM nodesInvolvedInCycle $ \(Some es) -> whoCreatedEventSubscribed es
1919+ let cycleInfo = ":\n" <> drawForest (listsToForest stacks)
1920+#else
1921+ let cycleInfo = ""
1922+#endif
1923+ error $ "Causality loop found" <> cycleInfo
20881924 scheduleMergeSelf m height
20891925 , subscriberInvalidateHeight = \old -> do --TODO: When removing a parent doesn't actually change the height, maybe we can avoid invalidating
20901926 modifyIORef' (_merge_heightBagRef m) $ heightBagRemove old
@@ -2095,45 +1931,31 @@ mergeSubscriber subscribed m getKey = Subscriber
20951931 }
20961932
20971933--TODO: Be able to run as much of this as possible promptly
2098−updateMerge :: (HasSpiderTimeline x, GCompare k) => EventSubscribed x -> Merge x k v s -> MergeUpdateFunc k v x p s -> p -> SomeMergeUpdate x
2099−updateMerge subscribed m updateFunc p = SomeMergeUpdate updateMe (invalidateMergeHeight m) (revalidateMergeHeight m)
1934+updateMerge :: (HasSpiderTimeline x, GCompare k) => Merge x k v s -> MergeUpdateFunc k v x p s -> p -> SomeMergeUpdate x
1935+updateMerge m updateFunc p = SomeMergeUpdate updateMe (invalidateMergeHeight m) (revalidateMergeHeight m)
21001936 where updateMe = do
21011937 oldParents <- liftIO $ readIORef $ _merge_parentsRef m
2102− (subscriptionsToKill, newParents) <- updateFunc (mergeSubscriber subscribed m) (_merge_heightBagRef m) oldParents p
1938+ (subscriptionsToKill, newParents) <- updateFunc (mergeSubscriber m) (_merge_heightBagRef m) oldParents p
21031939 liftIO $ writeIORef (_merge_parentsRef m) $! newParents
21041940 return subscriptionsToKill
21051941
21061942{-# INLINE mergeGCheap' #-}
21071943mergeGCheap' :: forall k v x p s q. (HasSpiderTimeline x, GCompare k, PatchTarget p ~ DMap k q)
2108− => MergeGetSubscription x s -> MergeInitFunc k v q x s -> MergeUpdateFunc k v x p s -> MergeDestroyFunc k s -> DynamicS x p -> Event x (DMap k v)
2109−mergeGCheap' getParent getInitialSubscribers updateFunc destroy d = Event $ \sub -> do
1944+ => MergeInitFunc k v q x s -> MergeUpdateFunc k v x p s -> MergeDestroyFunc k s -> DynamicS x p -> Event x (DMap k v)
1945+mergeGCheap' getInitialSubscribers updateFunc destroy d = Event $ \sub -> do
21101946 initialParents <- readBehaviorUntracked $ dynamicCurrent d
21111947 accumRef <- liftIO $ newIORef $ error "merge: accumRef not yet initialized"
21121948 heightRef <- liftIO $ newIORef $ error "merge: heightRef not yet initialized"
21131949 heightBagRef <- liftIO $ newIORef $ error "merge: heightBagRef not yet initialized"
21141950 parentsRef :: IORef (DMap k s) <- liftIO $ newIORef $ error "merge: parentsRef not yet initialized"
2115− changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
2116−
2117− let subscribed = EventSubscribed
2118− { eventSubscribedHeightRef = heightRef
2119− , eventSubscribedRetained = toAny (parentsRef, changeSubdRef)
2120−#ifdef DEBUG_CYCLES
2121− , eventSubscribedGetParents = do
2122− let getParent' (_ :=> v) = _eventSubscription_subscribed (getParent v)
2123− fmap getParent' . DMap.toList <$> readIORef parentsRef
2124− , eventSubscribedHasOwnHeightRef = False
2125− , eventSubscribedWhoCreated = whoCreatedIORef heightRef
2126−#endif
2127− }
2128−
2129− m = Merge
1951+ let m = Merge
21301952 { _merge_parentsRef = parentsRef
21311953 , _merge_heightBagRef = heightBagRef
21321954 , _merge_heightRef = heightRef
21331955 , _merge_sub = sub
21341956 , _merge_accumRef = accumRef
21351957 }
2136− (dm, heights, initialParentState) <- getInitialSubscribers initialParents $ mergeSubscriber subscribed m
1958+ (dm, heights, initialParentState) <- getInitialSubscribers initialParents $ mergeSubscriber m
21371959 let myHeightBag = heightBagFromList $ filter (/= invalidHeight) heights
21381960 myHeight = if invalidHeight `elem` heights
21391961 then invalidHeight
@@ -2142,29 +1964,31 @@ mergeGCheap' getParent getInitialSubscribers updateFunc destroy d = Event $ \sub
21421964 let (occ, accum) = if currentHeight >= myHeight -- If we should have fired by now
21431965 then (if DMap.null dm then Nothing else Just dm, DMap.empty)
21441966 else (Nothing, dm)
2145− unless (DMap.null accum) $ scheduleMergeSelf m myHeight
1967+ unless (DMap.null accum) $ do
1968+ scheduleMergeSelf m myHeight
21461969 liftIO $ writeIORef accumRef $! accum
21471970 liftIO $ writeIORef heightRef $! myHeight
21481971 liftIO $ writeIORef heightBagRef $! myHeightBag
1972+ changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
21491973 liftIO $ writeIORef parentsRef $! initialParentState
21501974 defer $ SomeMergeInit $ do
2151− let changeSubscriber = Subscriber
1975+ let s = Subscriber
21521976 { subscriberPropagate = \a -> {-# SCC "traverseMergeChange" #-} do
2153− tracePropagate (Proxy :: Proxy x) "SubscriberMerge/Change"
2154− defer $ updateMerge subscribed m updateFunc a
1977+ tracePropagate (Proxy :: Proxy x) $ "SubscriberMerge/Change"
1978+ defer $ updateMerge m updateFunc a
21551979 , subscriberInvalidateHeight = \_ -> return ()
21561980 , subscriberRecalculateHeight = \_ -> return ()
21571981 }
2158− (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) changeSubscriber
2159− forM_ change $ \c -> defer $ updateMerge subscribed m updateFunc c
1982+ (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) s
1983+ forM_ change $ \c -> defer $ updateMerge m updateFunc c
21601984 -- We explicitly hold on to the unsubscribe function from subscribing to the update event.
21611985 -- If we don't do this, there are certain cases where mergeCheap will fail to properly retain
21621986 -- its subscription.
2163− liftIO $ writeIORef changeSubdRef (changeSubscriber, changeSubscription)
1987+ liftIO $ writeIORef changeSubdRef (s, changeSubscription)
21641988 let unsubscribeAll = destroy =<< readIORef parentsRef
2165−
2166− return (EventSubscription unsubscribeAll subscribed, occ)
2167−
1989+ return ( EventSubscription unsubscribeAll $ EventSubscribed heightRef $ toAny (parentsRef, changeSubdRef)
1990+ , occ
1991+ )
21681992
21691993mergeInt :: forall x a. (HasSpiderTimeline x) => DynamicS x (PatchIntMap (Event x a)) -> Event x (IntMap a)
21701994mergeInt = cacheEvent . mergeIntCheap
@@ -2177,22 +2001,13 @@ mergeIntCheap d = Event $ \sub -> do
21772001 heightRef <- liftIO $ newIORef zeroHeight
21782002 heightBagRef <- liftIO $ newIORef heightBagEmpty
21792003 parents <- liftIO $ FastMutableIntMap.newEmpty
2180− changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
2181− let subscribed = EventSubscribed
2182− { eventSubscribedHeightRef = heightRef
2183− , eventSubscribedRetained = toAny (parents, changeSubdRef)
2184−#ifdef DEBUG_CYCLES
2185− , eventSubscribedGetParents = fmap (_eventSubscription_subscribed . snd) <$> FastMutableIntMap.toList parents
2186− , eventSubscribedHasOwnHeightRef = False
2187− , eventSubscribedWhoCreated = whoCreatedIORef heightRef
2188−#endif
2189− }
21902004 let scheduleSelf = do
21912005 height <- liftIO $ readIORef $ heightRef
21922006 scheduleMerge' height heightRef $ do
21932007 vals <- liftIO $ FastMutableIntMap.getFrozenAndClear accum
21942008 subscriberPropagate sub vals
2195− invalidateMyHeight = invalidateMergeHeight' heightRef sub
2009+ invalidateMyHeight = do
2010+ invalidateMergeHeight' heightRef sub
21962011 recalculateMyHeight = do
21972012 currentHeight <- readIORef heightRef
21982013 when (currentHeight == invalidHeight) $ do --TODO: This will almost always be true; can we get rid of this check and just proceed to the next one always?
@@ -2202,14 +2017,12 @@ mergeIntCheap d = Event $ \sub -> do
22022017 LT -> return ()
22032018 EQ -> do
22042019 let height = succHeight $ heightBagMax heights
2205− traceInvalidateHeight $ "recalculateSubscriberHeight: height: " <> show height
2020+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: height: " <> show height
22062021 writeIORef heightRef $! height
22072022 subscriberRecalculateHeight sub height
22082023 GT -> error $ "revalidateMergeHeight: more heights (" <> show (heightBagSize heights) <> ") than parents (" <> show numParents <> ") for Merge"
22092024 mySubscriber k = Subscriber
22102025 { subscriberPropagate = \a -> do
2211− checkCycle subscribed
2212−
22132026 wasEmpty <- liftIO $ FastMutableIntMap.isEmpty accum
22142027 liftIO $ FastMutableIntMap.insert accum k a
22152028 when wasEmpty scheduleSelf
@@ -2243,6 +2056,7 @@ mergeIntCheap d = Event $ \sub -> do
22432056 else liftIO $ Just <$> FastMutableIntMap.getFrozenAndClear accum
22442057 else do when (not isEmpty) scheduleSelf -- We have things accumulated, but we shouldn't have fired them yet
22452058 return Nothing
2059+ changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
22462060 defer $ SomeMergeInit $ do
22472061 let updateMe a = SomeMergeUpdate u invalidateMyHeight recalculateMyHeight
22482062 where
@@ -2256,27 +2070,25 @@ mergeIntCheap d = Event $ \sub -> do
22562070 oldParents <- liftIO $ FastMutableIntMap.applyPatch parents newSubscriptions
22572071 liftIO $ for_ oldParents $ \oldParent -> do
22582072 oldParentHeight <- getEventSubscribedHeight $ _eventSubscription_subscribed oldParent
2259−
2260− print ("updateMe", oldParentHeight)
22612073 modifyIORef' heightBagRef $ heightBagRemove oldParentHeight
22622074 return $ IntMap.elems oldParents
2263− let changeSubscriber = Subscriber
2075+ let s = Subscriber
22642076 { subscriberPropagate = \a -> {-# SCC "traverseMergeChange" #-} do
22652077 tracePropagate (Proxy :: Proxy x) $ "SubscriberMergeInt/Change"
22662078 defer $ updateMe a
22672079 , subscriberInvalidateHeight = \_ -> return ()
22682080 , subscriberRecalculateHeight = \_ -> return ()
22692081 }
2270− (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) changeSubscriber
2082+ (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) s
22712083 forM_ change $ \c -> defer $ updateMe c
22722084 -- We explicitly hold on to the unsubscribe function from subscribing to the update event.
22732085 -- If we don't do this, there are certain cases where mergeCheap will fail to properly retain
22742086 -- its subscription.
2275− liftIO $ writeIORef changeSubdRef (changeSubscriber, changeSubscription)
2087+ liftIO $ writeIORef changeSubdRef (s, changeSubscription)
22762088 let unsubscribeAll = traverse_ unsubscribe =<< FastMutableIntMap.getFrozenAndClear parents
2277−
2278−
2279− return (EventSubscription unsubscribeAll subscribed, occ)
2089+ return ( EventSubscription unsubscribeAll $ EventSubscribed heightRef $ toAny (parents, changeSubdRef)
2090+ , occ
2091+ )
22802092
22812093newtype EventSelector x k = EventSelector { select :: forall a. k a -> Event x a }
22822094newtype EventSelectorG x k v = EventSelectorG { selectG :: forall a. k a -> Event x (v a) }
@@ -2359,19 +2171,19 @@ runFrame a = SpiderHost $ do
23592171 coincidenceInfos <- readIORef $ eventEnvResetCoincidences env
23602172 forM_ toAssign $ \(SomeAssignment vRef iRef v) -> {-# SCC "assignment" #-} do
23612173 writeIORef vRef v
2362− traceInvalidate $ "Invalidating Hold"
2174+ when debugInvalidate $ putStrLn $ "Invalidating Hold"
23632175 writeIORef iRef =<< evaluate =<< invalidate toReconnectRef =<< readIORef iRef
23642176 mergeUpdates <- readIORef $ eventEnvMergeUpdates env
23652177 writeIORef (eventEnvMergeUpdates env) []
2366− tracePropagate (Proxy::Proxy x) $ "Updating merges"
2178+ when debugPropagate $ putStrLn "Updating merges"
23672179 mergeSubscriptionsToKill <- runEventM $ concat <$> mapM _someMergeUpdate_update mergeUpdates
2368− tracePropagate (Proxy::Proxy x) $ "Updating merges done"
2180+ when debugPropagate $ putStrLn "Updating merges done"
23692181 toReconnect <- readIORef toReconnectRef
23702182 clearEventEnv env
23712183 switchSubscriptionsToKill <- forM toReconnect $ \(SomeSwitchSubscribed subscribed) -> {-# SCC "switchSubscribed" #-} do
23722184 oldSubscription <- readIORef $ switchSubscribedCurrentParent subscribed
23732185 wi <- readIORef $ switchSubscribedOwnWeakInvalidator subscribed
2374− traceInvalidate $ "Finalizing invalidator for Switch" <> showNodeId subscribed
2186+ when debugInvalidate $ putStrLn $ "Finalizing invalidator for Switch" <> showNodeId subscribed
23752187 finalize wi
23762188 i <- evaluate $ switchSubscribedOwnInvalidator subscribed
23772189 wi' <- mkWeakPtrWithDebug i "wi'"
@@ -2385,7 +2197,7 @@ runFrame a = SpiderHost $ do
23852197 subscription <- unSpiderHost $ runFrame $ {-# SCC "subscribeSwitch" #-} subscribe e sub --TODO: Assert that the event isn't firing --TODO: This should not loop because none of the events should be firing, but still, it is inefficient
23862198 {-
23872199 stackTrace <- liftIO $ fmap renderStack $ ccsToStrings =<< (getCCSOf $! switchSubscribedParent subscribed)
2388− liftIO $ debugStrLn $ (++stackTrace) $ "subd' subscribed to " ++ case e of
2200+ liftIO $ putStrLn $ (++stackTrace) $ "subd' subscribed to " ++ case e of
23892201 EventRoot _ -> "EventRoot"
23902202 EventNever -> "EventNever"
23912203 _ -> "something else"
@@ -2520,8 +2332,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Event
25202332 {-# INLINABLE headE #-}
25212333 headE = R.slowHeadE
25222334-- headE (SpiderEvent e) = SpiderEvent <$> Reflex.Spider.Internal.headE e
2523− {-# INLINABLE now #-}
2524− now = nowSpiderEventM
25252335
25262336instance Reflex.Class.MonadSample (SpiderTimeline x) (SpiderPullM x) where
25272337 {-# INLINABLE sample #-}
@@ -2543,9 +2353,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Spide
25432353 {-# INLINABLE headE #-}
25442354 headE = R.slowHeadE
25452355-- headE (SpiderEvent e) = SpiderPushM $ SpiderEvent <$> Reflex.Spider.Internal.headE e
2546− {-# INLINABLE now #-}
2547− now = SpiderPushM nowSpiderEventM
2548−
25492356
25502357instance HasSpiderTimeline x => Monad (Reflex.Class.Dynamic (SpiderTimeline x)) where
25512358 {-# INLINE return #-}
@@ -2609,9 +2416,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Spide
26092416 buildDynamic getV0 e = runFrame . runSpiderHostFrame $ Reflex.Class.buildDynamic getV0 e
26102417 {-# INLINABLE headE #-}
26112418 headE e = runFrame . runSpiderHostFrame $ Reflex.Class.headE e
2612− {-# INLINABLE now #-}
2613− now = runFrame . runSpiderHostFrame $ Reflex.Class.now
2614−
26152419
26162420instance HasSpiderTimeline x => Reflex.Class.MonadSample (SpiderTimeline x) (SpiderHostFrame x) where
26172421 sample = SpiderHostFrame . readBehaviorUntracked . unSpiderBehavior --TODO: This can cause problems with laziness, so we should get rid of it if we can
@@ -2628,8 +2432,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Spide
26282432 {-# INLINABLE headE #-}
26292433 headE = R.slowHeadE
26302434-- headE (SpiderEvent e) = SpiderHostFrame $ SpiderEvent <$> Reflex.Spider.Internal.headE e
2631− {-# INLINABLE now #-}
2632− now = SpiderHostFrame Reflex.Class.now
26332435
26342436instance HasSpiderTimeline x => Reflex.Class.MonadSample (SpiderTimeline x) (SpiderHost x) where
26352437 {-# INLINABLE sample #-}
@@ -2650,8 +2452,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Refle
26502452 buildDynamic getV0 e = Reflex.Spider.Internal.ReadPhase $ Reflex.Class.buildDynamic getV0 e
26512453 {-# INLINABLE headE #-}
26522454 headE e = Reflex.Spider.Internal.ReadPhase $ Reflex.Class.headE e
2653− {-# INLINABLE now #-}
2654− now = Reflex.Spider.Internal.ReadPhase Reflex.Class.now
26552455
26562456--------------------------------------------------------------------------------
26572457-- Deprecated items
@@ -2689,13 +2489,13 @@ instance HasSpiderTimeline x => Reflex.Host.Class.MonadReadEvent (SpiderTimeline
26892489 touch h
26902490 return result
26912491
2692−instance HasSpiderTimeline x => Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHost x) where
2492+instance Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHost x) where
26932493 newEventWithTrigger = SpiderHost . fmap SpiderEvent . newEventWithTriggerIO
26942494 newFanEventWithTrigger f = SpiderHost $ do
26952495 es <- newFanEventWithTriggerIO f
26962496 return $ Reflex.Class.EventSelector $ SpiderEvent . Reflex.Spider.Internal.select es
26972497
2698−instance HasSpiderTimeline x => Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHostFrame x) where
2498+instance Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHostFrame x) where
26992499 newEventWithTrigger = SpiderHostFrame . EventM . liftIO . fmap SpiderEvent . newEventWithTriggerIO
27002500 newFanEventWithTrigger f = SpiderHostFrame $ EventM $ liftIO $ do
27012501 es <- newFanEventWithTriggerIO f
@@ -2775,7 +2575,7 @@ instance HasSpiderTimeline x => R.Reflex (SpiderTimeline x) where
27752575 fanG e = R.EventSelectorG $ SpiderEvent . selectG (fanG (unSpiderEvent e))
27762576 {-# INLINABLE mergeG #-}
27772577 mergeG
2778− :: forall k2 (k :: k2 -> *) q (v :: k2 -> *). GCompare k
2578+ :: forall (k :: k2 -> *) q (v :: k2 -> *). GCompare k
27792579 => (forall a. q a -> R.Event (SpiderTimeline x) (v a))
27802580 -> DMap k q
27812581 -> R.Event (SpiderTimeline x) (DMap k v)
@@ -2881,12 +2681,12 @@ instance NotReady (SpiderTimeline x) (SpiderHostFrame x) where
28812681 notReadyUntil _ = pure ()
28822682 notReady = pure ()
28832683
2884−newEventWithTriggerIO :: forall x a. HasSpiderTimeline x => (RootTrigger x a -> IO (IO ())) -> IO (Event x a)
2684+newEventWithTriggerIO :: (RootTrigger x a -> IO (IO ())) -> IO (Event x a)
28852685newEventWithTriggerIO f = do
28862686 es <- newFanEventWithTriggerIO $ \Refl -> f
28872687 return $ select es Refl
28882688
2889−newFanEventWithTriggerIO :: (HasSpiderTimeline x, GCompare k) => (forall a. k a -> RootTrigger x a -> IO (IO ())) -> IO (EventSelector x k)
2689+newFanEventWithTriggerIO :: GCompare k => (forall a. k a -> RootTrigger x a -> IO (IO ())) -> IO (EventSelector x k)
28902690newFanEventWithTriggerIO f = do
28912691 occRef <- newIORef DMap.empty
28922692 subscribedRef <- newIORef DMap.empty
@@ -2927,4 +2727,4 @@ instance NotReady (SpiderTimeline x) (SpiderHost x) where
29272727
29282728instance HasSpiderTimeline x => NotReady (SpiderTimeline x) (PerformEventT (SpiderTimeline x) (SpiderHost x)) where
29292729 notReadyUntil _ = return ()
2930− notReady = return ()
2730+ notReady = return ()