on bccbe42 help sign in
.github/workflows/haskell.ymldeleted−41
since splitsnapshots
unifiedsplit
@@ -1,41 +0,0 @@
1−name: github-action
2−
3−on: [push, pull_request]
4−
5−jobs:
6− build:
7− strategy:
8− matrix:
9− ghc: ['8.4.4', '8.6.5', '8.8.4', '8.10.2']
10− os: ['ubuntu-latest', 'macos-latest']
11− runs-on: ${{ matrix.os }}
12−
13− name: GHC ${{ matrix.ghc }} on ${{ matrix.os }}
14− steps:
15− - uses: actions/checkout@v2
16− - uses: actions/setup-haskell@v1
17− with:
18− ghc-version: ${{ matrix.ghc }}
19− - name: Cache
20− uses: actions/cache@v1
21− env:
22− cache-name: cache-cabal
23− with:
24− path: ~/.cabal
25− key: ${{ runner.os }}-${{ matrix.ghc }}-build-${{ env.cache-name }}-${{ hashFiles('**/*.cabal') }}-${{ hashFiles('**/cabal.project') }}
26− restore-keys: |
27− ${{ runner.os }}-${{ matrix.ghc }}-build-${{ env.cache-name }}-
28− ${{ runner.os }}-${{ matrix.ghc }}-build-
29− ${{ runner.os }}-${{ matrix.ghc }}-
30− ${{ runner.os }}
31−
32− - name: Install dependencies
33− run: |
34− cabal update
35− cabal build --only-dependencies --enable-tests --enable-benchmarks
36− - name: Build
37− run: cabal build --enable-tests --enable-benchmarks all
38− - name: Run tests
39− run: cabal test all
40− - name: Build Docs
41− run: cabal haddock
CONTRIBUTING.md−9
@@ -5,7 +5,6 @@ Contributions and issue reports are encouraged and appreciated!
5- [Opening Issues](#opening-issues)
5- [Opening Issues](#opening-issues)
6- [Submitting Changes](#submitting-changes)
6- [Submitting Changes](#submitting-changes)
7 - [Guidelines for Commit Messages](#guidelines-for-commit-messages)
7 - [Guidelines for Commit Messages](#guidelines-for-commit-messages)
8− - [Guidelines for Pull Requests](#guidelines-for-pull-requests)
9 - [Code Quality](#code-quality)
8 - [Code Quality](#code-quality)
10 - [Documentation](#documentation)
9 - [Documentation](#documentation)
11
10
@@ -31,10 +30,6 @@ One way to think about it is that your commit message should be able to complete
31#### Body
30#### Body
32For breaking changes, new features, refactors, or other major changes, the body of the commit message should describe the motivation behind the change in greater detail and may include references to the issue tracker. The body shouldn't repeat code/comments from the diff.
31For breaking changes, new features, refactors, or other major changes, the body of the commit message should describe the motivation behind the change in greater detail and may include references to the issue tracker. The body shouldn't repeat code/comments from the diff.
33
32
34−### Guidelines for Pull Requests
35−
36−Wherever possible, pull requests should add a single feature or fix a single bug. Pull requests should not bundle several unrelated changes.
37−
38### Code Quality
33### Code Quality
39
34
40#### Warnings
35#### Warnings
@@ -45,10 +40,6 @@ Your pull request should add no new warnings to the project. It should also gene
45
40
46Make sure the project builds and that the tests pass! This will generally also be checked by CI before merge, but trying it yourself first means you'll catch problems earlier and your contribution can be merged that much sooner!
41Make sure the project builds and that the tests pass! This will generally also be checked by CI before merge, but trying it yourself first means you'll catch problems earlier and your contribution can be merged that much sooner!
47
42
48−#### Dependencies
49−
50−Include version bounds whenever adding a dependency to the library stanza of the cabal file. Note that libraries added to reflex.cabal also need to be added to default.nix.
51−
52### Documentation
43### Documentation
53
44
54#### In the code
45#### In the code
ChangeLog.md−129
@@ -1,151 +1,22 @@
1# Revision history for reflex
1# Revision history for reflex
2
2
3−## 0.8.2.0
4−
5−* Add `matchResponseMapWithRequests`, which it similar to `matchResponsesWithRequests` but allows processing of multiple responses at once.
6−
7−## 0.8.1.1
8−
9−* Allow newer hlint for older GHCs, and add upper bound for newer GHCs
10−
11−## 0.8.1.0
12−
13−* Add support for GHC 8.10
14−* Drop support for GHC < 8.4
15−
16−## 0.8.0.0
17−
18−* Replace 0.7.2.0 with 0.8.0.0 to reflect the `MonadHold` interface change. Deprecates 0.7.2.0.
19−
20−## 0.7.2.0 -- *Deprecated*
21−
22−* ([#416](https://github.com/reflex-frp/reflex/pull/416)) Add `now :: m (Event t ())` to `MonadHold`.
23−* Extend some dependency version bounds
24−* Fix HLint 3 test
25−
26−## 0.7.1.1
27−
28−*Backport release*.
29−Changes do not carry forward to 0.7.2.0.
30−
31−* Add support for GHC 8.10
32−* Drop support for GHC < 8.4
33−* Extend some dependency version bounds
34−* Fix HLint 3 test
35−
36−## 0.7.1.0
37−
38−* ([#413](https://github.com/reflex-frp/reflex/pull/413), [#417](https://github.com/reflex-frp/reflex/pull/417)) Add `Reflex.Host.Headless` module which provides `runHeadlessApp` as an easy way to run a Reflex network in a "headless" environment.
39−* ([#420](https://github.com/reflex-frp/reflex/pull/420)) Add a [`Data.Zip.Unzip`](https://hackage.haskell.org/package/semialign-1.1/docs/Data-Zip.html#t:Unzip) instance for `Event`.
40−* ([#419](https://github.com/reflex-frp/reflex/pull/419)) Add `distributeIntMapOverDynPure` and `joinDynThroughIntMap` as convenience functions for working with `Dynamic` `IntMap`s.
41−
42−
43−## 0.7.0.0
44−
45−* Add lifting instances for most classes to `Reflex.Profiled.Profiled`. ([#398](https://github.com/reflex-frp/reflex/pull/398))
46−* Class `MonadQuery t q m` now has a `Monad m` superclass constraint. ([#400](https://github.com/reflex-frp/reflex/pull/400))
47−* **(Breaking change)** Rename class `MonadBehaviorWriter` -> `BehaviorWriter` for consistency with `EventWriter`/`DynamicWriter`. ([#401](https://github.com/reflex-frp/reflex/pull/401))
48−* Introduce deprecated alias `MonadBehaviorWriter = BehaviorWriter`. ([#401](https://github.com/reflex-frp/reflex/pull/401))
49−* Fix bug in spider where event subscriptions would be prematurely finalized due to over-aggressive inlining. ([#409](https://github.com/reflex-frp/reflex/pull/409))
50−* Add instances of `PerformEvent` and `TriggerEvent` for `MaybeT`. ([#395](https://github.com/reflex-frp/reflex/pull/395))
51−
52−## 0.6.4.1
53−
54−* Fix a bug in the Reflex Profiled transformer where
55− `Reflex.Class.mergeIncrementalG` and
56− `Reflex.Class.mergeIncrementalWithMoveG` implementations referenced
57− itself instead of the inner transformed timeline, causing an
58− infinite loop.
59−
60−## 0.6.4
61−
62−* Support GHC 8.8
63−
64−* Add `Reflex.Query.Base.mapQueryT`. See that module for documentation
65−
66−* The `Reflex.Patch.*` modules were moved to the `patch` library.
67− They are `Data.Patch.*` there, but reexported under their old names for backwards compatability here.
68−
69−* Additional instances for `Query` classes for basic types.
70−
71−* Add cabal flags `debug-propagation` and `debug-event-cycles` to build in debugging
72− code for performance and for cyclic dependencies between events
73−
74−## 0.6.3
75−
76−* `Data.WeakBag.traverse` and `Data.FastWeakBag.traverse` have been deprecated.
77− They are replaced with `Data.WeakBag.traverse_` and `Data.FastWeakBag.traverse_`, respectively.
78−
79−* Fixes a bug in `Reflex.Patch.MapWithMove.patchThatSortsMapWith` that was producing invalid `PatchMapWithMove`.
80−
81−* Add missing `NotReady` instances:
82− - `instance NotReady (SpiderTimeline x) (SpiderHost x)`
83− - `instance HasSpiderTimeline x => NotReady (SpiderTimeline x) (PerformEventT (SpiderTimeline x) (SpiderHost x))`
84−
85−## 0.6.2.4
86−
87−* Update to monoidal-containers 0.6
88−
89−## 0.6.2.3
90−
91−* Add an upper-bound to witherable
92−
93−## 0.6.2.2
94−
95−* Support these >= 1. Add `split-these` flag to control whether to use new these/semialign combination or not.
96−
97−* Update version bounds to fix some CI failures
98−
99−* Add travis CI configuration
100−
101−## 0.6.2.1
102−
103−* Generalize `fan` to `fanG` to take a `DMap` with non-`Identity`
104− functor:
105− * `fan` to `fanG`
106− * `EventSelectorG` for `fanG` result selector.
107−
108−* Reduce the amount of unsafeCoerce in coercing newtypes under Event/Dynamic/Behavior.
109− * Add fused ReaderIO for the purpose of coercion (ReaderT's third argument has nominal role preventing automated coerce)
110− * Add incrementalCoercion/coerceIncremental to go with dynamicCoercion/coerceDynamic
111−
112−* Generalize merging functions:
113− `merge` to `mergeG`,
114− `mergeIncremental` to `mergeIncrementalG`,
115− `mergeIncrementalWithMove` to `mergeIncrementalWithMoveG`.
116−
117−* Generalize distribute function:
118− `distributeDMapOverDynPure` to `distributeDMapOverDynPureG`,
119−
120## 0.6.2.0
3## 0.6.2.0
121
4
122−* Fix `holdDyn` so that it is lazy in its event argument
123− These produce `DMap`s whose values needn't be `Identity`.
124−
125* Stop using the now-deprecated `*Tag` classes (e.g., `ShowTag`).
5* Stop using the now-deprecated `*Tag` classes (e.g., `ShowTag`).
126−
127* Fix `holdDyn` so that it is lazy in its event argument.
6* Fix `holdDyn` so that it is lazy in its event argument.
128
7
129## 0.6.1.0
8## 0.6.1.0
130
9
131* Re-export all of `Data.Map.Monoidal`
10* Re-export all of `Data.Map.Monoidal`
132−
133* Fix `QueryT` and `RequesterT` tests
11* Fix `QueryT` and `RequesterT` tests
134
12
135## 0.6.0.0 -- 2019-03-20
13## 0.6.0.0 -- 2019-03-20
136
14
137* Deprecate `FunctorMaybe` in favor of `Data.Witherable.Filterable`. We still export `fmapMaybe`, `ffilter`, etc., but they all rely on `Filterable` now.
15* Deprecate `FunctorMaybe` in favor of `Data.Witherable.Filterable`. We still export `fmapMaybe`, `ffilter`, etc., but they all rely on `Filterable` now.
138−
139* Rename `MonadDynamicWriter` to `DynamicWriter` and add a deprecation for the old name.
16* Rename `MonadDynamicWriter` to `DynamicWriter` and add a deprecation for the old name.
140−
141* Remove many deprecated functions.
17* Remove many deprecated functions.
142−
143* Add a `Num` instance for `Dynamic`.
18* Add a `Num` instance for `Dynamic`.
144−
145* Add `matchRequestsWithResponses` to make it easier to use `Requester` with protocols that don't do this matching for you.
19* Add `matchRequestsWithResponses` to make it easier to use `Requester` with protocols that don't do this matching for you.
146−
147* Add `withRequesterT` to map functions over the request and response of a `RequesterT`.
20* Add `withRequesterT` to map functions over the request and response of a `RequesterT`.
148−
149* Suppress nil patches in `QueryT` as an optimization. The `Query` type must now have an `Eq` instance.
21* Suppress nil patches in `QueryT` as an optimization. The `Query` type must now have an `Eq` instance.
150−
151* Add `throttleBatchWithLag` to `Reflex.Time`. See that module for details.
22* Add `throttleBatchWithLag` to `Reflex.Time`. See that module for details.
Quickref.md+11−15
@@ -54,7 +54,6 @@ Since MonadHold depends on MonadSample, any [S] function also runs in [H] contex
54[ ] difference :: Event a -> Event b -> Event a
54[ ] difference :: Event a -> Event b -> Event a
55[ ] align :: Event a -> Event b -> Event (These a b)
55[ ] align :: Event a -> Event b -> Event (These a b)
56[ ] alignWith :: (These a b -> c) -> Event a -> Event b -> Event c
56[ ] alignWith :: (These a b -> c) -> Event a -> Event b -> Event c
57− -- Note align functions from Data.Align in semialign package
58[ ] mergeWith :: (a -> a -> a) -> [Event a] -> Event a
57[ ] mergeWith :: (a -> a -> a) -> [Event a] -> Event a
59[ ] leftmost :: [Event a] -> Event a
58[ ] leftmost :: [Event a] -> Event a
60[ ] mergeList :: [Event a] -> Event (NonEmpty a)
59[ ] mergeList :: [Event a] -> Event (NonEmpty a)
@@ -199,7 +198,7 @@ For Events, the returned Event fires whenever the latest Event supplied by the w
199The functions mentioned above are used to create a static FRP network.
198The functions mentioned above are used to create a static FRP network.
200There are additional typeclasses that can be used to modify the FRP network, to have it interact with IO action, or to introspect the building of the network.
199There are additional typeclasses that can be used to modify the FRP network, to have it interact with IO action, or to introspect the building of the network.
201
200
202−The typeclasses and their associated annotations include:
201+Th typeclasses and their associated annotations include:
203
202
204- `PostBuild`
203- `PostBuild`
205 Fire an Event when an FRP network has been set up.
204 Fire an Event when an FRP network has been set up.
@@ -207,7 +206,7 @@ The typeclasses and their associated annotations include:
207 [B] -- Function runs in any monad supporting PostBuild
206 [B] -- Function runs in any monad supporting PostBuild
208 ```
207 ```
209
208
210−- `Adjustable`
209+- `Adjustable`
211 Use Events to add or remove pieces of an FRP network.
210 Use Events to add or remove pieces of an FRP network.
212 ```haskell
211 ```haskell
213 [A] -- Function runs in any monad supporting Adjustable
212 [A] -- Function runs in any monad supporting Adjustable
@@ -272,7 +271,7 @@ The typeclasses and their associated annotations include:
272```haskell
271```haskell
273-- Run side-effecting actions in Event when it occurs; returned Event contains
272-- Run side-effecting actions in Event when it occurs; returned Event contains
274-- results. Side effects run in the (Performable m) monad which is associated with
273-- results. Side effects run in the (Performable m) monad which is associated with
275−-- the (PerformEvent t m) typeclass constraint.
274+-- the (PerformEvent t m) typeclass constraint.
276-- This allows for working with IO when a ((MonadIO (Performable m)) constraint is available.
275-- This allows for working with IO when a ((MonadIO (Performable m)) constraint is available.
277[P] performEvent :: Event (Performable m a ) -> m (Event a)
276[P] performEvent :: Event (Performable m a ) -> m (Event a)
278
277
@@ -296,20 +295,17 @@ The typeclasses and their associated annotations include:
296## Networks
295## Networks
297
296
298```haskell
297```haskell
299−-- Functions from Reflex.Adjustable / Reflex.Network used to deal with Dynamics/Events carrying (m a)
298+-- Functions from Reflex.Network used to deal with Dynamics/Events carrying (m a)
300
299
301−[A] runWithReplace :: m a -> Event t (m b) -> m (a, Event t b)
302−
303−-- Given a Dynamic of network-creating actions, create a network that is recreated whenever the Dynamic updates.
300+-- Given a Dynamic of network-creating actions, create a network that is recreated whenever the Dynamic updates.
304−-- The returned Event of network results occurs when the Dynamic does. Note: Often, the type a is an Event,
301+-- The returned Event of network results occurs when the Dynamic does. Note: Often, the type a is an Event,
305-- in which case the return value is an Event-of-Events that would typically be flattened (via switchHold).
302-- in which case the return value is an Event-of-Events that would typically be flattened (via switchHold).
306−[P,A] networkView :: Dynamic (m a) -> m (Event a)
303+[P,A] networkView :: Dynamic (m a) -> m (Event a)
307
304
308−-- Given an initial network and an Event of network-creating actions, create a network that is recreated whenever the
305+-- Given an initial network and an Event of network-creating actions, create a network that is recreated whenever the
309−-- Event fires. The returned Dynamic of network results occurs when the Event does. Note: Often, the type a is an
306+-- Event fires. The returned Dynamic of network results occurs when the Event does. Note: Often, the type a is an
310-- Event, in which case the return value is a Dynamic-of-Events that would typically be flattened.
307-- Event, in which case the return value is a Dynamic-of-Events that would typically be flattened.
311−[H,A] networkHold :: m a -> Event (m a) -> m (Dynamic a)
308+[H,A] networkHold :: m a -> Event (m a) -> m (Dynamic a)
312
309
313-- Render a placeholder network to be shown while another network is not yet done building
310-- Render a placeholder network to be shown while another network is not yet done building
314−[P,A] untilReady :: m a -> m b -> m (a, Event b)
311+[P,A] untilReady :: m a -> m b -> m (a, Event b)
315−```
README.md+17−15
@@ -1,23 +1,25 @@
1−# [Reflex](https://reflex-frp.org/)
1+## [Reflex](https://reflex-frp.org/)
2
2
3−[![Haskell](https://img.shields.io/badge/language-Haskell-orange.svg)](https://haskell.org) [![Hackage](https://img.shields.io/hackage/v/reflex.svg)](https://hackage.haskell.org/package/reflex) [![Hackage CI](https://matrix.hackage.haskell.org/api/v2/packages/reflex/badge)](https://matrix.hackage.haskell.org/#/package/reflex) [![BSD3 License](https://img.shields.io/badge/license-BSD3-blue.svg)](https://github.com/reflex-frp/reflex/blob/master/LICENSE)
3+[![Hackage](https://img.shields.io/hackage/v/reflex.svg)](http://hackage.haskell.org/package/reflex)
4
4
5−Interactive programs without callbacks or side-effects. Functional Reactive Programming (FRP) uses composable events and time-varying values to describe interactive systems as pure functions. Just like other pure functional code, functional reactive code is easier to get right on the first try, maintain, and reuse.
5+### Practical Functional Reactive Programming
6
6
7−Reflex is a fully-deterministic, higher-order Functional Reactive Programming interface and an engine that efficiently implements that interface.
7+Reflex is a fully-deterministic, higher-order Functional Reactive Programming (FRP) interface and an engine that efficiently implements that interface.
8
8
9−**Visit https://reflex-frp.org for more information, tutorials, documentation and [examples](https://examples.reflex-frp.org/).**
9+[Reflex-DOM](https://github.com/reflex-frp/reflex-dom) is a framework built on Reflex that facilitates the development of web pages, including highly-interactive single-page apps.
10
10
11−## Resources
11+A summary of Reflex functions is available in the [quick reference](Quickref.md).
12
12
13−* [Official Website](https://reflex-frp.org)
13+**Visit https://reflex-frp.org/ for more information, tutorials, documentation and [examples](https://examples.reflex-frp.org/).**
14−* [Quick Reference](Quickref.md)
15−* [Reflex-DOM](https://github.com/reflex-frp/reflex-dom): A framework built on Reflex that facilitates the development of web pages, including highly-interactive single-page apps.
16−* [Obelisk](https://github.com/obsidiansystems/obelisk#obelisk): A framework built on Reflex and Reflex-DOM for functional reactive web and mobile applications, with batteries included.
17−* [Get started with Reflex](https://github.com/reflex-frp/reflex-platform)
18−* [/r/reflexfrp](https://www.reddit.com/r/reflexfrp)
19−* [irc.freenode.net #reflex-frp](http://webchat.freenode.net?channels=%23reflex-frp&uio=d4)
20
14
21−## Hacking
15+### Resources
16+[Get started with Reflex](https://github.com/reflex-frp/reflex-platform)
22
17
23−From the root of a [Reflex Platform](https://github.com/reflex-frp/reflex-platform) checkout, run `./scripts/hack-on haskell-overlays/reflex-packages/dep/reflex`. This will check out the reflex source code into the `haskell-overlays/reflex-packages/dep/reflex` directory. You can then point that checkout at your fork, make changes, etc. Use the `./try-reflex` or `./scripts/work-on` scripts to start a shell in which you can test your changes.
18+[/r/reflexfrp](https://www.reddit.com/r/reflexfrp)
19+
20+[irc.freenode.net #reflex-frp](http://webchat.freenode.net?channels=%23reflex-frp&uio=d4)
21+
22+### Hacking
23+
24+Use the `./scripts/hack-on reflex` script in [Reflex Platform](https://github.com/reflex-frp/reflex-platform) to checkout the source code of `reflex` locally in `reflex-platform/reflex` directory.
25+Then do modifications to the source in place, and use the `./try-reflex` or `./scripts/work-on` scripts to create the shell to test your changes.
cabal.haskell-cideleted−23
@@ -1,23 +0,0 @@
1−distribution: xenial
2−benchmarks: False
3−unconstrained: False
4−installed: -all
5−
6−-- https://github.com/haskell/cabal/issues/6106
7−install-dependencies: False
8−
9−constraint-set no-th
10− constraints: reflex -use-template-haskell
11−
12−constraint-set old-these
13− ghc: <8.8
14− constraints: these <1
15−
16−constraint-set old-witherable
17− constraints: witherable <0.3.2
18−
19−constraint-set debug-propagation
20− constraints: reflex +debug-propagation
21−
22−constraint-set debug-cycles
23− constraints: reflex +debug-cycles
cabal.projectdeleted−1
@@ -1 +0,0 @@
1−packages: .
default.nixnew file+39
@@ -0,0 +1,39 @@
1+{ mkDerivation, ghc, base, bifunctors, containers, deepseq
2+, dependent-map, dependent-sum, exception-transformers
3+, haskell-src-exts, haskell-src-meta, hlint, lens, MemoTrie
4+, monad-control, mtl, primitive, random, ref-tf
5+, semigroupoids , semigroups, split, stdenv, stm, syb
6+, template-haskell , these, time, transformers
7+, transformers-compat, unbounded-delays, prim-uniq
8+, data-default, filepath, directory, filemanip, ghcjs-base
9+, monoidal-containers, witherable
10+, useTemplateHaskell ? true
11+}:
12+mkDerivation {
13+ pname = "reflex";
14+ version = "0.6.2.0";
15+ src = builtins.filterSource (path: type: !(builtins.elem (baseNameOf path) [ ".git" "dist" ])) ./.;
16+ libraryHaskellDepends = [
17+ base bifunctors containers dependent-map dependent-sum
18+ exception-transformers lens
19+ MemoTrie monad-control mtl primitive ref-tf semigroupoids
20+ semigroups stm syb template-haskell these transformers
21+ transformers-compat prim-uniq
22+ base bifunctors containers deepseq dependent-map dependent-sum
23+ mtl ref-tf split transformers data-default
24+ random time unbounded-delays monoidal-containers witherable
25+ ] ++ (if ghc.isGhcjs or false then [
26+ ghcjs-base
27+ ] else []) ++ (if !useTemplateHaskell then [] else [
28+ haskell-src-exts haskell-src-meta
29+ ]);
30+ testHaskellDepends = if ghc.isGhcjs or false then [] else [
31+ hlint filepath directory filemanip
32+ ];
33+ configureFlags = if useTemplateHaskell then [] else [
34+ "-f-use-template-haskell"
35+ ];
36+ homepage = "https://github.com/reflex-frp/reflex";
37+ description = "Higher-order Functional Reactive Programming";
38+ license = stdenv.lib.licenses.bsd3;
39+}
dep/reflex-platform/default.nixdeleted−7
@@ -1,7 +0,0 @@
1−# DO NOT HAND-EDIT THIS FILE
2−import ((import <nixpkgs> {}).fetchFromGitHub (
3− let json = builtins.fromJSON (builtins.readFile ./github.json);
4− in { inherit (json) owner repo rev sha256;
5− private = json.private or false;
6− }
7−))
dep/reflex-platform/github.jsondeleted−7
@@ -1,7 +0,0 @@
1−{
2− "owner": "reflex-frp",
3− "repo": "reflex-platform",
4− "branch": "develop",
5− "rev": "f628398d076243a0851b27e625b37f65dff9b89b",
6− "sha256": "0sl0hf1glgyb1vmf2mhw4r9ipmcqk1y19d3wsic7dix2jwywzrh9"
7−}
hydra.jsonnew file+29
@@ -0,0 +1,29 @@
1+{
2+ "enabled": 1,
3+ "hidden": true,
4+ "description": "Jobsets",
5+ "nixexprinput": "src",
6+ "nixexprpath": "jobsets.nix",
7+ "checkinterval": 300,
8+ "schedulingshares": 100,
9+ "enableemail": false,
10+ "emailoverride": "",
11+ "keepnr": 10,
12+ "inputs": {
13+ "src": {
14+ "type": "git",
15+ "value": "https://github.com/reflex-frp/reflex.git develop",
16+ "emailresponsible": false
17+ },
18+ "nixpkgs": {
19+ "type": "git",
20+ "value": "https://github.com/NixOS/nixpkgs-channels nixos-unstable",
21+ "emailresponsible": false
22+ },
23+ "prs": {
24+ "type": "githubpulls",
25+ "value": "reflex-frp reflex",
26+ "emailresponsible": false
27+ }
28+ }
29+}
jobsets.nixnew file+70
@@ -0,0 +1,70 @@
1+{ prs }:
2+
3+let
4+ pkgs = (import ./reflex-platform.nix {}).nixpkgs;
5+ mkFetchGithub = value: {
6+ inherit value;
7+ type = "git";
8+ emailresponsible = false;
9+ };
10+in
11+with pkgs.lib;
12+let
13+ defaults = jobs: {
14+ inherit (jobs) description;
15+ enabled = 1;
16+ hidden = false;
17+ keepnr = 10;
18+ schedulingshares = 100;
19+ checkinterval = 120;
20+ enableemail = false;
21+ emailoverride = "";
22+ nixexprinput = "reflex";
23+ nixexprpath = "release.nix";
24+ inputs = jobs.inputs // {
25+ nixpkgs = {
26+ type = "git";
27+ value = "https://github.com/NixOS/nixpkgs-channels nixos-unstable";
28+ emailresponsible = false;
29+ };
30+ config = {
31+ type = "nix";
32+ value = "{ android_sdk.accept_license = true; }";
33+ emailresponsible = false;
34+ };
35+ };
36+ };
37+ branchJobset = branch: defaults {
38+ description = "reflex-${branch}";
39+ inputs = {
40+ reflex = {
41+ value = "https://github.com/reflex-frp/reflex ${branch}";
42+ type = "git";
43+ emailresponsible = false;
44+ };
45+ };
46+ };
47+ makePr = num: info: {
48+ name = "reflex-pr-${num}";
49+ value = defaults {
50+ description = "#${num}: ${info.title}";
51+ inputs = {
52+ reflex = {
53+ #NOTE: This should really use "pull/${num}/merge"; however, GitHub's
54+ #status checks only operate on PR heads. This creates a race
55+ #condition, which can currently only be solved by requiring PRs to be
56+ #up to date before they're merged. See
57+ #https://github.com/isaacs/github/issues/1002
58+ value = "https://github.com/reflex-frp/reflex pull/${num}/head";
59+ type = "git";
60+ emailresponsible = false;
61+ };
62+ };
63+ };
64+ };
65+ processedPrs = mapAttrs' makePr (builtins.fromJSON (builtins.readFile prs));
66+ jobsetsAttrs = processedPrs //
67+ genAttrs ["develop"] branchJobset;
68+in {
69+ jobsets = pkgs.writeText "spec.json" (builtins.toJSON jobsetsAttrs);
70+}
reflex-platform.nixnew file+8
@@ -0,0 +1,8 @@
1+let
2+ reflex-platform-src = (import <nixpkgs> {}).fetchFromGitHub {
3+ owner = "reflex-frp";
4+ repo = "reflex-platform";
5+ rev = "384cd850f3adf1d404bced2424b5f6efb0f415f2";
6+ sha256 = "1ws77prqx8khmp8j6br1ij4k2v4dlgv170r9fmg0p1jivfbn8y9d";
7+ };
8+in import reflex-platform-src
reflex.cabal+57−188
@@ -1,17 +1,7 @@
1Name: reflex
1Name: reflex
2−Version: 0.8.2.0
2+Version: 0.6.2.0
3Synopsis: Higher-order Functional Reactive Programming
3Synopsis: Higher-order Functional Reactive Programming
4−Description:
5− Interactive programs without callbacks or side-effects.
6− Functional Reactive Programming (FRP) uses composable events and time-varying
7− values to describe interactive systems as pure functions.
8− Just like other pure functional code, functional reactive code is easier
9− to get right on the first try, maintain, and reuse.
10− .
11− Reflex is a fully-deterministic, higher-order Functional Reactive Programming
4+Description: Reflex is a high-performance, deterministic, higher-order Functional Reactive Programming system
12− interface and an engine that efficiently implements that interface.
13− .
14− <https://reflex-frp.org>
15License: BSD3
5License: BSD3
16License-file: LICENSE
6License-file: LICENSE
17Author: Ryan Trinkle
7Author: Ryan Trinkle
@@ -19,7 +9,7 @@ Maintainer: ryan.trinkle@gmail.com
19Stability: Experimental
9Stability: Experimental
20Category: FRP
10Category: FRP
21Build-type: Simple
11Build-type: Simple
22−Cabal-version: 1.22
12+Cabal-version: >=1.9.2
23homepage: https://reflex-frp.org
13homepage: https://reflex-frp.org
24bug-reports: https://github.com/reflex-frp/reflex/issues
14bug-reports: https://github.com/reflex-frp/reflex/issues
25extra-source-files:
15extra-source-files:
@@ -27,10 +17,6 @@ extra-source-files:
27 Quickref.md
17 Quickref.md
28 ChangeLog.md
18 ChangeLog.md
29
19
30−tested-with:
31− GHC ==8.4.4 || ==8.6.5 || ==8.8.1 || ==8.10.2,
32− GHCJS ==8.6
33−
34flag use-reflex-optimizer
20flag use-reflex-optimizer
35 description: Use the GHC plugin Reflex.Optimizer on some of the modules in the package. This is still experimental.
21 description: Use the GHC plugin Reflex.Optimizer on some of the modules in the package. This is still experimental.
36 default: False
22 default: False
@@ -51,67 +37,43 @@ flag fast-weak
51 default: False
37 default: False
52 manual: True
38 manual: True
53
39
54−flag debug-propagation
55− description: Enable debugging of spider internals
56− default: False
57− manual: True
58−
59−flag debug-cycles
60− description: Enable debugging of event cycles
61− default: False
62− manual: True
63−
64−flag split-these
65− description: Use split these/semialign packages
66− manual: False
67− default: True
68−
69library
40library
70− default-language: Haskell2010
71 hs-source-dirs: src
41 hs-source-dirs: src
72 build-depends:
42 build-depends:
73 MemoTrie == 0.6.*,
43 MemoTrie == 0.6.*,
74− base >= 4.11 && < 4.15,
44+ base >= 4.9 && < 4.13,
75 bifunctors >= 5.2 && < 5.6,
45 bifunctors >= 5.2 && < 5.6,
76− comonad >= 5.0.4 && < 5.1,
46+ comonad,
77− constraints >= 0.10 && <0.14,
78− constraints-extras >= 0.3 && < 0.4,
47+ constraints-extras >= 0.2,
79− containers >= 0.6 && < 0.7,
48+ containers >= 0.5 && < 0.7,
80 data-default >= 0.5 && < 0.8,
49 data-default >= 0.5 && < 0.8,
81− dependent-map >= 0.3 && < 0.5,
50+ dependent-map >= 0.3 && < 0.4,
82 exception-transformers == 0.4.*,
51 exception-transformers == 0.4.*,
83 lens >= 4.7 && < 5,
52 lens >= 4.7 && < 5,
84− mmorph >= 1.0 && < 1.2,
85 monad-control >= 1.0.1 && < 1.1,
53 monad-control >= 1.0.1 && < 1.1,
54+ monoidal-containers == 0.4.*,
86 mtl >= 2.1 && < 2.3,
55 mtl >= 2.1 && < 2.3,
87− patch >= 0.0.1 && < 0.1,
88− prim-uniq >= 0.1.0.1 && < 0.3,
56+ prim-uniq >= 0.1.0.1 && < 0.2,
89− primitive >= 0.5 && < 0.8,
57+ primitive >= 0.5 && < 0.7,
90− profunctors >= 5.3 && < 5.7,
91 random == 1.1.*,
58 random == 1.1.*,
92 ref-tf == 0.4.*,
59 ref-tf == 0.4.*,
93 reflection == 2.1.*,
60 reflection == 2.1.*,
94 semigroupoids >= 4.0 && < 6,
61 semigroupoids >= 4.0 && < 6,
62+ semigroups >= 0.16 && < 0.19,
95 stm >= 2.4 && < 2.6,
63 stm >= 2.4 && < 2.6,
96 syb >= 0.5 && < 0.8,
64 syb >= 0.5 && < 0.8,
65+ these >= 0.4 && < 0.9,
97− time >= 1.4 && < 1.10,
66+ time >= 1.4 && < 1.9,
98− transformers >= 0.5.6.0 && < 0.6,
67+ transformers >= 0.2,
68+ transformers-compat >= 0.3,
99 unbounded-delays >= 0.1.0.0 && < 0.2,
69 unbounded-delays >= 0.1.0.0 && < 0.2,
100− witherable >= 0.3 && < 0.5
70+ witherable >= 0.2 && < 0.4
101−
102− if flag(split-these)
103− build-depends: these >= 1 && <1.2,
104− semialign >=1 && <1.2,
105− monoidal-containers >= 0.6 && < 0.7
106− else
107− build-depends: these >= 0.4 && <0.9,
108− monoidal-containers == 0.4.0.0
109
71
110 exposed-modules:
72 exposed-modules:
111− Control.Monad.ReaderIO
112 Data.AppendMap,
73 Data.AppendMap,
113 Data.FastMutableIntMap,
74 Data.FastMutableIntMap,
114 Data.FastWeakBag,
75 Data.FastWeakBag,
76+ Data.Functor.Misc,
115 Data.Map.Misc,
77 Data.Map.Misc,
116 Data.WeakBag,
78 Data.WeakBag,
117 Reflex,
79 Reflex,
@@ -131,9 +93,15 @@ library
131 Reflex.FastWeak,
93 Reflex.FastWeak,
132 Reflex.FunctorMaybe,
94 Reflex.FunctorMaybe,
133 Reflex.Host.Class,
95 Reflex.Host.Class,
134− Reflex.Host.Headless,
135 Reflex.Network,
96 Reflex.Network,
136 Reflex.NotReady.Class,
97 Reflex.NotReady.Class,
98+ Reflex.Patch,
99+ Reflex.Patch.Class,
100+ Reflex.Patch.DMap,
101+ Reflex.Patch.DMapWithMove,
102+ Reflex.Patch.IntMap,
103+ Reflex.Patch.Map,
104+ Reflex.Patch.MapWithMove,
137 Reflex.PerformEvent.Base,
105 Reflex.PerformEvent.Base,
138 Reflex.PerformEvent.Class,
106 Reflex.PerformEvent.Class,
139 Reflex.PostBuild.Base,
107 Reflex.PostBuild.Base,
@@ -152,57 +120,38 @@ library
152 Reflex.Widget.Basic,
120 Reflex.Widget.Basic,
153 Reflex.Workflow
121 Reflex.Workflow
154
122
155− reexported-modules:
156− patch:Data.Functor.Misc,
157− patch:Data.Patch as Reflex.Patch,
158− patch:Data.Patch.Class as Reflex.Patch.Class,
159− patch:Data.Patch.DMap as Reflex.Patch.DMap,
160− patch:Data.Patch.DMapWithMove as Reflex.Patch.DMapWithMove,
161− patch:Data.Patch.IntMap as Reflex.Patch.IntMap,
162− patch:Data.Patch.Map as Reflex.Patch.Map,
163− patch:Data.Patch.MapWithMove as Reflex.Patch.MapWithMove
164−
165 ghc-options: -Wall -fwarn-redundant-constraints -fwarn-tabs -funbox-strict-fields -O2 -fspecialise-aggressively
123 ghc-options: -Wall -fwarn-redundant-constraints -fwarn-tabs -funbox-strict-fields -O2 -fspecialise-aggressively
166
124
167 if flag(debug-trace-events)
125 if flag(debug-trace-events)
168 cpp-options: -DDEBUG_TRACE_EVENTS
126 cpp-options: -DDEBUG_TRACE_EVENTS
169− build-depends:
127+ build-depends: bytestring
170− bytestring >= 0.10.8 && < 0.11
171
128
172 if flag(use-reflex-optimizer)
129 if flag(use-reflex-optimizer)
173 cpp-options: -DUSE_REFLEX_OPTIMIZER
130 cpp-options: -DUSE_REFLEX_OPTIMIZER
174 build-depends: ghc
131 build-depends: ghc
175 exposed-modules: Reflex.Optimizer
132 exposed-modules: Reflex.Optimizer
176
133
177− if flag(debug-propagation)
178− cpp-options: -DDEBUG -DDEBUG_TRACE_PROPAGATION -DDEBUG_TRACE_INVALIDATION
179−
180− if flag(debug-cycles)
181− cpp-options: -DDEBUG_CYCLES
182−
183 if flag(use-template-haskell)
134 if flag(use-template-haskell)
184 cpp-options: -DUSE_TEMPLATE_HASKELL
135 cpp-options: -DUSE_TEMPLATE_HASKELL
185 build-depends:
136 build-depends:
186− dependent-sum >= 0.6 && < 0.8,
137+ dependent-sum >= 0.6 && < 0.7,
187− haskell-src-exts >= 1.16 && < 1.24,
138+ haskell-src-exts >= 1.16 && < 1.22,
188 haskell-src-meta >= 0.6 && < 0.9,
139 haskell-src-meta >= 0.6 && < 0.9,
189− template-haskell >= 2.9 && < 2.17
140+ template-haskell >= 2.9 && < 2.15
190 exposed-modules:
141 exposed-modules:
191 Reflex.Dynamic.TH
142 Reflex.Dynamic.TH
192 other-extensions: TemplateHaskell
143 other-extensions: TemplateHaskell
193 else
144 else
194 build-depends:
145 build-depends:
195− dependent-sum >= 0.6 && < 0.8
146+ dependent-sum == 0.6.*
196
147
197 if flag(fast-weak) && impl(ghcjs)
148 if flag(fast-weak) && impl(ghcjs)
198 cpp-options: -DGHCJS_FAST_WEAK
149 cpp-options: -DGHCJS_FAST_WEAK
199
150
200 if impl(ghcjs)
151 if impl(ghcjs)
201− build-depends:
152+ build-depends: ghcjs-base
202− ghcjs-base == 0.2.*
203
153
204test-suite semantics
154test-suite semantics
205− default-language: Haskell2010
206 type: exitcode-stdio-1.0
155 type: exitcode-stdio-1.0
207 main-is: semantics.hs
156 main-is: semantics.hs
208 hs-source-dirs: test
157 hs-source-dirs: test
@@ -211,14 +160,14 @@ test-suite semantics
211 base,
160 base,
212 bifunctors,
161 bifunctors,
213 containers,
162 containers,
214− deepseq,
163+ deepseq >= 1.3 && < 1.5,
215 dependent-map,
164 dependent-map,
216 dependent-sum,
165 dependent-sum,
217 mtl,
166 mtl,
218 ref-tf,
167 ref-tf,
219 reflex,
168 reflex,
220 split,
169 split,
221− transformers
170+ transformers >= 0.3
222 other-modules:
171 other-modules:
223 Reflex.Bench.Focused
172 Reflex.Bench.Focused
224 Reflex.Plan.Pure
173 Reflex.Plan.Pure
@@ -228,7 +177,6 @@ test-suite semantics
228 Reflex.TestPlan
177 Reflex.TestPlan
229
178
230test-suite CrossImpl
179test-suite CrossImpl
231− default-language: Haskell2010
232 type: exitcode-stdio-1.0
180 type: exitcode-stdio-1.0
233 main-is: Reflex/Test/CrossImpl.hs
181 main-is: Reflex/Test/CrossImpl.hs
234 hs-source-dirs: test
182 hs-source-dirs: test
@@ -238,7 +186,7 @@ test-suite CrossImpl
238 containers,
186 containers,
239 dependent-map,
187 dependent-map,
240 dependent-sum,
188 dependent-sum,
241− deepseq,
189+ deepseq >= 1.3 && < 1.5,
242 mtl,
190 mtl,
243 transformers,
191 transformers,
244 ref-tf,
192 ref-tf,
@@ -250,7 +198,6 @@ test-suite CrossImpl
250 Reflex.Plan.Pure
198 Reflex.Plan.Pure
251
199
252test-suite hlint
200test-suite hlint
253− default-language: Haskell2010
254 type: exitcode-stdio-1.0
201 type: exitcode-stdio-1.0
255 main-is: hlint.hs
202 main-is: hlint.hs
256 hs-source-dirs: test
203 hs-source-dirs: test
@@ -258,21 +205,17 @@ test-suite hlint
258 , directory
205 , directory
259 , filepath
206 , filepath
260 , filemanip
207 , filemanip
261− if impl(ghc >= 8.8)
208+ , hlint
262− build-depends: hlint >= 3 && < 4
263− else
264− build-depends: hlint (< 2.1 || >= 2.2.2) && < 4
265 if impl(ghcjs)
209 if impl(ghcjs)
266 buildable: False
210 buildable: False
267
211
268test-suite EventWriterT
212test-suite EventWriterT
269− default-language: Haskell2010
270 type: exitcode-stdio-1.0
213 type: exitcode-stdio-1.0
271 main-is: EventWriterT.hs
214 main-is: EventWriterT.hs
272 hs-source-dirs: test
215 hs-source-dirs: test
273 build-depends: base
216 build-depends: base
274 , containers
217 , containers
275− , deepseq
218+ , deepseq >= 1.3 && < 1.5
276 , dependent-map
219 , dependent-map
277 , dependent-sum
220 , dependent-sum
278 , lens
221 , lens
@@ -281,96 +224,33 @@ test-suite EventWriterT
281 , transformers
224 , transformers
282 , reflex
225 , reflex
283 , ref-tf
226 , ref-tf
284−
285− if flag(split-these)
286− build-depends: these-lens
287−
288− other-modules:
289− Test.Run
290−
291−
292−test-suite DebugCycles
293− default-language: Haskell2010
294− type: exitcode-stdio-1.0
295− main-is: DebugCycles.hs
296− hs-source-dirs: test
297− ghc-options: -threaded
298− build-depends: base
299− , containers
300− , deepseq
301− , dependent-map
302− , dependent-sum
303− , hspec
304− , lens
305− , mtl
306− , these
307− , transformers
308− , reflex
309− , ref-tf
310− , witherable
311− , proctest
312−
313−
314− if flag(split-these)
315− build-depends: these-lens, semialign
316−
317 other-modules:
227 other-modules:
228+ Reflex.Test
229+ Reflex.TestPlan
230+ Reflex.Plan.Reflex
231+ Reflex.Plan.Pure
318 Test.Run
232 Test.Run
319
233
320−
321test-suite RequesterT
234test-suite RequesterT
322− default-language: Haskell2010
323 type: exitcode-stdio-1.0
235 type: exitcode-stdio-1.0
324 main-is: RequesterT.hs
236 main-is: RequesterT.hs
325 hs-source-dirs: test
237 hs-source-dirs: test
326 build-depends: base
238 build-depends: base
327− , constraints
328− , constraints-extras
329 , containers
239 , containers
330− , deepseq
240+ , deepseq >= 1.3 && < 1.5
331− , dependent-map
332 , dependent-sum
241 , dependent-sum
242+ , dependent-map
333 , lens
243 , lens
334 , mtl
244 , mtl
335− , ref-tf
336− , reflex
337− , text
338 , these
245 , these
339 , transformers
246 , transformers
340−
341− if flag(split-these)
342− build-depends: these-lens
343−
344− other-modules:
345− Reflex.TestPlan
346− Reflex.Plan.Pure
347− Test.Run
348−
349−test-suite Headless
350− default-language: Haskell2010
351− type: exitcode-stdio-1.0
352− main-is: Headless.hs
353− hs-source-dirs: test
354− build-depends: base
355− , reflex
356−
357−test-suite Adjustable
358− default-language: Haskell2010
359− type: exitcode-stdio-1.0
360− main-is: Adjustable.hs
361− hs-source-dirs: test
362− build-depends: base
363− , containers
364− , dependent-sum
365 , reflex
247 , reflex
366 , ref-tf
248 , ref-tf
367− , these
368−
369 other-modules:
249 other-modules:
370− Test.Run
250+ Reflex.TestPlan
251+ Reflex.Plan.Pure
371
252
372test-suite QueryT
253test-suite QueryT
373− default-language: Haskell2010
374 type: exitcode-stdio-1.0
254 type: exitcode-stdio-1.0
375 main-is: QueryT.hs
255 main-is: QueryT.hs
376 hs-source-dirs: test
256 hs-source-dirs: test
@@ -378,19 +258,15 @@ test-suite QueryT
378 , containers
258 , containers
379 , dependent-map
259 , dependent-map
380 , dependent-sum
260 , dependent-sum
381− , deepseq
261+ , deepseq >= 1.3 && < 1.5
382 , lens
262 , lens
383 , monoidal-containers
263 , monoidal-containers
384 , mtl
264 , mtl
385− , patch
386 , ref-tf
265 , ref-tf
387 , reflex
266 , reflex
267+ , semigroups
388 , these
268 , these
389 , transformers
269 , transformers
390−
391− if flag(split-these)
392− build-depends: semialign, these-lens
393−
394 other-modules:
270 other-modules:
395 Test.Run
271 Test.Run
396 Reflex.TestPlan
272 Reflex.TestPlan
@@ -398,7 +274,6 @@ test-suite QueryT
398 Reflex.Plan.Pure
274 Reflex.Plan.Pure
399
275
400test-suite GC-Semantics
276test-suite GC-Semantics
401− default-language: Haskell2010
402 type: exitcode-stdio-1.0
277 type: exitcode-stdio-1.0
403 main-is: GC.hs
278 main-is: GC.hs
404 hs-source-dirs: test
279 hs-source-dirs: test
@@ -406,17 +281,14 @@ test-suite GC-Semantics
406 , containers
281 , containers
407 , dependent-sum
282 , dependent-sum
408 , dependent-map
283 , dependent-map
409− , deepseq
284+ , deepseq >= 1.3 && < 1.5
410 , mtl
285 , mtl
411− , patch
412 , these
286 , these
413 , transformers
287 , transformers
414 , reflex
288 , reflex
415 , ref-tf
289 , ref-tf
416−
290+ if impl(ghc < 8)
417− if flag(split-these)
418− build-depends: semialign
291+ build-depends: semigroups
419−
420 other-modules:
292 other-modules:
421 Reflex.Plan.Pure
293 Reflex.Plan.Pure
422 Reflex.Plan.Reflex
294 Reflex.Plan.Reflex
@@ -424,13 +296,12 @@ test-suite GC-Semantics
424 Test.Run
296 Test.Run
425
297
426test-suite rootCleanup
298test-suite rootCleanup
427− default-language: Haskell2010
428 type: exitcode-stdio-1.0
299 type: exitcode-stdio-1.0
429 main-is: rootCleanup.hs
300 main-is: rootCleanup.hs
430 hs-source-dirs: test
301 hs-source-dirs: test
431 build-depends: base
302 build-depends: base
432 , containers
303 , containers
433− , deepseq
304+ , deepseq >= 1.3 && < 1.5
434 , dependent-sum
305 , dependent-sum
435 , mtl
306 , mtl
436 , reflex
307 , reflex
@@ -442,7 +313,6 @@ test-suite rootCleanup
442 Test.Run
313 Test.Run
443
314
444benchmark spider-bench
315benchmark spider-bench
445− default-language: Haskell2010
446 type: exitcode-stdio-1.0
316 type: exitcode-stdio-1.0
447 hs-source-dirs: bench test
317 hs-source-dirs: bench test
448 main-is: Main.hs
318 main-is: Main.hs
@@ -450,8 +320,8 @@ benchmark spider-bench
450 build-depends:
320 build-depends:
451 base,
321 base,
452 containers,
322 containers,
453− criterion,
323+ criterion >= 1.1 && < 1.6,
454− deepseq,
324+ deepseq >= 1.3 && < 1.5,
455 dependent-map,
325 dependent-map,
456 dependent-sum,
326 dependent-sum,
457 ref-tf,
327 ref-tf,
@@ -460,14 +330,13 @@ benchmark spider-bench
460 reflex,
330 reflex,
461 split,
331 split,
462 stm,
332 stm,
463− transformers
333+ transformers >= 0.3
464 other-modules:
334 other-modules:
465 Reflex.TestPlan
335 Reflex.TestPlan
466 Reflex.Plan.Reflex
336 Reflex.Plan.Reflex
467 Reflex.Bench.Focused
337 Reflex.Bench.Focused
468
338
469benchmark saulzar-bench
339benchmark saulzar-bench
470− default-language: Haskell2010
471 type: exitcode-stdio-1.0
340 type: exitcode-stdio-1.0
472 hs-source-dirs: bench test
341 hs-source-dirs: bench test
473 c-sources: bench-cbits/checkCapability.c
342 c-sources: bench-cbits/checkCapability.c
@@ -475,9 +344,9 @@ benchmark saulzar-bench
475 ghc-options: -Wall -O2 -rtsopts -threaded
344 ghc-options: -Wall -O2 -rtsopts -threaded
476 build-depends:
345 build-depends:
477 base,
346 base,
478− containers,
347+ containers >= 0.5 && < 0.7,
479− criterion,
348+ criterion >= 1.1 && < 1.6,
480− deepseq,
349+ deepseq >= 1.3 && < 1.5,
481 dependent-map,
350 dependent-map,
482 dependent-sum,
351 dependent-sum,
483 loch-th,
352 loch-th,
@@ -489,7 +358,7 @@ benchmark saulzar-bench
489 split,
358 split,
490 stm,
359 stm,
491 time,
360 time,
492− transformers
361+ transformers >= 0.3
493 other-modules:
362 other-modules:
494 Reflex.TestPlan
363 Reflex.TestPlan
495 Reflex.Plan.Reflex
364 Reflex.Plan.Reflex
release.nix+7−56
@@ -1,58 +1,9 @@
1−{ reflex-platform-fun ? import ./dep/reflex-platform
1+{ rp ? import ./reflex-platform.nix {}
2−, supportedSystems ? ["x86_64-linux" "x86_64-darwin"]
3}:
2}:
4−
5let
3let
6− native-reflex-platform = reflex-platform-fun {};
7− inherit (native-reflex-platform.nixpkgs) lib;
4+ inherit (rp.nixpkgs) lib;
8−
5+ compilers = ["ghc8_4" "ghc8_0" "ghcjs8_4" "ghcjs8_0"];
9− perPlatform = lib.genAttrs supportedSystems (system: let
10− reflex-platform = reflex-platform-fun { inherit system; };
11− compilers = [
12− "ghc"
13− "ghcjs"
14− ] ++ lib.optionals (reflex-platform.androidSupport) [
15− "ghcAndroidAarch64"
16− "ghcAndroidAarch32"
17− ] ++ lib.optionals (reflex-platform.iosSupport) [
18− "ghcIosAarch64"
19− ];
20− variations = map (v: "reflex" + v) [
21− "-dontUseTemplateHaskell"
22− ""
23− ];
24− compilerPkgs = lib.genAttrs compilers (ghc: let
6+in lib.genAttrs compilers (ghc: {
25− variationPkgs = lib.genAttrs variations (variation: let
7+ reflex-useTemplateHaskell = rp.${ghc}.callPackage ./. { useTemplateHaskell = true; };
26− reflex-platform = reflex-platform-fun {
8+ reflex = rp.${ghc}.callPackage ./. { useTemplateHaskell = false; };
27− inherit system;
9+})
28− __useTemplateHaskell = variation == "reflex"; # TODO hack
29− haskellOverlays = [
30− # Use this package's source for reflex
31− (self: super: {
32− _dep = super._dep // {
33− reflex = builtins.filterSource (path: type: !(builtins.elem (baseNameOf path) [
34− "release.nix"
35− ".git"
36− "dist"
37− "cabal.haskell-ci"
38− "cabal.project"
39− ".travis.yml"
40− ])) ./.;
41− };
42− })
43− ];
44− };
45− in reflex-platform.${ghc}.reflex);
46− in variationPkgs // {
47− cache = reflex-platform.pinBuildInputs "reflex-${system}-${ghc}"
48− (builtins.attrValues variationPkgs);
49− });
50− in compilerPkgs // {
51− cache = reflex-platform.pinBuildInputs "reflex-${system}"
52− (map (a: a.cache) (builtins.attrValues compilerPkgs));
53− });
54−
55− metaCache = native-reflex-platform.pinBuildInputs "reflex-everywhere"
56− (map (a: a.cache) (builtins.attrValues perPlatform));
57−
58−in perPlatform // { inherit metaCache; }
src/Control/Monad/ReaderIO.hsdeleted−60
@@ -1,60 +0,0 @@
1−{-# language RoleAnnotations #-}
2−{-# language MultiParamTypeClasses #-}
3−{-# language FlexibleInstances #-}
4−{-# language CPP #-}
5−module Control.Monad.ReaderIO
6− (
7− ReaderIO (..)
8− )
9− where
10−
11−import Control.Monad.Fix
12−#if MIN_VERSION_base(4,10,0)
13−import Control.Applicative
14−#endif
15−import Control.Monad
16−import Control.Monad.Reader.Class
17−import Control.Monad.IO.Class
18−
19−-- | An approximate clone of @RIO@ from the @rio@ package, but not based on
20−-- @ReaderT@. The trouble with @ReaderT@ is that its third type argument has a
21−-- @nominal@ role, so we can't coerce through it when it's wrapped in some
22−-- other @data@ type. Ugh.
23−newtype ReaderIO e a = ReaderIO { runReaderIO :: e -> IO a }
24−type role ReaderIO representational representational
25−
26−instance Functor (ReaderIO e) where
27− fmap = liftM
28− {-# INLINE fmap #-}
29− a <$ m = m >> pure a
30− {-# INLINE (<$) #-}
31−
32−instance Applicative (ReaderIO e) where
33− pure a = ReaderIO $ \_ -> pure a
34− {-# INLINE pure #-}
35− (<*>) = ap
36− {-# INLINE (<*>) #-}
37−#if MIN_VERSION_base(4,10,0)
38− liftA2 = liftM2
39− {-# INLINE liftA2 #-}
40−#endif
41− (*>) = (>>)
42− {-# INLINE (*>) #-}
43−
44−instance Monad (ReaderIO e) where
45− ReaderIO q >>= f = ReaderIO $ \e -> q e >>= \a -> runReaderIO (f a) e
46− {-# INLINE (>>=) #-}
47−
48−instance MonadFix (ReaderIO e) where
49− mfix f = ReaderIO $ \e -> mfix $ \r -> runReaderIO (f r) e
50− {-# INLINE mfix #-}
51−
52−instance MonadIO (ReaderIO e) where
53− liftIO m = ReaderIO $ \_ -> m
54− {-# INLINE liftIO #-}
55−
56−instance MonadReader e (ReaderIO e) where
57− ask = ReaderIO pure
58− {-# INLINE ask #-}
59− local f (ReaderIO m) = ReaderIO (m . f)
60− {-# INLINE local #-}
src/Data/AppendMap.hs+3−7
@@ -20,7 +20,7 @@ module Data.AppendMap
20 , module Data.Map.Monoidal
20 , module Data.Map.Monoidal
21 ) where
21 ) where
22
22
23−import Prelude hiding (null)
23+import Prelude hiding (map, null)
24
24
25import Data.Coerce
25import Data.Coerce
26import Data.Default
26import Data.Default
@@ -32,8 +32,6 @@ import qualified Data.Map as Map (showTree, showTreeWith)
32#endif
32#endif
33import qualified Data.Witherable as W
33import qualified Data.Witherable as W
34import Data.Map.Monoidal
34import Data.Map.Monoidal
35−import qualified Data.Map.Monoidal as MonoidalMap
36−
37
35
38{-# DEPRECATED AppendMap "Use 'MonoidalMap' instead" #-}
36{-# DEPRECATED AppendMap "Use 'MonoidalMap' instead" #-}
39-- | AppendMap is a synonym for 'Data.Map.Monoidal.MonoidalMap'
37-- | AppendMap is a synonym for 'Data.Map.Monoidal.MonoidalMap'
@@ -48,10 +46,8 @@ _unAppendMap = getMonoidalMap
48pattern AppendMap :: Map k v -> MonoidalMap k v
46pattern AppendMap :: Map k v -> MonoidalMap k v
49pattern AppendMap m = MonoidalMap m
47pattern AppendMap m = MonoidalMap m
50
48
51−#if !MIN_VERSION_witherable(0,3,2)
52instance W.Filterable (MonoidalMap k) where
49instance W.Filterable (MonoidalMap k) where
53− mapMaybe = MonoidalMap.mapMaybe
50+ mapMaybe = mapMaybe
54−#endif
55
51
56-- | Deletes a key, returning 'Nothing' if the result is empty.
52-- | Deletes a key, returning 'Nothing' if the result is empty.
57nonEmptyDelete :: Ord k => k -> MonoidalMap k a -> Maybe (MonoidalMap k a)
53nonEmptyDelete :: Ord k => k -> MonoidalMap k a -> Maybe (MonoidalMap k a)
@@ -71,7 +67,7 @@ mapMaybeNoNull f as =
71 then Nothing
67 then Nothing
72 else Just bs
68 else Just bs
73
69
74−-- TODO: Move instances to `Data.Patch`
70+-- TODO: Move instances to `Reflex.Patch`
75-- | Displays a 'MonoidalMap' as a tree. See 'Data.Map.Lazy.showTree' for details.
71-- | Displays a 'MonoidalMap' as a tree. See 'Data.Map.Lazy.showTree' for details.
76showTree :: forall k a. (Show k, Show a) => MonoidalMap k a -> String
72showTree :: forall k a. (Show k, Show a) => MonoidalMap k a -> String
77showTree = coerce (Map.showTree :: Map k a -> String)
73showTree = coerce (Map.showTree :: Map k a -> String)
src/Data/FastMutableIntMap.hs+3−7
@@ -21,7 +21,6 @@ module Data.FastMutableIntMap
21 , patchIntMapNewElements
21 , patchIntMapNewElements
22 , patchIntMapNewElementsMap
22 , patchIntMapNewElementsMap
23 , getDeletions
23 , getDeletions
24− , toList
25 ) where
24 ) where
26
25
27--TODO: Pure JS version
26--TODO: Pure JS version
@@ -35,8 +34,8 @@ import Data.Foldable (traverse_)
35import Data.IntMap.Strict (IntMap)
34import Data.IntMap.Strict (IntMap)
36import qualified Data.IntMap.Strict as IntMap
35import qualified Data.IntMap.Strict as IntMap
37import Data.IORef
36import Data.IORef
38−import Data.Patch.Class
37+import Reflex.Patch.Class
39−import Data.Patch.IntMap
38+import Reflex.Patch.IntMap
40
39
41-- | A 'FastMutableIntMap' holds a map of values of type @a@ and allows low-overhead modifications via IO.
40-- | A 'FastMutableIntMap' holds a map of values of type @a@ and allows low-overhead modifications via IO.
42-- Operations on 'FastMutableIntMap' run in IO.
41-- Operations on 'FastMutableIntMap' run in IO.
@@ -85,13 +84,10 @@ getFrozenAndClear (FastMutableIntMap r) = do
85 writeIORef r IntMap.empty
84 writeIORef r IntMap.empty
86 return result
85 return result
87
86
88−-- | Updates the value of a 'FastMutableIntMap' with the given patch (see 'Data.Patch.IntMap'),
87+-- | Updates the value of a 'FastMutableIntMap' with the given patch (see 'Reflex.Patch.IntMap'),
89-- and returns an 'IntMap' with the modified keys and values.
88-- and returns an 'IntMap' with the modified keys and values.
90applyPatch :: FastMutableIntMap a -> PatchIntMap a -> IO (IntMap a)
89applyPatch :: FastMutableIntMap a -> PatchIntMap a -> IO (IntMap a)
91applyPatch (FastMutableIntMap r) p@(PatchIntMap m) = do
90applyPatch (FastMutableIntMap r) p@(PatchIntMap m) = do
92 v <- readIORef r
91 v <- readIORef r
93 writeIORef r $! applyAlways p v
92 writeIORef r $! applyAlways p v
94 return $ IntMap.intersection v m
93 return $ IntMap.intersection v m
95−
96−toList :: FastMutableIntMap a -> IO [(Int, a)]
97−toList (FastMutableIntMap r) = IntMap.toList <$> readIORef r
src/Data/FastWeakBag.hs+4−9
@@ -18,7 +18,6 @@ module Data.FastWeakBag
18 , isEmpty
18 , isEmpty
19 , insert
19 , insert
20 , traverse
20 , traverse
21− , traverse_
22 , remove
21 , remove
23 -- * Internal functions
22 -- * Internal functions
24 -- These will not always be available.
23 -- These will not always be available.
@@ -117,14 +116,14 @@ foreign import javascript unsafe "(function(){ for(var i = 0; i < $1.tickets.len
117isEmpty bag = {-# SCC "isEmpty" #-} IntMap.null <$> readIORef (_weakBag_children bag)
116isEmpty bag = {-# SCC "isEmpty" #-} IntMap.null <$> readIORef (_weakBag_children bag)
118#endif
117#endif
119
118
120−{-# INLINE traverse_ #-}
119+{-# INLINE traverse #-}
121-- | Visit every node in the given list. If new nodes are appended during the
120-- | Visit every node in the given list. If new nodes are appended during the
122-- traversal, they will not be visited. Every live node that was in the list
121-- traversal, they will not be visited. Every live node that was in the list
123-- when the traversal began will be visited exactly once; however, no guarantee
122-- when the traversal began will be visited exactly once; however, no guarantee
124-- is made about the order of the traversal.
123-- is made about the order of the traversal.
125−traverse_ :: forall a m. MonadIO m => FastWeakBag a -> (a -> m ()) -> m ()
124+traverse :: forall a m. MonadIO m => FastWeakBag a -> (a -> m ()) -> m ()
126#ifdef GHCJS_FAST_WEAK
125#ifdef GHCJS_FAST_WEAK
127−traverse_ wb f = do
126+traverse wb f = do
128 let go cursor = when (not $ js_isNull cursor) $ do
127 let go cursor = when (not $ js_isNull cursor) $ do
129 val <- liftIO $ js_getTicketValue cursor
128 val <- liftIO $ js_getTicketValue cursor
130 f $ unsafeFromRawJSVal val
129 f $ unsafeFromRawJSVal val
@@ -135,17 +134,13 @@ foreign import javascript unsafe "$r = $1.val;" js_getTicketValue :: JSVal -> IO
135--TODO: Fix the race condition where if a cursor is deleted (presumably using 'remove', below) while we're holding it, it can't find its way back to the correct bag
134--TODO: Fix the race condition where if a cursor is deleted (presumably using 'remove', below) while we're holding it, it can't find its way back to the correct bag
136foreign import javascript unsafe "(function(){ for(var i = $1.pos - 1; i >= 0; i--) { if($1.bag.tickets[i] !== null) { return $1.bag.tickets[i]; } }; return null; })()" js_getNext :: FastWeakBagTicket a -> IO JSVal --TODO: Clean up as we go along so this isn't O(n) every time -- Result can be null or a FastWeakBagTicket a
135foreign import javascript unsafe "(function(){ for(var i = $1.pos - 1; i >= 0; i--) { if($1.bag.tickets[i] !== null) { return $1.bag.tickets[i]; } }; return null; })()" js_getNext :: FastWeakBagTicket a -> IO JSVal --TODO: Clean up as we go along so this isn't O(n) every time -- Result can be null or a FastWeakBagTicket a
137#else
136#else
138−traverse_ (FastWeakBag _ children) f = {-# SCC "traverse_" #-} do
137+traverse (FastWeakBag _ children) f = {-# SCC "traverse" #-} do
139 cs <- liftIO $ readIORef children
138 cs <- liftIO $ readIORef children
140 forM_ cs $ \c -> do
139 forM_ cs $ \c -> do
141 ma <- liftIO $ deRefWeak c
140 ma <- liftIO $ deRefWeak c
142 mapM_ f ma
141 mapM_ f ma
143#endif
142#endif
144
143
145−{-# DEPRECATED traverse "Use 'traverse_' instead" #-}
146−traverse :: forall a m. MonadIO m => FastWeakBag a -> (a -> m ()) -> m ()
147−traverse = traverse_
148−
149-- | Remove an item from the 'FastWeakBag'; does nothing if invoked multiple times
144-- | Remove an item from the 'FastWeakBag'; does nothing if invoked multiple times
150-- on the same 'FastWeakBagTicket'.
145-- on the same 'FastWeakBagTicket'.
151{-# INLINE remove #-}
146{-# INLINE remove #-}
src/Data/Functor/Misc.hsnew file+235
@@ -0,0 +1,235 @@
1+{-# LANGUAGE CPP #-}
2+{-# LANGUAGE DeriveDataTypeable #-}
3+{-# LANGUAGE DeriveFunctor #-}
4+{-# LANGUAGE FlexibleContexts #-}
5+{-# LANGUAGE FlexibleInstances #-}
6+{-# LANGUAGE GADTs #-}
7+{-# LANGUAGE KindSignatures #-}
8+{-# LANGUAGE LambdaCase #-}
9+{-# LANGUAGE MultiParamTypeClasses #-}
10+{-# LANGUAGE PatternSynonyms #-}
11+{-# LANGUAGE PolyKinds #-}
12+{-# LANGUAGE RankNTypes #-}
13+{-# LANGUAGE ScopedTypeVariables #-}
14+{-# LANGUAGE StandaloneDeriving #-}
15+#ifdef USE_REFLEX_OPTIMIZER
16+{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
17+#endif
18+-- | This module provides types and functions with no particular theme, but
19+-- which are relevant to the use of 'Functor'-based datastructures like
20+-- 'Data.Dependent.Map.DMap'.
21+module Data.Functor.Misc
22+ ( -- * Const2
23+ Const2 (..)
24+ , unConst2
25+ , dmapToMap
26+ , dmapToIntMap
27+ , dmapToMapWith
28+ , mapToDMap
29+ , weakenDMapWith
30+ -- * WrapArg
31+ , WrapArg (..)
32+ -- * Convenience functions for DMap
33+ , mapWithFunctorToDMap
34+ , intMapWithFunctorToDMap
35+ , mapKeyValuePairsMonotonic
36+ , combineDMapsWithKey
37+ , EitherTag (..)
38+ , dmapToThese
39+ , eitherToDSum
40+ , dsumToEither
41+ , ComposeMaybe (..)
42+ ) where
43+
44+import Control.Applicative ((<$>))
45+import Control.Monad.Identity
46+import Data.Dependent.Map (DMap)
47+import qualified Data.Dependent.Map as DMap
48+import Data.Dependent.Sum
49+import Data.GADT.Compare
50+import Data.GADT.Show
51+import Data.IntMap (IntMap)
52+import qualified Data.IntMap as IntMap
53+import Data.Map (Map)
54+import qualified Data.Map as Map
55+import Data.Some (Some(Some))
56+import Data.These
57+import Data.Typeable hiding (Refl)
58+
59+--------------------------------------------------------------------------------
60+-- Const2
61+--------------------------------------------------------------------------------
62+
63+-- | 'Const2' stores a value of a given type 'k' and ensures that a particular
64+-- type 'v' is always given for the last type parameter
65+data Const2 :: * -> x -> x -> * where
66+ Const2 :: k -> Const2 k v v
67+ deriving (Typeable)
68+
69+-- | Extract the value from a Const2
70+unConst2 :: Const2 k v v' -> k
71+unConst2 (Const2 k) = k
72+
73+deriving instance Eq k => Eq (Const2 k v v')
74+deriving instance Ord k => Ord (Const2 k v v')
75+deriving instance Show k => Show (Const2 k v v')
76+deriving instance Read k => Read (Const2 k v v)
77+
78+instance Show k => GShow (Const2 k v) where
79+ gshowsPrec n x@(Const2 _) = showsPrec n x
80+
81+instance Eq k => GEq (Const2 k v) where
82+ geq (Const2 a) (Const2 b) =
83+ if a == b
84+ then Just Refl
85+ else Nothing
86+
87+instance Ord k => GCompare (Const2 k v) where
88+ gcompare (Const2 a) (Const2 b) = case compare a b of
89+ LT -> GLT
90+ EQ -> GEQ
91+ GT -> GGT
92+
93+-- | Convert a 'DMap' to a regular 'Map'
94+dmapToMap :: DMap (Const2 k v) Identity -> Map k v
95+dmapToMap = Map.fromDistinctAscList . map (\(Const2 k :=> Identity v) -> (k, v)) . DMap.toAscList
96+
97+-- | Convert a 'DMap' to an 'IntMap'
98+dmapToIntMap :: DMap (Const2 IntMap.Key v) Identity -> IntMap v
99+dmapToIntMap = IntMap.fromDistinctAscList . map (\(Const2 k :=> Identity v) -> (k, v)) . DMap.toAscList
100+
101+-- | Convert a 'DMap' to a regular 'Map', applying the given function to remove
102+-- the wrapping 'Functor'
103+dmapToMapWith :: (f v -> v') -> DMap (Const2 k v) f -> Map k v'
104+dmapToMapWith f = Map.fromDistinctAscList . map (\(Const2 k :=> v) -> (k, f v)) . DMap.toAscList
105+
106+-- | Convert a regular 'Map' to a 'DMap'
107+mapToDMap :: Map k v -> DMap (Const2 k v) Identity
108+mapToDMap = DMap.fromDistinctAscList . map (\(k, v) -> Const2 k :=> Identity v) . Map.toAscList
109+
110+-- | Convert a regular 'Map', where the values are already wrapped in a functor,
111+-- to a 'DMap'
112+mapWithFunctorToDMap :: Map k (f v) -> DMap (Const2 k v) f
113+mapWithFunctorToDMap = DMap.fromDistinctAscList . map (\(k, v) -> Const2 k :=> v) . Map.toAscList
114+
115+-- | Convert a regular 'IntMap', where the values are already wrapped in a
116+-- functor, to a 'DMap'
117+intMapWithFunctorToDMap :: IntMap (f v) -> DMap (Const2 IntMap.Key v) f
118+intMapWithFunctorToDMap = DMap.fromDistinctAscList . map (\(k, v) -> Const2 k :=> v) . IntMap.toAscList
119+
120+-- | Convert a 'DMap' to a regular 'Map' by forgetting the types associated with
121+-- the keys, using a function to remove the wrapping 'Functor'
122+weakenDMapWith :: (forall a. v a -> v') -> DMap k v -> Map (Some k) v'
123+weakenDMapWith f = Map.fromDistinctAscList . map (\(k :=> v) -> (Some k, f v)) . DMap.toAscList
124+
125+--------------------------------------------------------------------------------
126+-- WrapArg
127+--------------------------------------------------------------------------------
128+
129+-- | 'WrapArg' can be used to tag a value in one functor with a type
130+-- representing another functor. This was primarily used with dependent-map <
131+-- 0.2, in which the value type was not wrapped in a separate functor.
132+data WrapArg :: (k -> *) -> (k -> *) -> * -> * where
133+ WrapArg :: f a -> WrapArg g f (g a)
134+
135+deriving instance Eq (f a) => Eq (WrapArg g f (g' a))
136+deriving instance Ord (f a) => Ord (WrapArg g f (g' a))
137+deriving instance Show (f a) => Show (WrapArg g f (g' a))
138+deriving instance Read (f a) => Read (WrapArg g f (g a))
139+
140+instance GEq f => GEq (WrapArg g f) where
141+ geq (WrapArg a) (WrapArg b) = (\Refl -> Refl) <$> geq a b
142+
143+instance GCompare f => GCompare (WrapArg g f) where
144+ gcompare (WrapArg a) (WrapArg b) = case gcompare a b of
145+ GLT -> GLT
146+ GEQ -> GEQ
147+ GGT -> GGT
148+
149+--------------------------------------------------------------------------------
150+-- Convenience functions for DMap
151+--------------------------------------------------------------------------------
152+
153+-- | Map over all key/value pairs in a 'DMap', potentially altering the key as
154+-- well as the value. The provided function MUST preserve the ordering of the
155+-- keys, or the resulting 'DMap' will be malformed.
156+mapKeyValuePairsMonotonic :: (DSum k v -> DSum k' v') -> DMap k v -> DMap k' v'
157+mapKeyValuePairsMonotonic f = DMap.fromDistinctAscList . map f . DMap.toAscList
158+
159+{-# INLINE combineDMapsWithKey #-}
160+-- | Union two 'DMap's of different types, yielding another type. Each key that
161+-- is present in either input map will be present in the output.
162+combineDMapsWithKey :: forall f g h i.
163+ GCompare f
164+ => (forall a. f a -> These (g a) (h a) -> i a)
165+ -> DMap f g
166+ -> DMap f h
167+ -> DMap f i
168+combineDMapsWithKey f mg mh = DMap.fromList $ go (DMap.toList mg) (DMap.toList mh)
169+ where go :: [DSum f g] -> [DSum f h] -> [DSum f i]
170+ go [] hs = map (\(hk :=> hv) -> hk :=> f hk (That hv)) hs
171+ go gs [] = map (\(gk :=> gv) -> gk :=> f gk (This gv)) gs
172+ go gs@((gk :=> gv) : gs') hs@((hk :=> hv) : hs') = case gk `gcompare` hk of
173+ GLT -> (gk :=> f gk (This gv)) : go gs' hs
174+ GEQ -> (gk :=> f gk (These gv hv)) : go gs' hs'
175+ GGT -> (hk :=> f hk (That hv)) : go gs hs'
176+
177+-- | Extract the values of a 'DMap' of 'EitherTag's.
178+dmapToThese :: DMap (EitherTag a b) Identity -> Maybe (These a b)
179+dmapToThese m = case (DMap.lookup LeftTag m, DMap.lookup RightTag m) of
180+ (Nothing, Nothing) -> Nothing
181+ (Just (Identity a), Nothing) -> Just $ This a
182+ (Nothing, Just (Identity b)) -> Just $ That b
183+ (Just (Identity a), Just (Identity b)) -> Just $ These a b
184+
185+-- | Tag type for 'Either' to use it as a 'DSum'.
186+data EitherTag l r a where
187+ LeftTag :: EitherTag l r l
188+ RightTag :: EitherTag l r r
189+ deriving (Typeable)
190+
191+deriving instance Show (EitherTag l r a)
192+deriving instance Eq (EitherTag l r a)
193+deriving instance Ord (EitherTag l r a)
194+
195+instance GEq (EitherTag l r) where
196+ geq a b = case (a, b) of
197+ (LeftTag, LeftTag) -> Just Refl
198+ (RightTag, RightTag) -> Just Refl
199+ _ -> Nothing
200+
201+instance GCompare (EitherTag l r) where
202+ gcompare a b = case (a, b) of
203+ (LeftTag, LeftTag) -> GEQ
204+ (LeftTag, RightTag) -> GLT
205+ (RightTag, LeftTag) -> GGT
206+ (RightTag, RightTag) -> GEQ
207+
208+instance GShow (EitherTag l r) where
209+ gshowsPrec _ a = case a of
210+ LeftTag -> showString "LeftTag"
211+ RightTag -> showString "RightTag"
212+
213+-- | Convert 'Either' to a 'DSum'. Inverse of 'dsumToEither'.
214+eitherToDSum :: Either a b -> DSum (EitherTag a b) Identity
215+eitherToDSum = \case
216+ Left a -> (LeftTag :=> Identity a)
217+ Right b -> (RightTag :=> Identity b)
218+
219+-- | Convert 'DSum' to 'Either'. Inverse of 'eitherToDSum'.
220+dsumToEither :: DSum (EitherTag a b) Identity -> Either a b
221+dsumToEither = \case
222+ (LeftTag :=> Identity a) -> Left a
223+ (RightTag :=> Identity b) -> Right b
224+
225+--------------------------------------------------------------------------------
226+-- ComposeMaybe
227+--------------------------------------------------------------------------------
228+
229+-- | We can't use @Compose Maybe@ instead of 'ComposeMaybe', because that would
230+-- make the 'f' parameter have a nominal type role. We need f to be
231+-- representational so that we can use safe 'coerce'.
232+newtype ComposeMaybe f a =
233+ ComposeMaybe { getComposeMaybe :: Maybe (f a) } deriving (Show, Eq, Ord)
234+
235+deriving instance Functor f => Functor (ComposeMaybe f)
src/Data/Map/Misc.hs+1−1
@@ -43,7 +43,7 @@ diffMap olds news = flip Map.mapMaybe (align olds news) $ \case
43
43
44-- |Given a @'Map' k (Maybe v)@ representing keys to insert/update (@Just@) or delete (@Nothing@), produce a new map from the given input @'Map' k v@.
44-- |Given a @'Map' k (Maybe v)@ representing keys to insert/update (@Just@) or delete (@Nothing@), produce a new map from the given input @'Map' k v@.
45--
45--
46−-- See also 'Data.Patch.Map' and 'Data.Patch.MapWithMove'.
46+-- See also 'Reflex.Patch.Map' and 'Reflex.Patch.MapWithMove'.
47applyMap :: Ord k => Map k (Maybe v) -> Map k v -> Map k v
47applyMap :: Ord k => Map k (Maybe v) -> Map k v -> Map k v
48applyMap patch old = insertions `Map.union` (old `Map.difference` deletions)
48applyMap patch old = insertions `Map.union` (old `Map.difference` deletions)
49 where (deletions, insertions) = Map.mapEither maybeToEither patch
49 where (deletions, insertions) = Map.mapEither maybeToEither patch
src/Data/WeakBag.hs+3−8
@@ -15,7 +15,6 @@ module Data.WeakBag
15 , singleton
15 , singleton
16 , insert
16 , insert
17 , traverse
17 , traverse
18− , traverse_
19 , remove
18 , remove
20 -- * Internal functions
19 -- * Internal functions
21 -- These will not always be available.
20 -- These will not always be available.
@@ -100,22 +99,18 @@ singleton a wbRef finalizer = {-# SCC "singleton" #-} do
100 ticket <- insert a bag wbRef finalizer
99 ticket <- insert a bag wbRef finalizer
101 return (bag, ticket)
100 return (bag, ticket)
102
101
103−{-# INLINE traverse_ #-}
102+{-# INLINE traverse #-}
104-- | Visit every node in the given list. If new nodes are appended during the
103-- | Visit every node in the given list. If new nodes are appended during the
105-- traversal, they will not be visited. Every live node that was in the list
104-- traversal, they will not be visited. Every live node that was in the list
106-- when the traversal began will be visited exactly once; however, no guarantee
105-- when the traversal began will be visited exactly once; however, no guarantee
107-- is made about the order of the traversal.
106-- is made about the order of the traversal.
108−traverse_ :: MonadIO m => WeakBag a -> (a -> m ()) -> m ()
107+traverse :: MonadIO m => WeakBag a -> (a -> m ()) -> m ()
109−traverse_ (WeakBag _ children) f = {-# SCC "traverse" #-} do
108+traverse (WeakBag _ children) f = {-# SCC "traverse" #-} do
110 cs <- liftIO $ readIORef children
109 cs <- liftIO $ readIORef children
111 forM_ cs $ \c -> do
110 forM_ cs $ \c -> do
112 ma <- liftIO $ deRefWeak c
111 ma <- liftIO $ deRefWeak c
113 mapM_ f ma
112 mapM_ f ma
114
113
115−{-# DEPRECATED traverse "Use 'traverse_' instead" #-}
116−traverse :: MonadIO m => WeakBag a -> (a -> m ()) -> m ()
117−traverse = traverse_
118−
119-- | Remove an item from the 'WeakBag'; does nothing if invoked multiple times
114-- | Remove an item from the 'WeakBag'; does nothing if invoked multiple times
120-- on the same 'WeakBagTicket'.
115-- on the same 'WeakBagTicket'.
121{-# INLINE remove #-}
116{-# INLINE remove #-}
src/Reflex/Adjustable/Class.hs+3−3
@@ -3,6 +3,7 @@
3{-# LANGUAGE FlexibleInstances #-}
3{-# LANGUAGE FlexibleInstances #-}
4{-# LANGUAGE FunctionalDependencies #-}
4{-# LANGUAGE FunctionalDependencies #-}
5{-# LANGUAGE LambdaCase #-}
5{-# LANGUAGE LambdaCase #-}
6+{-# LANGUAGE MultiParamTypeClasses #-}
6{-# LANGUAGE RankNTypes #-}
7{-# LANGUAGE RankNTypes #-}
7{-# LANGUAGE ScopedTypeVariables #-}
8{-# LANGUAGE ScopedTypeVariables #-}
8{-# LANGUAGE TypeFamilies #-}
9{-# LANGUAGE TypeFamilies #-}
@@ -30,8 +31,7 @@ module Reflex.Adjustable.Class
30
31
31import Control.Monad.Identity
32import Control.Monad.Identity
32import Control.Monad.Reader
33import Control.Monad.Reader
33−import Data.Dependent.Map (DMap)
34+import Data.Dependent.Map (DMap, GCompare (..))
34−import Data.GADT.Compare (GCompare(..))
35import qualified Data.Dependent.Map as DMap
35import qualified Data.Dependent.Map as DMap
36import Data.Functor.Constant
36import Data.Functor.Constant
37import Data.Functor.Misc
37import Data.Functor.Misc
@@ -40,7 +40,7 @@ import qualified Data.IntMap.Strict as IntMap
40import Data.Map (Map)
40import Data.Map (Map)
41
41
42import Reflex.Class
42import Reflex.Class
43−import Data.Patch.DMapWithMove
43+import Reflex.Patch.DMapWithMove
44
44
45-- | A 'Monad' that supports adjustment over time. After an action has been
45-- | A 'Monad' that supports adjustment over time. After an action has been
46-- run, if the given events fire, it will adjust itself so that its net effect
46-- run, if the given events fire, it will adjust itself so that its net effect
src/Reflex/BehaviorWriter/Base.hs+7−16
@@ -1,6 +1,6 @@
1{-|
1{-|
2Module: Reflex.BehaviorWriter.Base
2Module: Reflex.BehaviorWriter.Base
3−Description: Implementation of BehaviorWriter
3+Description: Implementation of MonadBehaviorWriter
4-}
4-}
5{-# LANGUAGE CPP #-}
5{-# LANGUAGE CPP #-}
6{-# LANGUAGE FlexibleInstances #-}
6{-# LANGUAGE FlexibleInstances #-}
@@ -24,7 +24,6 @@ module Reflex.BehaviorWriter.Base
24import Control.Monad.Exception
24import Control.Monad.Exception
25import Control.Monad.Identity
25import Control.Monad.Identity
26import Control.Monad.IO.Class
26import Control.Monad.IO.Class
27−import Control.Monad.Morph
28import Control.Monad.Reader
27import Control.Monad.Reader
29import Control.Monad.Ref
28import Control.Monad.Ref
30import Control.Monad.State.Strict
29import Control.Monad.State.Strict
@@ -47,20 +46,9 @@ import Reflex.Query.Class
47import Reflex.Requester.Class
46import Reflex.Requester.Class
48import Reflex.TriggerEvent.Class
47import Reflex.TriggerEvent.Class
49
48
50−-- | A basic implementation of 'BehaviorWriter'.
49+-- | A basic implementation of 'MonadBehaviorWriter'.
51newtype BehaviorWriterT t w m a = BehaviorWriterT { unBehaviorWriterT :: StateT [Behavior t w] m a }
50newtype BehaviorWriterT t w m a = BehaviorWriterT { unBehaviorWriterT :: StateT [Behavior t w] m a }
52− -- The list is kept in reverse order
51+ deriving (Functor, Applicative, Monad, MonadIO, MonadFix, MonadAsyncException, MonadException) -- The list is kept in reverse order
53− deriving
54− ( Functor
55− , Applicative
56− , Monad
57− , MonadTrans
58− , MFunctor
59− , MonadIO
60− , MonadFix
61− , MonadAsyncException
62− , MonadException
63− )
64
52
65-- | Run a 'BehaviorWriterT' action. The behavior writer output will be provided
53-- | Run a 'BehaviorWriterT' action. The behavior writer output will be provided
66-- along with the result of the action.
54-- along with the result of the action.
@@ -85,6 +73,9 @@ withBehaviorWriterT f dw = do
85deriving instance MonadHold t m => MonadHold t (BehaviorWriterT t w m)
73deriving instance MonadHold t m => MonadHold t (BehaviorWriterT t w m)
86deriving instance MonadSample t m => MonadSample t (BehaviorWriterT t w m)
74deriving instance MonadSample t m => MonadSample t (BehaviorWriterT t w m)
87
75
76+instance MonadTrans (BehaviorWriterT t w) where
77+ lift = BehaviorWriterT . lift
78+
88instance MonadRef m => MonadRef (BehaviorWriterT t w m) where
79instance MonadRef m => MonadRef (BehaviorWriterT t w m) where
89 type Ref (BehaviorWriterT t w m) = Ref m
80 type Ref (BehaviorWriterT t w m) = Ref m
90 newRef = lift . newRef
81 newRef = lift . newRef
@@ -98,7 +89,7 @@ instance MonadReflexCreateTrigger t m => MonadReflexCreateTrigger t (BehaviorWri
98 newEventWithTrigger = lift . newEventWithTrigger
89 newEventWithTrigger = lift . newEventWithTrigger
99 newFanEventWithTrigger f = lift $ newFanEventWithTrigger f
90 newFanEventWithTrigger f = lift $ newFanEventWithTrigger f
100
91
101−instance (Monad m, Monoid w, Reflex t) => BehaviorWriter t w (BehaviorWriterT t w m) where
92+instance (Monad m, Monoid w, Reflex t) => MonadBehaviorWriter t w (BehaviorWriterT t w m) where
102 tellBehavior w = BehaviorWriterT $ modify (w :)
93 tellBehavior w = BehaviorWriterT $ modify (w :)
103
94
104instance MonadReader r m => MonadReader r (BehaviorWriterT t w m) where
95instance MonadReader r m => MonadReader r (BehaviorWriterT t w m) where
src/Reflex/BehaviorWriter/Class.hs+6−11
@@ -1,31 +1,26 @@
1{-|
1{-|
2Module: Reflex.BehaviorWriter.Class
2Module: Reflex.BehaviorWriter.Class
3−Description: This module defines the 'BehaviorWriter' class
3+Description: This module defines the 'MonadBehaviorWriter' class
4-}
4-}
5{-# LANGUAGE CPP #-}
5{-# LANGUAGE CPP #-}
6−{-# LANGUAGE ConstraintKinds #-}
7{-# LANGUAGE FlexibleInstances #-}
6{-# LANGUAGE FlexibleInstances #-}
8{-# LANGUAGE FunctionalDependencies #-}
7{-# LANGUAGE FunctionalDependencies #-}
8+{-# LANGUAGE MultiParamTypeClasses #-}
9{-# LANGUAGE UndecidableInstances #-}
9{-# LANGUAGE UndecidableInstances #-}
10#ifdef USE_REFLEX_OPTIMIZER
10#ifdef USE_REFLEX_OPTIMIZER
11{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
11{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
12#endif
12#endif
13module Reflex.BehaviorWriter.Class
13module Reflex.BehaviorWriter.Class
14− ( MonadBehaviorWriter
14+ ( MonadBehaviorWriter (..)
15− , BehaviorWriter(..)
16 ) where
15 ) where
17
16
18import Control.Monad.Reader (ReaderT, lift)
17import Control.Monad.Reader (ReaderT, lift)
19import Reflex.Class (Behavior)
18import Reflex.Class (Behavior)
20
19
21−{-# DEPRECATED MonadBehaviorWriter "Use 'BehaviorWriter' instead" #-}
22−-- | Type synonym for 'BehaviorWriter'
23−type MonadBehaviorWriter = BehaviorWriter
24−
25−-- | 'BehaviorWriter' efficiently collects 'Behavior' values using 'tellBehavior'
20+-- | 'MonadBehaviorWriter' efficiently collects 'Behavior' values using 'tellBehavior'
26-- and combines them monoidally to provide a 'Behavior' result.
21-- and combines them monoidally to provide a 'Behavior' result.
27−class (Monad m, Monoid w) => BehaviorWriter t w m | m -> t w where
22+class (Monad m, Monoid w) => MonadBehaviorWriter t w m | m -> t w where
28 tellBehavior :: Behavior t w -> m ()
23 tellBehavior :: Behavior t w -> m ()
29
24
30−instance BehaviorWriter t w m => BehaviorWriter t w (ReaderT r m) where
25+instance MonadBehaviorWriter t w m => MonadBehaviorWriter t w (ReaderT r m) where
31 tellBehavior = lift . tellBehavior
26 tellBehavior = lift . tellBehavior
src/Reflex/Class.hs+31−140
@@ -7,6 +7,7 @@
7{-# LANGUAGE FunctionalDependencies #-}
7{-# LANGUAGE FunctionalDependencies #-}
8{-# LANGUAGE GADTs #-}
8{-# LANGUAGE GADTs #-}
9{-# LANGUAGE LambdaCase #-}
9{-# LANGUAGE LambdaCase #-}
10+{-# LANGUAGE MultiParamTypeClasses #-}
10{-# LANGUAGE NoMonomorphismRestriction #-}
11{-# LANGUAGE NoMonomorphismRestriction #-}
11{-# LANGUAGE PolyKinds #-}
12{-# LANGUAGE PolyKinds #-}
12{-# LANGUAGE RankNTypes #-}
13{-# LANGUAGE RankNTypes #-}
@@ -16,7 +17,6 @@
16{-# LANGUAGE TypeFamilies #-}
17{-# LANGUAGE TypeFamilies #-}
17{-# LANGUAGE TypeOperators #-}
18{-# LANGUAGE TypeOperators #-}
18{-# LANGUAGE UndecidableInstances #-}
19{-# LANGUAGE UndecidableInstances #-}
19−{-# LANGUAGE Trustworthy #-}
20#ifdef USE_REFLEX_OPTIMIZER
20#ifdef USE_REFLEX_OPTIMIZER
21{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
21{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
22#endif
22#endif
@@ -29,28 +29,23 @@
29-- convenience functions for working with 'Event's, 'Behavior's, and other
29-- convenience functions for working with 'Event's, 'Behavior's, and other
30-- signals.
30-- signals.
31module Reflex.Class
31module Reflex.Class
32− ( module Data.Patch
32+ ( module Reflex.Patch
33 -- * Primitives
33 -- * Primitives
34 , Reflex (..)
34 , Reflex (..)
35 , mergeInt
35 , mergeInt
36 , coerceBehavior
36 , coerceBehavior
37 , coerceEvent
37 , coerceEvent
38 , coerceDynamic
38 , coerceDynamic
39− , coerceIncremental
40 , MonadSample (..)
39 , MonadSample (..)
41 , MonadHold (..)
40 , MonadHold (..)
42 -- ** 'fan' related types
41 -- ** 'fan' related types
43 , EventSelector (..)
42 , EventSelector (..)
44− , EventSelectorG (..)
45 , EventSelectorInt (..)
43 , EventSelectorInt (..)
46 -- * Convenience functions
44 -- * Convenience functions
47 , constDyn
45 , constDyn
48 , pushAlways
46 , pushAlways
49 -- ** Combining 'Event's
47 -- ** Combining 'Event's
50 , leftmost
48 , leftmost
51− , merge
52− , mergeIncremental
53− , mergeIncrementalWithMove
54 , mergeMap
49 , mergeMap
55 , mergeIntMap
50 , mergeIntMap
56 , mergeMapIncremental
51 , mergeMapIncremental
@@ -65,7 +60,6 @@ module Reflex.Class
65 , alignEventWithMaybe
60 , alignEventWithMaybe
66 -- ** Breaking up 'Event's
61 -- ** Breaking up 'Event's
67 , splitE
62 , splitE
68− , fan
69 , fanEither
63 , fanEither
70 , fanThese
64 , fanThese
71 , fanMap
65 , fanMap
@@ -90,7 +84,6 @@ module Reflex.Class
90 , gate
84 , gate
91 -- ** Combining 'Dynamic's
85 -- ** Combining 'Dynamic's
92 , distributeDMapOverDynPure
86 , distributeDMapOverDynPure
93− , distributeDMapOverDynPureG
94 , distributeListOverDyn
87 , distributeListOverDyn
95 , distributeListOverDynWith
88 , distributeListOverDynWith
96 , zipDyn
89 , zipDyn
@@ -173,17 +166,6 @@ module Reflex.Class
173 , slowHeadE
166 , slowHeadE
174 ) where
167 ) where
175
168
176−#ifdef MIN_VERSION_semialign
177−import Prelude hiding (zip, zipWith)
178−
179−#if MIN_VERSION_these(0,8,0)
180−import Data.These.Combinators (justThese)
181−#endif
182−#if MIN_VERSION_semialign(1,1,0)
183−import Data.Zip (Zip (..), Unzip (..))
184−#endif
185−#endif
186−
187import Control.Applicative
169import Control.Applicative
188import Control.Monad.Identity
170import Control.Monad.Identity
189import Control.Monad.Reader
171import Control.Monad.Reader
@@ -196,12 +178,11 @@ import Data.Align
196import Data.Bifunctor
178import Data.Bifunctor
197import Data.Coerce
179import Data.Coerce
198import Data.Default
180import Data.Default
199−import Data.Dependent.Map (DMap)
181+import Data.Dependent.Map (DMap, DSum (..))
200−import Data.Dependent.Sum (DSum (..))
201import qualified Data.Dependent.Map as DMap
182import qualified Data.Dependent.Map as DMap
202import Data.Functor.Compose
183import Data.Functor.Compose
203import Data.Functor.Product
184import Data.Functor.Product
204−import Data.GADT.Compare (GEq (..), GCompare (..))
185+import Data.GADT.Compare (GEq (..), GCompare (..), (:~:) (..))
205import Data.FastMutableIntMap (PatchIntMap)
186import Data.FastMutableIntMap (PatchIntMap)
206import Data.Foldable
187import Data.Foldable
207import Data.Functor.Bind
188import Data.Functor.Bind
@@ -211,18 +192,17 @@ import Data.IntMap.Strict (IntMap)
211import qualified Data.IntMap.Strict as IntMap
192import qualified Data.IntMap.Strict as IntMap
212import Data.List.NonEmpty (NonEmpty (..))
193import Data.List.NonEmpty (NonEmpty (..))
213import Data.Map (Map)
194import Data.Map (Map)
214−import Data.Semigroup (Semigroup (..))
195+import Data.Semigroup (Semigroup, sconcat, stimes, (<>))
215import Data.Some (Some(Some))
196import Data.Some (Some(Some))
216import Data.String
197import Data.String
217import Data.These
198import Data.These
218import Data.Type.Coercion
199import Data.Type.Coercion
219−import Data.Type.Equality ((:~:) (..))
220import Data.Witherable (Filterable(..))
200import Data.Witherable (Filterable(..))
221import qualified Data.Witherable as W
201import qualified Data.Witherable as W
222import Reflex.FunctorMaybe (FunctorMaybe)
202import Reflex.FunctorMaybe (FunctorMaybe)
223import qualified Reflex.FunctorMaybe
203import qualified Reflex.FunctorMaybe
224−import Data.Patch
204+import Reflex.Patch
225−import qualified Data.Patch.MapWithMove as PatchMapWithMove
205+import qualified Reflex.Patch.MapWithMove as PatchMapWithMove
226
206
227import Debug.Trace (trace)
207import Debug.Trace (trace)
228
208
@@ -275,21 +255,15 @@ class ( MonadHold t (PushM t)
275 -- | Merge a collection of events; the resulting 'Event' will only occur if at
255 -- | Merge a collection of events; the resulting 'Event' will only occur if at
276 -- least one input event is occurring, and will contain all of the input keys
256 -- least one input event is occurring, and will contain all of the input keys
277 -- that are occurring simultaneously
257 -- that are occurring simultaneously
278−
279− --TODO: Generalize to get rid of DMap use --TODO: Provide a type-level guarantee that the result is not empty
258+ merge :: GCompare k => DMap k (Event t) -> Event t (DMap k Identity) --TODO: Generalize to get rid of DMap use --TODO: Provide a type-level guarantee that the result is not empty
280− mergeG :: GCompare k => (forall a. q a -> Event t (v a))
281− -> DMap k q -> Event t (DMap k v)
282−
283 -- | Efficiently fan-out an event to many destinations. You should save the
259 -- | Efficiently fan-out an event to many destinations. You should save the
284− -- result in a @let@-binding, and then repeatedly 'selectG' on the result to
260+ -- result in a @let@-binding, and then repeatedly 'select' on the result to
285 -- create child events
261 -- create child events
286− fanG :: GCompare k => Event t (DMap k v) -> EventSelectorG t k v
262+ fan :: GCompare k => Event t (DMap k Identity) -> EventSelector t k
287−
288 -- | Create an 'Event' that will occur whenever the currently-selected input
263 -- | Create an 'Event' that will occur whenever the currently-selected input
289 -- 'Event' occurs
264 -- 'Event' occurs
290 switch :: Behavior t (Event t a) -> Event t a
265 switch :: Behavior t (Event t a) -> Event t a
291− -- | Create an 'Event' that will occur whenever the input event is occurring -- and its occurrence value, another 'Event', is also occurring.
266+ -- | Create an 'Event' that will occur whenever the input event is occurring -- and its occurrence value, another 'Event', is also occurring
292− -- You maybe looking for '@switchHold@ @never@' instead.
293 coincidence :: Event t (Event t a) -> Event t a
267 coincidence :: Event t (Event t a) -> Event t a
294 -- | Extract the 'Behavior' of a 'Dynamic'.
268 -- | Extract the 'Behavior' of a 'Dynamic'.
295 current :: Dynamic t a -> Behavior t a
269 current :: Dynamic t a -> Behavior t a
@@ -303,14 +277,9 @@ class ( MonadHold t (PushM t)
303 -- that value.
277 -- that value.
304 unsafeBuildIncremental :: Patch p => PullM t (PatchTarget p) -> Event t p -> Incremental t p
278 unsafeBuildIncremental :: Patch p => PullM t (PatchTarget p) -> Event t p -> Incremental t p
305 -- | Create a merge whose parents can change over time
279 -- | Create a merge whose parents can change over time
306− mergeIncrementalG :: GCompare k
307− => (forall a. q a -> Event t (v a))
308− -> Incremental t (PatchDMap k q)
280+ mergeIncremental :: GCompare k => Incremental t (PatchDMap k (Event t)) -> Event t (DMap k Identity)
309− -> Event t (DMap k v)
310 -- | Experimental: Create a merge whose parents can change over time; changing the key of an Event is more efficient than with mergeIncremental
281 -- | Experimental: Create a merge whose parents can change over time; changing the key of an Event is more efficient than with mergeIncremental
311− mergeIncrementalWithMoveG :: GCompare k
312− => (forall a. q a -> Event t (v a))
313− -> Incremental t (PatchDMapWithMove k q) -> Event t (DMap k v)
282+ mergeIncrementalWithMove :: GCompare k => Incremental t (PatchDMapWithMove k (Event t)) -> Event t (DMap k Identity)
314 -- | Extract the 'Behavior' component of an 'Incremental'
283 -- | Extract the 'Behavior' component of an 'Incremental'
315 currentIncremental :: Patch p => Incremental t p -> Behavior t (PatchTarget p)
284 currentIncremental :: Patch p => Incremental t p -> Behavior t (PatchTarget p)
316 -- | Extract the 'Event' component of an 'Incremental'
285 -- | Extract the 'Event' component of an 'Incremental'
@@ -326,25 +295,9 @@ class ( MonadHold t (PushM t)
326 -- | Construct a 'Coercion' for a 'Dynamic' given an 'Coercion' for its
295 -- | Construct a 'Coercion' for a 'Dynamic' given an 'Coercion' for its
327 -- occurrence type
296 -- occurrence type
328 dynamicCoercion :: Coercion a b -> Coercion (Dynamic t a) (Dynamic t b)
297 dynamicCoercion :: Coercion a b -> Coercion (Dynamic t a) (Dynamic t b)
329− -- | Construct a 'Coercion' for an 'Incremental' given 'Coercion's for its
330− -- patch target and patch types.
331− incrementalCoercion
332− :: Coercion (PatchTarget a) (PatchTarget b) -> Coercion a b -> Coercion (Incremental t a) (Incremental t b)
333 mergeIntIncremental :: Incremental t (PatchIntMap (Event t a)) -> Event t (IntMap a)
298 mergeIntIncremental :: Incremental t (PatchIntMap (Event t a)) -> Event t (IntMap a)
334 fanInt :: Event t (IntMap a) -> EventSelectorInt t a
299 fanInt :: Event t (IntMap a) -> EventSelectorInt t a
335
300
336−-- | Efficiently fan-out an event to many destinations. You should save the
337−-- result in a @let@-binding, and then repeatedly 'select' on the result to
338−-- create child events
339−fan :: forall t k. (Reflex t, GCompare k)
340− => Event t (DMap k Identity) -> EventSelector t k
341− --TODO: Can we help enforce the partial application discipline here? The combinator is worthless without it
342−fan e = EventSelector (fixup (selectG (fanG e) :: k a -> Event t (Identity a)) :: forall a. k a -> Event t a)
343− where
344− fixup :: forall a. (k a -> Event t (Identity a)) -> k a -> Event t a
345− fixup = case eventCoercion Coercion :: Coercion (Event t (Identity a)) (Event t a) of
346− Coercion -> coerce
347−
348--TODO: Specialize this so that we can take advantage of knowing that there's no changing going on
301--TODO: Specialize this so that we can take advantage of knowing that there's no changing going on
349-- | Constructs a single 'Event' out of a map of events. The output event may fire with multiple
302-- | Constructs a single 'Event' out of a map of events. The output event may fire with multiple
350-- keys simultaneously.
303-- keys simultaneously.
@@ -363,12 +316,6 @@ coerceEvent = coerceWith $ eventCoercion Coercion
363coerceDynamic :: (Reflex t, Coercible a b) => Dynamic t a -> Dynamic t b
316coerceDynamic :: (Reflex t, Coercible a b) => Dynamic t a -> Dynamic t b
364coerceDynamic = coerceWith $ dynamicCoercion Coercion
317coerceDynamic = coerceWith $ dynamicCoercion Coercion
365
318
366−-- | Coerce an 'Incremental' between representationally-equivalent value types
367−coerceIncremental
368− :: (Reflex t, Coercible a b, Coercible (PatchTarget a) (PatchTarget b))
369− => Incremental t a -> Incremental t b
370−coerceIncremental = coerceWith $ incrementalCoercion Coercion Coercion
371−
372-- | Construct a 'Dynamic' from a 'Behavior' and an 'Event'. The 'Behavior'
319-- | Construct a 'Dynamic' from a 'Behavior' and an 'Event'. The 'Behavior'
373-- __must__ change when and only when the 'Event' fires, such that the
320-- __must__ change when and only when the 'Event' fires, such that the
374-- 'Behavior''s value is always equal to the most recent firing of the 'Event';
321-- 'Behavior''s value is always equal to the most recent firing of the 'Event';
@@ -421,13 +368,6 @@ class MonadSample t m => MonadHold t m where
421 -- | Create a new 'Event' that only occurs only once, on the first occurrence of
368 -- | Create a new 'Event' that only occurs only once, on the first occurrence of
422 -- the supplied 'Event'.
369 -- the supplied 'Event'.
423 headE :: Event t a -> m (Event t a)
370 headE :: Event t a -> m (Event t a)
424− -- | An event which only occurs at the current moment in time, such that:
425− --
426− -- > coincidence (pushAlways (\a -> (a <$) <$> now) e) = e
427− --
428− now :: m (Event t ())
429− default now :: (m ~ f m', MonadTrans f, MonadHold t m') => m (Event t ())
430− now = lift now
431
371
432-- | Accumulate an 'Incremental' with the supplied initial value and the firings of the provided 'Event',
372-- | Accumulate an 'Incremental' with the supplied initial value and the firings of the provided 'Event',
433-- using the combining function to produce a patch.
373-- using the combining function to produce a patch.
@@ -545,17 +485,6 @@ newtype EventSelector t k = EventSelector
545 select :: forall a. k a -> Event t a
485 select :: forall a. k a -> Event t a
546 }
486 }
547
487
548−newtype EventSelectorG t k v = EventSelectorG
549− { -- | Retrieve the 'Event' for the given key. The type of the 'Event' is
550− -- determined by the type of the key, so this can be used to fan-out
551− -- 'Event's whose sub-'Event's have different types.
552− --
553− -- Using 'EventSelector's and the 'fan' primitive is far more efficient than
554− -- (but equivalent to) using 'mapMaybe' to select only the relevant
555− -- occurrences of an 'Event'.
556− selectG :: forall a. k a -> Event t (v a)
557− }
558−
559-- | Efficiently select an 'Event' keyed on 'Int'. This is more efficient than manually
488-- | Efficiently select an 'Event' keyed on 'Int'. This is more efficient than manually
560-- filtering by key.
489-- filtering by key.
561newtype EventSelectorInt t a = EventSelectorInt { selectInt :: Int -> Event t a }
490newtype EventSelectorInt t a = EventSelectorInt { selectInt :: Int -> Event t a }
@@ -573,7 +502,6 @@ instance MonadHold t m => MonadHold t (ReaderT r m) where
573 holdIncremental a0 = lift . holdIncremental a0
502 holdIncremental a0 = lift . holdIncremental a0
574 buildDynamic a0 = lift . buildDynamic a0
503 buildDynamic a0 = lift . buildDynamic a0
575 headE = lift . headE
504 headE = lift . headE
576− now = lift now
577
505
578instance (MonadSample t m, Monoid r) => MonadSample t (WriterT r m) where
506instance (MonadSample t m, Monoid r) => MonadSample t (WriterT r m) where
579 sample = lift . sample
507 sample = lift . sample
@@ -584,7 +512,6 @@ instance (MonadHold t m, Monoid r) => MonadHold t (WriterT r m) where
584 holdIncremental a0 = lift . holdIncremental a0
512 holdIncremental a0 = lift . holdIncremental a0
585 buildDynamic a0 = lift . buildDynamic a0
513 buildDynamic a0 = lift . buildDynamic a0
586 headE = lift . headE
514 headE = lift . headE
587− now = lift now
588
515
589instance MonadSample t m => MonadSample t (StateT s m) where
516instance MonadSample t m => MonadSample t (StateT s m) where
590 sample = lift . sample
517 sample = lift . sample
@@ -595,7 +522,6 @@ instance MonadHold t m => MonadHold t (StateT s m) where
595 holdIncremental a0 = lift . holdIncremental a0
522 holdIncremental a0 = lift . holdIncremental a0
596 buildDynamic a0 = lift . buildDynamic a0
523 buildDynamic a0 = lift . buildDynamic a0
597 headE = lift . headE
524 headE = lift . headE
598− now = lift now
599
525
600instance MonadSample t m => MonadSample t (ExceptT e m) where
526instance MonadSample t m => MonadSample t (ExceptT e m) where
601 sample = lift . sample
527 sample = lift . sample
@@ -606,7 +532,6 @@ instance MonadHold t m => MonadHold t (ExceptT e m) where
606 holdIncremental a0 = lift . holdIncremental a0
532 holdIncremental a0 = lift . holdIncremental a0
607 buildDynamic a0 = lift . buildDynamic a0
533 buildDynamic a0 = lift . buildDynamic a0
608 headE = lift . headE
534 headE = lift . headE
609− now = lift now
610
535
611instance (MonadSample t m, Monoid w) => MonadSample t (RWST r w s m) where
536instance (MonadSample t m, Monoid w) => MonadSample t (RWST r w s m) where
612 sample = lift . sample
537 sample = lift . sample
@@ -617,7 +542,6 @@ instance (MonadHold t m, Monoid w) => MonadHold t (RWST r w s m) where
617 holdIncremental a0 = lift . holdIncremental a0
542 holdIncremental a0 = lift . holdIncremental a0
618 buildDynamic a0 = lift . buildDynamic a0
543 buildDynamic a0 = lift . buildDynamic a0
619 headE = lift . headE
544 headE = lift . headE
620− now = lift now
621
545
622instance MonadSample t m => MonadSample t (ContT r m) where
546instance MonadSample t m => MonadSample t (ContT r m) where
623 sample = lift . sample
547 sample = lift . sample
@@ -628,7 +552,6 @@ instance MonadHold t m => MonadHold t (ContT r m) where
628 holdIncremental a0 = lift . holdIncremental a0
552 holdIncremental a0 = lift . holdIncremental a0
629 buildDynamic a0 = lift . buildDynamic a0
553 buildDynamic a0 = lift . buildDynamic a0
630 headE = lift . headE
554 headE = lift . headE
631− now = lift now
632
555
633--------------------------------------------------------------------------------
556--------------------------------------------------------------------------------
634-- Convenience functions
557-- Convenience functions
@@ -678,9 +601,7 @@ instance Reflex t => Monad (Behavior t) where
678 a >>= f = pull $ sample a >>= sample . f
601 a >>= f = pull $ sample a >>= sample . f
679 -- Note: it is tempting to write (_ >> b = b); however, this would result in (fail x >> return y) succeeding (returning y), which violates the law that (a >> b = a >>= \_ -> b), since the implementation of (>>=) above actually will fail. Since we can't examine 'Behavior's other than by using sample, I don't think it's possible to write (>>) to be more efficient than the (>>=) above.
602 -- Note: it is tempting to write (_ >> b = b); however, this would result in (fail x >> return y) succeeding (returning y), which violates the law that (a >> b = a >>= \_ -> b), since the implementation of (>>=) above actually will fail. Since we can't examine 'Behavior's other than by using sample, I don't think it's possible to write (>>) to be more efficient than the (>>=) above.
680 return = constant
603 return = constant
681−#if !MIN_VERSION_base(4,13,0)
682 fail = error "Monad (Behavior t) does not support fail"
604 fail = error "Monad (Behavior t) does not support fail"
683−#endif
684
605
685instance (Reflex t, Monoid a) => Monoid (Behavior t a) where
606instance (Reflex t, Monoid a) => Monoid (Behavior t a) where
686 mempty = constant mempty
607 mempty = constant mempty
@@ -708,7 +629,11 @@ instance (Num a, Reflex t) => Num (Dynamic t a) where
708instance (Reflex t, Semigroup a) => Semigroup (Behavior t a) where
629instance (Reflex t, Semigroup a) => Semigroup (Behavior t a) where
709 a <> b = pull $ liftM2 (<>) (sample a) (sample b)
630 a <> b = pull $ liftM2 (<>) (sample a) (sample b)
710 sconcat = pull . fmap sconcat . mapM sample
631 sconcat = pull . fmap sconcat . mapM sample
632+#if MIN_VERSION_semigroups(0,17,0)
711 stimes n = fmap $ stimes n
633 stimes n = fmap $ stimes n
634+#else
635+ times1p n = fmap $ times1p n
636+#endif
712
637
713-- | Alias for 'mapMaybe'
638-- | Alias for 'mapMaybe'
714fmapMaybe :: Filterable f => (a -> Maybe b) -> f a -> f b
639fmapMaybe :: Filterable f => (a -> Maybe b) -> f a -> f b
@@ -735,12 +660,9 @@ filterRight = mapMaybe (either (const Nothing) Just)
735instance Reflex t => Alt (Event t) where
660instance Reflex t => Alt (Event t) where
736 ev1 <!> ev2 = leftmost [ev1, ev2]
661 ev1 <!> ev2 = leftmost [ev1, ev2]
737
662
738−-- | 'Event' intersection. Only occurs when both events are co-incident.
663+-- | 'Event' intersection (convenient interface to 'coincidence').
739instance Reflex t => Apply (Event t) where
664instance Reflex t => Apply (Event t) where
740− evf <.> evx = mapMaybe f (align evf evx) where
665+ evf <.> evx = coincidence (fmap (<$> evx) evf)
741− f (These g a) = Just (g a)
742− f _ = Nothing
743−
744
666
745-- | 'Event' intersection (convenient interface to 'coincidence').
667-- | 'Event' intersection (convenient interface to 'coincidence').
746instance Reflex t => Bind (Event t) where
668instance Reflex t => Bind (Event t) where
@@ -909,7 +831,11 @@ traceEventWith f = push $ \x -> trace (f x) $ return $ Just x
909instance (Semigroup a, Reflex t) => Semigroup (Event t a) where
831instance (Semigroup a, Reflex t) => Semigroup (Event t a) where
910 (<>) = alignWith (mergeThese (<>))
832 (<>) = alignWith (mergeThese (<>))
911 sconcat = fmap sconcat . mergeList . toList
833 sconcat = fmap sconcat . mergeList . toList
834+#if MIN_VERSION_semigroups(0,17,0)
912 stimes n = fmap $ stimes n
835 stimes n = fmap $ stimes n
836+#else
837+ times1p n = fmap $ times1p n
838+#endif
913
839
914instance (Semigroup a, Reflex t) => Monoid (Event t a) where
840instance (Semigroup a, Reflex t) => Monoid (Event t a) where
915 mempty = never
841 mempty = never
@@ -1098,19 +1024,6 @@ instance Reflex t => Semialign (Event t) where
1098#endif
1024#endif
1099 align = alignEventWithMaybe Just
1025 align = alignEventWithMaybe Just
1100
1026
1101−#ifdef MIN_VERSION_semialign
1102−#if MIN_VERSION_semialign(1,1,0)
1103−instance Reflex t => Zip (Event t) where
1104−#endif
1105− zip x y = mapMaybe justThese $ align x y
1106−#endif
1107−
1108−#ifdef MIN_VERSION_semialign
1109−#if MIN_VERSION_semialign(1,1,0)
1110−instance Reflex t => Unzip (Event t) where
1111− unzip = splitE
1112−#endif
1113−#endif
1114
1027
1115-- | Create a new 'Event' that only occurs if the supplied 'Event' occurs and
1028-- | Create a new 'Event' that only occurs if the supplied 'Event' occurs and
1116-- the 'Behavior' is true at the time of occurrence.
1029-- the 'Behavior' is true at the time of occurrence.
@@ -1151,7 +1064,11 @@ zipDynWith f da db =
1151
1064
1152instance (Reflex t, Semigroup a) => Semigroup (Dynamic t a) where
1065instance (Reflex t, Semigroup a) => Semigroup (Dynamic t a) where
1153 (<>) = zipDynWith (<>)
1066 (<>) = zipDynWith (<>)
1067+#if MIN_VERSION_semigroups(0,17,0)
1154 stimes n = fmap $ stimes n
1068 stimes n = fmap $ stimes n
1069+#else
1070+ times1p n = fmap $ times1p n
1071+#endif
1155
1072
1156instance (Reflex t, Monoid a) => Monoid (Dynamic t a) where
1073instance (Reflex t, Monoid a) => Monoid (Dynamic t a) where
1157 mconcat = distributeListOverDynWith mconcat
1074 mconcat = distributeListOverDynWith mconcat
@@ -1162,21 +1079,12 @@ instance (Reflex t, Monoid a) => Monoid (Dynamic t a) where
1162-- 'Dynamic' 'DMap'. Its implementation is more efficient than doing the same
1079-- 'Dynamic' 'DMap'. Its implementation is more efficient than doing the same
1163-- through the use of multiple uses of 'zipDynWith' or 'Applicative' operators.
1080-- through the use of multiple uses of 'zipDynWith' or 'Applicative' operators.
1164distributeDMapOverDynPure :: forall t k. (Reflex t, GCompare k) => DMap k (Dynamic t) -> Dynamic t (DMap k Identity)
1081distributeDMapOverDynPure :: forall t k. (Reflex t, GCompare k) => DMap k (Dynamic t) -> Dynamic t (DMap k Identity)
1165−distributeDMapOverDynPure = distributeDMapOverDynPureG coerceDynamic
1082+distributeDMapOverDynPure dm = case DMap.toList dm of
1166−
1167−-- | This function converts a 'DMap' whose elements are 'Dynamic's into a
1168−-- 'Dynamic' 'DMap'. Its implementation is more efficient than doing the same
1169−-- through the use of multiple uses of 'zipDynWith' or 'Applicative' operators.
1170−distributeDMapOverDynPureG
1171− :: forall t k q v. (Reflex t, GCompare k)
1172− => (forall a. q a -> Dynamic t (v a))
1173− -> DMap k q -> Dynamic t (DMap k v)
1174−distributeDMapOverDynPureG nt dm = case DMap.toList dm of
1175 [] -> constDyn DMap.empty
1083 [] -> constDyn DMap.empty
1176− [k :=> v] -> DMap.singleton k <$> nt v
1084+ [k :=> v] -> fmap (DMap.singleton k . Identity) v
1177 _ ->
1085 _ ->
1178− let getInitial = DMap.traverseWithKey (\_ -> sample . current . nt) dm
1086+ let getInitial = DMap.traverseWithKey (\_ -> fmap Identity . sample . current) dm
1179− edmPre = mergeG getCompose $ DMap.map (Compose . updated . nt) dm
1087+ edmPre = merge $ DMap.map updated dm
1180 result = unsafeBuildDynamic getInitial $ flip pushAlways edmPre $ \news -> do
1088 result = unsafeBuildDynamic getInitial $ flip pushAlways edmPre $ \news -> do
1181 olds <- sample $ current result
1089 olds <- sample $ current result
1182 return $ DMap.unionWithKey (\_ _ new -> new) olds news
1090 return $ DMap.unionWithKey (\_ _ new -> new) olds news
@@ -1649,23 +1557,6 @@ fmapCheap f = pushCheap $ return . Just . f
1649tagCheap :: Reflex t => Behavior t b -> Event t a -> Event t b
1557tagCheap :: Reflex t => Behavior t b -> Event t a -> Event t b
1650tagCheap b = pushAlwaysCheap $ \_ -> sample b
1558tagCheap b = pushAlwaysCheap $ \_ -> sample b
1651
1559
1652−-- | Merge a collection of events; the resulting 'Event' will only occur if at
1653−-- least one input event is occurring, and will contain all of the input keys
1654−-- that are occurring simultaneously
1655−merge :: (Reflex t, GCompare k) => DMap k (Event t) -> Event t (DMap k Identity)
1656−merge = mergeG coerceEvent
1657−{-# INLINE merge #-}
1658−
1659−-- | Create a merge whose parents can change over time
1660−mergeIncremental :: (Reflex t, GCompare k)
1661− => Incremental t (PatchDMap k (Event t)) -> Event t (DMap k Identity)
1662−mergeIncremental = mergeIncrementalG coerceEvent
1663−
1664−-- | Experimental: Create a merge whose parents can change over time; changing the key of an Event is more efficient than with mergeIncremental
1665−mergeIncrementalWithMove :: (Reflex t, GCompare k)
1666− => Incremental t (PatchDMapWithMove k (Event t)) -> Event t (DMap k Identity)
1667−mergeIncrementalWithMove = mergeIncrementalWithMoveG coerceEvent
1668−
1669-- | A "cheap" version of 'mergeWithCheap'. See the performance note on 'pushCheap'.
1560-- | A "cheap" version of 'mergeWithCheap'. See the performance note on 'pushCheap'.
1670{-# INLINE mergeWithCheap #-}
1561{-# INLINE mergeWithCheap #-}
1671mergeWithCheap :: Reflex t => (a -> a -> a) -> [Event t a] -> Event t a
1562mergeWithCheap :: Reflex t => (a -> a -> a) -> [Event t a] -> Event t a
src/Reflex/Collection.hs+1−8
@@ -27,13 +27,6 @@ module Reflex.Collection
27 , simpleList
27 , simpleList
28 ) where
28 ) where
29
29
30−#ifdef MIN_VERSION_semialign
31−import Prelude hiding (zip, zipWith)
32−#if MIN_VERSION_semialign(1,1,0)
33−import Data.Zip (Zip (..))
34−#endif
35−#endif
36−
37import Control.Monad.Identity
30import Control.Monad.Identity
38import Data.Align
31import Data.Align
39import Data.Functor.Misc
32import Data.Functor.Misc
@@ -130,7 +123,7 @@ listWithKeyShallowDiff initialVals valsChanged mkChild = do
130 Nothing -> Just Nothing
123 Nothing -> Just Nothing
131
124
132 -- We don't want to let spurious re-creations of items through
125 -- We don't want to let spurious re-creations of items through
133− Just _ -> Nothing
126+ Just _ -> Nothing
134 listHoldWithKey
127 listHoldWithKey
135 initialVals
128 initialVals
136 (attachWith (flip (Map.differenceWith relevantPatch))
129 (attachWith (flip (Map.differenceWith relevantPatch))
src/Reflex/Dynamic.hs+2−17
@@ -53,12 +53,10 @@ module Reflex.Dynamic
53 , foldDynMaybe
53 , foldDynMaybe
54 , foldDynMaybeM
54 , foldDynMaybeM
55 , joinDynThroughMap
55 , joinDynThroughMap
56− , joinDynThroughIntMap
57 , traceDyn
56 , traceDyn
58 , traceDynWith
57 , traceDynWith
59 , splitDynPure
58 , splitDynPure
60 , distributeMapOverDynPure
59 , distributeMapOverDynPure
61− , distributeIntMapOverDynPure
62 , distributeDMapOverDynPure
60 , distributeDMapOverDynPure
63 , distributeListOverDynPure
61 , distributeListOverDynPure
64 , Demux
62 , Demux
@@ -89,14 +87,11 @@ import Data.Align
89import Data.Dependent.Map (DMap)
87import Data.Dependent.Map (DMap)
90import qualified Data.Dependent.Map as DMap
88import qualified Data.Dependent.Map as DMap
91import Data.Dependent.Sum (DSum (..))
89import Data.Dependent.Sum (DSum (..))
92−import Data.GADT.Compare (GCompare (..), GEq (..), GOrdering (..))
90+import Data.GADT.Compare ((:~:) (..), GCompare (..), GEq (..), GOrdering (..))
93−import Data.IntMap (IntMap)
94−import qualified Data.IntMap as IntMap
95import Data.Map (Map)
91import Data.Map (Map)
96import Data.Maybe
92import Data.Maybe
97import Data.Monoid ((<>))
93import Data.Monoid ((<>))
98import Data.These
94import Data.These
99−import Data.Type.Equality ((:~:) (..))
100
95
101import Debug.Trace
96import Debug.Trace
102
97
@@ -206,11 +201,6 @@ splitDynPure d = (fmap fst d, fmap snd d)
206distributeMapOverDynPure :: (Reflex t, Ord k) => Map k (Dynamic t v) -> Dynamic t (Map k v)
201distributeMapOverDynPure :: (Reflex t, Ord k) => Map k (Dynamic t v) -> Dynamic t (Map k v)
207distributeMapOverDynPure = fmap dmapToMap . distributeDMapOverDynPure . mapWithFunctorToDMap
202distributeMapOverDynPure = fmap dmapToMap . distributeDMapOverDynPure . mapWithFunctorToDMap
208
203
209−-- | Convert an 'IntMap' with 'Dynamic' elements into a 'Dynamic' of an 'IntMap' with
210−-- non-'Dynamic' elements.
211−distributeIntMapOverDynPure :: (Reflex t) => IntMap (Dynamic t v) -> Dynamic t (IntMap v)
212−distributeIntMapOverDynPure = fmap dmapToIntMap . distributeDMapOverDynPure . intMapWithFunctorToDMap
213−
214-- | Convert a list with 'Dynamic' elements into a 'Dynamic' of a list with
204-- | Convert a list with 'Dynamic' elements into a 'Dynamic' of a list with
215-- non-'Dynamic' elements, preserving the order of the elements.
205-- non-'Dynamic' elements, preserving the order of the elements.
216{-# DEPRECATED distributeListOverDynPure "Use 'distributeListOverDyn' instead" #-}
206{-# DEPRECATED distributeListOverDynPure "Use 'distributeListOverDyn' instead" #-}
@@ -223,11 +213,6 @@ distributeListOverDynPure = distributeListOverDyn
223joinDynThroughMap :: forall t k a. (Reflex t, Ord k) => Dynamic t (Map k (Dynamic t a)) -> Dynamic t (Map k a)
213joinDynThroughMap :: forall t k a. (Reflex t, Ord k) => Dynamic t (Map k (Dynamic t a)) -> Dynamic t (Map k a)
224joinDynThroughMap = (distributeMapOverDynPure =<<)
214joinDynThroughMap = (distributeMapOverDynPure =<<)
225
215
226−-- | Combine a 'Dynamic' of an 'IntMap' of 'Dynamic's into a 'Dynamic'
227−-- with the current values of the 'Dynamic's in a map.
228−joinDynThroughIntMap :: forall t a. (Reflex t) => Dynamic t (IntMap (Dynamic t a)) -> Dynamic t (IntMap a)
229−joinDynThroughIntMap = (distributeIntMapOverDynPure =<<)
230−
231-- | Print the value of the 'Dynamic' when it is first read and on each
216-- | Print the value of the 'Dynamic' when it is first read and on each
232-- subsequent change that is observed (as 'traceEvent'), prefixed with the
217-- subsequent change that is observed (as 'traceEvent'), prefixed with the
233-- provided string. This should /only/ be used for debugging.
218-- provided string. This should /only/ be used for debugging.
@@ -348,7 +333,7 @@ factorDyn d = buildDynamic (sample (current d) >>= holdKey) update where
348--
333--
349-- > demuxed (demux d) k === fmap (== k) d
334-- > demuxed (demux d) k === fmap (== k) d
350--
335--
351−-- However, when 'demuxed' is used multiple times, the complexity is only
336+-- However, when getDemuxed is used multiple times, the complexity is only
352-- /O(log(n))/, rather than /O(n)/ for fmap.
337-- /O(log(n))/, rather than /O(n)/ for fmap.
353data Demux t k = Demux { demuxValue :: Behavior t k
338data Demux t k = Demux { demuxValue :: Behavior t k
354 , demuxSelector :: EventSelector t (Const2 k Bool)
339 , demuxSelector :: EventSelector t (Const2 k Bool)
src/Reflex/Dynamic/TH.hs+1−1
@@ -81,7 +81,7 @@ mkDynPure = QuasiQuoter
81 }
81 }
82
82
83mkDynExp :: String -> Q Exp
83mkDynExp :: String -> Q Exp
84−mkDynExp s = case Hs.parseExpWithMode Hs.defaultParseMode { Hs.extensions = [ Hs.EnableExtension Hs.TemplateHaskell ] } s of
84+mkDynExp s = case Hs.parseExpWithMode (Hs.defaultParseMode { Hs.extensions = [ Hs.EnableExtension Hs.TemplateHaskell ] }) s of
85 Hs.ParseFailed (Hs.SrcLoc _ l c) err -> fail $ "mkDyn:" <> show l <> ":" <> show c <> ": " <> err
85 Hs.ParseFailed (Hs.SrcLoc _ l c) err -> fail $ "mkDyn:" <> show l <> ":" <> show c <> ": " <> err
86 Hs.ParseOk e -> qDynPure $ return $ everywhere (id `extT` reinstateUnqDyn) $ Hs.toExp $ everywhere (id `extT` antiE) e
86 Hs.ParseOk e -> qDynPure $ return $ everywhere (id `extT` reinstateUnqDyn) $ Hs.toExp $ everywhere (id `extT` antiE) e
87 where TH.Name (TH.OccName occName) (TH.NameG _ _ (TH.ModName modName)) = 'unqMarker
87 where TH.Name (TH.OccName occName) (TH.NameG _ _ (TH.ModName modName)) = 'unqMarker
src/Reflex/DynamicWriter/Base.hs+5−14
@@ -22,7 +22,6 @@ module Reflex.DynamicWriter.Base
22import Control.Monad.Exception
22import Control.Monad.Exception
23import Control.Monad.Identity
23import Control.Monad.Identity
24import Control.Monad.IO.Class
24import Control.Monad.IO.Class
25−import Control.Monad.Morph
26import Control.Monad.Primitive
25import Control.Monad.Primitive
27import Control.Monad.Reader
26import Control.Monad.Reader
28import Control.Monad.Ref
27import Control.Monad.Ref
@@ -45,13 +44,16 @@ import Reflex.Class
45import Reflex.DynamicWriter.Class
44import Reflex.DynamicWriter.Class
46import Reflex.EventWriter.Class (EventWriter, tellEvent)
45import Reflex.EventWriter.Class (EventWriter, tellEvent)
47import Reflex.Host.Class
46import Reflex.Host.Class
48−import qualified Data.Patch.MapWithMove as MapWithMove
47+import qualified Reflex.Patch.MapWithMove as MapWithMove
49import Reflex.PerformEvent.Class
48import Reflex.PerformEvent.Class
50import Reflex.PostBuild.Class
49import Reflex.PostBuild.Class
51import Reflex.Query.Class
50import Reflex.Query.Class
52import Reflex.Requester.Class
51import Reflex.Requester.Class
53import Reflex.TriggerEvent.Class
52import Reflex.TriggerEvent.Class
54
53
54+instance MonadTrans (DynamicWriterT t w) where
55+ lift = DynamicWriterT . lift
56+
55mapIncrementalMapValues :: (Reflex t, Patch (p v), Patch (p v'), PatchTarget (p v) ~ f v, PatchTarget (p v') ~ f v', Functor p, Functor f) => (v -> v') -> Incremental t (p v) -> Incremental t (p v')
57mapIncrementalMapValues :: (Reflex t, Patch (p v), Patch (p v'), PatchTarget (p v) ~ f v, PatchTarget (p v') ~ f v', Functor p, Functor f) => (v -> v') -> Incremental t (p v) -> Incremental t (p v')
56mapIncrementalMapValues f = unsafeMapIncremental (fmap f) (fmap f)
58mapIncrementalMapValues f = unsafeMapIncremental (fmap f) (fmap f)
57
59
@@ -88,18 +90,7 @@ mergeDynIncrementalWithMove a = unsafeBuildIncremental (mapM (sample . current)
88
90
89-- | A basic implementation of 'DynamicWriter'.
91-- | A basic implementation of 'DynamicWriter'.
90newtype DynamicWriterT t w m a = DynamicWriterT { unDynamicWriterT :: StateT [Dynamic t w] m a }
92newtype DynamicWriterT t w m a = DynamicWriterT { unDynamicWriterT :: StateT [Dynamic t w] m a }
91− -- The list is kept in reverse order
93+ deriving (Functor, Applicative, Monad, MonadIO, MonadFix, MonadAsyncException, MonadException) -- The list is kept in reverse order
92− deriving
93− ( Functor
94− , Applicative
95− , Monad
96− , MonadTrans
97− , MFunctor
98− , MonadIO
99− , MonadFix
100− , MonadAsyncException
101− , MonadException
102− )
103
94
104deriving instance MonadHold t m => MonadHold t (DynamicWriterT t w m)
95deriving instance MonadHold t m => MonadHold t (DynamicWriterT t w m)
105deriving instance MonadSample t m => MonadSample t (DynamicWriterT t w m)
96deriving instance MonadSample t m => MonadSample t (DynamicWriterT t w m)
src/Reflex/DynamicWriter/Class.hs+2
@@ -3,6 +3,7 @@
3{-# LANGUAGE CPP #-}
3{-# LANGUAGE CPP #-}
4{-# LANGUAGE FlexibleInstances #-}
4{-# LANGUAGE FlexibleInstances #-}
5{-# LANGUAGE FunctionalDependencies #-}
5{-# LANGUAGE FunctionalDependencies #-}
6+{-# LANGUAGE MultiParamTypeClasses #-}
6{-# LANGUAGE UndecidableInstances #-}
7{-# LANGUAGE UndecidableInstances #-}
7#ifdef USE_REFLEX_OPTIMIZER
8#ifdef USE_REFLEX_OPTIMIZER
8{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
9{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
@@ -26,3 +27,4 @@ class (Monad m, Monoid w) => DynamicWriter t w m | m -> t w where
26
27
27instance DynamicWriter t w m => DynamicWriter t w (ReaderT r m) where
28instance DynamicWriter t w m => DynamicWriter t w (ReaderT r m) where
28 tellDyn = lift . tellDyn
29 tellDyn = lift . tellDyn
30+
src/Reflex/EventWriter/Base.hs+6−17
@@ -35,14 +35,12 @@ import Reflex.TriggerEvent.Class
35
35
36import Control.Monad.Exception
36import Control.Monad.Exception
37import Control.Monad.Identity
37import Control.Monad.Identity
38−import Control.Monad.Morph
39import Control.Monad.Primitive
38import Control.Monad.Primitive
40import Control.Monad.Reader
39import Control.Monad.Reader
41import Control.Monad.Ref
40import Control.Monad.Ref
42import Control.Monad.State.Strict
41import Control.Monad.State.Strict
43−import Data.Dependent.Map (DMap)
42+import Data.Dependent.Map (DMap, DSum (..))
44import qualified Data.Dependent.Map as DMap
43import qualified Data.Dependent.Map as DMap
45−import Data.Dependent.Sum (DSum (..))
46import Data.Functor.Compose
44import Data.Functor.Compose
47import Data.Functor.Misc
45import Data.Functor.Misc
48import Data.GADT.Compare (GCompare (..), GEq (..), GOrdering (..))
46import Data.GADT.Compare (GCompare (..), GEq (..), GOrdering (..))
@@ -54,7 +52,7 @@ import qualified Data.Map as Map
54import Data.Semigroup
52import Data.Semigroup
55import Data.Some (Some)
53import Data.Some (Some)
56import Data.Tuple
54import Data.Tuple
57−import Data.Type.Equality
55+import Data.Type.Equality hiding (apply)
58
56
59import Unsafe.Coerce
57import Unsafe.Coerce
60
58
@@ -98,17 +96,7 @@ data EventWriterState t w = EventWriterState
98
96
99-- | A basic implementation of 'EventWriter'.
97-- | A basic implementation of 'EventWriter'.
100newtype EventWriterT t w m a = EventWriterT { unEventWriterT :: StateT (EventWriterState t w) m a }
98newtype EventWriterT t w m a = EventWriterT { unEventWriterT :: StateT (EventWriterState t w) m a }
101− deriving
99+ deriving (Functor, Applicative, Monad, MonadFix, MonadIO, MonadException, MonadAsyncException)
102− ( Functor
103− , Applicative
104− , Monad
105− , MonadTrans
106− , MFunctor
107− , MonadFix
108− , MonadIO
109− , MonadException
110− , MonadAsyncException
111− )
112
100
113-- | Run a 'EventWriterT' action.
101-- | Run a 'EventWriterT' action.
114runEventWriterT :: forall t m w a. (Reflex t, Monad m, Semigroup w) => EventWriterT t w m a -> m (a, Event t w)
102runEventWriterT :: forall t m w a. (Reflex t, Monad m, Semigroup w) => EventWriterT t w m a -> m (a, Event t w)
@@ -128,6 +116,9 @@ instance (Reflex t, Monad m, Semigroup w) => EventWriter t w (EventWriterT t w m
128 , _eventWriterState_told = (tellId myId :=> w) : _eventWriterState_told old
116 , _eventWriterState_told = (tellId myId :=> w) : _eventWriterState_told old
129 }
117 }
130
118
119+instance MonadTrans (EventWriterT t w) where
120+ lift = EventWriterT . lift
121+
131instance MonadSample t m => MonadSample t (EventWriterT t w m) where
122instance MonadSample t m => MonadSample t (EventWriterT t w m) where
132 sample = lift . sample
123 sample = lift . sample
133
124
@@ -142,8 +133,6 @@ instance MonadHold t m => MonadHold t (EventWriterT t w m) where
142 buildDynamic a0 = lift . buildDynamic a0
133 buildDynamic a0 = lift . buildDynamic a0
143 {-# INLINABLE headE #-}
134 {-# INLINABLE headE #-}
144 headE = lift . headE
135 headE = lift . headE
145− {-# INLINABLE now #-}
146− now = lift now
147
136
148instance (Reflex t, Adjustable t m, MonadHold t m, Semigroup w) => Adjustable t (EventWriterT t w m) where
137instance (Reflex t, Adjustable t m, MonadHold t m, Semigroup w) => Adjustable t (EventWriterT t w m) where
149 runWithReplace = runWithReplaceEventWriterTWith $ \dm0 dm' -> lift $ runWithReplace dm0 dm'
138 runWithReplace = runWithReplaceEventWriterTWith $ \dm0 dm' -> lift $ runWithReplace dm0 dm'
src/Reflex/EventWriter/Class.hs+1
@@ -2,6 +2,7 @@
2{-# LANGUAGE CPP #-}
2{-# LANGUAGE CPP #-}
3{-# LANGUAGE FlexibleInstances #-}
3{-# LANGUAGE FlexibleInstances #-}
4{-# LANGUAGE FunctionalDependencies #-}
4{-# LANGUAGE FunctionalDependencies #-}
5+{-# LANGUAGE MultiParamTypeClasses #-}
5{-# LANGUAGE UndecidableInstances #-}
6{-# LANGUAGE UndecidableInstances #-}
6#ifdef USE_REFLEX_OPTIMIZER
7#ifdef USE_REFLEX_OPTIMIZER
7{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
8{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
src/Reflex/FastWeak.hs−10
@@ -151,16 +151,6 @@ getFastWeakTicket w = do
151
151
152-- | Create a 'FastWeakTicket' directly from a value, creating a 'FastWeak' in the process
152-- | Create a 'FastWeakTicket' directly from a value, creating a 'FastWeak' in the process
153-- which can be obtained with 'getFastWeakTicketValue'.
153-- which can be obtained with 'getFastWeakTicketValue'.
154−--
155−-- This function is marked NOINLINE so it is opaque to GHC.
156−-- If we do not do this, then GHC will sometimes fuse the constructor away
157−-- so any weak references that are attached to the ticket will have their
158−-- finalizer run. Using the opaque constructor, GHC does not see the
159−-- constructor application, so it behaves like an IORef and cannot be fused away.
160−--
161−-- The result is also evaluated to WHNF, since forcing a thunk invalidates
162−-- the weak pointer to it in some cases.
163−{-# NOINLINE mkFastWeakTicket #-}
164mkFastWeakTicket :: a -> IO (FastWeakTicket a)
154mkFastWeakTicket :: a -> IO (FastWeakTicket a)
165-- I think it's fine if this is lazy - it'll retain the 'a', but so would the output; we just need to make sure it's forced before we start relying on the
155-- I think it's fine if this is lazy - it'll retain the 'a', but so would the output; we just need to make sure it's forced before we start relying on the
166-- associated FastWeak to actually be weak
156-- associated FastWeak to actually be weak
src/Reflex/Host/Class.hs+1
@@ -4,6 +4,7 @@
4{-# LANGUAGE FlexibleInstances #-}
4{-# LANGUAGE FlexibleInstances #-}
5{-# LANGUAGE FunctionalDependencies #-}
5{-# LANGUAGE FunctionalDependencies #-}
6{-# LANGUAGE GADTs #-}
6{-# LANGUAGE GADTs #-}
7+{-# LANGUAGE MultiParamTypeClasses #-}
7{-# LANGUAGE RankNTypes #-}
8{-# LANGUAGE RankNTypes #-}
8{-# LANGUAGE RoleAnnotations #-}
9{-# LANGUAGE RoleAnnotations #-}
9{-# LANGUAGE ScopedTypeVariables #-}
10{-# LANGUAGE ScopedTypeVariables #-}
src/Reflex/Host/Headless.hsdeleted−128
@@ -1,128 +0,0 @@
1−{-# LANGUAGE LambdaCase #-}
2−{-# LANGUAGE FlexibleContexts #-}
3−{-# LANGUAGE RankNTypes #-}
4−{-# LANGUAGE TypeFamilies #-}
5−{-# LANGUAGE ConstraintKinds #-}
6−
7−module Reflex.Host.Headless where
8−
9−import Control.Concurrent.Chan (newChan, readChan)
10−import Control.Monad (unless)
11−import Control.Monad.Fix (MonadFix, fix)
12−import Control.Monad.IO.Class (MonadIO, liftIO)
13−import Control.Monad.Primitive (PrimMonad)
14−import Control.Monad.Ref (MonadRef, Ref, readRef)
15−import Data.Dependent.Sum (DSum (..), (==>))
16−import Data.Foldable (for_)
17−import Data.Functor.Identity (Identity(..))
18−import Data.IORef (IORef, readIORef)
19−import Data.Maybe (catMaybes, fromMaybe)
20−import Data.Traversable (for)
21−
22−import Reflex
23−import Reflex.Host.Class
24−
25−type MonadHeadlessApp t m =
26− ( Adjustable t m
27− , MonadFix m
28− , MonadHold t m
29− , MonadIO (HostFrame t)
30− , MonadIO (Performable m)
31− , MonadIO m
32− , MonadRef (HostFrame t)
33− , NotReady t m
34− , PerformEvent t m
35− , PostBuild t m
36− , PrimMonad (HostFrame t)
37− , Ref (HostFrame t) ~ IORef
38− , Ref m ~ IORef
39− , Reflex t
40− , ReflexHost t
41− , TriggerEvent t m
42− )
43−
44−-- | Run a headless FRP network. Inside the action, you will most probably use
45−-- the capabilities provided by the 'TriggerEvent' and 'PerformEvent' type
46−-- classes to interface the FRP network with the outside world. Useful for
47−-- testing. Each headless network runs on its own spider timeline.
48−runHeadlessApp
49− :: (forall t m. MonadHeadlessApp t m => m (Event t ()))
50− -- ^ The action to be run in the headless FRP network. The FRP network is
51− -- closed at the first occurrence of the resulting 'Event'.
52− -> IO ()
53−runHeadlessApp guest =
54− -- We are using the 'Spider' implementation of reflex. Running the host
55− -- allows us to take actions on the FRP timeline.
56− withSpiderTimeline $ runSpiderHostForTimeline $ do
57− -- Create the "post-build" event and associated trigger. This event fires
58− -- once, when the application starts.
59− (postBuild, postBuildTriggerRef) <- newEventWithTriggerRef
60− -- Create a queue to which we will write 'Event's that need to be
61− -- processed.
62− events <- liftIO newChan
63− -- Run the "guest" application, providing the appropriate context. We'll
64− -- pure the result of the action, and a 'FireCommand' that will be used to
65− -- trigger events.
66− (result, fc@(FireCommand fire)) <- do
67− hostPerformEventT $ -- Allows the guest app to run
68− -- 'performEvent', so that actions
69− -- (e.g., IO actions) can be run when
70− -- 'Event's fire.
71−
72− flip runPostBuildT postBuild $ -- Allows the guest app to access to
73− -- a "post-build" 'Event'
74−
75− flip runTriggerEventT events $ -- Allows the guest app to create new
76− -- events and triggers and write
77− -- those triggers to a channel from
78− -- which they will be read and
79− -- processed.
80− guest
81−
82− -- Read the trigger reference for the post-build event. This will be
83− -- 'Nothing' if the guest application hasn't subscribed to this event.
84− mPostBuildTrigger <- readRef postBuildTriggerRef
85−
86− -- Subscribe to an 'Event' of that the guest application can use to
87− -- request application shutdown. We'll check whether this 'Event' is firing
88− -- to determine whether to terminate.
89− shutdown <- subscribeEvent result
90−
91− -- When there is a subscriber to the post-build event, fire the event.
92− soa <- for mPostBuildTrigger $ \postBuildTrigger ->
93− fire [postBuildTrigger :=> Identity ()] $ isFiring shutdown
94−
95− -- The main application loop. We wait for new events and fire those that
96− -- have subscribers. If we detect a shutdown request, the application
97− -- terminates.
98− unless (or (fromMaybe [] soa)) $ fix $ \loop -> do
99− -- Read the next event (blocking).
100− ers <- liftIO $ readChan events
101− stop <- do
102− -- Fire events that have subscribers.
103− fireEventTriggerRefs fc ers $
104− -- Check if the shutdown 'Event' is firing.
105− isFiring shutdown
106− if or stop
107− then pure ()
108− else loop
109− where
110− isFiring ev = readEvent ev >>= \case
111− Nothing -> pure False
112− Just _ -> pure True
113− -- Use the given 'FireCommand' to fire events that have subscribers
114− -- and call the callback for the 'TriggerInvocation' of each.
115− fireEventTriggerRefs
116− :: MonadIO m
117− => FireCommand t m
118− -> [DSum (EventTriggerRef t) TriggerInvocation]
119− -> ReadPhase m a
120− -> m [a]
121− fireEventTriggerRefs (FireCommand fire) ers rcb = do
122− mes <- liftIO $
123− for ers $ \(EventTriggerRef er :=> TriggerInvocation a _) -> do
124− me <- readIORef er
125− pure $ fmap (==> a) me
126− a <- fire (catMaybes mes) rcb
127− liftIO $ for_ ers $ \(_ :=> TriggerInvocation _ cb) -> cb
128− pure a
src/Reflex/Network.hs+1−1
@@ -20,7 +20,7 @@ import Reflex.NotReady.Class
20import Reflex.PostBuild.Class
20import Reflex.PostBuild.Class
21
21
22-- | A 'Dynamic' "network": Takes a 'Dynamic' of network-creating actions and replaces the network whenever the 'Dynamic' updates.
22-- | A 'Dynamic' "network": Takes a 'Dynamic' of network-creating actions and replaces the network whenever the 'Dynamic' updates.
23−-- The returned Event of network results fires at post-build time and when the 'Dynamic' updates.
23+-- The returned Event of network results fires when the 'Dynamic' updates.
24-- Note: Often, the type 'a' is an Event, in which case the return value is an Event-of-Events, where the outer 'Event' fires
24-- Note: Often, the type 'a' is an Event, in which case the return value is an Event-of-Events, where the outer 'Event' fires
25-- when switching networks. Such an 'Event' would typically be flattened (via 'switchPromptly').
25-- when switching networks. Such an 'Event' would typically be flattened (via 'switchPromptly').
26networkView :: (NotReady t m, Adjustable t m, PostBuild t m) => Dynamic t (m a) -> m (Event t a)
26networkView :: (NotReady t m, Adjustable t m, PostBuild t m) => Dynamic t (m a) -> m (Event t a)
src/Reflex/NotReady/Class.hs+1
@@ -3,6 +3,7 @@
3{-# LANGUAGE FlexibleContexts #-}
3{-# LANGUAGE FlexibleContexts #-}
4{-# LANGUAGE FlexibleInstances #-}
4{-# LANGUAGE FlexibleInstances #-}
5{-# LANGUAGE FunctionalDependencies #-}
5{-# LANGUAGE FunctionalDependencies #-}
6+{-# LANGUAGE MultiParamTypeClasses #-}
6{-# LANGUAGE TypeFamilies #-}
7{-# LANGUAGE TypeFamilies #-}
7{-# LANGUAGE UndecidableInstances #-}
8{-# LANGUAGE UndecidableInstances #-}
8#ifdef USE_REFLEX_OPTIMIZER
9#ifdef USE_REFLEX_OPTIMIZER
src/Reflex/Patch.hsnew file+46
@@ -0,0 +1,46 @@
1+{-# LANGUAGE TypeFamilies #-}
2+-- |
3+-- Module:
4+-- Reflex.Patch
5+-- Description:
6+-- This module defines the 'Patch' class, which is used by Reflex to manage
7+-- changes to 'Reflex.Class.Incremental' values.
8+module Reflex.Patch
9+ ( module Reflex.Patch
10+ , module X
11+ ) where
12+
13+import Reflex.Patch.Class as X
14+import Reflex.Patch.DMap as X hiding (getDeletions)
15+import Reflex.Patch.DMapWithMove as X (PatchDMapWithMove, const2PatchDMapWithMoveWith, mapPatchDMapWithMove,
16+ patchDMapWithMoveToPatchMapWithMoveWith,
17+ traversePatchDMapWithMoveWithKey, unPatchDMapWithMove,
18+ unsafePatchDMapWithMove, weakenPatchDMapWithMoveWith)
19+import Reflex.Patch.IntMap as X hiding (getDeletions)
20+import Reflex.Patch.Map as X
21+import Reflex.Patch.MapWithMove as X (PatchMapWithMove, patchMapWithMoveNewElements,
22+ patchMapWithMoveNewElementsMap, unPatchMapWithMove,
23+ unsafePatchMapWithMove)
24+import Data.Map.Monoidal (MonoidalMap)
25+import Data.Semigroup (Semigroup (..), (<>))
26+
27+-- | A 'Group' is a 'Monoid' where every element has an inverse.
28+class (Semigroup q, Monoid q) => Group q where
29+ negateG :: q -> q
30+ (~~) :: q -> q -> q
31+ r ~~ s = r <> negateG s
32+
33+-- | An 'Additive' 'Semigroup' is one where (<>) is commutative
34+class Semigroup q => Additive q where
35+
36+-- | The elements of an 'Additive' 'Semigroup' can be considered as patches of their own type.
37+newtype AdditivePatch p = AdditivePatch { unAdditivePatch :: p }
38+
39+instance Additive p => Patch (AdditivePatch p) where
40+ type PatchTarget (AdditivePatch p) = p
41+ apply (AdditivePatch p) q = Just $ p <> q
42+
43+instance (Ord k, Group q) => Group (MonoidalMap k q) where
44+ negateG = fmap negateG
45+
46+instance (Ord k, Additive q) => Additive (MonoidalMap k q)
src/Reflex/Patch/Class.hsnew file+34
@@ -0,0 +1,34 @@
1+{-# LANGUAGE TypeFamilies #-}
2+-- | The interface for types which represent changes made to other types
3+module Reflex.Patch.Class where
4+
5+import Control.Monad.Identity
6+import Data.Maybe
7+import Data.Semigroup (Semigroup(..))
8+
9+-- | A 'Patch' type represents a kind of change made to a datastructure.
10+--
11+-- If an instance of 'Patch' is also an instance of 'Semigroup', it should obey
12+-- the law that @applyAlways (f <> g) == applyAlways f . applyAlways g@.
13+class Patch p where
14+ type PatchTarget p :: *
15+ -- | Apply the patch @p a@ to the value @a@. If no change is needed, return
16+ -- 'Nothing'.
17+ apply :: p -> PatchTarget p -> Maybe (PatchTarget p)
18+
19+-- | Apply a 'Patch'; if it does nothing, return the original value
20+applyAlways :: Patch p => p -> PatchTarget p -> PatchTarget p
21+applyAlways p t = fromMaybe t $ apply p t
22+
23+-- | 'Identity' can be used as a 'Patch' that always fully replaces the value
24+instance Patch (Identity a) where
25+ type PatchTarget (Identity a) = a
26+ apply (Identity a) _ = Just a
27+
28+-- | Like '(.)', but composes functions that return patches rather than
29+-- functions that return new values. The Semigroup instance for patches must
30+-- apply patches right-to-left, like '(.)'.
31+composePatchFunctions :: (Patch p, Semigroup p) => (PatchTarget p -> p) -> (PatchTarget p -> p) -> PatchTarget p -> p
32+composePatchFunctions g f a =
33+ let fp = f a
34+ in g (applyAlways fp a) <> fp
src/Reflex/Patch/DMap.hsnew file+82
@@ -0,0 +1,82 @@
1+{-# LANGUAGE GeneralizedNewtypeDeriving #-}
2+{-# LANGUAGE LambdaCase #-}
3+{-# LANGUAGE PolyKinds #-}
4+{-# LANGUAGE Rank2Types #-}
5+{-# LANGUAGE ScopedTypeVariables #-}
6+{-# LANGUAGE StandaloneDeriving #-}
7+{-# LANGUAGE TypeFamilies #-}
8+-- | 'Patch'es on 'DMap' that consist only of insertions (or overwrites) and deletions.
9+module Reflex.Patch.DMap where
10+
11+import Reflex.Patch.Class
12+import Reflex.Patch.IntMap
13+import Reflex.Patch.Map
14+
15+import Data.Dependent.Map (DMap, DSum (..), GCompare (..))
16+import qualified Data.Dependent.Map as DMap
17+import Data.Functor.Constant
18+import Data.Functor.Misc
19+import qualified Data.IntMap as IntMap
20+import qualified Data.Map as Map
21+import Data.Semigroup (Semigroup (..))
22+import Data.Some (Some)
23+
24+-- | A set of changes to a 'DMap'. Any element may be inserted/updated or deleted.
25+-- Insertions are represented as @'ComposeMaybe' (Just value)@,
26+-- while deletions are represented as @'ComposeMaybe' Nothing@.
27+newtype PatchDMap k v = PatchDMap { unPatchDMap :: DMap k (ComposeMaybe v) }
28+
29+deriving instance GCompare k => Semigroup (PatchDMap k v)
30+
31+deriving instance GCompare k => Monoid (PatchDMap k v)
32+
33+-- | Apply the insertions or deletions to a given 'DMap'.
34+instance GCompare k => Patch (PatchDMap k v) where
35+ type PatchTarget (PatchDMap k v) = DMap k v
36+ apply (PatchDMap diff) old = Just $! insertions `DMap.union` (old `DMap.difference` deletions) --TODO: return Nothing sometimes --Note: the strict application here is critical to ensuring that incremental merges don't hold onto all their prerequisite events forever; can we make this more robust?
37+ where insertions = DMap.mapMaybeWithKey (const $ getComposeMaybe) diff
38+ deletions = DMap.mapMaybeWithKey (const $ nothingToJust . getComposeMaybe) diff
39+ nothingToJust = \case
40+ Nothing -> Just $ Constant ()
41+ Just _ -> Nothing
42+
43+-- | Map a function @v a -> v' a@ over any inserts/updates in the given
44+-- @'PatchDMap' k v@ to produce a @'PatchDMap' k v'@.
45+mapPatchDMap :: (forall a. v a -> v' a) -> PatchDMap k v -> PatchDMap k v'
46+mapPatchDMap f (PatchDMap p) = PatchDMap $ DMap.map (ComposeMaybe . fmap f . getComposeMaybe) p
47+
48+-- | Map an effectful function @v a -> f (v' a)@ over any inserts/updates in the given
49+-- @'PatchDMap' k v@ to produce a @'PatchDMap' k v'@.
50+traversePatchDMap :: Applicative f => (forall a. v a -> f (v' a)) -> PatchDMap k v -> f (PatchDMap k v')
51+traversePatchDMap f = traversePatchDMapWithKey $ const f
52+
53+-- | Map an effectful function @k a -> v a -> f (v' a)@ over any inserts/updates
54+-- in the given @'PatchDMap' k v@ to produce a @'PatchDMap' k v'@.
55+traversePatchDMapWithKey :: Applicative m => (forall a. k a -> v a -> m (v' a)) -> PatchDMap k v -> m (PatchDMap k v')
56+traversePatchDMapWithKey f (PatchDMap p) = PatchDMap <$> DMap.traverseWithKey (\k (ComposeMaybe v) -> ComposeMaybe <$> traverse (f k) v) p
57+
58+-- | Weaken a @'PatchDMap' k v@ to a @'PatchMap' (Some k) v'@ using a function
59+-- @v a -> v'@ to weaken each value contained in the patch.
60+weakenPatchDMapWith :: (forall a. v a -> v') -> PatchDMap k v -> PatchMap (Some k) v'
61+weakenPatchDMapWith f (PatchDMap p) = PatchMap $ weakenDMapWith (fmap f . getComposeMaybe) p
62+
63+-- | Convert a weak @'PatchDMap' ('Const2' k a) v@ where the @a@ is known by way of
64+-- the @Const2@ into a @'PatchMap' k v'@ using a rank 1 function @v a -> v'@.
65+patchDMapToPatchMapWith :: (v a -> v') -> PatchDMap (Const2 k a) v -> PatchMap k v'
66+patchDMapToPatchMapWith f (PatchDMap p) = PatchMap $ dmapToMapWith (fmap f . getComposeMaybe) p
67+
68+-- | Convert a @'PatchMap' k v@ into a @'PatchDMap' ('Const2' k a) v'@ using a function @v -> v' a@.
69+const2PatchDMapWith :: forall k v v' a. (v -> v' a) -> PatchMap k v -> PatchDMap (Const2 k a) v'
70+const2PatchDMapWith f (PatchMap p) = PatchDMap $ DMap.fromDistinctAscList $ g <$> Map.toAscList p
71+ where g :: (k, Maybe v) -> DSum (Const2 k a) (ComposeMaybe v')
72+ g (k, e) = Const2 k :=> ComposeMaybe (f <$> e)
73+
74+-- | Convert a @'PatchIntMap' v@ into a @'PatchDMap' ('Const2' Int a) v'@ using a function @v -> v' a@.
75+const2IntPatchDMapWith :: forall v f a. (v -> f a) -> PatchIntMap v -> PatchDMap (Const2 IntMap.Key a) f
76+const2IntPatchDMapWith f (PatchIntMap p) = PatchDMap $ DMap.fromDistinctAscList $ g <$> IntMap.toAscList p
77+ where g :: (IntMap.Key, Maybe v) -> DSum (Const2 IntMap.Key a) (ComposeMaybe f)
78+ g (k, e) = Const2 k :=> ComposeMaybe (f <$> e)
79+
80+-- | Get the values that will be replaced or deleted if the given patch is applied to the given 'DMap'.
81+getDeletions :: GCompare k => PatchDMap k v -> DMap k v' -> DMap k v'
82+getDeletions (PatchDMap p) m = DMap.intersectionWithKey (\_ v _ -> v) m p
src/Reflex/Patch/DMapWithMove.hsnew file+363
@@ -0,0 +1,363 @@
1+{-# LANGUAGE CPP #-}
2+{-# LANGUAGE FlexibleContexts #-}
3+{-# LANGUAGE FlexibleInstances #-}
4+{-# LANGUAGE GADTs #-}
5+{-# LANGUAGE LambdaCase #-}
6+{-# LANGUAGE MultiParamTypeClasses #-}
7+{-# LANGUAGE PatternGuards #-}
8+{-# LANGUAGE PolyKinds #-}
9+{-# LANGUAGE Rank2Types #-}
10+{-# LANGUAGE ScopedTypeVariables #-}
11+{-# LANGUAGE TypeFamilies #-}
12+{-# LANGUAGE UndecidableInstances #-}
13+
14+-- |Module containing @'PatchDMapWithMove' k v@ and associated functions, which represents a 'Patch' to a @'DMap' k v@ which can insert, update, delete, and
15+-- move values between keys.
16+module Reflex.Patch.DMapWithMove where
17+
18+import Reflex.Patch.Class
19+import Reflex.Patch.MapWithMove (PatchMapWithMove (..))
20+import qualified Reflex.Patch.MapWithMove as MapWithMove
21+
22+import Data.Constraint.Extras
23+import Data.Dependent.Map (DMap, DSum (..), GCompare (..))
24+import qualified Data.Dependent.Map as DMap
25+import Data.Functor.Constant
26+import Data.Functor.Misc
27+import Data.Functor.Product
28+import Data.GADT.Compare (GEq (..))
29+import Data.GADT.Show (GShow, gshow)
30+import qualified Data.Map as Map
31+import Data.Maybe
32+import Data.Semigroup (Semigroup (..), (<>))
33+import Data.Some (Some(Some))
34+import Data.These
35+
36+-- | Like 'PatchMapWithMove', but for 'DMap'. Each key carries a 'NodeInfo' which describes how it will be changed by the patch and connects move sources and
37+-- destinations.
38+--
39+-- Invariants:
40+--
41+-- * A key should not move to itself.
42+-- * A move should always be represented with both the destination key (as a 'From_Move') and the source key (as a @'ComposeMaybe' ('Just' destination)@)
43+newtype PatchDMapWithMove k v = PatchDMapWithMove (DMap k (NodeInfo k v))
44+
45+-- |Structure which represents what changes apply to a particular key. @_nodeInfo_from@ specifies what happens to this key, and in particular what other key
46+-- the current key is moving from, while @_nodeInfo_to@ specifies what key the current key is moving to if involved in a move.
47+data NodeInfo k v a = NodeInfo
48+ { _nodeInfo_from :: !(From k v a)
49+ -- ^Change applying to the current key, be it an insert, move, or delete.
50+ , _nodeInfo_to :: !(To k a)
51+ -- ^Where this key is moving to, if involved in a move. Should only be @ComposeMaybe (Just k)@ when there is a corresponding 'From_Move'.
52+ }
53+ deriving (Show)
54+
55+-- |Structure describing a particular change to a key, be it inserting a new key (@From_Insert@), updating an existing key (@From_Insert@ again), deleting a
56+-- key (@From_Delete@), or moving a key (@From_Move@).
57+data From (k :: a -> *) (v :: a -> *) :: a -> * where
58+ -- |Insert a new or update an existing key with the given value @v a@
59+ From_Insert :: v a -> From k v a
60+ -- |Delete the existing key
61+ From_Delete :: From k v a
62+ -- |Move the value from the given key @k a@ to this key. The source key should also have an entry in the patch giving the current key as @_nodeInfo_to@,
63+ -- usually but not necessarily with @From_Delete@.
64+ From_Move :: !(k a) -> From k v a
65+ deriving (Show, Read, Eq, Ord)
66+
67+-- |Type alias for the "to" part of a 'NodeInfo'. @'ComposeMaybe' ('Just' k)@ means the key is moving to another key, @ComposeMaybe Nothing@ for any other
68+-- operation.
69+type To = ComposeMaybe
70+
71+-- |Test whether a 'PatchDMapWithMove' satisfies its invariants.
72+validPatchDMapWithMove :: forall k v. (GCompare k, GShow k) => DMap k (NodeInfo k v) -> Bool
73+validPatchDMapWithMove = not . null . validationErrorsForPatchDMapWithMove
74+
75+-- |Enumerate what reasons a 'PatchDMapWithMove' doesn't satisfy its invariants, returning @[]@ if it's valid.
76+validationErrorsForPatchDMapWithMove :: forall k v. (GCompare k, GShow k) => DMap k (NodeInfo k v) -> [String]
77+validationErrorsForPatchDMapWithMove m =
78+ noSelfMoves <> movesBalanced
79+ where
80+ noSelfMoves = mapMaybe selfMove . DMap.toAscList $ m
81+ selfMove (dst :=> NodeInfo (From_Move src) _) | Just _ <- dst `geq` src = Just $ "self move of key " <> gshow src <> " at destination side"
82+ selfMove (src :=> NodeInfo _ (ComposeMaybe (Just dst))) | Just _ <- src `geq` dst = Just $ "self move of key " <> gshow dst <> " at source side"
83+ selfMove _ = Nothing
84+ movesBalanced = mapMaybe unbalancedMove . DMap.toAscList $ m
85+ unbalancedMove (dst :=> NodeInfo (From_Move src) _) =
86+ case DMap.lookup src m of
87+ Nothing -> Just $ "unbalanced move at destination key " <> gshow dst <> " supposedly from " <> gshow src <> " but source key is not in the patch"
88+ Just (NodeInfo _ (ComposeMaybe (Just dst'))) ->
89+ if isNothing (dst' `geq` dst)
90+ then Just $ "unbalanced move at destination key " <> gshow dst <> " from " <> gshow src <> " is going to " <> gshow dst' <> " instead"
91+ else Nothing
92+ _ ->
93+ Just $ "unbalanced move at destination key " <> gshow dst <> " supposedly from " <> gshow src <> " but source key has no move to key"
94+ unbalancedMove (src :=> NodeInfo _ (ComposeMaybe (Just dst))) =
95+ case DMap.lookup dst m of
96+ Nothing -> Just $ " unbalanced move at source key " <> gshow src <> " supposedly going to " <> gshow dst <> " but destination key is not in the patch"
97+ Just (NodeInfo (From_Move src') _) ->
98+ if isNothing (src' `geq` src)
99+ then Just $ "unbalanced move at source key " <> gshow src <> " to " <> gshow dst <> " is coming from " <> gshow src' <> " instead"
100+ else Nothing
101+
102+ _ ->
103+ Just $ "unbalanced move at source key " <> gshow src <> " supposedly going to " <> gshow dst <> " but destination key is not moving"
104+ unbalancedMove _ = Nothing
105+
106+-- |Test whether two @'PatchDMapWithMove' k v@ contain the same patch operations.
107+instance (GEq k, Has' Eq k (NodeInfo k v)) => Eq (PatchDMapWithMove k v) where
108+ PatchDMapWithMove a == PatchDMapWithMove b = a == b
109+
110+-- |Higher kinded 2-tuple, identical to @Data.Functor.Product@ from base ≥ 4.9
111+data Pair1 f g a = Pair1 (f a) (g a)
112+
113+-- |Helper data structure used for composing patches using the monoid instance.
114+data Fixup k v a
115+ = Fixup_Delete
116+ | Fixup_Update (These (From k v a) (To k a))
117+
118+-- |Compose patches having the same effect as applying the patches in turn: @'applyAlways' (p <> q) == 'applyAlways' p . 'applyAlways' q@
119+instance GCompare k => Semigroup (PatchDMapWithMove k v) where
120+ PatchDMapWithMove ma <> PatchDMapWithMove mb = PatchDMapWithMove m
121+ where
122+ connections = DMap.toList $ DMap.intersectionWithKey (\_ a b -> Pair1 (_nodeInfo_to a) (_nodeInfo_from b)) ma mb
123+ h :: DSum k (Pair1 (ComposeMaybe k) (From k v)) -> [DSum k (Fixup k v)]
124+ h (_ :=> Pair1 (ComposeMaybe mToAfter) editBefore) = case (mToAfter, editBefore) of
125+ (Just toAfter, From_Move fromBefore)
126+ | isJust $ fromBefore `geq` toAfter
127+ -> [toAfter :=> Fixup_Delete]
128+ | otherwise
129+ -> [ toAfter :=> Fixup_Update (This editBefore)
130+ , fromBefore :=> Fixup_Update (That (ComposeMaybe mToAfter))
131+ ]
132+ (Nothing, From_Move fromBefore) -> [fromBefore :=> Fixup_Update (That (ComposeMaybe mToAfter))] -- The item is destroyed in the second patch, so indicate that it is destroyed in the source map
133+ (Just toAfter, _) -> [toAfter :=> Fixup_Update (This editBefore)]
134+ (Nothing, _) -> []
135+ mergeFixups _ Fixup_Delete Fixup_Delete = Fixup_Delete
136+ mergeFixups _ (Fixup_Update a) (Fixup_Update b)
137+ | This x <- a, That y <- b
138+ = Fixup_Update $ These x y
139+ | That y <- a, This x <- b
140+ = Fixup_Update $ These x y
141+ mergeFixups _ _ _ = error "PatchDMapWithMove: incompatible fixups"
142+ fixups = DMap.fromListWithKey mergeFixups $ concatMap h connections
143+ combineNodeInfos _ nia nib = NodeInfo
144+ { _nodeInfo_from = _nodeInfo_from nia
145+ , _nodeInfo_to = _nodeInfo_to nib
146+ }
147+ applyFixup _ ni = \case
148+ Fixup_Delete -> Nothing
149+ Fixup_Update u -> Just $ NodeInfo
150+ { _nodeInfo_from = fromMaybe (_nodeInfo_from ni) $ getHere u
151+ , _nodeInfo_to = fromMaybe (_nodeInfo_to ni) $ getThere u
152+ }
153+ m = DMap.differenceWithKey applyFixup (DMap.unionWithKey combineNodeInfos ma mb) fixups
154+ getHere :: These a b -> Maybe a
155+ getHere = \case
156+ This a -> Just a
157+ These a _ -> Just a
158+ That _ -> Nothing
159+ getThere :: These a b -> Maybe b
160+ getThere = \case
161+ This _ -> Nothing
162+ These _ b -> Just b
163+ That b -> Just b
164+
165+-- |Compose patches having the same effect as applying the patches in turn: @'applyAlways' (p <> q) == 'applyAlways' p . 'applyAlways' q@
166+instance GCompare k => Monoid (PatchDMapWithMove k v) where
167+ mempty = PatchDMapWithMove mempty
168+ mappend = (<>)
169+
170+{-
171+mappendPatchDMapWithMoveSlow :: forall k v. (ShowTag k v, GCompare k) => PatchDMapWithMove k v -> PatchDMapWithMove k v -> PatchDMapWithMove k v
172+PatchDMapWithMove dstAfter srcAfter `mappendPatchDMapWithMoveSlow` PatchDMapWithMove dstBefore srcBefore = PatchDMapWithMove dst src
173+ where
174+ getDstAction k m = fromMaybe (From_Move k) $ DMap.lookup k m -- Any key that isn't present is treated as that key moving to itself
175+ removeRedundantDst toKey (From_Move fromKey) | isJust (toKey `geq` fromKey) = Nothing
176+ removeRedundantDst _ a = Just a
177+ f :: forall a. k a -> From k v a -> Maybe (From k v a)
178+ f toKey _ = removeRedundantDst toKey $ case getDstAction toKey dstAfter of
179+ From_Move fromKey -> getDstAction fromKey dstBefore
180+ nonMove -> nonMove
181+ dst = DMap.mapMaybeWithKey f $ DMap.union dstAfter dstBefore
182+ getSrcAction k m = fromMaybe (ComposeMaybe $ Just k) $ DMap.lookup k m
183+ removeRedundantSrc fromKey (ComposeMaybe (Just toKey)) | isJust (fromKey `geq` toKey) = Nothing
184+ removeRedundantSrc _ a = Just a
185+ g :: forall a. k a -> ComposeMaybe k a -> Maybe (ComposeMaybe k a)
186+ g fromKey _ = removeRedundantSrc fromKey $ case getSrcAction fromKey srcBefore of
187+ ComposeMaybe Nothing -> ComposeMaybe Nothing
188+ ComposeMaybe (Just toKeyBefore) -> getSrcAction toKeyBefore srcAfter
189+ src = DMap.mapMaybeWithKey g $ DMap.union srcAfter srcBefore
190+-}
191+
192+-- |Make a @'PatchDMapWithMove' k v@ which has the effect of inserting or updating a value @v a@ to the given key @k a@, like 'DMap.insert'.
193+insertDMapKey :: k a -> v a -> PatchDMapWithMove k v
194+insertDMapKey k v =
195+ PatchDMapWithMove . DMap.singleton k $ NodeInfo (From_Insert v) (ComposeMaybe Nothing)
196+
197+-- |Make a @'PatchDMapWithMove' k v@ which has the effect of moving the value from the first key @k a@ to the second key @k a@, equivalent to:
198+--
199+-- @
200+-- 'DMap.delete' src (maybe dmap ('DMap.insert' dst) (DMap.lookup src dmap))
201+-- @
202+moveDMapKey :: GCompare k => k a -> k a -> PatchDMapWithMove k v
203+moveDMapKey src dst = case src `geq` dst of
204+ Nothing -> PatchDMapWithMove $ DMap.fromList
205+ [ dst :=> NodeInfo (From_Move src) (ComposeMaybe Nothing)
206+ , src :=> NodeInfo From_Delete (ComposeMaybe $ Just dst)
207+ ]
208+ Just _ -> mempty
209+
210+-- |Make a @'PatchDMapWithMove' k v@ which has the effect of swapping two keys in the mapping, equivalent to:
211+--
212+-- @
213+-- let aMay = DMap.lookup a dmap
214+-- bMay = DMap.lookup b dmap
215+-- in maybe id (DMap.insert a) (bMay `mplus` aMay)
216+-- . maybe id (DMap.insert b) (aMay `mplus` bMay)
217+-- . DMap.delete a . DMap.delete b $ dmap
218+-- @
219+swapDMapKey :: GCompare k => k a -> k a -> PatchDMapWithMove k v
220+swapDMapKey src dst = case src `geq` dst of
221+ Nothing -> PatchDMapWithMove $ DMap.fromList
222+ [ dst :=> NodeInfo (From_Move src) (ComposeMaybe $ Just src)
223+ , src :=> NodeInfo (From_Move dst) (ComposeMaybe $ Just dst)
224+ ]
225+ Just _ -> mempty
226+
227+-- |Make a @'PatchDMapWithMove' k v@ which has the effect of deleting a key in the mapping, equivalent to 'DMap.delete'.
228+deleteDMapKey :: k a -> PatchDMapWithMove k v
229+deleteDMapKey k = PatchDMapWithMove $ DMap.singleton k $ NodeInfo From_Delete $ ComposeMaybe Nothing
230+
231+{-
232+k1, k2 :: Const2 Int () ()
233+k1 = Const2 1
234+k2 = Const2 2
235+p1, p2 :: PatchDMapWithMove (Const2 Int ()) Identity
236+p1 = moveDMapKey k1 k2
237+p2 = moveDMapKey k2 k1
238+p12 = p1 <> p2
239+p21 = p2 <> p1
240+p12Slow = p1 `mappendPatchDMapWithMoveSlow` p2
241+p21Slow = p2 `mappendPatchDMapWithMoveSlow` p1
242+
243+testPatchDMapWithMove = do
244+ print p1
245+ print p2
246+ print $ p12 == deleteDMapKey k1
247+ print $ p21 == deleteDMapKey k2
248+ print $ p12Slow == deleteDMapKey k1
249+ print $ p21Slow == deleteDMapKey k2
250+
251+dst (PatchDMapWithMove x _) = x
252+src (PatchDMapWithMove _ x) = x
253+-}
254+
255+-- |Extract the 'DMap' representing the patch changes from the 'PatchDMapWithMove'.
256+unPatchDMapWithMove :: PatchDMapWithMove k v -> DMap k (NodeInfo k v)
257+unPatchDMapWithMove (PatchDMapWithMove p) = p
258+
259+-- |Wrap a 'DMap' representing patch changes into a 'PatchDMapWithMove', without checking any invariants.
260+--
261+-- __Warning:__ when using this function, you must ensure that the invariants of 'PatchDMapWithMove' are preserved; they will not be checked.
262+unsafePatchDMapWithMove :: DMap k (NodeInfo k v) -> PatchDMapWithMove k v
263+unsafePatchDMapWithMove = PatchDMapWithMove
264+
265+-- |Wrap a 'DMap' representing patch changes into a 'PatchDMapWithMove' while checking invariants. If the invariants are satisfied, @Right p@ is returned
266+-- otherwise @Left errors@.
267+patchDMapWithMove :: (GCompare k, GShow k) => DMap k (NodeInfo k v) -> Either [String] (PatchDMapWithMove k v)
268+patchDMapWithMove dm =
269+ case validationErrorsForPatchDMapWithMove dm of
270+ [] -> Right $ unsafePatchDMapWithMove dm
271+ errs -> Left errs
272+
273+-- |Map a natural transform @v -> v'@ over the given patch, transforming @'PatchDMapWithMove' k v@ into @'PatchDMapWithMove' k v'@.
274+mapPatchDMapWithMove :: forall k v v'. (forall a. v a -> v' a) -> PatchDMapWithMove k v -> PatchDMapWithMove k v'
275+mapPatchDMapWithMove f (PatchDMapWithMove p) = PatchDMapWithMove $
276+ DMap.map (\ni -> ni { _nodeInfo_from = g $ _nodeInfo_from ni }) p
277+ where g :: forall a. From k v a -> From k v' a
278+ g = \case
279+ From_Insert v -> From_Insert $ f v
280+ From_Delete -> From_Delete
281+ From_Move k -> From_Move k
282+
283+-- |Traverse an effectful function @forall a. v a -> m (v ' a)@ over the given patch, transforming @'PatchDMapWithMove' k v@ into @m ('PatchDMapWithMove' k v')@.
284+traversePatchDMapWithMove :: forall m k v v'. Applicative m => (forall a. v a -> m (v' a)) -> PatchDMapWithMove k v -> m (PatchDMapWithMove k v')
285+traversePatchDMapWithMove f = traversePatchDMapWithMoveWithKey $ const f
286+
287+-- |Map an effectful function @forall a. k a -> v a -> m (v ' a)@ over the given patch, transforming @'PatchDMapWithMove' k v@ into @m ('PatchDMapWithMove' k v')@.
288+traversePatchDMapWithMoveWithKey :: forall m k v v'. Applicative m => (forall a. k a -> v a -> m (v' a)) -> PatchDMapWithMove k v -> m (PatchDMapWithMove k v')
289+traversePatchDMapWithMoveWithKey f (PatchDMapWithMove p) = PatchDMapWithMove <$> DMap.traverseWithKey (nodeInfoMapFromM . g) p
290+ where g :: forall a. k a -> From k v a -> m (From k v' a)
291+ g k = \case
292+ From_Insert v -> From_Insert <$> f k v
293+ From_Delete -> pure From_Delete
294+ From_Move fromKey -> pure $ From_Move fromKey
295+
296+-- |Map a function which transforms @'From' k v a@ into a @'From' k v' a@ over a @'NodeInfo' k v a@.
297+nodeInfoMapFrom :: (From k v a -> From k v' a) -> NodeInfo k v a -> NodeInfo k v' a
298+nodeInfoMapFrom f ni = ni { _nodeInfo_from = f $ _nodeInfo_from ni }
299+
300+-- |Map an effectful function which transforms @'From' k v a@ into a @f ('From' k v' a)@ over a @'NodeInfo' k v a@.
301+nodeInfoMapFromM :: Functor f => (From k v a -> f (From k v' a)) -> NodeInfo k v a -> f (NodeInfo k v' a)
302+nodeInfoMapFromM f ni = fmap (\result -> ni { _nodeInfo_from = result }) $ f $ _nodeInfo_from ni
303+
304+-- |Weaken a 'PatchDMapWithMove' to a 'PatchMapWithMove' by weakening the keys from @k a@ to @'Some' k@ and applying a given weakening function @v a -> v'@ to
305+-- values.
306+weakenPatchDMapWithMoveWith :: forall k v v'. (forall a. v a -> v') -> PatchDMapWithMove k v -> PatchMapWithMove (Some k) v'
307+weakenPatchDMapWithMoveWith f (PatchDMapWithMove p) = PatchMapWithMove $ weakenDMapWith g p
308+ where g :: forall a. NodeInfo k v a -> MapWithMove.NodeInfo (Some k) v'
309+ g ni = MapWithMove.NodeInfo
310+ { MapWithMove._nodeInfo_from = case _nodeInfo_from ni of
311+ From_Insert v -> MapWithMove.From_Insert $ f v
312+ From_Delete -> MapWithMove.From_Delete
313+ From_Move k -> MapWithMove.From_Move $ Some k
314+ , MapWithMove._nodeInfo_to = Some <$> getComposeMaybe (_nodeInfo_to ni)
315+ }
316+
317+-- |"Weaken" a @'PatchDMapWithMove' (Const2 k a) v@ to a @'PatchMapWithMove' k v'@. Weaken is in scare quotes because the 'Const2' has already disabled any
318+-- dependency in the typing and all points are already @a@, hence the function to map each value to @v'@ is not higher rank.
319+patchDMapWithMoveToPatchMapWithMoveWith :: forall k v v' a. (v a -> v') -> PatchDMapWithMove (Const2 k a) v -> PatchMapWithMove k v'
320+patchDMapWithMoveToPatchMapWithMoveWith f (PatchDMapWithMove p) = PatchMapWithMove $ dmapToMapWith g p
321+ where g :: NodeInfo (Const2 k a) v a -> MapWithMove.NodeInfo k v'
322+ g ni = MapWithMove.NodeInfo
323+ { MapWithMove._nodeInfo_from = case _nodeInfo_from ni of
324+ From_Insert v -> MapWithMove.From_Insert $ f v
325+ From_Delete -> MapWithMove.From_Delete
326+ From_Move (Const2 k) -> MapWithMove.From_Move k
327+ , MapWithMove._nodeInfo_to = unConst2 <$> getComposeMaybe (_nodeInfo_to ni)
328+ }
329+
330+-- |"Strengthen" a @'PatchMapWithMove' k v@ into a @'PatchDMapWithMove ('Const2' k a)@; that is, turn a non-dependently-typed patch into a dependently typed
331+-- one but which always has a constant key type represented by 'Const2'. Apply the given function to each @v@ to produce a @v' a@.
332+-- Completemented by 'patchDMapWithMoveToPatchMapWithMoveWith'
333+const2PatchDMapWithMoveWith :: forall k v v' a. (v -> v' a) -> PatchMapWithMove k v -> PatchDMapWithMove (Const2 k a) v'
334+const2PatchDMapWithMoveWith f (PatchMapWithMove p) = PatchDMapWithMove $ DMap.fromDistinctAscList $ g <$> Map.toAscList p
335+ where g :: (k, MapWithMove.NodeInfo k v) -> DSum (Const2 k a) (NodeInfo (Const2 k a) v')
336+ g (k, ni) = Const2 k :=> NodeInfo
337+ { _nodeInfo_from = case MapWithMove._nodeInfo_from ni of
338+ MapWithMove.From_Insert v -> From_Insert $ f v
339+ MapWithMove.From_Delete -> From_Delete
340+ MapWithMove.From_Move fromKey -> From_Move $ Const2 fromKey
341+ , _nodeInfo_to = ComposeMaybe $ Const2 <$> MapWithMove._nodeInfo_to ni
342+ }
343+
344+-- | Apply the insertions, deletions, and moves to a given 'DMap'.
345+instance GCompare k => Patch (PatchDMapWithMove k v) where
346+ type PatchTarget (PatchDMapWithMove k v) = DMap k v
347+ apply (PatchDMapWithMove p) old = Just $! insertions `DMap.union` (old `DMap.difference` deletions) --TODO: return Nothing sometimes --Note: the strict application here is critical to ensuring that incremental merges don't hold onto all their prerequisite events forever; can we make this more robust?
348+ where insertions = DMap.mapMaybeWithKey insertFunc p
349+ insertFunc :: forall a. k a -> NodeInfo k v a -> Maybe (v a)
350+ insertFunc _ ni = case _nodeInfo_from ni of
351+ From_Insert v -> Just v
352+ From_Move k -> DMap.lookup k old
353+ From_Delete -> Nothing
354+ deletions = DMap.mapMaybeWithKey deleteFunc p
355+ deleteFunc :: forall a. k a -> NodeInfo k v a -> Maybe (Constant () a)
356+ deleteFunc _ ni = case _nodeInfo_from ni of
357+ From_Delete -> Just $ Constant ()
358+ _ -> Nothing
359+
360+-- | Get the values that will be replaced, deleted, or moved if the given patch is applied to the given 'DMap'.
361+getDeletionsAndMoves :: GCompare k => PatchDMapWithMove k v -> DMap k v' -> DMap k (Product v' (ComposeMaybe k))
362+getDeletionsAndMoves (PatchDMapWithMove p) m = DMap.intersectionWithKey f m p
363+ where f _ v ni = Pair v $ _nodeInfo_to ni
src/Reflex/Patch/IntMap.hsnew file+67
@@ -0,0 +1,67 @@
1+{-# LANGUAGE CPP #-}
2+{-# LANGUAGE DeriveFoldable #-}
3+{-# LANGUAGE DeriveFunctor #-}
4+{-# LANGUAGE DeriveTraversable #-}
5+{-# LANGUAGE GeneralizedNewtypeDeriving #-}
6+{-# LANGUAGE TypeFamilies #-}
7+-- | Module containing 'PatchIntMap', a 'Patch' for 'IntMap' which allows for
8+-- insert/update or delete of associations.
9+module Reflex.Patch.IntMap where
10+
11+import Data.IntMap.Strict (IntMap)
12+import qualified Data.IntMap.Strict as IntMap
13+import Data.Maybe
14+import Data.Semigroup
15+import Reflex.Patch.Class
16+
17+-- | 'Patch' for 'IntMap' which represents insertion or deletion of keys in the mapping.
18+-- Internally represented by 'IntMap (Maybe a)', where @Just@ means insert/update
19+-- and @Nothing@ means delete.
20+newtype PatchIntMap a = PatchIntMap (IntMap (Maybe a)) deriving (Functor, Foldable, Traversable, Monoid)
21+
22+-- | Apply the insertions or deletions to a given 'IntMap'.
23+instance Patch (PatchIntMap a) where
24+ type PatchTarget (PatchIntMap a) = IntMap a
25+ apply (PatchIntMap p) v = if IntMap.null p then Nothing else Just $
26+ let removes = IntMap.filter isNothing p
27+ adds = IntMap.mapMaybe id p
28+ in IntMap.union adds $ v `IntMap.difference` removes
29+
30+-- | @a <> b@ will apply the changes of @b@ and then apply the changes of @a@.
31+-- If the same key is modified by both patches, the one on the left will take
32+-- precedence.
33+instance Semigroup (PatchIntMap v) where
34+ PatchIntMap a <> PatchIntMap b = PatchIntMap $ a `mappend` b --TODO: Add a semigroup instance for Map
35+ -- PatchMap is idempotent, so stimes n is id for every n
36+#if MIN_VERSION_semigroups(0,17,0)
37+ stimes = stimesIdempotentMonoid
38+#else
39+ times1p n x = case compare n 0 of
40+ LT -> error "stimesIdempotentMonoid: negative multiplier"
41+ EQ -> mempty
42+ GT -> x
43+#endif
44+
45+-- | Map a function @Int -> a -> b@ over all @a@s in the given @'PatchIntMap' a@
46+-- (that is, all inserts/updates), producing a @PatchIntMap b@.
47+mapIntMapPatchWithKey :: (Int -> a -> b) -> PatchIntMap a -> PatchIntMap b
48+mapIntMapPatchWithKey f (PatchIntMap m) = PatchIntMap $ IntMap.mapWithKey (\ k mv -> f k <$> mv) m
49+
50+-- | Map an effectful function @Int -> a -> f b@ over all @a@s in the given @'PatchIntMap' a@
51+-- (that is, all inserts/updates), producing a @f (PatchIntMap b)@.
52+traverseIntMapPatchWithKey :: Applicative f => (Int -> a -> f b) -> PatchIntMap a -> f (PatchIntMap b)
53+traverseIntMapPatchWithKey f (PatchIntMap m) = PatchIntMap <$> IntMap.traverseWithKey (\k mv -> traverse (f k) mv) m
54+
55+-- | Extract all @a@s inserted/updated by the given @'PatchIntMap' a@.
56+patchIntMapNewElements :: PatchIntMap a -> [a]
57+patchIntMapNewElements (PatchIntMap m) = catMaybes $ IntMap.elems m
58+
59+-- | Convert the given @'PatchIntMap' a@ into an @'IntMap' a@ with all
60+-- the inserts/updates in the given patch.
61+patchIntMapNewElementsMap :: PatchIntMap a -> IntMap a
62+patchIntMapNewElementsMap (PatchIntMap m) = IntMap.mapMaybe id m
63+
64+-- | Subset the given @'IntMap' a@ to contain only the keys that would be
65+-- deleted by the given @'PatchIntMap' a@.
66+getDeletions :: PatchIntMap v -> IntMap v' -> IntMap v'
67+getDeletions (PatchIntMap m) v = IntMap.intersection v m
src/Reflex/Patch/Map.hsnew file+63
@@ -0,0 +1,63 @@
1+{-# LANGUAGE CPP #-}
2+{-# LANGUAGE LambdaCase #-}
3+{-# LANGUAGE TypeFamilies #-}
4+-- | 'Patch'es on 'Map' that consist only of insertions (including overwrites)
5+-- and deletions
6+module Reflex.Patch.Map where
7+
8+import Reflex.Patch.Class
9+
10+import Data.Map (Map)
11+import qualified Data.Map as Map
12+import Data.Maybe
13+import Data.Semigroup
14+
15+-- | A set of changes to a 'Map'. Any element may be inserted/updated or
16+-- deleted. Insertions are represented as values wrapped in 'Just', while
17+-- deletions are represented as 'Nothing's
18+newtype PatchMap k v = PatchMap { unPatchMap :: Map k (Maybe v) }
19+ deriving (Show, Read, Eq, Ord)
20+
21+-- | Apply the insertions or deletions to a given 'Map'.
22+instance Ord k => Patch (PatchMap k v) where
23+ type PatchTarget (PatchMap k v) = Map k v
24+ {-# INLINABLE apply #-}
25+ apply (PatchMap p) old = Just $! insertions `Map.union` (old `Map.difference` deletions) --TODO: return Nothing sometimes --Note: the strict application here is critical to ensuring that incremental merges don't hold onto all their prerequisite events forever; can we make this more robust?
26+ where insertions = Map.mapMaybeWithKey (const id) p
27+ deletions = Map.mapMaybeWithKey (const nothingToJust) p
28+ nothingToJust = \case
29+ Nothing -> Just ()
30+ Just _ -> Nothing
31+
32+-- | @a <> b@ will apply the changes of @b@ and then apply the changes of @a@.
33+-- If the same key is modified by both patches, the one on the left will take
34+-- precedence.
35+instance Ord k => Semigroup (PatchMap k v) where
36+ PatchMap a <> PatchMap b = PatchMap $ a `mappend` b --TODO: Add a semigroup instance for Map
37+ -- PatchMap is idempotent, so stimes n is id for every n
38+#if MIN_VERSION_semigroups(0,17,0)
39+ stimes = stimesIdempotentMonoid
40+#else
41+ times1p n x = case compare n 0 of
42+ LT -> error "stimesIdempotentMonoid: negative multiplier"
43+ EQ -> mempty
44+ GT -> x
45+#endif
46+
47+-- | The empty 'PatchMap' contains no insertions or deletions
48+instance Ord k => Monoid (PatchMap k v) where
49+ mempty = PatchMap mempty
50+ mappend = (<>)
51+
52+-- | 'fmap'ping a 'PatchMap' will alter all of the values it will insert.
53+-- Deletions are unaffected.
54+instance Functor (PatchMap k) where
55+ fmap f = PatchMap . fmap (fmap f) . unPatchMap
56+
57+-- | Returns all the new elements that will be added to the 'Map'
58+patchMapNewElements :: PatchMap k v -> [v]
59+patchMapNewElements (PatchMap p) = catMaybes $ Map.elems p
60+
61+-- | Returns all the new elements that will be added to the 'Map'
62+patchMapNewElementsMap :: PatchMap k v -> Map k v
63+patchMapNewElementsMap (PatchMap p) = Map.mapMaybe id p
src/Reflex/Patch/MapWithMove.hsnew file+270
@@ -0,0 +1,270 @@
1+{-# LANGUAGE DeriveFoldable #-}
2+{-# LANGUAGE DeriveFunctor #-}
3+{-# LANGUAGE DeriveTraversable #-}
4+{-# LANGUAGE FlexibleContexts #-}
5+{-# LANGUAGE LambdaCase #-}
6+{-# LANGUAGE PatternGuards #-}
7+{-# LANGUAGE ScopedTypeVariables #-}
8+{-# LANGUAGE TypeFamilies #-}
9+-- | 'Patch'es on 'Map' that can insert, delete, and move values from one key to
10+-- another
11+module Reflex.Patch.MapWithMove where
12+
13+import Reflex.Patch.Class
14+
15+import Control.Arrow
16+import Control.Monad.State
17+import Data.Foldable
18+import Data.Function
19+import Data.List
20+import Data.Map (Map)
21+import qualified Data.Map as Map
22+import Data.Maybe
23+import Data.Semigroup (Semigroup (..), (<>))
24+import qualified Data.Set as Set
25+import Data.These (These(..))
26+import Data.Tuple
27+
28+-- | Patch a DMap with additions, deletions, and moves. Invariant: If key @k1@
29+-- is coming from @From_Move k2@, then key @k2@ should be going to @Just k1@,
30+-- and vice versa. There should never be any unpaired From/To keys.
31+newtype PatchMapWithMove k v = PatchMapWithMove (Map k (NodeInfo k v)) deriving (Show, Eq, Ord, Functor, Foldable, Traversable)
32+
33+-- | Holds the information about each key: where its new value should come from,
34+-- and where its old value should go to
35+data NodeInfo k v = NodeInfo
36+ { _nodeInfo_from :: !(From k v)
37+ -- ^ Where do we get the new value for this key?
38+ , _nodeInfo_to :: !(To k)
39+ -- ^ If the old value is being kept (i.e. moved rather than deleted or
40+ -- replaced), where is it going?
41+ }
42+ deriving (Show, Read, Eq, Ord, Functor, Foldable, Traversable)
43+
44+-- | Describe how a key's new value should be produced
45+data From k v
46+ = From_Insert v -- ^ Insert the given value here
47+ | From_Delete -- ^ Delete the existing value, if any, from here
48+ | From_Move !k -- ^ Move the value here from the given key
49+ deriving (Show, Read, Eq, Ord, Functor, Foldable, Traversable)
50+
51+-- | Describe where a key's old value will go. If this is 'Just', that means
52+-- the key's old value will be moved to the given other key; if it is 'Nothing',
53+-- that means it will be deleted.
54+type To = Maybe
55+
56+-- | Create a 'PatchMapWithMove', validating it
57+patchMapWithMove :: Ord k => Map k (NodeInfo k v) -> Maybe (PatchMapWithMove k v)
58+patchMapWithMove m = if valid then Just $ PatchMapWithMove m else Nothing
59+ where valid = forwardLinks == backwardLinks
60+ forwardLinks = Map.mapMaybe _nodeInfo_to m
61+ backwardLinks = Map.fromList $ catMaybes $ flip fmap (Map.toList m) $ \(to, v) ->
62+ case _nodeInfo_from v of
63+ From_Move from -> Just (from, to)
64+ _ -> Nothing
65+
66+-- | Create a 'PatchMapWithMove' that inserts everything in the given 'Map'
67+patchMapWithMoveInsertAll :: Map k v -> PatchMapWithMove k v
68+patchMapWithMoveInsertAll m = PatchMapWithMove $ flip fmap m $ \v -> NodeInfo
69+ { _nodeInfo_from = From_Insert v
70+ , _nodeInfo_to = Nothing
71+ }
72+
73+-- | Extract the internal representation of the 'PatchMapWithMove'
74+unPatchMapWithMove :: PatchMapWithMove k v -> Map k (NodeInfo k v)
75+unPatchMapWithMove (PatchMapWithMove p) = p
76+
77+-- | Make a @'PatchMapWithMove' k v@ which has the effect of inserting or updating a value @v@ to the given key @k@, like 'Map.insert'.
78+insertMapKey :: k -> v -> PatchMapWithMove k v
79+insertMapKey k v = PatchMapWithMove . Map.singleton k $ NodeInfo (From_Insert v) Nothing
80+
81+-- |Make a @'PatchMapWithMove' k v@ which has the effect of moving the value from the first key @k@ to the second key @k@, equivalent to:
82+--
83+-- @
84+-- 'Map.delete' src (maybe map ('Map.insert' dst) (Map.lookup src map))
85+-- @
86+moveMapKey :: Ord k => k -> k -> PatchMapWithMove k v
87+moveMapKey src dst
88+ | src == dst = mempty
89+ | otherwise =
90+ PatchMapWithMove $ Map.fromList
91+ [ (dst, NodeInfo (From_Move src) Nothing)
92+ , (src, NodeInfo From_Delete (Just dst))
93+ ]
94+
95+-- |Make a @'PatchMapWithMove' k v@ which has the effect of swapping two keys in the mapping, equivalent to:
96+--
97+-- @
98+-- let aMay = Map.lookup a map
99+-- bMay = Map.lookup b map
100+-- in maybe id (Map.insert a) (bMay `mplus` aMay)
101+-- . maybe id (Map.insert b) (aMay `mplus` bMay)
102+-- . Map.delete a . Map.delete b $ map
103+-- @
104+swapMapKey :: Ord k => k -> k -> PatchMapWithMove k v
105+swapMapKey src dst
106+ | src == dst = mempty
107+ | otherwise =
108+ PatchMapWithMove $ Map.fromList
109+ [ (dst, NodeInfo (From_Move src) (Just src))
110+ , (src, NodeInfo (From_Move dst) (Just dst))
111+ ]
112+
113+-- |Make a @'PatchMapWithMove' k v@ which has the effect of deleting a key in the mapping, equivalent to 'Map.delete'.
114+deleteMapKey :: k -> PatchMapWithMove k v
115+deleteMapKey k = PatchMapWithMove . Map.singleton k $ NodeInfo From_Delete Nothing
116+
117+-- | Wrap a @'Map' k (NodeInfo k v)@ representing patch changes into a @'PatchMapWithMove' k v@, without checking any invariants.
118+--
119+-- __Warning:__ when using this function, you must ensure that the invariants of 'PatchMapWithMove' are preserved; they will not be checked.
120+unsafePatchMapWithMove :: Map k (NodeInfo k v) -> PatchMapWithMove k v
121+unsafePatchMapWithMove = PatchMapWithMove
122+
123+-- | Apply the insertions, deletions, and moves to a given 'Map'
124+instance Ord k => Patch (PatchMapWithMove k v) where
125+ type PatchTarget (PatchMapWithMove k v) = Map k v
126+ apply (PatchMapWithMove p) old = Just $! insertions `Map.union` (old `Map.difference` deletions) --TODO: return Nothing sometimes --Note: the strict application here is critical to ensuring that incremental merges don't hold onto all their prerequisite events forever; can we make this more robust?
127+ where insertions = flip Map.mapMaybeWithKey p $ \_ ni -> case _nodeInfo_from ni of
128+ From_Insert v -> Just v
129+ From_Move k -> Map.lookup k old
130+ From_Delete -> Nothing
131+ deletions = flip Map.mapMaybeWithKey p $ \_ ni -> case _nodeInfo_from ni of
132+ From_Delete -> Just ()
133+ _ -> Nothing
134+
135+-- | Returns all the new elements that will be added to the 'Map'.
136+patchMapWithMoveNewElements :: PatchMapWithMove k v -> [v]
137+patchMapWithMoveNewElements = Map.elems . patchMapWithMoveNewElementsMap
138+
139+-- | Return a @'Map' k v@ with all the inserts/updates from the given @'PatchMapWithMove' k v@.
140+patchMapWithMoveNewElementsMap :: PatchMapWithMove k v -> Map k v
141+patchMapWithMoveNewElementsMap (PatchMapWithMove p) = Map.mapMaybe f p
142+ where f ni = case _nodeInfo_from ni of
143+ From_Insert v -> Just v
144+ From_Move _ -> Nothing
145+ From_Delete -> Nothing
146+
147+-- | Create a 'PatchMapWithMove' that, if applied to the given 'Map', will sort
148+-- its values using the given ordering function. The set keys of the 'Map' is
149+-- not changed.
150+patchThatSortsMapWith :: Ord k => (v -> v -> Ordering) -> Map k v -> PatchMapWithMove k v
151+patchThatSortsMapWith cmp m = PatchMapWithMove $ Map.fromList $ catMaybes $ zipWith g unsorted sorted
152+ where unsorted = Map.toList m
153+ sorted = sortBy (cmp `on` snd) unsorted
154+ f (to, _) (from, _) = if to == from then Nothing else
155+ Just (from, to)
156+ reverseMapping = Map.fromList $ catMaybes $ zipWith f unsorted sorted
157+ g (to, _) (from, _) = if to == from then Nothing else
158+ let Just movingTo = Map.lookup from reverseMapping
159+ in Just (to, NodeInfo (From_Move from) $ Just movingTo)
160+
161+-- | Create a 'PatchMapWithMove' that, if applied to the first 'Map' provided,
162+-- will produce a 'Map' with the same values as the second 'Map' but with the
163+-- values sorted with the given ordering function.
164+patchThatChangesAndSortsMapWith :: forall k v. (Ord k, Ord v) => (v -> v -> Ordering) -> Map k v -> Map k v -> PatchMapWithMove k v
165+patchThatChangesAndSortsMapWith cmp oldByIndex newByIndexUnsorted = patchThatChangesMap oldByIndex newByIndex
166+ where newList = Map.toList newByIndexUnsorted
167+ newByIndex = Map.fromList $ zip (fst <$> newList) $ sortBy cmp $ snd <$> newList
168+
169+-- | Create a 'PatchMapWithMove' that, if applied to the first 'Map' provided,
170+-- will produce the second 'Map'.
171+patchThatChangesMap :: (Ord k, Ord v) => Map k v -> Map k v -> PatchMapWithMove k v
172+patchThatChangesMap oldByIndex newByIndex = patch
173+ where oldByValue = Map.fromListWith Set.union $ swap . first Set.singleton <$> Map.toList oldByIndex
174+ (insertsAndMoves, unusedValuesByValue) = flip runState oldByValue $ do
175+ let f k v = do
176+ remainingValues <- get
177+ let putRemainingKeys remainingKeys = put $ if Set.null remainingKeys
178+ then Map.delete v remainingValues
179+ else Map.insert v remainingKeys remainingValues
180+ case Map.lookup v remainingValues of
181+ Nothing -> return $ NodeInfo (From_Insert v) $ Just undefined -- There's no existing value we can take
182+ Just fromKs ->
183+ if k `Set.member` fromKs
184+ then do
185+ putRemainingKeys $ Set.delete k fromKs
186+ return $ NodeInfo (From_Move k) $ Just undefined -- There's an existing value, and it's here, so no patch necessary
187+ else do
188+ (fromK, remainingKeys) <- return . fromJust $ Set.minView fromKs -- There's an existing value, but it's not here; move it here
189+ putRemainingKeys remainingKeys
190+ return $ NodeInfo (From_Move fromK) $ Just undefined
191+ Map.traverseWithKey f newByIndex
192+ unusedOldKeys = fold unusedValuesByValue
193+ pointlessMove k = \case
194+ From_Move k' | k == k' -> True
195+ _ -> False
196+ keyWasMoved k = if k `Map.member` oldByIndex && not (k `Set.member` unusedOldKeys)
197+ then Just undefined
198+ else Nothing
199+ patch = unsafePatchMapWithMove $ Map.filterWithKey (\k -> not . pointlessMove k . _nodeInfo_from) $ Map.mergeWithKey (\k a _ -> Just $ nodeInfoSetTo (keyWasMoved k) a) (Map.mapWithKey $ \k -> nodeInfoSetTo $ keyWasMoved k) (Map.mapWithKey $ \k _ -> NodeInfo From_Delete $ keyWasMoved k) insertsAndMoves oldByIndex
200+
201+-- | Change the 'From' value of a 'NodeInfo'
202+nodeInfoMapFrom :: (From k v -> From k v) -> NodeInfo k v -> NodeInfo k v
203+nodeInfoMapFrom f ni = ni { _nodeInfo_from = f $ _nodeInfo_from ni }
204+
205+-- | Change the 'From' value of a 'NodeInfo', using a 'Functor' (or
206+-- 'Applicative', 'Monad', etc.) action to get the new value
207+nodeInfoMapMFrom :: Functor f => (From k v -> f (From k v)) -> NodeInfo k v -> f (NodeInfo k v)
208+nodeInfoMapMFrom f ni = fmap (\result -> ni { _nodeInfo_from = result }) $ f $ _nodeInfo_from ni
209+
210+-- | Set the 'To' field of a 'NodeInfo'
211+nodeInfoSetTo :: To k -> NodeInfo k v -> NodeInfo k v
212+nodeInfoSetTo to ni = ni { _nodeInfo_to = to }
213+
214+-- |Helper data structure used for composing patches using the monoid instance.
215+data Fixup k v
216+ = Fixup_Delete
217+ | Fixup_Update (These (From k v) (To k))
218+
219+-- |Compose patches having the same effect as applying the patches in turn: @'applyAlways' (p <> q) == 'applyAlways' p . 'applyAlways' q@
220+instance Ord k => Semigroup (PatchMapWithMove k v) where
221+ PatchMapWithMove ma <> PatchMapWithMove mb = PatchMapWithMove m
222+ where
223+ connections = Map.toList $ Map.intersectionWithKey (\_ a b -> (_nodeInfo_to a, _nodeInfo_from b)) ma mb
224+ h :: (k, (Maybe k, From k v)) -> [(k, Fixup k v)]
225+ h (_, (mToAfter, editBefore)) = case (mToAfter, editBefore) of
226+ (Just toAfter, From_Move fromBefore)
227+ | fromBefore == toAfter
228+ -> [(toAfter, Fixup_Delete)]
229+ | otherwise
230+ -> [ (toAfter, Fixup_Update (This editBefore))
231+ , (fromBefore, Fixup_Update (That mToAfter))
232+ ]
233+ (Nothing, From_Move fromBefore) -> [(fromBefore, Fixup_Update (That mToAfter))] -- The item is destroyed in the second patch, so indicate that it is destroyed in the source map
234+ (Just toAfter, _) -> [(toAfter, Fixup_Update (This editBefore))]
235+ (Nothing, _) -> []
236+ mergeFixups _ Fixup_Delete Fixup_Delete = Fixup_Delete
237+ mergeFixups _ (Fixup_Update a) (Fixup_Update b)
238+ | This x <- a, That y <- b
239+ = Fixup_Update $ These x y
240+ | That y <- a, This x <- b
241+ = Fixup_Update $ These x y
242+ mergeFixups _ _ _ = error "PatchMapWithMove: incompatible fixups"
243+ fixups = Map.fromListWithKey mergeFixups $ concatMap h connections
244+ combineNodeInfos _ nia nib = NodeInfo
245+ { _nodeInfo_from = _nodeInfo_from nia
246+ , _nodeInfo_to = _nodeInfo_to nib
247+ }
248+ applyFixup _ ni = \case
249+ Fixup_Delete -> Nothing
250+ Fixup_Update u -> Just $ NodeInfo
251+ { _nodeInfo_from = fromMaybe (_nodeInfo_from ni) $ getHere u
252+ , _nodeInfo_to = fromMaybe (_nodeInfo_to ni) $ getThere u
253+ }
254+ m = Map.differenceWithKey applyFixup (Map.unionWithKey combineNodeInfos ma mb) fixups
255+ getHere :: These a b -> Maybe a
256+ getHere = \case
257+ This a -> Just a
258+ These a _ -> Just a
259+ That _ -> Nothing
260+ getThere :: These a b -> Maybe b
261+ getThere = \case
262+ This _ -> Nothing
263+ These _ b -> Just b
264+ That b -> Just b
265+
266+--TODO: Figure out how to implement this in terms of PatchDMapWithMove rather than duplicating it here
267+-- |Compose patches having the same effect as applying the patches in turn: @'applyAlways' (p <> q) == 'applyAlways' p . 'applyAlways' q@
268+instance Ord k => Monoid (PatchMapWithMove k v) where
269+ mempty = PatchMapWithMove mempty
270+ mappend = (<>)
src/Reflex/PerformEvent/Base.hs+1−3
@@ -141,7 +141,7 @@ hostPerformEventT a = do
141 case mToPerform of
141 case mToPerform of
142 Nothing -> return [result']
142 Nothing -> return [result']
143 Just toPerform -> do
143 Just toPerform -> do
144− responses <- runHostFrame $ traverseRequesterData (fmap Identity) toPerform
144+ responses <- runHostFrame $ traverseRequesterData (\v -> Identity <$> v) toPerform
145 mrt <- readRef responseTrigger
145 mrt <- readRef responseTrigger
146 let followupEventTriggers = case mrt of
146 let followupEventTriggers = case mrt of
147 Just rt -> [rt :=> Identity responses]
147 Just rt -> [rt :=> Identity responses]
@@ -164,8 +164,6 @@ instance (ReflexHost t, MonadHold t m) => MonadHold t (PerformEventT t m) where
164 buildDynamic getV0 v' = PerformEventT $ lift $ buildDynamic getV0 v'
164 buildDynamic getV0 v' = PerformEventT $ lift $ buildDynamic getV0 v'
165 {-# INLINABLE headE #-}
165 {-# INLINABLE headE #-}
166 headE = PerformEventT . lift . headE
166 headE = PerformEventT . lift . headE
167− {-# INLINABLE now #-}
168− now = PerformEventT . lift $ now
169
167
170instance (MonadRef (HostFrame t), ReflexHost t) => MonadRef (PerformEventT t m) where
168instance (MonadRef (HostFrame t), ReflexHost t) => MonadRef (PerformEventT t m) where
171 type Ref (PerformEventT t m) = Ref (HostFrame t)
169 type Ref (PerformEventT t m) = Ref (HostFrame t)
src/Reflex/PerformEvent/Class.hs+2−6
@@ -5,9 +5,11 @@
5{-# LANGUAGE FlexibleContexts #-}
5{-# LANGUAGE FlexibleContexts #-}
6{-# LANGUAGE FlexibleInstances #-}
6{-# LANGUAGE FlexibleInstances #-}
7{-# LANGUAGE FunctionalDependencies #-}
7{-# LANGUAGE FunctionalDependencies #-}
8+{-# LANGUAGE MultiParamTypeClasses #-}
8{-# LANGUAGE RankNTypes #-}
9{-# LANGUAGE RankNTypes #-}
9{-# LANGUAGE ScopedTypeVariables #-}
10{-# LANGUAGE ScopedTypeVariables #-}
10{-# LANGUAGE TypeFamilies #-}
11{-# LANGUAGE TypeFamilies #-}
12+{-# LANGUAGE TypeOperators #-}
11{-# LANGUAGE UndecidableInstances #-}
13{-# LANGUAGE UndecidableInstances #-}
12#ifdef USE_REFLEX_OPTIMIZER
14#ifdef USE_REFLEX_OPTIMIZER
13{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
15{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
@@ -21,7 +23,6 @@ import Reflex.Class
21import Reflex.TriggerEvent.Class
23import Reflex.TriggerEvent.Class
22
24
23import Control.Monad.Reader
25import Control.Monad.Reader
24−import Control.Monad.Trans.Maybe (MaybeT (..))
25
26
26-- | 'PerformEvent' represents actions that can trigger other actions based on
27-- | 'PerformEvent' represents actions that can trigger other actions based on
27-- 'Event's.
28-- 'Event's.
@@ -61,8 +62,3 @@ instance PerformEvent t m => PerformEvent t (ReaderT r m) where
61 performEvent e = do
62 performEvent e = do
62 r <- ask
63 r <- ask
63 lift $ performEvent $ flip runReaderT r <$> e
64 lift $ performEvent $ flip runReaderT r <$> e
64−
65−instance PerformEvent t m => PerformEvent t (MaybeT m) where
66− type Performable (MaybeT m) = MaybeT (Performable m)
67− performEvent_ = lift . performEvent_ . fmapCheap (void . runMaybeT)
68− performEvent = lift . fmap (fmapMaybe id) . performEvent . fmapCheap runMaybeT
src/Reflex/PostBuild/Base.hs+1−2
@@ -9,6 +9,7 @@
9{-# LANGUAGE RecursiveDo #-}
9{-# LANGUAGE RecursiveDo #-}
10{-# LANGUAGE ScopedTypeVariables #-}
10{-# LANGUAGE ScopedTypeVariables #-}
11{-# LANGUAGE TypeFamilies #-}
11{-# LANGUAGE TypeFamilies #-}
12+{-# LANGUAGE TypeOperators #-}
12{-# LANGUAGE UndecidableInstances #-}
13{-# LANGUAGE UndecidableInstances #-}
13#ifdef USE_REFLEX_OPTIMIZER
14#ifdef USE_REFLEX_OPTIMIZER
14{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
15{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
@@ -83,8 +84,6 @@ instance MonadHold t m => MonadHold t (PostBuildT t m) where
83 buildDynamic a0 = lift . buildDynamic a0
84 buildDynamic a0 = lift . buildDynamic a0
84 {-# INLINABLE headE #-}
85 {-# INLINABLE headE #-}
85 headE = lift . headE
86 headE = lift . headE
86− {-# INLINABLE now #-}
87− now = lift now
88
87
89instance PerformEvent t m => PerformEvent t (PostBuildT t m) where
88instance PerformEvent t m => PerformEvent t (PostBuildT t m) where
90 type Performable (PostBuildT t m) = Performable m
89 type Performable (PostBuildT t m) = Performable m
src/Reflex/PostBuild/Class.hs+2
@@ -4,8 +4,10 @@
4{-# LANGUAGE DataKinds #-}
4{-# LANGUAGE DataKinds #-}
5{-# LANGUAGE FlexibleInstances #-}
5{-# LANGUAGE FlexibleInstances #-}
6{-# LANGUAGE FunctionalDependencies #-}
6{-# LANGUAGE FunctionalDependencies #-}
7+{-# LANGUAGE MultiParamTypeClasses #-}
7{-# LANGUAGE ScopedTypeVariables #-}
8{-# LANGUAGE ScopedTypeVariables #-}
8{-# LANGUAGE TypeFamilies #-}
9{-# LANGUAGE TypeFamilies #-}
10+{-# LANGUAGE TypeOperators #-}
9{-# LANGUAGE UndecidableInstances #-}
11{-# LANGUAGE UndecidableInstances #-}
10#ifdef USE_REFLEX_OPTIMIZER
12#ifdef USE_REFLEX_OPTIMIZER
11{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
13{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
src/Reflex/Profiled.hs+18−80
@@ -8,9 +8,6 @@
8{-# LANGUAGE StandaloneDeriving #-}
8{-# LANGUAGE StandaloneDeriving #-}
9{-# LANGUAGE TypeFamilies #-}
9{-# LANGUAGE TypeFamilies #-}
10{-# LANGUAGE UndecidableInstances #-}
10{-# LANGUAGE UndecidableInstances #-}
11−{-# LANGUAGE PolyKinds #-}
12−{-# LANGUAGE TypeApplications #-}
13−{-# LANGUAGE RankNTypes #-}
14-- |
11-- |
15-- Module:
12-- Module:
16-- Reflex.Profiled
13-- Reflex.Profiled
@@ -19,6 +16,7 @@
19-- profiling/cost-center information.
16-- profiling/cost-center information.
20module Reflex.Profiled where
17module Reflex.Profiled where
21
18
19+import Control.Lens hiding (children)
22import Control.Monad
20import Control.Monad
23import Control.Monad.Exception
21import Control.Monad.Exception
24import Control.Monad.Fix
22import Control.Monad.Fix
@@ -26,10 +24,8 @@ import Control.Monad.Primitive
26import Control.Monad.Reader
24import Control.Monad.Reader
27import Control.Monad.Ref
25import Control.Monad.Ref
28import Control.Monad.State.Strict (StateT, execStateT, modify)
26import Control.Monad.State.Strict (StateT, execStateT, modify)
29−import Data.Bifunctor
30import Data.Coerce
27import Data.Coerce
31−import Data.Dependent.Map (DMap)
28+import Data.Dependent.Map (DMap, GCompare)
32−import Data.GADT.Compare (GCompare)
33import Data.FastMutableIntMap
29import Data.FastMutableIntMap
34import Data.IORef
30import Data.IORef
35import Data.List
31import Data.List
@@ -37,27 +33,18 @@ import Data.Map (Map)
37import qualified Data.Map.Strict as Map
33import qualified Data.Map.Strict as Map
38import Data.Monoid ((<>))
34import Data.Monoid ((<>))
39import Data.Ord
35import Data.Ord
40−import Data.Profunctor.Unsafe ((#.))
41import qualified Data.Semigroup as S
36import qualified Data.Semigroup as S
42import Data.Type.Coercion
37import Data.Type.Coercion
43import Foreign.Ptr
38import Foreign.Ptr
44import GHC.Foreign
39import GHC.Foreign
45import GHC.IO.Encoding
40import GHC.IO.Encoding
46import GHC.Stack
41import GHC.Stack
47−import Reflex.Adjustable.Class
48−import Reflex.BehaviorWriter.Class
49import Reflex.Class
42import Reflex.Class
50−import Reflex.DynamicWriter.Class
51−import Reflex.EventWriter.Class
52import Reflex.Host.Class
43import Reflex.Host.Class
53−import Reflex.NotReady.Class
54import Reflex.PerformEvent.Class
44import Reflex.PerformEvent.Class
55−import Reflex.PostBuild.Class
56−import Reflex.Query.Class
57−import Reflex.Requester.Class
58−import Reflex.TriggerEvent.Class
59
45
60import System.IO.Unsafe
46import System.IO.Unsafe
47+import Unsafe.Coerce
61
48
62data ProfiledTimeline t
49data ProfiledTimeline t
63
50
@@ -90,9 +77,9 @@ getCostCentreStack = go []
90 go (cc : l) parent
77 go (cc : l) parent
91
78
92toCostCentreTree :: Ptr CostCentreStack -> Int -> IO CostCentreTree
79toCostCentreTree :: Ptr CostCentreStack -> Int -> IO CostCentreTree
93−toCostCentreTree ccs n =
80+toCostCentreTree ccs n = do
81+ ccList <- getCostCentreStack ccs
94− foldr (\cc child -> CostCentreTree 0 n $ Map.singleton cc child) (CostCentreTree n n mempty)
82+ return $ foldr (\cc child -> CostCentreTree 0 n $ Map.singleton cc child) (CostCentreTree n n mempty) ccList
95− <$> getCostCentreStack ccs
96
83
97getCostCentreTree :: IO CostCentreTree
84getCostCentreTree :: IO CostCentreTree
98getCostCentreTree = do
85getCostCentreTree = do
@@ -146,32 +133,27 @@ instance Reflex t => Reflex (ProfiledTimeline t) where
146 push f (Event_Profiled e) = coerce $ push (coerce f) $ profileEvent e -- Profile before rather than after; this way fanout won't count against us
133 push f (Event_Profiled e) = coerce $ push (coerce f) $ profileEvent e -- Profile before rather than after; this way fanout won't count against us
147 pushCheap f (Event_Profiled e) = coerce $ pushCheap (coerce f) $ profileEvent e
134 pushCheap f (Event_Profiled e) = coerce $ pushCheap (coerce f) $ profileEvent e
148 pull = Behavior_Profiled . pull . coerce
135 pull = Behavior_Profiled . pull . coerce
149− fanG (Event_Profiled e) = EventSelectorG $ coerce $ selectG (fanG $ profileEvent e)
136+ merge :: forall k. GCompare k => DMap k (Event (ProfiledTimeline t)) -> Event (ProfiledTimeline t) (DMap k Identity)
150− mergeG :: forall z (k :: z -> *) q v. GCompare k
151− => (forall a. q a -> Event (ProfiledTimeline t) (v a))
152− -> DMap k q -> Event (ProfiledTimeline t) (DMap k v)
137+ merge = Event_Profiled . merge . (unsafeCoerce :: DMap k (Event (ProfiledTimeline t)) -> DMap k (Event t))
153− mergeG nt = Event_Profiled #. mergeG (coerce nt)
138+ fan (Event_Profiled e) = EventSelector $ coerce $ select (fan $ profileEvent e)
154 switch (Behavior_Profiled b) = coerce $ profileEvent $ switch (coerceBehavior b)
139 switch (Behavior_Profiled b) = coerce $ profileEvent $ switch (coerceBehavior b)
155 coincidence (Event_Profiled e) = coerce $ profileEvent $ coincidence (coerceEvent e)
140 coincidence (Event_Profiled e) = coerce $ profileEvent $ coincidence (coerceEvent e)
156 current (Dynamic_Profiled d) = coerce $ current d
141 current (Dynamic_Profiled d) = coerce $ current d
157 updated (Dynamic_Profiled d) = coerce $ profileEvent $ updated d
142 updated (Dynamic_Profiled d) = coerce $ profileEvent $ updated d
158 unsafeBuildDynamic (ProfiledM a0) (Event_Profiled a') = coerce $ unsafeBuildDynamic a0 a'
143 unsafeBuildDynamic (ProfiledM a0) (Event_Profiled a') = coerce $ unsafeBuildDynamic a0 a'
159 unsafeBuildIncremental (ProfiledM a0) (Event_Profiled a') = coerce $ unsafeBuildIncremental a0 a'
144 unsafeBuildIncremental (ProfiledM a0) (Event_Profiled a') = coerce $ unsafeBuildIncremental a0 a'
160− mergeIncrementalG nt res = Event_Profiled $ mergeIncrementalG (coerce nt) (coerce res)
145+ mergeIncremental = Event_Profiled . mergeIncremental . (unsafeCoerce :: Incremental (ProfiledTimeline t) (PatchDMap k (Event (ProfiledTimeline t))) -> Incremental t (PatchDMap k (Event t)))
161− mergeIncrementalWithMoveG nt res = Event_Profiled $ mergeIncrementalWithMoveG (coerce nt) (coerce res)
146+ mergeIncrementalWithMove = Event_Profiled . mergeIncrementalWithMove . (unsafeCoerce :: Incremental (ProfiledTimeline t) (PatchDMapWithMove k (Event (ProfiledTimeline t))) -> Incremental t (PatchDMapWithMove k (Event t)))
162 currentIncremental (Incremental_Profiled i) = coerce $ currentIncremental i
147 currentIncremental (Incremental_Profiled i) = coerce $ currentIncremental i
163 updatedIncremental (Incremental_Profiled i) = coerce $ profileEvent $ updatedIncremental i
148 updatedIncremental (Incremental_Profiled i) = coerce $ profileEvent $ updatedIncremental i
164 incrementalToDynamic (Incremental_Profiled i) = coerce $ incrementalToDynamic i
149 incrementalToDynamic (Incremental_Profiled i) = coerce $ incrementalToDynamic i
165− behaviorCoercion c =
150+ behaviorCoercion (c :: Coercion a b) = case behaviorCoercion c :: Coercion (Behavior t a) (Behavior t b) of
166− Coercion `trans` behaviorCoercion @t c `trans` Coercion
151+ Coercion -> unsafeCoerce (Coercion :: Coercion (Behavior (ProfiledTimeline t) a) (Behavior (ProfiledTimeline t) a)) --TODO: Figure out how to make this typecheck without the unsafeCoerce
167− eventCoercion c =
152+ eventCoercion (c :: Coercion a b) = case eventCoercion c :: Coercion (Event t a) (Event t b) of
168− Coercion `trans` eventCoercion @t c `trans` Coercion
153+ Coercion -> unsafeCoerce (Coercion :: Coercion (Event (ProfiledTimeline t) a) (Event (ProfiledTimeline t) a)) --TODO: Figure out how to make this typecheck without the unsafeCoerce
169− dynamicCoercion c =
154+ dynamicCoercion (c :: Coercion a b) = case dynamicCoercion c :: Coercion (Dynamic t a) (Dynamic t b) of
170− Coercion `trans` dynamicCoercion @t c `trans` Coercion
155+ Coercion -> unsafeCoerce (Coercion :: Coercion (Dynamic (ProfiledTimeline t) a) (Dynamic (ProfiledTimeline t) a)) --TODO: Figure out how to make this typecheck without the unsafeCoerce
171− incrementalCoercion c d =
172− Coercion `trans` incrementalCoercion @t c d `trans` Coercion
173− mergeIntIncremental = Event_Profiled . mergeIntIncremental .
156+ mergeIntIncremental = Event_Profiled . mergeIntIncremental . (unsafeCoerce :: Incremental (ProfiledTimeline t) (PatchIntMap (Event (ProfiledTimeline t) a)) -> Incremental t (PatchIntMap (Event t a)))
174− coerceWith (Coercion `trans` incrementalCoercion Coercion Coercion `trans` Coercion)
175 fanInt (Event_Profiled e) = coerce $ fanInt $ profileEvent e
157 fanInt (Event_Profiled e) = coerce $ fanInt $ profileEvent e
176
158
177deriving instance Functor (Dynamic t) => Functor (Dynamic (ProfiledTimeline t))
159deriving instance Functor (Dynamic t) => Functor (Dynamic (ProfiledTimeline t))
@@ -184,21 +166,10 @@ instance MonadHold t m => MonadHold (ProfiledTimeline t) (ProfiledM m) where
184 holdIncremental v0 (Event_Profiled v') = ProfiledM $ Incremental_Profiled <$> holdIncremental v0 v'
166 holdIncremental v0 (Event_Profiled v') = ProfiledM $ Incremental_Profiled <$> holdIncremental v0 v'
185 buildDynamic (ProfiledM v0) (Event_Profiled v') = ProfiledM $ Dynamic_Profiled <$> buildDynamic v0 v'
167 buildDynamic (ProfiledM v0) (Event_Profiled v') = ProfiledM $ Dynamic_Profiled <$> buildDynamic v0 v'
186 headE (Event_Profiled e) = ProfiledM $ Event_Profiled <$> headE e
168 headE (Event_Profiled e) = ProfiledM $ Event_Profiled <$> headE e
187− now = ProfiledM $ Event_Profiled <$> now
188
169
189instance MonadSample t m => MonadSample (ProfiledTimeline t) (ProfiledM m) where
170instance MonadSample t m => MonadSample (ProfiledTimeline t) (ProfiledM m) where
190 sample (Behavior_Profiled b) = ProfiledM $ sample b
171 sample (Behavior_Profiled b) = ProfiledM $ sample b
191
172
192−instance Adjustable t m => Adjustable (ProfiledTimeline t) (ProfiledM m) where
193− runWithReplace a0 a' = (fmap . fmap) coerce . lift $
194− runWithReplace (coerce a0) (coerce $ coerce <$> a')
195− traverseIntMapWithKeyWithAdjust f dm0 dm' = (fmap . fmap) coerce . lift $
196− traverseIntMapWithKeyWithAdjust (\k v -> coerce $ f k v) dm0 (coerce dm')
197− traverseDMapWithKeyWithAdjust f dm0 dm' = (fmap . fmap) coerce . lift $
198− traverseDMapWithKeyWithAdjust (\k v -> coerce $ f k v) dm0 (coerce dm')
199− traverseDMapWithKeyWithAdjustWithMove f dm0 dm' = (fmap . fmap) coerce . lift $
200− traverseDMapWithKeyWithAdjustWithMove (\k v -> coerce $ f k v) dm0 (coerce dm')
201−
202instance MonadTrans ProfiledM where
173instance MonadTrans ProfiledM where
203 lift = ProfiledM
174 lift = ProfiledM
204
175
@@ -210,39 +181,6 @@ instance PerformEvent t m => PerformEvent (ProfiledTimeline t) (ProfiledM m) whe
210 performEvent_ = lift . performEvent_ . coerce
181 performEvent_ = lift . performEvent_ . coerce
211 performEvent = lift . fmap coerce . performEvent . coerce
182 performEvent = lift . fmap coerce . performEvent . coerce
212
183
213−instance TriggerEvent t m => TriggerEvent (ProfiledTimeline t) (ProfiledM m) where
214− newTriggerEvent = first coerce <$> lift newTriggerEvent
215− newTriggerEventWithOnComplete = first coerce <$> lift newTriggerEventWithOnComplete
216− newEventWithLazyTriggerWithOnComplete f = coerce <$> lift (newEventWithLazyTriggerWithOnComplete f)
217−
218−instance PostBuild t m => PostBuild (ProfiledTimeline t) (ProfiledM m) where
219− getPostBuild = coerce <$> lift getPostBuild
220−
221−instance NotReady t m => NotReady (ProfiledTimeline t) (ProfiledM m) where
222− notReady = lift notReady
223− notReadyUntil = lift . notReadyUntil . coerce
224−
225−instance BehaviorWriter t w m => BehaviorWriter (ProfiledTimeline t) w (ProfiledM m) where
226− tellBehavior = lift . tellBehavior . coerce
227−
228−instance DynamicWriter t w m => DynamicWriter (ProfiledTimeline t) w (ProfiledM m) where
229− tellDyn = lift . tellDyn . coerce
230−
231−instance EventWriter t w m => EventWriter (ProfiledTimeline t) w (ProfiledM m) where
232− tellEvent = lift . tellEvent . coerce
233−
234−instance MonadQuery t q m => MonadQuery (ProfiledTimeline t) q (ProfiledM m) where
235− tellQueryIncremental = lift . tellQueryIncremental . coerce
236− askQueryResult = coerce <$> lift askQueryResult
237− queryIncremental = fmap coerce . lift . queryIncremental . coerce
238−
239−instance Requester t m => Requester (ProfiledTimeline t) (ProfiledM m) where
240− type Request (ProfiledM m) = Request m
241− type Response (ProfiledM m) = Response m
242−
243− requesting = fmap coerce . lift . requesting . coerce
244− requesting_ = lift . requesting_ . coerce
245−
246instance MonadRef m => MonadRef (ProfiledM m) where
184instance MonadRef m => MonadRef (ProfiledM m) where
247 type Ref (ProfiledM m) = Ref m
185 type Ref (ProfiledM m) = Ref m
248 newRef = lift . newRef
186 newRef = lift . newRef
src/Reflex/Pure.hs+18−27
@@ -5,9 +5,6 @@
5{-# LANGUAGE MultiParamTypeClasses #-}
5{-# LANGUAGE MultiParamTypeClasses #-}
6{-# LANGUAGE ScopedTypeVariables #-}
6{-# LANGUAGE ScopedTypeVariables #-}
7{-# LANGUAGE TypeFamilies #-}
7{-# LANGUAGE TypeFamilies #-}
8−{-# LANGUAGE RankNTypes #-}
9−{-# LANGUAGE PolyKinds #-}
10−
11#ifdef USE_REFLEX_OPTIMIZER
8#ifdef USE_REFLEX_OPTIMIZER
12{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
9{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
13#endif
10#endif
@@ -31,10 +28,14 @@ module Reflex.Pure
31 , Incremental (..)
28 , Incremental (..)
32 ) where
29 ) where
33
30
31+#if !MIN_VERSION_base(4,8,0)
32+import Control.Applicative
33+#endif
34+
34import Control.Monad
35import Control.Monad
35−import Data.Dependent.Map (DMap)
36+import Data.Dependent.Map (DMap, GCompare)
36−import Data.GADT.Compare (GCompare)
37import qualified Data.Dependent.Map as DMap
37import qualified Data.Dependent.Map as DMap
38+import Data.Functor.Identity
38import Data.IntMap (IntMap)
39import Data.IntMap (IntMap)
39import qualified Data.IntMap as IntMap
40import qualified Data.IntMap as IntMap
40import Data.Maybe
41import Data.Maybe
@@ -42,11 +43,10 @@ import Data.MemoTrie
42import Data.Monoid
43import Data.Monoid
43import Data.Type.Coercion
44import Data.Type.Coercion
44import Reflex.Class
45import Reflex.Class
45−import Data.Kind (Type)
46
46
47-- | A completely pure-functional 'Reflex' timeline, identifying moments in time
47-- | A completely pure-functional 'Reflex' timeline, identifying moments in time
48-- with the type @/t/@.
48-- with the type @/t/@.
49−data Pure (t :: Type)
49+data Pure t
50
50
51-- | The 'Enum' instance of @/t/@ must be dense: for all @/x :: t/@, there must not exist
51-- | The 'Enum' instance of @/t/@ must be dense: for all @/x :: t/@, there must not exist
52-- any @/y :: t/@ such that @/'pred' x < y < x/@. The 'HasTrie' instance will be used
52-- any @/y :: t/@ such that @/'pred' x < y < x/@. The 'HasTrie' instance will be used
@@ -79,19 +79,17 @@ instance (Enum t, HasTrie t, Ord t) => Reflex (Pure t) where
79 -- [UNUSED_CONSTRAINT]: The following type signature for merge will produce a
79 -- [UNUSED_CONSTRAINT]: The following type signature for merge will produce a
80 -- warning because the GCompare instance is not used; however, removing the
80 -- warning because the GCompare instance is not used; however, removing the
81 -- GCompare instance produces a different warning, due to that constraint
81 -- GCompare instance produces a different warning, due to that constraint
82− -- being present in the original class definition.
82+ -- being present in the original class definition
83
83
84− --mergeG :: GCompare k => (forall a. q a -> Event (Pure t) (v a))
84+ --merge :: GCompare k => DMap k (Event (Pure t)) -> Event (Pure t) (DMap k Identity)
85− -- -> DMap k q -> Event (Pure t) (DMap k v)
86− mergeG nt events = Event $ memo $ \t ->
85+ merge events = Event $ memo $ \t ->
87− let currentOccurrences = DMap.mapMaybeWithKey (\_ q -> case nt q of Event a -> a t) events
86+ let currentOccurrences = DMap.mapMaybeWithKey (\_ (Event a) -> Identity <$> a t) events
88 in if DMap.null currentOccurrences
87 in if DMap.null currentOccurrences
89 then Nothing
88 then Nothing
90 else Just currentOccurrences
89 else Just currentOccurrences
91
90
92−-- The instance signature doeesn't compile, leave commented for documentation
93−-- fanG :: GCompare k => Event (Pure t) (DMap k v) -> EventSelectorG (Pure t) k v
91+ fan :: GCompare k => Event (Pure t) (DMap k Identity) -> EventSelector (Pure t) k
94− fanG e = EventSelectorG $ \k -> Event $ \t -> unEvent e t >>= DMap.lookup k
92+ fan e = EventSelector $ \k -> Event $ \t -> unEvent e t >>= fmap runIdentity . DMap.lookup k
95
93
96 switch :: Behavior (Pure t) (Event (Pure t) a) -> Event (Pure t) a
94 switch :: Behavior (Pure t) (Event (Pure t) a) -> Event (Pure t) a
97 switch b = Event $ memo $ \t -> unEvent (unBehavior b t) t
95 switch b = Event $ memo $ \t -> unEvent (unBehavior b t) t
@@ -114,8 +112,8 @@ instance (Enum t, HasTrie t, Ord t) => Reflex (Pure t) where
114 --a) -> Incremental (Pure t) p a
112 --a) -> Incremental (Pure t) p a
115 unsafeBuildIncremental readV0 p = Incremental $ \t -> (readV0 t, unEvent p t)
113 unsafeBuildIncremental readV0 p = Incremental $ \t -> (readV0 t, unEvent p t)
116
114
117− mergeIncrementalG = mergeIncrementalImpl
115+ mergeIncremental = mergeIncrementalImpl
118− mergeIncrementalWithMoveG = mergeIncrementalImpl
116+ mergeIncrementalWithMove = mergeIncrementalImpl
119
117
120 currentIncremental i = Behavior $ \t -> fst $ unIncremental i t
118 currentIncremental i = Behavior $ \t -> fst $ unIncremental i t
121
119
@@ -130,17 +128,14 @@ instance (Enum t, HasTrie t, Ord t) => Reflex (Pure t) where
130 behaviorCoercion Coercion = Coercion
128 behaviorCoercion Coercion = Coercion
131 eventCoercion Coercion = Coercion
129 eventCoercion Coercion = Coercion
132 dynamicCoercion Coercion = Coercion
130 dynamicCoercion Coercion = Coercion
133− incrementalCoercion Coercion Coercion = Coercion
134
131
135 fanInt e = EventSelectorInt $ \k -> Event $ \t -> unEvent e t >>= IntMap.lookup k
132 fanInt e = EventSelectorInt $ \k -> Event $ \t -> unEvent e t >>= IntMap.lookup k
136
133
137 mergeIntIncremental = mergeIntIncrementalImpl
134 mergeIntIncremental = mergeIntIncrementalImpl
138
135
139−mergeIncrementalImpl :: (PatchTarget p ~ DMap k q, GCompare k)
136+mergeIncrementalImpl :: (PatchTarget p ~ DMap k (Event (Pure t)), GCompare k) => Incremental (Pure t) p -> Event (Pure t) (DMap k Identity)
140− => (forall a. q a -> Event (Pure t) (v a))
141− -> Incremental (Pure t) p -> Event (Pure t) (DMap k v)
142−mergeIncrementalImpl nt i = Event $ \t ->
137+mergeIncrementalImpl i = Event $ \t ->
143− let results = DMap.mapMaybeWithKey (\_ q -> case nt q of Event e -> e t) $ fst $ unIncremental i t
138+ let results = DMap.mapMaybeWithKey (\_ (Event e) -> Identity <$> e t) $ fst $ unIncremental i t
144 in if DMap.null results
139 in if DMap.null results
145 then Nothing
140 then Nothing
146 else Just results
141 else Just results
@@ -211,7 +206,3 @@ instance (Enum t, HasTrie t, Ord t) => MonadHold (Pure t) ((->) t) where
211 Just x -> fromMaybe lastValue $ apply x lastValue
206 Just x -> fromMaybe lastValue $ apply x lastValue
212
207
213 headE = slowHeadE
208 headE = slowHeadE
214− now t = Event $ guard . (t ==)
215−
216−
217−
src/Reflex/Query/Base.hs+5−15
@@ -1,6 +1,7 @@
1{-# LANGUAGE FlexibleInstances #-}
1{-# LANGUAGE FlexibleInstances #-}
2{-# LANGUAGE GeneralizedNewtypeDeriving #-}
2{-# LANGUAGE GeneralizedNewtypeDeriving #-}
3{-# LANGUAGE InstanceSigs #-}
3{-# LANGUAGE InstanceSigs #-}
4+{-# LANGUAGE KindSignatures #-}
4{-# LANGUAGE LambdaCase #-}
5{-# LANGUAGE LambdaCase #-}
5{-# LANGUAGE MultiParamTypeClasses #-}
6{-# LANGUAGE MultiParamTypeClasses #-}
6{-# LANGUAGE RankNTypes #-}
7{-# LANGUAGE RankNTypes #-}
@@ -16,25 +17,21 @@ module Reflex.Query.Base
16 , mapQueryResult
17 , mapQueryResult
17 , dynWithQueryT
18 , dynWithQueryT
18 , withQueryT
19 , withQueryT
19− , mapQueryT
20 ) where
20 ) where
21
21
22import Control.Applicative (liftA2)
22import Control.Applicative (liftA2)
23import Control.Monad.Exception
23import Control.Monad.Exception
24import Control.Monad.Fix
24import Control.Monad.Fix
25−import Control.Monad.Morph
26import Control.Monad.Primitive
25import Control.Monad.Primitive
27import Control.Monad.Reader
26import Control.Monad.Reader
28import Control.Monad.Ref
27import Control.Monad.Ref
29import Control.Monad.State.Strict
28import Control.Monad.State.Strict
30import Data.Align
29import Data.Align
31−import Data.Dependent.Map (DMap)
30+import Data.Dependent.Map (DMap, DSum (..))
32import qualified Data.Dependent.Map as DMap
31import qualified Data.Dependent.Map as DMap
33−import Data.Dependent.Sum (DSum(..))
34import Data.Foldable
32import Data.Foldable
35import Data.Functor.Compose
33import Data.Functor.Compose
36import Data.Functor.Misc
34import Data.Functor.Misc
37−import Data.GADT.Compare (GCompare)
38import Data.IntMap (IntMap)
35import Data.IntMap (IntMap)
39import qualified Data.IntMap as IntMap
36import qualified Data.IntMap as IntMap
40import Data.Map (Map)
37import Data.Map (Map)
@@ -50,7 +47,7 @@ import Reflex.DynamicWriter.Class
50import Reflex.EventWriter.Base
47import Reflex.EventWriter.Base
51import Reflex.EventWriter.Class
48import Reflex.EventWriter.Class
52import Reflex.Host.Class
49import Reflex.Host.Class
53−import qualified Data.Patch.MapWithMove as MapWithMove
50+import qualified Reflex.Patch.MapWithMove as MapWithMove
54import Reflex.PerformEvent.Class
51import Reflex.PerformEvent.Class
55import Reflex.PostBuild.Class
52import Reflex.PostBuild.Class
56import Reflex.Query.Class
53import Reflex.Query.Class
@@ -138,7 +135,7 @@ instance (Reflex t, MonadFix m, Group q, Additive q, Query q, Eq q, MonadHold t
138 tellQueryIncremental $ unsafeBuildIncremental (fold <$> mapM sampleBs liftedBs0) qpatch
135 tellQueryIncremental $ unsafeBuildIncremental (fold <$> mapM sampleBs liftedBs0) qpatch
139 return (liftedResult0, liftedResult')
136 return (liftedResult0, liftedResult')
140
137
141− traverseDMapWithKeyWithAdjust :: forall (k :: * -> *) v v'. (GCompare k) => (forall a. k a -> v a -> QueryT t q m (v' a)) -> DMap k v -> Event t (PatchDMap k v) -> QueryT t q m (DMap k v', Event t (PatchDMap k v'))
138+ traverseDMapWithKeyWithAdjust :: forall (k :: * -> *) v v'. (DMap.GCompare k) => (forall a. k a -> v a -> QueryT t q m (v' a)) -> DMap k v -> Event t (PatchDMap k v) -> QueryT t q m (DMap k v', Event t (PatchDMap k v'))
142 traverseDMapWithKeyWithAdjust f dm0 dm' = do
139 traverseDMapWithKeyWithAdjust f dm0 dm' = do
143 let f' :: forall a. k a -> v a -> EventWriterT t q (ReaderT (Dynamic t (QueryResult q)) m) (Compose (QueryTLoweredResult t q) v' a)
140 let f' :: forall a. k a -> v a -> EventWriterT t q (ReaderT (Dynamic t (QueryResult q)) m) (Compose (QueryTLoweredResult t q) v' a)
144 f' k v = fmap (Compose . QueryTLoweredResult) $ flip runStateT [] $ unQueryT $ f k v
141 f' k v = fmap (Compose . QueryTLoweredResult) $ flip runStateT [] $ unQueryT $ f k v
@@ -183,7 +180,7 @@ instance (Reflex t, MonadFix m, Group q, Additive q, Query q, Eq q, MonadHold t
183 tellQueryIncremental $ unsafeBuildIncremental (fold <$> mapM sampleBs liftedBs0) qpatch
180 tellQueryIncremental $ unsafeBuildIncremental (fold <$> mapM sampleBs liftedBs0) qpatch
184 return (liftedResult0, liftedResult')
181 return (liftedResult0, liftedResult')
185
182
186− traverseDMapWithKeyWithAdjustWithMove :: forall (k :: * -> *) v v'. (GCompare k) => (forall a. k a -> v a -> QueryT t q m (v' a)) -> DMap k v -> Event t (PatchDMapWithMove k v) -> QueryT t q m (DMap k v', Event t (PatchDMapWithMove k v'))
183+ traverseDMapWithKeyWithAdjustWithMove :: forall (k :: * -> *) v v'. (DMap.GCompare k) => (forall a. k a -> v a -> QueryT t q m (v' a)) -> DMap k v -> Event t (PatchDMapWithMove k v) -> QueryT t q m (DMap k v', Event t (PatchDMapWithMove k v'))
187 traverseDMapWithKeyWithAdjustWithMove f dm0 dm' = do
184 traverseDMapWithKeyWithAdjustWithMove f dm0 dm' = do
188 let f' :: forall a. k a -> v a -> EventWriterT t q (ReaderT (Dynamic t (QueryResult q)) m) (Compose (QueryTLoweredResult t q) v' a)
185 let f' :: forall a. k a -> v a -> EventWriterT t q (ReaderT (Dynamic t (QueryResult q)) m) (Compose (QueryTLoweredResult t q) v' a)
189 f' k v = fmap (Compose . QueryTLoweredResult) $ flip runStateT [] $ unQueryT $ f k v
186 f' k v = fmap (Compose . QueryTLoweredResult) $ flip runStateT [] $ unQueryT $ f k v
@@ -240,9 +237,6 @@ instance (Reflex t, MonadFix m, Group q, Additive q, Query q, Eq q, MonadHold t
240instance MonadTrans (QueryT t q) where
237instance MonadTrans (QueryT t q) where
241 lift = QueryT . lift . lift . lift
238 lift = QueryT . lift . lift . lift
242
239
243−instance MFunctor (QueryT t q) where
244− hoist = mapQueryT
245−
246instance PrimMonad m => PrimMonad (QueryT t q m) where
240instance PrimMonad m => PrimMonad (QueryT t q m) where
247 type PrimState (QueryT t q m) = PrimState m
241 type PrimState (QueryT t q m) = PrimState m
248 primitive = lift . primitive
242 primitive = lift . primitive
@@ -294,10 +288,6 @@ withQueryT f a = do
294 (fmapCheap (AdditivePatch . mapQuery f . unAdditivePatch) $ updatedIncremental q)
288 (fmapCheap (AdditivePatch . mapQuery f . unAdditivePatch) $ updatedIncremental q)
295 return result
289 return result
296
290
297−-- | Maps a function over a 'QueryT' that can change the underlying monad
298−mapQueryT :: (forall b. m b -> n b) -> QueryT t q m a -> QueryT t q n a
299−mapQueryT f (QueryT a) = QueryT $ mapStateT (mapEventWriterT (mapReaderT f)) a
300−
301-- | dynWithQueryT's (Dynamic t QueryMorphism) argument needs to be a group homomorphism at all times in order to behave correctly
291-- | dynWithQueryT's (Dynamic t QueryMorphism) argument needs to be a group homomorphism at all times in order to behave correctly
302dynWithQueryT :: (MonadFix m, PostBuild t m, Group q, Additive q, Group q', Additive q', Query q')
292dynWithQueryT :: (MonadFix m, PostBuild t m, Group q, Additive q, Group q', Additive q', Query q')
303 => Dynamic t (QueryMorphism q q')
293 => Dynamic t (QueryMorphism q q')
src/Reflex/Query/Class.hs+5−44
@@ -1,9 +1,9 @@
1−{-# LANGUAGE CPP #-}
2{-# LANGUAGE DeriveDataTypeable #-}
1{-# LANGUAGE DeriveDataTypeable #-}
3{-# LANGUAGE FlexibleContexts #-}
2{-# LANGUAGE FlexibleContexts #-}
4{-# LANGUAGE FlexibleInstances #-}
3{-# LANGUAGE FlexibleInstances #-}
5{-# LANGUAGE FunctionalDependencies #-}
4{-# LANGUAGE FunctionalDependencies #-}
6{-# LANGUAGE GeneralizedNewtypeDeriving #-}
5{-# LANGUAGE GeneralizedNewtypeDeriving #-}
6+{-# LANGUAGE MultiParamTypeClasses #-}
7{-# LANGUAGE TypeFamilies #-}
7{-# LANGUAGE TypeFamilies #-}
8{-# LANGUAGE UndecidableInstances #-}
8{-# LANGUAGE UndecidableInstances #-}
9-- |
9-- |
@@ -22,7 +22,6 @@ module Reflex.Query.Class
22 , MonadQuery (..)
22 , MonadQuery (..)
23 , tellQueryDyn
23 , tellQueryDyn
24 , queryDyn
24 , queryDyn
25− , subQuery
26 , mapQuery
25 , mapQuery
27 , mapQueryResult
26 , mapQueryResult
28 ) where
27 ) where
@@ -37,9 +36,6 @@ import Data.Map.Monoidal (MonoidalMap)
37import qualified Data.Map.Monoidal as MonoidalMap
36import qualified Data.Map.Monoidal as MonoidalMap
38import Data.Semigroup (Semigroup(..))
37import Data.Semigroup (Semigroup(..))
39import Foreign.Storable
38import Foreign.Storable
40−import Data.Void
41−import Data.Monoid hiding ((<>))
42−import Control.Applicative
43
39
44import Reflex.Class
40import Reflex.Class
45
41
@@ -55,37 +51,6 @@ instance (Ord k, Query v) => Query (MonoidalMap k v) where
55 type QueryResult (MonoidalMap k v) = MonoidalMap k (QueryResult v)
51 type QueryResult (MonoidalMap k v) = MonoidalMap k (QueryResult v)
56 crop q r = MonoidalMap.intersectionWith (flip crop) r q
52 crop q r = MonoidalMap.intersectionWith (flip crop) r q
57
53
58−-- | the result of two queries is both results.
59−instance (Query a, Query b) => Query (a, b) where
60− type QueryResult (a, b) = (QueryResult a, QueryResult b)
61− crop (x, x') (y, y') = (crop x y, crop x' y')
62−
63−-- | Trivial queries have trivial results.
64−instance Query () where
65− type QueryResult () = ()
66− crop _ _ = ()
67−
68−-- | The result of an absurd query is trivial; If you can ask the question, the
69−-- answer cannot tell you anything you didn't already know.
70−--
71−-- 'QueryResult Void = @Void@' seems like it would also work, but that has
72−-- problems of robustness. In some applications, an unasked question can still
73−-- be answered, so it is important that the result is inhabited even when the
74−-- question isn't. Applications that wish to prevent this can mandate that the
75−-- query result be paired with the query: then the whole response will be
76−-- uninhabited as desired.
77−instance Query Void where
78− type QueryResult Void = ()
79− crop = absurd
80−
81−#if MIN_VERSION_base(4,12,0)
82−-- | We can lift queries into monoidal containers.
83−-- But beware of Applicatives whose monoid is different from (pure mempty, liftA2 mappend)
84−instance (Query q, Applicative f) => Query (Ap f q) where
85− type QueryResult (Ap f q) = Ap f (QueryResult q)
86− crop = liftA2 crop
87−#endif
88−
89-- | QueryMorphism's must be group homomorphisms when acting on the query type
54-- | QueryMorphism's must be group homomorphisms when acting on the query type
90-- and compatible with the query relationship when acting on the query result.
55-- and compatible with the query relationship when acting on the query result.
91data QueryMorphism q q' = QueryMorphism
56data QueryMorphism q q' = QueryMorphism
@@ -125,7 +90,7 @@ instance Group SelectedCount where
125
90
126instance Additive SelectedCount
91instance Additive SelectedCount
127
92
128−-- | The Semigroup\/Monoid\/Group instances for a Query containing 'SelectedCount's should use
93+-- | The Semigroup/Monoid/Group instances for a Query containing 'SelectedCount's should use
129-- this function which returns Nothing if the result is 0. This allows the pruning of leaves
94-- this function which returns Nothing if the result is 0. This allows the pruning of leaves
130-- of the 'Query' that are no longer wanted.
95-- of the 'Query' that are no longer wanted.
131combineSelectedCounts :: SelectedCount -> SelectedCount -> Maybe SelectedCount
96combineSelectedCounts :: SelectedCount -> SelectedCount -> Maybe SelectedCount
@@ -133,12 +98,12 @@ combineSelectedCounts (SelectedCount i) (SelectedCount j) = if i == negate j the
133
98
134-- | A class that allows sending of 'Query's and retrieval of 'QueryResult's. See 'queryDyn' for a commonly
99-- | A class that allows sending of 'Query's and retrieval of 'QueryResult's. See 'queryDyn' for a commonly
135-- used interface.
100-- used interface.
136−class (Group q, Additive q, Query q, Monad m) => MonadQuery t q m | m -> q t where
101+class (Group q, Additive q, Query q) => MonadQuery t q m | m -> q t where
137 tellQueryIncremental :: Incremental t (AdditivePatch q) -> m ()
102 tellQueryIncremental :: Incremental t (AdditivePatch q) -> m ()
138 askQueryResult :: m (Dynamic t (QueryResult q))
103 askQueryResult :: m (Dynamic t (QueryResult q))
139 queryIncremental :: Incremental t (AdditivePatch q) -> m (Dynamic t (QueryResult q))
104 queryIncremental :: Incremental t (AdditivePatch q) -> m (Dynamic t (QueryResult q))
140
105
141−instance MonadQuery t q m => MonadQuery t q (ReaderT r m) where
106+instance (Monad m, MonadQuery t q m) => MonadQuery t q (ReaderT r m) where
142 tellQueryIncremental = lift . tellQueryIncremental
107 tellQueryIncremental = lift . tellQueryIncremental
143 askQueryResult = lift askQueryResult
108 askQueryResult = lift askQueryResult
144 queryIncremental = lift . queryIncremental
109 queryIncremental = lift . queryIncremental
@@ -148,11 +113,7 @@ tellQueryDyn :: (Reflex t, MonadQuery t q m) => Dynamic t q -> m ()
148tellQueryDyn d = tellQueryIncremental $ unsafeBuildIncremental (sample (current d)) $ attachWith (\old new -> AdditivePatch $ new ~~ old) (current d) (updated d)
113tellQueryDyn d = tellQueryIncremental $ unsafeBuildIncremental (sample (current d)) $ attachWith (\old new -> AdditivePatch $ new ~~ old) (current d) (updated d)
149
114
150-- | Retrieve 'Dynamic'ally updating 'QueryResult's for a 'Dynamic'ally updating 'Query'.
115-- | Retrieve 'Dynamic'ally updating 'QueryResult's for a 'Dynamic'ally updating 'Query'.
151−queryDyn :: (Reflex t, MonadQuery t q m) => Dynamic t q -> m (Dynamic t (QueryResult q))
116+queryDyn :: (Reflex t, Monad m, MonadQuery t q m) => Dynamic t q -> m (Dynamic t (QueryResult q))
152queryDyn q = do
117queryDyn q = do
153 tellQueryDyn q
118 tellQueryDyn q
154 zipDynWith crop q <$> askQueryResult
119 zipDynWith crop q <$> askQueryResult
155−
156−-- | Use a query morphism to operate on a smaller version of a query.
157−subQuery :: (Reflex t, MonadQuery t q2 m) => QueryMorphism q1 q2 -> Dynamic t q1 -> m (Dynamic t (QueryResult q1))
158−subQuery (QueryMorphism f g) x = fmap g <$> queryDyn (fmap f x)
src/Reflex/Requester/Base.hs+27−97
@@ -1,7 +1,6 @@
1-- | This module provides 'RequesterT', the standard implementation of
1-- | This module provides 'RequesterT', the standard implementation of
2-- 'Requester'.
2-- 'Requester'.
3{-# LANGUAGE AllowAmbiguousTypes #-}
3{-# LANGUAGE AllowAmbiguousTypes #-}
4−{-# LANGUAGE ApplicativeDo #-}
5{-# LANGUAGE CPP #-}
4{-# LANGUAGE CPP #-}
6{-# LANGUAGE EmptyDataDecls #-}
5{-# LANGUAGE EmptyDataDecls #-}
7{-# LANGUAGE ExistentialQuantification #-}
6{-# LANGUAGE ExistentialQuantification #-}
@@ -33,7 +32,6 @@ module Reflex.Requester.Base
33 , requesterDataToList
32 , requesterDataToList
34 , singletonRequesterData
33 , singletonRequesterData
35 , matchResponsesWithRequests
34 , matchResponsesWithRequests
36− , matchResponseMapWithRequests
37 , multiEntry
35 , multiEntry
38 , unMultiEntry
36 , unMultiEntry
39 , requesting'
37 , requesting'
@@ -51,17 +49,14 @@ import Reflex.TriggerEvent.Class
51import Control.Applicative (liftA2)
49import Control.Applicative (liftA2)
52import Control.Monad.Exception
50import Control.Monad.Exception
53import Control.Monad.Identity
51import Control.Monad.Identity
54−import Control.Monad.Morph
55import Control.Monad.Primitive
52import Control.Monad.Primitive
56import Control.Monad.Reader
53import Control.Monad.Reader
57import Control.Monad.Ref
54import Control.Monad.Ref
58import Control.Monad.State.Strict
55import Control.Monad.State.Strict
59import Data.Bits
56import Data.Bits
60import Data.Coerce
57import Data.Coerce
61−import Data.Constraint
62−import Data.Dependent.Map (DMap)
58+import Data.Dependent.Map (DMap, DSum (..))
63import qualified Data.Dependent.Map as DMap
59import qualified Data.Dependent.Map as DMap
64−import Data.Dependent.Sum (DSum (..))
65import Data.Functor.Compose
60import Data.Functor.Compose
66import Data.Functor.Misc
61import Data.Functor.Misc
67import Data.IntMap.Strict (IntMap)
62import Data.IntMap.Strict (IntMap)
@@ -84,51 +79,19 @@ newtype TagMap (f :: * -> *) = TagMap (IntMap Any)
84
79
85newtype RequesterData f = RequesterData (TagMap (Entry f))
80newtype RequesterData f = RequesterData (TagMap (Entry f))
86
81
87−emptyRequesterData :: RequesterData f
88−emptyRequesterData = RequesterData $ TagMap IntMap.empty
89−
90data RequesterDataKey a where
82data RequesterDataKey a where
91 RequesterDataKey_Single :: {-# UNPACK #-} !(MyTag (Single a)) -> RequesterDataKey a
83 RequesterDataKey_Single :: {-# UNPACK #-} !(MyTag (Single a)) -> RequesterDataKey a
92 RequesterDataKey_Multi :: {-# UNPACK #-} !(MyTag Multi) -> {-# UNPACK #-} !Int -> !(RequesterDataKey a) -> RequesterDataKey a --TODO: Don't put a second Int here (or in the other Multis); use a single Int instead
84 RequesterDataKey_Multi :: {-# UNPACK #-} !(MyTag Multi) -> {-# UNPACK #-} !Int -> !(RequesterDataKey a) -> RequesterDataKey a --TODO: Don't put a second Int here (or in the other Multis); use a single Int instead
93− RequesterDataKey_Multi2 :: GCompare k => {-# UNPACK #-} !(MyTag (Multi2 k)) -> !(Some k) -> {-# UNPACK #-} !Int -> !(RequesterDataKey a) -> RequesterDataKey a
85+ RequesterDataKey_Multi2 :: {-# UNPACK #-} !(MyTag (Multi2 k)) -> !(Some k) -> {-# UNPACK #-} !Int -> !(RequesterDataKey a) -> RequesterDataKey a
94 RequesterDataKey_Multi3 :: {-# UNPACK #-} !(MyTag Multi3) -> {-# UNPACK #-} !Int -> {-# UNPACK #-} !Int -> !(RequesterDataKey a) -> RequesterDataKey a
86 RequesterDataKey_Multi3 :: {-# UNPACK #-} !(MyTag Multi3) -> {-# UNPACK #-} !Int -> {-# UNPACK #-} !Int -> !(RequesterDataKey a) -> RequesterDataKey a
95
87
96singletonRequesterData :: RequesterDataKey a -> f a -> RequesterData f
88singletonRequesterData :: RequesterDataKey a -> f a -> RequesterData f
97singletonRequesterData rdk v = case rdk of
89singletonRequesterData rdk v = case rdk of
98 RequesterDataKey_Single k -> RequesterData $ singletonTagMap k $ Entry v
90 RequesterDataKey_Single k -> RequesterData $ singletonTagMap k $ Entry v
99 RequesterDataKey_Multi k k' k'' -> RequesterData $ singletonTagMap k $ Entry $ IntMap.singleton k' $ singletonRequesterData k'' v
91 RequesterDataKey_Multi k k' k'' -> RequesterData $ singletonTagMap k $ Entry $ IntMap.singleton k' $ singletonRequesterData k'' v
100− RequesterDataKey_Multi2 k k' k'' k''' -> RequesterData $ singletonTagMap k $ Entry $ Multi2Contents
92+ RequesterDataKey_Multi2 k k' k'' k''' -> RequesterData $ singletonTagMap k $ Entry $ Map.singleton k' $ IntMap.singleton k'' $ singletonRequesterData k''' v
101− { _multi2Contents_values = Map.singleton k' $ IntMap.singleton k'' $ singletonRequesterData k''' v
102− , _multi2Contents_dict = Dict
103− }
104 RequesterDataKey_Multi3 k k' k'' k''' -> RequesterData $ singletonTagMap k $ Entry $ IntMap.singleton k' $ IntMap.singleton k'' $ singletonRequesterData k''' v
93 RequesterDataKey_Multi3 k k' k'' k''' -> RequesterData $ singletonTagMap k $ Entry $ IntMap.singleton k' $ IntMap.singleton k'' $ singletonRequesterData k''' v
105
94
106−mergeRequesterData :: RequesterData f -> RequesterData f -> RequesterData f
107−mergeRequesterData (RequesterData a) (RequesterData b) = RequesterData $ mergeTagMap a b
108−
109−mergeTagMap :: forall f. TagMap (Entry f) -> TagMap (Entry f) -> TagMap (Entry f)
110−mergeTagMap (TagMap m) (TagMap n) =
111− TagMap $ IntMap.unionWithKey (g' combiner) m n
112− where
113− combiner :: forall a. MyTag a -> Entry f a -> Entry f a -> Entry f a
114− combiner k (Entry a) (Entry b) = Entry $ case myKeyType k of
115− MyTagType_Single -> a
116− MyTagType_Multi -> IntMap.unionWith mergeRequesterData a b
117− MyTagType_Multi2 -> case _multi2Contents_dict a of
118− Dict -> Multi2Contents
119− { _multi2Contents_values = Map.unionWith (IntMap.unionWith mergeRequesterData) (_multi2Contents_values a) (_multi2Contents_values b)
120− , _multi2Contents_dict = Dict
121− }
122− MyTagType_Multi3 -> IntMap.unionWith (IntMap.unionWith mergeRequesterData) a b
123− g' :: (forall a. MyTag a -> Entry f a -> Entry f a -> Entry f a) -> Int -> Any -> Any -> Any
124− g' f rawKey a b =
125− let k = MyTag rawKey :: MyTag a
126− fromAny :: Any -> Entry f a
127− fromAny = unsafeCoerce
128− toAny :: Entry f a -> Any
129− toAny = unsafeCoerce
130− in toAny $ f k (fromAny a) (fromAny b)
131−
132requesterDataToList :: RequesterData f -> [DSum RequesterDataKey f]
95requesterDataToList :: RequesterData f -> [DSum RequesterDataKey f]
133requesterDataToList (RequesterData m) = do
96requesterDataToList (RequesterData m) = do
134 k :=> Entry e <- tagMapToList m
97 k :=> Entry e <- tagMapToList m
@@ -138,12 +101,11 @@ requesterDataToList (RequesterData m) = do
138 (k', e') <- IntMap.toList e
101 (k', e') <- IntMap.toList e
139 k'' :=> e'' <- requesterDataToList e'
102 k'' :=> e'' <- requesterDataToList e'
140 return $ RequesterDataKey_Multi k k' k'' :=> e''
103 return $ RequesterDataKey_Multi k k' k'' :=> e''
141− MyTagType_Multi2 -> case _multi2Contents_dict e of
104+ MyTagType_Multi2 -> do
142− Dict -> do
143− (k', e') <- Map.toList $ _multi2Contents_values e
105+ (k', e') <- Map.toList e
144− (k'', e'') <- IntMap.toList e'
106+ (k'', e'') <- IntMap.toList e'
145− k''' :=> e''' <- requesterDataToList e''
107+ k''' :=> e''' <- requesterDataToList e''
146− return $ RequesterDataKey_Multi2 k k' k'' k''' :=> e'''
108+ return $ RequesterDataKey_Multi2 k k' k'' k''' :=> e'''
147 MyTagType_Multi3 -> do
109 MyTagType_Multi3 -> do
148 (k', e') <- IntMap.toList e
110 (k', e') <- IntMap.toList e
149 (k'', e'') <- IntMap.toList e'
111 (k'', e'') <- IntMap.toList e'
@@ -171,13 +133,7 @@ traverseRequesterData f (RequesterData m) = RequesterData <$> traverseTagMapWith
171 go k (Entry request) = Entry <$> case myKeyType k of
133 go k (Entry request) = Entry <$> case myKeyType k of
172 MyTagType_Single -> f request
134 MyTagType_Single -> f request
173 MyTagType_Multi -> traverse (traverseRequesterData f) request
135 MyTagType_Multi -> traverse (traverseRequesterData f) request
174− MyTagType_Multi2 -> case request of
175− Multi2Contents { _multi2Contents_values = request', _multi2Contents_dict = Dict } -> do
176− v <- traverse (traverse (traverseRequesterData f)) request'
136+ MyTagType_Multi2 -> traverse (traverse (traverseRequesterData f)) request
177− pure $ Multi2Contents
178− { _multi2Contents_values = v
179− , _multi2Contents_dict = Dict
180− }
181 MyTagType_Multi3 -> traverse (traverse (traverseRequesterData f)) request
137 MyTagType_Multi3 -> traverse (traverse (traverseRequesterData f)) request
182
138
183-- | 'traverseRequesterData' with its arguments flipped
139-- | 'traverseRequesterData' with its arguments flipped
@@ -221,14 +177,9 @@ instance MyTagTypeOffset Multi3 where
221type family EntryContents request a where
177type family EntryContents request a where
222 EntryContents request (Single a) = request a
178 EntryContents request (Single a) = request a
223 EntryContents request Multi = IntMap (RequesterData request)
179 EntryContents request Multi = IntMap (RequesterData request)
224− EntryContents request (Multi2 k) = Multi2Contents k request
180+ EntryContents request (Multi2 k) = Map (Some k) (IntMap (RequesterData request))
225 EntryContents request Multi3 = IntMap (IntMap (RequesterData request))
181 EntryContents request Multi3 = IntMap (IntMap (RequesterData request))
226
182
227−data Multi2Contents k request = Multi2Contents
228− { _multi2Contents_dict :: {-# UNPACK #-} !(Dict (GCompare k)) -- This is a Dict instead of an existential context because we only want to use it in certain circumstances
229− , _multi2Contents_values :: {-# UNPACK #-} !(Map (Some k) (IntMap (RequesterData request)))
230− }
231−
232newtype Entry request x = Entry { unEntry :: EntryContents request x }
183newtype Entry request x = Entry { unEntry :: EntryContents request x }
233
184
234{-# INLINE singleEntry #-}
185{-# INLINE singleEntry #-}
@@ -357,7 +308,7 @@ tagRequest req = do
357 return t
308 return t
358
309
359{-# INLINE responseFromTag #-}
310{-# INLINE responseFromTag #-}
360−responseFromTag :: forall m t request response x. Monad m => MyTagWrap response (Entry response x) -> RequesterT t request response m (Event t (Entry response x))
311+responseFromTag :: Monad m => MyTagWrap response (Entry response x) -> RequesterT t request response m (Event t (Entry response x))
361responseFromTag (MyTagWrap t) = do
312responseFromTag (MyTagWrap t) = do
362 responses :: EventSelectorInt t Any <- RequesterT ask
313 responses :: EventSelectorInt t Any <- RequesterT ask
363 return $ (unsafeCoerce :: Event t Any -> Event t (Entry response x)) $ selectInt responses t
314 return $ (unsafeCoerce :: Event t Any -> Event t (Entry response x)) $ selectInt responses t
@@ -365,9 +316,6 @@ responseFromTag (MyTagWrap t) = do
365instance MonadTrans (RequesterT t request response) where
316instance MonadTrans (RequesterT t request response) where
366 lift = RequesterT . lift . lift
317 lift = RequesterT . lift . lift
367
318
368−instance MFunctor (RequesterT t request response) where
369− hoist f = RequesterT . hoist (hoist f) . unRequesterT
370−
371instance PerformEvent t m => PerformEvent t (RequesterT t request response m) where
319instance PerformEvent t m => PerformEvent t (RequesterT t request response m) where
372 type Performable (RequesterT t request response m) = Performable m
320 type Performable (RequesterT t request response m) = Performable m
373 performEvent_ = lift . performEvent_
321 performEvent_ = lift . performEvent_
@@ -487,9 +435,9 @@ traverseDMapWithKeyWithAdjustRequesterTWith base mapPatch weakenPatchWith patchN
487 let responses :: EventSelector t (Const2 (Some k) (IntMap (RequesterData response)))
435 let responses :: EventSelector t (Const2 (Some k) (IntMap (RequesterData response)))
488 responses = fanMap $ fmapCheap unpack response
436 responses = fanMap $ fmapCheap unpack response
489 unpack :: Entry response (Multi2 k) -> Map (Some k) (IntMap (RequesterData response))
437 unpack :: Entry response (Multi2 k) -> Map (Some k) (IntMap (RequesterData response))
490− unpack = _multi2Contents_values . unEntry
438+ unpack = unEntry
491 pack :: Map (Some k) (IntMap (RequesterData request)) -> Entry request (Multi2 k)
439 pack :: Map (Some k) (IntMap (RequesterData request)) -> Entry request (Multi2 k)
492− pack m = Entry $ Multi2Contents { _multi2Contents_values = m, _multi2Contents_dict = Dict }
440+ pack = Entry
493 f' :: forall a. k a -> Compose ((,) Int) v a -> m (Compose ((,) (Event t (IntMap (RequesterData request)))) v' a)
441 f' :: forall a. k a -> Compose ((,) Int) v a -> m (Compose ((,) (Event t (IntMap (RequesterData request)))) v' a)
494 f' k (Compose (n, v)) = do
442 f' k (Compose (n, v)) = do
495 (result, myRequests) <- runRequesterT (f k v) $ mapMaybeCheap (IntMap.lookup n) $ select responses (Const2 (Some k))
443 (result, myRequests) <- runRequesterT (f k v) $ mapMaybeCheap (IntMap.lookup n) $ select responses (Const2 (Some k))
@@ -510,30 +458,10 @@ traverseDMapWithKeyWithAdjustRequesterTWith base mapPatch weakenPatchWith patchN
510data Decoder rawResponse response =
458data Decoder rawResponse response =
511 forall a. Decoder (RequesterDataKey a) (rawResponse -> response a)
459 forall a. Decoder (RequesterDataKey a) (rawResponse -> response a)
512
460
513−matchResponsesWithRequests
514− :: forall t rawRequest rawResponse request response m.
515− ( MonadFix m
516− , MonadHold t m
517− , Reflex t
518− )
519− => (forall a. request a -> (rawRequest, rawResponse -> response a))
520− -- ^ Given a request (from 'Requester'), produces the wire format of the
521− -- request and a function used to process the associated response
522− -> Event t (RequesterData request)
523− -- ^ The outgoing requests
524− -> Event t (Int, rawResponse)
525− -- ^ The incoming responses, tagged by an identifying key
526− -> m ( Event t (Map Int rawRequest)
527− , Event t (RequesterData response)
528− )
529− -- ^ A map of outgoing wire-format requests and an event of responses keyed
530− -- by the 'RequesterData' key of the associated outgoing request
531−matchResponsesWithRequests f send recv = matchResponseMapWithRequests f send $ uncurry Map.singleton <$> recv
532−
533-- | Matches incoming responses with previously-sent requests
461-- | Matches incoming responses with previously-sent requests
534-- and uses the provided request "decoder" function to process
462-- and uses the provided request "decoder" function to process
535-- incoming responses.
463-- incoming responses.
536−matchResponseMapWithRequests
464+matchResponsesWithRequests
537 :: forall t rawRequest rawResponse request response m.
465 :: forall t rawRequest rawResponse request response m.
538 ( MonadFix m
466 ( MonadFix m
539 , MonadHold t m
467 , MonadHold t m
@@ -544,14 +472,14 @@ matchResponseMapWithRequests
544 -- request and a function used to process the associated response
472 -- request and a function used to process the associated response
545 -> Event t (RequesterData request)
473 -> Event t (RequesterData request)
546 -- ^ The outgoing requests
474 -- ^ The outgoing requests
547− -> Event t (Map Int rawResponse)
475+ -> Event t (Int, rawResponse)
548− -- ^ A map of incoming responses, tagged by an identifying key
476+ -- ^ The incoming responses, tagged by an identifying key
549 -> m ( Event t (Map Int rawRequest)
477 -> m ( Event t (Map Int rawRequest)
550 , Event t (RequesterData response)
478 , Event t (RequesterData response)
551 )
479 )
552 -- ^ A map of outgoing wire-format requests and an event of responses keyed
480 -- ^ A map of outgoing wire-format requests and an event of responses keyed
553 -- by the 'RequesterData' key of the associated outgoing request
481 -- by the 'RequesterData' key of the associated outgoing request
554−matchResponseMapWithRequests f send recv = do
482+matchResponsesWithRequests f send recv = do
555 rec nextId <- hold 1 $ fmap (\(next, _, _) -> next) outgoing
483 rec nextId <- hold 1 $ fmap (\(next, _, _) -> next) outgoing
556 waitingFor :: Incremental t (PatchMap Int (Decoder rawResponse response)) <-
484 waitingFor :: Incremental t (PatchMap Int (Decoder rawResponse response)) <-
557 holdIncremental mempty $ leftmost
485 holdIncremental mempty $ leftmost
@@ -593,15 +521,17 @@ matchResponseMapWithRequests f send recv = do
593 processIncoming
521 processIncoming
594 :: Incremental t (PatchMap Int (Decoder rawResponse response))
522 :: Incremental t (PatchMap Int (Decoder rawResponse response))
595 -- A map of outstanding expected responses
523 -- A map of outstanding expected responses
596− -> Event t (Map Int rawResponse)
524+ -> Event t (Int, rawResponse)
597 -- A incoming response paired with its identifying key
525 -- A incoming response paired with its identifying key
598 -> Event t (RequesterData response, PatchMap Int v)
526 -> Event t (RequesterData response, PatchMap Int v)
599 -- The decoded response and a patch that clears the outstanding responses queue
527 -- The decoded response and a patch that clears the outstanding responses queue
600− processIncoming waitingFor inc = flip push inc $ \rspMap -> do
528+ processIncoming waitingFor inc = flip push inc $ \(n, rawRsp) -> do
601 wf <- sample $ currentIncremental waitingFor
529 wf <- sample $ currentIncremental waitingFor
602− let match rawRsp (Decoder k rspF) =
530+ case Map.lookup n wf of
603− let rsp = rspF rawRsp
531+ Nothing -> return Nothing -- TODO How should lookup failures be handled here? They shouldn't ever happen..
604− in singletonRequesterData k rsp
532+ Just (Decoder k rspF) -> do
605− matches = Map.intersectionWith match rspMap wf
533+ let rsp = rspF rawRsp
606− pure $ if Map.null matches then Nothing else Just
534+ return $ Just
607− (Map.foldl' mergeRequesterData emptyRequesterData matches, PatchMap $ Nothing <$ matches)
535+ ( singletonRequesterData k rsp
536+ , PatchMap $ Map.singleton n Nothing
537+ )
src/Reflex/Requester/Class.hs+1
@@ -6,6 +6,7 @@
6{-# LANGUAGE CPP #-}
6{-# LANGUAGE CPP #-}
7{-# LANGUAGE FlexibleInstances #-}
7{-# LANGUAGE FlexibleInstances #-}
8{-# LANGUAGE FunctionalDependencies #-}
8{-# LANGUAGE FunctionalDependencies #-}
9+{-# LANGUAGE MultiParamTypeClasses #-}
9{-# LANGUAGE RecursiveDo #-}
10{-# LANGUAGE RecursiveDo #-}
10{-# LANGUAGE TypeFamilies #-}
11{-# LANGUAGE TypeFamilies #-}
11{-# LANGUAGE UndecidableInstances #-}
12{-# LANGUAGE UndecidableInstances #-}
src/Reflex/Spider/Internal.hs+421−711
@@ -9,22 +9,17 @@
9{-# LANGUAGE GADTs #-}
9{-# LANGUAGE GADTs #-}
10{-# LANGUAGE GeneralizedNewtypeDeriving #-}
10{-# LANGUAGE GeneralizedNewtypeDeriving #-}
11{-# LANGUAGE LambdaCase #-}
11{-# LANGUAGE LambdaCase #-}
12+{-# LANGUAGE MultiParamTypeClasses #-}
13+{-# LANGUAGE MultiWayIf #-}
12{-# LANGUAGE RankNTypes #-}
14{-# LANGUAGE RankNTypes #-}
13{-# LANGUAGE RoleAnnotations #-}
15{-# LANGUAGE RoleAnnotations #-}
14{-# LANGUAGE ScopedTypeVariables #-}
16{-# LANGUAGE ScopedTypeVariables #-}
15{-# LANGUAGE TypeFamilies #-}
17{-# LANGUAGE TypeFamilies #-}
16{-# LANGUAGE TypeOperators #-}
18{-# LANGUAGE TypeOperators #-}
17{-# LANGUAGE UndecidableInstances #-}
19{-# LANGUAGE UndecidableInstances #-}
18−{-# LANGUAGE PolyKinds #-}
19−{-# LANGUAGE DeriveFunctor #-}
20−{-# LANGUAGE StandaloneDeriving #-}
21−{-# LANGUAGE InstanceSigs #-}
22−{-# LANGUAGE MultiWayIf #-}
23−
24#ifdef USE_REFLEX_OPTIMIZER
20#ifdef USE_REFLEX_OPTIMIZER
25{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
21{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
26#endif
22#endif
27−{-# OPTIONS_GHC -Wunused-binds #-}
28-- | This module is the implementation of the 'Spider' 'Reflex' engine. It uses
23-- | This module is the implementation of the 'Spider' 'Reflex' engine. It uses
29-- a graph traversal algorithm to propagate 'Event's and 'Behavior's.
24-- a graph traversal algorithm to propagate 'Event's and 'Behavior's.
30module Reflex.Spider.Internal (module Reflex.Spider.Internal) where
25module Reflex.Spider.Internal (module Reflex.Spider.Internal) where
@@ -38,17 +33,12 @@ import Control.Monad hiding (forM, forM_, mapM, mapM_)
38import Control.Monad.Exception
33import Control.Monad.Exception
39import Control.Monad.Identity hiding (forM, forM_, mapM, mapM_)
34import Control.Monad.Identity hiding (forM, forM_, mapM, mapM_)
40import Control.Monad.Primitive
35import Control.Monad.Primitive
41−import Control.Monad.Reader.Class
36+import Control.Monad.Reader hiding (forM, forM_, mapM, mapM_)
42−import Control.Monad.IO.Class
43−import Control.Monad.ReaderIO
44import Control.Monad.Ref
37import Control.Monad.Ref
45−import Control.Monad.Fail (MonadFail)
46−import qualified Control.Monad.Fail as MonadFail
47import Data.Align
38import Data.Align
48import Data.Coerce
39import Data.Coerce
49−import Data.Dependent.Map (DMap)
40+import Data.Dependent.Map (DMap, DSum (..))
50import qualified Data.Dependent.Map as DMap
41import qualified Data.Dependent.Map as DMap
51−import Data.Dependent.Sum (DSum (..))
52import Data.FastMutableIntMap (FastMutableIntMap, PatchIntMap (..))
42import Data.FastMutableIntMap (FastMutableIntMap, PatchIntMap (..))
53import qualified Data.FastMutableIntMap as FastMutableIntMap
43import qualified Data.FastMutableIntMap as FastMutableIntMap
54import Data.Foldable hiding (concat, elem, sequence_)
44import Data.Foldable hiding (concat, elem, sequence_)
@@ -59,15 +49,13 @@ import Data.GADT.Compare
59import Data.IntMap.Strict (IntMap)
49import Data.IntMap.Strict (IntMap)
60import qualified Data.IntMap.Strict as IntMap
50import qualified Data.IntMap.Strict as IntMap
61import Data.IORef
51import Data.IORef
62−import Data.Kind (Type)
63import Data.Maybe hiding (mapMaybe)
52import Data.Maybe hiding (mapMaybe)
64−import Data.Monoid (mempty, (<>))
53+import Data.Monoid ((<>))
65import Data.Proxy
54import Data.Proxy
66import Data.These
55import Data.These
67import Data.Traversable
56import Data.Traversable
68−import Data.Type.Equality ((:~:)(Refl))
69import Data.Witherable (Filterable, mapMaybe)
57import Data.Witherable (Filterable, mapMaybe)
70−import GHC.Exts hiding (toList)
58+import GHC.Exts
71import GHC.IORef (IORef (..))
59import GHC.IORef (IORef (..))
72import GHC.Stack
60import GHC.Stack
73import Reflex.FastWeak
61import Reflex.FastWeak
@@ -75,57 +63,39 @@ import System.IO.Unsafe
75import System.Mem.Weak
63import System.Mem.Weak
76import Unsafe.Coerce
64import Unsafe.Coerce
77
65
78−#ifdef MIN_VERSION_semialign
79−#if MIN_VERSION_these(0,8,0)
80−import Data.These.Combinators (justThese)
81−#endif
82−#if MIN_VERSION_semialign(1,1,0)
83−import Data.Zip (Zip (..))
84−#endif
85−#endif
86−
87#ifdef DEBUG_CYCLES
66#ifdef DEBUG_CYCLES
88import Control.Monad.State hiding (forM, forM_, mapM, mapM_, sequence)
67import Control.Monad.State hiding (forM, forM_, mapM, mapM_, sequence)
89−#endif
90−
91import Data.List.NonEmpty (NonEmpty (..), nonEmpty)
68import Data.List.NonEmpty (NonEmpty (..), nonEmpty)
92import qualified Data.List.NonEmpty as NonEmpty
69import qualified Data.List.NonEmpty as NonEmpty
70+import Data.Monoid (mempty)
93import Data.Tree (Forest, Tree (..), drawForest)
71import Data.Tree (Forest, Tree (..), drawForest)
94−import Data.List (isPrefixOf)
72+#endif
95
73
96−import Data.FastWeakBag (FastWeakBag, FastWeakBagTicket)
74+import Data.FastWeakBag (FastWeakBag)
97import qualified Data.FastWeakBag as FastWeakBag
75import qualified Data.FastWeakBag as FastWeakBag
98−
99import Data.Reflection
76import Data.Reflection
100import Data.Some (Some(Some))
77import Data.Some (Some(Some))
101import Data.Type.Coercion
78import Data.Type.Coercion
102−import Data.Profunctor.Unsafe ((#.), (.#))
103import Data.WeakBag (WeakBag, WeakBagTicket, _weakBag_children)
79import Data.WeakBag (WeakBag, WeakBagTicket, _weakBag_children)
104import qualified Data.WeakBag as WeakBag
80import qualified Data.WeakBag as WeakBag
105import qualified Reflex.Class
81import qualified Reflex.Class
106import qualified Reflex.Class as R
82import qualified Reflex.Class as R
107import qualified Reflex.Host.Class
83import qualified Reflex.Host.Class
108import Reflex.NotReady.Class
84import Reflex.NotReady.Class
109−import Data.Patch
85+import Reflex.Patch
110−import qualified Data.Patch.DMapWithMove as PatchDMapWithMove
86+import qualified Reflex.Patch.DMapWithMove as PatchDMapWithMove
111−import Reflex.PerformEvent.Base (PerformEventT)
112
87
113#ifdef DEBUG_TRACE_EVENTS
88#ifdef DEBUG_TRACE_EVENTS
114import qualified Data.ByteString.Char8 as BS8
89import qualified Data.ByteString.Char8 as BS8
115import System.IO (stderr)
90import System.IO (stderr)
116−import Data.List (isPrefixOf)
117#endif
91#endif
118
92
119−-- TODO stdout might not be the best channel for debug output
120−debugStrLn :: String -> IO ()
121−debugStrLn = putStrLn
122−
123#ifdef DEBUG_TRACE_EVENTS
93#ifdef DEBUG_TRACE_EVENTS
94+
124withStackOneLine :: (BS8.ByteString -> a) -> a
95withStackOneLine :: (BS8.ByteString -> a) -> a
125withStackOneLine expr = unsafePerformIO $ do
96withStackOneLine expr = unsafePerformIO $ do
126 stack <- currentCallStack
97 stack <- currentCallStack
127− return (expr . BS8.pack . unwords . dropInternal . reverse $ stack)
98+ return (expr (BS8.pack (unwords (reverse stack))))
128− where dropInternal = filterStack "Reflex.Spider.Internal"
129
99
130#endif
100#endif
131
101
@@ -136,42 +106,28 @@ debugInvalidateHeight :: Bool
136debugInvalidate :: Bool
106debugInvalidate :: Bool
137
107
138#ifdef DEBUG
108#ifdef DEBUG
109+
139#define DEBUG_NODEIDS
110#define DEBUG_NODEIDS
140
111
141−#ifdef DEBUG_TRACE_PROPAGATION
142debugPropagate = True
112debugPropagate = True
143−#else
144−debugPropagate = False
145−#endif
146
113
147−#ifdef DEBUG_TRACE_HEIGHT
148−debugInvalidateHeight = True
149−#else
150debugInvalidateHeight = False
114debugInvalidateHeight = False
151−#endif
152
115
153−#ifdef DEBUG_TRACE_INVALIDATION
154debugInvalidate = True
116debugInvalidate = True
155−#else
156−debugInvalidate = False
157−#endif
158
117
159class HasNodeId a where
118class HasNodeId a where
160 getNodeId :: a -> Int
119 getNodeId :: a -> Int
161
120
162−instance HasNodeId (CacheSubscribed x a) where
121+instance HasNodeId (Hold x p a) where
163− getNodeId = _cacheSubscribed_nodeId
164−
165−instance HasNodeId (FanInt x a) where
166− getNodeId = _fanInt_nodeId
167−
168−instance HasNodeId (Hold x p) where
169 getNodeId = holdNodeId
122 getNodeId = holdNodeId
170
123
124+instance HasNodeId (PushSubscribed x a b) where
125+ getNodeId = pushSubscribedNodeId
126+
171instance HasNodeId (SwitchSubscribed x a) where
127instance HasNodeId (SwitchSubscribed x a) where
172 getNodeId = switchSubscribedNodeId
128 getNodeId = switchSubscribedNodeId
173
129
174−instance HasNodeId (FanSubscribed x v a) where
130+instance HasNodeId (FanSubscribed x a) where
175 getNodeId = fanSubscribedNodeId
131 getNodeId = fanSubscribedNodeId
176
132
177instance HasNodeId (CoincidenceSubscribed x a) where
133instance HasNodeId (CoincidenceSubscribed x a) where
@@ -185,16 +141,41 @@ instance HasNodeId (Pull x a) where
185
141
186{-# INLINE showNodeId #-}
142{-# INLINE showNodeId #-}
187showNodeId :: HasNodeId a => a -> String
143showNodeId :: HasNodeId a => a -> String
188−showNodeId = showNodeId' . getNodeId
144+showNodeId = ("#"<>) . show . getNodeId
189−
145+
190−showNodeId' :: Int -> String
146+showSubscriberType :: Subscriber x a -> String
191−showNodeId' = ("#"<>) . show
147+showSubscriberType = \case
192−
148+ SubscriberPush _ _ -> "SubscriberPush"
149+ SubscriberMerge _ _ -> "SubscriberMerge"
150+ SubscriberFan _ -> "SubscriberFan"
151+ SubscriberMergeChange _ -> "SubscriberMergeChange"
152+ SubscriberHold _ -> "SubscriberHold"
153+ SubscriberHoldIdentity _ -> "SubscriberHoldIdentity"
154+ SubscriberSwitch _ -> "SubscriberSwitch"
155+ SubscriberCoincidenceOuter _ -> "SubscriberCoincidenceOuter"
156+ SubscriberCoincidenceInner _ -> "SubscriberCoincidenceInner"
157+ SubscriberHandle -> "SubscriberHandle"
158+
159+showEventType :: Event x a -> String
160+showEventType = \case
161+ EventRoot _ _ -> "EventRoot"
162+ EventNever -> "EventNever"
163+ EventPush _ -> "EventPush"
164+ EventMerge _ -> "EventMerge"
165+ EventFan _ _ -> "EventFan"
166+ EventSwitch _ -> "EventSwitch"
167+ EventCoincidence _ -> "EventCoincidence"
168+ EventHold _ -> "EventHold"
169+ EventDyn _ -> "EventDyn"
170+ EventHoldIdentity _ -> "EventHoldIdentity"
171+ EventDynIdentity _ -> "EventDynIdentity"
193
172
194#else
173#else
195
174
196debugPropagate = False
175debugPropagate = False
176+
197debugInvalidateHeight = False
177debugInvalidateHeight = False
178+
198debugInvalidate = False
179debugInvalidate = False
199
180
200-- This must be inline, or error messages will cause memory leaks due to retaining the node in question
181-- This must be inline, or error messages will cause memory leaks due to retaining the node in question
@@ -202,10 +183,6 @@ debugInvalidate = False
202showNodeId :: a -> String
183showNodeId :: a -> String
203showNodeId _ = ""
184showNodeId _ = ""
204
185
205−{-# INLINE showNodeId' #-}
206−showNodeId' :: Int -> String
207−showNodeId' _ = ""
208−
209#endif
186#endif
210
187
211#ifdef DEBUG_NODEIDS
188#ifdef DEBUG_NODEIDS
@@ -215,6 +192,12 @@ nextNodeIdRef = unsafePerformIO $ newIORef 1
215
192
216newNodeId :: IO Int
193newNodeId :: IO Int
217newNodeId = atomicModifyIORef' nextNodeIdRef $ \n -> (succ n, n)
194newNodeId = atomicModifyIORef' nextNodeIdRef $ \n -> (succ n, n)
195+
196+{-# NOINLINE unsafeNodeId #-}
197+unsafeNodeId :: a -> Int
198+unsafeNodeId a = unsafePerformIO $ do
199+ touch a
200+ newNodeId
218#endif
201#endif
219
202
220--------------------------------------------------------------------------------
203--------------------------------------------------------------------------------
@@ -251,9 +234,9 @@ subscribeAndRead = unEvent
251-- caching; if the computation function is very cheap, this is (much) more
234-- caching; if the computation function is very cheap, this is (much) more
252-- efficient than 'push'
235-- efficient than 'push'
253{-# INLINE [1] pushCheap #-}
236{-# INLINE [1] pushCheap #-}
254−pushCheap :: HasSpiderTimeline x => (a -> ComputeM x (Maybe b)) -> Event x a -> Event x b
237+pushCheap :: (a -> ComputeM x (Maybe b)) -> Event x a -> Event x b
255pushCheap !f e = Event $ \sub -> do
238pushCheap !f e = Event $ \sub -> do
256− (subscription, occ) <- subscribeAndRead e $ debugSubscriber' "push" $ sub
239+ (subscription, occ) <- subscribeAndRead e $ sub
257 { subscriberPropagate = \a -> do
240 { subscriberPropagate = \a -> do
258 mb <- f a
241 mb <- f a
259 mapM_ (subscriberPropagate sub) mb
242 mapM_ (subscriberPropagate sub) mb
@@ -272,10 +255,10 @@ terminalSubscriber p = Subscriber
272
255
273-- | Subscribe to an Event only for the duration of one occurrence
256-- | Subscribe to an Event only for the duration of one occurrence
274{-# INLINE subscribeAndReadHead #-}
257{-# INLINE subscribeAndReadHead #-}
275−subscribeAndReadHead :: HasSpiderTimeline x => Event x a -> Subscriber x a -> EventM x (EventSubscription x, Maybe a)
258+subscribeAndReadHead :: Event x a -> Subscriber x a -> EventM x (EventSubscription x, Maybe a)
276subscribeAndReadHead e sub = do
259subscribeAndReadHead e sub = do
277 subscriptionRef <- liftIO $ newIORef $ error "subscribeAndReadHead: not initialized"
260 subscriptionRef <- liftIO $ newIORef $ error "subscribeAndReadHead: not initialized"
278− (subscription, occ) <- subscribeAndRead e $ debugSubscriber' "head" $ sub
261+ (subscription, occ) <- subscribeAndRead e $ sub
279 { subscriberPropagate = \a -> do
262 { subscriberPropagate = \a -> do
280 liftIO $ unsubscribe =<< readIORef subscriptionRef
263 liftIO $ unsubscribe =<< readIORef subscriptionRef
281 subscriberPropagate sub a
264 subscriberPropagate sub a
@@ -286,42 +269,24 @@ subscribeAndReadHead e sub = do
286 return (subscription, occ)
269 return (subscription, occ)
287
270
288--TODO: Make this lazy in its input event
271--TODO: Make this lazy in its input event
289−headE :: (MonadIO m, Defer (SomeMergeInit x) m, HasSpiderTimeline x) => Event x a -> m (Event x a)
272+headE :: (MonadIO m, Defer (SomeMergeInit x) m) => Event x a -> m (Event x a)
290headE originalE = do
273headE originalE = do
291 parent <- liftIO $ newIORef $ Just originalE
274 parent <- liftIO $ newIORef $ Just originalE
292 defer $ SomeMergeInit $ do --TODO: Rename SomeMergeInit appropriately
275 defer $ SomeMergeInit $ do --TODO: Rename SomeMergeInit appropriately
293 let clearParent = liftIO $ writeIORef parent Nothing
276 let clearParent = liftIO $ writeIORef parent Nothing
294− (_, occ) <- subscribeAndReadHead originalE $ terminalSubscriber $ const clearParent
277+ (_, occ) <- subscribeAndReadHead originalE $ terminalSubscriber $ \_ -> clearParent
295 when (isJust occ) clearParent
278 when (isJust occ) clearParent
296− return $ Event $ \sub ->
279+ return $ Event $ \sub -> do
297 liftIO (readIORef parent) >>= \case
280 liftIO (readIORef parent) >>= \case
298− Nothing -> subscribeAndReadNever
281+ Nothing -> return (EventSubscription (return ()) $ EventSubscribed zeroRef $ toAny (), Nothing)
299 Just e -> subscribeAndReadHead e sub
282 Just e -> subscribeAndReadHead e sub
300
283
301data CacheSubscribed x a
284data CacheSubscribed x a
302 = CacheSubscribed { _cacheSubscribed_subscribers :: {-# UNPACK #-} !(FastWeakBag (Subscriber x a))
285 = CacheSubscribed { _cacheSubscribed_subscribers :: {-# UNPACK #-} !(FastWeakBag (Subscriber x a))
303 , _cacheSubscribed_parent :: {-# UNPACK #-} !(EventSubscription x)
286 , _cacheSubscribed_parent :: {-# UNPACK #-} !(EventSubscription x)
304 , _cacheSubscribed_occurrence :: {-# UNPACK #-} !(IORef (Maybe a))
287 , _cacheSubscribed_occurrence :: {-# UNPACK #-} !(IORef (Maybe a))
305−#ifdef DEBUG_NODEIDS
306− , _cacheSubscribed_nodeId :: {-# UNPACK #-} !Int
307−#endif
308 }
288 }
309
289
310−nowSpiderEventM :: (HasSpiderTimeline x) => EventM x (R.Event (SpiderTimeline x) ())
311−nowSpiderEventM =
312− SpiderEvent <$> now
313−
314−now :: (MonadIO m, Defer (Some Clear) m, HasSpiderTimeline x
315− ) => m (Event x ())
316−now = do
317− nowOrNot <- liftIO $ newIORef $ Just ()
318− scheduleClear nowOrNot
319− return . Event $ \_ -> do
320− occ <- liftIO . readIORef $ nowOrNot
321− return ( EventSubscription (return ()) eventSubscribedNow
322− , occ
323− )
324−
325-- | Construct an 'Event' whose value is guaranteed not to be recomputed
290-- | Construct an 'Event' whose value is guaranteed not to be recomputed
326-- repeatedly
291-- repeatedly
327--
292--
@@ -336,33 +301,27 @@ cacheEvent e =
336#else
301#else
337 Event $
302 Event $
338#endif
303#endif
339− unsafePerformIO $ do
340− mSubscribedRef :: IORef (FastWeak (CacheSubscribed x a))
304+ let mSubscribedRef :: IORef (FastWeak (CacheSubscribed x a))
341− <- newIORef emptyFastWeak
305+ !mSubscribedRef = unsafeNewIORef e emptyFastWeak
342− pure $ \sub -> {-# SCC "cacheEvent" #-} do
306+ in \sub -> {-# SCC "cacheEvent" #-} do
343#ifdef DEBUG_TRACE_EVENTS
307#ifdef DEBUG_TRACE_EVENTS
344 unless (BS8.null callSite) $ liftIO $ BS8.hPutStrLn stderr callSite
308 unless (BS8.null callSite) $ liftIO $ BS8.hPutStrLn stderr callSite
345#endif
309#endif
346 subscribedTicket <- liftIO (readIORef mSubscribedRef >>= getFastWeakTicket) >>= \case
310 subscribedTicket <- liftIO (readIORef mSubscribedRef >>= getFastWeakTicket) >>= \case
347 Just subscribedTicket -> return subscribedTicket
311 Just subscribedTicket -> return subscribedTicket
348 Nothing -> do
312 Nothing -> do
349−#ifdef DEBUG_NODEIDS
350− nodeId <- liftIO newNodeId
351−#endif
352 subscribers <- liftIO FastWeakBag.empty
313 subscribers <- liftIO FastWeakBag.empty
353 occRef <- liftIO $ newIORef Nothing -- This should never be read prior to being set below
314 occRef <- liftIO $ newIORef Nothing -- This should never be read prior to being set below
354−#ifdef DEBUG_NODEIDS
355− (parentSub, occ) <- subscribeAndRead e $ debugSubscriber' ("cacheEvent" <> showNodeId' nodeId) $ Subscriber
356−#else
357 (parentSub, occ) <- subscribeAndRead e $ Subscriber
315 (parentSub, occ) <- subscribeAndRead e $ Subscriber
358−#endif
359− { subscriberPropagate = \a -> do
316+ { subscriberPropagate = \a -> do
360− liftIO $ writeIORef occRef (Just a)
317+ liftIO $ writeIORef occRef $ Just a
361− scheduleClear occRef
318+ scheduleClear occRef
362− propagateFast a subscribers
319+ propagateFast a subscribers
320+ , subscriberInvalidateHeight = \old -> do
363− , subscriberInvalidateHeight = FastWeakBag.traverse_ subscribers . invalidateSubscriberHeight
321+ FastWeakBag.traverse subscribers $ invalidateSubscriberHeight old
322+ , subscriberRecalculateHeight = \new -> do
364− , subscriberRecalculateHeight = FastWeakBag.traverse_ subscribers . recalculateSubscriberHeight
323+ FastWeakBag.traverse subscribers $ recalculateSubscriberHeight new
365− }
324+ }
366 when (isJust occ) $ do
325 when (isJust occ) $ do
367 liftIO $ writeIORef occRef occ -- Set the initial value of occRef; we don't need to do this if occ is Nothing
326 liftIO $ writeIORef occRef occ -- Set the initial value of occRef; we don't need to do this if occ is Nothing
368 scheduleClear occRef
327 scheduleClear occRef
@@ -370,45 +329,29 @@ cacheEvent e =
370 { _cacheSubscribed_subscribers = subscribers
329 { _cacheSubscribed_subscribers = subscribers
371 , _cacheSubscribed_parent = parentSub
330 , _cacheSubscribed_parent = parentSub
372 , _cacheSubscribed_occurrence = occRef
331 , _cacheSubscribed_occurrence = occRef
373−#ifdef DEBUG_NODEIDS
374− , _cacheSubscribed_nodeId = nodeId
375−#endif
376 }
332 }
377 subscribedTicket <- liftIO $ mkFastWeakTicket subscribed
333 subscribedTicket <- liftIO $ mkFastWeakTicket subscribed
378 liftIO $ writeIORef mSubscribedRef =<< getFastWeakTicketWeak subscribedTicket
334 liftIO $ writeIORef mSubscribedRef =<< getFastWeakTicketWeak subscribedTicket
379 return subscribedTicket
335 return subscribedTicket
380− liftIO $ cacheSubscription sub mSubscribedRef subscribedTicket
336+ liftIO $ do
381−
382−cacheSubscription :: Subscriber x a -> IORef (FastWeak (CacheSubscribed x a))
383− -> FastWeakTicket (CacheSubscribed x a) -> IO (EventSubscription x, Maybe a)
384−cacheSubscription sub mSubscribedRef subscribedTicket = do
385− subscribed <- getFastWeakTicketValue subscribedTicket
337+ subscribed <- getFastWeakTicketValue subscribedTicket
386− ticket <- FastWeakBag.insert sub $ _cacheSubscribed_subscribers subscribed
338+ ticket <- FastWeakBag.insert sub $ _cacheSubscribed_subscribers subscribed
387− occ <- readIORef $ _cacheSubscribed_occurrence subscribed
339+ occ <- readIORef $ _cacheSubscribed_occurrence subscribed
388−
389− let parentSub = _cacheSubscribed_parent subscribed
390− es = EventSubscription
340+ let es = EventSubscription
391− { _eventSubscription_unsubscribe = do
341+ { _eventSubscription_unsubscribe = do
392− FastWeakBag.remove ticket
342+ FastWeakBag.remove ticket
393−
394− isEmpty <- FastWeakBag.isEmpty $ _cacheSubscribed_subscribers subscribed
343+ isEmpty <- FastWeakBag.isEmpty $ _cacheSubscribed_subscribers subscribed
395− when isEmpty $ do
344+ when isEmpty $ do
396− writeIORef mSubscribedRef emptyFastWeak
345+ writeIORef mSubscribedRef emptyFastWeak
397− unsubscribe parentSub
346+ unsubscribe $ _cacheSubscribed_parent subscribed
398− touch ticket
347+ touch ticket
399− touch subscribedTicket
348+ touch subscribedTicket
400− , _eventSubscription_subscribed = EventSubscribed
349+ , _eventSubscription_subscribed = EventSubscribed
401− { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed parentSub
350+ { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed $ _cacheSubscribed_parent subscribed
402− , eventSubscribedRetained = toAny subscribedTicket
351+ , eventSubscribedRetained = toAny subscribedTicket
403−#ifdef DEBUG_CYCLES
404− , eventSubscribedGetParents = return [_eventSubscription_subscribed parentSub]
405− , eventSubscribedHasOwnHeightRef = False
406− , eventSubscribedWhoCreated = whoCreatedIORef mSubscribedRef
407−#endif
408− }
352+ }
409− }
353+ }
410− return (es, occ)
354+ return (es, occ)
411−
412
355
413subscribe :: Event x a -> Subscriber x a -> EventM x (EventSubscription x)
356subscribe :: Event x a -> Subscriber x a -> EventM x (EventSubscription x)
414subscribe e s = fst <$> subscribeAndRead e s
357subscribe e s = fst <$> subscribeAndRead e s
@@ -420,16 +363,13 @@ wrap tag getSpecificSubscribed sub = do
420 let es = tag subd
363 let es = tag subd
421 return (EventSubscription (WeakBag.remove sln >> touch sln) es, occ)
364 return (EventSubscription (WeakBag.remove sln >> touch sln) es, occ)
422
365
423−eventRoot :: (GCompare k, HasSpiderTimeline x) => k a -> Root x k -> Event x a
366+eventRoot :: GCompare k => k a -> Root x k -> Event x a
424eventRoot !k !r = Event $ wrap eventSubscribedRoot $ liftIO . getRootSubscribed k r
367eventRoot !k !r = Event $ wrap eventSubscribedRoot $ liftIO . getRootSubscribed k r
425
368
426−subscribeAndReadNever :: EventM x (EventSubscription x, Maybe a)
427−subscribeAndReadNever = return (EventSubscription (return ()) eventSubscribedNever, Nothing)
428−
429eventNever :: Event x a
369eventNever :: Event x a
430−eventNever = Event $ const subscribeAndReadNever
370+eventNever = Event $ \_ -> return (EventSubscription (return ()) eventSubscribedNever, Nothing)
431
371
432−eventFan :: (GCompare k, HasSpiderTimeline x) => k a -> Fan x k v -> Event x (v a)
372+eventFan :: (GCompare k, HasSpiderTimeline x) => k a -> Fan x k -> Event x a
433eventFan !k !f = Event $ wrap eventSubscribedFan $ getFanSubscribed k f
373eventFan !k !f = Event $ wrap eventSubscribedFan $ getFanSubscribed k f
434
374
435eventSwitch :: HasSpiderTimeline x => Switch x a -> Event x a
375eventSwitch :: HasSpiderTimeline x => Switch x a -> Event x a
@@ -464,6 +404,16 @@ data Subscriber x a = Subscriber
464 , subscriberRecalculateHeight :: !(Height -> IO ())
404 , subscriberRecalculateHeight :: !(Height -> IO ())
465 }
405 }
466
406
407+--TODO: Move this comment to WeakBag
408+-- These function are constructor functions that are marked NOINLINE so they are
409+-- opaque to GHC. If we do not do this, then GHC will sometimes fuse the constructor away
410+-- so any weak references that are attached to the constructors will have their
411+-- finalizer run. Using the opaque constructor, does not see the
412+-- constructor application, so it behaves like an IORef and cannot be fused away.
413+--
414+-- The result is also evaluated to WHNF, since forcing a thunk invalidates
415+-- the weak pointer to it in some cases.
416+
467newSubscriberHold :: (HasSpiderTimeline x, Patch p) => Hold x p -> IO (Subscriber x p)
417newSubscriberHold :: (HasSpiderTimeline x, Patch p) => Hold x p -> IO (Subscriber x p)
468newSubscriberHold h = return $ Subscriber
418newSubscriberHold h = return $ Subscriber
469 { subscriberPropagate = {-# SCC "traverseHold" #-} propagateSubscriberHold h
419 { subscriberPropagate = {-# SCC "traverseHold" #-} propagateSubscriberHold h
@@ -471,68 +421,85 @@ newSubscriberHold h = return $ Subscriber
471 , subscriberRecalculateHeight = \_ -> return ()
421 , subscriberRecalculateHeight = \_ -> return ()
472 }
422 }
473
423
474−newSubscriberFan :: forall x k v. (HasSpiderTimeline x, GCompare k) => FanSubscribed x k v -> IO (Subscriber x (DMap k v))
424+newSubscriberFan :: forall x k. (HasSpiderTimeline x, GCompare k) => FanSubscribed x k -> IO (Subscriber x (DMap k Identity))
475−newSubscriberFan subscribed = debugSubscriber ("SubscriberFan " <> showNodeId subscribed) $ Subscriber
425+newSubscriberFan subscribed = return $ Subscriber
476 { subscriberPropagate = \a -> {-# SCC "traverseFan" #-} do
426 { subscriberPropagate = \a -> {-# SCC "traverseFan" #-} do
477 subs <- liftIO $ readIORef $ fanSubscribedSubscribers subscribed
427 subs <- liftIO $ readIORef $ fanSubscribedSubscribers subscribed
478− tracePropagate (Proxy :: Proxy x) $ show (DMap.size subs) <> " keys subscribed, " <> show (DMap.size a) <> " keys firing"
428+ tracePropagate (Proxy :: Proxy x) $ "SubscriberFan" <> showNodeId subscribed <> ": " ++ show (DMap.size subs) ++ " keys subscribed, " ++ show (DMap.size a) ++ " keys firing"
479 liftIO $ writeIORef (fanSubscribedOccurrence subscribed) $ Just a
429 liftIO $ writeIORef (fanSubscribedOccurrence subscribed) $ Just a
480 scheduleClear $ fanSubscribedOccurrence subscribed
430 scheduleClear $ fanSubscribedOccurrence subscribed
481− let f _ (Pair v subsubs) = do
431+ let f _ (Pair (Identity v) subsubs) = do
482 propagate v $ _fanSubscribedChildren_list subsubs
432 propagate v $ _fanSubscribedChildren_list subsubs
483 return $ Constant ()
433 return $ Constant ()
484 _ <- DMap.traverseWithKey f $ DMap.intersectionWithKey (\_ -> Pair) a subs --TODO: Would be nice to have DMap.traverse_
434 _ <- DMap.traverseWithKey f $ DMap.intersectionWithKey (\_ -> Pair) a subs --TODO: Would be nice to have DMap.traverse_
485 return ()
435 return ()
486 , subscriberInvalidateHeight = \old -> do
436 , subscriberInvalidateHeight = \old -> do
437+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberFan" <> showNodeId subscribed
487 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
438 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
488− forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse_ (_fanSubscribedChildren_list v) $ invalidateSubscriberHeight old
439+ forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse (_fanSubscribedChildren_list v) $ invalidateSubscriberHeight old
440+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberFan" <> showNodeId subscribed <> " done"
489 , subscriberRecalculateHeight = \new -> do
441 , subscriberRecalculateHeight = \new -> do
442+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberFan" <> showNodeId subscribed
490 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
443 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
491− forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse_ (_fanSubscribedChildren_list v) $ recalculateSubscriberHeight new
444+ forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse (_fanSubscribedChildren_list v) $ recalculateSubscriberHeight new
445+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberFan" <> showNodeId subscribed <> " done"
492 }
446 }
493
447
494newSubscriberSwitch :: forall x a. HasSpiderTimeline x => SwitchSubscribed x a -> IO (Subscriber x a)
448newSubscriberSwitch :: forall x a. HasSpiderTimeline x => SwitchSubscribed x a -> IO (Subscriber x a)
495−newSubscriberSwitch subscribed = debugSubscriber ("SubscriberCoincidenceOuter" <> showNodeId subscribed) $ Subscriber
449+newSubscriberSwitch subscribed = return $ Subscriber
496 { subscriberPropagate = \a -> {-# SCC "traverseSwitch" #-} do
450 { subscriberPropagate = \a -> {-# SCC "traverseSwitch" #-} do
451+ tracePropagate (Proxy :: Proxy x) $ "SubscriberSwitch" <> showNodeId subscribed
497 liftIO $ writeIORef (switchSubscribedOccurrence subscribed) $ Just a
452 liftIO $ writeIORef (switchSubscribedOccurrence subscribed) $ Just a
498 scheduleClear $ switchSubscribedOccurrence subscribed
453 scheduleClear $ switchSubscribedOccurrence subscribed
499 propagate a $ switchSubscribedSubscribers subscribed
454 propagate a $ switchSubscribedSubscribers subscribed
500 , subscriberInvalidateHeight = \_ -> do
455 , subscriberInvalidateHeight = \_ -> do
456+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed
501 oldHeight <- readIORef $ switchSubscribedHeight subscribed
457 oldHeight <- readIORef $ switchSubscribedHeight subscribed
502 when (oldHeight /= invalidHeight) $ do
458 when (oldHeight /= invalidHeight) $ do
503 writeIORef (switchSubscribedHeight subscribed) $! invalidHeight
459 writeIORef (switchSubscribedHeight subscribed) $! invalidHeight
504− WeakBag.traverse_ (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
460+ WeakBag.traverse (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
461+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed <> " done"
462+ , subscriberRecalculateHeight = \new -> do
463+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed
505− , subscriberRecalculateHeight = (`updateSwitchHeight` subscribed)
464+ updateSwitchHeight new subscribed
465+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed <> " done"
506− }
466+ }
507
467
508newSubscriberCoincidenceOuter :: forall x b. HasSpiderTimeline x => CoincidenceSubscribed x b -> IO (Subscriber x (Event x b))
468newSubscriberCoincidenceOuter :: forall x b. HasSpiderTimeline x => CoincidenceSubscribed x b -> IO (Subscriber x (Event x b))
509−newSubscriberCoincidenceOuter subscribed = debugSubscriber ("SubscriberCoincidenceOuter" <> showNodeId subscribed) $ Subscriber
469+newSubscriberCoincidenceOuter subscribed = return $ Subscriber
510 { subscriberPropagate = \a -> {-# SCC "traverseCoincidenceOuter" #-} do
470 { subscriberPropagate = \a -> {-# SCC "traverseCoincidenceOuter" #-} do
471+ tracePropagate (Proxy :: Proxy x) $ "SubscriberCoincidenceOuter" <> showNodeId subscribed
511 outerHeight <- liftIO $ readIORef $ coincidenceSubscribedHeight subscribed
472 outerHeight <- liftIO $ readIORef $ coincidenceSubscribedHeight subscribed
512 tracePropagate (Proxy :: Proxy x) $ " outerHeight = " <> show outerHeight
473 tracePropagate (Proxy :: Proxy x) $ " outerHeight = " <> show outerHeight
513 (occ, innerHeight, innerSubd) <- subscribeCoincidenceInner a outerHeight subscribed
474 (occ, innerHeight, innerSubd) <- subscribeCoincidenceInner a outerHeight subscribed
514 tracePropagate (Proxy :: Proxy x) $ " isJust occ = " <> show (isJust occ)
475 tracePropagate (Proxy :: Proxy x) $ " isJust occ = " <> show (isJust occ)
515 tracePropagate (Proxy :: Proxy x) $ " innerHeight = " <> show innerHeight
476 tracePropagate (Proxy :: Proxy x) $ " innerHeight = " <> show innerHeight
516−
517 liftIO $ writeIORef (coincidenceSubscribedInnerParent subscribed) $ Just innerSubd
477 liftIO $ writeIORef (coincidenceSubscribedInnerParent subscribed) $ Just innerSubd
518 scheduleClear $ coincidenceSubscribedInnerParent subscribed
478 scheduleClear $ coincidenceSubscribedInnerParent subscribed
519 case occ of
479 case occ of
520− Nothing ->
480+ Nothing -> do
521 when (innerHeight > outerHeight) $ liftIO $ do -- If the event fires, it will fire at a later height
481 when (innerHeight > outerHeight) $ liftIO $ do -- If the event fires, it will fire at a later height
522 writeIORef (coincidenceSubscribedHeight subscribed) $! innerHeight
482 writeIORef (coincidenceSubscribedHeight subscribed) $! innerHeight
523− WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight outerHeight
483+ WeakBag.traverse (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight outerHeight
524− WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ recalculateSubscriberHeight innerHeight
484+ WeakBag.traverse (coincidenceSubscribedSubscribers subscribed) $ recalculateSubscriberHeight innerHeight
525 Just o -> do -- Since it's already firing, no need to adjust height
485 Just o -> do -- Since it's already firing, no need to adjust height
526 liftIO $ writeIORef (coincidenceSubscribedOccurrence subscribed) occ
486 liftIO $ writeIORef (coincidenceSubscribedOccurrence subscribed) occ
527 scheduleClear $ coincidenceSubscribedOccurrence subscribed
487 scheduleClear $ coincidenceSubscribedOccurrence subscribed
528 propagate o $ coincidenceSubscribedSubscribers subscribed
488 propagate o $ coincidenceSubscribedSubscribers subscribed
489+ , subscriberInvalidateHeight = \_ -> do
490+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed
529− , subscriberInvalidateHeight = \_ -> invalidateCoincidenceHeight subscribed
491+ invalidateCoincidenceHeight subscribed
492+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed <> " done"
493+ , subscriberRecalculateHeight = \_ -> do
494+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed
530− , subscriberRecalculateHeight = \_ -> recalculateCoincidenceHeight subscribed
495+ recalculateCoincidenceHeight subscribed
496+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed <> " done"
531 }
497 }
532
498
533newSubscriberCoincidenceInner :: forall x a. HasSpiderTimeline x => CoincidenceSubscribed x a -> IO (Subscriber x a)
499newSubscriberCoincidenceInner :: forall x a. HasSpiderTimeline x => CoincidenceSubscribed x a -> IO (Subscriber x a)
534−newSubscriberCoincidenceInner subscribed = debugSubscriber ("SubscriberCoincidenceInner" <> showNodeId subscribed) $ Subscriber
500+newSubscriberCoincidenceInner subscribed = return $ Subscriber
535 { subscriberPropagate = \a -> {-# SCC "traverseCoincidenceInner" #-} do
501 { subscriberPropagate = \a -> {-# SCC "traverseCoincidenceInner" #-} do
502+ tracePropagate (Proxy :: Proxy x) $ "SubscriberCoincidenceInner" <> showNodeId subscribed
536 occ <- liftIO $ readIORef $ coincidenceSubscribedOccurrence subscribed
503 occ <- liftIO $ readIORef $ coincidenceSubscribedOccurrence subscribed
537 case occ of
504 case occ of
538 Just _ -> return () -- SubscriberCoincidenceOuter must have already propagated this event
505 Just _ -> return () -- SubscriberCoincidenceOuter must have already propagated this event
@@ -540,8 +507,14 @@ newSubscriberCoincidenceInner subscribed = debugSubscriber ("SubscriberCoinciden
540 liftIO $ writeIORef (coincidenceSubscribedOccurrence subscribed) $ Just a
507 liftIO $ writeIORef (coincidenceSubscribedOccurrence subscribed) $ Just a
541 scheduleClear $ coincidenceSubscribedOccurrence subscribed
508 scheduleClear $ coincidenceSubscribedOccurrence subscribed
542 propagate a $ coincidenceSubscribedSubscribers subscribed
509 propagate a $ coincidenceSubscribedSubscribers subscribed
510+ , subscriberInvalidateHeight = \_ -> do
511+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed
543− , subscriberInvalidateHeight = \_ -> invalidateCoincidenceHeight subscribed
512+ invalidateCoincidenceHeight subscribed
513+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed <> " done"
514+ , subscriberRecalculateHeight = \_ -> do
515+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed
544− , subscriberRecalculateHeight = \_ -> recalculateCoincidenceHeight subscribed
516+ recalculateCoincidenceHeight subscribed
517+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed <> " done"
545 }
518 }
546
519
547invalidateSubscriberHeight :: Height -> Subscriber x a -> IO ()
520invalidateSubscriberHeight :: Height -> Subscriber x a -> IO ()
@@ -551,18 +524,18 @@ recalculateSubscriberHeight :: Height -> Subscriber x a -> IO ()
551recalculateSubscriberHeight = flip subscriberRecalculateHeight
524recalculateSubscriberHeight = flip subscriberRecalculateHeight
552
525
553-- | Propagate everything at the current height
526-- | Propagate everything at the current height
554−propagate :: forall x a. HasSpiderTimeline x => a -> WeakBag (Subscriber x a) -> EventM x ()
527+propagate :: a -> WeakBag (Subscriber x a) -> EventM x ()
555−propagate a subscribers = withIncreasedDepth (Proxy::Proxy x) $
528+propagate a subscribers = withIncreasedDepth $ do
556 -- Note: in the following traversal, we do not visit nodes that are added to the list during our traversal; they are new events, which will necessarily have full information already, so there is no need to traverse them
529 -- Note: in the following traversal, we do not visit nodes that are added to the list during our traversal; they are new events, which will necessarily have full information already, so there is no need to traverse them
557 --TODO: Should we check if nodes already have their values before propagating? Maybe we're re-doing work
530 --TODO: Should we check if nodes already have their values before propagating? Maybe we're re-doing work
558− WeakBag.traverse_ subscribers $ \s -> subscriberPropagate s a
531+ WeakBag.traverse subscribers $ \s -> subscriberPropagate s a
559
532
560-- | Propagate everything at the current height
533-- | Propagate everything at the current height
561−propagateFast :: forall x a. HasSpiderTimeline x => a -> FastWeakBag (Subscriber x a) -> EventM x ()
534+propagateFast :: a -> FastWeakBag (Subscriber x a) -> EventM x ()
562−propagateFast a subscribers = withIncreasedDepth (Proxy::Proxy x) $
535+propagateFast a subscribers = withIncreasedDepth $ do
563 -- Note: in the following traversal, we do not visit nodes that are added to the list during our traversal; they are new events, which will necessarily have full information already, so there is no need to traverse them
536 -- Note: in the following traversal, we do not visit nodes that are added to the list during our traversal; they are new events, which will necessarily have full information already, so there is no need to traverse them
564 --TODO: Should we check if nodes already have their values before propagating? Maybe we're re-doing work
537 --TODO: Should we check if nodes already have their values before propagating? Maybe we're re-doing work
565− FastWeakBag.traverse_ subscribers $ \s -> subscriberPropagate s a
538+ FastWeakBag.traverse subscribers $ \s -> subscriberPropagate s a
566
539
567--------------------------------------------------------------------------------
540--------------------------------------------------------------------------------
568-- EventSubscribed
541-- EventSubscribed
@@ -571,16 +544,11 @@ propagateFast a subscribers = withIncreasedDepth (Proxy::Proxy x) $
571toAny :: a -> Any
544toAny :: a -> Any
572toAny = unsafeCoerce
545toAny = unsafeCoerce
573
546
574−-- Why do we use Any here, instead of just giving eventSubscribedRetained an
575−-- existential type? Sadly, GHC does not currently know how to unbox types
576−-- with existentially quantified fields. So instead we just coerce values
577−-- to type Any on the way in. Since we never coerce them back, this is
578−-- perfectly safe.
579data EventSubscribed x = EventSubscribed
547data EventSubscribed x = EventSubscribed
580 { eventSubscribedHeightRef :: {-# UNPACK #-} !(IORef Height)
548 { eventSubscribedHeightRef :: {-# UNPACK #-} !(IORef Height)
581 , eventSubscribedRetained :: {-# NOUNPACK #-} !Any
549 , eventSubscribedRetained :: {-# NOUNPACK #-} !Any
582#ifdef DEBUG_CYCLES
550#ifdef DEBUG_CYCLES
583− , eventSubscribedGetParents :: !(IO [EventSubscribed x]) -- For debugging loops
551+ , eventSubscribedGetParents :: !(IO [Some (EventSubscribed x)]) -- For debugging loops
584 , eventSubscribedHasOwnHeightRef :: !Bool
552 , eventSubscribedHasOwnHeightRef :: !Bool
585 , eventSubscribedWhoCreated :: !(IO [String])
553 , eventSubscribedWhoCreated :: !(IO [String])
586#endif
554#endif
@@ -607,23 +575,13 @@ eventSubscribedNever = EventSubscribed
607 , eventSubscribedWhoCreated = return ["never"]
575 , eventSubscribedWhoCreated = return ["never"]
608#endif
576#endif
609 }
577 }
610−eventSubscribedNow :: EventSubscribed x
611−eventSubscribedNow = EventSubscribed
612− { eventSubscribedHeightRef = zeroRef
613− , eventSubscribedRetained = toAny ()
614−#ifdef DEBUG_CYCLES
615− , eventSubscribedGetParents = return []
616− , eventSubscribedHasOwnHeightRef = False
617− , eventSubscribedWhoCreated = return ["now"]
618−#endif
619− }
620
578
621−eventSubscribedFan :: FanSubscribed x k v -> EventSubscribed x
579+eventSubscribedFan :: FanSubscribed x k -> EventSubscribed x
622eventSubscribedFan !subscribed = EventSubscribed
580eventSubscribedFan !subscribed = EventSubscribed
623 { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed $ fanSubscribedParent subscribed
581 { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed $ fanSubscribedParent subscribed
624 , eventSubscribedRetained = toAny subscribed
582 , eventSubscribedRetained = toAny subscribed
625#ifdef DEBUG_CYCLES
583#ifdef DEBUG_CYCLES
626− , eventSubscribedGetParents = return [_eventSubscription_subscribed $ fanSubscribedParent subscribed]
584+ , eventSubscribedGetParents = return [Some $ _eventSubscription_subscribed $ fanSubscribedParent subscribed]
627 , eventSubscribedHasOwnHeightRef = False
585 , eventSubscribedHasOwnHeightRef = False
628 , eventSubscribedWhoCreated = whoCreatedIORef $ fanSubscribedCachedSubscribed subscribed
586 , eventSubscribedWhoCreated = whoCreatedIORef $ fanSubscribedCachedSubscribed subscribed
629#endif
587#endif
@@ -636,7 +594,7 @@ eventSubscribedSwitch !subscribed = EventSubscribed
636#ifdef DEBUG_CYCLES
594#ifdef DEBUG_CYCLES
637 , eventSubscribedGetParents = do
595 , eventSubscribedGetParents = do
638 s <- readIORef $ switchSubscribedCurrentParent subscribed
596 s <- readIORef $ switchSubscribedCurrentParent subscribed
639− return [_eventSubscription_subscribed s]
597+ return [Some $ _eventSubscription_subscribed s]
640 , eventSubscribedHasOwnHeightRef = True
598 , eventSubscribedHasOwnHeightRef = True
641 , eventSubscribedWhoCreated = whoCreatedIORef $ switchSubscribedCachedSubscribed subscribed
599 , eventSubscribedWhoCreated = whoCreatedIORef $ switchSubscribedCachedSubscribed subscribed
642#endif
600#endif
@@ -649,8 +607,8 @@ eventSubscribedCoincidence !subscribed = EventSubscribed
649#ifdef DEBUG_CYCLES
607#ifdef DEBUG_CYCLES
650 , eventSubscribedGetParents = do
608 , eventSubscribedGetParents = do
651 innerSubscription <- readIORef $ coincidenceSubscribedInnerParent subscribed
609 innerSubscription <- readIORef $ coincidenceSubscribedInnerParent subscribed
652− let outerParent = _eventSubscription_subscribed $ coincidenceSubscribedOuterParent subscribed
610+ let outerParent = Some $ _eventSubscription_subscribed $ coincidenceSubscribedOuterParent subscribed
653− innerParents = maybeToList $ innerSubscription
611+ innerParents = maybeToList $ fmap Some innerSubscription
654 return $ outerParent : innerParents
612 return $ outerParent : innerParents
655 , eventSubscribedHasOwnHeightRef = True
613 , eventSubscribedHasOwnHeightRef = True
656 , eventSubscribedWhoCreated = whoCreatedIORef $ coincidenceSubscribedCachedSubscribed subscribed
614 , eventSubscribedWhoCreated = whoCreatedIORef $ coincidenceSubscribedCachedSubscribed subscribed
@@ -664,15 +622,15 @@ getEventSubscribedHeight es = readIORef $ eventSubscribedHeightRef es
664whoCreatedEventSubscribed :: EventSubscribed x -> IO [String]
622whoCreatedEventSubscribed :: EventSubscribed x -> IO [String]
665whoCreatedEventSubscribed = eventSubscribedWhoCreated
623whoCreatedEventSubscribed = eventSubscribedWhoCreated
666
624
667−walkInvalidHeightParents :: EventSubscribed x -> IO [EventSubscribed x]
625+walkInvalidHeightParents :: EventSubscribed x -> IO [Some (EventSubscribed x)]
668walkInvalidHeightParents s0 = do
626walkInvalidHeightParents s0 = do
669− subscribers <- flip execStateT mempty $ ($ s0) $ fix $ \loop s -> do
627+ subscribers <- flip execStateT mempty $ ($ Some s0) $ fix $ \loop (Some s) -> do
670 h <- liftIO $ readIORef $ eventSubscribedHeightRef s
628 h <- liftIO $ readIORef $ eventSubscribedHeightRef s
671 when (h == invalidHeight) $ do
629 when (h == invalidHeight) $ do
672 when (eventSubscribedHasOwnHeightRef s) $ liftIO $ writeIORef (eventSubscribedHeightRef s) $! invalidHeightBeingTraversed
630 when (eventSubscribedHasOwnHeightRef s) $ liftIO $ writeIORef (eventSubscribedHeightRef s) $! invalidHeightBeingTraversed
673− modify (s :)
631+ modify (Some s :)
674 mapM_ loop =<< liftIO (eventSubscribedGetParents s)
632 mapM_ loop =<< liftIO (eventSubscribedGetParents s)
675− forM_ subscribers $ \s -> writeIORef (eventSubscribedHeightRef s) $! invalidHeight
633+ forM_ subscribers $ \(Some s) -> writeIORef (eventSubscribedHeightRef s) $! invalidHeight
676 return subscribers
634 return subscribers
677#endif
635#endif
678
636
@@ -709,7 +667,7 @@ behaviorPull !p = Behavior $ do
709 wi <- liftIO $ mkWeakPtrWithDebug i "InvalidatorPull"
667 wi <- liftIO $ mkWeakPtrWithDebug i "InvalidatorPull"
710 parentsRef <- liftIO $ newIORef []
668 parentsRef <- liftIO $ newIORef []
711 holdInits <- askBehaviorHoldInits
669 holdInits <- askBehaviorHoldInits
712− a <- liftIO $ runReaderIO (unBehaviorM $ pullCompute p) (Just (wi, parentsRef), holdInits)
670+ a <- liftIO $ runReaderT (unBehaviorM $ pullCompute p) (Just (wi, parentsRef), holdInits)
713 invsRef <- liftIO . newIORef . maybeToList =<< askInvalidator
671 invsRef <- liftIO . newIORef . maybeToList =<< askInvalidator
714 parents <- liftIO $ readIORef parentsRef
672 parents <- liftIO $ readIORef parentsRef
715 let subscribed = PullSubscribed
673 let subscribed = PullSubscribed
@@ -744,46 +702,42 @@ readBehaviorUntracked b = do
744-- Dynamic
702-- Dynamic
745--------------------------------------------------------------------------------
703--------------------------------------------------------------------------------
746
704
747−type DynamicS x p = Dynamic x (PatchTarget p) p
748−
749−data Dynamic x target p = Dynamic
705+data Dynamic x p = Dynamic
750− { dynamicCurrent :: !(Behavior x target)
706+ { dynamicCurrent :: !(Behavior x (PatchTarget p))
751 , dynamicUpdated :: Event x p -- This must be lazy; see the comment on holdEvent --TODO: Would this let us eliminate `Dyn`?
707 , dynamicUpdated :: Event x p -- This must be lazy; see the comment on holdEvent --TODO: Would this let us eliminate `Dyn`?
752 }
708 }
753
709
754−deriving instance (HasSpiderTimeline x) => Functor (Dynamic x target)
755−
756−
757−
758−
759−dynamicHold :: Hold x p -> DynamicS x p
710+dynamicHold :: Hold x p -> Dynamic x p
760dynamicHold !h = Dynamic
711dynamicHold !h = Dynamic
761 { dynamicCurrent = behaviorHold h
712 { dynamicCurrent = behaviorHold h
762 , dynamicUpdated = eventHold h
713 , dynamicUpdated = eventHold h
763 }
714 }
764
715
765−dynamicHoldIdentity :: Hold x (Identity a) -> DynamicS x (Identity a)
716+dynamicHoldIdentity :: Hold x (Identity a) -> Dynamic x (Identity a)
766dynamicHoldIdentity = dynamicHold
717dynamicHoldIdentity = dynamicHold
767
718
768−dynamicConst :: PatchTarget p -> DynamicS x p
719+dynamicConst :: PatchTarget p -> Dynamic x p
769dynamicConst !a = Dynamic
720dynamicConst !a = Dynamic
770 { dynamicCurrent = behaviorConst a
721 { dynamicCurrent = behaviorConst a
771 , dynamicUpdated = eventNever
722 , dynamicUpdated = eventNever
772 }
723 }
773
724
774−dynamicDyn :: (HasSpiderTimeline x, Patch p) => Dyn x p -> DynamicS x p
725+dynamicDyn :: (HasSpiderTimeline x, Patch p) => Dyn x p -> Dynamic x p
775dynamicDyn !d = Dynamic
726dynamicDyn !d = Dynamic
776 { dynamicCurrent = behaviorDyn d
727 { dynamicCurrent = behaviorDyn d
777 , dynamicUpdated = eventDyn d
728 , dynamicUpdated = eventDyn d
778 }
729 }
779
730
780−dynamicDynIdentity :: HasSpiderTimeline x => Dyn x (Identity a) -> DynamicS x (Identity a)
731+dynamicDynIdentity :: HasSpiderTimeline x => Dyn x (Identity a) -> Dynamic x (Identity a)
781dynamicDynIdentity = dynamicDyn
732dynamicDynIdentity = dynamicDyn
782
733
783--------------------------------------------------------------------------------
734--------------------------------------------------------------------------------
784-- Combinators
735-- Combinators
785--------------------------------------------------------------------------------
736--------------------------------------------------------------------------------
786
737
738+--TODO: Figure out why certain things are not 'representational', then make them
739+--representational so we can use coerce
740+
787--type role Hold representational
741--type role Hold representational
788data Hold x p
742data Hold x p
789 = Hold { holdValue :: !(IORef (PatchTarget p))
743 = Hold { holdValue :: !(IORef (PatchTarget p))
@@ -804,25 +758,20 @@ globalSpiderTimelineEnv = unsafePerformIO unsafeNewSpiderTimelineEnv
804
758
805-- | Stores all global data relevant to a particular Spider timeline; only one
759-- | Stores all global data relevant to a particular Spider timeline; only one
806-- value should exist for each type @x@
760-- value should exist for each type @x@
807−newtype SpiderTimelineEnv x = STE {unSTE :: SpiderTimelineEnv' x}
808−-- We implement SpiderTimelineEnv with a newtype wrapper so
809−-- we can get the coercions we want safely.
810−type role SpiderTimelineEnv nominal
811−
812−data SpiderTimelineEnv' x = SpiderTimelineEnv
761+data SpiderTimelineEnv x = SpiderTimelineEnv
813 { _spiderTimeline_lock :: {-# UNPACK #-} !(MVar ())
762 { _spiderTimeline_lock :: {-# UNPACK #-} !(MVar ())
814 , _spiderTimeline_eventEnv :: {-# UNPACK #-} !(EventEnv x)
763 , _spiderTimeline_eventEnv :: {-# UNPACK #-} !(EventEnv x)
815#ifdef DEBUG
764#ifdef DEBUG
816 , _spiderTimeline_depth :: {-# UNPACK #-} !(IORef Int)
765 , _spiderTimeline_depth :: {-# UNPACK #-} !(IORef Int)
817#endif
766#endif
818 }
767 }
819−type role SpiderTimelineEnv' phantom
768+type role SpiderTimelineEnv nominal
820
769
821instance Eq (SpiderTimelineEnv x) where
770instance Eq (SpiderTimelineEnv x) where
822 _ == _ = True -- Since only one exists of each type
771 _ == _ = True -- Since only one exists of each type
823
772
824instance GEq SpiderTimelineEnv where
773instance GEq SpiderTimelineEnv where
825− a `geq` b = if _spiderTimeline_lock (unSTE a) == _spiderTimeline_lock (unSTE b)
774+ a `geq` b = if _spiderTimeline_lock a == _spiderTimeline_lock b
826 then Just $ unsafeCoerce Refl -- This unsafeCoerce is safe because the same SpiderTimelineEnv can't have two different 'x' arguments
775 then Just $ unsafeCoerce Refl -- This unsafeCoerce is safe because the same SpiderTimelineEnv can't have two different 'x' arguments
827 else Nothing
776 else Nothing
828
777
@@ -845,7 +794,7 @@ runEventM :: EventM x a -> IO a
845runEventM = unEventM
794runEventM = unEventM
846
795
847asksEventEnv :: forall x a. HasSpiderTimeline x => (EventEnv x -> a) -> EventM x a
796asksEventEnv :: forall x a. HasSpiderTimeline x => (EventEnv x -> a) -> EventM x a
848−asksEventEnv f = return $ f $ _spiderTimeline_eventEnv (unSTE (spiderTimeline :: SpiderTimelineEnv x))
797+asksEventEnv f = return $ f $ _spiderTimeline_eventEnv (spiderTimeline :: SpiderTimelineEnv x)
849
798
850class MonadIO m => Defer a m where
799class MonadIO m => Defer a m where
851 getDeferralQueue :: m (IORef [a])
800 getDeferralQueue :: m (IORef [a])
@@ -983,9 +932,9 @@ getHoldEventSubscription h = do
983
932
984type BehaviorEnv x = (Maybe (Weak (Invalidator x), IORef [SomeBehaviorSubscribed x]), IORef [SomeHoldInit x])
933type BehaviorEnv x = (Maybe (Weak (Invalidator x), IORef [SomeBehaviorSubscribed x]), IORef [SomeHoldInit x])
985
934
935+--type role BehaviorM representational
986-- BehaviorM can sample behaviors
936-- BehaviorM can sample behaviors
987−newtype BehaviorM x a = BehaviorM { unBehaviorM :: ReaderIO (BehaviorEnv x) a }
937+newtype BehaviorM x a = BehaviorM { unBehaviorM :: ReaderT (BehaviorEnv x) IO a } deriving (Functor, Applicative, MonadIO, MonadFix)
988− deriving (Functor, Applicative, MonadIO, MonadFix, MonadReader (BehaviorEnv x))
989
938
990instance Monad (BehaviorM x) where
939instance Monad (BehaviorM x) where
991 {-# INLINE (>>=) #-}
940 {-# INLINE (>>=) #-}
@@ -994,10 +943,8 @@ instance Monad (BehaviorM x) where
994 BehaviorM x >> BehaviorM y = BehaviorM $ x >> y
943 BehaviorM x >> BehaviorM y = BehaviorM $ x >> y
995 {-# INLINE return #-}
944 {-# INLINE return #-}
996 return x = BehaviorM $ return x
945 return x = BehaviorM $ return x
997−#if !MIN_VERSION_base(4,13,0)
998 {-# INLINE fail #-}
946 {-# INLINE fail #-}
999 fail s = BehaviorM $ fail s
947 fail s = BehaviorM $ fail s
1000−#endif
1001
948
1002data BehaviorSubscribed x a
949data BehaviorSubscribed x a
1003 = forall p. BehaviorSubscribedHold (Hold x p)
950 = forall p. BehaviorSubscribedHold (Hold x p)
@@ -1038,7 +985,7 @@ data RootSubscribed x a = forall k. GCompare k => RootSubscribed
1038#endif
985#endif
1039 }
986 }
1040
987
1041−data Root x k
988+data Root x (k :: * -> *)
1042 = Root { rootOccurrence :: !(IORef (DMap k Identity)) -- The currently-firing occurrence of this event
989 = Root { rootOccurrence :: !(IORef (DMap k Identity)) -- The currently-firing occurrence of this event
1043 , rootSubscribed :: !(IORef (DMap k (RootSubscribed x)))
990 , rootSubscribed :: !(IORef (DMap k (RootSubscribed x)))
1044 , rootInit :: !(forall a. k a -> RootTrigger x a -> IO (IO ()))
991 , rootInit :: !(forall a. k a -> RootTrigger x a -> IO (IO ()))
@@ -1057,7 +1004,7 @@ data SomeMergeUpdate x = SomeMergeUpdate
1057newtype SomeMergeInit x = SomeMergeInit { unSomeMergeInit :: EventM x () }
1004newtype SomeMergeInit x = SomeMergeInit { unSomeMergeInit :: EventM x () }
1058
1005
1059-- EventM can do everything BehaviorM can, plus create holds
1006-- EventM can do everything BehaviorM can, plus create holds
1060−newtype EventM x a = EventM { unEventM :: IO a } deriving (Functor, Applicative, Monad, MonadIO, MonadFix, MonadException, MonadAsyncException)
1007+newtype EventM x a = EventM { unEventM :: IO a } deriving (Functor, Applicative, Monad, MonadIO, MonadFix, MonadException, MonadAsyncException) -- The environment should be Nothing if we are not in a frame, and Just if we are - in which case it is a list of assignments to be done after the frame is over
1061
1008
1062newtype MergeSubscribedParent x a = MergeSubscribedParent { unMergeSubscribedParent :: EventSubscription x }
1009newtype MergeSubscribedParent x a = MergeSubscribedParent { unMergeSubscribedParent :: EventSubscription x }
1063
1010
@@ -1082,8 +1029,7 @@ heightBagFromList :: [Height] -> HeightBag
1082heightBagFromList heights = heightBagVerify $ foldl' (flip heightBagAdd) heightBagEmpty heights
1029heightBagFromList heights = heightBagVerify $ foldl' (flip heightBagAdd) heightBagEmpty heights
1083
1030
1084heightBagAdd :: Height -> HeightBag -> HeightBag
1031heightBagAdd :: Height -> HeightBag -> HeightBag
1085−heightBagAdd (Height h) (HeightBag s c) = heightBagVerify $ HeightBag (succ s) $
1032+heightBagAdd (Height h) (HeightBag s c) = heightBagVerify $ HeightBag (succ s) $ IntMap.insertWithKey (\_ _ old -> succ old) h 0 c
1086− IntMap.insertWithKey (\_ _ old -> succ old) h 0 c
1087
1033
1088heightBagRemove :: Height -> HeightBag -> HeightBag
1034heightBagRemove :: Height -> HeightBag -> HeightBag
1089heightBagRemove (Height h) b@(HeightBag s c) = heightBagVerify $ case IntMap.lookup h c of
1035heightBagRemove (Height h) b@(HeightBag s c) = heightBagVerify $ case IntMap.lookup h c of
@@ -1092,13 +1038,6 @@ heightBagRemove (Height h) b@(HeightBag s c) = heightBagVerify $ case IntMap.loo
1092 0 -> IntMap.delete h c
1038 0 -> IntMap.delete h c
1093 _ -> IntMap.insert h (pred old) c
1039 _ -> IntMap.insert h (pred old) c
1094
1040
1095−heightBagRemoveMaybe :: Height -> HeightBag -> Maybe HeightBag
1096−heightBagRemoveMaybe (Height h) b@(HeightBag s c) = heightBagVerify . removed <$> IntMap.lookup h c where
1097− removed old = HeightBag (pred s) $ case old of
1098− 0 -> IntMap.delete h c
1099− _ -> IntMap.insert h (pred old) c
1100−
1101−
1102heightBagMax :: HeightBag -> Height
1041heightBagMax :: HeightBag -> Height
1103heightBagMax (HeightBag _ c) = case IntMap.maxViewWithKey c of
1042heightBagMax (HeightBag _ c) = case IntMap.maxViewWithKey c of
1104 Just ((h, _), _) -> Height h
1043 Just ((h, _), _) -> Height h
@@ -1116,25 +1055,25 @@ heightBagVerify b@(HeightBag s c) = if
1116heightBagVerify = id
1055heightBagVerify = id
1117#endif
1056#endif
1118
1057
1119−data FanSubscribedChildren x k v a = FanSubscribedChildren
1058+data FanSubscribedChildren (x :: *) k a = FanSubscribedChildren
1120− { _fanSubscribedChildren_list :: !(WeakBag (Subscriber x (v a)))
1059+ { _fanSubscribedChildren_list :: !(WeakBag (Subscriber x a))
1121− , _fanSubscribedChildren_self :: {-# NOUNPACK #-} !(k a, FanSubscribed x k v)
1060+ , _fanSubscribedChildren_self :: {-# NOUNPACK #-} !(k a, FanSubscribed x k)
1122− , _fanSubscribedChildren_weakSelf :: !(IORef (Weak (k a, FanSubscribed x k v)))
1061+ , _fanSubscribedChildren_weakSelf :: !(IORef (Weak (k a, FanSubscribed x k)))
1123 }
1062 }
1124
1063
1125−data FanSubscribed x k v
1064+data FanSubscribed (x :: *) k
1126− = FanSubscribed { fanSubscribedCachedSubscribed :: !(IORef (Maybe (FanSubscribed x k v)))
1065+ = FanSubscribed { fanSubscribedCachedSubscribed :: !(IORef (Maybe (FanSubscribed x k)))
1127− , fanSubscribedOccurrence :: !(IORef (Maybe (DMap k v)))
1066+ , fanSubscribedOccurrence :: !(IORef (Maybe (DMap k Identity)))
1128− , fanSubscribedSubscribers :: !(IORef (DMap k (FanSubscribedChildren x k v))) -- This DMap should never be empty
1067+ , fanSubscribedSubscribers :: !(IORef (DMap k (FanSubscribedChildren x k))) -- This DMap should never be empty
1129 , fanSubscribedParent :: !(EventSubscription x)
1068 , fanSubscribedParent :: !(EventSubscription x)
1130#ifdef DEBUG_NODEIDS
1069#ifdef DEBUG_NODEIDS
1131 , fanSubscribedNodeId :: Int
1070 , fanSubscribedNodeId :: Int
1132#endif
1071#endif
1133 }
1072 }
1134
1073
1135−data Fan x k v
1074+data Fan x k
1136− = Fan { fanParent :: !(Event x (DMap k v))
1075+ = Fan { fanParent :: !(Event x (DMap k Identity))
1137− , fanSubscribed :: !(IORef (Maybe (FanSubscribed x k v)))
1076+ , fanSubscribed :: !(IORef (Maybe (FanSubscribed x k)))
1138 }
1077 }
1139
1078
1140data SwitchSubscribed x a
1079data SwitchSubscribed x a
@@ -1196,27 +1135,19 @@ instance HasSpiderTimeline x => Align (Event x) where
1196#if MIN_VERSION_these(0, 8, 0)
1135#if MIN_VERSION_these(0, 8, 0)
1197instance HasSpiderTimeline x => Semialign (Event x) where
1136instance HasSpiderTimeline x => Semialign (Event x) where
1198#endif
1137#endif
1199− align ea eb = mapMaybe dmapToThese $ mergeG coerce $ dynamicConst $
1200− DMap.fromDistinctAscList [LeftTag :=> ea, RightTag :=> eb]
1138+ align ea eb = mapMaybe dmapToThese $ merge $ dynamicConst $ DMap.fromDistinctAscList [LeftTag :=> ea, RightTag :=> eb]
1201−
1202−#ifdef MIN_VERSION_semialign
1203−#if MIN_VERSION_semialign(1,1,0)
1204−instance HasSpiderTimeline x => Zip (Event x) where
1205−#endif
1206− zip x y = mapMaybe justThese $ align x y
1207−#endif
1208
1139
1209data DynType x p = UnsafeDyn !(BehaviorM x (PatchTarget p), Event x p)
1140data DynType x p = UnsafeDyn !(BehaviorM x (PatchTarget p), Event x p)
1210 | BuildDyn !(EventM x (PatchTarget p), Event x p)
1141 | BuildDyn !(EventM x (PatchTarget p), Event x p)
1211 | HoldDyn !(Hold x p)
1142 | HoldDyn !(Hold x p)
1212
1143
1213−newtype Dyn (x :: Type) p = Dyn { unDyn :: IORef (DynType x p) }
1144+newtype Dyn x p = Dyn { unDyn :: IORef (DynType x p) }
1214
1145
1215−newMapDyn :: HasSpiderTimeline x => (a -> b) -> DynamicS x (Identity a) -> DynamicS x (Identity b)
1146+newMapDyn :: HasSpiderTimeline x => (a -> b) -> Dynamic x (Identity a) -> Dynamic x (Identity b)
1216newMapDyn f d = dynamicDynIdentity $ unsafeBuildDynamic (fmap f $ readBehaviorTracked $ dynamicCurrent d) (Identity . f . runIdentity <$> dynamicUpdated d)
1147newMapDyn f d = dynamicDynIdentity $ unsafeBuildDynamic (fmap f $ readBehaviorTracked $ dynamicCurrent d) (Identity . f . runIdentity <$> dynamicUpdated d)
1217
1148
1218--TODO: Avoid the duplication between this and R.zipDynWith
1149--TODO: Avoid the duplication between this and R.zipDynWith
1219−zipDynWith :: HasSpiderTimeline x => (a -> b -> c) -> DynamicS x (Identity a) -> DynamicS x (Identity b) -> DynamicS x (Identity c)
1150+zipDynWith :: HasSpiderTimeline x => (a -> b -> c) -> Dynamic x (Identity a) -> Dynamic x (Identity b) -> Dynamic x (Identity c)
1220zipDynWith f da db =
1151zipDynWith f da db =
1221 let eab = align (dynamicUpdated da) (dynamicUpdated db)
1152 let eab = align (dynamicUpdated da) (dynamicUpdated db)
1222 ec = flip push eab $ \o -> do
1153 ec = flip push eab $ \o -> do
@@ -1239,12 +1170,18 @@ buildDynamic readV0 v' = do
1239 return d
1170 return d
1240
1171
1241unsafeBuildDynamic :: BehaviorM x (PatchTarget p) -> Event x p -> Dyn x p
1172unsafeBuildDynamic :: BehaviorM x (PatchTarget p) -> Event x p -> Dyn x p
1242−unsafeBuildDynamic readV0 v' =
1173+unsafeBuildDynamic readV0 v' = Dyn $ unsafeNewIORef x $ UnsafeDyn x
1243− Dyn $ unsafePerformIO $ newIORef $ UnsafeDyn (readV0, v')
1174+ where x = (readV0, v')
1244
1175
1245-- ResultM can read behaviors and events
1176-- ResultM can read behaviors and events
1246type ResultM = EventM
1177type ResultM = EventM
1247
1178
1179+{-# NOINLINE unsafeNewIORef #-}
1180+unsafeNewIORef :: a -> b -> IORef b
1181+unsafeNewIORef a b = unsafePerformIO $ do
1182+ touch a
1183+ newIORef b
1184+
1248instance HasSpiderTimeline x => Functor (Event x) where
1185instance HasSpiderTimeline x => Functor (Event x) where
1249 fmap f = push $ return . Just . f
1186 fmap f = push $ return . Just . f
1250
1187
@@ -1257,42 +1194,33 @@ push f e = cacheEvent (pushCheap f e)
1257
1194
1258{-# INLINABLE pull #-}
1195{-# INLINABLE pull #-}
1259pull :: BehaviorM x a -> Behavior x a
1196pull :: BehaviorM x a -> Behavior x a
1260−pull a = unsafePerformIO $ do
1197+pull a = behaviorPull $ Pull
1261− ref <- newIORef Nothing
1198+ { pullCompute = a
1199+ , pullValue = unsafeNewIORef a Nothing
1262#ifdef DEBUG_NODEIDS
1200#ifdef DEBUG_NODEIDS
1263− nid <- newNodeId
1201+ , pullNodeId = unsafeNodeId a
1264#endif
1202#endif
1265− pure $ behaviorPull $ Pull
1266− { pullCompute = a
1267− , pullValue = ref
1268−#ifdef DEBUG_NODEIDS
1269− , pullNodeId = nid
1270−#endif
1271− }
1203+ }
1272
1204
1273{-# INLINABLE switch #-}
1205{-# INLINABLE switch #-}
1274switch :: HasSpiderTimeline x => Behavior x (Event x a) -> Event x a
1206switch :: HasSpiderTimeline x => Behavior x (Event x a) -> Event x a
1275−switch a = unsafePerformIO $ do
1276− ref <- newIORef Nothing
1277− pure $ eventSwitch $ Switch
1207+switch a = eventSwitch $ Switch
1278− { switchParent = a
1208+ { switchParent = a
1279− , switchSubscribed = ref
1209+ , switchSubscribed = unsafeNewIORef a Nothing
1280− }
1210+ }
1281
1211
1282coincidence :: HasSpiderTimeline x => Event x (Event x a) -> Event x a
1212coincidence :: HasSpiderTimeline x => Event x (Event x a) -> Event x a
1283−coincidence a = unsafePerformIO $ do
1284− ref <- newIORef Nothing
1285− pure $ eventCoincidence $ Coincidence
1213+coincidence a = eventCoincidence $ Coincidence
1286− { coincidenceParent = a
1214+ { coincidenceParent = a
1287− , coincidenceSubscribed = ref
1215+ , coincidenceSubscribed = unsafeNewIORef a Nothing
1288− }
1216+ }
1289
1217
1290-- Propagate the given event occurrence; before cleaning up, run the given action, which may read the state of events and behaviors
1218-- Propagate the given event occurrence; before cleaning up, run the given action, which may read the state of events and behaviors
1291run :: forall x b. HasSpiderTimeline x => [DSum (RootTrigger x) Identity] -> ResultM x b -> SpiderHost x b
1219run :: forall x b. HasSpiderTimeline x => [DSum (RootTrigger x) Identity] -> ResultM x b -> SpiderHost x b
1292run roots after = do
1220run roots after = do
1293 tracePropagate (Proxy :: Proxy x) $ "Running an event frame with " <> show (length roots) <> " events"
1221 tracePropagate (Proxy :: Proxy x) $ "Running an event frame with " <> show (length roots) <> " events"
1294 let t = spiderTimeline :: SpiderTimelineEnv x
1222 let t = spiderTimeline :: SpiderTimelineEnv x
1295− result <- SpiderHost $ withMVar (_spiderTimeline_lock (unSTE t)) $ \_ -> unSpiderHost $ runFrame $ do
1223+ result <- SpiderHost $ withMVar (_spiderTimeline_lock t) $ \_ -> unSpiderHost $ runFrame $ do
1296 rootsToPropagate <- forM roots $ \r@(RootTrigger (_, occRef, k) :=> a) -> do
1224 rootsToPropagate <- forM roots $ \r@(RootTrigger (_, occRef, k) :=> a) -> do
1297 occBefore <- liftIO $ do
1225 occBefore <- liftIO $ do
1298 occBefore <- readIORef occRef
1226 occBefore <- readIORef occRef
@@ -1346,110 +1274,55 @@ mkWeakPtrWithDebug x debugNote = do
1346 x' <- evaluate x
1274 x' <- evaluate x
1347 mkWeakPtr x' $
1275 mkWeakPtr x' $
1348 if debugFinalize
1276 if debugFinalize
1349− then Just $ debugStrLn $ "finalizing: " ++ debugNote
1277+ then Just $ putStrLn $ "finalizing: " ++ debugNote
1350 else Nothing
1278 else Nothing
1351
1279
1352type WeakList a = [Weak a]
1280type WeakList a = [Weak a]
1353
1281
1354−type CanTrace x m = (HasSpiderTimeline x, MonadIO m)
1355−
1356−
1357−
1358−
1359−#ifdef DEBUG
1360−
1361−debugSubscriber :: forall x a. HasSpiderTimeline x => String -> Subscriber x a -> IO (Subscriber x a)
1362−debugSubscriber description = return . debugSubscriber' description
1363−
1364−debugSubscriber' :: forall x a. HasSpiderTimeline x => String -> Subscriber x a -> Subscriber x a
1365−debugSubscriber' description subscribed = Subscriber
1366− {
1367− subscriberPropagate = \m -> do
1368− tracePropagate (Proxy :: Proxy x) ("subscriberPropagate: " <> description)
1369− subscriberPropagate subscribed m
1370− , subscriberInvalidateHeight = \old -> do
1371− traceInvalidateHeight $ "invalidateSubscriberHeight: " <> description <> ", old = " <> show (unHeight old)
1372− subscriberInvalidateHeight subscribed old
1373− traceInvalidateHeight $ "invalidateSubscriberHeight: " <> description <> ", done"
1374− , subscriberRecalculateHeight = \new -> do
1375− traceInvalidateHeight $ "subscriberRecalculateHeight: " <> description <> ", new = " <> show (unHeight new)
1376− subscriberRecalculateHeight subscribed new
1377− traceInvalidateHeight $ "subscriberRecalculateHeight: " <> description <> ", done"
1378− }
1379−
1380−
1381{-# INLINE withIncreasedDepth #-}
1282{-# INLINE withIncreasedDepth #-}
1283+#ifdef DEBUG
1382−withIncreasedDepth :: forall proxy x m a. CanTrace x m => proxy x -> m a -> m a
1284+withIncreasedDepth :: CanTrace x m => m a -> m a
1383−withIncreasedDepth _ a = do
1285+withIncreasedDepth a = do
1286+ spiderTimeline <- askSpiderTimelineEnv
1384− liftIO $ modifyIORef' (_spiderTimeline_depth $ unSTE (spiderTimeline :: SpiderTimelineEnv x)) succ
1287+ liftIO $ modifyIORef' (_spiderTimeline_depth spiderTimeline) succ
1385 result <- a
1288 result <- a
1386− liftIO $ modifyIORef' (_spiderTimeline_depth $ unSTE (spiderTimeline :: SpiderTimelineEnv x)) pred
1289+ liftIO $ modifyIORef' (_spiderTimeline_depth spiderTimeline) pred
1387 return result
1290 return result
1388−
1389−{-# INLINE tracePropagate #-}
1390−tracePropagate :: (CanTrace x m) => proxy x -> String -> m ()
1391−tracePropagate p = when debugPropagate . trace p
1392−
1393−{-# INLINE traceInvalidate #-}
1394−traceInvalidate :: String -> IO ()
1395−traceInvalidate = when debugInvalidate . liftIO . debugStrLn
1396−
1397−{-# INLINE traceInvalidateHeight #-}
1398−traceInvalidateHeight :: String -> IO ()
1399−traceInvalidateHeight = when debugInvalidateHeight . liftIO . debugStrLn
1400−
1401−{-# INLINE trace #-}
1402−trace :: (CanTrace x m) => proxy x -> String -> m ()
1403−trace p message = traceM p $ return message
1404−
1405−{-# INLINE traceM #-}
1406−traceM :: forall x proxy m. (CanTrace x m) => proxy x -> m String -> m ()
1407−traceM _ getMessage = do
1408− message <- getMessage
1409− d <- liftIO $ readIORef $ _spiderTimeline_depth $ unSTE (spiderTimeline :: SpiderTimelineEnv x)
1410− liftIO $ debugStrLn $ replicate d ' ' <> message
1411−
1412#else
1291#else
1292+withIncreasedDepth :: m a -> m a
1293+withIncreasedDepth = id
1294+#endif
1413
1295
1414−{-# INLINE withIncreasedDepth #-}
1296+type CanTrace x m = (HasSpiderTimeline x, MonadIO m)
1415−withIncreasedDepth :: proxy x -> m a -> m a
1416−withIncreasedDepth _ = id
1417
1297
1418{-# INLINE tracePropagate #-}
1298{-# INLINE tracePropagate #-}
1419tracePropagate :: (CanTrace x m) => proxy x -> String -> m ()
1299tracePropagate :: (CanTrace x m) => proxy x -> String -> m ()
1420−tracePropagate _ _ = return ()
1300+tracePropagate p = traceWhen p debugPropagate
1421
1301
1422{-# INLINE traceInvalidate #-}
1302{-# INLINE traceInvalidate #-}
1423traceInvalidate :: String -> IO ()
1303traceInvalidate :: String -> IO ()
1424−traceInvalidate _ = return ()
1304+traceInvalidate = when debugInvalidate . liftIO . putStrLn
1425−
1426−{-# INLINE traceInvalidateHeight #-}
1427−traceInvalidateHeight :: String -> IO ()
1428−traceInvalidateHeight _ = return ()
1429−
1430−{-# INLINE debugSubscriber #-}
1431−debugSubscriber :: String -> Subscriber x a -> IO (Subscriber x a)
1432−debugSubscriber _ = return
1433
1305
1434−{-# INLINE debugSubscriber' #-}
1306+{-# INLINE traceWhen #-}
1435−debugSubscriber' :: String -> Subscriber x a -> Subscriber x a
1436−debugSubscriber' _ = id
1437−
1438−
1439−
1440−{-# INLINE trace #-}
1441−trace :: (CanTrace x m) => proxy x -> String -> m ()
1307+traceWhen :: (CanTrace x m) => proxy x -> Bool -> String -> m ()
1442−trace _ _ = return ()
1308+traceWhen p b message = traceMWhen p b $ return message
1443−
1444−{-# INLINE traceM #-}
1445−traceM :: (CanTrace x m) => proxy x -> m String -> m ()
1446−traceM _ _ = return ()
1447
1309
1310+{-# INLINE traceMWhen #-}
1311+traceMWhen :: (CanTrace x m) => proxy x -> Bool -> m String -> m ()
1312+traceMWhen _ b getMessage = when b $ do
1313+ message <- getMessage
1314+#ifdef DEBUG
1315+ spiderTimeline <- askSpiderTimelineEnv
1316+ d <- liftIO $ readIORef $ _spiderTimeline_depth spiderTimeline
1317+#else
1318+ let d = 0
1448#endif
1319#endif
1320+ liftIO $ putStrLn $ replicate d ' ' <> message
1449
1321
1450whoCreatedIORef :: IORef a -> IO [String]
1322whoCreatedIORef :: IORef a -> IO [String]
1451whoCreatedIORef (IORef a) = whoCreated $! a
1323whoCreatedIORef (IORef a) = whoCreated $! a
1452
1324
1325+#ifdef DEBUG_CYCLES
1453groupByHead :: Eq a => [NonEmpty a] -> [(a, NonEmpty [a])]
1326groupByHead :: Eq a => [NonEmpty a] -> [(a, NonEmpty [a])]
1454groupByHead = \case
1327groupByHead = \case
1455 [] -> []
1328 [] -> []
@@ -1460,54 +1333,20 @@ groupByHead = \case
1460 | otherwise -> (x, xs :| []) : l
1333 | otherwise -> (x, xs :| []) : l
1461
1334
1462listsToForest :: Eq a => [[a]] -> Forest a
1335listsToForest :: Eq a => [[a]] -> Forest a
1463−listsToForest lists = buildForest <$> groupByHead (mapMaybe nonEmpty lists)
1336+listsToForest l = fmap (\(a, l') -> Node a $ listsToForest $ toList l') $ groupByHead $ catMaybes $ fmap nonEmpty l
1464− where buildForest (a, lists') = Node a $ listsToForest $ toList lists'
1465−
1466−showStacks :: [[String]] -> String
1467−showStacks = drawForest . listsToForest . fmap (filterStack "Reflex.Spider.Internal")
1468−
1469−filterStack :: String -> [String] -> [String]
1470−#ifdef DEBUG_HIDE_INTERNALS
1471−filterStack prefix = filter (not . (prefix `isPrefixOf`))
1472−#else
1473−filterStack prefix = id
1474−#endif
1475−
1476−#ifdef DEBUG_CYCLES
1477−
1478−data EventLoopException = EventLoopException [[String]]
1479−instance Exception EventLoopException
1480−
1481−instance Show EventLoopException where
1482− show (EventLoopException stacks) = "causality loop detected:\n" <> if null stacks
1483− then "no location information, compile with profiling enabled for stack tree"
1484− else showStacks stacks
1485−
1486−#else
1487−
1488−data EventLoopException = EventLoopException
1489−instance Exception EventLoopException
1490−
1491−instance Show EventLoopException where
1492− show EventLoopException = "causality loop detected: \n" <>
1493− "compile reflex with flag 'debug-cycles' and compile with profiling enabled for stack tree"
1494−
1495#endif
1337#endif
1496
1338
1497−
1498{-# INLINE propagateSubscriberHold #-}
1339{-# INLINE propagateSubscriberHold #-}
1499propagateSubscriberHold :: forall x p. (HasSpiderTimeline x, Patch p) => Hold x p -> p -> EventM x ()
1340propagateSubscriberHold :: forall x p. (HasSpiderTimeline x, Patch p) => Hold x p -> p -> EventM x ()
1500propagateSubscriberHold h a = do
1341propagateSubscriberHold h a = do
1501− {-# SCC "trace" #-} when debugPropagate $ traceM (Proxy :: Proxy x) $ liftIO $ do
1342+ {-# SCC "trace" #-} traceMWhen (Proxy :: Proxy x) debugPropagate $ liftIO $ do
1502 invalidators <- liftIO $ readIORef $ holdInvalidators h
1343 invalidators <- liftIO $ readIORef $ holdInvalidators h
1503 return $ "SubscriberHold" <> showNodeId h <> ": " ++ show (length invalidators)
1344 return $ "SubscriberHold" <> showNodeId h <> ": " ++ show (length invalidators)
1504−
1505 v <- {-# SCC "read" #-} liftIO $ readIORef $ holdValue h
1345 v <- {-# SCC "read" #-} liftIO $ readIORef $ holdValue h
1506 case {-# SCC "apply" #-} apply a v of
1346 case {-# SCC "apply" #-} apply a v of
1507 Nothing -> return ()
1347 Nothing -> return ()
1508 Just v' -> do
1348 Just v' -> do
1509− {-# SCC "trace2" #-} withIncreasedDepth (Proxy :: Proxy x) $
1510− tracePropagate (Proxy :: Proxy x) ("propagateSubscriberHold: assigning Hold" <> showNodeId h)
1349+ {-# SCC "trace2" #-} withIncreasedDepth $ tracePropagate (Proxy :: Proxy x) $ "propagateSubscriberHold: assigning Hold" <> showNodeId h
1511 vRef <- {-# SCC "vRef" #-} liftIO $ evaluate $ holdValue h
1350 vRef <- {-# SCC "vRef" #-} liftIO $ evaluate $ holdValue h
1512 iRef <- {-# SCC "iRef" #-} liftIO $ evaluate $ holdInvalidators h
1351 iRef <- {-# SCC "iRef" #-} liftIO $ evaluate $ holdInvalidators h
1513 defer $ {-# SCC "assignment" #-} SomeAssignment vRef iRef v'
1352 defer $ {-# SCC "assignment" #-} SomeAssignment vRef iRef v'
@@ -1515,25 +1354,25 @@ propagateSubscriberHold h a = do
1515data SomeResetCoincidence x = forall a. SomeResetCoincidence !(EventSubscription x) !(Maybe (CoincidenceSubscribed x a)) -- The CoincidenceSubscriber will be present only if heights need to be reset
1354data SomeResetCoincidence x = forall a. SomeResetCoincidence !(EventSubscription x) !(Maybe (CoincidenceSubscribed x a)) -- The CoincidenceSubscriber will be present only if heights need to be reset
1516
1355
1517runBehaviorM :: BehaviorM x a -> Maybe (Weak (Invalidator x), IORef [SomeBehaviorSubscribed x]) -> IORef [SomeHoldInit x] -> IO a
1356runBehaviorM :: BehaviorM x a -> Maybe (Weak (Invalidator x), IORef [SomeBehaviorSubscribed x]) -> IORef [SomeHoldInit x] -> IO a
1518−runBehaviorM a mwi holdInits = runReaderIO (unBehaviorM a) (mwi, holdInits)
1357+runBehaviorM a mwi holdInits = runReaderT (unBehaviorM a) (mwi, holdInits)
1519
1358
1520askInvalidator :: BehaviorM x (Maybe (Weak (Invalidator x)))
1359askInvalidator :: BehaviorM x (Maybe (Weak (Invalidator x)))
1521askInvalidator = do
1360askInvalidator = do
1522− (!m, _) <- ask
1361+ (!m, _) <- BehaviorM ask
1523 case m of
1362 case m of
1524 Nothing -> return Nothing
1363 Nothing -> return Nothing
1525 Just (!wi, _) -> return $ Just wi
1364 Just (!wi, _) -> return $ Just wi
1526
1365
1527askParentsRef :: BehaviorM x (Maybe (IORef [SomeBehaviorSubscribed x]))
1366askParentsRef :: BehaviorM x (Maybe (IORef [SomeBehaviorSubscribed x]))
1528askParentsRef = do
1367askParentsRef = do
1529− (!m, _) <- ask
1368+ (!m, _) <- BehaviorM ask
1530 case m of
1369 case m of
1531 Nothing -> return Nothing
1370 Nothing -> return Nothing
1532 Just (_, !p) -> return $ Just p
1371 Just (_, !p) -> return $ Just p
1533
1372
1534askBehaviorHoldInits :: BehaviorM x (IORef [SomeHoldInit x])
1373askBehaviorHoldInits :: BehaviorM x (IORef [SomeHoldInit x])
1535askBehaviorHoldInits = do
1374askBehaviorHoldInits = do
1536− (_, !his) <- ask
1375+ (_, !his) <- BehaviorM ask
1537 return his
1376 return his
1538
1377
1539{-# INLINE getDynHold #-}
1378{-# INLINE getDynHold #-}
@@ -1561,7 +1400,7 @@ getDynHold d = do
1561zeroRef :: IORef Height
1400zeroRef :: IORef Height
1562zeroRef = unsafePerformIO $ newIORef zeroHeight
1401zeroRef = unsafePerformIO $ newIORef zeroHeight
1563
1402
1564−getRootSubscribed :: forall k x a. (GCompare k, HasSpiderTimeline x) => k a -> Root x k -> Subscriber x a -> IO (WeakBagTicket, RootSubscribed x a, Maybe a)
1403+getRootSubscribed :: GCompare k => k a -> Root x k -> Subscriber x a -> IO (WeakBagTicket, RootSubscribed x a, Maybe a)
1565getRootSubscribed k r sub = do
1404getRootSubscribed k r sub = do
1566 mSubscribed <- readIORef $ rootSubscribed r
1405 mSubscribed <- readIORef $ rootSubscribed r
1567 let getOcc = fmap (coerce . DMap.lookup k) $ readIORef $ rootOccurrence r
1406 let getOcc = fmap (coerce . DMap.lookup k) $ readIORef $ rootOccurrence r
@@ -1575,14 +1414,9 @@ getRootSubscribed k r sub = do
1575 let !cached = rootSubscribed r
1414 let !cached = rootSubscribed r
1576 uninitRef <- newIORef $ error "getRootsubscribed: uninitRef not initialized"
1415 uninitRef <- newIORef $ error "getRootsubscribed: uninitRef not initialized"
1577 (subs, sln) <- WeakBag.singleton sub weakSelf cleanupRootSubscribed
1416 (subs, sln) <- WeakBag.singleton sub weakSelf cleanupRootSubscribed
1578−
1579− tracePropagate (Proxy::Proxy x) $ "getRootSubscribed: calling rootInit"
1417+ when debugPropagate $ putStrLn $ "getRootSubscribed: calling rootInit"
1580−
1581 uninit <- rootInit r k $ RootTrigger (subs, rootOccurrence r, k)
1418 uninit <- rootInit r k $ RootTrigger (subs, rootOccurrence r, k)
1582 writeIORef uninitRef $! uninit
1419 writeIORef uninitRef $! uninit
1583−#ifdef DEBUG_NODEIDS
1584− nid <- newNodeId
1585−#endif
1586 let !subscribed = RootSubscribed
1420 let !subscribed = RootSubscribed
1587 { rootSubscribedKey = k
1421 { rootSubscribedKey = k
1588 , rootSubscribedCachedSubscribed = cached
1422 , rootSubscribedCachedSubscribed = cached
@@ -1591,7 +1425,7 @@ getRootSubscribed k r sub = do
1591 , rootSubscribedUninit = uninit
1425 , rootSubscribedUninit = uninit
1592 , rootSubscribedWeakSelf = weakSelf
1426 , rootSubscribedWeakSelf = weakSelf
1593#ifdef DEBUG_NODEIDS
1427#ifdef DEBUG_NODEIDS
1594− , rootSubscribedNodeId = nid
1428+ , rootSubscribedNodeId = unsafeNodeId (k, r, subs)
1595#endif
1429#endif
1596 }
1430 }
1597 -- If we die at the same moment that all our children die, they will
1431 -- If we die at the same moment that all our children die, they will
@@ -1627,9 +1461,6 @@ data FanInt x a = FanInt
1627 { _fanInt_subscribers :: {-# UNPACK #-} !(FastMutableIntMap (FastWeakBag (Subscriber x a))) --TODO: Clean up the keys in here when their child weak bags get empty --TODO: Remove our own subscription when the subscribers list is completely empty
1461 { _fanInt_subscribers :: {-# UNPACK #-} !(FastMutableIntMap (FastWeakBag (Subscriber x a))) --TODO: Clean up the keys in here when their child weak bags get empty --TODO: Remove our own subscription when the subscribers list is completely empty
1628 , _fanInt_subscriptionRef :: {-# UNPACK #-} !(IORef (EventSubscription x)) -- This should have a valid subscription iff subscribers is non-empty
1462 , _fanInt_subscriptionRef :: {-# UNPACK #-} !(IORef (EventSubscription x)) -- This should have a valid subscription iff subscribers is non-empty
1629 , _fanInt_occRef :: {-# UNPACK #-} !(IORef (IntMap a))
1463 , _fanInt_occRef :: {-# UNPACK #-} !(IORef (IntMap a))
1630−#ifdef DEBUG_NODEIDS
1631− , _fanInt_nodeId :: {-# UNPACK #-} !Int
1632−#endif
1633 }
1464 }
1634
1465
1635newFanInt :: IO (FanInt x a)
1466newFanInt :: IO (FanInt x a)
@@ -1637,39 +1468,38 @@ newFanInt = do
1637 subscribers <- FastMutableIntMap.newEmpty --TODO: Clean up the keys in here when their child weak bags get empty --TODO: Remove our own subscription when the subscribers list is completely empty
1468 subscribers <- FastMutableIntMap.newEmpty --TODO: Clean up the keys in here when their child weak bags get empty --TODO: Remove our own subscription when the subscribers list is completely empty
1638 subscriptionRef <- newIORef $ error "fanInt: no subscription"
1469 subscriptionRef <- newIORef $ error "fanInt: no subscription"
1639 occRef <- newIORef $ error "fanInt: no occurrence"
1470 occRef <- newIORef $ error "fanInt: no occurrence"
1640−#ifdef DEBUG_NODEIDS
1641− nodeId <- newNodeId
1642−#endif
1643 return $ FanInt
1471 return $ FanInt
1644 { _fanInt_subscribers = subscribers
1472 { _fanInt_subscribers = subscribers
1645 , _fanInt_subscriptionRef = subscriptionRef
1473 , _fanInt_subscriptionRef = subscriptionRef
1646 , _fanInt_occRef = occRef
1474 , _fanInt_occRef = occRef
1647−#ifdef DEBUG_NODEIDS
1648− , _fanInt_nodeId = nodeId
1649−#endif
1650 }
1475 }
1651
1476
1477+{-# NOINLINE unsafeNewFanInt #-}
1478+unsafeNewFanInt :: b -> FanInt x a
1479+unsafeNewFanInt b = unsafePerformIO $ do
1480+ touch b
1481+ newFanInt
1482+
1652fanInt :: HasSpiderTimeline x => Event x (IntMap a) -> EventSelectorInt x a
1483fanInt :: HasSpiderTimeline x => Event x (IntMap a) -> EventSelectorInt x a
1653−fanInt p = unsafePerformIO $ do
1484+fanInt p =
1654− self <- newFanInt
1485+ let self = unsafeNewFanInt p
1655− pure $ EventSelectorInt $ \k -> Event $ \sub -> do
1486+ in EventSelectorInt $ \k -> Event $ \sub -> do
1656 isEmpty <- liftIO $ FastMutableIntMap.isEmpty (_fanInt_subscribers self)
1487 isEmpty <- liftIO $ FastMutableIntMap.isEmpty (_fanInt_subscribers self)
1657 when isEmpty $ do -- This is the first subscriber, so we need to subscribe to our input
1488 when isEmpty $ do -- This is the first subscriber, so we need to subscribe to our input
1658− let desc = "fanInt" <> showNodeId self <> ", k = " <> show k
1659− (subscription, parentOcc) <- subscribeAndRead p $ debugSubscriber' desc $ Subscriber
1489+ (subscription, parentOcc) <- subscribeAndRead p $ Subscriber
1660 { subscriberPropagate = \m -> do
1490 { subscriberPropagate = \m -> do
1661 liftIO $ writeIORef (_fanInt_occRef self) m
1491 liftIO $ writeIORef (_fanInt_occRef self) m
1662 scheduleIntClear $ _fanInt_occRef self
1492 scheduleIntClear $ _fanInt_occRef self
1663− FastMutableIntMap.forIntersectionWithImmutable_ (_fanInt_subscribers self) m $ \b v -> --TODO: Do we need to know that no subscribers are being added as we traverse?
1493+ FastMutableIntMap.forIntersectionWithImmutable_ (_fanInt_subscribers self) m $ \b v -> do --TODO: Do we need to know that no subscribers are being added as we traverse?
1664− FastWeakBag.traverse_ b $ \s ->
1494+ FastWeakBag.traverse b $ \s -> do
1665 subscriberPropagate s v
1495 subscriberPropagate s v
1666− , subscriberInvalidateHeight = \old ->
1496+ , subscriberInvalidateHeight = \old -> do
1667− FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b ->
1497+ FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b -> do
1668− FastWeakBag.traverse_ b $ \s ->
1498+ FastWeakBag.traverse b $ \s -> do
1669 subscriberInvalidateHeight s old
1499 subscriberInvalidateHeight s old
1670− , subscriberRecalculateHeight = \new ->
1500+ , subscriberRecalculateHeight = \new -> do
1671− FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b ->
1501+ FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b -> do
1672− FastWeakBag.traverse_ b $ \s ->
1502+ FastWeakBag.traverse b $ \s -> do
1673 subscriberRecalculateHeight s new
1503 subscriberRecalculateHeight s new
1674 }
1504 }
1675 liftIO $ do
1505 liftIO $ do
@@ -1683,28 +1513,13 @@ fanInt p = unsafePerformIO $ do
1683 FastMutableIntMap.insert (_fanInt_subscribers self) k b
1513 FastMutableIntMap.insert (_fanInt_subscribers self) k b
1684 return b
1514 return b
1685 Just b -> return b
1515 Just b -> return b
1686− ticket <- liftIO $ FastWeakBag.insert sub b
1516+ t <- liftIO $ FastWeakBag.insert sub b
1687 currentOcc <- readIORef (_fanInt_occRef self)
1517 currentOcc <- readIORef (_fanInt_occRef self)
1688−
1518+ (EventSubscription _ (EventSubscribed !heightRef _)) <- readIORef (_fanInt_subscriptionRef self)
1689− subscribed <- fanIntSubscribed ticket self
1690− return (EventSubscription (FastWeakBag.remove ticket) subscribed, IntMap.lookup k currentOcc)
1519+ return (EventSubscription (FastWeakBag.remove t) $! EventSubscribed heightRef $! toAny (_fanInt_subscriptionRef self, t), IntMap.lookup k currentOcc)
1691−
1692−fanIntSubscribed :: FastWeakBagTicket k -> FanInt x a -> IO (EventSubscribed x)
1693−fanIntSubscribed ticket self = do
1694− subscribedParent <- _eventSubscription_subscribed <$> readIORef (_fanInt_subscriptionRef self)
1695− return $ EventSubscribed
1696− { eventSubscribedHeightRef = eventSubscribedHeightRef subscribedParent
1697− , eventSubscribedRetained = toAny (_fanInt_subscriptionRef self, ticket)
1698−#ifdef DEBUG_CYCLES
1699− , eventSubscribedGetParents = return [subscribedParent]
1700− , eventSubscribedHasOwnHeightRef = False
1701− , eventSubscribedWhoCreated = whoCreatedIORef $ _fanInt_subscriptionRef self
1702−#endif
1703− }
1704−
1705
1520
1706{-# INLINABLE getFanSubscribed #-}
1521{-# INLINABLE getFanSubscribed #-}
1707−getFanSubscribed :: (HasSpiderTimeline x, GCompare k) => k a -> Fan x k v -> Subscriber x (v a) -> EventM x (WeakBagTicket, FanSubscribed x k v, Maybe (v a))
1522+getFanSubscribed :: (HasSpiderTimeline x, GCompare k) => k a -> Fan x k -> Subscriber x a -> EventM x (WeakBagTicket, FanSubscribed x k, Maybe a)
1708getFanSubscribed k f sub = do
1523getFanSubscribed k f sub = do
1709 mSubscribed <- liftIO $ readIORef $ fanSubscribed f
1524 mSubscribed <- liftIO $ readIORef $ fanSubscribed f
1710 case mSubscribed of
1525 case mSubscribed of
@@ -1722,16 +1537,13 @@ getFanSubscribed k f sub = do
1722 subscribersRef <- liftIO $ newIORef $ error "getFanSubscribed: subscribersRef not yet initialized"
1537 subscribersRef <- liftIO $ newIORef $ error "getFanSubscribed: subscribersRef not yet initialized"
1723 occRef <- liftIO $ newIORef parentOcc
1538 occRef <- liftIO $ newIORef parentOcc
1724 when (isJust parentOcc) $ scheduleClear occRef
1539 when (isJust parentOcc) $ scheduleClear occRef
1725−#ifdef DEBUG_NODEIDS
1726− nid <- liftIO newNodeId
1727−#endif
1728 let subscribed = FanSubscribed
1540 let subscribed = FanSubscribed
1729 { fanSubscribedCachedSubscribed = fanSubscribed f
1541 { fanSubscribedCachedSubscribed = fanSubscribed f
1730 , fanSubscribedOccurrence = occRef
1542 , fanSubscribedOccurrence = occRef
1731 , fanSubscribedParent = subscription
1543 , fanSubscribedParent = subscription
1732 , fanSubscribedSubscribers = subscribersRef
1544 , fanSubscribedSubscribers = subscribersRef
1733#ifdef DEBUG_NODEIDS
1545#ifdef DEBUG_NODEIDS
1734− , fanSubscribedNodeId = nid
1546+ , fanSubscribedNodeId = unsafeNodeId f
1735#endif
1547#endif
1736 }
1548 }
1737 let !self = (k, subscribed)
1549 let !self = (k, subscribed)
@@ -1741,7 +1553,7 @@ getFanSubscribed k f sub = do
1741 liftIO $ writeIORef (fanSubscribed f) $ Just subscribed
1553 liftIO $ writeIORef (fanSubscribed f) $ Just subscribed
1742 return (slnForSub, subscribed, coerce $ DMap.lookup k =<< parentOcc)
1554 return (slnForSub, subscribed, coerce $ DMap.lookup k =<< parentOcc)
1743
1555
1744−cleanupFanSubscribed :: GCompare k => (k a, FanSubscribed x k v) -> IO ()
1556+cleanupFanSubscribed :: GCompare k => (k a, FanSubscribed x k) -> IO ()
1745cleanupFanSubscribed (k, subscribed) = do
1557cleanupFanSubscribed (k, subscribed) = do
1746 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
1558 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
1747 let reducedSubscribers = DMap.delete k subscribers
1559 let reducedSubscribers = DMap.delete k subscribers
@@ -1753,7 +1565,7 @@ cleanupFanSubscribed (k, subscribed) = do
1753 else writeIORef (fanSubscribedSubscribers subscribed) $! reducedSubscribers
1565 else writeIORef (fanSubscribedSubscribers subscribed) $! reducedSubscribers
1754
1566
1755{-# INLINE subscribeFanSubscribed #-}
1567{-# INLINE subscribeFanSubscribed #-}
1756−subscribeFanSubscribed :: GCompare k => k a -> FanSubscribed x k v -> Subscriber x (v a) -> IO WeakBagTicket
1568+subscribeFanSubscribed :: GCompare k => k a -> FanSubscribed x k -> Subscriber x a -> IO WeakBagTicket
1757subscribeFanSubscribed k subscribed sub = do
1569subscribeFanSubscribed k subscribed sub = do
1758 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
1570 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
1759 case DMap.lookup k subscribers of
1571 case DMap.lookup k subscribers of
@@ -1791,9 +1603,6 @@ getSwitchSubscribed s sub = do
1791 when (isJust parentOcc) $ scheduleClear occRef
1603 when (isJust parentOcc) $ scheduleClear occRef
1792 weakSelf <- liftIO $ newIORef $ error "getSwitchSubscribed: weakSelf not yet initialized"
1604 weakSelf <- liftIO $ newIORef $ error "getSwitchSubscribed: weakSelf not yet initialized"
1793 (subs, slnForSub) <- liftIO $ WeakBag.singleton sub weakSelf cleanupSwitchSubscribed
1605 (subs, slnForSub) <- liftIO $ WeakBag.singleton sub weakSelf cleanupSwitchSubscribed
1794−#ifdef DEBUG_NODEIDS
1795− nid <- liftIO newNodeId
1796−#endif
1797 let !subscribed = SwitchSubscribed
1606 let !subscribed = SwitchSubscribed
1798 { switchSubscribedCachedSubscribed = switchSubscribed s
1607 { switchSubscribedCachedSubscribed = switchSubscribed s
1799 , switchSubscribedOccurrence = occRef
1608 , switchSubscribedOccurrence = occRef
@@ -1806,7 +1615,7 @@ getSwitchSubscribed s sub = do
1806 , switchSubscribedCurrentParent = subscriptionRef
1615 , switchSubscribedCurrentParent = subscriptionRef
1807 , switchSubscribedWeakSelf = weakSelf
1616 , switchSubscribedWeakSelf = weakSelf
1808#ifdef DEBUG_NODEIDS
1617#ifdef DEBUG_NODEIDS
1809− , switchSubscribedNodeId = nid
1618+ , switchSubscribedNodeId = unsafeNodeId s
1810#endif
1619#endif
1811 }
1620 }
1812 liftIO $ writeIORef weakSelf =<< evaluate =<< mkWeakPtrWithDebug subscribed "switchSubscribedWeakSelf"
1621 liftIO $ writeIORef weakSelf =<< evaluate =<< mkWeakPtrWithDebug subscribed "switchSubscribedWeakSelf"
@@ -1851,9 +1660,6 @@ getCoincidenceSubscribed c sub = do
1851 scheduleClear innerSubdRef
1660 scheduleClear innerSubdRef
1852 weakSelf <- liftIO $ newIORef $ error "getCoincidenceSubscribed: weakSelf not yet implemented"
1661 weakSelf <- liftIO $ newIORef $ error "getCoincidenceSubscribed: weakSelf not yet implemented"
1853 (subs, slnForSub) <- liftIO $ WeakBag.singleton sub weakSelf cleanupCoincidenceSubscribed
1662 (subs, slnForSub) <- liftIO $ WeakBag.singleton sub weakSelf cleanupCoincidenceSubscribed
1854−#ifdef DEBUG_NODEIDS
1855− nid <- liftIO newNodeId
1856−#endif
1857 let subscribed = CoincidenceSubscribed
1663 let subscribed = CoincidenceSubscribed
1858 { coincidenceSubscribedCachedSubscribed = coincidenceSubscribed c
1664 { coincidenceSubscribedCachedSubscribed = coincidenceSubscribed c
1859 , coincidenceSubscribedOccurrence = occRef
1665 , coincidenceSubscribedOccurrence = occRef
@@ -1864,7 +1670,7 @@ getCoincidenceSubscribed c sub = do
1864 , coincidenceSubscribedInnerParent = innerSubdRef
1670 , coincidenceSubscribedInnerParent = innerSubdRef
1865 , coincidenceSubscribedWeakSelf = weakSelf
1671 , coincidenceSubscribedWeakSelf = weakSelf
1866#ifdef DEBUG_NODEIDS
1672#ifdef DEBUG_NODEIDS
1867− , coincidenceSubscribedNodeId = nid
1673+ , coincidenceSubscribedNodeId = unsafeNodeId c
1868#endif
1674#endif
1869 }
1675 }
1870 liftIO $ writeIORef weakSelf =<< evaluate =<< mkWeakPtrWithDebug subscribed "CoincidenceSubscribed"
1676 liftIO $ writeIORef weakSelf =<< evaluate =<< mkWeakPtrWithDebug subscribed "CoincidenceSubscribed"
@@ -1881,72 +1687,57 @@ cleanupCoincidenceSubscribed subscribed = do
1881subscribeCoincidenceSubscribed :: CoincidenceSubscribed x a -> Subscriber x a -> IO WeakBagTicket
1687subscribeCoincidenceSubscribed :: CoincidenceSubscribed x a -> Subscriber x a -> IO WeakBagTicket
1882subscribeCoincidenceSubscribed subscribed sub = WeakBag.insert sub (coincidenceSubscribedSubscribers subscribed) (coincidenceSubscribedWeakSelf subscribed) cleanupCoincidenceSubscribed
1688subscribeCoincidenceSubscribed subscribed sub = WeakBag.insert sub (coincidenceSubscribedSubscribers subscribed) (coincidenceSubscribedWeakSelf subscribed) cleanupCoincidenceSubscribed
1883
1689
1884−{-# INLINE mergeG #-}
1690+{-# INLINE merge #-}
1885−mergeG :: forall k q x v. (HasSpiderTimeline x, GCompare k)
1691+merge :: forall k x. (HasSpiderTimeline x, GCompare k) => Dynamic x (PatchDMap k (Event x)) -> Event x (DMap k Identity)
1886− => (forall a. q a -> Event x (v a))
1887− -> DynamicS x (PatchDMap k q) -> Event x (DMap k v)
1888−mergeG nt d = cacheEvent (mergeCheap nt d)
1692+merge d = cacheEvent (mergeCheap d)
1889
1693
1890{-# INLINE mergeWithMove #-}
1694{-# INLINE mergeWithMove #-}
1891−mergeWithMove :: forall k v q x. (HasSpiderTimeline x, GCompare k)
1695+mergeWithMove :: forall k x. (HasSpiderTimeline x, GCompare k) => Dynamic x (PatchDMapWithMove k (Event x)) -> Event x (DMap k Identity)
1892− => (forall a. q a -> Event x (v a))
1893− -> DynamicS x (PatchDMapWithMove k q) -> Event x (DMap k v)
1894−mergeWithMove nt d = cacheEvent (mergeCheapWithMove nt d)
1696+mergeWithMove d = cacheEvent (mergeCheapWithMove d)
1895
1697
1896{-# INLINE [1] mergeCheap #-}
1698{-# INLINE [1] mergeCheap #-}
1897−mergeCheap
1898− :: forall k x q v. (HasSpiderTimeline x, GCompare k)
1699+mergeCheap :: forall k x. (HasSpiderTimeline x, GCompare k) => Dynamic x (PatchDMap k (Event x)) -> Event x (DMap k Identity)
1899− => (forall a. q a -> Event x (v a))
1900− -> DynamicS x (PatchDMap k q)
1901− -> Event x (DMap k v)
1902−mergeCheap nt = mergeGCheap' unMergeSubscribedParent getInitialSubscribers updateMe destroy
1700+mergeCheap = mergeCheap' getInitialSubscribers updateMe destroy
1903 where
1701 where
1904− updateMe :: MergeUpdateFunc k v x (PatchDMap k q) (MergeSubscribedParent x)
1702+ updateMe :: MergeUpdateFunc k x (PatchDMap k (Event x)) (MergeSubscribedParent x)
1905 updateMe subscriber heightBagRef oldParents (PatchDMap p) = do
1703 updateMe subscriber heightBagRef oldParents (PatchDMap p) = do
1906 let f (subscriptionsToKill, ps) (k :=> ComposeMaybe me) = do
1704 let f (subscriptionsToKill, ps) (k :=> ComposeMaybe me) = do
1907 (mOldSubd, newPs) <- case me of
1705 (mOldSubd, newPs) <- case me of
1908 Nothing -> return $ DMap.updateLookupWithKey (\_ _ -> Nothing) k ps
1706 Nothing -> return $ DMap.updateLookupWithKey (\_ _ -> Nothing) k ps
1909 Just e -> do
1707 Just e -> do
1910 let s = subscriber $ return k
1708 let s = subscriber $ return k
1911− subscription@(EventSubscription _ subd) <- subscribe (nt e) s
1709+ subscription@(EventSubscription _ subd) <- subscribe e s
1912 newParentHeight <- liftIO $ getEventSubscribedHeight subd
1710 newParentHeight <- liftIO $ getEventSubscribedHeight subd
1913 let newParent = MergeSubscribedParent subscription
1711 let newParent = MergeSubscribedParent subscription
1914 liftIO $ modifyIORef' heightBagRef $ heightBagAdd newParentHeight
1712 liftIO $ modifyIORef' heightBagRef $ heightBagAdd newParentHeight
1915 return $ DMap.insertLookupWithKey' (\_ new _ -> new) k newParent ps
1713 return $ DMap.insertLookupWithKey' (\_ new _ -> new) k newParent ps
1916 forM_ mOldSubd $ \oldSubd -> do
1714 forM_ mOldSubd $ \oldSubd -> do
1917− oldHeight <- liftIO $ getEventSubscribedHeight $
1918− _eventSubscription_subscribed $ unMergeSubscribedParent oldSubd
1715+ oldHeight <- liftIO $ getEventSubscribedHeight $ _eventSubscription_subscribed $ unMergeSubscribedParent oldSubd
1919−
1920 liftIO $ modifyIORef heightBagRef $ heightBagRemove oldHeight
1716 liftIO $ modifyIORef heightBagRef $ heightBagRemove oldHeight
1921 return (maybeToList (unMergeSubscribedParent <$> mOldSubd) ++ subscriptionsToKill, newPs)
1717 return (maybeToList (unMergeSubscribedParent <$> mOldSubd) ++ subscriptionsToKill, newPs)
1922 foldM f ([], oldParents) $ DMap.toList p
1718 foldM f ([], oldParents) $ DMap.toList p
1923−
1924− getInitialSubscribers :: MergeInitFunc k v q x (MergeSubscribedParent x)
1719+ getInitialSubscribers :: MergeInitFunc k x (MergeSubscribedParent x)
1925 getInitialSubscribers initialParents subscriber = do
1720 getInitialSubscribers initialParents subscriber = do
1926 subscribers <- forM (DMap.toList initialParents) $ \(k :=> e) -> do
1721 subscribers <- forM (DMap.toList initialParents) $ \(k :=> e) -> do
1927 let s = subscriber $ return k
1722 let s = subscriber $ return k
1928− (subscription@(EventSubscription _ parentSubd), parentOcc) <- subscribeAndRead (nt e) s
1723+ (subscription@(EventSubscription _ parentSubd), parentOcc) <- subscribeAndRead e s
1929 height <- liftIO $ getEventSubscribedHeight parentSubd
1724 height <- liftIO $ getEventSubscribedHeight parentSubd
1930− return (fmap (k :=>) parentOcc, height, k :=> MergeSubscribedParent subscription)
1725+ return (fmap (\x -> k :=> Identity x) parentOcc, height, k :=> MergeSubscribedParent subscription)
1931 return ( DMap.fromDistinctAscList $ mapMaybe (\(x, _, _) -> x) subscribers
1726 return ( DMap.fromDistinctAscList $ mapMaybe (\(x, _, _) -> x) subscribers
1932 , fmap (\(_, h, _) -> h) subscribers --TODO: Assert that there's no invalidHeight in here
1727 , fmap (\(_, h, _) -> h) subscribers --TODO: Assert that there's no invalidHeight in here
1933 , DMap.fromDistinctAscList $ map (\(_, _, x) -> x) subscribers
1728 , DMap.fromDistinctAscList $ map (\(_, _, x) -> x) subscribers
1934 )
1729 )
1935−
1936 destroy :: MergeDestroyFunc k (MergeSubscribedParent x)
1730 destroy :: MergeDestroyFunc k (MergeSubscribedParent x)
1937 destroy s = forM_ (DMap.toList s) $ \(_ :=> MergeSubscribedParent sub) -> unsubscribe sub
1731 destroy s = forM_ (DMap.toList s) $ \(_ :=> MergeSubscribedParent sub) -> unsubscribe sub
1938
1732
1939{-# INLINE [1] mergeCheapWithMove #-}
1733{-# INLINE [1] mergeCheapWithMove #-}
1940−mergeCheapWithMove :: forall k x v q. (HasSpiderTimeline x, GCompare k)
1734+mergeCheapWithMove :: forall k x. (HasSpiderTimeline x, GCompare k) => Dynamic x (PatchDMapWithMove k (Event x)) -> Event x (DMap k Identity)
1941− => (forall a. q a -> Event x (v a))
1942− -> DynamicS x (PatchDMapWithMove k q)
1943− -> Event x (DMap k v)
1944−mergeCheapWithMove nt = mergeGCheap' _mergeSubscribedParentWithMove_subscription getInitialSubscribers updateMe destroy
1735+mergeCheapWithMove = mergeCheap' getInitialSubscribers updateMe destroy
1945 where
1736 where
1946− updateMe :: MergeUpdateFunc k v x (PatchDMapWithMove k q) (MergeSubscribedParentWithMove x k)
1737+ updateMe :: MergeUpdateFunc k x (PatchDMapWithMove k (Event x)) (MergeSubscribedParentWithMove x k)
1947 updateMe subscriber heightBagRef oldParents p = do
1738 updateMe subscriber heightBagRef oldParents p = do
1948 -- Prepare new parents for insertion
1739 -- Prepare new parents for insertion
1949− let subscribeParent :: forall a. k a -> Event x (v a) -> EventM x (MergeSubscribedParentWithMove x k a)
1740+ let subscribeParent :: forall a. k a -> Event x a -> EventM x (MergeSubscribedParentWithMove x k a)
1950 subscribeParent k e = do
1741 subscribeParent k e = do
1951 keyRef <- liftIO $ newIORef k
1742 keyRef <- liftIO $ newIORef k
1952 let s = subscriber $ liftIO $ readIORef keyRef
1743 let s = subscriber $ liftIO $ readIORef keyRef
@@ -1955,82 +1746,73 @@ mergeCheapWithMove nt = mergeGCheap' _mergeSubscribedParentWithMove_subscription
1955 newParentHeight <- getEventSubscribedHeight subd
1746 newParentHeight <- getEventSubscribedHeight subd
1956 modifyIORef' heightBagRef $ heightBagAdd newParentHeight
1747 modifyIORef' heightBagRef $ heightBagAdd newParentHeight
1957 return $ MergeSubscribedParentWithMove subscription keyRef
1748 return $ MergeSubscribedParentWithMove subscription keyRef
1958− p' <- PatchDMapWithMove.traversePatchDMapWithMoveWithKey (\k q -> subscribeParent k (nt q)) p
1749+ p' <- PatchDMapWithMove.traversePatchDMapWithMoveWithKey subscribeParent p
1959 -- Collect old parents for deletion and update the keys of moved parents
1750 -- Collect old parents for deletion and update the keys of moved parents
1960− let moveOrDelete :: forall a. k a -> PatchDMapWithMove.NodeInfo k q a -> MergeSubscribedParentWithMove x k a -> Constant (EventM x (Maybe (EventSubscription x))) a
1751+ let moveOrDelete :: forall a. k a -> PatchDMapWithMove.NodeInfo k (Event x) a -> MergeSubscribedParentWithMove x k a -> Constant (EventM x (Maybe (EventSubscription x))) a
1961 moveOrDelete _ ni parent = Constant $ case getComposeMaybe $ PatchDMapWithMove._nodeInfo_to ni of
1752 moveOrDelete _ ni parent = Constant $ case getComposeMaybe $ PatchDMapWithMove._nodeInfo_to ni of
1962 Nothing -> do
1753 Nothing -> do
1963− oldHeight <- liftIO $ getEventSubscribedHeight $ _eventSubscription_subscribed $
1754+ oldHeight <- liftIO $ getEventSubscribedHeight $ _eventSubscription_subscribed $ _mergeSubscribedParentWithMove_subscription parent
1964− _mergeSubscribedParentWithMove_subscription parent
1965−
1966 liftIO $ modifyIORef heightBagRef $ heightBagRemove oldHeight
1755 liftIO $ modifyIORef heightBagRef $ heightBagRemove oldHeight
1967 return $ Just $ _mergeSubscribedParentWithMove_subscription parent
1756 return $ Just $ _mergeSubscribedParentWithMove_subscription parent
1968 Just toKey -> do
1757 Just toKey -> do
1969 liftIO $ writeIORef (_mergeSubscribedParentWithMove_key parent) $! toKey
1758 liftIO $ writeIORef (_mergeSubscribedParentWithMove_key parent) $! toKey
1970 return Nothing
1759 return Nothing
1971− toDelete <- fmap catMaybes $ mapM (\(_ :=> v) -> getConstant v) $ DMap.toList $
1972− DMap.intersectionWithKey moveOrDelete (unPatchDMapWithMove p) oldParents
1760+ toDelete <- fmap catMaybes $ mapM (\(_ :=> v) -> getConstant v) $ DMap.toList $ DMap.intersectionWithKey moveOrDelete (unPatchDMapWithMove p) oldParents
1973−
1974 return (toDelete, applyAlways p' oldParents)
1761 return (toDelete, applyAlways p' oldParents)
1975− getInitialSubscribers :: MergeInitFunc k v q x (MergeSubscribedParentWithMove x k)
1762+ getInitialSubscribers :: MergeInitFunc k x (MergeSubscribedParentWithMove x k)
1976 getInitialSubscribers initialParents subscriber = do
1763 getInitialSubscribers initialParents subscriber = do
1977 subscribers <- forM (DMap.toList initialParents) $ \(k :=> e) -> do
1764 subscribers <- forM (DMap.toList initialParents) $ \(k :=> e) -> do
1978 keyRef <- liftIO $ newIORef k
1765 keyRef <- liftIO $ newIORef k
1979 let s = subscriber $ liftIO $ readIORef keyRef
1766 let s = subscriber $ liftIO $ readIORef keyRef
1980− (subscription@(EventSubscription _ parentSubd), parentOcc) <- subscribeAndRead (nt e) s
1767+ (subscription@(EventSubscription _ parentSubd), parentOcc) <- subscribeAndRead e s
1981 height <- liftIO $ getEventSubscribedHeight parentSubd
1768 height <- liftIO $ getEventSubscribedHeight parentSubd
1982− return (fmap (k :=>) parentOcc, height, k :=> MergeSubscribedParentWithMove subscription keyRef)
1769+ return (fmap (\x -> k :=> Identity x) parentOcc, height, k :=> MergeSubscribedParentWithMove subscription keyRef)
1983 return ( DMap.fromDistinctAscList $ mapMaybe (\(x, _, _) -> x) subscribers
1770 return ( DMap.fromDistinctAscList $ mapMaybe (\(x, _, _) -> x) subscribers
1984 , fmap (\(_, h, _) -> h) subscribers --TODO: Assert that there's no invalidHeight in here
1771 , fmap (\(_, h, _) -> h) subscribers --TODO: Assert that there's no invalidHeight in here
1985 , DMap.fromDistinctAscList $ map (\(_, _, x) -> x) subscribers
1772 , DMap.fromDistinctAscList $ map (\(_, _, x) -> x) subscribers
1986 )
1773 )
1987−
1988 destroy :: MergeDestroyFunc k (MergeSubscribedParentWithMove x k)
1774 destroy :: MergeDestroyFunc k (MergeSubscribedParentWithMove x k)
1989 destroy s = forM_ (DMap.toList s) $ \(_ :=> MergeSubscribedParentWithMove sub _) -> unsubscribe sub
1775 destroy s = forM_ (DMap.toList s) $ \(_ :=> MergeSubscribedParentWithMove sub _) -> unsubscribe sub
1990
1776
1991−type MergeUpdateFunc k v x p s
1777+type MergeUpdateFunc k x p s
1992− = (forall a. EventM x (k a) -> Subscriber x (v a))
1778+ = (forall a. EventM x (k a) -> Subscriber x a)
1993 -> IORef HeightBag
1779 -> IORef HeightBag
1994 -> DMap k s
1780 -> DMap k s
1995 -> p
1781 -> p
1996 -> EventM x ([EventSubscription x], DMap k s)
1782 -> EventM x ([EventSubscription x], DMap k s)
1997
1783
1998−type MergeGetSubscription x s = forall a. s a -> EventSubscription x
1999−
2000−type MergeInitFunc k v q x s
1784+type MergeInitFunc k x s
2001− = DMap k q
1785+ = DMap k (Event x)
2002− -> (forall a. EventM x (k a) -> Subscriber x (v a))
1786+ -> (forall a. EventM x (k a) -> Subscriber x a)
2003− -> EventM x (DMap k v, [Height], DMap k s)
1787+ -> EventM x (DMap k Identity, [Height], DMap k s)
2004
1788
2005type MergeDestroyFunc k s
1789type MergeDestroyFunc k s
2006 = DMap k s
1790 = DMap k s
2007 -> IO ()
1791 -> IO ()
2008
1792
2009−data Merge x k v s = Merge
1793+data Merge x k s = Merge
2010 { _merge_parentsRef :: {-# UNPACK #-} !(IORef (DMap k s))
1794 { _merge_parentsRef :: {-# UNPACK #-} !(IORef (DMap k s))
2011 , _merge_heightBagRef :: {-# UNPACK #-} !(IORef HeightBag)
1795 , _merge_heightBagRef :: {-# UNPACK #-} !(IORef HeightBag)
2012 , _merge_heightRef :: {-# UNPACK #-} !(IORef Height)
1796 , _merge_heightRef :: {-# UNPACK #-} !(IORef Height)
2013− , _merge_sub :: {-# UNPACK #-} !(Subscriber x (DMap k v))
1797+ , _merge_sub :: {-# UNPACK #-} !(Subscriber x (DMap k Identity))
2014− , _merge_accumRef :: {-# UNPACK #-} !(IORef (DMap k v))
1798+ , _merge_accumRef :: {-# UNPACK #-} !(IORef (DMap k Identity))
2015 }
1799 }
2016
1800
2017−invalidateMergeHeight :: Merge x k v s -> IO ()
1801+invalidateMergeHeight :: Merge x k s -> IO ()
2018invalidateMergeHeight m = invalidateMergeHeight' (_merge_heightRef m) (_merge_sub m)
1802invalidateMergeHeight m = invalidateMergeHeight' (_merge_heightRef m) (_merge_sub m)
2019
1803
2020invalidateMergeHeight' :: IORef Height -> Subscriber x a -> IO ()
1804invalidateMergeHeight' :: IORef Height -> Subscriber x a -> IO ()
2021invalidateMergeHeight' heightRef sub = do
1805invalidateMergeHeight' heightRef sub = do
2022 oldHeight <- readIORef heightRef
1806 oldHeight <- readIORef heightRef
2023− -- If the height used to be valid, it must be invalid now; we should never have *more* heights than we have parents
1807+ when (oldHeight /= invalidHeight) $ do -- If the height used to be valid, it must be invalid now; we should never have *more* heights than we have parents
2024− when (oldHeight /= invalidHeight) $ do
2025 writeIORef heightRef $! invalidHeight
1808 writeIORef heightRef $! invalidHeight
2026 subscriberInvalidateHeight sub oldHeight
1809 subscriberInvalidateHeight sub oldHeight
2027
1810
1811+
2028−revalidateMergeHeight :: Merge x k v s -> IO ()
1812+revalidateMergeHeight :: Merge x k s -> IO ()
2029revalidateMergeHeight m = do
1813revalidateMergeHeight m = do
2030 currentHeight <- readIORef $ _merge_heightRef m
1814 currentHeight <- readIORef $ _merge_heightRef m
2031−
2032− -- revalidateMergeHeight may be called multiple times; perhaps the's a way to finesse it to avoid this check
1815+ when (currentHeight == invalidHeight) $ do -- revalidateMergeHeight may be called multiple times; perhaps the's a way to finesse it to avoid this check
2033− when (currentHeight == invalidHeight) $ do
2034 heights <- readIORef $ _merge_heightBagRef m
1816 heights <- readIORef $ _merge_heightBagRef m
2035 parents <- readIORef $ _merge_parentsRef m
1817 parents <- readIORef $ _merge_parentsRef m
2036 -- When the number of heights in the bag reaches the number of parents, we should have a valid height
1818 -- When the number of heights in the bag reaches the number of parents, we should have a valid height
@@ -2038,53 +1820,44 @@ revalidateMergeHeight m = do
2038 LT -> return ()
1820 LT -> return ()
2039 EQ -> do
1821 EQ -> do
2040 let height = succHeight $ heightBagMax heights
1822 let height = succHeight $ heightBagMax heights
2041− traceInvalidateHeight $ "recalculateSubscriberHeight: height: " <> show height
1823+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: height: " <> show height
2042 writeIORef (_merge_heightRef m) $! height
1824 writeIORef (_merge_heightRef m) $! height
2043 subscriberRecalculateHeight (_merge_sub m) height
1825 subscriberRecalculateHeight (_merge_sub m) height
2044 GT -> error $ "revalidateMergeHeight: more heights (" <> show (heightBagSize heights) <> ") than parents (" <> show (DMap.size parents) <> ") for Merge"
1826 GT -> error $ "revalidateMergeHeight: more heights (" <> show (heightBagSize heights) <> ") than parents (" <> show (DMap.size parents) <> ") for Merge"
2045
1827
2046−scheduleMergeSelf :: HasSpiderTimeline x => Merge x k v s -> Height -> EventM x ()
1828+scheduleMergeSelf :: HasSpiderTimeline x => Merge x k s -> Height -> EventM x ()
2047scheduleMergeSelf m height = scheduleMerge' height (_merge_heightRef m) $ do
1829scheduleMergeSelf m height = scheduleMerge' height (_merge_heightRef m) $ do
2048 vals <- liftIO $ readIORef $ _merge_accumRef m
1830 vals <- liftIO $ readIORef $ _merge_accumRef m
2049− -- Once we're done with this, we can clear it immediately, because if there's a cacheEvent in front of us,
1831+ liftIO $ writeIORef (_merge_accumRef m) $! DMap.empty -- Once we're done with this, we can clear it immediately, because if there's a cacheEvent in front of us, it'll handle subsequent subscribers, and if not, we won't get subsequent subscribers
2050− -- it'll handle subsequent subscribers, and if not, we won't get subsequent subscribers
2051− liftIO $ writeIORef (_merge_accumRef m) $! DMap.empty
2052 --TODO: Assert that m is not empty
1832 --TODO: Assert that m is not empty
2053 subscriberPropagate (_merge_sub m) vals
1833 subscriberPropagate (_merge_sub m) vals
2054
1834
2055−checkCycle :: HasSpiderTimeline x => EventSubscribed x -> EventM x ()
2056−checkCycle subscribed = liftIO $ do
2057− height <- readIORef (eventSubscribedHeightRef subscribed)
2058−
2059− -- currentHeight <- getCurrentHeight
2060− -- when (height <= currentHeight) $ if height /= invalidHeight
2061− -- then do
2062− -- myStack <- liftIO $ whoCreatedIORef undefined --TODO
2063− -- error $ "Height (" ++ show height ++ ") is not greater than current height (" ++ show currentHeight ++ ")\n" ++ unlines (reverse myStack)
2064− -- else liftIO $
2065− when (height == invalidHeight) $
2066−#ifdef DEBUG_CYCLES
2067− do
2068− nodesInvolvedInCycle <- walkInvalidHeightParents subscribed
2069− stacks <- forM nodesInvolvedInCycle whoCreatedEventSubscribed
2070− throwIO (EventLoopException stacks)
2071−#else
2072− throwIO EventLoopException
2073−#endif
2074−
2075−
2076−mergeSubscriber :: forall x k v s a. (HasSpiderTimeline x, GCompare k) => EventSubscribed x -> Merge x k v s -> EventM x (k a) -> Subscriber x (v a)
1835+mergeSubscriber :: forall x k s a. (HasSpiderTimeline x, GCompare k) => Merge x k s -> EventM x (k a) -> Subscriber x a
2077−mergeSubscriber subscribed m getKey = Subscriber
1836+mergeSubscriber m getKey = Subscriber
2078 { subscriberPropagate = \a -> do
1837 { subscriberPropagate = \a -> do
2079 oldM <- liftIO $ readIORef $ _merge_accumRef m
1838 oldM <- liftIO $ readIORef $ _merge_accumRef m
2080 k <- getKey
1839 k <- getKey
2081− let newM = DMap.insertWith (error "Same key fired multiple times for Merge") k a oldM
1840+ let newM = DMap.insertWith (error $ "Same key fired multiple times for Merge") k (Identity a) oldM
2082 tracePropagate (Proxy :: Proxy x) $ " DMap.size oldM = " <> show (DMap.size oldM) <> "; DMap.size newM = " <> show (DMap.size newM)
1841 tracePropagate (Proxy :: Proxy x) $ " DMap.size oldM = " <> show (DMap.size oldM) <> "; DMap.size newM = " <> show (DMap.size newM)
2083 liftIO $ writeIORef (_merge_accumRef m) $! newM
1842 liftIO $ writeIORef (_merge_accumRef m) $! newM
2084 when (DMap.null oldM) $ do -- Only schedule the firing once
1843 when (DMap.null oldM) $ do -- Only schedule the firing once
2085 height <- liftIO $ readIORef $ _merge_heightRef m
1844 height <- liftIO $ readIORef $ _merge_heightRef m
2086− checkCycle subscribed
1845+ --TODO: assertions about height
2087−
1846+ currentHeight <- getCurrentHeight
1847+ when (height <= currentHeight) $ do
1848+ if height /= invalidHeight
1849+ then do
1850+ myStack <- liftIO $ whoCreatedIORef undefined --TODO
1851+ error $ "Height (" ++ show height ++ ") is not greater than current height (" ++ show currentHeight ++ ")\n" ++ unlines (reverse myStack)
1852+ else liftIO $ do
1853+#ifdef DEBUG_CYCLES
1854+ nodesInvolvedInCycle <- walkInvalidHeightParents $ eventSubscribedMerge subscribed
1855+ stacks <- forM nodesInvolvedInCycle $ \(Some es) -> whoCreatedEventSubscribed es
1856+ let cycleInfo = ":\n" <> drawForest (listsToForest stacks)
1857+#else
1858+ let cycleInfo = ""
1859+#endif
1860+ error $ "Causality loop found" <> cycleInfo
2088 scheduleMergeSelf m height
1861 scheduleMergeSelf m height
2089 , subscriberInvalidateHeight = \old -> do --TODO: When removing a parent doesn't actually change the height, maybe we can avoid invalidating
1862 , subscriberInvalidateHeight = \old -> do --TODO: When removing a parent doesn't actually change the height, maybe we can avoid invalidating
2090 modifyIORef' (_merge_heightBagRef m) $ heightBagRemove old
1863 modifyIORef' (_merge_heightBagRef m) $ heightBagRemove old
@@ -2095,45 +1868,30 @@ mergeSubscriber subscribed m getKey = Subscriber
2095 }
1868 }
2096
1869
2097--TODO: Be able to run as much of this as possible promptly
1870--TODO: Be able to run as much of this as possible promptly
2098−updateMerge :: (HasSpiderTimeline x, GCompare k) => EventSubscribed x -> Merge x k v s -> MergeUpdateFunc k v x p s -> p -> SomeMergeUpdate x
1871+updateMerge :: (HasSpiderTimeline x, GCompare k) => Merge x k s -> MergeUpdateFunc k x p s -> p -> SomeMergeUpdate x
2099−updateMerge subscribed m updateFunc p = SomeMergeUpdate updateMe (invalidateMergeHeight m) (revalidateMergeHeight m)
1872+updateMerge m updateFunc p = SomeMergeUpdate updateMe (invalidateMergeHeight m) (revalidateMergeHeight m)
2100 where updateMe = do
1873 where updateMe = do
2101 oldParents <- liftIO $ readIORef $ _merge_parentsRef m
1874 oldParents <- liftIO $ readIORef $ _merge_parentsRef m
2102− (subscriptionsToKill, newParents) <- updateFunc (mergeSubscriber subscribed m) (_merge_heightBagRef m) oldParents p
1875+ (subscriptionsToKill, newParents) <- updateFunc (mergeSubscriber m) (_merge_heightBagRef m) oldParents p
2103 liftIO $ writeIORef (_merge_parentsRef m) $! newParents
1876 liftIO $ writeIORef (_merge_parentsRef m) $! newParents
2104 return subscriptionsToKill
1877 return subscriptionsToKill
2105
1878
2106−{-# INLINE mergeGCheap' #-}
1879+{-# INLINE mergeCheap' #-}
2107−mergeGCheap' :: forall k v x p s q. (HasSpiderTimeline x, GCompare k, PatchTarget p ~ DMap k q)
2108− => MergeGetSubscription x s -> MergeInitFunc k v q x s -> MergeUpdateFunc k v x p s -> MergeDestroyFunc k s -> DynamicS x p -> Event x (DMap k v)
1880+mergeCheap' :: forall k x p s. (HasSpiderTimeline x, GCompare k, PatchTarget p ~ DMap k (Event x)) => MergeInitFunc k x s -> MergeUpdateFunc k x p s -> MergeDestroyFunc k s -> Dynamic x p -> Event x (DMap k Identity)
2109−mergeGCheap' getParent getInitialSubscribers updateFunc destroy d = Event $ \sub -> do
1881+mergeCheap' getInitialSubscribers updateFunc destroy d = Event $ \sub -> do
2110 initialParents <- readBehaviorUntracked $ dynamicCurrent d
1882 initialParents <- readBehaviorUntracked $ dynamicCurrent d
2111 accumRef <- liftIO $ newIORef $ error "merge: accumRef not yet initialized"
1883 accumRef <- liftIO $ newIORef $ error "merge: accumRef not yet initialized"
2112 heightRef <- liftIO $ newIORef $ error "merge: heightRef not yet initialized"
1884 heightRef <- liftIO $ newIORef $ error "merge: heightRef not yet initialized"
2113 heightBagRef <- liftIO $ newIORef $ error "merge: heightBagRef not yet initialized"
1885 heightBagRef <- liftIO $ newIORef $ error "merge: heightBagRef not yet initialized"
2114 parentsRef :: IORef (DMap k s) <- liftIO $ newIORef $ error "merge: parentsRef not yet initialized"
1886 parentsRef :: IORef (DMap k s) <- liftIO $ newIORef $ error "merge: parentsRef not yet initialized"
2115− changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
2116−
2117− let subscribed = EventSubscribed
2118− { eventSubscribedHeightRef = heightRef
2119− , eventSubscribedRetained = toAny (parentsRef, changeSubdRef)
2120−#ifdef DEBUG_CYCLES
2121− , eventSubscribedGetParents = do
2122− let getParent' (_ :=> v) = _eventSubscription_subscribed (getParent v)
2123− fmap getParent' . DMap.toList <$> readIORef parentsRef
2124− , eventSubscribedHasOwnHeightRef = False
2125− , eventSubscribedWhoCreated = whoCreatedIORef heightRef
2126−#endif
2127− }
2128−
2129− m = Merge
1887+ let m = Merge
2130 { _merge_parentsRef = parentsRef
1888 { _merge_parentsRef = parentsRef
2131 , _merge_heightBagRef = heightBagRef
1889 , _merge_heightBagRef = heightBagRef
2132 , _merge_heightRef = heightRef
1890 , _merge_heightRef = heightRef
2133 , _merge_sub = sub
1891 , _merge_sub = sub
2134 , _merge_accumRef = accumRef
1892 , _merge_accumRef = accumRef
2135 }
1893 }
2136− (dm, heights, initialParentState) <- getInitialSubscribers initialParents $ mergeSubscriber subscribed m
1894+ (dm, heights, initialParentState) <- getInitialSubscribers initialParents $ mergeSubscriber m
2137 let myHeightBag = heightBagFromList $ filter (/= invalidHeight) heights
1895 let myHeightBag = heightBagFromList $ filter (/= invalidHeight) heights
2138 myHeight = if invalidHeight `elem` heights
1896 myHeight = if invalidHeight `elem` heights
2139 then invalidHeight
1897 then invalidHeight
@@ -2142,57 +1900,50 @@ mergeGCheap' getParent getInitialSubscribers updateFunc destroy d = Event $ \sub
2142 let (occ, accum) = if currentHeight >= myHeight -- If we should have fired by now
1900 let (occ, accum) = if currentHeight >= myHeight -- If we should have fired by now
2143 then (if DMap.null dm then Nothing else Just dm, DMap.empty)
1901 then (if DMap.null dm then Nothing else Just dm, DMap.empty)
2144 else (Nothing, dm)
1902 else (Nothing, dm)
1903+ unless (DMap.null accum) $ do
2145− unless (DMap.null accum) $ scheduleMergeSelf m myHeight
1904+ scheduleMergeSelf m myHeight
2146 liftIO $ writeIORef accumRef $! accum
1905 liftIO $ writeIORef accumRef $! accum
2147 liftIO $ writeIORef heightRef $! myHeight
1906 liftIO $ writeIORef heightRef $! myHeight
2148 liftIO $ writeIORef heightBagRef $! myHeightBag
1907 liftIO $ writeIORef heightBagRef $! myHeightBag
1908+ changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
2149 liftIO $ writeIORef parentsRef $! initialParentState
1909 liftIO $ writeIORef parentsRef $! initialParentState
2150 defer $ SomeMergeInit $ do
1910 defer $ SomeMergeInit $ do
2151− let changeSubscriber = Subscriber
1911+ let s = Subscriber
2152 { subscriberPropagate = \a -> {-# SCC "traverseMergeChange" #-} do
1912 { subscriberPropagate = \a -> {-# SCC "traverseMergeChange" #-} do
2153− tracePropagate (Proxy :: Proxy x) "SubscriberMerge/Change"
1913+ tracePropagate (Proxy :: Proxy x) $ "SubscriberMerge/Change"
2154− defer $ updateMerge subscribed m updateFunc a
1914+ defer $ updateMerge m updateFunc a
2155 , subscriberInvalidateHeight = \_ -> return ()
1915 , subscriberInvalidateHeight = \_ -> return ()
2156 , subscriberRecalculateHeight = \_ -> return ()
1916 , subscriberRecalculateHeight = \_ -> return ()
2157 }
1917 }
2158− (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) changeSubscriber
1918+ (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) s
2159− forM_ change $ \c -> defer $ updateMerge subscribed m updateFunc c
1919+ forM_ change $ \c -> defer $ updateMerge m updateFunc c
2160 -- We explicitly hold on to the unsubscribe function from subscribing to the update event.
1920 -- We explicitly hold on to the unsubscribe function from subscribing to the update event.
2161 -- If we don't do this, there are certain cases where mergeCheap will fail to properly retain
1921 -- If we don't do this, there are certain cases where mergeCheap will fail to properly retain
2162 -- its subscription.
1922 -- its subscription.
2163− liftIO $ writeIORef changeSubdRef (changeSubscriber, changeSubscription)
1923+ liftIO $ writeIORef changeSubdRef (s, changeSubscription)
2164 let unsubscribeAll = destroy =<< readIORef parentsRef
1924 let unsubscribeAll = destroy =<< readIORef parentsRef
1925+ return ( EventSubscription unsubscribeAll $ EventSubscribed heightRef $ toAny (parentsRef, changeSubdRef)
1926+ , occ
1927+ )
2165
1928
2166− return (EventSubscription unsubscribeAll subscribed, occ)
2167−
2168−
2169−mergeInt :: forall x a. (HasSpiderTimeline x) => DynamicS x (PatchIntMap (Event x a)) -> Event x (IntMap a)
1929+mergeInt :: forall x a. (HasSpiderTimeline x) => Dynamic x (PatchIntMap (Event x a)) -> Event x (IntMap a)
2170mergeInt = cacheEvent . mergeIntCheap
1930mergeInt = cacheEvent . mergeIntCheap
2171
1931
2172{-# INLINABLE mergeIntCheap #-}
1932{-# INLINABLE mergeIntCheap #-}
2173−mergeIntCheap :: forall x a. (HasSpiderTimeline x) => DynamicS x (PatchIntMap (Event x a)) -> Event x (IntMap a)
1933+mergeIntCheap :: forall x a. (HasSpiderTimeline x) => Dynamic x (PatchIntMap (Event x a)) -> Event x (IntMap a)
2174mergeIntCheap d = Event $ \sub -> do
1934mergeIntCheap d = Event $ \sub -> do
2175 initialParents <- readBehaviorUntracked $ dynamicCurrent d
1935 initialParents <- readBehaviorUntracked $ dynamicCurrent d
2176 accum <- liftIO $ FastMutableIntMap.newEmpty
1936 accum <- liftIO $ FastMutableIntMap.newEmpty
2177 heightRef <- liftIO $ newIORef zeroHeight
1937 heightRef <- liftIO $ newIORef zeroHeight
2178 heightBagRef <- liftIO $ newIORef heightBagEmpty
1938 heightBagRef <- liftIO $ newIORef heightBagEmpty
2179 parents <- liftIO $ FastMutableIntMap.newEmpty
1939 parents <- liftIO $ FastMutableIntMap.newEmpty
2180− changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
2181− let subscribed = EventSubscribed
2182− { eventSubscribedHeightRef = heightRef
2183− , eventSubscribedRetained = toAny (parents, changeSubdRef)
2184−#ifdef DEBUG_CYCLES
2185− , eventSubscribedGetParents = fmap (_eventSubscription_subscribed . snd) <$> FastMutableIntMap.toList parents
2186− , eventSubscribedHasOwnHeightRef = False
2187− , eventSubscribedWhoCreated = whoCreatedIORef heightRef
2188−#endif
2189− }
2190 let scheduleSelf = do
1940 let scheduleSelf = do
2191 height <- liftIO $ readIORef $ heightRef
1941 height <- liftIO $ readIORef $ heightRef
2192 scheduleMerge' height heightRef $ do
1942 scheduleMerge' height heightRef $ do
2193 vals <- liftIO $ FastMutableIntMap.getFrozenAndClear accum
1943 vals <- liftIO $ FastMutableIntMap.getFrozenAndClear accum
2194 subscriberPropagate sub vals
1944 subscriberPropagate sub vals
1945+ invalidateMyHeight = do
2195− invalidateMyHeight = invalidateMergeHeight' heightRef sub
1946+ invalidateMergeHeight' heightRef sub
2196 recalculateMyHeight = do
1947 recalculateMyHeight = do
2197 currentHeight <- readIORef heightRef
1948 currentHeight <- readIORef heightRef
2198 when (currentHeight == invalidHeight) $ do --TODO: This will almost always be true; can we get rid of this check and just proceed to the next one always?
1949 when (currentHeight == invalidHeight) $ do --TODO: This will almost always be true; can we get rid of this check and just proceed to the next one always?
@@ -2202,14 +1953,12 @@ mergeIntCheap d = Event $ \sub -> do
2202 LT -> return ()
1953 LT -> return ()
2203 EQ -> do
1954 EQ -> do
2204 let height = succHeight $ heightBagMax heights
1955 let height = succHeight $ heightBagMax heights
2205− traceInvalidateHeight $ "recalculateSubscriberHeight: height: " <> show height
1956+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: height: " <> show height
2206 writeIORef heightRef $! height
1957 writeIORef heightRef $! height
2207 subscriberRecalculateHeight sub height
1958 subscriberRecalculateHeight sub height
2208 GT -> error $ "revalidateMergeHeight: more heights (" <> show (heightBagSize heights) <> ") than parents (" <> show numParents <> ") for Merge"
1959 GT -> error $ "revalidateMergeHeight: more heights (" <> show (heightBagSize heights) <> ") than parents (" <> show numParents <> ") for Merge"
2209 mySubscriber k = Subscriber
1960 mySubscriber k = Subscriber
2210 { subscriberPropagate = \a -> do
1961 { subscriberPropagate = \a -> do
2211− checkCycle subscribed
2212−
2213 wasEmpty <- liftIO $ FastMutableIntMap.isEmpty accum
1962 wasEmpty <- liftIO $ FastMutableIntMap.isEmpty accum
2214 liftIO $ FastMutableIntMap.insert accum k a
1963 liftIO $ FastMutableIntMap.insert accum k a
2215 when wasEmpty scheduleSelf
1964 when wasEmpty scheduleSelf
@@ -2243,6 +1992,7 @@ mergeIntCheap d = Event $ \sub -> do
2243 else liftIO $ Just <$> FastMutableIntMap.getFrozenAndClear accum
1992 else liftIO $ Just <$> FastMutableIntMap.getFrozenAndClear accum
2244 else do when (not isEmpty) scheduleSelf -- We have things accumulated, but we shouldn't have fired them yet
1993 else do when (not isEmpty) scheduleSelf -- We have things accumulated, but we shouldn't have fired them yet
2245 return Nothing
1994 return Nothing
1995+ changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
2246 defer $ SomeMergeInit $ do
1996 defer $ SomeMergeInit $ do
2247 let updateMe a = SomeMergeUpdate u invalidateMyHeight recalculateMyHeight
1997 let updateMe a = SomeMergeUpdate u invalidateMyHeight recalculateMyHeight
2248 where
1998 where
@@ -2256,39 +2006,35 @@ mergeIntCheap d = Event $ \sub -> do
2256 oldParents <- liftIO $ FastMutableIntMap.applyPatch parents newSubscriptions
2006 oldParents <- liftIO $ FastMutableIntMap.applyPatch parents newSubscriptions
2257 liftIO $ for_ oldParents $ \oldParent -> do
2007 liftIO $ for_ oldParents $ \oldParent -> do
2258 oldParentHeight <- getEventSubscribedHeight $ _eventSubscription_subscribed oldParent
2008 oldParentHeight <- getEventSubscribedHeight $ _eventSubscription_subscribed oldParent
2259−
2260− print ("updateMe", oldParentHeight)
2261 modifyIORef' heightBagRef $ heightBagRemove oldParentHeight
2009 modifyIORef' heightBagRef $ heightBagRemove oldParentHeight
2262 return $ IntMap.elems oldParents
2010 return $ IntMap.elems oldParents
2263− let changeSubscriber = Subscriber
2011+ let s = Subscriber
2264 { subscriberPropagate = \a -> {-# SCC "traverseMergeChange" #-} do
2012 { subscriberPropagate = \a -> {-# SCC "traverseMergeChange" #-} do
2265 tracePropagate (Proxy :: Proxy x) $ "SubscriberMergeInt/Change"
2013 tracePropagate (Proxy :: Proxy x) $ "SubscriberMergeInt/Change"
2266 defer $ updateMe a
2014 defer $ updateMe a
2267 , subscriberInvalidateHeight = \_ -> return ()
2015 , subscriberInvalidateHeight = \_ -> return ()
2268 , subscriberRecalculateHeight = \_ -> return ()
2016 , subscriberRecalculateHeight = \_ -> return ()
2269 }
2017 }
2270− (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) changeSubscriber
2018+ (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) s
2271 forM_ change $ \c -> defer $ updateMe c
2019 forM_ change $ \c -> defer $ updateMe c
2272 -- We explicitly hold on to the unsubscribe function from subscribing to the update event.
2020 -- We explicitly hold on to the unsubscribe function from subscribing to the update event.
2273 -- If we don't do this, there are certain cases where mergeCheap will fail to properly retain
2021 -- If we don't do this, there are certain cases where mergeCheap will fail to properly retain
2274 -- its subscription.
2022 -- its subscription.
2275− liftIO $ writeIORef changeSubdRef (changeSubscriber, changeSubscription)
2023+ liftIO $ writeIORef changeSubdRef (s, changeSubscription)
2276 let unsubscribeAll = traverse_ unsubscribe =<< FastMutableIntMap.getFrozenAndClear parents
2024 let unsubscribeAll = traverse_ unsubscribe =<< FastMutableIntMap.getFrozenAndClear parents
2277−
2278−
2279− return (EventSubscription unsubscribeAll subscribed, occ)
2025+ return ( EventSubscription unsubscribeAll $ EventSubscribed heightRef $ toAny (parents, changeSubdRef)
2026+ , occ
2027+ )
2280
2028
2281newtype EventSelector x k = EventSelector { select :: forall a. k a -> Event x a }
2029newtype EventSelector x k = EventSelector { select :: forall a. k a -> Event x a }
2282−newtype EventSelectorG x k v = EventSelectorG { selectG :: forall a. k a -> Event x (v a) }
2283
2030
2284−fanG :: (HasSpiderTimeline x, GCompare k) => Event x (DMap k v) -> EventSelectorG x k v
2031+fan :: (HasSpiderTimeline x, GCompare k) => Event x (DMap k Identity) -> EventSelector x k
2285−fanG e = unsafePerformIO $ do
2032+fan e =
2286− ref <- newIORef Nothing
2287 let f = Fan
2033 let f = Fan
2288 { fanParent = e
2034 { fanParent = e
2289− , fanSubscribed = ref
2035+ , fanSubscribed = unsafeNewIORef e Nothing
2290 }
2036 }
2291− pure $ EventSelectorG $ \k -> eventFan k f
2037+ in EventSelector $ \k -> eventFan k f
2292
2038
2293runHoldInits :: HasSpiderTimeline x => IORef [SomeHoldInit x] -> IORef [SomeDynInit x] -> IORef [SomeMergeInit x] -> EventM x ()
2039runHoldInits :: HasSpiderTimeline x => IORef [SomeHoldInit x] -> IORef [SomeDynInit x] -> IORef [SomeMergeInit x] -> EventM x ()
2294runHoldInits holdInitRef dynInitRef mergeInitRef = do
2040runHoldInits holdInitRef dynInitRef mergeInitRef = do
@@ -2342,7 +2088,7 @@ clearEventEnv (EventEnv toAssignRef holdInitRef dynInitRef mergeUpdateRef mergeI
2342-- | Run an event action outside of a frame
2088-- | Run an event action outside of a frame
2343runFrame :: forall x a. HasSpiderTimeline x => EventM x a -> SpiderHost x a --TODO: This function also needs to hold the mutex
2089runFrame :: forall x a. HasSpiderTimeline x => EventM x a -> SpiderHost x a --TODO: This function also needs to hold the mutex
2344runFrame a = SpiderHost $ do
2090runFrame a = SpiderHost $ do
2345− let env = _spiderTimeline_eventEnv $ unSTE (spiderTimeline :: SpiderTimelineEnv x)
2091+ let env = _spiderTimeline_eventEnv (spiderTimeline :: SpiderTimelineEnv x)
2346 let go = do
2092 let go = do
2347 result <- a
2093 result <- a
2348 runHoldInits (eventEnvHoldInits env) (eventEnvDynInits env) (eventEnvMergeInits env) -- This must happen before doing the assignments, in case subscribing a Hold causes existing Holds to be read by the newly-propagated events
2094 runHoldInits (eventEnvHoldInits env) (eventEnvDynInits env) (eventEnvMergeInits env) -- This must happen before doing the assignments, in case subscribing a Hold causes existing Holds to be read by the newly-propagated events
@@ -2359,19 +2105,19 @@ runFrame a = SpiderHost $ do
2359 coincidenceInfos <- readIORef $ eventEnvResetCoincidences env
2105 coincidenceInfos <- readIORef $ eventEnvResetCoincidences env
2360 forM_ toAssign $ \(SomeAssignment vRef iRef v) -> {-# SCC "assignment" #-} do
2106 forM_ toAssign $ \(SomeAssignment vRef iRef v) -> {-# SCC "assignment" #-} do
2361 writeIORef vRef v
2107 writeIORef vRef v
2362− traceInvalidate $ "Invalidating Hold"
2108+ when debugInvalidate $ putStrLn $ "Invalidating Hold"
2363 writeIORef iRef =<< evaluate =<< invalidate toReconnectRef =<< readIORef iRef
2109 writeIORef iRef =<< evaluate =<< invalidate toReconnectRef =<< readIORef iRef
2364 mergeUpdates <- readIORef $ eventEnvMergeUpdates env
2110 mergeUpdates <- readIORef $ eventEnvMergeUpdates env
2365 writeIORef (eventEnvMergeUpdates env) []
2111 writeIORef (eventEnvMergeUpdates env) []
2366− tracePropagate (Proxy::Proxy x) $ "Updating merges"
2112+ when debugPropagate $ putStrLn "Updating merges"
2367 mergeSubscriptionsToKill <- runEventM $ concat <$> mapM _someMergeUpdate_update mergeUpdates
2113 mergeSubscriptionsToKill <- runEventM $ concat <$> mapM _someMergeUpdate_update mergeUpdates
2368− tracePropagate (Proxy::Proxy x) $ "Updating merges done"
2114+ when debugPropagate $ putStrLn "Updating merges done"
2369 toReconnect <- readIORef toReconnectRef
2115 toReconnect <- readIORef toReconnectRef
2370 clearEventEnv env
2116 clearEventEnv env
2371 switchSubscriptionsToKill <- forM toReconnect $ \(SomeSwitchSubscribed subscribed) -> {-# SCC "switchSubscribed" #-} do
2117 switchSubscriptionsToKill <- forM toReconnect $ \(SomeSwitchSubscribed subscribed) -> {-# SCC "switchSubscribed" #-} do
2372 oldSubscription <- readIORef $ switchSubscribedCurrentParent subscribed
2118 oldSubscription <- readIORef $ switchSubscribedCurrentParent subscribed
2373 wi <- readIORef $ switchSubscribedOwnWeakInvalidator subscribed
2119 wi <- readIORef $ switchSubscribedOwnWeakInvalidator subscribed
2374− traceInvalidate $ "Finalizing invalidator for Switch" <> showNodeId subscribed
2120+ when debugInvalidate $ putStrLn $ "Finalizing invalidator for Switch" <> showNodeId subscribed
2375 finalize wi
2121 finalize wi
2376 i <- evaluate $ switchSubscribedOwnInvalidator subscribed
2122 i <- evaluate $ switchSubscribedOwnInvalidator subscribed
2377 wi' <- mkWeakPtrWithDebug i "wi'"
2123 wi' <- mkWeakPtrWithDebug i "wi'"
@@ -2385,7 +2131,7 @@ runFrame a = SpiderHost $ do
2385 subscription <- unSpiderHost $ runFrame $ {-# SCC "subscribeSwitch" #-} subscribe e sub --TODO: Assert that the event isn't firing --TODO: This should not loop because none of the events should be firing, but still, it is inefficient
2131 subscription <- unSpiderHost $ runFrame $ {-# SCC "subscribeSwitch" #-} subscribe e sub --TODO: Assert that the event isn't firing --TODO: This should not loop because none of the events should be firing, but still, it is inefficient
2386 {-
2132 {-
2387 stackTrace <- liftIO $ fmap renderStack $ ccsToStrings =<< (getCCSOf $! switchSubscribedParent subscribed)
2133 stackTrace <- liftIO $ fmap renderStack $ ccsToStrings =<< (getCCSOf $! switchSubscribedParent subscribed)
2388− liftIO $ debugStrLn $ (++stackTrace) $ "subd' subscribed to " ++ case e of
2134+ liftIO $ putStrLn $ (++stackTrace) $ "subd' subscribed to " ++ case e of
2389 EventRoot _ -> "EventRoot"
2135 EventRoot _ -> "EventRoot"
2390 EventNever -> "EventNever"
2136 EventNever -> "EventNever"
2391 _ -> "something else"
2137 _ -> "something else"
@@ -2400,7 +2146,7 @@ runFrame a = SpiderHost $ do
2400 myHeight <- readIORef $ switchSubscribedHeight subscribed
2146 myHeight <- readIORef $ switchSubscribedHeight subscribed
2401 when (parentHeight /= myHeight) $ do
2147 when (parentHeight /= myHeight) $ do
2402 writeIORef (switchSubscribedHeight subscribed) $! invalidHeight
2148 writeIORef (switchSubscribedHeight subscribed) $! invalidHeight
2403− WeakBag.traverse_ (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight myHeight
2149+ WeakBag.traverse (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight myHeight
2404 mapM_ _someMergeUpdate_invalidateHeight mergeUpdates --TODO: In addition to when the patch is completely empty, we should also not run this if it has some Nothing values, but none of them have actually had any effect; potentially, we could even check for Just values with no effect (e.g. by comparing their IORefs and ignoring them if they are unchanged); actually, we could just check if the new height is different
2150 mapM_ _someMergeUpdate_invalidateHeight mergeUpdates --TODO: In addition to when the patch is completely empty, we should also not run this if it has some Nothing values, but none of them have actually had any effect; potentially, we could even check for Just values with no effect (e.g. by comparing their IORefs and ignoring them if they are unchanged); actually, we could just check if the new height is different
2405 forM_ coincidenceInfos $ \(SomeResetCoincidence subscription mcs) -> do
2151 forM_ coincidenceInfos $ \(SomeResetCoincidence subscription mcs) -> do
2406 unsubscribe subscription
2152 unsubscribe subscription
@@ -2441,7 +2187,7 @@ invalidateCoincidenceHeight subscribed = do
2441 oldHeight <- readIORef $ coincidenceSubscribedHeight subscribed
2187 oldHeight <- readIORef $ coincidenceSubscribedHeight subscribed
2442 when (oldHeight /= invalidHeight) $ do
2188 when (oldHeight /= invalidHeight) $ do
2443 writeIORef (coincidenceSubscribedHeight subscribed) $! invalidHeight
2189 writeIORef (coincidenceSubscribedHeight subscribed) $! invalidHeight
2444− WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
2190+ WeakBag.traverse (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
2445
2191
2446updateSwitchHeight :: Height -> SwitchSubscribed x a -> IO ()
2192updateSwitchHeight :: Height -> SwitchSubscribed x a -> IO ()
2447updateSwitchHeight new subscribed = do
2193updateSwitchHeight new subscribed = do
@@ -2449,7 +2195,7 @@ updateSwitchHeight new subscribed = do
2449 when (oldHeight == invalidHeight) $ do --TODO: This 'when' should probably be an assertion
2195 when (oldHeight == invalidHeight) $ do --TODO: This 'when' should probably be an assertion
2450 when (new /= invalidHeight) $ do --TODO: This 'when' should probably be an assertion
2196 when (new /= invalidHeight) $ do --TODO: This 'when' should probably be an assertion
2451 writeIORef (switchSubscribedHeight subscribed) $! new
2197 writeIORef (switchSubscribedHeight subscribed) $! new
2452− WeakBag.traverse_ (switchSubscribedSubscribers subscribed) $ recalculateSubscriberHeight new
2198+ WeakBag.traverse (switchSubscribedSubscribers subscribed) $ recalculateSubscriberHeight new
2453
2199
2454recalculateCoincidenceHeight :: CoincidenceSubscribed x a -> IO ()
2200recalculateCoincidenceHeight :: CoincidenceSubscribed x a -> IO ()
2455recalculateCoincidenceHeight subscribed = do
2201recalculateCoincidenceHeight subscribed = do
@@ -2458,7 +2204,7 @@ recalculateCoincidenceHeight subscribed = do
2458 height <- calculateCoincidenceHeight subscribed
2204 height <- calculateCoincidenceHeight subscribed
2459 when (height /= invalidHeight) $ do
2205 when (height /= invalidHeight) $ do
2460 writeIORef (coincidenceSubscribedHeight subscribed) $! height
2206 writeIORef (coincidenceSubscribedHeight subscribed) $! height
2461− WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ recalculateSubscriberHeight height
2207+ WeakBag.traverse (coincidenceSubscribedSubscribers subscribed) $ recalculateSubscriberHeight height
2462
2208
2463calculateSwitchHeight :: SwitchSubscribed x a -> IO Height
2209calculateSwitchHeight :: SwitchSubscribed x a -> IO Height
2464calculateSwitchHeight subscribed = getEventSubscribedHeight . _eventSubscription_subscribed =<< readIORef (switchSubscribedCurrentParent subscribed)
2210calculateSwitchHeight subscribed = getEventSubscribedHeight . _eventSubscription_subscribed =<< readIORef (switchSubscribedCurrentParent subscribed)
@@ -2520,8 +2266,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Event
2520 {-# INLINABLE headE #-}
2266 {-# INLINABLE headE #-}
2521 headE = R.slowHeadE
2267 headE = R.slowHeadE
2522-- headE (SpiderEvent e) = SpiderEvent <$> Reflex.Spider.Internal.headE e
2268-- headE (SpiderEvent e) = SpiderEvent <$> Reflex.Spider.Internal.headE e
2523− {-# INLINABLE now #-}
2524− now = nowSpiderEventM
2525
2269
2526instance Reflex.Class.MonadSample (SpiderTimeline x) (SpiderPullM x) where
2270instance Reflex.Class.MonadSample (SpiderTimeline x) (SpiderPullM x) where
2527 {-# INLINABLE sample #-}
2271 {-# INLINABLE sample #-}
@@ -2543,9 +2287,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Spide
2543 {-# INLINABLE headE #-}
2287 {-# INLINABLE headE #-}
2544 headE = R.slowHeadE
2288 headE = R.slowHeadE
2545-- headE (SpiderEvent e) = SpiderPushM $ SpiderEvent <$> Reflex.Spider.Internal.headE e
2289-- headE (SpiderEvent e) = SpiderPushM $ SpiderEvent <$> Reflex.Spider.Internal.headE e
2546− {-# INLINABLE now #-}
2547− now = SpiderPushM nowSpiderEventM
2548−
2549
2290
2550instance HasSpiderTimeline x => Monad (Reflex.Class.Dynamic (SpiderTimeline x)) where
2291instance HasSpiderTimeline x => Monad (Reflex.Class.Dynamic (SpiderTimeline x)) where
2551 {-# INLINE return #-}
2292 {-# INLINE return #-}
@@ -2554,13 +2295,11 @@ instance HasSpiderTimeline x => Monad (Reflex.Class.Dynamic (SpiderTimeline x))
2554 x >>= f = SpiderDynamic $ dynamicDynIdentity $ newJoinDyn $ newMapDyn (unSpiderDynamic . f) $ unSpiderDynamic x
2295 x >>= f = SpiderDynamic $ dynamicDynIdentity $ newJoinDyn $ newMapDyn (unSpiderDynamic . f) $ unSpiderDynamic x
2555 {-# INLINE (>>) #-}
2296 {-# INLINE (>>) #-}
2556 (>>) = (*>)
2297 (>>) = (*>)
2557−#if !MIN_VERSION_base(4,13,0)
2558 {-# INLINE fail #-}
2298 {-# INLINE fail #-}
2559 fail _ = error "Dynamic does not support 'fail'"
2299 fail _ = error "Dynamic does not support 'fail'"
2560−#endif
2561
2300
2562{-# INLINABLE newJoinDyn #-}
2301{-# INLINABLE newJoinDyn #-}
2563−newJoinDyn :: HasSpiderTimeline x => DynamicS x (Identity (DynamicS x (Identity a))) -> Reflex.Spider.Internal.Dyn x (Identity a)
2302+newJoinDyn :: HasSpiderTimeline x => Reflex.Spider.Internal.Dynamic x (Identity (Reflex.Spider.Internal.Dynamic x (Identity a))) -> Reflex.Spider.Internal.Dyn x (Identity a)
2564newJoinDyn d =
2303newJoinDyn d =
2565 let readV0 = readBehaviorTracked . dynamicCurrent =<< readBehaviorTracked (dynamicCurrent d)
2304 let readV0 = readBehaviorTracked . dynamicCurrent =<< readBehaviorTracked (dynamicCurrent d)
2566 eOuter = Reflex.Spider.Internal.push (fmap (Just . Identity) . readBehaviorUntracked . dynamicCurrent . runIdentity) $ dynamicUpdated d
2305 eOuter = Reflex.Spider.Internal.push (fmap (Just . Identity) . readBehaviorUntracked . dynamicCurrent . runIdentity) $ dynamicUpdated d
@@ -2609,9 +2348,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Spide
2609 buildDynamic getV0 e = runFrame . runSpiderHostFrame $ Reflex.Class.buildDynamic getV0 e
2348 buildDynamic getV0 e = runFrame . runSpiderHostFrame $ Reflex.Class.buildDynamic getV0 e
2610 {-# INLINABLE headE #-}
2349 {-# INLINABLE headE #-}
2611 headE e = runFrame . runSpiderHostFrame $ Reflex.Class.headE e
2350 headE e = runFrame . runSpiderHostFrame $ Reflex.Class.headE e
2612− {-# INLINABLE now #-}
2613− now = runFrame . runSpiderHostFrame $ Reflex.Class.now
2614−
2615
2351
2616instance HasSpiderTimeline x => Reflex.Class.MonadSample (SpiderTimeline x) (SpiderHostFrame x) where
2352instance HasSpiderTimeline x => Reflex.Class.MonadSample (SpiderTimeline x) (SpiderHostFrame x) where
2617 sample = SpiderHostFrame . readBehaviorUntracked . unSpiderBehavior --TODO: This can cause problems with laziness, so we should get rid of it if we can
2353 sample = SpiderHostFrame . readBehaviorUntracked . unSpiderBehavior --TODO: This can cause problems with laziness, so we should get rid of it if we can
@@ -2628,8 +2364,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Spide
2628 {-# INLINABLE headE #-}
2364 {-# INLINABLE headE #-}
2629 headE = R.slowHeadE
2365 headE = R.slowHeadE
2630-- headE (SpiderEvent e) = SpiderHostFrame $ SpiderEvent <$> Reflex.Spider.Internal.headE e
2366-- headE (SpiderEvent e) = SpiderHostFrame $ SpiderEvent <$> Reflex.Spider.Internal.headE e
2631− {-# INLINABLE now #-}
2632− now = SpiderHostFrame Reflex.Class.now
2633
2367
2634instance HasSpiderTimeline x => Reflex.Class.MonadSample (SpiderTimeline x) (SpiderHost x) where
2368instance HasSpiderTimeline x => Reflex.Class.MonadSample (SpiderTimeline x) (SpiderHost x) where
2635 {-# INLINABLE sample #-}
2369 {-# INLINABLE sample #-}
@@ -2650,8 +2384,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Refle
2650 buildDynamic getV0 e = Reflex.Spider.Internal.ReadPhase $ Reflex.Class.buildDynamic getV0 e
2384 buildDynamic getV0 e = Reflex.Spider.Internal.ReadPhase $ Reflex.Class.buildDynamic getV0 e
2651 {-# INLINABLE headE #-}
2385 {-# INLINABLE headE #-}
2652 headE e = Reflex.Spider.Internal.ReadPhase $ Reflex.Class.headE e
2386 headE e = Reflex.Spider.Internal.ReadPhase $ Reflex.Class.headE e
2653− {-# INLINABLE now #-}
2654− now = Reflex.Spider.Internal.ReadPhase Reflex.Class.now
2655
2387
2656--------------------------------------------------------------------------------
2388--------------------------------------------------------------------------------
2657-- Deprecated items
2389-- Deprecated items
@@ -2689,13 +2421,13 @@ instance HasSpiderTimeline x => Reflex.Host.Class.MonadReadEvent (SpiderTimeline
2689 touch h
2421 touch h
2690 return result
2422 return result
2691
2423
2692−instance HasSpiderTimeline x => Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHost x) where
2424+instance Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHost x) where
2693 newEventWithTrigger = SpiderHost . fmap SpiderEvent . newEventWithTriggerIO
2425 newEventWithTrigger = SpiderHost . fmap SpiderEvent . newEventWithTriggerIO
2694 newFanEventWithTrigger f = SpiderHost $ do
2426 newFanEventWithTrigger f = SpiderHost $ do
2695 es <- newFanEventWithTriggerIO f
2427 es <- newFanEventWithTriggerIO f
2696 return $ Reflex.Class.EventSelector $ SpiderEvent . Reflex.Spider.Internal.select es
2428 return $ Reflex.Class.EventSelector $ SpiderEvent . Reflex.Spider.Internal.select es
2697
2429
2698−instance HasSpiderTimeline x => Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHostFrame x) where
2430+instance Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHostFrame x) where
2699 newEventWithTrigger = SpiderHostFrame . EventM . liftIO . fmap SpiderEvent . newEventWithTriggerIO
2431 newEventWithTrigger = SpiderHostFrame . EventM . liftIO . fmap SpiderEvent . newEventWithTriggerIO
2700 newFanEventWithTrigger f = SpiderHostFrame $ EventM $ liftIO $ do
2432 newFanEventWithTrigger f = SpiderHostFrame $ EventM $ liftIO $ do
2701 es <- newFanEventWithTriggerIO f
2433 es <- newFanEventWithTriggerIO f
@@ -2717,7 +2449,7 @@ unsafeNewSpiderTimelineEnv = do
2717#ifdef DEBUG
2449#ifdef DEBUG
2718 depthRef <- newIORef 0
2450 depthRef <- newIORef 0
2719#endif
2451#endif
2720− return $ STE $ SpiderTimelineEnv
2452+ return $ SpiderTimelineEnv
2721 { _spiderTimeline_lock = lock
2453 { _spiderTimeline_lock = lock
2722 , _spiderTimeline_eventEnv = env
2454 , _spiderTimeline_eventEnv = env
2723#ifdef DEBUG
2455#ifdef DEBUG
@@ -2729,17 +2461,17 @@ unsafeNewSpiderTimelineEnv = do
2729newSpiderTimeline :: IO (Some SpiderTimelineEnv)
2461newSpiderTimeline :: IO (Some SpiderTimelineEnv)
2730newSpiderTimeline = withSpiderTimeline (pure . Some)
2462newSpiderTimeline = withSpiderTimeline (pure . Some)
2731
2463
2732−data LocalSpiderTimeline (x :: Type) s
2464+data LocalSpiderTimeline x s
2733
2465
2734instance Reifies s (SpiderTimelineEnv x) =>
2466instance Reifies s (SpiderTimelineEnv x) =>
2735 HasSpiderTimeline (LocalSpiderTimeline x s) where
2467 HasSpiderTimeline (LocalSpiderTimeline x s) where
2736− spiderTimeline = localSpiderTimeline Proxy $ reflect (Proxy :: Proxy s)
2468+ spiderTimeline = localSpiderTimeline (Proxy :: Proxy s) $ reflect (Proxy :: Proxy s)
2737
2469
2738localSpiderTimeline
2470localSpiderTimeline
2739− :: proxy s
2471+ :: Proxy s
2740 -> SpiderTimelineEnv x
2472 -> SpiderTimelineEnv x
2741 -> SpiderTimelineEnv (LocalSpiderTimeline x s)
2473 -> SpiderTimelineEnv (LocalSpiderTimeline x s)
2742−localSpiderTimeline _ = coerce
2474+localSpiderTimeline _ = unsafeCoerce
2743
2475
2744-- | Pass a new timeline to the given function.
2476-- | Pass a new timeline to the given function.
2745withSpiderTimeline :: (forall x. HasSpiderTimeline x => SpiderTimelineEnv x -> IO r) -> IO r
2477withSpiderTimeline :: (forall x. HasSpiderTimeline x => SpiderTimelineEnv x -> IO r) -> IO r
@@ -2747,18 +2479,18 @@ withSpiderTimeline k = do
2747 env <- unsafeNewSpiderTimelineEnv
2479 env <- unsafeNewSpiderTimelineEnv
2748 reify env $ \s -> k $ localSpiderTimeline s env
2480 reify env $ \s -> k $ localSpiderTimeline s env
2749
2481
2750−newtype SpiderPullM (x :: Type) a = SpiderPullM (BehaviorM x a) deriving (Functor, Applicative, Monad, MonadIO, MonadFix)
2482+newtype SpiderPullM x a = SpiderPullM (BehaviorM x a) deriving (Functor, Applicative, Monad, MonadIO, MonadFix)
2751
2483
2752type ComputeM = EventM
2484type ComputeM = EventM
2753
2485
2754−newtype SpiderPushM (x :: Type) a = SpiderPushM (ComputeM x a) deriving (Functor, Applicative, Monad, MonadIO, MonadFix)
2486+newtype SpiderPushM x a = SpiderPushM (ComputeM x a) deriving (Functor, Applicative, Monad, MonadIO, MonadFix)
2755
2487
2756instance HasSpiderTimeline x => R.Reflex (SpiderTimeline x) where
2488instance HasSpiderTimeline x => R.Reflex (SpiderTimeline x) where
2757 {-# SPECIALIZE instance R.Reflex (SpiderTimeline Global) #-}
2489 {-# SPECIALIZE instance R.Reflex (SpiderTimeline Global) #-}
2758 newtype Behavior (SpiderTimeline x) a = SpiderBehavior { unSpiderBehavior :: Behavior x a }
2490 newtype Behavior (SpiderTimeline x) a = SpiderBehavior { unSpiderBehavior :: Behavior x a }
2759 newtype Event (SpiderTimeline x) a = SpiderEvent { unSpiderEvent :: Event x a }
2491 newtype Event (SpiderTimeline x) a = SpiderEvent { unSpiderEvent :: Event x a }
2760− newtype Dynamic (SpiderTimeline x) a = SpiderDynamic { unSpiderDynamic :: DynamicS x (Identity a) } -- deriving (Functor, Applicative, Monad)
2492+ newtype Dynamic (SpiderTimeline x) a = SpiderDynamic { unSpiderDynamic :: Dynamic x (Identity a) } -- deriving (Functor, Applicative, Monad)
2761− newtype Incremental (SpiderTimeline x) p = SpiderIncremental { unSpiderIncremental :: DynamicS x p }
2493+ newtype Incremental (SpiderTimeline x) p = SpiderIncremental { unSpiderIncremental :: Dynamic x p }
2762 type PullM (SpiderTimeline x) = SpiderPullM x
2494 type PullM (SpiderTimeline x) = SpiderPullM x
2763 type PushM (SpiderTimeline x) = SpiderPushM x
2495 type PushM (SpiderTimeline x) = SpiderPushM x
2764 {-# INLINABLE never #-}
2496 {-# INLINABLE never #-}
@@ -2771,15 +2503,10 @@ instance HasSpiderTimeline x => R.Reflex (SpiderTimeline x) where
2771 pushCheap f = SpiderEvent . pushCheap (coerce f) . unSpiderEvent
2503 pushCheap f = SpiderEvent . pushCheap (coerce f) . unSpiderEvent
2772 {-# INLINABLE pull #-}
2504 {-# INLINABLE pull #-}
2773 pull = SpiderBehavior . pull . coerce
2505 pull = SpiderBehavior . pull . coerce
2774− {-# INLINABLE fanG #-}
2506+ {-# INLINABLE merge #-}
2775− fanG e = R.EventSelectorG $ SpiderEvent . selectG (fanG (unSpiderEvent e))
2507+ merge = SpiderEvent . merge . dynamicConst . (coerce :: DMap k (R.Event (SpiderTimeline x)) -> DMap k (Event x))
2776− {-# INLINABLE mergeG #-}
2508+ {-# INLINABLE fan #-}
2777− mergeG
2509+ fan e = R.EventSelector $ SpiderEvent . select (fan (unSpiderEvent e))
2778− :: forall k2 (k :: k2 -> *) q (v :: k2 -> *). GCompare k
2779− => (forall a. q a -> R.Event (SpiderTimeline x) (v a))
2780− -> DMap k q
2781− -> R.Event (SpiderTimeline x) (DMap k v)
2782− mergeG nt = SpiderEvent . mergeG (unSpiderEvent #. nt) . dynamicConst
2783 {-# INLINABLE switch #-}
2510 {-# INLINABLE switch #-}
2784 switch = SpiderEvent . switch . (coerce :: Behavior x (R.Event (SpiderTimeline x) a) -> Behavior x (Event x a)) . unSpiderBehavior
2511 switch = SpiderEvent . switch . (coerce :: Behavior x (R.Event (SpiderTimeline x) a) -> Behavior x (Event x a)) . unSpiderBehavior
2785 {-# INLINABLE coincidence #-}
2512 {-# INLINABLE coincidence #-}
@@ -2787,15 +2514,15 @@ instance HasSpiderTimeline x => R.Reflex (SpiderTimeline x) where
2787 {-# INLINABLE current #-}
2514 {-# INLINABLE current #-}
2788 current = SpiderBehavior . dynamicCurrent . unSpiderDynamic
2515 current = SpiderBehavior . dynamicCurrent . unSpiderDynamic
2789 {-# INLINABLE updated #-}
2516 {-# INLINABLE updated #-}
2790− updated = SpiderEvent #. dynamicUpdated .# fmap coerce . unSpiderDynamic
2517+ updated = coerce $ SpiderEvent . dynamicUpdated . unSpiderDynamic
2791 {-# INLINABLE unsafeBuildDynamic #-}
2518 {-# INLINABLE unsafeBuildDynamic #-}
2792 unsafeBuildDynamic readV0 v' = SpiderDynamic $ dynamicDynIdentity $ unsafeBuildDynamic (coerce readV0) $ coerce $ unSpiderEvent v'
2519 unsafeBuildDynamic readV0 v' = SpiderDynamic $ dynamicDynIdentity $ unsafeBuildDynamic (coerce readV0) $ coerce $ unSpiderEvent v'
2793 {-# INLINABLE unsafeBuildIncremental #-}
2520 {-# INLINABLE unsafeBuildIncremental #-}
2794 unsafeBuildIncremental readV0 dv = SpiderIncremental $ dynamicDyn $ unsafeBuildDynamic (coerce readV0) $ unSpiderEvent dv
2521 unsafeBuildIncremental readV0 dv = SpiderIncremental $ dynamicDyn $ unsafeBuildDynamic (coerce readV0) $ unSpiderEvent dv
2795− {-# INLINABLE mergeIncrementalG #-}
2522+ {-# INLINABLE mergeIncremental #-}
2796− mergeIncrementalG nt = SpiderEvent #. mergeG (coerce #. nt) .# unSpiderIncremental
2523+ mergeIncremental = SpiderEvent . merge . (unsafeCoerce :: Dynamic x (PatchDMap k (R.Event (SpiderTimeline x))) -> Dynamic x (PatchDMap k (Event x))) . unSpiderIncremental
2797− {-# INLINABLE mergeIncrementalWithMoveG #-}
2524+ {-# INLINABLE mergeIncrementalWithMove #-}
2798− mergeIncrementalWithMoveG nt = SpiderEvent #. mergeWithMove (coerce #. nt) .# unSpiderIncremental
2525+ mergeIncrementalWithMove = SpiderEvent . mergeWithMove . (unsafeCoerce :: Dynamic x (PatchDMapWithMove k (R.Event (SpiderTimeline x))) -> Dynamic x (PatchDMapWithMove k (Event x))) . unSpiderIncremental
2799 {-# INLINABLE currentIncremental #-}
2526 {-# INLINABLE currentIncremental #-}
2800 currentIncremental = SpiderBehavior . dynamicCurrent . unSpiderIncremental
2527 currentIncremental = SpiderBehavior . dynamicCurrent . unSpiderIncremental
2801 {-# INLINABLE updatedIncremental #-}
2528 {-# INLINABLE updatedIncremental #-}
@@ -2806,10 +2533,9 @@ instance HasSpiderTimeline x => R.Reflex (SpiderTimeline x) where
2806 return $ Identity <$> apply p c --TODO: Avoid the redundant 'apply'
2533 return $ Identity <$> apply p c --TODO: Avoid the redundant 'apply'
2807 eventCoercion Coercion = Coercion
2534 eventCoercion Coercion = Coercion
2808 behaviorCoercion Coercion = Coercion
2535 behaviorCoercion Coercion = Coercion
2809− dynamicCoercion Coercion = Coercion
2536+ dynamicCoercion = unsafeCoerce --TODO: How can we avoid this unsafeCoerce? This is safe only because we know how Identity works as a Patch instance
2810− incrementalCoercion Coercion Coercion = Coercion
2811 {-# INLINABLE mergeIntIncremental #-}
2537 {-# INLINABLE mergeIntIncremental #-}
2812− mergeIntIncremental = SpiderEvent . mergeInt . coerce
2538+ mergeIntIncremental = SpiderEvent . mergeInt . (unsafeCoerce :: Dynamic x (PatchIntMap (R.Event (SpiderTimeline x) a)) -> Dynamic x (PatchIntMap (Event x a))) . unSpiderIncremental
2813 {-# INLINABLE fanInt #-}
2539 {-# INLINABLE fanInt #-}
2814 fanInt e = R.EventSelectorInt $ SpiderEvent . selectInt (fanInt (unSpiderEvent e))
2540 fanInt e = R.EventSelectorInt $ SpiderEvent . selectInt (fanInt (unSpiderEvent e))
2815
2541
@@ -2834,7 +2560,7 @@ instance MonadAtomicRef (EventM x) where
2834 atomicModifyRef r f = liftIO $ atomicModifyRef r f
2560 atomicModifyRef r f = liftIO $ atomicModifyRef r f
2835
2561
2836-- | The monad for actions that manipulate a Spider timeline identified by @x@
2562-- | The monad for actions that manipulate a Spider timeline identified by @x@
2837−newtype SpiderHost (x :: Type) a = SpiderHost { unSpiderHost :: IO a } deriving (Functor, Applicative, MonadFix, MonadIO, MonadException, MonadAsyncException)
2563+newtype SpiderHost x a = SpiderHost { unSpiderHost :: IO a } deriving (Functor, Applicative, MonadFix, MonadIO, MonadException, MonadAsyncException)
2838
2564
2839instance Monad (SpiderHost x) where
2565instance Monad (SpiderHost x) where
2840 {-# INLINABLE (>>=) #-}
2566 {-# INLINABLE (>>=) #-}
@@ -2843,14 +2569,8 @@ instance Monad (SpiderHost x) where
2843 SpiderHost x >> SpiderHost y = SpiderHost $ x >> y
2569 SpiderHost x >> SpiderHost y = SpiderHost $ x >> y
2844 {-# INLINABLE return #-}
2570 {-# INLINABLE return #-}
2845 return x = SpiderHost $ return x
2571 return x = SpiderHost $ return x
2846−#if !MIN_VERSION_base(4,13,0)
2847 {-# INLINABLE fail #-}
2572 {-# INLINABLE fail #-}
2848− fail = MonadFail.fail
2849−#endif
2850−
2851−instance MonadFail (SpiderHost x) where
2852− {-# INLINABLE fail #-}
2853− fail s = SpiderHost $ MonadFail.fail s
2573+ fail s = SpiderHost $ fail s
2854
2574
2855-- | Run an action affecting the global Spider timeline; this will be guarded by
2575-- | Run an action affecting the global Spider timeline; this will be guarded by
2856-- a mutex for that timeline
2576-- a mutex for that timeline
@@ -2862,7 +2582,7 @@ runSpiderHost (SpiderHost a) = a
2862runSpiderHostForTimeline :: SpiderHost x a -> SpiderTimelineEnv x -> IO a
2582runSpiderHostForTimeline :: SpiderHost x a -> SpiderTimelineEnv x -> IO a
2863runSpiderHostForTimeline (SpiderHost a) _ = a
2583runSpiderHostForTimeline (SpiderHost a) _ = a
2864
2584
2865−newtype SpiderHostFrame (x :: Type) a = SpiderHostFrame { runSpiderHostFrame :: EventM x a }
2585+newtype SpiderHostFrame x a = SpiderHostFrame { runSpiderHostFrame :: EventM x a }
2866 deriving (Functor, Applicative, MonadFix, MonadIO, MonadException, MonadAsyncException)
2586 deriving (Functor, Applicative, MonadFix, MonadIO, MonadException, MonadAsyncException)
2867
2587
2868instance Monad (SpiderHostFrame x) where
2588instance Monad (SpiderHostFrame x) where
@@ -2872,21 +2592,19 @@ instance Monad (SpiderHostFrame x) where
2872 SpiderHostFrame x >> SpiderHostFrame y = SpiderHostFrame $ x >> y
2592 SpiderHostFrame x >> SpiderHostFrame y = SpiderHostFrame $ x >> y
2873 {-# INLINABLE return #-}
2593 {-# INLINABLE return #-}
2874 return x = SpiderHostFrame $ return x
2594 return x = SpiderHostFrame $ return x
2875−#if !MIN_VERSION_base(4,13,0)
2876 {-# INLINABLE fail #-}
2595 {-# INLINABLE fail #-}
2877 fail s = SpiderHostFrame $ fail s
2596 fail s = SpiderHostFrame $ fail s
2878−#endif
2879
2597
2880instance NotReady (SpiderTimeline x) (SpiderHostFrame x) where
2598instance NotReady (SpiderTimeline x) (SpiderHostFrame x) where
2881 notReadyUntil _ = pure ()
2599 notReadyUntil _ = pure ()
2882 notReady = pure ()
2600 notReady = pure ()
2883
2601
2884−newEventWithTriggerIO :: forall x a. HasSpiderTimeline x => (RootTrigger x a -> IO (IO ())) -> IO (Event x a)
2602+newEventWithTriggerIO :: (RootTrigger x a -> IO (IO ())) -> IO (Event x a)
2885newEventWithTriggerIO f = do
2603newEventWithTriggerIO f = do
2886 es <- newFanEventWithTriggerIO $ \Refl -> f
2604 es <- newFanEventWithTriggerIO $ \Refl -> f
2887 return $ select es Refl
2605 return $ select es Refl
2888
2606
2889−newFanEventWithTriggerIO :: (HasSpiderTimeline x, GCompare k) => (forall a. k a -> RootTrigger x a -> IO (IO ())) -> IO (EventSelector x k)
2607+newFanEventWithTriggerIO :: GCompare k => (forall a. k a -> RootTrigger x a -> IO (IO ())) -> IO (EventSelector x k)
2890newFanEventWithTriggerIO f = do
2608newFanEventWithTriggerIO f = do
2891 occRef <- newIORef DMap.empty
2609 occRef <- newIORef DMap.empty
2892 subscribedRef <- newIORef DMap.empty
2610 subscribedRef <- newIORef DMap.empty
@@ -2920,11 +2638,3 @@ instance MonadAtomicRef (SpiderHostFrame x) where
2920instance PrimMonad (SpiderHostFrame x) where
2638instance PrimMonad (SpiderHostFrame x) where
2921 type PrimState (SpiderHostFrame x) = PrimState IO
2639 type PrimState (SpiderHostFrame x) = PrimState IO
2922 primitive = SpiderHostFrame . EventM . primitive
2640 primitive = SpiderHostFrame . EventM . primitive
2923−
2924−instance NotReady (SpiderTimeline x) (SpiderHost x) where
2925− notReadyUntil _ = return ()
2926− notReady = return ()
2927−
2928−instance HasSpiderTimeline x => NotReady (SpiderTimeline x) (PerformEventT (SpiderTimeline x) (SpiderHost x)) where
2929− notReadyUntil _ = return ()
2930− notReady = return ()
src/Reflex/TriggerEvent/Base.hs−2
@@ -122,8 +122,6 @@ instance MonadHold t m => MonadHold t (TriggerEventT t m) where
122 buildDynamic a0 = lift . buildDynamic a0
122 buildDynamic a0 = lift . buildDynamic a0
123 {-# INLINABLE headE #-}
123 {-# INLINABLE headE #-}
124 headE = lift . headE
124 headE = lift . headE
125− {-# INLINABLE now #-}
126− now = lift now
127
125
128instance Adjustable t m => Adjustable t (TriggerEventT t m) where
126instance Adjustable t m => Adjustable t (TriggerEventT t m) where
129 {-# INLINABLE runWithReplace #-}
127 {-# INLINABLE runWithReplace #-}
src/Reflex/TriggerEvent/Class.hs+1−6
@@ -2,6 +2,7 @@
2-- new 'Event's that can be triggered from 'IO'.
2-- new 'Event's that can be triggered from 'IO'.
3{-# LANGUAGE FlexibleInstances #-}
3{-# LANGUAGE FlexibleInstances #-}
4{-# LANGUAGE FunctionalDependencies #-}
4{-# LANGUAGE FunctionalDependencies #-}
5+{-# LANGUAGE MultiParamTypeClasses #-}
5{-# LANGUAGE UndecidableInstances #-}
6{-# LANGUAGE UndecidableInstances #-}
6module Reflex.TriggerEvent.Class
7module Reflex.TriggerEvent.Class
7 ( TriggerEvent (..)
8 ( TriggerEvent (..)
@@ -12,7 +13,6 @@ import Reflex.Class
12import Control.Monad.Reader
13import Control.Monad.Reader
13import Control.Monad.State
14import Control.Monad.State
14import qualified Control.Monad.State.Strict as Strict
15import qualified Control.Monad.State.Strict as Strict
15−import Control.Monad.Trans.Maybe (MaybeT)
16
16
17--TODO: Shouldn't have IO hard-coded
17--TODO: Shouldn't have IO hard-coded
18-- | 'TriggerEvent' represents actions that can create 'Event's that can be
18-- | 'TriggerEvent' represents actions that can create 'Event's that can be
@@ -48,8 +48,3 @@ instance TriggerEvent t m => TriggerEvent t (Strict.StateT s m) where
48 newTriggerEvent = lift newTriggerEvent
48 newTriggerEvent = lift newTriggerEvent
49 newTriggerEventWithOnComplete = lift newTriggerEventWithOnComplete
49 newTriggerEventWithOnComplete = lift newTriggerEventWithOnComplete
50 newEventWithLazyTriggerWithOnComplete = lift . newEventWithLazyTriggerWithOnComplete
50 newEventWithLazyTriggerWithOnComplete = lift . newEventWithLazyTriggerWithOnComplete
51−
52−instance TriggerEvent t m => TriggerEvent t (MaybeT m) where
53− newTriggerEvent = lift newTriggerEvent
54− newTriggerEventWithOnComplete = lift newTriggerEventWithOnComplete
55− newEventWithLazyTriggerWithOnComplete = lift . newEventWithLazyTriggerWithOnComplete
src/Reflex/Widget/Basic.hs+1−1
@@ -13,7 +13,7 @@ import Data.Map (Map)
13
13
14import Reflex.Class
14import Reflex.Class
15import Reflex.Adjustable.Class
15import Reflex.Adjustable.Class
16−import Data.Patch.MapWithMove
16+import Reflex.Patch.MapWithMove
17
17
18
18
19-- | Build sortable content in such a way that re-sorting it can cause minimal
19-- | Build sortable content in such a way that re-sorting it can cause minimal
src/Reflex/Workflow.hs+1−1
@@ -34,7 +34,7 @@ workflow w0 = do
34 rec eResult <- networkHold (unWorkflow w0) $ fmap unWorkflow $ switch $ snd <$> current eResult
34 rec eResult <- networkHold (unWorkflow w0) $ fmap unWorkflow $ switch $ snd <$> current eResult
35 return $ fmap fst eResult
35 return $ fmap fst eResult
36
36
37−-- | Similar to 'workflow', but outputs an 'Event' that fires at post-build time and whenever the current 'Workflow' is replaced by the next 'Workflow'.
37+-- | Similar to 'workflow', but outputs an 'Event' that fires whenever the current 'Workflow' is replaced by the next 'Workflow'.
38workflowView :: forall t m a. (Reflex t, NotReady t m, Adjustable t m, MonadFix m, MonadHold t m, PostBuild t m) => Workflow t m a -> m (Event t a)
38workflowView :: forall t m a. (Reflex t, NotReady t m, Adjustable t m, MonadFix m, MonadHold t m, PostBuild t m) => Workflow t m a -> m (Event t a)
39workflowView w0 = do
39workflowView w0 = do
40 rec eResult <- networkView . fmap unWorkflow =<< holdDyn w0 eReplace
40 rec eResult <- networkView . fmap unWorkflow =<< holdDyn w0 eReplace
test/Adjustable.hsdeleted−62
@@ -1,62 +0,0 @@
1−{-# LANGUAGE BangPatterns #-}
2−{-# LANGUAGE LambdaCase #-}
3−{-# LANGUAGE RankNTypes #-}
4−{-# LANGUAGE RecursiveDo #-}
5−
6−module Main where
7−
8−import Control.Monad.Fix
9−import Data.Maybe
10−import qualified Data.Map as Map
11−
12−import Reflex
13−import Reflex.EventWriter.Base
14−import Reflex.Network
15−import Reflex.Patch.MapWithMove
16−import Test.Run
17−
18−main :: IO ()
19−main = do
20− let actions = [ Increment, Update0th, Increment, Swap, Increment, Increment ]
21− os <- runAppB testPatchMapWithMove $ map Just actions
22− -- If the final counter value in the adjusted widgets corresponds to the number of times it has
23− -- been incremented, we know that the networks haven't broken.
24− let expectedCount = length $ ffilter (== Increment) actions
25− -- let !True = last (last os) == [expectedCount,expectedCount] -- TODO re-enable this test after issue #369 has been resolved
26− return ()
27−
28−data PatchMapTestAction
29− = Increment
30− | Swap
31− | Update0th
32− deriving Eq
33−
34−-- See https://github.com/reflex-frp/reflex/issues/369 for the bug that this is testing.
35−testPatchMapWithMove
36− :: forall t m
37− . ( Reflex t
38− , Adjustable t m
39− , MonadHold t m
40− , MonadFix m
41− )
42− => Event t PatchMapTestAction
43− -> m (Behavior t [Int])
44−testPatchMapWithMove pulse = do
45− let pulseAction = ffor pulse $ \case
46− Increment -> Nothing
47− Swap -> patchMapWithMove $ Map.fromList
48− [ (0, NodeInfo (From_Move 1) (Just 1))
49− , (1, NodeInfo (From_Move 0) (Just 0))
50− ]
51− Update0th -> patchMapWithMove $ Map.fromList
52− [ (0, NodeInfo (From_Insert 'z') Nothing) ]
53− (_, result) <- runBehaviorWriterT $ mdo
54− counter <- foldDyn (+) 1 $ fmapMaybe (\e -> if isNothing e then Just 1 else Nothing) pulseAction
55− _ <- mapMapWithAdjustWithMove
56− (\_ _ -> networkHold
57− (tellBehavior $ constant [])
58− ((\t -> tellBehavior $ constant [t]) <$> updated counter))
59− (Map.fromList $ zip [0..] "ab")
60− (fmapMaybe id pulseAction)
61− return ()
62− return result
test/DebugCycles.hsdeleted−171
@@ -1,171 +0,0 @@
1−{-# LANGUAGE CPP #-}
2−{-# LANGUAGE ConstraintKinds #-}
3−{-# LANGUAGE FlexibleContexts #-}
4−{-# LANGUAGE GADTs #-}
5−{-# LANGUAGE RecursiveDo #-}
6−{-# LANGUAGE ScopedTypeVariables #-}
7−{-# LANGUAGE PatternSynonyms #-}
8−{-# LANGUAGE RankNTypes #-}
9−
10−module Main where
11−
12−import Data.Foldable
13−import Control.Lens
14−import Control.Applicative
15−import Control.Monad
16−import Control.Monad.Fix
17−import Control.Exception
18−import System.Timeout
19−import Data.Maybe (isJust)
20−import Data.Functor.Misc
21−import qualified Data.Map as Map
22−import Data.Map (Map)
23−import qualified Data.IntMap as IntMap
24−import Data.IntMap (IntMap)
25−import Data.These
26−import Data.Align
27−import Reflex
28−import Reflex.EventWriter.Base
29−import Test.Run
30−import Test.Hspec
31−import Reflex.Spider.Internal (EventLoopException)
32−import Data.Witherable (Filterable)
33−
34−#if defined(MIN_VERSION_these_lens) || (MIN_VERSION_these(0,8,0) && !MIN_VERSION_these(0,9,0))
35−import Data.These.Lens
36−#endif
37−
38−type Widget t m = (MonadHold t m, Reflex t, MonadFix m)
39−
40−connectDyn :: Widget t m => Event t () -> (Dynamic t a, Dynamic t a) -> m (Dynamic t a)
41−connectDyn e (d, d') = do
42− dd <- holdDyn d (d' <$ e)
43− return $ join dd
44−
45−dynLoop :: Widget t m => (Event t Int, Event t ()) -> m (Event t Int)
46−dynLoop (e1, e2) = do
47− -- "heightBagRemove: Height 2 not present in bag HeightBag {_heightBag_size = 2, _heightBag_contents = fromList [(0,1)]}"
48− rec
49− d <- count e1
50− d' <- connectDyn e2 (d, liftA2 (+) d d')
51− return $ updated d'
52−
53−connectOnCoincidence :: Widget t m => Event t () -> Event t a -> m (Event t a)
54−connectOnCoincidence click e = do
55− d <- holdDyn never (e <$ click)
56− return $ coincidence (updated d)
57−
58−coincidenceLoop :: Widget t m => (Event t Int, Event t ()) -> m (Event t Int)
59−coincidenceLoop (e1, e2) = do
60−-- "heightBagRemove: Height 1 not present in bag HeightBag {_heightBag_size = 1, _heightBag_contents = fromList [(0,0)]}"
61−-- (simpler version of dynLoop)
62− rec
63− e' <- connectOnCoincidence e2 (updated d)
64− d <- count (align e' e1)
65− return $ updated d
66−
67−addHeight :: Reflex t => Event t a -> Event t a
68−addHeight e = leftmost [e4, e4] where
69− e1 = leftmost [e, e]
70− e2 = leftmost [e1, e1]
71− e3 = leftmost [e2, e2]
72− e4 = leftmost [e3, e3]
73−
74−-- Take an existing test and build it inside a
75−buildLoop :: Widget t m => (forall t m. Widget t m => (Event t Int, Event t ()) -> m (Event t Int)) -> (Event t Int, Event t ()) -> m (Event t Int)
76−buildLoop test (e1, e2) = switchHold never buildLoop
77− where buildLoop = pushAlways (const $ test (e1, e2)) e2
78−
79−connectButtonPromptly :: Widget t m => Event t () -> Event t a -> m (Event t a)
80−connectButtonPromptly click e = do
81− d <- holdDyn never (e <$ click)
82− return (switchDyn d)
83−
84−connectButton :: Widget t m => Event t () -> Event t a -> m (Event t a)
85−connectButton click e = do
86− d <- hold never (e <$ click)
87− return (switch d)
88−
89−switchLoop01 :: Widget t m => (Event t Int, Event t ()) -> m (Event t Int)
90−switchLoop01 (e1, e2) = do
91− rec
92− e' <- connectButton e2 (updated d)
93− d <- count (align e' e1)
94− return $ updated d
95−
96−mergeLoop :: forall t m. (Adjustable t m, Widget t m) => (Event t Int, Event t ()) -> m (Event t Int)
97−mergeLoop (e1, e2) = do
98− rec
99− (_, e) <- runEventWriterT $
100− runWithReplace w (leftmost [w <$ e1])
101− return (sum <$> e)
102− where
103− w = do
104− c <- count e1
105− tellEvent (updated ((pure <$> c) :: Dynamic t [Int]))
106−
107−switchLoop02 :: Widget t m => (Event t Int, Event t ()) -> m (Event t Int)
108−switchLoop02 (e1, e2) = do
109− rec
110− e' <- connectButton e2 (updated d)
111− d <- count (leftmost [e', e1])
112− return $ updated d
113−
114−switchLoop03 :: Widget t m => (Event t Int, Event t ()) -> m (Event t Int)
115−switchLoop03 (e1, e2) = do
116− rec
117− e' <- connectButton e2 (addHeight $ updated d)
118− d <- count (align e' e1)
119− return $ updated d
120−
121−staticLoop01 :: Widget t m => (Event t Int, Event t ()) -> m (Event t Int)
122−staticLoop01 (e1, e2) = do
123− rec
124− d <- foldDyn (+) (0 :: Int) (1 <$ align e1 (updated d))
125− return $ updated d
126−
127−staticLoop02 :: Widget t m => (Event t Int, Event t ()) -> m (Event t Int)
128−staticLoop02 (e1, e2) = do
129− rec
130− d <- foldDyn (+) (0 :: Int) (leftmost [e1, updated d])
131− return $ updated d
132−
133−buildStaticLoop :: Widget t m => (Event t Int, Event t ()) -> m (Event t Int)
134−buildStaticLoop (e1, e2) = switchHold never buildLoop
135− where buildLoop = pushAlways (const $ staticLoop01 (e1, e2)) e2
136−
137−splitThese :: Filterable f => f (These a b) -> (f a, f b)
138−splitThese f = (mapMaybe (preview here) f, mapMaybe (preview there) f)
139−
140−main :: IO ()
141−main = hspec $ do
142− describe "DebugCycles" $ do
143− it "throws EventLoopException on switchLoop01" $ do
144− check switchLoop01
145− it "throws EventLoopException on switchLoop02" $ do
146− check switchLoop02
147− it "throws EventLoopException on switchLoop03" $ do
148− check switchLoop03
149− it "throws EventLoopException on buildSwitchLoop" $ do
150− check $ buildLoop switchLoop01
151− xit "throws EventLoopException on mergeLoop" $ do
152− check mergeLoop
153− xit "throws EventLoopException on staticLoop01" $ do
154− check staticLoop01
155− xit "throws EventLoopException on staticLoop02" $ do
156− check staticLoop02
157− xit "throws EventLoopException on buildStaticLoop" $ do
158− check buildStaticLoop
159− xit "throws EventLoopException on coincidenceLoop" $ do
160− check coincidenceLoop
161− xit "throws EventLoopException on dynLoop" $ do
162− check dynLoop
163− xit "throws EventLoopException on buildCoincidenceLoop" $ do
164− check $ buildLoop coincidenceLoop
165− where
166− milliseconds = (*1000)
167− occs = [ This 1, This 2, That (), This 3, That (), This 1 ]
168− check test = do
169− let action = timeout (milliseconds 50) $ do
170− runApp' (test . splitThese) (Just <$> occs)
171− action `shouldThrow` (const True :: Selector EventLoopException)
test/EventWriterT.hs+4−6
@@ -1,4 +1,3 @@
1−{-# LANGUAGE CPP #-}
2{-# LANGUAGE BangPatterns #-}
1{-# LANGUAGE BangPatterns #-}
3{-# LANGUAGE FlexibleContexts #-}
2{-# LANGUAGE FlexibleContexts #-}
4{-# LANGUAGE GADTs #-}
3{-# LANGUAGE GADTs #-}
@@ -14,10 +13,6 @@ import Data.Functor.Misc
14import qualified Data.Map as M
13import qualified Data.Map as M
15import Data.These
14import Data.These
16
15
17−#if defined(MIN_VERSION_these_lens) || (MIN_VERSION_these(0,8,0) && !MIN_VERSION_these(0,9,0))
18−import Data.These.Lens
19−#endif
20−
21import Reflex
16import Reflex
22import Reflex.EventWriter.Base
17import Reflex.EventWriter.Base
23import Test.Run
18import Test.Run
@@ -53,13 +48,16 @@ unwrapApp x appIn = do
53 return e
48 return e
54
49
55testOrdering :: (Reflex t, Monad m) => Event t () -> EventWriterT t [Int] m ()
50testOrdering :: (Reflex t, Monad m) => Event t () -> EventWriterT t [Int] m ()
51+testOrdering pulse = do
56−testOrdering pulse = forM_ [10,9..1] $ \i -> tellEvent ([i] <$ pulse)
52+ forM_ [10,9..1] $ \i -> tellEvent ([i] <$ pulse)
53+ return ()
57
54
58testSimultaneous :: (Reflex t, Adjustable t m, MonadHold t m) => Event t (These () ()) -> EventWriterT t [Int] m ()
55testSimultaneous :: (Reflex t, Adjustable t m, MonadHold t m) => Event t (These () ()) -> EventWriterT t [Int] m ()
59testSimultaneous pulse = do
56testSimultaneous pulse = do
60 let e0 = fmapMaybe (^? here) pulse
57 let e0 = fmapMaybe (^? here) pulse
61 e1 = fmapMaybe (^? there) pulse
58 e1 = fmapMaybe (^? there) pulse
62 forM_ [1,3..9] $ \i -> runWithReplace (tellEvent ([i] <$ e0)) $ ffor e1 $ \_ -> tellEvent ([i+1] <$ e0)
59 forM_ [1,3..9] $ \i -> runWithReplace (tellEvent ([i] <$ e0)) $ ffor e1 $ \_ -> tellEvent ([i+1] <$ e0)
60+ return ()
63
61
64-- | Test that a widget telling and event which fires at the same time it has been replaced
62-- | Test that a widget telling and event which fires at the same time it has been replaced
65-- doesn't count along with the new widget.
63-- doesn't count along with the new widget.
test/GC.hs+5−6
@@ -18,17 +18,15 @@ import Data.GADT.Compare
18import Data.IORef
18import Data.IORef
19import Data.Semigroup
19import Data.Semigroup
20import Data.These
20import Data.These
21−import Data.Type.Equality ((:~:)(Refl))
22
21
23import Data.Functor.Misc
22import Data.Functor.Misc
24−import Data.Patch
23+import Reflex.Patch
25
24
26import qualified Reflex.Host.Class as Host
25import qualified Reflex.Host.Class as Host
27import qualified Reflex.Spider.Internal as S
26import qualified Reflex.Spider.Internal as S
28
27
29import System.Exit
28import System.Exit
30import System.Mem
29import System.Mem
31−import Data.Coerce
32
30
33main :: IO ()
31main :: IO ()
34main = do
32main = do
@@ -48,7 +46,7 @@ hostPerf ref = S.runSpiderHost $ do
48 eventToPerform <- Host.runHostFrame $ do
46 eventToPerform <- Host.runHostFrame $ do
49 (reqMap :: S.Event S.Global (DMap (Const2 Int (DMap Tell (S.SpiderHostFrame S.Global))) Identity))
47 (reqMap :: S.Event S.Global (DMap (Const2 Int (DMap Tell (S.SpiderHostFrame S.Global))) Identity))
50 <- S.SpiderHostFrame
48 <- S.SpiderHostFrame
51− $ fmap ( S.mergeG coerce
49+ $ fmap ( S.merge
52 . S.dynamicHold)
50 . S.dynamicHold)
53 $ S.hold DMap.empty
51 $ S.hold DMap.empty
54 -- Construct a new heap object for the subscriber, invalidating any weak references to the subscriber if they are not retained
52 -- Construct a new heap object for the subscriber, invalidating any weak references to the subscriber if they are not retained
@@ -57,8 +55,8 @@ hostPerf ref = S.runSpiderHost $ do
57 { S.subscriberPropagate = S.subscriberPropagate sub
55 { S.subscriberPropagate = S.subscriberPropagate sub
58 }
56 }
59 return (s, o))
57 return (s, o))
60− $ runIdentity . runIdentity <$> S.selectG
58+ $ runIdentity <$> S.select
61− (S.fanG $ S.pushCheap (return . Just . mapKeyValuePairsMonotonic (\(t :=> e) -> WrapArg t :=> Identity e)) response)
59+ (S.fan $ S.pushCheap (return . Just . mapKeyValuePairsMonotonic (\(t :=> e) -> WrapArg t :=> Identity e)) response)
62 (WrapArg Request)
60 (WrapArg Request)
63 return $ alignWith (mergeThese (<>))
61 return $ alignWith (mergeThese (<>))
64 (flip S.pushCheap eadd $ \_ -> return $ Just $ DMap.singleton Request $ do
62 (flip S.pushCheap eadd $ \_ -> return $ Just $ DMap.singleton Request $ do
@@ -84,6 +82,7 @@ hostPerf ref = S.runSpiderHost $ do
84 Nothing -> []
82 Nothing -> []
85 Host.fireEventsAndRead followupEventTriggers $ return ()
83 Host.fireEventsAndRead followupEventTriggers $ return ()
86 return ()
84 return ()
85+ return ()
87
86
88data Tell a where
87data Tell a where
89 Action :: Tell ()
88 Action :: Tell ()
test/Headless.hsdeleted−10
@@ -1,10 +0,0 @@
1−module Main where
2−
3−import Reflex
4−import Reflex.Host.Headless (runHeadlessApp)
5−
6−main :: IO ()
7−main = do
8− runHeadlessApp $ do
9− pb <- getPostBuild
10− performEvent (pure <$> pb)
test/QueryT.hs+1−5
@@ -19,12 +19,8 @@ import Data.Map.Monoidal (MonoidalMap)
19import Data.Semigroup
19import Data.Semigroup
20import Data.These
20import Data.These
21
21
22−#if defined(MIN_VERSION_these_lens) || (MIN_VERSION_these(0,8,0) && !MIN_VERSION_these(0,9,0))
23−import Data.These.Lens
24−#endif
25−
26import Reflex
22import Reflex
27−import Data.Patch.MapWithMove
23+import Reflex.Patch.MapWithMove
28import Test.Run
24import Test.Run
29
25
30newtype MyQuery = MyQuery SelectedCount
26newtype MyQuery = MyQuery SelectedCount
test/Reflex/Bench/Focused.hs−12
@@ -130,16 +130,6 @@ mapDynChain = iterM (return . fmap (+1))
130joinDynChain :: (Reflex t, MonadHold t m) => Word -> Dynamic t Word -> m (Dynamic t Word)
130joinDynChain :: (Reflex t, MonadHold t m) => Word -> Dynamic t Word -> m (Dynamic t Word)
131joinDynChain = iterM (\d -> return $ join $ fmap (const d) d)
131joinDynChain = iterM (\d -> return $ join $ fmap (const d) d)
132
132
133−holdDynChain :: (Reflex t, MonadHold t m) => Word -> Dynamic t Word -> m (Dynamic t Word)
134−holdDynChain = iterM (\d -> sample (current d) >>= flip holdDyn (updated d))
135−
136−buildDynChain :: (Reflex t, MonadHold t m) => Word -> Dynamic t Word -> m (Dynamic t Word)
137−buildDynChain = iterM (\d -> do
138− let b = fmap (+1) (current d)
139− e = fmap (*2) (updated d)
140− buildDynamic (sample b) e)
141−
142−
143combineDynChain :: (Reflex t, MonadHold t m) => Word -> Dynamic t Word -> m (Dynamic t Word)
133combineDynChain :: (Reflex t, MonadHold t m) => Word -> Dynamic t Word -> m (Dynamic t Word)
144combineDynChain = iterM (\d -> return $ zipDynWith (+) d d)
134combineDynChain = iterM (\d -> return $ zipDynWith (+) d d)
145
135
@@ -318,8 +308,6 @@ dynamics :: Word -> [(String, TestCase)]
318dynamics n =
308dynamics n =
319 [ testE "mapDynChain" $ fmap updated $ mapDynChain n =<< d
309 [ testE "mapDynChain" $ fmap updated $ mapDynChain n =<< d
320 , testE "joinDynChain" $ fmap updated $ joinDynChain n =<< d
310 , testE "joinDynChain" $ fmap updated $ joinDynChain n =<< d
321− , testE "holdDynChain" $ fmap updated $ holdDynChain n =<< d
322− , testE "buildDynChain" $ fmap updated $ buildDynChain n =<< d
323 , testE "combineDynChain" $ fmap updated $ combineDynChain n =<< d
311 , testE "combineDynChain" $ fmap updated $ combineDynChain n =<< d
324 , testE "dense mergeTree" $ fmap (updated . mergeTreeDyn 8) dense
312 , testE "dense mergeTree" $ fmap (updated . mergeTreeDyn 8) dense
325 , testE "sparse mergeTree" $ fmap (updated . mergeTreeDyn 8) sparse
313 , testE "sparse mergeTree" $ fmap (updated . mergeTreeDyn 8) sparse
test/Reflex/Plan/Pure.hs−1
@@ -41,7 +41,6 @@ instance MonadHold (Pure Int) PurePlan where
41 holdIncremental initial = liftPlan . holdIncremental initial
41 holdIncremental initial = liftPlan . holdIncremental initial
42 buildDynamic getInitial = liftPlan . buildDynamic getInitial
42 buildDynamic getInitial = liftPlan . buildDynamic getInitial
43 headE = liftPlan . headE
43 headE = liftPlan . headE
44− now = liftPlan now
45
44
46instance MonadSample (Pure Int) PurePlan where
45instance MonadSample (Pure Int) PurePlan where
47 sample = liftPlan . sample
46 sample = liftPlan . sample
test/Reflex/Test/CrossImpl.hs+8−18
@@ -21,12 +21,11 @@ import Reflex.Dynamic
21import Reflex.Host.Class
21import Reflex.Host.Class
22import qualified Reflex.Pure as P
22import qualified Reflex.Pure as P
23import qualified Reflex.Spider.Internal as S
23import qualified Reflex.Spider.Internal as S
24−import qualified Reflex.Profiled as Prof
25
24
26import Control.Arrow (second, (&&&))
25import Control.Arrow (second, (&&&))
27import Control.Monad.Identity hiding (forM, forM_, mapM, mapM_, sequence, sequence_)
26import Control.Monad.Identity hiding (forM, forM_, mapM, mapM_, sequence, sequence_)
28import Control.Monad.State.Strict hiding (forM, forM_, mapM, mapM_, sequence, sequence_)
27import Control.Monad.State.Strict hiding (forM, forM_, mapM, mapM_, sequence, sequence_)
29−import Data.Dependent.Sum (DSum (..))
28+import Data.Dependent.Map (DSum (..))
30import Data.Foldable
29import Data.Foldable
31import Data.Map.Strict (Map)
30import Data.Map.Strict (Map)
32import qualified Data.Map.Strict as Map
31import qualified Data.Map.Strict as Map
@@ -36,6 +35,8 @@ import Data.Traversable
36import System.Exit
35import System.Exit
37import System.Mem
36import System.Mem
38
37
38+import System.IO.Unsafe
39+
39mapToPureBehavior :: Map Int a -> Behavior PureReflexDomain a
40mapToPureBehavior :: Map Int a -> Behavior PureReflexDomain a
40mapToPureBehavior m = P.Behavior $ \t -> case Map.lookupLE t m of
41mapToPureBehavior m = P.Behavior $ \t -> case Map.lookupLE t m of
41 Nothing -> error $ "mapToPureBehavior: no value for time " <> show t
42 Nothing -> error $ "mapToPureBehavior: no value for time " <> show t
@@ -72,14 +73,11 @@ instance MapMSignals (Event t a) (Event t' a) t t' where
72instance (MapMSignals a a' t t', MapMSignals b b' t t') => MapMSignals (a, b) (a', b') t t' where
73instance (MapMSignals a a' t t', MapMSignals b b' t t') => MapMSignals (a, b) (a', b') t t' where
73 mapMSignals fb fe (a, b) = liftM2 (,) (mapMSignals fb fe a) (mapMSignals fb fe b)
74 mapMSignals fb fe (a, b) = liftM2 (,) (mapMSignals fb fe a) (mapMSignals fb fe b)
74
75
75−testTimeline
76− :: (forall m t. TestCaseConstraint t m => (Behavior t a, Event t b) -> m (Behavior t c, Event t d))
76+testSpider :: (forall m t. TestCaseConstraint t m => (Behavior t a, Event t b) -> m (Behavior t c, Event t d)) -> (Map Int a, Map Int b) -> (Map Int c, Map Int d)
77− -> (Map Int a, Map Int b)
78− -> (forall m t. (MonadReflexHost t m, MonadIO m, MonadRef m, Ref m ~ Ref IO, MonadSample t m) => m (Map Int c, Map Int d))
79−testTimeline builder (bMap, eMap) = do
77+testSpider builder (bMap, eMap) = unsafePerformIO $ S.runSpiderHost $ do
80 (re, reTrigger) <- newEventWithTriggerRef
78 (re, reTrigger) <- newEventWithTriggerRef
81 (rb, rbTrigger) <- newEventWithTriggerRef
79 (rb, rbTrigger) <- newEventWithTriggerRef
82− b <- runHostFrame $ hold (error "testTimeline: No value for input behavior yet") rb
80+ b <- runHostFrame $ hold (error "testSpider: No value for input behavior yet") rb
83 (b', e') <- runHostFrame $ builder (b, re)
81 (b', e') <- runHostFrame $ builder (b, re)
84 e'Handle <- subscribeEvent e' --TODO: This should be unnecessary
82 e'Handle <- subscribeEvent e' --TODO: This should be unnecessary
85 let times = relevantTestingTimes (bMap, eMap)
83 let times = relevantTestingTimes (bMap, eMap)
@@ -104,11 +102,9 @@ testAgreement :: (Eq c, Eq d, Show c, Show d) => (forall m t. TestCaseConstraint
104testAgreement builder inputs = do
102testAgreement builder inputs = do
105 let identityResult = testPure builder inputs
103 let identityResult = testPure builder inputs
106 tracePerf "---------" $ return ()
104 tracePerf "---------" $ return ()
107− spiderResult <- S.runSpiderHost $ testTimeline builder inputs
105+ let spiderResult = testSpider builder inputs
108− tracePerf "---------" $ return ()
109− profiledResult <- S.runSpiderHost $ Prof.runProfiledM $ testTimeline builder inputs
110 tracePerf "---------" $ return ()
106 tracePerf "---------" $ return ()
111− let resultsAgree = identityResult == spiderResult && identityResult == profiledResult
107+ let resultsAgree = identityResult == spiderResult
112 if resultsAgree
108 if resultsAgree
113 then do --putStrLn "Success:"
109 then do --putStrLn "Success:"
114 --print identityResult
110 --print identityResult
@@ -116,7 +112,6 @@ testAgreement builder inputs = do
116 else do putStrLn "Failure:"
112 else do putStrLn "Failure:"
117 putStrLn $ "Pure result: " <> show identityResult
113 putStrLn $ "Pure result: " <> show identityResult
118 putStrLn $ "Spider result: " <> show spiderResult
114 putStrLn $ "Spider result: " <> show spiderResult
119− putStrLn $ "Profiled result: " <> show profiledResult
120 return resultsAgree
115 return resultsAgree
121
116
122type TestCaseConstraint t m = (Reflex t, MonadSample t m, MonadHold t m, MonadFix m, MonadFix (PushM t))
117type TestCaseConstraint t m = (Reflex t, MonadSample t m, MonadHold t m, MonadFix m, MonadFix (PushM t))
@@ -223,11 +218,6 @@ testCases =
223 bb <- hold b $ pushAlways (const $ hold "asdf" eo) eo
218 bb <- hold b $ pushAlways (const $ hold "asdf" eo) eo
224 let b' = pull $ sample =<< sample bb
219 let b' = pull $ sample =<< sample bb
225 return (b', e)
220 return (b', e)
226− , (,) "foldDynWhileFiring" $ TestCase (Map.singleton 0 "zxc", Map.fromList [(1, "qwer"), (2, "lkj")]) $ \(_, e) -> do
227− d <- foldDyn (:) [] $
228− pushAlways (\a -> foldDyn (:) [a] e) e
229− let b = current (join (fmap distributeListOverDynPure d))
230− return (b, e)
231 , (,) "joinDyn" $ TestCase (Map.singleton 0 (0 :: Int), Map.fromList [(1, "qwer"), (2, "lkj")]) $ \(b, e) -> do
221 , (,) "joinDyn" $ TestCase (Map.singleton 0 (0 :: Int), Map.fromList [(1, "qwer"), (2, "lkj")]) $ \(b, e) -> do
232 bb <- hold "b" e
222 bb <- hold "b" e
233 bd <- hold never . fmap (const e) =<< headE e
223 bd <- hold never . fmap (const e) =<< headE e
test/Reflex/Test/Micro.hs+2−8
@@ -322,14 +322,8 @@ testCases =
322 let e = never <$ switch b
322 let e = never <$ switch b
323 return $ void e
323 return $ void e
324 lazyHold
324 lazyHold
325− , testE "now-1" $ do
325+
326− e1 <- events1
326+
327− switchHoldPromptly never . pushAlways (\a -> fmap (a <$) now) $ e1
328− , testE "now-2" $ do
329− e1 <- events1
330− let e = pushAlways (\a -> if a == "a" then now else return never) e1
331− x <- accumDyn (<>) never e
332− return . coincidence $ updated x
333 ] where
327 ] where
334
328
335 events1, events2, events3 :: TestPlan t m => m (Event t String)
329 events1, events2, events3 :: TestPlan t m => m (Event t String)
test/RequesterT.hs+2−68
@@ -1,40 +1,19 @@
1−{-# LANGUAGE CPP #-}
2{-# LANGUAGE BangPatterns #-}
1{-# LANGUAGE BangPatterns #-}
3{-# LANGUAGE FlexibleContexts #-}
2{-# LANGUAGE FlexibleContexts #-}
4−{-# LANGUAGE FlexibleInstances #-}
5{-# LANGUAGE GADTs #-}
3{-# LANGUAGE GADTs #-}
6−{-# LANGUAGE LambdaCase #-}
4+{-# LANGUAGE RankNTypes #-}
7−{-# LANGUAGE MultiParamTypeClasses #-}
8{-# LANGUAGE RecursiveDo #-}
5{-# LANGUAGE RecursiveDo #-}
9{-# LANGUAGE ScopedTypeVariables #-}
6{-# LANGUAGE ScopedTypeVariables #-}
10−{-# LANGUAGE TemplateHaskell #-}
11−{-# LANGUAGE TypeApplications #-}
12−{-# LANGUAGE TypeFamilies #-}
13module Main where
7module Main where
14
8
15−import Control.Lens hiding (has)
9+import Control.Lens
16import Control.Monad
10import Control.Monad
17import Control.Monad.Fix
11import Control.Monad.Fix
18−import Control.Monad.IO.Class (MonadIO)
19−import Data.Constraint.Extras
20−import Data.Constraint.Extras.TH
21−import Data.Constraint.Forall
22import qualified Data.Dependent.Map as DMap
12import qualified Data.Dependent.Map as DMap
23import Data.Dependent.Sum
13import Data.Dependent.Sum
24import Data.Functor.Misc
14import Data.Functor.Misc
25−import Data.List (words)
26−import Data.Map (Map)
27import qualified Data.Map as M
15import qualified Data.Map as M
28−#if !MIN_VERSION_these(4,11,0)
29−import Data.Semigroup ((<>))
30−#endif
31−import Data.Text (Text)
32import Data.These
16import Data.These
33−import Text.Read (readMaybe)
34−
35−#if defined(MIN_VERSION_these_lens) || (MIN_VERSION_these(0,8,0) && !MIN_VERSION_these(0,9,0))
36−import Data.These.Lens
37−#endif
38
17
39import Reflex
18import Reflex
40import Reflex.Requester.Base
19import Reflex.Requester.Base
@@ -65,19 +44,12 @@ main = do
65 print os5
44 print os5
66 os6 <- runApp' (unwrapApp delayedPulse) [Just ()]
45 os6 <- runApp' (unwrapApp delayedPulse) [Just ()]
67 print os6
46 print os6
68− os7 <- runApp' testMatchRequestsWithResponses [ Just $ TestRequest_Increment 1 ]
69− print os7
70− os8 <- runApp' testMatchRequestsWithResponses [ Just $ TestRequest_Reverse "yoyo" ]
71− print os8
72 let ![[Just [1,2,3,4,5,6,7,8,9,10]]] = os1 -- The order is reversed here: see the documentation for 'runRequesterT'
47 let ![[Just [1,2,3,4,5,6,7,8,9,10]]] = os1 -- The order is reversed here: see the documentation for 'runRequesterT'
73 let ![[Just [9,7,5,3,1]],[Nothing,Nothing],[Just [10,8,6,4,2]],[Just [10,8,6,4,2],Nothing]] = os2
48 let ![[Just [9,7,5,3,1]],[Nothing,Nothing],[Just [10,8,6,4,2]],[Just [10,8,6,4,2],Nothing]] = os2
74 let ![[Nothing, Just [2]]] = os3
49 let ![[Nothing, Just [2]]] = os3
75 let ![[Nothing, Just [2]]] = os4
50 let ![[Nothing, Just [2]]] = os4
76 let ![[Nothing, Just [1, 2]]] = os5
51 let ![[Nothing, Just [1, 2]]] = os5
77 -- let ![[Nothing, Nothing]] = os6 -- TODO re-enable this test after issue #233 has been resolved
52 -- let ![[Nothing, Nothing]] = os6 -- TODO re-enable this test after issue #233 has been resolved
78− let !(Just [(1,"2")]) = M.toList <$> head (head os7)
79− let !(Just [(1,"oyoy")]) = M.toList <$> head (head os8)
80−
81 return ()
53 return ()
82
54
83unwrapRequest :: DSum tag RequestInt -> Int
55unwrapRequest :: DSum tag RequestInt -> Int
@@ -195,41 +167,3 @@ delayedPulse pulse = void $ flip runWithReplace (pure () <$ pulse) $ do
195 -- This has the effect of delaying pulse' from pulse
167 -- This has the effect of delaying pulse' from pulse
196 (_, pulse') <- runWithReplace (pure ()) $ pure (RequestInt 1) <$ pulse
168 (_, pulse') <- runWithReplace (pure ()) $ pure (RequestInt 1) <$ pulse
197 requestingIdentity pulse'
169 requestingIdentity pulse'
198−
199−data TestRequest a where
200− TestRequest_Reverse :: String -> TestRequest String
201− TestRequest_Increment :: Int -> TestRequest Int
202−
203−testMatchRequestsWithResponses
204− :: forall m t req a
205− . ( MonadFix m
206− , MonadHold t m
207− , Reflex t
208− , PerformEvent t m
209− , MonadIO (Performable m)
210− , ForallF Show req
211− , Has Read req
212− )
213− => Event t (req a) -> m (Event t (Map Int String))
214−testMatchRequestsWithResponses pulse = mdo
215− (_, requests) <- runRequesterT (requesting pulse) responses
216− let rawResponses = M.map (\v ->
217− case words v of
218− ["reverse", str] -> reverse str
219− ["increment", i] -> show $ succ $ (read i :: Int)
220− ) <$> rawRequestMap
221− (rawRequestMap, responses) <- matchResponsesWithRequests reqEncoder requests (head . M.toList <$> rawResponses)
222− pure rawResponses
223− where
224− reqEncoder :: forall a. req a -> (String, String -> Maybe a)
225− reqEncoder r =
226− ( whichever @Show @req @a $ show r
227− , \x -> has @Read r $ readMaybe x
228− )
229−
230−deriveArgDict ''TestRequest
231−
232−instance Show (TestRequest a) where
233− show = \case
234− TestRequest_Reverse str -> "reverse " <> str
235− TestRequest_Increment i -> "increment " <> show i
test/hlint.hs+8−3
@@ -1,7 +1,7 @@
1module Main where
1module Main where
2
2
3import Control.Monad
3import Control.Monad
4−import Language.Haskell.HLint (hlint)
4+import Language.Haskell.HLint3 (hlint)
5import System.Directory
5import System.Directory
6import System.Exit (exitFailure, exitSuccess)
6import System.Exit (exitFailure, exitSuccess)
7import System.FilePath
7import System.FilePath
@@ -22,8 +22,6 @@ main = do
22 , "--ignore=Use unless"
22 , "--ignore=Use unless"
23 , "--ignore=Reduce duplication"
23 , "--ignore=Reduce duplication"
24 , "--cpp-define=USE_TEMPLATE_HASKELL"
24 , "--cpp-define=USE_TEMPLATE_HASKELL"
25− , "--cpp-define=DEBUG"
26− , "--ignore=Use tuple-section"
27 ]
25 ]
28 recurseInto = and <$> sequence
26 recurseInto = and <$> sequence
29 [ fileType ==? Directory
27 [ fileType ==? Directory
@@ -31,9 +29,16 @@ main = do
31 ]
29 ]
32 matchFile = and <$> sequence
30 matchFile = and <$> sequence
33 [ extension ==? ".hs"
31 [ extension ==? ".hs"
32+ , let notElem' = liftOp notElem
33+ in filePath `notElem'` filePathExceptions pwd
34 ]
34 ]
35 files <- find recurseInto matchFile (pwd </> "src") --TODO: Someday fix all hints in tests, etc.
35 files <- find recurseInto matchFile (pwd </> "src") --TODO: Someday fix all hints in tests, etc.
36 ideas <- fmap concat $ forM files $ \f -> do
36 ideas <- fmap concat $ forM files $ \f -> do
37 putStr $ "linting file " ++ drop (length pwd + 1) f ++ "... "
37 putStr $ "linting file " ++ drop (length pwd + 1) f ++ "... "
38 runHlint f
38 runHlint f
39 if null ideas then exitSuccess else exitFailure
39 if null ideas then exitSuccess else exitFailure
40+
41+filePathExceptions :: FilePath -> [FilePath]
42+filePathExceptions pwd = map (pwd </>) $
43+ [ "src/Data/AppendMap.hs" -- parse error when hlint runs
44+ ]