@@ -9,6 +9,7 @@
99{-# LANGUAGE GADTs #-}
1010{-# LANGUAGE GeneralizedNewtypeDeriving #-}
1111{-# LANGUAGE LambdaCase #-}
12+{-# LANGUAGE MultiWayIf #-}
1213{-# LANGUAGE RankNTypes #-}
1314{-# LANGUAGE RoleAnnotations #-}
1415{-# LANGUAGE ScopedTypeVariables #-}
@@ -19,7 +20,6 @@
1920{-# LANGUAGE DeriveFunctor #-}
2021{-# LANGUAGE StandaloneDeriving #-}
2122{-# LANGUAGE InstanceSigs #-}
22−{-# LANGUAGE MultiWayIf #-}
2323
2424#ifdef USE_REFLEX_OPTIMIZER
2525{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
@@ -38,17 +38,15 @@ import Control.Monad hiding (forM, forM_, mapM, mapM_)
3838import Control.Monad.Exception
3939import Control.Monad.Identity hiding (forM, forM_, mapM, mapM_)
4040import Control.Monad.Primitive
41+--import Control.Monad.Reader hiding (forM, forM_, mapM, mapM_)
4142import Control.Monad.Reader.Class
4243import Control.Monad.IO.Class
4344import Control.Monad.ReaderIO
4445import Control.Monad.Ref
45−import Control.Monad.Fail (MonadFail)
46−import qualified Control.Monad.Fail as MonadFail
4746import Data.Align
4847import Data.Coerce
49−import Data.Dependent.Map (DMap)
48+import Data.Dependent.Map (DMap, DSum (..))
5049import qualified Data.Dependent.Map as DMap
51−import Data.Dependent.Sum (DSum (..))
5250import Data.FastMutableIntMap (FastMutableIntMap, PatchIntMap (..))
5351import qualified Data.FastMutableIntMap as FastMutableIntMap
5452import Data.Foldable hiding (concat, elem, sequence_)
@@ -61,13 +59,12 @@ import qualified Data.IntMap.Strict as IntMap
6159import Data.IORef
6260import Data.Kind (Type)
6361import Data.Maybe hiding (mapMaybe)
64−import Data.Monoid (mempty, (<>))
62+import Data.Monoid ((<>))
6563import Data.Proxy
6664import Data.These
6765import Data.Traversable
68−import Data.Type.Equality ((:~:)(Refl))
6966import Data.Witherable (Filterable, mapMaybe)
70−import GHC.Exts hiding (toList)
67+import GHC.Exts
7168import GHC.IORef (IORef (..))
7269import GHC.Stack
7370import Reflex.FastWeak
@@ -86,16 +83,14 @@ import Data.Zip (Zip (..))
8683
8784#ifdef DEBUG_CYCLES
8885import Control.Monad.State hiding (forM, forM_, mapM, mapM_, sequence)
89−#endif
90−
9186import Data.List.NonEmpty (NonEmpty (..), nonEmpty)
9287import qualified Data.List.NonEmpty as NonEmpty
88+import Data.Monoid (mempty)
9389import Data.Tree (Forest, Tree (..), drawForest)
94−import Data.List (isPrefixOf)
90+#endif
9591
96−import Data.FastWeakBag (FastWeakBag, FastWeakBagTicket)
92+import Data.FastWeakBag (FastWeakBag)
9793import qualified Data.FastWeakBag as FastWeakBag
98−
9994import Data.Reflection
10095import Data.Some (Some(Some))
10196import Data.Type.Coercion
@@ -106,26 +101,21 @@ import qualified Reflex.Class
106101import qualified Reflex.Class as R
107102import qualified Reflex.Host.Class
108103import Reflex.NotReady.Class
109−import Data.Patch
110−import qualified Data.Patch.DMapWithMove as PatchDMapWithMove
104+import Reflex.Patch
105+import qualified Reflex.Patch.DMapWithMove as PatchDMapWithMove
111106import Reflex.PerformEvent.Base (PerformEventT)
112107
113108#ifdef DEBUG_TRACE_EVENTS
114109import qualified Data.ByteString.Char8 as BS8
115110import System.IO (stderr)
116−import Data.List (isPrefixOf)
117111#endif
118112
119−-- TODO stdout might not be the best channel for debug output
120−debugStrLn :: String -> IO ()
121−debugStrLn = putStrLn
122−
123113#ifdef DEBUG_TRACE_EVENTS
114+
124115withStackOneLine :: (BS8.ByteString -> a) -> a
125116withStackOneLine expr = unsafePerformIO $ do
126117 stack <- currentCallStack
127− return (expr . BS8.pack . unwords . dropInternal . reverse $ stack)
128− where dropInternal = filterStack "Reflex.Spider.Internal"
118+ return (expr (BS8.pack (unwords (reverse stack))))
129119
130120#endif
131121
@@ -136,42 +126,28 @@ debugInvalidateHeight :: Bool
136126debugInvalidate :: Bool
137127
138128#ifdef DEBUG
129+
139130#define DEBUG_NODEIDS
140131
141−#ifdef DEBUG_TRACE_PROPAGATION
142132debugPropagate = True
143−#else
144−debugPropagate = False
145−#endif
146133
147−#ifdef DEBUG_TRACE_HEIGHT
148−debugInvalidateHeight = True
149−#else
150134debugInvalidateHeight = False
151−#endif
152135
153−#ifdef DEBUG_TRACE_INVALIDATION
154136debugInvalidate = True
155−#else
156−debugInvalidate = False
157−#endif
158137
159138class HasNodeId a where
160139 getNodeId :: a -> Int
161140
162−instance HasNodeId (CacheSubscribed x a) where
163− getNodeId = _cacheSubscribed_nodeId
164−
165−instance HasNodeId (FanInt x a) where
166− getNodeId = _fanInt_nodeId
167−
168−instance HasNodeId (Hold x p) where
141+instance HasNodeId (Hold x p a) where
169142 getNodeId = holdNodeId
170143
144+instance HasNodeId (PushSubscribed x a b) where
145+ getNodeId = pushSubscribedNodeId
146+
171147instance HasNodeId (SwitchSubscribed x a) where
172148 getNodeId = switchSubscribedNodeId
173149
174−instance HasNodeId (FanSubscribed x v a) where
150+instance HasNodeId (FanSubscribed x a) where
175151 getNodeId = fanSubscribedNodeId
176152
177153instance HasNodeId (CoincidenceSubscribed x a) where
@@ -185,16 +161,41 @@ instance HasNodeId (Pull x a) where
185161
186162{-# INLINE showNodeId #-}
187163showNodeId :: HasNodeId a => a -> String
188−showNodeId = showNodeId' . getNodeId
189−
190−showNodeId' :: Int -> String
191−showNodeId' = ("#"<>) . show
192−
164+showNodeId = ("#"<>) . show . getNodeId
165+
166+showSubscriberType :: Subscriber x a -> String
167+showSubscriberType = \case
168+ SubscriberPush _ _ -> "SubscriberPush"
169+ SubscriberMerge _ _ -> "SubscriberMerge"
170+ SubscriberFan _ -> "SubscriberFan"
171+ SubscriberMergeChange _ -> "SubscriberMergeChange"
172+ SubscriberHold _ -> "SubscriberHold"
173+ SubscriberHoldIdentity _ -> "SubscriberHoldIdentity"
174+ SubscriberSwitch _ -> "SubscriberSwitch"
175+ SubscriberCoincidenceOuter _ -> "SubscriberCoincidenceOuter"
176+ SubscriberCoincidenceInner _ -> "SubscriberCoincidenceInner"
177+ SubscriberHandle -> "SubscriberHandle"
178+
179+showEventType :: Event x a -> String
180+showEventType = \case
181+ EventRoot _ _ -> "EventRoot"
182+ EventNever -> "EventNever"
183+ EventPush _ -> "EventPush"
184+ EventMerge _ -> "EventMerge"
185+ EventFan _ _ -> "EventFan"
186+ EventSwitch _ -> "EventSwitch"
187+ EventCoincidence _ -> "EventCoincidence"
188+ EventHold _ -> "EventHold"
189+ EventDyn _ -> "EventDyn"
190+ EventHoldIdentity _ -> "EventHoldIdentity"
191+ EventDynIdentity _ -> "EventDynIdentity"
193192
194193#else
195194
196195debugPropagate = False
196+
197197debugInvalidateHeight = False
198+
198199debugInvalidate = False
199200
200201-- This must be inline, or error messages will cause memory leaks due to retaining the node in question
@@ -202,10 +203,6 @@ debugInvalidate = False
202203showNodeId :: a -> String
203204showNodeId _ = ""
204205
205−{-# INLINE showNodeId' #-}
206−showNodeId' :: Int -> String
207−showNodeId' _ = ""
208−
209206#endif
210207
211208#ifdef DEBUG_NODEIDS
@@ -251,9 +248,9 @@ subscribeAndRead = unEvent
251248-- caching; if the computation function is very cheap, this is (much) more
252249-- efficient than 'push'
253250{-# INLINE [1] pushCheap #-}
254−pushCheap :: HasSpiderTimeline x => (a -> ComputeM x (Maybe b)) -> Event x a -> Event x b
251+pushCheap :: (a -> ComputeM x (Maybe b)) -> Event x a -> Event x b
255252pushCheap !f e = Event $ \sub -> do
256− (subscription, occ) <- subscribeAndRead e $ debugSubscriber' "push" $ sub
253+ (subscription, occ) <- subscribeAndRead e $ sub
257254 { subscriberPropagate = \a -> do
258255 mb <- f a
259256 mapM_ (subscriberPropagate sub) mb
@@ -272,10 +269,10 @@ terminalSubscriber p = Subscriber
272269
273270-- | Subscribe to an Event only for the duration of one occurrence
274271{-# INLINE subscribeAndReadHead #-}
275−subscribeAndReadHead :: HasSpiderTimeline x => Event x a -> Subscriber x a -> EventM x (EventSubscription x, Maybe a)
272+subscribeAndReadHead :: Event x a -> Subscriber x a -> EventM x (EventSubscription x, Maybe a)
276273subscribeAndReadHead e sub = do
277274 subscriptionRef <- liftIO $ newIORef $ error "subscribeAndReadHead: not initialized"
278− (subscription, occ) <- subscribeAndRead e $ debugSubscriber' "head" $ sub
275+ (subscription, occ) <- subscribeAndRead e $ sub
279276 { subscriberPropagate = \a -> do
280277 liftIO $ unsubscribe =<< readIORef subscriptionRef
281278 subscriberPropagate sub a
@@ -286,42 +283,24 @@ subscribeAndReadHead e sub = do
286283 return (subscription, occ)
287284
288285--TODO: Make this lazy in its input event
289−headE :: (MonadIO m, Defer (SomeMergeInit x) m, HasSpiderTimeline x) => Event x a -> m (Event x a)
286+headE :: (MonadIO m, Defer (SomeMergeInit x) m) => Event x a -> m (Event x a)
290287headE originalE = do
291288 parent <- liftIO $ newIORef $ Just originalE
292289 defer $ SomeMergeInit $ do --TODO: Rename SomeMergeInit appropriately
293290 let clearParent = liftIO $ writeIORef parent Nothing
294− (_, occ) <- subscribeAndReadHead originalE $ terminalSubscriber $ const clearParent
291+ (_, occ) <- subscribeAndReadHead originalE $ terminalSubscriber $ \_ -> clearParent
295292 when (isJust occ) clearParent
296− return $ Event $ \sub ->
293+ return $ Event $ \sub -> do
297294 liftIO (readIORef parent) >>= \case
298− Nothing -> subscribeAndReadNever
295+ Nothing -> return (EventSubscription (return ()) $ EventSubscribed zeroRef $ toAny (), Nothing)
299296 Just e -> subscribeAndReadHead e sub
300297
301298data CacheSubscribed x a
302299 = CacheSubscribed { _cacheSubscribed_subscribers :: {-# UNPACK #-} !(FastWeakBag (Subscriber x a))
303300 , _cacheSubscribed_parent :: {-# UNPACK #-} !(EventSubscription x)
304301 , _cacheSubscribed_occurrence :: {-# UNPACK #-} !(IORef (Maybe a))
305−#ifdef DEBUG_NODEIDS
306− , _cacheSubscribed_nodeId :: {-# UNPACK #-} !Int
307−#endif
308302 }
309303
310−nowSpiderEventM :: (HasSpiderTimeline x) => EventM x (R.Event (SpiderTimeline x) ())
311−nowSpiderEventM =
312− SpiderEvent <$> now
313−
314−now :: (MonadIO m, Defer (Some Clear) m, HasSpiderTimeline x
315− ) => m (Event x ())
316−now = do
317− nowOrNot <- liftIO $ newIORef $ Just ()
318− scheduleClear nowOrNot
319− return . Event $ \_ -> do
320− occ <- liftIO . readIORef $ nowOrNot
321− return ( EventSubscription (return ()) eventSubscribedNow
322− , occ
323− )
324−
325304-- | Construct an 'Event' whose value is guaranteed not to be recomputed
326305-- repeatedly
327306--
@@ -346,23 +325,18 @@ cacheEvent e =
346325 subscribedTicket <- liftIO (readIORef mSubscribedRef >>= getFastWeakTicket) >>= \case
347326 Just subscribedTicket -> return subscribedTicket
348327 Nothing -> do
349−#ifdef DEBUG_NODEIDS
350− nodeId <- liftIO newNodeId
351−#endif
352328 subscribers <- liftIO FastWeakBag.empty
353329 occRef <- liftIO $ newIORef Nothing -- This should never be read prior to being set below
354−#ifdef DEBUG_NODEIDS
355− (parentSub, occ) <- subscribeAndRead e $ debugSubscriber' ("cacheEvent" <> showNodeId' nodeId) $ Subscriber
356−#else
357330 (parentSub, occ) <- subscribeAndRead e $ Subscriber
358−#endif
359− { subscriberPropagate = \a -> do
360− liftIO $ writeIORef occRef (Just a)
361− scheduleClear occRef
362− propagateFast a subscribers
363− , subscriberInvalidateHeight = FastWeakBag.traverse_ subscribers . invalidateSubscriberHeight
364− , subscriberRecalculateHeight = FastWeakBag.traverse_ subscribers . recalculateSubscriberHeight
365− }
331+ { subscriberPropagate = \a -> do
332+ liftIO $ writeIORef occRef $ Just a
333+ scheduleClear occRef
334+ propagateFast a subscribers
335+ , subscriberInvalidateHeight = \old -> do
336+ FastWeakBag.traverse_ subscribers $ invalidateSubscriberHeight old
337+ , subscriberRecalculateHeight = \new -> do
338+ FastWeakBag.traverse_ subscribers $ recalculateSubscriberHeight new
339+ }
366340 when (isJust occ) $ do
367341 liftIO $ writeIORef occRef occ -- Set the initial value of occRef; we don't need to do this if occ is Nothing
368342 scheduleClear occRef
@@ -370,45 +344,29 @@ cacheEvent e =
370344 { _cacheSubscribed_subscribers = subscribers
371345 , _cacheSubscribed_parent = parentSub
372346 , _cacheSubscribed_occurrence = occRef
373−#ifdef DEBUG_NODEIDS
374− , _cacheSubscribed_nodeId = nodeId
375−#endif
376347 }
377348 subscribedTicket <- liftIO $ mkFastWeakTicket subscribed
378349 liftIO $ writeIORef mSubscribedRef =<< getFastWeakTicketWeak subscribedTicket
379350 return subscribedTicket
380− liftIO $ cacheSubscription sub mSubscribedRef subscribedTicket
381−
382−cacheSubscription :: Subscriber x a -> IORef (FastWeak (CacheSubscribed x a))
383− -> FastWeakTicket (CacheSubscribed x a) -> IO (EventSubscription x, Maybe a)
384−cacheSubscription sub mSubscribedRef subscribedTicket = do
385− subscribed <- getFastWeakTicketValue subscribedTicket
386− ticket <- FastWeakBag.insert sub $ _cacheSubscribed_subscribers subscribed
387− occ <- readIORef $ _cacheSubscribed_occurrence subscribed
388−
389− let parentSub = _cacheSubscribed_parent subscribed
390− es = EventSubscription
391− { _eventSubscription_unsubscribe = do
392− FastWeakBag.remove ticket
393−
394− isEmpty <- FastWeakBag.isEmpty $ _cacheSubscribed_subscribers subscribed
395− when isEmpty $ do
396− writeIORef mSubscribedRef emptyFastWeak
397− unsubscribe parentSub
398− touch ticket
399− touch subscribedTicket
400− , _eventSubscription_subscribed = EventSubscribed
401− { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed parentSub
402− , eventSubscribedRetained = toAny subscribedTicket
403−#ifdef DEBUG_CYCLES
404− , eventSubscribedGetParents = return [_eventSubscription_subscribed parentSub]
405− , eventSubscribedHasOwnHeightRef = False
406− , eventSubscribedWhoCreated = whoCreatedIORef mSubscribedRef
407−#endif
408− }
409− }
410− return (es, occ)
411−
351+ liftIO $ do
352+ subscribed <- getFastWeakTicketValue subscribedTicket
353+ ticket <- FastWeakBag.insert sub $ _cacheSubscribed_subscribers subscribed
354+ occ <- readIORef $ _cacheSubscribed_occurrence subscribed
355+ let es = EventSubscription
356+ { _eventSubscription_unsubscribe = do
357+ FastWeakBag.remove ticket
358+ isEmpty <- FastWeakBag.isEmpty $ _cacheSubscribed_subscribers subscribed
359+ when isEmpty $ do
360+ writeIORef mSubscribedRef emptyFastWeak
361+ unsubscribe $ _cacheSubscribed_parent subscribed
362+ touch ticket
363+ touch subscribedTicket
364+ , _eventSubscription_subscribed = EventSubscribed
365+ { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed $ _cacheSubscribed_parent subscribed
366+ , eventSubscribedRetained = toAny subscribedTicket
367+ }
368+ }
369+ return (es, occ)
412370
413371subscribe :: Event x a -> Subscriber x a -> EventM x (EventSubscription x)
414372subscribe e s = fst <$> subscribeAndRead e s
@@ -420,14 +378,11 @@ wrap tag getSpecificSubscribed sub = do
420378 let es = tag subd
421379 return (EventSubscription (WeakBag.remove sln >> touch sln) es, occ)
422380
423−eventRoot :: (GCompare k, HasSpiderTimeline x) => k a -> Root x k -> Event x a
381+eventRoot :: GCompare k => k a -> Root x k -> Event x a
424382eventRoot !k !r = Event $ wrap eventSubscribedRoot $ liftIO . getRootSubscribed k r
425383
426−subscribeAndReadNever :: EventM x (EventSubscription x, Maybe a)
427−subscribeAndReadNever = return (EventSubscription (return ()) eventSubscribedNever, Nothing)
428−
429384eventNever :: Event x a
430−eventNever = Event $ const subscribeAndReadNever
385+eventNever = Event $ \_ -> return (EventSubscription (return ()) eventSubscribedNever, Nothing)
431386
432387eventFan :: (GCompare k, HasSpiderTimeline x) => k a -> Fan x k v -> Event x (v a)
433388eventFan !k !f = Event $ wrap eventSubscribedFan $ getFanSubscribed k f
@@ -464,6 +419,16 @@ data Subscriber x a = Subscriber
464419 , subscriberRecalculateHeight :: !(Height -> IO ())
465420 }
466421
422+--TODO: Move this comment to WeakBag
423+-- These function are constructor functions that are marked NOINLINE so they are
424+-- opaque to GHC. If we do not do this, then GHC will sometimes fuse the constructor away
425+-- so any weak references that are attached to the constructors will have their
426+-- finalizer run. Using the opaque constructor, does not see the
427+-- constructor application, so it behaves like an IORef and cannot be fused away.
428+--
429+-- The result is also evaluated to WHNF, since forcing a thunk invalidates
430+-- the weak pointer to it in some cases.
431+
467432newSubscriberHold :: (HasSpiderTimeline x, Patch p) => Hold x p -> IO (Subscriber x p)
468433newSubscriberHold h = return $ Subscriber
469434 { subscriberPropagate = {-# SCC "traverseHold" #-} propagateSubscriberHold h
@@ -472,10 +437,10 @@ newSubscriberHold h = return $ Subscriber
472437 }
473438
474439newSubscriberFan :: forall x k v. (HasSpiderTimeline x, GCompare k) => FanSubscribed x k v -> IO (Subscriber x (DMap k v))
475−newSubscriberFan subscribed = debugSubscriber ("SubscriberFan " <> showNodeId subscribed) $ Subscriber
440+newSubscriberFan subscribed = return $ Subscriber
476441 { subscriberPropagate = \a -> {-# SCC "traverseFan" #-} do
477442 subs <- liftIO $ readIORef $ fanSubscribedSubscribers subscribed
478− tracePropagate (Proxy :: Proxy x) $ show (DMap.size subs) <> " keys subscribed, " <> show (DMap.size a) <> " keys firing"
443+ tracePropagate (Proxy :: Proxy x) $ "SubscriberFan" <> showNodeId subscribed <> ": " ++ show (DMap.size subs) ++ " keys subscribed, " ++ show (DMap.size a) ++ " keys firing"
479444 liftIO $ writeIORef (fanSubscribedOccurrence subscribed) $ Just a
480445 scheduleClear $ fanSubscribedOccurrence subscribed
481446 let f _ (Pair v subsubs) = do
@@ -484,40 +449,50 @@ newSubscriberFan subscribed = debugSubscriber ("SubscriberFan " <> showNodeId su
484449 _ <- DMap.traverseWithKey f $ DMap.intersectionWithKey (\_ -> Pair) a subs --TODO: Would be nice to have DMap.traverse_
485450 return ()
486451 , subscriberInvalidateHeight = \old -> do
452+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberFan" <> showNodeId subscribed
487453 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
488454 forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse_ (_fanSubscribedChildren_list v) $ invalidateSubscriberHeight old
455+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberFan" <> showNodeId subscribed <> " done"
489456 , subscriberRecalculateHeight = \new -> do
457+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberFan" <> showNodeId subscribed
490458 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
491459 forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse_ (_fanSubscribedChildren_list v) $ recalculateSubscriberHeight new
460+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberFan" <> showNodeId subscribed <> " done"
492461 }
493462
494463newSubscriberSwitch :: forall x a. HasSpiderTimeline x => SwitchSubscribed x a -> IO (Subscriber x a)
495−newSubscriberSwitch subscribed = debugSubscriber ("SubscriberCoincidenceOuter" <> showNodeId subscribed) $ Subscriber
464+newSubscriberSwitch subscribed = return $ Subscriber
496465 { subscriberPropagate = \a -> {-# SCC "traverseSwitch" #-} do
466+ tracePropagate (Proxy :: Proxy x) $ "SubscriberSwitch" <> showNodeId subscribed
497467 liftIO $ writeIORef (switchSubscribedOccurrence subscribed) $ Just a
498468 scheduleClear $ switchSubscribedOccurrence subscribed
499469 propagate a $ switchSubscribedSubscribers subscribed
500470 , subscriberInvalidateHeight = \_ -> do
471+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed
501472 oldHeight <- readIORef $ switchSubscribedHeight subscribed
502473 when (oldHeight /= invalidHeight) $ do
503474 writeIORef (switchSubscribedHeight subscribed) $! invalidHeight
504475 WeakBag.traverse_ (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
505− , subscriberRecalculateHeight = (`updateSwitchHeight` subscribed)
506− }
476+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed <> " done"
477+ , subscriberRecalculateHeight = \new -> do
478+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed
479+ updateSwitchHeight new subscribed
480+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed <> " done"
481+ }
507482
508483newSubscriberCoincidenceOuter :: forall x b. HasSpiderTimeline x => CoincidenceSubscribed x b -> IO (Subscriber x (Event x b))
509−newSubscriberCoincidenceOuter subscribed = debugSubscriber ("SubscriberCoincidenceOuter" <> showNodeId subscribed) $ Subscriber
484+newSubscriberCoincidenceOuter subscribed = return $ Subscriber
510485 { subscriberPropagate = \a -> {-# SCC "traverseCoincidenceOuter" #-} do
486+ tracePropagate (Proxy :: Proxy x) $ "SubscriberCoincidenceOuter" <> showNodeId subscribed
511487 outerHeight <- liftIO $ readIORef $ coincidenceSubscribedHeight subscribed
512488 tracePropagate (Proxy :: Proxy x) $ " outerHeight = " <> show outerHeight
513489 (occ, innerHeight, innerSubd) <- subscribeCoincidenceInner a outerHeight subscribed
514490 tracePropagate (Proxy :: Proxy x) $ " isJust occ = " <> show (isJust occ)
515491 tracePropagate (Proxy :: Proxy x) $ " innerHeight = " <> show innerHeight
516−
517492 liftIO $ writeIORef (coincidenceSubscribedInnerParent subscribed) $ Just innerSubd
518493 scheduleClear $ coincidenceSubscribedInnerParent subscribed
519494 case occ of
520− Nothing ->
495+ Nothing -> do
521496 when (innerHeight > outerHeight) $ liftIO $ do -- If the event fires, it will fire at a later height
522497 writeIORef (coincidenceSubscribedHeight subscribed) $! innerHeight
523498 WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight outerHeight
@@ -526,13 +501,20 @@ newSubscriberCoincidenceOuter subscribed = debugSubscriber ("SubscriberCoinciden
526501 liftIO $ writeIORef (coincidenceSubscribedOccurrence subscribed) occ
527502 scheduleClear $ coincidenceSubscribedOccurrence subscribed
528503 propagate o $ coincidenceSubscribedSubscribers subscribed
529− , subscriberInvalidateHeight = \_ -> invalidateCoincidenceHeight subscribed
530− , subscriberRecalculateHeight = \_ -> recalculateCoincidenceHeight subscribed
504+ , subscriberInvalidateHeight = \_ -> do
505+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed
506+ invalidateCoincidenceHeight subscribed
507+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed <> " done"
508+ , subscriberRecalculateHeight = \_ -> do
509+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed
510+ recalculateCoincidenceHeight subscribed
511+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed <> " done"
531512 }
532513
533514newSubscriberCoincidenceInner :: forall x a. HasSpiderTimeline x => CoincidenceSubscribed x a -> IO (Subscriber x a)
534−newSubscriberCoincidenceInner subscribed = debugSubscriber ("SubscriberCoincidenceInner" <> showNodeId subscribed) $ Subscriber
515+newSubscriberCoincidenceInner subscribed = return $ Subscriber
535516 { subscriberPropagate = \a -> {-# SCC "traverseCoincidenceInner" #-} do
517+ tracePropagate (Proxy :: Proxy x) $ "SubscriberCoincidenceInner" <> showNodeId subscribed
536518 occ <- liftIO $ readIORef $ coincidenceSubscribedOccurrence subscribed
537519 case occ of
538520 Just _ -> return () -- SubscriberCoincidenceOuter must have already propagated this event
@@ -540,8 +522,14 @@ newSubscriberCoincidenceInner subscribed = debugSubscriber ("SubscriberCoinciden
540522 liftIO $ writeIORef (coincidenceSubscribedOccurrence subscribed) $ Just a
541523 scheduleClear $ coincidenceSubscribedOccurrence subscribed
542524 propagate a $ coincidenceSubscribedSubscribers subscribed
543− , subscriberInvalidateHeight = \_ -> invalidateCoincidenceHeight subscribed
544− , subscriberRecalculateHeight = \_ -> recalculateCoincidenceHeight subscribed
525+ , subscriberInvalidateHeight = \_ -> do
526+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed
527+ invalidateCoincidenceHeight subscribed
528+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed <> " done"
529+ , subscriberRecalculateHeight = \_ -> do
530+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed
531+ recalculateCoincidenceHeight subscribed
532+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed <> " done"
545533 }
546534
547535invalidateSubscriberHeight :: Height -> Subscriber x a -> IO ()
@@ -551,15 +539,15 @@ recalculateSubscriberHeight :: Height -> Subscriber x a -> IO ()
551539recalculateSubscriberHeight = flip subscriberRecalculateHeight
552540
553541-- | Propagate everything at the current height
554−propagate :: forall x a. HasSpiderTimeline x => a -> WeakBag (Subscriber x a) -> EventM x ()
555−propagate a subscribers = withIncreasedDepth (Proxy::Proxy x) $
542+propagate :: a -> WeakBag (Subscriber x a) -> EventM x ()
543+propagate a subscribers = withIncreasedDepth $ do
556544 -- Note: in the following traversal, we do not visit nodes that are added to the list during our traversal; they are new events, which will necessarily have full information already, so there is no need to traverse them
557545 --TODO: Should we check if nodes already have their values before propagating? Maybe we're re-doing work
558546 WeakBag.traverse_ subscribers $ \s -> subscriberPropagate s a
559547
560548-- | Propagate everything at the current height
561−propagateFast :: forall x a. HasSpiderTimeline x => a -> FastWeakBag (Subscriber x a) -> EventM x ()
562−propagateFast a subscribers = withIncreasedDepth (Proxy::Proxy x) $
549+propagateFast :: a -> FastWeakBag (Subscriber x a) -> EventM x ()
550+propagateFast a subscribers = withIncreasedDepth $ do
563551 -- Note: in the following traversal, we do not visit nodes that are added to the list during our traversal; they are new events, which will necessarily have full information already, so there is no need to traverse them
564552 --TODO: Should we check if nodes already have their values before propagating? Maybe we're re-doing work
565553 FastWeakBag.traverse_ subscribers $ \s -> subscriberPropagate s a
@@ -580,7 +568,7 @@ data EventSubscribed x = EventSubscribed
580568 { eventSubscribedHeightRef :: {-# UNPACK #-} !(IORef Height)
581569 , eventSubscribedRetained :: {-# NOUNPACK #-} !Any
582570#ifdef DEBUG_CYCLES
583− , eventSubscribedGetParents :: !(IO [EventSubscribed x]) -- For debugging loops
571+ , eventSubscribedGetParents :: !(IO [Some (EventSubscribed x)]) -- For debugging loops
584572 , eventSubscribedHasOwnHeightRef :: !Bool
585573 , eventSubscribedWhoCreated :: !(IO [String])
586574#endif
@@ -607,23 +595,13 @@ eventSubscribedNever = EventSubscribed
607595 , eventSubscribedWhoCreated = return ["never"]
608596#endif
609597 }
610−eventSubscribedNow :: EventSubscribed x
611−eventSubscribedNow = EventSubscribed
612− { eventSubscribedHeightRef = zeroRef
613− , eventSubscribedRetained = toAny ()
614−#ifdef DEBUG_CYCLES
615− , eventSubscribedGetParents = return []
616− , eventSubscribedHasOwnHeightRef = False
617− , eventSubscribedWhoCreated = return ["now"]
618−#endif
619− }
620598
621599eventSubscribedFan :: FanSubscribed x k v -> EventSubscribed x
622600eventSubscribedFan !subscribed = EventSubscribed
623601 { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed $ fanSubscribedParent subscribed
624602 , eventSubscribedRetained = toAny subscribed
625603#ifdef DEBUG_CYCLES
626− , eventSubscribedGetParents = return [_eventSubscription_subscribed $ fanSubscribedParent subscribed]
604+ , eventSubscribedGetParents = return [Some $ _eventSubscription_subscribed $ fanSubscribedParent subscribed]
627605 , eventSubscribedHasOwnHeightRef = False
628606 , eventSubscribedWhoCreated = whoCreatedIORef $ fanSubscribedCachedSubscribed subscribed
629607#endif
@@ -636,7 +614,7 @@ eventSubscribedSwitch !subscribed = EventSubscribed
636614#ifdef DEBUG_CYCLES
637615 , eventSubscribedGetParents = do
638616 s <- readIORef $ switchSubscribedCurrentParent subscribed
639− return [_eventSubscription_subscribed s]
617+ return [Some $ _eventSubscription_subscribed s]
640618 , eventSubscribedHasOwnHeightRef = True
641619 , eventSubscribedWhoCreated = whoCreatedIORef $ switchSubscribedCachedSubscribed subscribed
642620#endif
@@ -649,8 +627,8 @@ eventSubscribedCoincidence !subscribed = EventSubscribed
649627#ifdef DEBUG_CYCLES
650628 , eventSubscribedGetParents = do
651629 innerSubscription <- readIORef $ coincidenceSubscribedInnerParent subscribed
652− let outerParent = _eventSubscription_subscribed $ coincidenceSubscribedOuterParent subscribed
653− innerParents = maybeToList $ innerSubscription
630+ let outerParent = Some $ _eventSubscription_subscribed $ coincidenceSubscribedOuterParent subscribed
631+ innerParents = maybeToList $ fmap Some innerSubscription
654632 return $ outerParent : innerParents
655633 , eventSubscribedHasOwnHeightRef = True
656634 , eventSubscribedWhoCreated = whoCreatedIORef $ coincidenceSubscribedCachedSubscribed subscribed
@@ -664,15 +642,15 @@ getEventSubscribedHeight es = readIORef $ eventSubscribedHeightRef es
664642whoCreatedEventSubscribed :: EventSubscribed x -> IO [String]
665643whoCreatedEventSubscribed = eventSubscribedWhoCreated
666644
667−walkInvalidHeightParents :: EventSubscribed x -> IO [EventSubscribed x]
645+walkInvalidHeightParents :: EventSubscribed x -> IO [Some (EventSubscribed x)]
668646walkInvalidHeightParents s0 = do
669− subscribers <- flip execStateT mempty $ ($ s0) $ fix $ \loop s -> do
647+ subscribers <- flip execStateT mempty $ ($ Some s0) $ fix $ \loop (Some s) -> do
670648 h <- liftIO $ readIORef $ eventSubscribedHeightRef s
671649 when (h == invalidHeight) $ do
672650 when (eventSubscribedHasOwnHeightRef s) $ liftIO $ writeIORef (eventSubscribedHeightRef s) $! invalidHeightBeingTraversed
673− modify (s :)
651+ modify (Some s :)
674652 mapM_ loop =<< liftIO (eventSubscribedGetParents s)
675− forM_ subscribers $ \s -> writeIORef (eventSubscribedHeightRef s) $! invalidHeight
653+ forM_ subscribers $ \(Some s) -> writeIORef (eventSubscribedHeightRef s) $! invalidHeight
676654 return subscribers
677655#endif
678656
@@ -994,10 +972,8 @@ instance Monad (BehaviorM x) where
994972 BehaviorM x >> BehaviorM y = BehaviorM $ x >> y
995973 {-# INLINE return #-}
996974 return x = BehaviorM $ return x
997−#if !MIN_VERSION_base(4,13,0)
998975 {-# INLINE fail #-}
999976 fail s = BehaviorM $ fail s
1000−#endif
1001977
1002978data BehaviorSubscribed x a
1003979 = forall p. BehaviorSubscribedHold (Hold x p)
@@ -1057,7 +1033,7 @@ data SomeMergeUpdate x = SomeMergeUpdate
10571033newtype SomeMergeInit x = SomeMergeInit { unSomeMergeInit :: EventM x () }
10581034
10591035-- EventM can do everything BehaviorM can, plus create holds
1060−newtype EventM x a = EventM { unEventM :: IO a } deriving (Functor, Applicative, Monad, MonadIO, MonadFix, MonadException, MonadAsyncException)
1036+newtype EventM x a = EventM { unEventM :: IO a } deriving (Functor, Applicative, Monad, MonadIO, MonadFix, MonadException, MonadAsyncException) -- The environment should be Nothing if we are not in a frame, and Just if we are - in which case it is a list of assignments to be done after the frame is over
10611037
10621038newtype MergeSubscribedParent x a = MergeSubscribedParent { unMergeSubscribedParent :: EventSubscription x }
10631039
@@ -1082,8 +1058,7 @@ heightBagFromList :: [Height] -> HeightBag
10821058heightBagFromList heights = heightBagVerify $ foldl' (flip heightBagAdd) heightBagEmpty heights
10831059
10841060heightBagAdd :: Height -> HeightBag -> HeightBag
1085−heightBagAdd (Height h) (HeightBag s c) = heightBagVerify $ HeightBag (succ s) $
1086− IntMap.insertWithKey (\_ _ old -> succ old) h 0 c
1061+heightBagAdd (Height h) (HeightBag s c) = heightBagVerify $ HeightBag (succ s) $ IntMap.insertWithKey (\_ _ old -> succ old) h 0 c
10871062
10881063heightBagRemove :: Height -> HeightBag -> HeightBag
10891064heightBagRemove (Height h) b@(HeightBag s c) = heightBagVerify $ case IntMap.lookup h c of
@@ -1092,13 +1067,6 @@ heightBagRemove (Height h) b@(HeightBag s c) = heightBagVerify $ case IntMap.loo
10921067 0 -> IntMap.delete h c
10931068 _ -> IntMap.insert h (pred old) c
10941069
1095−heightBagRemoveMaybe :: Height -> HeightBag -> Maybe HeightBag
1096−heightBagRemoveMaybe (Height h) b@(HeightBag s c) = heightBagVerify . removed <$> IntMap.lookup h c where
1097− removed old = HeightBag (pred s) $ case old of
1098− 0 -> IntMap.delete h c
1099− _ -> IntMap.insert h (pred old) c
1100−
1101−
11021070heightBagMax :: HeightBag -> Height
11031071heightBagMax (HeightBag _ c) = case IntMap.maxViewWithKey c of
11041072 Just ((h, _), _) -> Height h
@@ -1346,110 +1314,55 @@ mkWeakPtrWithDebug x debugNote = do
13461314 x' <- evaluate x
13471315 mkWeakPtr x' $
13481316 if debugFinalize
1349− then Just $ debugStrLn $ "finalizing: " ++ debugNote
1317+ then Just $ putStrLn $ "finalizing: " ++ debugNote
13501318 else Nothing
13511319
13521320type WeakList a = [Weak a]
13531321
1354−type CanTrace x m = (HasSpiderTimeline x, MonadIO m)
1355−
1356−
1357−
1358−
1359−#ifdef DEBUG
1360−
1361−debugSubscriber :: forall x a. HasSpiderTimeline x => String -> Subscriber x a -> IO (Subscriber x a)
1362−debugSubscriber description = return . debugSubscriber' description
1363−
1364−debugSubscriber' :: forall x a. HasSpiderTimeline x => String -> Subscriber x a -> Subscriber x a
1365−debugSubscriber' description subscribed = Subscriber
1366− {
1367− subscriberPropagate = \m -> do
1368− tracePropagate (Proxy :: Proxy x) ("subscriberPropagate: " <> description)
1369− subscriberPropagate subscribed m
1370− , subscriberInvalidateHeight = \old -> do
1371− traceInvalidateHeight $ "invalidateSubscriberHeight: " <> description <> ", old = " <> show (unHeight old)
1372− subscriberInvalidateHeight subscribed old
1373− traceInvalidateHeight $ "invalidateSubscriberHeight: " <> description <> ", done"
1374− , subscriberRecalculateHeight = \new -> do
1375− traceInvalidateHeight $ "subscriberRecalculateHeight: " <> description <> ", new = " <> show (unHeight new)
1376− subscriberRecalculateHeight subscribed new
1377− traceInvalidateHeight $ "subscriberRecalculateHeight: " <> description <> ", done"
1378− }
1379−
1380−
13811322{-# INLINE withIncreasedDepth #-}
1382−withIncreasedDepth :: forall proxy x m a. CanTrace x m => proxy x -> m a -> m a
1383−withIncreasedDepth _ a = do
1384− liftIO $ modifyIORef' (_spiderTimeline_depth $ unSTE (spiderTimeline :: SpiderTimelineEnv x)) succ
1323+#ifdef DEBUG
1324+withIncreasedDepth :: CanTrace x m => m a -> m a
1325+withIncreasedDepth a = do
1326+ spiderTimeline <- askSpiderTimelineEnv
1327+ liftIO $ modifyIORef' (_spiderTimeline_depth (unSTE spiderTimeline)) succ
13851328 result <- a
1386− liftIO $ modifyIORef' (_spiderTimeline_depth $ unSTE (spiderTimeline :: SpiderTimelineEnv x)) pred
1329+ liftIO $ modifyIORef' (_spiderTimeline_depth (unSTE spiderTimeline)) pred
13871330 return result
1388−
1389−{-# INLINE tracePropagate #-}
1390−tracePropagate :: (CanTrace x m) => proxy x -> String -> m ()
1391−tracePropagate p = when debugPropagate . trace p
1392−
1393−{-# INLINE traceInvalidate #-}
1394−traceInvalidate :: String -> IO ()
1395−traceInvalidate = when debugInvalidate . liftIO . debugStrLn
1396−
1397−{-# INLINE traceInvalidateHeight #-}
1398−traceInvalidateHeight :: String -> IO ()
1399−traceInvalidateHeight = when debugInvalidateHeight . liftIO . debugStrLn
1400−
1401−{-# INLINE trace #-}
1402−trace :: (CanTrace x m) => proxy x -> String -> m ()
1403−trace p message = traceM p $ return message
1404−
1405−{-# INLINE traceM #-}
1406−traceM :: forall x proxy m. (CanTrace x m) => proxy x -> m String -> m ()
1407−traceM _ getMessage = do
1408− message <- getMessage
1409− d <- liftIO $ readIORef $ _spiderTimeline_depth $ unSTE (spiderTimeline :: SpiderTimelineEnv x)
1410− liftIO $ debugStrLn $ replicate d ' ' <> message
1411−
14121331#else
1332+withIncreasedDepth :: m a -> m a
1333+withIncreasedDepth = id
1334+#endif
14131335
1414−{-# INLINE withIncreasedDepth #-}
1415−withIncreasedDepth :: proxy x -> m a -> m a
1416−withIncreasedDepth _ = id
1336+type CanTrace x m = (HasSpiderTimeline x, MonadIO m)
14171337
14181338{-# INLINE tracePropagate #-}
14191339tracePropagate :: (CanTrace x m) => proxy x -> String -> m ()
1420−tracePropagate _ _ = return ()
1340+tracePropagate p = traceWhen p debugPropagate
14211341
14221342{-# INLINE traceInvalidate #-}
14231343traceInvalidate :: String -> IO ()
1424−traceInvalidate _ = return ()
1425−
1426−{-# INLINE traceInvalidateHeight #-}
1427−traceInvalidateHeight :: String -> IO ()
1428−traceInvalidateHeight _ = return ()
1429−
1430−{-# INLINE debugSubscriber #-}
1431−debugSubscriber :: String -> Subscriber x a -> IO (Subscriber x a)
1432−debugSubscriber _ = return
1433−
1434−{-# INLINE debugSubscriber' #-}
1435−debugSubscriber' :: String -> Subscriber x a -> Subscriber x a
1436−debugSubscriber' _ = id
1437−
1438−
1344+traceInvalidate = when debugInvalidate . liftIO . putStrLn
14391345
1440−{-# INLINE trace #-}
1441−trace :: (CanTrace x m) => proxy x -> String -> m ()
1442−trace _ _ = return ()
1443−
1444−{-# INLINE traceM #-}
1445−traceM :: (CanTrace x m) => proxy x -> m String -> m ()
1446−traceM _ _ = return ()
1346+{-# INLINE traceWhen #-}
1347+traceWhen :: (CanTrace x m) => proxy x -> Bool -> String -> m ()
1348+traceWhen p b message = traceMWhen p b $ return message
14471349
1350+{-# INLINE traceMWhen #-}
1351+traceMWhen :: (CanTrace x m) => proxy x -> Bool -> m String -> m ()
1352+traceMWhen _ b getMessage = when b $ do
1353+ message <- getMessage
1354+#ifdef DEBUG
1355+ spiderTimeline <- askSpiderTimelineEnv
1356+ d <- liftIO $ readIORef $ _spiderTimeline_depth $ unSTE spiderTimeline
1357+#else
1358+ let d = 0
14481359#endif
1360+ liftIO $ putStrLn $ replicate d ' ' <> message
14491361
14501362whoCreatedIORef :: IORef a -> IO [String]
14511363whoCreatedIORef (IORef a) = whoCreated $! a
14521364
1365+#ifdef DEBUG_CYCLES
14531366groupByHead :: Eq a => [NonEmpty a] -> [(a, NonEmpty [a])]
14541367groupByHead = \case
14551368 [] -> []
@@ -1460,54 +1373,20 @@ groupByHead = \case
14601373 | otherwise -> (x, xs :| []) : l
14611374
14621375listsToForest :: Eq a => [[a]] -> Forest a
1463−listsToForest lists = buildForest <$> groupByHead (mapMaybe nonEmpty lists)
1464− where buildForest (a, lists') = Node a $ listsToForest $ toList lists'
1465−
1466−showStacks :: [[String]] -> String
1467−showStacks = drawForest . listsToForest . fmap (filterStack "Reflex.Spider.Internal")
1468−
1469−filterStack :: String -> [String] -> [String]
1470−#ifdef DEBUG_HIDE_INTERNALS
1471−filterStack prefix = filter (not . (prefix `isPrefixOf`))
1472−#else
1473−filterStack prefix = id
1474−#endif
1475−
1476−#ifdef DEBUG_CYCLES
1477−
1478−data EventLoopException = EventLoopException [[String]]
1479−instance Exception EventLoopException
1480−
1481−instance Show EventLoopException where
1482− show (EventLoopException stacks) = "causality loop detected:\n" <> if null stacks
1483− then "no location information, compile with profiling enabled for stack tree"
1484− else showStacks stacks
1485−
1486−#else
1487−
1488−data EventLoopException = EventLoopException
1489−instance Exception EventLoopException
1490−
1491−instance Show EventLoopException where
1492− show EventLoopException = "causality loop detected: \n" <>
1493− "compile reflex with flag 'debug-cycles' and compile with profiling enabled for stack tree"
1494−
1376+listsToForest l = fmap (\(a, l') -> Node a $ listsToForest $ toList l') $ groupByHead $ catMaybes $ fmap nonEmpty l
14951377#endif
14961378
1497−
14981379{-# INLINE propagateSubscriberHold #-}
14991380propagateSubscriberHold :: forall x p. (HasSpiderTimeline x, Patch p) => Hold x p -> p -> EventM x ()
15001381propagateSubscriberHold h a = do
1501− {-# SCC "trace" #-} when debugPropagate $ traceM (Proxy :: Proxy x) $ liftIO $ do
1382+ {-# SCC "trace" #-} traceMWhen (Proxy :: Proxy x) debugPropagate $ liftIO $ do
15021383 invalidators <- liftIO $ readIORef $ holdInvalidators h
15031384 return $ "SubscriberHold" <> showNodeId h <> ": " ++ show (length invalidators)
1504−
15051385 v <- {-# SCC "read" #-} liftIO $ readIORef $ holdValue h
15061386 case {-# SCC "apply" #-} apply a v of
15071387 Nothing -> return ()
15081388 Just v' -> do
1509− {-# SCC "trace2" #-} withIncreasedDepth (Proxy :: Proxy x) $
1510− tracePropagate (Proxy :: Proxy x) ("propagateSubscriberHold: assigning Hold" <> showNodeId h)
1389+ {-# SCC "trace2" #-} withIncreasedDepth $ tracePropagate (Proxy :: Proxy x) $ "propagateSubscriberHold: assigning Hold" <> showNodeId h
15111390 vRef <- {-# SCC "vRef" #-} liftIO $ evaluate $ holdValue h
15121391 iRef <- {-# SCC "iRef" #-} liftIO $ evaluate $ holdInvalidators h
15131392 defer $ {-# SCC "assignment" #-} SomeAssignment vRef iRef v'
@@ -1561,7 +1440,7 @@ getDynHold d = do
15611440zeroRef :: IORef Height
15621441zeroRef = unsafePerformIO $ newIORef zeroHeight
15631442
1564−getRootSubscribed :: forall k x a. (GCompare k, HasSpiderTimeline x) => k a -> Root x k -> Subscriber x a -> IO (WeakBagTicket, RootSubscribed x a, Maybe a)
1443+getRootSubscribed :: GCompare k => k a -> Root x k -> Subscriber x a -> IO (WeakBagTicket, RootSubscribed x a, Maybe a)
15651444getRootSubscribed k r sub = do
15661445 mSubscribed <- readIORef $ rootSubscribed r
15671446 let getOcc = fmap (coerce . DMap.lookup k) $ readIORef $ rootOccurrence r
@@ -1575,9 +1454,7 @@ getRootSubscribed k r sub = do
15751454 let !cached = rootSubscribed r
15761455 uninitRef <- newIORef $ error "getRootsubscribed: uninitRef not initialized"
15771456 (subs, sln) <- WeakBag.singleton sub weakSelf cleanupRootSubscribed
1578−
1579− tracePropagate (Proxy::Proxy x) $ "getRootSubscribed: calling rootInit"
1580−
1457+ when debugPropagate $ putStrLn $ "getRootSubscribed: calling rootInit"
15811458 uninit <- rootInit r k $ RootTrigger (subs, rootOccurrence r, k)
15821459 writeIORef uninitRef $! uninit
15831460#ifdef DEBUG_NODEIDS
@@ -1627,9 +1504,6 @@ data FanInt x a = FanInt
16271504 { _fanInt_subscribers :: {-# UNPACK #-} !(FastMutableIntMap (FastWeakBag (Subscriber x a))) --TODO: Clean up the keys in here when their child weak bags get empty --TODO: Remove our own subscription when the subscribers list is completely empty
16281505 , _fanInt_subscriptionRef :: {-# UNPACK #-} !(IORef (EventSubscription x)) -- This should have a valid subscription iff subscribers is non-empty
16291506 , _fanInt_occRef :: {-# UNPACK #-} !(IORef (IntMap a))
1630−#ifdef DEBUG_NODEIDS
1631− , _fanInt_nodeId :: {-# UNPACK #-} !Int
1632−#endif
16331507 }
16341508
16351509newFanInt :: IO (FanInt x a)
@@ -1637,16 +1511,10 @@ newFanInt = do
16371511 subscribers <- FastMutableIntMap.newEmpty --TODO: Clean up the keys in here when their child weak bags get empty --TODO: Remove our own subscription when the subscribers list is completely empty
16381512 subscriptionRef <- newIORef $ error "fanInt: no subscription"
16391513 occRef <- newIORef $ error "fanInt: no occurrence"
1640−#ifdef DEBUG_NODEIDS
1641− nodeId <- newNodeId
1642−#endif
16431514 return $ FanInt
16441515 { _fanInt_subscribers = subscribers
16451516 , _fanInt_subscriptionRef = subscriptionRef
16461517 , _fanInt_occRef = occRef
1647−#ifdef DEBUG_NODEIDS
1648− , _fanInt_nodeId = nodeId
1649−#endif
16501518 }
16511519
16521520fanInt :: HasSpiderTimeline x => Event x (IntMap a) -> EventSelectorInt x a
@@ -1655,21 +1523,20 @@ fanInt p = unsafePerformIO $ do
16551523 pure $ EventSelectorInt $ \k -> Event $ \sub -> do
16561524 isEmpty <- liftIO $ FastMutableIntMap.isEmpty (_fanInt_subscribers self)
16571525 when isEmpty $ do -- This is the first subscriber, so we need to subscribe to our input
1658− let desc = "fanInt" <> showNodeId self <> ", k = " <> show k
1659− (subscription, parentOcc) <- subscribeAndRead p $ debugSubscriber' desc $ Subscriber
1526+ (subscription, parentOcc) <- subscribeAndRead p $ Subscriber
16601527 { subscriberPropagate = \m -> do
16611528 liftIO $ writeIORef (_fanInt_occRef self) m
16621529 scheduleIntClear $ _fanInt_occRef self
1663− FastMutableIntMap.forIntersectionWithImmutable_ (_fanInt_subscribers self) m $ \b v -> --TODO: Do we need to know that no subscribers are being added as we traverse?
1664− FastWeakBag.traverse_ b $ \s ->
1530+ FastMutableIntMap.forIntersectionWithImmutable_ (_fanInt_subscribers self) m $ \b v -> do --TODO: Do we need to know that no subscribers are being added as we traverse?
1531+ FastWeakBag.traverse_ b $ \s -> do
16651532 subscriberPropagate s v
1666− , subscriberInvalidateHeight = \old ->
1667− FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b ->
1668− FastWeakBag.traverse_ b $ \s ->
1533+ , subscriberInvalidateHeight = \old -> do
1534+ FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b -> do
1535+ FastWeakBag.traverse_ b $ \s -> do
16691536 subscriberInvalidateHeight s old
1670− , subscriberRecalculateHeight = \new ->
1671− FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b ->
1672− FastWeakBag.traverse_ b $ \s ->
1537+ , subscriberRecalculateHeight = \new -> do
1538+ FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b -> do
1539+ FastWeakBag.traverse_ b $ \s -> do
16731540 subscriberRecalculateHeight s new
16741541 }
16751542 liftIO $ do
@@ -1683,25 +1550,10 @@ fanInt p = unsafePerformIO $ do
16831550 FastMutableIntMap.insert (_fanInt_subscribers self) k b
16841551 return b
16851552 Just b -> return b
1686− ticket <- liftIO $ FastWeakBag.insert sub b
1553+ t <- liftIO $ FastWeakBag.insert sub b
16871554 currentOcc <- readIORef (_fanInt_occRef self)
1688−
1689− subscribed <- fanIntSubscribed ticket self
1690− return (EventSubscription (FastWeakBag.remove ticket) subscribed, IntMap.lookup k currentOcc)
1691−
1692−fanIntSubscribed :: FastWeakBagTicket k -> FanInt x a -> IO (EventSubscribed x)
1693−fanIntSubscribed ticket self = do
1694− subscribedParent <- _eventSubscription_subscribed <$> readIORef (_fanInt_subscriptionRef self)
1695− return $ EventSubscribed
1696− { eventSubscribedHeightRef = eventSubscribedHeightRef subscribedParent
1697− , eventSubscribedRetained = toAny (_fanInt_subscriptionRef self, ticket)
1698−#ifdef DEBUG_CYCLES
1699− , eventSubscribedGetParents = return [subscribedParent]
1700− , eventSubscribedHasOwnHeightRef = False
1701− , eventSubscribedWhoCreated = whoCreatedIORef $ _fanInt_subscriptionRef self
1702−#endif
1703− }
1704−
1555+ (EventSubscription _ (EventSubscribed !heightRef _)) <- readIORef (_fanInt_subscriptionRef self)
1556+ return (EventSubscription (FastWeakBag.remove t) $! EventSubscribed heightRef $! toAny (_fanInt_subscriptionRef self, t), IntMap.lookup k currentOcc)
17051557
17061558{-# INLINABLE getFanSubscribed #-}
17071559getFanSubscribed :: (HasSpiderTimeline x, GCompare k) => k a -> Fan x k v -> Subscriber x (v a) -> EventM x (WeakBagTicket, FanSubscribed x k v, Maybe (v a))
@@ -1899,7 +1751,7 @@ mergeCheap
18991751 => (forall a. q a -> Event x (v a))
19001752 -> DynamicS x (PatchDMap k q)
19011753 -> Event x (DMap k v)
1902−mergeCheap nt = mergeGCheap' unMergeSubscribedParent getInitialSubscribers updateMe destroy
1754+mergeCheap nt = mergeGCheap' getInitialSubscribers updateMe destroy
19031755 where
19041756 updateMe :: MergeUpdateFunc k v x (PatchDMap k q) (MergeSubscribedParent x)
19051757 updateMe subscriber heightBagRef oldParents (PatchDMap p) = do
@@ -1914,9 +1766,7 @@ mergeCheap nt = mergeGCheap' unMergeSubscribedParent getInitialSubscribers updat
19141766 liftIO $ modifyIORef' heightBagRef $ heightBagAdd newParentHeight
19151767 return $ DMap.insertLookupWithKey' (\_ new _ -> new) k newParent ps
19161768 forM_ mOldSubd $ \oldSubd -> do
1917− oldHeight <- liftIO $ getEventSubscribedHeight $
1918− _eventSubscription_subscribed $ unMergeSubscribedParent oldSubd
1919−
1769+ oldHeight <- liftIO $ getEventSubscribedHeight $ _eventSubscription_subscribed $ unMergeSubscribedParent oldSubd
19201770 liftIO $ modifyIORef heightBagRef $ heightBagRemove oldHeight
19211771 return (maybeToList (unMergeSubscribedParent <$> mOldSubd) ++ subscriptionsToKill, newPs)
19221772 foldM f ([], oldParents) $ DMap.toList p
@@ -1941,7 +1791,7 @@ mergeCheapWithMove :: forall k x v q. (HasSpiderTimeline x, GCompare k)
19411791 => (forall a. q a -> Event x (v a))
19421792 -> DynamicS x (PatchDMapWithMove k q)
19431793 -> Event x (DMap k v)
1944−mergeCheapWithMove nt = mergeGCheap' _mergeSubscribedParentWithMove_subscription getInitialSubscribers updateMe destroy
1794+mergeCheapWithMove nt = mergeGCheap' getInitialSubscribers updateMe destroy
19451795 where
19461796 updateMe :: MergeUpdateFunc k v x (PatchDMapWithMove k q) (MergeSubscribedParentWithMove x k)
19471797 updateMe subscriber heightBagRef oldParents p = do
@@ -1960,17 +1810,13 @@ mergeCheapWithMove nt = mergeGCheap' _mergeSubscribedParentWithMove_subscription
19601810 let moveOrDelete :: forall a. k a -> PatchDMapWithMove.NodeInfo k q a -> MergeSubscribedParentWithMove x k a -> Constant (EventM x (Maybe (EventSubscription x))) a
19611811 moveOrDelete _ ni parent = Constant $ case getComposeMaybe $ PatchDMapWithMove._nodeInfo_to ni of
19621812 Nothing -> do
1963− oldHeight <- liftIO $ getEventSubscribedHeight $ _eventSubscription_subscribed $
1964− _mergeSubscribedParentWithMove_subscription parent
1965−
1813+ oldHeight <- liftIO $ getEventSubscribedHeight $ _eventSubscription_subscribed $ _mergeSubscribedParentWithMove_subscription parent
19661814 liftIO $ modifyIORef heightBagRef $ heightBagRemove oldHeight
19671815 return $ Just $ _mergeSubscribedParentWithMove_subscription parent
19681816 Just toKey -> do
19691817 liftIO $ writeIORef (_mergeSubscribedParentWithMove_key parent) $! toKey
19701818 return Nothing
1971− toDelete <- fmap catMaybes $ mapM (\(_ :=> v) -> getConstant v) $ DMap.toList $
1972− DMap.intersectionWithKey moveOrDelete (unPatchDMapWithMove p) oldParents
1973−
1819+ toDelete <- fmap catMaybes $ mapM (\(_ :=> v) -> getConstant v) $ DMap.toList $ DMap.intersectionWithKey moveOrDelete (unPatchDMapWithMove p) oldParents
19741820 return (toDelete, applyAlways p' oldParents)
19751821 getInitialSubscribers :: MergeInitFunc k v q x (MergeSubscribedParentWithMove x k)
19761822 getInitialSubscribers initialParents subscriber = do
@@ -1995,8 +1841,6 @@ type MergeUpdateFunc k v x p s
19951841 -> p
19961842 -> EventM x ([EventSubscription x], DMap k s)
19971843
1998−type MergeGetSubscription x s = forall a. s a -> EventSubscription x
1999−
20001844type MergeInitFunc k v q x s
20011845 = DMap k q
20021846 -> (forall a. EventM x (k a) -> Subscriber x (v a))
@@ -2020,17 +1864,14 @@ invalidateMergeHeight m = invalidateMergeHeight' (_merge_heightRef m) (_merge_su
20201864invalidateMergeHeight' :: IORef Height -> Subscriber x a -> IO ()
20211865invalidateMergeHeight' heightRef sub = do
20221866 oldHeight <- readIORef heightRef
2023− -- If the height used to be valid, it must be invalid now; we should never have *more* heights than we have parents
2024− when (oldHeight /= invalidHeight) $ do
1867+ when (oldHeight /= invalidHeight) $ do -- If the height used to be valid, it must be invalid now; we should never have *more* heights than we have parents
20251868 writeIORef heightRef $! invalidHeight
20261869 subscriberInvalidateHeight sub oldHeight
20271870
20281871revalidateMergeHeight :: Merge x k v s -> IO ()
20291872revalidateMergeHeight m = do
20301873 currentHeight <- readIORef $ _merge_heightRef m
2031−
2032− -- revalidateMergeHeight may be called multiple times; perhaps the's a way to finesse it to avoid this check
2033− when (currentHeight == invalidHeight) $ do
1874+ when (currentHeight == invalidHeight) $ do -- revalidateMergeHeight may be called multiple times; perhaps the's a way to finesse it to avoid this check
20341875 heights <- readIORef $ _merge_heightBagRef m
20351876 parents <- readIORef $ _merge_parentsRef m
20361877 -- When the number of heights in the bag reaches the number of parents, we should have a valid height
@@ -2038,7 +1879,7 @@ revalidateMergeHeight m = do
20381879 LT -> return ()
20391880 EQ -> do
20401881 let height = succHeight $ heightBagMax heights
2041− traceInvalidateHeight $ "recalculateSubscriberHeight: height: " <> show height
1882+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: height: " <> show height
20421883 writeIORef (_merge_heightRef m) $! height
20431884 subscriberRecalculateHeight (_merge_sub m) height
20441885 GT -> error $ "revalidateMergeHeight: more heights (" <> show (heightBagSize heights) <> ") than parents (" <> show (DMap.size parents) <> ") for Merge"
@@ -2046,45 +1887,36 @@ revalidateMergeHeight m = do
20461887scheduleMergeSelf :: HasSpiderTimeline x => Merge x k v s -> Height -> EventM x ()
20471888scheduleMergeSelf m height = scheduleMerge' height (_merge_heightRef m) $ do
20481889 vals <- liftIO $ readIORef $ _merge_accumRef m
2049− -- Once we're done with this, we can clear it immediately, because if there's a cacheEvent in front of us,
2050− -- it'll handle subsequent subscribers, and if not, we won't get subsequent subscribers
2051− liftIO $ writeIORef (_merge_accumRef m) $! DMap.empty
1890+ liftIO $ writeIORef (_merge_accumRef m) $! DMap.empty -- Once we're done with this, we can clear it immediately, because if there's a cacheEvent in front of us, it'll handle subsequent subscribers, and if not, we won't get subsequent subscribers
20521891 --TODO: Assert that m is not empty
20531892 subscriberPropagate (_merge_sub m) vals
20541893
2055−checkCycle :: HasSpiderTimeline x => EventSubscribed x -> EventM x ()
2056−checkCycle subscribed = liftIO $ do
2057− height <- readIORef (eventSubscribedHeightRef subscribed)
2058−
2059− -- currentHeight <- getCurrentHeight
2060− -- when (height <= currentHeight) $ if height /= invalidHeight
2061− -- then do
2062− -- myStack <- liftIO $ whoCreatedIORef undefined --TODO
2063− -- error $ "Height (" ++ show height ++ ") is not greater than current height (" ++ show currentHeight ++ ")\n" ++ unlines (reverse myStack)
2064− -- else liftIO $
2065− when (height == invalidHeight) $
2066−#ifdef DEBUG_CYCLES
2067− do
2068− nodesInvolvedInCycle <- walkInvalidHeightParents subscribed
2069− stacks <- forM nodesInvolvedInCycle whoCreatedEventSubscribed
2070− throwIO (EventLoopException stacks)
2071−#else
2072− throwIO EventLoopException
2073−#endif
2074−
2075−
2076−mergeSubscriber :: forall x k v s a. (HasSpiderTimeline x, GCompare k) => EventSubscribed x -> Merge x k v s -> EventM x (k a) -> Subscriber x (v a)
2077−mergeSubscriber subscribed m getKey = Subscriber
1894+mergeSubscriber :: forall x k v s a. (HasSpiderTimeline x, GCompare k) => Merge x k v s -> EventM x (k a) -> Subscriber x (v a)
1895+mergeSubscriber m getKey = Subscriber
20781896 { subscriberPropagate = \a -> do
20791897 oldM <- liftIO $ readIORef $ _merge_accumRef m
20801898 k <- getKey
2081− let newM = DMap.insertWith (error "Same key fired multiple times for Merge") k a oldM
1899+ let newM = DMap.insertWith (error $ "Same key fired multiple times for Merge") k a oldM
20821900 tracePropagate (Proxy :: Proxy x) $ " DMap.size oldM = " <> show (DMap.size oldM) <> "; DMap.size newM = " <> show (DMap.size newM)
20831901 liftIO $ writeIORef (_merge_accumRef m) $! newM
20841902 when (DMap.null oldM) $ do -- Only schedule the firing once
20851903 height <- liftIO $ readIORef $ _merge_heightRef m
2086− checkCycle subscribed
2087−
1904+ --TODO: assertions about height
1905+ currentHeight <- getCurrentHeight
1906+ when (height <= currentHeight) $ do
1907+ if height /= invalidHeight
1908+ then do
1909+ myStack <- liftIO $ whoCreatedIORef undefined --TODO
1910+ error $ "Height (" ++ show height ++ ") is not greater than current height (" ++ show currentHeight ++ ")\n" ++ unlines (reverse myStack)
1911+ else liftIO $ do
1912+#ifdef DEBUG_CYCLES
1913+ nodesInvolvedInCycle <- walkInvalidHeightParents $ eventSubscribedMerge subscribed
1914+ stacks <- forM nodesInvolvedInCycle $ \(Some es) -> whoCreatedEventSubscribed es
1915+ let cycleInfo = ":\n" <> drawForest (listsToForest stacks)
1916+#else
1917+ let cycleInfo = ""
1918+#endif
1919+ error $ "Causality loop found" <> cycleInfo
20881920 scheduleMergeSelf m height
20891921 , subscriberInvalidateHeight = \old -> do --TODO: When removing a parent doesn't actually change the height, maybe we can avoid invalidating
20901922 modifyIORef' (_merge_heightBagRef m) $ heightBagRemove old
@@ -2095,45 +1927,31 @@ mergeSubscriber subscribed m getKey = Subscriber
20951927 }
20961928
20971929--TODO: Be able to run as much of this as possible promptly
2098−updateMerge :: (HasSpiderTimeline x, GCompare k) => EventSubscribed x -> Merge x k v s -> MergeUpdateFunc k v x p s -> p -> SomeMergeUpdate x
2099−updateMerge subscribed m updateFunc p = SomeMergeUpdate updateMe (invalidateMergeHeight m) (revalidateMergeHeight m)
1930+updateMerge :: (HasSpiderTimeline x, GCompare k) => Merge x k v s -> MergeUpdateFunc k v x p s -> p -> SomeMergeUpdate x
1931+updateMerge m updateFunc p = SomeMergeUpdate updateMe (invalidateMergeHeight m) (revalidateMergeHeight m)
21001932 where updateMe = do
21011933 oldParents <- liftIO $ readIORef $ _merge_parentsRef m
2102− (subscriptionsToKill, newParents) <- updateFunc (mergeSubscriber subscribed m) (_merge_heightBagRef m) oldParents p
1934+ (subscriptionsToKill, newParents) <- updateFunc (mergeSubscriber m) (_merge_heightBagRef m) oldParents p
21031935 liftIO $ writeIORef (_merge_parentsRef m) $! newParents
21041936 return subscriptionsToKill
21051937
21061938{-# INLINE mergeGCheap' #-}
21071939mergeGCheap' :: forall k v x p s q. (HasSpiderTimeline x, GCompare k, PatchTarget p ~ DMap k q)
2108− => MergeGetSubscription x s -> MergeInitFunc k v q x s -> MergeUpdateFunc k v x p s -> MergeDestroyFunc k s -> DynamicS x p -> Event x (DMap k v)
2109−mergeGCheap' getParent getInitialSubscribers updateFunc destroy d = Event $ \sub -> do
1940+ => MergeInitFunc k v q x s -> MergeUpdateFunc k v x p s -> MergeDestroyFunc k s -> DynamicS x p -> Event x (DMap k v)
1941+mergeGCheap' getInitialSubscribers updateFunc destroy d = Event $ \sub -> do
21101942 initialParents <- readBehaviorUntracked $ dynamicCurrent d
21111943 accumRef <- liftIO $ newIORef $ error "merge: accumRef not yet initialized"
21121944 heightRef <- liftIO $ newIORef $ error "merge: heightRef not yet initialized"
21131945 heightBagRef <- liftIO $ newIORef $ error "merge: heightBagRef not yet initialized"
21141946 parentsRef :: IORef (DMap k s) <- liftIO $ newIORef $ error "merge: parentsRef not yet initialized"
2115− changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
2116−
2117− let subscribed = EventSubscribed
2118− { eventSubscribedHeightRef = heightRef
2119− , eventSubscribedRetained = toAny (parentsRef, changeSubdRef)
2120−#ifdef DEBUG_CYCLES
2121− , eventSubscribedGetParents = do
2122− let getParent' (_ :=> v) = _eventSubscription_subscribed (getParent v)
2123− fmap getParent' . DMap.toList <$> readIORef parentsRef
2124− , eventSubscribedHasOwnHeightRef = False
2125− , eventSubscribedWhoCreated = whoCreatedIORef heightRef
2126−#endif
2127− }
2128−
2129− m = Merge
1947+ let m = Merge
21301948 { _merge_parentsRef = parentsRef
21311949 , _merge_heightBagRef = heightBagRef
21321950 , _merge_heightRef = heightRef
21331951 , _merge_sub = sub
21341952 , _merge_accumRef = accumRef
21351953 }
2136− (dm, heights, initialParentState) <- getInitialSubscribers initialParents $ mergeSubscriber subscribed m
1954+ (dm, heights, initialParentState) <- getInitialSubscribers initialParents $ mergeSubscriber m
21371955 let myHeightBag = heightBagFromList $ filter (/= invalidHeight) heights
21381956 myHeight = if invalidHeight `elem` heights
21391957 then invalidHeight
@@ -2142,29 +1960,31 @@ mergeGCheap' getParent getInitialSubscribers updateFunc destroy d = Event $ \sub
21421960 let (occ, accum) = if currentHeight >= myHeight -- If we should have fired by now
21431961 then (if DMap.null dm then Nothing else Just dm, DMap.empty)
21441962 else (Nothing, dm)
2145− unless (DMap.null accum) $ scheduleMergeSelf m myHeight
1963+ unless (DMap.null accum) $ do
1964+ scheduleMergeSelf m myHeight
21461965 liftIO $ writeIORef accumRef $! accum
21471966 liftIO $ writeIORef heightRef $! myHeight
21481967 liftIO $ writeIORef heightBagRef $! myHeightBag
1968+ changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
21491969 liftIO $ writeIORef parentsRef $! initialParentState
21501970 defer $ SomeMergeInit $ do
2151− let changeSubscriber = Subscriber
1971+ let s = Subscriber
21521972 { subscriberPropagate = \a -> {-# SCC "traverseMergeChange" #-} do
2153− tracePropagate (Proxy :: Proxy x) "SubscriberMerge/Change"
2154− defer $ updateMerge subscribed m updateFunc a
1973+ tracePropagate (Proxy :: Proxy x) $ "SubscriberMerge/Change"
1974+ defer $ updateMerge m updateFunc a
21551975 , subscriberInvalidateHeight = \_ -> return ()
21561976 , subscriberRecalculateHeight = \_ -> return ()
21571977 }
2158− (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) changeSubscriber
2159− forM_ change $ \c -> defer $ updateMerge subscribed m updateFunc c
1978+ (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) s
1979+ forM_ change $ \c -> defer $ updateMerge m updateFunc c
21601980 -- We explicitly hold on to the unsubscribe function from subscribing to the update event.
21611981 -- If we don't do this, there are certain cases where mergeCheap will fail to properly retain
21621982 -- its subscription.
2163− liftIO $ writeIORef changeSubdRef (changeSubscriber, changeSubscription)
1983+ liftIO $ writeIORef changeSubdRef (s, changeSubscription)
21641984 let unsubscribeAll = destroy =<< readIORef parentsRef
2165−
2166− return (EventSubscription unsubscribeAll subscribed, occ)
2167−
1985+ return ( EventSubscription unsubscribeAll $ EventSubscribed heightRef $ toAny (parentsRef, changeSubdRef)
1986+ , occ
1987+ )
21681988
21691989mergeInt :: forall x a. (HasSpiderTimeline x) => DynamicS x (PatchIntMap (Event x a)) -> Event x (IntMap a)
21701990mergeInt = cacheEvent . mergeIntCheap
@@ -2177,22 +1997,13 @@ mergeIntCheap d = Event $ \sub -> do
21771997 heightRef <- liftIO $ newIORef zeroHeight
21781998 heightBagRef <- liftIO $ newIORef heightBagEmpty
21791999 parents <- liftIO $ FastMutableIntMap.newEmpty
2180− changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
2181− let subscribed = EventSubscribed
2182− { eventSubscribedHeightRef = heightRef
2183− , eventSubscribedRetained = toAny (parents, changeSubdRef)
2184−#ifdef DEBUG_CYCLES
2185− , eventSubscribedGetParents = fmap (_eventSubscription_subscribed . snd) <$> FastMutableIntMap.toList parents
2186− , eventSubscribedHasOwnHeightRef = False
2187− , eventSubscribedWhoCreated = whoCreatedIORef heightRef
2188−#endif
2189− }
21902000 let scheduleSelf = do
21912001 height <- liftIO $ readIORef $ heightRef
21922002 scheduleMerge' height heightRef $ do
21932003 vals <- liftIO $ FastMutableIntMap.getFrozenAndClear accum
21942004 subscriberPropagate sub vals
2195− invalidateMyHeight = invalidateMergeHeight' heightRef sub
2005+ invalidateMyHeight = do
2006+ invalidateMergeHeight' heightRef sub
21962007 recalculateMyHeight = do
21972008 currentHeight <- readIORef heightRef
21982009 when (currentHeight == invalidHeight) $ do --TODO: This will almost always be true; can we get rid of this check and just proceed to the next one always?
@@ -2202,14 +2013,12 @@ mergeIntCheap d = Event $ \sub -> do
22022013 LT -> return ()
22032014 EQ -> do
22042015 let height = succHeight $ heightBagMax heights
2205− traceInvalidateHeight $ "recalculateSubscriberHeight: height: " <> show height
2016+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: height: " <> show height
22062017 writeIORef heightRef $! height
22072018 subscriberRecalculateHeight sub height
22082019 GT -> error $ "revalidateMergeHeight: more heights (" <> show (heightBagSize heights) <> ") than parents (" <> show numParents <> ") for Merge"
22092020 mySubscriber k = Subscriber
22102021 { subscriberPropagate = \a -> do
2211− checkCycle subscribed
2212−
22132022 wasEmpty <- liftIO $ FastMutableIntMap.isEmpty accum
22142023 liftIO $ FastMutableIntMap.insert accum k a
22152024 when wasEmpty scheduleSelf
@@ -2243,6 +2052,7 @@ mergeIntCheap d = Event $ \sub -> do
22432052 else liftIO $ Just <$> FastMutableIntMap.getFrozenAndClear accum
22442053 else do when (not isEmpty) scheduleSelf -- We have things accumulated, but we shouldn't have fired them yet
22452054 return Nothing
2055+ changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
22462056 defer $ SomeMergeInit $ do
22472057 let updateMe a = SomeMergeUpdate u invalidateMyHeight recalculateMyHeight
22482058 where
@@ -2256,27 +2066,25 @@ mergeIntCheap d = Event $ \sub -> do
22562066 oldParents <- liftIO $ FastMutableIntMap.applyPatch parents newSubscriptions
22572067 liftIO $ for_ oldParents $ \oldParent -> do
22582068 oldParentHeight <- getEventSubscribedHeight $ _eventSubscription_subscribed oldParent
2259−
2260− print ("updateMe", oldParentHeight)
22612069 modifyIORef' heightBagRef $ heightBagRemove oldParentHeight
22622070 return $ IntMap.elems oldParents
2263− let changeSubscriber = Subscriber
2071+ let s = Subscriber
22642072 { subscriberPropagate = \a -> {-# SCC "traverseMergeChange" #-} do
22652073 tracePropagate (Proxy :: Proxy x) $ "SubscriberMergeInt/Change"
22662074 defer $ updateMe a
22672075 , subscriberInvalidateHeight = \_ -> return ()
22682076 , subscriberRecalculateHeight = \_ -> return ()
22692077 }
2270− (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) changeSubscriber
2078+ (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) s
22712079 forM_ change $ \c -> defer $ updateMe c
22722080 -- We explicitly hold on to the unsubscribe function from subscribing to the update event.
22732081 -- If we don't do this, there are certain cases where mergeCheap will fail to properly retain
22742082 -- its subscription.
2275− liftIO $ writeIORef changeSubdRef (changeSubscriber, changeSubscription)
2083+ liftIO $ writeIORef changeSubdRef (s, changeSubscription)
22762084 let unsubscribeAll = traverse_ unsubscribe =<< FastMutableIntMap.getFrozenAndClear parents
2277−
2278−
2279− return (EventSubscription unsubscribeAll subscribed, occ)
2085+ return ( EventSubscription unsubscribeAll $ EventSubscribed heightRef $ toAny (parents, changeSubdRef)
2086+ , occ
2087+ )
22802088
22812089newtype EventSelector x k = EventSelector { select :: forall a. k a -> Event x a }
22822090newtype EventSelectorG x k v = EventSelectorG { selectG :: forall a. k a -> Event x (v a) }
@@ -2359,19 +2167,19 @@ runFrame a = SpiderHost $ do
23592167 coincidenceInfos <- readIORef $ eventEnvResetCoincidences env
23602168 forM_ toAssign $ \(SomeAssignment vRef iRef v) -> {-# SCC "assignment" #-} do
23612169 writeIORef vRef v
2362− traceInvalidate $ "Invalidating Hold"
2170+ when debugInvalidate $ putStrLn $ "Invalidating Hold"
23632171 writeIORef iRef =<< evaluate =<< invalidate toReconnectRef =<< readIORef iRef
23642172 mergeUpdates <- readIORef $ eventEnvMergeUpdates env
23652173 writeIORef (eventEnvMergeUpdates env) []
2366− tracePropagate (Proxy::Proxy x) $ "Updating merges"
2174+ when debugPropagate $ putStrLn "Updating merges"
23672175 mergeSubscriptionsToKill <- runEventM $ concat <$> mapM _someMergeUpdate_update mergeUpdates
2368− tracePropagate (Proxy::Proxy x) $ "Updating merges done"
2176+ when debugPropagate $ putStrLn "Updating merges done"
23692177 toReconnect <- readIORef toReconnectRef
23702178 clearEventEnv env
23712179 switchSubscriptionsToKill <- forM toReconnect $ \(SomeSwitchSubscribed subscribed) -> {-# SCC "switchSubscribed" #-} do
23722180 oldSubscription <- readIORef $ switchSubscribedCurrentParent subscribed
23732181 wi <- readIORef $ switchSubscribedOwnWeakInvalidator subscribed
2374− traceInvalidate $ "Finalizing invalidator for Switch" <> showNodeId subscribed
2182+ when debugInvalidate $ putStrLn $ "Finalizing invalidator for Switch" <> showNodeId subscribed
23752183 finalize wi
23762184 i <- evaluate $ switchSubscribedOwnInvalidator subscribed
23772185 wi' <- mkWeakPtrWithDebug i "wi'"
@@ -2385,7 +2193,7 @@ runFrame a = SpiderHost $ do
23852193 subscription <- unSpiderHost $ runFrame $ {-# SCC "subscribeSwitch" #-} subscribe e sub --TODO: Assert that the event isn't firing --TODO: This should not loop because none of the events should be firing, but still, it is inefficient
23862194 {-
23872195 stackTrace <- liftIO $ fmap renderStack $ ccsToStrings =<< (getCCSOf $! switchSubscribedParent subscribed)
2388− liftIO $ debugStrLn $ (++stackTrace) $ "subd' subscribed to " ++ case e of
2196+ liftIO $ putStrLn $ (++stackTrace) $ "subd' subscribed to " ++ case e of
23892197 EventRoot _ -> "EventRoot"
23902198 EventNever -> "EventNever"
23912199 _ -> "something else"
@@ -2520,8 +2328,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Event
25202328 {-# INLINABLE headE #-}
25212329 headE = R.slowHeadE
25222330-- headE (SpiderEvent e) = SpiderEvent <$> Reflex.Spider.Internal.headE e
2523− {-# INLINABLE now #-}
2524− now = nowSpiderEventM
25252331
25262332instance Reflex.Class.MonadSample (SpiderTimeline x) (SpiderPullM x) where
25272333 {-# INLINABLE sample #-}
@@ -2543,9 +2349,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Spide
25432349 {-# INLINABLE headE #-}
25442350 headE = R.slowHeadE
25452351-- headE (SpiderEvent e) = SpiderPushM $ SpiderEvent <$> Reflex.Spider.Internal.headE e
2546− {-# INLINABLE now #-}
2547− now = SpiderPushM nowSpiderEventM
2548−
25492352
25502353instance HasSpiderTimeline x => Monad (Reflex.Class.Dynamic (SpiderTimeline x)) where
25512354 {-# INLINE return #-}
@@ -2554,10 +2357,8 @@ instance HasSpiderTimeline x => Monad (Reflex.Class.Dynamic (SpiderTimeline x))
25542357 x >>= f = SpiderDynamic $ dynamicDynIdentity $ newJoinDyn $ newMapDyn (unSpiderDynamic . f) $ unSpiderDynamic x
25552358 {-# INLINE (>>) #-}
25562359 (>>) = (*>)
2557−#if !MIN_VERSION_base(4,13,0)
25582360 {-# INLINE fail #-}
25592361 fail _ = error "Dynamic does not support 'fail'"
2560−#endif
25612362
25622363{-# INLINABLE newJoinDyn #-}
25632364newJoinDyn :: HasSpiderTimeline x => DynamicS x (Identity (DynamicS x (Identity a))) -> Reflex.Spider.Internal.Dyn x (Identity a)
@@ -2609,9 +2410,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Spide
26092410 buildDynamic getV0 e = runFrame . runSpiderHostFrame $ Reflex.Class.buildDynamic getV0 e
26102411 {-# INLINABLE headE #-}
26112412 headE e = runFrame . runSpiderHostFrame $ Reflex.Class.headE e
2612− {-# INLINABLE now #-}
2613− now = runFrame . runSpiderHostFrame $ Reflex.Class.now
2614−
26152413
26162414instance HasSpiderTimeline x => Reflex.Class.MonadSample (SpiderTimeline x) (SpiderHostFrame x) where
26172415 sample = SpiderHostFrame . readBehaviorUntracked . unSpiderBehavior --TODO: This can cause problems with laziness, so we should get rid of it if we can
@@ -2628,8 +2426,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Spide
26282426 {-# INLINABLE headE #-}
26292427 headE = R.slowHeadE
26302428-- headE (SpiderEvent e) = SpiderHostFrame $ SpiderEvent <$> Reflex.Spider.Internal.headE e
2631− {-# INLINABLE now #-}
2632− now = SpiderHostFrame Reflex.Class.now
26332429
26342430instance HasSpiderTimeline x => Reflex.Class.MonadSample (SpiderTimeline x) (SpiderHost x) where
26352431 {-# INLINABLE sample #-}
@@ -2650,8 +2446,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Refle
26502446 buildDynamic getV0 e = Reflex.Spider.Internal.ReadPhase $ Reflex.Class.buildDynamic getV0 e
26512447 {-# INLINABLE headE #-}
26522448 headE e = Reflex.Spider.Internal.ReadPhase $ Reflex.Class.headE e
2653− {-# INLINABLE now #-}
2654− now = Reflex.Spider.Internal.ReadPhase Reflex.Class.now
26552449
26562450--------------------------------------------------------------------------------
26572451-- Deprecated items
@@ -2689,13 +2483,13 @@ instance HasSpiderTimeline x => Reflex.Host.Class.MonadReadEvent (SpiderTimeline
26892483 touch h
26902484 return result
26912485
2692−instance HasSpiderTimeline x => Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHost x) where
2486+instance Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHost x) where
26932487 newEventWithTrigger = SpiderHost . fmap SpiderEvent . newEventWithTriggerIO
26942488 newFanEventWithTrigger f = SpiderHost $ do
26952489 es <- newFanEventWithTriggerIO f
26962490 return $ Reflex.Class.EventSelector $ SpiderEvent . Reflex.Spider.Internal.select es
26972491
2698−instance HasSpiderTimeline x => Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHostFrame x) where
2492+instance Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHostFrame x) where
26992493 newEventWithTrigger = SpiderHostFrame . EventM . liftIO . fmap SpiderEvent . newEventWithTriggerIO
27002494 newFanEventWithTrigger f = SpiderHostFrame $ EventM $ liftIO $ do
27012495 es <- newFanEventWithTriggerIO f
@@ -2775,7 +2569,7 @@ instance HasSpiderTimeline x => R.Reflex (SpiderTimeline x) where
27752569 fanG e = R.EventSelectorG $ SpiderEvent . selectG (fanG (unSpiderEvent e))
27762570 {-# INLINABLE mergeG #-}
27772571 mergeG
2778− :: forall k2 (k :: k2 -> *) q (v :: k2 -> *). GCompare k
2572+ :: forall (k :: k2 -> *) q (v :: k2 -> *). GCompare k
27792573 => (forall a. q a -> R.Event (SpiderTimeline x) (v a))
27802574 -> DMap k q
27812575 -> R.Event (SpiderTimeline x) (DMap k v)
@@ -2843,14 +2637,8 @@ instance Monad (SpiderHost x) where
28432637 SpiderHost x >> SpiderHost y = SpiderHost $ x >> y
28442638 {-# INLINABLE return #-}
28452639 return x = SpiderHost $ return x
2846−#if !MIN_VERSION_base(4,13,0)
28472640 {-# INLINABLE fail #-}
2848− fail = MonadFail.fail
2849−#endif
2850−
2851−instance MonadFail (SpiderHost x) where
2852− {-# INLINABLE fail #-}
2853− fail s = SpiderHost $ MonadFail.fail s
2641+ fail s = SpiderHost $ fail s
28542642
28552643-- | Run an action affecting the global Spider timeline; this will be guarded by
28562644-- a mutex for that timeline
@@ -2872,21 +2660,19 @@ instance Monad (SpiderHostFrame x) where
28722660 SpiderHostFrame x >> SpiderHostFrame y = SpiderHostFrame $ x >> y
28732661 {-# INLINABLE return #-}
28742662 return x = SpiderHostFrame $ return x
2875−#if !MIN_VERSION_base(4,13,0)
28762663 {-# INLINABLE fail #-}
28772664 fail s = SpiderHostFrame $ fail s
2878−#endif
28792665
28802666instance NotReady (SpiderTimeline x) (SpiderHostFrame x) where
28812667 notReadyUntil _ = pure ()
28822668 notReady = pure ()
28832669
2884−newEventWithTriggerIO :: forall x a. HasSpiderTimeline x => (RootTrigger x a -> IO (IO ())) -> IO (Event x a)
2670+newEventWithTriggerIO :: (RootTrigger x a -> IO (IO ())) -> IO (Event x a)
28852671newEventWithTriggerIO f = do
28862672 es <- newFanEventWithTriggerIO $ \Refl -> f
28872673 return $ select es Refl
28882674
2889−newFanEventWithTriggerIO :: (HasSpiderTimeline x, GCompare k) => (forall a. k a -> RootTrigger x a -> IO (IO ())) -> IO (EventSelector x k)
2675+newFanEventWithTriggerIO :: GCompare k => (forall a. k a -> RootTrigger x a -> IO (IO ())) -> IO (EventSelector x k)
28902676newFanEventWithTriggerIO f = do
28912677 occRef <- newIORef DMap.empty
28922678 subscribedRef <- newIORef DMap.empty
@@ -2927,4 +2713,4 @@ instance NotReady (SpiderTimeline x) (SpiderHost x) where
29272713
29282714instance HasSpiderTimeline x => NotReady (SpiderTimeline x) (PerformEventT (SpiderTimeline x) (SpiderHost x)) where
29292715 notReadyUntil _ = return ()
2930− notReady = return ()
2716+ notReady = return ()