@@ -9,22 +9,17 @@
99{-# LANGUAGE GADTs #-}
1010{-# LANGUAGE GeneralizedNewtypeDeriving #-}
1111{-# LANGUAGE LambdaCase #-}
12+{-# LANGUAGE MultiParamTypeClasses #-}
13+{-# LANGUAGE MultiWayIf #-}
1214{-# LANGUAGE RankNTypes #-}
1315{-# LANGUAGE RoleAnnotations #-}
1416{-# LANGUAGE ScopedTypeVariables #-}
1517{-# LANGUAGE TypeFamilies #-}
1618{-# LANGUAGE TypeOperators #-}
1719{-# LANGUAGE UndecidableInstances #-}
18−{-# LANGUAGE PolyKinds #-}
19−{-# LANGUAGE DeriveFunctor #-}
20−{-# LANGUAGE StandaloneDeriving #-}
21−{-# LANGUAGE InstanceSigs #-}
22−{-# LANGUAGE MultiWayIf #-}
23−
2420#ifdef USE_REFLEX_OPTIMIZER
2521{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
2622#endif
27−{-# OPTIONS_GHC -Wunused-binds #-}
2823-- | This module is the implementation of the 'Spider' 'Reflex' engine. It uses
2924-- a graph traversal algorithm to propagate 'Event's and 'Behavior's.
3025module Reflex.Spider.Internal (module Reflex.Spider.Internal) where
@@ -38,17 +33,12 @@ import Control.Monad hiding (forM, forM_, mapM, mapM_)
3833import Control.Monad.Exception
3934import Control.Monad.Identity hiding (forM, forM_, mapM, mapM_)
4035import Control.Monad.Primitive
41−import Control.Monad.Reader.Class
42−import Control.Monad.IO.Class
43−import Control.Monad.ReaderIO
36+import Control.Monad.Reader hiding (forM, forM_, mapM, mapM_)
4437import Control.Monad.Ref
45−import Control.Monad.Fail (MonadFail)
46−import qualified Control.Monad.Fail as MonadFail
4738import Data.Align
4839import Data.Coerce
49−import Data.Dependent.Map (DMap)
40+import Data.Dependent.Map (DMap, DSum (..))
5041import qualified Data.Dependent.Map as DMap
51−import Data.Dependent.Sum (DSum (..))
5242import Data.FastMutableIntMap (FastMutableIntMap, PatchIntMap (..))
5343import qualified Data.FastMutableIntMap as FastMutableIntMap
5444import Data.Foldable hiding (concat, elem, sequence_)
@@ -59,15 +49,13 @@ import Data.GADT.Compare
5949import Data.IntMap.Strict (IntMap)
6050import qualified Data.IntMap.Strict as IntMap
6151import Data.IORef
62−import Data.Kind (Type)
6352import Data.Maybe hiding (mapMaybe)
64−import Data.Monoid (mempty, (<>))
53+import Data.Monoid ((<>))
6554import Data.Proxy
6655import Data.These
6756import Data.Traversable
68−import Data.Type.Equality ((:~:)(Refl))
6957import Data.Witherable (Filterable, mapMaybe)
70−import GHC.Exts hiding (toList)
58+import GHC.Exts
7159import GHC.IORef (IORef (..))
7260import GHC.Stack
7361import Reflex.FastWeak
@@ -75,103 +63,58 @@ import System.IO.Unsafe
7563import System.Mem.Weak
7664import Unsafe.Coerce
7765
78−#ifdef MIN_VERSION_semialign
79−#if MIN_VERSION_these(0,8,0)
80−import Data.These.Combinators (justThese)
81−#endif
82−#if MIN_VERSION_semialign(1,1,0)
83−import Data.Zip (Zip (..))
84−#endif
85−#endif
86−
8766#ifdef DEBUG_CYCLES
8867import Control.Monad.State hiding (forM, forM_, mapM, mapM_, sequence)
89−#endif
90−
9168import Data.List.NonEmpty (NonEmpty (..), nonEmpty)
9269import qualified Data.List.NonEmpty as NonEmpty
70+import Data.Monoid (mempty)
9371import Data.Tree (Forest, Tree (..), drawForest)
94−import Data.List (isPrefixOf)
72+#endif
9573
96−import Data.FastWeakBag (FastWeakBag, FastWeakBagTicket)
74+import Data.FastWeakBag (FastWeakBag)
9775import qualified Data.FastWeakBag as FastWeakBag
98−
9976import Data.Reflection
10077import Data.Some (Some(Some))
10178import Data.Type.Coercion
102−import Data.Profunctor.Unsafe ((#.), (.#))
10379import Data.WeakBag (WeakBag, WeakBagTicket, _weakBag_children)
10480import qualified Data.WeakBag as WeakBag
10581import qualified Reflex.Class
10682import qualified Reflex.Class as R
10783import qualified Reflex.Host.Class
10884import Reflex.NotReady.Class
109−import Data.Patch
110−import qualified Data.Patch.DMapWithMove as PatchDMapWithMove
111−import Reflex.PerformEvent.Base (PerformEventT)
85+import Reflex.Patch
86+import qualified Reflex.Patch.DMapWithMove as PatchDMapWithMove
11287
11388#ifdef DEBUG_TRACE_EVENTS
11489import qualified Data.ByteString.Char8 as BS8
11590import System.IO (stderr)
116−import Data.List (isPrefixOf)
11791#endif
11892
119−-- TODO stdout might not be the best channel for debug output
120−debugStrLn :: String -> IO ()
121−debugStrLn = putStrLn
122−
12393#ifdef DEBUG_TRACE_EVENTS
94+
12495withStackOneLine :: (BS8.ByteString -> a) -> a
12596withStackOneLine expr = unsafePerformIO $ do
12697 stack <- currentCallStack
127− return (expr . BS8.pack . unwords . dropInternal . reverse $ stack)
128− where dropInternal = filterStack "Reflex.Spider.Internal"
98+ return (expr (BS8.pack (unwords (reverse stack))))
12999
130100#endif
131101
132−debugPropagate :: Bool
133−
134−debugInvalidateHeight :: Bool
135−
136−debugInvalidate :: Bool
137−
138102#ifdef DEBUG
139103#define DEBUG_NODEIDS
140104
141−#ifdef DEBUG_TRACE_PROPAGATION
142−debugPropagate = True
143−#else
144−debugPropagate = False
145−#endif
146−
147−#ifdef DEBUG_TRACE_HEIGHT
148−debugInvalidateHeight = True
149−#else
150−debugInvalidateHeight = False
151−#endif
152−
153−#ifdef DEBUG_TRACE_INVALIDATION
154−debugInvalidate = True
155−#else
156−debugInvalidate = False
157−#endif
158−
159105class HasNodeId a where
160106 getNodeId :: a -> Int
161107
162−instance HasNodeId (CacheSubscribed x a) where
163− getNodeId = _cacheSubscribed_nodeId
164−
165−instance HasNodeId (FanInt x a) where
166− getNodeId = _fanInt_nodeId
167−
168108instance HasNodeId (Hold x p) where
169109 getNodeId = holdNodeId
170110
111+-- instance HasNodeId (PushSubscribed x a b) where
112+-- getNodeId = pushSubscribedNodeId
113+
171114instance HasNodeId (SwitchSubscribed x a) where
172115 getNodeId = switchSubscribedNodeId
173116
174−instance HasNodeId (FanSubscribed x v a) where
117+instance HasNodeId (FanSubscribed x a) where
175118 getNodeId = fanSubscribedNodeId
176119
177120instance HasNodeId (CoincidenceSubscribed x a) where
@@ -185,27 +128,16 @@ instance HasNodeId (Pull x a) where
185128
186129{-# INLINE showNodeId #-}
187130showNodeId :: HasNodeId a => a -> String
188−showNodeId = showNodeId' . getNodeId
189−
190−showNodeId' :: Int -> String
191−showNodeId' = ("#"<>) . show
131+showNodeId = ("#"<>) . show . getNodeId
192132
193133
194134#else
195135
196−debugPropagate = False
197−debugInvalidateHeight = False
198−debugInvalidate = False
199−
200136-- This must be inline, or error messages will cause memory leaks due to retaining the node in question
201137{-# INLINE showNodeId #-}
202138showNodeId :: a -> String
203139showNodeId _ = ""
204140
205−{-# INLINE showNodeId' #-}
206−showNodeId' :: Int -> String
207−showNodeId' _ = ""
208−
209141#endif
210142
211143#ifdef DEBUG_NODEIDS
@@ -215,6 +147,12 @@ nextNodeIdRef = unsafePerformIO $ newIORef 1
215147
216148newNodeId :: IO Int
217149newNodeId = atomicModifyIORef' nextNodeIdRef $ \n -> (succ n, n)
150+
151+{-# NOINLINE unsafeNodeId #-}
152+unsafeNodeId :: a -> Int
153+unsafeNodeId a = unsafePerformIO $ do
154+ touch a
155+ newNodeId
218156#endif
219157
220158--------------------------------------------------------------------------------
@@ -251,9 +189,9 @@ subscribeAndRead = unEvent
251189-- caching; if the computation function is very cheap, this is (much) more
252190-- efficient than 'push'
253191{-# INLINE [1] pushCheap #-}
254−pushCheap :: HasSpiderTimeline x => (a -> ComputeM x (Maybe b)) -> Event x a -> Event x b
192+pushCheap :: (a -> ComputeM x (Maybe b)) -> Event x a -> Event x b
255193pushCheap !f e = Event $ \sub -> do
256− (subscription, occ) <- subscribeAndRead e $ debugSubscriber' "push" $ sub
194+ (subscription, occ) <- subscribeAndRead e $ sub
257195 { subscriberPropagate = \a -> do
258196 mb <- f a
259197 mapM_ (subscriberPropagate sub) mb
@@ -272,10 +210,10 @@ terminalSubscriber p = Subscriber
272210
273211-- | Subscribe to an Event only for the duration of one occurrence
274212{-# INLINE subscribeAndReadHead #-}
275−subscribeAndReadHead :: HasSpiderTimeline x => Event x a -> Subscriber x a -> EventM x (EventSubscription x, Maybe a)
213+subscribeAndReadHead :: Event x a -> Subscriber x a -> EventM x (EventSubscription x, Maybe a)
276214subscribeAndReadHead e sub = do
277215 subscriptionRef <- liftIO $ newIORef $ error "subscribeAndReadHead: not initialized"
278− (subscription, occ) <- subscribeAndRead e $ debugSubscriber' "head" $ sub
216+ (subscription, occ) <- subscribeAndRead e $ sub
279217 { subscriberPropagate = \a -> do
280218 liftIO $ unsubscribe =<< readIORef subscriptionRef
281219 subscriberPropagate sub a
@@ -286,42 +224,24 @@ subscribeAndReadHead e sub = do
286224 return (subscription, occ)
287225
288226--TODO: Make this lazy in its input event
289−headE :: (MonadIO m, Defer (SomeMergeInit x) m, HasSpiderTimeline x) => Event x a -> m (Event x a)
227+headE :: (MonadIO m, Defer (SomeMergeInit x) m) => Event x a -> m (Event x a)
290228headE originalE = do
291229 parent <- liftIO $ newIORef $ Just originalE
292230 defer $ SomeMergeInit $ do --TODO: Rename SomeMergeInit appropriately
293231 let clearParent = liftIO $ writeIORef parent Nothing
294− (_, occ) <- subscribeAndReadHead originalE $ terminalSubscriber $ const clearParent
232+ (_, occ) <- subscribeAndReadHead originalE $ terminalSubscriber $ \_ -> clearParent
295233 when (isJust occ) clearParent
296− return $ Event $ \sub ->
234+ return $ Event $ \sub -> do
297235 liftIO (readIORef parent) >>= \case
298− Nothing -> subscribeAndReadNever
236+ Nothing -> return (EventSubscription (return ()) $ EventSubscribed zeroRef $ toAny (), Nothing)
299237 Just e -> subscribeAndReadHead e sub
300238
301239data CacheSubscribed x a
302240 = CacheSubscribed { _cacheSubscribed_subscribers :: {-# UNPACK #-} !(FastWeakBag (Subscriber x a))
303241 , _cacheSubscribed_parent :: {-# UNPACK #-} !(EventSubscription x)
304242 , _cacheSubscribed_occurrence :: {-# UNPACK #-} !(IORef (Maybe a))
305−#ifdef DEBUG_NODEIDS
306− , _cacheSubscribed_nodeId :: {-# UNPACK #-} !Int
307−#endif
308243 }
309244
310−nowSpiderEventM :: (HasSpiderTimeline x) => EventM x (R.Event (SpiderTimeline x) ())
311−nowSpiderEventM =
312− SpiderEvent <$> now
313−
314−now :: (MonadIO m, Defer (Some Clear) m, HasSpiderTimeline x
315− ) => m (Event x ())
316−now = do
317− nowOrNot <- liftIO $ newIORef $ Just ()
318− scheduleClear nowOrNot
319− return . Event $ \_ -> do
320− occ <- liftIO . readIORef $ nowOrNot
321− return ( EventSubscription (return ()) eventSubscribedNow
322− , occ
323− )
324−
325245-- | Construct an 'Event' whose value is guaranteed not to be recomputed
326246-- repeatedly
327247--
@@ -336,33 +256,27 @@ cacheEvent e =
336256#else
337257 Event $
338258#endif
339− unsafePerformIO $ do
340− mSubscribedRef :: IORef (FastWeak (CacheSubscribed x a))
341− <- newIORef emptyFastWeak
342− pure $ \sub -> {-# SCC "cacheEvent" #-} do
259+ let mSubscribedRef :: IORef (FastWeak (CacheSubscribed x a))
260+ !mSubscribedRef = unsafeNewIORef e emptyFastWeak
261+ in \sub -> {-# SCC "cacheEvent" #-} do
343262#ifdef DEBUG_TRACE_EVENTS
344263 unless (BS8.null callSite) $ liftIO $ BS8.hPutStrLn stderr callSite
345264#endif
346265 subscribedTicket <- liftIO (readIORef mSubscribedRef >>= getFastWeakTicket) >>= \case
347266 Just subscribedTicket -> return subscribedTicket
348267 Nothing -> do
349−#ifdef DEBUG_NODEIDS
350− nodeId <- liftIO newNodeId
351−#endif
352268 subscribers <- liftIO FastWeakBag.empty
353269 occRef <- liftIO $ newIORef Nothing -- This should never be read prior to being set below
354−#ifdef DEBUG_NODEIDS
355− (parentSub, occ) <- subscribeAndRead e $ debugSubscriber' ("cacheEvent" <> showNodeId' nodeId) $ Subscriber
356−#else
357270 (parentSub, occ) <- subscribeAndRead e $ Subscriber
358−#endif
359− { subscriberPropagate = \a -> do
360− liftIO $ writeIORef occRef (Just a)
361− scheduleClear occRef
362− propagateFast a subscribers
363− , subscriberInvalidateHeight = FastWeakBag.traverse_ subscribers . invalidateSubscriberHeight
364− , subscriberRecalculateHeight = FastWeakBag.traverse_ subscribers . recalculateSubscriberHeight
365− }
271+ { subscriberPropagate = \a -> do
272+ liftIO $ writeIORef occRef $ Just a
273+ scheduleClear occRef
274+ propagateFast a subscribers
275+ , subscriberInvalidateHeight = \old -> do
276+ FastWeakBag.traverse subscribers $ invalidateSubscriberHeight old
277+ , subscriberRecalculateHeight = \new -> do
278+ FastWeakBag.traverse subscribers $ recalculateSubscriberHeight new
279+ }
366280 when (isJust occ) $ do
367281 liftIO $ writeIORef occRef occ -- Set the initial value of occRef; we don't need to do this if occ is Nothing
368282 scheduleClear occRef
@@ -370,45 +284,29 @@ cacheEvent e =
370284 { _cacheSubscribed_subscribers = subscribers
371285 , _cacheSubscribed_parent = parentSub
372286 , _cacheSubscribed_occurrence = occRef
373−#ifdef DEBUG_NODEIDS
374− , _cacheSubscribed_nodeId = nodeId
375−#endif
376287 }
377288 subscribedTicket <- liftIO $ mkFastWeakTicket subscribed
378289 liftIO $ writeIORef mSubscribedRef =<< getFastWeakTicketWeak subscribedTicket
379290 return subscribedTicket
380− liftIO $ cacheSubscription sub mSubscribedRef subscribedTicket
381−
382−cacheSubscription :: Subscriber x a -> IORef (FastWeak (CacheSubscribed x a))
383− -> FastWeakTicket (CacheSubscribed x a) -> IO (EventSubscription x, Maybe a)
384−cacheSubscription sub mSubscribedRef subscribedTicket = do
385− subscribed <- getFastWeakTicketValue subscribedTicket
386− ticket <- FastWeakBag.insert sub $ _cacheSubscribed_subscribers subscribed
387− occ <- readIORef $ _cacheSubscribed_occurrence subscribed
388−
389− let parentSub = _cacheSubscribed_parent subscribed
390− es = EventSubscription
391− { _eventSubscription_unsubscribe = do
392− FastWeakBag.remove ticket
393−
394− isEmpty <- FastWeakBag.isEmpty $ _cacheSubscribed_subscribers subscribed
395− when isEmpty $ do
396− writeIORef mSubscribedRef emptyFastWeak
397− unsubscribe parentSub
398− touch ticket
399− touch subscribedTicket
400− , _eventSubscription_subscribed = EventSubscribed
401− { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed parentSub
402− , eventSubscribedRetained = toAny subscribedTicket
403−#ifdef DEBUG_CYCLES
404− , eventSubscribedGetParents = return [_eventSubscription_subscribed parentSub]
405− , eventSubscribedHasOwnHeightRef = False
406− , eventSubscribedWhoCreated = whoCreatedIORef mSubscribedRef
407−#endif
408− }
409− }
410− return (es, occ)
411−
291+ liftIO $ do
292+ subscribed <- getFastWeakTicketValue subscribedTicket
293+ ticket <- FastWeakBag.insert sub $ _cacheSubscribed_subscribers subscribed
294+ occ <- readIORef $ _cacheSubscribed_occurrence subscribed
295+ let es = EventSubscription
296+ { _eventSubscription_unsubscribe = do
297+ FastWeakBag.remove ticket
298+ isEmpty <- FastWeakBag.isEmpty $ _cacheSubscribed_subscribers subscribed
299+ when isEmpty $ do
300+ writeIORef mSubscribedRef emptyFastWeak
301+ unsubscribe $ _cacheSubscribed_parent subscribed
302+ touch ticket
303+ touch subscribedTicket
304+ , _eventSubscription_subscribed = EventSubscribed
305+ { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed $ _cacheSubscribed_parent subscribed
306+ , eventSubscribedRetained = toAny subscribedTicket
307+ }
308+ }
309+ return (es, occ)
412310
413311subscribe :: Event x a -> Subscriber x a -> EventM x (EventSubscription x)
414312subscribe e s = fst <$> subscribeAndRead e s
@@ -423,13 +321,10 @@ wrap tag getSpecificSubscribed sub = do
423321eventRoot :: (GCompare k, HasSpiderTimeline x) => k a -> Root x k -> Event x a
424322eventRoot !k !r = Event $ wrap eventSubscribedRoot $ liftIO . getRootSubscribed k r
425323
426−subscribeAndReadNever :: EventM x (EventSubscription x, Maybe a)
427−subscribeAndReadNever = return (EventSubscription (return ()) eventSubscribedNever, Nothing)
428−
429324eventNever :: Event x a
430−eventNever = Event $ const subscribeAndReadNever
325+eventNever = Event $ \_ -> return (EventSubscription (return ()) eventSubscribedNever, Nothing)
431326
432−eventFan :: (GCompare k, HasSpiderTimeline x) => k a -> Fan x k v -> Event x (v a)
327+eventFan :: (GCompare k, HasSpiderTimeline x) => k a -> Fan x k -> Event x a
433328eventFan !k !f = Event $ wrap eventSubscribedFan $ getFanSubscribed k f
434329
435330eventSwitch :: HasSpiderTimeline x => Switch x a -> Event x a
@@ -464,6 +359,16 @@ data Subscriber x a = Subscriber
464359 , subscriberRecalculateHeight :: !(Height -> IO ())
465360 }
466361
362+--TODO: Move this comment to WeakBag
363+-- These function are constructor functions that are marked NOINLINE so they are
364+-- opaque to GHC. If we do not do this, then GHC will sometimes fuse the constructor away
365+-- so any weak references that are attached to the constructors will have their
366+-- finalizer run. Using the opaque constructor, does not see the
367+-- constructor application, so it behaves like an IORef and cannot be fused away.
368+--
369+-- The result is also evaluated to WHNF, since forcing a thunk invalidates
370+-- the weak pointer to it in some cases.
371+
467372newSubscriberHold :: (HasSpiderTimeline x, Patch p) => Hold x p -> IO (Subscriber x p)
468373newSubscriberHold h = return $ Subscriber
469374 { subscriberPropagate = {-# SCC "traverseHold" #-} propagateSubscriberHold h
@@ -471,26 +376,28 @@ newSubscriberHold h = return $ Subscriber
471376 , subscriberRecalculateHeight = \_ -> return ()
472377 }
473378
474−newSubscriberFan :: forall x k v. (HasSpiderTimeline x, GCompare k) => FanSubscribed x k v -> IO (Subscriber x (DMap k v))
379+newSubscriberFan :: forall x k. (HasSpiderTimeline x, GCompare k) => FanSubscribed x k -> IO (Subscriber x (DMap k Identity))
475380newSubscriberFan subscribed = debugSubscriber ("SubscriberFan " <> showNodeId subscribed) $ Subscriber
476381 { subscriberPropagate = \a -> {-# SCC "traverseFan" #-} do
477382 subs <- liftIO $ readIORef $ fanSubscribedSubscribers subscribed
478383 tracePropagate (Proxy :: Proxy x) $ show (DMap.size subs) <> " keys subscribed, " <> show (DMap.size a) <> " keys firing"
479384 liftIO $ writeIORef (fanSubscribedOccurrence subscribed) $ Just a
480385 scheduleClear $ fanSubscribedOccurrence subscribed
481− let f _ (Pair v subsubs) = do
386+ let f _ (Pair (Identity v) subsubs) = do
482387 propagate v $ _fanSubscribedChildren_list subsubs
483388 return $ Constant ()
484389 _ <- DMap.traverseWithKey f $ DMap.intersectionWithKey (\_ -> Pair) a subs --TODO: Would be nice to have DMap.traverse_
485390 return ()
486391 , subscriberInvalidateHeight = \old -> do
487392 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
488− forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse_ (_fanSubscribedChildren_list v) $ invalidateSubscriberHeight old
393+ forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse (_fanSubscribedChildren_list v) $ invalidateSubscriberHeight old
394+
489395 , subscriberRecalculateHeight = \new -> do
490396 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
491− forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse_ (_fanSubscribedChildren_list v) $ recalculateSubscriberHeight new
397+ forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse (_fanSubscribedChildren_list v) $ recalculateSubscriberHeight new
492398 }
493399
400+
494401newSubscriberSwitch :: forall x a. HasSpiderTimeline x => SwitchSubscribed x a -> IO (Subscriber x a)
495402newSubscriberSwitch subscribed = debugSubscriber ("SubscriberCoincidenceOuter" <> showNodeId subscribed) $ Subscriber
496403 { subscriberPropagate = \a -> {-# SCC "traverseSwitch" #-} do
@@ -501,7 +408,7 @@ newSubscriberSwitch subscribed = debugSubscriber ("SubscriberCoincidenceOuter" <
501408 oldHeight <- readIORef $ switchSubscribedHeight subscribed
502409 when (oldHeight /= invalidHeight) $ do
503410 writeIORef (switchSubscribedHeight subscribed) $! invalidHeight
504− WeakBag.traverse_ (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
411+ WeakBag.traverse (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
505412 , subscriberRecalculateHeight = (`updateSwitchHeight` subscribed)
506413 }
507414
@@ -517,17 +424,17 @@ newSubscriberCoincidenceOuter subscribed = debugSubscriber ("SubscriberCoinciden
517424 liftIO $ writeIORef (coincidenceSubscribedInnerParent subscribed) $ Just innerSubd
518425 scheduleClear $ coincidenceSubscribedInnerParent subscribed
519426 case occ of
520− Nothing ->
427+ Nothing -> do
521428 when (innerHeight > outerHeight) $ liftIO $ do -- If the event fires, it will fire at a later height
522429 writeIORef (coincidenceSubscribedHeight subscribed) $! innerHeight
523− WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight outerHeight
524− WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ recalculateSubscriberHeight innerHeight
430+ WeakBag.traverse (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight outerHeight
431+ WeakBag.traverse (coincidenceSubscribedSubscribers subscribed) $ recalculateSubscriberHeight innerHeight
525432 Just o -> do -- Since it's already firing, no need to adjust height
526433 liftIO $ writeIORef (coincidenceSubscribedOccurrence subscribed) occ
527434 scheduleClear $ coincidenceSubscribedOccurrence subscribed
528435 propagate o $ coincidenceSubscribedSubscribers subscribed
529436 , subscriberInvalidateHeight = \_ -> invalidateCoincidenceHeight subscribed
530− , subscriberRecalculateHeight = \_ -> recalculateCoincidenceHeight subscribed
437+ , subscriberRecalculateHeight = \_ -> recalculateCoincidenceHeight subscribed
531438 }
532439
533440newSubscriberCoincidenceInner :: forall x a. HasSpiderTimeline x => CoincidenceSubscribed x a -> IO (Subscriber x a)
@@ -551,18 +458,18 @@ recalculateSubscriberHeight :: Height -> Subscriber x a -> IO ()
551458recalculateSubscriberHeight = flip subscriberRecalculateHeight
552459
553460-- | Propagate everything at the current height
554−propagate :: forall x a. HasSpiderTimeline x => a -> WeakBag (Subscriber x a) -> EventM x ()
555−propagate a subscribers = withIncreasedDepth (Proxy::Proxy x) $
461+propagate :: forall a x. HasSpiderTimeline x => a -> WeakBag (Subscriber x a) -> EventM x ()
462+propagate a subscribers = withIncreasedDepth (Proxy::Proxy x) $ do
556463 -- Note: in the following traversal, we do not visit nodes that are added to the list during our traversal; they are new events, which will necessarily have full information already, so there is no need to traverse them
557464 --TODO: Should we check if nodes already have their values before propagating? Maybe we're re-doing work
558− WeakBag.traverse_ subscribers $ \s -> subscriberPropagate s a
465+ WeakBag.traverse subscribers $ \s -> subscriberPropagate s a
559466
560467-- | Propagate everything at the current height
561−propagateFast :: forall x a. HasSpiderTimeline x => a -> FastWeakBag (Subscriber x a) -> EventM x ()
562−propagateFast a subscribers = withIncreasedDepth (Proxy::Proxy x) $
468+propagateFast :: forall a x. HasSpiderTimeline x => a -> FastWeakBag (Subscriber x a) -> EventM x ()
469+propagateFast a subscribers = withIncreasedDepth (Proxy::Proxy x) $ do
563470 -- Note: in the following traversal, we do not visit nodes that are added to the list during our traversal; they are new events, which will necessarily have full information already, so there is no need to traverse them
564471 --TODO: Should we check if nodes already have their values before propagating? Maybe we're re-doing work
565− FastWeakBag.traverse_ subscribers $ \s -> subscriberPropagate s a
472+ FastWeakBag.traverse subscribers $ \s -> subscriberPropagate s a
566473
567474--------------------------------------------------------------------------------
568475-- EventSubscribed
@@ -571,16 +478,11 @@ propagateFast a subscribers = withIncreasedDepth (Proxy::Proxy x) $
571478toAny :: a -> Any
572479toAny = unsafeCoerce
573480
574−-- Why do we use Any here, instead of just giving eventSubscribedRetained an
575−-- existential type? Sadly, GHC does not currently know how to unbox types
576−-- with existentially quantified fields. So instead we just coerce values
577−-- to type Any on the way in. Since we never coerce them back, this is
578−-- perfectly safe.
579481data EventSubscribed x = EventSubscribed
580482 { eventSubscribedHeightRef :: {-# UNPACK #-} !(IORef Height)
581483 , eventSubscribedRetained :: {-# NOUNPACK #-} !Any
582484#ifdef DEBUG_CYCLES
583− , eventSubscribedGetParents :: !(IO [EventSubscribed x]) -- For debugging loops
485+ , eventSubscribedGetParents :: !(IO [Some (EventSubscribed x)]) -- For debugging loops
584486 , eventSubscribedHasOwnHeightRef :: !Bool
585487 , eventSubscribedWhoCreated :: !(IO [String])
586488#endif
@@ -607,23 +509,13 @@ eventSubscribedNever = EventSubscribed
607509 , eventSubscribedWhoCreated = return ["never"]
608510#endif
609511 }
610−eventSubscribedNow :: EventSubscribed x
611−eventSubscribedNow = EventSubscribed
612− { eventSubscribedHeightRef = zeroRef
613− , eventSubscribedRetained = toAny ()
614−#ifdef DEBUG_CYCLES
615− , eventSubscribedGetParents = return []
616− , eventSubscribedHasOwnHeightRef = False
617− , eventSubscribedWhoCreated = return ["now"]
618−#endif
619− }
620512
621−eventSubscribedFan :: FanSubscribed x k v -> EventSubscribed x
513+eventSubscribedFan :: FanSubscribed x k -> EventSubscribed x
622514eventSubscribedFan !subscribed = EventSubscribed
623515 { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed $ fanSubscribedParent subscribed
624516 , eventSubscribedRetained = toAny subscribed
625517#ifdef DEBUG_CYCLES
626− , eventSubscribedGetParents = return [_eventSubscription_subscribed $ fanSubscribedParent subscribed]
518+ , eventSubscribedGetParents = return [Some $ _eventSubscription_subscribed $ fanSubscribedParent subscribed]
627519 , eventSubscribedHasOwnHeightRef = False
628520 , eventSubscribedWhoCreated = whoCreatedIORef $ fanSubscribedCachedSubscribed subscribed
629521#endif
@@ -636,7 +528,7 @@ eventSubscribedSwitch !subscribed = EventSubscribed
636528#ifdef DEBUG_CYCLES
637529 , eventSubscribedGetParents = do
638530 s <- readIORef $ switchSubscribedCurrentParent subscribed
639− return [_eventSubscription_subscribed s]
531+ return [Some $ _eventSubscription_subscribed s]
640532 , eventSubscribedHasOwnHeightRef = True
641533 , eventSubscribedWhoCreated = whoCreatedIORef $ switchSubscribedCachedSubscribed subscribed
642534#endif
@@ -649,8 +541,8 @@ eventSubscribedCoincidence !subscribed = EventSubscribed
649541#ifdef DEBUG_CYCLES
650542 , eventSubscribedGetParents = do
651543 innerSubscription <- readIORef $ coincidenceSubscribedInnerParent subscribed
652− let outerParent = _eventSubscription_subscribed $ coincidenceSubscribedOuterParent subscribed
653− innerParents = maybeToList $ innerSubscription
544+ let outerParent = Some $ _eventSubscription_subscribed $ coincidenceSubscribedOuterParent subscribed
545+ innerParents = maybeToList $ fmap Some innerSubscription
654546 return $ outerParent : innerParents
655547 , eventSubscribedHasOwnHeightRef = True
656548 , eventSubscribedWhoCreated = whoCreatedIORef $ coincidenceSubscribedCachedSubscribed subscribed
@@ -664,15 +556,15 @@ getEventSubscribedHeight es = readIORef $ eventSubscribedHeightRef es
664556whoCreatedEventSubscribed :: EventSubscribed x -> IO [String]
665557whoCreatedEventSubscribed = eventSubscribedWhoCreated
666558
667−walkInvalidHeightParents :: EventSubscribed x -> IO [EventSubscribed x]
559+walkInvalidHeightParents :: EventSubscribed x -> IO [Some (EventSubscribed x)]
668560walkInvalidHeightParents s0 = do
669− subscribers <- flip execStateT mempty $ ($ s0) $ fix $ \loop s -> do
561+ subscribers <- flip execStateT mempty $ ($ Some s0) $ fix $ \loop (Some s) -> do
670562 h <- liftIO $ readIORef $ eventSubscribedHeightRef s
671563 when (h == invalidHeight) $ do
672564 when (eventSubscribedHasOwnHeightRef s) $ liftIO $ writeIORef (eventSubscribedHeightRef s) $! invalidHeightBeingTraversed
673− modify (s :)
565+ modify (Some s :)
674566 mapM_ loop =<< liftIO (eventSubscribedGetParents s)
675− forM_ subscribers $ \s -> writeIORef (eventSubscribedHeightRef s) $! invalidHeight
567+ forM_ subscribers $ \(Some s) -> writeIORef (eventSubscribedHeightRef s) $! invalidHeight
676568 return subscribers
677569#endif
678570
@@ -709,7 +601,7 @@ behaviorPull !p = Behavior $ do
709601 wi <- liftIO $ mkWeakPtrWithDebug i "InvalidatorPull"
710602 parentsRef <- liftIO $ newIORef []
711603 holdInits <- askBehaviorHoldInits
712− a <- liftIO $ runReaderIO (unBehaviorM $ pullCompute p) (Just (wi, parentsRef), holdInits)
604+ a <- liftIO $ runReaderT (unBehaviorM $ pullCompute p) (Just (wi, parentsRef), holdInits)
713605 invsRef <- liftIO . newIORef . maybeToList =<< askInvalidator
714606 parents <- liftIO $ readIORef parentsRef
715607 let subscribed = PullSubscribed
@@ -744,46 +636,42 @@ readBehaviorUntracked b = do
744636-- Dynamic
745637--------------------------------------------------------------------------------
746638
747−type DynamicS x p = Dynamic x (PatchTarget p) p
748−
749−data Dynamic x target p = Dynamic
750− { dynamicCurrent :: !(Behavior x target)
639+data Dynamic x p = Dynamic
640+ { dynamicCurrent :: !(Behavior x (PatchTarget p))
751641 , dynamicUpdated :: Event x p -- This must be lazy; see the comment on holdEvent --TODO: Would this let us eliminate `Dyn`?
752642 }
753643
754−deriving instance (HasSpiderTimeline x) => Functor (Dynamic x target)
755−
756−
757−
758−
759−dynamicHold :: Hold x p -> DynamicS x p
644+dynamicHold :: Hold x p -> Dynamic x p
760645dynamicHold !h = Dynamic
761646 { dynamicCurrent = behaviorHold h
762647 , dynamicUpdated = eventHold h
763648 }
764649
765−dynamicHoldIdentity :: Hold x (Identity a) -> DynamicS x (Identity a)
650+dynamicHoldIdentity :: Hold x (Identity a) -> Dynamic x (Identity a)
766651dynamicHoldIdentity = dynamicHold
767652
768−dynamicConst :: PatchTarget p -> DynamicS x p
653+dynamicConst :: PatchTarget p -> Dynamic x p
769654dynamicConst !a = Dynamic
770655 { dynamicCurrent = behaviorConst a
771656 , dynamicUpdated = eventNever
772657 }
773658
774−dynamicDyn :: (HasSpiderTimeline x, Patch p) => Dyn x p -> DynamicS x p
659+dynamicDyn :: (HasSpiderTimeline x, Patch p) => Dyn x p -> Dynamic x p
775660dynamicDyn !d = Dynamic
776661 { dynamicCurrent = behaviorDyn d
777662 , dynamicUpdated = eventDyn d
778663 }
779664
780−dynamicDynIdentity :: HasSpiderTimeline x => Dyn x (Identity a) -> DynamicS x (Identity a)
665+dynamicDynIdentity :: HasSpiderTimeline x => Dyn x (Identity a) -> Dynamic x (Identity a)
781666dynamicDynIdentity = dynamicDyn
782667
783668--------------------------------------------------------------------------------
784669-- Combinators
785670--------------------------------------------------------------------------------
786671
672+--TODO: Figure out why certain things are not 'representational', then make them
673+--representational so we can use coerce
674+
787675--type role Hold representational
788676data Hold x p
789677 = Hold { holdValue :: !(IORef (PatchTarget p))
@@ -804,25 +692,20 @@ globalSpiderTimelineEnv = unsafePerformIO unsafeNewSpiderTimelineEnv
804692
805693-- | Stores all global data relevant to a particular Spider timeline; only one
806694-- value should exist for each type @x@
807−newtype SpiderTimelineEnv x = STE {unSTE :: SpiderTimelineEnv' x}
808−-- We implement SpiderTimelineEnv with a newtype wrapper so
809−-- we can get the coercions we want safely.
810−type role SpiderTimelineEnv nominal
811−
812−data SpiderTimelineEnv' x = SpiderTimelineEnv
695+data SpiderTimelineEnv x = SpiderTimelineEnv
813696 { _spiderTimeline_lock :: {-# UNPACK #-} !(MVar ())
814697 , _spiderTimeline_eventEnv :: {-# UNPACK #-} !(EventEnv x)
815698#ifdef DEBUG
816699 , _spiderTimeline_depth :: {-# UNPACK #-} !(IORef Int)
817700#endif
818701 }
819−type role SpiderTimelineEnv' phantom
702+type role SpiderTimelineEnv nominal
820703
821704instance Eq (SpiderTimelineEnv x) where
822705 _ == _ = True -- Since only one exists of each type
823706
824707instance GEq SpiderTimelineEnv where
825− a `geq` b = if _spiderTimeline_lock (unSTE a) == _spiderTimeline_lock (unSTE b)
708+ a `geq` b = if _spiderTimeline_lock a == _spiderTimeline_lock b
826709 then Just $ unsafeCoerce Refl -- This unsafeCoerce is safe because the same SpiderTimelineEnv can't have two different 'x' arguments
827710 else Nothing
828711
@@ -845,7 +728,7 @@ runEventM :: EventM x a -> IO a
845728runEventM = unEventM
846729
847730asksEventEnv :: forall x a. HasSpiderTimeline x => (EventEnv x -> a) -> EventM x a
848−asksEventEnv f = return $ f $ _spiderTimeline_eventEnv (unSTE (spiderTimeline :: SpiderTimelineEnv x))
731+asksEventEnv f = return $ f $ _spiderTimeline_eventEnv (spiderTimeline :: SpiderTimelineEnv x)
849732
850733class MonadIO m => Defer a m where
851734 getDeferralQueue :: m (IORef [a])
@@ -983,9 +866,9 @@ getHoldEventSubscription h = do
983866
984867type BehaviorEnv x = (Maybe (Weak (Invalidator x), IORef [SomeBehaviorSubscribed x]), IORef [SomeHoldInit x])
985868
869+--type role BehaviorM representational
986870-- BehaviorM can sample behaviors
987−newtype BehaviorM x a = BehaviorM { unBehaviorM :: ReaderIO (BehaviorEnv x) a }
988− deriving (Functor, Applicative, MonadIO, MonadFix, MonadReader (BehaviorEnv x))
871+newtype BehaviorM x a = BehaviorM { unBehaviorM :: ReaderT (BehaviorEnv x) IO a } deriving (Functor, Applicative, MonadIO, MonadFix)
989872
990873instance Monad (BehaviorM x) where
991874 {-# INLINE (>>=) #-}
@@ -994,10 +877,8 @@ instance Monad (BehaviorM x) where
994877 BehaviorM x >> BehaviorM y = BehaviorM $ x >> y
995878 {-# INLINE return #-}
996879 return x = BehaviorM $ return x
997−#if !MIN_VERSION_base(4,13,0)
998880 {-# INLINE fail #-}
999881 fail s = BehaviorM $ fail s
1000−#endif
1001882
1002883data BehaviorSubscribed x a
1003884 = forall p. BehaviorSubscribedHold (Hold x p)
@@ -1038,7 +919,7 @@ data RootSubscribed x a = forall k. GCompare k => RootSubscribed
1038919#endif
1039920 }
1040921
1041−data Root x k
922+data Root x (k :: * -> *)
1042923 = Root { rootOccurrence :: !(IORef (DMap k Identity)) -- The currently-firing occurrence of this event
1043924 , rootSubscribed :: !(IORef (DMap k (RootSubscribed x)))
1044925 , rootInit :: !(forall a. k a -> RootTrigger x a -> IO (IO ()))
@@ -1057,7 +938,7 @@ data SomeMergeUpdate x = SomeMergeUpdate
1057938newtype SomeMergeInit x = SomeMergeInit { unSomeMergeInit :: EventM x () }
1058939
1059940-- EventM can do everything BehaviorM can, plus create holds
1060−newtype EventM x a = EventM { unEventM :: IO a } deriving (Functor, Applicative, Monad, MonadIO, MonadFix, MonadException, MonadAsyncException)
941+newtype EventM x a = EventM { unEventM :: IO a } deriving (Functor, Applicative, Monad, MonadIO, MonadFix, MonadException, MonadAsyncException)
1061942
1062943newtype MergeSubscribedParent x a = MergeSubscribedParent { unMergeSubscribedParent :: EventSubscription x }
1063944
@@ -1082,8 +963,7 @@ heightBagFromList :: [Height] -> HeightBag
1082963heightBagFromList heights = heightBagVerify $ foldl' (flip heightBagAdd) heightBagEmpty heights
1083964
1084965heightBagAdd :: Height -> HeightBag -> HeightBag
1085−heightBagAdd (Height h) (HeightBag s c) = heightBagVerify $ HeightBag (succ s) $
1086− IntMap.insertWithKey (\_ _ old -> succ old) h 0 c
966+heightBagAdd (Height h) (HeightBag s c) = heightBagVerify $ HeightBag (succ s) $ IntMap.insertWithKey (\_ _ old -> succ old) h 0 c
1087967
1088968heightBagRemove :: Height -> HeightBag -> HeightBag
1089969heightBagRemove (Height h) b@(HeightBag s c) = heightBagVerify $ case IntMap.lookup h c of
@@ -1092,13 +972,6 @@ heightBagRemove (Height h) b@(HeightBag s c) = heightBagVerify $ case IntMap.loo
1092972 0 -> IntMap.delete h c
1093973 _ -> IntMap.insert h (pred old) c
1094974
1095−heightBagRemoveMaybe :: Height -> HeightBag -> Maybe HeightBag
1096−heightBagRemoveMaybe (Height h) b@(HeightBag s c) = heightBagVerify . removed <$> IntMap.lookup h c where
1097− removed old = HeightBag (pred s) $ case old of
1098− 0 -> IntMap.delete h c
1099− _ -> IntMap.insert h (pred old) c
1100−
1101−
1102975heightBagMax :: HeightBag -> Height
1103976heightBagMax (HeightBag _ c) = case IntMap.maxViewWithKey c of
1104977 Just ((h, _), _) -> Height h
@@ -1116,25 +989,25 @@ heightBagVerify b@(HeightBag s c) = if
1116989heightBagVerify = id
1117990#endif
1118991
1119−data FanSubscribedChildren x k v a = FanSubscribedChildren
1120− { _fanSubscribedChildren_list :: !(WeakBag (Subscriber x (v a)))
1121− , _fanSubscribedChildren_self :: {-# NOUNPACK #-} !(k a, FanSubscribed x k v)
1122− , _fanSubscribedChildren_weakSelf :: !(IORef (Weak (k a, FanSubscribed x k v)))
992+data FanSubscribedChildren (x :: *) k a = FanSubscribedChildren
993+ { _fanSubscribedChildren_list :: !(WeakBag (Subscriber x a))
994+ , _fanSubscribedChildren_self :: {-# NOUNPACK #-} !(k a, FanSubscribed x k)
995+ , _fanSubscribedChildren_weakSelf :: !(IORef (Weak (k a, FanSubscribed x k)))
1123996 }
1124997
1125−data FanSubscribed x k v
1126− = FanSubscribed { fanSubscribedCachedSubscribed :: !(IORef (Maybe (FanSubscribed x k v)))
1127− , fanSubscribedOccurrence :: !(IORef (Maybe (DMap k v)))
1128− , fanSubscribedSubscribers :: !(IORef (DMap k (FanSubscribedChildren x k v))) -- This DMap should never be empty
998+data FanSubscribed (x :: *) k
999+ = FanSubscribed { fanSubscribedCachedSubscribed :: !(IORef (Maybe (FanSubscribed x k)))
1000+ , fanSubscribedOccurrence :: !(IORef (Maybe (DMap k Identity)))
1001+ , fanSubscribedSubscribers :: !(IORef (DMap k (FanSubscribedChildren x k))) -- This DMap should never be empty
11291002 , fanSubscribedParent :: !(EventSubscription x)
11301003#ifdef DEBUG_NODEIDS
11311004 , fanSubscribedNodeId :: Int
11321005#endif
11331006 }
11341007
1135−data Fan x k v
1136− = Fan { fanParent :: !(Event x (DMap k v))
1137− , fanSubscribed :: !(IORef (Maybe (FanSubscribed x k v)))
1008+data Fan x k
1009+ = Fan { fanParent :: !(Event x (DMap k Identity))
1010+ , fanSubscribed :: !(IORef (Maybe (FanSubscribed x k)))
11381011 }
11391012
11401013data SwitchSubscribed x a
@@ -1196,27 +1069,19 @@ instance HasSpiderTimeline x => Align (Event x) where
11961069#if MIN_VERSION_these(0, 8, 0)
11971070instance HasSpiderTimeline x => Semialign (Event x) where
11981071#endif
1199− align ea eb = mapMaybe dmapToThese $ mergeG coerce $ dynamicConst $
1200− DMap.fromDistinctAscList [LeftTag :=> ea, RightTag :=> eb]
1201−
1202−#ifdef MIN_VERSION_semialign
1203−#if MIN_VERSION_semialign(1,1,0)
1204−instance HasSpiderTimeline x => Zip (Event x) where
1205−#endif
1206− zip x y = mapMaybe justThese $ align x y
1207−#endif
1072+ align ea eb = mapMaybe dmapToThese $ merge $ dynamicConst $ DMap.fromDistinctAscList [LeftTag :=> ea, RightTag :=> eb]
12081073
12091074data DynType x p = UnsafeDyn !(BehaviorM x (PatchTarget p), Event x p)
12101075 | BuildDyn !(EventM x (PatchTarget p), Event x p)
12111076 | HoldDyn !(Hold x p)
12121077
1213−newtype Dyn (x :: Type) p = Dyn { unDyn :: IORef (DynType x p) }
1078+newtype Dyn x p = Dyn { unDyn :: IORef (DynType x p) }
12141079
1215−newMapDyn :: HasSpiderTimeline x => (a -> b) -> DynamicS x (Identity a) -> DynamicS x (Identity b)
1080+newMapDyn :: HasSpiderTimeline x => (a -> b) -> Dynamic x (Identity a) -> Dynamic x (Identity b)
12161081newMapDyn f d = dynamicDynIdentity $ unsafeBuildDynamic (fmap f $ readBehaviorTracked $ dynamicCurrent d) (Identity . f . runIdentity <$> dynamicUpdated d)
12171082
12181083--TODO: Avoid the duplication between this and R.zipDynWith
1219−zipDynWith :: HasSpiderTimeline x => (a -> b -> c) -> DynamicS x (Identity a) -> DynamicS x (Identity b) -> DynamicS x (Identity c)
1084+zipDynWith :: HasSpiderTimeline x => (a -> b -> c) -> Dynamic x (Identity a) -> Dynamic x (Identity b) -> Dynamic x (Identity c)
12201085zipDynWith f da db =
12211086 let eab = align (dynamicUpdated da) (dynamicUpdated db)
12221087 ec = flip push eab $ \o -> do
@@ -1239,12 +1104,18 @@ buildDynamic readV0 v' = do
12391104 return d
12401105
12411106unsafeBuildDynamic :: BehaviorM x (PatchTarget p) -> Event x p -> Dyn x p
1242−unsafeBuildDynamic readV0 v' =
1243− Dyn $ unsafePerformIO $ newIORef $ UnsafeDyn (readV0, v')
1107+unsafeBuildDynamic readV0 v' = Dyn $ unsafeNewIORef x $ UnsafeDyn x
1108+ where x = (readV0, v')
12441109
12451110-- ResultM can read behaviors and events
12461111type ResultM = EventM
12471112
1113+{-# NOINLINE unsafeNewIORef #-}
1114+unsafeNewIORef :: a -> b -> IORef b
1115+unsafeNewIORef a b = unsafePerformIO $ do
1116+ touch a
1117+ newIORef b
1118+
12481119instance HasSpiderTimeline x => Functor (Event x) where
12491120 fmap f = push $ return . Just . f
12501121
@@ -1257,42 +1128,33 @@ push f e = cacheEvent (pushCheap f e)
12571128
12581129{-# INLINABLE pull #-}
12591130pull :: BehaviorM x a -> Behavior x a
1260−pull a = unsafePerformIO $ do
1261− ref <- newIORef Nothing
1262−#ifdef DEBUG_NODEIDS
1263− nid <- newNodeId
1264−#endif
1265− pure $ behaviorPull $ Pull
1266− { pullCompute = a
1267− , pullValue = ref
1131+pull a = behaviorPull $ Pull
1132+ { pullCompute = a
1133+ , pullValue = unsafeNewIORef a Nothing
12681134#ifdef DEBUG_NODEIDS
1269− , pullNodeId = nid
1135+ , pullNodeId = unsafeNodeId a
12701136#endif
1271− }
1137+ }
12721138
12731139{-# INLINABLE switch #-}
12741140switch :: HasSpiderTimeline x => Behavior x (Event x a) -> Event x a
1275−switch a = unsafePerformIO $ do
1276− ref <- newIORef Nothing
1277− pure $ eventSwitch $ Switch
1278− { switchParent = a
1279− , switchSubscribed = ref
1280− }
1141+switch a = eventSwitch $ Switch
1142+ { switchParent = a
1143+ , switchSubscribed = unsafeNewIORef a Nothing
1144+ }
12811145
12821146coincidence :: HasSpiderTimeline x => Event x (Event x a) -> Event x a
1283−coincidence a = unsafePerformIO $ do
1284− ref <- newIORef Nothing
1285− pure $ eventCoincidence $ Coincidence
1286− { coincidenceParent = a
1287− , coincidenceSubscribed = ref
1288− }
1147+coincidence a = eventCoincidence $ Coincidence
1148+ { coincidenceParent = a
1149+ , coincidenceSubscribed = unsafeNewIORef a Nothing
1150+ }
12891151
12901152-- Propagate the given event occurrence; before cleaning up, run the given action, which may read the state of events and behaviors
12911153run :: forall x b. HasSpiderTimeline x => [DSum (RootTrigger x) Identity] -> ResultM x b -> SpiderHost x b
12921154run roots after = do
12931155 tracePropagate (Proxy :: Proxy x) $ "Running an event frame with " <> show (length roots) <> " events"
12941156 let t = spiderTimeline :: SpiderTimelineEnv x
1295− result <- SpiderHost $ withMVar (_spiderTimeline_lock (unSTE t)) $ \_ -> unSpiderHost $ runFrame $ do
1157+ result <- SpiderHost $ withMVar (_spiderTimeline_lock t) $ \_ -> unSpiderHost $ runFrame $ do
12961158 rootsToPropagate <- forM roots $ \r@(RootTrigger (_, occRef, k) :=> a) -> do
12971159 occBefore <- liftIO $ do
12981160 occBefore <- readIORef occRef
@@ -1346,7 +1208,7 @@ mkWeakPtrWithDebug x debugNote = do
13461208 x' <- evaluate x
13471209 mkWeakPtr x' $
13481210 if debugFinalize
1349− then Just $ debugStrLn $ "finalizing: " ++ debugNote
1211+ then Just $ putStrLn $ "finalizing: " ++ debugNote
13501212 else Nothing
13511213
13521214type WeakList a = [Weak a]
@@ -1359,44 +1221,37 @@ type CanTrace x m = (HasSpiderTimeline x, MonadIO m)
13591221#ifdef DEBUG
13601222
13611223debugSubscriber :: forall x a. HasSpiderTimeline x => String -> Subscriber x a -> IO (Subscriber x a)
1362−debugSubscriber description = return . debugSubscriber' description
1363−
1364−debugSubscriber' :: forall x a. HasSpiderTimeline x => String -> Subscriber x a -> Subscriber x a
1365−debugSubscriber' description subscribed = Subscriber
1224+debugSubscriber description subscribed = return $ Subscriber
13661225 {
13671226 subscriberPropagate = \m -> do
13681227 tracePropagate (Proxy :: Proxy x) ("subscriberPropagate: " <> description)
13691228 subscriberPropagate subscribed m
13701229 , subscriberInvalidateHeight = \old -> do
1371− traceInvalidateHeight $ "invalidateSubscriberHeight: " <> description <> ", old = " <> show (unHeight old)
1230+ putStrLn $ "invalidateSubscriberHeight: " <> description
13721231 subscriberInvalidateHeight subscribed old
1373− traceInvalidateHeight $ "invalidateSubscriberHeight: " <> description <> ", done"
1232+ putStrLn $ "invalidateSubscriberHeight: " <> description <> ", done"
13741233 , subscriberRecalculateHeight = \new -> do
1375− traceInvalidateHeight $ "subscriberRecalculateHeight: " <> description <> ", new = " <> show (unHeight new)
1234+ putStrLn $ "subscriberRecalculateHeight: " <> description
13761235 subscriberRecalculateHeight subscribed new
1377− traceInvalidateHeight $ "subscriberRecalculateHeight: " <> description <> ", done"
1236+ putStrLn $ "subscriberRecalculateHeight: " <> description <> ", done"
13781237 }
13791238
13801239
13811240{-# INLINE withIncreasedDepth #-}
13821241withIncreasedDepth :: forall proxy x m a. CanTrace x m => proxy x -> m a -> m a
13831242withIncreasedDepth _ a = do
1384− liftIO $ modifyIORef' (_spiderTimeline_depth $ unSTE (spiderTimeline :: SpiderTimelineEnv x)) succ
1243+ liftIO $ modifyIORef' (_spiderTimeline_depth (spiderTimeline :: SpiderTimelineEnv x)) succ
13851244 result <- a
1386− liftIO $ modifyIORef' (_spiderTimeline_depth $ unSTE (spiderTimeline :: SpiderTimelineEnv x)) pred
1245+ liftIO $ modifyIORef' (_spiderTimeline_depth (spiderTimeline :: SpiderTimelineEnv x)) pred
13871246 return result
13881247
13891248{-# INLINE tracePropagate #-}
13901249tracePropagate :: (CanTrace x m) => proxy x -> String -> m ()
1391−tracePropagate p = when debugPropagate . trace p
1250+tracePropagate p = trace p
13921251
13931252{-# INLINE traceInvalidate #-}
13941253traceInvalidate :: String -> IO ()
1395−traceInvalidate = when debugInvalidate . liftIO . debugStrLn
1396−
1397−{-# INLINE traceInvalidateHeight #-}
1398−traceInvalidateHeight :: String -> IO ()
1399−traceInvalidateHeight = when debugInvalidateHeight . liftIO . debugStrLn
1254+traceInvalidate = liftIO . putStrLn
14001255
14011256{-# INLINE trace #-}
14021257trace :: (CanTrace x m) => proxy x -> String -> m ()
@@ -1406,13 +1261,13 @@ trace p message = traceM p $ return message
14061261traceM :: forall x proxy m. (CanTrace x m) => proxy x -> m String -> m ()
14071262traceM _ getMessage = do
14081263 message <- getMessage
1409− d <- liftIO $ readIORef $ _spiderTimeline_depth $ unSTE (spiderTimeline :: SpiderTimelineEnv x)
1410− liftIO $ debugStrLn $ replicate d ' ' <> message
1264+ d <- liftIO $ readIORef $ _spiderTimeline_depth (spiderTimeline :: SpiderTimelineEnv x)
1265+ liftIO $ putStrLn $ replicate d ' ' <> message
14111266
14121267#else
14131268
14141269{-# INLINE withIncreasedDepth #-}
1415−withIncreasedDepth :: proxy x -> m a -> m a
1270+withIncreasedDepth :: forall x m proxy a. HasSpiderTimeline x => proxy x -> m a -> m a
14161271withIncreasedDepth _ = id
14171272
14181273{-# INLINE tracePropagate #-}
@@ -1423,20 +1278,10 @@ tracePropagate _ _ = return ()
14231278traceInvalidate :: String -> IO ()
14241279traceInvalidate _ = return ()
14251280
1426−{-# INLINE traceInvalidateHeight #-}
1427−traceInvalidateHeight :: String -> IO ()
1428−traceInvalidateHeight _ = return ()
1429−
14301281{-# INLINE debugSubscriber #-}
1431−debugSubscriber :: String -> Subscriber x a -> IO (Subscriber x a)
1282+debugSubscriber :: HasSpiderTimeline x => String -> Subscriber x a -> IO (Subscriber x a)
14321283debugSubscriber _ = return
14331284
1434−{-# INLINE debugSubscriber' #-}
1435−debugSubscriber' :: String -> Subscriber x a -> Subscriber x a
1436−debugSubscriber' _ = id
1437−
1438−
1439−
14401285{-# INLINE trace #-}
14411286trace :: (CanTrace x m) => proxy x -> String -> m ()
14421287trace _ _ = return ()
@@ -1447,9 +1292,13 @@ traceM _ _ = return ()
14471292
14481293#endif
14491294
1295+
1296+
1297+
14501298whoCreatedIORef :: IORef a -> IO [String]
14511299whoCreatedIORef (IORef a) = whoCreated $! a
14521300
1301+#ifdef DEBUG_CYCLES
14531302groupByHead :: Eq a => [NonEmpty a] -> [(a, NonEmpty [a])]
14541303groupByHead = \case
14551304 [] -> []
@@ -1460,45 +1309,13 @@ groupByHead = \case
14601309 | otherwise -> (x, xs :| []) : l
14611310
14621311listsToForest :: Eq a => [[a]] -> Forest a
1463−listsToForest lists = buildForest <$> groupByHead (mapMaybe nonEmpty lists)
1464− where buildForest (a, lists') = Node a $ listsToForest $ toList lists'
1465−
1466−showStacks :: [[String]] -> String
1467−showStacks = drawForest . listsToForest . fmap (filterStack "Reflex.Spider.Internal")
1468−
1469−filterStack :: String -> [String] -> [String]
1470−#ifdef DEBUG_HIDE_INTERNALS
1471−filterStack prefix = filter (not . (prefix `isPrefixOf`))
1472−#else
1473−filterStack prefix = id
1312+listsToForest l = fmap (\(a, l') -> Node a $ listsToForest $ toList l') $ groupByHead $ catMaybes $ fmap nonEmpty l
14741313#endif
14751314
1476−#ifdef DEBUG_CYCLES
1477−
1478−data EventLoopException = EventLoopException [[String]]
1479−instance Exception EventLoopException
1480−
1481−instance Show EventLoopException where
1482− show (EventLoopException stacks) = "causality loop detected:\n" <> if null stacks
1483− then "no location information, compile with profiling enabled for stack tree"
1484− else showStacks stacks
1485−
1486−#else
1487−
1488−data EventLoopException = EventLoopException
1489−instance Exception EventLoopException
1490−
1491−instance Show EventLoopException where
1492− show EventLoopException = "causality loop detected: \n" <>
1493− "compile reflex with flag 'debug-cycles' and compile with profiling enabled for stack tree"
1494−
1495−#endif
1496−
1497−
14981315{-# INLINE propagateSubscriberHold #-}
14991316propagateSubscriberHold :: forall x p. (HasSpiderTimeline x, Patch p) => Hold x p -> p -> EventM x ()
15001317propagateSubscriberHold h a = do
1501− {-# SCC "trace" #-} when debugPropagate $ traceM (Proxy :: Proxy x) $ liftIO $ do
1318+ traceM (Proxy :: Proxy x) $ liftIO $ do
15021319 invalidators <- liftIO $ readIORef $ holdInvalidators h
15031320 return $ "SubscriberHold" <> showNodeId h <> ": " ++ show (length invalidators)
15041321
@@ -1506,7 +1323,7 @@ propagateSubscriberHold h a = do
15061323 case {-# SCC "apply" #-} apply a v of
15071324 Nothing -> return ()
15081325 Just v' -> do
1509− {-# SCC "trace2" #-} withIncreasedDepth (Proxy :: Proxy x) $
1326+ withIncreasedDepth (Proxy :: Proxy x) $
15101327 tracePropagate (Proxy :: Proxy x) ("propagateSubscriberHold: assigning Hold" <> showNodeId h)
15111328 vRef <- {-# SCC "vRef" #-} liftIO $ evaluate $ holdValue h
15121329 iRef <- {-# SCC "iRef" #-} liftIO $ evaluate $ holdInvalidators h
@@ -1515,25 +1332,25 @@ propagateSubscriberHold h a = do
15151332data SomeResetCoincidence x = forall a. SomeResetCoincidence !(EventSubscription x) !(Maybe (CoincidenceSubscribed x a)) -- The CoincidenceSubscriber will be present only if heights need to be reset
15161333
15171334runBehaviorM :: BehaviorM x a -> Maybe (Weak (Invalidator x), IORef [SomeBehaviorSubscribed x]) -> IORef [SomeHoldInit x] -> IO a
1518−runBehaviorM a mwi holdInits = runReaderIO (unBehaviorM a) (mwi, holdInits)
1335+runBehaviorM a mwi holdInits = runReaderT (unBehaviorM a) (mwi, holdInits)
15191336
15201337askInvalidator :: BehaviorM x (Maybe (Weak (Invalidator x)))
15211338askInvalidator = do
1522− (!m, _) <- ask
1339+ (!m, _) <- BehaviorM ask
15231340 case m of
15241341 Nothing -> return Nothing
15251342 Just (!wi, _) -> return $ Just wi
15261343
15271344askParentsRef :: BehaviorM x (Maybe (IORef [SomeBehaviorSubscribed x]))
15281345askParentsRef = do
1529− (!m, _) <- ask
1346+ (!m, _) <- BehaviorM ask
15301347 case m of
15311348 Nothing -> return Nothing
15321349 Just (_, !p) -> return $ Just p
15331350
15341351askBehaviorHoldInits :: BehaviorM x (IORef [SomeHoldInit x])
15351352askBehaviorHoldInits = do
1536− (_, !his) <- ask
1353+ (_, !his) <- BehaviorM ask
15371354 return his
15381355
15391356{-# INLINE getDynHold #-}
@@ -1580,9 +1397,6 @@ getRootSubscribed k r sub = do
15801397
15811398 uninit <- rootInit r k $ RootTrigger (subs, rootOccurrence r, k)
15821399 writeIORef uninitRef $! uninit
1583−#ifdef DEBUG_NODEIDS
1584− nid <- newNodeId
1585−#endif
15861400 let !subscribed = RootSubscribed
15871401 { rootSubscribedKey = k
15881402 , rootSubscribedCachedSubscribed = cached
@@ -1591,7 +1405,7 @@ getRootSubscribed k r sub = do
15911405 , rootSubscribedUninit = uninit
15921406 , rootSubscribedWeakSelf = weakSelf
15931407#ifdef DEBUG_NODEIDS
1594− , rootSubscribedNodeId = nid
1408+ , rootSubscribedNodeId = unsafeNodeId (k, r, subs)
15951409#endif
15961410 }
15971411 -- If we die at the same moment that all our children die, they will
@@ -1627,9 +1441,6 @@ data FanInt x a = FanInt
16271441 { _fanInt_subscribers :: {-# UNPACK #-} !(FastMutableIntMap (FastWeakBag (Subscriber x a))) --TODO: Clean up the keys in here when their child weak bags get empty --TODO: Remove our own subscription when the subscribers list is completely empty
16281442 , _fanInt_subscriptionRef :: {-# UNPACK #-} !(IORef (EventSubscription x)) -- This should have a valid subscription iff subscribers is non-empty
16291443 , _fanInt_occRef :: {-# UNPACK #-} !(IORef (IntMap a))
1630−#ifdef DEBUG_NODEIDS
1631− , _fanInt_nodeId :: {-# UNPACK #-} !Int
1632−#endif
16331444 }
16341445
16351446newFanInt :: IO (FanInt x a)
@@ -1637,39 +1448,38 @@ newFanInt = do
16371448 subscribers <- FastMutableIntMap.newEmpty --TODO: Clean up the keys in here when their child weak bags get empty --TODO: Remove our own subscription when the subscribers list is completely empty
16381449 subscriptionRef <- newIORef $ error "fanInt: no subscription"
16391450 occRef <- newIORef $ error "fanInt: no occurrence"
1640−#ifdef DEBUG_NODEIDS
1641− nodeId <- newNodeId
1642−#endif
16431451 return $ FanInt
16441452 { _fanInt_subscribers = subscribers
16451453 , _fanInt_subscriptionRef = subscriptionRef
16461454 , _fanInt_occRef = occRef
1647−#ifdef DEBUG_NODEIDS
1648− , _fanInt_nodeId = nodeId
1649−#endif
16501455 }
16511456
1457+{-# NOINLINE unsafeNewFanInt #-}
1458+unsafeNewFanInt :: b -> FanInt x a
1459+unsafeNewFanInt b = unsafePerformIO $ do
1460+ touch b
1461+ newFanInt
1462+
16521463fanInt :: HasSpiderTimeline x => Event x (IntMap a) -> EventSelectorInt x a
1653−fanInt p = unsafePerformIO $ do
1654− self <- newFanInt
1655− pure $ EventSelectorInt $ \k -> Event $ \sub -> do
1464+fanInt p =
1465+ let self = unsafeNewFanInt p
1466+ in EventSelectorInt $ \k -> Event $ \sub -> do
16561467 isEmpty <- liftIO $ FastMutableIntMap.isEmpty (_fanInt_subscribers self)
16571468 when isEmpty $ do -- This is the first subscriber, so we need to subscribe to our input
1658− let desc = "fanInt" <> showNodeId self <> ", k = " <> show k
1659− (subscription, parentOcc) <- subscribeAndRead p $ debugSubscriber' desc $ Subscriber
1469+ (subscription, parentOcc) <- subscribeAndRead p $ Subscriber
16601470 { subscriberPropagate = \m -> do
16611471 liftIO $ writeIORef (_fanInt_occRef self) m
16621472 scheduleIntClear $ _fanInt_occRef self
1663− FastMutableIntMap.forIntersectionWithImmutable_ (_fanInt_subscribers self) m $ \b v -> --TODO: Do we need to know that no subscribers are being added as we traverse?
1664− FastWeakBag.traverse_ b $ \s ->
1473+ FastMutableIntMap.forIntersectionWithImmutable_ (_fanInt_subscribers self) m $ \b v -> do --TODO: Do we need to know that no subscribers are being added as we traverse?
1474+ FastWeakBag.traverse b $ \s -> do
16651475 subscriberPropagate s v
1666− , subscriberInvalidateHeight = \old ->
1667− FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b ->
1668− FastWeakBag.traverse_ b $ \s ->
1476+ , subscriberInvalidateHeight = \old -> do
1477+ FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b -> do
1478+ FastWeakBag.traverse b $ \s -> do
16691479 subscriberInvalidateHeight s old
1670− , subscriberRecalculateHeight = \new ->
1671− FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b ->
1672− FastWeakBag.traverse_ b $ \s ->
1480+ , subscriberRecalculateHeight = \new -> do
1481+ FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b -> do
1482+ FastWeakBag.traverse b $ \s -> do
16731483 subscriberRecalculateHeight s new
16741484 }
16751485 liftIO $ do
@@ -1683,28 +1493,13 @@ fanInt p = unsafePerformIO $ do
16831493 FastMutableIntMap.insert (_fanInt_subscribers self) k b
16841494 return b
16851495 Just b -> return b
1686− ticket <- liftIO $ FastWeakBag.insert sub b
1496+ t <- liftIO $ FastWeakBag.insert sub b
16871497 currentOcc <- readIORef (_fanInt_occRef self)
1688−
1689− subscribed <- fanIntSubscribed ticket self
1690− return (EventSubscription (FastWeakBag.remove ticket) subscribed, IntMap.lookup k currentOcc)
1691−
1692−fanIntSubscribed :: FastWeakBagTicket k -> FanInt x a -> IO (EventSubscribed x)
1693−fanIntSubscribed ticket self = do
1694− subscribedParent <- _eventSubscription_subscribed <$> readIORef (_fanInt_subscriptionRef self)
1695− return $ EventSubscribed
1696− { eventSubscribedHeightRef = eventSubscribedHeightRef subscribedParent
1697− , eventSubscribedRetained = toAny (_fanInt_subscriptionRef self, ticket)
1698−#ifdef DEBUG_CYCLES
1699− , eventSubscribedGetParents = return [subscribedParent]
1700− , eventSubscribedHasOwnHeightRef = False
1701− , eventSubscribedWhoCreated = whoCreatedIORef $ _fanInt_subscriptionRef self
1702−#endif
1703− }
1704−
1498+ (EventSubscription _ (EventSubscribed !heightRef _)) <- readIORef (_fanInt_subscriptionRef self)
1499+ return (EventSubscription (FastWeakBag.remove t) $! EventSubscribed heightRef $! toAny (_fanInt_subscriptionRef self, t), IntMap.lookup k currentOcc)
17051500
17061501{-# INLINABLE getFanSubscribed #-}
1707−getFanSubscribed :: (HasSpiderTimeline x, GCompare k) => k a -> Fan x k v -> Subscriber x (v a) -> EventM x (WeakBagTicket, FanSubscribed x k v, Maybe (v a))
1502+getFanSubscribed :: (HasSpiderTimeline x, GCompare k) => k a -> Fan x k -> Subscriber x a -> EventM x (WeakBagTicket, FanSubscribed x k, Maybe a)
17081503getFanSubscribed k f sub = do
17091504 mSubscribed <- liftIO $ readIORef $ fanSubscribed f
17101505 case mSubscribed of
@@ -1722,16 +1517,13 @@ getFanSubscribed k f sub = do
17221517 subscribersRef <- liftIO $ newIORef $ error "getFanSubscribed: subscribersRef not yet initialized"
17231518 occRef <- liftIO $ newIORef parentOcc
17241519 when (isJust parentOcc) $ scheduleClear occRef
1725−#ifdef DEBUG_NODEIDS
1726− nid <- liftIO newNodeId
1727−#endif
17281520 let subscribed = FanSubscribed
17291521 { fanSubscribedCachedSubscribed = fanSubscribed f
17301522 , fanSubscribedOccurrence = occRef
17311523 , fanSubscribedParent = subscription
17321524 , fanSubscribedSubscribers = subscribersRef
17331525#ifdef DEBUG_NODEIDS
1734− , fanSubscribedNodeId = nid
1526+ , fanSubscribedNodeId = unsafeNodeId f
17351527#endif
17361528 }
17371529 let !self = (k, subscribed)
@@ -1741,7 +1533,7 @@ getFanSubscribed k f sub = do
17411533 liftIO $ writeIORef (fanSubscribed f) $ Just subscribed
17421534 return (slnForSub, subscribed, coerce $ DMap.lookup k =<< parentOcc)
17431535
1744−cleanupFanSubscribed :: GCompare k => (k a, FanSubscribed x k v) -> IO ()
1536+cleanupFanSubscribed :: GCompare k => (k a, FanSubscribed x k) -> IO ()
17451537cleanupFanSubscribed (k, subscribed) = do
17461538 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
17471539 let reducedSubscribers = DMap.delete k subscribers
@@ -1753,7 +1545,7 @@ cleanupFanSubscribed (k, subscribed) = do
17531545 else writeIORef (fanSubscribedSubscribers subscribed) $! reducedSubscribers
17541546
17551547{-# INLINE subscribeFanSubscribed #-}
1756−subscribeFanSubscribed :: GCompare k => k a -> FanSubscribed x k v -> Subscriber x (v a) -> IO WeakBagTicket
1548+subscribeFanSubscribed :: GCompare k => k a -> FanSubscribed x k -> Subscriber x a -> IO WeakBagTicket
17571549subscribeFanSubscribed k subscribed sub = do
17581550 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
17591551 case DMap.lookup k subscribers of
@@ -1791,9 +1583,6 @@ getSwitchSubscribed s sub = do
17911583 when (isJust parentOcc) $ scheduleClear occRef
17921584 weakSelf <- liftIO $ newIORef $ error "getSwitchSubscribed: weakSelf not yet initialized"
17931585 (subs, slnForSub) <- liftIO $ WeakBag.singleton sub weakSelf cleanupSwitchSubscribed
1794−#ifdef DEBUG_NODEIDS
1795− nid <- liftIO newNodeId
1796−#endif
17971586 let !subscribed = SwitchSubscribed
17981587 { switchSubscribedCachedSubscribed = switchSubscribed s
17991588 , switchSubscribedOccurrence = occRef
@@ -1806,7 +1595,7 @@ getSwitchSubscribed s sub = do
18061595 , switchSubscribedCurrentParent = subscriptionRef
18071596 , switchSubscribedWeakSelf = weakSelf
18081597#ifdef DEBUG_NODEIDS
1809− , switchSubscribedNodeId = nid
1598+ , switchSubscribedNodeId = unsafeNodeId s
18101599#endif
18111600 }
18121601 liftIO $ writeIORef weakSelf =<< evaluate =<< mkWeakPtrWithDebug subscribed "switchSubscribedWeakSelf"
@@ -1851,9 +1640,6 @@ getCoincidenceSubscribed c sub = do
18511640 scheduleClear innerSubdRef
18521641 weakSelf <- liftIO $ newIORef $ error "getCoincidenceSubscribed: weakSelf not yet implemented"
18531642 (subs, slnForSub) <- liftIO $ WeakBag.singleton sub weakSelf cleanupCoincidenceSubscribed
1854−#ifdef DEBUG_NODEIDS
1855− nid <- liftIO newNodeId
1856−#endif
18571643 let subscribed = CoincidenceSubscribed
18581644 { coincidenceSubscribedCachedSubscribed = coincidenceSubscribed c
18591645 , coincidenceSubscribedOccurrence = occRef
@@ -1864,7 +1650,7 @@ getCoincidenceSubscribed c sub = do
18641650 , coincidenceSubscribedInnerParent = innerSubdRef
18651651 , coincidenceSubscribedWeakSelf = weakSelf
18661652#ifdef DEBUG_NODEIDS
1867− , coincidenceSubscribedNodeId = nid
1653+ , coincidenceSubscribedNodeId = unsafeNodeId c
18681654#endif
18691655 }
18701656 liftIO $ writeIORef weakSelf =<< evaluate =<< mkWeakPtrWithDebug subscribed "CoincidenceSubscribed"
@@ -1881,72 +1667,57 @@ cleanupCoincidenceSubscribed subscribed = do
18811667subscribeCoincidenceSubscribed :: CoincidenceSubscribed x a -> Subscriber x a -> IO WeakBagTicket
18821668subscribeCoincidenceSubscribed subscribed sub = WeakBag.insert sub (coincidenceSubscribedSubscribers subscribed) (coincidenceSubscribedWeakSelf subscribed) cleanupCoincidenceSubscribed
18831669
1884−{-# INLINE mergeG #-}
1885−mergeG :: forall k q x v. (HasSpiderTimeline x, GCompare k)
1886− => (forall a. q a -> Event x (v a))
1887− -> DynamicS x (PatchDMap k q) -> Event x (DMap k v)
1888−mergeG nt d = cacheEvent (mergeCheap nt d)
1670+{-# INLINE merge #-}
1671+merge :: forall k x. (HasSpiderTimeline x, GCompare k) => Dynamic x (PatchDMap k (Event x)) -> Event x (DMap k Identity)
1672+merge d = cacheEvent (mergeCheap d)
18891673
18901674{-# INLINE mergeWithMove #-}
1891−mergeWithMove :: forall k v q x. (HasSpiderTimeline x, GCompare k)
1892− => (forall a. q a -> Event x (v a))
1893− -> DynamicS x (PatchDMapWithMove k q) -> Event x (DMap k v)
1894−mergeWithMove nt d = cacheEvent (mergeCheapWithMove nt d)
1675+mergeWithMove :: forall k x. (HasSpiderTimeline x, GCompare k) => Dynamic x (PatchDMapWithMove k (Event x)) -> Event x (DMap k Identity)
1676+mergeWithMove d = cacheEvent (mergeCheapWithMove d)
18951677
18961678{-# INLINE [1] mergeCheap #-}
1897−mergeCheap
1898− :: forall k x q v. (HasSpiderTimeline x, GCompare k)
1899− => (forall a. q a -> Event x (v a))
1900− -> DynamicS x (PatchDMap k q)
1901− -> Event x (DMap k v)
1902−mergeCheap nt = mergeGCheap' unMergeSubscribedParent getInitialSubscribers updateMe destroy
1679+mergeCheap :: forall k x. (HasSpiderTimeline x, GCompare k) => Dynamic x (PatchDMap k (Event x)) -> Event x (DMap k Identity)
1680+mergeCheap = mergeCheap' getInitialSubscribers updateMe destroy
19031681 where
1904− updateMe :: MergeUpdateFunc k v x (PatchDMap k q) (MergeSubscribedParent x)
1682+ updateMe :: MergeUpdateFunc k x (PatchDMap k (Event x)) (MergeSubscribedParent x)
19051683 updateMe subscriber heightBagRef oldParents (PatchDMap p) = do
19061684 let f (subscriptionsToKill, ps) (k :=> ComposeMaybe me) = do
19071685 (mOldSubd, newPs) <- case me of
19081686 Nothing -> return $ DMap.updateLookupWithKey (\_ _ -> Nothing) k ps
19091687 Just e -> do
19101688 let s = subscriber $ return k
1911− subscription@(EventSubscription _ subd) <- subscribe (nt e) s
1689+ subscription@(EventSubscription _ subd) <- subscribe e s
19121690 newParentHeight <- liftIO $ getEventSubscribedHeight subd
19131691 let newParent = MergeSubscribedParent subscription
19141692 liftIO $ modifyIORef' heightBagRef $ heightBagAdd newParentHeight
19151693 return $ DMap.insertLookupWithKey' (\_ new _ -> new) k newParent ps
19161694 forM_ mOldSubd $ \oldSubd -> do
1917− oldHeight <- liftIO $ getEventSubscribedHeight $
1918− _eventSubscription_subscribed $ unMergeSubscribedParent oldSubd
1919−
1695+ oldHeight <- liftIO $ getEventSubscribedHeight $ _eventSubscription_subscribed $ unMergeSubscribedParent oldSubd
19201696 liftIO $ modifyIORef heightBagRef $ heightBagRemove oldHeight
19211697 return (maybeToList (unMergeSubscribedParent <$> mOldSubd) ++ subscriptionsToKill, newPs)
19221698 foldM f ([], oldParents) $ DMap.toList p
1923−
1924− getInitialSubscribers :: MergeInitFunc k v q x (MergeSubscribedParent x)
1699+ getInitialSubscribers :: MergeInitFunc k x (MergeSubscribedParent x)
19251700 getInitialSubscribers initialParents subscriber = do
19261701 subscribers <- forM (DMap.toList initialParents) $ \(k :=> e) -> do
19271702 let s = subscriber $ return k
1928− (subscription@(EventSubscription _ parentSubd), parentOcc) <- subscribeAndRead (nt e) s
1703+ (subscription@(EventSubscription _ parentSubd), parentOcc) <- subscribeAndRead e s
19291704 height <- liftIO $ getEventSubscribedHeight parentSubd
1930− return (fmap (k :=>) parentOcc, height, k :=> MergeSubscribedParent subscription)
1705+ return (fmap (\x -> k :=> Identity x) parentOcc, height, k :=> MergeSubscribedParent subscription)
19311706 return ( DMap.fromDistinctAscList $ mapMaybe (\(x, _, _) -> x) subscribers
19321707 , fmap (\(_, h, _) -> h) subscribers --TODO: Assert that there's no invalidHeight in here
19331708 , DMap.fromDistinctAscList $ map (\(_, _, x) -> x) subscribers
19341709 )
1935−
19361710 destroy :: MergeDestroyFunc k (MergeSubscribedParent x)
19371711 destroy s = forM_ (DMap.toList s) $ \(_ :=> MergeSubscribedParent sub) -> unsubscribe sub
19381712
19391713{-# INLINE [1] mergeCheapWithMove #-}
1940−mergeCheapWithMove :: forall k x v q. (HasSpiderTimeline x, GCompare k)
1941− => (forall a. q a -> Event x (v a))
1942− -> DynamicS x (PatchDMapWithMove k q)
1943− -> Event x (DMap k v)
1944−mergeCheapWithMove nt = mergeGCheap' _mergeSubscribedParentWithMove_subscription getInitialSubscribers updateMe destroy
1714+mergeCheapWithMove :: forall k x. (HasSpiderTimeline x, GCompare k) => Dynamic x (PatchDMapWithMove k (Event x)) -> Event x (DMap k Identity)
1715+mergeCheapWithMove = mergeCheap' getInitialSubscribers updateMe destroy
19451716 where
1946− updateMe :: MergeUpdateFunc k v x (PatchDMapWithMove k q) (MergeSubscribedParentWithMove x k)
1717+ updateMe :: MergeUpdateFunc k x (PatchDMapWithMove k (Event x)) (MergeSubscribedParentWithMove x k)
19471718 updateMe subscriber heightBagRef oldParents p = do
19481719 -- Prepare new parents for insertion
1949− let subscribeParent :: forall a. k a -> Event x (v a) -> EventM x (MergeSubscribedParentWithMove x k a)
1720+ let subscribeParent :: forall a. k a -> Event x a -> EventM x (MergeSubscribedParentWithMove x k a)
19501721 subscribeParent k e = do
19511722 keyRef <- liftIO $ newIORef k
19521723 let s = subscriber $ liftIO $ readIORef keyRef
@@ -1955,82 +1726,73 @@ mergeCheapWithMove nt = mergeGCheap' _mergeSubscribedParentWithMove_subscription
19551726 newParentHeight <- getEventSubscribedHeight subd
19561727 modifyIORef' heightBagRef $ heightBagAdd newParentHeight
19571728 return $ MergeSubscribedParentWithMove subscription keyRef
1958− p' <- PatchDMapWithMove.traversePatchDMapWithMoveWithKey (\k q -> subscribeParent k (nt q)) p
1729+ p' <- PatchDMapWithMove.traversePatchDMapWithMoveWithKey subscribeParent p
19591730 -- Collect old parents for deletion and update the keys of moved parents
1960− let moveOrDelete :: forall a. k a -> PatchDMapWithMove.NodeInfo k q a -> MergeSubscribedParentWithMove x k a -> Constant (EventM x (Maybe (EventSubscription x))) a
1731+ let moveOrDelete :: forall a. k a -> PatchDMapWithMove.NodeInfo k (Event x) a -> MergeSubscribedParentWithMove x k a -> Constant (EventM x (Maybe (EventSubscription x))) a
19611732 moveOrDelete _ ni parent = Constant $ case getComposeMaybe $ PatchDMapWithMove._nodeInfo_to ni of
19621733 Nothing -> do
1963− oldHeight <- liftIO $ getEventSubscribedHeight $ _eventSubscription_subscribed $
1964− _mergeSubscribedParentWithMove_subscription parent
1965−
1734+ oldHeight <- liftIO $ getEventSubscribedHeight $ _eventSubscription_subscribed $ _mergeSubscribedParentWithMove_subscription parent
19661735 liftIO $ modifyIORef heightBagRef $ heightBagRemove oldHeight
19671736 return $ Just $ _mergeSubscribedParentWithMove_subscription parent
19681737 Just toKey -> do
19691738 liftIO $ writeIORef (_mergeSubscribedParentWithMove_key parent) $! toKey
19701739 return Nothing
1971− toDelete <- fmap catMaybes $ mapM (\(_ :=> v) -> getConstant v) $ DMap.toList $
1972− DMap.intersectionWithKey moveOrDelete (unPatchDMapWithMove p) oldParents
1973−
1740+ toDelete <- fmap catMaybes $ mapM (\(_ :=> v) -> getConstant v) $ DMap.toList $ DMap.intersectionWithKey moveOrDelete (unPatchDMapWithMove p) oldParents
19741741 return (toDelete, applyAlways p' oldParents)
1975− getInitialSubscribers :: MergeInitFunc k v q x (MergeSubscribedParentWithMove x k)
1742+ getInitialSubscribers :: MergeInitFunc k x (MergeSubscribedParentWithMove x k)
19761743 getInitialSubscribers initialParents subscriber = do
19771744 subscribers <- forM (DMap.toList initialParents) $ \(k :=> e) -> do
19781745 keyRef <- liftIO $ newIORef k
19791746 let s = subscriber $ liftIO $ readIORef keyRef
1980− (subscription@(EventSubscription _ parentSubd), parentOcc) <- subscribeAndRead (nt e) s
1747+ (subscription@(EventSubscription _ parentSubd), parentOcc) <- subscribeAndRead e s
19811748 height <- liftIO $ getEventSubscribedHeight parentSubd
1982− return (fmap (k :=>) parentOcc, height, k :=> MergeSubscribedParentWithMove subscription keyRef)
1749+ return (fmap (\x -> k :=> Identity x) parentOcc, height, k :=> MergeSubscribedParentWithMove subscription keyRef)
19831750 return ( DMap.fromDistinctAscList $ mapMaybe (\(x, _, _) -> x) subscribers
19841751 , fmap (\(_, h, _) -> h) subscribers --TODO: Assert that there's no invalidHeight in here
19851752 , DMap.fromDistinctAscList $ map (\(_, _, x) -> x) subscribers
19861753 )
1987−
19881754 destroy :: MergeDestroyFunc k (MergeSubscribedParentWithMove x k)
19891755 destroy s = forM_ (DMap.toList s) $ \(_ :=> MergeSubscribedParentWithMove sub _) -> unsubscribe sub
19901756
1991−type MergeUpdateFunc k v x p s
1992− = (forall a. EventM x (k a) -> Subscriber x (v a))
1757+type MergeUpdateFunc k x p s
1758+ = (forall a. EventM x (k a) -> Subscriber x a)
19931759 -> IORef HeightBag
19941760 -> DMap k s
19951761 -> p
19961762 -> EventM x ([EventSubscription x], DMap k s)
19971763
1998−type MergeGetSubscription x s = forall a. s a -> EventSubscription x
1999−
2000−type MergeInitFunc k v q x s
2001− = DMap k q
2002− -> (forall a. EventM x (k a) -> Subscriber x (v a))
2003− -> EventM x (DMap k v, [Height], DMap k s)
1764+type MergeInitFunc k x s
1765+ = DMap k (Event x)
1766+ -> (forall a. EventM x (k a) -> Subscriber x a)
1767+ -> EventM x (DMap k Identity, [Height], DMap k s)
20041768
20051769type MergeDestroyFunc k s
20061770 = DMap k s
20071771 -> IO ()
20081772
2009−data Merge x k v s = Merge
1773+data Merge x k s = Merge
20101774 { _merge_parentsRef :: {-# UNPACK #-} !(IORef (DMap k s))
20111775 , _merge_heightBagRef :: {-# UNPACK #-} !(IORef HeightBag)
20121776 , _merge_heightRef :: {-# UNPACK #-} !(IORef Height)
2013− , _merge_sub :: {-# UNPACK #-} !(Subscriber x (DMap k v))
2014− , _merge_accumRef :: {-# UNPACK #-} !(IORef (DMap k v))
1777+ , _merge_sub :: {-# UNPACK #-} !(Subscriber x (DMap k Identity))
1778+ , _merge_accumRef :: {-# UNPACK #-} !(IORef (DMap k Identity))
20151779 }
20161780
2017−invalidateMergeHeight :: Merge x k v s -> IO ()
1781+invalidateMergeHeight :: Merge x k s -> IO ()
20181782invalidateMergeHeight m = invalidateMergeHeight' (_merge_heightRef m) (_merge_sub m)
20191783
20201784invalidateMergeHeight' :: IORef Height -> Subscriber x a -> IO ()
20211785invalidateMergeHeight' heightRef sub = do
20221786 oldHeight <- readIORef heightRef
2023− -- If the height used to be valid, it must be invalid now; we should never have *more* heights than we have parents
2024− when (oldHeight /= invalidHeight) $ do
1787+ when (oldHeight /= invalidHeight) $ do -- If the height used to be valid, it must be invalid now; we should never have *more* heights than we have parents
20251788 writeIORef heightRef $! invalidHeight
20261789 subscriberInvalidateHeight sub oldHeight
20271790
2028−revalidateMergeHeight :: Merge x k v s -> IO ()
1791+
1792+revalidateMergeHeight :: Merge x k s -> IO ()
20291793revalidateMergeHeight m = do
20301794 currentHeight <- readIORef $ _merge_heightRef m
2031−
2032− -- revalidateMergeHeight may be called multiple times; perhaps the's a way to finesse it to avoid this check
2033− when (currentHeight == invalidHeight) $ do
1795+ when (currentHeight == invalidHeight) $ do -- revalidateMergeHeight may be called multiple times; perhaps the's a way to finesse it to avoid this check
20341796 heights <- readIORef $ _merge_heightBagRef m
20351797 parents <- readIORef $ _merge_parentsRef m
20361798 -- When the number of heights in the bag reaches the number of parents, we should have a valid height
@@ -2038,53 +1800,44 @@ revalidateMergeHeight m = do
20381800 LT -> return ()
20391801 EQ -> do
20401802 let height = succHeight $ heightBagMax heights
2041− traceInvalidateHeight $ "recalculateSubscriberHeight: height: " <> show height
1803+ traceInvalidate $ "recalculateSubscriberHeight: height: " <> show height
20421804 writeIORef (_merge_heightRef m) $! height
20431805 subscriberRecalculateHeight (_merge_sub m) height
20441806 GT -> error $ "revalidateMergeHeight: more heights (" <> show (heightBagSize heights) <> ") than parents (" <> show (DMap.size parents) <> ") for Merge"
20451807
2046−scheduleMergeSelf :: HasSpiderTimeline x => Merge x k v s -> Height -> EventM x ()
1808+scheduleMergeSelf :: HasSpiderTimeline x => Merge x k s -> Height -> EventM x ()
20471809scheduleMergeSelf m height = scheduleMerge' height (_merge_heightRef m) $ do
20481810 vals <- liftIO $ readIORef $ _merge_accumRef m
2049− -- Once we're done with this, we can clear it immediately, because if there's a cacheEvent in front of us,
2050− -- it'll handle subsequent subscribers, and if not, we won't get subsequent subscribers
2051− liftIO $ writeIORef (_merge_accumRef m) $! DMap.empty
1811+ liftIO $ writeIORef (_merge_accumRef m) $! DMap.empty -- Once we're done with this, we can clear it immediately, because if there's a cacheEvent in front of us, it'll handle subsequent subscribers, and if not, we won't get subsequent subscribers
20521812 --TODO: Assert that m is not empty
20531813 subscriberPropagate (_merge_sub m) vals
20541814
2055−checkCycle :: HasSpiderTimeline x => EventSubscribed x -> EventM x ()
2056−checkCycle subscribed = liftIO $ do
2057− height <- readIORef (eventSubscribedHeightRef subscribed)
2058−
2059− -- currentHeight <- getCurrentHeight
2060− -- when (height <= currentHeight) $ if height /= invalidHeight
2061− -- then do
2062− -- myStack <- liftIO $ whoCreatedIORef undefined --TODO
2063− -- error $ "Height (" ++ show height ++ ") is not greater than current height (" ++ show currentHeight ++ ")\n" ++ unlines (reverse myStack)
2064− -- else liftIO $
2065− when (height == invalidHeight) $
2066−#ifdef DEBUG_CYCLES
2067− do
2068− nodesInvolvedInCycle <- walkInvalidHeightParents subscribed
2069− stacks <- forM nodesInvolvedInCycle whoCreatedEventSubscribed
2070− throwIO (EventLoopException stacks)
2071−#else
2072− throwIO EventLoopException
2073−#endif
2074−
2075−
2076−mergeSubscriber :: forall x k v s a. (HasSpiderTimeline x, GCompare k) => EventSubscribed x -> Merge x k v s -> EventM x (k a) -> Subscriber x (v a)
2077−mergeSubscriber subscribed m getKey = Subscriber
1815+mergeSubscriber :: forall x k s a. (HasSpiderTimeline x, GCompare k) => Merge x k s -> EventM x (k a) -> Subscriber x a
1816+mergeSubscriber m getKey = Subscriber
20781817 { subscriberPropagate = \a -> do
20791818 oldM <- liftIO $ readIORef $ _merge_accumRef m
20801819 k <- getKey
2081− let newM = DMap.insertWith (error "Same key fired multiple times for Merge") k a oldM
1820+ let newM = DMap.insertWith (error $ "Same key fired multiple times for Merge") k (Identity a) oldM
20821821 tracePropagate (Proxy :: Proxy x) $ " DMap.size oldM = " <> show (DMap.size oldM) <> "; DMap.size newM = " <> show (DMap.size newM)
20831822 liftIO $ writeIORef (_merge_accumRef m) $! newM
20841823 when (DMap.null oldM) $ do -- Only schedule the firing once
20851824 height <- liftIO $ readIORef $ _merge_heightRef m
2086− checkCycle subscribed
2087−
1825+ --TODO: assertions about height
1826+ currentHeight <- getCurrentHeight
1827+ when (height <= currentHeight) $ do
1828+ if height /= invalidHeight
1829+ then do
1830+ myStack <- liftIO $ whoCreatedIORef undefined --TODO
1831+ error $ "Height (" ++ show height ++ ") is not greater than current height (" ++ show currentHeight ++ ")\n" ++ unlines (reverse myStack)
1832+ else liftIO $ do
1833+#ifdef DEBUG_CYCLES
1834+ nodesInvolvedInCycle <- walkInvalidHeightParents $ eventSubscribedMerge subscribed
1835+ stacks <- forM nodesInvolvedInCycle $ \(Some es) -> whoCreatedEventSubscribed es
1836+ let cycleInfo = ":\n" <> drawForest (listsToForest stacks)
1837+#else
1838+ let cycleInfo = ""
1839+#endif
1840+ error $ "Causality loop found" <> cycleInfo
20881841 scheduleMergeSelf m height
20891842 , subscriberInvalidateHeight = \old -> do --TODO: When removing a parent doesn't actually change the height, maybe we can avoid invalidating
20901843 modifyIORef' (_merge_heightBagRef m) $ heightBagRemove old
@@ -2095,45 +1848,30 @@ mergeSubscriber subscribed m getKey = Subscriber
20951848 }
20961849
20971850--TODO: Be able to run as much of this as possible promptly
2098−updateMerge :: (HasSpiderTimeline x, GCompare k) => EventSubscribed x -> Merge x k v s -> MergeUpdateFunc k v x p s -> p -> SomeMergeUpdate x
2099−updateMerge subscribed m updateFunc p = SomeMergeUpdate updateMe (invalidateMergeHeight m) (revalidateMergeHeight m)
1851+updateMerge :: (HasSpiderTimeline x, GCompare k) => Merge x k s -> MergeUpdateFunc k x p s -> p -> SomeMergeUpdate x
1852+updateMerge m updateFunc p = SomeMergeUpdate updateMe (invalidateMergeHeight m) (revalidateMergeHeight m)
21001853 where updateMe = do
21011854 oldParents <- liftIO $ readIORef $ _merge_parentsRef m
2102− (subscriptionsToKill, newParents) <- updateFunc (mergeSubscriber subscribed m) (_merge_heightBagRef m) oldParents p
1855+ (subscriptionsToKill, newParents) <- updateFunc (mergeSubscriber m) (_merge_heightBagRef m) oldParents p
21031856 liftIO $ writeIORef (_merge_parentsRef m) $! newParents
21041857 return subscriptionsToKill
21051858
2106−{-# INLINE mergeGCheap' #-}
2107−mergeGCheap' :: forall k v x p s q. (HasSpiderTimeline x, GCompare k, PatchTarget p ~ DMap k q)
2108− => MergeGetSubscription x s -> MergeInitFunc k v q x s -> MergeUpdateFunc k v x p s -> MergeDestroyFunc k s -> DynamicS x p -> Event x (DMap k v)
2109−mergeGCheap' getParent getInitialSubscribers updateFunc destroy d = Event $ \sub -> do
1859+{-# INLINE mergeCheap' #-}
1860+mergeCheap' :: forall k x p s. (HasSpiderTimeline x, GCompare k, PatchTarget p ~ DMap k (Event x)) => MergeInitFunc k x s -> MergeUpdateFunc k x p s -> MergeDestroyFunc k s -> Dynamic x p -> Event x (DMap k Identity)
1861+mergeCheap' getInitialSubscribers updateFunc destroy d = Event $ \sub -> do
21101862 initialParents <- readBehaviorUntracked $ dynamicCurrent d
21111863 accumRef <- liftIO $ newIORef $ error "merge: accumRef not yet initialized"
21121864 heightRef <- liftIO $ newIORef $ error "merge: heightRef not yet initialized"
21131865 heightBagRef <- liftIO $ newIORef $ error "merge: heightBagRef not yet initialized"
21141866 parentsRef :: IORef (DMap k s) <- liftIO $ newIORef $ error "merge: parentsRef not yet initialized"
2115− changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
2116−
2117− let subscribed = EventSubscribed
2118− { eventSubscribedHeightRef = heightRef
2119− , eventSubscribedRetained = toAny (parentsRef, changeSubdRef)
2120−#ifdef DEBUG_CYCLES
2121− , eventSubscribedGetParents = do
2122− let getParent' (_ :=> v) = _eventSubscription_subscribed (getParent v)
2123− fmap getParent' . DMap.toList <$> readIORef parentsRef
2124− , eventSubscribedHasOwnHeightRef = False
2125− , eventSubscribedWhoCreated = whoCreatedIORef heightRef
2126−#endif
2127− }
2128−
2129− m = Merge
1867+ let m = Merge
21301868 { _merge_parentsRef = parentsRef
21311869 , _merge_heightBagRef = heightBagRef
21321870 , _merge_heightRef = heightRef
21331871 , _merge_sub = sub
21341872 , _merge_accumRef = accumRef
21351873 }
2136− (dm, heights, initialParentState) <- getInitialSubscribers initialParents $ mergeSubscriber subscribed m
1874+ (dm, heights, initialParentState) <- getInitialSubscribers initialParents $ mergeSubscriber m
21371875 let myHeightBag = heightBagFromList $ filter (/= invalidHeight) heights
21381876 myHeight = if invalidHeight `elem` heights
21391877 then invalidHeight
@@ -2142,57 +1880,50 @@ mergeGCheap' getParent getInitialSubscribers updateFunc destroy d = Event $ \sub
21421880 let (occ, accum) = if currentHeight >= myHeight -- If we should have fired by now
21431881 then (if DMap.null dm then Nothing else Just dm, DMap.empty)
21441882 else (Nothing, dm)
2145− unless (DMap.null accum) $ scheduleMergeSelf m myHeight
1883+ unless (DMap.null accum) $ do
1884+ scheduleMergeSelf m myHeight
21461885 liftIO $ writeIORef accumRef $! accum
21471886 liftIO $ writeIORef heightRef $! myHeight
21481887 liftIO $ writeIORef heightBagRef $! myHeightBag
1888+ changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
21491889 liftIO $ writeIORef parentsRef $! initialParentState
21501890 defer $ SomeMergeInit $ do
2151− let changeSubscriber = Subscriber
1891+ let s = Subscriber
21521892 { subscriberPropagate = \a -> {-# SCC "traverseMergeChange" #-} do
2153− tracePropagate (Proxy :: Proxy x) "SubscriberMerge/Change"
2154− defer $ updateMerge subscribed m updateFunc a
1893+ tracePropagate (Proxy :: Proxy x) $ "SubscriberMerge/Change"
1894+ defer $ updateMerge m updateFunc a
21551895 , subscriberInvalidateHeight = \_ -> return ()
21561896 , subscriberRecalculateHeight = \_ -> return ()
21571897 }
2158− (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) changeSubscriber
2159− forM_ change $ \c -> defer $ updateMerge subscribed m updateFunc c
1898+ (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) s
1899+ forM_ change $ \c -> defer $ updateMerge m updateFunc c
21601900 -- We explicitly hold on to the unsubscribe function from subscribing to the update event.
21611901 -- If we don't do this, there are certain cases where mergeCheap will fail to properly retain
21621902 -- its subscription.
2163− liftIO $ writeIORef changeSubdRef (changeSubscriber, changeSubscription)
1903+ liftIO $ writeIORef changeSubdRef (s, changeSubscription)
21641904 let unsubscribeAll = destroy =<< readIORef parentsRef
1905+ return ( EventSubscription unsubscribeAll $ EventSubscribed heightRef $ toAny (parentsRef, changeSubdRef)
1906+ , occ
1907+ )
21651908
2166− return (EventSubscription unsubscribeAll subscribed, occ)
2167−
2168−
2169−mergeInt :: forall x a. (HasSpiderTimeline x) => DynamicS x (PatchIntMap (Event x a)) -> Event x (IntMap a)
1909+mergeInt :: forall x a. (HasSpiderTimeline x) => Dynamic x (PatchIntMap (Event x a)) -> Event x (IntMap a)
21701910mergeInt = cacheEvent . mergeIntCheap
21711911
21721912{-# INLINABLE mergeIntCheap #-}
2173−mergeIntCheap :: forall x a. (HasSpiderTimeline x) => DynamicS x (PatchIntMap (Event x a)) -> Event x (IntMap a)
1913+mergeIntCheap :: forall x a. (HasSpiderTimeline x) => Dynamic x (PatchIntMap (Event x a)) -> Event x (IntMap a)
21741914mergeIntCheap d = Event $ \sub -> do
21751915 initialParents <- readBehaviorUntracked $ dynamicCurrent d
21761916 accum <- liftIO $ FastMutableIntMap.newEmpty
21771917 heightRef <- liftIO $ newIORef zeroHeight
21781918 heightBagRef <- liftIO $ newIORef heightBagEmpty
21791919 parents <- liftIO $ FastMutableIntMap.newEmpty
2180− changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
2181− let subscribed = EventSubscribed
2182− { eventSubscribedHeightRef = heightRef
2183− , eventSubscribedRetained = toAny (parents, changeSubdRef)
2184−#ifdef DEBUG_CYCLES
2185− , eventSubscribedGetParents = fmap (_eventSubscription_subscribed . snd) <$> FastMutableIntMap.toList parents
2186− , eventSubscribedHasOwnHeightRef = False
2187− , eventSubscribedWhoCreated = whoCreatedIORef heightRef
2188−#endif
2189− }
21901920 let scheduleSelf = do
21911921 height <- liftIO $ readIORef $ heightRef
21921922 scheduleMerge' height heightRef $ do
21931923 vals <- liftIO $ FastMutableIntMap.getFrozenAndClear accum
21941924 subscriberPropagate sub vals
2195− invalidateMyHeight = invalidateMergeHeight' heightRef sub
1925+ invalidateMyHeight = do
1926+ invalidateMergeHeight' heightRef sub
21961927 recalculateMyHeight = do
21971928 currentHeight <- readIORef heightRef
21981929 when (currentHeight == invalidHeight) $ do --TODO: This will almost always be true; can we get rid of this check and just proceed to the next one always?
@@ -2202,14 +1933,12 @@ mergeIntCheap d = Event $ \sub -> do
22021933 LT -> return ()
22031934 EQ -> do
22041935 let height = succHeight $ heightBagMax heights
2205− traceInvalidateHeight $ "recalculateSubscriberHeight: height: " <> show height
1936+ traceInvalidate $ "recalculateSubscriberHeight: height: " <> show height
22061937 writeIORef heightRef $! height
22071938 subscriberRecalculateHeight sub height
22081939 GT -> error $ "revalidateMergeHeight: more heights (" <> show (heightBagSize heights) <> ") than parents (" <> show numParents <> ") for Merge"
22091940 mySubscriber k = Subscriber
22101941 { subscriberPropagate = \a -> do
2211− checkCycle subscribed
2212−
22131942 wasEmpty <- liftIO $ FastMutableIntMap.isEmpty accum
22141943 liftIO $ FastMutableIntMap.insert accum k a
22151944 when wasEmpty scheduleSelf
@@ -2243,6 +1972,7 @@ mergeIntCheap d = Event $ \sub -> do
22431972 else liftIO $ Just <$> FastMutableIntMap.getFrozenAndClear accum
22441973 else do when (not isEmpty) scheduleSelf -- We have things accumulated, but we shouldn't have fired them yet
22451974 return Nothing
1975+ changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
22461976 defer $ SomeMergeInit $ do
22471977 let updateMe a = SomeMergeUpdate u invalidateMyHeight recalculateMyHeight
22481978 where
@@ -2256,39 +1986,35 @@ mergeIntCheap d = Event $ \sub -> do
22561986 oldParents <- liftIO $ FastMutableIntMap.applyPatch parents newSubscriptions
22571987 liftIO $ for_ oldParents $ \oldParent -> do
22581988 oldParentHeight <- getEventSubscribedHeight $ _eventSubscription_subscribed oldParent
2259−
2260− print ("updateMe", oldParentHeight)
22611989 modifyIORef' heightBagRef $ heightBagRemove oldParentHeight
22621990 return $ IntMap.elems oldParents
2263− let changeSubscriber = Subscriber
1991+ let s = Subscriber
22641992 { subscriberPropagate = \a -> {-# SCC "traverseMergeChange" #-} do
22651993 tracePropagate (Proxy :: Proxy x) $ "SubscriberMergeInt/Change"
22661994 defer $ updateMe a
22671995 , subscriberInvalidateHeight = \_ -> return ()
22681996 , subscriberRecalculateHeight = \_ -> return ()
22691997 }
2270− (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) changeSubscriber
1998+ (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) s
22711999 forM_ change $ \c -> defer $ updateMe c
22722000 -- We explicitly hold on to the unsubscribe function from subscribing to the update event.
22732001 -- If we don't do this, there are certain cases where mergeCheap will fail to properly retain
22742002 -- its subscription.
2275− liftIO $ writeIORef changeSubdRef (changeSubscriber, changeSubscription)
2003+ liftIO $ writeIORef changeSubdRef (s, changeSubscription)
22762004 let unsubscribeAll = traverse_ unsubscribe =<< FastMutableIntMap.getFrozenAndClear parents
2277−
2278−
2279− return (EventSubscription unsubscribeAll subscribed, occ)
2005+ return ( EventSubscription unsubscribeAll $ EventSubscribed heightRef $ toAny (parents, changeSubdRef)
2006+ , occ
2007+ )
22802008
22812009newtype EventSelector x k = EventSelector { select :: forall a. k a -> Event x a }
2282−newtype EventSelectorG x k v = EventSelectorG { selectG :: forall a. k a -> Event x (v a) }
22832010
2284−fanG :: (HasSpiderTimeline x, GCompare k) => Event x (DMap k v) -> EventSelectorG x k v
2285−fanG e = unsafePerformIO $ do
2286− ref <- newIORef Nothing
2011+fan :: (HasSpiderTimeline x, GCompare k) => Event x (DMap k Identity) -> EventSelector x k
2012+fan e =
22872013 let f = Fan
22882014 { fanParent = e
2289− , fanSubscribed = ref
2015+ , fanSubscribed = unsafeNewIORef e Nothing
22902016 }
2291− pure $ EventSelectorG $ \k -> eventFan k f
2017+ in EventSelector $ \k -> eventFan k f
22922018
22932019runHoldInits :: HasSpiderTimeline x => IORef [SomeHoldInit x] -> IORef [SomeDynInit x] -> IORef [SomeMergeInit x] -> EventM x ()
22942020runHoldInits holdInitRef dynInitRef mergeInitRef = do
@@ -2342,7 +2068,7 @@ clearEventEnv (EventEnv toAssignRef holdInitRef dynInitRef mergeUpdateRef mergeI
23422068-- | Run an event action outside of a frame
23432069runFrame :: forall x a. HasSpiderTimeline x => EventM x a -> SpiderHost x a --TODO: This function also needs to hold the mutex
23442070runFrame a = SpiderHost $ do
2345− let env = _spiderTimeline_eventEnv $ unSTE (spiderTimeline :: SpiderTimelineEnv x)
2071+ let env = _spiderTimeline_eventEnv (spiderTimeline :: SpiderTimelineEnv x)
23462072 let go = do
23472073 result <- a
23482074 runHoldInits (eventEnvHoldInits env) (eventEnvDynInits env) (eventEnvMergeInits env) -- This must happen before doing the assignments, in case subscribing a Hold causes existing Holds to be read by the newly-propagated events
@@ -2385,7 +2111,7 @@ runFrame a = SpiderHost $ do
23852111 subscription <- unSpiderHost $ runFrame $ {-# SCC "subscribeSwitch" #-} subscribe e sub --TODO: Assert that the event isn't firing --TODO: This should not loop because none of the events should be firing, but still, it is inefficient
23862112 {-
23872113 stackTrace <- liftIO $ fmap renderStack $ ccsToStrings =<< (getCCSOf $! switchSubscribedParent subscribed)
2388− liftIO $ debugStrLn $ (++stackTrace) $ "subd' subscribed to " ++ case e of
2114+ liftIO $ putStrLn $ (++stackTrace) $ "subd' subscribed to " ++ case e of
23892115 EventRoot _ -> "EventRoot"
23902116 EventNever -> "EventNever"
23912117 _ -> "something else"
@@ -2400,7 +2126,7 @@ runFrame a = SpiderHost $ do
24002126 myHeight <- readIORef $ switchSubscribedHeight subscribed
24012127 when (parentHeight /= myHeight) $ do
24022128 writeIORef (switchSubscribedHeight subscribed) $! invalidHeight
2403− WeakBag.traverse_ (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight myHeight
2129+ WeakBag.traverse (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight myHeight
24042130 mapM_ _someMergeUpdate_invalidateHeight mergeUpdates --TODO: In addition to when the patch is completely empty, we should also not run this if it has some Nothing values, but none of them have actually had any effect; potentially, we could even check for Just values with no effect (e.g. by comparing their IORefs and ignoring them if they are unchanged); actually, we could just check if the new height is different
24052131 forM_ coincidenceInfos $ \(SomeResetCoincidence subscription mcs) -> do
24062132 unsubscribe subscription
@@ -2441,7 +2167,7 @@ invalidateCoincidenceHeight subscribed = do
24412167 oldHeight <- readIORef $ coincidenceSubscribedHeight subscribed
24422168 when (oldHeight /= invalidHeight) $ do
24432169 writeIORef (coincidenceSubscribedHeight subscribed) $! invalidHeight
2444− WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
2170+ WeakBag.traverse (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
24452171
24462172updateSwitchHeight :: Height -> SwitchSubscribed x a -> IO ()
24472173updateSwitchHeight new subscribed = do
@@ -2449,7 +2175,7 @@ updateSwitchHeight new subscribed = do
24492175 when (oldHeight == invalidHeight) $ do --TODO: This 'when' should probably be an assertion
24502176 when (new /= invalidHeight) $ do --TODO: This 'when' should probably be an assertion
24512177 writeIORef (switchSubscribedHeight subscribed) $! new
2452− WeakBag.traverse_ (switchSubscribedSubscribers subscribed) $ recalculateSubscriberHeight new
2178+ WeakBag.traverse (switchSubscribedSubscribers subscribed) $ recalculateSubscriberHeight new
24532179
24542180recalculateCoincidenceHeight :: CoincidenceSubscribed x a -> IO ()
24552181recalculateCoincidenceHeight subscribed = do
@@ -2458,7 +2184,7 @@ recalculateCoincidenceHeight subscribed = do
24582184 height <- calculateCoincidenceHeight subscribed
24592185 when (height /= invalidHeight) $ do
24602186 writeIORef (coincidenceSubscribedHeight subscribed) $! height
2461− WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ recalculateSubscriberHeight height
2187+ WeakBag.traverse (coincidenceSubscribedSubscribers subscribed) $ recalculateSubscriberHeight height
24622188
24632189calculateSwitchHeight :: SwitchSubscribed x a -> IO Height
24642190calculateSwitchHeight subscribed = getEventSubscribedHeight . _eventSubscription_subscribed =<< readIORef (switchSubscribedCurrentParent subscribed)
@@ -2520,8 +2246,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Event
25202246 {-# INLINABLE headE #-}
25212247 headE = R.slowHeadE
25222248-- headE (SpiderEvent e) = SpiderEvent <$> Reflex.Spider.Internal.headE e
2523− {-# INLINABLE now #-}
2524− now = nowSpiderEventM
25252249
25262250instance Reflex.Class.MonadSample (SpiderTimeline x) (SpiderPullM x) where
25272251 {-# INLINABLE sample #-}
@@ -2543,9 +2267,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Spide
25432267 {-# INLINABLE headE #-}
25442268 headE = R.slowHeadE
25452269-- headE (SpiderEvent e) = SpiderPushM $ SpiderEvent <$> Reflex.Spider.Internal.headE e
2546− {-# INLINABLE now #-}
2547− now = SpiderPushM nowSpiderEventM
2548−
25492270
25502271instance HasSpiderTimeline x => Monad (Reflex.Class.Dynamic (SpiderTimeline x)) where
25512272 {-# INLINE return #-}
@@ -2554,13 +2275,11 @@ instance HasSpiderTimeline x => Monad (Reflex.Class.Dynamic (SpiderTimeline x))
25542275 x >>= f = SpiderDynamic $ dynamicDynIdentity $ newJoinDyn $ newMapDyn (unSpiderDynamic . f) $ unSpiderDynamic x
25552276 {-# INLINE (>>) #-}
25562277 (>>) = (*>)
2557−#if !MIN_VERSION_base(4,13,0)
25582278 {-# INLINE fail #-}
25592279 fail _ = error "Dynamic does not support 'fail'"
2560−#endif
25612280
25622281{-# INLINABLE newJoinDyn #-}
2563−newJoinDyn :: HasSpiderTimeline x => DynamicS x (Identity (DynamicS x (Identity a))) -> Reflex.Spider.Internal.Dyn x (Identity a)
2282+newJoinDyn :: HasSpiderTimeline x => Reflex.Spider.Internal.Dynamic x (Identity (Reflex.Spider.Internal.Dynamic x (Identity a))) -> Reflex.Spider.Internal.Dyn x (Identity a)
25642283newJoinDyn d =
25652284 let readV0 = readBehaviorTracked . dynamicCurrent =<< readBehaviorTracked (dynamicCurrent d)
25662285 eOuter = Reflex.Spider.Internal.push (fmap (Just . Identity) . readBehaviorUntracked . dynamicCurrent . runIdentity) $ dynamicUpdated d
@@ -2609,9 +2328,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Spide
26092328 buildDynamic getV0 e = runFrame . runSpiderHostFrame $ Reflex.Class.buildDynamic getV0 e
26102329 {-# INLINABLE headE #-}
26112330 headE e = runFrame . runSpiderHostFrame $ Reflex.Class.headE e
2612− {-# INLINABLE now #-}
2613− now = runFrame . runSpiderHostFrame $ Reflex.Class.now
2614−
26152331
26162332instance HasSpiderTimeline x => Reflex.Class.MonadSample (SpiderTimeline x) (SpiderHostFrame x) where
26172333 sample = SpiderHostFrame . readBehaviorUntracked . unSpiderBehavior --TODO: This can cause problems with laziness, so we should get rid of it if we can
@@ -2628,8 +2344,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Spide
26282344 {-# INLINABLE headE #-}
26292345 headE = R.slowHeadE
26302346-- headE (SpiderEvent e) = SpiderHostFrame $ SpiderEvent <$> Reflex.Spider.Internal.headE e
2631− {-# INLINABLE now #-}
2632− now = SpiderHostFrame Reflex.Class.now
26332347
26342348instance HasSpiderTimeline x => Reflex.Class.MonadSample (SpiderTimeline x) (SpiderHost x) where
26352349 {-# INLINABLE sample #-}
@@ -2650,8 +2364,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Refle
26502364 buildDynamic getV0 e = Reflex.Spider.Internal.ReadPhase $ Reflex.Class.buildDynamic getV0 e
26512365 {-# INLINABLE headE #-}
26522366 headE e = Reflex.Spider.Internal.ReadPhase $ Reflex.Class.headE e
2653− {-# INLINABLE now #-}
2654− now = Reflex.Spider.Internal.ReadPhase Reflex.Class.now
26552367
26562368--------------------------------------------------------------------------------
26572369-- Deprecated items
@@ -2717,7 +2429,7 @@ unsafeNewSpiderTimelineEnv = do
27172429#ifdef DEBUG
27182430 depthRef <- newIORef 0
27192431#endif
2720− return $ STE $ SpiderTimelineEnv
2432+ return $ SpiderTimelineEnv
27212433 { _spiderTimeline_lock = lock
27222434 , _spiderTimeline_eventEnv = env
27232435#ifdef DEBUG
@@ -2729,17 +2441,17 @@ unsafeNewSpiderTimelineEnv = do
27292441newSpiderTimeline :: IO (Some SpiderTimelineEnv)
27302442newSpiderTimeline = withSpiderTimeline (pure . Some)
27312443
2732−data LocalSpiderTimeline (x :: Type) s
2444+data LocalSpiderTimeline x s
27332445
27342446instance Reifies s (SpiderTimelineEnv x) =>
27352447 HasSpiderTimeline (LocalSpiderTimeline x s) where
2736− spiderTimeline = localSpiderTimeline Proxy $ reflect (Proxy :: Proxy s)
2448+ spiderTimeline = localSpiderTimeline (Proxy :: Proxy s) $ reflect (Proxy :: Proxy s)
27372449
27382450localSpiderTimeline
2739− :: proxy s
2451+ :: Proxy s
27402452 -> SpiderTimelineEnv x
27412453 -> SpiderTimelineEnv (LocalSpiderTimeline x s)
2742−localSpiderTimeline _ = coerce
2454+localSpiderTimeline _ = unsafeCoerce
27432455
27442456-- | Pass a new timeline to the given function.
27452457withSpiderTimeline :: (forall x. HasSpiderTimeline x => SpiderTimelineEnv x -> IO r) -> IO r
@@ -2747,18 +2459,18 @@ withSpiderTimeline k = do
27472459 env <- unsafeNewSpiderTimelineEnv
27482460 reify env $ \s -> k $ localSpiderTimeline s env
27492461
2750−newtype SpiderPullM (x :: Type) a = SpiderPullM (BehaviorM x a) deriving (Functor, Applicative, Monad, MonadIO, MonadFix)
2462+newtype SpiderPullM x a = SpiderPullM (BehaviorM x a) deriving (Functor, Applicative, Monad, MonadIO, MonadFix)
27512463
27522464type ComputeM = EventM
27532465
2754−newtype SpiderPushM (x :: Type) a = SpiderPushM (ComputeM x a) deriving (Functor, Applicative, Monad, MonadIO, MonadFix)
2466+newtype SpiderPushM x a = SpiderPushM (ComputeM x a) deriving (Functor, Applicative, Monad, MonadIO, MonadFix)
27552467
27562468instance HasSpiderTimeline x => R.Reflex (SpiderTimeline x) where
27572469 {-# SPECIALIZE instance R.Reflex (SpiderTimeline Global) #-}
27582470 newtype Behavior (SpiderTimeline x) a = SpiderBehavior { unSpiderBehavior :: Behavior x a }
27592471 newtype Event (SpiderTimeline x) a = SpiderEvent { unSpiderEvent :: Event x a }
2760− newtype Dynamic (SpiderTimeline x) a = SpiderDynamic { unSpiderDynamic :: DynamicS x (Identity a) } -- deriving (Functor, Applicative, Monad)
2761− newtype Incremental (SpiderTimeline x) p = SpiderIncremental { unSpiderIncremental :: DynamicS x p }
2472+ newtype Dynamic (SpiderTimeline x) a = SpiderDynamic { unSpiderDynamic :: Dynamic x (Identity a) } -- deriving (Functor, Applicative, Monad)
2473+ newtype Incremental (SpiderTimeline x) p = SpiderIncremental { unSpiderIncremental :: Dynamic x p }
27622474 type PullM (SpiderTimeline x) = SpiderPullM x
27632475 type PushM (SpiderTimeline x) = SpiderPushM x
27642476 {-# INLINABLE never #-}
@@ -2771,15 +2483,10 @@ instance HasSpiderTimeline x => R.Reflex (SpiderTimeline x) where
27712483 pushCheap f = SpiderEvent . pushCheap (coerce f) . unSpiderEvent
27722484 {-# INLINABLE pull #-}
27732485 pull = SpiderBehavior . pull . coerce
2774− {-# INLINABLE fanG #-}
2775− fanG e = R.EventSelectorG $ SpiderEvent . selectG (fanG (unSpiderEvent e))
2776− {-# INLINABLE mergeG #-}
2777− mergeG
2778− :: forall k2 (k :: k2 -> *) q (v :: k2 -> *). GCompare k
2779− => (forall a. q a -> R.Event (SpiderTimeline x) (v a))
2780− -> DMap k q
2781− -> R.Event (SpiderTimeline x) (DMap k v)
2782− mergeG nt = SpiderEvent . mergeG (unSpiderEvent #. nt) . dynamicConst
2486+ {-# INLINABLE merge #-}
2487+ merge = SpiderEvent . merge . dynamicConst . (coerce :: DMap k (R.Event (SpiderTimeline x)) -> DMap k (Event x))
2488+ {-# INLINABLE fan #-}
2489+ fan e = R.EventSelector $ SpiderEvent . select (fan (unSpiderEvent e))
27832490 {-# INLINABLE switch #-}
27842491 switch = SpiderEvent . switch . (coerce :: Behavior x (R.Event (SpiderTimeline x) a) -> Behavior x (Event x a)) . unSpiderBehavior
27852492 {-# INLINABLE coincidence #-}
@@ -2787,15 +2494,15 @@ instance HasSpiderTimeline x => R.Reflex (SpiderTimeline x) where
27872494 {-# INLINABLE current #-}
27882495 current = SpiderBehavior . dynamicCurrent . unSpiderDynamic
27892496 {-# INLINABLE updated #-}
2790− updated = SpiderEvent #. dynamicUpdated .# fmap coerce . unSpiderDynamic
2497+ updated = coerce $ SpiderEvent . dynamicUpdated . unSpiderDynamic
27912498 {-# INLINABLE unsafeBuildDynamic #-}
27922499 unsafeBuildDynamic readV0 v' = SpiderDynamic $ dynamicDynIdentity $ unsafeBuildDynamic (coerce readV0) $ coerce $ unSpiderEvent v'
27932500 {-# INLINABLE unsafeBuildIncremental #-}
27942501 unsafeBuildIncremental readV0 dv = SpiderIncremental $ dynamicDyn $ unsafeBuildDynamic (coerce readV0) $ unSpiderEvent dv
2795− {-# INLINABLE mergeIncrementalG #-}
2796− mergeIncrementalG nt = SpiderEvent #. mergeG (coerce #. nt) .# unSpiderIncremental
2797− {-# INLINABLE mergeIncrementalWithMoveG #-}
2798− mergeIncrementalWithMoveG nt = SpiderEvent #. mergeWithMove (coerce #. nt) .# unSpiderIncremental
2502+ {-# INLINABLE mergeIncremental #-}
2503+ mergeIncremental = SpiderEvent . merge . (unsafeCoerce :: Dynamic x (PatchDMap k (R.Event (SpiderTimeline x))) -> Dynamic x (PatchDMap k (Event x))) . unSpiderIncremental
2504+ {-# INLINABLE mergeIncrementalWithMove #-}
2505+ mergeIncrementalWithMove = SpiderEvent . mergeWithMove . (unsafeCoerce :: Dynamic x (PatchDMapWithMove k (R.Event (SpiderTimeline x))) -> Dynamic x (PatchDMapWithMove k (Event x))) . unSpiderIncremental
27992506 {-# INLINABLE currentIncremental #-}
28002507 currentIncremental = SpiderBehavior . dynamicCurrent . unSpiderIncremental
28012508 {-# INLINABLE updatedIncremental #-}
@@ -2806,10 +2513,9 @@ instance HasSpiderTimeline x => R.Reflex (SpiderTimeline x) where
28062513 return $ Identity <$> apply p c --TODO: Avoid the redundant 'apply'
28072514 eventCoercion Coercion = Coercion
28082515 behaviorCoercion Coercion = Coercion
2809− dynamicCoercion Coercion = Coercion
2810− incrementalCoercion Coercion Coercion = Coercion
2516+ dynamicCoercion = unsafeCoerce --TODO: How can we avoid this unsafeCoerce? This is safe only because we know how Identity works as a Patch instance
28112517 {-# INLINABLE mergeIntIncremental #-}
2812− mergeIntIncremental = SpiderEvent . mergeInt . coerce
2518+ mergeIntIncremental = SpiderEvent . mergeInt . (unsafeCoerce :: Dynamic x (PatchIntMap (R.Event (SpiderTimeline x) a)) -> Dynamic x (PatchIntMap (Event x a))) . unSpiderIncremental
28132519 {-# INLINABLE fanInt #-}
28142520 fanInt e = R.EventSelectorInt $ SpiderEvent . selectInt (fanInt (unSpiderEvent e))
28152521
@@ -2834,7 +2540,7 @@ instance MonadAtomicRef (EventM x) where
28342540 atomicModifyRef r f = liftIO $ atomicModifyRef r f
28352541
28362542-- | The monad for actions that manipulate a Spider timeline identified by @x@
2837−newtype SpiderHost (x :: Type) a = SpiderHost { unSpiderHost :: IO a } deriving (Functor, Applicative, MonadFix, MonadIO, MonadException, MonadAsyncException)
2543+newtype SpiderHost x a = SpiderHost { unSpiderHost :: IO a } deriving (Functor, Applicative, MonadFix, MonadIO, MonadException, MonadAsyncException)
28382544
28392545instance Monad (SpiderHost x) where
28402546 {-# INLINABLE (>>=) #-}
@@ -2843,14 +2549,8 @@ instance Monad (SpiderHost x) where
28432549 SpiderHost x >> SpiderHost y = SpiderHost $ x >> y
28442550 {-# INLINABLE return #-}
28452551 return x = SpiderHost $ return x
2846−#if !MIN_VERSION_base(4,13,0)
28472552 {-# INLINABLE fail #-}
2848− fail = MonadFail.fail
2849−#endif
2850−
2851−instance MonadFail (SpiderHost x) where
2852− {-# INLINABLE fail #-}
2853− fail s = SpiderHost $ MonadFail.fail s
2553+ fail s = SpiderHost $ fail s
28542554
28552555-- | Run an action affecting the global Spider timeline; this will be guarded by
28562556-- a mutex for that timeline
@@ -2862,7 +2562,7 @@ runSpiderHost (SpiderHost a) = a
28622562runSpiderHostForTimeline :: SpiderHost x a -> SpiderTimelineEnv x -> IO a
28632563runSpiderHostForTimeline (SpiderHost a) _ = a
28642564
2865−newtype SpiderHostFrame (x :: Type) a = SpiderHostFrame { runSpiderHostFrame :: EventM x a }
2565+newtype SpiderHostFrame x a = SpiderHostFrame { runSpiderHostFrame :: EventM x a }
28662566 deriving (Functor, Applicative, MonadFix, MonadIO, MonadException, MonadAsyncException)
28672567
28682568instance Monad (SpiderHostFrame x) where
@@ -2872,10 +2572,8 @@ instance Monad (SpiderHostFrame x) where
28722572 SpiderHostFrame x >> SpiderHostFrame y = SpiderHostFrame $ x >> y
28732573 {-# INLINABLE return #-}
28742574 return x = SpiderHostFrame $ return x
2875−#if !MIN_VERSION_base(4,13,0)
28762575 {-# INLINABLE fail #-}
28772576 fail s = SpiderHostFrame $ fail s
2878−#endif
28792577
28802578instance NotReady (SpiderTimeline x) (SpiderHostFrame x) where
28812579 notReadyUntil _ = pure ()
@@ -2920,11 +2618,3 @@ instance MonadAtomicRef (SpiderHostFrame x) where
29202618instance PrimMonad (SpiderHostFrame x) where
29212619 type PrimState (SpiderHostFrame x) = PrimState IO
29222620 primitive = SpiderHostFrame . EventM . primitive
2923−
2924−instance NotReady (SpiderTimeline x) (SpiderHost x) where
2925− notReadyUntil _ = return ()
2926− notReady = return ()
2927−
2928−instance HasSpiderTimeline x => NotReady (SpiderTimeline x) (PerformEventT (SpiderTimeline x) (SpiderHost x)) where
2929− notReadyUntil _ = return ()
2930− notReady = return ()