@@ -9,6 +9,8 @@
99{-# LANGUAGE GADTs #-}
1010{-# LANGUAGE GeneralizedNewtypeDeriving #-}
1111{-# LANGUAGE LambdaCase #-}
12+{-# LANGUAGE MultiParamTypeClasses #-}
13+{-# LANGUAGE MultiWayIf #-}
1214{-# LANGUAGE RankNTypes #-}
1315{-# LANGUAGE RoleAnnotations #-}
1416{-# LANGUAGE ScopedTypeVariables #-}
@@ -16,10 +18,7 @@
1618{-# LANGUAGE TypeOperators #-}
1719{-# LANGUAGE UndecidableInstances #-}
1820{-# LANGUAGE PolyKinds #-}
19−{-# LANGUAGE DeriveFunctor #-}
20−{-# LANGUAGE StandaloneDeriving #-}
2121{-# LANGUAGE InstanceSigs #-}
22−{-# LANGUAGE MultiWayIf #-}
2322
2423#ifdef USE_REFLEX_OPTIMIZER
2524{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
@@ -38,17 +37,12 @@ import Control.Monad hiding (forM, forM_, mapM, mapM_)
3837import Control.Monad.Exception
3938import Control.Monad.Identity hiding (forM, forM_, mapM, mapM_)
4039import Control.Monad.Primitive
41−import Control.Monad.Reader.Class
42−import Control.Monad.IO.Class
43−import Control.Monad.ReaderIO
40+import Control.Monad.Reader hiding (forM, forM_, mapM, mapM_)
4441import Control.Monad.Ref
45−import Control.Monad.Fail (MonadFail)
46−import qualified Control.Monad.Fail as MonadFail
4742import Data.Align
4843import Data.Coerce
49−import Data.Dependent.Map (DMap)
44+import Data.Dependent.Map (DMap, DSum (..))
5045import qualified Data.Dependent.Map as DMap
51−import Data.Dependent.Sum (DSum (..))
5246import Data.FastMutableIntMap (FastMutableIntMap, PatchIntMap (..))
5347import qualified Data.FastMutableIntMap as FastMutableIntMap
5448import Data.Foldable hiding (concat, elem, sequence_)
@@ -61,13 +55,12 @@ import qualified Data.IntMap.Strict as IntMap
6155import Data.IORef
6256import Data.Kind (Type)
6357import Data.Maybe hiding (mapMaybe)
64−import Data.Monoid (mempty, (<>))
58+import Data.Monoid ((<>))
6559import Data.Proxy
6660import Data.These
6761import Data.Traversable
68−import Data.Type.Equality ((:~:)(Refl))
6962import Data.Witherable (Filterable, mapMaybe)
70−import GHC.Exts hiding (toList)
63+import GHC.Exts
7164import GHC.IORef (IORef (..))
7265import GHC.Stack
7366import Reflex.FastWeak
@@ -75,27 +68,22 @@ import System.IO.Unsafe
7568import System.Mem.Weak
7669import Unsafe.Coerce
7770
78−#ifdef MIN_VERSION_semialign
71+#if defined(MIN_VERSION_semialign)
7972#if MIN_VERSION_these(0,8,0)
8073import Data.These.Combinators (justThese)
8174#endif
82−#if MIN_VERSION_semialign(1,1,0)
83−import Data.Zip (Zip (..))
84−#endif
8575#endif
8676
8777#ifdef DEBUG_CYCLES
8878import Control.Monad.State hiding (forM, forM_, mapM, mapM_, sequence)
89−#endif
90−
9179import Data.List.NonEmpty (NonEmpty (..), nonEmpty)
9280import qualified Data.List.NonEmpty as NonEmpty
81+import Data.Monoid (mempty)
9382import Data.Tree (Forest, Tree (..), drawForest)
94−import Data.List (isPrefixOf)
83+#endif
9584
96−import Data.FastWeakBag (FastWeakBag, FastWeakBagTicket)
85+import Data.FastWeakBag (FastWeakBag)
9786import qualified Data.FastWeakBag as FastWeakBag
98−
9987import Data.Reflection
10088import Data.Some (Some(Some))
10189import Data.Type.Coercion
@@ -106,26 +94,20 @@ import qualified Reflex.Class
10694import qualified Reflex.Class as R
10795import qualified Reflex.Host.Class
10896import Reflex.NotReady.Class
109−import Data.Patch
110−import qualified Data.Patch.DMapWithMove as PatchDMapWithMove
111−import Reflex.PerformEvent.Base (PerformEventT)
97+import Reflex.Patch
98+import qualified Reflex.Patch.DMapWithMove as PatchDMapWithMove
11299
113100#ifdef DEBUG_TRACE_EVENTS
114101import qualified Data.ByteString.Char8 as BS8
115102import System.IO (stderr)
116−import Data.List (isPrefixOf)
117103#endif
118104
119−-- TODO stdout might not be the best channel for debug output
120−debugStrLn :: String -> IO ()
121−debugStrLn = putStrLn
122−
123105#ifdef DEBUG_TRACE_EVENTS
106+
124107withStackOneLine :: (BS8.ByteString -> a) -> a
125108withStackOneLine expr = unsafePerformIO $ do
126109 stack <- currentCallStack
127− return (expr . BS8.pack . unwords . dropInternal . reverse $ stack)
128− where dropInternal = filterStack "Reflex.Spider.Internal"
110+ return (expr (BS8.pack (unwords (reverse stack))))
129111
130112#endif
131113
@@ -136,42 +118,28 @@ debugInvalidateHeight :: Bool
136118debugInvalidate :: Bool
137119
138120#ifdef DEBUG
121+
139122#define DEBUG_NODEIDS
140123
141−#ifdef DEBUG_TRACE_PROPAGATION
142124debugPropagate = True
143−#else
144−debugPropagate = False
145−#endif
146125
147−#ifdef DEBUG_TRACE_HEIGHT
148−debugInvalidateHeight = True
149−#else
150126debugInvalidateHeight = False
151−#endif
152127
153−#ifdef DEBUG_TRACE_INVALIDATION
154128debugInvalidate = True
155−#else
156−debugInvalidate = False
157−#endif
158129
159130class HasNodeId a where
160131 getNodeId :: a -> Int
161132
162−instance HasNodeId (CacheSubscribed x a) where
163− getNodeId = _cacheSubscribed_nodeId
164−
165−instance HasNodeId (FanInt x a) where
166− getNodeId = _fanInt_nodeId
167−
168−instance HasNodeId (Hold x p) where
133+instance HasNodeId (Hold x p a) where
169134 getNodeId = holdNodeId
170135
136+instance HasNodeId (PushSubscribed x a b) where
137+ getNodeId = pushSubscribedNodeId
138+
171139instance HasNodeId (SwitchSubscribed x a) where
172140 getNodeId = switchSubscribedNodeId
173141
174−instance HasNodeId (FanSubscribed x v a) where
142+instance HasNodeId (FanSubscribed x a) where
175143 getNodeId = fanSubscribedNodeId
176144
177145instance HasNodeId (CoincidenceSubscribed x a) where
@@ -185,16 +153,41 @@ instance HasNodeId (Pull x a) where
185153
186154{-# INLINE showNodeId #-}
187155showNodeId :: HasNodeId a => a -> String
188−showNodeId = showNodeId' . getNodeId
189−
190−showNodeId' :: Int -> String
191−showNodeId' = ("#"<>) . show
192−
156+showNodeId = ("#"<>) . show . getNodeId
157+
158+showSubscriberType :: Subscriber x a -> String
159+showSubscriberType = \case
160+ SubscriberPush _ _ -> "SubscriberPush"
161+ SubscriberMerge _ _ -> "SubscriberMerge"
162+ SubscriberFan _ -> "SubscriberFan"
163+ SubscriberMergeChange _ -> "SubscriberMergeChange"
164+ SubscriberHold _ -> "SubscriberHold"
165+ SubscriberHoldIdentity _ -> "SubscriberHoldIdentity"
166+ SubscriberSwitch _ -> "SubscriberSwitch"
167+ SubscriberCoincidenceOuter _ -> "SubscriberCoincidenceOuter"
168+ SubscriberCoincidenceInner _ -> "SubscriberCoincidenceInner"
169+ SubscriberHandle -> "SubscriberHandle"
170+
171+showEventType :: Event x a -> String
172+showEventType = \case
173+ EventRoot _ _ -> "EventRoot"
174+ EventNever -> "EventNever"
175+ EventPush _ -> "EventPush"
176+ EventMerge _ -> "EventMerge"
177+ EventFan _ _ -> "EventFan"
178+ EventSwitch _ -> "EventSwitch"
179+ EventCoincidence _ -> "EventCoincidence"
180+ EventHold _ -> "EventHold"
181+ EventDyn _ -> "EventDyn"
182+ EventHoldIdentity _ -> "EventHoldIdentity"
183+ EventDynIdentity _ -> "EventDynIdentity"
193184
194185#else
195186
196187debugPropagate = False
188+
197189debugInvalidateHeight = False
190+
198191debugInvalidate = False
199192
200193-- This must be inline, or error messages will cause memory leaks due to retaining the node in question
@@ -202,10 +195,6 @@ debugInvalidate = False
202195showNodeId :: a -> String
203196showNodeId _ = ""
204197
205−{-# INLINE showNodeId' #-}
206−showNodeId' :: Int -> String
207−showNodeId' _ = ""
208−
209198#endif
210199
211200#ifdef DEBUG_NODEIDS
@@ -251,9 +240,9 @@ subscribeAndRead = unEvent
251240-- caching; if the computation function is very cheap, this is (much) more
252241-- efficient than 'push'
253242{-# INLINE [1] pushCheap #-}
254−pushCheap :: HasSpiderTimeline x => (a -> ComputeM x (Maybe b)) -> Event x a -> Event x b
243+pushCheap :: (a -> ComputeM x (Maybe b)) -> Event x a -> Event x b
255244pushCheap !f e = Event $ \sub -> do
256− (subscription, occ) <- subscribeAndRead e $ debugSubscriber' "push" $ sub
245+ (subscription, occ) <- subscribeAndRead e $ sub
257246 { subscriberPropagate = \a -> do
258247 mb <- f a
259248 mapM_ (subscriberPropagate sub) mb
@@ -272,10 +261,10 @@ terminalSubscriber p = Subscriber
272261
273262-- | Subscribe to an Event only for the duration of one occurrence
274263{-# INLINE subscribeAndReadHead #-}
275−subscribeAndReadHead :: HasSpiderTimeline x => Event x a -> Subscriber x a -> EventM x (EventSubscription x, Maybe a)
264+subscribeAndReadHead :: Event x a -> Subscriber x a -> EventM x (EventSubscription x, Maybe a)
276265subscribeAndReadHead e sub = do
277266 subscriptionRef <- liftIO $ newIORef $ error "subscribeAndReadHead: not initialized"
278− (subscription, occ) <- subscribeAndRead e $ debugSubscriber' "head" $ sub
267+ (subscription, occ) <- subscribeAndRead e $ sub
279268 { subscriberPropagate = \a -> do
280269 liftIO $ unsubscribe =<< readIORef subscriptionRef
281270 subscriberPropagate sub a
@@ -286,42 +275,24 @@ subscribeAndReadHead e sub = do
286275 return (subscription, occ)
287276
288277--TODO: Make this lazy in its input event
289−headE :: (MonadIO m, Defer (SomeMergeInit x) m, HasSpiderTimeline x) => Event x a -> m (Event x a)
278+headE :: (MonadIO m, Defer (SomeMergeInit x) m) => Event x a -> m (Event x a)
290279headE originalE = do
291280 parent <- liftIO $ newIORef $ Just originalE
292281 defer $ SomeMergeInit $ do --TODO: Rename SomeMergeInit appropriately
293282 let clearParent = liftIO $ writeIORef parent Nothing
294− (_, occ) <- subscribeAndReadHead originalE $ terminalSubscriber $ const clearParent
283+ (_, occ) <- subscribeAndReadHead originalE $ terminalSubscriber $ \_ -> clearParent
295284 when (isJust occ) clearParent
296− return $ Event $ \sub ->
285+ return $ Event $ \sub -> do
297286 liftIO (readIORef parent) >>= \case
298− Nothing -> subscribeAndReadNever
287+ Nothing -> return (EventSubscription (return ()) $ EventSubscribed zeroRef $ toAny (), Nothing)
299288 Just e -> subscribeAndReadHead e sub
300289
301290data CacheSubscribed x a
302291 = CacheSubscribed { _cacheSubscribed_subscribers :: {-# UNPACK #-} !(FastWeakBag (Subscriber x a))
303292 , _cacheSubscribed_parent :: {-# UNPACK #-} !(EventSubscription x)
304293 , _cacheSubscribed_occurrence :: {-# UNPACK #-} !(IORef (Maybe a))
305−#ifdef DEBUG_NODEIDS
306− , _cacheSubscribed_nodeId :: {-# UNPACK #-} !Int
307−#endif
308294 }
309295
310−nowSpiderEventM :: (HasSpiderTimeline x) => EventM x (R.Event (SpiderTimeline x) ())
311−nowSpiderEventM =
312− SpiderEvent <$> now
313−
314−now :: (MonadIO m, Defer (Some Clear) m, HasSpiderTimeline x
315− ) => m (Event x ())
316−now = do
317− nowOrNot <- liftIO $ newIORef $ Just ()
318− scheduleClear nowOrNot
319− return . Event $ \_ -> do
320− occ <- liftIO . readIORef $ nowOrNot
321− return ( EventSubscription (return ()) eventSubscribedNow
322− , occ
323− )
324−
325296-- | Construct an 'Event' whose value is guaranteed not to be recomputed
326297-- repeatedly
327298--
@@ -346,23 +317,18 @@ cacheEvent e =
346317 subscribedTicket <- liftIO (readIORef mSubscribedRef >>= getFastWeakTicket) >>= \case
347318 Just subscribedTicket -> return subscribedTicket
348319 Nothing -> do
349−#ifdef DEBUG_NODEIDS
350− nodeId <- liftIO newNodeId
351−#endif
352320 subscribers <- liftIO FastWeakBag.empty
353321 occRef <- liftIO $ newIORef Nothing -- This should never be read prior to being set below
354−#ifdef DEBUG_NODEIDS
355− (parentSub, occ) <- subscribeAndRead e $ debugSubscriber' ("cacheEvent" <> showNodeId' nodeId) $ Subscriber
356−#else
357322 (parentSub, occ) <- subscribeAndRead e $ Subscriber
358−#endif
359− { subscriberPropagate = \a -> do
360− liftIO $ writeIORef occRef (Just a)
361− scheduleClear occRef
362− propagateFast a subscribers
363− , subscriberInvalidateHeight = FastWeakBag.traverse_ subscribers . invalidateSubscriberHeight
364− , subscriberRecalculateHeight = FastWeakBag.traverse_ subscribers . recalculateSubscriberHeight
365− }
323+ { subscriberPropagate = \a -> do
324+ liftIO $ writeIORef occRef $ Just a
325+ scheduleClear occRef
326+ propagateFast a subscribers
327+ , subscriberInvalidateHeight = \old -> do
328+ FastWeakBag.traverse subscribers $ invalidateSubscriberHeight old
329+ , subscriberRecalculateHeight = \new -> do
330+ FastWeakBag.traverse subscribers $ recalculateSubscriberHeight new
331+ }
366332 when (isJust occ) $ do
367333 liftIO $ writeIORef occRef occ -- Set the initial value of occRef; we don't need to do this if occ is Nothing
368334 scheduleClear occRef
@@ -370,45 +336,29 @@ cacheEvent e =
370336 { _cacheSubscribed_subscribers = subscribers
371337 , _cacheSubscribed_parent = parentSub
372338 , _cacheSubscribed_occurrence = occRef
373−#ifdef DEBUG_NODEIDS
374− , _cacheSubscribed_nodeId = nodeId
375−#endif
376339 }
377340 subscribedTicket <- liftIO $ mkFastWeakTicket subscribed
378341 liftIO $ writeIORef mSubscribedRef =<< getFastWeakTicketWeak subscribedTicket
379342 return subscribedTicket
380− liftIO $ cacheSubscription sub mSubscribedRef subscribedTicket
381−
382−cacheSubscription :: Subscriber x a -> IORef (FastWeak (CacheSubscribed x a))
383− -> FastWeakTicket (CacheSubscribed x a) -> IO (EventSubscription x, Maybe a)
384−cacheSubscription sub mSubscribedRef subscribedTicket = do
385− subscribed <- getFastWeakTicketValue subscribedTicket
386− ticket <- FastWeakBag.insert sub $ _cacheSubscribed_subscribers subscribed
387− occ <- readIORef $ _cacheSubscribed_occurrence subscribed
388−
389− let parentSub = _cacheSubscribed_parent subscribed
390− es = EventSubscription
391− { _eventSubscription_unsubscribe = do
392− FastWeakBag.remove ticket
393−
394− isEmpty <- FastWeakBag.isEmpty $ _cacheSubscribed_subscribers subscribed
395− when isEmpty $ do
396− writeIORef mSubscribedRef emptyFastWeak
397− unsubscribe parentSub
398− touch ticket
399− touch subscribedTicket
400− , _eventSubscription_subscribed = EventSubscribed
401− { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed parentSub
402− , eventSubscribedRetained = toAny subscribedTicket
403−#ifdef DEBUG_CYCLES
404− , eventSubscribedGetParents = return [_eventSubscription_subscribed parentSub]
405− , eventSubscribedHasOwnHeightRef = False
406− , eventSubscribedWhoCreated = whoCreatedIORef mSubscribedRef
407−#endif
408− }
409− }
410− return (es, occ)
411−
343+ liftIO $ do
344+ subscribed <- getFastWeakTicketValue subscribedTicket
345+ ticket <- FastWeakBag.insert sub $ _cacheSubscribed_subscribers subscribed
346+ occ <- readIORef $ _cacheSubscribed_occurrence subscribed
347+ let es = EventSubscription
348+ { _eventSubscription_unsubscribe = do
349+ FastWeakBag.remove ticket
350+ isEmpty <- FastWeakBag.isEmpty $ _cacheSubscribed_subscribers subscribed
351+ when isEmpty $ do
352+ writeIORef mSubscribedRef emptyFastWeak
353+ unsubscribe $ _cacheSubscribed_parent subscribed
354+ touch ticket
355+ touch subscribedTicket
356+ , _eventSubscription_subscribed = EventSubscribed
357+ { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed $ _cacheSubscribed_parent subscribed
358+ , eventSubscribedRetained = toAny subscribedTicket
359+ }
360+ }
361+ return (es, occ)
412362
413363subscribe :: Event x a -> Subscriber x a -> EventM x (EventSubscription x)
414364subscribe e s = fst <$> subscribeAndRead e s
@@ -420,14 +370,11 @@ wrap tag getSpecificSubscribed sub = do
420370 let es = tag subd
421371 return (EventSubscription (WeakBag.remove sln >> touch sln) es, occ)
422372
423−eventRoot :: (GCompare k, HasSpiderTimeline x) => k a -> Root x k -> Event x a
373+eventRoot :: GCompare k => k a -> Root x k -> Event x a
424374eventRoot !k !r = Event $ wrap eventSubscribedRoot $ liftIO . getRootSubscribed k r
425375
426−subscribeAndReadNever :: EventM x (EventSubscription x, Maybe a)
427−subscribeAndReadNever = return (EventSubscription (return ()) eventSubscribedNever, Nothing)
428−
429376eventNever :: Event x a
430−eventNever = Event $ const subscribeAndReadNever
377+eventNever = Event $ \_ -> return (EventSubscription (return ()) eventSubscribedNever, Nothing)
431378
432379eventFan :: (GCompare k, HasSpiderTimeline x) => k a -> Fan x k v -> Event x (v a)
433380eventFan !k !f = Event $ wrap eventSubscribedFan $ getFanSubscribed k f
@@ -464,6 +411,16 @@ data Subscriber x a = Subscriber
464411 , subscriberRecalculateHeight :: !(Height -> IO ())
465412 }
466413
414+--TODO: Move this comment to WeakBag
415+-- These function are constructor functions that are marked NOINLINE so they are
416+-- opaque to GHC. If we do not do this, then GHC will sometimes fuse the constructor away
417+-- so any weak references that are attached to the constructors will have their
418+-- finalizer run. Using the opaque constructor, does not see the
419+-- constructor application, so it behaves like an IORef and cannot be fused away.
420+--
421+-- The result is also evaluated to WHNF, since forcing a thunk invalidates
422+-- the weak pointer to it in some cases.
423+
467424newSubscriberHold :: (HasSpiderTimeline x, Patch p) => Hold x p -> IO (Subscriber x p)
468425newSubscriberHold h = return $ Subscriber
469426 { subscriberPropagate = {-# SCC "traverseHold" #-} propagateSubscriberHold h
@@ -472,10 +429,10 @@ newSubscriberHold h = return $ Subscriber
472429 }
473430
474431newSubscriberFan :: forall x k v. (HasSpiderTimeline x, GCompare k) => FanSubscribed x k v -> IO (Subscriber x (DMap k v))
475−newSubscriberFan subscribed = debugSubscriber ("SubscriberFan " <> showNodeId subscribed) $ Subscriber
432+newSubscriberFan subscribed = return $ Subscriber
476433 { subscriberPropagate = \a -> {-# SCC "traverseFan" #-} do
477434 subs <- liftIO $ readIORef $ fanSubscribedSubscribers subscribed
478− tracePropagate (Proxy :: Proxy x) $ show (DMap.size subs) <> " keys subscribed, " <> show (DMap.size a) <> " keys firing"
435+ tracePropagate (Proxy :: Proxy x) $ "SubscriberFan" <> showNodeId subscribed <> ": " ++ show (DMap.size subs) ++ " keys subscribed, " ++ show (DMap.size a) ++ " keys firing"
479436 liftIO $ writeIORef (fanSubscribedOccurrence subscribed) $ Just a
480437 scheduleClear $ fanSubscribedOccurrence subscribed
481438 let f _ (Pair v subsubs) = do
@@ -484,55 +441,72 @@ newSubscriberFan subscribed = debugSubscriber ("SubscriberFan " <> showNodeId su
484441 _ <- DMap.traverseWithKey f $ DMap.intersectionWithKey (\_ -> Pair) a subs --TODO: Would be nice to have DMap.traverse_
485442 return ()
486443 , subscriberInvalidateHeight = \old -> do
444+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberFan" <> showNodeId subscribed
487445 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
488− forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse_ (_fanSubscribedChildren_list v) $ invalidateSubscriberHeight old
446+ forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse (_fanSubscribedChildren_list v) $ invalidateSubscriberHeight old
447+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberFan" <> showNodeId subscribed <> " done"
489448 , subscriberRecalculateHeight = \new -> do
449+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberFan" <> showNodeId subscribed
490450 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
491− forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse_ (_fanSubscribedChildren_list v) $ recalculateSubscriberHeight new
451+ forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse (_fanSubscribedChildren_list v) $ recalculateSubscriberHeight new
452+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberFan" <> showNodeId subscribed <> " done"
492453 }
493454
494455newSubscriberSwitch :: forall x a. HasSpiderTimeline x => SwitchSubscribed x a -> IO (Subscriber x a)
495−newSubscriberSwitch subscribed = debugSubscriber ("SubscriberCoincidenceOuter" <> showNodeId subscribed) $ Subscriber
456+newSubscriberSwitch subscribed = return $ Subscriber
496457 { subscriberPropagate = \a -> {-# SCC "traverseSwitch" #-} do
458+ tracePropagate (Proxy :: Proxy x) $ "SubscriberSwitch" <> showNodeId subscribed
497459 liftIO $ writeIORef (switchSubscribedOccurrence subscribed) $ Just a
498460 scheduleClear $ switchSubscribedOccurrence subscribed
499461 propagate a $ switchSubscribedSubscribers subscribed
500462 , subscriberInvalidateHeight = \_ -> do
463+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed
501464 oldHeight <- readIORef $ switchSubscribedHeight subscribed
502465 when (oldHeight /= invalidHeight) $ do
503466 writeIORef (switchSubscribedHeight subscribed) $! invalidHeight
504− WeakBag.traverse_ (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
505− , subscriberRecalculateHeight = (`updateSwitchHeight` subscribed)
506− }
467+ WeakBag.traverse (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
468+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed <> " done"
469+ , subscriberRecalculateHeight = \new -> do
470+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed
471+ updateSwitchHeight new subscribed
472+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed <> " done"
473+ }
507474
508475newSubscriberCoincidenceOuter :: forall x b. HasSpiderTimeline x => CoincidenceSubscribed x b -> IO (Subscriber x (Event x b))
509−newSubscriberCoincidenceOuter subscribed = debugSubscriber ("SubscriberCoincidenceOuter" <> showNodeId subscribed) $ Subscriber
476+newSubscriberCoincidenceOuter subscribed = return $ Subscriber
510477 { subscriberPropagate = \a -> {-# SCC "traverseCoincidenceOuter" #-} do
478+ tracePropagate (Proxy :: Proxy x) $ "SubscriberCoincidenceOuter" <> showNodeId subscribed
511479 outerHeight <- liftIO $ readIORef $ coincidenceSubscribedHeight subscribed
512480 tracePropagate (Proxy :: Proxy x) $ " outerHeight = " <> show outerHeight
513481 (occ, innerHeight, innerSubd) <- subscribeCoincidenceInner a outerHeight subscribed
514482 tracePropagate (Proxy :: Proxy x) $ " isJust occ = " <> show (isJust occ)
515483 tracePropagate (Proxy :: Proxy x) $ " innerHeight = " <> show innerHeight
516−
517484 liftIO $ writeIORef (coincidenceSubscribedInnerParent subscribed) $ Just innerSubd
518485 scheduleClear $ coincidenceSubscribedInnerParent subscribed
519486 case occ of
520− Nothing ->
487+ Nothing -> do
521488 when (innerHeight > outerHeight) $ liftIO $ do -- If the event fires, it will fire at a later height
522489 writeIORef (coincidenceSubscribedHeight subscribed) $! innerHeight
523− WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight outerHeight
524− WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ recalculateSubscriberHeight innerHeight
490+ WeakBag.traverse (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight outerHeight
491+ WeakBag.traverse (coincidenceSubscribedSubscribers subscribed) $ recalculateSubscriberHeight innerHeight
525492 Just o -> do -- Since it's already firing, no need to adjust height
526493 liftIO $ writeIORef (coincidenceSubscribedOccurrence subscribed) occ
527494 scheduleClear $ coincidenceSubscribedOccurrence subscribed
528495 propagate o $ coincidenceSubscribedSubscribers subscribed
529− , subscriberInvalidateHeight = \_ -> invalidateCoincidenceHeight subscribed
530− , subscriberRecalculateHeight = \_ -> recalculateCoincidenceHeight subscribed
496+ , subscriberInvalidateHeight = \_ -> do
497+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed
498+ invalidateCoincidenceHeight subscribed
499+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed <> " done"
500+ , subscriberRecalculateHeight = \_ -> do
501+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed
502+ recalculateCoincidenceHeight subscribed
503+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed <> " done"
531504 }
532505
533506newSubscriberCoincidenceInner :: forall x a. HasSpiderTimeline x => CoincidenceSubscribed x a -> IO (Subscriber x a)
534−newSubscriberCoincidenceInner subscribed = debugSubscriber ("SubscriberCoincidenceInner" <> showNodeId subscribed) $ Subscriber
507+newSubscriberCoincidenceInner subscribed = return $ Subscriber
535508 { subscriberPropagate = \a -> {-# SCC "traverseCoincidenceInner" #-} do
509+ tracePropagate (Proxy :: Proxy x) $ "SubscriberCoincidenceInner" <> showNodeId subscribed
536510 occ <- liftIO $ readIORef $ coincidenceSubscribedOccurrence subscribed
537511 case occ of
538512 Just _ -> return () -- SubscriberCoincidenceOuter must have already propagated this event
@@ -540,8 +514,14 @@ newSubscriberCoincidenceInner subscribed = debugSubscriber ("SubscriberCoinciden
540514 liftIO $ writeIORef (coincidenceSubscribedOccurrence subscribed) $ Just a
541515 scheduleClear $ coincidenceSubscribedOccurrence subscribed
542516 propagate a $ coincidenceSubscribedSubscribers subscribed
543− , subscriberInvalidateHeight = \_ -> invalidateCoincidenceHeight subscribed
544− , subscriberRecalculateHeight = \_ -> recalculateCoincidenceHeight subscribed
517+ , subscriberInvalidateHeight = \_ -> do
518+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed
519+ invalidateCoincidenceHeight subscribed
520+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed <> " done"
521+ , subscriberRecalculateHeight = \_ -> do
522+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed
523+ recalculateCoincidenceHeight subscribed
524+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed <> " done"
545525 }
546526
547527invalidateSubscriberHeight :: Height -> Subscriber x a -> IO ()
@@ -551,18 +531,18 @@ recalculateSubscriberHeight :: Height -> Subscriber x a -> IO ()
551531recalculateSubscriberHeight = flip subscriberRecalculateHeight
552532
553533-- | Propagate everything at the current height
554−propagate :: forall x a. HasSpiderTimeline x => a -> WeakBag (Subscriber x a) -> EventM x ()
555−propagate a subscribers = withIncreasedDepth (Proxy::Proxy x) $
534+propagate :: a -> WeakBag (Subscriber x a) -> EventM x ()
535+propagate a subscribers = withIncreasedDepth $ do
556536 -- Note: in the following traversal, we do not visit nodes that are added to the list during our traversal; they are new events, which will necessarily have full information already, so there is no need to traverse them
557537 --TODO: Should we check if nodes already have their values before propagating? Maybe we're re-doing work
558− WeakBag.traverse_ subscribers $ \s -> subscriberPropagate s a
538+ WeakBag.traverse subscribers $ \s -> subscriberPropagate s a
559539
560540-- | Propagate everything at the current height
561−propagateFast :: forall x a. HasSpiderTimeline x => a -> FastWeakBag (Subscriber x a) -> EventM x ()
562−propagateFast a subscribers = withIncreasedDepth (Proxy::Proxy x) $
541+propagateFast :: a -> FastWeakBag (Subscriber x a) -> EventM x ()
542+propagateFast a subscribers = withIncreasedDepth $ do
563543 -- Note: in the following traversal, we do not visit nodes that are added to the list during our traversal; they are new events, which will necessarily have full information already, so there is no need to traverse them
564544 --TODO: Should we check if nodes already have their values before propagating? Maybe we're re-doing work
565− FastWeakBag.traverse_ subscribers $ \s -> subscriberPropagate s a
545+ FastWeakBag.traverse subscribers $ \s -> subscriberPropagate s a
566546
567547--------------------------------------------------------------------------------
568548-- EventSubscribed
@@ -571,16 +551,11 @@ propagateFast a subscribers = withIncreasedDepth (Proxy::Proxy x) $
571551toAny :: a -> Any
572552toAny = unsafeCoerce
573553
574−-- Why do we use Any here, instead of just giving eventSubscribedRetained an
575−-- existential type? Sadly, GHC does not currently know how to unbox types
576−-- with existentially quantified fields. So instead we just coerce values
577−-- to type Any on the way in. Since we never coerce them back, this is
578−-- perfectly safe.
579554data EventSubscribed x = EventSubscribed
580555 { eventSubscribedHeightRef :: {-# UNPACK #-} !(IORef Height)
581556 , eventSubscribedRetained :: {-# NOUNPACK #-} !Any
582557#ifdef DEBUG_CYCLES
583− , eventSubscribedGetParents :: !(IO [EventSubscribed x]) -- For debugging loops
558+ , eventSubscribedGetParents :: !(IO [Some (EventSubscribed x)]) -- For debugging loops
584559 , eventSubscribedHasOwnHeightRef :: !Bool
585560 , eventSubscribedWhoCreated :: !(IO [String])
586561#endif
@@ -607,23 +582,13 @@ eventSubscribedNever = EventSubscribed
607582 , eventSubscribedWhoCreated = return ["never"]
608583#endif
609584 }
610−eventSubscribedNow :: EventSubscribed x
611−eventSubscribedNow = EventSubscribed
612− { eventSubscribedHeightRef = zeroRef
613− , eventSubscribedRetained = toAny ()
614−#ifdef DEBUG_CYCLES
615− , eventSubscribedGetParents = return []
616− , eventSubscribedHasOwnHeightRef = False
617− , eventSubscribedWhoCreated = return ["now"]
618−#endif
619− }
620585
621586eventSubscribedFan :: FanSubscribed x k v -> EventSubscribed x
622587eventSubscribedFan !subscribed = EventSubscribed
623588 { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed $ fanSubscribedParent subscribed
624589 , eventSubscribedRetained = toAny subscribed
625590#ifdef DEBUG_CYCLES
626− , eventSubscribedGetParents = return [_eventSubscription_subscribed $ fanSubscribedParent subscribed]
591+ , eventSubscribedGetParents = return [Some $ _eventSubscription_subscribed $ fanSubscribedParent subscribed]
627592 , eventSubscribedHasOwnHeightRef = False
628593 , eventSubscribedWhoCreated = whoCreatedIORef $ fanSubscribedCachedSubscribed subscribed
629594#endif
@@ -636,7 +601,7 @@ eventSubscribedSwitch !subscribed = EventSubscribed
636601#ifdef DEBUG_CYCLES
637602 , eventSubscribedGetParents = do
638603 s <- readIORef $ switchSubscribedCurrentParent subscribed
639− return [_eventSubscription_subscribed s]
604+ return [Some $ _eventSubscription_subscribed s]
640605 , eventSubscribedHasOwnHeightRef = True
641606 , eventSubscribedWhoCreated = whoCreatedIORef $ switchSubscribedCachedSubscribed subscribed
642607#endif
@@ -649,8 +614,8 @@ eventSubscribedCoincidence !subscribed = EventSubscribed
649614#ifdef DEBUG_CYCLES
650615 , eventSubscribedGetParents = do
651616 innerSubscription <- readIORef $ coincidenceSubscribedInnerParent subscribed
652− let outerParent = _eventSubscription_subscribed $ coincidenceSubscribedOuterParent subscribed
653− innerParents = maybeToList $ innerSubscription
617+ let outerParent = Some $ _eventSubscription_subscribed $ coincidenceSubscribedOuterParent subscribed
618+ innerParents = maybeToList $ fmap Some innerSubscription
654619 return $ outerParent : innerParents
655620 , eventSubscribedHasOwnHeightRef = True
656621 , eventSubscribedWhoCreated = whoCreatedIORef $ coincidenceSubscribedCachedSubscribed subscribed
@@ -664,15 +629,15 @@ getEventSubscribedHeight es = readIORef $ eventSubscribedHeightRef es
664629whoCreatedEventSubscribed :: EventSubscribed x -> IO [String]
665630whoCreatedEventSubscribed = eventSubscribedWhoCreated
666631
667−walkInvalidHeightParents :: EventSubscribed x -> IO [EventSubscribed x]
632+walkInvalidHeightParents :: EventSubscribed x -> IO [Some (EventSubscribed x)]
668633walkInvalidHeightParents s0 = do
669− subscribers <- flip execStateT mempty $ ($ s0) $ fix $ \loop s -> do
634+ subscribers <- flip execStateT mempty $ ($ Some s0) $ fix $ \loop (Some s) -> do
670635 h <- liftIO $ readIORef $ eventSubscribedHeightRef s
671636 when (h == invalidHeight) $ do
672637 when (eventSubscribedHasOwnHeightRef s) $ liftIO $ writeIORef (eventSubscribedHeightRef s) $! invalidHeightBeingTraversed
673− modify (s :)
638+ modify (Some s :)
674639 mapM_ loop =<< liftIO (eventSubscribedGetParents s)
675− forM_ subscribers $ \s -> writeIORef (eventSubscribedHeightRef s) $! invalidHeight
640+ forM_ subscribers $ \(Some s) -> writeIORef (eventSubscribedHeightRef s) $! invalidHeight
676641 return subscribers
677642#endif
678643
@@ -709,7 +674,7 @@ behaviorPull !p = Behavior $ do
709674 wi <- liftIO $ mkWeakPtrWithDebug i "InvalidatorPull"
710675 parentsRef <- liftIO $ newIORef []
711676 holdInits <- askBehaviorHoldInits
712− a <- liftIO $ runReaderIO (unBehaviorM $ pullCompute p) (Just (wi, parentsRef), holdInits)
677+ a <- liftIO $ runReaderT (unBehaviorM $ pullCompute p) (Just (wi, parentsRef), holdInits)
713678 invsRef <- liftIO . newIORef . maybeToList =<< askInvalidator
714679 parents <- liftIO $ readIORef parentsRef
715680 let subscribed = PullSubscribed
@@ -744,46 +709,42 @@ readBehaviorUntracked b = do
744709-- Dynamic
745710--------------------------------------------------------------------------------
746711
747−type DynamicS x p = Dynamic x (PatchTarget p) p
748−
749−data Dynamic x target p = Dynamic
750− { dynamicCurrent :: !(Behavior x target)
712+data Dynamic x p = Dynamic
713+ { dynamicCurrent :: !(Behavior x (PatchTarget p))
751714 , dynamicUpdated :: Event x p -- This must be lazy; see the comment on holdEvent --TODO: Would this let us eliminate `Dyn`?
752715 }
753716
754−deriving instance (HasSpiderTimeline x) => Functor (Dynamic x target)
755−
756−
757−
758−
759−dynamicHold :: Hold x p -> DynamicS x p
717+dynamicHold :: Hold x p -> Dynamic x p
760718dynamicHold !h = Dynamic
761719 { dynamicCurrent = behaviorHold h
762720 , dynamicUpdated = eventHold h
763721 }
764722
765−dynamicHoldIdentity :: Hold x (Identity a) -> DynamicS x (Identity a)
723+dynamicHoldIdentity :: Hold x (Identity a) -> Dynamic x (Identity a)
766724dynamicHoldIdentity = dynamicHold
767725
768−dynamicConst :: PatchTarget p -> DynamicS x p
726+dynamicConst :: PatchTarget p -> Dynamic x p
769727dynamicConst !a = Dynamic
770728 { dynamicCurrent = behaviorConst a
771729 , dynamicUpdated = eventNever
772730 }
773731
774−dynamicDyn :: (HasSpiderTimeline x, Patch p) => Dyn x p -> DynamicS x p
732+dynamicDyn :: (HasSpiderTimeline x, Patch p) => Dyn x p -> Dynamic x p
775733dynamicDyn !d = Dynamic
776734 { dynamicCurrent = behaviorDyn d
777735 , dynamicUpdated = eventDyn d
778736 }
779737
780−dynamicDynIdentity :: HasSpiderTimeline x => Dyn x (Identity a) -> DynamicS x (Identity a)
738+dynamicDynIdentity :: HasSpiderTimeline x => Dyn x (Identity a) -> Dynamic x (Identity a)
781739dynamicDynIdentity = dynamicDyn
782740
783741--------------------------------------------------------------------------------
784742-- Combinators
785743--------------------------------------------------------------------------------
786744
745+--TODO: Figure out why certain things are not 'representational', then make them
746+--representational so we can use coerce
747+
787748--type role Hold representational
788749data Hold x p
789750 = Hold { holdValue :: !(IORef (PatchTarget p))
@@ -804,25 +765,20 @@ globalSpiderTimelineEnv = unsafePerformIO unsafeNewSpiderTimelineEnv
804765
805766-- | Stores all global data relevant to a particular Spider timeline; only one
806767-- value should exist for each type @x@
807−newtype SpiderTimelineEnv x = STE {unSTE :: SpiderTimelineEnv' x}
808−-- We implement SpiderTimelineEnv with a newtype wrapper so
809−-- we can get the coercions we want safely.
810−type role SpiderTimelineEnv nominal
811−
812−data SpiderTimelineEnv' x = SpiderTimelineEnv
768+data SpiderTimelineEnv x = SpiderTimelineEnv
813769 { _spiderTimeline_lock :: {-# UNPACK #-} !(MVar ())
814770 , _spiderTimeline_eventEnv :: {-# UNPACK #-} !(EventEnv x)
815771#ifdef DEBUG
816772 , _spiderTimeline_depth :: {-# UNPACK #-} !(IORef Int)
817773#endif
818774 }
819−type role SpiderTimelineEnv' phantom
775+type role SpiderTimelineEnv nominal
820776
821777instance Eq (SpiderTimelineEnv x) where
822778 _ == _ = True -- Since only one exists of each type
823779
824780instance GEq SpiderTimelineEnv where
825− a `geq` b = if _spiderTimeline_lock (unSTE a) == _spiderTimeline_lock (unSTE b)
781+ a `geq` b = if _spiderTimeline_lock a == _spiderTimeline_lock b
826782 then Just $ unsafeCoerce Refl -- This unsafeCoerce is safe because the same SpiderTimelineEnv can't have two different 'x' arguments
827783 else Nothing
828784
@@ -845,7 +801,7 @@ runEventM :: EventM x a -> IO a
845801runEventM = unEventM
846802
847803asksEventEnv :: forall x a. HasSpiderTimeline x => (EventEnv x -> a) -> EventM x a
848−asksEventEnv f = return $ f $ _spiderTimeline_eventEnv (unSTE (spiderTimeline :: SpiderTimelineEnv x))
804+asksEventEnv f = return $ f $ _spiderTimeline_eventEnv (spiderTimeline :: SpiderTimelineEnv x)
849805
850806class MonadIO m => Defer a m where
851807 getDeferralQueue :: m (IORef [a])
@@ -983,9 +939,9 @@ getHoldEventSubscription h = do
983939
984940type BehaviorEnv x = (Maybe (Weak (Invalidator x), IORef [SomeBehaviorSubscribed x]), IORef [SomeHoldInit x])
985941
942+--type role BehaviorM representational
986943-- BehaviorM can sample behaviors
987−newtype BehaviorM x a = BehaviorM { unBehaviorM :: ReaderIO (BehaviorEnv x) a }
988− deriving (Functor, Applicative, MonadIO, MonadFix, MonadReader (BehaviorEnv x))
944+newtype BehaviorM x a = BehaviorM { unBehaviorM :: ReaderT (BehaviorEnv x) IO a } deriving (Functor, Applicative, MonadIO, MonadFix)
989945
990946instance Monad (BehaviorM x) where
991947 {-# INLINE (>>=) #-}
@@ -994,10 +950,8 @@ instance Monad (BehaviorM x) where
994950 BehaviorM x >> BehaviorM y = BehaviorM $ x >> y
995951 {-# INLINE return #-}
996952 return x = BehaviorM $ return x
997−#if !MIN_VERSION_base(4,13,0)
998953 {-# INLINE fail #-}
999954 fail s = BehaviorM $ fail s
1000−#endif
1001955
1002956data BehaviorSubscribed x a
1003957 = forall p. BehaviorSubscribedHold (Hold x p)
@@ -1057,7 +1011,7 @@ data SomeMergeUpdate x = SomeMergeUpdate
10571011newtype SomeMergeInit x = SomeMergeInit { unSomeMergeInit :: EventM x () }
10581012
10591013-- EventM can do everything BehaviorM can, plus create holds
1060−newtype EventM x a = EventM { unEventM :: IO a } deriving (Functor, Applicative, Monad, MonadIO, MonadFix, MonadException, MonadAsyncException)
1014+newtype EventM x a = EventM { unEventM :: IO a } deriving (Functor, Applicative, Monad, MonadIO, MonadFix, MonadException, MonadAsyncException) -- The environment should be Nothing if we are not in a frame, and Just if we are - in which case it is a list of assignments to be done after the frame is over
10611015
10621016newtype MergeSubscribedParent x a = MergeSubscribedParent { unMergeSubscribedParent :: EventSubscription x }
10631017
@@ -1082,8 +1036,7 @@ heightBagFromList :: [Height] -> HeightBag
10821036heightBagFromList heights = heightBagVerify $ foldl' (flip heightBagAdd) heightBagEmpty heights
10831037
10841038heightBagAdd :: Height -> HeightBag -> HeightBag
1085−heightBagAdd (Height h) (HeightBag s c) = heightBagVerify $ HeightBag (succ s) $
1086− IntMap.insertWithKey (\_ _ old -> succ old) h 0 c
1039+heightBagAdd (Height h) (HeightBag s c) = heightBagVerify $ HeightBag (succ s) $ IntMap.insertWithKey (\_ _ old -> succ old) h 0 c
10871040
10881041heightBagRemove :: Height -> HeightBag -> HeightBag
10891042heightBagRemove (Height h) b@(HeightBag s c) = heightBagVerify $ case IntMap.lookup h c of
@@ -1092,13 +1045,6 @@ heightBagRemove (Height h) b@(HeightBag s c) = heightBagVerify $ case IntMap.loo
10921045 0 -> IntMap.delete h c
10931046 _ -> IntMap.insert h (pred old) c
10941047
1095−heightBagRemoveMaybe :: Height -> HeightBag -> Maybe HeightBag
1096−heightBagRemoveMaybe (Height h) b@(HeightBag s c) = heightBagVerify . removed <$> IntMap.lookup h c where
1097− removed old = HeightBag (pred s) $ case old of
1098− 0 -> IntMap.delete h c
1099− _ -> IntMap.insert h (pred old) c
1100−
1101−
11021048heightBagMax :: HeightBag -> Height
11031049heightBagMax (HeightBag _ c) = case IntMap.maxViewWithKey c of
11041050 Just ((h, _), _) -> Height h
@@ -1199,10 +1145,7 @@ instance HasSpiderTimeline x => Semialign (Event x) where
11991145 align ea eb = mapMaybe dmapToThese $ mergeG coerce $ dynamicConst $
12001146 DMap.fromDistinctAscList [LeftTag :=> ea, RightTag :=> eb]
12011147
1202−#ifdef MIN_VERSION_semialign
1203−#if MIN_VERSION_semialign(1,1,0)
1204−instance HasSpiderTimeline x => Zip (Event x) where
1205−#endif
1148+#if defined(MIN_VERSION_semialign)
12061149 zip x y = mapMaybe justThese $ align x y
12071150#endif
12081151
@@ -1212,11 +1155,11 @@ data DynType x p = UnsafeDyn !(BehaviorM x (PatchTarget p), Event x p)
12121155
12131156newtype Dyn (x :: Type) p = Dyn { unDyn :: IORef (DynType x p) }
12141157
1215−newMapDyn :: HasSpiderTimeline x => (a -> b) -> DynamicS x (Identity a) -> DynamicS x (Identity b)
1158+newMapDyn :: HasSpiderTimeline x => (a -> b) -> Dynamic x (Identity a) -> Dynamic x (Identity b)
12161159newMapDyn f d = dynamicDynIdentity $ unsafeBuildDynamic (fmap f $ readBehaviorTracked $ dynamicCurrent d) (Identity . f . runIdentity <$> dynamicUpdated d)
12171160
12181161--TODO: Avoid the duplication between this and R.zipDynWith
1219−zipDynWith :: HasSpiderTimeline x => (a -> b -> c) -> DynamicS x (Identity a) -> DynamicS x (Identity b) -> DynamicS x (Identity c)
1162+zipDynWith :: HasSpiderTimeline x => (a -> b -> c) -> Dynamic x (Identity a) -> Dynamic x (Identity b) -> Dynamic x (Identity c)
12201163zipDynWith f da db =
12211164 let eab = align (dynamicUpdated da) (dynamicUpdated db)
12221165 ec = flip push eab $ \o -> do
@@ -1292,7 +1235,7 @@ run :: forall x b. HasSpiderTimeline x => [DSum (RootTrigger x) Identity] -> Res
12921235run roots after = do
12931236 tracePropagate (Proxy :: Proxy x) $ "Running an event frame with " <> show (length roots) <> " events"
12941237 let t = spiderTimeline :: SpiderTimelineEnv x
1295− result <- SpiderHost $ withMVar (_spiderTimeline_lock (unSTE t)) $ \_ -> unSpiderHost $ runFrame $ do
1238+ result <- SpiderHost $ withMVar (_spiderTimeline_lock t) $ \_ -> unSpiderHost $ runFrame $ do
12961239 rootsToPropagate <- forM roots $ \r@(RootTrigger (_, occRef, k) :=> a) -> do
12971240 occBefore <- liftIO $ do
12981241 occBefore <- readIORef occRef
@@ -1346,110 +1289,55 @@ mkWeakPtrWithDebug x debugNote = do
13461289 x' <- evaluate x
13471290 mkWeakPtr x' $
13481291 if debugFinalize
1349− then Just $ debugStrLn $ "finalizing: " ++ debugNote
1292+ then Just $ putStrLn $ "finalizing: " ++ debugNote
13501293 else Nothing
13511294
13521295type WeakList a = [Weak a]
13531296
1354−type CanTrace x m = (HasSpiderTimeline x, MonadIO m)
1355−
1356−
1357−
1358−
1359−#ifdef DEBUG
1360−
1361−debugSubscriber :: forall x a. HasSpiderTimeline x => String -> Subscriber x a -> IO (Subscriber x a)
1362−debugSubscriber description = return . debugSubscriber' description
1363−
1364−debugSubscriber' :: forall x a. HasSpiderTimeline x => String -> Subscriber x a -> Subscriber x a
1365−debugSubscriber' description subscribed = Subscriber
1366− {
1367− subscriberPropagate = \m -> do
1368− tracePropagate (Proxy :: Proxy x) ("subscriberPropagate: " <> description)
1369− subscriberPropagate subscribed m
1370− , subscriberInvalidateHeight = \old -> do
1371− traceInvalidateHeight $ "invalidateSubscriberHeight: " <> description <> ", old = " <> show (unHeight old)
1372− subscriberInvalidateHeight subscribed old
1373− traceInvalidateHeight $ "invalidateSubscriberHeight: " <> description <> ", done"
1374− , subscriberRecalculateHeight = \new -> do
1375− traceInvalidateHeight $ "subscriberRecalculateHeight: " <> description <> ", new = " <> show (unHeight new)
1376− subscriberRecalculateHeight subscribed new
1377− traceInvalidateHeight $ "subscriberRecalculateHeight: " <> description <> ", done"
1378− }
1379−
1380−
13811297{-# INLINE withIncreasedDepth #-}
1382−withIncreasedDepth :: forall proxy x m a. CanTrace x m => proxy x -> m a -> m a
1383−withIncreasedDepth _ a = do
1384− liftIO $ modifyIORef' (_spiderTimeline_depth $ unSTE (spiderTimeline :: SpiderTimelineEnv x)) succ
1298+#ifdef DEBUG
1299+withIncreasedDepth :: CanTrace x m => m a -> m a
1300+withIncreasedDepth a = do
1301+ spiderTimeline <- askSpiderTimelineEnv
1302+ liftIO $ modifyIORef' (_spiderTimeline_depth spiderTimeline) succ
13851303 result <- a
1386− liftIO $ modifyIORef' (_spiderTimeline_depth $ unSTE (spiderTimeline :: SpiderTimelineEnv x)) pred
1304+ liftIO $ modifyIORef' (_spiderTimeline_depth spiderTimeline) pred
13871305 return result
1388−
1389−{-# INLINE tracePropagate #-}
1390−tracePropagate :: (CanTrace x m) => proxy x -> String -> m ()
1391−tracePropagate p = when debugPropagate . trace p
1392−
1393−{-# INLINE traceInvalidate #-}
1394−traceInvalidate :: String -> IO ()
1395−traceInvalidate = when debugInvalidate . liftIO . debugStrLn
1396−
1397−{-# INLINE traceInvalidateHeight #-}
1398−traceInvalidateHeight :: String -> IO ()
1399−traceInvalidateHeight = when debugInvalidateHeight . liftIO . debugStrLn
1400−
1401−{-# INLINE trace #-}
1402−trace :: (CanTrace x m) => proxy x -> String -> m ()
1403−trace p message = traceM p $ return message
1404−
1405−{-# INLINE traceM #-}
1406−traceM :: forall x proxy m. (CanTrace x m) => proxy x -> m String -> m ()
1407−traceM _ getMessage = do
1408− message <- getMessage
1409− d <- liftIO $ readIORef $ _spiderTimeline_depth $ unSTE (spiderTimeline :: SpiderTimelineEnv x)
1410− liftIO $ debugStrLn $ replicate d ' ' <> message
1411−
14121306#else
1307+withIncreasedDepth :: m a -> m a
1308+withIncreasedDepth = id
1309+#endif
14131310
1414−{-# INLINE withIncreasedDepth #-}
1415−withIncreasedDepth :: proxy x -> m a -> m a
1416−withIncreasedDepth _ = id
1311+type CanTrace x m = (HasSpiderTimeline x, MonadIO m)
14171312
14181313{-# INLINE tracePropagate #-}
14191314tracePropagate :: (CanTrace x m) => proxy x -> String -> m ()
1420−tracePropagate _ _ = return ()
1315+tracePropagate p = traceWhen p debugPropagate
14211316
14221317{-# INLINE traceInvalidate #-}
14231318traceInvalidate :: String -> IO ()
1424−traceInvalidate _ = return ()
1425−
1426−{-# INLINE traceInvalidateHeight #-}
1427−traceInvalidateHeight :: String -> IO ()
1428−traceInvalidateHeight _ = return ()
1319+traceInvalidate = when debugInvalidate . liftIO . putStrLn
14291320
1430−{-# INLINE debugSubscriber #-}
1431−debugSubscriber :: String -> Subscriber x a -> IO (Subscriber x a)
1432−debugSubscriber _ = return
1433−
1434−{-# INLINE debugSubscriber' #-}
1435−debugSubscriber' :: String -> Subscriber x a -> Subscriber x a
1436−debugSubscriber' _ = id
1437−
1438−
1439−
1440−{-# INLINE trace #-}
1441−trace :: (CanTrace x m) => proxy x -> String -> m ()
1442−trace _ _ = return ()
1443−
1444−{-# INLINE traceM #-}
1445−traceM :: (CanTrace x m) => proxy x -> m String -> m ()
1446−traceM _ _ = return ()
1321+{-# INLINE traceWhen #-}
1322+traceWhen :: (CanTrace x m) => proxy x -> Bool -> String -> m ()
1323+traceWhen p b message = traceMWhen p b $ return message
14471324
1325+{-# INLINE traceMWhen #-}
1326+traceMWhen :: (CanTrace x m) => proxy x -> Bool -> m String -> m ()
1327+traceMWhen _ b getMessage = when b $ do
1328+ message <- getMessage
1329+#ifdef DEBUG
1330+ spiderTimeline <- askSpiderTimelineEnv
1331+ d <- liftIO $ readIORef $ _spiderTimeline_depth spiderTimeline
1332+#else
1333+ let d = 0
14481334#endif
1335+ liftIO $ putStrLn $ replicate d ' ' <> message
14491336
14501337whoCreatedIORef :: IORef a -> IO [String]
14511338whoCreatedIORef (IORef a) = whoCreated $! a
14521339
1340+#ifdef DEBUG_CYCLES
14531341groupByHead :: Eq a => [NonEmpty a] -> [(a, NonEmpty [a])]
14541342groupByHead = \case
14551343 [] -> []
@@ -1460,54 +1348,20 @@ groupByHead = \case
14601348 | otherwise -> (x, xs :| []) : l
14611349
14621350listsToForest :: Eq a => [[a]] -> Forest a
1463−listsToForest lists = buildForest <$> groupByHead (mapMaybe nonEmpty lists)
1464− where buildForest (a, lists') = Node a $ listsToForest $ toList lists'
1465−
1466−showStacks :: [[String]] -> String
1467−showStacks = drawForest . listsToForest . fmap (filterStack "Reflex.Spider.Internal")
1468−
1469−filterStack :: String -> [String] -> [String]
1470−#ifdef DEBUG_HIDE_INTERNALS
1471−filterStack prefix = filter (not . (prefix `isPrefixOf`))
1472−#else
1473−filterStack prefix = id
1351+listsToForest l = fmap (\(a, l') -> Node a $ listsToForest $ toList l') $ groupByHead $ catMaybes $ fmap nonEmpty l
14741352#endif
14751353
1476−#ifdef DEBUG_CYCLES
1477−
1478−data EventLoopException = EventLoopException [[String]]
1479−instance Exception EventLoopException
1480−
1481−instance Show EventLoopException where
1482− show (EventLoopException stacks) = "causality loop detected:\n" <> if null stacks
1483− then "no location information, compile with profiling enabled for stack tree"
1484− else showStacks stacks
1485−
1486−#else
1487−
1488−data EventLoopException = EventLoopException
1489−instance Exception EventLoopException
1490−
1491−instance Show EventLoopException where
1492− show EventLoopException = "causality loop detected: \n" <>
1493− "compile reflex with flag 'debug-cycles' and compile with profiling enabled for stack tree"
1494−
1495−#endif
1496−
1497−
14981354{-# INLINE propagateSubscriberHold #-}
14991355propagateSubscriberHold :: forall x p. (HasSpiderTimeline x, Patch p) => Hold x p -> p -> EventM x ()
15001356propagateSubscriberHold h a = do
1501− {-# SCC "trace" #-} when debugPropagate $ traceM (Proxy :: Proxy x) $ liftIO $ do
1357+ {-# SCC "trace" #-} traceMWhen (Proxy :: Proxy x) debugPropagate $ liftIO $ do
15021358 invalidators <- liftIO $ readIORef $ holdInvalidators h
15031359 return $ "SubscriberHold" <> showNodeId h <> ": " ++ show (length invalidators)
1504−
15051360 v <- {-# SCC "read" #-} liftIO $ readIORef $ holdValue h
15061361 case {-# SCC "apply" #-} apply a v of
15071362 Nothing -> return ()
15081363 Just v' -> do
1509− {-# SCC "trace2" #-} withIncreasedDepth (Proxy :: Proxy x) $
1510− tracePropagate (Proxy :: Proxy x) ("propagateSubscriberHold: assigning Hold" <> showNodeId h)
1364+ {-# SCC "trace2" #-} withIncreasedDepth $ tracePropagate (Proxy :: Proxy x) $ "propagateSubscriberHold: assigning Hold" <> showNodeId h
15111365 vRef <- {-# SCC "vRef" #-} liftIO $ evaluate $ holdValue h
15121366 iRef <- {-# SCC "iRef" #-} liftIO $ evaluate $ holdInvalidators h
15131367 defer $ {-# SCC "assignment" #-} SomeAssignment vRef iRef v'
@@ -1515,25 +1369,25 @@ propagateSubscriberHold h a = do
15151369data SomeResetCoincidence x = forall a. SomeResetCoincidence !(EventSubscription x) !(Maybe (CoincidenceSubscribed x a)) -- The CoincidenceSubscriber will be present only if heights need to be reset
15161370
15171371runBehaviorM :: BehaviorM x a -> Maybe (Weak (Invalidator x), IORef [SomeBehaviorSubscribed x]) -> IORef [SomeHoldInit x] -> IO a
1518−runBehaviorM a mwi holdInits = runReaderIO (unBehaviorM a) (mwi, holdInits)
1372+runBehaviorM a mwi holdInits = runReaderT (unBehaviorM a) (mwi, holdInits)
15191373
15201374askInvalidator :: BehaviorM x (Maybe (Weak (Invalidator x)))
15211375askInvalidator = do
1522− (!m, _) <- ask
1376+ (!m, _) <- BehaviorM ask
15231377 case m of
15241378 Nothing -> return Nothing
15251379 Just (!wi, _) -> return $ Just wi
15261380
15271381askParentsRef :: BehaviorM x (Maybe (IORef [SomeBehaviorSubscribed x]))
15281382askParentsRef = do
1529− (!m, _) <- ask
1383+ (!m, _) <- BehaviorM ask
15301384 case m of
15311385 Nothing -> return Nothing
15321386 Just (_, !p) -> return $ Just p
15331387
15341388askBehaviorHoldInits :: BehaviorM x (IORef [SomeHoldInit x])
15351389askBehaviorHoldInits = do
1536− (_, !his) <- ask
1390+ (_, !his) <- BehaviorM ask
15371391 return his
15381392
15391393{-# INLINE getDynHold #-}
@@ -1561,7 +1415,7 @@ getDynHold d = do
15611415zeroRef :: IORef Height
15621416zeroRef = unsafePerformIO $ newIORef zeroHeight
15631417
1564−getRootSubscribed :: forall k x a. (GCompare k, HasSpiderTimeline x) => k a -> Root x k -> Subscriber x a -> IO (WeakBagTicket, RootSubscribed x a, Maybe a)
1418+getRootSubscribed :: GCompare k => k a -> Root x k -> Subscriber x a -> IO (WeakBagTicket, RootSubscribed x a, Maybe a)
15651419getRootSubscribed k r sub = do
15661420 mSubscribed <- readIORef $ rootSubscribed r
15671421 let getOcc = fmap (coerce . DMap.lookup k) $ readIORef $ rootOccurrence r
@@ -1575,9 +1429,7 @@ getRootSubscribed k r sub = do
15751429 let !cached = rootSubscribed r
15761430 uninitRef <- newIORef $ error "getRootsubscribed: uninitRef not initialized"
15771431 (subs, sln) <- WeakBag.singleton sub weakSelf cleanupRootSubscribed
1578−
1579− tracePropagate (Proxy::Proxy x) $ "getRootSubscribed: calling rootInit"
1580−
1432+ when debugPropagate $ putStrLn $ "getRootSubscribed: calling rootInit"
15811433 uninit <- rootInit r k $ RootTrigger (subs, rootOccurrence r, k)
15821434 writeIORef uninitRef $! uninit
15831435#ifdef DEBUG_NODEIDS
@@ -1627,9 +1479,6 @@ data FanInt x a = FanInt
16271479 { _fanInt_subscribers :: {-# UNPACK #-} !(FastMutableIntMap (FastWeakBag (Subscriber x a))) --TODO: Clean up the keys in here when their child weak bags get empty --TODO: Remove our own subscription when the subscribers list is completely empty
16281480 , _fanInt_subscriptionRef :: {-# UNPACK #-} !(IORef (EventSubscription x)) -- This should have a valid subscription iff subscribers is non-empty
16291481 , _fanInt_occRef :: {-# UNPACK #-} !(IORef (IntMap a))
1630−#ifdef DEBUG_NODEIDS
1631− , _fanInt_nodeId :: {-# UNPACK #-} !Int
1632−#endif
16331482 }
16341483
16351484newFanInt :: IO (FanInt x a)
@@ -1637,16 +1486,10 @@ newFanInt = do
16371486 subscribers <- FastMutableIntMap.newEmpty --TODO: Clean up the keys in here when their child weak bags get empty --TODO: Remove our own subscription when the subscribers list is completely empty
16381487 subscriptionRef <- newIORef $ error "fanInt: no subscription"
16391488 occRef <- newIORef $ error "fanInt: no occurrence"
1640−#ifdef DEBUG_NODEIDS
1641− nodeId <- newNodeId
1642−#endif
16431489 return $ FanInt
16441490 { _fanInt_subscribers = subscribers
16451491 , _fanInt_subscriptionRef = subscriptionRef
16461492 , _fanInt_occRef = occRef
1647−#ifdef DEBUG_NODEIDS
1648− , _fanInt_nodeId = nodeId
1649−#endif
16501493 }
16511494
16521495fanInt :: HasSpiderTimeline x => Event x (IntMap a) -> EventSelectorInt x a
@@ -1655,21 +1498,20 @@ fanInt p = unsafePerformIO $ do
16551498 pure $ EventSelectorInt $ \k -> Event $ \sub -> do
16561499 isEmpty <- liftIO $ FastMutableIntMap.isEmpty (_fanInt_subscribers self)
16571500 when isEmpty $ do -- This is the first subscriber, so we need to subscribe to our input
1658− let desc = "fanInt" <> showNodeId self <> ", k = " <> show k
1659− (subscription, parentOcc) <- subscribeAndRead p $ debugSubscriber' desc $ Subscriber
1501+ (subscription, parentOcc) <- subscribeAndRead p $ Subscriber
16601502 { subscriberPropagate = \m -> do
16611503 liftIO $ writeIORef (_fanInt_occRef self) m
16621504 scheduleIntClear $ _fanInt_occRef self
1663− FastMutableIntMap.forIntersectionWithImmutable_ (_fanInt_subscribers self) m $ \b v -> --TODO: Do we need to know that no subscribers are being added as we traverse?
1664− FastWeakBag.traverse_ b $ \s ->
1505+ FastMutableIntMap.forIntersectionWithImmutable_ (_fanInt_subscribers self) m $ \b v -> do --TODO: Do we need to know that no subscribers are being added as we traverse?
1506+ FastWeakBag.traverse b $ \s -> do
16651507 subscriberPropagate s v
1666− , subscriberInvalidateHeight = \old ->
1667− FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b ->
1668− FastWeakBag.traverse_ b $ \s ->
1508+ , subscriberInvalidateHeight = \old -> do
1509+ FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b -> do
1510+ FastWeakBag.traverse b $ \s -> do
16691511 subscriberInvalidateHeight s old
1670− , subscriberRecalculateHeight = \new ->
1671− FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b ->
1672− FastWeakBag.traverse_ b $ \s ->
1512+ , subscriberRecalculateHeight = \new -> do
1513+ FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b -> do
1514+ FastWeakBag.traverse b $ \s -> do
16731515 subscriberRecalculateHeight s new
16741516 }
16751517 liftIO $ do
@@ -1683,25 +1525,10 @@ fanInt p = unsafePerformIO $ do
16831525 FastMutableIntMap.insert (_fanInt_subscribers self) k b
16841526 return b
16851527 Just b -> return b
1686− ticket <- liftIO $ FastWeakBag.insert sub b
1528+ t <- liftIO $ FastWeakBag.insert sub b
16871529 currentOcc <- readIORef (_fanInt_occRef self)
1688−
1689− subscribed <- fanIntSubscribed ticket self
1690− return (EventSubscription (FastWeakBag.remove ticket) subscribed, IntMap.lookup k currentOcc)
1691−
1692−fanIntSubscribed :: FastWeakBagTicket k -> FanInt x a -> IO (EventSubscribed x)
1693−fanIntSubscribed ticket self = do
1694− subscribedParent <- _eventSubscription_subscribed <$> readIORef (_fanInt_subscriptionRef self)
1695− return $ EventSubscribed
1696− { eventSubscribedHeightRef = eventSubscribedHeightRef subscribedParent
1697− , eventSubscribedRetained = toAny (_fanInt_subscriptionRef self, ticket)
1698−#ifdef DEBUG_CYCLES
1699− , eventSubscribedGetParents = return [subscribedParent]
1700− , eventSubscribedHasOwnHeightRef = False
1701− , eventSubscribedWhoCreated = whoCreatedIORef $ _fanInt_subscriptionRef self
1702−#endif
1703− }
1704−
1530+ (EventSubscription _ (EventSubscribed !heightRef _)) <- readIORef (_fanInt_subscriptionRef self)
1531+ return (EventSubscription (FastWeakBag.remove t) $! EventSubscribed heightRef $! toAny (_fanInt_subscriptionRef self, t), IntMap.lookup k currentOcc)
17051532
17061533{-# INLINABLE getFanSubscribed #-}
17071534getFanSubscribed :: (HasSpiderTimeline x, GCompare k) => k a -> Fan x k v -> Subscriber x (v a) -> EventM x (WeakBagTicket, FanSubscribed x k v, Maybe (v a))
@@ -1884,22 +1711,22 @@ subscribeCoincidenceSubscribed subscribed sub = WeakBag.insert sub (coincidenceS
18841711{-# INLINE mergeG #-}
18851712mergeG :: forall k q x v. (HasSpiderTimeline x, GCompare k)
18861713 => (forall a. q a -> Event x (v a))
1887− -> DynamicS x (PatchDMap k q) -> Event x (DMap k v)
1714+ -> Dynamic x (PatchDMap k q) -> Event x (DMap k v)
18881715mergeG nt d = cacheEvent (mergeCheap nt d)
18891716
18901717{-# INLINE mergeWithMove #-}
18911718mergeWithMove :: forall k v q x. (HasSpiderTimeline x, GCompare k)
18921719 => (forall a. q a -> Event x (v a))
1893− -> DynamicS x (PatchDMapWithMove k q) -> Event x (DMap k v)
1720+ -> Dynamic x (PatchDMapWithMove k q) -> Event x (DMap k v)
18941721mergeWithMove nt d = cacheEvent (mergeCheapWithMove nt d)
18951722
18961723{-# INLINE [1] mergeCheap #-}
18971724mergeCheap
18981725 :: forall k x q v. (HasSpiderTimeline x, GCompare k)
18991726 => (forall a. q a -> Event x (v a))
1900− -> DynamicS x (PatchDMap k q)
1727+ -> Dynamic x (PatchDMap k q)
19011728 -> Event x (DMap k v)
1902−mergeCheap nt = mergeGCheap' unMergeSubscribedParent getInitialSubscribers updateMe destroy
1729+mergeCheap nt = mergeGCheap' getInitialSubscribers updateMe destroy
19031730 where
19041731 updateMe :: MergeUpdateFunc k v x (PatchDMap k q) (MergeSubscribedParent x)
19051732 updateMe subscriber heightBagRef oldParents (PatchDMap p) = do
@@ -1914,9 +1741,7 @@ mergeCheap nt = mergeGCheap' unMergeSubscribedParent getInitialSubscribers updat
19141741 liftIO $ modifyIORef' heightBagRef $ heightBagAdd newParentHeight
19151742 return $ DMap.insertLookupWithKey' (\_ new _ -> new) k newParent ps
19161743 forM_ mOldSubd $ \oldSubd -> do
1917− oldHeight <- liftIO $ getEventSubscribedHeight $
1918− _eventSubscription_subscribed $ unMergeSubscribedParent oldSubd
1919−
1744+ oldHeight <- liftIO $ getEventSubscribedHeight $ _eventSubscription_subscribed $ unMergeSubscribedParent oldSubd
19201745 liftIO $ modifyIORef heightBagRef $ heightBagRemove oldHeight
19211746 return (maybeToList (unMergeSubscribedParent <$> mOldSubd) ++ subscriptionsToKill, newPs)
19221747 foldM f ([], oldParents) $ DMap.toList p
@@ -1927,7 +1752,7 @@ mergeCheap nt = mergeGCheap' unMergeSubscribedParent getInitialSubscribers updat
19271752 let s = subscriber $ return k
19281753 (subscription@(EventSubscription _ parentSubd), parentOcc) <- subscribeAndRead (nt e) s
19291754 height <- liftIO $ getEventSubscribedHeight parentSubd
1930− return (fmap (k :=>) parentOcc, height, k :=> MergeSubscribedParent subscription)
1755+ return (fmap (\x -> k :=> x) parentOcc, height, k :=> MergeSubscribedParent subscription)
19311756 return ( DMap.fromDistinctAscList $ mapMaybe (\(x, _, _) -> x) subscribers
19321757 , fmap (\(_, h, _) -> h) subscribers --TODO: Assert that there's no invalidHeight in here
19331758 , DMap.fromDistinctAscList $ map (\(_, _, x) -> x) subscribers
@@ -1939,9 +1764,9 @@ mergeCheap nt = mergeGCheap' unMergeSubscribedParent getInitialSubscribers updat
19391764{-# INLINE [1] mergeCheapWithMove #-}
19401765mergeCheapWithMove :: forall k x v q. (HasSpiderTimeline x, GCompare k)
19411766 => (forall a. q a -> Event x (v a))
1942− -> DynamicS x (PatchDMapWithMove k q)
1767+ -> Dynamic x (PatchDMapWithMove k q)
19431768 -> Event x (DMap k v)
1944−mergeCheapWithMove nt = mergeGCheap' _mergeSubscribedParentWithMove_subscription getInitialSubscribers updateMe destroy
1769+mergeCheapWithMove nt = mergeGCheap' getInitialSubscribers updateMe destroy
19451770 where
19461771 updateMe :: MergeUpdateFunc k v x (PatchDMapWithMove k q) (MergeSubscribedParentWithMove x k)
19471772 updateMe subscriber heightBagRef oldParents p = do
@@ -1960,17 +1785,13 @@ mergeCheapWithMove nt = mergeGCheap' _mergeSubscribedParentWithMove_subscription
19601785 let moveOrDelete :: forall a. k a -> PatchDMapWithMove.NodeInfo k q a -> MergeSubscribedParentWithMove x k a -> Constant (EventM x (Maybe (EventSubscription x))) a
19611786 moveOrDelete _ ni parent = Constant $ case getComposeMaybe $ PatchDMapWithMove._nodeInfo_to ni of
19621787 Nothing -> do
1963− oldHeight <- liftIO $ getEventSubscribedHeight $ _eventSubscription_subscribed $
1964− _mergeSubscribedParentWithMove_subscription parent
1965−
1788+ oldHeight <- liftIO $ getEventSubscribedHeight $ _eventSubscription_subscribed $ _mergeSubscribedParentWithMove_subscription parent
19661789 liftIO $ modifyIORef heightBagRef $ heightBagRemove oldHeight
19671790 return $ Just $ _mergeSubscribedParentWithMove_subscription parent
19681791 Just toKey -> do
19691792 liftIO $ writeIORef (_mergeSubscribedParentWithMove_key parent) $! toKey
19701793 return Nothing
1971− toDelete <- fmap catMaybes $ mapM (\(_ :=> v) -> getConstant v) $ DMap.toList $
1972− DMap.intersectionWithKey moveOrDelete (unPatchDMapWithMove p) oldParents
1973−
1794+ toDelete <- fmap catMaybes $ mapM (\(_ :=> v) -> getConstant v) $ DMap.toList $ DMap.intersectionWithKey moveOrDelete (unPatchDMapWithMove p) oldParents
19741795 return (toDelete, applyAlways p' oldParents)
19751796 getInitialSubscribers :: MergeInitFunc k v q x (MergeSubscribedParentWithMove x k)
19761797 getInitialSubscribers initialParents subscriber = do
@@ -1979,7 +1800,7 @@ mergeCheapWithMove nt = mergeGCheap' _mergeSubscribedParentWithMove_subscription
19791800 let s = subscriber $ liftIO $ readIORef keyRef
19801801 (subscription@(EventSubscription _ parentSubd), parentOcc) <- subscribeAndRead (nt e) s
19811802 height <- liftIO $ getEventSubscribedHeight parentSubd
1982− return (fmap (k :=>) parentOcc, height, k :=> MergeSubscribedParentWithMove subscription keyRef)
1803+ return (fmap (\x -> k :=> x) parentOcc, height, k :=> MergeSubscribedParentWithMove subscription keyRef)
19831804 return ( DMap.fromDistinctAscList $ mapMaybe (\(x, _, _) -> x) subscribers
19841805 , fmap (\(_, h, _) -> h) subscribers --TODO: Assert that there's no invalidHeight in here
19851806 , DMap.fromDistinctAscList $ map (\(_, _, x) -> x) subscribers
@@ -1995,8 +1816,6 @@ type MergeUpdateFunc k v x p s
19951816 -> p
19961817 -> EventM x ([EventSubscription x], DMap k s)
19971818
1998−type MergeGetSubscription x s = forall a. s a -> EventSubscription x
1999−
20001819type MergeInitFunc k v q x s
20011820 = DMap k q
20021821 -> (forall a. EventM x (k a) -> Subscriber x (v a))
@@ -2020,17 +1839,14 @@ invalidateMergeHeight m = invalidateMergeHeight' (_merge_heightRef m) (_merge_su
20201839invalidateMergeHeight' :: IORef Height -> Subscriber x a -> IO ()
20211840invalidateMergeHeight' heightRef sub = do
20221841 oldHeight <- readIORef heightRef
2023− -- If the height used to be valid, it must be invalid now; we should never have *more* heights than we have parents
2024− when (oldHeight /= invalidHeight) $ do
1842+ when (oldHeight /= invalidHeight) $ do -- If the height used to be valid, it must be invalid now; we should never have *more* heights than we have parents
20251843 writeIORef heightRef $! invalidHeight
20261844 subscriberInvalidateHeight sub oldHeight
20271845
20281846revalidateMergeHeight :: Merge x k v s -> IO ()
20291847revalidateMergeHeight m = do
20301848 currentHeight <- readIORef $ _merge_heightRef m
2031−
2032− -- revalidateMergeHeight may be called multiple times; perhaps the's a way to finesse it to avoid this check
2033− when (currentHeight == invalidHeight) $ do
1849+ when (currentHeight == invalidHeight) $ do -- revalidateMergeHeight may be called multiple times; perhaps the's a way to finesse it to avoid this check
20341850 heights <- readIORef $ _merge_heightBagRef m
20351851 parents <- readIORef $ _merge_parentsRef m
20361852 -- When the number of heights in the bag reaches the number of parents, we should have a valid height
@@ -2038,7 +1854,7 @@ revalidateMergeHeight m = do
20381854 LT -> return ()
20391855 EQ -> do
20401856 let height = succHeight $ heightBagMax heights
2041− traceInvalidateHeight $ "recalculateSubscriberHeight: height: " <> show height
1857+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: height: " <> show height
20421858 writeIORef (_merge_heightRef m) $! height
20431859 subscriberRecalculateHeight (_merge_sub m) height
20441860 GT -> error $ "revalidateMergeHeight: more heights (" <> show (heightBagSize heights) <> ") than parents (" <> show (DMap.size parents) <> ") for Merge"
@@ -2046,45 +1862,36 @@ revalidateMergeHeight m = do
20461862scheduleMergeSelf :: HasSpiderTimeline x => Merge x k v s -> Height -> EventM x ()
20471863scheduleMergeSelf m height = scheduleMerge' height (_merge_heightRef m) $ do
20481864 vals <- liftIO $ readIORef $ _merge_accumRef m
2049− -- Once we're done with this, we can clear it immediately, because if there's a cacheEvent in front of us,
2050− -- it'll handle subsequent subscribers, and if not, we won't get subsequent subscribers
2051− liftIO $ writeIORef (_merge_accumRef m) $! DMap.empty
1865+ liftIO $ writeIORef (_merge_accumRef m) $! DMap.empty -- Once we're done with this, we can clear it immediately, because if there's a cacheEvent in front of us, it'll handle subsequent subscribers, and if not, we won't get subsequent subscribers
20521866 --TODO: Assert that m is not empty
20531867 subscriberPropagate (_merge_sub m) vals
20541868
2055−checkCycle :: HasSpiderTimeline x => EventSubscribed x -> EventM x ()
2056−checkCycle subscribed = liftIO $ do
2057− height <- readIORef (eventSubscribedHeightRef subscribed)
2058−
2059− -- currentHeight <- getCurrentHeight
2060− -- when (height <= currentHeight) $ if height /= invalidHeight
2061− -- then do
2062− -- myStack <- liftIO $ whoCreatedIORef undefined --TODO
2063− -- error $ "Height (" ++ show height ++ ") is not greater than current height (" ++ show currentHeight ++ ")\n" ++ unlines (reverse myStack)
2064− -- else liftIO $
2065− when (height == invalidHeight) $
2066−#ifdef DEBUG_CYCLES
2067− do
2068− nodesInvolvedInCycle <- walkInvalidHeightParents subscribed
2069− stacks <- forM nodesInvolvedInCycle whoCreatedEventSubscribed
2070− throwIO (EventLoopException stacks)
2071−#else
2072− throwIO EventLoopException
2073−#endif
2074−
2075−
2076−mergeSubscriber :: forall x k v s a. (HasSpiderTimeline x, GCompare k) => EventSubscribed x -> Merge x k v s -> EventM x (k a) -> Subscriber x (v a)
2077−mergeSubscriber subscribed m getKey = Subscriber
1869+mergeSubscriber :: forall x k v s a. (HasSpiderTimeline x, GCompare k) => Merge x k v s -> EventM x (k a) -> Subscriber x (v a)
1870+mergeSubscriber m getKey = Subscriber
20781871 { subscriberPropagate = \a -> do
20791872 oldM <- liftIO $ readIORef $ _merge_accumRef m
20801873 k <- getKey
2081− let newM = DMap.insertWith (error "Same key fired multiple times for Merge") k a oldM
1874+ let newM = DMap.insertWith (error $ "Same key fired multiple times for Merge") k a oldM
20821875 tracePropagate (Proxy :: Proxy x) $ " DMap.size oldM = " <> show (DMap.size oldM) <> "; DMap.size newM = " <> show (DMap.size newM)
20831876 liftIO $ writeIORef (_merge_accumRef m) $! newM
20841877 when (DMap.null oldM) $ do -- Only schedule the firing once
20851878 height <- liftIO $ readIORef $ _merge_heightRef m
2086− checkCycle subscribed
2087−
1879+ --TODO: assertions about height
1880+ currentHeight <- getCurrentHeight
1881+ when (height <= currentHeight) $ do
1882+ if height /= invalidHeight
1883+ then do
1884+ myStack <- liftIO $ whoCreatedIORef undefined --TODO
1885+ error $ "Height (" ++ show height ++ ") is not greater than current height (" ++ show currentHeight ++ ")\n" ++ unlines (reverse myStack)
1886+ else liftIO $ do
1887+#ifdef DEBUG_CYCLES
1888+ nodesInvolvedInCycle <- walkInvalidHeightParents $ eventSubscribedMerge subscribed
1889+ stacks <- forM nodesInvolvedInCycle $ \(Some es) -> whoCreatedEventSubscribed es
1890+ let cycleInfo = ":\n" <> drawForest (listsToForest stacks)
1891+#else
1892+ let cycleInfo = ""
1893+#endif
1894+ error $ "Causality loop found" <> cycleInfo
20881895 scheduleMergeSelf m height
20891896 , subscriberInvalidateHeight = \old -> do --TODO: When removing a parent doesn't actually change the height, maybe we can avoid invalidating
20901897 modifyIORef' (_merge_heightBagRef m) $ heightBagRemove old
@@ -2095,45 +1902,31 @@ mergeSubscriber subscribed m getKey = Subscriber
20951902 }
20961903
20971904--TODO: Be able to run as much of this as possible promptly
2098−updateMerge :: (HasSpiderTimeline x, GCompare k) => EventSubscribed x -> Merge x k v s -> MergeUpdateFunc k v x p s -> p -> SomeMergeUpdate x
2099−updateMerge subscribed m updateFunc p = SomeMergeUpdate updateMe (invalidateMergeHeight m) (revalidateMergeHeight m)
1905+updateMerge :: (HasSpiderTimeline x, GCompare k) => Merge x k v s -> MergeUpdateFunc k v x p s -> p -> SomeMergeUpdate x
1906+updateMerge m updateFunc p = SomeMergeUpdate updateMe (invalidateMergeHeight m) (revalidateMergeHeight m)
21001907 where updateMe = do
21011908 oldParents <- liftIO $ readIORef $ _merge_parentsRef m
2102− (subscriptionsToKill, newParents) <- updateFunc (mergeSubscriber subscribed m) (_merge_heightBagRef m) oldParents p
1909+ (subscriptionsToKill, newParents) <- updateFunc (mergeSubscriber m) (_merge_heightBagRef m) oldParents p
21031910 liftIO $ writeIORef (_merge_parentsRef m) $! newParents
21041911 return subscriptionsToKill
21051912
21061913{-# INLINE mergeGCheap' #-}
21071914mergeGCheap' :: forall k v x p s q. (HasSpiderTimeline x, GCompare k, PatchTarget p ~ DMap k q)
2108− => MergeGetSubscription x s -> MergeInitFunc k v q x s -> MergeUpdateFunc k v x p s -> MergeDestroyFunc k s -> DynamicS x p -> Event x (DMap k v)
2109−mergeGCheap' getParent getInitialSubscribers updateFunc destroy d = Event $ \sub -> do
1915+ => MergeInitFunc k v q x s -> MergeUpdateFunc k v x p s -> MergeDestroyFunc k s -> Dynamic x p -> Event x (DMap k v)
1916+mergeGCheap' getInitialSubscribers updateFunc destroy d = Event $ \sub -> do
21101917 initialParents <- readBehaviorUntracked $ dynamicCurrent d
21111918 accumRef <- liftIO $ newIORef $ error "merge: accumRef not yet initialized"
21121919 heightRef <- liftIO $ newIORef $ error "merge: heightRef not yet initialized"
21131920 heightBagRef <- liftIO $ newIORef $ error "merge: heightBagRef not yet initialized"
21141921 parentsRef :: IORef (DMap k s) <- liftIO $ newIORef $ error "merge: parentsRef not yet initialized"
2115− changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
2116−
2117− let subscribed = EventSubscribed
2118− { eventSubscribedHeightRef = heightRef
2119− , eventSubscribedRetained = toAny (parentsRef, changeSubdRef)
2120−#ifdef DEBUG_CYCLES
2121− , eventSubscribedGetParents = do
2122− let getParent' (_ :=> v) = _eventSubscription_subscribed (getParent v)
2123− fmap getParent' . DMap.toList <$> readIORef parentsRef
2124− , eventSubscribedHasOwnHeightRef = False
2125− , eventSubscribedWhoCreated = whoCreatedIORef heightRef
2126−#endif
2127− }
2128−
2129− m = Merge
1922+ let m = Merge
21301923 { _merge_parentsRef = parentsRef
21311924 , _merge_heightBagRef = heightBagRef
21321925 , _merge_heightRef = heightRef
21331926 , _merge_sub = sub
21341927 , _merge_accumRef = accumRef
21351928 }
2136− (dm, heights, initialParentState) <- getInitialSubscribers initialParents $ mergeSubscriber subscribed m
1929+ (dm, heights, initialParentState) <- getInitialSubscribers initialParents $ mergeSubscriber m
21371930 let myHeightBag = heightBagFromList $ filter (/= invalidHeight) heights
21381931 myHeight = if invalidHeight `elem` heights
21391932 then invalidHeight
@@ -2142,57 +1935,50 @@ mergeGCheap' getParent getInitialSubscribers updateFunc destroy d = Event $ \sub
21421935 let (occ, accum) = if currentHeight >= myHeight -- If we should have fired by now
21431936 then (if DMap.null dm then Nothing else Just dm, DMap.empty)
21441937 else (Nothing, dm)
2145− unless (DMap.null accum) $ scheduleMergeSelf m myHeight
1938+ unless (DMap.null accum) $ do
1939+ scheduleMergeSelf m myHeight
21461940 liftIO $ writeIORef accumRef $! accum
21471941 liftIO $ writeIORef heightRef $! myHeight
21481942 liftIO $ writeIORef heightBagRef $! myHeightBag
1943+ changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
21491944 liftIO $ writeIORef parentsRef $! initialParentState
21501945 defer $ SomeMergeInit $ do
2151− let changeSubscriber = Subscriber
1946+ let s = Subscriber
21521947 { subscriberPropagate = \a -> {-# SCC "traverseMergeChange" #-} do
2153− tracePropagate (Proxy :: Proxy x) "SubscriberMerge/Change"
2154− defer $ updateMerge subscribed m updateFunc a
1948+ tracePropagate (Proxy :: Proxy x) $ "SubscriberMerge/Change"
1949+ defer $ updateMerge m updateFunc a
21551950 , subscriberInvalidateHeight = \_ -> return ()
21561951 , subscriberRecalculateHeight = \_ -> return ()
21571952 }
2158− (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) changeSubscriber
2159− forM_ change $ \c -> defer $ updateMerge subscribed m updateFunc c
1953+ (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) s
1954+ forM_ change $ \c -> defer $ updateMerge m updateFunc c
21601955 -- We explicitly hold on to the unsubscribe function from subscribing to the update event.
21611956 -- If we don't do this, there are certain cases where mergeCheap will fail to properly retain
21621957 -- its subscription.
2163− liftIO $ writeIORef changeSubdRef (changeSubscriber, changeSubscription)
1958+ liftIO $ writeIORef changeSubdRef (s, changeSubscription)
21641959 let unsubscribeAll = destroy =<< readIORef parentsRef
1960+ return ( EventSubscription unsubscribeAll $ EventSubscribed heightRef $ toAny (parentsRef, changeSubdRef)
1961+ , occ
1962+ )
21651963
2166− return (EventSubscription unsubscribeAll subscribed, occ)
2167−
2168−
2169−mergeInt :: forall x a. (HasSpiderTimeline x) => DynamicS x (PatchIntMap (Event x a)) -> Event x (IntMap a)
1964+mergeInt :: forall x a. (HasSpiderTimeline x) => Dynamic x (PatchIntMap (Event x a)) -> Event x (IntMap a)
21701965mergeInt = cacheEvent . mergeIntCheap
21711966
21721967{-# INLINABLE mergeIntCheap #-}
2173−mergeIntCheap :: forall x a. (HasSpiderTimeline x) => DynamicS x (PatchIntMap (Event x a)) -> Event x (IntMap a)
1968+mergeIntCheap :: forall x a. (HasSpiderTimeline x) => Dynamic x (PatchIntMap (Event x a)) -> Event x (IntMap a)
21741969mergeIntCheap d = Event $ \sub -> do
21751970 initialParents <- readBehaviorUntracked $ dynamicCurrent d
21761971 accum <- liftIO $ FastMutableIntMap.newEmpty
21771972 heightRef <- liftIO $ newIORef zeroHeight
21781973 heightBagRef <- liftIO $ newIORef heightBagEmpty
21791974 parents <- liftIO $ FastMutableIntMap.newEmpty
2180− changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
2181− let subscribed = EventSubscribed
2182− { eventSubscribedHeightRef = heightRef
2183− , eventSubscribedRetained = toAny (parents, changeSubdRef)
2184−#ifdef DEBUG_CYCLES
2185− , eventSubscribedGetParents = fmap (_eventSubscription_subscribed . snd) <$> FastMutableIntMap.toList parents
2186− , eventSubscribedHasOwnHeightRef = False
2187− , eventSubscribedWhoCreated = whoCreatedIORef heightRef
2188−#endif
2189− }
21901975 let scheduleSelf = do
21911976 height <- liftIO $ readIORef $ heightRef
21921977 scheduleMerge' height heightRef $ do
21931978 vals <- liftIO $ FastMutableIntMap.getFrozenAndClear accum
21941979 subscriberPropagate sub vals
2195− invalidateMyHeight = invalidateMergeHeight' heightRef sub
1980+ invalidateMyHeight = do
1981+ invalidateMergeHeight' heightRef sub
21961982 recalculateMyHeight = do
21971983 currentHeight <- readIORef heightRef
21981984 when (currentHeight == invalidHeight) $ do --TODO: This will almost always be true; can we get rid of this check and just proceed to the next one always?
@@ -2202,14 +1988,12 @@ mergeIntCheap d = Event $ \sub -> do
22021988 LT -> return ()
22031989 EQ -> do
22041990 let height = succHeight $ heightBagMax heights
2205− traceInvalidateHeight $ "recalculateSubscriberHeight: height: " <> show height
1991+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: height: " <> show height
22061992 writeIORef heightRef $! height
22071993 subscriberRecalculateHeight sub height
22081994 GT -> error $ "revalidateMergeHeight: more heights (" <> show (heightBagSize heights) <> ") than parents (" <> show numParents <> ") for Merge"
22091995 mySubscriber k = Subscriber
22101996 { subscriberPropagate = \a -> do
2211− checkCycle subscribed
2212−
22131997 wasEmpty <- liftIO $ FastMutableIntMap.isEmpty accum
22141998 liftIO $ FastMutableIntMap.insert accum k a
22151999 when wasEmpty scheduleSelf
@@ -2243,6 +2027,7 @@ mergeIntCheap d = Event $ \sub -> do
22432027 else liftIO $ Just <$> FastMutableIntMap.getFrozenAndClear accum
22442028 else do when (not isEmpty) scheduleSelf -- We have things accumulated, but we shouldn't have fired them yet
22452029 return Nothing
2030+ changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
22462031 defer $ SomeMergeInit $ do
22472032 let updateMe a = SomeMergeUpdate u invalidateMyHeight recalculateMyHeight
22482033 where
@@ -2256,27 +2041,25 @@ mergeIntCheap d = Event $ \sub -> do
22562041 oldParents <- liftIO $ FastMutableIntMap.applyPatch parents newSubscriptions
22572042 liftIO $ for_ oldParents $ \oldParent -> do
22582043 oldParentHeight <- getEventSubscribedHeight $ _eventSubscription_subscribed oldParent
2259−
2260− print ("updateMe", oldParentHeight)
22612044 modifyIORef' heightBagRef $ heightBagRemove oldParentHeight
22622045 return $ IntMap.elems oldParents
2263− let changeSubscriber = Subscriber
2046+ let s = Subscriber
22642047 { subscriberPropagate = \a -> {-# SCC "traverseMergeChange" #-} do
22652048 tracePropagate (Proxy :: Proxy x) $ "SubscriberMergeInt/Change"
22662049 defer $ updateMe a
22672050 , subscriberInvalidateHeight = \_ -> return ()
22682051 , subscriberRecalculateHeight = \_ -> return ()
22692052 }
2270− (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) changeSubscriber
2053+ (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) s
22712054 forM_ change $ \c -> defer $ updateMe c
22722055 -- We explicitly hold on to the unsubscribe function from subscribing to the update event.
22732056 -- If we don't do this, there are certain cases where mergeCheap will fail to properly retain
22742057 -- its subscription.
2275− liftIO $ writeIORef changeSubdRef (changeSubscriber, changeSubscription)
2058+ liftIO $ writeIORef changeSubdRef (s, changeSubscription)
22762059 let unsubscribeAll = traverse_ unsubscribe =<< FastMutableIntMap.getFrozenAndClear parents
2277−
2278−
2279− return (EventSubscription unsubscribeAll subscribed, occ)
2060+ return ( EventSubscription unsubscribeAll $ EventSubscribed heightRef $ toAny (parents, changeSubdRef)
2061+ , occ
2062+ )
22802063
22812064newtype EventSelector x k = EventSelector { select :: forall a. k a -> Event x a }
22822065newtype EventSelectorG x k v = EventSelectorG { selectG :: forall a. k a -> Event x (v a) }
@@ -2342,7 +2125,7 @@ clearEventEnv (EventEnv toAssignRef holdInitRef dynInitRef mergeUpdateRef mergeI
23422125-- | Run an event action outside of a frame
23432126runFrame :: forall x a. HasSpiderTimeline x => EventM x a -> SpiderHost x a --TODO: This function also needs to hold the mutex
23442127runFrame a = SpiderHost $ do
2345− let env = _spiderTimeline_eventEnv $ unSTE (spiderTimeline :: SpiderTimelineEnv x)
2128+ let env = _spiderTimeline_eventEnv (spiderTimeline :: SpiderTimelineEnv x)
23462129 let go = do
23472130 result <- a
23482131 runHoldInits (eventEnvHoldInits env) (eventEnvDynInits env) (eventEnvMergeInits env) -- This must happen before doing the assignments, in case subscribing a Hold causes existing Holds to be read by the newly-propagated events
@@ -2359,19 +2142,19 @@ runFrame a = SpiderHost $ do
23592142 coincidenceInfos <- readIORef $ eventEnvResetCoincidences env
23602143 forM_ toAssign $ \(SomeAssignment vRef iRef v) -> {-# SCC "assignment" #-} do
23612144 writeIORef vRef v
2362− traceInvalidate $ "Invalidating Hold"
2145+ when debugInvalidate $ putStrLn $ "Invalidating Hold"
23632146 writeIORef iRef =<< evaluate =<< invalidate toReconnectRef =<< readIORef iRef
23642147 mergeUpdates <- readIORef $ eventEnvMergeUpdates env
23652148 writeIORef (eventEnvMergeUpdates env) []
2366− tracePropagate (Proxy::Proxy x) $ "Updating merges"
2149+ when debugPropagate $ putStrLn "Updating merges"
23672150 mergeSubscriptionsToKill <- runEventM $ concat <$> mapM _someMergeUpdate_update mergeUpdates
2368− tracePropagate (Proxy::Proxy x) $ "Updating merges done"
2151+ when debugPropagate $ putStrLn "Updating merges done"
23692152 toReconnect <- readIORef toReconnectRef
23702153 clearEventEnv env
23712154 switchSubscriptionsToKill <- forM toReconnect $ \(SomeSwitchSubscribed subscribed) -> {-# SCC "switchSubscribed" #-} do
23722155 oldSubscription <- readIORef $ switchSubscribedCurrentParent subscribed
23732156 wi <- readIORef $ switchSubscribedOwnWeakInvalidator subscribed
2374− traceInvalidate $ "Finalizing invalidator for Switch" <> showNodeId subscribed
2157+ when debugInvalidate $ putStrLn $ "Finalizing invalidator for Switch" <> showNodeId subscribed
23752158 finalize wi
23762159 i <- evaluate $ switchSubscribedOwnInvalidator subscribed
23772160 wi' <- mkWeakPtrWithDebug i "wi'"
@@ -2385,7 +2168,7 @@ runFrame a = SpiderHost $ do
23852168 subscription <- unSpiderHost $ runFrame $ {-# SCC "subscribeSwitch" #-} subscribe e sub --TODO: Assert that the event isn't firing --TODO: This should not loop because none of the events should be firing, but still, it is inefficient
23862169 {-
23872170 stackTrace <- liftIO $ fmap renderStack $ ccsToStrings =<< (getCCSOf $! switchSubscribedParent subscribed)
2388− liftIO $ debugStrLn $ (++stackTrace) $ "subd' subscribed to " ++ case e of
2171+ liftIO $ putStrLn $ (++stackTrace) $ "subd' subscribed to " ++ case e of
23892172 EventRoot _ -> "EventRoot"
23902173 EventNever -> "EventNever"
23912174 _ -> "something else"
@@ -2400,7 +2183,7 @@ runFrame a = SpiderHost $ do
24002183 myHeight <- readIORef $ switchSubscribedHeight subscribed
24012184 when (parentHeight /= myHeight) $ do
24022185 writeIORef (switchSubscribedHeight subscribed) $! invalidHeight
2403− WeakBag.traverse_ (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight myHeight
2186+ WeakBag.traverse (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight myHeight
24042187 mapM_ _someMergeUpdate_invalidateHeight mergeUpdates --TODO: In addition to when the patch is completely empty, we should also not run this if it has some Nothing values, but none of them have actually had any effect; potentially, we could even check for Just values with no effect (e.g. by comparing their IORefs and ignoring them if they are unchanged); actually, we could just check if the new height is different
24052188 forM_ coincidenceInfos $ \(SomeResetCoincidence subscription mcs) -> do
24062189 unsubscribe subscription
@@ -2441,7 +2224,7 @@ invalidateCoincidenceHeight subscribed = do
24412224 oldHeight <- readIORef $ coincidenceSubscribedHeight subscribed
24422225 when (oldHeight /= invalidHeight) $ do
24432226 writeIORef (coincidenceSubscribedHeight subscribed) $! invalidHeight
2444− WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
2227+ WeakBag.traverse (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
24452228
24462229updateSwitchHeight :: Height -> SwitchSubscribed x a -> IO ()
24472230updateSwitchHeight new subscribed = do
@@ -2449,7 +2232,7 @@ updateSwitchHeight new subscribed = do
24492232 when (oldHeight == invalidHeight) $ do --TODO: This 'when' should probably be an assertion
24502233 when (new /= invalidHeight) $ do --TODO: This 'when' should probably be an assertion
24512234 writeIORef (switchSubscribedHeight subscribed) $! new
2452− WeakBag.traverse_ (switchSubscribedSubscribers subscribed) $ recalculateSubscriberHeight new
2235+ WeakBag.traverse (switchSubscribedSubscribers subscribed) $ recalculateSubscriberHeight new
24532236
24542237recalculateCoincidenceHeight :: CoincidenceSubscribed x a -> IO ()
24552238recalculateCoincidenceHeight subscribed = do
@@ -2458,7 +2241,7 @@ recalculateCoincidenceHeight subscribed = do
24582241 height <- calculateCoincidenceHeight subscribed
24592242 when (height /= invalidHeight) $ do
24602243 writeIORef (coincidenceSubscribedHeight subscribed) $! height
2461− WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ recalculateSubscriberHeight height
2244+ WeakBag.traverse (coincidenceSubscribedSubscribers subscribed) $ recalculateSubscriberHeight height
24622245
24632246calculateSwitchHeight :: SwitchSubscribed x a -> IO Height
24642247calculateSwitchHeight subscribed = getEventSubscribedHeight . _eventSubscription_subscribed =<< readIORef (switchSubscribedCurrentParent subscribed)
@@ -2520,8 +2303,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Event
25202303 {-# INLINABLE headE #-}
25212304 headE = R.slowHeadE
25222305-- headE (SpiderEvent e) = SpiderEvent <$> Reflex.Spider.Internal.headE e
2523− {-# INLINABLE now #-}
2524− now = nowSpiderEventM
25252306
25262307instance Reflex.Class.MonadSample (SpiderTimeline x) (SpiderPullM x) where
25272308 {-# INLINABLE sample #-}
@@ -2543,9 +2324,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Spide
25432324 {-# INLINABLE headE #-}
25442325 headE = R.slowHeadE
25452326-- headE (SpiderEvent e) = SpiderPushM $ SpiderEvent <$> Reflex.Spider.Internal.headE e
2546− {-# INLINABLE now #-}
2547− now = SpiderPushM nowSpiderEventM
2548−
25492327
25502328instance HasSpiderTimeline x => Monad (Reflex.Class.Dynamic (SpiderTimeline x)) where
25512329 {-# INLINE return #-}
@@ -2554,13 +2332,11 @@ instance HasSpiderTimeline x => Monad (Reflex.Class.Dynamic (SpiderTimeline x))
25542332 x >>= f = SpiderDynamic $ dynamicDynIdentity $ newJoinDyn $ newMapDyn (unSpiderDynamic . f) $ unSpiderDynamic x
25552333 {-# INLINE (>>) #-}
25562334 (>>) = (*>)
2557−#if !MIN_VERSION_base(4,13,0)
25582335 {-# INLINE fail #-}
25592336 fail _ = error "Dynamic does not support 'fail'"
2560−#endif
25612337
25622338{-# INLINABLE newJoinDyn #-}
2563−newJoinDyn :: HasSpiderTimeline x => DynamicS x (Identity (DynamicS x (Identity a))) -> Reflex.Spider.Internal.Dyn x (Identity a)
2339+newJoinDyn :: HasSpiderTimeline x => Reflex.Spider.Internal.Dynamic x (Identity (Reflex.Spider.Internal.Dynamic x (Identity a))) -> Reflex.Spider.Internal.Dyn x (Identity a)
25642340newJoinDyn d =
25652341 let readV0 = readBehaviorTracked . dynamicCurrent =<< readBehaviorTracked (dynamicCurrent d)
25662342 eOuter = Reflex.Spider.Internal.push (fmap (Just . Identity) . readBehaviorUntracked . dynamicCurrent . runIdentity) $ dynamicUpdated d
@@ -2609,9 +2385,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Spide
26092385 buildDynamic getV0 e = runFrame . runSpiderHostFrame $ Reflex.Class.buildDynamic getV0 e
26102386 {-# INLINABLE headE #-}
26112387 headE e = runFrame . runSpiderHostFrame $ Reflex.Class.headE e
2612− {-# INLINABLE now #-}
2613− now = runFrame . runSpiderHostFrame $ Reflex.Class.now
2614−
26152388
26162389instance HasSpiderTimeline x => Reflex.Class.MonadSample (SpiderTimeline x) (SpiderHostFrame x) where
26172390 sample = SpiderHostFrame . readBehaviorUntracked . unSpiderBehavior --TODO: This can cause problems with laziness, so we should get rid of it if we can
@@ -2628,8 +2401,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Spide
26282401 {-# INLINABLE headE #-}
26292402 headE = R.slowHeadE
26302403-- headE (SpiderEvent e) = SpiderHostFrame $ SpiderEvent <$> Reflex.Spider.Internal.headE e
2631− {-# INLINABLE now #-}
2632− now = SpiderHostFrame Reflex.Class.now
26332404
26342405instance HasSpiderTimeline x => Reflex.Class.MonadSample (SpiderTimeline x) (SpiderHost x) where
26352406 {-# INLINABLE sample #-}
@@ -2650,8 +2421,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Refle
26502421 buildDynamic getV0 e = Reflex.Spider.Internal.ReadPhase $ Reflex.Class.buildDynamic getV0 e
26512422 {-# INLINABLE headE #-}
26522423 headE e = Reflex.Spider.Internal.ReadPhase $ Reflex.Class.headE e
2653− {-# INLINABLE now #-}
2654− now = Reflex.Spider.Internal.ReadPhase Reflex.Class.now
26552424
26562425--------------------------------------------------------------------------------
26572426-- Deprecated items
@@ -2689,13 +2458,13 @@ instance HasSpiderTimeline x => Reflex.Host.Class.MonadReadEvent (SpiderTimeline
26892458 touch h
26902459 return result
26912460
2692−instance HasSpiderTimeline x => Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHost x) where
2461+instance Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHost x) where
26932462 newEventWithTrigger = SpiderHost . fmap SpiderEvent . newEventWithTriggerIO
26942463 newFanEventWithTrigger f = SpiderHost $ do
26952464 es <- newFanEventWithTriggerIO f
26962465 return $ Reflex.Class.EventSelector $ SpiderEvent . Reflex.Spider.Internal.select es
26972466
2698−instance HasSpiderTimeline x => Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHostFrame x) where
2467+instance Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHostFrame x) where
26992468 newEventWithTrigger = SpiderHostFrame . EventM . liftIO . fmap SpiderEvent . newEventWithTriggerIO
27002469 newFanEventWithTrigger f = SpiderHostFrame $ EventM $ liftIO $ do
27012470 es <- newFanEventWithTriggerIO f
@@ -2717,7 +2486,7 @@ unsafeNewSpiderTimelineEnv = do
27172486#ifdef DEBUG
27182487 depthRef <- newIORef 0
27192488#endif
2720− return $ STE $ SpiderTimelineEnv
2489+ return $ SpiderTimelineEnv
27212490 { _spiderTimeline_lock = lock
27222491 , _spiderTimeline_eventEnv = env
27232492#ifdef DEBUG
@@ -2733,13 +2502,13 @@ data LocalSpiderTimeline (x :: Type) s
27332502
27342503instance Reifies s (SpiderTimelineEnv x) =>
27352504 HasSpiderTimeline (LocalSpiderTimeline x s) where
2736− spiderTimeline = localSpiderTimeline Proxy $ reflect (Proxy :: Proxy s)
2505+ spiderTimeline = localSpiderTimeline (Proxy :: Proxy s) $ reflect (Proxy :: Proxy s)
27372506
27382507localSpiderTimeline
2739− :: proxy s
2508+ :: Proxy s
27402509 -> SpiderTimelineEnv x
27412510 -> SpiderTimelineEnv (LocalSpiderTimeline x s)
2742−localSpiderTimeline _ = coerce
2511+localSpiderTimeline _ = unsafeCoerce
27432512
27442513-- | Pass a new timeline to the given function.
27452514withSpiderTimeline :: (forall x. HasSpiderTimeline x => SpiderTimelineEnv x -> IO r) -> IO r
@@ -2757,8 +2526,8 @@ instance HasSpiderTimeline x => R.Reflex (SpiderTimeline x) where
27572526 {-# SPECIALIZE instance R.Reflex (SpiderTimeline Global) #-}
27582527 newtype Behavior (SpiderTimeline x) a = SpiderBehavior { unSpiderBehavior :: Behavior x a }
27592528 newtype Event (SpiderTimeline x) a = SpiderEvent { unSpiderEvent :: Event x a }
2760− newtype Dynamic (SpiderTimeline x) a = SpiderDynamic { unSpiderDynamic :: DynamicS x (Identity a) } -- deriving (Functor, Applicative, Monad)
2761− newtype Incremental (SpiderTimeline x) p = SpiderIncremental { unSpiderIncremental :: DynamicS x p }
2529+ newtype Dynamic (SpiderTimeline x) a = SpiderDynamic { unSpiderDynamic :: Dynamic x (Identity a) } -- deriving (Functor, Applicative, Monad)
2530+ newtype Incremental (SpiderTimeline x) p = SpiderIncremental { unSpiderIncremental :: Dynamic x p }
27622531 type PullM (SpiderTimeline x) = SpiderPullM x
27632532 type PushM (SpiderTimeline x) = SpiderPushM x
27642533 {-# INLINABLE never #-}
@@ -2775,7 +2544,7 @@ instance HasSpiderTimeline x => R.Reflex (SpiderTimeline x) where
27752544 fanG e = R.EventSelectorG $ SpiderEvent . selectG (fanG (unSpiderEvent e))
27762545 {-# INLINABLE mergeG #-}
27772546 mergeG
2778− :: forall k2 (k :: k2 -> *) q (v :: k2 -> *). GCompare k
2547+ :: forall (k :: k2 -> *) q (v :: k2 -> *). GCompare k
27792548 => (forall a. q a -> R.Event (SpiderTimeline x) (v a))
27802549 -> DMap k q
27812550 -> R.Event (SpiderTimeline x) (DMap k v)
@@ -2787,7 +2556,7 @@ instance HasSpiderTimeline x => R.Reflex (SpiderTimeline x) where
27872556 {-# INLINABLE current #-}
27882557 current = SpiderBehavior . dynamicCurrent . unSpiderDynamic
27892558 {-# INLINABLE updated #-}
2790− updated = SpiderEvent #. dynamicUpdated .# fmap coerce . unSpiderDynamic
2559+ updated = coerce $ SpiderEvent . dynamicUpdated . unSpiderDynamic
27912560 {-# INLINABLE unsafeBuildDynamic #-}
27922561 unsafeBuildDynamic readV0 v' = SpiderDynamic $ dynamicDynIdentity $ unsafeBuildDynamic (coerce readV0) $ coerce $ unSpiderEvent v'
27932562 {-# INLINABLE unsafeBuildIncremental #-}
@@ -2806,10 +2575,9 @@ instance HasSpiderTimeline x => R.Reflex (SpiderTimeline x) where
28062575 return $ Identity <$> apply p c --TODO: Avoid the redundant 'apply'
28072576 eventCoercion Coercion = Coercion
28082577 behaviorCoercion Coercion = Coercion
2809− dynamicCoercion Coercion = Coercion
2810− incrementalCoercion Coercion Coercion = Coercion
2578+ dynamicCoercion = unsafeCoerce --TODO: How can we avoid this unsafeCoerce? This is safe only because we know how Identity works as a Patch instance
28112579 {-# INLINABLE mergeIntIncremental #-}
2812− mergeIntIncremental = SpiderEvent . mergeInt . coerce
2580+ mergeIntIncremental = SpiderEvent . mergeInt . (unsafeCoerce :: Dynamic x (PatchIntMap (R.Event (SpiderTimeline x) a)) -> Dynamic x (PatchIntMap (Event x a))) . unSpiderIncremental
28132581 {-# INLINABLE fanInt #-}
28142582 fanInt e = R.EventSelectorInt $ SpiderEvent . selectInt (fanInt (unSpiderEvent e))
28152583
@@ -2843,14 +2611,8 @@ instance Monad (SpiderHost x) where
28432611 SpiderHost x >> SpiderHost y = SpiderHost $ x >> y
28442612 {-# INLINABLE return #-}
28452613 return x = SpiderHost $ return x
2846−#if !MIN_VERSION_base(4,13,0)
28472614 {-# INLINABLE fail #-}
2848− fail = MonadFail.fail
2849−#endif
2850−
2851−instance MonadFail (SpiderHost x) where
2852− {-# INLINABLE fail #-}
2853− fail s = SpiderHost $ MonadFail.fail s
2615+ fail s = SpiderHost $ fail s
28542616
28552617-- | Run an action affecting the global Spider timeline; this will be guarded by
28562618-- a mutex for that timeline
@@ -2872,21 +2634,19 @@ instance Monad (SpiderHostFrame x) where
28722634 SpiderHostFrame x >> SpiderHostFrame y = SpiderHostFrame $ x >> y
28732635 {-# INLINABLE return #-}
28742636 return x = SpiderHostFrame $ return x
2875−#if !MIN_VERSION_base(4,13,0)
28762637 {-# INLINABLE fail #-}
28772638 fail s = SpiderHostFrame $ fail s
2878−#endif
28792639
28802640instance NotReady (SpiderTimeline x) (SpiderHostFrame x) where
28812641 notReadyUntil _ = pure ()
28822642 notReady = pure ()
28832643
2884−newEventWithTriggerIO :: forall x a. HasSpiderTimeline x => (RootTrigger x a -> IO (IO ())) -> IO (Event x a)
2644+newEventWithTriggerIO :: (RootTrigger x a -> IO (IO ())) -> IO (Event x a)
28852645newEventWithTriggerIO f = do
28862646 es <- newFanEventWithTriggerIO $ \Refl -> f
28872647 return $ select es Refl
28882648
2889−newFanEventWithTriggerIO :: (HasSpiderTimeline x, GCompare k) => (forall a. k a -> RootTrigger x a -> IO (IO ())) -> IO (EventSelector x k)
2649+newFanEventWithTriggerIO :: GCompare k => (forall a. k a -> RootTrigger x a -> IO (IO ())) -> IO (EventSelector x k)
28902650newFanEventWithTriggerIO f = do
28912651 occRef <- newIORef DMap.empty
28922652 subscribedRef <- newIORef DMap.empty
@@ -2920,11 +2680,3 @@ instance MonadAtomicRef (SpiderHostFrame x) where
29202680instance PrimMonad (SpiderHostFrame x) where
29212681 type PrimState (SpiderHostFrame x) = PrimState IO
29222682 primitive = SpiderHostFrame . EventM . primitive
2923−
2924−instance NotReady (SpiderTimeline x) (SpiderHost x) where
2925− notReadyUntil _ = return ()
2926− notReady = return ()
2927−
2928−instance HasSpiderTimeline x => NotReady (SpiderTimeline x) (PerformEventT (SpiderTimeline x) (SpiderHost x)) where
2929− notReadyUntil _ = return ()
2930− notReady = return ()