@@ -9,40 +9,49 @@
99{-# LANGUAGE GADTs #-}
1010{-# LANGUAGE GeneralizedNewtypeDeriving #-}
1111{-# LANGUAGE LambdaCase #-}
12−{-# LANGUAGE MagicHash #-}
13−{-# LANGUAGE MultiParamTypeClasses #-}
14−{-# LANGUAGE MultiWayIf #-}
1512{-# LANGUAGE RankNTypes #-}
1613{-# LANGUAGE RoleAnnotations #-}
1714{-# LANGUAGE ScopedTypeVariables #-}
1815{-# LANGUAGE TypeFamilies #-}
1916{-# LANGUAGE TypeOperators #-}
2017{-# LANGUAGE UndecidableInstances #-}
18+{-# LANGUAGE PolyKinds #-}
19+{-# LANGUAGE DeriveFunctor #-}
20+{-# LANGUAGE StandaloneDeriving #-}
21+{-# LANGUAGE InstanceSigs #-}
22+{-# LANGUAGE MultiWayIf #-}
23+
2124#ifdef USE_REFLEX_OPTIMIZER
2225{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
2326#endif
24−#ifdef SPECIALIZE_TO_SPIDERTIMELINE_GLOBAL
25−{-# OPTIONS_GHC -fno-warn-orphans #-}
26−#endif
27+{-# OPTIONS_GHC -Wunused-binds #-}
2728-- | This module is the implementation of the 'Spider' 'Reflex' engine. It uses
2829-- a graph traversal algorithm to propagate 'Event's and 'Behavior's.
2930module Reflex.Spider.Internal (module Reflex.Spider.Internal) where
3031
31−import Control.Applicative
32+#if MIN_VERSION_base(4,10,0)
33+import Control.Applicative (liftA2)
34+#endif
3235import Control.Concurrent
3336import Control.Exception
34−import Control.Monad hiding (forM, forM_, mapM, mapM_, sequence)
37+import Control.Monad hiding (forM, forM_, mapM, mapM_)
3538import Control.Monad.Exception
36−import Control.Monad.Identity hiding (forM, forM_, mapM, mapM_, sequence)
39+import Control.Monad.Identity hiding (forM, forM_, mapM, mapM_)
3740import Control.Monad.Primitive
38−import Control.Monad.Reader hiding (forM, forM_, mapM, mapM_, sequence)
41+import Control.Monad.Reader.Class
42+import Control.Monad.IO.Class
43+import Control.Monad.ReaderIO
3944import Control.Monad.Ref
45+import Control.Monad.Fail (MonadFail)
46+import qualified Control.Monad.Fail as MonadFail
4047import Data.Align
4148import Data.Coerce
42−import Data.Dependent.Map (DMap, DSum (..))
49+import Data.Dependent.Map (DMap)
4350import qualified Data.Dependent.Map as DMap
51+import Data.Dependent.Sum (DSum (..))
52+import Data.FastMutableIntMap (FastMutableIntMap, PatchIntMap (..))
53+import qualified Data.FastMutableIntMap as FastMutableIntMap
4454import Data.Foldable hiding (concat, elem, sequence_)
45−import Data.Function
4655import Data.Functor.Constant
4756import Data.Functor.Misc
4857import Data.Functor.Product
@@ -50,62 +59,73 @@ import Data.GADT.Compare
5059import Data.IntMap.Strict (IntMap)
5160import qualified Data.IntMap.Strict as IntMap
5261import Data.IORef
53−import Data.List hiding (foldl')
54−import Data.Maybe
55−import Data.Monoid ((<>))
62+import Data.Kind (Type)
63+import Data.Maybe hiding (mapMaybe)
64+import Data.Monoid (mempty, (<>))
5665import Data.Proxy
5766import Data.These
5867import Data.Traversable
59−import Data.Word
60−import Data.FastMutableIntMap (FastMutableIntMap, PatchIntMap (..))
61−import qualified Data.FastMutableIntMap as FastMutableIntMap
62−import GHC.Exts
68+import Data.Type.Equality ((:~:)(Refl))
69+import Data.Witherable (Filterable, mapMaybe)
70+import GHC.Exts hiding (toList)
6371import GHC.IORef (IORef (..))
6472import GHC.Stack
6573import Reflex.FastWeak
66−import Reflex.FunctorMaybe
6774import System.IO.Unsafe
6875import System.Mem.Weak
6976import Unsafe.Coerce
7077
78+#ifdef MIN_VERSION_semialign
79+#if MIN_VERSION_these(0,8,0)
80+import Data.These.Combinators (justThese)
81+#endif
82+#if MIN_VERSION_semialign(1,1,0)
83+import Data.Zip (Zip (..))
84+#endif
85+#endif
86+
7187#ifdef DEBUG_CYCLES
7288import Control.Monad.State hiding (forM, forM_, mapM, mapM_, sequence)
89+#endif
90+
7391import Data.List.NonEmpty (NonEmpty (..), nonEmpty)
7492import qualified Data.List.NonEmpty as NonEmpty
75−import Data.Monoid (mempty)
7693import Data.Tree (Forest, Tree (..), drawForest)
77−#endif
94+import Data.List (isPrefixOf)
7895
79−import Data.FastWeakBag (FastWeakBag)
96+import Data.FastWeakBag (FastWeakBag, FastWeakBagTicket)
8097import qualified Data.FastWeakBag as FastWeakBag
81−import Data.WeakBag (WeakBag, WeakBagTicket, _weakBag_children)
82−import qualified Data.WeakBag as WeakBag
83−#ifndef SPECIALIZE_TO_SPIDERTIMELINE_GLOBAL
98+
8499import Data.Reflection
85−import Data.Some (Some)
86−import qualified Data.Some as Some
100+import Data.Some (Some(Some))
87101import Data.Type.Coercion
102+import Data.Profunctor.Unsafe ((#.), (.#))
103+import Data.WeakBag (WeakBag, WeakBagTicket, _weakBag_children)
104+import qualified Data.WeakBag as WeakBag
88105import qualified Reflex.Class
89106import qualified Reflex.Class as R
90107import qualified Reflex.Host.Class
91−#endif
92−import Reflex.Patch
93−import qualified Reflex.Patch.DMapWithMove as PatchDMapWithMove
94−
95−-- Note: must come last to silence warnings due to AMP on GHC < 7.10
96−import Prelude hiding (any, concat, mapM, mapM_, sequence)
108+import Reflex.NotReady.Class
109+import Data.Patch
110+import qualified Data.Patch.DMapWithMove as PatchDMapWithMove
111+import Reflex.PerformEvent.Base (PerformEventT)
97112
98113#ifdef DEBUG_TRACE_EVENTS
99−import System.IO (stderr)
100114import qualified Data.ByteString.Char8 as BS8
115+import System.IO (stderr)
116+import Data.List (isPrefixOf)
101117#endif
102118
103−#ifdef DEBUG_TRACE_EVENTS
119+-- TODO stdout might not be the best channel for debug output
120+debugStrLn :: String -> IO ()
121+debugStrLn = putStrLn
104122
123+#ifdef DEBUG_TRACE_EVENTS
105124withStackOneLine :: (BS8.ByteString -> a) -> a
106125withStackOneLine expr = unsafePerformIO $ do
107126 stack <- currentCallStack
108− return (expr (BS8.pack (unwords (reverse stack))))
127+ return (expr . BS8.pack . unwords . dropInternal . reverse $ stack)
128+ where dropInternal = filterStack "Reflex.Spider.Internal"
109129
110130#endif
111131
@@ -116,28 +136,42 @@ debugInvalidateHeight :: Bool
116136debugInvalidate :: Bool
117137
118138#ifdef DEBUG
119−
120139#define DEBUG_NODEIDS
121140
141+#ifdef DEBUG_TRACE_PROPAGATION
122142debugPropagate = True
143+#else
144+debugPropagate = False
145+#endif
123146
147+#ifdef DEBUG_TRACE_HEIGHT
148+debugInvalidateHeight = True
149+#else
124150debugInvalidateHeight = False
151+#endif
125152
153+#ifdef DEBUG_TRACE_INVALIDATION
126154debugInvalidate = True
155+#else
156+debugInvalidate = False
157+#endif
127158
128159class HasNodeId a where
129160 getNodeId :: a -> Int
130161
131−instance HasNodeId (Hold x p a) where
132− getNodeId = holdNodeId
162+instance HasNodeId (CacheSubscribed x a) where
163+ getNodeId = _cacheSubscribed_nodeId
133164
134−instance HasNodeId (PushSubscribed x a b) where
135− getNodeId = pushSubscribedNodeId
165+instance HasNodeId (FanInt x a) where
166+ getNodeId = _fanInt_nodeId
167+
168+instance HasNodeId (Hold x p) where
169+ getNodeId = holdNodeId
136170
137171instance HasNodeId (SwitchSubscribed x a) where
138172 getNodeId = switchSubscribedNodeId
139173
140−instance HasNodeId (FanSubscribed x a) where
174+instance HasNodeId (FanSubscribed x v a) where
141175 getNodeId = fanSubscribedNodeId
142176
143177instance HasNodeId (CoincidenceSubscribed x a) where
@@ -151,41 +185,16 @@ instance HasNodeId (Pull x a) where
151185
152186{-# INLINE showNodeId #-}
153187showNodeId :: HasNodeId a => a -> String
154−showNodeId = ("#"<>) . show . getNodeId
155−
156−showSubscriberType :: Subscriber x a -> String
157−showSubscriberType = \case
158− SubscriberPush _ _ -> "SubscriberPush"
159− SubscriberMerge _ _ -> "SubscriberMerge"
160− SubscriberFan _ -> "SubscriberFan"
161− SubscriberMergeChange _ -> "SubscriberMergeChange"
162− SubscriberHold _ -> "SubscriberHold"
163− SubscriberHoldIdentity _ -> "SubscriberHoldIdentity"
164− SubscriberSwitch _ -> "SubscriberSwitch"
165− SubscriberCoincidenceOuter _ -> "SubscriberCoincidenceOuter"
166− SubscriberCoincidenceInner _ -> "SubscriberCoincidenceInner"
167− SubscriberHandle -> "SubscriberHandle"
168−
169−showEventType :: Event x a -> String
170−showEventType = \case
171− EventRoot _ _ -> "EventRoot"
172− EventNever -> "EventNever"
173− EventPush _ -> "EventPush"
174− EventMerge _ -> "EventMerge"
175− EventFan _ _ -> "EventFan"
176− EventSwitch _ -> "EventSwitch"
177− EventCoincidence _ -> "EventCoincidence"
178− EventHold _ -> "EventHold"
179− EventDyn _ -> "EventDyn"
180− EventHoldIdentity _ -> "EventHoldIdentity"
181− EventDynIdentity _ -> "EventDynIdentity"
188+showNodeId = showNodeId' . getNodeId
189+
190+showNodeId' :: Int -> String
191+showNodeId' = ("#"<>) . show
192+
182193
183194#else
184195
185196debugPropagate = False
186−
187197debugInvalidateHeight = False
188−
189198debugInvalidate = False
190199
191200-- This must be inline, or error messages will cause memory leaks due to retaining the node in question
@@ -193,6 +202,10 @@ debugInvalidate = False
193202showNodeId :: a -> String
194203showNodeId _ = ""
195204
205+{-# INLINE showNodeId' #-}
206+showNodeId' :: Int -> String
207+showNodeId' _ = ""
208+
196209#endif
197210
198211#ifdef DEBUG_NODEIDS
@@ -202,12 +215,6 @@ nextNodeIdRef = unsafePerformIO $ newIORef 1
202215
203216newNodeId :: IO Int
204217newNodeId = atomicModifyIORef' nextNodeIdRef $ \n -> (succ n, n)
205−
206−{-# NOINLINE unsafeNodeId #-}
207−unsafeNodeId :: a -> Int
208−unsafeNodeId a = unsafePerformIO $ do
209− touch a
210− newNodeId
211218#endif
212219
213220--------------------------------------------------------------------------------
@@ -246,7 +253,7 @@ subscribeAndRead = unEvent
246253{-# INLINE [1] pushCheap #-}
247254pushCheap :: HasSpiderTimeline x => (a -> ComputeM x (Maybe b)) -> Event x a -> Event x b
248255pushCheap !f e = Event $ \sub -> do
249− (subscription, occ) <- subscribeAndRead e $ sub
256+ (subscription, occ) <- subscribeAndRead e $ debugSubscriber' "push" $ sub
250257 { subscriberPropagate = \a -> do
251258 mb <- f a
252259 mapM_ (subscriberPropagate sub) mb
@@ -265,10 +272,10 @@ terminalSubscriber p = Subscriber
265272
266273-- | Subscribe to an Event only for the duration of one occurrence
267274{-# INLINE subscribeAndReadHead #-}
268−subscribeAndReadHead :: Event x a -> Subscriber x a -> EventM x (EventSubscription x, Maybe a)
275+subscribeAndReadHead :: HasSpiderTimeline x => Event x a -> Subscriber x a -> EventM x (EventSubscription x, Maybe a)
269276subscribeAndReadHead e sub = do
270277 subscriptionRef <- liftIO $ newIORef $ error "subscribeAndReadHead: not initialized"
271− (subscription, occ) <- subscribeAndRead e $ sub
278+ (subscription, occ) <- subscribeAndRead e $ debugSubscriber' "head" $ sub
272279 { subscriberPropagate = \a -> do
273280 liftIO $ unsubscribe =<< readIORef subscriptionRef
274281 subscriberPropagate sub a
@@ -279,24 +286,42 @@ subscribeAndReadHead e sub = do
279286 return (subscription, occ)
280287
281288--TODO: Make this lazy in its input event
282−headE :: (MonadIO m, Defer (SomeMergeInit x) m) => Event x a -> m (Event x a)
289+headE :: (MonadIO m, Defer (SomeMergeInit x) m, HasSpiderTimeline x) => Event x a -> m (Event x a)
283290headE originalE = do
284291 parent <- liftIO $ newIORef $ Just originalE
285292 defer $ SomeMergeInit $ do --TODO: Rename SomeMergeInit appropriately
286293 let clearParent = liftIO $ writeIORef parent Nothing
287− (_, occ) <- subscribeAndReadHead originalE $ terminalSubscriber $ \_ -> clearParent
294+ (_, occ) <- subscribeAndReadHead originalE $ terminalSubscriber $ const clearParent
288295 when (isJust occ) clearParent
289− return $ Event $ \sub -> do
296+ return $ Event $ \sub ->
290297 liftIO (readIORef parent) >>= \case
291− Nothing -> return (EventSubscription (return ()) $ EventSubscribed zeroRef $ toAny (), Nothing)
298+ Nothing -> subscribeAndReadNever
292299 Just e -> subscribeAndReadHead e sub
293300
294301data CacheSubscribed x a
295302 = CacheSubscribed { _cacheSubscribed_subscribers :: {-# UNPACK #-} !(FastWeakBag (Subscriber x a))
296303 , _cacheSubscribed_parent :: {-# UNPACK #-} !(EventSubscription x)
297304 , _cacheSubscribed_occurrence :: {-# UNPACK #-} !(IORef (Maybe a))
305+#ifdef DEBUG_NODEIDS
306+ , _cacheSubscribed_nodeId :: {-# UNPACK #-} !Int
307+#endif
298308 }
299309
310+nowSpiderEventM :: (HasSpiderTimeline x) => EventM x (R.Event (SpiderTimeline x) ())
311+nowSpiderEventM =
312+ SpiderEvent <$> now
313+
314+now :: (MonadIO m, Defer (Some Clear) m, HasSpiderTimeline x
315+ ) => m (Event x ())
316+now = do
317+ nowOrNot <- liftIO $ newIORef $ Just ()
318+ scheduleClear nowOrNot
319+ return . Event $ \_ -> do
320+ occ <- liftIO . readIORef $ nowOrNot
321+ return ( EventSubscription (return ()) eventSubscribedNow
322+ , occ
323+ )
324+
300325-- | Construct an 'Event' whose value is guaranteed not to be recomputed
301326-- repeatedly
302327--
@@ -311,27 +336,33 @@ cacheEvent e =
311336#else
312337 Event $
313338#endif
314− let mSubscribedRef :: IORef (FastWeak (CacheSubscribed x a))
315− !mSubscribedRef = unsafeNewIORef e emptyFastWeak
316− in \sub -> {-# SCC "cacheEvent" #-} do
339+ unsafePerformIO $ do
340+ mSubscribedRef :: IORef (FastWeak (CacheSubscribed x a))
341+ <- newIORef emptyFastWeak
342+ pure $ \sub -> {-# SCC "cacheEvent" #-} do
317343#ifdef DEBUG_TRACE_EVENTS
318344 unless (BS8.null callSite) $ liftIO $ BS8.hPutStrLn stderr callSite
319345#endif
320346 subscribedTicket <- liftIO (readIORef mSubscribedRef >>= getFastWeakTicket) >>= \case
321347 Just subscribedTicket -> return subscribedTicket
322348 Nothing -> do
349+#ifdef DEBUG_NODEIDS
350+ nodeId <- liftIO newNodeId
351+#endif
323352 subscribers <- liftIO FastWeakBag.empty
324353 occRef <- liftIO $ newIORef Nothing -- This should never be read prior to being set below
354+#ifdef DEBUG_NODEIDS
355+ (parentSub, occ) <- subscribeAndRead e $ debugSubscriber' ("cacheEvent" <> showNodeId' nodeId) $ Subscriber
356+#else
325357 (parentSub, occ) <- subscribeAndRead e $ Subscriber
326− { subscriberPropagate = \a -> do
327− liftIO $ writeIORef occRef $ Just a
328− scheduleClear occRef
329− propagateFast a subscribers
330− , subscriberInvalidateHeight = \old -> do
331− FastWeakBag.traverse subscribers $ invalidateSubscriberHeight old
332− , subscriberRecalculateHeight = \new -> do
333− FastWeakBag.traverse subscribers $ recalculateSubscriberHeight new
334− }
358+#endif
359+ { subscriberPropagate = \a -> do
360+ liftIO $ writeIORef occRef (Just a)
361+ scheduleClear occRef
362+ propagateFast a subscribers
363+ , subscriberInvalidateHeight = FastWeakBag.traverse_ subscribers . invalidateSubscriberHeight
364+ , subscriberRecalculateHeight = FastWeakBag.traverse_ subscribers . recalculateSubscriberHeight
365+ }
335366 when (isJust occ) $ do
336367 liftIO $ writeIORef occRef occ -- Set the initial value of occRef; we don't need to do this if occ is Nothing
337368 scheduleClear occRef
@@ -339,29 +370,45 @@ cacheEvent e =
339370 { _cacheSubscribed_subscribers = subscribers
340371 , _cacheSubscribed_parent = parentSub
341372 , _cacheSubscribed_occurrence = occRef
373+#ifdef DEBUG_NODEIDS
374+ , _cacheSubscribed_nodeId = nodeId
375+#endif
342376 }
343377 subscribedTicket <- liftIO $ mkFastWeakTicket subscribed
344378 liftIO $ writeIORef mSubscribedRef =<< getFastWeakTicketWeak subscribedTicket
345379 return subscribedTicket
346− liftIO $ do
347− subscribed <- getFastWeakTicketValue subscribedTicket
348− ticket <- FastWeakBag.insert sub $ _cacheSubscribed_subscribers subscribed
349− occ <- readIORef $ _cacheSubscribed_occurrence subscribed
350− let es = EventSubscription
351− { _eventSubscription_unsubscribe = do
352− FastWeakBag.remove ticket
353− isEmpty <- FastWeakBag.isEmpty $ _cacheSubscribed_subscribers subscribed
354− when isEmpty $ do
355− writeIORef mSubscribedRef emptyFastWeak
356− unsubscribe $ _cacheSubscribed_parent subscribed
357− touch ticket
358− touch subscribedTicket
359− , _eventSubscription_subscribed = EventSubscribed
360− { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed $ _cacheSubscribed_parent subscribed
361− , eventSubscribedRetained = toAny subscribedTicket
362− }
363− }
364− return (es, occ)
380+ liftIO $ cacheSubscription sub mSubscribedRef subscribedTicket
381+
382+cacheSubscription :: Subscriber x a -> IORef (FastWeak (CacheSubscribed x a))
383+ -> FastWeakTicket (CacheSubscribed x a) -> IO (EventSubscription x, Maybe a)
384+cacheSubscription sub mSubscribedRef subscribedTicket = do
385+ subscribed <- getFastWeakTicketValue subscribedTicket
386+ ticket <- FastWeakBag.insert sub $ _cacheSubscribed_subscribers subscribed
387+ occ <- readIORef $ _cacheSubscribed_occurrence subscribed
388+
389+ let parentSub = _cacheSubscribed_parent subscribed
390+ es = EventSubscription
391+ { _eventSubscription_unsubscribe = do
392+ FastWeakBag.remove ticket
393+
394+ isEmpty <- FastWeakBag.isEmpty $ _cacheSubscribed_subscribers subscribed
395+ when isEmpty $ do
396+ writeIORef mSubscribedRef emptyFastWeak
397+ unsubscribe parentSub
398+ touch ticket
399+ touch subscribedTicket
400+ , _eventSubscription_subscribed = EventSubscribed
401+ { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed parentSub
402+ , eventSubscribedRetained = toAny subscribedTicket
403+#ifdef DEBUG_CYCLES
404+ , eventSubscribedGetParents = return [_eventSubscription_subscribed parentSub]
405+ , eventSubscribedHasOwnHeightRef = False
406+ , eventSubscribedWhoCreated = whoCreatedIORef mSubscribedRef
407+#endif
408+ }
409+ }
410+ return (es, occ)
411+
365412
366413subscribe :: Event x a -> Subscriber x a -> EventM x (EventSubscription x)
367414subscribe e s = fst <$> subscribeAndRead e s
@@ -373,13 +420,16 @@ wrap tag getSpecificSubscribed sub = do
373420 let es = tag subd
374421 return (EventSubscription (WeakBag.remove sln >> touch sln) es, occ)
375422
376−eventRoot :: GCompare k => k a -> Root x k -> Event x a
423+eventRoot :: (GCompare k, HasSpiderTimeline x) => k a -> Root x k -> Event x a
377424eventRoot !k !r = Event $ wrap eventSubscribedRoot $ liftIO . getRootSubscribed k r
378425
426+subscribeAndReadNever :: EventM x (EventSubscription x, Maybe a)
427+subscribeAndReadNever = return (EventSubscription (return ()) eventSubscribedNever, Nothing)
428+
379429eventNever :: Event x a
380−eventNever = Event $ \_ -> return (EventSubscription (return ()) eventSubscribedNever, Nothing)
430+eventNever = Event $ const subscribeAndReadNever
381431
382−eventFan :: (GCompare k, HasSpiderTimeline x) => k a -> Fan x k -> Event x a
432+eventFan :: (GCompare k, HasSpiderTimeline x) => k a -> Fan x k v -> Event x (v a)
383433eventFan !k !f = Event $ wrap eventSubscribedFan $ getFanSubscribed k f
384434
385435eventSwitch :: HasSpiderTimeline x => Switch x a -> Event x a
@@ -388,7 +438,7 @@ eventSwitch !s = Event $ wrap eventSubscribedSwitch $ getSwitchSubscribed s
388438eventCoincidence :: HasSpiderTimeline x => Coincidence x a -> Event x a
389439eventCoincidence !c = Event $ wrap eventSubscribedCoincidence $ getCoincidenceSubscribed c
390440
391−eventHold :: HasSpiderTimeline x => Hold x p -> Event x p
441+eventHold :: Hold x p -> Event x p
392442eventHold !h = Event $ subscribeHoldEvent h
393443
394444eventDyn :: (HasSpiderTimeline x, Patch p) => Dyn x p -> Event x p
@@ -414,16 +464,6 @@ data Subscriber x a = Subscriber
414464 , subscriberRecalculateHeight :: !(Height -> IO ())
415465 }
416466
417−--TODO: Move this comment to WeakBag
418−-- These function are constructor functions that are marked NOINLINE so they are
419−-- opaque to GHC. If we do not do this, then GHC will sometimes fuse the constructor away
420−-- so any weak references that are attached to the constructors will have their
421−-- finalizer run. Using the opaque constructor, does not see the
422−-- constructor application, so it behaves like an IORef and cannot be fused away.
423−--
424−-- The result is also evaluated to WHNF, since forcing a thunk invalidates
425−-- the weak pointer to it in some cases.
426−
427467newSubscriberHold :: (HasSpiderTimeline x, Patch p) => Hold x p -> IO (Subscriber x p)
428468newSubscriberHold h = return $ Subscriber
429469 { subscriberPropagate = {-# SCC "traverseHold" #-} propagateSubscriberHold h
@@ -431,85 +471,68 @@ newSubscriberHold h = return $ Subscriber
431471 , subscriberRecalculateHeight = \_ -> return ()
432472 }
433473
434−newSubscriberFan :: forall x k. (HasSpiderTimeline x, GCompare k) => FanSubscribed x k -> IO (Subscriber x (DMap k Identity))
435−newSubscriberFan subscribed = return $ Subscriber
474+newSubscriberFan :: forall x k v. (HasSpiderTimeline x, GCompare k) => FanSubscribed x k v -> IO (Subscriber x (DMap k v))
475+newSubscriberFan subscribed = debugSubscriber ("SubscriberFan " <> showNodeId subscribed) $ Subscriber
436476 { subscriberPropagate = \a -> {-# SCC "traverseFan" #-} do
437477 subs <- liftIO $ readIORef $ fanSubscribedSubscribers subscribed
438− tracePropagate (Proxy :: Proxy x) $ "SubscriberFan" <> showNodeId subscribed <> ": " ++ show (DMap.size subs) ++ " keys subscribed, " ++ show (DMap.size a) ++ " keys firing"
478+ tracePropagate (Proxy :: Proxy x) $ show (DMap.size subs) <> " keys subscribed, " <> show (DMap.size a) <> " keys firing"
439479 liftIO $ writeIORef (fanSubscribedOccurrence subscribed) $ Just a
440480 scheduleClear $ fanSubscribedOccurrence subscribed
441− let f _ (Pair (Identity v) subsubs) = do
481+ let f _ (Pair v subsubs) = do
442482 propagate v $ _fanSubscribedChildren_list subsubs
443483 return $ Constant ()
444484 _ <- DMap.traverseWithKey f $ DMap.intersectionWithKey (\_ -> Pair) a subs --TODO: Would be nice to have DMap.traverse_
445485 return ()
446486 , subscriberInvalidateHeight = \old -> do
447− when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberFan" <> showNodeId subscribed
448487 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
449− forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse (_fanSubscribedChildren_list v) $ invalidateSubscriberHeight old
450− when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberFan" <> showNodeId subscribed <> " done"
488+ forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse_ (_fanSubscribedChildren_list v) $ invalidateSubscriberHeight old
451489 , subscriberRecalculateHeight = \new -> do
452− when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberFan" <> showNodeId subscribed
453490 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
454− forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse (_fanSubscribedChildren_list v) $ recalculateSubscriberHeight new
455− when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberFan" <> showNodeId subscribed <> " done"
491+ forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse_ (_fanSubscribedChildren_list v) $ recalculateSubscriberHeight new
456492 }
457493
458494newSubscriberSwitch :: forall x a. HasSpiderTimeline x => SwitchSubscribed x a -> IO (Subscriber x a)
459−newSubscriberSwitch subscribed = return $ Subscriber
495+newSubscriberSwitch subscribed = debugSubscriber ("SubscriberCoincidenceOuter" <> showNodeId subscribed) $ Subscriber
460496 { subscriberPropagate = \a -> {-# SCC "traverseSwitch" #-} do
461− tracePropagate (Proxy :: Proxy x) $ "SubscriberSwitch" <> showNodeId subscribed
462497 liftIO $ writeIORef (switchSubscribedOccurrence subscribed) $ Just a
463498 scheduleClear $ switchSubscribedOccurrence subscribed
464499 propagate a $ switchSubscribedSubscribers subscribed
465500 , subscriberInvalidateHeight = \_ -> do
466− when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed
467501 oldHeight <- readIORef $ switchSubscribedHeight subscribed
468502 when (oldHeight /= invalidHeight) $ do
469503 writeIORef (switchSubscribedHeight subscribed) $! invalidHeight
470− WeakBag.traverse (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
471− when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed <> " done"
472− , subscriberRecalculateHeight = \new -> do
473− when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed
474− updateSwitchHeight new subscribed
475− when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed <> " done"
476− }
504+ WeakBag.traverse_ (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
505+ , subscriberRecalculateHeight = (`updateSwitchHeight` subscribed)
506+ }
477507
478508newSubscriberCoincidenceOuter :: forall x b. HasSpiderTimeline x => CoincidenceSubscribed x b -> IO (Subscriber x (Event x b))
479−newSubscriberCoincidenceOuter subscribed = return $ Subscriber
509+newSubscriberCoincidenceOuter subscribed = debugSubscriber ("SubscriberCoincidenceOuter" <> showNodeId subscribed) $ Subscriber
480510 { subscriberPropagate = \a -> {-# SCC "traverseCoincidenceOuter" #-} do
481− tracePropagate (Proxy :: Proxy x) $ "SubscriberCoincidenceOuter" <> showNodeId subscribed
482511 outerHeight <- liftIO $ readIORef $ coincidenceSubscribedHeight subscribed
483512 tracePropagate (Proxy :: Proxy x) $ " outerHeight = " <> show outerHeight
484513 (occ, innerHeight, innerSubd) <- subscribeCoincidenceInner a outerHeight subscribed
485514 tracePropagate (Proxy :: Proxy x) $ " isJust occ = " <> show (isJust occ)
486515 tracePropagate (Proxy :: Proxy x) $ " innerHeight = " <> show innerHeight
516+
487517 liftIO $ writeIORef (coincidenceSubscribedInnerParent subscribed) $ Just innerSubd
488518 scheduleClear $ coincidenceSubscribedInnerParent subscribed
489519 case occ of
490− Nothing -> do
520+ Nothing ->
491521 when (innerHeight > outerHeight) $ liftIO $ do -- If the event fires, it will fire at a later height
492522 writeIORef (coincidenceSubscribedHeight subscribed) $! innerHeight
493− WeakBag.traverse (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight outerHeight
494− WeakBag.traverse (coincidenceSubscribedSubscribers subscribed) $ recalculateSubscriberHeight innerHeight
523+ WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight outerHeight
524+ WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ recalculateSubscriberHeight innerHeight
495525 Just o -> do -- Since it's already firing, no need to adjust height
496526 liftIO $ writeIORef (coincidenceSubscribedOccurrence subscribed) occ
497527 scheduleClear $ coincidenceSubscribedOccurrence subscribed
498528 propagate o $ coincidenceSubscribedSubscribers subscribed
499− , subscriberInvalidateHeight = \_ -> do
500− when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed
501− invalidateCoincidenceHeight subscribed
502− when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed <> " done"
503− , subscriberRecalculateHeight = \_ -> do
504− when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed
505− recalculateCoincidenceHeight subscribed
506− when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed <> " done"
529+ , subscriberInvalidateHeight = \_ -> invalidateCoincidenceHeight subscribed
530+ , subscriberRecalculateHeight = \_ -> recalculateCoincidenceHeight subscribed
507531 }
508532
509533newSubscriberCoincidenceInner :: forall x a. HasSpiderTimeline x => CoincidenceSubscribed x a -> IO (Subscriber x a)
510−newSubscriberCoincidenceInner subscribed = return $ Subscriber
534+newSubscriberCoincidenceInner subscribed = debugSubscriber ("SubscriberCoincidenceInner" <> showNodeId subscribed) $ Subscriber
511535 { subscriberPropagate = \a -> {-# SCC "traverseCoincidenceInner" #-} do
512− tracePropagate (Proxy :: Proxy x) $ "SubscriberCoincidenceInner" <> showNodeId subscribed
513536 occ <- liftIO $ readIORef $ coincidenceSubscribedOccurrence subscribed
514537 case occ of
515538 Just _ -> return () -- SubscriberCoincidenceOuter must have already propagated this event
@@ -517,14 +540,8 @@ newSubscriberCoincidenceInner subscribed = return $ Subscriber
517540 liftIO $ writeIORef (coincidenceSubscribedOccurrence subscribed) $ Just a
518541 scheduleClear $ coincidenceSubscribedOccurrence subscribed
519542 propagate a $ coincidenceSubscribedSubscribers subscribed
520− , subscriberInvalidateHeight = \_ -> do
521− when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed
522− invalidateCoincidenceHeight subscribed
523− when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed <> " done"
524− , subscriberRecalculateHeight = \_ -> do
525− when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed
526− recalculateCoincidenceHeight subscribed
527− when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed <> " done"
543+ , subscriberInvalidateHeight = \_ -> invalidateCoincidenceHeight subscribed
544+ , subscriberRecalculateHeight = \_ -> recalculateCoincidenceHeight subscribed
528545 }
529546
530547invalidateSubscriberHeight :: Height -> Subscriber x a -> IO ()
@@ -534,18 +551,18 @@ recalculateSubscriberHeight :: Height -> Subscriber x a -> IO ()
534551recalculateSubscriberHeight = flip subscriberRecalculateHeight
535552
536553-- | Propagate everything at the current height
537−propagate :: a -> WeakBag (Subscriber x a) -> EventM x ()
538−propagate a subscribers = withIncreasedDepth $ do
554+propagate :: forall x a. HasSpiderTimeline x => a -> WeakBag (Subscriber x a) -> EventM x ()
555+propagate a subscribers = withIncreasedDepth (Proxy::Proxy x) $
539556 -- Note: in the following traversal, we do not visit nodes that are added to the list during our traversal; they are new events, which will necessarily have full information already, so there is no need to traverse them
540557 --TODO: Should we check if nodes already have their values before propagating? Maybe we're re-doing work
541− WeakBag.traverse subscribers $ \s -> subscriberPropagate s a
558+ WeakBag.traverse_ subscribers $ \s -> subscriberPropagate s a
542559
543560-- | Propagate everything at the current height
544−propagateFast :: a -> FastWeakBag (Subscriber x a) -> EventM x ()
545−propagateFast a subscribers = withIncreasedDepth $ do
561+propagateFast :: forall x a. HasSpiderTimeline x => a -> FastWeakBag (Subscriber x a) -> EventM x ()
562+propagateFast a subscribers = withIncreasedDepth (Proxy::Proxy x) $
546563 -- Note: in the following traversal, we do not visit nodes that are added to the list during our traversal; they are new events, which will necessarily have full information already, so there is no need to traverse them
547564 --TODO: Should we check if nodes already have their values before propagating? Maybe we're re-doing work
548− FastWeakBag.traverse subscribers $ \s -> subscriberPropagate s a
565+ FastWeakBag.traverse_ subscribers $ \s -> subscriberPropagate s a
549566
550567--------------------------------------------------------------------------------
551568-- EventSubscribed
@@ -554,11 +571,16 @@ propagateFast a subscribers = withIncreasedDepth $ do
554571toAny :: a -> Any
555572toAny = unsafeCoerce
556573
574+-- Why do we use Any here, instead of just giving eventSubscribedRetained an
575+-- existential type? Sadly, GHC does not currently know how to unbox types
576+-- with existentially quantified fields. So instead we just coerce values
577+-- to type Any on the way in. Since we never coerce them back, this is
578+-- perfectly safe.
557579data EventSubscribed x = EventSubscribed
558580 { eventSubscribedHeightRef :: {-# UNPACK #-} !(IORef Height)
559581 , eventSubscribedRetained :: {-# NOUNPACK #-} !Any
560582#ifdef DEBUG_CYCLES
561− , eventSubscribedGetParents :: !(IO [Some (EventSubscribed x)]) -- For debugging loops
583+ , eventSubscribedGetParents :: !(IO [EventSubscribed x]) -- For debugging loops
562584 , eventSubscribedHasOwnHeightRef :: !Bool
563585 , eventSubscribedWhoCreated :: !(IO [String])
564586#endif
@@ -585,13 +607,23 @@ eventSubscribedNever = EventSubscribed
585607 , eventSubscribedWhoCreated = return ["never"]
586608#endif
587609 }
610+eventSubscribedNow :: EventSubscribed x
611+eventSubscribedNow = EventSubscribed
612+ { eventSubscribedHeightRef = zeroRef
613+ , eventSubscribedRetained = toAny ()
614+#ifdef DEBUG_CYCLES
615+ , eventSubscribedGetParents = return []
616+ , eventSubscribedHasOwnHeightRef = False
617+ , eventSubscribedWhoCreated = return ["now"]
618+#endif
619+ }
588620
589−eventSubscribedFan :: FanSubscribed x k -> EventSubscribed x
621+eventSubscribedFan :: FanSubscribed x k v -> EventSubscribed x
590622eventSubscribedFan !subscribed = EventSubscribed
591623 { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed $ fanSubscribedParent subscribed
592624 , eventSubscribedRetained = toAny subscribed
593625#ifdef DEBUG_CYCLES
594− , eventSubscribedGetParents = return [Some.This $ _eventSubscription_subscribed $ fanSubscribedParent subscribed]
626+ , eventSubscribedGetParents = return [_eventSubscription_subscribed $ fanSubscribedParent subscribed]
595627 , eventSubscribedHasOwnHeightRef = False
596628 , eventSubscribedWhoCreated = whoCreatedIORef $ fanSubscribedCachedSubscribed subscribed
597629#endif
@@ -604,7 +636,7 @@ eventSubscribedSwitch !subscribed = EventSubscribed
604636#ifdef DEBUG_CYCLES
605637 , eventSubscribedGetParents = do
606638 s <- readIORef $ switchSubscribedCurrentParent subscribed
607− return [Some.This $ _eventSubscription_subscribed s]
639+ return [_eventSubscription_subscribed s]
608640 , eventSubscribedHasOwnHeightRef = True
609641 , eventSubscribedWhoCreated = whoCreatedIORef $ switchSubscribedCachedSubscribed subscribed
610642#endif
@@ -617,8 +649,8 @@ eventSubscribedCoincidence !subscribed = EventSubscribed
617649#ifdef DEBUG_CYCLES
618650 , eventSubscribedGetParents = do
619651 innerSubscription <- readIORef $ coincidenceSubscribedInnerParent subscribed
620− let outerParent = Some.This $ _eventSubscription_subscribed $ coincidenceSubscribedOuterParent subscribed
621− innerParents = maybeToList $ fmap Some.This innerSubscription
652+ let outerParent = _eventSubscription_subscribed $ coincidenceSubscribedOuterParent subscribed
653+ innerParents = maybeToList $ innerSubscription
622654 return $ outerParent : innerParents
623655 , eventSubscribedHasOwnHeightRef = True
624656 , eventSubscribedWhoCreated = whoCreatedIORef $ coincidenceSubscribedCachedSubscribed subscribed
@@ -632,20 +664,20 @@ getEventSubscribedHeight es = readIORef $ eventSubscribedHeightRef es
632664whoCreatedEventSubscribed :: EventSubscribed x -> IO [String]
633665whoCreatedEventSubscribed = eventSubscribedWhoCreated
634666
635−walkInvalidHeightParents :: EventSubscribed x -> IO [Some (EventSubscribed x)]
667+walkInvalidHeightParents :: EventSubscribed x -> IO [EventSubscribed x]
636668walkInvalidHeightParents s0 = do
637− subscribers <- flip execStateT mempty $ ($ Some.This s0) $ fix $ \loop (Some.This s) -> do
669+ subscribers <- flip execStateT mempty $ ($ s0) $ fix $ \loop s -> do
638670 h <- liftIO $ readIORef $ eventSubscribedHeightRef s
639671 when (h == invalidHeight) $ do
640672 when (eventSubscribedHasOwnHeightRef s) $ liftIO $ writeIORef (eventSubscribedHeightRef s) $! invalidHeightBeingTraversed
641− modify (Some.This s :)
673+ modify (s :)
642674 mapM_ loop =<< liftIO (eventSubscribedGetParents s)
643− forM_ subscribers $ \(Some.This s) -> writeIORef (eventSubscribedHeightRef s) $! invalidHeight
675+ forM_ subscribers $ \s -> writeIORef (eventSubscribedHeightRef s) $! invalidHeight
644676 return subscribers
645677#endif
646678
647679{-# INLINE subscribeHoldEvent #-}
648−subscribeHoldEvent :: HasSpiderTimeline x => Hold x p -> Subscriber x p -> EventM x (EventSubscription x, Maybe p)
680+subscribeHoldEvent :: Hold x p -> Subscriber x p -> EventM x (EventSubscription x, Maybe p)
649681subscribeHoldEvent = subscribeAndRead . holdEvent
650682
651683--------------------------------------------------------------------------------
@@ -668,7 +700,7 @@ behaviorPull !p = Behavior $ do
668700 val <- liftIO $ readIORef $ pullValue p
669701 case val of
670702 Just subscribed -> do
671− askParentsRef >>= mapM_ (\r -> liftIO $ modifyIORef' r (SomeBehaviorSubscribed (BehaviorSubscribedPull subscribed) :))
703+ askParentsRef >>= mapM_ (\r -> liftIO $ modifyIORef' r (SomeBehaviorSubscribed (Some (BehaviorSubscribedPull subscribed)) :))
672704 askInvalidator >>= mapM_ (\wi -> liftIO $ modifyIORef' (pullSubscribedInvalidators subscribed) (wi:))
673705 liftIO $ touch $ pullSubscribedOwnInvalidator subscribed
674706 return $ pullSubscribedValue subscribed
@@ -677,7 +709,7 @@ behaviorPull !p = Behavior $ do
677709 wi <- liftIO $ mkWeakPtrWithDebug i "InvalidatorPull"
678710 parentsRef <- liftIO $ newIORef []
679711 holdInits <- askBehaviorHoldInits
680− a <- liftIO $ runReaderT (unBehaviorM $ pullCompute p) (Just (wi, parentsRef), holdInits)
712+ a <- liftIO $ runReaderIO (unBehaviorM $ pullCompute p) (Just (wi, parentsRef), holdInits)
681713 invsRef <- liftIO . newIORef . maybeToList =<< askInvalidator
682714 parents <- liftIO $ readIORef parentsRef
683715 let subscribed = PullSubscribed
@@ -687,7 +719,7 @@ behaviorPull !p = Behavior $ do
687719 , pullSubscribedParents = parents
688720 }
689721 liftIO $ writeIORef (pullValue p) $ Just subscribed
690− askParentsRef >>= mapM_ (\r -> liftIO $ modifyIORef' r (SomeBehaviorSubscribed (BehaviorSubscribedPull subscribed) :))
722+ askParentsRef >>= mapM_ (\r -> liftIO $ modifyIORef' r (SomeBehaviorSubscribed (Some (BehaviorSubscribedPull subscribed)) :))
691723 return a
692724
693725behaviorDyn :: Patch p => Dyn x p -> Behavior x (PatchTarget p)
@@ -698,7 +730,8 @@ readHoldTracked :: Hold x p -> BehaviorM x (PatchTarget p)
698730readHoldTracked h = do
699731 result <- liftIO $ readIORef $ holdValue h
700732 askInvalidator >>= mapM_ (\wi -> liftIO $ modifyIORef' (holdInvalidators h) (wi:))
701− askParentsRef >>= mapM_ (\r -> liftIO $ modifyIORef' r (SomeBehaviorSubscribed (BehaviorSubscribedHold h) :))
733+ askParentsRef >>= mapM_ (\r -> liftIO $ modifyIORef' r (SomeBehaviorSubscribed (Some (BehaviorSubscribedHold h)) :))
734+ liftIO $ touch h -- Otherwise, if this gets inlined enough, the hold's parent reference may get collected
702735 return result
703736
704737{-# INLINABLE readBehaviorUntracked #-}
@@ -711,42 +744,46 @@ readBehaviorUntracked b = do
711744-- Dynamic
712745--------------------------------------------------------------------------------
713746
714−data Dynamic x p = Dynamic
715− { dynamicCurrent :: !(Behavior x (PatchTarget p))
716− , dynamicUpdated :: !(Event x p)
747+type DynamicS x p = Dynamic x (PatchTarget p) p
748+
749+data Dynamic x target p = Dynamic
750+ { dynamicCurrent :: !(Behavior x target)
751+ , dynamicUpdated :: Event x p -- This must be lazy; see the comment on holdEvent --TODO: Would this let us eliminate `Dyn`?
717752 }
718753
719−dynamicHold :: HasSpiderTimeline x => Hold x p -> Dynamic x p
754+deriving instance (HasSpiderTimeline x) => Functor (Dynamic x target)
755+
756+
757+
758+
759+dynamicHold :: Hold x p -> DynamicS x p
720760dynamicHold !h = Dynamic
721761 { dynamicCurrent = behaviorHold h
722762 , dynamicUpdated = eventHold h
723763 }
724764
725−dynamicHoldIdentity :: HasSpiderTimeline x => Hold x (Identity a) -> Dynamic x (Identity a)
765+dynamicHoldIdentity :: Hold x (Identity a) -> DynamicS x (Identity a)
726766dynamicHoldIdentity = dynamicHold
727767
728−dynamicConst :: PatchTarget p -> Dynamic x p
768+dynamicConst :: PatchTarget p -> DynamicS x p
729769dynamicConst !a = Dynamic
730770 { dynamicCurrent = behaviorConst a
731771 , dynamicUpdated = eventNever
732772 }
733773
734−dynamicDyn :: (HasSpiderTimeline x, Patch p) => Dyn x p -> Dynamic x p
774+dynamicDyn :: (HasSpiderTimeline x, Patch p) => Dyn x p -> DynamicS x p
735775dynamicDyn !d = Dynamic
736776 { dynamicCurrent = behaviorDyn d
737777 , dynamicUpdated = eventDyn d
738778 }
739779
740−dynamicDynIdentity :: HasSpiderTimeline x => Dyn x (Identity a) -> Dynamic x (Identity a)
780+dynamicDynIdentity :: HasSpiderTimeline x => Dyn x (Identity a) -> DynamicS x (Identity a)
741781dynamicDynIdentity = dynamicDyn
742782
743783--------------------------------------------------------------------------------
744784-- Combinators
745785--------------------------------------------------------------------------------
746786
747−--TODO: Figure out why certain things are not 'representational', then make them
748−--representational so we can use coerce
749−
750787--type role Hold representational
751788data Hold x p
752789 = Hold { holdValue :: !(IORef (PatchTarget p))
@@ -758,9 +795,7 @@ data Hold x p
758795#endif
759796 }
760797
761−-- | A statically allocated 'SpiderTimeline'; this is the only instance of
762−-- 'SpiderTimeline' that can used when using
763−-- -fspecialize-to-spidertimeline-global.
798+-- | A statically allocated 'SpiderTimeline'
764799data Global
765800
766801{-# NOINLINE globalSpiderTimelineEnv #-}
@@ -769,30 +804,27 @@ globalSpiderTimelineEnv = unsafePerformIO unsafeNewSpiderTimelineEnv
769804
770805-- | Stores all global data relevant to a particular Spider timeline; only one
771806-- value should exist for each type @x@
772−data SpiderTimelineEnv x = SpiderTimelineEnv
807+newtype SpiderTimelineEnv x = STE {unSTE :: SpiderTimelineEnv' x}
808+-- We implement SpiderTimelineEnv with a newtype wrapper so
809+-- we can get the coercions we want safely.
810+type role SpiderTimelineEnv nominal
811+
812+data SpiderTimelineEnv' x = SpiderTimelineEnv
773813 { _spiderTimeline_lock :: {-# UNPACK #-} !(MVar ())
774814 , _spiderTimeline_eventEnv :: {-# UNPACK #-} !(EventEnv x)
775815#ifdef DEBUG
776816 , _spiderTimeline_depth :: {-# UNPACK #-} !(IORef Int)
777817#endif
778818 }
779−type role SpiderTimelineEnv nominal
819+type role SpiderTimelineEnv' phantom
780820
781821instance Eq (SpiderTimelineEnv x) where
782822 _ == _ = True -- Since only one exists of each type
783823
784824instance GEq SpiderTimelineEnv where
785−#ifdef EXPERIMENTAL_DEPENDENT_SUM_INSTANCES
786− geqToEq _ = id
787− geqUnify (a :: SpiderTimelineEnv a) (b :: SpiderTimelineEnv b) different same = if _spiderTimeline_lock a == _spiderTimeline_lock b
788− then case unsafeCoerce Refl :: a :~: b of
789− Refl -> same -- This unsafeCoerce is safe because the same SpiderTimelineEnv can't have two different 'x' arguments
790− else different
791−#else
792− a `geq` b = if _spiderTimeline_lock a == _spiderTimeline_lock b
825+ a `geq` b = if _spiderTimeline_lock (unSTE a) == _spiderTimeline_lock (unSTE b)
793826 then Just $ unsafeCoerce Refl -- This unsafeCoerce is safe because the same SpiderTimelineEnv can't have two different 'x' arguments
794827 else Nothing
795−#endif
796828
797829data EventEnv x
798830 = EventEnv { eventEnvAssignments :: !(IORef [SomeAssignment x]) -- Needed for Subscribe
@@ -800,9 +832,9 @@ data EventEnv x
800832 , eventEnvDynInits :: !(IORef [SomeDynInit x])
801833 , eventEnvMergeUpdates :: !(IORef [SomeMergeUpdate x])
802834 , eventEnvMergeInits :: !(IORef [SomeMergeInit x]) -- Needed for Subscribe
803− , eventEnvClears :: !(IORef [SomeClear]) -- Needed for Subscribe
804− , eventEnvIntClears :: !(IORef [SomeIntClear])
805− , eventEnvRootClears :: !(IORef [SomeRootClear])
835+ , eventEnvClears :: !(IORef [Some Clear]) -- Needed for Subscribe
836+ , eventEnvIntClears :: !(IORef [Some IntClear])
837+ , eventEnvRootClears :: !(IORef [Some RootClear])
806838 , eventEnvCurrentHeight :: !(IORef Height) -- Needed for Subscribe
807839 , eventEnvResetCoincidences :: !(IORef [SomeResetCoincidence x]) -- Needed for Subscribe
808840 , eventEnvDelayedMerges :: !(IORef (IntMap [EventM x ()]))
@@ -813,7 +845,7 @@ runEventM :: EventM x a -> IO a
813845runEventM = unEventM
814846
815847asksEventEnv :: forall x a. HasSpiderTimeline x => (EventEnv x -> a) -> EventM x a
816−asksEventEnv f = return $ f $ _spiderTimeline_eventEnv (spiderTimeline :: SpiderTimelineEnv x)
848+asksEventEnv f = return $ f $ _spiderTimeline_eventEnv (unSTE (spiderTimeline :: SpiderTimelineEnv x))
817849
818850class MonadIO m => Defer a m where
819851 getDeferralQueue :: m (IORef [a])
@@ -862,11 +894,7 @@ instance HasSpiderTimeline x => HasCurrentHeight x (EventM x) where
862894 delayedRef <- asksEventEnv eventEnvDelayedMerges
863895 liftIO $ modifyIORef' delayedRef $ IntMap.insertWith (++) (unHeight height) [subscribed]
864896
865−#ifdef SPECIALIZE_TO_SPIDERTIMELINE_GLOBAL
866−class x ~ Global => HasSpiderTimeline x where
867−#else
868897class HasSpiderTimeline x where
869−#endif
870898 -- | Retrieve the current SpiderTimelineEnv
871899 spiderTimeline :: SpiderTimelineEnv x
872900
@@ -878,29 +906,29 @@ putCurrentHeight h = do
878906 heightRef <- asksEventEnv eventEnvCurrentHeight
879907 liftIO $ writeIORef heightRef $! h
880908
881−instance HasSpiderTimeline x => Defer SomeClear (EventM x) where
909+instance HasSpiderTimeline x => Defer (Some Clear) (EventM x) where
882910 {-# INLINE getDeferralQueue #-}
883911 getDeferralQueue = asksEventEnv eventEnvClears
884912
885913{-# INLINE scheduleClear #-}
886−scheduleClear :: Defer SomeClear m => IORef (Maybe a) -> m ()
887−scheduleClear r = defer $ SomeClear r
914+scheduleClear :: Defer (Some Clear) m => IORef (Maybe a) -> m ()
915+scheduleClear r = defer $ Some $ Clear r
888916
889−instance HasSpiderTimeline x => Defer SomeIntClear (EventM x) where
917+instance HasSpiderTimeline x => Defer (Some IntClear) (EventM x) where
890918 {-# INLINE getDeferralQueue #-}
891919 getDeferralQueue = asksEventEnv eventEnvIntClears
892920
893921{-# INLINE scheduleIntClear #-}
894−scheduleIntClear :: Defer SomeIntClear m => IORef (IntMap a) -> m ()
895−scheduleIntClear r = defer $ SomeIntClear r
922+scheduleIntClear :: Defer (Some IntClear) m => IORef (IntMap a) -> m ()
923+scheduleIntClear r = defer $ Some $ IntClear r
896924
897−instance HasSpiderTimeline x => Defer SomeRootClear (EventM x) where
925+instance HasSpiderTimeline x => Defer (Some RootClear) (EventM x) where
898926 {-# INLINE getDeferralQueue #-}
899927 getDeferralQueue = asksEventEnv eventEnvRootClears
900928
901929{-# INLINE scheduleRootClear #-}
902−scheduleRootClear :: Defer SomeRootClear m => IORef (DMap k Identity) -> m ()
903−scheduleRootClear r = defer $ SomeRootClear r
930+scheduleRootClear :: Defer (Some RootClear) m => IORef (DMap k Identity) -> m ()
931+scheduleRootClear r = defer $ Some $ RootClear r
904932
905933instance HasSpiderTimeline x => Defer (SomeResetCoincidence x) (EventM x) where
906934 {-# INLINE getDeferralQueue #-}
@@ -955,9 +983,9 @@ getHoldEventSubscription h = do
955983
956984type BehaviorEnv x = (Maybe (Weak (Invalidator x), IORef [SomeBehaviorSubscribed x]), IORef [SomeHoldInit x])
957985
958−--type role BehaviorM representational
959986-- BehaviorM can sample behaviors
960−newtype BehaviorM x a = BehaviorM { unBehaviorM :: ReaderT (BehaviorEnv x) IO a } deriving (Functor, Applicative, MonadIO, MonadFix)
987+newtype BehaviorM x a = BehaviorM { unBehaviorM :: ReaderIO (BehaviorEnv x) a }
988+ deriving (Functor, Applicative, MonadIO, MonadFix, MonadReader (BehaviorEnv x))
961989
962990instance Monad (BehaviorM x) where
963991 {-# INLINE (>>=) #-}
@@ -966,14 +994,16 @@ instance Monad (BehaviorM x) where
966994 BehaviorM x >> BehaviorM y = BehaviorM $ x >> y
967995 {-# INLINE return #-}
968996 return x = BehaviorM $ return x
997+#if !MIN_VERSION_base(4,13,0)
969998 {-# INLINE fail #-}
970999 fail s = BehaviorM $ fail s
1000+#endif
9711001
9721002data BehaviorSubscribed x a
9731003 = forall p. BehaviorSubscribedHold (Hold x p)
9741004 | BehaviorSubscribedPull (PullSubscribed x a)
9751005
976−data SomeBehaviorSubscribed x = forall a. SomeBehaviorSubscribed (BehaviorSubscribed x a)
1006+newtype SomeBehaviorSubscribed x = SomeBehaviorSubscribed (Some (BehaviorSubscribed x))
9771007
9781008--type role PullSubscribed representational
9791009data PullSubscribed x a
@@ -1008,7 +1038,7 @@ data RootSubscribed x a = forall k. GCompare k => RootSubscribed
10081038#endif
10091039 }
10101040
1011−data Root x (k :: * -> *)
1041+data Root x k
10121042 = Root { rootOccurrence :: !(IORef (DMap k Identity)) -- The currently-firing occurrence of this event
10131043 , rootSubscribed :: !(IORef (DMap k (RootSubscribed x)))
10141044 , rootInit :: !(forall a. k a -> RootTrigger x a -> IO (IO ()))
@@ -1027,7 +1057,7 @@ data SomeMergeUpdate x = SomeMergeUpdate
10271057newtype SomeMergeInit x = SomeMergeInit { unSomeMergeInit :: EventM x () }
10281058
10291059-- EventM can do everything BehaviorM can, plus create holds
1030−newtype EventM x a = EventM { unEventM :: IO a } deriving (Functor, Applicative, Monad, MonadIO, MonadFix, MonadException, MonadAsyncException) -- The environment should be Nothing if we are not in a frame, and Just if we are - in which case it is a list of assignments to be done after the frame is over
1060+newtype EventM x a = EventM { unEventM :: IO a } deriving (Functor, Applicative, Monad, MonadIO, MonadFix, MonadException, MonadAsyncException)
10311061
10321062newtype MergeSubscribedParent x a = MergeSubscribedParent { unMergeSubscribedParent :: EventSubscription x }
10331063
@@ -1052,7 +1082,8 @@ heightBagFromList :: [Height] -> HeightBag
10521082heightBagFromList heights = heightBagVerify $ foldl' (flip heightBagAdd) heightBagEmpty heights
10531083
10541084heightBagAdd :: Height -> HeightBag -> HeightBag
1055−heightBagAdd (Height h) (HeightBag s c) = heightBagVerify $ HeightBag (succ s) $ IntMap.insertWithKey (\_ _ old -> succ old) h 0 c
1085+heightBagAdd (Height h) (HeightBag s c) = heightBagVerify $ HeightBag (succ s) $
1086+ IntMap.insertWithKey (\_ _ old -> succ old) h 0 c
10561087
10571088heightBagRemove :: Height -> HeightBag -> HeightBag
10581089heightBagRemove (Height h) b@(HeightBag s c) = heightBagVerify $ case IntMap.lookup h c of
@@ -1061,6 +1092,13 @@ heightBagRemove (Height h) b@(HeightBag s c) = heightBagVerify $ case IntMap.loo
10611092 0 -> IntMap.delete h c
10621093 _ -> IntMap.insert h (pred old) c
10631094
1095+heightBagRemoveMaybe :: Height -> HeightBag -> Maybe HeightBag
1096+heightBagRemoveMaybe (Height h) b@(HeightBag s c) = heightBagVerify . removed <$> IntMap.lookup h c where
1097+ removed old = HeightBag (pred s) $ case old of
1098+ 0 -> IntMap.delete h c
1099+ _ -> IntMap.insert h (pred old) c
1100+
1101+
10641102heightBagMax :: HeightBag -> Height
10651103heightBagMax (HeightBag _ c) = case IntMap.maxViewWithKey c of
10661104 Just ((h, _), _) -> Height h
@@ -1078,25 +1116,25 @@ heightBagVerify b@(HeightBag s c) = if
10781116heightBagVerify = id
10791117#endif
10801118
1081−data FanSubscribedChildren (x :: *) k a = FanSubscribedChildren
1082− { _fanSubscribedChildren_list :: !(WeakBag (Subscriber x a))
1083− , _fanSubscribedChildren_self :: {-# NOUNPACK #-} !(k a, FanSubscribed x k)
1084− , _fanSubscribedChildren_weakSelf :: !(IORef (Weak (k a, FanSubscribed x k)))
1119+data FanSubscribedChildren x k v a = FanSubscribedChildren
1120+ { _fanSubscribedChildren_list :: !(WeakBag (Subscriber x (v a)))
1121+ , _fanSubscribedChildren_self :: {-# NOUNPACK #-} !(k a, FanSubscribed x k v)
1122+ , _fanSubscribedChildren_weakSelf :: !(IORef (Weak (k a, FanSubscribed x k v)))
10851123 }
10861124
1087−data FanSubscribed (x :: *) k
1088− = FanSubscribed { fanSubscribedCachedSubscribed :: !(IORef (Maybe (FanSubscribed x k)))
1089− , fanSubscribedOccurrence :: !(IORef (Maybe (DMap k Identity)))
1090− , fanSubscribedSubscribers :: !(IORef (DMap k (FanSubscribedChildren x k))) -- This DMap should never be empty
1125+data FanSubscribed x k v
1126+ = FanSubscribed { fanSubscribedCachedSubscribed :: !(IORef (Maybe (FanSubscribed x k v)))
1127+ , fanSubscribedOccurrence :: !(IORef (Maybe (DMap k v)))
1128+ , fanSubscribedSubscribers :: !(IORef (DMap k (FanSubscribedChildren x k v))) -- This DMap should never be empty
10911129 , fanSubscribedParent :: !(EventSubscription x)
10921130#ifdef DEBUG_NODEIDS
10931131 , fanSubscribedNodeId :: Int
10941132#endif
10951133 }
10961134
1097−data Fan x k
1098− = Fan { fanParent :: !(Event x (DMap k Identity))
1099− , fanSubscribed :: !(IORef (Maybe (FanSubscribed x k)))
1135+data Fan x k v
1136+ = Fan { fanParent :: !(Event x (DMap k v))
1137+ , fanSubscribed :: !(IORef (Maybe (FanSubscribed x k v)))
11001138 }
11011139
11021140data SwitchSubscribed x a
@@ -1150,20 +1188,35 @@ newInvalidatorSwitch subd = return $! InvalidatorSwitch subd
11501188newInvalidatorPull :: Pull x a -> IO (Invalidator x)
11511189newInvalidatorPull p = return $! InvalidatorPull p
11521190
1153−instance HasSpiderTimeline x => FunctorMaybe (Event x) where
1154− fmapMaybe f = push $ return . f
1191+instance HasSpiderTimeline x => Filterable (Event x) where
1192+ mapMaybe f = push $ return . f
11551193
11561194instance HasSpiderTimeline x => Align (Event x) where
11571195 nil = eventNever
1158− align ea eb = fmapMaybe dmapToThese $ merge $ dynamicConst $ DMap.fromDistinctAscList [LeftTag :=> ea, RightTag :=> eb]
1196+#if MIN_VERSION_these(0, 8, 0)
1197+instance HasSpiderTimeline x => Semialign (Event x) where
1198+#endif
1199+ align ea eb = mapMaybe dmapToThese $ mergeG coerce $ dynamicConst $
1200+ DMap.fromDistinctAscList [LeftTag :=> ea, RightTag :=> eb]
1201+
1202+#ifdef MIN_VERSION_semialign
1203+#if MIN_VERSION_semialign(1,1,0)
1204+instance HasSpiderTimeline x => Zip (Event x) where
1205+#endif
1206+ zip x y = mapMaybe justThese $ align x y
1207+#endif
1208+
1209+data DynType x p = UnsafeDyn !(BehaviorM x (PatchTarget p), Event x p)
1210+ | BuildDyn !(EventM x (PatchTarget p), Event x p)
1211+ | HoldDyn !(Hold x p)
11591212
1160−newtype Dyn x p = Dyn { unDyn :: IORef (Either (BehaviorM x (PatchTarget p), Event x p) (Hold x p)) }
1213+newtype Dyn (x :: Type) p = Dyn { unDyn :: IORef (DynType x p) }
11611214
1162−newMapDyn :: HasSpiderTimeline x => (a -> b) -> Dynamic x (Identity a) -> Dynamic x (Identity b)
1215+newMapDyn :: HasSpiderTimeline x => (a -> b) -> DynamicS x (Identity a) -> DynamicS x (Identity b)
11631216newMapDyn f d = dynamicDynIdentity $ unsafeBuildDynamic (fmap f $ readBehaviorTracked $ dynamicCurrent d) (Identity . f . runIdentity <$> dynamicUpdated d)
11641217
11651218--TODO: Avoid the duplication between this and R.zipDynWith
1166−zipDynWith :: HasSpiderTimeline x => (a -> b -> c) -> Dynamic x (Identity a) -> Dynamic x (Identity b) -> Dynamic x (Identity c)
1219+zipDynWith :: HasSpiderTimeline x => (a -> b -> c) -> DynamicS x (Identity a) -> DynamicS x (Identity b) -> DynamicS x (Identity c)
11671220zipDynWith f da db =
11681221 let eab = align (dynamicUpdated da) (dynamicUpdated db)
11691222 ec = flip push eab $ \o -> do
@@ -1178,26 +1231,20 @@ zipDynWith f da db =
11781231 return $ Just $ Identity $ f a b
11791232 in dynamicDynIdentity $ unsafeBuildDynamic (f <$> readBehaviorUntracked (dynamicCurrent da) <*> readBehaviorUntracked (dynamicCurrent db)) ec
11801233
1181−buildDynamic :: (Defer (SomeDynInit x) m, Patch p) => BehaviorM x (PatchTarget p) -> Event x p -> m (Dyn x p)
1234+buildDynamic :: (Defer (SomeDynInit x) m, Patch p) => EventM x (PatchTarget p) -> Event x p -> m (Dyn x p)
11821235buildDynamic readV0 v' = do
1183− result <- liftIO $ newIORef $ Left (readV0, v')
1236+ result <- liftIO $ newIORef $ BuildDyn (readV0, v')
11841237 let !d = Dyn result
11851238 defer $ SomeDynInit d
11861239 return d
11871240
11881241unsafeBuildDynamic :: BehaviorM x (PatchTarget p) -> Event x p -> Dyn x p
1189−unsafeBuildDynamic readV0 v' = Dyn $ unsafeNewIORef x $ Left x
1190− where x = (readV0, v')
1242+unsafeBuildDynamic readV0 v' =
1243+ Dyn $ unsafePerformIO $ newIORef $ UnsafeDyn (readV0, v')
11911244
11921245-- ResultM can read behaviors and events
11931246type ResultM = EventM
11941247
1195−{-# NOINLINE unsafeNewIORef #-}
1196−unsafeNewIORef :: a -> b -> IORef b
1197−unsafeNewIORef a b = unsafePerformIO $ do
1198− touch a
1199− newIORef b
1200−
12011248instance HasSpiderTimeline x => Functor (Event x) where
12021249 fmap f = push $ return . Just . f
12031250
@@ -1210,33 +1257,42 @@ push f e = cacheEvent (pushCheap f e)
12101257
12111258{-# INLINABLE pull #-}
12121259pull :: BehaviorM x a -> Behavior x a
1213−pull a = behaviorPull $ Pull
1214− { pullCompute = a
1215− , pullValue = unsafeNewIORef a Nothing
1260+pull a = unsafePerformIO $ do
1261+ ref <- newIORef Nothing
12161262#ifdef DEBUG_NODEIDS
1217− , pullNodeId = unsafeNodeId a
1263+ nid <- newNodeId
12181264#endif
1219− }
1265+ pure $ behaviorPull $ Pull
1266+ { pullCompute = a
1267+ , pullValue = ref
1268+#ifdef DEBUG_NODEIDS
1269+ , pullNodeId = nid
1270+#endif
1271+ }
12201272
12211273{-# INLINABLE switch #-}
12221274switch :: HasSpiderTimeline x => Behavior x (Event x a) -> Event x a
1223−switch a = eventSwitch $ Switch
1224− { switchParent = a
1225− , switchSubscribed = unsafeNewIORef a Nothing
1226− }
1275+switch a = unsafePerformIO $ do
1276+ ref <- newIORef Nothing
1277+ pure $ eventSwitch $ Switch
1278+ { switchParent = a
1279+ , switchSubscribed = ref
1280+ }
12271281
12281282coincidence :: HasSpiderTimeline x => Event x (Event x a) -> Event x a
1229−coincidence a = eventCoincidence $ Coincidence
1230− { coincidenceParent = a
1231− , coincidenceSubscribed = unsafeNewIORef a Nothing
1232− }
1283+coincidence a = unsafePerformIO $ do
1284+ ref <- newIORef Nothing
1285+ pure $ eventCoincidence $ Coincidence
1286+ { coincidenceParent = a
1287+ , coincidenceSubscribed = ref
1288+ }
12331289
12341290-- Propagate the given event occurrence; before cleaning up, run the given action, which may read the state of events and behaviors
12351291run :: forall x b. HasSpiderTimeline x => [DSum (RootTrigger x) Identity] -> ResultM x b -> SpiderHost x b
12361292run roots after = do
12371293 tracePropagate (Proxy :: Proxy x) $ "Running an event frame with " <> show (length roots) <> " events"
1238− t <- SpiderHost ask
1239− result <- SpiderHost $ lift $ withMVar (_spiderTimeline_lock t) $ \_ -> flip runReaderT t $ unSpiderHost $ runFrame $ do
1294+ let t = spiderTimeline :: SpiderTimelineEnv x
1295+ result <- SpiderHost $ withMVar (_spiderTimeline_lock (unSTE t)) $ \_ -> unSpiderHost $ runFrame $ do
12401296 rootsToPropagate <- forM roots $ \r@(RootTrigger (_, occRef, k) :=> a) -> do
12411297 occBefore <- liftIO $ do
12421298 occBefore <- readIORef occRef
@@ -1274,11 +1330,11 @@ scheduleMerge' initialHeight heightRef a = scheduleMerge initialHeight $ do
12741330 GT -> scheduleMerge' height heightRef a -- The height has been increased (by a coincidence event; TODO: is this the only way?)
12751331 EQ -> a
12761332
1277−data SomeClear = forall a. SomeClear {-# UNPACK #-} !(IORef (Maybe a))
1333+newtype Clear a = Clear (IORef (Maybe a))
12781334
1279−data SomeIntClear = forall a. SomeIntClear {-# UNPACK #-} !(IORef (IntMap a))
1335+newtype IntClear a = IntClear (IORef (IntMap a))
12801336
1281−data SomeRootClear = forall k. SomeRootClear {-# UNPACK #-} !(IORef (DMap k Identity))
1337+newtype RootClear k = RootClear (IORef (DMap k Identity))
12821338
12831339data SomeAssignment x = forall a. SomeAssignment {-# UNPACK #-} !(IORef a) {-# UNPACK #-} !(IORef [Weak (Invalidator x)]) a
12841340
@@ -1290,55 +1346,110 @@ mkWeakPtrWithDebug x debugNote = do
12901346 x' <- evaluate x
12911347 mkWeakPtr x' $
12921348 if debugFinalize
1293− then Just $ putStrLn $ "finalizing: " ++ debugNote
1349+ then Just $ debugStrLn $ "finalizing: " ++ debugNote
12941350 else Nothing
12951351
12961352type WeakList a = [Weak a]
12971353
1298−{-# INLINE withIncreasedDepth #-}
1354+type CanTrace x m = (HasSpiderTimeline x, MonadIO m)
1355+
1356+
1357+
1358+
12991359#ifdef DEBUG
1300−withIncreasedDepth :: CanTrace x m => m a -> m a
1301−withIncreasedDepth a = do
1302− spiderTimeline <- askSpiderTimelineEnv
1303− liftIO $ modifyIORef' (_spiderTimeline_depth spiderTimeline) succ
1360+
1361+debugSubscriber :: forall x a. HasSpiderTimeline x => String -> Subscriber x a -> IO (Subscriber x a)
1362+debugSubscriber description = return . debugSubscriber' description
1363+
1364+debugSubscriber' :: forall x a. HasSpiderTimeline x => String -> Subscriber x a -> Subscriber x a
1365+debugSubscriber' description subscribed = Subscriber
1366+ {
1367+ subscriberPropagate = \m -> do
1368+ tracePropagate (Proxy :: Proxy x) ("subscriberPropagate: " <> description)
1369+ subscriberPropagate subscribed m
1370+ , subscriberInvalidateHeight = \old -> do
1371+ traceInvalidateHeight $ "invalidateSubscriberHeight: " <> description <> ", old = " <> show (unHeight old)
1372+ subscriberInvalidateHeight subscribed old
1373+ traceInvalidateHeight $ "invalidateSubscriberHeight: " <> description <> ", done"
1374+ , subscriberRecalculateHeight = \new -> do
1375+ traceInvalidateHeight $ "subscriberRecalculateHeight: " <> description <> ", new = " <> show (unHeight new)
1376+ subscriberRecalculateHeight subscribed new
1377+ traceInvalidateHeight $ "subscriberRecalculateHeight: " <> description <> ", done"
1378+ }
1379+
1380+
1381+{-# INLINE withIncreasedDepth #-}
1382+withIncreasedDepth :: forall proxy x m a. CanTrace x m => proxy x -> m a -> m a
1383+withIncreasedDepth _ a = do
1384+ liftIO $ modifyIORef' (_spiderTimeline_depth $ unSTE (spiderTimeline :: SpiderTimelineEnv x)) succ
13041385 result <- a
1305− liftIO $ modifyIORef' (_spiderTimeline_depth spiderTimeline) pred
1386+ liftIO $ modifyIORef' (_spiderTimeline_depth $ unSTE (spiderTimeline :: SpiderTimelineEnv x)) pred
13061387 return result
1307−#else
1308−withIncreasedDepth :: m a -> m a
1309−withIncreasedDepth = id
1310−#endif
1311−
1312−type CanTrace x m = (HasSpiderTimeline x, MonadIO m)
13131388
13141389{-# INLINE tracePropagate #-}
13151390tracePropagate :: (CanTrace x m) => proxy x -> String -> m ()
1316−tracePropagate p = traceWhen p debugPropagate
1391+tracePropagate p = when debugPropagate . trace p
13171392
13181393{-# INLINE traceInvalidate #-}
13191394traceInvalidate :: String -> IO ()
1320−traceInvalidate = when debugInvalidate . liftIO . putStrLn
1395+traceInvalidate = when debugInvalidate . liftIO . debugStrLn
13211396
1322−{-# INLINE traceWhen #-}
1323−traceWhen :: (CanTrace x m) => proxy x -> Bool -> String -> m ()
1324−traceWhen p b message = traceMWhen p b $ return message
1397+{-# INLINE traceInvalidateHeight #-}
1398+traceInvalidateHeight :: String -> IO ()
1399+traceInvalidateHeight = when debugInvalidateHeight . liftIO . debugStrLn
13251400
1326−{-# INLINE traceMWhen #-}
1327−traceMWhen :: (CanTrace x m) => proxy x -> Bool -> m String -> m ()
1328−traceMWhen _ b getMessage = when b $ do
1401+{-# INLINE trace #-}
1402+trace :: (CanTrace x m) => proxy x -> String -> m ()
1403+trace p message = traceM p $ return message
1404+
1405+{-# INLINE traceM #-}
1406+traceM :: forall x proxy m. (CanTrace x m) => proxy x -> m String -> m ()
1407+traceM _ getMessage = do
13291408 message <- getMessage
1330−#ifdef DEBUG
1331− spiderTimeline <- askSpiderTimelineEnv
1332− d <- liftIO $ readIORef $ _spiderTimeline_depth spiderTimeline
1409+ d <- liftIO $ readIORef $ _spiderTimeline_depth $ unSTE (spiderTimeline :: SpiderTimelineEnv x)
1410+ liftIO $ debugStrLn $ replicate d ' ' <> message
1411+
13331412#else
1334− let d = 0
1413+
1414+{-# INLINE withIncreasedDepth #-}
1415+withIncreasedDepth :: proxy x -> m a -> m a
1416+withIncreasedDepth _ = id
1417+
1418+{-# INLINE tracePropagate #-}
1419+tracePropagate :: (CanTrace x m) => proxy x -> String -> m ()
1420+tracePropagate _ _ = return ()
1421+
1422+{-# INLINE traceInvalidate #-}
1423+traceInvalidate :: String -> IO ()
1424+traceInvalidate _ = return ()
1425+
1426+{-# INLINE traceInvalidateHeight #-}
1427+traceInvalidateHeight :: String -> IO ()
1428+traceInvalidateHeight _ = return ()
1429+
1430+{-# INLINE debugSubscriber #-}
1431+debugSubscriber :: String -> Subscriber x a -> IO (Subscriber x a)
1432+debugSubscriber _ = return
1433+
1434+{-# INLINE debugSubscriber' #-}
1435+debugSubscriber' :: String -> Subscriber x a -> Subscriber x a
1436+debugSubscriber' _ = id
1437+
1438+
1439+
1440+{-# INLINE trace #-}
1441+trace :: (CanTrace x m) => proxy x -> String -> m ()
1442+trace _ _ = return ()
1443+
1444+{-# INLINE traceM #-}
1445+traceM :: (CanTrace x m) => proxy x -> m String -> m ()
1446+traceM _ _ = return ()
1447+
13351448#endif
1336− liftIO $ putStrLn $ replicate d ' ' <> message
13371449
13381450whoCreatedIORef :: IORef a -> IO [String]
13391451whoCreatedIORef (IORef a) = whoCreated $! a
13401452
1341−#ifdef DEBUG_CYCLES
13421453groupByHead :: Eq a => [NonEmpty a] -> [(a, NonEmpty [a])]
13431454groupByHead = \case
13441455 [] -> []
@@ -1349,20 +1460,54 @@ groupByHead = \case
13491460 | otherwise -> (x, xs :| []) : l
13501461
13511462listsToForest :: Eq a => [[a]] -> Forest a
1352−listsToForest l = fmap (\(a, l') -> Node a $ listsToForest $ toList l') $ groupByHead $ catMaybes $ fmap nonEmpty l
1463+listsToForest lists = buildForest <$> groupByHead (mapMaybe nonEmpty lists)
1464+ where buildForest (a, lists') = Node a $ listsToForest $ toList lists'
1465+
1466+showStacks :: [[String]] -> String
1467+showStacks = drawForest . listsToForest . fmap (filterStack "Reflex.Spider.Internal")
1468+
1469+filterStack :: String -> [String] -> [String]
1470+#ifdef DEBUG_HIDE_INTERNALS
1471+filterStack prefix = filter (not . (prefix `isPrefixOf`))
1472+#else
1473+filterStack prefix = id
1474+#endif
1475+
1476+#ifdef DEBUG_CYCLES
1477+
1478+data EventLoopException = EventLoopException [[String]]
1479+instance Exception EventLoopException
1480+
1481+instance Show EventLoopException where
1482+ show (EventLoopException stacks) = "causality loop detected:\n" <> if null stacks
1483+ then "no location information, compile with profiling enabled for stack tree"
1484+ else showStacks stacks
1485+
1486+#else
1487+
1488+data EventLoopException = EventLoopException
1489+instance Exception EventLoopException
1490+
1491+instance Show EventLoopException where
1492+ show EventLoopException = "causality loop detected: \n" <>
1493+ "compile reflex with flag 'debug-cycles' and compile with profiling enabled for stack tree"
1494+
13531495#endif
13541496
1497+
13551498{-# INLINE propagateSubscriberHold #-}
13561499propagateSubscriberHold :: forall x p. (HasSpiderTimeline x, Patch p) => Hold x p -> p -> EventM x ()
13571500propagateSubscriberHold h a = do
1358− {-# SCC "trace" #-} traceMWhen (Proxy :: Proxy x) debugPropagate $ liftIO $ do
1501+ {-# SCC "trace" #-} when debugPropagate $ traceM (Proxy :: Proxy x) $ liftIO $ do
13591502 invalidators <- liftIO $ readIORef $ holdInvalidators h
13601503 return $ "SubscriberHold" <> showNodeId h <> ": " ++ show (length invalidators)
1504+
13611505 v <- {-# SCC "read" #-} liftIO $ readIORef $ holdValue h
13621506 case {-# SCC "apply" #-} apply a v of
13631507 Nothing -> return ()
13641508 Just v' -> do
1365− {-# SCC "trace2" #-} withIncreasedDepth $ tracePropagate (Proxy :: Proxy x) $ "propagateSubscriberHold: assigning Hold" <> showNodeId h
1509+ {-# SCC "trace2" #-} withIncreasedDepth (Proxy :: Proxy x) $
1510+ tracePropagate (Proxy :: Proxy x) ("propagateSubscriberHold: assigning Hold" <> showNodeId h)
13661511 vRef <- {-# SCC "vRef" #-} liftIO $ evaluate $ holdValue h
13671512 iRef <- {-# SCC "iRef" #-} liftIO $ evaluate $ holdInvalidators h
13681513 defer $ {-# SCC "assignment" #-} SomeAssignment vRef iRef v'
@@ -1370,25 +1515,25 @@ propagateSubscriberHold h a = do
13701515data SomeResetCoincidence x = forall a. SomeResetCoincidence !(EventSubscription x) !(Maybe (CoincidenceSubscribed x a)) -- The CoincidenceSubscriber will be present only if heights need to be reset
13711516
13721517runBehaviorM :: BehaviorM x a -> Maybe (Weak (Invalidator x), IORef [SomeBehaviorSubscribed x]) -> IORef [SomeHoldInit x] -> IO a
1373−runBehaviorM a mwi holdInits = runReaderT (unBehaviorM a) (mwi, holdInits)
1518+runBehaviorM a mwi holdInits = runReaderIO (unBehaviorM a) (mwi, holdInits)
13741519
13751520askInvalidator :: BehaviorM x (Maybe (Weak (Invalidator x)))
13761521askInvalidator = do
1377− (!m, _) <- BehaviorM ask
1522+ (!m, _) <- ask
13781523 case m of
13791524 Nothing -> return Nothing
13801525 Just (!wi, _) -> return $ Just wi
13811526
13821527askParentsRef :: BehaviorM x (Maybe (IORef [SomeBehaviorSubscribed x]))
13831528askParentsRef = do
1384− (!m, _) <- BehaviorM ask
1529+ (!m, _) <- ask
13851530 case m of
13861531 Nothing -> return Nothing
13871532 Just (_, !p) -> return $ Just p
13881533
13891534askBehaviorHoldInits :: BehaviorM x (IORef [SomeHoldInit x])
13901535askBehaviorHoldInits = do
1391− (_, !his) <- BehaviorM ask
1536+ (_, !his) <- ask
13921537 return his
13931538
13941539{-# INLINE getDynHold #-}
@@ -1396,20 +1541,27 @@ getDynHold :: (Defer (SomeHoldInit x) m, Patch p) => Dyn x p -> m (Hold x p)
13961541getDynHold d = do
13971542 mh <- liftIO $ readIORef $ unDyn d
13981543 case mh of
1399− Right h -> return h
1400− Left (readV0, v') -> do
1544+ HoldDyn h -> return h
1545+ UnsafeDyn (readV0, v') -> do
14011546 holdInits <- getDeferralQueue
14021547 v0 <- liftIO $ runBehaviorM readV0 Nothing holdInits
1548+ hold' v0 v'
1549+ BuildDyn (readV0, v') -> do
1550+ v0 <- liftIO $ runEventM readV0
1551+ hold' v0 v'
1552+ where
1553+ hold' v0 v' = do
14031554 h <- hold v0 v'
1404− liftIO $ writeIORef (unDyn d) $ Right h
1555+ liftIO $ writeIORef (unDyn d) $ HoldDyn h
14051556 return h
14061557
1558+
14071559-- Always refers to 0
14081560{-# NOINLINE zeroRef #-}
14091561zeroRef :: IORef Height
14101562zeroRef = unsafePerformIO $ newIORef zeroHeight
14111563
1412−getRootSubscribed :: GCompare k => k a -> Root x k -> Subscriber x a -> IO (WeakBagTicket, RootSubscribed x a, Maybe a)
1564+getRootSubscribed :: forall k x a. (GCompare k, HasSpiderTimeline x) => k a -> Root x k -> Subscriber x a -> IO (WeakBagTicket, RootSubscribed x a, Maybe a)
14131565getRootSubscribed k r sub = do
14141566 mSubscribed <- readIORef $ rootSubscribed r
14151567 let getOcc = fmap (coerce . DMap.lookup k) $ readIORef $ rootOccurrence r
@@ -1423,9 +1575,14 @@ getRootSubscribed k r sub = do
14231575 let !cached = rootSubscribed r
14241576 uninitRef <- newIORef $ error "getRootsubscribed: uninitRef not initialized"
14251577 (subs, sln) <- WeakBag.singleton sub weakSelf cleanupRootSubscribed
1426− when debugPropagate $ putStrLn $ "getRootSubscribed: calling rootInit"
1578+
1579+ tracePropagate (Proxy::Proxy x) $ "getRootSubscribed: calling rootInit"
1580+
14271581 uninit <- rootInit r k $ RootTrigger (subs, rootOccurrence r, k)
14281582 writeIORef uninitRef $! uninit
1583+#ifdef DEBUG_NODEIDS
1584+ nid <- newNodeId
1585+#endif
14291586 let !subscribed = RootSubscribed
14301587 { rootSubscribedKey = k
14311588 , rootSubscribedCachedSubscribed = cached
@@ -1434,7 +1591,7 @@ getRootSubscribed k r sub = do
14341591 , rootSubscribedUninit = uninit
14351592 , rootSubscribedWeakSelf = weakSelf
14361593#ifdef DEBUG_NODEIDS
1437− , rootSubscribedNodeId = unsafeNodeId (k, r, subs)
1594+ , rootSubscribedNodeId = nid
14381595#endif
14391596 }
14401597 -- If we die at the same moment that all our children die, they will
@@ -1470,6 +1627,9 @@ data FanInt x a = FanInt
14701627 { _fanInt_subscribers :: {-# UNPACK #-} !(FastMutableIntMap (FastWeakBag (Subscriber x a))) --TODO: Clean up the keys in here when their child weak bags get empty --TODO: Remove our own subscription when the subscribers list is completely empty
14711628 , _fanInt_subscriptionRef :: {-# UNPACK #-} !(IORef (EventSubscription x)) -- This should have a valid subscription iff subscribers is non-empty
14721629 , _fanInt_occRef :: {-# UNPACK #-} !(IORef (IntMap a))
1630+#ifdef DEBUG_NODEIDS
1631+ , _fanInt_nodeId :: {-# UNPACK #-} !Int
1632+#endif
14731633 }
14741634
14751635newFanInt :: IO (FanInt x a)
@@ -1477,38 +1637,39 @@ newFanInt = do
14771637 subscribers <- FastMutableIntMap.newEmpty --TODO: Clean up the keys in here when their child weak bags get empty --TODO: Remove our own subscription when the subscribers list is completely empty
14781638 subscriptionRef <- newIORef $ error "fanInt: no subscription"
14791639 occRef <- newIORef $ error "fanInt: no occurrence"
1640+#ifdef DEBUG_NODEIDS
1641+ nodeId <- newNodeId
1642+#endif
14801643 return $ FanInt
14811644 { _fanInt_subscribers = subscribers
14821645 , _fanInt_subscriptionRef = subscriptionRef
14831646 , _fanInt_occRef = occRef
1647+#ifdef DEBUG_NODEIDS
1648+ , _fanInt_nodeId = nodeId
1649+#endif
14841650 }
14851651
1486−{-# NOINLINE unsafeNewFanInt #-}
1487−unsafeNewFanInt :: b -> FanInt x a
1488−unsafeNewFanInt b = unsafePerformIO $ do
1489− touch b
1490− newFanInt
1491−
14921652fanInt :: HasSpiderTimeline x => Event x (IntMap a) -> EventSelectorInt x a
1493−fanInt p =
1494− let self = unsafeNewFanInt p
1495− in EventSelectorInt $ \k -> Event $ \sub -> do
1653+fanInt p = unsafePerformIO $ do
1654+ self <- newFanInt
1655+ pure $ EventSelectorInt $ \k -> Event $ \sub -> do
14961656 isEmpty <- liftIO $ FastMutableIntMap.isEmpty (_fanInt_subscribers self)
14971657 when isEmpty $ do -- This is the first subscriber, so we need to subscribe to our input
1498− (subscription, parentOcc) <- subscribeAndRead p $ Subscriber
1658+ let desc = "fanInt" <> showNodeId self <> ", k = " <> show k
1659+ (subscription, parentOcc) <- subscribeAndRead p $ debugSubscriber' desc $ Subscriber
14991660 { subscriberPropagate = \m -> do
15001661 liftIO $ writeIORef (_fanInt_occRef self) m
15011662 scheduleIntClear $ _fanInt_occRef self
1502− FastMutableIntMap.forIntersectionWithImmutable_ (_fanInt_subscribers self) m $ \b v -> do --TODO: Do we need to know that no subscribers are being added as we traverse?
1503− FastWeakBag.traverse b $ \s -> do
1663+ FastMutableIntMap.forIntersectionWithImmutable_ (_fanInt_subscribers self) m $ \b v -> --TODO: Do we need to know that no subscribers are being added as we traverse?
1664+ FastWeakBag.traverse_ b $ \s ->
15041665 subscriberPropagate s v
1505− , subscriberInvalidateHeight = \old -> do
1506− FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b -> do
1507− FastWeakBag.traverse b $ \s -> do
1666+ , subscriberInvalidateHeight = \old ->
1667+ FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b ->
1668+ FastWeakBag.traverse_ b $ \s ->
15081669 subscriberInvalidateHeight s old
1509− , subscriberRecalculateHeight = \new -> do
1510− FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b -> do
1511− FastWeakBag.traverse b $ \s -> do
1670+ , subscriberRecalculateHeight = \new ->
1671+ FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b ->
1672+ FastWeakBag.traverse_ b $ \s ->
15121673 subscriberRecalculateHeight s new
15131674 }
15141675 liftIO $ do
@@ -1522,13 +1683,28 @@ fanInt p =
15221683 FastMutableIntMap.insert (_fanInt_subscribers self) k b
15231684 return b
15241685 Just b -> return b
1525− t <- liftIO $ FastWeakBag.insert sub b
1686+ ticket <- liftIO $ FastWeakBag.insert sub b
15261687 currentOcc <- readIORef (_fanInt_occRef self)
1527− (EventSubscription _ (EventSubscribed !heightRef _)) <- readIORef (_fanInt_subscriptionRef self)
1528− return (EventSubscription (FastWeakBag.remove t) $! EventSubscribed heightRef $! toAny (_fanInt_subscriptionRef self, t), IntMap.lookup k currentOcc)
1688+
1689+ subscribed <- fanIntSubscribed ticket self
1690+ return (EventSubscription (FastWeakBag.remove ticket) subscribed, IntMap.lookup k currentOcc)
1691+
1692+fanIntSubscribed :: FastWeakBagTicket k -> FanInt x a -> IO (EventSubscribed x)
1693+fanIntSubscribed ticket self = do
1694+ subscribedParent <- _eventSubscription_subscribed <$> readIORef (_fanInt_subscriptionRef self)
1695+ return $ EventSubscribed
1696+ { eventSubscribedHeightRef = eventSubscribedHeightRef subscribedParent
1697+ , eventSubscribedRetained = toAny (_fanInt_subscriptionRef self, ticket)
1698+#ifdef DEBUG_CYCLES
1699+ , eventSubscribedGetParents = return [subscribedParent]
1700+ , eventSubscribedHasOwnHeightRef = False
1701+ , eventSubscribedWhoCreated = whoCreatedIORef $ _fanInt_subscriptionRef self
1702+#endif
1703+ }
1704+
15291705
15301706{-# INLINABLE getFanSubscribed #-}
1531−getFanSubscribed :: (HasSpiderTimeline x, GCompare k) => k a -> Fan x k -> Subscriber x a -> EventM x (WeakBagTicket, FanSubscribed x k, Maybe a)
1707+getFanSubscribed :: (HasSpiderTimeline x, GCompare k) => k a -> Fan x k v -> Subscriber x (v a) -> EventM x (WeakBagTicket, FanSubscribed x k v, Maybe (v a))
15321708getFanSubscribed k f sub = do
15331709 mSubscribed <- liftIO $ readIORef $ fanSubscribed f
15341710 case mSubscribed of
@@ -1546,13 +1722,16 @@ getFanSubscribed k f sub = do
15461722 subscribersRef <- liftIO $ newIORef $ error "getFanSubscribed: subscribersRef not yet initialized"
15471723 occRef <- liftIO $ newIORef parentOcc
15481724 when (isJust parentOcc) $ scheduleClear occRef
1725+#ifdef DEBUG_NODEIDS
1726+ nid <- liftIO newNodeId
1727+#endif
15491728 let subscribed = FanSubscribed
15501729 { fanSubscribedCachedSubscribed = fanSubscribed f
15511730 , fanSubscribedOccurrence = occRef
15521731 , fanSubscribedParent = subscription
15531732 , fanSubscribedSubscribers = subscribersRef
15541733#ifdef DEBUG_NODEIDS
1555− , fanSubscribedNodeId = unsafeNodeId f
1734+ , fanSubscribedNodeId = nid
15561735#endif
15571736 }
15581737 let !self = (k, subscribed)
@@ -1562,7 +1741,7 @@ getFanSubscribed k f sub = do
15621741 liftIO $ writeIORef (fanSubscribed f) $ Just subscribed
15631742 return (slnForSub, subscribed, coerce $ DMap.lookup k =<< parentOcc)
15641743
1565−cleanupFanSubscribed :: GCompare k => (k a, FanSubscribed x k) -> IO ()
1744+cleanupFanSubscribed :: GCompare k => (k a, FanSubscribed x k v) -> IO ()
15661745cleanupFanSubscribed (k, subscribed) = do
15671746 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
15681747 let reducedSubscribers = DMap.delete k subscribers
@@ -1574,7 +1753,7 @@ cleanupFanSubscribed (k, subscribed) = do
15741753 else writeIORef (fanSubscribedSubscribers subscribed) $! reducedSubscribers
15751754
15761755{-# INLINE subscribeFanSubscribed #-}
1577−subscribeFanSubscribed :: GCompare k => k a -> FanSubscribed x k -> Subscriber x a -> IO WeakBagTicket
1756+subscribeFanSubscribed :: GCompare k => k a -> FanSubscribed x k v -> Subscriber x (v a) -> IO WeakBagTicket
15781757subscribeFanSubscribed k subscribed sub = do
15791758 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
15801759 case DMap.lookup k subscribers of
@@ -1612,6 +1791,9 @@ getSwitchSubscribed s sub = do
16121791 when (isJust parentOcc) $ scheduleClear occRef
16131792 weakSelf <- liftIO $ newIORef $ error "getSwitchSubscribed: weakSelf not yet initialized"
16141793 (subs, slnForSub) <- liftIO $ WeakBag.singleton sub weakSelf cleanupSwitchSubscribed
1794+#ifdef DEBUG_NODEIDS
1795+ nid <- liftIO newNodeId
1796+#endif
16151797 let !subscribed = SwitchSubscribed
16161798 { switchSubscribedCachedSubscribed = switchSubscribed s
16171799 , switchSubscribedOccurrence = occRef
@@ -1624,7 +1806,7 @@ getSwitchSubscribed s sub = do
16241806 , switchSubscribedCurrentParent = subscriptionRef
16251807 , switchSubscribedWeakSelf = weakSelf
16261808#ifdef DEBUG_NODEIDS
1627− , switchSubscribedNodeId = unsafeNodeId s
1809+ , switchSubscribedNodeId = nid
16281810#endif
16291811 }
16301812 liftIO $ writeIORef weakSelf =<< evaluate =<< mkWeakPtrWithDebug subscribed "switchSubscribedWeakSelf"
@@ -1669,6 +1851,9 @@ getCoincidenceSubscribed c sub = do
16691851 scheduleClear innerSubdRef
16701852 weakSelf <- liftIO $ newIORef $ error "getCoincidenceSubscribed: weakSelf not yet implemented"
16711853 (subs, slnForSub) <- liftIO $ WeakBag.singleton sub weakSelf cleanupCoincidenceSubscribed
1854+#ifdef DEBUG_NODEIDS
1855+ nid <- liftIO newNodeId
1856+#endif
16721857 let subscribed = CoincidenceSubscribed
16731858 { coincidenceSubscribedCachedSubscribed = coincidenceSubscribed c
16741859 , coincidenceSubscribedOccurrence = occRef
@@ -1679,7 +1864,7 @@ getCoincidenceSubscribed c sub = do
16791864 , coincidenceSubscribedInnerParent = innerSubdRef
16801865 , coincidenceSubscribedWeakSelf = weakSelf
16811866#ifdef DEBUG_NODEIDS
1682− , coincidenceSubscribedNodeId = unsafeNodeId c
1867+ , coincidenceSubscribedNodeId = nid
16831868#endif
16841869 }
16851870 liftIO $ writeIORef weakSelf =<< evaluate =<< mkWeakPtrWithDebug subscribed "CoincidenceSubscribed"
@@ -1696,57 +1881,72 @@ cleanupCoincidenceSubscribed subscribed = do
16961881subscribeCoincidenceSubscribed :: CoincidenceSubscribed x a -> Subscriber x a -> IO WeakBagTicket
16971882subscribeCoincidenceSubscribed subscribed sub = WeakBag.insert sub (coincidenceSubscribedSubscribers subscribed) (coincidenceSubscribedWeakSelf subscribed) cleanupCoincidenceSubscribed
16981883
1699−{-# INLINE merge #-}
1700−merge :: forall k x. (HasSpiderTimeline x, GCompare k) => Dynamic x (PatchDMap k (Event x)) -> Event x (DMap k Identity)
1701−merge d = cacheEvent (mergeCheap d)
1884+{-# INLINE mergeG #-}
1885+mergeG :: forall k q x v. (HasSpiderTimeline x, GCompare k)
1886+ => (forall a. q a -> Event x (v a))
1887+ -> DynamicS x (PatchDMap k q) -> Event x (DMap k v)
1888+mergeG nt d = cacheEvent (mergeCheap nt d)
17021889
17031890{-# INLINE mergeWithMove #-}
1704−mergeWithMove :: forall k x. (HasSpiderTimeline x, GCompare k) => Dynamic x (PatchDMapWithMove k (Event x)) -> Event x (DMap k Identity)
1705−mergeWithMove d = cacheEvent (mergeCheapWithMove d)
1891+mergeWithMove :: forall k v q x. (HasSpiderTimeline x, GCompare k)
1892+ => (forall a. q a -> Event x (v a))
1893+ -> DynamicS x (PatchDMapWithMove k q) -> Event x (DMap k v)
1894+mergeWithMove nt d = cacheEvent (mergeCheapWithMove nt d)
17061895
17071896{-# INLINE [1] mergeCheap #-}
1708−mergeCheap :: forall k x. (HasSpiderTimeline x, GCompare k) => Dynamic x (PatchDMap k (Event x)) -> Event x (DMap k Identity)
1709−mergeCheap = mergeCheap' getInitialSubscribers updateMe destroy
1897+mergeCheap
1898+ :: forall k x q v. (HasSpiderTimeline x, GCompare k)
1899+ => (forall a. q a -> Event x (v a))
1900+ -> DynamicS x (PatchDMap k q)
1901+ -> Event x (DMap k v)
1902+mergeCheap nt = mergeGCheap' unMergeSubscribedParent getInitialSubscribers updateMe destroy
17101903 where
1711− updateMe :: MergeUpdateFunc k x (PatchDMap k (Event x)) (MergeSubscribedParent x)
1904+ updateMe :: MergeUpdateFunc k v x (PatchDMap k q) (MergeSubscribedParent x)
17121905 updateMe subscriber heightBagRef oldParents (PatchDMap p) = do
17131906 let f (subscriptionsToKill, ps) (k :=> ComposeMaybe me) = do
17141907 (mOldSubd, newPs) <- case me of
17151908 Nothing -> return $ DMap.updateLookupWithKey (\_ _ -> Nothing) k ps
17161909 Just e -> do
17171910 let s = subscriber $ return k
1718− subscription@(EventSubscription _ subd) <- subscribe e s
1911+ subscription@(EventSubscription _ subd) <- subscribe (nt e) s
17191912 newParentHeight <- liftIO $ getEventSubscribedHeight subd
17201913 let newParent = MergeSubscribedParent subscription
17211914 liftIO $ modifyIORef' heightBagRef $ heightBagAdd newParentHeight
17221915 return $ DMap.insertLookupWithKey' (\_ new _ -> new) k newParent ps
17231916 forM_ mOldSubd $ \oldSubd -> do
1724− oldHeight <- liftIO $ getEventSubscribedHeight $ _eventSubscription_subscribed $ unMergeSubscribedParent oldSubd
1917+ oldHeight <- liftIO $ getEventSubscribedHeight $
1918+ _eventSubscription_subscribed $ unMergeSubscribedParent oldSubd
1919+
17251920 liftIO $ modifyIORef heightBagRef $ heightBagRemove oldHeight
17261921 return (maybeToList (unMergeSubscribedParent <$> mOldSubd) ++ subscriptionsToKill, newPs)
17271922 foldM f ([], oldParents) $ DMap.toList p
1728− getInitialSubscribers :: MergeInitFunc k x (MergeSubscribedParent x)
1923+
1924+ getInitialSubscribers :: MergeInitFunc k v q x (MergeSubscribedParent x)
17291925 getInitialSubscribers initialParents subscriber = do
17301926 subscribers <- forM (DMap.toList initialParents) $ \(k :=> e) -> do
17311927 let s = subscriber $ return k
1732− (subscription@(EventSubscription _ parentSubd), parentOcc) <- subscribeAndRead e s
1928+ (subscription@(EventSubscription _ parentSubd), parentOcc) <- subscribeAndRead (nt e) s
17331929 height <- liftIO $ getEventSubscribedHeight parentSubd
1734− return (fmap (\x -> k :=> Identity x) parentOcc, height, k :=> MergeSubscribedParent subscription)
1930+ return (fmap (k :=>) parentOcc, height, k :=> MergeSubscribedParent subscription)
17351931 return ( DMap.fromDistinctAscList $ mapMaybe (\(x, _, _) -> x) subscribers
17361932 , fmap (\(_, h, _) -> h) subscribers --TODO: Assert that there's no invalidHeight in here
17371933 , DMap.fromDistinctAscList $ map (\(_, _, x) -> x) subscribers
17381934 )
1935+
17391936 destroy :: MergeDestroyFunc k (MergeSubscribedParent x)
17401937 destroy s = forM_ (DMap.toList s) $ \(_ :=> MergeSubscribedParent sub) -> unsubscribe sub
17411938
17421939{-# INLINE [1] mergeCheapWithMove #-}
1743−mergeCheapWithMove :: forall k x. (HasSpiderTimeline x, GCompare k) => Dynamic x (PatchDMapWithMove k (Event x)) -> Event x (DMap k Identity)
1744−mergeCheapWithMove = mergeCheap' getInitialSubscribers updateMe destroy
1940+mergeCheapWithMove :: forall k x v q. (HasSpiderTimeline x, GCompare k)
1941+ => (forall a. q a -> Event x (v a))
1942+ -> DynamicS x (PatchDMapWithMove k q)
1943+ -> Event x (DMap k v)
1944+mergeCheapWithMove nt = mergeGCheap' _mergeSubscribedParentWithMove_subscription getInitialSubscribers updateMe destroy
17451945 where
1746− updateMe :: MergeUpdateFunc k x (PatchDMapWithMove k (Event x)) (MergeSubscribedParentWithMove x k)
1946+ updateMe :: MergeUpdateFunc k v x (PatchDMapWithMove k q) (MergeSubscribedParentWithMove x k)
17471947 updateMe subscriber heightBagRef oldParents p = do
17481948 -- Prepare new parents for insertion
1749− let subscribeParent :: forall a. k a -> Event x a -> EventM x (MergeSubscribedParentWithMove x k a)
1949+ let subscribeParent :: forall a. k a -> Event x (v a) -> EventM x (MergeSubscribedParentWithMove x k a)
17501950 subscribeParent k e = do
17511951 keyRef <- liftIO $ newIORef k
17521952 let s = subscriber $ liftIO $ readIORef keyRef
@@ -1755,73 +1955,82 @@ mergeCheapWithMove = mergeCheap' getInitialSubscribers updateMe destroy
17551955 newParentHeight <- getEventSubscribedHeight subd
17561956 modifyIORef' heightBagRef $ heightBagAdd newParentHeight
17571957 return $ MergeSubscribedParentWithMove subscription keyRef
1758− p' <- PatchDMapWithMove.traversePatchDMapWithMoveWithKey subscribeParent p
1958+ p' <- PatchDMapWithMove.traversePatchDMapWithMoveWithKey (\k q -> subscribeParent k (nt q)) p
17591959 -- Collect old parents for deletion and update the keys of moved parents
1760− let moveOrDelete :: forall a. k a -> PatchDMapWithMove.NodeInfo k (Event x) a -> MergeSubscribedParentWithMove x k a -> Constant (EventM x (Maybe (EventSubscription x))) a
1960+ let moveOrDelete :: forall a. k a -> PatchDMapWithMove.NodeInfo k q a -> MergeSubscribedParentWithMove x k a -> Constant (EventM x (Maybe (EventSubscription x))) a
17611961 moveOrDelete _ ni parent = Constant $ case getComposeMaybe $ PatchDMapWithMove._nodeInfo_to ni of
17621962 Nothing -> do
1763− oldHeight <- liftIO $ getEventSubscribedHeight $ _eventSubscription_subscribed $ _mergeSubscribedParentWithMove_subscription parent
1963+ oldHeight <- liftIO $ getEventSubscribedHeight $ _eventSubscription_subscribed $
1964+ _mergeSubscribedParentWithMove_subscription parent
1965+
17641966 liftIO $ modifyIORef heightBagRef $ heightBagRemove oldHeight
17651967 return $ Just $ _mergeSubscribedParentWithMove_subscription parent
17661968 Just toKey -> do
17671969 liftIO $ writeIORef (_mergeSubscribedParentWithMove_key parent) $! toKey
17681970 return Nothing
1769− toDelete <- fmap catMaybes $ mapM (\(_ :=> v) -> getConstant v) $ DMap.toList $ DMap.intersectionWithKey moveOrDelete (unPatchDMapWithMove p) oldParents
1971+ toDelete <- fmap catMaybes $ mapM (\(_ :=> v) -> getConstant v) $ DMap.toList $
1972+ DMap.intersectionWithKey moveOrDelete (unPatchDMapWithMove p) oldParents
1973+
17701974 return (toDelete, applyAlways p' oldParents)
1771− getInitialSubscribers :: MergeInitFunc k x (MergeSubscribedParentWithMove x k)
1975+ getInitialSubscribers :: MergeInitFunc k v q x (MergeSubscribedParentWithMove x k)
17721976 getInitialSubscribers initialParents subscriber = do
17731977 subscribers <- forM (DMap.toList initialParents) $ \(k :=> e) -> do
17741978 keyRef <- liftIO $ newIORef k
17751979 let s = subscriber $ liftIO $ readIORef keyRef
1776− (subscription@(EventSubscription _ parentSubd), parentOcc) <- subscribeAndRead e s
1980+ (subscription@(EventSubscription _ parentSubd), parentOcc) <- subscribeAndRead (nt e) s
17771981 height <- liftIO $ getEventSubscribedHeight parentSubd
1778− return (fmap (\x -> k :=> Identity x) parentOcc, height, k :=> MergeSubscribedParentWithMove subscription keyRef)
1982+ return (fmap (k :=>) parentOcc, height, k :=> MergeSubscribedParentWithMove subscription keyRef)
17791983 return ( DMap.fromDistinctAscList $ mapMaybe (\(x, _, _) -> x) subscribers
17801984 , fmap (\(_, h, _) -> h) subscribers --TODO: Assert that there's no invalidHeight in here
17811985 , DMap.fromDistinctAscList $ map (\(_, _, x) -> x) subscribers
17821986 )
1987+
17831988 destroy :: MergeDestroyFunc k (MergeSubscribedParentWithMove x k)
17841989 destroy s = forM_ (DMap.toList s) $ \(_ :=> MergeSubscribedParentWithMove sub _) -> unsubscribe sub
17851990
1786−type MergeUpdateFunc k x p s
1787− = (forall a. EventM x (k a) -> Subscriber x a)
1991+type MergeUpdateFunc k v x p s
1992+ = (forall a. EventM x (k a) -> Subscriber x (v a))
17881993 -> IORef HeightBag
17891994 -> DMap k s
17901995 -> p
17911996 -> EventM x ([EventSubscription x], DMap k s)
17921997
1793−type MergeInitFunc k x s
1794− = DMap k (Event x)
1795− -> (forall a. EventM x (k a) -> Subscriber x a)
1796− -> EventM x (DMap k Identity, [Height], DMap k s)
1998+type MergeGetSubscription x s = forall a. s a -> EventSubscription x
1999+
2000+type MergeInitFunc k v q x s
2001+ = DMap k q
2002+ -> (forall a. EventM x (k a) -> Subscriber x (v a))
2003+ -> EventM x (DMap k v, [Height], DMap k s)
17972004
17982005type MergeDestroyFunc k s
17992006 = DMap k s
18002007 -> IO ()
18012008
1802−data Merge x k s = Merge
2009+data Merge x k v s = Merge
18032010 { _merge_parentsRef :: {-# UNPACK #-} !(IORef (DMap k s))
18042011 , _merge_heightBagRef :: {-# UNPACK #-} !(IORef HeightBag)
18052012 , _merge_heightRef :: {-# UNPACK #-} !(IORef Height)
1806− , _merge_sub :: {-# UNPACK #-} !(Subscriber x (DMap k Identity))
1807− , _merge_accumRef :: {-# UNPACK #-} !(IORef (DMap k Identity))
2013+ , _merge_sub :: {-# UNPACK #-} !(Subscriber x (DMap k v))
2014+ , _merge_accumRef :: {-# UNPACK #-} !(IORef (DMap k v))
18082015 }
18092016
1810−invalidateMergeHeight :: Merge x k s -> IO ()
2017+invalidateMergeHeight :: Merge x k v s -> IO ()
18112018invalidateMergeHeight m = invalidateMergeHeight' (_merge_heightRef m) (_merge_sub m)
18122019
18132020invalidateMergeHeight' :: IORef Height -> Subscriber x a -> IO ()
18142021invalidateMergeHeight' heightRef sub = do
18152022 oldHeight <- readIORef heightRef
1816− when (oldHeight /= invalidHeight) $ do -- If the height used to be valid, it must be invalid now; we should never have *more* heights than we have parents
2023+ -- If the height used to be valid, it must be invalid now; we should never have *more* heights than we have parents
2024+ when (oldHeight /= invalidHeight) $ do
18172025 writeIORef heightRef $! invalidHeight
18182026 subscriberInvalidateHeight sub oldHeight
18192027
1820−
1821−revalidateMergeHeight :: Merge x k s -> IO ()
2028+revalidateMergeHeight :: Merge x k v s -> IO ()
18222029revalidateMergeHeight m = do
18232030 currentHeight <- readIORef $ _merge_heightRef m
1824− when (currentHeight == invalidHeight) $ do -- revalidateMergeHeight may be called multiple times; perhaps the's a way to finesse it to avoid this check
2031+
2032+ -- revalidateMergeHeight may be called multiple times; perhaps the's a way to finesse it to avoid this check
2033+ when (currentHeight == invalidHeight) $ do
18252034 heights <- readIORef $ _merge_heightBagRef m
18262035 parents <- readIORef $ _merge_parentsRef m
18272036 -- When the number of heights in the bag reaches the number of parents, we should have a valid height
@@ -1829,44 +2038,53 @@ revalidateMergeHeight m = do
18292038 LT -> return ()
18302039 EQ -> do
18312040 let height = succHeight $ heightBagMax heights
1832− when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: height: " <> show height
2041+ traceInvalidateHeight $ "recalculateSubscriberHeight: height: " <> show height
18332042 writeIORef (_merge_heightRef m) $! height
18342043 subscriberRecalculateHeight (_merge_sub m) height
18352044 GT -> error $ "revalidateMergeHeight: more heights (" <> show (heightBagSize heights) <> ") than parents (" <> show (DMap.size parents) <> ") for Merge"
18362045
1837−scheduleMergeSelf :: HasSpiderTimeline x => Merge x k s -> Height -> EventM x ()
2046+scheduleMergeSelf :: HasSpiderTimeline x => Merge x k v s -> Height -> EventM x ()
18382047scheduleMergeSelf m height = scheduleMerge' height (_merge_heightRef m) $ do
18392048 vals <- liftIO $ readIORef $ _merge_accumRef m
1840− liftIO $ writeIORef (_merge_accumRef m) $! DMap.empty -- Once we're done with this, we can clear it immediately, because if there's a cacheEvent in front of us, it'll handle subsequent subscribers, and if not, we won't get subsequent subscribers
2049+ -- Once we're done with this, we can clear it immediately, because if there's a cacheEvent in front of us,
2050+ -- it'll handle subsequent subscribers, and if not, we won't get subsequent subscribers
2051+ liftIO $ writeIORef (_merge_accumRef m) $! DMap.empty
18412052 --TODO: Assert that m is not empty
18422053 subscriberPropagate (_merge_sub m) vals
18432054
1844−mergeSubscriber :: forall x k s a. (HasSpiderTimeline x, GCompare k) => Merge x k s -> EventM x (k a) -> Subscriber x a
1845−mergeSubscriber m getKey = Subscriber
2055+checkCycle :: HasSpiderTimeline x => EventSubscribed x -> EventM x ()
2056+checkCycle subscribed = liftIO $ do
2057+ height <- readIORef (eventSubscribedHeightRef subscribed)
2058+
2059+ -- currentHeight <- getCurrentHeight
2060+ -- when (height <= currentHeight) $ if height /= invalidHeight
2061+ -- then do
2062+ -- myStack <- liftIO $ whoCreatedIORef undefined --TODO
2063+ -- error $ "Height (" ++ show height ++ ") is not greater than current height (" ++ show currentHeight ++ ")\n" ++ unlines (reverse myStack)
2064+ -- else liftIO $
2065+ when (height == invalidHeight) $
2066+#ifdef DEBUG_CYCLES
2067+ do
2068+ nodesInvolvedInCycle <- walkInvalidHeightParents subscribed
2069+ stacks <- forM nodesInvolvedInCycle whoCreatedEventSubscribed
2070+ throwIO (EventLoopException stacks)
2071+#else
2072+ throwIO EventLoopException
2073+#endif
2074+
2075+
2076+mergeSubscriber :: forall x k v s a. (HasSpiderTimeline x, GCompare k) => EventSubscribed x -> Merge x k v s -> EventM x (k a) -> Subscriber x (v a)
2077+mergeSubscriber subscribed m getKey = Subscriber
18462078 { subscriberPropagate = \a -> do
18472079 oldM <- liftIO $ readIORef $ _merge_accumRef m
18482080 k <- getKey
1849− let newM = DMap.insertWith (error $ "Same key fired multiple times for Merge") k (Identity a) oldM
2081+ let newM = DMap.insertWith (error "Same key fired multiple times for Merge") k a oldM
18502082 tracePropagate (Proxy :: Proxy x) $ " DMap.size oldM = " <> show (DMap.size oldM) <> "; DMap.size newM = " <> show (DMap.size newM)
18512083 liftIO $ writeIORef (_merge_accumRef m) $! newM
18522084 when (DMap.null oldM) $ do -- Only schedule the firing once
18532085 height <- liftIO $ readIORef $ _merge_heightRef m
1854− --TODO: assertions about height
1855− currentHeight <- getCurrentHeight
1856− when (height <= currentHeight) $ do
1857− if height /= invalidHeight
1858− then do
1859− myStack <- liftIO $ whoCreatedIORef undefined --TODO
1860− error $ "Height (" ++ show height ++ ") is not greater than current height (" ++ show currentHeight ++ ")\n" ++ unlines (reverse myStack)
1861− else liftIO $ do
1862−#ifdef DEBUG_CYCLES
1863− nodesInvolvedInCycle <- walkInvalidHeightParents $ eventSubscribedMerge subscribed
1864− stacks <- forM nodesInvolvedInCycle $ \(Some.This es) -> whoCreatedEventSubscribed es
1865− let cycleInfo = ":\n" <> drawForest (listsToForest stacks)
1866−#else
1867− let cycleInfo = ""
1868−#endif
1869− error $ "Causality loop found" <> cycleInfo
2086+ checkCycle subscribed
2087+
18702088 scheduleMergeSelf m height
18712089 , subscriberInvalidateHeight = \old -> do --TODO: When removing a parent doesn't actually change the height, maybe we can avoid invalidating
18722090 modifyIORef' (_merge_heightBagRef m) $ heightBagRemove old
@@ -1877,30 +2095,45 @@ mergeSubscriber m getKey = Subscriber
18772095 }
18782096
18792097--TODO: Be able to run as much of this as possible promptly
1880−updateMerge :: (HasSpiderTimeline x, GCompare k) => Merge x k s -> MergeUpdateFunc k x p s -> p -> SomeMergeUpdate x
1881−updateMerge m updateFunc p = SomeMergeUpdate updateMe (invalidateMergeHeight m) (revalidateMergeHeight m)
2098+updateMerge :: (HasSpiderTimeline x, GCompare k) => EventSubscribed x -> Merge x k v s -> MergeUpdateFunc k v x p s -> p -> SomeMergeUpdate x
2099+updateMerge subscribed m updateFunc p = SomeMergeUpdate updateMe (invalidateMergeHeight m) (revalidateMergeHeight m)
18822100 where updateMe = do
18832101 oldParents <- liftIO $ readIORef $ _merge_parentsRef m
1884− (subscriptionsToKill, newParents) <- updateFunc (mergeSubscriber m) (_merge_heightBagRef m) oldParents p
2102+ (subscriptionsToKill, newParents) <- updateFunc (mergeSubscriber subscribed m) (_merge_heightBagRef m) oldParents p
18852103 liftIO $ writeIORef (_merge_parentsRef m) $! newParents
18862104 return subscriptionsToKill
18872105
1888−{-# INLINE mergeCheap' #-}
1889−mergeCheap' :: forall k x p s. (HasSpiderTimeline x, GCompare k, PatchTarget p ~ DMap k (Event x)) => MergeInitFunc k x s -> MergeUpdateFunc k x p s -> MergeDestroyFunc k s -> Dynamic x p -> Event x (DMap k Identity)
1890−mergeCheap' getInitialSubscribers updateFunc destroy d = Event $ \sub -> do
2106+{-# INLINE mergeGCheap' #-}
2107+mergeGCheap' :: forall k v x p s q. (HasSpiderTimeline x, GCompare k, PatchTarget p ~ DMap k q)
2108+ => MergeGetSubscription x s -> MergeInitFunc k v q x s -> MergeUpdateFunc k v x p s -> MergeDestroyFunc k s -> DynamicS x p -> Event x (DMap k v)
2109+mergeGCheap' getParent getInitialSubscribers updateFunc destroy d = Event $ \sub -> do
18912110 initialParents <- readBehaviorUntracked $ dynamicCurrent d
18922111 accumRef <- liftIO $ newIORef $ error "merge: accumRef not yet initialized"
18932112 heightRef <- liftIO $ newIORef $ error "merge: heightRef not yet initialized"
18942113 heightBagRef <- liftIO $ newIORef $ error "merge: heightBagRef not yet initialized"
18952114 parentsRef :: IORef (DMap k s) <- liftIO $ newIORef $ error "merge: parentsRef not yet initialized"
1896− let m = Merge
2115+ changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
2116+
2117+ let subscribed = EventSubscribed
2118+ { eventSubscribedHeightRef = heightRef
2119+ , eventSubscribedRetained = toAny (parentsRef, changeSubdRef)
2120+#ifdef DEBUG_CYCLES
2121+ , eventSubscribedGetParents = do
2122+ let getParent' (_ :=> v) = _eventSubscription_subscribed (getParent v)
2123+ fmap getParent' . DMap.toList <$> readIORef parentsRef
2124+ , eventSubscribedHasOwnHeightRef = False
2125+ , eventSubscribedWhoCreated = whoCreatedIORef heightRef
2126+#endif
2127+ }
2128+
2129+ m = Merge
18972130 { _merge_parentsRef = parentsRef
18982131 , _merge_heightBagRef = heightBagRef
18992132 , _merge_heightRef = heightRef
19002133 , _merge_sub = sub
19012134 , _merge_accumRef = accumRef
19022135 }
1903− (dm, heights, initialParentState) <- getInitialSubscribers initialParents $ mergeSubscriber m
2136+ (dm, heights, initialParentState) <- getInitialSubscribers initialParents $ mergeSubscriber subscribed m
19042137 let myHeightBag = heightBagFromList $ filter (/= invalidHeight) heights
19052138 myHeight = if invalidHeight `elem` heights
19062139 then invalidHeight
@@ -1909,50 +2142,57 @@ mergeCheap' getInitialSubscribers updateFunc destroy d = Event $ \sub -> do
19092142 let (occ, accum) = if currentHeight >= myHeight -- If we should have fired by now
19102143 then (if DMap.null dm then Nothing else Just dm, DMap.empty)
19112144 else (Nothing, dm)
1912− unless (DMap.null accum) $ do
1913− scheduleMergeSelf m myHeight
2145+ unless (DMap.null accum) $ scheduleMergeSelf m myHeight
19142146 liftIO $ writeIORef accumRef $! accum
19152147 liftIO $ writeIORef heightRef $! myHeight
19162148 liftIO $ writeIORef heightBagRef $! myHeightBag
1917− changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
19182149 liftIO $ writeIORef parentsRef $! initialParentState
19192150 defer $ SomeMergeInit $ do
1920− let s = Subscriber
2151+ let changeSubscriber = Subscriber
19212152 { subscriberPropagate = \a -> {-# SCC "traverseMergeChange" #-} do
1922− tracePropagate (Proxy :: Proxy x) $ "SubscriberMerge/Change"
1923− defer $ updateMerge m updateFunc a
2153+ tracePropagate (Proxy :: Proxy x) "SubscriberMerge/Change"
2154+ defer $ updateMerge subscribed m updateFunc a
19242155 , subscriberInvalidateHeight = \_ -> return ()
19252156 , subscriberRecalculateHeight = \_ -> return ()
19262157 }
1927− (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) s
1928− forM_ change $ \c -> defer $ updateMerge m updateFunc c
2158+ (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) changeSubscriber
2159+ forM_ change $ \c -> defer $ updateMerge subscribed m updateFunc c
19292160 -- We explicitly hold on to the unsubscribe function from subscribing to the update event.
19302161 -- If we don't do this, there are certain cases where mergeCheap will fail to properly retain
19312162 -- its subscription.
1932− liftIO $ writeIORef changeSubdRef (s, changeSubscription)
2163+ liftIO $ writeIORef changeSubdRef (changeSubscriber, changeSubscription)
19332164 let unsubscribeAll = destroy =<< readIORef parentsRef
1934− return ( EventSubscription unsubscribeAll $ EventSubscribed heightRef $ toAny (parentsRef, changeSubdRef)
1935− , occ
1936− )
19372165
1938−mergeInt :: forall x a. (HasSpiderTimeline x) => Dynamic x (PatchIntMap (Event x a)) -> Event x (IntMap a)
2166+ return (EventSubscription unsubscribeAll subscribed, occ)
2167+
2168+
2169+mergeInt :: forall x a. (HasSpiderTimeline x) => DynamicS x (PatchIntMap (Event x a)) -> Event x (IntMap a)
19392170mergeInt = cacheEvent . mergeIntCheap
19402171
19412172{-# INLINABLE mergeIntCheap #-}
1942−mergeIntCheap :: forall x a. (HasSpiderTimeline x) => Dynamic x (PatchIntMap (Event x a)) -> Event x (IntMap a)
2173+mergeIntCheap :: forall x a. (HasSpiderTimeline x) => DynamicS x (PatchIntMap (Event x a)) -> Event x (IntMap a)
19432174mergeIntCheap d = Event $ \sub -> do
19442175 initialParents <- readBehaviorUntracked $ dynamicCurrent d
19452176 accum <- liftIO $ FastMutableIntMap.newEmpty
19462177 heightRef <- liftIO $ newIORef zeroHeight
19472178 heightBagRef <- liftIO $ newIORef heightBagEmpty
19482179 parents <- liftIO $ FastMutableIntMap.newEmpty
2180+ changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
2181+ let subscribed = EventSubscribed
2182+ { eventSubscribedHeightRef = heightRef
2183+ , eventSubscribedRetained = toAny (parents, changeSubdRef)
2184+#ifdef DEBUG_CYCLES
2185+ , eventSubscribedGetParents = fmap (_eventSubscription_subscribed . snd) <$> FastMutableIntMap.toList parents
2186+ , eventSubscribedHasOwnHeightRef = False
2187+ , eventSubscribedWhoCreated = whoCreatedIORef heightRef
2188+#endif
2189+ }
19492190 let scheduleSelf = do
19502191 height <- liftIO $ readIORef $ heightRef
19512192 scheduleMerge' height heightRef $ do
19522193 vals <- liftIO $ FastMutableIntMap.getFrozenAndClear accum
19532194 subscriberPropagate sub vals
1954− invalidateMyHeight = do
1955− invalidateMergeHeight' heightRef sub
2195+ invalidateMyHeight = invalidateMergeHeight' heightRef sub
19562196 recalculateMyHeight = do
19572197 currentHeight <- readIORef heightRef
19582198 when (currentHeight == invalidHeight) $ do --TODO: This will almost always be true; can we get rid of this check and just proceed to the next one always?
@@ -1962,12 +2202,14 @@ mergeIntCheap d = Event $ \sub -> do
19622202 LT -> return ()
19632203 EQ -> do
19642204 let height = succHeight $ heightBagMax heights
1965− when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: height: " <> show height
2205+ traceInvalidateHeight $ "recalculateSubscriberHeight: height: " <> show height
19662206 writeIORef heightRef $! height
19672207 subscriberRecalculateHeight sub height
19682208 GT -> error $ "revalidateMergeHeight: more heights (" <> show (heightBagSize heights) <> ") than parents (" <> show numParents <> ") for Merge"
19692209 mySubscriber k = Subscriber
19702210 { subscriberPropagate = \a -> do
2211+ checkCycle subscribed
2212+
19712213 wasEmpty <- liftIO $ FastMutableIntMap.isEmpty accum
19722214 liftIO $ FastMutableIntMap.insert accum k a
19732215 when wasEmpty scheduleSelf
@@ -2001,7 +2243,6 @@ mergeIntCheap d = Event $ \sub -> do
20012243 else liftIO $ Just <$> FastMutableIntMap.getFrozenAndClear accum
20022244 else do when (not isEmpty) scheduleSelf -- We have things accumulated, but we shouldn't have fired them yet
20032245 return Nothing
2004− changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
20052246 defer $ SomeMergeInit $ do
20062247 let updateMe a = SomeMergeUpdate u invalidateMyHeight recalculateMyHeight
20072248 where
@@ -2015,35 +2256,39 @@ mergeIntCheap d = Event $ \sub -> do
20152256 oldParents <- liftIO $ FastMutableIntMap.applyPatch parents newSubscriptions
20162257 liftIO $ for_ oldParents $ \oldParent -> do
20172258 oldParentHeight <- getEventSubscribedHeight $ _eventSubscription_subscribed oldParent
2259+
2260+ print ("updateMe", oldParentHeight)
20182261 modifyIORef' heightBagRef $ heightBagRemove oldParentHeight
20192262 return $ IntMap.elems oldParents
2020− let s = Subscriber
2263+ let changeSubscriber = Subscriber
20212264 { subscriberPropagate = \a -> {-# SCC "traverseMergeChange" #-} do
20222265 tracePropagate (Proxy :: Proxy x) $ "SubscriberMergeInt/Change"
20232266 defer $ updateMe a
20242267 , subscriberInvalidateHeight = \_ -> return ()
20252268 , subscriberRecalculateHeight = \_ -> return ()
20262269 }
2027− (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) s
2270+ (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) changeSubscriber
20282271 forM_ change $ \c -> defer $ updateMe c
20292272 -- We explicitly hold on to the unsubscribe function from subscribing to the update event.
20302273 -- If we don't do this, there are certain cases where mergeCheap will fail to properly retain
20312274 -- its subscription.
2032− liftIO $ writeIORef changeSubdRef (s, changeSubscription)
2275+ liftIO $ writeIORef changeSubdRef (changeSubscriber, changeSubscription)
20332276 let unsubscribeAll = traverse_ unsubscribe =<< FastMutableIntMap.getFrozenAndClear parents
2034− return ( EventSubscription unsubscribeAll $ EventSubscribed heightRef $ toAny (parents, changeSubdRef)
2035− , occ
2036− )
2277+
2278+
2279+ return (EventSubscription unsubscribeAll subscribed, occ)
20372280
20382281newtype EventSelector x k = EventSelector { select :: forall a. k a -> Event x a }
2282+newtype EventSelectorG x k v = EventSelectorG { selectG :: forall a. k a -> Event x (v a) }
20392283
2040−fan :: (HasSpiderTimeline x, GCompare k) => Event x (DMap k Identity) -> EventSelector x k
2041−fan e =
2284+fanG :: (HasSpiderTimeline x, GCompare k) => Event x (DMap k v) -> EventSelectorG x k v
2285+fanG e = unsafePerformIO $ do
2286+ ref <- newIORef Nothing
20422287 let f = Fan
20432288 { fanParent = e
2044− , fanSubscribed = unsafeNewIORef e Nothing
2289+ , fanSubscribed = ref
20452290 }
2046− in EventSelector $ \k -> eventFan k f
2291+ pure $ EventSelectorG $ \k -> eventFan k f
20472292
20482293runHoldInits :: HasSpiderTimeline x => IORef [SomeHoldInit x] -> IORef [SomeDynInit x] -> IORef [SomeMergeInit x] -> EventM x ()
20492294runHoldInits holdInitRef dynInitRef mergeInitRef = do
@@ -2096,37 +2341,37 @@ clearEventEnv (EventEnv toAssignRef holdInitRef dynInitRef mergeUpdateRef mergeI
20962341
20972342-- | Run an event action outside of a frame
20982343runFrame :: forall x a. HasSpiderTimeline x => EventM x a -> SpiderHost x a --TODO: This function also needs to hold the mutex
2099−runFrame a = SpiderHost $ ask >>= \_ -> lift $ do
2100− let env = _spiderTimeline_eventEnv (spiderTimeline :: SpiderTimelineEnv x)
2344+runFrame a = SpiderHost $ do
2345+ let env = _spiderTimeline_eventEnv $ unSTE (spiderTimeline :: SpiderTimelineEnv x)
21012346 let go = do
21022347 result <- a
21032348 runHoldInits (eventEnvHoldInits env) (eventEnvDynInits env) (eventEnvMergeInits env) -- This must happen before doing the assignments, in case subscribing a Hold causes existing Holds to be read by the newly-propagated events
21042349 return result
21052350 result <- runEventM go
21062351 toClear <- readIORef $ eventEnvClears env
2107− forM_ toClear $ \(SomeClear ref) -> {-# SCC "clear" #-} writeIORef ref Nothing
2352+ forM_ toClear $ \(Some (Clear ref)) -> {-# SCC "clear" #-} writeIORef ref Nothing
21082353 toClearInt <- readIORef $ eventEnvIntClears env
2109− forM_ toClearInt $ \(SomeIntClear ref) -> {-# SCC "intClear" #-} writeIORef ref $! IntMap.empty
2354+ forM_ toClearInt $ \(Some (IntClear ref)) -> {-# SCC "intClear" #-} writeIORef ref $! IntMap.empty
21102355 toClearRoot <- readIORef $ eventEnvRootClears env
2111− forM_ toClearRoot $ \(SomeRootClear ref) -> {-# SCC "rootClear" #-} writeIORef ref $! DMap.empty
2356+ forM_ toClearRoot $ \(Some (RootClear ref)) -> {-# SCC "rootClear" #-} writeIORef ref $! DMap.empty
21122357 toAssign <- readIORef $ eventEnvAssignments env
21132358 toReconnectRef <- newIORef []
21142359 coincidenceInfos <- readIORef $ eventEnvResetCoincidences env
21152360 forM_ toAssign $ \(SomeAssignment vRef iRef v) -> {-# SCC "assignment" #-} do
21162361 writeIORef vRef v
2117− when debugInvalidate $ putStrLn $ "Invalidating Hold"
2362+ traceInvalidate $ "Invalidating Hold"
21182363 writeIORef iRef =<< evaluate =<< invalidate toReconnectRef =<< readIORef iRef
21192364 mergeUpdates <- readIORef $ eventEnvMergeUpdates env
21202365 writeIORef (eventEnvMergeUpdates env) []
2121− when debugPropagate $ putStrLn "Updating merges"
2366+ tracePropagate (Proxy::Proxy x) $ "Updating merges"
21222367 mergeSubscriptionsToKill <- runEventM $ concat <$> mapM _someMergeUpdate_update mergeUpdates
2123− when debugPropagate $ putStrLn "Updating merges done"
2368+ tracePropagate (Proxy::Proxy x) $ "Updating merges done"
21242369 toReconnect <- readIORef toReconnectRef
21252370 clearEventEnv env
21262371 switchSubscriptionsToKill <- forM toReconnect $ \(SomeSwitchSubscribed subscribed) -> {-# SCC "switchSubscribed" #-} do
21272372 oldSubscription <- readIORef $ switchSubscribedCurrentParent subscribed
21282373 wi <- readIORef $ switchSubscribedOwnWeakInvalidator subscribed
2129− when debugInvalidate $ putStrLn $ "Finalizing invalidator for Switch" <> showNodeId subscribed
2374+ traceInvalidate $ "Finalizing invalidator for Switch" <> showNodeId subscribed
21302375 finalize wi
21312376 i <- evaluate $ switchSubscribedOwnInvalidator subscribed
21322377 wi' <- mkWeakPtrWithDebug i "wi'"
@@ -2137,10 +2382,10 @@ runFrame a = SpiderHost $ ask >>= \_ -> lift $ do
21372382 runEventM $ runHoldInits (eventEnvHoldInits env) (eventEnvDynInits env) (eventEnvMergeInits env) --TODO: Is this actually OK? It seems like it should be, since we know that no events are firing at this point, but it still seems inelegant
21382383 --TODO: Make sure we touch the pieces of the SwitchSubscribed at the appropriate times
21392384 sub <- newSubscriberSwitch subscribed
2140− subscription <- runReaderT (unSpiderHost (runFrame ({-# SCC "subscribeSwitch" #-} subscribe e sub))) spiderTimeline --TODO: Assert that the event isn't firing --TODO: This should not loop because none of the events should be firing, but still, it is inefficient
2385+ subscription <- unSpiderHost $ runFrame $ {-# SCC "subscribeSwitch" #-} subscribe e sub --TODO: Assert that the event isn't firing --TODO: This should not loop because none of the events should be firing, but still, it is inefficient
21412386 {-
21422387 stackTrace <- liftIO $ fmap renderStack $ ccsToStrings =<< (getCCSOf $! switchSubscribedParent subscribed)
2143− liftIO $ putStrLn $ (++stackTrace) $ "subd' subscribed to " ++ case e of
2388+ liftIO $ debugStrLn $ (++stackTrace) $ "subd' subscribed to " ++ case e of
21442389 EventRoot _ -> "EventRoot"
21452390 EventNever -> "EventNever"
21462391 _ -> "something else"
@@ -2155,7 +2400,7 @@ runFrame a = SpiderHost $ ask >>= \_ -> lift $ do
21552400 myHeight <- readIORef $ switchSubscribedHeight subscribed
21562401 when (parentHeight /= myHeight) $ do
21572402 writeIORef (switchSubscribedHeight subscribed) $! invalidHeight
2158− WeakBag.traverse (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight myHeight
2403+ WeakBag.traverse_ (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight myHeight
21592404 mapM_ _someMergeUpdate_invalidateHeight mergeUpdates --TODO: In addition to when the patch is completely empty, we should also not run this if it has some Nothing values, but none of them have actually had any effect; potentially, we could even check for Just values with no effect (e.g. by comparing their IORefs and ignoring them if they are unchanged); actually, we could just check if the new height is different
21602405 forM_ coincidenceInfos $ \(SomeResetCoincidence subscription mcs) -> do
21612406 unsubscribe subscription
@@ -2196,7 +2441,7 @@ invalidateCoincidenceHeight subscribed = do
21962441 oldHeight <- readIORef $ coincidenceSubscribedHeight subscribed
21972442 when (oldHeight /= invalidHeight) $ do
21982443 writeIORef (coincidenceSubscribedHeight subscribed) $! invalidHeight
2199− WeakBag.traverse (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
2444+ WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
22002445
22012446updateSwitchHeight :: Height -> SwitchSubscribed x a -> IO ()
22022447updateSwitchHeight new subscribed = do
@@ -2204,7 +2449,7 @@ updateSwitchHeight new subscribed = do
22042449 when (oldHeight == invalidHeight) $ do --TODO: This 'when' should probably be an assertion
22052450 when (new /= invalidHeight) $ do --TODO: This 'when' should probably be an assertion
22062451 writeIORef (switchSubscribedHeight subscribed) $! new
2207− WeakBag.traverse (switchSubscribedSubscribers subscribed) $ recalculateSubscriberHeight new
2452+ WeakBag.traverse_ (switchSubscribedSubscribers subscribed) $ recalculateSubscriberHeight new
22082453
22092454recalculateCoincidenceHeight :: CoincidenceSubscribed x a -> IO ()
22102455recalculateCoincidenceHeight subscribed = do
@@ -2213,7 +2458,7 @@ recalculateCoincidenceHeight subscribed = do
22132458 height <- calculateCoincidenceHeight subscribed
22142459 when (height /= invalidHeight) $ do
22152460 writeIORef (coincidenceSubscribedHeight subscribed) $! height
2216− WeakBag.traverse (coincidenceSubscribedSubscribers subscribed) $ recalculateSubscriberHeight height
2461+ WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ recalculateSubscriberHeight height
22172462
22182463calculateSwitchHeight :: SwitchSubscribed x a -> IO Height
22192464calculateSwitchHeight subscribed = getEventSubscribedHeight . _eventSubscription_subscribed =<< readIORef (switchSubscribedCurrentParent subscribed)
@@ -2252,14 +2497,219 @@ invalidate toReconnectRef wis = do
22522497-- Reflex integration
22532498--------------------------------------------------------------------------------
22542499
2255−#ifndef SPECIALIZE_TO_SPIDERTIMELINE_GLOBAL
2256−-- When we're specializing, we include this from Reflex.Class instead, because
2257−-- it needs access to these types; when we're not, we want them here, so our
2258−-- instance isn't an orphan instance.
2259−#include "SpiderTimeline.include.hs"
2260−#include "SpiderTimelineHost.include.hs"
2500+-- | Designates the default, global Spider timeline
2501+data SpiderTimeline x
2502+type role SpiderTimeline nominal
2503+
2504+-- | The default, global Spider environment
2505+type Spider = SpiderTimeline Global
2506+
2507+instance HasSpiderTimeline x => Reflex.Class.MonadSample (SpiderTimeline x) (EventM x) where
2508+ {-# INLINABLE sample #-}
2509+ sample (SpiderBehavior b) = readBehaviorUntracked b
2510+
2511+instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (EventM x) where
2512+ {-# INLINABLE hold #-}
2513+ hold = holdSpiderEventM
2514+ {-# INLINABLE holdDyn #-}
2515+ holdDyn = holdDynSpiderEventM
2516+ {-# INLINABLE holdIncremental #-}
2517+ holdIncremental = holdIncrementalSpiderEventM
2518+ {-# INLINABLE buildDynamic #-}
2519+ buildDynamic = buildDynamicSpiderEventM
2520+ {-# INLINABLE headE #-}
2521+ headE = R.slowHeadE
2522+-- headE (SpiderEvent e) = SpiderEvent <$> Reflex.Spider.Internal.headE e
2523+ {-# INLINABLE now #-}
2524+ now = nowSpiderEventM
2525+
2526+instance Reflex.Class.MonadSample (SpiderTimeline x) (SpiderPullM x) where
2527+ {-# INLINABLE sample #-}
2528+ sample = coerce . readBehaviorTracked . unSpiderBehavior
2529+
2530+instance HasSpiderTimeline x => Reflex.Class.MonadSample (SpiderTimeline x) (SpiderPushM x) where
2531+ {-# INLINABLE sample #-}
2532+ sample (SpiderBehavior b) = SpiderPushM $ readBehaviorUntracked b
2533+
2534+instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (SpiderPushM x) where
2535+ {-# INLINABLE hold #-}
2536+ hold v0 e = Reflex.Class.current <$> Reflex.Class.holdDyn v0 e
2537+ {-# INLINABLE holdDyn #-}
2538+ holdDyn v0 (SpiderEvent e) = SpiderPushM $ fmap (SpiderDynamic . dynamicHoldIdentity) $ Reflex.Spider.Internal.hold v0 $ coerce e
2539+ {-# INLINABLE holdIncremental #-}
2540+ holdIncremental v0 (SpiderEvent e) = SpiderPushM $ SpiderIncremental . dynamicHold <$> Reflex.Spider.Internal.hold v0 e
2541+ {-# INLINABLE buildDynamic #-}
2542+ buildDynamic getV0 (SpiderEvent e) = SpiderPushM $ fmap (SpiderDynamic . dynamicDynIdentity) $ Reflex.Spider.Internal.buildDynamic (coerce getV0) $ coerce e
2543+ {-# INLINABLE headE #-}
2544+ headE = R.slowHeadE
2545+-- headE (SpiderEvent e) = SpiderPushM $ SpiderEvent <$> Reflex.Spider.Internal.headE e
2546+ {-# INLINABLE now #-}
2547+ now = SpiderPushM nowSpiderEventM
2548+
2549+
2550+instance HasSpiderTimeline x => Monad (Reflex.Class.Dynamic (SpiderTimeline x)) where
2551+ {-# INLINE return #-}
2552+ return = pure
2553+ {-# INLINE (>>=) #-}
2554+ x >>= f = SpiderDynamic $ dynamicDynIdentity $ newJoinDyn $ newMapDyn (unSpiderDynamic . f) $ unSpiderDynamic x
2555+ {-# INLINE (>>) #-}
2556+ (>>) = (*>)
2557+#if !MIN_VERSION_base(4,13,0)
2558+ {-# INLINE fail #-}
2559+ fail _ = error "Dynamic does not support 'fail'"
22612560#endif
22622561
2562+{-# INLINABLE newJoinDyn #-}
2563+newJoinDyn :: HasSpiderTimeline x => DynamicS x (Identity (DynamicS x (Identity a))) -> Reflex.Spider.Internal.Dyn x (Identity a)
2564+newJoinDyn d =
2565+ let readV0 = readBehaviorTracked . dynamicCurrent =<< readBehaviorTracked (dynamicCurrent d)
2566+ eOuter = Reflex.Spider.Internal.push (fmap (Just . Identity) . readBehaviorUntracked . dynamicCurrent . runIdentity) $ dynamicUpdated d
2567+ eInner = Reflex.Spider.Internal.switch $ dynamicUpdated <$> dynamicCurrent d
2568+ eBoth = Reflex.Spider.Internal.coincidence $ dynamicUpdated . runIdentity <$> dynamicUpdated d
2569+ v' = unSpiderEvent $ Reflex.Class.leftmost $ map SpiderEvent [eBoth, eOuter, eInner]
2570+ in Reflex.Spider.Internal.unsafeBuildDynamic readV0 v'
2571+
2572+instance HasSpiderTimeline x => Functor (Reflex.Class.Dynamic (SpiderTimeline x)) where
2573+ fmap = mapDynamicSpider
2574+ x <$ d = R.unsafeBuildDynamic (return x) $ x <$ R.updated d
2575+
2576+mapDynamicSpider :: HasSpiderTimeline x => (a -> b) -> Reflex.Class.Dynamic (SpiderTimeline x) a -> Reflex.Class.Dynamic (SpiderTimeline x) b
2577+mapDynamicSpider f = SpiderDynamic . newMapDyn f . unSpiderDynamic
2578+{-# INLINE [1] mapDynamicSpider #-}
2579+
2580+instance HasSpiderTimeline x => Applicative (Reflex.Class.Dynamic (SpiderTimeline x)) where
2581+ pure = SpiderDynamic . dynamicConst
2582+#if MIN_VERSION_base(4,10,0)
2583+ liftA2 f a b = SpiderDynamic $ Reflex.Spider.Internal.zipDynWith f (unSpiderDynamic a) (unSpiderDynamic b)
2584+#endif
2585+ SpiderDynamic a <*> SpiderDynamic b = SpiderDynamic $ Reflex.Spider.Internal.zipDynWith ($) a b
2586+ a *> b = R.unsafeBuildDynamic (R.sample $ R.current b) $ R.leftmost [R.updated b, R.tag (R.current b) $ R.updated a]
2587+ (<*) = flip (*>) -- There are no effects, so order doesn't matter
2588+
2589+holdSpiderEventM :: HasSpiderTimeline x => a -> Reflex.Class.Event (SpiderTimeline x) a -> EventM x (Reflex.Class.Behavior (SpiderTimeline x) a)
2590+holdSpiderEventM v0 e = fmap (SpiderBehavior . behaviorHoldIdentity) $ Reflex.Spider.Internal.hold v0 $ coerce $ unSpiderEvent e
2591+
2592+holdDynSpiderEventM :: HasSpiderTimeline x => a -> Reflex.Class.Event (SpiderTimeline x) a -> EventM x (Reflex.Class.Dynamic (SpiderTimeline x) a)
2593+holdDynSpiderEventM v0 e = fmap (SpiderDynamic . dynamicHoldIdentity) $ Reflex.Spider.Internal.hold v0 $ coerce $ unSpiderEvent e
2594+
2595+holdIncrementalSpiderEventM :: (HasSpiderTimeline x, Patch p) => PatchTarget p -> Reflex.Class.Event (SpiderTimeline x) p -> EventM x (Reflex.Class.Incremental (SpiderTimeline x) p)
2596+holdIncrementalSpiderEventM v0 e = fmap (SpiderIncremental . dynamicHold) $ Reflex.Spider.Internal.hold v0 $ unSpiderEvent e
2597+
2598+buildDynamicSpiderEventM :: HasSpiderTimeline x => SpiderPushM x a -> Reflex.Class.Event (SpiderTimeline x) a -> EventM x (Reflex.Class.Dynamic (SpiderTimeline x) a)
2599+buildDynamicSpiderEventM getV0 e = fmap (SpiderDynamic . dynamicDynIdentity) $ Reflex.Spider.Internal.buildDynamic (coerce getV0) $ coerce $ unSpiderEvent e
2600+
2601+instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (SpiderHost x) where
2602+ {-# INLINABLE hold #-}
2603+ hold v0 e = runFrame . runSpiderHostFrame $ Reflex.Class.hold v0 e
2604+ {-# INLINABLE holdDyn #-}
2605+ holdDyn v0 e = runFrame . runSpiderHostFrame $ Reflex.Class.holdDyn v0 e
2606+ {-# INLINABLE holdIncremental #-}
2607+ holdIncremental v0 e = runFrame . runSpiderHostFrame $ Reflex.Class.holdIncremental v0 e
2608+ {-# INLINABLE buildDynamic #-}
2609+ buildDynamic getV0 e = runFrame . runSpiderHostFrame $ Reflex.Class.buildDynamic getV0 e
2610+ {-# INLINABLE headE #-}
2611+ headE e = runFrame . runSpiderHostFrame $ Reflex.Class.headE e
2612+ {-# INLINABLE now #-}
2613+ now = runFrame . runSpiderHostFrame $ Reflex.Class.now
2614+
2615+
2616+instance HasSpiderTimeline x => Reflex.Class.MonadSample (SpiderTimeline x) (SpiderHostFrame x) where
2617+ sample = SpiderHostFrame . readBehaviorUntracked . unSpiderBehavior --TODO: This can cause problems with laziness, so we should get rid of it if we can
2618+
2619+instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (SpiderHostFrame x) where
2620+ {-# INLINABLE hold #-}
2621+ hold v0 e = SpiderHostFrame $ fmap (SpiderBehavior . behaviorHoldIdentity) $ Reflex.Spider.Internal.hold v0 $ coerce $ unSpiderEvent e
2622+ {-# INLINABLE holdDyn #-}
2623+ holdDyn v0 e = SpiderHostFrame $ fmap (SpiderDynamic . dynamicHoldIdentity) $ Reflex.Spider.Internal.hold v0 $ coerce $ unSpiderEvent e
2624+ {-# INLINABLE holdIncremental #-}
2625+ holdIncremental v0 e = SpiderHostFrame $ fmap (SpiderIncremental . dynamicHold) $ Reflex.Spider.Internal.hold v0 $ unSpiderEvent e
2626+ {-# INLINABLE buildDynamic #-}
2627+ buildDynamic getV0 e = SpiderHostFrame $ fmap (SpiderDynamic . dynamicDynIdentity) $ Reflex.Spider.Internal.buildDynamic (coerce getV0) $ coerce $ unSpiderEvent e
2628+ {-# INLINABLE headE #-}
2629+ headE = R.slowHeadE
2630+-- headE (SpiderEvent e) = SpiderHostFrame $ SpiderEvent <$> Reflex.Spider.Internal.headE e
2631+ {-# INLINABLE now #-}
2632+ now = SpiderHostFrame Reflex.Class.now
2633+
2634+instance HasSpiderTimeline x => Reflex.Class.MonadSample (SpiderTimeline x) (SpiderHost x) where
2635+ {-# INLINABLE sample #-}
2636+ sample = runFrame . readBehaviorUntracked . unSpiderBehavior
2637+
2638+instance HasSpiderTimeline x => Reflex.Class.MonadSample (SpiderTimeline x) (Reflex.Spider.Internal.ReadPhase x) where
2639+ {-# INLINABLE sample #-}
2640+ sample = Reflex.Spider.Internal.ReadPhase . Reflex.Class.sample
2641+
2642+instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Reflex.Spider.Internal.ReadPhase x) where
2643+ {-# INLINABLE hold #-}
2644+ hold v0 e = Reflex.Spider.Internal.ReadPhase $ Reflex.Class.hold v0 e
2645+ {-# INLINABLE holdDyn #-}
2646+ holdDyn v0 e = Reflex.Spider.Internal.ReadPhase $ Reflex.Class.holdDyn v0 e
2647+ {-# INLINABLE holdIncremental #-}
2648+ holdIncremental v0 e = Reflex.Spider.Internal.ReadPhase $ Reflex.Class.holdIncremental v0 e
2649+ {-# INLINABLE buildDynamic #-}
2650+ buildDynamic getV0 e = Reflex.Spider.Internal.ReadPhase $ Reflex.Class.buildDynamic getV0 e
2651+ {-# INLINABLE headE #-}
2652+ headE e = Reflex.Spider.Internal.ReadPhase $ Reflex.Class.headE e
2653+ {-# INLINABLE now #-}
2654+ now = Reflex.Spider.Internal.ReadPhase Reflex.Class.now
2655+
2656+--------------------------------------------------------------------------------
2657+-- Deprecated items
2658+--------------------------------------------------------------------------------
2659+
2660+-- | 'SpiderEnv' is the old name for 'SpiderTimeline'
2661+{-# DEPRECATED SpiderEnv "Use 'SpiderTimelineEnv' instead" #-}
2662+type SpiderEnv = SpiderTimeline
2663+instance HasSpiderTimeline x => Reflex.Host.Class.MonadSubscribeEvent (SpiderTimeline x) (SpiderHostFrame x) where
2664+ {-# INLINABLE subscribeEvent #-}
2665+ subscribeEvent e = SpiderHostFrame $ do
2666+ --TODO: Unsubscribe eventually (manually and/or with weak ref)
2667+ val <- liftIO $ newIORef Nothing
2668+ subscription <- subscribe (unSpiderEvent e) $ Subscriber
2669+ { subscriberPropagate = \a -> do
2670+ liftIO $ writeIORef val $ Just a
2671+ scheduleClear val
2672+ , subscriberInvalidateHeight = \_ -> return ()
2673+ , subscriberRecalculateHeight = \_ -> return ()
2674+ }
2675+ return $ SpiderEventHandle
2676+ { spiderEventHandleSubscription = subscription
2677+ , spiderEventHandleValue = val
2678+ }
2679+
2680+instance HasSpiderTimeline x => Reflex.Host.Class.ReflexHost (SpiderTimeline x) where
2681+ type EventTrigger (SpiderTimeline x) = RootTrigger x
2682+ type EventHandle (SpiderTimeline x) = SpiderEventHandle x
2683+ type HostFrame (SpiderTimeline x) = SpiderHostFrame x
2684+
2685+instance HasSpiderTimeline x => Reflex.Host.Class.MonadReadEvent (SpiderTimeline x) (Reflex.Spider.Internal.ReadPhase x) where
2686+ {-# NOINLINE readEvent #-}
2687+ readEvent h = Reflex.Spider.Internal.ReadPhase $ fmap (fmap return) $ liftIO $ do
2688+ result <- readIORef $ spiderEventHandleValue h
2689+ touch h
2690+ return result
2691+
2692+instance HasSpiderTimeline x => Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHost x) where
2693+ newEventWithTrigger = SpiderHost . fmap SpiderEvent . newEventWithTriggerIO
2694+ newFanEventWithTrigger f = SpiderHost $ do
2695+ es <- newFanEventWithTriggerIO f
2696+ return $ Reflex.Class.EventSelector $ SpiderEvent . Reflex.Spider.Internal.select es
2697+
2698+instance HasSpiderTimeline x => Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHostFrame x) where
2699+ newEventWithTrigger = SpiderHostFrame . EventM . liftIO . fmap SpiderEvent . newEventWithTriggerIO
2700+ newFanEventWithTrigger f = SpiderHostFrame $ EventM $ liftIO $ do
2701+ es <- newFanEventWithTriggerIO f
2702+ return $ Reflex.Class.EventSelector $ SpiderEvent . Reflex.Spider.Internal.select es
2703+
2704+instance HasSpiderTimeline x => Reflex.Host.Class.MonadSubscribeEvent (SpiderTimeline x) (SpiderHost x) where
2705+ {-# INLINABLE subscribeEvent #-}
2706+ subscribeEvent = runFrame . runSpiderHostFrame . Reflex.Host.Class.subscribeEvent
2707+
2708+instance HasSpiderTimeline x => Reflex.Host.Class.MonadReflexHost (SpiderTimeline x) (SpiderHost x) where
2709+ type ReadPhase (SpiderHost x) = Reflex.Spider.Internal.ReadPhase x
2710+ fireEventsAndRead es (Reflex.Spider.Internal.ReadPhase a) = run es a
2711+ runHostFrame = runFrame . runSpiderHostFrame
2712+
22632713unsafeNewSpiderTimelineEnv :: forall x. IO (SpiderTimelineEnv x)
22642714unsafeNewSpiderTimelineEnv = do
22652715 lock <- newMVar ()
@@ -2267,7 +2717,7 @@ unsafeNewSpiderTimelineEnv = do
22672717#ifdef DEBUG
22682718 depthRef <- newIORef 0
22692719#endif
2270− return $ SpiderTimelineEnv
2720+ return $ STE $ SpiderTimelineEnv
22712721 { _spiderTimeline_lock = lock
22722722 , _spiderTimeline_eventEnv = env
22732723#ifdef DEBUG
@@ -2275,43 +2725,40 @@ unsafeNewSpiderTimelineEnv = do
22752725#endif
22762726 }
22772727
2278−#ifndef SPECIALIZE_TO_SPIDERTIMELINE_GLOBAL
22792728-- | Create a new SpiderTimelineEnv
22802729newSpiderTimeline :: IO (Some SpiderTimelineEnv)
2281−newSpiderTimeline = withSpiderTimeline (pure . Some.This)
2730+newSpiderTimeline = withSpiderTimeline (pure . Some)
22822731
2283−data LocalSpiderTimeline x s
2732+data LocalSpiderTimeline (x :: Type) s
22842733
22852734instance Reifies s (SpiderTimelineEnv x) =>
22862735 HasSpiderTimeline (LocalSpiderTimeline x s) where
2287− spiderTimeline = localSpiderTimeline (Proxy :: Proxy s) $ reflect (Proxy :: Proxy s)
2736+ spiderTimeline = localSpiderTimeline Proxy $ reflect (Proxy :: Proxy s)
22882737
22892738localSpiderTimeline
2290− :: Proxy s
2739+ :: proxy s
22912740 -> SpiderTimelineEnv x
22922741 -> SpiderTimelineEnv (LocalSpiderTimeline x s)
2293−localSpiderTimeline _ = unsafeCoerce
2742+localSpiderTimeline _ = coerce
22942743
22952744-- | Pass a new timeline to the given function.
22962745withSpiderTimeline :: (forall x. HasSpiderTimeline x => SpiderTimelineEnv x -> IO r) -> IO r
22972746withSpiderTimeline k = do
22982747 env <- unsafeNewSpiderTimelineEnv
22992748 reify env $ \s -> k $ localSpiderTimeline s env
2300−#endif
23012749
2302−newtype SpiderPullM x a = SpiderPullM (BehaviorM x a) deriving (Functor, Applicative, Monad, MonadIO, MonadFix)
2750+newtype SpiderPullM (x :: Type) a = SpiderPullM (BehaviorM x a) deriving (Functor, Applicative, Monad, MonadIO, MonadFix)
23032751
23042752type ComputeM = EventM
23052753
2306−newtype SpiderPushM x a = SpiderPushM (ComputeM x a) deriving (Functor, Applicative, Monad, MonadIO, MonadFix)
2754+newtype SpiderPushM (x :: Type) a = SpiderPushM (ComputeM x a) deriving (Functor, Applicative, Monad, MonadIO, MonadFix)
23072755
2308−#ifndef SPECIALIZE_TO_SPIDERTIMELINE_GLOBAL
23092756instance HasSpiderTimeline x => R.Reflex (SpiderTimeline x) where
23102757 {-# SPECIALIZE instance R.Reflex (SpiderTimeline Global) #-}
23112758 newtype Behavior (SpiderTimeline x) a = SpiderBehavior { unSpiderBehavior :: Behavior x a }
23122759 newtype Event (SpiderTimeline x) a = SpiderEvent { unSpiderEvent :: Event x a }
2313− newtype Dynamic (SpiderTimeline x) a = SpiderDynamic { unSpiderDynamic :: Dynamic x (Identity a) } -- deriving (Functor, Applicative, Monad)
2314− newtype Incremental (SpiderTimeline x) p = SpiderIncremental { unSpiderIncremental :: Dynamic x p }
2760+ newtype Dynamic (SpiderTimeline x) a = SpiderDynamic { unSpiderDynamic :: DynamicS x (Identity a) } -- deriving (Functor, Applicative, Monad)
2761+ newtype Incremental (SpiderTimeline x) p = SpiderIncremental { unSpiderIncremental :: DynamicS x p }
23152762 type PullM (SpiderTimeline x) = SpiderPullM x
23162763 type PushM (SpiderTimeline x) = SpiderPushM x
23172764 {-# INLINABLE never #-}
@@ -2324,10 +2771,15 @@ instance HasSpiderTimeline x => R.Reflex (SpiderTimeline x) where
23242771 pushCheap f = SpiderEvent . pushCheap (coerce f) . unSpiderEvent
23252772 {-# INLINABLE pull #-}
23262773 pull = SpiderBehavior . pull . coerce
2327− {-# INLINABLE merge #-}
2328− merge = SpiderEvent . merge . dynamicConst . (coerce :: DMap k (R.Event (SpiderTimeline x)) -> DMap k (Event x))
2329− {-# INLINABLE fan #-}
2330− fan e = R.EventSelector $ SpiderEvent . select (fan (unSpiderEvent e))
2774+ {-# INLINABLE fanG #-}
2775+ fanG e = R.EventSelectorG $ SpiderEvent . selectG (fanG (unSpiderEvent e))
2776+ {-# INLINABLE mergeG #-}
2777+ mergeG
2778+ :: forall k2 (k :: k2 -> *) q (v :: k2 -> *). GCompare k
2779+ => (forall a. q a -> R.Event (SpiderTimeline x) (v a))
2780+ -> DMap k q
2781+ -> R.Event (SpiderTimeline x) (DMap k v)
2782+ mergeG nt = SpiderEvent . mergeG (unSpiderEvent #. nt) . dynamicConst
23312783 {-# INLINABLE switch #-}
23322784 switch = SpiderEvent . switch . (coerce :: Behavior x (R.Event (SpiderTimeline x) a) -> Behavior x (Event x a)) . unSpiderBehavior
23332785 {-# INLINABLE coincidence #-}
@@ -2335,15 +2787,15 @@ instance HasSpiderTimeline x => R.Reflex (SpiderTimeline x) where
23352787 {-# INLINABLE current #-}
23362788 current = SpiderBehavior . dynamicCurrent . unSpiderDynamic
23372789 {-# INLINABLE updated #-}
2338− updated = coerce $ SpiderEvent . dynamicUpdated . unSpiderDynamic
2790+ updated = SpiderEvent #. dynamicUpdated .# fmap coerce . unSpiderDynamic
23392791 {-# INLINABLE unsafeBuildDynamic #-}
23402792 unsafeBuildDynamic readV0 v' = SpiderDynamic $ dynamicDynIdentity $ unsafeBuildDynamic (coerce readV0) $ coerce $ unSpiderEvent v'
23412793 {-# INLINABLE unsafeBuildIncremental #-}
23422794 unsafeBuildIncremental readV0 dv = SpiderIncremental $ dynamicDyn $ unsafeBuildDynamic (coerce readV0) $ unSpiderEvent dv
2343− {-# INLINABLE mergeIncremental #-}
2344− mergeIncremental = SpiderEvent . merge . (unsafeCoerce :: Dynamic x (PatchDMap k (R.Event (SpiderTimeline x))) -> Dynamic x (PatchDMap k (Event x))) . unSpiderIncremental
2345− {-# INLINABLE mergeIncrementalWithMove #-}
2346− mergeIncrementalWithMove = SpiderEvent . mergeWithMove . (unsafeCoerce :: Dynamic x (PatchDMapWithMove k (R.Event (SpiderTimeline x))) -> Dynamic x (PatchDMapWithMove k (Event x))) . unSpiderIncremental
2795+ {-# INLINABLE mergeIncrementalG #-}
2796+ mergeIncrementalG nt = SpiderEvent #. mergeG (coerce #. nt) .# unSpiderIncremental
2797+ {-# INLINABLE mergeIncrementalWithMoveG #-}
2798+ mergeIncrementalWithMoveG nt = SpiderEvent #. mergeWithMove (coerce #. nt) .# unSpiderIncremental
23472799 {-# INLINABLE currentIncremental #-}
23482800 currentIncremental = SpiderBehavior . dynamicCurrent . unSpiderIncremental
23492801 {-# INLINABLE updatedIncremental #-}
@@ -2354,12 +2806,12 @@ instance HasSpiderTimeline x => R.Reflex (SpiderTimeline x) where
23542806 return $ Identity <$> apply p c --TODO: Avoid the redundant 'apply'
23552807 eventCoercion Coercion = Coercion
23562808 behaviorCoercion Coercion = Coercion
2357− dynamicCoercion = unsafeCoerce --TODO: How can we avoid this unsafeCoerce? This is safe only because we know how Identity works as a Patch instance
2809+ dynamicCoercion Coercion = Coercion
2810+ incrementalCoercion Coercion Coercion = Coercion
23582811 {-# INLINABLE mergeIntIncremental #-}
2359− mergeIntIncremental = SpiderEvent . mergeInt . (unsafeCoerce :: Dynamic x (PatchIntMap (R.Event (SpiderTimeline x) a)) -> Dynamic x (PatchIntMap (Event x a))) . unSpiderIncremental
2812+ mergeIntIncremental = SpiderEvent . mergeInt . coerce
23602813 {-# INLINABLE fanInt #-}
23612814 fanInt e = R.EventSelectorInt $ SpiderEvent . selectInt (fanInt (unSpiderEvent e))
2362−#endif
23632815
23642816data RootTrigger x a = forall k. GCompare k => RootTrigger (WeakBag (Subscriber x a), IORef (DMap k Identity), k a)
23652817
@@ -2382,7 +2834,7 @@ instance MonadAtomicRef (EventM x) where
23822834 atomicModifyRef r f = liftIO $ atomicModifyRef r f
23832835
23842836-- | The monad for actions that manipulate a Spider timeline identified by @x@
2385−newtype SpiderHost x a = SpiderHost { unSpiderHost :: ReaderT (SpiderTimelineEnv x) IO a } deriving (Functor, Applicative, MonadFix, MonadIO, MonadException, MonadAsyncException)
2837+newtype SpiderHost (x :: Type) a = SpiderHost { unSpiderHost :: IO a } deriving (Functor, Applicative, MonadFix, MonadIO, MonadException, MonadAsyncException)
23862838
23872839instance Monad (SpiderHost x) where
23882840 {-# INLINABLE (>>=) #-}
@@ -2391,22 +2843,27 @@ instance Monad (SpiderHost x) where
23912843 SpiderHost x >> SpiderHost y = SpiderHost $ x >> y
23922844 {-# INLINABLE return #-}
23932845 return x = SpiderHost $ return x
2846+#if !MIN_VERSION_base(4,13,0)
23942847 {-# INLINABLE fail #-}
2395− fail s = SpiderHost $ fail s
2848+ fail = MonadFail.fail
2849+#endif
2850+
2851+instance MonadFail (SpiderHost x) where
2852+ {-# INLINABLE fail #-}
2853+ fail s = SpiderHost $ MonadFail.fail s
23962854
23972855-- | Run an action affecting the global Spider timeline; this will be guarded by
23982856-- a mutex for that timeline
23992857runSpiderHost :: SpiderHost Global a -> IO a
2400−runSpiderHost (SpiderHost a) = runReaderT a globalSpiderTimelineEnv
2858+runSpiderHost (SpiderHost a) = a
24012859
2402−#ifndef SPECIALIZE_TO_SPIDERTIMELINE_GLOBAL
24032860-- | Run an action affecting a given Spider timeline; this will be guarded by a
24042861-- mutex for that timeline
24052862runSpiderHostForTimeline :: SpiderHost x a -> SpiderTimelineEnv x -> IO a
2406−runSpiderHostForTimeline (SpiderHost a) = runReaderT a
2407−#endif
2863+runSpiderHostForTimeline (SpiderHost a) _ = a
24082864
2409−newtype SpiderHostFrame x a = SpiderHostFrame { runSpiderHostFrame :: EventM x a } deriving (Functor, Applicative, MonadFix, MonadIO, MonadException, MonadAsyncException)
2865+newtype SpiderHostFrame (x :: Type) a = SpiderHostFrame { runSpiderHostFrame :: EventM x a }
2866+ deriving (Functor, Applicative, MonadFix, MonadIO, MonadException, MonadAsyncException)
24102867
24112868instance Monad (SpiderHostFrame x) where
24122869 {-# INLINABLE (>>=) #-}
@@ -2415,15 +2872,21 @@ instance Monad (SpiderHostFrame x) where
24152872 SpiderHostFrame x >> SpiderHostFrame y = SpiderHostFrame $ x >> y
24162873 {-# INLINABLE return #-}
24172874 return x = SpiderHostFrame $ return x
2875+#if !MIN_VERSION_base(4,13,0)
24182876 {-# INLINABLE fail #-}
24192877 fail s = SpiderHostFrame $ fail s
2878+#endif
24202879
2421−newEventWithTriggerIO :: (RootTrigger x a -> IO (IO ())) -> IO (Event x a)
2880+instance NotReady (SpiderTimeline x) (SpiderHostFrame x) where
2881+ notReadyUntil _ = pure ()
2882+ notReady = pure ()
2883+
2884+newEventWithTriggerIO :: forall x a. HasSpiderTimeline x => (RootTrigger x a -> IO (IO ())) -> IO (Event x a)
24222885newEventWithTriggerIO f = do
24232886 es <- newFanEventWithTriggerIO $ \Refl -> f
24242887 return $ select es Refl
24252888
2426−newFanEventWithTriggerIO :: GCompare k => (forall a. k a -> RootTrigger x a -> IO (IO ())) -> IO (EventSelector x k)
2889+newFanEventWithTriggerIO :: (HasSpiderTimeline x, GCompare k) => (forall a. k a -> RootTrigger x a -> IO (IO ())) -> IO (EventSelector x k)
24272890newFanEventWithTriggerIO f = do
24282891 occRef <- newIORef DMap.empty
24292892 subscribedRef <- newIORef DMap.empty
@@ -2457,3 +2920,11 @@ instance MonadAtomicRef (SpiderHostFrame x) where
24572920instance PrimMonad (SpiderHostFrame x) where
24582921 type PrimState (SpiderHostFrame x) = PrimState IO
24592922 primitive = SpiderHostFrame . EventM . primitive
2923+
2924+instance NotReady (SpiderTimeline x) (SpiderHost x) where
2925+ notReadyUntil _ = return ()
2926+ notReady = return ()
2927+
2928+instance HasSpiderTimeline x => NotReady (SpiderTimeline x) (PerformEventT (SpiderTimeline x) (SpiderHost x)) where
2929+ notReadyUntil _ = return ()
2930+ notReady = return ()