remarkjs/remark-lint
1
1
Fork 0
mirror of https://github.com/remarkjs/remark-lint.git synced 2024-09-11 19:57:15 +03:00
Code Issues Projects Releases Wiki Activity

Fix table-cell-padding warnings for empty cells

Browse Source 
Previously, the `table-cell-padding` rule messaged about empty cells.
This commit removes those messages, thus ignoring blank cells in
warnings.

Closes GH-104.
This commit is contained in:
Titus Wormer 2016-11-01 15:42:12 +01:00
parent 65b8e56d18
commit 2dc4d61f05
1 changed files with 17 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
packages/remark-lint/lib/rules/table-cell-padding.js
View File

@ -46,6 +46,14 @@
* @example {"name": "invalid.md", "label": "output", "setting": "invalid", "config": {"positionless": true}}
*
* 1:1: Invalid table-cell-padding style `invalid`
*
* @example {"name": "empty.md"}
*
* <!-- Empty cells are always OK. -->
*
* | Alpha | |
* | ----- | ------- |
* | Bravo | Charlie |
*/
'use strict';
@ -92,6 +100,7 @@ function tableCellPadding(ast, file, preferred) {
var contents = file.toString();
var starts = [];
var ends = [];
var cells;
var locations;
var positions;
var style;
@ -156,13 +165,7 @@ function tableCellPadding(ast, file, preferred) {
style = 0;
} else {
style = null;
}
if (preferred === 'padded') {
style = 1;
} else if (preferred === 'compact') {
style = 0;
} else {
positions.some(function (pos) {
/* `some` skips non-existant indices, so
* there's no need to check for `!isNaN`. */
@ -172,17 +175,22 @@ function tableCellPadding(ast, file, preferred) {
});
}
locations = children[0].children.map(function (cell) {
cells = children[0].children;
locations = cells.map(function (cell) {
return start(cell);
}).concat(children[0].children.map(function (cell) {
}).concat(cells.map(function (cell) {
return end(cell);
}));
cells = cells.concat(cells);
type = style === 1 ? 'padded' : 'compact';
warning = 'Cell should be ' + type + ', isn’t';
positions.forEach(function (diff, index) {
if (diff !== style && diff !== undefined && diff !== null) {
var cell = cells[index];
if (cell && cell.children.length && diff !== style && diff !== undefined && diff !== null) {
file.message(warning, locations[index]);
}
});