roc-lang/roc
1
1
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2024-09-20 23:37:56 +03:00
Code Issues Packages Projects Releases Wiki Activity

Put RocCacheDir::Temp behind #[cfg(test)]

Browse Source
This commit is contained in:
Richard Feldman 2022-11-20 20:46:25 -05:00
parent 60f89f75aa
commit 4987fe1656
No known key found for this signature in database
GPG Key ID: F1F21AA5B1D9E43B
2 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
crates/packaging/Cargo.toml
View File

@ -20,8 +20,9 @@ base64-url = "1.4.13"
ureq = "2.5.0"
bumpalo.workspace = true
tempfile.workspace = true
[dev-dependencies]
pretty_assertions = "1.3.0"
indoc = "1.0.7"
indoc = "1.0.7"
tempfile.workspace = true

11
crates/packaging/src/cache.rs
View File

@ -5,7 +5,6 @@ use std::{
use roc_error_macros::internal_error;
use tar::Archive;
use tempfile::TempDir;
use crate::https::{self, PackageMetadata, Problem};
@ -16,10 +15,11 @@ const TARBALL_BUFFER_SIZE: usize = 16 * 1_000_000; // MB
pub enum RocCacheDir<'a> {
/// Normal scenario: reading from the user's cache dir on disk
Persistent(&'a Path),
/// For tests and such; we don't want to write to the real cache during a test!
Temp(&'a TempDir),
/// Pretty much just for build.rs - we should never be downloading anything; blow up if we try!
/// For build.rs and tests where we never want be downloading anything - yell loudly if we try!
Disallowed,
/// For tests only; we don't want to write to the real cache during a test!
#[cfg(test)]
Temp(&'a tempfile::TempDir),
}
/// Accepts either a path to the Roc cache dir, or else a TempDir. If a TempDir, always download
@ -53,13 +53,14 @@ pub fn install_package<'a>(
dest_dir
}
RocCacheDir::Temp(temp_dir) => temp_dir.path().to_path_buf(),
RocCacheDir::Disallowed => {
internal_error!(
"Tried to download a package ({:?}) via RocCacheDir::Disallowed - which was explicitly used in order to disallow downloading packages in the current context!",
url
)
}
#[cfg(test)]
RocCacheDir::Temp(temp_dir) => temp_dir.path().to_path_buf(),
};
// Download the tarball into memory and verify it. Early return if it fails verification,