From 642271d7309d3df85652b3397c9780b650fe4d58 Mon Sep 17 00:00:00 2001 From: Folkert Date: Wed, 16 Jun 2021 23:18:56 +0200 Subject: [PATCH] clippy --- compiler/mono/src/alias_analysis.rs | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/compiler/mono/src/alias_analysis.rs b/compiler/mono/src/alias_analysis.rs index 55f026c594..845b0313c4 100644 --- a/compiler/mono/src/alias_analysis.rs +++ b/compiler/mono/src/alias_analysis.rs @@ -860,7 +860,7 @@ fn expr_spec( Struct(fields) => build_tuple_value(builder, env, block, fields), AccessAtIndex { index, - field_layouts, + field_layouts: _, structure, wrapped, } => { @@ -886,18 +886,14 @@ fn expr_spec( } Wrapped::MultiTagUnion => { // Clearly this is not generally correct, but it should be for our examples - let hacky_is_recursive = - field_layouts.iter().any(|l| l == &Layout::RecursivePointer); + // let hacky_is_recursive = field_layouts.iter().any(|l| l == &Layout::RecursivePointer); + // if hacky_is_recursive { - if hacky_is_recursive { - let result_type = layout_spec(builder, layout)?; - builder.add_unknown_with(block, &[value_id], result_type) - } else { - // what to do, what to do. - let result_type = layout_spec(builder, layout)?; - builder.add_unknown_with(block, &[value_id], result_type) - // builder.add_get_tuple_field(block, value_id, *index as u32) - } + // we don't know what constructor we are at this point, so how can we get a + // field from an enum value? + + let result_type = layout_spec(builder, layout)?; + builder.add_unknown_with(block, &[value_id], result_type) } } }