mirror of
https://github.com/roc-lang/roc.git
synced 2024-11-13 09:49:11 +03:00
improve comments
This commit is contained in:
parent
652dbde26e
commit
a0dc33e796
@ -32,7 +32,7 @@ jobs:
|
||||
run: nix develop -c cargo test --locked --release
|
||||
|
||||
- name: test launching the editor
|
||||
run: cargo test --release --locked editor_launch_test::launch -- --ignored # --ignored to run this test that is ignored for "normal" runs
|
||||
run: cargo test --release --locked editor_launch_test::launch -- --ignored # `--ignored` to run this test that is ignored for "normal" runs
|
||||
|
||||
# we run the llvm wasm tests only on this machine because it is fast and wasm should be cross-target
|
||||
- name: execute llvm wasm tests with --release
|
||||
|
2
.github/workflows/ubuntu_x86_64.yml
vendored
2
.github/workflows/ubuntu_x86_64.yml
vendored
@ -34,7 +34,7 @@ jobs:
|
||||
run: cargo test --locked --release --features with_sound serde --workspace && sccache --show-stats
|
||||
|
||||
- name: test launching the editor
|
||||
run: cargo test --release --locked editor_launch_test::launch -- --ignored # --ignored to run this test that is ignored for "normal" runs
|
||||
run: cargo test --release --locked editor_launch_test::launch -- --ignored # `--ignored` to run this test that is ignored for "normal" runs
|
||||
|
||||
- name: test the dev backend # these tests require an explicit feature flag
|
||||
run: cargo test --locked --release --package test_gen --no-default-features --features gen-dev && sccache --show-stats
|
||||
|
@ -18,6 +18,8 @@ mod editor_launch_test {
|
||||
#[test]
|
||||
fn launch() {
|
||||
let root_dir = root_dir();
|
||||
|
||||
// The editor expects to be run from the root of the repo, so it can find the cli-platform to init a new project folder.
|
||||
env::set_current_dir(&root_dir)
|
||||
.unwrap_or_else(|_| panic!("Failed to set current dir to {:?}", root_dir));
|
||||
|
||||
@ -44,6 +46,7 @@ mod editor_launch_test {
|
||||
Ok(None) => {
|
||||
// The editor is still running as desired, we check if logs are as expected:
|
||||
assert_eq!("Loading file", std::str::from_utf8(&stdout_buffer).unwrap());
|
||||
// Kill the editor, we don't want it to stay open forever.
|
||||
roc_process.kill().unwrap();
|
||||
}
|
||||
Err(e) => panic!("Failed to wait launch editor cli command: {e}"),
|
||||
|
Loading…
Reference in New Issue
Block a user