roc-lang/roc
1
1
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2024-09-22 08:17:40 +03:00
Code Issues Packages Projects Releases Wiki Activity

properly serialize tag names

Browse Source
This commit is contained in:
Folkert 2022-03-21 19:45:21 +01:00
parent 68adeba43c
commit ba5244693a
No known key found for this signature in database
GPG Key ID: 1F17F6FFD112B97C
1 changed files with 64 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

66
compiler/types/src/subs.rs
View File

@ -107,6 +107,12 @@ fn round_to_multiple_of(value: usize, base: usize) -> usize {
(value + (base - 1)) / base * base
}
enum SerializedTagName {
Global(SubsSlice<u8>),
Private(Symbol),
Closure(Symbol),
}
impl Subs {
pub fn serialize(&self, writer: &mut impl std::io::Write) -> std::io::Result<usize> {
let mut written = 0;
@ -118,7 +124,7 @@ impl Subs {
written = Self::serialize_unification_table(&self.utable, writer, written)?;
written = Self::serialize_slice(&self.variables, writer, written)?;
written = Self::serialize_slice(&self.tag_names, writer, written)?;
written = Self::serialize_tag_names(&self.tag_names, writer, written)?;
written = Self::serialize_field_names(&self.field_names, writer, written)?;
written = Self::serialize_slice(&self.record_fields, writer, written)?;
written = Self::serialize_slice(&self.variable_slices, writer, written)?;
@ -177,6 +183,36 @@ impl Subs {
Self::serialize_slice(&buf, writer, written)
}
/// Lowercase can be heap-allocated
fn serialize_tag_names(
tag_names: &[TagName],
writer: &mut impl std::io::Write,
written: usize,
) -> std::io::Result<usize> {
let mut buf: Vec<u8> = Vec::new();
let mut slices: Vec<SerializedTagName> = Vec::new();
for tag_name in tag_names {
let serialized = match tag_name {
TagName::Global(uppercase) => {
let slice = SubsSlice::extend_new(
&mut buf,
uppercase.as_str().as_bytes().iter().copied(),
);
SerializedTagName::Global(slice)
}
TagName::Private(symbol) => SerializedTagName::Private(*symbol),
TagName::Closure(symbol) => SerializedTagName::Closure(*symbol),
};
slices.push(serialized);
}
let written = Self::serialize_slice(&slices, writer, written)?;
Self::serialize_slice(&buf, writer, written)
}
fn serialize_slice<T>(
slice: &[T],
writer: &mut impl std::io::Write,
@ -206,7 +242,7 @@ impl Subs {
let (utable, offset) = Self::deserialize_unification_table(bytes, header.utable, offset);
let (variables, offset) = Self::deserialize_slice(bytes, header.variables, offset);
let (tag_names, offset) = Self::deserialize_slice(bytes, header.tag_names, offset);
let (tag_names, offset) = Self::deserialize_tag_names(bytes, header.tag_names, offset);
let (field_names, offset) =
Self::deserialize_field_names(bytes, header.field_names, offset);
let (record_fields, offset) = Self::deserialize_slice(bytes, header.record_fields, offset);
@ -283,6 +319,32 @@ impl Subs {
(lowercases, offset)
}
fn deserialize_tag_names(bytes: &[u8], length: usize, offset: usize) -> (Vec<TagName>, usize) {
let (slices, mut offset) =
Self::deserialize_slice::<SerializedTagName>(bytes, length, offset);
let string_slice = &bytes[offset..];
let mut tag_names = Vec::with_capacity(length);
for serialized_tag_name in slices {
let tag_name = match serialized_tag_name {
SerializedTagName::Global(subs_slice) => {
let bytes = &string_slice[subs_slice.indices()];
offset += bytes.len();
let string = unsafe { std::str::from_utf8_unchecked(bytes) };
TagName::Global(string.into())
}
SerializedTagName::Private(symbol) => TagName::Private(*symbol),
SerializedTagName::Closure(symbol) => TagName::Closure(*symbol),
};
tag_names.push(tag_name);
}
(tag_names, offset)
}
fn deserialize_slice<T>(bytes: &[u8], length: usize, mut offset: usize) -> (&[T], usize) {
let alignment = std::mem::align_of::<T>();
let size = std::mem::size_of::<T>();