roc-lang/roc
1
1
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2024-11-13 09:49:11 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix stack overflow in reporting

Browse Source
This commit is contained in:
Richard Feldman 2022-07-27 15:22:21 -04:00
parent fa5bd442f8
commit c2865e39ff
No known key found for this signature in database
GPG Key ID: 7E4127D1E4241798
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
crates/reporting/src/report.rs
View File

@ -633,7 +633,12 @@ impl<'a> RocDocAllocator<'a> {
// If the outer region takes more than 1 full screen (~60 lines), only show the inner region
if region.end().line.saturating_sub(region.start().line) > 60 {
return self.region_with_subregion(sub_region, sub_region);
// If the inner region contains the outer region (or if they are the same),
// attempting this will recurse forever, so don't do that! Instead, give up and
// accept that this report will take up more than 1 full screen.
if !sub_region.contains(&region) {
return self.region_with_subregion(sub_region, sub_region);
}
}
// if true, the final line of the snippet will be some ^^^ that point to the region where