From c65d638c1da0f7759ec6b832d2c815d97a166049 Mon Sep 17 00:00:00 2001 From: Anton-4 <17049058+Anton-4@users.noreply.github.com> Date: Sat, 9 Sep 2023 20:02:03 +0200 Subject: [PATCH] Apply Brendan's review suggestions Co-authored-by: Brendan Hansknecht Signed-off-by: Anton-4 <17049058+Anton-4@users.noreply.github.com> --- CONTRIBUTING.md | 2 +- devtools/signing.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 3c7e758972..2162635633 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -53,7 +53,7 @@ This command will generate the documentation in the [`generated-docs`](generated ### Commit signing -All your commits need to be signed [to prevent impersonation](https://dev.to/martiliones/how-i-got-linus-torvalds-in-my-contributors-on-github-3k4g). Check out our guide for commit signing [here](devtools/signing.md). +All your commits need to be signed [to prevent impersonation](https://dev.to/martiliones/how-i-got-linus-torvalds-in-my-contributors-on-github-3k4g). Check out [our guide for commit signing](devtools/signing.md). #### Commit signing on NixOS diff --git a/devtools/signing.md b/devtools/signing.md index 79304d91fd..1297b142de 100644 --- a/devtools/signing.md +++ b/devtools/signing.md @@ -41,7 +41,7 @@ Open the program Kleopatra (installed with gpg4win) and go to Smartcards. You should see your Yubikey there, it should also say something like `failed to find public key locally`. Click the import button, change the available file types at the bottom right to `Any files` and open the `public.key` file you created earlier. Close Kleopatra. -Install the `YubiKey Minidriver for 64-bit systems – Windows Installer` from [here](https://www.yubico.com/support/download/smart-card-drivers-tools/). +Install the [YubiKey Minidriver for 64-bit systems – Windows Installer](https://www.yubico.com/support/download/smart-card-drivers-tools/). Insert your Yubikey and check if it is mentioned in the output of `gpg --card-status` (powershell).