cleanup

.github/workflows/basic_cli_build_release.yml

@@ -1,6 +1,6 @@
-on: [pull_request, workflow_dispatch] # TODO remove pull_request
+on: [workflow_dispatch]
 
-# this cancels runs currently in progress if you start a new one
+# this cancels workflows currently in progress if you start a new one
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: true
@@ -13,7 +13,7 @@ jobs:
       - uses: actions/checkout@v3
 
       # note: moving this step to a bash script will not work, the GITHUB_TOKEN is not passed properly
-      - name: Fetch releases data and save to file. Authorization is used to prevent rate limiting due to shared IP of github's macos ci servers.
+      - name: Fetch releases data and save to file. Authorization is used to prevent rate limiting.
         run: |
           curl --request GET \
           --url https://api.github.com/repos/roc-lang/roc/releases \
@@ -21,13 +21,9 @@ jobs:
           --header 'content-type: application/json' \
           --output roc_releases.json
 
-      - run: cat roc_releases.json
-
       # does a build with the surgical linker and also with the legacy linker
       - run: ./ci/build_basic_cli.sh linux_x86_64 "--linker legacy"
 
-      - run: ls basic-cli/src
-
       - name: Save .rh1, .rm1 and .o file 
         uses: actions/upload-artifact@v3
         with:
@@ -89,7 +85,7 @@ jobs:
         run: ls | grep -v  ci | xargs rm -rf
 
       # note: moving this step to a bash script will not work, the GITHUB_TOKEN is not passed properly
-      - name: Fetch releases data and save to file. Authorization is used to prevent rate limiting due to shared IP of github's macos ci servers.
+      - name: Fetch releases data and save to file. Authorization is used to prevent rate limiting.
         run: |
           curl --request GET \
           --url https://api.github.com/repos/roc-lang/roc/releases \
@@ -110,10 +106,6 @@ jobs:
       - name: Download the previously uploaded files
         uses: actions/download-artifact@v3
 
-      - run: ls
-
-      - run: ls linux-x86_64-files
-
       - run: cp macos-apple-silicon-files/* ./basic-cli/src
       
       - run: cp linux-x86_64-files/* ./basic-cli/src

.github/workflows/benchmarks.yml

@@ -1,4 +1,4 @@
-on: #[pull_request]
+on: [pull_request]
 
 name: Benchmarks
 

.github/workflows/markdown_link_check.yml

@@ -1,5 +1,5 @@
 on:
-  #pull_request:
+  pull_request:
   schedule:
     - cron: '0 9 * * *' # 9=9am utc+0
 

.github/workflows/nix_linux_x86_64.yml

@@ -1,4 +1,4 @@
-on: #[pull_request]
+on: [pull_request]
 
 name: Nix linux x86_64 cargo test
 

.github/workflows/nix_macos_apple_silicon.yml

@@ -1,4 +1,4 @@
-on: #[pull_request]
+on: [pull_request]
 
 name: Nix apple silicon cargo test
 

.github/workflows/nix_macos_x86_64.yml

@@ -1,4 +1,4 @@
-on: #[pull_request]
+on: [pull_request]
 
 name: Nix macOS x86_64 cargo test
 

.github/workflows/spellcheck.yml

@@ -1,4 +1,4 @@
-on: #[pull_request]
+on: [pull_request]
 
 name: SpellCheck
 

.github/workflows/ubuntu_x86_64.yml

@@ -1,4 +1,4 @@
-on: #[pull_request]
+on: [pull_request]
 
 name: CI
 

.github/workflows/windows.yml

@@ -1,4 +1,4 @@
-on: #[pull_request]
+on: [pull_request]
 
 name: Test windows build