git.iko.soy/rowtype-yoga/purescript-native
on golang help sign in
Merge pull request #1909 from purescript/1906-otherwise-guard

Fix true not being treated as an infallible guard

commit44b52667b489fa1689e1ed0757bb7ce479963580 authorGary Burgess <gary.burgess@gmail.com> dateMon 29 Feb 2016, 18:25 (11 years ago) parentf698f2bac58693
1 file changed+5−3
compare with golang
unifiedsplit
src/Language/PureScript/Linter/Exhaustive.hs+5−3
src/Language/PureScript/Linter/Exhaustive.hs+5−3
@@ -201,9 +201,11 @@ isExhaustiveGuard :: Either [(Guard, Expr)] Expr -> Bool
201201isExhaustiveGuard (Left gs) = not . null $ filter (\(g, _) -> isOtherwise g) gs
202202 where
203203 isOtherwise :: Expr -> Bool
204− isOtherwise (TypedValue _ (BooleanLiteral True) _) = True
205− isOtherwise (TypedValue _ (Var (Qualified (Just (ModuleName [ProperName "Prelude"])) (Ident "otherwise"))) _) = True
206− isOtherwise (TypedValue _ (Var (Qualified (Just (ModuleName [ProperName "Data", ProperName "Boolean"])) (Ident "otherwise"))) _) = True
204+ isOtherwise (BooleanLiteral True) = True
205+ isOtherwise (Var (Qualified (Just (ModuleName [ProperName "Prelude"])) (Ident "otherwise"))) = True
206+ isOtherwise (Var (Qualified (Just (ModuleName [ProperName "Data", ProperName "Boolean"])) (Ident "otherwise"))) = True
207+ isOtherwise (TypedValue _ e _) = isOtherwise e
208+ isOtherwise (PositionedValue _ _ e) = isOtherwise e
207209 isOtherwise _ = False
208210isExhaustiveGuard (Right _) = True
209211