6bb8d5e · rowtype-yoga/purescript-native

git.iko.soy/rowtype-yoga/purescript-native

Fix #1889, improve performance by avoiding whitespace operations on large strings

commit6bb8d5e4cd02079d7cedf30e390e690ae2c1b39f authorPhil Freeman <paf31@cantab.net> dateSat 12 Mar 2016, 18:33 (11 years ago) parent3293a7b

2 files changed+12−11

compare with golang

unifiedsplit

src/Language/PureScript/Errors.hs+11−10 src/Language/PureScript/Publish/ErrorsWarnings.hs+1−1

src/Language/PureScript/Errors.hs+11−10

@@ -1181,31 +1181,32 @@ prettyPrintRef (PositionedDeclarationRef _ _ ref) = prettyPrintExport ref

11811181-- Pretty print multiple errors

11821182--

11831183prettyPrintMultipleErrors :: Bool -> MultipleErrors -> String

1184−prettyPrintMultipleErrors full = renderBox . prettyPrintMultipleErrorsBox full

1184+prettyPrintMultipleErrors full = unlines . map renderBox . prettyPrintMultipleErrorsBox full

11851185

11861186-- |

11871187-- Pretty print multiple warnings

11881188--

1189−prettyPrintMultipleWarnings :: Bool -> MultipleErrors -> String

1190−prettyPrintMultipleWarnings full = renderBox . prettyPrintMultipleWarningsBox full

1189+prettyPrintMultipleWarnings :: Bool -> MultipleErrors -> String

1190+prettyPrintMultipleWarnings full = unlines . map renderBox . prettyPrintMultipleWarningsBox full

11911191

11921192-- | Pretty print warnings as a Box

1193−prettyPrintMultipleWarningsBox :: Bool -> MultipleErrors -> Box.Box

1193+prettyPrintMultipleWarningsBox :: Bool -> MultipleErrors -> [Box.Box]

11941194prettyPrintMultipleWarningsBox full = prettyPrintMultipleErrorsWith Warning "Warning found:" "Warning" full

11951195

11961196-- | Pretty print errors as a Box

1197−prettyPrintMultipleErrorsBox :: Bool -> MultipleErrors -> Box.Box

1197+prettyPrintMultipleErrorsBox :: Bool -> MultipleErrors -> [Box.Box]

11981198prettyPrintMultipleErrorsBox full = prettyPrintMultipleErrorsWith Error "Error found:" "Error" full

11991199

1200−prettyPrintMultipleErrorsWith :: Level -> String -> String -> Bool -> MultipleErrors -> Box.Box

1200+prettyPrintMultipleErrorsWith :: Level -> String -> String -> Bool -> MultipleErrors -> [Box.Box]

12011201prettyPrintMultipleErrorsWith level intro _ full (MultipleErrors [e]) =

12021202 let result = prettyPrintSingleError full level True e

1203− in Box.vcat Box.left [ Box.text intro

1204− , result

1205− ]

1203+ in [ Box.vcat Box.left [ Box.text intro

1204+ , result

1205+ ]

1206+ ]

12061207prettyPrintMultipleErrorsWith level _ intro full (MultipleErrors es) =

12071208 let result = map (prettyPrintSingleError full level True) es

1208− in Box.vsep 1 Box.left $ concat $ zipWith withIntro [1 :: Int ..] result

1209+ in concat $ zipWith withIntro [1 :: Int ..] result

12091210 where

12101211 withIntro i err = [ Box.text (intro ++ " " ++ show i ++ " of " ++ show (length es) ++ ":")

12111212 , Box.moveRight 2 err

src/Language/PureScript/Publish/ErrorsWarnings.hs+1−1

@@ -190,7 +190,7 @@ displayUserError e = case e of

190190 CompileError err ->

191191 vcat

192192 [ para "Compile error:"

193− , indented (P.prettyPrintMultipleErrorsBox False err)

193+ , indented (vcat (P.prettyPrintMultipleErrorsBox False err))

194194 ]

195195 DirtyWorkingTree ->

196196 para (