@@ -5,12 +5,12 @@ Please follow the following guidelines:
5- Add at least a test to `examples/passing/` and possibly to `examples/failing`.
5- Add at least a test to `examples/passing/` and possibly to `examples/failing`.
6- Build the binaries and libs with `cabal build`
6- Build the binaries and libs with `cabal build`
7- Install the binaries and libs with `cabal install`.
7- Install the binaries and libs with `cabal install`.
8−- Run `cabal test` to build the test suite.
8+- Run `cabal configure --enable-tests && cabal build && cabal test` to build the test suite.
9−- Run `./execTests.sh` to execute the test suite.
9+- Run `purescript-test-everything` to make sure you haven't broken any core library builds.
10−- Please run `hlint`.
10+- Run `starter-kit` to make sure the starter kit has not been broken.
12If you would like to contribute, please consider the issues in the current milestone first.
12If you would like to contribute, please consider the issues in the current milestone first.
14−Send me (`paf31`) a message if you have any implementation questions, I'm more than happy to talk about the design, and I'm more than willing to redesign parts if necessary.
16Finally, if you have made code changes and would like to be included in the copyright notice in the cabal file, please include that change in your pull request.
14Finally, if you have made code changes and would like to be included in the copyright notice in the cabal file, please include that change in your pull request.
16+To prevent core libraries from getting broken, every change must be reviewed. A pull request will be merged as long as one other team member has verified the changes.