git.iko.soy/rowtype-yoga/purescript-native
on golang help sign in
Fix #812
commita131d5a2916cdb70f4228b3ee2bd49a40513f9ea authorPhil Freeman <paf31@cantab.net> dateMon 2 Feb 2015, 20:00 (12 years ago) parent5061808
2 files changed+19−8
examples/passing/NewtypeWithRecordUpdate.purs+15 src/Language/PureScript/TypeChecker/Types.hs+4−8
examples/passing/NewtypeWithRecordUpdate.pursnew file+15
@@ -0,0 +1,15 @@
1+-- https://github.com/purescript/purescript/issues/812
2+
3+module Main where
4+
5+import Debug.Trace
6+
7+newtype NewType a = NewType (Object a)
8+
9+rec1 :: Object (a :: Number, b :: Number, c:: Number)
10+rec1 = { a: 0, b: 0, c: 0 }
11+
12+rec2 :: NewType (a :: Number, b :: Number, c :: Number)
13+rec2 = NewType (rec1 { a = 1 })
14+
15+main = trace "Done"
src/Language/PureScript/TypeChecker/Types.hs+4−8
@@ -581,18 +581,14 @@ containsTypeSynonyms = everythingOnTypes (||) go where
581581checkProperties :: [(String, Expr)] -> Type -> Bool -> UnifyT Type Check [(String, Expr)]
582582checkProperties ps row lax = let (ts, r') = rowToList row in go ps ts r' where
583583 go [] [] REmpty = return []
584− go [] [] u@(TUnknown _) = do u =?= REmpty
585− return []
584+ go [] [] u@(TUnknown _)
585+ | lax = return []
586+ | otherwise = do u =?= REmpty
587+ return []
586588 go [] [] Skolem{} | lax = return []
587589 go [] ((p, _): _) _ | lax = return []
588590 | otherwise = throwError $ mkErrorStack ("Object does not have property " ++ p) (Just (ExprError (ObjectLiteral ps)))
589591 go ((p,_):_) [] REmpty = throwError $ mkErrorStack ("Property " ++ p ++ " is not present in closed object type " ++ prettyPrintRow row) (Just (ExprError (ObjectLiteral ps)))
590− go ((p,v):ps') [] u@(TUnknown _) = do
591− v'@(TypedValue _ _ ty) <- infer v
592− rest <- fresh
593− u =?= RCons p ty rest
594− ps'' <- go ps' [] rest
595− return $ (p, v') : ps''
596592 go ((p,v):ps') ts r =
597593 case lookup p ts of
598594 Nothing -> do