git.iko.soy/rowtype-yoga/purescript-native
on golang help sign in
Simplify replaceAllTypeVars and handle some more edge cases
d68d1eaPhil Freeman
src/Language/PureScript/Types.hs+21−21
compare with golang
unifiedsplit
@@ -132,29 +132,29 @@ replaceTypeVars v r = replaceAllTypeVars [(v, r)]
132-- Replace named type variables with types
132-- Replace named type variables with types
133--
133--
134replaceAllTypeVars :: [(String, Type)] -> Type -> Type
134replaceAllTypeVars :: [(String, Type)] -> Type -> Type
135−replaceAllTypeVars = replaceAllTypeVars' []
135+replaceAllTypeVars = go []
136 where
136 where
137− replaceAllTypeVars' bound m = go bound
137+
138− where
139− go :: [String] -> Type -> Type
138+ go :: [String] -> [(String, Type)] -> Type -> Type
140− go _ (TypeVar v) =
139+ go _ m (TypeVar v) =
141− case v `lookup` m of
140+ case v `lookup` m of
142− Just r -> r
141+ Just r -> r
143− Nothing -> TypeVar v
142+ Nothing -> TypeVar v
144− go bs (TypeApp t1 t2) = TypeApp (go bs t1) (go bs t2)
143+ go bs m (TypeApp t1 t2) = TypeApp (go bs m t1) (go bs m t2)
145− go bs (SaturatedTypeSynonym name' ts) = SaturatedTypeSynonym name' $ map (go bs) ts
144+ go bs m (SaturatedTypeSynonym name' ts) = SaturatedTypeSynonym name' $ map (go bs m) ts
146− go bs f@(ForAll v t sco) | v `elem` keys = f
145+ go bs m f@(ForAll v t sco) | v `elem` keys = go bs (filter ((/= v) . fst) m) f
147 | v `elem` usedVars =
146 | v `elem` usedVars =
148− let v' = genName v (keys ++ bs ++ usedVars)
147+ let v' = genName v (keys ++ bs ++ usedVars)
149− t' = replaceAllTypeVars' bs [(v, TypeVar v')] t
148+ t' = go bs [(v, TypeVar v')] t
150− in ForAll v' (go (v' : bs) t') sco
149+ in ForAll v' (go (v' : bs) m t') sco
151− | otherwise = ForAll v (go (v : bs) t) sco
150+ | otherwise = ForAll v (go (v : bs) m t) sco
152− where
151+ where
153− keys = map fst m
152+ keys = map fst m
154− usedVars = concatMap (usedTypeVariables . snd) m
153+ usedVars = concatMap (usedTypeVariables . snd) m
155− go bs (ConstrainedType cs t) = ConstrainedType (map (second $ map (go bs)) cs) (go bs t)
154+ go bs m (ConstrainedType cs t) = ConstrainedType (map (second $ map (go bs m)) cs) (go bs m t)
156− go bs (RCons name' t r) = RCons name' (go bs t) (go bs r)
155+ go bs m (RCons name' t r) = RCons name' (go bs m t) (go bs m r)
157− go _ ty = ty
156+ go _ _ ty = ty
157+
158 genName orig inUse = try 0
158 genName orig inUse = try 0
159 where
159 where
160 try :: Integer -> String
160 try :: Integer -> String