git.iko.soy/rowtype-yoga/purescript-native
on golang help sign in
Merge pull request #683 from purescript/682
ed31dc0Phil Freeman
examples/passing/ObjectUpdate2.pursnew file+14
@@ -0,0 +1,14 @@
1+module Main where
2+
3+type X r = { | r }
4+
5+foreign import x "var x = {};" :: forall r. X r
6+
7+blah :: forall r. X r -> X r
8+blah x = x
9+
10+test = blah x
11+ { baz = "blah"
12+ }
13+
14+main = Debug.Trace.trace "Done"
src/Language/PureScript/TypeChecker/Types.hs+4−3
@@ -1018,10 +1018,11 @@ check' (TypeClassDictionaryConstructorApp name ps) t = do
1018 return $ TypedValue True (TypeClassDictionaryConstructorApp name ps') t
1018 return $ TypedValue True (TypeClassDictionaryConstructorApp name ps') t
1019check' (ObjectUpdate obj ps) t@(TypeApp o row) | o == tyObject = do
1019check' (ObjectUpdate obj ps) t@(TypeApp o row) | o == tyObject = do
1020 ensureNoDuplicateProperties ps
1020 ensureNoDuplicateProperties ps
1021− us <- zip (map fst ps) <$> replicateM (length ps) fresh
1021+ -- We need to be careful to avoid duplicate labels here.
1022+ -- We check _obj_ agaist the type _t_ with the types in _ps_ replaced with unknowns.
1022 let (propsToCheck, rest) = rowToList row
1023 let (propsToCheck, rest) = rowToList row
1023− propsToRemove = map fst ps
1024− remainingProps = filter (\(p, _) -> p `notElem` propsToRemove) propsToCheck
1024+ (removedProps, remainingProps) = partition (\(p, _) -> p `elem` map fst ps) propsToCheck
1025+ us <- zip (map fst removedProps) <$> replicateM (length ps) fresh
1025 obj' <- check obj (TypeApp tyObject (rowFromList (us ++ remainingProps, rest)))
1026 obj' <- check obj (TypeApp tyObject (rowFromList (us ++ remainingProps, rest)))
1026 ps' <- checkProperties ps row True
1027 ps' <- checkProperties ps row True
1027 return $ TypedValue True (ObjectUpdate obj' ps') t
1028 return $ TypedValue True (ObjectUpdate obj' ps') t