@@ -41,6 +41,11 @@ import qualified Data.Aeson.Types as A
41-- The Show instance for PSString produces a string literal which would
41-- The Show instance for PSString produces a string literal which would
42-- represent the same data were it inserted into a PureScript source file.
42-- represent the same data were it inserted into a PureScript source file.
44+-- Because JSON parsers vary wildly in terms of how they deal with lone
45+-- surrogates in JSON strings, the ToJSON instance for PSString produces JSON
46+-- strings where that would be safe (i.e. when there are no lone surrogates),
47+-- and arrays of UTF-16 code units (integers) otherwise.
44newtype PSString = PSString { toUTF16CodeUnits :: [Word16] }
49newtype PSString = PSString { toUTF16CodeUnits :: [Word16] }
45 deriving (Eq, Ord, Monoid)
50 deriving (Eq, Ord, Monoid)
@@ -117,12 +122,17 @@ instance IsString PSString where
117 encodeUTF16 c = [toWord $ fromEnum c]
122 encodeUTF16 c = [toWord $ fromEnum c]
119instance A.ToJSON PSString where
124instance A.ToJSON PSString where
126+ case decodeString str of
127+ Just t -> A.toJSON t
120− toJSON = A.toJSON . toUTF16CodeUnits
128+ Nothing -> A.toJSON (toUTF16CodeUnits str)
122instance A.FromJSON PSString where
130instance A.FromJSON PSString where
123− parseJSON a = currentParser <|> backwardsCompat
131+ parseJSON a = jsonString <|> arrayOfCodeUnits
133+ jsonString = fromString <$> A.parseJSON a
125− currentParser = PSString <$> parseArrayOfCodeUnits a
135+ arrayOfCodeUnits = PSString <$> parseArrayOfCodeUnits a
127 parseArrayOfCodeUnits :: A.Value -> A.Parser [Word16]
137 parseArrayOfCodeUnits :: A.Value -> A.Parser [Word16]
128 parseArrayOfCodeUnits = A.withArray "array of UTF-16 code units" (traverse parseCodeUnit . V.toList)
138 parseArrayOfCodeUnits = A.withArray "array of UTF-16 code units" (traverse parseCodeUnit . V.toList)
@@ -130,10 +140,6 @@ instance A.FromJSON PSString where
130 parseCodeUnit :: A.Value -> A.Parser Word16
140 parseCodeUnit :: A.Value -> A.Parser Word16
131 parseCodeUnit b = A.withScientific "two-byte non-negative integer" (maybe (A.typeMismatch "" b) return . toBoundedInteger) b
141 parseCodeUnit b = A.withScientific "two-byte non-negative integer" (maybe (A.typeMismatch "" b) return . toBoundedInteger) b
133− -- For backwards compatibility: this allows us to parse JSON produced by
134− -- 0.10.4 or earlier
135− backwardsCompat = fromString <$> A.parseJSON a
138-- Pretty print a PSString, using JavaScript escape sequences. Intended for
144-- Pretty print a PSString, using JavaScript escape sequences. Intended for
139-- use in compiled JS output.
145-- use in compiled JS output.