rui314/mold
1
1
Fork 0
mirror of https://github.com/rui314/mold.git synced 2024-09-11 21:17:28 +03:00
Code Issues Projects Releases Wiki Activity

[Mach-O] Use binary search in find_subsection()

Browse Source 
When using ld64.mold to link clang for Mach-O, most of the time was
spent in the first call to find_subsection() from
parse_compact_unwind(). Changing its linear search to a binary search
cut an 18-second link time down to about 3 seconds.

Signed-off-by: James Widman <james.widman@gmail.com>
This commit is contained in:
James Widman 2022-10-25 18:07:25 -07:00
parent 0763dd5639
commit 13eda8051a
1 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
macho/input-files.cc
View File

@ -418,11 +418,18 @@ LoadCommand *ObjectFile<E>::find_load_command(Context<E> &ctx, u32 type) {
template <typename E>
Subsection<E> *
ObjectFile<E>::find_subsection(Context<E> &ctx, u32 secidx, u32 addr) {
Subsection<E> *ret = nullptr;
for (Subsection<E> *subsec : subsections)
if (subsec->isec.secidx == secidx && subsec->input_addr <= addr)
ret = subsec;
return ret;
assert(subsections.size() > 0);
auto begin = subsections.begin();
auto end = subsections.end();
auto upper = std::upper_bound(begin, end, addr,
[](u32 addr, Subsection<E> *subsec) { return addr < subsec->input_addr; });
if (upper == begin)
return nullptr;
Subsection<E> *subsec = *(upper - 1);
if (subsec->isec.secidx == secidx)
return subsec;
return nullptr;
}
template <typename E>