rui314/mold
1
1
Fork 0
mirror of https://github.com/rui314/mold.git synced 2024-09-19 17:07:29 +03:00
Code Issues Projects Releases Wiki Activity

[ELF][LTO] Restart the linker when get_symbols_v2 is called for the first time

Browse Source 
Previously, we detected if a given linker plugin supports get_symbols_v3
or not and restart the process if only get_symbols_v2 is supported.

Now, mold restart itself wehn get_symbols_v2 is called for the first time,
eliminating the need for the feature detection.

https://github.com/rui314/mold/issues/454
This commit is contained in:
Rui Ueyama 2022-05-04 10:36:44 +08:00
parent cde4b0fb45
commit 38f2b965db
1 changed files with 7 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
elf/lto.cc
View File

@ -347,6 +347,13 @@ template <typename E>
static PluginStatus
get_symbols_v2(const void *handle, int nsyms, PluginSymbol *psyms) {
LOG << "get_symbols_v2\n";
static std::once_flag flag;
std::call_once(flag, [&] {
if (!gctx<E>->arg.lto_pass2)
restart_process(*gctx<E>);
});
return get_symbols<E>(handle, nsyms, psyms, true);
}
@ -523,13 +530,6 @@ static bool is_llvm(Context<E> &ctx) {
return ctx.arg.plugin.ends_with("LLVMgold.so");
}
// Returns true if a given linker plugin supports the get_symbols_v3 API.
// Currently, we simply assume that LLVM supports it and GCC does not.
template <typename E>
static bool suppots_v3_api(Context<E> &ctx) {
return is_llvm(ctx);
}
template <typename E>
ObjectFile<E> *read_lto_object(Context<E> &ctx, MappedFile<Context<E>> *mf) {
LOG << "read_lto_object: " << mf->name << "\n";
@ -608,9 +608,6 @@ template <typename E>
std::vector<ObjectFile<E> *> do_lto(Context<E> &ctx) {
Timer t(ctx, "do_lto");
if (!ctx.arg.lto_pass2 && !suppots_v3_api(ctx))
restart_process(ctx);
assert(phase == 1);
phase = 2;