rui314/mold
1
1
Fork 0
mirror of https://github.com/rui314/mold.git synced 2024-08-18 01:10:32 +03:00
Code Issues Projects Releases Wiki Activity

Do not write relocation addends for RISC-V

Browse Source 
Probably due to a bug in glibc, static PIE binaries crash on startup
in some environment.

Fixes https://github.com/rui314/mold/issues/1291
This commit is contained in:
Rui Ueyama 2024-06-27 12:48:33 +09:00
parent 35d67a3fab
commit 3dbe2ac704
1 changed files with 16 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
elf/cmdline.cc
View File

@ -542,17 +542,21 @@ std::vector<std::string> parse_nonpositional_args(Context<E> &ctx) {
if constexpr (is_riscv<E>)
ctx.arg.discard_locals = true;
// It looks like the SPARC's dynamic linker takes both RELA's r_addend
// and the value at the relocated place. So we don't want to write
// values to relocated places.
if constexpr (is_sparc<E>)
// We generally don't need to write addends to relocated places if the
// relocation type is RELA because RELA records contain addends.
// However, there are too much code that wrongly assumes that addends
// are written to both RELA records and relocated places, so we write
// addends to relocated places by default. There are a few exceptions:
//
// - It looks like the SPARC's dynamic linker takes both RELA's r_addend
// and the value at the relocated place. So we don't want to write
// values to relocated places.
//
// - Static PIE binaries crash on startup in some RISC-V environment if
// we write addends to relocated places.
if constexpr (is_sparc<E> || is_riscv<E>)
ctx.arg.apply_dynamic_relocs = false;
// For some reason, SH4 always stores relocation addends to
// relocated places even though its RELA.
if constexpr (is_sh4<E>)
ctx.arg.apply_dynamic_relocs = true;
auto read_arg = [&](std::string name) {
for (const std::string &opt : add_dashes(name)) {
if (args[0] == opt) {
@ -1360,6 +1364,9 @@ std::vector<std::string> parse_nonpositional_args(Context<E> &ctx) {
Fatal(ctx) << "-auxiliary may not be used without -shared";
}
// Even though SH4 is RELA, addends in its relocation records are always
// zero, and actual addends are written to relocated places. So we need
// to handle it as an exception.
if constexpr (!E::is_rela || is_sh4<E>)
if (!ctx.arg.apply_dynamic_relocs)
Fatal(ctx) << "--no-apply-dynamic-relocs may not be used on "