rui314/mold
1
1
Fork 0
mirror of https://github.com/rui314/mold.git synced 2024-11-13 09:39:13 +03:00
Code Issues Projects Releases Wiki Activity

[Mach-O] Report errors for remaining undefined symbols

Browse Source
This commit is contained in:
Rui Ueyama 2021-10-27 21:46:57 +09:00
parent 04fcb66580
commit 7236d14650
3 changed files with 26 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
macho/input-sections.cc
View File

@ -104,6 +104,11 @@ void InputSection::scan_relocations(Context &ctx) {
void Subsection::apply_reloc(Context &ctx, u8 *buf) {
for (const Relocation &rel : std::span(isec.rels).subspan(rel_offset, nrels)) {
if (rel.sym && !rel.sym->file) {
Error(ctx) << "undefined symbol: " << isec.file << ": " << *rel.sym;
continue;
}
u32 *loc = (u32 *)(buf + rel.offset);
#define S (rel.sym ? rel.sym->get_addr(ctx) : \

1
macho/main.cc
View File

@ -205,6 +205,7 @@ int main(int argc, char **argv) {
seg->copy_buf(ctx);
ctx.output_file->close(ctx);
ctx.checkpoint();
return 0;
}

20
test/macho/missing-error.sh Executable file
View File

@ -0,0 +1,20 @@
#!/bin/bash
set -e
cd $(dirname $0)
mold=`pwd`/../../ld64.mold
echo -n "Testing $(basename -s .sh $0) ... "
t=$(pwd)/../../out/test/elf/$(basename -s .sh $0)
mkdir -p $t
cat <<EOF | cc -o $t/a.o -c -xc -
int foo();
int main() {
foo();
}
EOF
! clang -fuse-ld=$mold -o $t/exe $t/a.o 2> $t/log || false
grep -q 'undefined symbol: .*\.o: _foo' $t/log
echo OK