rui314/mold
1
1
Fork 0
mirror of https://github.com/rui314/mold.git synced 2024-11-12 23:48:51 +03:00
Code Issues Projects Releases Wiki Activity

Fix name lookup for section symbols when st_shndx == SHN_XINDEX

Browse Source 
When the section-header index has the escape value `SHN_XINDEX`, the
actual index must be looked up in the separate `SHT_SYMTAB_SHNDX` table.
Trying to use `SHN_XINDEX` (= 0xffff) as an index results in an
out-of-bounds read. The error can be observed when running the
`x86_64_many-sections.sh` test on RHEL 8 or 9 (but not on Fedora,
because there the assembler doesn't emit section symbols).

Instead of using `st_shndx` directly, call the pre-existing helper
method `get_shndx()` to get the correct behaviour.

Signed-off-by: Christoph Erhardt <github@sicherha.de>
This commit is contained in:
Christoph Erhardt 2022-10-22 14:41:42 +02:00
parent 288cd5b400
commit f8cb32e59a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
elf/input-files.cc
View File

@ -439,7 +439,7 @@ void ObjectFile<E>::initialize_symbols(Context<E> &ctx) {
std::string_view name;
if (esym.st_type == STT_SECTION)
name = this->shstrtab.data() + this->elf_sections[esym.st_shndx].sh_name;
name = this->shstrtab.data() + this->elf_sections[get_shndx(esym)].sh_name;
else
name = this->symbol_strtab.data() + esym.st_name;