rustwasm/wasm-bindgen
1
0
Fork 0
mirror of https://github.com/rustwasm/wasm-bindgen.git synced 2024-11-27 10:52:39 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #1490 from RReverser/deprecate-custom-try-from

Browse Source 
Recommend to use dyn_ref on funcs and strings
This commit is contained in:
Alex Crichton 2019-04-29 09:08:00 -05:00 committed by GitHub
commit 60bb68649b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
crates/js-sys/src/lib.rs
View File

@ -1089,6 +1089,7 @@ impl Function {
///
/// If this JS value is not an instance of a function then this returns
/// `None`.
#[deprecated(note = "recommended to use dyn_ref instead which is now equivalent")]
pub fn try_from(val: &JsValue) -> Option<&Function> {
val.dyn_ref()
}
@ -3819,6 +3820,7 @@ impl JsString {
///
/// If this JS value is not an instance of a string then this returns
/// `None`.
#[deprecated(note = "recommended to use dyn_ref instead which is now equivalent")]
pub fn try_from(val: &JsValue) -> Option<&JsString> {
val.dyn_ref()
}