rustwasm/wasm-bindgen
1
0
Fork 0
mirror of https://github.com/rustwasm/wasm-bindgen.git synced 2024-12-27 20:15:14 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

js-sys: Add extends attributes for js_sys::Float64Array

Browse Source 
address review comments

add review comments
This commit is contained in:
Sendil Kumar 2018-08-14 19:39:02 +02:00
parent d9fbc48daa
commit af9ecac296
2 changed files with 3 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
crates/js-sys/src/lib.rs
View File

@ -683,7 +683,6 @@ extern "C" {
// Float32Array
#[wasm_bindgen]
extern "C" {
// TODO Uncomment this once TypedArray is added:
#[wasm_bindgen(extends = Object)]
#[derive(Clone, Debug)]
pub type Float32Array;
@ -737,8 +736,7 @@ extern "C" {
// Float64Array
#[wasm_bindgen]
extern "C" {
// TODO Uncomment this once TypedArray is added:
// #[wasm_bindgen(extends = Object, extends = TypedArray)]
#[wasm_bindgen(extends = Object)]
#[derive(Clone, Debug)]
pub type Float64Array;

16
crates/js-sys/tests/wasm/TypedArray.rs
View File

@ -13,6 +13,7 @@ macro_rules! each {
$m!(Int16Array);
$m!(Int32Array);
$m!(Float32Array);
$m!(Float64Array);
)
}
@ -20,6 +21,7 @@ macro_rules! test_inheritence {
($arr:ident) => ({
let arr = $arr::new(&JsValue::undefined());
assert!(arr.is_instance_of::<$arr>());
let _: &Object = arr.as_ref();
assert!(arr.is_instance_of::<Object>());
})
}
@ -28,20 +30,6 @@ fn inheritence() {
each!(test_inheritence);
}
macro_rules! each {
($m:ident) => (
$m!(Uint8Array);
$m!(Uint8ClampedArray);
$m!(Uint16Array);
$m!(Uint32Array);
$m!(Int8Array);
$m!(Int16Array);
$m!(Int32Array);
$m!(Float32Array);
$m!(Float64Array);
)
}
macro_rules! test_undefined {
($arr:ident) => ({
let arr = $arr::new(&JsValue::undefined());