mirror of
https://github.com/rustwasm/wasm-bindgen.git
synced 2024-12-15 21:02:10 +03:00
bb7271aa43
This commit employs the strategy described in #908 to apply a non-breaking change to fix WebIDL to be compatible with all browsers, including Safari. The problem here is that `BaseAudioContext` and `AudioScheduledSourceNode` are not types in Safari, but they are types in Firefox/Chrome. The fix here was to move the contents of these two interfaces into mixins, and then include the mixins in all classes which inherit from these two classes. That should have the same effect as defining the methods inherently on the original interface. Additionally a special `[RustDeprecated]` attribute to WebIDL was added to signify interfaces this has happened to. Currently it's directly tailored towards this case of "this intermediate class doesn't exist in all browsers", but we may want to refine and extend the deprecation message over time. Although it's possible we could do this as a breaking change to `web-sys` I'm hoping that we can do this as a non-breaking change for now and then eventually on the next breaking release batch all these changes together, deleting the intermediate classes. This is also hopefully a good trial run for how stable web-sys can be when it's actually stable! cc #897 cc #908
42 lines
1.2 KiB
Plaintext
Vendored
42 lines
1.2 KiB
Plaintext
Vendored
/* -*- Mode: IDL; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this file,
|
|
* You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*
|
|
* The origin of this IDL file is
|
|
* https://webaudio.github.io/web-audio-api/
|
|
*
|
|
* Copyright © 2012 W3C® (MIT, ERCIM, Keio), All Rights Reserved. W3C
|
|
* liability, trademark and document use rules apply.
|
|
*/
|
|
|
|
enum OscillatorType {
|
|
"sine",
|
|
"square",
|
|
"sawtooth",
|
|
"triangle",
|
|
"custom"
|
|
};
|
|
|
|
dictionary OscillatorOptions : AudioNodeOptions {
|
|
OscillatorType type = "sine";
|
|
float frequency = 440;
|
|
float detune = 0;
|
|
PeriodicWave periodicWave;
|
|
};
|
|
|
|
[Pref="dom.webaudio.enabled",
|
|
Constructor(BaseAudioContext context, optional OscillatorOptions options)]
|
|
interface OscillatorNode : AudioScheduledSourceNode {
|
|
|
|
[SetterThrows]
|
|
attribute OscillatorType type;
|
|
|
|
readonly attribute AudioParam frequency; // in Hertz
|
|
readonly attribute AudioParam detune; // in Cents
|
|
|
|
void setPeriodicWave(PeriodicWave periodicWave);
|
|
};
|
|
|
|
OscillatorNode includes rustAudioScheduledSourceNode;
|