mirror of
https://github.com/ryantm/nixpkgs-update.git
synced 2024-09-11 13:57:20 +03:00
Cleanup whitespace in PR comment function
Since we have an interpolated string, let's try to keep the newlines inside the interpolation region, rather than attached to the variables -- particularly when it's multiple newlines. This makes it easier to read/visualize what the PR description will look like. Updated and trimmed some excessive whitespace. This doesn't cause a rendering diff on the UI, but makes the raw output cleaner.
This commit is contained in:
parent
dc1f1ff36c
commit
0b0e919328
@ -391,16 +391,16 @@ prMessage updateEnv isBroken metaDescription metaHomepage metaChangelog rewriteM
|
||||
rewriteMsgsLine = foldl (\ms m -> ms <> T.pack "\n- " <> m) "\n###### Updates performed" rewriteMsgs
|
||||
maintainersCc =
|
||||
if not (T.null maintainers)
|
||||
then "\n\ncc " <> maintainers <> " for testing."
|
||||
then "cc " <> maintainers <> " for testing."
|
||||
else ""
|
||||
releaseUrlMessage =
|
||||
if releaseUrl == T.empty
|
||||
then ""
|
||||
else "\n- [Release on GitHub](" <> releaseUrl <> ")"
|
||||
else "- [Release on GitHub](" <> releaseUrl <> ")"
|
||||
compareUrlMessage =
|
||||
if compareUrl == T.empty
|
||||
then ""
|
||||
else "\n- [Compare changes on GitHub](" <> compareUrl <> ")\n\n"
|
||||
else "- [Compare changes on GitHub](" <> compareUrl <> ")"
|
||||
nixpkgsReviewSection =
|
||||
if nixpkgsReviewMsg == T.empty
|
||||
then "NixPkgs review skipped"
|
||||
@ -431,6 +431,7 @@ prMessage updateEnv isBroken metaDescription metaHomepage metaChangelog rewriteM
|
||||
###### To inspect upstream changes
|
||||
|
||||
$releaseUrlMessage
|
||||
|
||||
$compareUrlMessage
|
||||
|
||||
###### Impact
|
||||
|
@ -14,12 +14,10 @@ meta.changelog for foobar is: "https://foobar-homepage.com/changelog/v1.2.3"
|
||||
|
||||
###### To inspect upstream changes
|
||||
|
||||
|
||||
- [Release on GitHub](https://github.com/foobar/releases)
|
||||
|
||||
- [Compare changes on GitHub](https://github.com/foobar/compare)
|
||||
|
||||
|
||||
###### Impact
|
||||
|
||||
<details>
|
||||
@ -86,6 +84,4 @@ nixpkgs-review comment body
|
||||
|
||||
###### Maintainer pings
|
||||
|
||||
|
||||
|
||||
cc @maintainer1 for testing.
|
||||
|
@ -14,12 +14,10 @@ meta.changelog for foobar is: "https://foobar-homepage.com/changelog/v1.2.3"
|
||||
|
||||
###### To inspect upstream changes
|
||||
|
||||
|
||||
- [Release on GitHub](https://github.com/foobar/releases)
|
||||
|
||||
- [Compare changes on GitHub](https://github.com/foobar/compare)
|
||||
|
||||
|
||||
###### Impact
|
||||
|
||||
<details>
|
||||
@ -79,6 +77,4 @@ NixPkgs review skipped
|
||||
|
||||
###### Maintainer pings
|
||||
|
||||
|
||||
|
||||
cc @maintainer1 for testing.
|
||||
|
Loading…
Reference in New Issue
Block a user