2de68b5..master · sc-build

src/Control/HasGithubStatus.hs+1

since splitsnapshots

unifiedsplit

@@ -11,3 +11,4 @@ class HasGithubStatus m where

11 schedulePendingStatus :: WithLog env Message m => Name Owner -> Name Repo -> Name Commit -> m ()

12 scheduleTestedStatus :: WithLog env Message m => TestResult -> Name Owner -> Name Repo -> Name Commit -> m ()

13 scheduleFailedStatus :: WithLog env Message m => String -> Name Owner -> Name Repo -> Name Commit -> m ()

14+ deadlineHasPassedStatus :: WithLog env Message m => Name Owner -> Name Repo -> Name Commit -> m ()

src/Control/Task/Scheduler.hs+4−1

@@ -21,6 +21,7 @@ import Data.Word

21import GHC.TypeLits

22import Server.Schema

23import Squeal.PostgreSQL

24+import UnliftIO.Exception

24

25

25scheduleTask ::

26scheduleTask ::

26 (StaticPQ m, WithLog env Message m, Task t s, MonadUnliftIO m) =>

27 (StaticPQ m, WithLog env Message m, Task t s, MonadUnliftIO m) =>

@@ -66,7 +67,9 @@ instance

66 <> e

67 <> e

67 A.Success t -> do

68 A.Success t -> do

68 logInfo . T.pack $ "running task " <> task <> " with " <> show t <> " created at " <> show initialStartTime

69 logInfo . T.pack $ "running task " <> task <> " with " <> show t <> " created at " <> show initialStartTime

69− r <- performTask @t @ts @m t

70+ r <- performTask @t @ts @m t `catchAny` \e -> do

71+ logError . T.pack . displayException $ e

72+ return Failure

70 when (r == Failure) $ logWarning . T.pack $ "Task " <> task <> " failed"

73 when (r == Failure) $ logWarning . T.pack $ "Task " <> task <> " failed"

71 case r of

74 case r of

72 Success -> completeTaskQuery t

75 Success -> completeTaskQuery t

src/Control/Task/Scheduler/Query.hs+6−1

@@ -41,6 +41,7 @@ scheduleTaskQuery task = do

41 :* Set (param @2) `as` #payload

42 :* Default `as` #creation_time

43 :* Default `as` #started

44+ :* Default `as` #failures

44 )

45 )

45 ( OnConflict

46 ( OnConflict

46 (OnConstraint #pk_task_payload)

47 (OnConstraint #pk_task_payload)

@@ -87,6 +88,7 @@ rescheduleTaskQuery payload = do

87 #tasks

88 #tasks

88 ( Default `as` #creation_time

89 ( Default `as` #creation_time

89 :* Default `as` #started

90 :* Default `as` #started

91+ :* Set (#failures + 1) `as` #failures

90 )

92 )

91 (param @1 .== #task .&& param @2 .== #payload)

93 (param @1 .== #task .&& param @2 .== #payload)

92 dbWrite (const $ return ()) $

94 dbWrite (const $ return ()) $

@@ -101,7 +103,7 @@ pickTasksQuery ::

101 Word64 ->

103 Word64 ->

102 m [PickedTask]

104 m [PickedTask]

103pickTasksQuery tasks limitCount = do

105pickTasksQuery tasks limitCount = do

104− logDebug "reading tasks"

106+ logDebug $ "reading tasks " <> T.unwords (T.pack <$> tasks)

105 let query :: Query_ Schema () PickedTask

107 let query :: Query_ Schema () PickedTask

106 query =

108 query =

107 select_

109 select_

@@ -112,7 +114,10 @@ pickTasksQuery tasks limitCount = do

112 ( from (table #tasks)

114 ( from (table #tasks)

113 & where_ (#task `in_` (literal <$> tasks))

115 & where_ (#task `in_` (literal <$> tasks))

114 & where_ (not_ . notNull $ #started)

116 & where_ (not_ . notNull $ #started)

117+ & where_ (#failures .< 20)

118+ & orderBy [#creation_time & Asc]

115 & limit limitCount

119 & limit limitCount

120+ & orderBy [#creation_time & Desc]

116 )

121 )

117 startedMan :: Manipulation_ Schema (String, Jsonb Value) ()

122 startedMan :: Manipulation_ Schema (String, Jsonb Value) ()

118 startedMan =

123 startedMan =

src/Data/Submission.hs+1

@@ -29,6 +29,7 @@ data SubmissionStatus

29 = SubmissionRun TestResult

30 | SubmissionFailed String

31 | BuildScheduled

32+ | PastDeadline

32 deriving (Generic, FromJSON, ToJSON, Eq, Show)

33 deriving (Generic, FromJSON, ToJSON, Eq, Show)

33

34

34newtype TestResult

35newtype TestResult

src/Server.hs+49−19

@@ -30,6 +30,7 @@ import Data.Submission.Query

30import Data.Tasks.Build

31import Data.Tasks.StatusUpdate

32import qualified Data.Text as T

33+import Data.Time.Clock

33import Data.Yaml

34import Data.Yaml

34import GHC.Generics

35import GHC.Generics

35import GitHub hiding (Accept)

36import GitHub hiding (Accept)

@@ -49,7 +50,6 @@ import Server.Config

49import Server.Html

50import Server.Html

50import Server.Schema

51import Server.Schema

51import Squeal.PostgreSQL

52import Squeal.PostgreSQL

52−import System.IO

53import Text.Blaze.Html

54import UnliftIO.Exception (catch, displayException, handleAny, throwIO, try)

55

@@ -75,14 +75,18 @@ type API =

75 :> Post '[HTML] Markup

76 :<|> "results" :> Capture "task name" String :> Get '[CSV, HTML] [Score]

77

78−webhookInstallation :: MonadIO m => RepoWebhookEvent -> ((), InstallationEvent) -> m ()

78+webhookInstallation :: WithLog env Message m => RepoWebhookEvent -> ((), InstallationEvent) -> m ()

79webhookInstallation _ ((), ev) =

80− liftIO $ do

80+ logInfo . T.pack . show $ ev

81− print ev

82− hFlush stdout

83

81

84webhookPushEvent ::

82webhookPushEvent ::

83+ ( StaticPQ m,

85− (StaticPQ m, MonadReader (ServerData m) m, MonadUnliftIO m, HasTasks m, MonadError ServerError m) =>

84+ MonadReader (ServerData m) m,

85+ MonadUnliftIO m,

86+ HasTasks m,

87+ MonadError ServerError m,

88+ WithLog env Message m

89+ ) =>

86 RepoWebhookEvent ->

90 RepoWebhookEvent ->

87 ((), PushEvent) ->

91 ((), PushEvent) ->

88 m ()

92 m ()

@@ -100,18 +104,28 @@ webhookPushEvent _ ((), ev) = do

100 M.takeWhileAntitone (repoName >) tasks

104 M.takeWhileAntitone (repoName >) tasks

101 case task of

105 case task of

102 Just (name, TaskConfig {..}) | T.take (T.length name) repoName == name -> do

106 Just (name, TaskConfig {..}) | T.take (T.length name) repoName == name -> do

107+ nowTime <- liftIO getCurrentTime

108+ if nowTime > deadline

109+ then do

110+ deadlineHasPassedStatus (N owner) (N repoName) (N sha)

111+ createSubmission $

112+ Submission

113+ user

114+ (T.unpack fullRepoName)

115+ (T.unpack name)

116+ (T.unpack sha)

117+ (Jsonb PastDeadline)

118+ else do

103− schedulePendingStatus (N owner) (N repoName) (N sha)

119+ schedulePendingStatus (N owner) (N repoName) (N sha)

104− createSubmission $

120+ createSubmission $

105− Submission

121+ Submission

106− user

122+ user

107− (T.unpack fullRepoName)

123+ (T.unpack fullRepoName)

108− (T.unpack name)

124+ (T.unpack name)

109− (T.unpack sha)

125+ (T.unpack sha)

110− (Jsonb BuildScheduled)

126+ (Jsonb BuildScheduled)

111− scheduleTask $ Build prebuild dockerfile (N owner) (N repoName) (N sha) timeoutMinutes

127+ scheduleTask $ Build prebuild dockerfile (N owner) (N repoName) (N sha) timeoutMinutes

112− liftIO $ do

128+ logInfo . T.pack . show $ ev

113− print ev

114− hFlush stdout

115 _ -> return ()

129 _ -> return ()

116

130

117retestSubmission ::

131retestSubmission ::

@@ -315,6 +329,21 @@ instance (MonadReader (ServerData m) m, StaticPQ m, MonadUnliftIO m) => HasGithu

315 newStatusContext = Just c

329 newStatusContext = Just c

316 }

330 }

317 scheduleTask status

331 scheduleTask status

332+ deadlineHasPassedStatus nOwner@(N owner) nRepo@(N repo) nCommit@(N sha) = do

333+ h <- asks baseUrl

334+ c <- asks context

335+ let status =

336+ StatusUpdate

337+ nOwner

338+ nRepo

339+ nCommit

340+ NewStatus

341+ { newStatusState = StatusError,

342+ newStatusTargetUrl = Just . URL $ h <> "/submission/" <> owner <> "/" <> repo <> "/" <> sha,

343+ newStatusDescription = Just "The deadline has passed ⏰",

344+ newStatusContext = Just c

345+ }

346+ scheduleTask status

318

347

319instance (MonadReader (ServerData n) m) => HasDockerInfo m where

348instance (MonadReader (ServerData n) m) => HasDockerInfo m where

320 getDockerUrl = asks dockerUrl

349 getDockerUrl = asks dockerUrl

@@ -325,7 +354,8 @@ data TaskConfig

325 = TaskConfig

354 = TaskConfig

326 { prebuild :: String,

355 { prebuild :: String,

327 dockerfile :: String,

356 dockerfile :: String,

328− timeoutMinutes :: Int

357+ timeoutMinutes :: Int,

358+ deadline :: UTCTime

329 }

359 }

330 deriving stock (Show, Eq, Generic)

360 deriving stock (Show, Eq, Generic)

331 deriving anyclass (FromJSON, ToJSON)

361 deriving anyclass (FromJSON, ToJSON)

src/Server/Html.hs+2

@@ -61,6 +61,8 @@ getSubmissionR user repo sha' = do

61 H.table $ flip M.foldMapWithKey tests $ \testName testPassed -> H.tr $ do

62 (H.td H.! A.align "right") . H.p $ toHtml testName

63 H.td $ if testPassed then "✅" else "❌"

64+ Jsonb PastDeadline ->

65+ H.h3 "This was submitted after the deadline ⏰"

64 return . docTypeHtml $ do

66 return . docTypeHtml $ do

65 H.head $ do

67 H.head $ do

66 H.title $ toHtml titleText

68 H.title $ toHtml titleText

src/Server/Schema.hs+3−1

@@ -6,13 +6,15 @@ module Server.Schema

6where

7

8import Server.Schema.V1

9+import Server.Schema.V2

9import Squeal.PostgreSQL

10import Squeal.PostgreSQL

10

11

11type StaticPQ m = MonadPQ Schema m

12type StaticPQ m = MonadPQ Schema m

12

13

13−type Schema = SchemaV1

14+type Schema = SchemaV2

14

15

15migration :: AlignedList (Migration (Terminally PQ IO)) (Public '[]) Schema

16migration :: AlignedList (Migration (Terminally PQ IO)) (Public '[]) Schema

16migration =

17migration =

17 pureMigration schemaMigrationV1

18 pureMigration schemaMigrationV1

19+ :>> pureMigration schemaMigrationV2

18 :>> Done

20 :>> Done

src/Server/Schema/V2.hsnew file+46

@@ -0,0 +1,46 @@

1+module Server.Schema.V2

2+ ( SchemaV2,

3+ schemaMigrationV2,

4+ )

5+where

6+

7+import Data.Aeson

8+import Data.Int

9+import Data.Submission

10+import Data.Text (Text)

11+import Data.Time

12+import Server.Schema.V1

13+import Squeal.PostgreSQL

14+

15+type SchemaV2 =

16+ Public

17+ '[ "tasks"

18+ ::: 'Table

19+ ( '[ "pk_task_payload" :=> 'PrimaryKey '["task", "payload"]

20+ ]

21+ :=> '[ "task" ::: 'NoDef :=> 'NotNull (PG Text),

22+ "payload" ::: 'NoDef :=> 'NotNull (PG (Jsonb Value)),

23+ "creation_time" ::: 'Def :=> 'NotNull (PG UTCTime),

24+ "started" ::: 'Def :=> 'NotNull (PG Bool),

25+ "failures" ::: 'Def :=> 'NotNull (PG Int32)

26+ ]

27+ ),

28+ "submissions"

29+ ::: 'Table

30+ ( '["pk_submission_repo_full_name_sha" :=> 'PrimaryKey '["repo_full_name", "sha"]]

31+ :=> '[ "user_name" ::: 'NoDef :=> 'NotNull (PG String),

32+ "repo_full_name" ::: 'NoDef :=> 'NotNull (PG String),

33+ "problem" ::: 'NoDef :=> 'NotNull (PG String),

34+ "sha" ::: 'NoDef :=> 'NotNull (PG String),

35+ "status" ::: 'NoDef :=> 'NotNull (PG (Jsonb SubmissionStatus))

36+ ]

37+ )

38+ ]

39+

40+schemaMigrationV2 :: Migration Definition SchemaV1 SchemaV2

41+schemaMigrationV2 =

42+ Migration

43+ { name = "v2",

44+ up = alterTable #tasks (addColumn #failures (default_ 0 $ notNullable int)),

45+ down = alterTable #tasks (dropColumn #failures)

46+ }