@@ -5,7 +5,7 @@ PYTHONPATH=$BASE_DIR
55SEARX_DIR="$BASE_DIR/searx"
66ACTION=$1
77
8−cd $BASE_DIR
8+cd "$BASE_DIR"
99
1010update_packages() {
1111 pip install -r "$BASE_DIR/requirements.txt"
@@ -18,6 +18,7 @@ update_dev_packages() {
1818
1919install_geckodriver() {
2020 echo '[!] Checking geckodriver'
21+ # TODO : check the current geckodriver version
2122 set -e
2223 geckodriver -V 2>1 > /dev/null || NOTFOUND=1
2324 set +e
@@ -35,24 +36,24 @@ install_geckodriver() {
3536 esac
3637 GECKODRIVER_URL="https://github.com/mozilla/geckodriver/releases/download/$GECKODRIVER_VERSION/geckodriver-$GECKODRIVER_VERSION-$ARCH.tar.gz";
3738
38− if [ -z $1 ]; then
39+ if [ -z "$1" ]; then
3940 if [ -z "$VIRTUAL_ENV" ]; then
4041 echo "geckodriver can't be installed because VIRTUAL_ENV is not set, you should download it from\n $GECKODRIVER_URL"
4142 exit
4243 else
43− GECKODRIVER_DIR=$VIRTUAL_ENV/bin
44+ GECKODRIVER_DIR="$VIRTUAL_ENV/bin"
4445 fi
4546 else
46− GECKODRIVER_DIR=$1
47− mkdir -p $GECKODRIVER_DIR
47+ GECKODRIVER_DIR="$1"
48+ mkdir -p "$GECKODRIVER_DIR"
4849 fi
4950
50− echo "Installing $GECKODRIVER_DIR from\n $GECKODRIVER_URL"
51+ echo "Installing $GECKODRIVER_DIR/geckodriver from\n $GECKODRIVER_URL"
5152
5253 FILE=`mktemp`
53− wget "$GECKODRIVER_URL" -qO $FILE && tar xz -C $GECKODRIVER_DIR -f $FILE geckodriver
54+ wget "$GECKODRIVER_URL" -qO $FILE && tar xz -C "$GECKODRIVER_DIR" -f $FILE geckodriver
5455 rm $FILE
55− chmod 777 $GECKODRIVER_DIR/geckodriver
56+ chmod 777 "$GECKODRIVER_DIR/geckodriver"
5657}
5758
5859pep8_check() {
@@ -153,4 +154,4 @@ Commands
153154
154155[ "$(command -V "$ACTION" | grep ' function$')" = "" ] \
155156 && help "action not found" \
156− || $ACTION $2
157+ || $ACTION "$2"