on master help sign in
Comparison to None should be 'if cond is not None:'
4261a41stepshal
utils/fetch_currencies.py+2−2
@@ -84,7 +84,7 @@ def parse_currency(data):
84 labels = data.get('labels', {})
84 labels = data.get('labels', {})
85 for language in languages:
85 for language in languages:
86 name = labels.get(language, {}).get('value', None)
86 name = labels.get(language, {}).get('value', None)
87− if name != None:
87+ if name is not None:
88 add_currency_name(name, iso4217)
88 add_currency_name(name, iso4217)
89 add_currency_label(name, iso4217, language)
89 add_currency_label(name, iso4217, language)
90
90
@@ -126,7 +126,7 @@ def wdq_query(query):
126 jsonresponse = json.loads(htmlresponse.content)
126 jsonresponse = json.loads(htmlresponse.content)
127 qlist = map(add_q, jsonresponse.get('items', {}))
127 qlist = map(add_q, jsonresponse.get('items', {}))
128 error = jsonresponse.get('status', {}).get('error', None)
128 error = jsonresponse.get('status', {}).get('error', None)
129− if error != None and error != 'OK':
129+ if error is not None and error != 'OK':
130 print "error for query '" + query + "' :" + error
130 print "error for query '" + query + "' :" + error
131
131
132 fetch_data_batch(qlist)
132 fetch_data_batch(qlist)