on master help sign in
[fix] urls merge in infobox (#593)

TODO: merge attributes

commitc2e40142879fcb08291471f0306a793fce63c124 authormarc <a01200356@itesm.mx> dateFri 24 Jun 2016, 00:38 (10 years ago) parenta0a1284
2 files changed+25−21
searx/engines/wikipedia.py+1−2 searx/results.py+24−19
searx/engines/wikipedia.py+1−2
@@ -99,9 +99,8 @@ def response(resp):
9999 return []
100100
101101 # link to wikipedia article
102− # parenthesis are not quoted to make infobox mergeable with wikidata's
103102 wikipedia_link = url_lang(resp.search_params['language']) \
104− + 'wiki/' + quote(title.replace(' ', '_').encode('utf8')).replace('%28', '(').replace('%29', ')')
103+ + 'wiki/' + quote(title.replace(' ', '_').encode('utf8'))
105104
106105 results.append({'url': wikipedia_link, 'title': title})
107106
searx/results.py+24−19
@@ -18,7 +18,17 @@ def result_content_len(content):
1818
1919
2020def compare_urls(url_a, url_b):
21− if url_a.netloc != url_b.netloc or url_a.query != url_b.query:
21+ # ignore www. in comparison
22+ if url_a.netloc.startswith('www.'):
23+ host_a = url_a.netloc.replace('www.', '', 1)
24+ else:
25+ host_a = url_a.netloc
26+ if url_b.netloc.startswith('www.'):
27+ host_b = url_b.netloc.replace('www.', '', 1)
28+ else:
29+ host_b = url_b.netloc
30+
31+ if host_a != host_b or url_a.query != url_b.query:
2232 return False
2333
2434 # remove / from the end of the url if required
@@ -37,15 +47,17 @@ def merge_two_infoboxes(infobox1, infobox2):
3747 urls1 = infobox1.get('urls', None)
3848 if urls1 is None:
3949 urls1 = []
40− infobox1['urls'] = urls1
4150
42− urlSet = set()
43− for url in infobox1.get('urls', []):
44− urlSet.add(url.get('url', None))
51+ for url2 in infobox2.get('urls', []):
52+ unique_url = True
53+ for url1 in infobox1.get('urls', []):
54+ if compare_urls(urlparse(url1.get('url', '')), urlparse(url2.get('url', ''))):
55+ unique_url = False
56+ break
57+ if unique_url:
58+ urls1.append(url2)
4559
46− for url in infobox2.get('urls', []):
47− if url.get('url', None) not in urlSet:
48− urls1.append(url)
60+ infobox1['urls'] = urls1
4961
5062 if 'img_src' in infobox2:
5163 img1 = infobox1.get('img_src', None)
@@ -97,7 +109,6 @@ class ResultContainer(object):
97109 self.results = defaultdict(list)
98110 self._merged_results = []
99111 self.infoboxes = []
100− self._infobox_ids = {}
101112 self.suggestions = set()
102113 self.answers = set()
103114 self._number_of_results = []
@@ -138,14 +149,13 @@ class ResultContainer(object):
138149 add_infobox = True
139150 infobox_id = infobox.get('id', None)
140151 if infobox_id is not None:
141− existingIndex = self._infobox_ids.get(infobox_id, None)
142− if existingIndex is not None:
143− merge_two_infoboxes(self.infoboxes[existingIndex], infobox)
144− add_infobox = False
152+ for existingIndex in self.infoboxes:
153+ if compare_urls(urlparse(existingIndex.get('id', '')), urlparse(infobox_id)):
154+ merge_two_infoboxes(existingIndex, infobox)
155+ add_infobox = False
145156
146157 if add_infobox:
147158 self.infoboxes.append(infobox)
148− self._infobox_ids[infobox_id] = len(self.infoboxes) - 1
149159
150160 def _merge_result(self, result, position):
151161 result['parsed_url'] = urlparse(result['url'])
@@ -155,11 +165,6 @@ class ResultContainer(object):
155165 result['parsed_url'] = result['parsed_url']._replace(scheme="http")
156166 result['url'] = result['parsed_url'].geturl()
157167
158− result['host'] = result['parsed_url'].netloc
159−
160− if result['host'].startswith('www.'):
161− result['host'] = result['host'].replace('www.', '', 1)
162−
163168 result['engines'] = [result['engine']]
164169
165170 # strip multiple spaces and cariage returns from content