@@ -11,7 +11,7 @@ from searx.preferences import Preferences
1111# FIXME: does not fix "!music !soundcloud", because the categories are 'none' and 'music'
1212def deduplicate_engineref_list(engineref_list: List[EngineRef]) -> List[EngineRef]:
1313 engineref_dict = {q.category + '|' + q.name: q for q in engineref_list}
14− return engineref_dict.values()
14+ return list(engineref_dict.values())
1515
1616
1717def validate_engineref_list(engineref_list: List[EngineRef], preferences: Preferences)\
@@ -82,7 +82,7 @@ def parse_safesearch(preferences: Preferences, form: Dict[str, str]) -> int:
8282 return query_safesearch
8383
8484
85−def parse_time_range(form: Dict[str, str]) -> str:
85+def parse_time_range(form: Dict[str, str]) -> Optional[str]:
8686 query_time_range = form.get('time_range')
8787 # check time_range
8888 query_time_range = None if query_time_range in ('', 'None') else query_time_range
@@ -92,16 +92,16 @@ def parse_time_range(form: Dict[str, str]) -> str:
9292
9393
9494def parse_timeout(form: Dict[str, str], raw_text_query: RawTextQuery) -> Optional[float]:
95− query_timeout = raw_text_query.timeout_limit
96− if query_timeout is None and 'timeout_limit' in form:
97− raw_time_limit = form.get('timeout_limit')
98− if raw_time_limit in ['None', '']:
99− return None
100− else:
101− try:
102− return float(raw_time_limit)
103− except ValueError:
104− raise SearxParameterException('timeout_limit', raw_time_limit)
95+ timeout_limit = raw_text_query.timeout_limit
96+ if timeout_limit is None:
97+ timeout_limit = form.get('timeout_limit')
98+
99+ if timeout_limit is None or timeout_limit in ['None', '']:
100+ return None
101+ try:
102+ return float(timeout_limit)
103+ except ValueError:
104+ raise SearxParameterException('timeout_limit', timeout_limit)
105105
106106
107107def parse_specific(raw_text_query: RawTextQuery) -> Tuple[List[EngineRef], List[str]]:
@@ -134,7 +134,7 @@ def parse_category_form(query_categories: List[str], name: str, value: str) -> N
134134 query_categories.remove(category)
135135
136136
137−def get_selected_categories(preferences: Preferences, form: Dict[str, str]) -> List[str]:
137+def get_selected_categories(preferences: Preferences, form: Optional[Dict[str, str]]) -> List[str]:
138138 selected_categories = []
139139
140140 if form is not None:
@@ -157,37 +157,49 @@ def get_selected_categories(preferences: Preferences, form: Dict[str, str]) -> L
157157 return selected_categories
158158
159159
160+def get_engineref_from_category_list(category_list: List[str], disabled_engines: List[str]) -> List[EngineRef]:
161+ result = []
162+ for categ in category_list:
163+ result.extend(EngineRef(engine.name, categ)
164+ for engine in categories[categ]
165+ if (engine.name, categ) not in disabled_engines)
166+ return result
167+
168+
160169def parse_generic(preferences: Preferences, form: Dict[str, str], disabled_engines: List[str])\
161170 -> Tuple[List[EngineRef], List[str]]:
162171 query_engineref_list = []
163172 query_categories = []
164173
165174 # set categories/engines
166− load_default_categories = True
175+ explicit_engine_list = False
167176 for pd_name, pd in form.items():
168177 if pd_name == 'engines':
169178 pd_engines = [EngineRef(engine_name, engines[engine_name].categories[0])
170179 for engine_name in map(str.strip, pd.split(',')) if engine_name in engines]
171180 if pd_engines:
172181 query_engineref_list.extend(pd_engines)
173− load_default_categories = False
182+ explicit_engine_list = True
174183 else:
175184 parse_category_form(query_categories, pd_name, pd)
176185
177− if not load_default_categories:
178− if not query_categories:
179− query_categories = list(set(engine['category']
180− for engine in query_engineref_list))
186+ if explicit_engine_list:
187+ # explicit list of engines with the "engines" parameter in the form
188+ if query_categories:
189+ # add engines from referenced by the "categories" parameter and the "category_*"" parameters
190+ query_engineref_list.extend(get_engineref_from_category_list(query_categories, disabled_engines))
191+ # get categories from the query_engineref_list
192+ query_categories = list(set(engine.category for engine in query_engineref_list))
181193 else:
194+ # no "engines" parameters in the form
182195 if not query_categories:
196+ # and neither "categories" parameter nor "category_*"" parameters in the form
197+ # -> get the categories from the preferences (the cookies or the settings)
183198 query_categories = get_selected_categories(preferences, None)
184199
185200 # using all engines for that search, which are
186201 # declared under the specific categories
187− for categ in query_categories:
188− query_engineref_list.extend(EngineRef(engine.name, categ)
189− for engine in categories[categ]
190− if (engine.name, categ) not in disabled_engines)
202+ query_engineref_list.extend(get_engineref_from_category_list(query_categories, disabled_engines))
191203
192204 return query_engineref_list, query_categories
193205