on master help sign in
[mod] searx.search.EngineRef: remove from_bang parameter
eda8934Alexandre Flament
searx/query.py+2−2
@@ -125,12 +125,12 @@ class RawTextQuery:
125 searx_query_part = True
125 searx_query_part = True
126 engine_name = engine_shortcuts[prefix]
126 engine_name = engine_shortcuts[prefix]
127 if engine_name in engines:
127 if engine_name in engines:
128− self.enginerefs.append(EngineRef(engine_name, 'none', True))
128+ self.enginerefs.append(EngineRef(engine_name, 'none'))
129
129
130 # check if prefix is equal with engine name
130 # check if prefix is equal with engine name
131 elif prefix in engines:
131 elif prefix in engines:
132 searx_query_part = True
132 searx_query_part = True
133− self.enginerefs.append(EngineRef(prefix, 'none', True))
133+ self.enginerefs.append(EngineRef(prefix, 'none'))
134
134
135 # check if prefix is equal with categorie name
135 # check if prefix is equal with categorie name
136 elif prefix in categories:
136 elif prefix in categories:
searx/search/__init__.py+4−5
@@ -52,18 +52,17 @@ def initialize(settings_engines=None):
52
52
53class EngineRef:
53class EngineRef:
54
54
55− __slots__ = 'name', 'category', 'from_bang'
55+ __slots__ = 'name', 'category'
56
56
57− def __init__(self, name: str, category: str, from_bang: bool=False):
57+ def __init__(self, name: str, category: str):
58 self.name = name
58 self.name = name
59 self.category = category
59 self.category = category
60− self.from_bang = from_bang
61
60
62 def __repr__(self):
61 def __repr__(self):
63− return "EngineRef({!r}, {!r}, {!r})".format(self.name, self.category, self.from_bang)
62+ return "EngineRef({!r}, {!r})".format(self.name, self.category)
64
63
65 def __eq__(self, other):
64 def __eq__(self, other):
66− return self.name == other.name and self.category == other.category and self.from_bang == other.from_bang
65+ return self.name == other.name and self.category == other.category
67
66
68
67
69class SearchQuery:
68class SearchQuery:
searx/webadapter.py+1−12
@@ -109,17 +109,6 @@ def parse_timeout(form: Dict[str, str], raw_text_query: RawTextQuery) -> Optiona
109 raise SearxParameterException('timeout_limit', timeout_limit)
109 raise SearxParameterException('timeout_limit', timeout_limit)
110
110
111
111
112−def parse_specific(raw_text_query: RawTextQuery) -> Tuple[List[EngineRef], List[str]]:
113− query_engineref_list = raw_text_query.enginerefs
114− additional_categories = set()
115− for engineref in raw_text_query.enginerefs:
116− if engineref.from_bang:
117− additional_categories.add('none')
118− else:
119− additional_categories.add(engineref.category)
120− return query_engineref_list
121−
122−
123def parse_category_form(query_categories: List[str], name: str, value: str) -> None:
112def parse_category_form(query_categories: List[str], name: str, value: str) -> None:
124 if name == 'categories':
113 if name == 'categories':
125 query_categories.extend(categ for categ in map(str.strip, value.split(',')) if categ in categories)
114 query_categories.extend(categ for categ in map(str.strip, value.split(',')) if categ in categories)
@@ -232,7 +221,7 @@ def get_search_query_from_webapp(preferences: Preferences, form: Dict[str, str])
232 if not is_locked('categories') and raw_text_query.enginerefs and raw_text_query.specific:
221 if not is_locked('categories') and raw_text_query.enginerefs and raw_text_query.specific:
233 # if engines are calculated from query,
222 # if engines are calculated from query,
234 # set categories by using that informations
223 # set categories by using that informations
235− query_engineref_list = parse_specific(raw_text_query)
224+ query_engineref_list = raw_text_query.enginerefs
236 else:
225 else:
237 # otherwise, using defined categories to
226 # otherwise, using defined categories to
238 # calculate which engines should be used
227 # calculate which engines should be used
tests/unit/test_search.py+4−4
@@ -23,13 +23,13 @@ TEST_ENGINES = [
23class SearchQueryTestCase(SearxTestCase):
23class SearchQueryTestCase(SearxTestCase):
24
24
25 def test_repr(self):
25 def test_repr(self):
26− s = SearchQuery('test', [EngineRef('bing', 'general', False)], 'all', 0, 1, '1', 5.0, 'g')
26+ s = SearchQuery('test', [EngineRef('bing', 'general')], 'all', 0, 1, '1', 5.0, 'g')
27 self.assertEqual(repr(s),
27 self.assertEqual(repr(s),
28− "SearchQuery('test', [EngineRef('bing', 'general', False)], 'all', 0, 1, '1', 5.0, 'g')") # noqa
28+ "SearchQuery('test', [EngineRef('bing', 'general')], 'all', 0, 1, '1', 5.0, 'g')") # noqa
29
29
30 def test_eq(self):
30 def test_eq(self):
31− s = SearchQuery('test', [EngineRef('bing', 'general', False)], 'all', 0, 1, None, None, None)
31+ s = SearchQuery('test', [EngineRef('bing', 'general')], 'all', 0, 1, None, None, None)
32− t = SearchQuery('test', [EngineRef('google', 'general', False)], 'all', 0, 1, None, None, None)
32+ t = SearchQuery('test', [EngineRef('google', 'general')], 'all', 0, 1, None, None, None)
33 self.assertEqual(s, s)
33 self.assertEqual(s, s)
34 self.assertNotEqual(s, t)
34 self.assertNotEqual(s, t)
35
35
tests/unit/test_standalone_searx.py+1−1
@@ -101,7 +101,7 @@ class StandaloneSearx(SearxTestCase):
101 args = sas.parse_argument(['rain', ])
101 args = sas.parse_argument(['rain', ])
102 search_q = sas.get_search_query(args)
102 search_q = sas.get_search_query(args)
103 self.assertTrue(search_q)
103 self.assertTrue(search_q)
104− self.assertEqual(search_q, SearchQuery('rain', [EngineRef('engine1', 'general', False)],
104+ self.assertEqual(search_q, SearchQuery('rain', [EngineRef('engine1', 'general')],
105 'all', 0, 1, None, None, None))
105 'all', 0, 1, None, None, None))
106
106
107 def test_no_parsed_url(self):
107 def test_no_parsed_url(self):