@@ -1,24 +1,36 @@
1−{-# LANGUAGE MultiWayIf #-}
2module Servant.QuickCheck.Internal.Predicates where
1module Servant.QuickCheck.Internal.Predicates where
4−import Control.Monad
3+import Control.Exception (catch, throw)
4+import Control.Monad (liftM2, unless, when)
5import Data.Aeson (Object, decode)
5import Data.Aeson (Object, decode)
6−import Data.Bifunctor (Bifunctor (..))
6+import Data.Bifunctor (first)
7import qualified Data.ByteString as SBS
7import qualified Data.ByteString as SBS
8import qualified Data.ByteString.Char8 as SBSC
8import qualified Data.ByteString.Char8 as SBSC
9import qualified Data.ByteString.Lazy as LBS
9import qualified Data.ByteString.Lazy as LBS
10−import Data.CaseInsensitive (mk)
10+import Data.CaseInsensitive (foldCase, foldedCase, mk)
11import Data.Either (isRight)
11import Data.Either (isRight)
12import Data.List.Split (wordsBy)
12import Data.List.Split (wordsBy)
13−import Data.Maybe (isJust)
13+import Data.Maybe (fromMaybe, isJust)
14−import Data.Monoid ((<>))
14+import Data.Semigroup (Semigroup (..))
15−import Data.Text (Text)
15+import qualified Data.Text as T
16+import Data.Time (UTCTime, defaultTimeLocale, parseTimeM,
16import GHC.Generics (Generic)
18import GHC.Generics (Generic)
17import Network.HTTP.Client (Manager, Request, Response, httpLbs,
19import Network.HTTP.Client (Manager, Request, Response, httpLbs,
20+ method, parseRequest, requestHeaders,
18− method, responseBody, responseHeaders,
21+ responseBody, responseHeaders,
19 responseStatus)
22 responseStatus)
23+import Network.HTTP.Media (matchAccept)
20import Network.HTTP.Types (methodGet, methodHead, parseMethod,
24import Network.HTTP.Types (methodGet, methodHead, parseMethod,
25+ renderStdMethod, status100, status200,
26+ status201, status300, status401,
21− status401, renderStdMethod, status405, status500)
27+ status405, status500)
29+import System.Clock (Clock (Monotonic), diffTimeSpec,
32+import Servant.QuickCheck.Internal.ErrorTypes
23-- | [__Best Practice__]
35-- | [__Best Practice__]
@@ -27,8 +39,27 @@ import Network.HTTP.Types (methodGet, methodHead, parseMethod,
27-- indication of how to proceed or what went wrong.
39-- indication of how to proceed or what went wrong.
29-- This function checks that the response code is not 500.
41-- This function checks that the response code is not 500.
30−not500 :: ResponsePredicate Text Bool
44+not500 :: ResponsePredicate
31−not500 = ResponsePredicate "not500" (\resp -> not $ responseStatus resp == status500)
45+not500 = ResponsePredicate $ \resp ->
46+ when (responseStatus resp == status500) $ throw $ PredicateFailure "not500" Nothing resp
50+-- This function checks that the response from the server does not take longer
51+-- than the specified number of nanoseconds.
54+notLongerThan :: Integer -> RequestPredicate
55+notLongerThan maxAllowed
56+ = RequestPredicate $ \req mgr -> do
57+ start <- getTime Monotonic
58+ resp <- httpLbs req mgr
59+ end <- getTime Monotonic
60+ when (toNanoSecs (end `diffTimeSpec` start) > maxAllowed) $
61+ throw $ PredicateFailure "notLongerThan" (Just req) resp
33-- | [__Best Practice__]
64-- | [__Best Practice__]
@@ -49,30 +80,90 @@ not500 = ResponsePredicate "not500" (\resp -> not $ responseStatus resp == statu
50-- * JSON Grammar: <https://tools.ietf.org/html/rfc7159#section-2 RFC 7159 Section 2>
81-- * JSON Grammar: <https://tools.ietf.org/html/rfc7159#section-2 RFC 7159 Section 2>
51-- * JSON Grammar: <https://tools.ietf.org/html/rfc4627#section-2 RFC 4627 Section 2>
82-- * JSON Grammar: <https://tools.ietf.org/html/rfc4627#section-2 RFC 4627 Section 2>
52−onlyJsonObjects :: ResponsePredicate Text Bool
85+onlyJsonObjects :: ResponsePredicate
53onlyJsonObjects
86onlyJsonObjects
87+ = ResponsePredicate (\resp -> do
88+ case lookup "content-type" (first foldedCase <$> responseHeaders resp) of
90+ Just ctype -> when ("application/json" `SBS.isPrefixOf` ctype) $ do
54− = ResponsePredicate "onlyJsonObjects" (\resp -> case decode (responseBody resp) of
91+ case (decode (responseBody resp) :: Maybe Object) of
55− Nothing -> False
92+ Nothing -> throw $ PredicateFailure "onlyJsonObjects" Nothing resp
56− Just (_ :: Object) -> True)
93+ Just _ -> return ())
58−{-
95+-- | __Optional__
59−-- | When creating a new resource, it is good practice to provide a @Location@
97+-- When creating a new resource, it is good practice to provide a @Location@
60-- header with a link to the created resource.
98-- header with a link to the created resource.
62-- This function checks that every @201 Created@ response contains a @Location@
100-- This function checks that every @201 Created@ response contains a @Location@
63-- header, and that the link in it responds with a 2XX response code to @GET@
101-- header, and that the link in it responds with a 2XX response code to @GET@
64-- requests.
102-- requests.
104+-- This is considered optional because other means of linking to the resource
105+-- (e.g. via the response body) are also acceptable; linking to the resource in
106+-- some way is considered best practice.
110+-- * 201 Created: <https://tools.ietf.org/html/rfc7231#section-6.3.2 RFC 7231 Section 6.3.2>
66−-- References: <RFC 7231, Section 6.3.2 https://tools.ietf.org/html/rfc7231#section-6.3.2>
111+-- * Location header: <https://tools.ietf.org/html/rfc7231#section-7.1.2 RFC 7231 Section 7.1.2>
67−createContainsValidLocation :: ResponsePredicate Text Bool
114+createContainsValidLocation :: RequestPredicate
68createContainsValidLocation
115createContainsValidLocation
116+ = RequestPredicate $ \req mgr -> do
69− = ResponsePredicate "createContainsValidLocation" (\resp ->
117+ let n = "createContainsValidLocation"
70−
118+ resp <- httpLbs req mgr
119+ if responseStatus resp == status201
120+ then case lookup "Location" $ responseHeaders resp of
121+ Nothing -> throw $ PredicateFailure n (Just req) resp
122+ Just l -> case parseRequest $ SBSC.unpack l of
123+ Nothing -> throw $ PredicateFailure n (Just req) resp
125+ resp2 <- httpLbs x mgr
126+ status2XX (Just req) resp2 n
127+ return [resp, resp2]
132+-- The @Last-Modified@ header represents the time a resource was last
133+-- modified. It is used to drive caching and conditional requests.
135+-- When using this mechanism, the server adds the @Last-Modified@ header to
136+-- responses. Clients may then make requests with the @If-Modified-Since@
137+-- header to conditionally request resources. If the resource has not
138+-- changed since that date, the server responds with a status code of 304
139+-- (@Not Modified@) without a response body.
141+-- The @Last-Modified@ header can also be used in conjunction with the
142+-- @If-Unmodified-Since@ header to drive optimistic concurrency.
144+-- The @Last-Modified@ date must be in RFC 822 format.
148+-- * 304 Not Modified: <https://tools.ietf.org/html/rfc7232#section-4.1 RFC 7232 Section 4.1>
149+-- * Last-Modified header: <https://tools.ietf.org/html/rfc7232#section-2.2 RFC 7232 Section 2.2>
150+-- * If-Modified-Since header: <https://tools.ietf.org/html/rfc7232#section-3.3 RFC 7232 Section 3.3>
151+-- * If-Unmodified-Since header: <https://tools.ietf.org/html/rfc7232#section-3.4 RFC 7232 Section 3.4>
152+-- * Date format: <https://tools.ietf.org/html/rfc2616#section-3.3 RFC 2616 Section 3.3>
71−getsHaveLastModifiedHeader :: ResponsePredicate Text Bool
155+getsHaveLastModifiedHeader :: RequestPredicate
72getsHaveLastModifiedHeader
156getsHaveLastModifiedHeader
73− = ResponsePredicate "getsHaveLastModifiedHeader" (\resp ->
157+ = RequestPredicate $ \req mgr ->
158+ if (method req == methodGet)
160+ resp <- httpLbs req mgr
161+ unless (hasValidHeader "Last-Modified" isRFC822Date resp) $ do
162+ throw $ PredicateFailure "getsHaveLastModifiedHeader" (Just req) resp
77-- | [__RFC Compliance__]
168-- | [__RFC Compliance__]
@@ -84,55 +175,61 @@ getsHaveLastModifiedHeader
84-- This function checks that every @405 Method Not Allowed@ response contains
175-- This function checks that every @405 Method Not Allowed@ response contains
85-- an @Allow@ header with a list of standard HTTP methods.
176-- an @Allow@ header with a list of standard HTTP methods.
178+-- Note that 'servant' itself does not currently set the @Allow@ headers.
87-- __References__:
180-- __References__:
89-- * @Allow@ header: <https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html RFC 2616 Section 14.7>
182-- * @Allow@ header: <https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html RFC 2616 Section 14.7>
90-- * Status 405: <https://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html RFC 2616 Section 10.4.6>
183-- * Status 405: <https://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html RFC 2616 Section 10.4.6>
184+-- * Servant Allow header issue: <https://github.com/haskell-servant/servant/issues/489 Issue #489>
91−notAllowedContainsAllowHeader :: RequestPredicate Text Bool
187+notAllowedContainsAllowHeader :: RequestPredicate
92notAllowedContainsAllowHeader
188notAllowedContainsAllowHeader
93− = RequestPredicate
189+ = RequestPredicate $ \req mgr -> do
95− , reqResps = \req mgr -> mapM (flip httpLbs mgr)
96− [ req { method = renderStdMethod m }
190+ let reqs = [ req { method = renderStdMethod m } | m <- [minBound .. maxBound]
97− | m <- [minBound .. maxBound ]
98− , renderStdMethod m /= method req ]
191+ , renderStdMethod m /= method req ]
99− , reqPred = pred'
192+ resp <- mapM (flip httpLbs mgr) reqs
194+ case filter pred' (zip reqs resp) of
195+ (x:_) -> throw $ PredicateFailure "notAllowedContainsAllowHeader" (Just $ fst x) (snd x)
102− name = "notAllowedContainsAllowHeader"
103− pred' = ResponsePredicate name (\resp ->
104− if responseStatus resp == status405
198+ pred' (_, resp) = responseStatus resp == status405 && not (hasValidHeader "Allow" go resp)
105− then hasValidHeader "Allow" go resp
108 go x = all (\y -> isRight $ parseMethod $ SBSC.pack y)
200 go x = all (\y -> isRight $ parseMethod $ SBSC.pack y)
109 $ wordsBy (`elem` (", " :: [Char])) (SBSC.unpack x)
201 $ wordsBy (`elem` (", " :: [Char])) (SBSC.unpack x)
204+-- | [__RFC Compliance__]
112−-- | When a request contains an @Accept@ header, the server must either return
206+-- When a request contains an @Accept@ header, the server must either return
113-- content in one of the requested representations, or respond with @406 Not
207-- content in one of the requested representations, or respond with @406 Not
114-- Acceptable@.
208-- Acceptable@.
116-- This function checks that every *successful* response has a @Content-Type@
210-- This function checks that every *successful* response has a @Content-Type@
117−-- header that matches the @Accept@ header.
211+-- header that matches the @Accept@ header. It does *not* check that the server
212+-- matches the quality descriptions of the @Accept@ header correctly.
119-- __References__:
214-- __References__:
121-- * @Accept@ header: <https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html RFC 2616 Section 14.1>
216-- * @Accept@ header: <https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html RFC 2616 Section 14.1>
122−honoursAcceptHeader :: RequestPredicate b Bool
219+honoursAcceptHeader :: RequestPredicate
123honoursAcceptHeader
220honoursAcceptHeader
124− = RequestPredicate name (ResponsePredicate name $ \req mgr -> do
221+ = RequestPredicate $ \req mgr -> do
126 resp <- httpLbs req mgr
222 resp <- httpLbs req mgr
127 let scode = responseStatus resp
223 let scode = responseStatus resp
128− sctype = maybeToList $ lookup "Content-Type" $ responseHeaders resp
224+ sctype = lookup "Content-Type" $ responseHeaders resp
129− sacc = fromMaybe "*/*" $ lookup "Accept" $ requestHeaders req
225+ sacc = fromMaybe "*/*" $ lookup "Accept" (requestHeaders req)
130− if 100 < scode && scode < 300
226+ if status100 < scode && scode < status300
131− then isJust matchAccept sacc sctype
227+ then if isJust $ sctype >>= \x -> matchAccept [x] sacc
133− where name = "honoursAcceptHeader"
228+ then throw $ PredicateFailure "honoursAcceptHeader" (Just req) resp
136-- | [__Best Practice__]
233-- | [__Best Practice__]
138-- Whether or not a representation should be cached, it is good practice to
235-- Whether or not a representation should be cached, it is good practice to
@@ -145,33 +242,34 @@ honoursAcceptHeader
145-- __References__:
242-- __References__:
147-- * @Cache-Control@ header: <https://tools.ietf.org/html/rfc7234#section-5.2 RFC 7234 Section 5.2>
244-- * @Cache-Control@ header: <https://tools.ietf.org/html/rfc7234#section-5.2 RFC 7234 Section 5.2>
148−getsHaveCacheControlHeader :: RequestPredicate Text Bool
247+getsHaveCacheControlHeader :: RequestPredicate
149getsHaveCacheControlHeader
248getsHaveCacheControlHeader
150− = RequestPredicate
249+ = RequestPredicate $ \req mgr ->
151− { reqPredName = name
152− , reqResps = \req mgr -> if method req == methodGet
250+ if (method req == methodGet)
153− then return <$> httpLbs req mgr
252+ resp <- httpLbs req mgr
154− else return []
253+ unless (hasValidHeader "Cache-Control" (const True) resp) $ do
155− , reqPred = ResponsePredicate name $ \resp ->
156− isJust $ lookup "Cache-Control" $ responseHeaders resp
158− where name = "getsHaveCacheControlHeader"
254+ throw $ PredicateFailure "getsHaveCacheControlHeader" (Just req) resp
160-- | [__Best Practice__]
258-- | [__Best Practice__]
162-- Like 'getsHaveCacheControlHeader', but for @HEAD@ requests.
260-- Like 'getsHaveCacheControlHeader', but for @HEAD@ requests.
163−headsHaveCacheControlHeader :: RequestPredicate Text Bool
263+headsHaveCacheControlHeader :: RequestPredicate
164headsHaveCacheControlHeader
264headsHaveCacheControlHeader
165− = RequestPredicate
265+ = RequestPredicate $ \req mgr ->
166− { reqPredName = name
167− , reqResps = \req mgr -> if method req == methodHead
266+ if (method req == methodHead)
168− then return <$> httpLbs req mgr
268+ resp <- httpLbs req mgr
169− else return []
269+ unless (hasValidHeader "Cache-Control" (const True) resp) $
170− , reqPred = ResponsePredicate name $ \resp ->
171− isJust $ lookup "Cache-Control" $ responseHeaders resp
173− where name = "headsHaveCacheControlHeader"
270+ throw $ PredicateFailure "headsHaveCacheControlHeader" (Just req) resp
@@ -231,12 +329,37 @@ linkHeadersAreValid
231-- __References__:
329-- __References__:
233-- * @WWW-Authenticate@ header: <https://tools.ietf.org/html/rfc7235#section-4.1 RFC 7235 Section 4.1>
331-- * @WWW-Authenticate@ header: <https://tools.ietf.org/html/rfc7235#section-4.1 RFC 7235 Section 4.1>
234−unauthorizedContainsWWWAuthenticate :: ResponsePredicate Text Bool
334+unauthorizedContainsWWWAuthenticate :: ResponsePredicate
235unauthorizedContainsWWWAuthenticate
335unauthorizedContainsWWWAuthenticate
236− = ResponsePredicate "unauthorizedContainsWWWAuthenticate" (\resp ->
336+ = ResponsePredicate $ \resp ->
237 if responseStatus resp == status401
337 if responseStatus resp == status401
238− then hasValidHeader "WWW-Authenticate" (const True) resp
338+ then unless (hasValidHeader "WWW-Authenticate" (const True) resp) $
339+ throw $ PredicateFailure "unauthorizedContainsWWWAuthenticate" Nothing resp
343+-- | [__RFC Compliance__]
345+-- [An HTML] document will start with exactly this string: <!DOCTYPE html>
347+-- This function checks that HTML documents (those with `Content-Type: text/html...`)
348+-- include a DOCTYPE declaration at the top. We do not enforce capital case for the string `DOCTYPE`.
352+-- * HTML5 Doctype: <https://tools.ietf.org/html/rfc7992#section-6.1 RFC 7992 Section 6.1>
354+htmlIncludesDoctype :: ResponsePredicate
356+ = ResponsePredicate $ \resp ->
357+ if hasValidHeader "Content-Type" (SBS.isPrefixOf . foldCase $ "text/html") resp
359+ let htmlContent = foldCase . LBS.take 20 $ responseBody resp
360+ unless (LBS.isPrefixOf (foldCase "<!doctype html>") htmlContent) $
361+ throw $ PredicateFailure "htmlIncludesDoctype" Nothing resp
239− else True)
362+ else return ()
241-- * Predicate logic
364-- * Predicate logic
@@ -246,79 +369,77 @@ unauthorizedContainsWWWAuthenticate
247-- Still, this is all kind of ugly.
370-- Still, this is all kind of ugly.
372+-- | A predicate that depends only on the response.
249−data ResponsePredicate n r = ResponsePredicate
375+newtype ResponsePredicate = ResponsePredicate
251− , respPred :: Response LBS.ByteString -> r
376+ { getResponsePredicate :: Response LBS.ByteString -> IO ()
252− } deriving (Functor, Generic)
377+ } deriving (Generic)
254−instance Bifunctor ResponsePredicate where
379+instance Semigroup ResponsePredicate where
255− first f (ResponsePredicate a b) = ResponsePredicate (f a) b
380+ ResponsePredicate a <> ResponsePredicate b = ResponsePredicate $ \x -> a x >> b x
258−instance (Monoid n, Monoid r) => Monoid (ResponsePredicate n r) where
382+instance Monoid ResponsePredicate where
259− mempty = ResponsePredicate mempty mempty
383+ mempty = ResponsePredicate $ const $ return ()
260− a `mappend` b = ResponsePredicate
384+ mappend = (<>)
261− { respPredName = respPredName a <> respPredName b
262− , respPred = respPred a <> respPred b
386+-- | A predicate that depends on both the request and the response.
265−data RequestPredicate n r = RequestPredicate
389+newtype RequestPredicate = RequestPredicate
267− , reqResps :: Request -> Manager -> IO [Response LBS.ByteString]
390+ { getRequestPredicate :: Request -> Manager -> IO [Response LBS.ByteString]
268− , reqPred :: ResponsePredicate n r
269− } deriving (Generic, Functor)
391+ } deriving (Generic)
393+-- TODO: This isn't actually a monoid
271−instance Bifunctor RequestPredicate where
394+instance Monoid RequestPredicate where
272− first f (RequestPredicate a b c) = RequestPredicate (f a) b (first f c)
395+ mempty = RequestPredicate (\r m -> httpLbs r m >>= \x -> return ([x]))
273− second = fmap
396+ mappend = (<>)
275-- TODO: This isn't actually a monoid
398-- TODO: This isn't actually a monoid
276−instance (Monoid n, Monoid r) => Monoid (RequestPredicate n r) where
399+instance Semigroup RequestPredicate where
277− mempty = RequestPredicate mempty (\r m -> return <$> httpLbs r m) mempty
400+ RequestPredicate a <> RequestPredicate b = RequestPredicate $ \r mgr ->
278− a `mappend` b = RequestPredicate
401+ liftM2 (<>) (a r mgr) (b r mgr)
279− { reqPredName = reqPredName a <> reqPredName b
280− , reqResps = \x m -> liftM2 (<>) (reqResps a x m) (reqResps b x m)
281− , reqPred = reqPred a <> reqPred b
284−data Predicates n r = Predicates
285− { reqPreds :: RequestPredicate n r
286− , respPreds :: ResponsePredicate n r
287− } deriving (Generic, Functor)
289−instance (Monoid n, Monoid r) => Monoid (Predicates n r) where
290− mempty = Predicates mempty mempty
291− a `mappend` b = Predicates (reqPreds a <> reqPreds b) (respPreds a <> respPreds b)
403+-- | A set of predicates. Construct one with 'mempty' and '<%>'.
404+data Predicates = Predicates
405+ { requestPredicates :: RequestPredicate
406+ , responsePredicates :: ResponsePredicate
407+ } deriving (Generic)
409+instance Semigroup Predicates where
410+ a <> b = Predicates (requestPredicates a <> requestPredicates b)
411+ (responsePredicates a <> responsePredicates b)
295−class JoinPreds a where
413+instance Monoid Predicates where
296− joinPreds :: a -> Predicates [Text] [Text] -> Predicates [Text] [Text]
414+ mempty = Predicates mempty mempty
298−instance JoinPreds (RequestPredicate Text Bool) where
417+class JoinPreds a where
299− joinPreds p (Predicates x y) = Predicates (go <> x) y
418+ joinPreds :: a -> Predicates -> Predicates
300− where go = let p' = first return p
301− in fmap (\z -> if z then [] else reqPredName p') p'
303−instance JoinPreds (ResponsePredicate Text Bool) where
420+instance JoinPreds (RequestPredicate ) where
304− joinPreds p (Predicates x y) = Predicates x (go <> y)
421+ joinPreds p (Predicates x y) = Predicates (p <> x) y
305− where go = let p' = first return p
306− in fmap (\z -> if z then [] else respPredName p') p'
423+instance JoinPreds (ResponsePredicate ) where
424+ joinPreds p (Predicates x y) = Predicates x (p <> y)
309-- | Adds a new predicate (either `ResponsePredicate` or `RequestPredicate`) to
426-- | Adds a new predicate (either `ResponsePredicate` or `RequestPredicate`) to
310-- the existing predicates.
427-- the existing predicates.
312-- > not500 <%> onlyJsonObjects <%> empty
429-- > not500 <%> onlyJsonObjects <%> empty
313−(<%>) :: JoinPreds a => a -> Predicates [Text] [Text] -> Predicates [Text] [Text]
432+(<%>) :: JoinPreds a => a -> Predicates -> Predicates
314(<%>) = joinPreds
433(<%>) = joinPreds
315infixr 6 <%>
434infixr 6 <%>
317−finishPredicates :: Predicates [Text] [Text] -> Request -> Manager -> IO [Text]
436+finishPredicates :: Predicates -> Request -> Manager -> IO (Maybe PredicateFailure)
318−finishPredicates p req mgr = do
437+finishPredicates p req mgr = go `catch` \(e :: PredicateFailure) -> return $ Just e
319− resps <- reqResps (reqPreds p) req mgr
438+ where
320− let preds = reqPred (reqPreds p) <> respPreds p
439+ go = do
321− return $ mconcat [respPred preds r | r <- resps ]
440+ resps <- getRequestPredicate (requestPredicates p) req mgr
441+ mapM_ (getResponsePredicate $ responsePredicates p) resps
323-- * helpers
444-- * helpers
@@ -326,3 +447,15 @@ hasValidHeader :: SBS.ByteString -> (SBS.ByteString -> Bool) -> Response b -> Bo
326hasValidHeader hdr p r = case lookup (mk hdr) (responseHeaders r) of
447hasValidHeader hdr p r = case lookup (mk hdr) (responseHeaders r) of
327 Nothing -> False
448 Nothing -> False
328 Just v -> p v
449 Just v -> p v
451+isRFC822Date :: SBS.ByteString -> Bool
453+ = case parseTimeM True defaultTimeLocale rfc822DateFormat (SBSC.unpack s) of
455+ Just (_ :: UTCTime) -> True
457+status2XX :: Monad m => Maybe Request -> Response LBS.ByteString -> T.Text -> m ()
458+status2XX mreq resp t
459+ | status200 <= responseStatus resp && responseStatus resp < status300
461+ | otherwise = throw $ PredicateFailure t mreq resp