@@ -1,30 +1,69 @@
1module Servant.QuickCheck.Internal.Predicates where
1module Servant.QuickCheck.Internal.Predicates where
3−import Control.Monad
3+import Control.Exception (catch, throw)
4+import Control.Monad (liftM2, unless, when)
4−import Data.Aeson (Object, decode)
5+import Data.Aeson (Object, decode)
5−import Data.Bifunctor (Bifunctor (..))
6+import Data.Bifunctor (first)
6−import qualified Data.ByteString.Lazy as LBS
7+import qualified Data.ByteString as SBS
7−import qualified Data.ByteString as SBS
8import qualified Data.ByteString.Char8 as SBSC
8import qualified Data.ByteString.Char8 as SBSC
9+import qualified Data.ByteString.Lazy as LBS
9−import Data.CaseInsensitive (mk)
10+import Data.CaseInsensitive (foldCase, foldedCase, mk)
10−import Data.Either (isRight)
11+import Data.Either (isRight)
11−import Data.List.Split (wordsBy)
12+import Data.List.Split (wordsBy)
12−import Data.Monoid ((<>))
13+import Data.Maybe (fromMaybe, isJust)
13−import Data.Text (Text)
14+import Data.Semigroup (Semigroup (..))
15+import qualified Data.Text as T
16+import Data.Time (UTCTime, defaultTimeLocale, parseTimeM,
14−import GHC.Generics (Generic)
18+import GHC.Generics (Generic)
15−import Network.HTTP.Client (Manager, Request, Response, httpLbs,
19+import Network.HTTP.Client (Manager, Request, Response, httpLbs,
20+ method, parseRequest, requestHeaders,
16− responseBody, responseStatus, responseHeaders)
21+ responseBody, responseHeaders,
17−import Network.HTTP.Types (status500, status405, status401, parseMethod)
22+ responseStatus)
18−
23+import Network.HTTP.Media (matchAccept)
24+import Network.HTTP.Types (methodGet, methodHead, parseMethod,
25+ renderStdMethod, status100, status200,
26+ status201, status300, status401,
27+ status405, status500)
29+import System.Clock (Clock (Monotonic), diffTimeSpec,
32+import Servant.QuickCheck.Internal.ErrorTypes
35+-- | [__Best Practice__]
19−-- | @500 Internal Server Error@ should be avoided - it may represent some
37+-- @500 Internal Server Error@ should be avoided - it may represent some
20-- issue with the application code, and it moreover gives the client little
38-- issue with the application code, and it moreover gives the client little
21-- indication of how to proceed or what went wrong.
39-- indication of how to proceed or what went wrong.
23-- This function checks that the response code is not 500.
41-- This function checks that the response code is not 500.
24−not500 :: ResponsePredicate Text Bool
44+not500 :: ResponsePredicate
25−not500 = ResponsePredicate "not500" (\resp -> not $ responseStatus resp == status500)
45+not500 = ResponsePredicate $ \resp ->
46+ when (responseStatus resp == status500) $ throw $ PredicateFailure "not500" Nothing resp
50+-- This function checks that the response from the server does not take longer
51+-- than the specified number of nanoseconds.
54+notLongerThan :: Integer -> RequestPredicate
55+notLongerThan maxAllowed
56+ = RequestPredicate $ \req mgr -> do
57+ start <- getTime Monotonic
58+ resp <- httpLbs req mgr
59+ end <- getTime Monotonic
60+ when (toNanoSecs (end `diffTimeSpec` start) > maxAllowed) $
61+ throw $ PredicateFailure "notLongerThan" (Just req) resp
64+-- | [__Best Practice__]
27−-- | Returning anything other than an object when returning JSON is considered
66+-- Returning anything other than an object when returning JSON is considered
28-- bad practice, as:
67-- bad practice, as:
30-- (1) it is hard to modify the returned value while maintaining backwards
69-- (1) it is hard to modify the returned value while maintaining backwards
@@ -41,80 +80,197 @@ not500 = ResponsePredicate "not500" (\resp -> not $ responseStatus resp == statu
42-- * JSON Grammar: <https://tools.ietf.org/html/rfc7159#section-2 RFC 7159 Section 2>
81-- * JSON Grammar: <https://tools.ietf.org/html/rfc7159#section-2 RFC 7159 Section 2>
43-- * JSON Grammar: <https://tools.ietf.org/html/rfc4627#section-2 RFC 4627 Section 2>
82-- * JSON Grammar: <https://tools.ietf.org/html/rfc4627#section-2 RFC 4627 Section 2>
44−onlyJsonObjects :: ResponsePredicate Text Bool
85+onlyJsonObjects :: ResponsePredicate
45onlyJsonObjects
86onlyJsonObjects
87+ = ResponsePredicate (\resp -> do
88+ case lookup "content-type" (first foldedCase <$> responseHeaders resp) of
90+ Just ctype -> when ("application/json" `SBS.isPrefixOf` ctype) $ do
46− = ResponsePredicate "onlyJsonObjects" (\resp -> case decode (responseBody resp) of
91+ case (decode (responseBody resp) :: Maybe Object) of
47− Nothing -> False
92+ Nothing -> throw $ PredicateFailure "onlyJsonObjects" Nothing resp
48− Just (_ :: Object) -> True)
93+ Just _ -> return ())
50−{-
95+-- | __Optional__
51−-- | When creating a new resource, it is good practice to provide a @Location@
97+-- When creating a new resource, it is good practice to provide a @Location@
52-- header with a link to the created resource.
98-- header with a link to the created resource.
54-- This function checks that every @201 Created@ response contains a @Location@
100-- This function checks that every @201 Created@ response contains a @Location@
55-- header, and that the link in it responds with a 2XX response code to @GET@
101-- header, and that the link in it responds with a 2XX response code to @GET@
56-- requests.
102-- requests.
104+-- This is considered optional because other means of linking to the resource
105+-- (e.g. via the response body) are also acceptable; linking to the resource in
106+-- some way is considered best practice.
110+-- * 201 Created: <https://tools.ietf.org/html/rfc7231#section-6.3.2 RFC 7231 Section 6.3.2>
58−-- References: <RFC 7231, Section 6.3.2 https://tools.ietf.org/html/rfc7231#section-6.3.2>
111+-- * Location header: <https://tools.ietf.org/html/rfc7231#section-7.1.2 RFC 7231 Section 7.1.2>
59−createContainsValidLocation :: ResponsePredicate Text Bool
114+createContainsValidLocation :: RequestPredicate
60createContainsValidLocation
115createContainsValidLocation
116+ = RequestPredicate $ \req mgr -> do
61− = ResponsePredicate "createContainsValidLocation" (\resp ->
117+ let n = "createContainsValidLocation"
62−
118+ resp <- httpLbs req mgr
119+ if responseStatus resp == status201
120+ then case lookup "Location" $ responseHeaders resp of
121+ Nothing -> throw $ PredicateFailure n (Just req) resp
122+ Just l -> case parseRequest $ SBSC.unpack l of
123+ Nothing -> throw $ PredicateFailure n (Just req) resp
125+ resp2 <- httpLbs x mgr
126+ status2XX (Just req) resp2 n
127+ return [resp, resp2]
132+-- The @Last-Modified@ header represents the time a resource was last
133+-- modified. It is used to drive caching and conditional requests.
135+-- When using this mechanism, the server adds the @Last-Modified@ header to
136+-- responses. Clients may then make requests with the @If-Modified-Since@
137+-- header to conditionally request resources. If the resource has not
138+-- changed since that date, the server responds with a status code of 304
139+-- (@Not Modified@) without a response body.
141+-- The @Last-Modified@ header can also be used in conjunction with the
142+-- @If-Unmodified-Since@ header to drive optimistic concurrency.
144+-- The @Last-Modified@ date must be in RFC 822 format.
148+-- * 304 Not Modified: <https://tools.ietf.org/html/rfc7232#section-4.1 RFC 7232 Section 4.1>
149+-- * Last-Modified header: <https://tools.ietf.org/html/rfc7232#section-2.2 RFC 7232 Section 2.2>
150+-- * If-Modified-Since header: <https://tools.ietf.org/html/rfc7232#section-3.3 RFC 7232 Section 3.3>
151+-- * If-Unmodified-Since header: <https://tools.ietf.org/html/rfc7232#section-3.4 RFC 7232 Section 3.4>
152+-- * Date format: <https://tools.ietf.org/html/rfc2616#section-3.3 RFC 2616 Section 3.3>
63−getsHaveLastModifiedHeader :: ResponsePredicate Text Bool
155+getsHaveLastModifiedHeader :: RequestPredicate
64getsHaveLastModifiedHeader
156getsHaveLastModifiedHeader
65− = ResponsePredicate "getsHaveLastModifiedHeader" (\resp ->
157+ = RequestPredicate $ \req mgr ->
158+ if (method req == methodGet)
160+ resp <- httpLbs req mgr
161+ unless (hasValidHeader "Last-Modified" isRFC822Date resp) $ do
162+ throw $ PredicateFailure "getsHaveLastModifiedHeader" (Just req) resp
168+-- | [__RFC Compliance__]
69−-- | When an HTTP request has a method that is not allowed, a 405 response
170+-- When an HTTP request has a method that is not allowed,
70−-- should be returned. Additionally, it is good practice to return an @Allow@
171+-- a 405 response should be returned. Additionally, it is good practice to
71-- header with the list of allowed methods.
173-- header with the list of allowed methods.
73-- This function checks that every @405 Method Not Allowed@ response contains
175-- This function checks that every @405 Method Not Allowed@ response contains
74-- an @Allow@ header with a list of standard HTTP methods.
176-- an @Allow@ header with a list of standard HTTP methods.
178+-- Note that 'servant' itself does not currently set the @Allow@ headers.
76-- __References__:
180-- __References__:
78-- * @Allow@ header: <https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html RFC 2616 Section 14.7>
182-- * @Allow@ header: <https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html RFC 2616 Section 14.7>
183+-- * Status 405: <https://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html RFC 2616 Section 10.4.6>
184+-- * Servant Allow header issue: <https://github.com/haskell-servant/servant/issues/489 Issue #489>
79−notAllowedContainsAllowHeader :: ResponsePredicate Text Bool
187+notAllowedContainsAllowHeader :: RequestPredicate
80notAllowedContainsAllowHeader
188notAllowedContainsAllowHeader
189+ = RequestPredicate $ \req mgr -> do
190+ let reqs = [ req { method = renderStdMethod m } | m <- [minBound .. maxBound]
191+ , renderStdMethod m /= method req ]
192+ resp <- mapM (flip httpLbs mgr) reqs
194+ case filter pred' (zip reqs resp) of
81− = ResponsePredicate "notAllowedContainsAllowHeader" (\resp ->
195+ (x:_) -> throw $ PredicateFailure "notAllowedContainsAllowHeader" (Just $ fst x) (snd x)
82− if responseStatus resp == status405
198+ pred' (_, resp) = responseStatus resp == status405 && not (hasValidHeader "Allow" go resp)
83− then hasValidHeader "Allow" go resp
86− go x = all (\y -> isRight $ parseMethod $ SBSC.pack y)
200+ go x = all (\y -> isRight $ parseMethod $ SBSC.pack y)
87− $ wordsBy (`elem` (", " :: [Char])) (SBSC.unpack x)
201+ $ wordsBy (`elem` (", " :: [Char])) (SBSC.unpack x)
204+-- | [__RFC Compliance__]
90−-- | When a request contains an @Accept@ header, the server must either return
206+-- When a request contains an @Accept@ header, the server must either return
91-- content in one of the requested representations, or respond with @406 Not
207-- content in one of the requested representations, or respond with @406 Not
92-- Acceptable@.
208-- Acceptable@.
94-- This function checks that every *successful* response has a @Content-Type@
210-- This function checks that every *successful* response has a @Content-Type@
95−-- header that matches the @Accept@ header.
211+-- header that matches the @Accept@ header. It does *not* check that the server
212+-- matches the quality descriptions of the @Accept@ header correctly.
216+-- * @Accept@ header: <https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html RFC 2616 Section 14.1>
96−honoursAcceptHeader :: Predicate b Bool
219+honoursAcceptHeader :: RequestPredicate
97honoursAcceptHeader
220honoursAcceptHeader
98− = RequestPredicate "honoursAcceptHeader" _
221+ = RequestPredicate $ \req mgr -> do
99−
222+ resp <- httpLbs req mgr
223+ let scode = responseStatus resp
224+ sctype = lookup "Content-Type" $ responseHeaders resp
225+ sacc = fromMaybe "*/*" $ lookup "Accept" (requestHeaders req)
226+ if status100 < scode && scode < status300
227+ then if isJust $ sctype >>= \x -> matchAccept [x] sacc
228+ then throw $ PredicateFailure "honoursAcceptHeader" (Just req) resp
233+-- | [__Best Practice__]
100−-- | Whether or not a representation should be cached, it is good practice to
235+-- Whether or not a representation should be cached, it is good practice to
101-- have a @Cache-Control@ header for @GET@ requests. If the representation
236-- have a @Cache-Control@ header for @GET@ requests. If the representation
102-- should not be cached, used @Cache-Control: no-cache@.
237-- should not be cached, used @Cache-Control: no-cache@.
104−-- This function checks that @GET@ responses have a valid @Cache-Control@
239+-- This function checks that @GET@ responses have @Cache-Control@ header.
105−-- header.
240+-- It does NOT currently check that the header is valid.
107−-- References: RFC 7234 Section 5.2
242+-- __References__:
108−-- https://tools.ietf.org/html/rfc7234#section-5.2
244+-- * @Cache-Control@ header: <https://tools.ietf.org/html/rfc7234#section-5.2 RFC 7234 Section 5.2>
109−getsHaveCacheControlHeader :: Predicate b Bool
247+getsHaveCacheControlHeader :: RequestPredicate
110getsHaveCacheControlHeader
248getsHaveCacheControlHeader
249+ = RequestPredicate $ \req mgr ->
250+ if (method req == methodGet)
252+ resp <- httpLbs req mgr
253+ unless (hasValidHeader "Cache-Control" (const True) resp) $ do
111− = ResponsePredicate "getsHaveCacheControlHeader" _
254+ throw $ PredicateFailure "getsHaveCacheControlHeader" (Just req) resp
258+-- | [__Best Practice__]
113−-- | Like 'getsHaveCacheControlHeader', but for @HEAD@ requests.
260+-- Like 'getsHaveCacheControlHeader', but for @HEAD@ requests.
114−headsHaveCacheControlHeader :: Predicate b Bool
263+headsHaveCacheControlHeader :: RequestPredicate
115headsHaveCacheControlHeader
264headsHaveCacheControlHeader
265+ = RequestPredicate $ \req mgr ->
266+ if (method req == methodHead)
268+ resp <- httpLbs req mgr
269+ unless (hasValidHeader "Cache-Control" (const True) resp) $
116− = ResponsePredicate "headsHaveCacheControlHeader" _
270+ throw $ PredicateFailure "headsHaveCacheControlHeader" (Just req) resp
120-- If the original request modifies the resource, this function makes two
276-- If the original request modifies the resource, this function makes two
@@ -163,7 +319,9 @@ linkHeadersAreValid
163 = ResponsePredicate "linkHeadersAreValid" _
319 = ResponsePredicate "linkHeadersAreValid" _
322+-- | [__RFC Compliance__]
166−-- | Any @401 Unauthorized@ response must include a @WWW-Authenticate@ header.
324+-- Any @401 Unauthorized@ response must include a @WWW-Authenticate@ header.
168-- This function checks that, if a response has status code 401, it contains a
326-- This function checks that, if a response has status code 401, it contains a
169-- @WWW-Authenticate@ header.
327-- @WWW-Authenticate@ header.
@@ -171,12 +329,37 @@ linkHeadersAreValid
171-- __References__:
329-- __References__:
173-- * @WWW-Authenticate@ header: <https://tools.ietf.org/html/rfc7235#section-4.1 RFC 7235 Section 4.1>
331-- * @WWW-Authenticate@ header: <https://tools.ietf.org/html/rfc7235#section-4.1 RFC 7235 Section 4.1>
174−unauthorizedContainsWWWAuthenticate :: ResponsePredicate Text Bool
334+unauthorizedContainsWWWAuthenticate :: ResponsePredicate
175unauthorizedContainsWWWAuthenticate
335unauthorizedContainsWWWAuthenticate
176− = ResponsePredicate "unauthorizedContainsWWWAuthenticate" (\resp ->
336+ = ResponsePredicate $ \resp ->
177 if responseStatus resp == status401
337 if responseStatus resp == status401
178− then hasValidHeader "WWW-Authenticate" (const True) resp
338+ then unless (hasValidHeader "WWW-Authenticate" (const True) resp) $
339+ throw $ PredicateFailure "unauthorizedContainsWWWAuthenticate" Nothing resp
343+-- | [__RFC Compliance__]
345+-- [An HTML] document will start with exactly this string: <!DOCTYPE html>
347+-- This function checks that HTML documents (those with `Content-Type: text/html...`)
348+-- include a DOCTYPE declaration at the top. We do not enforce capital case for the string `DOCTYPE`.
352+-- * HTML5 Doctype: <https://tools.ietf.org/html/rfc7992#section-6.1 RFC 7992 Section 6.1>
354+htmlIncludesDoctype :: ResponsePredicate
356+ = ResponsePredicate $ \resp ->
357+ if hasValidHeader "Content-Type" (SBS.isPrefixOf . foldCase $ "text/html") resp
359+ let htmlContent = foldCase . LBS.take 20 $ responseBody resp
360+ unless (LBS.isPrefixOf (foldCase "<!doctype html>") htmlContent) $
361+ throw $ PredicateFailure "htmlIncludesDoctype" Nothing resp
179− else True)
362+ else return ()
181-- * Predicate logic
364-- * Predicate logic
@@ -186,79 +369,77 @@ unauthorizedContainsWWWAuthenticate
187-- Still, this is all kind of ugly.
370-- Still, this is all kind of ugly.
372+-- | A predicate that depends only on the response.
189−data ResponsePredicate n r = ResponsePredicate
375+newtype ResponsePredicate = ResponsePredicate
191− , respPred :: Response LBS.ByteString -> r
376+ { getResponsePredicate :: Response LBS.ByteString -> IO ()
192− } deriving (Functor, Generic)
377+ } deriving (Generic)
194−instance Bifunctor ResponsePredicate where
379+instance Semigroup ResponsePredicate where
195− first f (ResponsePredicate a b) = ResponsePredicate (f a) b
380+ ResponsePredicate a <> ResponsePredicate b = ResponsePredicate $ \x -> a x >> b x
198−instance (Monoid n, Monoid r) => Monoid (ResponsePredicate n r) where
382+instance Monoid ResponsePredicate where
199− mempty = ResponsePredicate mempty mempty
383+ mempty = ResponsePredicate $ const $ return ()
200− a `mappend` b = ResponsePredicate
384+ mappend = (<>)
201− { respPredName = respPredName a <> respPredName b
202− , respPred = respPred a <> respPred b
386+-- | A predicate that depends on both the request and the response.
205−data RequestPredicate n r = RequestPredicate
389+newtype RequestPredicate = RequestPredicate
207− , reqResps :: Request -> Manager -> IO [Response LBS.ByteString]
390+ { getRequestPredicate :: Request -> Manager -> IO [Response LBS.ByteString]
208− , reqPred :: ResponsePredicate n r
209− } deriving (Generic, Functor)
391+ } deriving (Generic)
393+-- TODO: This isn't actually a monoid
211−instance Bifunctor RequestPredicate where
394+instance Monoid RequestPredicate where
212− first f (RequestPredicate a b c) = RequestPredicate (f a) b (first f c)
395+ mempty = RequestPredicate (\r m -> httpLbs r m >>= \x -> return ([x]))
213− second = fmap
396+ mappend = (<>)
215-- TODO: This isn't actually a monoid
398-- TODO: This isn't actually a monoid
216−instance (Monoid n, Monoid r) => Monoid (RequestPredicate n r) where
399+instance Semigroup RequestPredicate where
217− mempty = RequestPredicate mempty (\r m -> return <$> httpLbs r m) mempty
400+ RequestPredicate a <> RequestPredicate b = RequestPredicate $ \r mgr ->
218− a `mappend` b = RequestPredicate
401+ liftM2 (<>) (a r mgr) (b r mgr)
219− { reqPredName = reqPredName a <> reqPredName b
220− , reqResps = \x m -> liftM2 (<>) (reqResps a x m) (reqResps b x m)
221− , reqPred = reqPred a <> reqPred b
224−data Predicates n r = Predicates
225− { reqPreds :: RequestPredicate n r
226− , respPreds :: ResponsePredicate n r
227− } deriving (Generic, Functor)
229−instance (Monoid n, Monoid r) => Monoid (Predicates n r) where
230− mempty = Predicates mempty mempty
231− a `mappend` b = Predicates (reqPreds a <> reqPreds b) (respPreds a <> respPreds b)
403+-- | A set of predicates. Construct one with 'mempty' and '<%>'.
404+data Predicates = Predicates
405+ { requestPredicates :: RequestPredicate
406+ , responsePredicates :: ResponsePredicate
407+ } deriving (Generic)
409+instance Semigroup Predicates where
410+ a <> b = Predicates (requestPredicates a <> requestPredicates b)
411+ (responsePredicates a <> responsePredicates b)
235−class JoinPreds a where
413+instance Monoid Predicates where
236− joinPreds :: a -> Predicates [Text] [Text] -> Predicates [Text] [Text]
414+ mempty = Predicates mempty mempty
238−instance JoinPreds (RequestPredicate Text Bool) where
417+class JoinPreds a where
239− joinPreds p (Predicates x y) = Predicates (go <> x) y
418+ joinPreds :: a -> Predicates -> Predicates
240− where go = let p' = first return p
241− in fmap (\z -> if z then [] else reqPredName p') p'
243−instance JoinPreds (ResponsePredicate Text Bool) where
420+instance JoinPreds (RequestPredicate ) where
244− joinPreds p (Predicates x y) = Predicates x (go <> y)
421+ joinPreds p (Predicates x y) = Predicates (p <> x) y
245− where go = let p' = first return p
246− in fmap (\z -> if z then [] else respPredName p') p'
423+instance JoinPreds (ResponsePredicate ) where
424+ joinPreds p (Predicates x y) = Predicates x (p <> y)
249-- | Adds a new predicate (either `ResponsePredicate` or `RequestPredicate`) to
426-- | Adds a new predicate (either `ResponsePredicate` or `RequestPredicate`) to
250-- the existing predicates.
427-- the existing predicates.
252-- > not500 <%> onlyJsonObjects <%> empty
429-- > not500 <%> onlyJsonObjects <%> empty
253−(<%>) :: JoinPreds a => a -> Predicates [Text] [Text] -> Predicates [Text] [Text]
432+(<%>) :: JoinPreds a => a -> Predicates -> Predicates
254(<%>) = joinPreds
433(<%>) = joinPreds
255infixr 6 <%>
434infixr 6 <%>
257−finishPredicates :: Predicates [Text] [Text] -> Request -> Manager -> IO [Text]
436+finishPredicates :: Predicates -> Request -> Manager -> IO (Maybe PredicateFailure)
258−finishPredicates p req mgr = do
437+finishPredicates p req mgr = go `catch` \(e :: PredicateFailure) -> return $ Just e
259− resps <- reqResps (reqPreds p) req mgr
438+ where
260− let preds = reqPred (reqPreds p) <> respPreds p
439+ go = do
261− return $ mconcat [respPred preds r | r <- resps ]
440+ resps <- getRequestPredicate (requestPredicates p) req mgr
441+ mapM_ (getResponsePredicate $ responsePredicates p) resps
263-- * helpers
444-- * helpers
@@ -266,3 +447,15 @@ hasValidHeader :: SBS.ByteString -> (SBS.ByteString -> Bool) -> Response b -> Bo
266hasValidHeader hdr p r = case lookup (mk hdr) (responseHeaders r) of
447hasValidHeader hdr p r = case lookup (mk hdr) (responseHeaders r) of
267 Nothing -> False
448 Nothing -> False
268 Just v -> p v
449 Just v -> p v
451+isRFC822Date :: SBS.ByteString -> Bool
453+ = case parseTimeM True defaultTimeLocale rfc822DateFormat (SBSC.unpack s) of
455+ Just (_ :: UTCTime) -> True
457+status2XX :: Monad m => Maybe Request -> Response LBS.ByteString -> T.Text -> m ()
458+status2XX mreq resp t
459+ | status200 <= responseStatus resp && responseStatus resp < status300
461+ | otherwise = throw $ PredicateFailure t mreq resp